Re: [PATCH] checkpatch: avoid default n

2019-07-03 Thread Joe Perches
On Wed, 2019-07-03 at 16:30 +0800, Miles Chen wrote: > This change reports a warning when "default n" is used. > > I have seen several "remove default n" patches, so I think > it might be helpful to add this test in checkpatch. > > tested: > WARNING: 'default n' is the default value, no need to

Re: [PATCH V2 1/2] serial/8250: Add support for NI-Serial PXI/PXIe+485 devices

2019-07-03 Thread Greg KH
On Wed, Jul 03, 2019 at 12:24:35AM -0700, jeyentam wrote: > Add support for NI-Serial PXIe-RS232, PXI-RS485 and PXIe-RS485 devices. > > Signed-off-by: jeyentam I need a "full" name here please. Also, this patch breaks the build, which is not allowed, and makes me wonder how you tested it :(

Re: [PATCH net-next v6 04/15] ethtool: introduce ethtool netlink interface

2019-07-03 Thread Jiri Pirko
Tue, Jul 02, 2019 at 04:52:41PM CEST, mkube...@suse.cz wrote: >On Tue, Jul 02, 2019 at 02:25:21PM +0200, Jiri Pirko wrote: >> Tue, Jul 02, 2019 at 01:49:59PM CEST, mkube...@suse.cz wrote: >> >+Request header >> >+-- >> >+ >> >+Each request or reply message contains a nested attribute

Re: linux-next: manual merge of the char-misc tree with the driver-core tree

2019-07-03 Thread Suzuki K Poulose
Greg, Stephen, All, On 02/07/2019 22:41, Stephen Rothwell wrote: Hi all, On Tue, 2 Jul 2019 13:05:59 -0400 "Michael S. Tsirkin" wrote: On Tue, Jul 02, 2019 at 05:58:51PM +0200, Joerg Roedel wrote: On Tue, Jul 02, 2019 at 11:23:34AM -0400, Michael S. Tsirkin wrote: I can drop virtio iommu

Re: [PATCH 2/2] riscv/include/uapi: Define a custom __SIGINFO struct for RV32

2019-07-03 Thread Arnd Bergmann
On Wed, Jul 3, 2019 at 2:21 AM Alistair Francis wrote: > > The glibc implementation of siginfo_t results in an allignment of 8 bytes > for the union _sifields on RV32. The kernel has an allignment of 4 bytes > for the _sifields union. This results in information being lost when > glibc parses the

linux-next: manual merge of the akpm-current tree with the net-next tree

2019-07-03 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the akpm-current tree got a conflict in: lib/Makefile between commit: 509e56b37cc3 ("blackhole_dev: add a selftest") from the net-next tree and commit: c86f3a66de9a ("lib: introduce test_meminit module") from the akpm-current tree. I fixed it up

Re: [PATCH v2 0/8] pinctrl: aspeed: Preparation for AST2600

2019-07-03 Thread Linus Walleij
Hi Andrew, On Fri, Jun 28, 2019 at 4:39 AM Andrew Jeffery wrote: > > Hello! > > The ASPEED AST2600 is in the pipeline, and we have enough information to start > preparing to upstream support for it. This series lays some ground work; > splitting the bindings and dicing the implementation up a

Re: [PATCH v2] mm, vmscan: prevent useless kswapd loops

2019-07-03 Thread Mel Gorman
On Mon, Jul 01, 2019 at 01:18:47PM -0700, Shakeel Butt wrote: > On production we have noticed hard lockups on large machines running > large jobs due to kswaps hoarding lru lock within isolate_lru_pages when > sc->reclaim_idx is 0 which is a small zone. The lru was couple hundred > GiBs and the

Re: [PATCH V2 2/2] PCI: Add NI-Serial PXI/PXIe+485 device IDs

2019-07-03 Thread Greg KH
On Wed, Jul 03, 2019 at 12:25:16AM -0700, jeyentam wrote: > Add NI PXIe-RS232, PXI-RS485 and PXIe-RS485 device IDs. > > Signed-off-by: jeyentam > --- > include/linux/pci_ids.h | 12 > 1 file changed, 12 insertions(+) You have read the comment at the top of this file, right? If

Re: [PATCH] ASoC: sunxi: sun50i-codec-analog: Add earpiece

2019-07-03 Thread Chen-Yu Tsai
On Wed, Jul 3, 2019 at 3:17 AM Luca Weiss wrote: > > This adds the necessary registers and audio routes to play audio using > the Earpiece, that's supported on the A64. > > Signed-off-by: Luca Weiss > --- > So, first of all: This is my first audio patch and I hope I didn't make > too many

[PATCH] x86/fpu: Make no387 and nofxsr work a little better on modern CPUs

2019-07-03 Thread Sebastian Andrzej Siewior
The command line option `no387' is designed to disable the FPU entirely. The documentation says to disable the coprocessor and the Kconfig entry for MATH_EMULATION says to set it in order to use emulation. It should be restricted to 32bit only because 64bit expect SSE (which includes basic FPU and

Re: [alsa-devel] [PATCH] ALSA: usb-audio: fix Line6 Helix audio format rates

2019-07-03 Thread Takashi Iwai
On Wed, 03 Jul 2019 10:26:31 +0200, Wasko, Michal wrote: > > >> My idea is that if line6 in the future fixes their code (they are quite > >> active > >> on the helix line) the call will not fail and we get a proper device > >> without > >> quirks. > >> But If the driver fail to get the clock

[PATCH] qlcnic: remove redundant assignment to variable err

2019-07-03 Thread Colin King
From: Colin Ian King The variable err is being initialized with a value that is never read and it is being updated later with a new value. The initialization is redundant and can be removed. Addresses-Coverity: ("Unused value") Signed-off-by: Colin Ian King ---

Re: [PATCH 1/2] uapi/asm-generic: Allow defining a custom __SIGINFO struct

2019-07-03 Thread Arnd Bergmann
On Wed, Jul 3, 2019 at 2:21 AM Alistair Francis wrote: > > Allow defining a custom __SIGINFO struct. This allows architectures to > apply their own padding and allignment requirements to the struct. This > is similar to the __ARCH_SI_ATTRIBUTES #define that already exists, but > applies to the

Re: [PATCH v2] arm64: mm: Fix dead assignment of old_pte

2019-07-03 Thread Vladimir Murzin
On 7/3/19 12:41 AM, Nathan Huckleberry wrote: > When analyzed with the clang static analyzer the > following warning occurs > > line 251, column 2 > Value stored to 'old_pte' is never read > > This warning is repeated every time pgtable.h is > included by another file and produces ~3500 > extra

[PATCH] checkpatch: avoid default n

2019-07-03 Thread Miles Chen
This change reports a warning when "default n" is used. I have seen several "remove default n" patches, so I think it might be helpful to add this test in checkpatch. tested: WARNING: 'default n' is the default value, no need to write it explicitly. + default n Signed-off-by: Miles Chen

[tip:x86/urgent] x86/ldt: Initialize the context lock for init_mm

2019-07-03 Thread tip-bot for Sebastian Andrzej Siewior
Commit-ID: 32232b350d7cd93cdc65fe5a453e6a40b539e9f9 Gitweb: https://git.kernel.org/tip/32232b350d7cd93cdc65fe5a453e6a40b539e9f9 Author: Sebastian Andrzej Siewior AuthorDate: Mon, 1 Jul 2019 19:33:54 +0200 Committer: Thomas Gleixner CommitDate: Wed, 3 Jul 2019 10:25:04 +0200 x86/ldt:

[PATCH v2 bpf-next] bpf: cgroup: Fix build error without CONFIG_NET

2019-07-03 Thread YueHaibing
If CONFIG_NET is not set and CONFIG_CGROUP_BPF=y, gcc building fails: kernel/bpf/cgroup.o: In function `cg_sockopt_func_proto': cgroup.c:(.text+0x237e): undefined reference to `bpf_sk_storage_get_proto' cgroup.c:(.text+0x2394): undefined reference to `bpf_sk_storage_delete_proto'

Re: [PATCH v3] pinctrl: qcom: Add irq_enable callback for msm gpio

2019-07-03 Thread Linus Walleij
On Tue, Jun 25, 2019 at 4:14 PM Neeraj Upadhyay wrote: > From: Srinivas Ramana > > Introduce the irq_enable callback which will be same as irq_unmask > except that it will also clear the status bit before unmask. > > This will help in clearing any erroneous interrupts that would > have got

Re: [alsa-devel] [PATCH] ALSA: usb-audio: fix Line6 Helix audio format rates

2019-07-03 Thread Wasko, Michal
On 7/3/2019 9:49 AM, Takashi Iwai wrote: On Wed, 03 Jul 2019 09:41:00 +0200, nick83ola wrote: On Tue 2 Jul 2019, 16:57 Takashi Iwai, wrote: On Tue, 02 Jul 2019 17:52:01 +0200, Wasko, Michal wrote: > > On 7/2/2019 4:37 PM, Takashi Iwai wrote: > > On Tue, 02 Jul 2019

RE: [PATCH v1 9/9] smaples: add vfio-mdev-pci driver

2019-07-03 Thread Liu, Yi L
Hi Alex, Thanks for the comments. Have four inline responses below. And one of them need your further help. :-) . > From: Alex Williamson [mailto:alex.william...@redhat.com] > Sent: Friday, June 28, 2019 11:08 PM > To: Liu, Yi L > Subject: Re: [PATCH v1 9/9] smaples: add vfio-mdev-pci driver >

[PATCH V2 2/2] PCI: Add NI-Serial PXI/PXIe+485 device IDs

2019-07-03 Thread jeyentam
Add NI PXIe-RS232, PXI-RS485 and PXIe-RS485 device IDs. Signed-off-by: jeyentam --- include/linux/pci_ids.h | 12 1 file changed, 12 insertions(+) diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h index 70e86148cb1e..7fad4794789f 100644 --- a/include/linux/pci_ids.h

Re: [PATCH v1 11/11] perf cs-etm: Smatch: Fix potential NULL pointer dereference

2019-07-03 Thread Leo Yan
Hi Mathieu, On Tue, Jul 02, 2019 at 11:03:06AM -0600, Mathieu Poirier wrote: > Hi Leo, > > On Tue, Jul 02, 2019 at 06:34:20PM +0800, Leo Yan wrote: > > Based on the following report from Smatch, fix the potential > > NULL pointer dereference check. > > > > tools/perf/util/cs-etm.c:2545 > >

Re: [PATCH] selftests/ftrace: skip ftrace test if FTRACE was not enabled

2019-07-03 Thread Masami Hiramatsu
On Tue, 2 Jul 2019 23:18:08 -0400 Steven Rostedt wrote: > On Wed, 3 Jul 2019 12:09:53 +0900 > Masami Hiramatsu wrote: > > > > Would something like that work? > > > > For older kernel, I think we'd better try to mount debugfs first. > > Sure, that's pretty trivial to do. Or what I was

Re: [GIT PULL] arm64: fixes for 5.2

2019-07-03 Thread pr-tracker-bot
The pull request you sent on Mon, 1 Jul 2019 14:02:12 +0100: > git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git tags/arm64-fixes has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/4b1fe9b58e9d20f23f6b07d1c2e0dbd921da67bf Thank you! -- Deet-doot-dot, I am a

Re: [GIT PULL] SMB3 fix

2019-07-03 Thread pr-tracker-bot
The pull request you sent on Tue, 2 Jul 2019 23:54:00 -0500: > git://git.samba.org/sfrench/cifs-2.6.git tags/5.2-rc6-smb3-fix has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/6e692c3b721f30485a9124f93e27a0cb6569116c Thank you! -- Deet-doot-dot, I am a bot.

[tip:x86/apic] x86/irq: Seperate unused system vectors from spurious entry again

2019-07-03 Thread tip-bot for Thomas Gleixner
Commit-ID: f8a8fe61fec8006575699559ead88b0b833d5cad Gitweb: https://git.kernel.org/tip/f8a8fe61fec8006575699559ead88b0b833d5cad Author: Thomas Gleixner AuthorDate: Fri, 28 Jun 2019 13:11:54 +0200 Committer: Thomas Gleixner CommitDate: Wed, 3 Jul 2019 10:12:31 +0200 x86/irq: Seperate

[PATCH] regulator: max77620: remove redundant assignment to variable ret

2019-07-03 Thread Colin King
From: Colin Ian King The variable ret is being initialized with a value that is never read and it is being updated later with a new value. The initialization is redundant and can be removed. Addresses-Coverity: ("Unused value") Signed-off-by: Colin Ian King ---

Re: [GIT PULL] fixes for v5.2-rc8

2019-07-03 Thread pr-tracker-bot
The pull request you sent on Mon, 1 Jul 2019 18:15:03 +0200: > g...@gitolite.kernel.org:pub/scm/linux/kernel/git/brauner/linux > tags/for-linus-20190701 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/8d68d93255227da660c63b9162f7001e2f5d470a Thank you! --

[tip:x86/apic] x86/irq: Handle spurious interrupt after shutdown gracefully

2019-07-03 Thread tip-bot for Thomas Gleixner
Commit-ID: b7107a67f0d125459fe41f86e8079afd1a5e0b15 Gitweb: https://git.kernel.org/tip/b7107a67f0d125459fe41f86e8079afd1a5e0b15 Author: Thomas Gleixner AuthorDate: Fri, 28 Jun 2019 13:11:53 +0200 Committer: Thomas Gleixner CommitDate: Wed, 3 Jul 2019 10:12:30 +0200 x86/irq: Handle

[PATCH] percpu: Make pcpu_setup_first_chunk() void function

2019-07-03 Thread Kefeng Wang
pcpu_setup_first_chunk() will panic or BUG_ON if the are some error and doesn't return any error, hence it can be defined to return void. Signed-off-by: Kefeng Wang --- arch/ia64/mm/contig.c| 5 + arch/ia64/mm/discontig.c | 5 + include/linux/percpu.h | 2 +- mm/percpu.c

[tip:x86/apic] x86/ioapic: Implement irq_get_irqchip_state() callback

2019-07-03 Thread tip-bot for Thomas Gleixner
Commit-ID: dfe0cf8b51b07e56ded571e3de0a4a9382517231 Gitweb: https://git.kernel.org/tip/dfe0cf8b51b07e56ded571e3de0a4a9382517231 Author: Thomas Gleixner AuthorDate: Fri, 28 Jun 2019 13:11:52 +0200 Committer: Thomas Gleixner CommitDate: Wed, 3 Jul 2019 10:12:30 +0200 x86/ioapic:

Re: [PATCH] NFS: Less function calls in show_pnfs()

2019-07-03 Thread Julia Lawall
On Tue, 2 Jul 2019, Markus Elfring wrote: > From: Markus Elfring > Date: Tue, 2 Jul 2019 16:30:53 +0200 > > Reduce function calls for data output into a sequence. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring > --- > fs/nfs/super.c | 9

[tip:x86/apic] genirq: Add optional hardware synchronization for shutdown

2019-07-03 Thread tip-bot for Thomas Gleixner
Commit-ID: 62e0468650c30f0298822c580f382b16328119f6 Gitweb: https://git.kernel.org/tip/62e0468650c30f0298822c580f382b16328119f6 Author: Thomas Gleixner AuthorDate: Fri, 28 Jun 2019 13:11:51 +0200 Committer: Thomas Gleixner CommitDate: Wed, 3 Jul 2019 10:12:29 +0200 genirq: Add

[tip:x86/apic] genirq: Fix misleading synchronize_irq() documentation

2019-07-03 Thread tip-bot for Thomas Gleixner
Commit-ID: 1d21f2af8571c6a6a44e7c1911780614847b0253 Gitweb: https://git.kernel.org/tip/1d21f2af8571c6a6a44e7c1911780614847b0253 Author: Thomas Gleixner AuthorDate: Fri, 28 Jun 2019 13:11:50 +0200 Committer: Thomas Gleixner CommitDate: Wed, 3 Jul 2019 10:12:29 +0200 genirq: Fix

Re: [PATCH v1 10/11] perf intel-pt: Smatch: Fix potential NULL pointer dereference

2019-07-03 Thread Leo Yan
On Wed, Jul 03, 2019 at 08:19:19AM +0300, Adrian Hunter wrote: > On 3/07/19 4:35 AM, Leo Yan wrote: > > Hi Adrian, > > > > On Tue, Jul 02, 2019 at 02:07:40PM +0300, Adrian Hunter wrote: > >> On 2/07/19 1:34 PM, Leo Yan wrote: > >>> Based on the following report from Smatch, fix the potential >

[PATCH] ext4: remove unnecessary error check

2019-07-03 Thread Shi Siyuan
From: shisiyuan Remove unnecessary error check in ext4_file_write_iter(), because this check will be done in upcoming later function -- ext4_write_checks() -> generic_write_checks() Change-Id: I7b0ab27f693a50765c15b5eaa3f4e7c38f42e01e Signed-off-by: shisiyuan --- fs/ext4/file.c | 2 -- 1 file

[tip:x86/apic] genirq: Delay deactivation in free_irq()

2019-07-03 Thread tip-bot for Thomas Gleixner
Commit-ID: 4001d8e8762f57d418b66e4e668601791900a1dd Gitweb: https://git.kernel.org/tip/4001d8e8762f57d418b66e4e668601791900a1dd Author: Thomas Gleixner AuthorDate: Fri, 28 Jun 2019 13:11:49 +0200 Committer: Thomas Gleixner CommitDate: Wed, 3 Jul 2019 10:12:28 +0200 genirq: Delay

[PATCH v4 11/16] crypto: caam - move cpu_to_caam_dma() selection to runtime

2019-07-03 Thread Andrey Smirnov
Instead of selecting the implementation of cpu_to_caam_dma()/caam_dma_to_cpu() at build time using the preprocessor, convert the code to do that at run-time using IS_ENABLED macro. This is needed to add support for i.MX8MQ. No functional change intended. Signed-off-by: Andrey Smirnov Cc: Chris

[PATCH][next] staging: rtl8723bs: hal: remove redundant assignment to packetType

2019-07-03 Thread Colin King
From: Colin Ian King Local variable packetType is being assigned a value that is never read just before a return statement. The assignment is redundant and can be removed. Addresses-Coverity: ("Unused value") Signed-off-by: Colin Ian King --- drivers/staging/rtl8723bs/hal/hal_btcoex.c | 1 -

[PATCH v4 09/16] crypto: caam - drop 64-bit only wr/rd_reg64()

2019-07-03 Thread Andrey Smirnov
Since 32-bit of both wr_reg64 and rd_reg64 now use 64-bit IO helpers, these functions should no longer be necessary. No functional change intended. Signed-off-by: Andrey Smirnov Cc: Chris Spencer Cc: Cory Tusar Cc: Chris Healy Cc: Lucas Stach Cc: Horia Geantă Cc: Aymen Sghaier Cc: Leonard

[PATCH v4 16/16] crypto: caam - add clock entry for i.MX8MQ

2019-07-03 Thread Andrey Smirnov
Add clock entry needed to support i.MX8MQ. Signed-off-by: Andrey Smirnov Cc: Chris Spencer Cc: Cory Tusar Cc: Chris Healy Cc: Lucas Stach Cc: Horia Geantă Cc: Aymen Sghaier Cc: Leonard Crestez Cc: linux-cry...@vger.kernel.org Cc: linux-kernel@vger.kernel.org ---

[PATCH v4 08/16] crypto: caam - use ioread64*_hi_lo in rd_reg64

2019-07-03 Thread Andrey Smirnov
Following the same transformation logic as outlined in previous commit converting wr_reg64, convert rd_reg64 to use helpers from first. No functional change intended. Signed-off-by: Andrey Smirnov Cc: Chris Spencer Cc: Cory Tusar Cc: Chris Healy Cc: Lucas Stach Cc: Horia Geantă Cc: Aymen

[PATCH v4 15/16] crypto: caam - always select job ring via RSR on i.MX8MQ

2019-07-03 Thread Andrey Smirnov
Per feedback from NXP tech support the way to use register based service interface on i.MX8MQ is to follow the same set of steps outlined for the case when virtualization is enabled, regardless if it is. Current version of SRM for i.MX8MQ speaks of DECO DID_MS and DECO DID_LS registers, but

[PATCH] waitqueue: fix clang -Wuninitialized warnings

2019-07-03 Thread Arnd Bergmann
When CONFIG_LOCKDEP is set, every use of DECLARE_WAIT_QUEUE_HEAD_ONSTACK() produces an annoying warning from clang, which is particularly annoying for allmodconfig builds: fs/namei.c:1646:34: error: variable 'wq' is uninitialized when used within its own initialization [-Werror,-Wuninitialized]

[PATCH] perf tools: Do not rely on errno values for precise_ip fallback

2019-07-03 Thread Jiri Olsa
Konstantin reported problem with default perf record command, which fails on some AMD servers, because of the default maximum precise config. The current fallback mechanism counts on getting ENOTSUP errno for precise_ip fails, but that's not the case on some AMD servers. We can fix this by

Re: [PATCH] devres: allow const resource arguments

2019-07-03 Thread Linus Walleij
On Fri, Jun 28, 2019 at 5:00 PM Arnd Bergmann wrote: > devm_ioremap_resource() does not currently take 'const' arguments, > which results in a warning from the first driver trying to do it > anyway: > > drivers/gpio/gpio-amd-fch.c: In function 'amd_fch_gpio_probe': >

[PATCH V2 1/2] serial/8250: Add support for NI-Serial PXI/PXIe+485 devices

2019-07-03 Thread jeyentam
Add support for NI-Serial PXIe-RS232, PXI-RS485 and PXIe-RS485 devices. Signed-off-by: jeyentam --- drivers/tty/serial/8250/8250_pci.c | 293 - 1 file changed, 289 insertions(+), 4 deletions(-) diff --git a/drivers/tty/serial/8250/8250_pci.c

Re: [PATCH v5 0/6] add edma2 for i.mx7ulp

2019-07-03 Thread Vinod Koul
On 25-06-19, 17:43, yibin.g...@nxp.com wrote: > From: Robin Gong > > This patch set add new version of edma for i.mx7ulp, the main changes > are as belows: > 1. only one dmamux. > 2. another clock dma_clk except dmamux clk. > 3. 16 independent interrupts instead of only one interrupt for >

Re: [PATCH bpf-next] bpf: cgroup: Fix build error without CONFIG_NET

2019-07-03 Thread Yuehaibing
On 2019/7/2 23:53, Stanislav Fomichev wrote: > On 07/02, YueHaibing wrote: >> If CONFIG_NET is not set, gcc building fails: >> >> kernel/bpf/cgroup.o: In function `cg_sockopt_func_proto': >> cgroup.c:(.text+0x237e): undefined reference to `bpf_sk_storage_get_proto' >> cgroup.c:(.text+0x2394):

[PATCH] media: cobalt: remove redundant assignment to variable data

2019-07-03 Thread Colin King
From: Colin Ian King The variable data is being initialized with a value that is never read and it is being updated later with a new value. The initialization is redundant and can be removed. Addresses-Coverity: ("Unused value") Signed-off-by: Colin Ian King ---

Re: KASAN: use-after-free Read in cpia2_usb_disconnect

2019-07-03 Thread Oliver Neukum
Am Dienstag, den 02.07.2019, 18:01 -0700 schrieb syzbot: > syzbot has found a reproducer for the following crash on: > > HEAD commit:7829a896 usb-fuzzer: main usb gadget fuzzer driver > git tree: https://github.com/google/kasan.git usb-fuzzer > console output:

[PATCH] atl1c: remove redundant assignment to variable tpd_req

2019-07-03 Thread Colin King
From: Colin Ian King The variable tpd_req is being initialized with a value that is never read and it is being updated later with a new value. The initialization is redundant and can be removed. Addresses-Coverity: ("Unused value") Signed-off-by: Colin Ian King ---

Re: [PATCH] rtl8xxxu: Fix wifi low signal strength issue of RTL8723BU

2019-07-03 Thread Daniel Drake
On Tue, Jul 2, 2019 at 4:01 PM Chris Chiu wrote: > When the vendor driver invokes rtw_btcoex_HAL_Initialize, which will then > call halbtc8723b1ant_SetAntPath to configure the registers in this patch. > From the code, the registers will have different register settings per the > antenna position

Re: [alsa-devel] [PATCH] ALSA: usb-audio: fix Line6 Helix audio format rates

2019-07-03 Thread Takashi Iwai
On Wed, 03 Jul 2019 09:41:00 +0200, nick83ola wrote: > > On Tue 2 Jul 2019, 16:57 Takashi Iwai, wrote: > > On Tue, 02 Jul 2019 17:52:01 +0200, > Wasko, Michal wrote: > > > > On 7/2/2019 4:37 PM, Takashi Iwai wrote: > > > On Tue, 02 Jul 2019 02:43:14 +0200, > > > Nicola

Re: [PATCH] rtl8xxxu: Fix wifi low signal strength issue of RTL8723BU

2019-07-03 Thread Daniel Drake
On Tue, Jul 2, 2019 at 8:42 PM Jes Sorensen wrote: > We definitely don't want to bring over the vendor code, since it's a > pile of spaghetti, but we probably need to get something sorted. This > went down the drain when the bluetooth driver was added without taking > it into account - long after

Re: [RFC PATCH 0/5] Add CONFIG symbol as module attribute

2019-07-03 Thread Greg Kroah-Hartman
On Tue, Jul 02, 2019 at 08:51:06PM +, Luis Chamberlain wrote: > On Sat, Jun 29, 2019 at 10:42:57AM +0200, Greg Kroah-Hartman wrote: > > On Fri, Jun 28, 2019 at 11:40:22AM -0700, Luis Chamberlain wrote: > > > On Wed, Jun 26, 2019 at 9:51 PM Christoph Hellwig wrote: > > > > > > > > On Wed, Jun

Re: [alsa-devel] [PATCH 1/2] ASoC: codecs: ad193x: Group register initialization at probe

2019-07-03 Thread Tzung-Bi Shih
On Thu, Jun 27, 2019 at 8:05 PM Codrin Ciubotariu wrote: > +struct ad193x_reg_default { > + unsigned int reg; > + unsigned int val; > +}; You probably don't need to define this. There is a struct reg_sequence in regmap.h. > + > +/* codec register values to set after reset */ >

[PATCH] dax: Fix missed PMD wakeups

2019-07-03 Thread Dan Williams
Ever since the conversion of DAX to the Xarray a RocksDB benchmark has been encountering intermittent lockups. In the failing case a thread that is taking a PMD-fault is awaiting a wakeup while holding the 'mmap_sem' for read. As soon as the next mmap() event occurs that tries to take the

Re: [PATCH v5 net-next 6/6] net: ethernet: ti: cpsw: add XDP support

2019-07-03 Thread Ivan Khoronzhuk
On Wed, Jul 03, 2019 at 09:26:03AM +0200, Jesper Dangaard Brouer wrote: On Sun, 30 Jun 2019 20:23:48 +0300 Ivan Khoronzhuk wrote: Add XDP support based on rx page_pool allocator, one frame per page. Page pool allocator is used with assumption that only one rx_handler is running

Re: [PATCH net-next v6 11/15] ethtool: provide link mode names as a string set

2019-07-03 Thread Michal Kubecek
On Tue, Jul 02, 2019 at 07:11:24PM -0700, Jakub Kicinski wrote: > On Tue, 2 Jul 2019 19:04:19 -0700, Jakub Kicinski wrote: > > On Tue, 2 Jul 2019 13:50:34 +0200 (CEST), Michal Kubecek wrote: > > > +const char *const link_mode_names[] = { > > > + __DEFINE_LINK_MODE_NAME(10, T, Half), > > > +

Re: linux-next: Fixes tag needs some work in the staging tree

2019-07-03 Thread Greg KH
On Wed, Jul 03, 2019 at 07:52:21AM +1000, Stephen Rothwell wrote: > Hi all, > > In commit > > 597382cbd3c1 ("dt-bindings: iio: adc: stm32: add missing vdda supply") > > Fixes tag > > Fixes: 841fcea454fe ("Documentation: dt-bindings: Document STM32 ADC DT > > has these problem(s): > > -

Re: [PATCH v2 3/3] habanalabs: Add busy engines bitmask to HW idle IOCTL

2019-07-03 Thread Oded Gabbay
On Mon, Jul 1, 2019 at 4:59 PM Tomer Tayar wrote: > > The information which is currently provided as a response to the > "HL_INFO_HW_IDLE" IOCTL is merely a general boolean value. > This patch extends it and provides also a bitmask that indicates which > of the device engines are busy. > >

Re: [PATCH 3/3] add driver and MAINTAINERS for poweroff

2019-07-03 Thread Matthias Brugger
On 02/07/2019 11:40, Frank Wunderlich wrote: > From: Josef Friedl > > poweroff for BPI-R2 > Suggested-by: Frank Wunderlich > > Signed-off-by: Josef Friedl Fix the commit message. MAINTAINERS get normally send a independent patch. Split patches between RTC and PWRC. > =2D-- > MAINTAINERS

Re: [PATCH v5 net-next 6/6] net: ethernet: ti: cpsw: add XDP support

2019-07-03 Thread Jesper Dangaard Brouer
On Sun, 30 Jun 2019 20:23:48 +0300 Ivan Khoronzhuk wrote: > Add XDP support based on rx page_pool allocator, one frame per page. > Page pool allocator is used with assumption that only one rx_handler > is running simultaneously. DMA map/unmap is reused from page pool > despite there is no

Re: [PATCH 5.1 51/55] bpf, arm64: use more scalable stadd over ldxr / stxr loop in xadd

2019-07-03 Thread Greg Kroah-Hartman
On Tue, Jul 02, 2019 at 10:02:00PM -0400, Sasha Levin wrote: > On Tue, Jul 02, 2019 at 10:01:59AM +0200, Greg Kroah-Hartman wrote: > > From: Daniel Borkmann > > > > commit 34b8ab091f9ef57a2bb3c8c8359a0a03a8abf2f9 upstream. > > > > Since ARMv8.1 supplement introduced LSE atomic instructions back

Re: [PATCH] x86/fpu: Fix nofxsr regression

2019-07-03 Thread Sebastian Andrzej Siewior
On 2019-07-03 00:17:17 [+0200], Thomas Gleixner wrote: > On Tue, 2 Jul 2019, Andi Kleen wrote: > > > > - if (cmdline_find_option_bool(boot_command_line, "nofxsr")) { > > + if (!IS_ENABLED(CONFIG_64BIT) && > > + cmdline_find_option_bool(boot_command_line, "nofxsr")) { > > +

Re: [PATCH net-next v6 05/15] ethtool: helper functions for netlink interface

2019-07-03 Thread Michal Kubecek
On Tue, Jul 02, 2019 at 06:37:24PM -0700, Jakub Kicinski wrote: > On Tue, 2 Jul 2019 13:50:04 +0200 (CEST), Michal Kubecek wrote: > > Add common request/reply header definition and helpers to parse request > > header and fill reply header. Provide ethnl_update_* helpers to update > > structure

Re: [PATCH v3 0/3] make RB_DECLARE_CALLBACKS more generic

2019-07-03 Thread Peter Zijlstra
On Tue, Jul 02, 2019 at 09:01:53PM -0700, Michel Lespinasse wrote: > These changes are intended to make the RB_DECLARE_CALLBACKS macro > more generic (allowing the aubmented subtree information to be a struct > instead of a scalar). > > Changes since v2: Left the RBSTATIC and RBNAME arguments

Re: [GIT PULL] FSI changes for 5.3

2019-07-03 Thread Greg KH
On Wed, Jul 03, 2019 at 03:39:17AM +, Joel Stanley wrote: > Hello Greg, > > We've not had a MAINAINERS entry for drivers/fsi, so this fixes that. It names > Jeremy and I as maintainers, so if it works for you we will send pull requests > to you each cycle. > > I realise this one is a bit

Re: [PATCH 1/3] add doc and MAINTAINERS for poweroff

2019-07-03 Thread Matthias Brugger
On 02/07/2019 11:40, Frank Wunderlich wrote: > From: Josef Friedl > > poweroff for BPI-R2 > Suggested-by: Frank Wunderlich > > Signed-off-by: Josef Friedl > =2D-- Please provide a proper commit message. Also subject should be adjusted. Just have a look into the git log to see what prefix

Re: [PATCH 4.19 26/72] usb: dwc3: gadget: use num_trbs when skipping TRBs on ->dequeue()

2019-07-03 Thread Greg Kroah-Hartman
On Tue, Jul 02, 2019 at 10:03:12PM -0400, Sasha Levin wrote: > On Tue, Jul 02, 2019 at 10:01:27AM +0200, Greg Kroah-Hartman wrote: > > commit c3acd59014148470dc58519870fbc779785b4bf7 upstream > > > > Now that we track how many TRBs a request uses, it's easier to skip > > over them in case of a

Re: [PATCH v2 3/3] pinctrl: qcom: Add SM8150 pinctrl driver

2019-07-03 Thread Bjorn Andersson
On Tue 02 Jul 03:50 PDT 2019, Vinod Koul wrote: > From: Prasad Sodagudi > > Add initial pinctrl driver to support pin configuration with > pinctrl framework for SM8150 > > Signed-off-by: Prasad Sodagudi > Signed-off-by: Isaac J. Manjarres > [vkoul: modify to use upstream tile support >

[PATCH] soc: qcom: msm_bus: initialize cldata->handle field

2019-07-03 Thread Lu Shuaibing
The initialize cldata->handle in msm_bus_dbg_client_data() or this field could be used uninitialized in msm_bus_dbg_rec_transaction(). KUMSAN(KernelUninitializedMemorySantizer, a new error detection tool) reports this bug. [ 435.087052]

Re: [PATCH v2 2/3] dt-bindings: pinctrl: qcom: Add SM8150 pinctrl binding

2019-07-03 Thread Bjorn Andersson
On Tue 02 Jul 03:50 PDT 2019, Vinod Koul wrote: > From: Prasad Sodagudi > > Add the binding for the TLMM pinctrl block found in the SM8150 platform. > > Signed-off-by: Prasad Sodagudi > Signed-off-by: Isaac J. Manjarres > [vkoul: add missing nodes of gpio range and reserved > rewrote

Re: [PATCH v2 1/3] dt-bindings: pinctrl: qcom: Document missing gpio nodes

2019-07-03 Thread Bjorn Andersson
On Tue 02 Jul 03:50 PDT 2019, Vinod Koul wrote: > The bindings for msm8998-pinctrl was missing gpio-ranges and > gpio-reserved-ranges, so document them as well > > Signed-off-by: Vinod Koul Reviewed-by: Bjorn Andersson > --- > .../bindings/pinctrl/qcom,msm8998-pinctrl.txt | 10

[PATCH 2/2] debugfs: log errors when something goes wrong

2019-07-03 Thread Greg Kroah-Hartman
As it is not recommended that debugfs calls be checked, it was pointed out that major errors should still be logged somewhere so that developers and users have a chance to figure out what went wrong. To help with this, error logging has been added to the debugfs core so that it is not needed to

[PATCH 1/2] debugfs: provide pr_fmt() macro

2019-07-03 Thread Greg Kroah-Hartman
Use a common "debugfs: " prefix for all pr_* calls in a single place. Cc: Mark Brown Cc: Takashi Iwai Cc: "Rafael J. Wysocki" Signed-off-by: Greg Kroah-Hartman --- fs/debugfs/inode.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/fs/debugfs/inode.c

[PATCH v2 3/9] x86/mm/tlb: Open-code on_each_cpu_cond_mask() for tlb_is_not_lazy()

2019-07-03 Thread Nadav Amit
Open-code on_each_cpu_cond_mask() in native_flush_tlb_others() to optimize the code. Open-coding eliminates the need for the indirect branch that is used to call is_lazy(), and in CPUs that are vulnerable to Spectre v2, it eliminates the retpoline. In addition, it allows to use a preallocated

[PATCH v2 6/9] x86/mm/tlb: Do not make is_lazy dirty for no reason

2019-07-03 Thread Nadav Amit
Blindly writing to is_lazy for no reason, when the written value is identical to the old value, makes the cacheline dirty for no reason. Avoid making such writes to prevent cache coherency traffic for no reason. Cc: Andy Lutomirski Cc: Peter Zijlstra Suggested-by: Dave Hansen Signed-off-by:

[PATCH v2 2/9] x86/mm/tlb: Remove reason as argument for flush_tlb_func_local()

2019-07-03 Thread Nadav Amit
To use flush_tlb_func_local() as an argument to __smp_call_function_many() we need it to have a single (void *) parameter. Eliminate the second parameter and deduce the reason for the flush. Cc: Peter Zijlstra Cc: Dave Hansen Cc: Rik van Riel Cc: Thomas Gleixner Cc: Andy Lutomirski Cc: Josh

[PATCH v2 7/9] cpumask: Mark functions as pure

2019-07-03 Thread Nadav Amit
cpumask_next_and() and cpumask_any_but() are pure, and marking them as such seems to generate different and presumably better code for native_flush_tlb_multi(). Signed-off-by: Nadav Amit --- include/linux/cpumask.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

[PATCH v2 5/9] x86/mm/tlb: Privatize cpu_tlbstate

2019-07-03 Thread Nadav Amit
cpu_tlbstate is mostly private and only the variable is_lazy is shared. This causes some false-sharing when TLB flushes are performed. Break cpu_tlbstate intro cpu_tlbstate and cpu_tlbstate_shared, and mark each one accordingly. Cc: Dave Hansen Cc: Andy Lutomirski Cc: Peter Zijlstra

[PATCH v2 9/9] x86/mm/tlb: Remove unnecessary uses of the inline keyword

2019-07-03 Thread Nadav Amit
The compiler is smart enough without these hints. Cc: Andy Lutomirski Cc: Peter Zijlstra Suggested-by: Dave Hansen Signed-off-by: Nadav Amit --- arch/x86/mm/tlb.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/x86/mm/tlb.c b/arch/x86/mm/tlb.c index

[PATCH v2 8/9] x86/mm/tlb: Remove UV special case

2019-07-03 Thread Nadav Amit
SGI UV support is outdated and not maintained, and it is not clear how it performs relatively to non-UV. Remove the code to simplify the code. Cc: Peter Zijlstra Cc: Dave Hansen Suggested-by: Andy Lutomirski Signed-off-by: Nadav Amit --- arch/x86/mm/tlb.c | 25 - 1

[PATCH v2 4/9] x86/mm/tlb: Flush remote and local TLBs concurrently

2019-07-03 Thread Nadav Amit
To improve TLB shootdown performance, flush the remote and local TLBs concurrently. Introduce flush_tlb_multi() that does so. Introduce paravirtual versions of flush_tlb_multi() for KVM, Xen and hyper-v (Xen and hyper-v are only compile-tested). While the updated smp infrastructure is capable of

[PATCH v2 0/9] x86: Concurrent TLB flushes

2019-07-03 Thread Nadav Amit
Currently, local and remote TLB flushes are not performed concurrently, which introduces unnecessary overhead - each INVLPG can take 100s of cycles. This patch-set allows TLB flushes to be run concurrently: first request the remote CPUs to initiate the flush, then run it locally, and finally wait

[PATCH v2 1/9] smp: Run functions concurrently in smp_call_function_many()

2019-07-03 Thread Nadav Amit
Currently, on_each_cpu() and similar functions do not exploit the potential of concurrency: the function is first executed remotely and only then it is executed locally. Functions such as TLB flush can take considerable time, so this provides an opportunity for performance optimization. To do so,

[PATCH net] r8152: move calling r8153b_rx_agg_chg_indicate()

2019-07-03 Thread Hayes Wang
r8153b_rx_agg_chg_indicate() needs to be called after enabling TX/RX and before calling rxdy_gated_en(tp, false). Otherwise, the change of the settings of RX aggregation wouldn't work. Besides, adjust rtl8152_set_coalesce() for the same reason. If rx_coalesce_usecs is changed, restart TX/RX to

Re: [PATCH RESEND 0/2] RISC-V: Handle the siginfo_t offset problem

2019-07-03 Thread Andreas Schwab
On Jul 02 2019, Alistair Francis wrote: > In the RISC-V 32-bit glibc port [1] the siginfo_t struct in the kernel > doesn't line up with the struct in glibc. In glibc world the _sifields > union is 8 byte alligned (although I can't figure out why) Try ptype/o in gdb. Andreas. -- Andreas

[tip:core/stacktrace] stacktrace: Use PF_KTHREAD to check for kernel threads

2019-07-03 Thread tip-bot for Thomas Gleixner
Commit-ID: 7e8e6816c6495a1168f9a7a50125d82c23e59300 Gitweb: https://git.kernel.org/tip/7e8e6816c6495a1168f9a7a50125d82c23e59300 Author: Thomas Gleixner AuthorDate: Tue, 2 Jul 2019 17:53:35 +0200 Committer: Thomas Gleixner CommitDate: Wed, 3 Jul 2019 09:04:06 +0200 stacktrace: Use

Re: [PATCH] mm/page_isolate: change the prototype of undo_isolate_page_range()

2019-07-03 Thread Anshuman Khandual
On 07/02/2019 07:23 PM, Pingfan Liu wrote: > undo_isolate_page_range() never fails, so no need to return value. > > Signed-off-by: Pingfan Liu > Cc: Andrew Morton > Cc: Michal Hocko > Cc: Oscar Salvador > Cc: Qian Cai > Cc: Anshuman Khandual > Cc: linux-kernel@vger.kernel.org

[PATCH v5 1/2] mtd: rawnand: Add Macronix raw NAND controller

2019-07-03 Thread Mason Yang
Add a driver for Macronix raw NAND controller. Signed-off-by: Mason Yang --- drivers/mtd/nand/raw/Kconfig | 6 + drivers/mtd/nand/raw/Makefile| 1 + drivers/mtd/nand/raw/mxic_nand.c | 557 +++ 3 files changed, 564 insertions(+) create mode 100644

[PATCH v5 0/2] Add Macronix raw NAND controller driver

2019-07-03 Thread Mason Yang
Hi, v5 patch including: 1. compatible rename to "macronix,nand-controller" 2. handle three clock in one 3. other minor patches v4 patch back to only raw NAND controller driver instead of MFD, raw NAND and SPI driver. This is based on MFD maintainer, Lee Jones comments: MFD is for registering

[PATCH v5 2/2] dt-bindings: mtd: Document Macronix raw NAND controller bindings

2019-07-03 Thread Mason Yang
Document the bindings used by the Macronix raw NAND controller. Signed-off-by: Mason Yang --- Documentation/devicetree/bindings/mtd/mxic-nand.txt | 20 1 file changed, 20 insertions(+) create mode 100644 Documentation/devicetree/bindings/mtd/mxic-nand.txt diff --git

[PATCH V2 0/2] recover the channel swap after xrun

2019-07-03 Thread shengjiu . wang
From: Shengjiu Wang recover the channel swap after xrun Shengjiu Wang (2): ASoC: fsl_esai: Wrap some operations to be functions ASoC: fsl_esai: recover the channel swap after xrun sound/soc/fsl/fsl_esai.c | 267 --- 1 file changed, 194 insertions(+), 73

[PATCH V2 2/2] ASoC: fsl_esai: recover the channel swap after xrun

2019-07-03 Thread shengjiu . wang
From: Shengjiu Wang There is chip errata ERR008000, the reference doc is (https://www.nxp.com/docs/en/errata/IMX6DQCE.pdf), The issue is "While using ESAI transmit or receive and an underrun/overrun happens, channel swap may occur. The only recovery mechanism is to reset the ESAI." This issue

[PATCH V2 1/2] ASoC: fsl_esai: Wrap some operations to be functions

2019-07-03 Thread shengjiu . wang
From: Shengjiu Wang Extract the operation to be functions, to improve the readability. In this patch, fsl_esai_init, fsl_esai_register_restore, fsl_esai_trigger_start and fsl_esai_trigger_stop are extracted. Signed-off-by: Shengjiu Wang --- sound/soc/fsl/fsl_esai.c | 191

Re: [PATCH v3 6/6] interconnect: Add OPP table support for interconnects

2019-07-03 Thread Vincent Guittot
On Wed, 3 Jul 2019 at 03:10, Saravana Kannan wrote: > > Interconnect paths can have different performance points. Now that OPP > framework supports bandwidth OPP tables, add OPP table support for > interconnects. > > Devices can use the interconnect-opp-table DT property to specify OPP > tables

Re: [PATCH v3 0/6] Introduce Bandwidth OPPs for interconnect paths

2019-07-03 Thread Viresh Kumar
On 02-07-19, 18:10, Saravana Kannan wrote: > Interconnects and interconnect paths quantify their performance levels in > terms of bandwidth and not in terms of frequency. So similar to how we have > frequency based OPP tables in DT and in the OPP framework, we need > bandwidth OPP table support in

<    5   6   7   8   9   10   11   >