Re: [PATCH v5 2/4] KVM: LAPIC: Inject timer interrupt via posted interrupt

2019-07-05 Thread Paolo Bonzini
On 21/06/19 11:40, Wanpeng Li wrote: > +bool __read_mostly pi_inject_timer = 0; > +module_param(pi_inject_timer, bool, S_IRUGO | S_IWUSR); > + > #define KVM_NR_SHARED_MSRS 16 > > struct kvm_shared_msrs_global { > @@ -7032,6 +7036,7 @@ int kvm_arch_init(void *opaque) > host_xcr0 =

Re: [PATCH] time: compat settimeofday: Validate the values of tv from user

2019-07-05 Thread zhengbin (A)
On 2019/7/5 20:14, Thomas Gleixner wrote: > Zhengbin, > > On Fri, 5 Jul 2019, zhengbin wrote: > >> Similar to commit 6ada1fc0e1c4 >> ("time: settimeofday: Validate the values of tv from user"), >> an unvalidated user input is multiplied by a constant, which can result >> in an undefined behaviour

Re: hmm_range_fault related fixes and legacy API removal v2

2019-07-05 Thread Jason Gunthorpe
On Wed, Jul 03, 2019 at 03:02:08PM -0700, Christoph Hellwig wrote: > Hi Jérôme, Ben and Jason, > > below is a series against the hmm tree which fixes up the mmap_sem > locking in nouveau and while at it also removes leftover legacy HMM APIs > only used by nouveau. As much as I like this series,

[PATCH] gpio: tegra: Fix build error without CONFIG_DEBUG_FS

2019-07-05 Thread YueHaibing
If CONFIG_DEBUG_FS is not set, building fails: drivers/gpio/gpio-tegra.c: In function tegra_gpio_probe: drivers/gpio/gpio-tegra.c:665:2: error: implicit declaration of function debugfs_create_file; did you mean bus_create_file? [-Werror=implicit-function-declaration]

Re: [PATCH v3 0/4] Devmap cleanups + arm64 support

2019-07-05 Thread Jason Gunthorpe
On Thu, Jul 04, 2019 at 04:37:51PM -0700, Dan Williams wrote: > > If we give up on CH's series the hmm.git will not have conflicts, > > however we just kick the can to the next merge window where we will be > > back to having to co-ordinate amd/nouveau/rdma git trees and -mm's > > patch workflow

Re: [PATCH] dmaengine: imx-sdma: fix use-after-free on probe error path

2019-07-05 Thread Sven Van Asbroeck
Hi Vinod, On Fri, Jul 5, 2019 at 3:32 AM Vinod Koul wrote: > > > + if (ret) > > + dev_warn(>dev, "failed to get firmware name\n"); > > if should have braces! > Applied after fixing braces! checkpatch.pl output after adding braces: WARNING: braces {} are not

Re: [PATCH] rcuperf: Make rcuperf kernel test more robust for !expedited mode

2019-07-05 Thread Joel Fernandes
On Fri, Jul 05, 2019 at 12:52:31PM +0900, Byungchul Park wrote: > On Thu, Jul 04, 2019 at 10:40:44AM -0700, Paul E. McKenney wrote: > > On Thu, Jul 04, 2019 at 12:34:30AM -0400, Joel Fernandes (Google) wrote: > > > It is possible that the rcuperf kernel test runs concurrently with init > > >

Re: [PATCH v2] sched/fair: fix imbalance due to CPU affinity

2019-07-05 Thread Vincent Guittot
On Tue, 2 Jul 2019 at 16:29, Valentin Schneider wrote: > > > > On 02/07/2019 11:00, Vincent Guittot wrote: > >> Does that want a > >> > >> Cc: sta...@vger.kernel.org > >> Fixes: afdeee0510db ("sched: Fix imbalance flag reset") > > > > I was not sure that this has been introduced by this patch or

Re: [PATCH v2 2/2] nvmet-loop: Flush nvme_delete_wq when removing the port

2019-07-05 Thread Max Gurtovoy
On 7/4/2019 2:03 AM, Logan Gunthorpe wrote: After calling nvme_loop_delete_ctrl(), the controllers will not yet be deleted because nvme_delete_ctrl() only schedules work to do the delete. This means a race can occur if a port is removed but there are still active controllers trying to access

Re: [PATCH v2 1/2] nvmet: Fix use-after-free bug when a port is removed

2019-07-05 Thread Max Gurtovoy
On 7/5/2019 12:01 AM, Logan Gunthorpe wrote: On 2019-07-04 3:00 p.m., Max Gurtovoy wrote: Hi Logan, On 7/4/2019 2:03 AM, Logan Gunthorpe wrote: When a port is removed through configfs, any connected controllers are still active and can still send commands. This causes a use-after-free bug

Re: general protection fault in do_move_mount (2)

2019-07-05 Thread Dmitry Vyukov
On Mon, Jul 1, 2019 at 5:18 PM Eric Biggers wrote: > > On Mon, Jul 01, 2019 at 04:59:04PM +0200, 'Dmitry Vyukov' via syzkaller-bugs > wrote: > > > > > > Dmitry, any idea why syzbot found such a bizarre reproducer for this? > > > This is actually reproducible by a simple single threaded program:

Re: kernel BUG at net/rxrpc/local_object.c:LINE!

2019-07-05 Thread Dmitry Vyukov
On Fri, Jul 5, 2019 at 2:12 PM Dmitry Vyukov wrote: > > syzbot wrote: > > > > I *think* the reproducer boils down to the attached, but I can't get > > syzkaller > > to work and the attached sample does not cause the oops to occur. Can you > > try > > it in your environment? > > > > > The bug

Re: [PATCH] time: compat settimeofday: Validate the values of tv from user

2019-07-05 Thread Thomas Gleixner
Zhengbin, On Fri, 5 Jul 2019, zhengbin wrote: > Similar to commit 6ada1fc0e1c4 > ("time: settimeofday: Validate the values of tv from user"), > an unvalidated user input is multiplied by a constant, which can result > in an undefined behaviour for large values. While this is validated > later,

[PATCH] KVM: LAPIC: ARBPRI is a reserved register for x2APIC

2019-07-05 Thread Paolo Bonzini
kvm-unit-tests were adjusted to match bare metal behavior, but KVM itself was not doing what bare metal does; fix that. Signed-off-by: Paolo Bonzini --- arch/x86/kvm/lapic.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/arch/x86/kvm/lapic.c b/arch/x86/kvm/lapic.c

Re: kernel BUG at net/rxrpc/local_object.c:LINE!

2019-07-05 Thread Dmitry Vyukov
,On Tue, Jul 2, 2019 at 3:37 PM David Howells wrote: > > syzbot wrote: > > I *think* the reproducer boils down to the attached, but I can't get syzkaller > to work and the attached sample does not cause the oops to occur. Can you try > it in your environment? > > > The bug was bisected to: > >

[PATCH net-next 0/2] net: mvpp2: Add classification based on the ETHER flow

2019-07-05 Thread Maxime Chevallier
Hello everyone, This series adds support for classification of the ETHER flow in the mvpp2 driver. The first patch allows detecting when a user specifies a flow_type that isn't supported by the driver, while the second adds support for this flow_type by adding the mapping between the ETHER_FLOW

[PATCH net-next 2/2] net: mvpp2: cls: Add support for ETHER_FLOW

2019-07-05 Thread Maxime Chevallier
Users can specify classification actions based on the 'ether' flow type. In that case, this will apply to all ethernet traffic, superseeding flows such as 'udp4' or 'tcp6'. Add support for this flow type in the PPv2 classifier, by mapping the ETHER_FLOW value to the corresponding entries in the

Re: [PATCH v7 2/6] vfio/type1: Check reserve region conflict and update iova list

2019-07-05 Thread Auger Eric
Hi Shameer, On 7/4/19 2:51 PM, Shameerali Kolothum Thodi wrote: > > >> -Original Message- >> From: kvm-ow...@vger.kernel.org [mailto:kvm-ow...@vger.kernel.org] On >> Behalf Of Alex Williamson >> Sent: 03 July 2019 21:34 >> To: Shameerali Kolothum Thodi >> Cc: eric.au...@redhat.com;

[PATCH net-next 1/2] net: mvpp2: cls: Report an error for unsupported flow types

2019-07-05 Thread Maxime Chevallier
Add a missing check to detect flow types that we don't support, so that user can be informed of this. Signed-off-by: Maxime Chevallier --- drivers/net/ethernet/marvell/mvpp2/mvpp2_cls.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/net/ethernet/marvell/mvpp2/mvpp2_cls.c

Re: linux-next: manual merge of the akpm-current tree with the hmm tree

2019-07-05 Thread Jason Gunthorpe
On Thu, Jul 04, 2019 at 04:29:55PM -0700, Dan Williams wrote: > Guys, Andrew has kicked the subsection patches out of -mm because of > the merge conflicts. Can we hold off on the hmm cleanups for this > cycle? I agree with you we should prioritize your subsection patches over CH's cleanup if we

RE: [PATCH v9 2/6] usb:gadget Separated decoding functions from dwc3 driver.

2019-07-05 Thread Pawel Laszczak
> > >On Fri, Jul 05, 2019 at 11:39:57AM +, Pawel Laszczak wrote: >> >> >On Fri, Jul 05, 2019 at 11:57:14AM +0100, Pawel Laszczak wrote: >> >> Patch moves some decoding functions from driver/usb/dwc3/debug.h driver >> >> to driver/usb/gadget/debug.c file. These moved functions include: >> >>

Re: [PATCH v7 net-next 5/5] net: ethernet: ti: cpsw: add XDP support

2019-07-05 Thread Ivan Khoronzhuk
On Fri, Jul 05, 2019 at 01:13:54PM +0200, Jesper Dangaard Brouer wrote: On Fri, 5 Jul 2019 02:14:06 +0300 Ivan Khoronzhuk wrote: +static int cpsw_xdp_tx_frame(struct cpsw_priv *priv, struct xdp_frame *xdpf, +struct page *page) +{ + struct cpsw_common *cpsw =

Re: [PATCH 0/2] scsi: add support for request batching

2019-07-05 Thread Paolo Bonzini
On 05/07/19 09:13, Hannes Reinecke wrote: > On 6/27/19 10:17 AM, Paolo Bonzini wrote: >> On 27/06/19 05:37, Martin K. Petersen wrote: Ping? Are there any more objections? >>> It's a core change so we'll need some more reviews. I suggest you >>> resubmit. >> Resubmit exactly the same patches?

Re: [PATCH v9 5/6] usb:cdns3 Add Cadence USB3 DRD Driver

2019-07-05 Thread Felipe Balbi
Hi, Pawel Laszczak writes: > diff --git a/drivers/usb/cdns3/core.c b/drivers/usb/cdns3/core.c > new file mode 100644 > index ..ddc73f1c87c5 > --- /dev/null > +++ b/drivers/usb/cdns3/core.c > @@ -0,0 +1,543 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * Cadence USBSS DRD

[PATCH] ARM: dts: stm32: add audio codec support on stm32mp157a-dk1 board

2019-07-05 Thread Olivier Moysan
Add support of Cirrus cs42l51 audio codec on stm32mp157a-dk1 board. Configuration overview: - SAI2A is the CPU interface used for the codec audio playback - SAI2B is the CPU interface used for the codec audio record - SAI2A is configured as a clock provider for the audio codec - SAI2A are

Re: [PATCH] Sched: Change type of 'overrun' from int to u64

2019-07-05 Thread Peter Zijlstra
On Fri, Jul 05, 2019 at 02:26:09PM +0530, Puranjay Mohan wrote: > Callers of hrtimer_forward_now() should save the return value in u64. > function sched_rt_period_timer() stores > it in variable 'overrun' of type int > change type of overrun from int to u64 to solve the issue. Is there an actual

Re: [PATCH v2] sched: fix unlikely use of sched_info_on()

2019-07-05 Thread Peter Zijlstra
On Fri, Jul 05, 2019 at 12:35:07PM +0800, Yi Wang wrote: > sched_info_on() is called with unlikely hint, however, the test > is to be a constant(1) on which compiler will do nothing when > make defconfig, so remove the hint. > > Also, fix a lack of {}. > > Signed-off-by: Yi Wang Thanks!

Re: [PATCH v7 05/14] media: rkisp1: add Rockchip ISP1 subdev driver

2019-07-05 Thread Dafna Hirschfeld
On Wed, Jul 3, 2019 at 9:11 PM Helen Koike wrote: > > From: Jacob Chen > > Add the subdev driver for rockchip isp1. > > Signed-off-by: Jacob Chen > Signed-off-by: Shunqian Zheng > Signed-off-by: Yichong Zhong > Signed-off-by: Jacob Chen > Signed-off-by: Eddie Cai > Signed-off-by: Jeffy Chen

Re: [PATCH v9 2/6] usb:gadget Separated decoding functions from dwc3 driver.

2019-07-05 Thread Greg KH
On Fri, Jul 05, 2019 at 11:39:57AM +, Pawel Laszczak wrote: > > >On Fri, Jul 05, 2019 at 11:57:14AM +0100, Pawel Laszczak wrote: > >> Patch moves some decoding functions from driver/usb/dwc3/debug.h driver > >> to driver/usb/gadget/debug.c file. These moved functions include: > >>

[PATCH] mm/sparse: fix ALIGN() without power of 2 in sparse_buffer_alloc()

2019-07-05 Thread Lecopzer Chen
The size argumnet passed into sparse_buffer_alloc() has already aligned with PAGE_SIZE or PMD_SIZE. If the size after aligned is not power of 2 (e.g. 0x48), the PTR_ALIGN() will return wrong value. Use roundup to round sparsemap_buf up to next multiple of size. Signed-off-by: Lecopzer Chen

[PATCH] mm/sparse: fix memory leak of sparsemap_buf in aliged memory

2019-07-05 Thread Lecopzer Chen
sparse_buffer_alloc(size) get size of memory from sparsemap_buf after being aligned with the size. However, the size is at least PAGE_ALIGN(sizeof(struct page) * PAGES_PER_SECTION) and usually larger than PAGE_SIZE. Also, the Sparse_buffer_fini() only frees memory between sparsemap_buf and

Re: [PATCH] Convert get_task_struct to return the task

2019-07-05 Thread Peter Zijlstra
On Thu, Jul 04, 2019 at 03:13:23PM -0700, Matthew Wilcox wrote: > From: "Matthew Wilcox (Oracle)" > > Returning the pointer that was passed in allows us to write > slightly more idiomatic code. Convert a few users. > > Signed-off-by: Matthew Wilcox (Oracle) Sure, thanks!

Re: [PATCH] perf/x86/intel: Fix spurious NMI on fixed counter

2019-07-05 Thread Peter Zijlstra
On Fri, Jul 05, 2019 at 08:23:37AM +0800, Jin, Yao wrote: > > > On 6/25/2019 10:58 PM, Jiri Olsa wrote: > > On Tue, Jun 25, 2019 at 07:21:35AM -0700, kan.li...@linux.intel.com wrote: > > > From: Kan Liang > > > > > > If a user first sample a PEBS event on a fixed counter, then sample a > > >

[PATCH 1/2] drm/komeda: Disable slave pipeline support

2019-07-05 Thread james qian wang (Arm Technology China)
Since the property slave_planes have been removed, to avoid the resource assignment problem in user disable slave pipeline support temporarily. Signed-off-by: james qian wang (Arm Technology China) --- drivers/gpu/drm/arm/display/komeda/komeda_crtc.c | 2 +- 1 file changed, 1 insertion(+), 1

RE: [PATCH v9 2/6] usb:gadget Separated decoding functions from dwc3 driver.

2019-07-05 Thread Pawel Laszczak
>EXTERNAL MAIL > > > >Hi, > >Pawel Laszczak writes: >> diff --git a/include/linux/usb/ch9.h b/include/linux/usb/ch9.h >> index da82606be605..d388a3a5ab7e 100644 >> --- a/include/linux/usb/ch9.h >> +++ b/include/linux/usb/ch9.h >> @@ -70,4 +70,29 @@ extern enum usb_device_speed

RE: [PATCH v9 2/6] usb:gadget Separated decoding functions from dwc3 driver.

2019-07-05 Thread Pawel Laszczak
>On Fri, Jul 05, 2019 at 11:57:14AM +0100, Pawel Laszczak wrote: >> Patch moves some decoding functions from driver/usb/dwc3/debug.h driver >> to driver/usb/gadget/debug.c file. These moved functions include: >> dwc3_decode_get_status >> dwc3_decode_set_clear_feature >>

Re: [PATCH v9 2/6] usb:gadget Separated decoding functions from dwc3 driver.

2019-07-05 Thread Felipe Balbi
Hi, Pawel Laszczak writes: > diff --git a/include/linux/usb/ch9.h b/include/linux/usb/ch9.h > index da82606be605..d388a3a5ab7e 100644 > --- a/include/linux/usb/ch9.h > +++ b/include/linux/usb/ch9.h > @@ -70,4 +70,29 @@ extern enum usb_device_speed usb_get_maximum_speed(struct > device *dev);

[PATCH] power: supply: bq25890_charger: Add the BQ25895 part

2019-07-05 Thread Angus Ainslie (Purism)
The BQ25895 is almost identical to the BQ25890. Signed-off-by: Angus Ainslie (Purism) --- drivers/power/supply/bq25890_charger.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/power/supply/bq25890_charger.c b/drivers/power/supply/bq25890_charger.c

Re: iowait v.s. idle accounting is "inconsistent" - iowait is too low

2019-07-05 Thread Peter Zijlstra
On Fri, Jul 05, 2019 at 12:25:46PM +0100, Alan Jenkins wrote: > Hi, scheduler experts! > > My cpu "iowait" time appears to be reported incorrectly.  Do you know why > this could happen? Because iowait is a magic random number that has no sane meaning. Personally I'd prefer to just delete the

Re: [PATCH 0/3] Update pcengines-apuv2 platform device

2019-07-05 Thread Florian Eckert
Hello Andy >> This patchset adds the following changes to this pcengines-apuv2 >> platform device. >> > > Before doing anything to this driver, what is the plan for previously > upstreamed: > > drivers/leds/leds-apu.c I think we can remove the related APU2/APU3 code stuff from this driver.

Re: [PATCH v2 0/2] char: tpm: add new driver for tpm i2c ptp

2019-07-05 Thread Jarkko Sakkinen
On Thu, 2019-07-04 at 12:48 -0500, Oshri Alkobi wrote: > Alex, Jarkko, thank you very much for your feedbacks! Please configure your email client to use plain text. > I totally agree, there are some duplications that can be common, indeed it > will require some work in tpm_tis_core. > Since I

Re: [PATCH v9 2/6] usb:gadget Separated decoding functions from dwc3 driver.

2019-07-05 Thread Greg KH
On Fri, Jul 05, 2019 at 11:57:14AM +0100, Pawel Laszczak wrote: > Patch moves some decoding functions from driver/usb/dwc3/debug.h driver > to driver/usb/gadget/debug.c file. These moved functions include: > dwc3_decode_get_status > dwc3_decode_set_clear_feature >

Re: iowait v.s. idle accounting is "inconsistent" - iowait is too low

2019-07-05 Thread Alan Jenkins
Hi, scheduler experts! My cpu "iowait" time appears to be reported incorrectly.  Do you know why this could happen? Doug helped me - it was he who noticed different behaviour on v4.15 vs v4.16 vs v4.17+.  So I have some confirmation of this.  I don't think Doug mentioned what hardware he

Re: [PATCH 3/8] thunderbolt: Use 32-bit writes when writing ring producer/consumer

2019-07-05 Thread Mika Westerberg
On Fri, Jul 05, 2019 at 02:09:44PM +0300, Yehezkel Bernat wrote: > On Fri, Jul 5, 2019 at 12:58 PM Mika Westerberg > wrote: > > > > The register access should be using 32-bit reads/writes according to the > > datasheet. With the previous generation hardware 16-bit writes have been > > working but

Re: [PATCH V7 7/7] cpufreq: Add QoS requests for userspace constraints

2019-07-05 Thread Rafael J. Wysocki
On Fri, Jul 5, 2019 at 12:52 PM Viresh Kumar wrote: > > This implements QoS requests to manage userspace configuration of min > and max frequency. > > Reviewed-by: Matthias Kaehlcke > Reviewed-by: Ulf Hansson > Signed-off-by: Viresh Kumar > Signed-off-by: Rafael J. Wysocki > --- > V6->V7: > -

Re: [PATCH] Revert "tpm: pass an array of tpm_extend_digest structures to tpm_pcr_extend()"

2019-07-05 Thread Jarkko Sakkinen
On Thu, 2019-07-04 at 07:48 -0400, Mimi Zohar wrote: > On Thu, 2019-07-04 at 13:28 +0200, Roberto Sassu wrote: > > On 7/4/2019 12:03 PM, Jarkko Sakkinen wrote: > > > On Mon, 2019-07-01 at 15:15 +0200, Michal Suchanek wrote: > > > > This reverts commit 0b6cf6b97b7ef1fa3c7fefab0cac897a1c4a3400 to

Re: [PATCH v3 0/4] Devmap cleanups + arm64 support

2019-07-05 Thread Robin Murphy
On 04/07/2019 22:13, Andrew Morton wrote: On Thu, 4 Jul 2019 21:54:36 +0100 Robin Murphy wrote: mm-clean-up-is_device__page-definitions.patch mm-introduce-arch_has_pte_devmap.patch arm64-mm-implement-pte_devmap-support.patch arm64-mm-implement-pte_devmap-support-fix.patch This one we

Re: [PATCH v2 0/2] char: tpm: add new driver for tpm i2c ptp

2019-07-05 Thread Jarkko Sakkinen
On Thu, 2019-07-04 at 13:29 +0200, Alexander Steffen wrote: > On 04.07.2019 10:43, Jarkko Sakkinen wrote: > > Check out tpm_tis_core.c and tpm_tis_spi.c. TPM TIS driver implements > > that spec so you should only implement a new physical layer. > > I had the same thought. Unfortunately, the

Re: linux-next: build failure after merge of the nvdimm tree

2019-07-05 Thread Pankaj Gupta
> > Hi Pankaj, > > On Fri, 5 Jul 2019 04:45:43 -0400 (EDT) Pankaj Gupta > wrote: > > > > Thank you for the report. > > That's what I am here for :-) :-) > > > Can we apply below patch [1] on top to complete linux-next build for today. > > I have tested this locally. > > Its a bit of a

Re: [PATCH v7 net-next 5/5] net: ethernet: ti: cpsw: add XDP support

2019-07-05 Thread Jesper Dangaard Brouer
On Fri, 5 Jul 2019 02:14:06 +0300 Ivan Khoronzhuk wrote: > +static int cpsw_xdp_tx_frame(struct cpsw_priv *priv, struct xdp_frame *xdpf, > + struct page *page) > +{ > + struct cpsw_common *cpsw = priv->cpsw; > + struct cpsw_meta_xdp *xmeta; > + struct

Re: [PATCH 3/8] thunderbolt: Use 32-bit writes when writing ring producer/consumer

2019-07-05 Thread Yehezkel Bernat
On Fri, Jul 5, 2019 at 12:58 PM Mika Westerberg wrote: > > The register access should be using 32-bit reads/writes according to the > datasheet. With the previous generation hardware 16-bit writes have been > working but starting with ICL this is not the case anymore so fix > producer/consumer

Re: linux-next: build failure after merge of the nvdimm tree

2019-07-05 Thread Stephen Rothwell
Hi Pankaj, On Fri, 5 Jul 2019 04:45:43 -0400 (EDT) Pankaj Gupta wrote: > > Thank you for the report. That's what I am here for :-) > Can we apply below patch [1] on top to complete linux-next build for today. > I have tested this locally. Its a bit of a pain to go back and linux-next is done

Re: linux-next boot error: WARNING in corrupted

2019-07-05 Thread Dmitry Vyukov
On Fri, Jul 5, 2019 at 12:54 PM Viresh Kumar wrote: > > On 05-07-19, 16:11, Viresh Kumar wrote: > > This fixes it for me (after faking the failure). @Rafael this needs to > > be merged to the top commit: > > > > 0d4c2a013b32 cpufreq: Add QoS requests for userspace constraints > > @Rafael: I have

[PATCH][V2] ubifs: remove redundant assignment to pointer fname

2019-07-05 Thread Colin King
From: Colin Ian King The pointer fname is being assigned with a value that is never read because the function returns after the assignment. The assignment is redundant and can be removed. Addresses-Coverity: ("Unused value") Signed-off-by: Colin Ian King --- V2: fix up commit message ---

[PATCH v3 2/3] vsock/virtio: stop workers during the .remove()

2019-07-05 Thread Stefano Garzarella
Before to call vdev->config->reset(vdev) we need to be sure that no one is accessing the device, for this reason, we add new variables in the struct virtio_vsock to stop the workers during the .remove(). This patch also add few comments before vdev->config->reset(vdev) and

[PATCH v3 3/3] vsock/virtio: fix flush of works during the .remove()

2019-07-05 Thread Stefano Garzarella
This patch moves the flush of works after vdev->config->del_vqs(vdev), because we need to be sure that no workers run before to free the 'vsock' object. Since we stopped the workers using the [tx|rx|event]_run flags, we are sure no one is accessing the device while we are calling

[PATCH v3 1/3] vsock/virtio: use RCU to avoid use-after-free on the_virtio_vsock

2019-07-05 Thread Stefano Garzarella
Some callbacks used by the upper layers can run while we are in the .remove(). A potential use-after-free can happen, because we free the_virtio_vsock without knowing if the callbacks are over or not. To solve this issue we move the assignment of the_virtio_vsock at the end of .probe(), when we

[PATCH v3 0/3] vsock/virtio: several fixes in the .probe() and .remove()

2019-07-05 Thread Stefano Garzarella
During the review of "[PATCH] vsock/virtio: Initialize core virtio vsock before registering the driver", Stefan pointed out some possible issues in the .probe() and .remove() callbacks of the virtio-vsock driver. This series tries to solve these issues: - Patch 1 adds RCU critical sections to

Re: [PATCH] Revert "tpm: pass an array of tpm_extend_digest structures to tpm_pcr_extend()"

2019-07-05 Thread Jarkko Sakkinen
On Thu, 2019-07-04 at 13:28 +0200, Roberto Sassu wrote: > On 7/4/2019 12:03 PM, Jarkko Sakkinen wrote: > > On Mon, 2019-07-01 at 15:15 +0200, Michal Suchanek wrote: > > > This reverts commit 0b6cf6b97b7ef1fa3c7fefab0cac897a1c4a3400 to avoid > > > following crash: > > > > Thank you. I think this

Re: [PATCH][next] ubifs: remove redundant assignment to pointer fname

2019-07-05 Thread Richard Weinberger
- Ursprüngliche Mail - > Von: "Sergei Shtylyov" > An: "Colin Ian King" , "richard" , > "Artem Bityutskiy" , > "Adrian Hunter" , "linux-mtd" > > CC: kernel-janit...@vger.kernel.org, "linux-kernel" > > Gesendet: Freitag, 5. Juli 2019 12:51:53 > Betreff: Re: [PATCH][next] ubifs: remove

Re: [PATCH] tpm: fixes uninitialized allocated banks for IBM vtpm driver

2019-07-05 Thread Jarkko Sakkinen
On Fri, 2019-07-05 at 13:42 +0300, Jarkko Sakkinen wrote: > On Wed, 2019-07-03 at 23:32 -0400, Nayna Jain wrote: > > The nr_allocated_banks and allocated banks are initialized as part of > > tpm_chip_register. Currently, this is done as part of auto startup > > function. However, some drivers,

[PATCH v9 3/6] usb:gadget Patch simplify usb_decode_set_clear_feature function.

2019-07-05 Thread Pawel Laszczak
Patch adds usb_decode_test_mode and usb_decode_device_feature functions, which allow to make more readable and simplify the usb_decode_set_clear_feature function. Signed-off-by: Pawel Laszczak --- drivers/usb/common/debug.c | 89 ++ 1 file changed, 43

[PATCH v9 0/6] Introduced new Cadence USBSS DRD Driver.

2019-07-05 Thread Pawel Laszczak
This patch introduce new Cadence USBSS DRD driver to linux kernel. The Cadence USBSS DRD Controller is a highly configurable IP Core which can be instantiated as Dual-Role Device (DRD), Peripheral Only and Host Only (XHCI)configurations. The current driver has been validated with FPGA burned. We

[PATCH v9 6/6] usb:cdns3 Fix for stuck packets in on-chip OUT buffer.

2019-07-05 Thread Pawel Laszczak
Controller for OUT endpoints has shared on-chip buffers for all incoming packets, including ep0out. It's FIFO buffer, so packets must be handled by DMA in correct order. If the first packet in the buffer will not be handled, then the following packets directed for other endpoints and functions

Re: [PATCH 2/8] thunderbolt: Move NVM upgrade support flag to struct icm

2019-07-05 Thread Mika Westerberg
On Fri, Jul 05, 2019 at 01:52:49PM +0300, Yehezkel Bernat wrote: > > @@ -2054,6 +2059,7 @@ struct tb *icm_probe(struct tb_nhi *nhi) > > case PCI_DEVICE_ID_INTEL_TITAN_RIDGE_2C_NHI: > > case PCI_DEVICE_ID_INTEL_TITAN_RIDGE_4C_NHI: > > icm->max_boot_acl =

[PATCH v9 4/6] usb:gadget Simplify usb_decode_get_set_descriptor function.

2019-07-05 Thread Pawel Laszczak
Patch moves switch responsible for decoding descriptor type outside snprintf. It improves code readability a little. Signed-off-by: Pawel Laszczak --- drivers/usb/common/debug.c | 113 +++-- 1 file changed, 58 insertions(+), 55 deletions(-) diff --git

[PATCH v9 1/6] dt-bindings: add binding for USBSS-DRD controller.

2019-07-05 Thread Pawel Laszczak
This patch aim at documenting USB related dt-bindings for the Cadence USBSS-DRD controller. Signed-off-by: Pawel Laszczak Reviewed-by: Rob Herring --- .../devicetree/bindings/usb/cdns-usb3.txt | 45 +++ 1 file changed, 45 insertions(+) create mode 100644

[PATCH v9 2/6] usb:gadget Separated decoding functions from dwc3 driver.

2019-07-05 Thread Pawel Laszczak
Patch moves some decoding functions from driver/usb/dwc3/debug.h driver to driver/usb/gadget/debug.c file. These moved functions include: dwc3_decode_get_status dwc3_decode_set_clear_feature dwc3_decode_set_address dwc3_decode_get_set_descriptor dwc3_decode_get_configuration

Re: [RFC PATCH 6/9] dt-bindings: opp: Add qcom-opp bindings with properties needed for CPR

2019-07-05 Thread Niklas Cassel
On Tue, Apr 09, 2019 at 02:53:52PM +0530, Viresh Kumar wrote: > On 04-04-19, 07:09, Niklas Cassel wrote: > > Add qcom-opp bindings with properties needed for Core Power Reduction (CPR). > > > > CPR is included in a great variety of Qualcomm SoC, e.g. msm8916 and > > msm8996, > > and was first

Re: linux-next boot error: WARNING in corrupted

2019-07-05 Thread Viresh Kumar
On 05-07-19, 16:11, Viresh Kumar wrote: > This fixes it for me (after faking the failure). @Rafael this needs to > be merged to the top commit: > > 0d4c2a013b32 cpufreq: Add QoS requests for userspace constraints @Rafael: I have sent V7 of this patch now after merging below diff (and improving

linux-next: Signed-off-bys missing for commits in the vfs tree

2019-07-05 Thread Stephen Rothwell
Hi all, Commits 408cbe695350 ("vfs: Convert fuse to use the new mount API") 0733dcbaebbd ("vfs: Convert orangefs to use the new mount API") are missing a Signed-off-by from their author. Commits 023d066a0d0a ("vfs: Kill sget_userns()") ea8157ab2ae5 ("zsfold: Convert zsfold to use the

Re: [PATCH 2/8] thunderbolt: Move NVM upgrade support flag to struct icm

2019-07-05 Thread Yehezkel Bernat
On Fri, Jul 5, 2019 at 12:58 PM Mika Westerberg wrote: > > @@ -1913,12 +1915,7 @@ static int icm_start(struct tb *tb) > if (IS_ERR(tb->root_switch)) > return PTR_ERR(tb->root_switch); > > - /* > -* NVM upgrade has not been tested on Apple systems and they > -

[PATCH V7 7/7] cpufreq: Add QoS requests for userspace constraints

2019-07-05 Thread Viresh Kumar
This implements QoS requests to manage userspace configuration of min and max frequency. Reviewed-by: Matthias Kaehlcke Reviewed-by: Ulf Hansson Signed-off-by: Viresh Kumar Signed-off-by: Rafael J. Wysocki --- V6->V7: - We can't call dev_pm_qos_remove_request() for a request which was never

Re: [PATCH] tpm: fixes uninitialized allocated banks for IBM vtpm driver

2019-07-05 Thread Michal Suchánek
On Fri, 05 Jul 2019 13:42:18 +0300 Jarkko Sakkinen wrote: > On Wed, 2019-07-03 at 23:32 -0400, Nayna Jain wrote: > > The nr_allocated_banks and allocated banks are initialized as part of > > tpm_chip_register. Currently, this is done as part of auto startup > > function. However, some drivers,

Re: [PATCH][next] ubifs: remove redundant assignment to pointer fname

2019-07-05 Thread Sergei Shtylyov
On 07/05/2019 11:31 AM, Colin Ian King wrote: >>> From: Colin Ian King >>> >>> The pointer fname rc is being assigned with a value that is never >> >>rc? > > Oops, cut'n'paste error. Do you want me to resend to can this be fixed > when it's applied? That's the question to the

Re: [PATCH] remove the initrd resource in /proc/iomem as theinitrdhas freed the reserved memblock.

2019-07-05 Thread James Morse
Hi, (CC: +devicetree list: memreserving the initrd, which linux then frees causes a zombie memreserve in all future kexec'd kernels) On 03/07/2019 12:42, huang.jun...@zte.com.cn wrote: On 02/07/2019 11:34, Yi Wang wrote: > From: Junhua Huang > The 'commit 50d7ba36b916 ("arm64:

OK

2019-07-05 Thread Ahmed Zama
Dear Friend, An oil business man made a fixed deposit of €15 Million Euros in my bank branch where I am a director and he died with his entire family in plane crash leaving behind no next of kin. I Propose to present you as next of kin to claim the fund,if interested contact me with your full

Re: [PATCH] tpm: fixes uninitialized allocated banks for IBM vtpm driver

2019-07-05 Thread Jarkko Sakkinen
On Wed, 2019-07-03 at 23:32 -0400, Nayna Jain wrote: > The nr_allocated_banks and allocated banks are initialized as part of > tpm_chip_register. Currently, this is done as part of auto startup > function. However, some drivers, like the ibm vtpm driver, do not run > auto startup during

Re: linux-next boot error: WARNING in corrupted

2019-07-05 Thread Viresh Kumar
On 05-07-19, 11:37, Dmitry Vyukov wrote: > On Fri, Jul 5, 2019 at 11:23 AM Rafael J. Wysocki wrote: > > > > On Thursday, July 4, 2019 7:27:04 PM CEST syzbot wrote: > > > Hello, > > > > > > syzbot found the following crash on: > > > > > > HEAD commit:16c474c9 Add linux-next specific files for

[PATCH] Fix for initialize drives not capable to handle maximum bandwidth

2019-07-05 Thread Michał Wadowski
In some cases if sata drive can't work with default controller bandwidth, driver fails to initialize the device. libata-core: sata_link_hardreset - if after reset the device is offline, then driver should try again, with lower SPD. sata_down_spd_limit - function should handle corner case values,

[PATCH] wl3501_cs: remove redundant variable ret

2019-07-05 Thread Colin King
From: Colin Ian King The variable ret is being initialized with a value that is never read and it is being updated later with a new value that is returned. The variable is redundant and can be replaced with a return 0 as there are no other return points in this function. Addresses-Coverity:

Re: [PATCH] ALSA: cs4281: remove redundant assignment to variable val and remove a goto

2019-07-05 Thread Takashi Iwai
On Fri, 05 Jul 2019 12:20:10 +0200, walter harms wrote: > > > > Am 05.07.2019 11:57, schrieb Colin King: > > From: Colin Ian King > > > > The variable val is being assigned with a value that is never > > read and it is being updated later with a new value. The > > assignment is redundant and

RE: [PATCH] gpiolib: fix incorrect IRQ requesting of an active-low lineevent

2019-07-05 Thread Michael.Wu
Hi Bartosz, For example, there is a button which drives level to be low when it is pushed, and drivers level to be high when it is released. We want to catch the event when the button is pushed. In user space we configure a line event with the following code: req.handleflags =

Re: [PATCH 0/8] thunderbolt: Intel Ice Lake support

2019-07-05 Thread Mika Westerberg
On Fri, Jul 05, 2019 at 12:57:52PM +0300, Mika Westerberg wrote: > Hi all, > > With the exception of the first patch which is fix, this series enables > Thunderbolt on Intel Ice Lake. Biggest difference from the previous > controllers is that the Thunderbolt controller is now integrated as part

Re: [PATCH 3/4] backlight: add led-backlight driver

2019-07-05 Thread Jean-Jacques Hiblot
Pavel On 05/07/2019 12:08, Pavel Machek wrote: Hi! Also still relevant is whether the LED device is being correctly modelled if the act of turning on the LED doesn't, in fact, turn the LED on. Is it *really* a correct implementation of an LED device that setting it to LED_FULL using sysfs

Re: [PATCH v4 03/16] crypto: caam - move tasklet_init() call down

2019-07-05 Thread Horia Geanta
On 7/4/2019 2:45 AM, Leonard Crestez wrote: > On 7/3/2019 8:14 PM, Andrey Smirnov wrote: >> On Wed, Jul 3, 2019 at 6:51 AM Leonard Crestez >> wrote: >>> On 7/3/2019 11:14 AM, Andrey Smirnov wrote: Move tasklet_init() call further down in order to simplify error path cleanup. No

Re: [PATCH] mm/kprobes: Add generic kprobe_fault_handler() fallback definition

2019-07-05 Thread Masami Hiramatsu
Hi Anshuman, On Fri, 5 Jul 2019 11:00:29 +0530 Anshuman Khandual wrote: > Architectures like parisc enable CONFIG_KROBES without having a definition > for kprobe_fault_handler() which results in a build failure. Hmm, as far as I can see, kprobe_fault_handler() is closed inside each arch

[PATCH net-next] hinic: add fw version query

2019-07-05 Thread Xue Chaojing
This patch adds firmware version query in ethtool -i. Signed-off-by: Xue Chaojing --- .../net/ethernet/huawei/hinic/hinic_ethtool.c | 8 + .../net/ethernet/huawei/hinic/hinic_hw_dev.h | 2 ++ .../net/ethernet/huawei/hinic/hinic_port.c| 30 +++

linux-next: Tree for Jul 5

2019-07-05 Thread Stephen Rothwell
Hi all, Changes since 20190704: The kbuild tree gained a build failure for which I applied a patch. The pm tree lost its build failures. The rdma tree still had its build failures so I used the version from next-20190628. The drm tree gained a conflict against the drm-fixes tree. The usb and

Re: [PATCH v2] HID: input: fix a4tech horizontal wheel custom usage

2019-07-05 Thread Nicolas Saenz Julienne
On Fri, 2019-06-14 at 16:25 +0200, Nicolas Saenz Julienne wrote: > On Fri, 2019-06-14 at 15:36 +0200, Benjamin Tissoires wrote: > > Hi Wolfgang, > > > > On Thu, Jun 13, 2019 at 1:49 PM Wolfgang Bauer wrote: > > > On Tuesday, 11. Juni 2019, 16:42:37 Benjamin Tissoires wrote: > > > > On Tue, Jun

[PATCH 2/2] Documentation: dt: binding: rtc: add binding for ftm alarm driver

2019-07-05 Thread Biwen Li
The patch adds binding for ftm alarm driver Signed-off-by: Biwen Li --- .../devicetree/bindings/rtc/rtc-fsl-ftm-alarm.txt | 33 ++ 1 file changed, 33 insertions(+) create mode 100644 Documentation/devicetree/bindings/rtc/rtc-fsl-ftm-alarm.txt diff --git

[PATCH 1/2] rtc/fsl: add FTM alarm driver as the wakeup source

2019-07-05 Thread Biwen Li
For the paltforms including LS1012A, LS1021A, LS1028A, LS1043A, LS1046A, LS1088A, LS208xA that has the FlexTimer module, implementing alarm functions within RTC subsystem to wakeup the system when system going to sleep. Signed-off-by: Biwen Li --- drivers/rtc/Kconfig | 14 ++

[PATCH net-next] hinic: add fw version query

2019-07-05 Thread Xue Chaojing
This patch adds firmware version query in ethtool -i. Signed-off-by: Xue Chaojing --- .../net/ethernet/huawei/hinic/hinic_ethtool.c | 8 + .../net/ethernet/huawei/hinic/hinic_hw_dev.h | 2 ++ .../net/ethernet/huawei/hinic/hinic_port.c| 30 +++

Re: [PATCH] ALSA: cs4281: remove redundant assignment to variable val and remove a goto

2019-07-05 Thread walter harms
Am 05.07.2019 11:57, schrieb Colin King: > From: Colin Ian King > > The variable val is being assigned with a value that is never > read and it is being updated later with a new value. The > assignment is redundant and can be removed. Also remove a > goto statement and a label and replace

Re: [PATCH 1/2] leds: tlc591xx: simplify driver by using the managed led API

2019-07-05 Thread Pavel Machek
On Mon 2019-07-01 17:26:01, Jean-Jacques Hiblot wrote: > Use the managed API of the LED class (devm_led_classdev_register() > instead of led_classdev_register()). > This allows us to remove the code used to track-and-destroy the LED devices > > Signed-off-by: Jean-Jacques Hiblot ack. --

Re: linux-next: build failure after merge of the akpm-current tree

2019-07-05 Thread Stephen Rothwell
Hi Marco, On Fri, 5 Jul 2019 11:27:58 +0200 Marco Elver wrote: > > Apologies for the breakage -- thanks for the fix! Shall I send a v+1 > or will your patch persist? I assume Andrew will grab it and squash it into the original patch before sending it to Linus. -- Cheers, Stephen Rothwell

Re: [PATCH 2/2] powercap/rapl: Add Ice Lake NNPI support to RAPL driver

2019-07-05 Thread Rafael J. Wysocki
On Friday, June 28, 2019 10:21:41 AM CEST Bhardwaj, Rajneesh wrote: > > On 28-Jun-19 3:32 AM, Rafael J. Wysocki wrote: > > On Friday, June 14, 2019 10:05:23 AM CEST Rajneesh Bhardwaj wrote: > >> Enables support for ICL-NNPI, which is a neural network processor for deep > >> learning inference.

Re: [PATCH] ALSA: cs4281: remove redundant assignment to variable val and remove a goto

2019-07-05 Thread Takashi Iwai
On Fri, 05 Jul 2019 11:57:04 +0200, Colin King wrote: > > From: Colin Ian King > > The variable val is being assigned with a value that is never > read and it is being updated later with a new value. The > assignment is redundant and can be removed. Also remove a > goto statement and a label

[PATCH v3] serial/8250: Add support for NI-Serial PXI/PXIe+485 devices

2019-07-05 Thread jeyentam
Add support for NI-Serial PXIe-RS232, PXI-RS485 and PXIe-RS485 devices. Signed-off-by: Je Yen Tam --- drivers/tty/serial/8250/8250_pci.c | 298 - 1 file changed, 294 insertions(+), 4 deletions(-) diff --git a/drivers/tty/serial/8250/8250_pci.c

Re: [PATCH] PCI: tegra: Fix support for GPIO based PERST#

2019-07-05 Thread Manikanta Maddireddy
On 05-Jul-19 3:20 PM, Lorenzo Pieralisi wrote: > On Fri, Jul 05, 2019 at 09:48:50AM +0100, Jon Hunter wrote: >> Commit 5e5e9c23f82a ("PCI: tegra: Add support for GPIO based PERST#") >> calls the function devm_gpiod_get_from_of_node() to request a GPIO. >> Unfortunately, around the same time

<    1   2   3   4   5   6   >