Re: [PATCH 01/12 v2] Platform: add a dev_groups pointer to struct platform_driver

2019-07-19 Thread Dmitry Torokhov
On Fri, Jul 19, 2019 at 08:52:20PM +0900, Greg Kroah-Hartman wrote: > On Sat, Jul 06, 2019 at 10:39:38AM -0700, Dmitry Torokhov wrote: > > On Sat, Jul 6, 2019 at 10:19 AM Greg Kroah-Hartman > > wrote: > > > > > > On Sat, Jul 06, 2019 at 10:04:39AM -0700, Dmitry Torokhov wrote: > > > > Hi Greg, >

[Patch v2] irqchip/stm32: Remove unneeded call to kfree

2019-07-19 Thread Hariprasad Kelam
Memory allocated by devm_ alloc will be freed upon device detachment. So we may not require free memory. Signed-off-by: Hariprasad Kelam --- v2: correct the subject line drivers/irqchip/irq-stm32-exti.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/irqchip/irq-stm32-exti.c

Re: [PATCH v3 0/6] Tracing vs CR2

2019-07-19 Thread Eiichi Tsukata
On 2019/07/19 5:27, Andy Lutomirski wrote: > Hi all- > > I suspect that a bunch of the bugs you're all finding boil down to: > > - Nested debug exceptions could corrupt the outer exception's DR6. > - Nested debug exceptions in which *both* exceptions came from the > kernel were probably all

[PATCH] libata: zpodd: Fix small read overflow in zpodd_get_mech_type()

2019-07-19 Thread Kees Cook
Much like commit 18c9a99bce2a ("libata: zpodd: small read overflow in eject_tray()"), this fixes a cdb[] buffer length, this time in zpodd_get_mech_type(): We read from the cdb[] buffer in ata_exec_internal_sg(). It has to be ATAPI_CDB_LEN (16) bytes long, but this buffer is only 12 bytes. The

[Question] orphan platform data header

2019-07-19 Thread Masahiro Yamada
Hi. I see several platform-data headers that are not used in upstream. For instance, please look at this driver: drivers/leds/leds-netxbig.c If I understood it correctly, this driver supports both device tree and legacy board-file. I grepped 'netxbig_led_platform_data', but I only found the

Re: [PATCH 2/2] checkpatch: Improve SPDX license checking

2019-07-19 Thread Stephen Rothwell
Hi Joe, On Fri, 19 Jul 2019 20:09:19 -0700 Joe Perches wrote: > > On Sat, 2019-07-20 at 12:22 +1000, Stephen Rothwell wrote: > > Hi Joe, > > > > On Fri, 19 Jul 2019 15:31:33 -0700 Joe Perches wrote: > > > Use perl's m@@ match and not // comparisons to avoid > > > an error using c90's //

Re: [PATCH 2/2] checkpatch: Improve SPDX license checking

2019-07-19 Thread Joe Perches
On Sat, 2019-07-20 at 12:22 +1000, Stephen Rothwell wrote: > Hi Joe, > > On Fri, 19 Jul 2019 15:31:33 -0700 Joe Perches wrote: > > Use perl's m@@ match and not // comparisons to avoid > > an error using c90's // comment style. > > > > Miscellanea: > > > > o Use normal tab indentation and

Re: [PATCHv4 1/2] media: docs-rst: Document memory-to-memory video decoder interface

2019-07-19 Thread Nicolas Dufresne
Le vendredi 19 juillet 2019 à 14:45 +0900, Tomasz Figa a écrit : > On Wed, Jul 17, 2019 at 9:18 PM Nicolas Dufresne wrote: > > Hello, > > > > there is one little detail/proposal, see inline . > > > > Le lundi 03 juin 2019 à 13:28 +0200, Hans Verkuil a écrit : > > > From: Tomasz Figa > > > > >

RE: [PATCH] phy: Change the configuration interface param to void* to make it more general

2019-07-19 Thread Zengtao (B)
Hi maxime: >-Original Message- >From: Maxime Ripard [mailto:maxime.rip...@bootlin.com] >Sent: Thursday, July 18, 2019 12:38 AM >To: Zengtao (B) >Cc: kis...@ti.com; Chen-Yu Tsai ; Paul Kocialkowski >; Sakari Ailus ; >linux-kernel@vger.kernel.org; linux-arm-ker...@lists.infradead.org

[git pull] vfs.git - dcache and mountpoint stuff

2019-07-19 Thread Al Viro
Saner handling of refcounts to mountpoints. Transfer the counting reference from struct mount ->mnt_mountpoint over to struct mountpoint ->m_dentry. That allows to get rid of the convoluted games with ordering of mount shutdowns. The cost is in teaching shrink_dcache_{parent,for_umount}

Re: [TRIVIAL PATCH] of: per-file dtc preprocessor flags

2019-07-19 Thread Masahiro Yamada
On Sat, Jul 20, 2019 at 4:28 AM Eugeniy Paltsev wrote: > > As of today we are able to pass custom flags to dtc compiler but not > to dtc preprocessor. > This ability is required for including some board-specific header files. > It allows us to pass defined constants to dts without their

[PATCH] ARM: Fix null die() string for unhandled data and prefetch abort cases

2019-07-19 Thread George G. Davis
When an unhandled data or prefetch abort occurs, the die() string is empty resulting in backtrace messages similar to the following: Internal error: : 1 [#1] PREEMPT SMP ARM Replace the null string with the name of the abort handler in order to provide more meaningful hints as to the

[GIT PULL] More Kbuild updates for v5.3-rc1

2019-07-19 Thread Masahiro Yamada
Hi Linus, Please pull some more Kbuild updates. Thanks! The following changes since commit 9637d517347e80ee2fe1c5d8ce45ba1b88d8b5cd: Merge tag 'for-linus-20190715' of git://git.kernel.dk/linux-block (2019-07-15 21:20:52 -0700) are available in the Git repository at:

Re: [GIT PULL] final round of SCSI updates for the 5.2+ merge window

2019-07-19 Thread Ming Lei
On Sat, Jul 20, 2019 at 8:38 AM James Bottomley wrote: > > This is the final round of mostly small fixes in our initial > submit. It's mostly minor fixes and driver updates. The only change > of note is adding a virt_boundary_mask to the SCSI host and host > template to parametrise this for

[PATCH] tracing: kmem: convert call_site addresses to user friendly symbols

2019-07-19 Thread George G. Davis
While attempting to debug slub freelist pointer corruption bugs caused by a module, I discovered that the kmem call_site addresses are not at all user friendly for modules unless you manage to save a copy of kallsyms for the running kernel beforehand. So convert kmem call_site addresses to user

Re: [PATCH 2/2] checkpatch: Improve SPDX license checking

2019-07-19 Thread Stephen Rothwell
Hi Joe, On Fri, 19 Jul 2019 15:31:33 -0700 Joe Perches wrote: > > Use perl's m@@ match and not // comparisons to avoid > an error using c90's // comment style. > > Miscellanea: > > o Use normal tab indentation and alignment > > Link: >

Re: [PATCH 1/2] checkpatch: Don't interpret stack dumps as commit IDs

2019-07-19 Thread Stephen Rothwell
Hi Joe, On Fri, 19 Jul 2019 15:31:32 -0700 Joe Perches wrote: > > Add more types of lines that appear to be stack dumps that also include > hex lines that might otherwise be interpreted as commit IDs. > > Link: >

Re: [PATCH] mm/migrate: initialize pud_entry in migrate_vma()

2019-07-19 Thread John Hubbard
On 7/19/19 4:32 PM, Ralph Campbell wrote: > When CONFIG_MIGRATE_VMA_HELPER is enabled, migrate_vma() calls > migrate_vma_collect() which initializes a struct mm_walk but > didn't initialize mm_walk.pud_entry. (Found by code inspection) > Use a C structure initialization to make sure it is set to

Thank you for your understanding

2019-07-19 Thread rose marye
Hello, my name is Rose, I have a business proposal that will benefit us, it is a business worth 3.5million USD, Kindly get back to us if your interested for more details. Regards Rose

[PATCH v4] sched/core: silence a warning in sched_init()

2019-07-19 Thread Qian Cai
Compiling a kernel with both FAIR_GROUP_SCHED=n and RT_GROUP_SCHED=n will generate a compiler warning, kernel/sched/core.c: In function 'sched_init': kernel/sched/core.c:5906:32: warning: variable 'ptr' set but not used [-Wunused-but-set-variable] unsigned long alloc_size = 0, ptr;

trivial script to update MAINTAINERS directory patterns

2019-07-19 Thread Joe Perches
Almost all directory file patterns in MAINTAINERS end with a trailing /. There are some directory file patterns that do not. It'd be nice to update those without the trailing / properly. Can you please run and apply this script after rc1 ? $ git grep -h "^[FX]:" MAINTAINERS | \ cut -f2- | grep

Re: [PATCH 2/4] ceph: fix buffer free while holding i_ceph_lock in __ceph_setxattr()

2019-07-19 Thread Jeff Layton
On Sat, 2019-07-20 at 00:30 +0100, Al Viro wrote: > On Sat, Jul 20, 2019 at 12:23:08AM +0100, Al Viro wrote: > > On Fri, Jul 19, 2019 at 07:07:49PM -0400, Jeff Layton wrote: > > > > > Al pointed out on IRC that vfree should be callable under spinlock. > > > > Al had been near-terminally low on

Re: [GIT PULL 1/4] ARM: SoC platform updates

2019-07-19 Thread pr-tracker-bot
The pull request you sent on Fri, 19 Jul 2019 16:54:31 -0700: > git://git.kernel.org/pub/scm/linux/kernel/git/soc/soc.git tags/armsoc-soc has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/24e44913aa746098349370a0f279733c0cadcba7 Thank you! -- Deet-doot-dot, I am a

Re: [GIT PULL 2/4] ARM: SoC-related driver updates

2019-07-19 Thread pr-tracker-bot
The pull request you sent on Fri, 19 Jul 2019 16:54:32 -0700: > git://git.kernel.org/pub/scm/linux/kernel/git/soc/soc.git tags/armsoc-drivers has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/8362fd64f07eaef7155c94fca8dee91c4f99a666 Thank you! -- Deet-doot-dot, I am a

Re: [GIT PULL 4/4] ARM: SoC defconfig updates

2019-07-19 Thread pr-tracker-bot
The pull request you sent on Fri, 19 Jul 2019 16:54:34 -0700: > git://git.kernel.org/pub/scm/linux/kernel/git/soc/soc.git > tags/armsoc-defconfig has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/abdfd52a295fb5731ab07b5c9013e2e39f4d1cbe Thank you! -- Deet-doot-dot, I

Re: [GIT PULL 3/4] ARM: Device-tree updates

2019-07-19 Thread pr-tracker-bot
The pull request you sent on Fri, 19 Jul 2019 16:54:33 -0700: > git://git.kernel.org/pub/scm/linux/kernel/git/soc/soc.git tags/armsoc-dt has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/af6af87d7e4ff67324425daa699b9cda32e3161d Thank you! -- Deet-doot-dot, I am a bot.

Did you receive my email?

2019-07-19 Thread .....
You maybe wondering how i get into you but it's God's doing. I have a top secret business proposal, $10 Million usd, to be transfer into your bank account, if you are ready let me know so that i will detail you for us to move forward. Waiting to hear from you, Thanks, Manager Mr. Juff Firti.

Re: [GIT PULL 2/4] ARM: SoC-related driver updates

2019-07-19 Thread Olof Johansson
On Fri, Jul 19, 2019 at 4:54 PM Olof Johansson wrote: > > Various driver updates for platforms and a couple of the small driver > subsystems we merge through our tree: > > - A driver for SCU (system control) on NXP i.MX8QXP > - Qualcomm Always-on Subsystem messaging driver (AOSS QMP) > - Qualcomm

[PATCH] kselftest: save-and-restore errno to allow for %m formatting

2019-07-19 Thread Aleksa Sarai
Previously, using "%m" in a ksft_* format string can result in strange output because the errno value wasn't saved before calling other libc functions. The solution is to simply save and restore the errno before we format the user-supplied format string. Signed-off-by: Aleksa Sarai ---

[GIT PULL 4/4] ARM: SoC defconfig updates

2019-07-19 Thread Olof Johansson
We keep this in a separate branch to avoid cross-branch conflicts, but most of the material here is fairly boring -- some new drivers turned on for hardware since they were merged, and some refreshed files due to time having moved a lot of entries around. Merge conflicts:

[GIT PULL 1/4] ARM: SoC platform updates

2019-07-19 Thread Olof Johansson
SoC platform changes. Main theme this merge window: - The Netx platform (Netx 100/500) platform is removed by Linus Walleij-- the SoC doesn't have active maintainers with hardware, and in discussions with the vendor the agreement was that it's OK to remove. - Russell King has a series of patches

[GIT PULL 2/4] ARM: SoC-related driver updates

2019-07-19 Thread Olof Johansson
Various driver updates for platforms and a couple of the small driver subsystems we merge through our tree: - A driver for SCU (system control) on NXP i.MX8QXP - Qualcomm Always-on Subsystem messaging driver (AOSS QMP) - Qualcomm PM support for MSM8998 - Support for a newer version of DRAM PHY

[GIT PULL 0/4] ARM: SoC contents for 5.3 merge window

2019-07-19 Thread Olof Johansson
Squeaking in on the last few days of the merge window, here's the ARM SoC contents for this merge window. It's again another cycle of business-as-usual. We've seen a few new SoCs, a handful of better supported boards (and new boards), and the general tweaks, improvements and cleanups. Most of the

[GIT PULL 3/4] ARM: Device-tree updates

2019-07-19 Thread Olof Johansson
We continue to see a lot of new material. I've highlighted some of it below, but there's been more beyond that as well. One of the sweeping changes is that many boards have seen their ARM Mali GPU devices added to device trees, since the DRM drivers have now been merged. So, with the caveat that

Re: [PATCH 2/2] mwifiex: Make use of the new sdio_trigger_replug() API to reset

2019-07-19 Thread Brian Norris
Hi Doug, On Tue, Jul 16, 2019 at 09:42:09AM -0700, Doug Anderson wrote: > As described in the patch ("mmc: core: Add sdio_trigger_replug() > API"), the current mwifiex_sdio_card_reset() is broken in the cases > where we're running Bluetooth on a second SDIO func on the same card > as WiFi. The

[GIT PULL] final round of SCSI updates for the 5.2+ merge window

2019-07-19 Thread James Bottomley
This is the final round of mostly small fixes in our initial submit. It's mostly minor fixes and driver updates. The only change of note is adding a virt_boundary_mask to the SCSI host and host template to parametrise this for NVMe devices instead of having them do a call in slave_alloc. It's a

[PATCH] mm/migrate: initialize pud_entry in migrate_vma()

2019-07-19 Thread Ralph Campbell
When CONFIG_MIGRATE_VMA_HELPER is enabled, migrate_vma() calls migrate_vma_collect() which initializes a struct mm_walk but didn't initialize mm_walk.pud_entry. (Found by code inspection) Use a C structure initialization to make sure it is set to NULL. Fixes: 8763cb45ab967 ("mm/migrate: new

Re: [PATCH 2/4] ceph: fix buffer free while holding i_ceph_lock in __ceph_setxattr()

2019-07-19 Thread Al Viro
On Sat, Jul 20, 2019 at 12:23:08AM +0100, Al Viro wrote: > On Fri, Jul 19, 2019 at 07:07:49PM -0400, Jeff Layton wrote: > > > Al pointed out on IRC that vfree should be callable under spinlock. > > Al had been near-terminally low on caffeine at the time, posted > a retraction a few minutes later

[PATCH v2] fs: fs_parser: avoid NULL param->string to kstrtouint

2019-07-19 Thread Yin Fengwei
syzbot reported general protection fault in kstrtouint: https://lkml.org/lkml/2019/7/18/328 >From the log, if the mount option is something like: fd, The default parameter (which has NULL param->string) will be passed to vfs_parse_fs_param. Finally, this NULL param->string

Re: [PATCH] fs: fs_parser: avoid NULL param->string to kstrtouint

2019-07-19 Thread YinFengwei
On Fri, Jul 19, 2019 at 07:38:11PM +0200, Greg KH wrote: > On Fri, Jul 19, 2019 at 08:43:29PM +0800, Yin Fengwei wrote: > > syzbot reported general protection fault in kstrtouint: > > https://lkml.org/lkml/2019/7/18/328 > > > > >From the log, if the mount option is something like: > >

Re: [PATCH] fs: fs_parser: avoid NULL param->string to kstrtouint

2019-07-19 Thread YinFengwei
On Fri, Jul 19, 2019 at 03:37:37PM +0200, Dmitry Vyukov wrote: > On Fri, Jul 19, 2019 at 2:44 PM Yin Fengwei wrote: > > > > syzbot reported general protection fault in kstrtouint: > > https://lkml.org/lkml/2019/7/18/328 > > > > From the log, if the mount option is something like: > >

Re: [PATCH 2/4] ceph: fix buffer free while holding i_ceph_lock in __ceph_setxattr()

2019-07-19 Thread Al Viro
On Fri, Jul 19, 2019 at 07:07:49PM -0400, Jeff Layton wrote: > Al pointed out on IRC that vfree should be callable under spinlock. Al had been near-terminally low on caffeine at the time, posted a retraction a few minutes later and went to grab some coffee... > It > only sleeps if

Re: [PATCH 2/4] ceph: fix buffer free while holding i_ceph_lock in __ceph_setxattr()

2019-07-19 Thread Jeff Layton
On Fri, 2019-07-19 at 15:32 +0100, Luis Henriques wrote: > Calling ceph_buffer_put() in __ceph_setxattr() may end up freeing the > i_xattrs.prealloc_blob buffer while holding the i_ceph_lock. This can be > fixed by postponing the call until later, when the lock is released. > > The following

Re: [PATCH v3 3/9] x86/mm/tlb: Open-code on_each_cpu_cond_mask() for tlb_is_not_lazy()

2019-07-19 Thread Nadav Amit
> On Jul 19, 2019, at 3:44 PM, Joe Perches wrote: > > On Fri, 2019-07-19 at 18:41 +, Nadav Amit wrote: >>> On Jul 19, 2019, at 11:36 AM, Dave Hansen wrote: >>> >>> On 7/18/19 5:58 PM, Nadav Amit wrote: @@ -865,7 +893,7 @@ void arch_tlbbatch_flush(struct arch_tlbflush_unmap_batch

Re: [PATCH] x86/stacktrace: Do not access user space memory unnecessarily

2019-07-19 Thread Thomas Gleixner
On Sat, 20 Jul 2019, Thomas Gleixner wrote: > On Fri, 19 Jul 2019, Sean Christopherson wrote: > > On Tue, Jul 02, 2019 at 01:39:05PM -0400, Steven Rostedt wrote: > > > > I'm hitting a similar panic that bisects to commit > > > > a0d14b8909de ("x86/mm, tracing: Fix CR2 corruption") > > > >

Re: [PATCH 4/4][V2] dt-bindings: iio: imu: add bindings for ADIS16460

2019-07-19 Thread Rob Herring
On Wed, Jul 17, 2019 at 5:51 AM Alexandru Ardelean wrote: > > This change adds device-tree bindings for the ADIS16460. > > Signed-off-by: Alexandru Ardelean > --- > .../bindings/iio/imu/adi,adis16460.yaml | 53 +++ > MAINTAINERS | 1 + >

Re: [PATCH v3 3/9] x86/mm/tlb: Open-code on_each_cpu_cond_mask() for tlb_is_not_lazy()

2019-07-19 Thread Joe Perches
On Fri, 2019-07-19 at 18:41 +, Nadav Amit wrote: > > On Jul 19, 2019, at 11:36 AM, Dave Hansen wrote: > > > > On 7/18/19 5:58 PM, Nadav Amit wrote: > > > @@ -865,7 +893,7 @@ void arch_tlbbatch_flush(struct > > > arch_tlbflush_unmap_batch *batch) > > > if (cpumask_test_cpu(cpu, >cpumask))

Re: [PATCH v2] 8250_lpss: check null return when calling pci_ioremap_bar

2019-07-19 Thread Andy Shevchenko
On Sat, Jul 20, 2019 at 12:45 AM Navid Emamdoost wrote: > > pci_ioremap_bar may return null. This is eventually de-referenced at > drivers/dma/dw/core.c:1154 and drivers/dma/dw/core.c:1168. A null check > is needed to prevent null de-reference. I am adding the check and in case > of failure.

Re: [PATCH] lpss8250_dma_setup: there is memory leak when second allocation fails

2019-07-19 Thread Andy Shevchenko
On Sat, Jul 20, 2019 at 1:23 AM Navid Emamdoost wrote: > > in lpss8250_dma_setup, we need to release the first dma slave object > allocated in case of the second allocation failure. > This will bring a double free instead of fixing anything. NAK. > Signed-off-by: Navid Emamdoost > --- >

Re: [PATCH 4.19 13/47] afs: Fix uninitialised spinlock afs_volume::cb_break_lock

2019-07-19 Thread Pavel Machek
Hi! > Without this, the following trace may be observed when a volume-break > callback is received: > > INFO: trying to register non-static key. > the code is fine but needs lockdep annotation. I'm sure this fixes the warning... > diff --git a/fs/afs/callback.c b/fs/afs/callback.c > index

[PATCH 2/2] checkpatch: Improve SPDX license checking

2019-07-19 Thread Joe Perches
Use perl's m@@ match and not // comparisons to avoid an error using c90's // comment style. Miscellanea: o Use normal tab indentation and alignment Link: http://lkml.kernel.org/r/5e4a8fa7901148fbcd77ab391e6dd0e6bf95777f.ca...@perches.com Signed-off-by: Joe Perches Signed-off-by: Andrew

[PATCH 1/2] checkpatch: Don't interpret stack dumps as commit IDs

2019-07-19 Thread Joe Perches
Add more types of lines that appear to be stack dumps that also include hex lines that might otherwise be interpreted as commit IDs. Link: http://lkml.kernel.org/r/ff00208289224f0ca4eaf4ff7c9c6e087dad0a63.ca...@perches.com Signed-off-by: Joe Perches Signed-off-by: Andrew Morton Signed-off-by:

Re: [PATCH v2] KVM: nVMX: do not use dangling shadow VMCS after guest reset

2019-07-19 Thread Liran Alon
> On 20 Jul 2019, at 1:21, Paolo Bonzini wrote: > > On 20/07/19 00:06, Liran Alon wrote: >> >> >>> On 20 Jul 2019, at 0:39, Paolo Bonzini wrote: >>> >>> If a KVM guest is reset while running a nested guest, free_nested will >>> disable the shadow VMCS execution control in the vmcs01.

Re: [PATCH] x86/stacktrace: Do not access user space memory unnecessarily

2019-07-19 Thread Thomas Gleixner
On Fri, 19 Jul 2019, Sean Christopherson wrote: > On Tue, Jul 02, 2019 at 01:39:05PM -0400, Steven Rostedt wrote: > > I'm hitting a similar panic that bisects to commit > > a0d14b8909de ("x86/mm, tracing: Fix CR2 corruption") > > except I'm experiencing death immediately after starting init.

Re: [PATCH v2] KVM: nVMX: do not use dangling shadow VMCS after guest reset

2019-07-19 Thread Paolo Bonzini
On 20/07/19 00:06, Liran Alon wrote: > > >> On 20 Jul 2019, at 0:39, Paolo Bonzini wrote: >> >> If a KVM guest is reset while running a nested guest, free_nested will >> disable the shadow VMCS execution control in the vmcs01. However, >> on the next KVM_RUN vmx_vcpu_run would nevertheless try

Re: [PATCH v2] KVM: nVMX: do not use dangling shadow VMCS after guest reset

2019-07-19 Thread Liran Alon
> On 20 Jul 2019, at 0:39, Paolo Bonzini wrote: > > If a KVM guest is reset while running a nested guest, free_nested will > disable the shadow VMCS execution control in the vmcs01. However, > on the next KVM_RUN vmx_vcpu_run would nevertheless try to sync > the VMCS12 to the shadow VMCS

[PATCH RT 10/16] Revert "futex: Fix bug on when a requeued RT task times out"

2019-07-19 Thread Steven Rostedt
4.19.59-rt24-rc1 stable review patch. If anyone has any objections, please let me know. -- From: Sebastian Andrzej Siewior [ Upstream commit f1a170cb3289a48df26cae3c60d77608f7a988bb ] Drop the RT fixup, the futex code will be changed to avoid the need for the workaround.

[PATCH RT 00/16] Linux 4.19.59-rt24-rc1

2019-07-19 Thread Steven Rostedt
Dear RT Folks, This is the RT stable review cycle of patch 4.19.59-rt24-rc1. Please scream at me if I messed something up. Please test the patches too. The -rc release will be uploaded to kernel.org and will be deleted when the final release is out. This is just a review release (or release

[PATCH RT 08/16] timers: Redo the notification of canceling timers on -RT

2019-07-19 Thread Steven Rostedt
4.19.59-rt24-rc1 stable review patch. If anyone has any objections, please let me know. -- From: Sebastian Andrzej Siewior [ Upstream commit c71273154c2ad12e1aada340ff30e826a11b ] Rework of the hrtimer, timer and posix-timer cancelation interface on -RT. Instead of the

[PATCH RT 05/16] rcu: Dont allow to change rcu_normal_after_boot on RT

2019-07-19 Thread Steven Rostedt
4.19.59-rt24-rc1 stable review patch. If anyone has any objections, please let me know. -- From: Sebastian Andrzej Siewior [ Upstream commit c6c058c10577815a2491ce661876cff00a4c3b15 ] On RT rcu_normal_after_boot is enabled by default. Don't allow to disable it on RT because

[PATCH RT 03/16] genirq: Handle missing work_struct in irq_set_affinity_notifier()

2019-07-19 Thread Steven Rostedt
4.19.59-rt24-rc1 stable review patch. If anyone has any objections, please let me know. -- From: Sebastian Andrzej Siewior [ Upstream commit bbc4d2a7d6ff54ba923640d9a42c7bef7185fe98 ] The backported stable commit 59c39840f5abf ("genirq: Prevent use-after-free and work list

[PATCH RT 01/16] kthread: add a global worker thread.

2019-07-19 Thread Steven Rostedt
4.19.59-rt24-rc1 stable review patch. If anyone has any objections, please let me know. -- From: Sebastian Andrzej Siewior [ Upstream commit 0532e87d9d44795221aa921ba7024bde689cc894 ] Add kthread_schedule_work() which uses a global kthread for all its jobs. Split the cgroup

[PATCH RT 09/16] Revert "futex: Ensure lock/unlock symetry versus pi_lock and hash bucket lock"

2019-07-19 Thread Steven Rostedt
4.19.59-rt24-rc1 stable review patch. If anyone has any objections, please let me know. -- From: Sebastian Andrzej Siewior [ Upstream commit 6a773b70cf105b46298ed3b44e77c102ce31d9ec ] Drop the RT fixup, the futex code will be changed to avoid the need for the workaround.

[PATCH RT 14/16] futex: Delay deallocation of pi_state

2019-07-19 Thread Steven Rostedt
4.19.59-rt24-rc1 stable review patch. If anyone has any objections, please let me know. -- From: Thomas Gleixner [ Upstream commit d7c7cf8cb68b7df17e6e50be1f25f35d83e686c7 ] On -RT we can't invoke kfree() in a non-preemptible context. Defer the deallocation of pi_state to

[PATCH RT 12/16] Revert "futex: workaround migrate_disable/enable in different context"

2019-07-19 Thread Steven Rostedt
4.19.59-rt24-rc1 stable review patch. If anyone has any objections, please let me know. -- From: Sebastian Andrzej Siewior [ Upstream commit a71221d81cc4873891ae44f3aa02df596079b786 ] Drop the RT fixup, the futex code will be changed to avoid the need for the workaround.

[PATCH RT 07/16] sched/core: Drop a preempt_disable_rt() statement

2019-07-19 Thread Steven Rostedt
4.19.59-rt24-rc1 stable review patch. If anyone has any objections, please let me know. -- From: Sebastian Andrzej Siewior [ Upstream commit 761126efdcbe3fa3e99c9079fa0ad6eca2f251f2 ] The caller holds a lock which already disables preemption. Drop the preempt_disable_rt()

[PATCH RT 13/16] futex: Make the futex_hash_bucket lock raw

2019-07-19 Thread Steven Rostedt
4.19.59-rt24-rc1 stable review patch. If anyone has any objections, please let me know. -- From: Sebastian Andrzej Siewior [ Upstream commit f646521aadedab78801c9befe193e2e8a0c99298 ] Since commit 1a1fb985f2e2b ("futex: Handle early deadlock return correctly") we can deadlock

[PATCH RT 11/16] Revert "rtmutex: Handle the various new futex race conditions"

2019-07-19 Thread Steven Rostedt
4.19.59-rt24-rc1 stable review patch. If anyone has any objections, please let me know. -- From: Sebastian Andrzej Siewior [ Upstream commit 9e0265c21af4d6388d47dcd5ce20f76ec3a2e468 ] Drop the RT fixup, the futex code will be changed to avoid the need for the workaround.

[PATCH RT 15/16] mm/zswap: Do not disable preemption in zswap_frontswap_store()

2019-07-19 Thread Steven Rostedt
4.19.59-rt24-rc1 stable review patch. If anyone has any objections, please let me know. -- From: "Luis Claudio R. Goncalves" [ Upstream commit 4e4cf4be79635e67144632d9135286381acbc95a ] Zswap causes "BUG: scheduling while atomic" by blocking on a rt_spin_lock() with preemption

[PATCH RT 06/16] pci/switchtec: fix stream_open.cocci warnings

2019-07-19 Thread Steven Rostedt
4.19.59-rt24-rc1 stable review patch. If anyone has any objections, please let me know. -- From: kbuild test robot [ Upstream commit 9462c69e29307adc95c289f50839d5d683973891 ] drivers/pci/switch/switchtec.c:395:1-17: ERROR: switchtec_fops: .read() can deadlock .write();

[PATCH RT 02/16] genirq: Do not invoke the affinity callback via a workqueue on RT

2019-07-19 Thread Steven Rostedt
4.19.59-rt24-rc1 stable review patch. If anyone has any objections, please let me know. -- From: Sebastian Andrzej Siewior [ Upstream commit 2122adbe011cdc0eb62ad62494e181005b23c76a ] Joe Korty reported, that __irq_set_affinity_locked() schedules a workqueue while holding a

[PATCH RT 04/16] arm: imx6: cpuidle: Use raw_spinlock_t

2019-07-19 Thread Steven Rostedt
4.19.59-rt24-rc1 stable review patch. If anyone has any objections, please let me know. -- From: Sebastian Andrzej Siewior [ Upstream commit 40d0332ec8312e9c090f0a5414d9c90e12b13611 ] The idle call back is invoked with disabled interrupts and requires raw_spinlock_t locks to

[PATCH RT 16/16] Linux 4.19.59-rt24-rc1

2019-07-19 Thread Steven Rostedt
4.19.59-rt24-rc1 stable review patch. If anyone has any objections, please let me know. -- From: "Steven Rostedt (VMware)" --- localversion-rt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/localversion-rt b/localversion-rt index 9a218ca23053..538297c53ccc

Re: [PATCH] be2net: fix adapter->big_page_size miscaculation

2019-07-19 Thread Qian Cai
On Thu, 2019-07-18 at 16:29 -0700, David Miller wrote: > From: Qian Cai > Date: Thu, 18 Jul 2019 19:26:47 -0400 > > >  > >  > >> On Jul 18, 2019, at 5:21 PM, Bill Wendling wrote: > >>  > >> [My previous response was marked as spam...] > >>  > >> Top-of-tree clang says that it's const: > >>  >

Re: [PATCH v2 2/3] mm/hmm: fix ZONE_DEVICE anon page mapping reuse

2019-07-19 Thread John Hubbard
On 7/19/19 12:29 PM, Ralph Campbell wrote: > When a ZONE_DEVICE private page is freed, the page->mapping field can be > set. If this page is reused as an anonymous page, the previous value can > prevent the page from being inserted into the CPU's anon rmap table. > For example, when migrating a

Re: [PATCH v2 1/3] mm: document zone device struct page field usage

2019-07-19 Thread John Hubbard
On 7/19/19 12:29 PM, Ralph Campbell wrote: > Struct page for ZONE_DEVICE private pages uses the page->mapping and > and page->index fields while the source anonymous pages are migrated to > device private memory. This is so rmap_walk() can find the page when > migrating the ZONE_DEVICE private

Re: [PATCH v2 5/5] KVM: x86: Don't check kvm_rebooting in __kvm_handle_fault_on_reboot()

2019-07-19 Thread Paolo Bonzini
On 19/07/19 22:41, Sean Christopherson wrote: > Remove the kvm_rebooting check from VMX/SVM instruction exception fixup > now that kvm_spurious_fault() conditions its BUG() on !kvm_rebooting. > Because the 'cleanup_insn' functionally is also gone, deferring to > kvm_spurious_fault() means

[PATCH v2] KVM: nVMX: do not use dangling shadow VMCS after guest reset

2019-07-19 Thread Paolo Bonzini
If a KVM guest is reset while running a nested guest, free_nested will disable the shadow VMCS execution control in the vmcs01. However, on the next KVM_RUN vmx_vcpu_run would nevertheless try to sync the VMCS12 to the shadow VMCS which has since been freed. This causes a vmptrld of a NULL

Re: [PATCH] KVM: nVMX: do not use dangling shadow VMCS after guest reset

2019-07-19 Thread Paolo Bonzini
On 19/07/19 23:01, Liran Alon wrote: > > >> On 19 Jul 2019, at 19:42, Paolo Bonzini wrote: >> >> If a KVM guest is reset while running a nested guest, free_nested will >> disable the shadow VMCS execution control in the vmcs01. However, >> on the next KVM_RUN vmx_vcpu_run would nevertheless

Re: [PATCH v3 0/9] x86: Concurrent TLB flushes

2019-07-19 Thread Dave Hansen
Thanks for doing this, it's something I've been hoping someone would do for a long time. While I kinda wish we had performance data for each individual patch (at least the behavior-changing ones), this does look like a good improvement. That might, for instance, tell is a bit about how the

Re: [PATCH v3] staging: kpc2000: Convert put_page to put_user_page*()

2019-07-19 Thread John Hubbard
On 7/19/19 1:02 PM, Bharath Vedartham wrote: > There have been issues with coordination of various subsystems using > get_user_pages. These issues are better described in [1]. > > An implementation of tracking get_user_pages is currently underway > The implementation requires the use

Re: network problems with r8169

2019-07-19 Thread Thomas Voegtle
hy_write(phydev, regnum, new); + __phy_write(phydev, regnum, new); - return ret < 0 ? ret : 1; + return new != ret; } EXPORT_SYMBOL_GPL(__phy_modify_changed); Took your patch on top of next-20190719. See attached dmesg. It didn't work. Same thing, lots of ping drops, no usable

Re: [PATCH 2/3] x86/mm: Sync also unmappings in vmalloc_sync_one()

2019-07-19 Thread Thomas Gleixner
On Fri, 19 Jul 2019, Joerg Roedel wrote: > On Thu, Jul 18, 2019 at 11:04:57AM +0200, Thomas Gleixner wrote: > > Joerg, > > > > On Thu, 18 Jul 2019, Joerg Roedel wrote: > > > On Wed, Jul 17, 2019 at 11:43:43PM +0200, Thomas Gleixner wrote: > > > > On Wed, 17 Jul 2019, Joerg Roedel wrote: > > > > >

Re: [PATCH] phy: Change the configuration interface param to void* to make it more general

2019-07-19 Thread kbuild test robot
Hi Zeng, Thank you for the patch! Yet something to improve: [auto build test ERROR on linus/master] [cannot apply to v5.2 next-20190719] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Zeng-Tao

Re: [PATCH v3] staging: kpc2000: Convert put_page to put_user_page*()

2019-07-19 Thread John Hubbard
On 7/19/19 1:59 PM, Matt Sickler wrote: >> From: Bharath Vedartham >> Changes since v2 >>- Added back PageResevered check as suggested by John Hubbard. >> >> The PageReserved check needs a closer look and is not worth messing >> around with for now. >> >> Matt, Could you give any

[ANNOUNCE] 4.19.59-rt23

2019-07-19 Thread Steven Rostedt
Dear RT Folks, I'm pleased to announce the 4.19.59-rt23 stable release. This release is just an update to the new stable 4.19.59 version and no RT specific changes have been made. You can get this release via the git tree at:

Re: [PATCH] KVM: VMX: dump VMCS on failed entry

2019-07-19 Thread Liran Alon
> On 19 Jul 2019, at 19:42, Paolo Bonzini wrote: > > This is useful for debugging, and is ratelimited nowadays. > > Signed-off-by: Paolo Bonzini Reviewed-by: Liran Alon > --- > arch/x86/kvm/vmx/vmx.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/x86/kvm/vmx/vmx.c

Re: [PATCH] KVM: nVMX: do not use dangling shadow VMCS after guest reset

2019-07-19 Thread Liran Alon
> On 19 Jul 2019, at 19:42, Paolo Bonzini wrote: > > If a KVM guest is reset while running a nested guest, free_nested will > disable the shadow VMCS execution control in the vmcs01. However, > on the next KVM_RUN vmx_vcpu_run would nevertheless try to sync > the VMCS12 to the shadow VMCS

RE: [PATCH v3] staging: kpc2000: Convert put_page to put_user_page*()

2019-07-19 Thread Matt Sickler
>From: Bharath Vedartham >Changes since v2 >- Added back PageResevered check as suggested by John Hubbard. > >The PageReserved check needs a closer look and is not worth messing >around with for now. > >Matt, Could you give any suggestions for testing this patch? Myself or someone else

Re: [PATCH v1 9/9] smaples: add vfio-mdev-pci driver

2019-07-19 Thread Alex Williamson
On Fri, 12 Jul 2019 12:55:27 + "Liu, Yi L" wrote: > Hi Alex, > > > From: Alex Williamson [mailto:alex.william...@redhat.com] > > Sent: Friday, July 12, 2019 3:08 AM > > To: Liu, Yi L > > Subject: Re: [PATCH v1 9/9] smaples: add vfio-mdev-pci driver > > > > On Thu, 11 Jul 2019 12:27:26

Re: [PATCH] [v2] kasan: remove clang version check for KASAN_STACK

2019-07-19 Thread Nick Desaulniers
On Fri, Jul 19, 2019 at 1:03 PM Arnd Bergmann wrote: > > asan-stack mode still uses dangerously large kernel stacks of > tens of kilobytes in some drivers, and it does not seem that anyone > is working on the clang bug. Acked-by: Nick Desaulniers > > Turn it off for all clang versions to

gpio: aspeed: Add SGPIO driver

2019-07-19 Thread Hongwei Zhang
Hello Andrew, Thanks for reviewing and suggestions. please see my inline comments. I just submitted v5 with a proper series title, please help review them. In AST2500 datasheet, it says: "Support up to 80 SGPIO input ports and 80 output ports concurrently only at the cost of 4 control

[PATCH v2 5/5] KVM: x86: Don't check kvm_rebooting in __kvm_handle_fault_on_reboot()

2019-07-19 Thread Sean Christopherson
Remove the kvm_rebooting check from VMX/SVM instruction exception fixup now that kvm_spurious_fault() conditions its BUG() on !kvm_rebooting. Because the 'cleanup_insn' functionally is also gone, deferring to kvm_spurious_fault() means __kvm_handle_fault_on_reboot() can eliminate its .fixup code

[PATCH v2 0/5] KVM: VMX: Optimize VMX instrs error/fault handling

2019-07-19 Thread Sean Christopherson
A recent commit reworked __kvm_handle_fault_on_reboot() to play nice with objtool. An unfortunate side effect is that JMP is now inserted after most VMX instructions so that the reboot macro can use an actual CALL to kvm_spurious_fault() instead of a funky PUSH+JMP facsimile in .fixup. Rework

[PATCH v2 2/5] KVM: VMX: Optimize VMX instruction error and fault handling

2019-07-19 Thread Sean Christopherson
Rework the VMX instruction helpers using asm-goto to branch directly to error/fault "handlers" in lieu of using __ex(), i.e. the generic kvm_handle_fault_on_reboot(). Branching directly to fault handling code during fixup avoids the extra JMP that is inserted after every VMX instruction when

[PATCH v2 1/5] objtool: KVM: x86: Check kvm_rebooting in kvm_spurious_fault()

2019-07-19 Thread Sean Christopherson
Explicitly check kvm_reboot in kvm_spurious_fault() prior to invoking BUG(), as opposed to assuming the caller has already done so. Letting kvm_spurious_fault() be called "directly" will allow VMX to better optimize its low level assembly flows. As a happy side effect, kvm_spurious_fault() no

[PATCH v2 3/5] KVM: VMX: Add error handling to VMREAD helper

2019-07-19 Thread Sean Christopherson
Now that VMREAD flows require a taken branch, courtesy of commit 3901336ed9887 ("x86/kvm: Don't call kvm_spurious_fault() from .fixup") bite the bullet and add full error handling to VMREAD, i.e. replace the JMP added by __ex()/kvm_handle_fault_on_reboot() with a hinted Jcc. To minimize

[PATCH v2 4/5] KVM: x86: Drop ____kvm_handle_fault_on_reboot()

2019-07-19 Thread Sean Christopherson
Remove the variation of __kvm_handle_fault_on_reboot() that accepts a post-fault cleanup instruction now that its sole user (VMREAD) uses a different method for handling faults. Acked-by: Paolo Bonzini Signed-off-by: Sean Christopherson --- arch/x86/include/asm/kvm_host.h | 6 +- 1 file

Re: [PATCH] mm/Kconfig: additional help text for HMM_MIRROR option

2019-07-19 Thread John Hubbard
On 7/19/19 5:04 AM, Pavel Machek wrote: > On Fri 2019-07-19 05:00:43, Christoph Hellwig wrote: >> On Fri, Jul 19, 2019 at 08:48:53AM -0300, Jason Gunthorpe wrote: >>> It is like MMU_NOTIFIERS, if something needs it, then it will select >>> it. >>> >>> Maybe it should just be a hidden kconfig

dt-bindings: gpio: aspeed: Add SGPIO support

2019-07-19 Thread Hongwei Zhang
Hello Andrew, Thanks for reviewing and please see my inline comments. --Hongwei > From: Andrew Jeffery > Sent: Wednesday, July 17, 2019 9:48 PM > To: Hongwei Zhang; Joel Stanley; Linus Walleij; devicet...@vger.kernel.org > Cc: Rob Herring; Mark Rutland; Bartosz Golaszewski; >

  1   2   3   4   5   6   >