[PATCH] mailbox: fix return value check in zynqmp_ipi_mbox_probe

2019-07-25 Thread Ding Xiang
If devm_ioremap() failed, it will return NULL pointer not ERR_PTR(). So, use NULL test instead of IS_ERR() test. Signed-off-by: Ding Xiang --- drivers/mailbox/zynqmp-ipi-mailbox.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git

Zdravstvujte! Vas interesuyut klientskie bazy dannyh?

2019-07-25 Thread linux-kernel
Zdravstvujte! Vas interesuyut klientskie bazy dannyh?

Re: [PATCH] mm/rmap.c: remove set but not used variable 'cstart'

2019-07-25 Thread Kirill Tkhai
On 24.07.2019 17:14, YueHaibing wrote: > Fixes gcc '-Wunused-but-set-variable' warning: > > mm/rmap.c: In function page_mkclean_one: > mm/rmap.c:906:17: warning: variable cstart set but not used > [-Wunused-but-set-variable] > > It is not used any more since > commit cdb07bdea28e ("mm/rmap.c:

[PATCH v3 4/4] arm64: Remove unneeded rcu_read_lock from debug handlers

2019-07-25 Thread Masami Hiramatsu
Remove rcu_read_lock()/rcu_read_unlock() from debug exception handlers since we are sure those are not preemptible and interrupts are off. Acked-by: Paul E. McKenney Signed-off-by: Masami Hiramatsu --- arch/arm64/kernel/debug-monitors.c | 14 -- 1 file changed, 8 insertions(+), 6

[PATCH v3 3/4] arm64: Make debug exception handlers visible from RCU

2019-07-25 Thread Masami Hiramatsu
Make debug exceptions visible from RCU so that synchronize_rcu() correctly track the debug exception handler. This also introduces sanity checks for user-mode exceptions as same as x86's ist_enter()/ist_exit(). The debug exception can interrupt in idle task. For example, it warns if we put a

[PATCH v3 2/4] arm64: unwind: Prohibit probing on return_address()

2019-07-25 Thread Masami Hiramatsu
Prohibit probing on return_address() and subroutines which is called from return_address(), since the it is invoked from trace_hardirqs_off() which is also kprobe blacklisted. Reported-by: Naresh Kamboju Signed-off-by: Masami Hiramatsu --- Changes in v3: - Fix to use NOKPROBE_SYMBOL() for

[PATCH v3 1/4] arm64: kprobes: Recover pstate.D in single-step exception handler

2019-07-25 Thread Masami Hiramatsu
kprobes manipulates the interrupted PSTATE for single step, and doesn't restore it. Thus, if we put a kprobe where the pstate.D (debug) masked, the mask will be cleared after the kprobe hits. Moreover, in the most complicated case, this can lead a kernel crash with below message when a nested

[PATCH v3 0/4] arm64: kprobes: Fix some bugs in arm64 kprobes

2019-07-25 Thread Masami Hiramatsu
Hi, Here are the v3 patches which fixes kprobe bugs on arm64. In this version I fixed some issues pointed by James and add Reviewed-by and Acked-bys. Background: Naresh reported that recently ftracetest crashes kernel, and I found there are 3 different bugs around the crash. In v1 thread, we

Re: [PATCH v8 2/4] uprobe: use original page when all uprobes are removed

2019-07-25 Thread Oleg Nesterov
On 07/24, Song Liu wrote: > > > > On Jul 24, 2019, at 4:37 AM, Oleg Nesterov wrote: > > > > On 07/24, Song Liu wrote: > >> > >>lock_page(old_page); > >> @@ -177,15 +180,24 @@ static int __replace_page(struct vm_area_struct > >> *vma, unsigned long addr, > >>

Re: [RFC PATCH 3/3] hugetlbfs: don't retry when pool page allocations start to fail

2019-07-25 Thread Mel Gorman
On Wed, Jul 24, 2019 at 10:50:14AM -0700, Mike Kravetz wrote: > When allocating hugetlbfs pool pages via /proc/sys/vm/nr_hugepages, > the pages will be interleaved between all nodes of the system. If > nodes are not equal, it is quite possible for one node to fill up > before the others. When

[PATCH] rtw88: pci: Use general byte arrays as the elements of RX ring

2019-07-25 Thread Jian-Hong Pan
Each skb as the element in RX ring was expected with sized buffer 8216 (RTK_PCI_RX_BUF_SIZE) bytes. However, the skb buffer's true size is 16640 bytes for alignment after allocated, x86_64 for example. And, the difference will be enlarged 512 times (RTK_MAX_RX_DESC_NUM). To prevent that much

Re: [RFC PATCH 2/3] mm, compaction: use MIN_COMPACT_COSTLY_PRIORITY everywhere for costly orders

2019-07-25 Thread Mel Gorman
On Wed, Jul 24, 2019 at 10:50:13AM -0700, Mike Kravetz wrote: > For PAGE_ALLOC_COSTLY_ORDER allocations, MIN_COMPACT_COSTLY_PRIORITY is > minimum (highest priority). Other places in the compaction code key off > of MIN_COMPACT_PRIORITY. Costly order allocations will never get to >

[PATCH] kbuild: detect missing "WITH Linux-syscall-note" for uapi headers

2019-07-25 Thread Masahiro Yamada
UAPI headers licensed under GPL are supposed to have exception "WITH Linux-syscall-note" so that they can be included into non-GPL user space application code. Unfortunately, people often miss to add it. Break 'make headers' when any of exported headers lacks the exception note so that the 0-day

Re: [RFC PATCH 1/3] mm, reclaim: make should_continue_reclaim perform dryrun detection

2019-07-25 Thread Mel Gorman
On Wed, Jul 24, 2019 at 10:50:12AM -0700, Mike Kravetz wrote: > From: Hillf Danton > > Address the issue of should_continue_reclaim continuing true too often > for __GFP_RETRY_MAYFAIL attempts when !nr_reclaimed and nr_scanned. > This could happen during hugetlb page allocation causing stalls

Re: [PATCH 2/2] Revert "media: vimc: propagate pixel format in the stream"

2019-07-25 Thread Hans Verkuil
Hi Helen, On 7/9/19 9:43 PM, Helen Koike wrote: > This reverts commit b6c61a6c37317efd7327199bfe24770af3d7e799. > > The requested pixelformat is being propagated from the capture to the > tpg in the sensor. > > This was a bad design choice, as we start having the following issues: > > * We set

Re: [PATCH 2/2] powercap/rapl: Add Ice Lake NNPI support to RAPL driver

2019-07-25 Thread Bhardwaj, Rajneesh
Hi Rafael On 28-Jun-19 3:32 AM, Rafael J. Wysocki wrote: On Friday, June 14, 2019 10:05:23 AM CEST Rajneesh Bhardwaj wrote: Enables support for ICL-NNPI, which is a neural network processor for deep learning inference. From RAPL point of view it is same as Ice Lake Mobile processor. Cc:

Re: [PATCH] platform/x86: intel_pmc_core: Add ICL-NNPI support to PMC Core

2019-07-25 Thread Bhardwaj, Rajneesh
Hi Andy On 29-Jun-19 6:48 PM, Andy Shevchenko wrote: On Fri, Jun 14, 2019 at 11:14 AM Rajneesh Bhardwaj wrote: Ice Lake Neural Network Processor for deep learning inference a.k.a. ICL-NNPI can re-use Ice Lake Mobile regmap to enable Intel PMC Core driver on it. This will be postponed till

[PATCH RESEND] autonuma: Fix scan period updating

2019-07-25 Thread Huang, Ying
From: Huang Ying >From the commit log and comments of commit 37ec97deb3a8 ("sched/numa: Slow down scan rate if shared faults dominate"), the autonuma scan period should be increased (scanning is slowed down) if the majority of the page accesses are shared with other processes. But in current

Re: [PATCH] media: vivid: fix device init when no_error_inj=1 and fb disabled

2019-07-25 Thread Hans Verkuil
On 7/24/19 5:19 PM, Guillaume Tucker wrote: > Add an extra condition to add the video output control class when the > device has some hdmi outputs defined. This is required to then always > be able to add the display present control, which is enabled when > there are some hdmi outputs. > > This

Re: [PATCH 2/2] powercap/rapl: Add Ice Lake NNPI support to RAPL driver

2019-07-25 Thread Bhardwaj, Rajneesh
Hi Rafael, On 05-Jul-19 3:43 PM, Rafael J. Wysocki wrote: On Friday, June 28, 2019 10:21:41 AM CEST Bhardwaj, Rajneesh wrote: On 28-Jun-19 3:32 AM, Rafael J. Wysocki wrote: On Friday, June 14, 2019 10:05:23 AM CEST Rajneesh Bhardwaj wrote: Enables support for ICL-NNPI, which is a neural

[PATCH v2 2/3] treewide: remove SPDX "WITH Linux-syscall-note" from kernel-space headers again

2019-07-25 Thread Masahiro Yamada
The "WITH Linux-syscall-note" exception exists for headers exported to user space. It is strange to add it to non-exported headers. Commit 687a3e4d8e61 ("treewide: remove SPDX "WITH Linux-syscall-note" from kernel-space headers") did cleanups some months ago, but it looks like we need to do this

[PATCH v2 1/3] treewide: add "WITH Linux-syscall-note" to SPDX tag of uapi headers

2019-07-25 Thread Masahiro Yamada
UAPI headers licensed under GPL are supposed to have exception "WITH Linux-syscall-note" so that they can be included into non-GPL user space application code. The exception note is missing in some UAPI headers. Some of them slipped in by the treewide conversion commit b24413180f56 ("License

[PATCH v2 3/3] iomap: fix Invalid License ID

2019-07-25 Thread Masahiro Yamada
Detected by: $ ./scripts/spdxcheck.py fs/iomap/Makefile: 1:27 Invalid License ID: GPL-2.0-or-newer Fixes: 1c230208f53d ("iomap: start moving code to fs/iomap/") Signed-off-by: Masahiro Yamada --- Changes in v2: - New patch fs/iomap/Makefile | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH 3/3] i2c: sprd: Validate the return value of clock initialization

2019-07-25 Thread Baolin Wang
The 'enable' clock of I2C master is required, we should return an error if failed to get the 'enable' clock, to make sure the I2C driver can be defer probe if the clock resource is not ready. Signed-off-by: Baolin Wang --- drivers/i2c/busses/i2c-sprd.c | 11 +++ 1 file changed, 7

[PATCH 1/3] i2c: sprd: Make I2C driver can be built as a module

2019-07-25 Thread Baolin Wang
Now there is no need to keep our I2C driver to be initialized so early, thus changing to module level and let it can be built as a module, meanwhile adding some module information. Signed-off-by: Baolin Wang --- drivers/i2c/busses/Kconfig|2 +- drivers/i2c/busses/i2c-sprd.c | 10

[PATCH 2/3] i2c: sprd: Change to use devm_platform_ioremap_resource()

2019-07-25 Thread Baolin Wang
Use the new helper that wraps the calls to platform_get_resource() and devm_ioremap_resource() together. Signed-off-by: Baolin Wang --- drivers/i2c/busses/i2c-sprd.c |4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/i2c/busses/i2c-sprd.c

Re: [PATCH 1/2] media: ir-kbd-i2c: prevent potential NULL pointer access

2019-07-25 Thread Wolfram Sang
Hi Sean, thanks for the review! On Thu, Jul 25, 2019 at 06:12:02AM +0100, Sean Young wrote: > On Mon, Jul 22, 2019 at 07:26:31PM +0200, Wolfram Sang wrote: > > i2c_new_dummy() can fail returning a NULL pointer. The code does not > > bail out in this case and the returned pointer is blindly used.

Re: [PATCH] perf/x86/intel: Fix SLOTS pebs event constraint

2019-07-25 Thread Peter Zijlstra
On Tue, Jul 23, 2019 at 01:04:29PM -0700, kan.li...@linux.intel.com wrote: > From: Kan Liang > > Sampling SLOTS event and ref-cycles event in a group on Icelake gives > EINVAL. > > SLOTS event is the event stands for the fixed counter 3, not fixed > counter 2. Wrong mask was set to SLOTS event

Re: [PATCH] staging: rtl8723bs: Disable procfs debugging by default

2019-07-25 Thread Greg KH
On Thu, Jul 18, 2019 at 05:25:22PM +0800, Kai-Heng Feng wrote: > The procfs provides many useful information for debugging, but it may be > too much for normal usage, routines like proc_get_sec_info() reports > various security related information. > > So disable it by defaultl. > >

Re: [PATCH 1/2] kernel/fork: Add support for stack-end guard page

2019-07-25 Thread Dmitry Vyukov
On Wed, Jul 24, 2019 at 1:21 PM Mark Rutland wrote: > > On Wed, Jul 24, 2019 at 11:11:49AM +0200, Dmitry Vyukov wrote: > > On Tue, Jul 23, 2019 at 6:41 PM Mark Rutland wrote: > > > > > > On Fri, Jul 19, 2019 at 03:28:17PM +0200, Marco Elver wrote: > > > > Enabling STACK_GUARD_PAGE helps catching

Re: [PATCH RESEND] perf/x86/intel: Bit 13 is valid for Icelake MSR_OFFCORE_RSP_x register

2019-07-25 Thread Peter Zijlstra
On Wed, Jul 24, 2019 at 09:11:01AM -0400, Liang, Kan wrote: > > > On 7/24/2019 4:29 AM, Yunying Sun wrote: > > From Intel SDM, bit 13 of Icelake MSR_OFFCORE_RSP_x register is valid for > > counting hardware generated prefetches of L3 cache. But current bitmasks > > in driver takes bit 13 as

[PATCH net-next] net: mvneta: use devm_platform_ioremap_resource() to simplify code

2019-07-25 Thread Jisheng Zhang
devm_platform_ioremap_resource() wraps platform_get_resource() and devm_ioremap_resource() in a single helper, let's use that helper to simplify the code. Signed-off-by: Jisheng Zhang --- drivers/net/ethernet/marvell/mvneta.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git

[PATCH 1/1] power/supply/powersupply_sysfs: Add of_node name to uevent message if available

2019-07-25 Thread Richard Tresidder
If the of_node name of the supply is available from the devicetree binding then include it under the var POWER_SUPPLY_OF_NODE_NAME. This helps where a consistent name is known via the device tree binding but it is hard to identify based on the usual enumeration process. Signed-off-by: Richard

Re: [PATCH] perf/x86: Apply more accurate check on hypervisor platform

2019-07-25 Thread Peter Zijlstra
On Thu, Jul 25, 2019 at 10:39:26AM +0800, Zhenzhong Duan wrote: > check_msr is used to fix a bug report in guest where KVM doesn't support > LBR MSR and cause #GP. > > The msr check is bypassed on real HW to workaround a false failure, > see commit d0e1a507bdc7 ("perf/x86/intel: Disable check_msr

Re: [PATCH v4] staging: kpc2000: Convert put_page to put_user_page*()

2019-07-25 Thread Greg KH
On Sat, Jul 20, 2019 at 11:02:14PM +0530, Bharath Vedartham wrote: > For pages that were retained via get_user_pages*(), release those pages > via the new put_user_page*() routines, instead of via put_page(). > > This is part a tree-wide conversion, as described in commit fc1d8e7cca2d > ("mm:

Re: [PATCH 1/2] string: Add stracpy and stracpy_pad mechanisms

2019-07-25 Thread Markus Elfring
> New version. I check for non-use of the return value of strlcpy and > address some issues that affected the matching of the case where the first > argument involves a pointer dereference. I suggest to take another look at corresponding implementation details of the shown SmPL script. >

Re: WARNING in __mmdrop

2019-07-25 Thread Jason Wang
On 2019/7/25 下午2:02, Michael S. Tsirkin wrote: On Mon, Jul 22, 2019 at 11:11:52AM -0300, Jason Gunthorpe wrote: On Sun, Jul 21, 2019 at 06:02:52AM -0400, Michael S. Tsirkin wrote: On Sat, Jul 20, 2019 at 03:08:00AM -0700, syzbot wrote: syzbot has bisected this bug to: commit

RE: [PATCH net-next 3/3] net: stmmac: Introducing support for Page Pool

2019-07-25 Thread Jose Abreu
From: Jon Hunter Date: Jul/24/2019, 12:58:15 (UTC+00:00) > > On 24/07/2019 12:34, Jose Abreu wrote: > > From: Jon Hunter > > Date: Jul/24/2019, 12:10:47 (UTC+00:00) > > > >> > >> On 24/07/2019 11:04, Jose Abreu wrote: > >> > >> ... > >> > >>> Jon, I was able to replicate (at some level) your

Re: WARNING in __mmdrop

2019-07-25 Thread Jason Wang
On 2019/7/25 下午1:52, Michael S. Tsirkin wrote: On Tue, Jul 23, 2019 at 09:31:35PM +0800, Jason Wang wrote: On 2019/7/23 下午5:26, Michael S. Tsirkin wrote: On Tue, Jul 23, 2019 at 04:49:01PM +0800, Jason Wang wrote: On 2019/7/23 下午4:10, Michael S. Tsirkin wrote: On Tue, Jul 23, 2019 at

Re: Issue with sequence to switch to HS400

2019-07-25 Thread Adrian Hunter
On 23/07/19 3:34 PM, Alan Cooper wrote: > On Tue, Jul 23, 2019 at 1:21 AM Adrian Hunter wrote: >> >> On 23/07/19 1:31 AM, Alan Cooper wrote: >>> I'm having a problem with a new SD/MMC controller and PHY in our >>> latest SoC's. The issue I'm seeing is that I can't switch into HS400 >>> mode. This

[PATCH] mmc: sdhci-pltfm: Use devm_platform_ioremap_resource() to simplify code

2019-07-25 Thread Jisheng Zhang
devm_platform_ioremap_resource() wraps platform_get_resource() and devm_ioremap_resource() in a single helper, let's use that helper to simplify the code. Signed-off-by: Jisheng Zhang --- drivers/mmc/host/sdhci-pltfm.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git

Re: [PATCH] extcon: max14577: Add irq mask IRQ_ONESHOT

2019-07-25 Thread Krzysztof Kozlowski
On Thu, 25 Jul 2019 at 08:42, Vasyl Gomonovych wrote: > > Do not fire irq again until thread done > This issue was found by code inspection > Coccicheck irqf_oneshot.cocci The same as in max77693 - this is virtual IRQ so no need for oneshot. The hardware IRQ has oneshot set. Otherwise please

Re: [PATCH] extcon: max77693: Add extra IRQF_ONESHOT

2019-07-25 Thread Krzysztof Kozlowski
On Thu, 25 Jul 2019 at 08:37, Vasyl Gomonovych wrote: > > Do not fire irq again until thread done > This issue was found by code inspection > Coccicheck irqf_oneshot.cocci Rationale does not look convincing. Do you fix real problem or just automatic fix from coccinelle? If the latter, then it

Re: [PATCH 1/1] x86/boot: clear some fields explicitly

2019-07-25 Thread Thomas Gleixner
On Wed, 24 Jul 2019, h...@zytor.com wrote: > On July 24, 2019 4:15:28 PM PDT, john.hubb...@gmail.com wrote: > >From: John Hubbard > > > >Recent gcc compilers (gcc 9.1) generate warnings about an > >out of bounds memset, if you trying memset across several fields > >of a struct. This generated a

Re: [RFC PATCH 00/10] implement KASLR for powerpc/fsl_booke/32

2019-07-25 Thread Jason Yan
Hi all, any comments? On 2019/7/17 16:06, Jason Yan wrote: This series implements KASLR for powerpc/fsl_booke/32, as a security feature that deters exploit attempts relying on knowledge of the location of kernel internals. Since CONFIG_RELOCATABLE has already supported, what we need to do is

[PATCH] aio: add timeout validity check for io_[p]getevents

2019-07-25 Thread zhangyi (F)
io_[p]getevents syscall should return -EINVAL if if timeout is out of range, add this validity check. Signed-off-by: zhangyi (F) --- fs/aio.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/fs/aio.c b/fs/aio.c index 01e0fb9..dd967a0 100644 --- a/fs/aio.c +++

Re: kernel BUG at mm/swap_state.c:170!

2019-07-25 Thread Huang, Ying
Mikhail Gavrilov writes: > On Tue, 23 Jul 2019 at 10:08, Huang, Ying wrote: >> >> Thanks! I have found another (easier way) to reproduce the panic. >> Could you try the below patch on top of v5.2-rc2? It can fix the panic >> for me. >> > > Thanks! Amazing work! The patch fixes the issue

Re: [PATCH 1/2] treewide: add "WITH Linux-syscall-note" to SPDX tag of uapi headers

2019-07-25 Thread Masahiro Yamada
Please do not apply this. I noticed mistakes. I will fix them and send v2. Thanks. On Thu, Jul 25, 2019 at 3:59 PM Masahiro Yamada wrote: > > UAPI headers licensed under GPL are supposed to have exception > "WITH Linux-syscall-note" so that they can be included into non-GPL > user space

[RFC v4 6/8] sched/fair: Tune task wake-up logic to pack jitter tasks

2019-07-25 Thread Parth Shah
The algorithm finds the first non idle core in the system and tries to place a task in the least utilized CPU in the chosen core. To maintain cache hotness, work of finding non idle core starts from the prev_cpu, which also reduces task ping-pong behaviour inside of the core. This is defined with

[RFC v4 5/8] powerpc: Define Core Capacity for POWER systems

2019-07-25 Thread Parth Shah
Tune arch_scale_core_capacity for powerpc architecture by scaling capacity w.r.t to the number of online SMT in the core such that for SMT-4, core capacity is 1.5x the capacity of sibling thread. Signed-off-by: Parth Shah --- arch/powerpc/include/asm/topology.h | 4

Re: [PATCH v12 1/5] can: m_can: Create a m_can platform framework

2019-07-25 Thread Marc Kleine-Budde
On 7/25/19 8:28 AM, Greg KH wrote: > On Wed, Jul 24, 2019 at 10:36:02AM -0500, Dan Murphy wrote: >> Hello >> >> On 7/24/19 1:47 AM, Greg KH wrote: >>> On Tue, Jul 23, 2019 at 10:14:14AM -0500, Dan Murphy wrote: Hello On 7/10/19 7:08 AM, Dan Murphy wrote: > Hello > > On

[RFC v4 3/8] sched/core: Update turbo_sched count only when required

2019-07-25 Thread Parth Shah
Use the get/put methods to add/remove the use of TurboSched support, such that the feature is turned on only if there is atleast one jitter task. Signed-off-by: Parth Shah --- kernel/sched/core.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/kernel/sched/core.c

[RFC v4 7/8] sched/fair: Bound non idle core search within LLC domain

2019-07-25 Thread Parth Shah
Specify the method which returns sched domain to limit the search for a non idle core. By default, limit the search in LLC domain which usually includes all the cores across the system. The select_non_idle_core searches for the non idle cores across whole system. But in the systems with multiple

[RFC v4 2/8] sched: Introduce switch to enable TurboSched mode

2019-07-25 Thread Parth Shah
Create a static key which allows to enable or disable TurboSched feature at runtime. This key is added in order to enable the TurboSched feature only when required. This helps in optimizing the scheduler fast-path when the TurboSched feature is disabled. Also provide get/put methods to keep

[RFC v4 1/8] sched/core: Add manual jitter classification using sched_setattr syscall

2019-07-25 Thread Parth Shah
Jitter tasks are short/bursty tasks, typically performing some housekeeping work and are less important in the overall scheme of things. So provide a way to mark the task as jitter with the use of additional flag to the existing task attribute. Also provide an interface from the userspace which

[RFC v4 4/8] sched/fair: Define core capacity to limit task packing

2019-07-25 Thread Parth Shah
Define a method name arch_scale_core_capacity which should return the capacity of the core. This method will be used in the future patches to determine if the spare capacity is left in the core to pack jitter tasks. For some architectures, core capacity does not increase much with the number of

[RFC v4 8/8] powerpc: Set turbo domain to NUMA node for task packing

2019-07-25 Thread Parth Shah
Provide an powerpc architecture specific implementation for defining the turbo domain to make searching of the core to be bound within the NUMA. This provides a way to decrease the searching time for specific architectures where we know the domain for the power budget. Signed-off-by: Parth Shah

[RFC v4 0/8] TurboSched: A scheduler for sustaining Turbo Frequencies for longer durations

2019-07-25 Thread Parth Shah
This is the 4th version of the patchset to sustain Turbo frequencies for longer durations. The previous versions can be found here: v3: https://lkml.org/lkml/2019/6/25/25 v2: https://lkml.org/lkml/2019/5/15/1258 v1: https://lwn.net/Articles/783959/ The changes in this versions are: v[3] -> v[4]:

Re: [PATCH] modules: always page-align module section allocations

2019-07-25 Thread Bartosz Golaszewski
śr., 24 lip 2019 o 17:02 Jessica Yu napisał(a): > > Some arches (e.g., arm64, x86) have moved towards non-executable > module_alloc() allocations for security hardening reasons. That means > that the module loader will need to set the text section of a module to > executable, regardless of

[PATCH 4.19 020/271] media: vpss: fix a potential NULL pointer dereference

2019-07-25 Thread Greg Kroah-Hartman
[ Upstream commit e08f0761234def47961d3252eac09ccedfe4c6a0 ] In case ioremap fails, the fix returns -ENOMEM to avoid NULL pointer dereference. Signed-off-by: Kangjie Lu Acked-by: Lad, Prabhakar Reviewed-by: Mukesh Ojha Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Sasha Levin ---

[PATCH 5.1 322/371] perf/x86/intel: Fix spurious NMI on fixed counter

2019-07-25 Thread Greg Kroah-Hartman
From: Kan Liang commit e4557c1a46b0d32746bd309e1941914b5a6912b4 upstream. If a user first sample a PEBS event on a fixed counter, then sample a non-PEBS event on the same fixed counter on Icelake, it will trigger spurious NMI. For example: perf record -e 'cycles:p' -a perf record -e

[PATCH 4.19 224/271] perf/x86/intel: Fix spurious NMI on fixed counter

2019-07-25 Thread Greg Kroah-Hartman
From: Kan Liang commit e4557c1a46b0d32746bd309e1941914b5a6912b4 upstream. If a user first sample a PEBS event on a fixed counter, then sample a non-PEBS event on the same fixed counter on Icelake, it will trigger spurious NMI. For example: perf record -e 'cycles:p' -a perf record -e

[PATCH 5.2 024/413] media: vpss: fix a potential NULL pointer dereference

2019-07-25 Thread Greg Kroah-Hartman
[ Upstream commit e08f0761234def47961d3252eac09ccedfe4c6a0 ] In case ioremap fails, the fix returns -ENOMEM to avoid NULL pointer dereference. Signed-off-by: Kangjie Lu Acked-by: Lad, Prabhakar Reviewed-by: Mukesh Ojha Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Sasha Levin ---

[PATCH 5.2 091/413] media: davinci: vpif_capture: fix memory leak in vpif_probe()

2019-07-25 Thread Greg Kroah-Hartman
[ Upstream commit 64f883cd98c6d43013fb0cea788b63e50ebc068c ] If vpif_probe() fails on v4l2_device_register() and vpif_probe_complete(), then memory allocated at initialize_vpif() for global vpif_obj.dev[i] become unreleased. The patch adds deallocation of vpif_obj.dev[i] on the error path.

[PATCH 5.2 354/413] perf/x86/intel: Fix spurious NMI on fixed counter

2019-07-25 Thread Greg Kroah-Hartman
From: Kan Liang commit e4557c1a46b0d32746bd309e1941914b5a6912b4 upstream. If a user first sample a PEBS event on a fixed counter, then sample a non-PEBS event on the same fixed counter on Icelake, it will trigger spurious NMI. For example: perf record -e 'cycles:p' -a perf record -e

[PATCH 5.1 028/371] media: vpss: fix a potential NULL pointer dereference

2019-07-25 Thread Greg Kroah-Hartman
[ Upstream commit e08f0761234def47961d3252eac09ccedfe4c6a0 ] In case ioremap fails, the fix returns -ENOMEM to avoid NULL pointer dereference. Signed-off-by: Kangjie Lu Acked-by: Lad, Prabhakar Reviewed-by: Mukesh Ojha Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Sasha Levin ---

[PATCH 5.1 084/371] media: davinci: vpif_capture: fix memory leak in vpif_probe()

2019-07-25 Thread Greg Kroah-Hartman
[ Upstream commit 64f883cd98c6d43013fb0cea788b63e50ebc068c ] If vpif_probe() fails on v4l2_device_register() and vpif_probe_complete(), then memory allocated at initialize_vpif() for global vpif_obj.dev[i] become unreleased. The patch adds deallocation of vpif_obj.dev[i] on the error path.

[PATCH 1/2] treewide: add "WITH Linux-syscall-note" to SPDX tag of uapi headers

2019-07-25 Thread Masahiro Yamada
UAPI headers licensed under GPL are supposed to have exception "WITH Linux-syscall-note" so that they can be included into non-GPL user space application code. The exception note is missing in some UAPI headers. Some of them slipped in by the treewide conversion commit b24413180f56 ("License

[PATCH 2/2] treewide: remove SPDX "WITH Linux-syscall-note" from kernel-space headers again

2019-07-25 Thread Masahiro Yamada
The "WITH Linux-syscall-note" exception exists for headers exported to user space. It is strange to add it to non-exported headers. Commit 687a3e4d8e61 ("treewide: remove SPDX "WITH Linux-syscall-note" from kernel-space headers") did cleanups some months ago, but it looks like we need to do this

Re: [PATCH v12 1/5] can: m_can: Create a m_can platform framework

2019-07-25 Thread Greg KH
On Wed, Jul 24, 2019 at 10:36:02AM -0500, Dan Murphy wrote: > Hello > > On 7/24/19 1:47 AM, Greg KH wrote: > > On Tue, Jul 23, 2019 at 10:14:14AM -0500, Dan Murphy wrote: > > > Hello > > > > > > On 7/10/19 7:08 AM, Dan Murphy wrote: > > > > Hello > > > > > > > > On 6/17/19 10:09 AM, Dan Murphy

Re: [HELP REQUESTED from the community] Was: Staging status of speakup

2019-07-25 Thread Greg Kroah-Hartman
On Thu, Jul 25, 2019 at 08:11:04AM +0200, Willem van der Walt wrote: > Hi, > I have added a few things inline in Greg's message, mainly regarding the > bleeps and cursor_time. This is a great start, can someone turn this into the correct format that we need for Documentation/ABI/ ? thanks, greg

Re: [PATCH v3 1/2] x86/mm: Identify the end of the kernel area to be reserved

2019-07-25 Thread Greg KH
On Wed, Jul 24, 2019 at 10:20:34PM +0200, Thomas Gleixner wrote: > On Wed, 24 Jul 2019, Thomas Gleixner wrote: > > > On Wed, 24 Jul 2019, Greg KH wrote: > > > On Wed, Jul 24, 2019 at 06:03:41PM +0200, Thomas Gleixner wrote: > > > > > Gotta love old tool-chains :( > > > > > > > > Oh yes. /me does

Re: [PATCH 5.2 038/413] signal/cifs: Fix cifs_put_tcp_session to call send_sig instead of force_sig

2019-07-25 Thread Greg Kroah-Hartman
On Wed, Jul 24, 2019 at 03:49:32PM -0500, Steve French wrote: > Note that this patch causes a regression (removing cifs module fails, > due to unmount leaking a thread with this change). > > We are testing a workaround to cifs.ko which would be needed if this > patch were to be backported. I've

Re: [PATCH net] net: hns: fix LED configuration for marvell phy

2019-07-25 Thread liuyonglong
On 2019/7/25 12:28, Andrew Lunn wrote: > On Thu, Jul 25, 2019 at 11:00:08AM +0800, liuyonglong wrote: >>> Revert "net: hns: fix LED configuration for marvell phy" >>> This reverts commit f4e5f775db5a4631300dccd0de5eafb50a77c131. >>> >>> Andrew Lunn says this should be handled another way. >>>

[RFC] mm/debug: Add tests for architecture exported page table helpers

2019-07-25 Thread Anshuman Khandual
This series adds a test validation for architecture exported page table helpers. Patch in the series add basic transformation tests at various level of the page table. This test was originally suggested by Catalin during arm64 THP migration RFC discussion earlier. Going forward it can include

[RFC] mm/pgtable/debug: Add test validating architecture page table helpers

2019-07-25 Thread Anshuman Khandual
This adds a test module which will validate architecture page table helpers and accessors regarding compliance with generic MM semantics expectations. This will help various architectures in validating changes to the existing page table helpers or addition of new ones. Cc: Andrew Morton Cc:

[PATCH] extcon: max77843: Add IRQ_ONESHOT mask

2019-07-25 Thread Vasyl Gomonovych
Do not fire irq again until thread done This issue was found by code inspection Coccicheck irqf_oneshot.cocci Signed-off-by: Vasyl Gomonovych --- drivers/extcon/extcon-max77843.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/extcon/extcon-max77843.c

[PATCH 1/1] dt-bindings: power/supply/sbs_sbs-battery: Addition of force_load binding Add device tree binding documentation for addition of force_load boolean value to allow loading a battery during b

2019-07-25 Thread Richard Tresidder
Signed-off-by: Richard Tresidder --- Notes: Add device tree binding documentation for addition of force_load boolean value to allow loading a battery during boot even if not present at that time. Accompanying patch to drivers/power/supply/sbs-battery.c submitted to

Re: [PATCH 1/1] x86/boot: clear some fields explicitly

2019-07-25 Thread John Hubbard
On 7/24/19 7:12 PM, h...@zytor.com wrote: On July 24, 2019 4:15:28 PM PDT, john.hubb...@gmail.com wrote: From: John Hubbard ... + boot_params->ext_ramdisk_image = 0; + boot_params->ext_ramdisk_size = 0; + boot_params->ext_cmd_line_ptr = 0; + +

Re: [PATCH 11/12] staging: media: cedrus: Fix misuse of GENMASK macro

2019-07-25 Thread Hans Verkuil
On 7/24/19 7:09 PM, Joe Perches wrote: > On Tue, 2019-07-09 at 22:04 -0700, Joe Perches wrote: >> Arguments are supposed to be ordered high then low. >> >> Signed-off-by: Joe Perches >> --- >> drivers/staging/media/sunxi/cedrus/cedrus_regs.h | 2 +- >> 1 file changed, 1 insertion(+), 1

Re: [PATCH 1/2] /proc/kpageflags: prevent an integer overflow in stable_page_flags()

2019-07-25 Thread Alexey Dobriyan
On Thu, Jul 25, 2019 at 02:31:16AM +, Toshiki Fukasawa wrote: > stable_page_flags() returns kpageflags info in u64, but it uses > "1 << KPF_*" internally which is considered as int. This type mismatch > causes no visible problem now, but it will if you set bit 32 or more as > done in a

[PATCH] extcon: max8997: Use irq mask IRQF_ONESHOT

2019-07-25 Thread Vasyl Gomonovych
Do not fire irq again until thread done This issue was found by code inspection Coccicheck irqf_oneshot.cocci Signed-off-by: Vasyl Gomonovych --- drivers/extcon/extcon-max8997.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/extcon/extcon-max8997.c

[PATCH] extcon: max14577: Add irq mask IRQ_ONESHOT

2019-07-25 Thread Vasyl Gomonovych
Do not fire irq again until thread done This issue was found by code inspection Coccicheck irqf_oneshot.cocci Signed-off-by: Vasyl Gomonovych --- drivers/extcon/extcon-max14577.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/extcon/extcon-max14577.c

[tip:core/urgent] objtool: Improve UACCESS coverage

2019-07-25 Thread tip-bot for Peter Zijlstra
Commit-ID: 882a0db9d143e5e8dac54b96e83135bccd1f68d1 Gitweb: https://git.kernel.org/tip/882a0db9d143e5e8dac54b96e83135bccd1f68d1 Author: Peter Zijlstra AuthorDate: Wed, 24 Jul 2019 17:47:26 -0500 Committer: Thomas Gleixner CommitDate: Thu, 25 Jul 2019 08:36:39 +0200 objtool: Improve

[PATCH] extcon: max77693: Add extra IRQF_ONESHOT

2019-07-25 Thread Vasyl Gomonovych
Do not fire irq again until thread done This issue was found by code inspection Coccicheck irqf_oneshot.cocci Signed-off-by: Vasyl Gomonovych --- drivers/extcon/extcon-max77693.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/extcon/extcon-max77693.c

[PATCH] iio: adc: sc27xx: Change to polling mode to read data

2019-07-25 Thread Baolin Wang
From: Freeman Liu On Spreadtrum platform, the headphone will read one ADC channel multiple times to identify the headphone type, and the headphone identification is sensitive of the ADC reading time. And we found it will take longer time to reading ADC data by using interrupt mode comparing with

Re: [BUG] Linux 5.3-rc1: timer problem on x86-64 (Pentium D)

2019-07-25 Thread Thomas Gleixner
Rui, On Thu, 25 Jul 2019, Rui Salvaterra wrote: > Looks like we have a winner. Actually, I did a full bisection between > 5.2 and 5.3-rc1. Full log follows: > > git bisect start > # good: [0ecfebd2b52404ae0c54a878c872bb93363ada36] Linux 5.2 > git bisect good

[PATCH] kprobes: Allow kprobes coexist with livepatch

2019-07-25 Thread Masami Hiramatsu
Allow kprobes which do not modify regs->ip, coexist with livepatch by dropping FTRACE_OPS_FL_IPMODIFY from ftrace_ops. User who wants to modify regs->ip (e.g. function fault injection) must set a dummy post_handler to its kprobes when registering. However, if such regs->ip modifying kprobes is

Re: [PATCH 2/2] DTS: ARM: gta04: introduce legacy spi-cs-high to make display work again

2019-07-25 Thread H. Nikolaus Schaller
Hi Rob, > Am 24.07.2019 um 21:42 schrieb Rob Herring : > > On Mon, Jul 08, 2019 at 04:46:05PM +0200, H. Nikolaus Schaller wrote: >> commit 6953c57ab172 "gpio: of: Handle SPI chipselect legacy bindings" >> >> did introduce logic to centrally handle the legacy spi-cs-high property >> in

Re: [PATCH v6] driver core: Fix use-after-free and double free on glue directory

2019-07-25 Thread Prateek Sood
On 7/24/19 9:30 PM, Muchun Song wrote: > There is a race condition between removing glue directory and adding a new > device under the glue directory. It can be reproduced in following test: > > path 1: Add the child device under glue dir > device_add() > get_device_parent() >

Re: [PATCH REBASE v4 11/14] mips: Adjust brk randomization offset to fit generic version

2019-07-25 Thread Alexandre Ghiti
On 7/24/19 7:58 AM, Alexandre Ghiti wrote: This commit simply bumps up to 32MB and 1GB the random offset of brk, compared to 8MB and 256MB, for 32bit and 64bit respectively. Suggested-by: Kees Cook Signed-off-by: Alexandre Ghiti Reviewed-by: Kees Cook --- arch/mips/mm/mmap.c | 7 ---

Re: [EXTERNAL][PATCH REBASE v4 00/14] Provide generic top-down mmap layout functions

2019-07-25 Thread Alexandre Ghiti
On 7/24/19 10:18 PM, Paul Burton wrote: Hi Alexandre, On Wed, Jul 24, 2019 at 01:58:36AM -0400, Alexandre Ghiti wrote: Hi Andrew, This is simply a rebase on top of next-20190719, where I added various Acked/Reviewed-by from Kees and Catalin and a note on commit 08/14 suggested by Kees

Re: [PATCH 4.4 stable net] net: tcp: Fix use-after-free in tcp_write_xmit

2019-07-25 Thread Eric Dumazet
On 7/25/19 6:29 AM, maowenan wrote: > > Syzkaller reproducer(): > r0 = socket$packet(0x11, 0x3, 0x300) > r1 = socket$inet_tcp(0x2, 0x1, 0x0) > bind$inet(r1, &(0x7f000300)={0x2, 0x4e21, @multicast1}, 0x10) > connect$inet(r1, &(0x7f000140)={0x2, 0x104e21,

Re: kernel BUG at mm/swap_state.c:170!

2019-07-25 Thread Mikhail Gavrilov
On Tue, 23 Jul 2019 at 10:08, Huang, Ying wrote: > > Thanks! I have found another (easier way) to reproduce the panic. > Could you try the below patch on top of v5.2-rc2? It can fix the panic > for me. > Thanks! Amazing work! The patch fixes the issue completely. The system worked at a high

Re: x86 - clang / objtool status

2019-07-25 Thread Sedat Dilek
On Mon, Jul 22, 2019 at 5:40 PM Sedat Dilek wrote: > > On Fri, Jul 19, 2019 at 3:48 PM Sedat Dilek wrote: > > > > > First of all I find out that it is possible to download and apply the > > > series (here: v2) from patchwork (see [1]). > > > I highly appreciate to have this in Josh's Git [2]. >

Re: [HELP REQUESTED from the community] Was: Staging status of speakup

2019-07-25 Thread Willem van der Walt
Hi, I have added a few things inline in Greg's message, mainly regarding the bleeps and cursor_time. FWIW, Willem On Wed, 24 Jul 2019, Gregory Nowak wrote: [The e-mail server of the sender could not be verified (SPF Record)] On Fri, Jul 12, 2019 at 05:46:23PM -0700, Gregory Nowak wrote: On

Re: [PATCH 1/2] drm/i915: Remove redundant user_access_end() from __copy_from_user() error path

2019-07-25 Thread Sedat Dilek
On Thu, Jul 25, 2019 at 12:48 AM Josh Poimboeuf wrote: > > Objtool reports: > > drivers/gpu/drm/i915/gem/i915_gem_execbuffer.o: warning: objtool: > .altinstr_replacement+0x36: redundant UACCESS disable > > __copy_from_user() already does both STAC and CLAC, so the > user_access_end() in its

Re: [PATCH REBASE v4 00/14] Provide generic top-down mmap layout functions

2019-07-25 Thread Alexandre Ghiti
On 7/24/19 7:17 PM, Luis Chamberlain wrote: Other than the two comments: Reviewed-by: Luis Chamberlain Thanks for your time Luis, Alex Luis

Re: [PATCH 11/14] PCI/P2PDMA: dma_map P2PDMA map requests that traverse the host bridge

2019-07-25 Thread Christoph Hellwig
On Wed, Jul 24, 2019 at 09:58:59AM -0600, Logan Gunthorpe wrote: > > > On 2019-07-24 12:32 a.m., Christoph Hellwig wrote: > >>struct dev_pagemap *pgmap = sg_page(sg)->pgmap; > >> + struct pci_dev *client; > >> + int dist; > >> + > >> + client = find_parent_pci_dev(dev); > >> + if

Re: [PATCH REBASE v4 12/14] mips: Replace arch specific way to determine 32bit task with generic version

2019-07-25 Thread Alexandre Ghiti
On 7/24/19 7:16 PM, Luis Chamberlain wrote: On Wed, Jul 24, 2019 at 01:58:48AM -0400, Alexandre Ghiti wrote: Mips uses TASK_IS_32BIT_ADDR to determine if a task is 32bit, but this define is mips specific and other arches do not have it: instead, use !IS_ENABLED(CONFIG_64BIT) || is_compat_task()

<    6   7   8   9   10   11   12   >