Re: [PATCH] linux/bits.h: Add compile time sanity check of GENMASK inputs

2019-07-31 Thread Joe Perches
On Wed, 2019-07-31 at 21:03 +0200, Rikard Falkeborn wrote: > GENMASK() and GENMASK_ULL() are supposed to be called with the high bit > as the first argument and the low bit as the second argument. Mixing > them will return a mask with zero bits set. > > Recent commits show getting this wrong is no

Re: [PATCH] watchdog:alim1535_wdt: Fix data race in ali_settimer() concerning ali_timeout_bits variable.

2019-07-31 Thread Guenter Roeck
Mark, On Wed, Jul 31, 2019 at 11:23:19AM -0700, Mark Balantzyan wrote: > Hi Guenter, all, > > It's alright if you still don't wish to review my patch on alim1535_wdt, but > my employer and I, using our race condition analysis tool, detected it to > contain a race condition warning. I believe any

Re: [PATCH V2] IB/core: Add mitigation for Spectre V1

2019-07-31 Thread Doug Ledford
On Wed, 2019-07-31 at 14:52 -0400, Doug Ledford wrote: > On Wed, 2019-07-31 at 12:52 -0500, Gustavo A. R. Silva wrote: > > This is insufficient. The speculation windows are large: > > > > "Speculative execution on modern CPUs can run several > > hundred instructions ahead." [1] > > > > [

[PATCH] tomoyo: common: Fix potential Spectre v1 vulnerability

2019-07-31 Thread Gustavo A. R. Silva
profile is controlled by user-space via /sys/kernel/security/tomoyo/profile, hence leading to a potential exploitation of the Spectre variant 1 vulnerability. This issue was detected with the help of Smatch: security/tomoyo/common.c:498 tomoyo_assign_profile() warn: potential spectre issue 'ns->

Re: [PATCH v10 3/4] mm, thp: introduce FOLL_SPLIT_PMD

2019-07-31 Thread Song Liu
> On Jul 31, 2019, at 8:18 AM, Oleg Nesterov wrote: > > On 07/30, Song Liu wrote: >> >> >>> On Jul 30, 2019, at 9:11 AM, Oleg Nesterov wrote: >>> >>> So after the next patch we have a single user of FOLL_SPLIT_PMD (uprobes) >>> and a single user of FOLL_SPLIT: arch/s390/mm/gmap.c:thp_split

Re: [PATCH 4.19 077/113] f2fs: avoid out-of-range memory access

2019-07-31 Thread Pavel Machek
Hi! > [ Upstream commit 56f3ce675103e3fb9e631cfb4131fc768bc23e9a ] > > blkoff_off might over 512 due to fs corrupt or security > vulnerability. That should be checked before being using. > > Use ENTRIES_IN_SUM to protect invalid value in cur_data_blkoff. > > Signed-off-by: Ocean Chen > Reviewe

Re: [PATCH bpf-next v10 06/10] bpf,landlock: Add a new map type: inode

2019-07-31 Thread Mickaël Salaün
On 31/07/2019 20:58, Alexei Starovoitov wrote: > On Wed, Jul 31, 2019 at 11:46 AM Mickaël Salaün > wrote: +for (i = 0; i < htab->n_buckets; i++) { +head = select_bucket(htab, i); +hlist_nulls_for_each_entry_safe(l, n, head, hash_node) { +

Re: [PATCH] regulator: of: Add of_node_put() before return in function

2019-07-31 Thread Mark Brown
On Wed, Jul 31, 2019 at 06:41:03PM +0530, Nishka Dasgupta wrote: > My added code is dropping a reference to search, using of_node_put(). > I'm probably misunderstanding this at some point, but I thought search and > child are two different nodes? Or am I completely misunderstanding what > you're e

Re: [PATCH v4 6/9] leds: multicolor: Introduce a multicolor class definition

2019-07-31 Thread Dan Murphy
Jacek On 7/29/19 3:50 PM, Jacek Anaszewski wrote: Dan, On 7/25/19 8:28 PM, Dan Murphy wrote: Introduce a multicolor class that groups colored LEDs within a LED node. The framework allows for dynamically setting individual LEDs or setting brightness levels of LEDs and updating them virtually s

Re: [PATCH v2 2/2] interconnect: qcom: Add tagging and wake/sleep support for sdm845

2019-07-31 Thread Evan Green
On Tue, Jul 30, 2019 at 5:37 PM David Dai wrote: > > > On 7/30/2019 3:54 PM, Evan Green wrote: > > On Thu, Jul 18, 2019 at 10:59 AM David Dai wrote: > >> On 7/16/2019 1:15 PM, Evan Green wrote: > >>> On Mon, Jul 15, 2019 at 4:34 PM David Dai > >>> wrote: > Hi Evan, > > Thanks for

Re: [PATCH 4.19 024/113] tty: serial: msm_serial: avoid system lockup condition

2019-07-31 Thread Pavel Machek
Hi! > [ Upstream commit ba3684f99f1b25d2a30b6956d02d339d7acb9799 ] > > The function msm_wait_for_xmitr can be taken with interrupts > disabled. In order to avoid a potential system lockup - demonstrated > under stress testing conditions on SoC QCS404/5 - make sure we wait > for a bounded amount o

[PATCH] linux/bits.h: Add compile time sanity check of GENMASK inputs

2019-07-31 Thread Rikard Falkeborn
GENMASK() and GENMASK_ULL() are supposed to be called with the high bit as the first argument and the low bit as the second argument. Mixing them will return a mask with zero bits set. Recent commits show getting this wrong is not uncommon, see e.g. commit aa4c0c9091b0 ("net: stmmac: Fix misuses o

[PATCH] net/mlx5e: always initialize frag->last_in_page

2019-07-31 Thread Qian Cai
The commit 069d11465a80 ("net/mlx5e: RX, Enhance legacy Receive Queue memory scheme") introduced an undefined behaviour below due to "frag->last_in_page" is only initialized in mlx5e_init_frags_partition() when, if (next_frag.offset + frag_info[f].frag_stride > PAGE_SIZE) or after bailed out the

Re: [PATCH bpf-next v10 06/10] bpf,landlock: Add a new map type: inode

2019-07-31 Thread Alexei Starovoitov
On Wed, Jul 31, 2019 at 11:46 AM Mickaël Salaün wrote: > >> +for (i = 0; i < htab->n_buckets; i++) { > >> +head = select_bucket(htab, i); > >> +hlist_nulls_for_each_entry_safe(l, n, head, hash_node) { > >> +landlock_inode_remove_map(*((struct inode *

[PATCH v2 2/2] KVM: no need to check return value of debugfs_create functions

2019-07-31 Thread Greg KH
When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this. Also, when doing this, change kvm_arch_create_vcpu_debugfs() to return void instead of an integer, as we should not

[PATCH v2 1/2] KVM: remove kvm_arch_has_vcpu_debugfs()

2019-07-31 Thread Greg KH
There is no need for this function as all arches have to implement kvm_arch_create_vcpu_debugfs() no matter what, so just remove this call as it is pointless. Cc: Paolo Bonzini Cc: "Radim Krm" Cc: Thomas Gleixner Cc: Ingo Molnar Cc: Borislav Petkov Cc: "H. Peter Anvin" Cc: Cc: Signed-off-b

Re: [PATCH v4 9/9] leds: Update the lp55xx to use the multi color framework

2019-07-31 Thread Dan Murphy
Jacek Thanks for looking On 7/31/19 1:45 PM, Jacek Anaszewski wrote: Hi Dan, Thank you for the patch. My comments are below. On 7/25/19 8:28 PM, Dan Murphy wrote: Update the lp5523 to use the multi color framework. Signed-off-by: Dan Murphy --- drivers/leds/leds-lp5523.c|

Re: [PATCH V2] IB/core: Add mitigation for Spectre V1

2019-07-31 Thread Doug Ledford
On Wed, 2019-07-31 at 12:52 -0500, Gustavo A. R. Silva wrote: > This is insufficient. The speculation windows are large: > > "Speculative execution on modern CPUs can run several > hundred instructions ahead." [1] > > [1] https://spectreattack.com/spectre.pdf Thanks, I'll take a look at

[git pull] vfs.git mount_capable() fix

2019-07-31 Thread Al Viro
Since nobody gave any specific objections and the thing appears to work... The following changes since commit 19a1c4092e7ca1ad1a72ac5535f902c483372cd5: fix the struct mount leak in umount_tree() (2019-07-26 07:59:06 -0400) are available in the git repository at: git://git.kernel.org

Re: [PATCH v6 40/57] soc: Remove dev_err() usage after platform_get_irq()

2019-07-31 Thread Li Yang
On Tue, Jul 30, 2019 at 10:01 PM Stephen Boyd wrote: > > Quoting Leo Li (2019-07-30 14:26:01) > > > > The patch looks good to me too. I can take it through my tree with your > > reviewed-by. > > > > I split it for you just in case you want different patches. > Thanks. I will take the fsl/nxp p

Re: [RFC PATCH] compiler_attributes.h: Add 'fallthrough' pseudo keyword for switch/case use

2019-07-31 Thread Peter Zijlstra
On Wed, Jul 31, 2019 at 11:24:36AM -0700, h...@zytor.com wrote: > >> > +/* > >> > + * Add the pseudo keyword 'fallthrough' so case statement blocks > >> > + * must end with any of these keywords: > >> > + * break; > >> > + * fallthrough; > >> > + * goto ; > >> > + * return [expression]; > >

Re: [PATCH] vfio: re-arrange vfio region definitions

2019-07-31 Thread Auger Eric
Hi Connie, On 7/17/19 1:49 PM, Cornelia Huck wrote: > It is easy to miss already defined region types. Let's re-arrange > the definitions a bit and add more comments to make it hopefully > a bit clearer. > > No functional change. > > Signed-off-by: Cornelia Huck > --- > include/uapi/linux/vfio

Re: [PATCH bpf-next v10 06/10] bpf,landlock: Add a new map type: inode

2019-07-31 Thread Mickaël Salaün
On 27/07/2019 03:40, Alexei Starovoitov wrote: > On Sun, Jul 21, 2019 at 11:31:12PM +0200, Mickaël Salaün wrote: >> FIXME: 64-bits in the doc FYI, this FIXME was fixed, just not removed from this message. :) >> >> This new map store arbitrary values referenced by inode keys. The map >> can be

Re: [PATCH v4 8/9] leds: lp50xx: Add the LP50XX family of the RGB LED driver

2019-07-31 Thread Dan Murphy
Jacek Thanks for looking at the patch On 7/30/19 4:24 PM, Jacek Anaszewski wrote: Hi Dan, Thank you for the patch I see few things to improve. On 7/25/19 8:28 PM, Dan Murphy wrote: Introduce the LP5036/30/24/18 RGB LED driver. The difference in these parts are the number of LED outputs wher

Re: [PATCH v4 9/9] leds: Update the lp55xx to use the multi color framework

2019-07-31 Thread Jacek Anaszewski
Hi Dan, Thank you for the patch. My comments are below. On 7/25/19 8:28 PM, Dan Murphy wrote: > Update the lp5523 to use the multi color framework. > > Signed-off-by: Dan Murphy > --- > drivers/leds/leds-lp5523.c| 13 ++ > drivers/leds/leds-lp55xx-common.c | 153 ++

Re: [PATCH] thermal: rcar_gen3_thermal: Use devm_add_action_or_reset() helper

2019-07-31 Thread Niklas Söderlund
Hi Geert, Thanks for your work. On 2019-07-31 14:50:53 +0200, Geert Uytterhoeven wrote: > Use the devm_add_action_or_reset() helper instead of open-coding the > same operations. > > Signed-off-by: Geert Uytterhoeven Reviewed-by: Niklas Söderlund > --- > drivers/thermal/rcar_gen3_thermal.c |

Re: [PATCH 1/2] mips: remove nargs from __SYSCALL

2019-07-31 Thread Paul Burton
Hello, Firoz Khan wrote: > The __SYSCALL macro's arguments are system call number, > system call entry name and number of arguments for the > system call. > > Argument- nargs in __SYSCALL(nr, entry, nargs) is neither > calculated nor used anywhere. So it would be better to > keep the implementaio

Re: [PATCH v10 05/22] mips: mm: Add p?d_leaf() definitions

2019-07-31 Thread Paul Burton
Hi Steven, On Wed, Jul 31, 2019 at 04:45:46PM +0100, Steven Price wrote: > walk_page_range() is going to be allowed to walk page tables other than > those of user space. For this it needs to know when it has reached a > 'leaf' entry in the page tables. This information is provided by the > p?d_lea

[PATCH] staging:kpc2000:Fix dubious x | !y sparse warning

2019-07-31 Thread Harsh Jain
Bitwise OR(|) operation with 0 always yield same result. It fixes dubious x | !y sparse warning. Signed-off-by: Harsh Jain --- drivers/staging/kpc2000/kpc2000_i2c.c | 16 +--- 1 file changed, 1 insertion(+), 15 deletions(-) diff --git a/drivers/staging/kpc2000/kpc2000_i2c.c b/drive

[PATCH v2 1/2] khugepaged: enable collapse pmd for pte-mapped THP

2019-07-31 Thread Song Liu
khugepaged needs exclusive mmap_sem to access page table. When it fails to lock mmap_sem, the page will fault in as pte-mapped THP. As the page is already a THP, khugepaged will not handle this pmd again. This patch enables the khugepaged to retry collapse the page table. struct mm_slot (in khuge

[PATCH v2 2/2] uprobe: collapse THP pmd after removing all uprobes

2019-07-31 Thread Song Liu
After all uprobes are removed from the huge page (with PTE pgtable), it is possible to collapse the pmd and benefit from THP again. This patch does the collapse by calling collapse_pte_mapped_thp(). Signed-off-by: Song Liu --- kernel/events/uprobes.c | 9 + 1 file changed, 9 insertions(+

[PATCH v2 0/2] khugepaged: collapse pmd for pte-mapped THP

2019-07-31 Thread Song Liu
Changes v1 => v2: 1. Call collapse_pte_mapped_thp() directly from uprobe_write_opcode(); 2. Add VM_BUG_ON() for addr alignment in khugepaged_add_pte_mapped_thp() and collapse_pte_mapped_thp(). This set is the newer version of 5/6 and 6/6 of [1]. Newer version of 1-4 of the work [2] was recently

[PATCH net] mvpp2: fix panic on module removal

2019-07-31 Thread Matteo Croce
mvpp2 uses a delayed workqueue to gather traffic statistics. On module removal the workqueue can be destroyed before calling cancel_delayed_work_sync() on its works. Fix it by moving the destroy_workqueue() call after mvpp2_port_remove(). # rmmod mvpp2 [ 2743.311722] mvpp2 f400.etherne

Re: [PATCH V2 7/9] vhost: do not use RCU to synchronize MMU notifier with worker

2019-07-31 Thread Michael S. Tsirkin
On Wed, Jul 31, 2019 at 04:46:53AM -0400, Jason Wang wrote: > We used to use RCU to synchronize MMU notifier with worker. This leads > calling synchronize_rcu() in invalidate_range_start(). But on a busy > system, there would be many factors that may slow down the > synchronize_rcu() which makes it

[PATCH v3 1/2] clk: qcom: rcg2: Add support for display port clock ops

2019-07-31 Thread Taniya Das
New display port clock ops supported for display port clocks. Signed-off-by: Taniya Das --- drivers/clk/qcom/Kconfig| 1 + drivers/clk/qcom/clk-rcg.h | 1 + drivers/clk/qcom/clk-rcg2.c | 77 + 3 files changed, 79 insertions(+) diff --git a/drivers/clk/

[PATCH v3 2/2] clk: qcom : dispcc: Add support for display port clocks

2019-07-31 Thread Taniya Das
SDM845 dispcc supports RCG and CBCRs for display port, so add support for the same. Signed-off-by: Taniya Das --- drivers/clk/qcom/dispcc-sdm845.c | 214 +- .../dt-bindings/clock/qcom,dispcc-sdm845.h| 13 +- 2 files changed, 225 insertions(+), 2 deletions(-) di

[PATCH v3 0/2] Add support for display port clocks and clock ops

2019-07-31 Thread Taniya Das
[v3] * Update KCONFIG select in alphabetical order. * Remove pr_err in set rate. * Fix/update code indentation and logic. * removal of CLK_GET_RATE_NOCACHE completely from RCGs. [v2] * Update KCONFIG to select RATIONAL * Clean up redundant code from dp_set_rate/dp_set_rate_and_

Re: [RFC PATCH] compiler_attributes.h: Add 'fallthrough' pseudo keyword for switch/case use

2019-07-31 Thread hpa
On July 31, 2019 10:51:37 AM PDT, Joe Perches wrote: >On Wed, 2019-07-31 at 19:14 +0200, Pavel Machek wrote: >> On Tue 2019-07-30 22:35:18, Joe Perches wrote: >> > Reserve the pseudo keyword 'fallthrough' for the ability to convert >the >> > various case block /* fallthrough */ style comments to a

[Patch v2 10/10] staging: rtl8723bs: core: Remove Macro "IS_MAC_ADDRESS_BROADCAST"

2019-07-31 Thread Hariprasad Kelam
Remove unused macro IS_MAC_ADDRESS_BROADCAST. In future if one wants use it ,use generic API "is_broadcast_ether_addr" Signed-off-by: Hariprasad Kelam --- v2 - Add patch number drivers/staging/rtl8723bs/core/rtw_ioctl_set.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/drivers/stagi

[PATCH v4 7/8] recordmcount: Remove redundant cleanup() calls

2019-07-31 Thread Matt Helsley
Redundant cleanup calls were introduced when transitioning from the old error/success handling via setjmp/longjmp -- the longjmp ensured the cleanup() call only happened once but replacing the success_file()/fail_file() calls with cleanup() meant that multiple cleanup() calls can happen as we retur

[PATCH v4 8/8] recordmcount: Clarify what cleanup() does

2019-07-31 Thread Matt Helsley
cleanup() mostly frees/unmaps the malloc'd/privately-mapped copy of the ELF file recordmcount is working on, which is set up in mmap_file(). It also deals with positioning within the pseduo prive-mapping of the file and appending to the ELF file. Split into two steps: mmap_cleanup() for th

[PATCH v4 5/8] recordmcount: Kernel style function signature formatting

2019-07-31 Thread Matt Helsley
The uwrite() and ulseek() functions are formatted inconsistently with the rest of the file and the kernel overall. While we're making other changes here let's fix this. Signed-off-by: Matt Helsley --- scripts/recordmcount.c | 21 +++-- scripts/recordmcount.h | 13 ++--- 2

[PATCH v4 4/8] recordmcount: Rewrite error/success handling

2019-07-31 Thread Matt Helsley
Recordmcount uses setjmp/longjmp to manage control flow as it reads and then writes the ELF file. This unusual control flow is hard to follow and check in addition to being unlike kernel coding style. So we rewrite these paths to use regular return values to indicate error/success. When an error o

[PATCH v4 6/8] recordmcount: Kernel style formatting

2019-07-31 Thread Matt Helsley
Fix up the whitespace irregularity in the ELF switch blocks. Swapping the initial value of gpfx allows us to simplify all but one of the one-line switch cases even further. Signed-off-by: Matt Helsley --- scripts/recordmcount.c | 47 ++ 1 file changed, 25

[PATCH v4 3/8] recordmcount: Remove unused fd from uwrite() and ulseek()

2019-07-31 Thread Matt Helsley
uwrite() works within the pseudo-mapping and extends it as necessary without needing the file descriptor (fd) parameter passed to it. Similarly, ulseek() doesn't need its fd parameter. These parameters were only added because the functions bear a conceptual resemblance to write() and lseek(). Worse

[PATCH v4 2/8] recordmcount: Remove uread()

2019-07-31 Thread Matt Helsley
uread() is only used to initialize the ELF file's pseudo private-memory mapping while uwrite() and ulseek() work within the pseudo-mapping and extend it as necessary. Thus it is not a complementary function to uwrite() and ulseek(). It also makes no sense to do cleanups inside uread() when its onl

[PATCH v4 1/8] recordmcount: Remove redundant strcmp

2019-07-31 Thread Matt Helsley
The strcmp is unnecessary since .text is already accepted as a prefix in the strncmp(). Signed-off-by: Matt Helsley --- scripts/recordmcount.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/scripts/recordmcount.c b/scripts/recordmcount.c index 8387a9bc064a..ebe98c39f3cd 10

[PATCH v4 0/8] recordmcount cleanups

2019-07-31 Thread Matt Helsley
recordmcount presents unnecessary challenges to reviewers: It pretends to wrap access to the ELF file in uread/uwrite/ulseek functions which aren't related the way you might think (i.e. not the way read, write, and lseek are releated to each other). It uses

[Patch v2 09/10] staging: rtl8723bs: core: Remove unneeded variables sgi_20m,sgi_40m and sgi_80m

2019-07-31 Thread Hariprasad Kelam
htpriv.sgi_* variables are of type u8 ,instead of storing them in local variables ,its better to read value directly from structure. Signed-off-by: Hariprasad Kelam --- v2 - Add patch number drivers/staging/rtl8723bs/core/rtw_xmit.c | 11 --- 1 file changed, 4 insertions(+), 7 deletions

Re: [PATCH] watchdog:alim1535_wdt: Fix data race in ali_settimer() concerning ali_timeout_bits variable.

2019-07-31 Thread Mark Balantzyan
Hi Guenter, all, It's alright if you still don't wish to review my patch on alim1535_wdt, but my employer and I, using our race condition analysis tool, detected it to contain a race condition warning. I believe any possible issues could be resolved if it were rewritten to use the watchdog sub

[Patch v2 08/10] staging: rtl8723bs: core: Remove unneeded extern WFD_OUI

2019-07-31 Thread Hariprasad Kelam
Remove unneeded extern variable "extern unsigned char WFD_OUI" Signed-off-by: Hariprasad Kelam --- v2 - Add patch number drivers/staging/rtl8723bs/core/rtw_ap.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_ap.c b/drivers/staging/rtl8723bs/core/rtw_ap.c

[Patch v2 07/10] staging: rtl8723bs: Remove unneeded function argument for init_addba_retry_timer

2019-07-31 Thread Hariprasad Kelam
init_addba_retry_timer does not use padapter, so only keep psta Signed-off-by: Hariprasad Kelam --- v2 - Add patch number drivers/staging/rtl8723bs/core/rtw_sta_mgt.c | 2 +- drivers/staging/rtl8723bs/include/rtw_mlme_ext.h | 2 +- drivers/staging/rtl8723bs/os_dep/mlme_linux.c| 2 +- 3

Re: [PATCH 4.19 038/113] serial: mctrl_gpio: Check if GPIO property exisits before requesting it

2019-07-31 Thread Pavel Machek
Hi! > This patch implements the fix suggested by Mika in his statement above. > @@ -12,6 +12,7 @@ > #include > #include > #include > +#include > > #include "serial_mctrl_gpio.h" > > @@ -115,6 +116,19 @@ struct mctrl_gpios *mctrl_gpio_init_noauto(struct device > *dev, unsigned int idx

[Patch v2 06/10] staging: rtl8723bs: os_dep: Remove unused defines related to combo scan

2019-07-31 Thread Hariprasad Kelam
Remove below defines WEXT_CSCAN_AMOUNT WEXT_CSCAN_BUF_LEN WEXT_CSCAN_NPROBE_SECTION Signed-off-by: Hariprasad Kelam --- v2 - Add patch number drivers/staging/rtl8723bs/os_dep/ioctl_linux.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c b/dr

Re: "mm: account nr_isolated_xxx in [isolate|putback]_lru_page" breaks OOM with swap

2019-07-31 Thread Qian Cai
On Wed, 2019-07-31 at 12:09 -0400, Qian Cai wrote: > On Wed, 2019-07-31 at 14:34 +0900, Minchan Kim wrote: > > On Tue, Jul 30, 2019 at 12:25:28PM -0400, Qian Cai wrote: > > > OOM workloads with swapping is unable to recover with linux-next since > > > next- > > > 20190729 due to the commit "mm: acc

[Patch v2 05/10] staging: rtl8723bs: os_dep: Remove unused defines

2019-07-31 Thread Hariprasad Kelam
Remove below unused defines RTW_CH_MAX_2G_CHANNEL rtw_a_rates RTW_A_RATES_NUM RTW_5G_CHANNELS_NUM Signed-off-by: Hariprasad Kelam --- v2 - Add patch number drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/staging/rtl8723bs/os_dep/

[Patch v2 04/10] staging: rtl8723bs: hal: Remove function argument padapter

2019-07-31 Thread Hariprasad Kelam
Remove function argument "padapter" in rtl8723bs_init_recv_priv function as its not being used Signed-off-by: Hariprasad Kelam --- v4 - Add patch number drivers/staging/rtl8723bs/hal/rtl8723bs_recv.c | 4 ++-- drivers/staging/rtl8723bs/include/recv_osdep.h | 2 +- drivers/staging/rtl8723bs/os_d

Re: [PATCH v2 2/2] clk: qcom : dispcc: Add support for display port clocks

2019-07-31 Thread Taniya Das
Hi Stephen, Thanks for your comments. On 7/16/2019 4:07 AM, Stephen Boyd wrote: Quoting Taniya Das (2019-05-14 21:20:39) @@ -128,6 +144,82 @@ enum { }, }; +static const struct freq_tbl ftbl_disp_cc_mdss_dp_aux_clk_src[] = { + F(1920, P_BI_TCXO, 1, 0, 0), + { } +}; +

Re: [PATCH v2 1/2] clk: qcom: rcg2: Add support for display port clock ops

2019-07-31 Thread Taniya Das
Hello Stephen, Thanks for your review. On 7/16/2019 4:13 AM, Stephen Boyd wrote: Quoting Taniya Das (2019-05-14 21:20:38) diff --git a/drivers/clk/qcom/Kconfig b/drivers/clk/qcom/Kconfig index 18bdf34..0de080f 100644 --- a/drivers/clk/qcom/Kconfig +++ b/drivers/clk/qcom/Kconfig @@ -15,6 +15,7

Re: [PATCH 4.19 112/113] libnvdimm/bus: Stop holding nvdimm_bus_list_mutex over __nd_ioctl()

2019-07-31 Thread Pavel Machek
On Mon 2019-07-29 21:23:19, Greg Kroah-Hartman wrote: > From: Dan Williams > > commit b70d31d054ee3a6fc1034b9d7fc0ae1e481aa018 upstream. > > In preparation for fixing a deadlock between wait_for_bus_probe_idle() > and the nvdimm_bus_list_mutex arrange for __nd_ioctl() without > nvdimm_bus_list_m

[Patch v2 03/10] staging: rtl8723bs: os_dep: Remove unused function argument sdio_device_id

2019-07-31 Thread Hariprasad Kelam
Remove passing pdid as function argument to rtw_sdio_if1_init as it is not being used Signed-off-by: Hariprasad Kelam --- v3 - Add patch number drivers/staging/rtl8723bs/os_dep/sdio_intf.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8723bs/os_dep/s

[Patch v2 02/10] staging: rtl8723bs: os_dep: Move common code to func

2019-07-31 Thread Hariprasad Kelam
Inthis file all functions has below common functionality 1.Check flag padapter->bSurpriseRemoved 2.Get sdio_func structure from intf_hdl. This patch introduces two new APIs rtw_isadapter_removed,rtw_sdio_get_func which helps to do above common functionality. Signed-off-by: Hariprasad Kelam --- v

[Patch v2 01/10] staging: rtl8723bs: os_dep: Remove function _rtw_regdomain_select

2019-07-31 Thread Hariprasad Kelam
This function simply returns &rtw_regdom_rd . So replace this function with actual code Signed-off-by: Hariprasad Kelam --- v2 - Add patch number drivers/staging/rtl8723bs/os_dep/wifi_regd.c | 9 + 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/drivers/staging/rtl8723bs/os

Re: [PATCH 0/5] Ziirave_wdt driver fixes

2019-07-31 Thread Guenter Roeck
On Wed, Jul 31, 2019 at 10:42:47AM -0700, Andrey Smirnov wrote: > Everyone, > > This series contains various fixes/improvements for ziirave_wdt > driver. Hopefully each commit is self-explanatory. > > Feedback is welcome! > > Thanks, > Andrey Smirnov > > Andrey Smirnov (5): > watchdog: ziirav

Re: [PATCH 4/5] watchdog: ziirave_wdt: Don't bail out on unexpected timeout value

2019-07-31 Thread Guenter Roeck
On Wed, Jul 31, 2019 at 10:42:51AM -0700, Andrey Smirnov wrote: > Reprogramming bootloader on watchdog MCU will result in reported > default timeout value of "0". That in turn will be unnecesarily unnecessarily > rejected by the driver as invalid device (-ENODEV). Simplify probe to > just read st

[RFC 1/9] platform/x86: huawei-wmi: Rename guid and driver name

2019-07-31 Thread Ayman Bagabas
Use WMI device UID, AMW0 has a UID of HWMI. WMI0 is the device name and doesn't have a UID so keep it as it is. Change module description to reflect the upcoming changes. Signed-off-by: Ayman Bagabas --- drivers/platform/x86/huawei-wmi.c | 14 -- 1 file changed, 8 insertions(+), 6 d

[tip:sched/rt] x86/kvm: Use CONFIG_PREEMPTION

2019-07-31 Thread tip-bot for Thomas Gleixner
Commit-ID: 09c7e8b21d67c3c78ab9701dbc0fb1e9f14a0ba5 Gitweb: https://git.kernel.org/tip/09c7e8b21d67c3c78ab9701dbc0fb1e9f14a0ba5 Author: Thomas Gleixner AuthorDate: Fri, 26 Jul 2019 23:19:44 +0200 Committer: Ingo Molnar CommitDate: Wed, 31 Jul 2019 19:03:36 +0200 x86/kvm: Use CONFIG_PRE

[PATCH 2/2] randstruct: remove dead code in is_pure_ops_struct()

2019-07-31 Thread Joonwon Kang
Recursive declaration for struct which has member of the same struct type, for example, struct foo { struct foo f; ... }; is not allowed. So, it is unnecessary to check if a struct has this kind of member. Signed-off-by: Joonwon Kang --- scripts/gcc-plugins/randomize_layout_plugin.c |

[PATCH] ARM: imx: Drop imx_anatop_init()

2019-07-31 Thread Andrey Smirnov
With commit b5bbe2235361 ("usb: phy: mxs: Disable external charger detect in mxs_phy_hw_init()") in tree all of the necessary charger setup is done by the USB PHY driver which covers all of the affected i.MX6 SoCs. NOTE: Imx_anatop_init() was also called for i.MX7D, but looking at its datasheet it

Re: [PATCH net-next v2 1/4] dt-bindings: net: Add aspeed,ast2600-mdio binding

2019-07-31 Thread Rob Herring
On Tue, Jul 30, 2019 at 11:39 PM Andrew Jeffery wrote: > > The AST2600 splits out the MDIO bus controller from the MAC into its own > IP block and rearranges the register layout. Add a new binding to > describe the new hardware. > > Signed-off-by: Andrew Jeffery > > --- > v2: > * aspeed: Utilise

[PATCH 1/2] randstruct: fix a bug in is_pure_ops_struct()

2019-07-31 Thread Joonwon Kang
Before this, there were false negatives in the case where a struct contains other structs which contain only function pointers because of unreachable code in is_pure_ops_struct(). Signed-off-by: Joonwon Kang --- scripts/gcc-plugins/randomize_layout_plugin.c | 10 +- 1 file changed, 5 ins

[PATCH 0/2] fix is_pure_ops_struct()

2019-07-31 Thread Joonwon Kang
Hello, This series fixes unreachable code bug and removes dead code in is_pure_ops_struct(). Thanks. Joonwon Kang (2): randstruct: fix a bug in is_pure_ops_struct() randstruct: remove dead code in is_pure_ops_struct() scripts/gcc-plugins/randomize_layout_plugin.c | 11 --- 1 file c

[tip:sched/rt] x86/dumpstack: Indicate PREEMPT_RT in dumps

2019-07-31 Thread tip-bot for Thomas Gleixner
Commit-ID: cb376c26971ff54f25980ec1f0ae2f06d6a69df0 Gitweb: https://git.kernel.org/tip/cb376c26971ff54f25980ec1f0ae2f06d6a69df0 Author: Thomas Gleixner AuthorDate: Fri, 26 Jul 2019 23:19:43 +0200 Committer: Ingo Molnar CommitDate: Wed, 31 Jul 2019 19:03:36 +0200 x86/dumpstack: Indicate

[tip:sched/rt] x86: Use CONFIG_PREEMPTION

2019-07-31 Thread tip-bot for Thomas Gleixner
Commit-ID: 48593975aeee548f25e256c515fd1d1e3fb2cc20 Gitweb: https://git.kernel.org/tip/48593975aeee548f25e256c515fd1d1e3fb2cc20 Author: Thomas Gleixner AuthorDate: Fri, 26 Jul 2019 23:19:42 +0200 Committer: Ingo Molnar CommitDate: Wed, 31 Jul 2019 19:03:35 +0200 x86: Use CONFIG_PREEMPT

Re: [PATCH v2 00/23] LPUART fixes and improvements

2019-07-31 Thread Fabio Estevam
Hi Andrey, On Wed, Jul 31, 2019 at 2:53 PM Andrey Smirnov wrote: > > Everyone: > > This series contains fixes/improvements to LPUART dirver I came up > with recently as well as fixes picked up from Toradex and NXP Vybrid > repos. > > Feedback is welcome! > > Changes since [v1]: Greg has already

Re: [PATCH v2 1/6] dt-bindings: thermal: Add DT bindings documentation for Amlogic Thermal

2019-07-31 Thread Rob Herring
On Wed, Jul 31, 2019 at 9:36 AM Guillaume La Roque wrote: > > Adding the devicetree binding documentation for the Amlogic temperature > sensor found in the Amlogic Meson G12 SoCs. > the G12A and G12B SoCs are supported. > > Signed-off-by: Guillaume La Roque > --- > .../bindings/thermal/amlogic,

Re: [PATCH 2/2] cnic: Use refcount_t for refcount

2019-07-31 Thread Michael Chan
On Wed, Jul 31, 2019 at 5:22 AM Chuhong Yuan wrote: > static void cnic_ctx_wr(struct cnic_dev *dev, u32 cid_addr, u32 off, u32 val) > @@ -494,7 +494,7 @@ int cnic_register_driver(int ulp_type, struct > cnic_ulp_ops *ulp_ops) > } > read_unlock(&cnic_dev_lock); > > - atomic_

[tip:sched/rt] kprobes: Use CONFIG_PREEMPTION

2019-07-31 Thread tip-bot for Thomas Gleixner
Commit-ID: 92616606368ee01f1163fcfc986116c810cd48ba Gitweb: https://git.kernel.org/tip/92616606368ee01f1163fcfc986116c810cd48ba Author: Thomas Gleixner AuthorDate: Fri, 26 Jul 2019 23:19:41 +0200 Committer: Ingo Molnar CommitDate: Wed, 31 Jul 2019 19:03:35 +0200 kprobes: Use CONFIG_PRE

[tip:sched/rt] tracing: Use CONFIG_PREEMPTION

2019-07-31 Thread tip-bot for Thomas Gleixner
Commit-ID: 30c937043b2db09ae3408f5534824f9ececdb581 Gitweb: https://git.kernel.org/tip/30c937043b2db09ae3408f5534824f9ececdb581 Author: Thomas Gleixner AuthorDate: Fri, 26 Jul 2019 23:19:40 +0200 Committer: Ingo Molnar CommitDate: Wed, 31 Jul 2019 19:03:35 +0200 tracing: Use CONFIG_PRE

[tip:sched/rt] locking/spinlocks: Use CONFIG_PREEMPTION

2019-07-31 Thread tip-bot for Thomas Gleixner
Commit-ID: 27972765bd0410fc2ef5e86a41de17c71440a2dd Gitweb: https://git.kernel.org/tip/27972765bd0410fc2ef5e86a41de17c71440a2dd Author: Thomas Gleixner AuthorDate: Fri, 26 Jul 2019 23:19:39 +0200 Committer: Ingo Molnar CommitDate: Wed, 31 Jul 2019 19:03:35 +0200 locking/spinlocks: Use

[tip:sched/rt] rcu: Use CONFIG_PREEMPTION

2019-07-31 Thread tip-bot for Thomas Gleixner
Commit-ID: 01b1d88b09824bea1a75b0bac04dcf50d9893875 Gitweb: https://git.kernel.org/tip/01b1d88b09824bea1a75b0bac04dcf50d9893875 Author: Thomas Gleixner AuthorDate: Fri, 26 Jul 2019 23:19:38 +0200 Committer: Ingo Molnar CommitDate: Wed, 31 Jul 2019 19:03:35 +0200 rcu: Use CONFIG_PREEMPT

[tip:sched/rt] sched/preempt: Use CONFIG_PREEMPTION where appropriate

2019-07-31 Thread tip-bot for Thomas Gleixner
Commit-ID: c1a280b68d4e6b6db4a65aa7865c22d8789ddf09 Gitweb: https://git.kernel.org/tip/c1a280b68d4e6b6db4a65aa7865c22d8789ddf09 Author: Thomas Gleixner AuthorDate: Fri, 26 Jul 2019 23:19:37 +0200 Committer: Ingo Molnar CommitDate: Wed, 31 Jul 2019 19:03:34 +0200 sched/preempt: Use CONF

[PATCH] IB/hfi1: Fix Spectre v1 vulnerability

2019-07-31 Thread Gustavo A. R. Silva
sl is controlled by user-space, hence leading to a potential exploitation of the Spectre variant 1 vulnerability. Fix this by sanitizing sl before using it to index ibp->sl_to_sc. Notice that given that speculation windows are large, the policy is to kill the speculation on the first load and not

[RFC 7/9] platform/x86: huawei-wmi: Add fn-lock support

2019-07-31 Thread Ayman Bagabas
Huawei Matebook laptops uses Fn key and toggle to access F1-F12 keys. Along with that, there is this feature called fn-lock that inverts the behavior of this Fn key. Implement the basic functionality of this feature to be used later by sysfs interface support introduced in this series. Signed-off

[RFC 4/9] platform/x86: huawei-wmi: Add quirks and module parameters

2019-07-31 Thread Ayman Bagabas
Introduce quirks and module parameters. 3 quirks are added: 1. Fixes reporting brightness keys twice since it's already handled by acpi-video. 2. Some models need a short delay when setting battery thresholds to prevent a race condition when two processes read/write. 3. Matebook X (2017) hand

[RFC 6/9] platform/x86: huawei-wmi: Add battery charging thresholds

2019-07-31 Thread Ayman Bagabas
Implement battery charging thresholds functionality to be used with sysfs interface support that is implemented in this series. Setting battery charging thresholds can introduce a race condition where two are trying to read/write values from/to EC memory. Even though a mutex is used, this doesn't

[RFC 8/9] platform/x86: huawei-wmi: Add sysfs interface support

2019-07-31 Thread Ayman Bagabas
Add sysfs interface to enable the use of battery charging thresholds and fn-lock support introduced in this series. Signed-off-by: Ayman Bagabas --- drivers/platform/x86/huawei-wmi.c | 82 +++ 1 file changed, 82 insertions(+) diff --git a/drivers/platform/x86/huawei-

[RFC 9/9] platform/x86: huawei-wmi: Add debugfs support

2019-07-31 Thread Ayman Bagabas
Add a debugfs interface that can be used to call the WMI management interface function. The WMI interface takes a 64 bit integer and returns 256-260 bytes buffer. This debugfs interface creates two files, one stores a 64 bit int and the other calls the WMI interface and dumps out the returned buff

[PATCH v4] watchdog: pc87413: Rewriting of pc87413_wdt driver to use watchdog subsystem

2019-07-31 Thread Mark Balantzyan
This patch rewrites the pc87413_wdt driver to use the watchdog subsystem. In doing so, it also addresses a potential race condition owing from the swc_base_addr variable being used before being set. Signed-off-by: Mark Balantzyan --- drivers/watchdog/Kconfig | 1 + drivers/watchdog/pc87

[RFC 3/9] platform/x86: huawei-wmi: Implement huawei wmi management interface

2019-07-31 Thread Ayman Bagabas
Huawei Matebook laptops come with a WMI management interface that can control various aspects of the device. This interface is also found on the old Matebook X released in 2017. Implement basic functionality of this interface along with supported command IDs that are implemented in this series. S

[RFC 2/9] platform/x86: huawei-wmi: Move to platform driver

2019-07-31 Thread Ayman Bagabas
Move from WMI driver to platform driver. This move is necessary since the driver is no longer a hotkeys driver only. Platform driver makes it easier for users to access sysfs attributes under (i.e. /sys/devices/platform/huawei-wmi) compared to wmi driver. Signed-off-by: Ayman Bagabas --- Do you t

[RFC 5/9] platform/x86: huawei-wmi: Control micmute led through wmi interface

2019-07-31 Thread Ayman Bagabas
Now that huawei WMI management interface is implemented, micmute LED can be controlled easily through this interface. Exception is the Matebook X (2017) which continue to uses ACPI EC method to control the LED. This model can control the LED through the legacy WMI interface which is not implemented

[RFC 0/9] platform/x86: Huawei WMI laptop extras driver

2019-07-31 Thread Ayman Bagabas
This patch series introduce changes to huawei-wmi driver that includes: * Move to platform driver * Implement WMI management interface * Add micmute LED support through WMI * Add battery charging protection support through WMI * Add fn-lock support through WMI * Implement driver quirks and paramete

Re: [PATCH V2] IB/core: Add mitigation for Spectre V1

2019-07-31 Thread Gustavo A. R. Silva
On 7/31/19 9:52 AM, Doug Ledford wrote: > > I'm not sure this is the best fix for this. However, here is where I > get to admit that I largely ignored the whole Spectre V1 thing, so I'm > not sure I completely understand the vulnerability and the limits to > that. But, looking at the functio

[PATCH v2 5/7] Drivers: hv: vmbus: Ignore the offers when resuming from hibernation

2019-07-31 Thread Dexuan Cui
When the VM resumes, the host re-sends the offers. We should not add the offers to the global vmbus_connection.chn_list again. Added some debug code, in case the host screws up the exact info related to the offers. Signed-off-by: Dexuan Cui --- drivers/hv/channel_mgmt.c | 29 +++

[PATCH v2 3/7] Drivers: hv: vmbus: Break out synic enable and disable operations

2019-07-31 Thread Dexuan Cui
Break out synic enable and disable operations into separate hv_synic_disable_regs() and hv_synic_enable_regs() functions for use by a later patch to support hibernation. There is no functional change except the unnecessary check "if (sctrl.enable != 1) return -EFAULT;" which is removed, because wh

[PATCH v2 6/7] Drivers: hv: vmbus: Suspend/resume the vmbus itself for hibernation

2019-07-31 Thread Dexuan Cui
Before Linux enters hibernation, it sends the CHANNELMSG_UNLOAD message to the host so all the offers are gone. After hibernation, Linux needs to re-negotiate with the host using the same vmbus protocol version (which was in use before hibernation), and ask the host to re-offer the vmbus devices.

[PATCH v2 2/7] clocksource/drivers: Suspend/resume Hyper-V clocksource for hibernation

2019-07-31 Thread Dexuan Cui
This is needed for hibernation, e.g. when we resume the old kernel, we need to disable the "current" kernel's TSC page and then resume the old kernel's. Signed-off-by: Dexuan Cui Reviewed-by: Michael Kelley --- drivers/clocksource/hyperv_timer.c | 25 + 1 file changed, 2

[PATCH v2 4/7] Drivers: hv: vmbus: Suspend/resume the synic for hibernation

2019-07-31 Thread Dexuan Cui
This is needed when we resume the old kernel from the "current" kernel. Note: when hv_synic_suspend() and hv_synic_resume() run, all the non-boot CPUs have been offlined, and interrupts are disabled on CPU0. Signed-off-by: Dexuan Cui --- drivers/hv/vmbus_drv.c | 46 +

[PATCH v2 1/7] x86/hyper-v: Suspend/resume the hypercall page for hibernation

2019-07-31 Thread Dexuan Cui
This is needed for hibernation, e.g. when we resume the old kernel, we need to disable the "current" kernel's hypercall page and then resume the old kernel's. Signed-off-by: Dexuan Cui Reviewed-by: Michael Kelley --- arch/x86/hyperv/hv_init.c | 34 ++ 1 file chan

<    1   2   3   4   5   6   7   8   9   10   >