Re: [PATCH v9 04/11] x86/entry/64: Adapt assembly for PIE support

2019-08-05 Thread Borislav Petkov
On Mon, Aug 05, 2019 at 10:50:30AM -0700, Thomas Garnier wrote: > I saw that %rdx was used for temporary usage and restored before the > end so I assumed that it was not an option. PUSH_AND_CLEAR_REGS saves all regs earlier so I think you should be able to use others. Like SAVE_AND_SWITCH_TO_KERNE

Re: Bisected: Kernel 4.14 + has 3 times higher write IO latency than Kernel 4.4 with raid1

2019-08-05 Thread riccardofarabia
Hello Linux raid folks? I've joined this email ring to ask for help (I'd be happy to try to help in return, but I doubt that I could help anyone with advanced raid issues. Maybe I can return any love in other non-raid ways? Ah well.. I've been using linux raid for a quite a few years, but until

Re: [PATCH net-next 06/10] net: stmmac: Implement RSS and enable it in XGMAC core

2019-08-05 Thread Jakub Kicinski
On Mon, 5 Aug 2019 20:01:19 +0200, Jose Abreu wrote: > Implement the RSS functionality and add the corresponding callbacks in > XGMAC core. > > Signed-off-by: Jose Abreu > --- > Cc: Giuseppe Cavallaro > Cc: Alexandre Torgue > Cc: Jose Abreu > Cc: "David S. Miller" > Cc: Maxime Coquelin > Cc

RE: [PATCHv2 3/3] PCI: layerscape: Add LS1028a support

2019-08-05 Thread Z.q. Hou
Hi Xiaowei, > -Original Message- > From: Xiaowei Bao [mailto:xiaowei@nxp.com] > Sent: 2019年8月5日 12:05 > To: bhelg...@google.com; robh...@kernel.org; mark.rutl...@arm.com; > shawn...@kernel.org; Leo Li ; kis...@ti.com; > lorenzo.pieral...@arm.com; a...@arndb.de; gre...@linuxfoundation.o

Re: [PATCH V2 05/10] ACPI: cpufreq: Switch to QoS requests instead of cpufreq notifier

2019-08-05 Thread Viresh Kumar
On 05-08-19, 11:42, Rafael J. Wysocki wrote: > On Tuesday, July 23, 2019 8:14:05 AM CEST Viresh Kumar wrote: > > @@ -310,8 +339,11 @@ static int __init acpi_processor_driver_init(void) > > cpuhp_setup_state_nocalls(CPUHP_ACPI_CPUDRV_DEAD, "acpi/cpu-drv:dead", > > N

[RFC PATCH] kbuild: re-implement detection of CONFIG options leaked to user-space

2019-08-05 Thread Masahiro Yamada
scripts/headers_check.pl can detect references to CONFIG options in exported headers, but it has been disabled for more than a decade. Reverting commit 7e3fa5614117 ("kbuild: drop check for CONFIG_ in headers_check") would emit the following warnings for headers_check on x86: usr/include/mtd/ubi-

Re: [PATCH net-next 03/10] net: stmmac: Fix issues when number of Queues >= 4

2019-08-05 Thread Jakub Kicinski
On Mon, 5 Aug 2019 20:01:16 +0200, Jose Abreu wrote: > When queues >= 4 we use different registers but we were not subtracting > the offset of 4. Fix this. > > Found out by Coverity. > > Signed-off-by: Jose Abreu Should this be a bug fix for the net tree?

[PATCH] acpi/hmat: ACPI_HMAT_MEMORY_PD_VALID is deprecated in ACPI-6.3

2019-08-05 Thread Daniel Black
ACPI-6.3 corresponds to when hmat revision was bumped from 1 to 2. In this version ACPI_HMAT_MEMORY_PD_VALID was deprecated and made reserved. As such in revision 2+ we shouldn't be testing this flag. This is as per ACPI-6.3, 5.2.27.3, Table 5-145 "Memory Proximity Domain Attributes Structure" fo

Re: [PATCH 4.9 00/42] 4.9.188-stable review

2019-08-05 Thread Jari Ruusu
Greg Kroah-Hartman wrote: > On Mon, Aug 05, 2019 at 11:11:01PM +0300, Jari Ruusu wrote: > > Peter Zijlstra's "x86/atomic: Fix smp_mb__{before,after}_atomic()" > > upstream commit 69d927bba39517d0980462efc051875b7f4db185 seems to > > be missing/lost from 4.9 and older stable kernels. > > Can you se

Re: [PATCH 4.9 00/42] 4.9.188-stable review

2019-08-05 Thread Jari Ruusu
Greg Kroah-Hartman wrote: > On Mon, Aug 05, 2019 at 11:11:01PM +0300, Jari Ruusu wrote: > > Peter Zijlstra's "x86/atomic: Fix smp_mb__{before,after}_atomic()" > > upstream commit 69d927bba39517d0980462efc051875b7f4db185 seems to > > be missing/lost from 4.9 and older stable kernels. > > Can you se

Re: [PATCH] media: uvcvideo: Add boottime clock support

2019-08-05 Thread Tomasz Figa
On Wed, Mar 13, 2019 at 11:38 AM Tomasz Figa wrote: > > On Wed, Mar 13, 2019 at 10:25 AM Laurent Pinchart > wrote: > > > > Hi Tomasz, > > > > On Fri, Nov 23, 2018 at 11:46:43PM +0900, Tomasz Figa wrote: > > > On Fri, Nov 2, 2018 at 12:03 AM Lars-Peter Clausen wrote: > > > > On 11/01/2018 03:30 PM

Re: [PATCH V3 2/2] cpufreq: intel_pstate: Implement ->resolve_freq()

2019-08-05 Thread Viresh Kumar
On 02-08-19, 11:28, Rafael J. Wysocki wrote: > On Friday, August 2, 2019 11:17:55 AM CEST Rafael J. Wysocki wrote: > > On Fri, Aug 2, 2019 at 7:44 AM Viresh Kumar wrote: > > > > > > Intel pstate driver exposes min_perf_pct and max_perf_pct sysfs files, > > > which can be used to force a limit on t

Re: [PATCH] cpufreq: schedutil: Don't skip freq update when limits change

2019-08-05 Thread Viresh Kumar
On 02-08-19, 11:11, Rafael J. Wysocki wrote: > On Friday, August 2, 2019 5:48:19 AM CEST Viresh Kumar wrote: > > On 01-08-19, 10:57, Doug Smythies wrote: > > > Disagree. > > > All I did was use a flag where it used to be set to UNIT_MAX, to basically > > > implement the same thing. > > > > And the

Re: [PATCH] arm64/cache: fix -Woverride-init compiler warnings

2019-08-05 Thread Qian Cai
> On Aug 5, 2019, at 10:01 AM, Will Deacon wrote: > > On Mon, Aug 05, 2019 at 07:47:37AM -0400, Qian Cai wrote: >> >> >>> On Aug 5, 2019, at 5:52 AM, Will Deacon wrote: >>> >>> On Fri, Aug 02, 2019 at 11:32:24AM -0400, Qian Cai wrote: The commit 155433cb365e ("arm64: cache: Remove sup

Re: linux-next: build failure after merge of the integrity tree

2019-08-05 Thread Stephen Rothwell
Hi Thiago, On Tue, 06 Aug 2019 00:18:06 -0300 Thiago Jung Bauermann wrote: > > Sorry for the trouble. I wasn't aware of that build time check. > I'll enable HEADER_TEST and KERNEL_HEADER_TEST for my next patches. I do allmodconfig builds which enable those. > Thanks for providing the fix. Shou

Re: [PATCH 2/2] /proc/kpageflags: do not use uninitialized struct pages

2019-08-05 Thread Dan Williams
On Wed, Jul 24, 2019 at 7:46 PM Toshiki Fukasawa wrote: > > A kernel panic was observed during reading /proc/kpageflags for > first few pfns allocated by pmem namespace: > > BUG: unable to handle page fault for address: fffe > [ 114.495280] #PF: supervisor read access in kernel mode >

Re: [PATCH 4.14 00/53] 4.14.137-stable review

2019-08-05 Thread Naresh Kamboju
On Mon, 5 Aug 2019 at 18:38, Greg Kroah-Hartman wrote: > > This is the start of the stable review cycle for the 4.14.137 release. > There are 53 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me know. > > Res

Re: [PATCH RFC] mm/memcontrol: reclaim severe usage over high limit in get_user_pages loop

2019-08-05 Thread Yang Shi
On Mon, Aug 5, 2019 at 7:32 AM Michal Hocko wrote: > > On Fri 02-08-19 11:56:28, Yang Shi wrote: > > On Fri, Aug 2, 2019 at 2:35 AM Michal Hocko wrote: > > > > > > On Thu 01-08-19 14:00:51, Yang Shi wrote: > > > > On Mon, Jul 29, 2019 at 11:48 AM Michal Hocko wrote: > > > > > > > > > > On Mon 29

Re: [PATCH v3 0/3] Powerpc64/Watchpoint: Few important fixes

2019-08-05 Thread Ravi Bangoria
Mikey, mpe ... Any thoughts?

Re: [PATCH] scsi/megaraid_sas: fix a compilation warning

2019-08-05 Thread Qian Cai
Ping. Please take a look at this trivial patch. > On Jul 26, 2019, at 10:25 AM, Qian Cai wrote: > > The commit de516379e85f ("scsi: megaraid_sas: changes to function > prototypes") introduced a comilation warning due to it changed the > function prototype of read_fw_status_reg() to take an insta

Re: [PATCH 2/2] /proc/kpageflags: do not use uninitialized struct pages

2019-08-05 Thread Dan Williams
On Sun, Aug 4, 2019 at 10:31 PM Toshiki Fukasawa wrote: > > On 2019/07/26 16:06, Michal Hocko wrote: > > On Fri 26-07-19 06:25:49, Toshiki Fukasawa wrote: > >> > >> > >> On 2019/07/25 18:03, Michal Hocko wrote: > >>> On Thu 25-07-19 02:31:18, Toshiki Fukasawa wrote: > A kernel panic was obser

Re: [RFC PATCH v3 00/16] Core scheduling v3

2019-08-05 Thread Aaron Lu
On Mon, Aug 05, 2019 at 08:55:28AM -0700, Tim Chen wrote: > On 8/2/19 8:37 AM, Julien Desfossez wrote: > > We tested both Aaron's and Tim's patches and here are our results. > > > > Test setup: > > - 2 1-thread sysbench, one running the cpu benchmark, the other one the > > mem benchmark > > - bo

Re: [PATCH v2] f2fs: fix wrong available node count calculation

2019-08-05 Thread Chao Yu
On 2019/8/5 18:27, Chao Yu wrote: > In mkfs, we have counted quota file's node number in cp.valid_node_count, > so we have to avoid wrong substraction of quota node number in > .available_nid/.avail_node_count calculation. > > f2fs_write_check_point_pack() > { > .. > set_cp(valid_node_count,

Re: [PATCH v3 11/19] RISC-V: KVM: Implement VMID allocator

2019-08-05 Thread Anup Patel
On Mon, Aug 5, 2019 at 9:33 PM Paolo Bonzini wrote: > > On 05/08/19 15:43, Anup Patel wrote: > > + spin_lock(&vmid_lock); > > + > > + /* > > + * We need to re-check the vmid_version here to ensure that if > > + * another vcpu already allocated a valid vmid for this vm. > > +

Re: linux-next: build failure after merge of the integrity tree

2019-08-05 Thread Thiago Jung Bauermann
Hello Stephen, Stephen Rothwell writes: > Hi all, > > After merging the integrity tree, today's linux-next build (x86_64 > allmodconfig) failed like this: > > In file included from : > include/linux/module_signature.h:32:2: error: unknown type name 'u8' > u8 algo; /* Public-key crypto algor

Re: [PATCH v3 06/19] RISC-V: KVM: Implement VCPU interrupts and requests handling

2019-08-05 Thread Anup Patel
On Mon, Aug 5, 2019 at 7:13 PM Anup Patel wrote: > > This patch implements VCPU interrupts and requests which are both > asynchronous events. > > The VCPU interrupts can be set/unset using KVM_INTERRUPT ioctl from > user-space. In future, the in-kernel IRQCHIP emulation will use > kvm_riscv_vcpu_s

Re: [PATCH] fork: Improve error message for corrupted page tables

2019-08-05 Thread Sai Praneeth Prakhya
On Mon, 2019-08-05 at 15:28 +0200, Vlastimil Babka wrote: > On 8/2/19 8:46 AM, Prakhya, Sai Praneeth wrote: > > > > > > +static const char * const resident_page_types[NR_MM_COUNTERS] = { > > > > > > + "MM_FILEPAGES", > > > > > > + "MM_ANONPAGES", > > > > > > + "MM_SWAPENTS", > > > > > > + "

[PATCH 2/2] ARM: zynq: Use memcpy_toio instead of memcpy on smp bring-up

2019-08-05 Thread Luis Araneda
This fixes a kernel panic (read overflow) on memcpy when FORTIFY_SOURCE is enabled. The computed size of memcpy args are: - p_size (dst): 4294967295 = (size_t) -1 - q_size (src): 1 - size (len): 8 Additionally, the memory is marked as __iomem, so one of the memcpy_* functions should be used for r

[PATCH V2] fork: Improve error message for corrupted page tables

2019-08-05 Thread Sai Praneeth Prakhya
When a user process exits, the kernel cleans up the mm_struct of the user process and during cleanup, check_mm() checks the page tables of the user process for corruption (E.g: unexpected page flags set/cleared). For corrupted page tables, the error message printed by check_mm() isn't very clear as

[PATCH 0/2] ARM: zynq: smp improvements

2019-08-05 Thread Luis Araneda
This series adds support for kernel compiled in Thumb mode and fixes a kernel panic on smp bring-up when FORTIFY_SOURCE is enabled. The series started with the second patch as an RFC, and the first patch were suggested on the review to complement the fix. The changes were run-tested on a Digilent

[PATCH 1/2] ARM: zynq: support smp in thumb mode

2019-08-05 Thread Luis Araneda
Add .arm directive to headsmp.S to ensure that the CPU starts in 32-bit ARM mode and the correct code size is copied on smp bring-up Additionally, start secondary CPUs on secondary_startup_arm to automatically switch from ARM to thumb on a thumb kernel Suggested-by: Michal Simek Signed-off-by: L

Re: [PATCH v1 1/3] net: hisilicon: make hip04_tx_reclaim non-reentrant

2019-08-05 Thread Jakub Kicinski
On Tue, 6 Aug 2019 10:00:52 +0800, Jiangfeng Xiao wrote: > If hip04_tx_reclaim is interrupted while it is running, and then > __irq_svc->gic_handle_irq->hip04_mac_interrupt->__napi_schedule->hip04_rx_poll->hip04_tx_reclaim Ah right, obviously you can't do stuff after napi_complete_done(), that ma

[PATCH v3] arm64/prefetch: fix a -Wtype-limits warning

2019-08-05 Thread Qian Cai
The commit d5370f754875 ("arm64: prefetch: add alternative pattern for CPUs without a prefetcher") introduced MIDR_IS_CPU_MODEL_RANGE() to be used in has_no_hw_prefetch() with rv_min=0 which generates a compilation warning from GCC, In file included from ./arch/arm64/include/asm/cache.h:8,

[PATCH v2] gpio: mpc8xxx: Add new platforms GPIO DT node description

2019-08-05 Thread Hui Song
From: Song Hui Update the NXP GPIO node dt-binding file for QorIQ and Layerscape platforms, and add one more example with ls1028a GPIO node. Signed-off-by: Song Hui --- Documentation/devicetree/bindings/gpio/gpio-mpc8xxx.txt | 14 ++ 1 file changed, 14 insertions(+) diff --git a/D

[PATCH 1/2] cxgb4: smt: Add lock for atomic_dec_and_test

2019-08-05 Thread Chuhong Yuan
The atomic_dec_and_test() is not safe because it is outside of locks. Move the locks of t4_smte_free() to its caller, cxgb4_smt_release() to protect the atomic decrement. Fixes: 3bdb376e6944 ("cxgb4: introduce SMT ops to prepare for SMAC rewrite support") Signed-off-by: Chuhong Yuan --- drivers

[PATCH 2/2] cxgb4: smt: Use normal int for refcount

2019-08-05 Thread Chuhong Yuan
All refcount operations are protected by spinlocks now. Then the atomic counter can be replaced by a normal int. This patch depends on PATCH 1/2. Signed-off-by: Chuhong Yuan --- drivers/net/ethernet/chelsio/cxgb4/smt.c | 14 +++--- drivers/net/ethernet/chelsio/cxgb4/smt.h | 2 +- 2 fil

RE: [PATCH] thermal: qoriq: add thermal monitor unit version 2 support

2019-08-05 Thread Andy Tang
Any comments? BR, Andy > -Original Message- > From: Yuantian Tang > Sent: 2019年6月4日 10:51 > To: edubez...@gmail.com; rui.zh...@intel.com > Cc: daniel.lezc...@linaro.org; Leo Li ; > linux...@vger.kernel.org; linux-kernel@vger.kernel.org; Andy Tang > > Subject: [PATCH] thermal: qoriq: add

Re: [PATCH 1/2] dma-mapping: fix page attributes for dma_mmap_*

2019-08-05 Thread Gavin Li
> /* create a coherent mapping */ > ret = dma_common_contiguous_remap(page, size, VM_USERMAP, > - arch_dma_mmap_pgprot(dev, PAGE_KERNEL, attrs), > + dma_pgprot(dev, PAGE_KERNEL, attrs), > __builtin_return_address(0)

Re: [PATCH 4.9 00/42] 4.9.188-stable review

2019-08-05 Thread Naresh Kamboju
On Mon, 5 Aug 2019 at 18:35, Greg Kroah-Hartman wrote: > > This is the start of the stable review cycle for the 4.9.188 release. > There are 42 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me know. > > Resp

[PATCH] mm/mempolicy.c: Remove unnecessary nodemask check in kernel_migrate_pages()

2019-08-05 Thread Kefeng Wang
1) task_nodes = cpuset_mems_allowed(current); -> cpuset_mems_allowed() guaranteed to return some non-empty subset of node_states[N_MEMORY]. 2) nodes_and(*new, *new, task_nodes); -> after nodes_and(), the 'new' should be empty or appropriate nodemask(online node and with memory).

[PATCH v17 2/2] dt-bindings: spi: Document Renesas R-Car Gen3 RPC-IF controller bindings

2019-08-05 Thread Mason Yang
Document the bindings used by the Renesas R-Car Gen3 RPC-IF controller. Signed-off-by: Mason Yang Reviewed-by: Rob Herring --- .../devicetree/bindings/spi/spi-renesas-rpc.txt| 45 ++ 1 file changed, 45 insertions(+) create mode 100644 Documentation/devicetree/bindings/s

[PATCH v17 0/2] spi: Add Renesas R-Car Gen3 RPC-IF SPI driver

2019-08-05 Thread Mason Yang
Hi Mark, v17 patch including: 1) patch adding rpc_spi_hw_init() after reset_control_rest() 2) v14 dt-binding file has reviewed by Rob Herring. v16 patch including: 1) fixed typo and spi-tx/rx-bus-width in DTS. 2) v14 dt-binding file has reviewed by Rob Herring. v15 patch including: 1) A typo in

[PATCH v17 1/2] spi: Add Renesas R-Car Gen3 RPC-IF SPI controller driver

2019-08-05 Thread Mason Yang
Add a driver for Renesas R-Car Gen3 RPC-IF SPI controller. Signed-off-by: Mason Yang Signed-off-by: Sergei Shtylyov --- drivers/spi/Kconfig | 6 + drivers/spi/Makefile | 1 + drivers/spi/spi-renesas-rpc.c | 756 ++ 3 files changed,

RE: [PATCH 2/2] clk: imx: disable i.mx7ulp composite clock during initialization

2019-08-05 Thread Anson Huang
Hi, Stephen I think we should resume this thread, without this patch, mainline kernel boot up will cause mmc timeout all the time. If it is NOT good to disabling those peripheral devices' clock in i.MX7ULP's clock driver, then we have to change the core framework to disable clock explici

Re: [PATCH] PCI: Add ACS quirk for Cavium ThunderX 2 root port devices

2019-08-05 Thread Shannon Zhao
On 2019/7/26 0:35, Jayachandran Chandrasekharan Nair wrote: On Wed, Jul 24, 2019 at 01:55:35PM -0500, Bjorn Helgaas wrote: See https://lkml.kernel.org/r/20171026223701.ga25...@bhelgaas-glaptop.roam.corp.google.com for incidental hints (subject, commit log, commit reference). Your patch basic

linux-next: build failure after merge of the integrity tree

2019-08-05 Thread Stephen Rothwell
Hi all, After merging the integrity tree, today's linux-next build (x86_64 allmodconfig) failed like this: In file included from : include/linux/module_signature.h:32:2: error: unknown type name 'u8' u8 algo; /* Public-key crypto algorithm [0] */ ^~ include/linux/module_signature.h:33:2: err

Re: [PATCH v3 RESEND] f2fs: introduce sb.required_features to store incompatible features

2019-08-05 Thread Chao Yu
On 2019/8/6 9:24, Jaegeuk Kim wrote: > On 08/06, Chao Yu wrote: >> On 2019/8/6 8:35, Jaegeuk Kim wrote: >>> On 08/02, Chao Yu wrote: On 2019/8/2 6:35, Jaegeuk Kim wrote: > On 08/01, Chao Yu wrote: >> On 2019/8/1 12:22, Jaegeuk Kim wrote: >>> On 07/31, Chao Yu wrote: On 201

Re: [PATCH v1 1/3] net: hisilicon: make hip04_tx_reclaim non-reentrant

2019-08-05 Thread Jiangfeng Xiao
On 2019/8/6 8:46, Jakub Kicinski wrote: > On Sat, 3 Aug 2019 20:31:39 +0800, Jiangfeng Xiao wrote: >> If hip04_tx_reclaim is interrupted while it is running >> and then __napi_schedule continues to execute >> hip04_rx_poll->hip04_tx_reclaim, reentrancy occurs >> and oops is generated. So you need

[PATCH v3] mlx5: Use refcount_t for refcount

2019-08-05 Thread Chuhong Yuan
Reference counters are preferred to use refcount_t instead of atomic_t. This is because the implementation of refcount_t can prevent overflows and detect possible use-after-free. So convert atomic_t ref counters to refcount_t. Signed-off-by: Chuhong Yuan --- Changes in v3: - Merge v2 patches to

RE: [PATCH V5 1/5] clocksource: imx-sysctr: Add internal clock divider handle

2019-08-05 Thread Anson Huang
Gentle ping... > From: Anson Huang > > The system counter block guide states that the base clock is internally > divided > by 3 before use, that means the clock input of system counter defined in DT > should be base clock which is normally from OSC, and then internally divided > by 3 before use

Re: [RFC PATCH] ARM: zynq: Use memcpy_toio instead of memcpy on smp bring-up

2019-08-05 Thread Luis Araneda
Hi Michal, Thanks for the review. On Mon, Aug 5, 2019 at 5:53 AM Michal Simek wrote: > > On 31. 07. 19 6:12, Luis Araneda wrote: > > Hi Russell, > > > > Thanks for reviewing. > > > > On Tue, Jul 30, 2019 at 6:47 AM Russell King - ARM Linux admin > > wrote: > >> > >> On Tue, Jul 30, 2019 at 12:4

[PATCH v2 2/4] mm, reclaim: cleanup should_continue_reclaim()

2019-08-05 Thread Mike Kravetz
From: Vlastimil Babka After commit "mm, reclaim: make should_continue_reclaim perform dryrun detection", closer look at the function shows, that nr_reclaimed == 0 means the function will always return false. And since non-zero nr_reclaimed implies non_zero nr_scanned, testing nr_scanned serves no

[PATCH v2 3/4] mm, compaction: raise compaction priority after it withdrawns

2019-08-05 Thread Mike Kravetz
From: Vlastimil Babka Mike Kravetz reports that "hugetlb allocations could stall for minutes or hours when should_compact_retry() would return true more often then it should. Specifically, this was in the case where compact_result was COMPACT_DEFERRED and COMPACT_PARTIAL_SKIPPED and no progress

[PATCH v2 4/4] hugetlbfs: don't retry when pool page allocations start to fail

2019-08-05 Thread Mike Kravetz
When allocating hugetlbfs pool pages via /proc/sys/vm/nr_hugepages, the pages will be interleaved between all nodes of the system. If nodes are not equal, it is quite possible for one node to fill up before the others. When this happens, the code still attempts to allocate pages from the full nod

[PATCH v2 1/4] mm, reclaim: make should_continue_reclaim perform dryrun detection

2019-08-05 Thread Mike Kravetz
From: Hillf Danton Address the issue of should_continue_reclaim returning true too often for __GFP_RETRY_MAYFAIL attempts when !nr_reclaimed and nr_scanned. This was observed during hugetlb page allocation causing stalls for minutes or hours. We can stop reclaiming pages if compaction reports it

[PATCH v2 0/4] address hugetlb page allocation stalls

2019-08-05 Thread Mike Kravetz
Allocation of hugetlb pages via sysctl or procfs can stall for minutes or hours. A simple example on a two node system with 8GB of memory is as follows: echo 4096 > /sys/devices/system/node/node1/hugepages/hugepages-2048kB/nr_hugepages echo 4096 > /proc/sys/vm/nr_hugepages Obviously, both alloc

Re: [PATCH resend v2] lib: scatterlist: Fix to support no mapped sg

2019-08-05 Thread Zhou Wang
On 2019/7/29 9:44, Zhou Wang wrote: > On 2019/7/24 11:54, Zhou Wang wrote: >> In function sg_split, the second sg_calculate_split will return -EINVAL >> when in_mapped_nents is 0. >> >> Indeed there is no need to do second sg_calculate_split and sg_split_mapped >> when in_mapped_nents is 0, as in_m

Re: [PATCH 2/2] mm/zsmalloc.c: Fix race condition in zs_destroy_pool

2019-08-05 Thread Minchan Kim
On Mon, Aug 05, 2019 at 10:34:41AM -0700, Henry Burns wrote: > On Sun, Aug 4, 2019 at 9:28 PM Minchan Kim wrote: > > > > Hi Henry, > > > > On Thu, Aug 01, 2019 at 06:53:32PM -0700, Henry Burns wrote: > > > In zs_destroy_pool() we call flush_work(&pool->free_work). However, we > > > have no guarant

[PATCH] rtl8712: rtl871x_ioctl_linux.c: fix unnecessary typecast

2019-08-05 Thread Jose Carlos Cazarin Filho
Fix checkpath warning: WARNING: Unnecessary typecast of c90 int constant Signed-off-by: Jose Carlos Cazarin Filho --- Hello all! This is my first commit to the Linux Kernel, I'm doing this to learn and be able to contribute more in the future Peace all! drivers/staging/rtl8712/rtl871x_ioct

Re: [PATCH v2 0/4] per-cgroup numa suite

2019-08-05 Thread 王贇
Hi, Folks Please feel free to comment if you got any concerns :-) Hi, Peter How do you think about this version? Please let us know if it's still not good enough to be accepted :-) Regards, Michael Wang On 2019/7/16 上午11:38, 王贇 wrote: > During our torturing on numa stuff, we found problems li

[PATCH net-next v4] net: can: Fix compiling warnings for two functions

2019-08-05 Thread Mao Wenan
There are two warnings in net/can, fix them by setting bcm_sock_no_ioctlcmd and raw_sock_no_ioctlcmd as static. net/can/bcm.c:1683:5: warning: symbol 'bcm_sock_no_ioctlcmd' was not declared. Should it be static? net/can/raw.c:840:5: warning: symbol 'raw_sock_no_ioctlcmd' was not declared. Should

Re: [PATCH v4 00/10] implement KASLR for powerpc/fsl_booke/32

2019-08-05 Thread Jason Yan
Hi Christophe , Can you take a look at patch 6,7,9 of this version? Thank you, Jason On 2019/8/5 14:43, Jason Yan wrote: This series implements KASLR for powerpc/fsl_booke/32, as a security feature that deters exploit attempts relying on knowledge of the location of kernel internals. Since CO

Re: [PATCH 4.4 00/22] 4.4.188-stable review

2019-08-05 Thread shuah
On 8/5/19 7:02 AM, Greg Kroah-Hartman wrote: This is the start of the stable review cycle for the 4.4.188 release. There are 22 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made b

Re: [PATCH 4.9 00/42] 4.9.188-stable review

2019-08-05 Thread shuah
On 8/5/19 7:02 AM, Greg Kroah-Hartman wrote: This is the start of the stable review cycle for the 4.9.188 release. There are 42 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made b

Re: Let's talk about the elephant in the room - the Linux kernel's inability to gracefully handle low memory pressure

2019-08-05 Thread Suren Baghdasaryan
On Mon, Aug 5, 2019 at 12:31 PM Johannes Weiner wrote: > > On Mon, Aug 05, 2019 at 02:13:16PM +0200, Vlastimil Babka wrote: > > On 8/4/19 11:23 AM, Artem S. Tashkinov wrote: > > > Hello, > > > > > > There's this bug which has been bugging many people for many years > > > already and which is repro

Re: [PATCH 4.14 00/53] 4.14.137-stable review

2019-08-05 Thread shuah
On 8/5/19 7:02 AM, Greg Kroah-Hartman wrote: This is the start of the stable review cycle for the 4.14.137 release. There are 53 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made

Re: list corruption in deferred_split_scan()

2019-08-05 Thread Qian Cai
> On Aug 5, 2019, at 6:15 PM, Yang Shi wrote: > > > > On 7/25/19 2:46 PM, Yang Shi wrote: >> >> >> On 7/24/19 2:13 PM, Qian Cai wrote: >>> On Wed, 2019-07-10 at 17:43 -0400, Qian Cai wrote: Running LTP oom01 test case with swap triggers a crash below. Revert the series "Make

Re: [PATCH 4.19 00/74] 4.19.65-stable review

2019-08-05 Thread shuah
On 8/5/19 7:02 AM, Greg Kroah-Hartman wrote: This is the start of the stable review cycle for the 4.19.65 release. There are 74 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made b

[PATCH 01/17] soundwire: intel: prevent possible dereference in hw_params

2019-08-05 Thread Pierre-Louis Bossart
This should not happen in production systems but we should test for all callback arguments before invoking the config_stream callback. Update the prototype to clarify that the first argument is mandatory. Also use local variable instead of multiple dereferences to improve readability. Signed-off

[PATCH 07/17] soundwire: include mod_devicetable.h to avoid compiling warnings

2019-08-05 Thread Pierre-Louis Bossart
From: Bard liao When integrating SoundWire, kbuild throws this warning with randconfig: >> include/linux/soundwire/sdw.h:571:17: warning: 'struct sdw_device_id' declared inside parameter list will not be visible outside of this definition or declaration const struct sdw_device_id *

[PATCH 08/17] soundwire: stream: fix disable sequence

2019-08-05 Thread Pierre-Louis Bossart
When we disable the stream and then call hw_free, two bank switches will be handled and as a result we re-enable the stream on hw_free. Make sure the stream is disabled on both banks. TODO: we need to completely revisit all this and make sure we have a mirroring mechanism between current and alte

[PATCH 12/17] soundwire: cadence_master: make use of mclk_freq property

2019-08-05 Thread Pierre-Louis Bossart
Now that the prototype and Intel implementation are enabled, use this property to avoid hard-coded values. For example for ICL the mclk_freq value is 38.4 MHz while on CNL/CML it's 24 MHz. The mclk_freq should not be confused with the max_clk_freq, which si the maximum bus clock. The mclk_freq is

[PATCH 06/17] soundwire: cadence_master: use firmware defaults for frame shape

2019-08-05 Thread Pierre-Louis Bossart
Remove hard-coding and use firmware (BIOS/DT) values. If they are wrong use default 48x2 frame shape. Signed-off-by: Pierre-Louis Bossart --- drivers/soundwire/cadence_master.c | 26 +++--- 1 file changed, 23 insertions(+), 3 deletions(-) diff --git a/drivers/soundwire/caden

[PATCH 11/17] soundwire: intel: read mclk_freq property from firmware

2019-08-05 Thread Pierre-Louis Bossart
The BIOS provides an Intel-specific property, let's use it to avoid hard-coded clock dividers. Signed-off-by: Pierre-Louis Bossart --- drivers/soundwire/intel.c | 26 ++ 1 file changed, 26 insertions(+) diff --git a/drivers/soundwire/intel.c b/drivers/soundwire/intel.c i

[PATCH 13/17] soundwire: cadence_master: fix divider setting in clock register

2019-08-05 Thread Pierre-Louis Bossart
From: Rander Wang The existing code uses an OR operation which would mix the original divider setting with the new one, resulting in an invalid configuration that can make codecs hang. Add the mask definition and use cdns_updatel to update divider Signed-off-by: Rander Wang Signed-off-by: Pier

[PATCH 10/17] soundwire: add new mclk_freq field for properties

2019-08-05 Thread Pierre-Louis Bossart
To help pass platform-specific values, add a new field that can either be set by the Master driver or read from firmware (BIOS/DT). Signed-off-by: Pierre-Louis Bossart --- include/linux/soundwire/sdw.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/linux/soundwire/sdw.h b/include/

[PATCH 03/17] soundwire: cadence_master: revisit interrupt settings

2019-08-05 Thread Pierre-Louis Bossart
Adding missing interrupt masks (parity, etc) and missing checks. Clarify which masks are for which usage. Signed-off-by: Bard Liao Signed-off-by: Pierre-Louis Bossart --- drivers/soundwire/cadence_master.c | 29 + 1 file changed, 25 insertions(+), 4 deletions(-) dif

[PATCH 14/17] soundwire: intel: handle disabled links

2019-08-05 Thread Pierre-Louis Bossart
On most hardware platforms, SoundWire interfaces are pin-muxed with other interfaces (typically DMIC or I2S) and the status of each link needs to be checked at boot time. For Intel platforms, the BIOS provides a menu to enable/disable the links separately, and the information is provided to the OS

[PATCH 05/17] soundwire: export helpers to find row and column values

2019-08-05 Thread Pierre-Louis Bossart
Add a prefix for common tables and export 2 helpers to set the frame shapes based on row/col values. These changes simplify bandwidth allocation algorithms as well as the Cadence parts which all need to convert from frame shape to indices used by the standard. These helpers are used in the followi

[PATCH 16/17] soundwire: cadence_master: add kernel parameter to override interrupt mask

2019-08-05 Thread Pierre-Louis Bossart
The code has a set of defaults which may not be relevant in all cases, add kernel parameter as a helper - mostly for early board bring-up. Signed-off-by: Pierre-Louis Bossart --- drivers/soundwire/cadence_master.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/soundwire/caden

[PATCH 15/17] soundwire: intel_init: add kernel module parameter to filter out links

2019-08-05 Thread Pierre-Louis Bossart
The hardware and ACPI info may report the presence of links that are not physically enabled (e.g. due to pin-muxing or hardware reworks), which in turn can result in errors being thrown. This shouldn't be the case for production devices but will happen a lot on development devices - even more so wh

[PATCH 17/17] soundwire: intel: move shutdown() callback and don't export symbol

2019-08-05 Thread Pierre-Louis Bossart
All DAI callbacks are in intel.c except for shutdown. Move and remove export symbol Signed-off-by: Pierre-Louis Bossart --- drivers/soundwire/cadence_master.c | 14 -- drivers/soundwire/cadence_master.h | 2 -- drivers/soundwire/intel.c | 17 +++-- 3 files chang

[PATCH 09/17] soundwire: stream: remove unnecessary variable initializations

2019-08-05 Thread Pierre-Louis Bossart
A number of variables don't need to be initialized. In a couple of cases where we loop on a list of runtimes, the code handling of the 'bus' variable leads to warnings that it may not be initialized. Add a specific error case to trap such cases. Signed-off-by: Pierre-Louis Bossart --- drivers/s

[PATCH 04/17] soundwire: bus: improve dynamic debug comments for enumeration

2019-08-05 Thread Pierre-Louis Bossart
update comments to provide better understanding of enumeration flows. Signed-off-by: Pierre-Louis Bossart --- drivers/soundwire/bus.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/soundwire/bus.c b/drivers/soundwire/bus.c index 89d5f1537d9b..40f7d0dc59a6 100644

[PATCH 02/17] soundwire: intel: fix channel number reported by hardware

2019-08-05 Thread Pierre-Louis Bossart
On all released Intel controllers (CNL/CML/ICL), PDI2 reports an invalid count, force the correct hardware-supported value This may have to be revisited with platform-specific values if the hardware changes, but for now this is good enough. Signed-off-by: Pierre-Louis Bossart --- drivers/soundw

[PATCH 00/17] soundwire: fixes for 5.4

2019-08-05 Thread Pierre-Louis Bossart
This series provides an update on the initial RFC. Debugfs and Intel updates will be provided in follow-up patches. The order of patches was changed since the RFC so detailed change logs are provided below. Changes since RFC: patch1: feedback from Vinod and Cezary use local variable to reduce num

Re: [PATCH 5.2 000/131] 5.2.7-stable review

2019-08-05 Thread shuah
On 8/5/19 7:01 AM, Greg Kroah-Hartman wrote: This is the start of the stable review cycle for the 5.2.7 release. There are 131 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made by

Re: [PATCH v1 1/3] net: hisilicon: make hip04_tx_reclaim non-reentrant

2019-08-05 Thread Jakub Kicinski
On Sat, 3 Aug 2019 20:31:39 +0800, Jiangfeng Xiao wrote: > If hip04_tx_reclaim is interrupted while it is running > and then __napi_schedule continues to execute > hip04_rx_poll->hip04_tx_reclaim, reentrancy occurs > and oops is generated. So you need to mask the interrupt > during the hip04_tx_rec

Re: [PATCH] phy: qcom-qmp: Correct READY_STATUS poll break condition

2019-08-05 Thread Bjorn Andersson
On Fri 19 Jul 08:50 PDT 2019, Marc Gonzalez wrote: > On 13/06/2019 11:10, Marc Gonzalez wrote: > > > Here are my observations for a 8998 board: > > > > 1) If I apply only the readl_poll_timeout() fix (not the mask_pcs_ready > > fixup) > > qcom_pcie_probe() fails with a timeout in phy_init. > >

[PATCH] phy: qcom-qmp: Correct ready status, again

2019-08-05 Thread Bjorn Andersson
Despite extensive testing of 885bd765963b ("phy: qcom-qmp: Correct READY_STATUS poll break condition") I failed to conclude that the PHYSTATUS bit of the PCS_STATUS register used in PCIe and USB3 falls as the PHY gets ready. Similar to the prior bug with UFS the code will generally get past the che

Re: [PATCH v4 2/2] mmc: Add support for the ASPEED SD controller

2019-08-05 Thread Andrew Jeffery
On Mon, 5 Aug 2019, at 23:08, Adrian Hunter wrote: > On 5/08/19 5:51 AM, Andrew Jeffery wrote: > > Add a minimal driver for ASPEED's SD controller, which exposes two > > SDHCIs. > > > > The ASPEED design implements a common register set for the SDHCIs, and > > moves some of the standard configu

Re: [PATCH v4 1/6] KVM: Fix leak vCPU's VMCS value into other pCPU

2019-08-05 Thread Wanpeng Li
On Tue, 6 Aug 2019 at 07:17, Paolo Bonzini wrote: > > On 05/08/19 04:03, Wanpeng Li wrote: > > From: Wanpeng Li > > > > After commit d73eb57b80b (KVM: Boost vCPUs that are delivering interrupts), > > a > > five years old bug is exposed. Running ebizzy benchmark in three 80 vCPUs > > VMs > > on

Re: [PATCH] perf pmu-events: Fix the missing "cpu_clk_unhalted.core"

2019-08-05 Thread Jin, Yao
On 7/30/2019 9:43 AM, Jin, Yao wrote: On 7/30/2019 2:16 AM, Andi Kleen wrote: diff --git a/tools/perf/pmu-events/jevents.c b/tools/perf/pmu-events/jevents.c index 1a91a197cafb..d413761621b0 100644 --- a/tools/perf/pmu-events/jevents.c +++ b/tools/perf/pmu-events/jevents.c @@ -453,6 +453,7

Re: [PATCH v2] perf diff: Report noisy for cycles diff

2019-08-05 Thread Jin, Yao
Hi, Any comments for this version? Thanks Jin Yao On 7/25/2019 6:14 AM, Jin Yao wrote: This patch prints the stddev and hist for the cycles diff of program block. It can help us to understand if the cycles diff is noisy or not. This patch is inspired by Andi Kleen's patch https://lwn.net/Arti

Re: [PATCH net-next v3] net: phy: broadcom: add 1000Base-X support for BCM54616S

2019-08-05 Thread Tao Ren
On 8/5/19 1:45 PM, Heiner Kallweit wrote: > On 04.08.2019 21:22, Vladimir Oltean wrote: >> On Sun, 4 Aug 2019 at 19:07, Heiner Kallweit wrote: >>> >>> On 04.08.2019 17:59, Vladimir Oltean wrote: On Sun, 4 Aug 2019 at 17:52, Andrew Lunn wrote: > >>> The patchset looks better now. But

[PATCH] Input: applespi - use struct_size() helper

2019-08-05 Thread Gustavo A. R. Silva
One of the more common cases of allocation size calculations is finding the size of a structure that has a zero-sized array at the end, along with memory for some number of elements for that array. For example: struct touchpad_protocol { ... struct tp_fingerfingers[0]; };

Re: linux-next: build warning after merge of the driver-core tree

2019-08-05 Thread Saravana Kannan
On Sun, Aug 4, 2019 at 9:56 PM Stephen Rothwell wrote: > > Hi all, > > On Mon, 5 Aug 2019 13:04:03 +1000 Stephen Rothwell > wrote: > > > > After merging the driver-core tree, today's linux-next build (powerpc > > ppc64_defconfig) produced this warning: > > > > drivers/of/platform.c:674:12: warni

Re: Bisected: Kernel 4.14 + has 3 times higher write IO latency than Kernel 4.4 with raid1

2019-08-05 Thread NeilBrown
On Mon, Aug 05 2019, Jinpu Wang wrote: > Hi Neil, > > For the md higher write IO latency problem, I bisected it to these commits: > > 4ad23a97 MD: use per-cpu counter for writes_pending > 210f7cd percpu-refcount: support synchronous switch to atomic mode. > > Do you maybe have an idea? How can we

[PATCH] coresight: tmc-etr: Fix updating buffer in not-snapshot mode.

2019-08-05 Thread Yabin Cui
TMC etr always copies all available data to perf aux buffer, which may exceed the available space in perf aux buffer. It isn't suitable for not-snapshot mode, because: 1) It may overwrite previously written data. 2) It may make the perf_event_mmap_page->aux_head report having more or less data than

[PATCH 03/22] media: entity: Convert media_entity_get_fwnode_pad() args to const

2019-08-05 Thread Steve Longerbeam
The function media_entity_get_fwnode_pad() can be passed the const local_fwnode member from a struct fwnode_endpoint, so the fwnode argument should be a const pointer. Change the direction_flags argument to const in the process. Signed-off-by: Steve Longerbeam --- drivers/media/mc/mc-entity.c |

<    1   2   3   4   5   6   7   8   9   10   >