[PATCH] media: fdp1: Fix a memory leak bug

2019-08-17 Thread Wenwen Wang
In fdp1_open(), 'ctx' is allocated through kzalloc(). However, it is not deallocated if v4l2_ctrl_new_std() fails, leading to a memory leak bug. To fix this issue, free 'ctx' before going to the 'done' label. Signed-off-by: Wenwen Wang --- drivers/media/platform/rcar_fdp1.c | 1 + 1 file

Re: [PATCH] staging: android: Remove ion device tree bindings from the TODO

2019-08-17 Thread Donald Yandt
On Sun, Aug 18, 2019 at 1:03 AM Greg KH wrote: > > On Sat, Aug 17, 2019 at 05:37:58PM -0400, Donald Yandt wrote: > > This patch removes the todo for the ion chunk and > > carveout device tree bindings. > > > > Signed-off-by: Donald Yandt > > --- > > drivers/staging/android/TODO | 2 -- > > 1

[PATCH v2] media: saa7146: add cleanup in hexium_attach()

2019-08-17 Thread Wenwen Wang
If saa7146_register_device() fails, no cleanup is executed, leading to memory/resource leaks. To fix this issue, perform necessary cleanup work before returning the error. Signed-off-by: Wenwen Wang --- drivers/media/pci/saa7146/hexium_gemini.c | 3 +++ 1 file changed, 3 insertions(+) diff

[PATCH] media: saa7146: add cleanup in hexium_attach()

2019-08-17 Thread Wenwen Wang
If saa7146_register_device(), no cleanup is executed, leading to memory/resource leaks. To fix this issue, perform necessary cleanup work before returning the error. Signed-off-by: Wenwen Wang --- drivers/media/pci/saa7146/hexium_gemini.c | 3 +++ 1 file changed, 3 insertions(+) diff --git

[PATCH 2/2] dmaengine: milbeaut-xdmac: Add XDMAC driver for Milbeaut platforms

2019-08-17 Thread jassisinghbrar
From: Jassi Brar Driver for Socionext Milbeaut XDMAC controller. The controller only supports Mem-To-Mem transfers over upto 8 configurable channels. Signed-off-by: Jassi Brar --- drivers/dma/Kconfig | 10 + drivers/dma/Makefile | 1 + drivers/dma/milbeaut-xdmac.c | 426

[PATCH 1/2] dt-bindings: milbeaut-m10v-xdmac: Add Socionext Milbeaut XDMAC bindings

2019-08-17 Thread jassisinghbrar
From: Jassi Brar Document the devicetree bindings for Socionext Milbeaut XDMAC controller. Controller only supports Mem->Mem transfers. Number of physical channels are determined by the number of irqs registered. Signed-off-by: Jassi Brar --- .../bindings/dma/milbeaut-m10v-xdmac.txt | 24

[PATCH 0/2] Add support for AXI DMA controller on Milbeaut series

2019-08-17 Thread jassisinghbrar
From: Jassi Brar The following series adds AXI DMA (XDMAC) controller support on Milbeaut series. This controller is capable of only Mem<->MEM transfers. Number of channels is configurable {2,4,8} Jassi Brar (2): dt-bindings: milbeaut-m10v-xdmac: Add Socionext Milbeaut XDMAC bindings

[PATCH v2 2/2] dmaengine: milbeaut-hdmac: Add HDMAC driver for Milbeaut platforms

2019-08-17 Thread jassisinghbrar
From: Jassi Brar Driver for Socionext Milbeaut HDMAC controller. The controller has upto 8 floating channels, that need a predefined slave-id to work from a set of slaves. Signed-off-by: Jassi Brar --- drivers/dma/Kconfig | 10 + drivers/dma/Makefile | 1 +

[PATCH v2 1/2] dt-bindings: milbeaut-m10v-hdmac: Add Socionext Milbeaut HDMAC bindings

2019-08-17 Thread jassisinghbrar
From: Jassi Brar Document the devicetree bindings for Socionext Milbeaut HDMAC controller. Controller has upto 8 floating channels, that need a predefined slave-id to work from a set of slaves. Signed-off-by: Jassi Brar --- .../bindings/dma/milbeaut-m10v-hdmac.txt | 32

[PATCH v2 0/2] Add support for AHB DMA controller on Milbeaut series

2019-08-17 Thread jassisinghbrar
From: Jassi Brar Changes since v1: 1) Drop uncessary headers from driver 2) Some Cosmetic changes. 3) Define macro for magic numbers 4) Specify constraints on number of channels/irq in DT bindings Jassi Brar (2): dt-bindings: milbeaut-m10v-hdmac: Add Socionext Milbeaut HDMAC bindings

Re: [PATCH] staging: android: Remove ion device tree bindings from the TODO

2019-08-17 Thread Greg KH
On Sat, Aug 17, 2019 at 05:37:58PM -0400, Donald Yandt wrote: > This patch removes the todo for the ion chunk and > carveout device tree bindings. > > Signed-off-by: Donald Yandt > --- > drivers/staging/android/TODO | 2 -- > 1 file changed, 2 deletions(-) > > diff --git

[PATCH] media: dvb-core: fix a memory leak bug

2019-08-17 Thread Wenwen Wang
In dvb_create_media_entity(), 'dvbdev->entity' is allocated through kzalloc(). Then, 'dvbdev->pads' is allocated through kcalloc(). However, if kcalloc() fails, the allocated 'dvbdev->entity' is not deallocated, leading to a memory leak bug. To fix this issue, free 'dvbdev->entity' before

Re: devm_memremap_pages() triggers a kasan_add_zero_shadow() warning

2019-08-17 Thread Qian Cai
> On Aug 17, 2019, at 12:59 PM, Dan Williams wrote: > > On Sat, Aug 17, 2019 at 4:13 AM Qian Cai wrote: >> >> >> >>> On Aug 16, 2019, at 11:57 PM, Dan Williams wrote: >>> >>> On Fri, Aug 16, 2019 at 8:34 PM Qian Cai wrote: > On Aug 16, 2019, at 5:48 PM, Dan

Re: [GIT PULL] Hyper-V fixes for v5.3-rc

2019-08-17 Thread pr-tracker-bot
The pull request you sent on Sat, 17 Aug 2019 15:59:35 -0400: > git://git.kernel.org/pub/scm/linux/kernel/git/hyperv/linux.git > tags/hyperv-fixes-signed has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/85d8d3b172eb37b23dcdbe9fa7a85e343642bfea Thank you! --

Re: [PATCH v2 4/6] dt: bindings: add mt7621-pll dt binding documentation

2019-08-17 Thread Chuanhong Guo
Hi! On Sun, Aug 18, 2019 at 2:06 AM Oleksij Rempel wrote: > >> SYSC_REG_CPLL_CLKCFG1 register is a clock gate controller. It is used to > >> enable or disable clocks. > >> Jist wild assumption. All peripheral devices are suing bus clock. > > > > This assumption is incorrect. When this patchset

Re: [PATCH] csky: Fixup ioremap function losing

2019-08-17 Thread Guo Ren
Thx Christoph, On Fri, Aug 16, 2019 at 3:03 PM Christoph Hellwig wrote: > > On Thu, Aug 15, 2019 at 07:28:57PM +0800, guo...@kernel.org wrote: > > From: Guo Ren > > > > Implement the following apis to meet usage in different scenarios. > > > > - ioremap (NonCache + StrongOrder) > > -

Re: [PATCH] powerpc/32: Add VDSO version of getcpu

2019-08-17 Thread kbuild test robot
Hi Christophe, Thank you for the patch! Yet something to improve: [auto build test ERROR on linus/master] [cannot apply to v5.3-rc4 next-20190816] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH AUTOSEL 5.2 57/59] coredump: split pipe command whitespace before expanding template

2019-08-17 Thread Sasha Levin
On Wed, Aug 07, 2019 at 09:41:46AM +0800, Paul Wise wrote: On Tue, 2019-08-06 at 17:33 -0400, Sasha Levin wrote: From: Paul Wise [ Upstream commit 315c69261dd3fa12dbc830d4fa00d1fad98d3b03 ] The patch changes the behaviour of the interface between the Linux kernel and userspace core dump

Re: [PATCH AUTOSEL 5.2 07/59] xtensa: fix build for cores with coprocessors

2019-08-17 Thread Sasha Levin
On Tue, Aug 06, 2019 at 02:55:29PM -0700, Max Filippov wrote: Hello, On Tue, Aug 6, 2019 at 2:33 PM Sasha Levin wrote: From: Max Filippov [ Upstream commit e3cacb73e626d885b8cf24103fed0ae26518e3c4 ] Assembly entry/return abstraction change didn't add asmmacro.h include statement to

Re: [PATCH 4/5] clk: Add driver for Bitmain BM1880 SoC clock controller

2019-08-17 Thread Stephen Boyd
Quoting Manivannan Sadhasivam (2019-08-16 20:55:57) > Hi Stephen, > > On Wed, Aug 07, 2019 at 10:15:59PM -0700, Stephen Boyd wrote: > > Quoting Manivannan Sadhasivam (2019-07-05 08:14:39) > > > diff --git a/drivers/clk/Kconfig b/drivers/clk/Kconfig > > > index fc1e0cf44995..ffc61ed85ade 100644 >

Re: [PATCH 1/5] dt-bindings: clock: Add Bitmain BM1880 SoC clock controller binding

2019-08-17 Thread Stephen Boyd
Quoting Manivannan Sadhasivam (2019-08-16 20:58:45) > On Fri, Aug 16, 2019 at 08:46:11PM -0700, Stephen Boyd wrote: > > Quoting Manivannan Sadhasivam (2019-08-16 20:34:22) > > > On Wed, Aug 07, 2019 at 10:01:28PM -0700, Stephen Boyd wrote: > > > > Quoting Manivannan Sadhasivam (2019-07-05

Re: [PATCH] clk: Remove extraneous 'for' word in comments

2019-08-17 Thread Stephen Boyd
Quoting Rishi Gupta (2019-08-16 23:35:59) > An extra 'for' word is grammatically incorrect in the comment > 'verifying ops for multi-parent clks'. This commit removes > this extra for word. > > Signed-off-by: Rishi Gupta > --- Applied to clk-next

RE: [PATCH 5/6] clk: imx8mn: Add necessary frequency support for ARM PLL table

2019-08-17 Thread Stephen Boyd
Quoting Anson Huang (2019-08-17 15:22:01) > Hi, Stephen > > > Quoting anson.hu...@nxp.com (2019-08-15 03:59:42) > > > diff --git a/drivers/clk/imx/clk-imx8mn.c > > > b/drivers/clk/imx/clk-imx8mn.c index ecd1062..3f1239a 100644 > > > --- a/drivers/clk/imx/clk-imx8mn.c > > > +++

Re: [PATCH v3 1/2] clk: qcom: Add MSM8998 GPU Clock Controller (GPUCC) driver

2019-08-17 Thread Stephen Boyd
Quoting Jeffrey Hugo (2019-06-11 12:20:49) > + > +static int gpucc_msm8998_probe(struct platform_device *pdev) > +{ > + struct regmap *regmap; > + struct clk *xo; > + > + /* > +* We must have a valid XO to continue until orphan probe defer is > +* implemented. XO

Re: [PATCH linux-next] qcom: qcs404: remove COMPILE_TEST from CONFIG_INTERCONNECT_QCOM_QCS404

2019-08-17 Thread Stephen Boyd
Quoting Mao Wenan (2019-08-15 00:48:48) > There is one compilation error when CONFIG_INTERCONNECT_QCOM_QCS404=y and > CONFIG_INTERCONNECT_QCOM_SMD_RPM=y, as well as CONFIG_COMPILE_TEST=y, > but CONFIG_QCOM_SMD_RPM is not set, logs as below: > > drivers/interconnect/qcom/smd-rpm.o: In function

Re: [PATCH v2 03/14] cpufreq: qcom: Re-organise kryo cpufreq to use it for other nvmem based qcom socs

2019-08-17 Thread Stephen Boyd
Quoting Niklas Cassel (2019-07-25 03:41:31) > From: Sricharan R > > The kryo cpufreq driver reads the nvmem cell and uses that data to > populate the opps. There are other qcom cpufreq socs like krait which > does similar thing. Except for the interpretation of the read data, > rest of the

Regards, Mrs.Linda Rail written from Hospital.

2019-08-17 Thread Mrs. Linda
Hello My Dear. Please do not feel disturbed for contacting you, based on the critical condition I find mine self, though, it's not financial problem, but my health, you might have know that cancer is not what to talk home about, I am married to Mr. Abaulkarim Rail who worked with Tunisia embassy

Re: [PATCH v2 11/14] power: avs: Add support for CPR (Core Power Reduction)

2019-08-17 Thread Stephen Boyd
Quoting Niklas Cassel (2019-07-25 03:41:39) > diff --git a/drivers/power/avs/Kconfig b/drivers/power/avs/Kconfig > index b5a217b828dc..4d4d742b3c6f 100644 > --- a/drivers/power/avs/Kconfig > +++ b/drivers/power/avs/Kconfig > @@ -12,6 +12,21 @@ menuconfig POWER_AVS > > Say Y here to

Re: [PATCH] Partially revert "mm/memcontrol.c: keep local VM counters in sync with the hierarchical ones"

2019-08-17 Thread Yafang Shao
On Sun, Aug 18, 2019 at 3:14 AM Roman Gushchin wrote: > > On Sat, Aug 17, 2019 at 11:33:57AM +0800, Yafang Shao wrote: > > On Sat, Aug 17, 2019 at 8:47 AM Roman Gushchin wrote: > > > > > > Commit 766a4c19d880 ("mm/memcontrol.c: keep local VM counters in sync > > > with the hierarchical ones")

Re: [PATCH] pinctrl/qcom: Fix -Wimplicit-fallthrough

2019-08-17 Thread Bjorn Andersson
On Sat 17 Aug 01:25 PDT 2019, Alex Dewar wrote: > In pinctrl-spmi-gpio.c there is a switch case which is obviously > intended to fall through to the next label. Add a comment to suppress > -Wimplicit-fallthrough warning. > Thanks for your patch Alex, this was fixed in 6161dc03587b ("pinctrl:

Re: [PATCH 1/1] Fix: trace sched switch start/stop racy updates

2019-08-17 Thread Paul E. McKenney
On Sat, Aug 17, 2019 at 09:03:30PM +0100, Valentin Schneider wrote: > Apologies to Steve for continuing this thread when all he wanted was moving > an operation inside a mutex... > > On 17/08/2019 16:02, Mathieu Desnoyers wrote: > [...] > > However, if the state of "x" can be any pointer value,

[PATCH V2 3/6] cpufreq: Use imx-cpufreq-dt for i.MX8MN's speed grading

2019-08-17 Thread Anson Huang
Add i.MX8MN to blacklist, so that imx-cpufreq-dt driver can handle speed grading bits just like other i.MX8M SoCs. Signed-off-by: Anson Huang --- No changes. --- drivers/cpufreq/cpufreq-dt-platdev.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/cpufreq/cpufreq-dt-platdev.c

[PATCH V2 5/6] clk: imx8mn: Improve ARM PLL table to support CPU frequency scaling

2019-08-17 Thread Anson Huang
i.MX8MN supports CPU running at 1.5GHz/1.4GHz/1.2GHz, add missing frequency for ARM PLL table, also add .rate_count assignment which is necessary for searching required PLL rate from the table. Signed-off-by: Anson Huang --- Changes since V1: - Improve commit log, no code change. ---

[PATCH V2 2/6] arm64: dts: imx8mn-ddr4-evk: Add rohm,bd71847 PMIC support

2019-08-17 Thread Anson Huang
On i.MX8MN DDR4 EVK board, there is a rohm,bd71847 PMIC on i2c1 bus, enable it. Signed-off-by: Anson Huang --- No changes. --- arch/arm64/boot/dts/freescale/imx8mn-ddr4-evk.dts | 109 ++ 1 file changed, 109 insertions(+) diff --git

[PATCH V2 1/6] arm64: dts: imx8mn-ddr4-evk: Add i2c1 support

2019-08-17 Thread Anson Huang
Enable i2c1 on i.MX8MN DDR4 EVK board. Signed-off-by: Anson Huang --- No changes. --- arch/arm64/boot/dts/freescale/imx8mn-ddr4-evk.dts | 14 ++ 1 file changed, 14 insertions(+) diff --git a/arch/arm64/boot/dts/freescale/imx8mn-ddr4-evk.dts

[PATCH V2 6/6] arm64: dts: imx8mn: Add cpu-freq support

2019-08-17 Thread Anson Huang
Add A53 OPP table, cpu regulator and speed grading node to support cpu-freq driver. Signed-off-by: Anson Huang --- No changes. --- arch/arm64/boot/dts/freescale/imx8mn-ddr4-evk.dts | 4 +++ arch/arm64/boot/dts/freescale/imx8mn.dtsi | 41 +++ 2 files changed, 45

[PATCH V2 4/6] cpufreq: imx-cpufreq-dt: Add i.MX8MN support

2019-08-17 Thread Anson Huang
i.MX8MN has different speed grading definition as below, it has 4 bits to define speed grading, add support for it. SPEED_GRADE[3:0]MHz 2300 00012200 00102100 00112000 01001900 01011800

Re: [PATCH 1/1] Fix: trace sched switch start/stop racy updates

2019-08-17 Thread Paul E. McKenney
On Sat, Aug 17, 2019 at 01:28:48AM -0700, Linus Torvalds wrote: [ . . . ] > Put another way: a WRITE_ONCE() without a paired READ_ONCE() is almost > certainly pointless. "Your honor, I have no further questions at this time, but I reserve the right to recall this witness." Outside of things

RE: [PATCH 5/6] clk: imx8mn: Add necessary frequency support for ARM PLL table

2019-08-17 Thread Anson Huang
Hi, Stephen > Quoting anson.hu...@nxp.com (2019-08-15 03:59:42) > > diff --git a/drivers/clk/imx/clk-imx8mn.c > > b/drivers/clk/imx/clk-imx8mn.c index ecd1062..3f1239a 100644 > > --- a/drivers/clk/imx/clk-imx8mn.c > > +++ b/drivers/clk/imx/clk-imx8mn.c > > @@ -82,6 +84,7 @@ static struct

Re: [PATCH 1/1] Fix: trace sched switch start/stop racy updates

2019-08-17 Thread Paul E. McKenney
On Sat, Aug 17, 2019 at 12:40:40PM -0400, Steven Rostedt wrote: > On Sat, 17 Aug 2019 11:55:17 -0400 (EDT) > Mathieu Desnoyers wrote: > > > - On Aug 17, 2019, at 11:26 AM, rostedt rost...@goodmis.org wrote: > > > > > On Sat, 17 Aug 2019 10:40:31 -0400 (EDT) > > > Mathieu Desnoyers wrote: >

Re: [PATCH v4 1/2] rcu/tree: Add basic support for kfree_rcu() batching

2019-08-17 Thread Paul E. McKenney
On Sat, Aug 17, 2019 at 01:53:29AM -0400, Joel Fernandes wrote: > On Fri, Aug 16, 2019 at 10:20:23PM -0700, Paul E. McKenney wrote: > > On Sat, Aug 17, 2019 at 12:30:24AM -0400, Joel Fernandes wrote: > > > On Fri, Aug 16, 2019 at 08:56:37PM -0700, Paul E. McKenney wrote: > > > > On Fri, Aug 16,

Re: PROBLEM: 5.3.0-rc* causes iwlwifi failure

2019-08-17 Thread Stuart Little
After some private coaching from Serge Belyshev on git-revert I can confirm that reverting that commit atop the current tree resolves the issue (the wifi card scans for and finds networks just fine, no dmesg errors reported, etc.). On Sat, Aug 17, 2019 at 11:59:59AM +0300, Serge Belyshev wrote:

Re: [PATCH -rcu/dev] Please squash: fixup! rcu/tree: Add basic support for kfree_rcu() batching

2019-08-17 Thread Paul E. McKenney
On Sat, Aug 17, 2019 at 12:43:08AM -0400, Joel Fernandes wrote: > On Fri, Aug 16, 2019 at 09:38:54PM -0700, Paul Walmsley wrote: > > On Sat, 17 Aug 2019, Joel Fernandes (Google) wrote: > > > > > xchg() on a bool is causing issues on riscv and arm32. > > > > Indeed, it seems best not to use

[PATCH] staging: android: Remove ion device tree bindings from the TODO

2019-08-17 Thread Donald Yandt
This patch removes the todo for the ion chunk and carveout device tree bindings. Signed-off-by: Donald Yandt --- drivers/staging/android/TODO | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/android/TODO b/drivers/staging/android/TODO index fbf015cc6..767dd98fd 100644 ---

Re: /sys/devices/system/cpu/vulnerabilities/ doesn't show all known CPU vulnerabilities

2019-08-17 Thread Kernel User
Thomas Gleixner, Alright. Then I guess I am wasting everyone's time and everything is as it should be according to you. I will unsubscribe from this mailing list because it is flooding my mail box with so many messages and I don't know of any way to subscribe only to this particular thread.

Re: sched: Unexpected reschedule of offline CPU#2!

2019-08-17 Thread Thomas Gleixner
On Fri, 16 Aug 2019, Guenter Roeck wrote: > On Fri, Aug 16, 2019 at 12:22:22PM +0200, Thomas Gleixner wrote: > > diff --git a/arch/x86/kernel/process.c b/arch/x86/kernel/process.c > > index 75fea0d48c0e..625627b1457c 100644 > > --- a/arch/x86/kernel/process.c > > +++ b/arch/x86/kernel/process.c >

Re: [PATCH 1/1] Fix: trace sched switch start/stop racy updates

2019-08-17 Thread Valentin Schneider
Apologies to Steve for continuing this thread when all he wanted was moving an operation inside a mutex... On 17/08/2019 16:02, Mathieu Desnoyers wrote: [...] > However, if the state of "x" can be any pointer value, or a reference > count value, then not using "WRITE_ONCE()" to store a constant

[GIT PULL] Hyper-V fixes for v5.3-rc

2019-08-17 Thread Sasha Levin
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 The following changes since commit 5f9e832c137075045d15cd6899ab0505cfb2ca4b: Linus 5.3-rc1 (2019-07-21 14:05:38 -0700) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/hyperv/linux.git

Re: [PATCH net-next v3 00/12] net: stmmac: Improvements for -next

2019-08-17 Thread David Miller
From: Jose Abreu Date: Sat, 17 Aug 2019 20:54:39 +0200 > Couple of improvements for -next tree. More info in commit logs. Series applied.

Re: [PATCH 07/15] dt: thermal: tsens: Document interrupt support in tsens driver

2019-08-17 Thread Rob Herring
On Fri, Aug 16, 2019 at 5:02 PM Amit Kucheria wrote: > > On Sat, Aug 17, 2019 at 3:06 AM Rob Herring wrote: > > > > On Fri, Jul 26, 2019 at 03:48:42AM +0530, Amit Kucheria wrote: > > > Define two new required properties to define interrupts and > > > interrupt-names for tsens. > > > > > >

Re: [PATCH] FS: timerfd: Fix unexpected return value of timerfd_read function.

2019-08-17 Thread Thomas Gleixner
Arul, On Sat, 17 Aug 2019, Arul Jeniston wrote: > Do you agree the possibility of returning zero value from timerfd_read()? Obviosuly it happens. > > That has absolutely nothing to do with CLOCK_REALTIME. Your machines > > TSC is either going backwards or not synchronized between cores. > > >

Re: [PATCH] Partially revert "mm/memcontrol.c: keep local VM counters in sync with the hierarchical ones"

2019-08-17 Thread Roman Gushchin
On Sat, Aug 17, 2019 at 08:36:16AM +0200, Greg KH wrote: > On Fri, Aug 16, 2019 at 05:47:26PM -0700, Roman Gushchin wrote: > > Commit 766a4c19d880 ("mm/memcontrol.c: keep local VM counters in sync > > with the hierarchical ones") effectively decreased the precision of > > per-memcg vmstats_local

Re: [PATCH] Partially revert "mm/memcontrol.c: keep local VM counters in sync with the hierarchical ones"

2019-08-17 Thread Roman Gushchin
On Sat, Aug 17, 2019 at 11:33:57AM +0800, Yafang Shao wrote: > On Sat, Aug 17, 2019 at 8:47 AM Roman Gushchin wrote: > > > > Commit 766a4c19d880 ("mm/memcontrol.c: keep local VM counters in sync > > with the hierarchical ones") effectively decreased the precision of > > per-memcg vmstats_local

[PATCH net-next v3 02/12] net: stmmac: Prepare to add Split Header support

2019-08-17 Thread Jose Abreu
In order to add Split Header support, stmmac_rx() needs to take into account that packet may be split accross multiple descriptors. Refactor the logic of this function in order to support this scenario. Changes from v2: - Fixup if condition detection (Jakub) - Don't stop NAPI

[PATCH net-next v3 09/12] net: stmmac: selftests: Add tests for SA Insertion/Replacement

2019-08-17 Thread Jose Abreu
Add 4 new tests: - SA Insertion (register based) - SA Insertion (descriptor based) - SA Replacament (register based) - SA Replacement (descriptor based) Signed-off-by: Jose Abreu --- Cc: Giuseppe Cavallaro Cc: Alexandre Torgue Cc: Jose Abreu Cc: "David S.

[PATCH net-next v3 10/12] net: stmmac: xgmac: Add EEE support

2019-08-17 Thread Jose Abreu
Add support for EEE in XGMAC cores by implementing the necessary callbacks. Signed-off-by: Jose Abreu --- Cc: Giuseppe Cavallaro Cc: Alexandre Torgue Cc: Jose Abreu Cc: "David S. Miller" Cc: Maxime Coquelin Cc: net...@vger.kernel.org Cc: linux-st...@st-md-mailman.stormreply.com Cc:

[PATCH net-next v3 12/12] net: stmmac: selftests: Add selftest for VLAN TX Offload

2019-08-17 Thread Jose Abreu
Add 2 new selftests for VLAN Insertion offloading. Tests are for inner and outer VLAN offloading. Signed-off-by: Jose Abreu --- Cc: Giuseppe Cavallaro Cc: Alexandre Torgue Cc: Jose Abreu Cc: "David S. Miller" Cc: Maxime Coquelin Cc: net...@vger.kernel.org Cc:

[PATCH net-next v3 07/12] net: stmmac: Add ethtool register dump for XGMAC cores

2019-08-17 Thread Jose Abreu
Add the ethtool interface to dump the register map in XGMAC cores. Changes from v2: - Remove uneeded memset (Jakub) Signed-off-by: Jose Abreu --- Cc: Giuseppe Cavallaro Cc: Alexandre Torgue Cc: Jose Abreu Cc: "David S. Miller" Cc: Maxime Coquelin Cc: net...@vger.kernel.org Cc:

[PATCH net-next v3 01/12] net: stmmac: Get correct timestamp values from XGMAC

2019-08-17 Thread Jose Abreu
TX Timestamp in XGMAC comes from MAC instead of descriptors. Implement this in a new callback. Also, RX Timestamp in XGMAC must be cheked against corruption and we need a barrier to make sure that descriptor fields are read correctly. Changes from v2: - Rework return code check (Jakub)

[PATCH net-next v3 04/12] net: stmmac: Add Split Header support and enable it in XGMAC cores

2019-08-17 Thread Jose Abreu
Add the support for Split Header feature in the RX path and enable it in XGMAC cores. This does not impact neither beneficts bandwidth but it does reduces CPU usage because without the feature all the entire packet is memcpy'ed, while that with the feature only the header is. With Split Header

[PATCH net-next v3 06/12] net: stmmac: dwxgmac: Add Flexible PPS support

2019-08-17 Thread Jose Abreu
Add the support for Flexible PPS in XGMAC cores. Signed-off-by: Jose Abreu --- Cc: Giuseppe Cavallaro Cc: Alexandre Torgue Cc: Jose Abreu Cc: "David S. Miller" Cc: Maxime Coquelin Cc: net...@vger.kernel.org Cc: linux-st...@st-md-mailman.stormreply.com Cc:

[PATCH net-next v3 05/12] net: stmmac: Add a counter for Split Header packets

2019-08-17 Thread Jose Abreu
Add a counter that increments each time a packet with split header is received. Signed-off-by: Jose Abreu --- Cc: Giuseppe Cavallaro Cc: Alexandre Torgue Cc: Jose Abreu Cc: "David S. Miller" Cc: Maxime Coquelin Cc: net...@vger.kernel.org Cc: linux-st...@st-md-mailman.stormreply.com Cc:

[PATCH net-next v3 08/12] net: stmmac: Add support for SA Insertion/Replacement in XGMAC cores

2019-08-17 Thread Jose Abreu
Add the support for Source Address Insertion and Replacement in XGMAC cores. Two methods are supported: Descriptor based and register based. Signed-off-by: Jose Abreu --- Cc: Giuseppe Cavallaro Cc: Alexandre Torgue Cc: Jose Abreu Cc: "David S. Miller" Cc: Maxime Coquelin Cc:

[PATCH net-next v3 03/12] net: stmmac: xgmac: Correctly return that RX descriptor is not last one

2019-08-17 Thread Jose Abreu
Return the correct value when RX descriptor is not the last one. Signed-off-by: Jose Abreu --- Cc: Giuseppe Cavallaro Cc: Alexandre Torgue Cc: Jose Abreu Cc: "David S. Miller" Cc: Maxime Coquelin Cc: net...@vger.kernel.org Cc: linux-st...@st-md-mailman.stormreply.com Cc:

[PATCH net-next v3 11/12] net: stmmac: Add support for VLAN Insertion Offload

2019-08-17 Thread Jose Abreu
Adds the logic to insert a given VLAN ID in a packet. This is offloaded to HW and its descriptor based. For now, only XGMAC implements the necessary callbacks. Signed-off-by: Jose Abreu --- Cc: Giuseppe Cavallaro Cc: Alexandre Torgue Cc: Jose Abreu Cc: "David S. Miller" Cc: Maxime Coquelin

[PATCH net-next v3 00/12] net: stmmac: Improvements for -next

2019-08-17 Thread Jose Abreu
Couple of improvements for -next tree. More info in commit logs. --- Cc: Giuseppe Cavallaro Cc: Alexandre Torgue Cc: Jose Abreu Cc: "David S. Miller" Cc: Maxime Coquelin Cc: net...@vger.kernel.org Cc: linux-st...@st-md-mailman.stormreply.com Cc: linux-arm-ker...@lists.infradead.org Cc:

[PATCH v2 6/7] clk: Warn if clk_init_data is not zero initialized

2019-08-17 Thread Manivannan Sadhasivam
The new implementation for determining parent map uses multiple ways to pass parent info. The order in which it gets processed depends on the first available member. Hence, it is necessary to zero init the clk_init_data struct so that the expected member gets processed correctly. So, add a warning

[PATCH v2 7/7] clk: Zero init clk_init_data in helpers

2019-08-17 Thread Manivannan Sadhasivam
The clk_init_data struct needs to be initialized to zero for the new parent_map implementation to work correctly. Otherwise, the member which is available first will get processed. Signed-off-by: Manivannan Sadhasivam --- drivers/clk/clk-composite.c | 2 +- drivers/clk/clk-divider.c| 2 +-

[PATCH v2 5/7] MAINTAINERS: Add entry for BM1880 SoC clock driver

2019-08-17 Thread Manivannan Sadhasivam
Add MAINTAINERS entry for Bitmain BM1880 SoC clock driver. Signed-off-by: Manivannan Sadhasivam --- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 997a4f8fe88e..280defec35b2 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1503,8 +1503,10 @@ M:

[RFC PATCH] powerpc: use __builtin_trap() in BUG/WARN macros.

2019-08-17 Thread Christophe Leroy
The below exemples of use of WARN_ON() show that the result is sub-optimal in regard of the capabilities of powerpc. void test_warn1(unsigned long long a) { WARN_ON(a); } void test_warn2(unsigned long a) { WARN_ON(a); } void test_warn3(unsigned long a, unsigned long b) {

[PATCH v2 4/7] clk: Add common clock driver for BM1880 SoC

2019-08-17 Thread Manivannan Sadhasivam
Add common clock driver for Bitmain BM1880 SoC. The clock controller on BM1880 has supplies clocks to all peripherals in the form of gate clocks and composite clocks (fixed factor + gate). Signed-off-by: Manivannan Sadhasivam --- drivers/clk/Kconfig | 6 + drivers/clk/Makefile | 1

[PATCH v2 3/7] arm64: dts: bitmain: Source common clock for UART controllers

2019-08-17 Thread Manivannan Sadhasivam
Remove fixed clock and source common clock for UART controllers. Signed-off-by: Manivannan Sadhasivam --- arch/arm64/boot/dts/bitmain/bm1880-sophon-edge.dts | 9 - arch/arm64/boot/dts/bitmain/bm1880.dtsi| 12 2 files changed, 12 insertions(+), 9 deletions(-)

[PATCH v2 2/7] arm64: dts: bitmain: Add clock controller support for BM1880 SoC

2019-08-17 Thread Manivannan Sadhasivam
Add clock controller support for Bitmain BM1880 SoC. Signed-off-by: Manivannan Sadhasivam --- arch/arm64/boot/dts/bitmain/bm1880.dtsi | 16 1 file changed, 16 insertions(+) diff --git a/arch/arm64/boot/dts/bitmain/bm1880.dtsi b/arch/arm64/boot/dts/bitmain/bm1880.dtsi index

[PATCH v2 0/7] Add Bitmain BM1880 clock driver

2019-08-17 Thread Manivannan Sadhasivam
Hello, This patchset adds common clock driver for Bitmain BM1880 SoC clock controller. The clock controller consists of gate, divider, mux and pll clocks with different compositions. Hence, the driver uses composite clock structure in place where multiple clocking units are combined together.

[PATCH v2 1/7] dt-bindings: clock: Add devicetree binding for BM1880 SoC

2019-08-17 Thread Manivannan Sadhasivam
Add YAML devicetree binding for Bitmain BM1880 SoC. Signed-off-by: Manivannan Sadhasivam --- .../bindings/clock/bitmain,bm1880-clk.yaml| 83 +++ include/dt-bindings/clock/bm1880-clock.h | 82 ++ 2 files changed, 165 insertions(+) create mode 100644

Re: [PATCH] arch : arm : add a criteria for pfn_valid

2019-08-17 Thread Russell King - ARM Linux admin
On Sat, Aug 17, 2019 at 11:00:13AM +0800, Zhaoyang Huang wrote: > From: Zhaoyang Huang > > pfn_valid can be wrong while the MSB of physical address be trimed as pfn > larger than the max_pfn. What scenario are you addressing here? At a guess, you're addressing the non-LPAE case with PFNs that

Re: [PATCH 05/19] irqchip/mmp: do not use of_address_to_resource() to get mux regs

2019-08-17 Thread Marc Zyngier
On Fri, 16 Aug 2019 20:41:22 +0200 Lubomir Rintel wrote: > On Fri, 2019-08-09 at 13:12 +0100, Marc Zyngier wrote: > > On 09/08/2019 10:31, Lubomir Rintel wrote: > > > The "regs" property of the "mrvl,mmp2-mux-intc" devices are silly. They > > > are offsets from intc's base, not addresses on

Re: [PATCH v2 4/6] dt: bindings: add mt7621-pll dt binding documentation

2019-08-17 Thread Oleksij Rempel
Am 17.08.19 um 18:22 schrieb Chuanhong Guo: > Hi! > > On Sat, Aug 17, 2019 at 11:40 PM Oleksij Rempel wrote: > >> In provided link [0] the ralink_clk_init function is reading >> SYSC_REG_CPLL_CLKCFG0 R/W register. >> This register is used to determine clock source, clock freq and CPU or bus

Re: [PATCH] Fix an OOB bug in uac_mixer_unit_bmControls

2019-08-17 Thread Takashi Iwai
On Sat, 17 Aug 2019 18:47:05 +0200, Hui Peng wrote: > > No, there was not triggering. I found it accidentally when I was going through > the code. > > Yeah, you are right. it is handled in the last check. Is it defined in the > spec that the descriptor needs to have 4/6/2 additional bytes for

Re: [GIT PULL] RISC-V updates for v5.3-rc5

2019-08-17 Thread pr-tracker-bot
The pull request you sent on Fri, 16 Aug 2019 18:25:40 -0700 (PDT): > git://git.kernel.org/pub/scm/linux/kernel/git/riscv/linux.git > tags/riscv/for-v5.3-rc5 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/2f478b60118f48bf66eaddcca0d23e80f87a682d Thank you! --

Re: [PULL REQUEST] i2c for 5.3

2019-08-17 Thread pr-tracker-bot
The pull request you sent on Sat, 17 Aug 2019 16:12:32 +0200: > git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git i2c/for-current has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/05c525326957b504561d271f669d3b315930422f Thank you! -- Deet-doot-dot, I am a

Re: [PATCH] Staging: speakup: spk_types: fixed an unnamed parameter style issue

2019-08-17 Thread kbuild test robot
/commits/Matthew-Hanzelik/Staging-speakup-spk_types-fixed-an-unnamed-parameter-style-issue/20190817-235230 config: x86_64-allyesconfig (attached as .config) compiler: gcc-7 (Debian 7.4.0-10) 7.4.0 reproduce: # save the attached .config to linux build tree make ARCH=x86_64 If you fix

Re: devm_memremap_pages() triggers a kasan_add_zero_shadow() warning

2019-08-17 Thread Dan Williams
On Sat, Aug 17, 2019 at 4:13 AM Qian Cai wrote: > > > > > On Aug 16, 2019, at 11:57 PM, Dan Williams wrote: > > > > On Fri, Aug 16, 2019 at 8:34 PM Qian Cai wrote: > >> > >> > >> > >>> On Aug 16, 2019, at 5:48 PM, Dan Williams > >>> wrote: > >>> > >>> On Fri, Aug 16, 2019 at 2:36 PM Qian Cai

Re: [PATCH 1/1] Fix: trace sched switch start/stop racy updates

2019-08-17 Thread Steven Rostedt
On Sat, 17 Aug 2019 11:53:41 -0400 (EDT) Mathieu Desnoyers wrote: > kernel/trace/trace.c:tracing_record_taskinfo_sched_switch() > kernel/trace/trace.c:tracing_record_taskinfo() > > where @flags is used to control a few branches. I don't think any of those > would end up causing corruption if

Re: [PATCH 1/1] Fix: trace sched switch start/stop racy updates

2019-08-17 Thread Steven Rostedt
On Sat, 17 Aug 2019 11:55:17 -0400 (EDT) Mathieu Desnoyers wrote: > - On Aug 17, 2019, at 11:26 AM, rostedt rost...@goodmis.org wrote: > > > On Sat, 17 Aug 2019 10:40:31 -0400 (EDT) > > Mathieu Desnoyers wrote: > > > >> > I'm now even more against adding the READ_ONCE() or WRITE_ONCE().

Why the edge-triggered mode doesn't work for epoll file descriptor?

2019-08-17 Thread Heiher
Hello, I've added a pipe file descriptor (fd1) to an epoll (fd3) with EPOLLOUT in edge-triggered mode, and then added the fd3 to another epoll (fd4) with EPOLLIN in edge-triggered too. Next, waiting for fd4 without timeout. When fd1 to be writable, i think epoll_wait(fd4, ...) only return once,

Re: 5.3-rc3-ish VM crash: RIP: 0010:tcp_trim_head+0x20/0xe0

2019-08-17 Thread Eric Dumazet
On 8/17/19 10:24 AM, Sander Eikelenboom wrote: > On 12/08/2019 19:56, Eric Dumazet wrote: >> >> >> On 8/12/19 2:50 PM, Sander Eikelenboom wrote: >>> L.S., >>> >>> While testing a somewhere-after-5.3-rc3 kernel (which included the latest >>> net merge (33920f1ec5bf47c5c0a1d2113989bdd9dfb3fae9),

Re: [PATCH v2 4/6] dt: bindings: add mt7621-pll dt binding documentation

2019-08-17 Thread Chuanhong Guo
Hi! On Sat, Aug 17, 2019 at 11:40 PM Oleksij Rempel wrote: > In provided link [0] the ralink_clk_init function is reading > SYSC_REG_CPLL_CLKCFG0 R/W register. > This register is used to determine clock source, clock freq and CPU or bus > clocks. This register should only be changed by

Re: [PATCH] Fix an OOB bug in uac_mixer_unit_bmControls

2019-08-17 Thread Takashi Iwai
On Sat, 17 Aug 2019 17:57:38 +0200, Hui Peng wrote: > > Looking around, there are other suspicious codes. E.g., in the following > function, it seems to be the same as `uac_mixer_unit_bmControls`, but it is > accessing `desc->bNrInPins + 5`, in case of UAC_VERSION_1. > Is this intended? Yes,

Re: [PATCH 1/2] PTP: introduce new versions of IOCTLs

2019-08-17 Thread Joe Perches
On Sat, 2019-08-17 at 08:59 -0700, Richard Cochran wrote: > On Wed, Aug 14, 2019 at 10:47:11AM +0300, Felipe Balbi wrote: > > The current version of the IOCTL have a small problem which prevents us > > from extending the API by making use of reserved fields. In these new > > IOCTLs, we are now

Re: [PATCH 2/2] PTP: add support for one-shot output

2019-08-17 Thread Richard Cochran
On Wed, Aug 14, 2019 at 10:47:12AM +0300, Felipe Balbi wrote: > diff --git a/include/uapi/linux/ptp_clock.h b/include/uapi/linux/ptp_clock.h > index 039cd62ec706..9412b16cc8ed 100644 > --- a/include/uapi/linux/ptp_clock.h > +++ b/include/uapi/linux/ptp_clock.h > @@ -67,7 +67,9 @@ struct

Re: [PATCH 1/2] PTP: introduce new versions of IOCTLs

2019-08-17 Thread Richard Cochran
On Wed, Aug 14, 2019 at 10:47:11AM +0300, Felipe Balbi wrote: > The current version of the IOCTL have a small problem which prevents us > from extending the API by making use of reserved fields. In these new > IOCTLs, we are now making sure that flags and rsv fields are zero which > will allow us

Re: [PATCH 1/1] Fix: trace sched switch start/stop racy updates

2019-08-17 Thread Mathieu Desnoyers
- On Aug 17, 2019, at 11:26 AM, rostedt rost...@goodmis.org wrote: > On Sat, 17 Aug 2019 10:40:31 -0400 (EDT) > Mathieu Desnoyers wrote: > >> > I'm now even more against adding the READ_ONCE() or WRITE_ONCE(). >> >> I'm not convinced by your arguments. > > Prove to me that there's an

Re: [PATCH 1/1] Fix: trace sched switch start/stop racy updates

2019-08-17 Thread Mathieu Desnoyers
- On Aug 17, 2019, at 11:42 AM, rostedt rost...@goodmis.org wrote: > On Sat, 17 Aug 2019 10:27:39 -0400 (EDT) > Mathieu Desnoyers wrote: > >> I get your point wrt WRITE_ONCE(): since it's a cache it should not have >> user-visible effects if a temporary incorrect value is observed. Well in

Re: [PATCH 1/1] Fix: trace sched switch start/stop racy updates

2019-08-17 Thread Steven Rostedt
On Sat, 17 Aug 2019 10:27:39 -0400 (EDT) Mathieu Desnoyers wrote: > I get your point wrt WRITE_ONCE(): since it's a cache it should not have > user-visible effects if a temporary incorrect value is observed. Well in > reality, it's not a cache: if the lookup fails, it returns "<...>" instead, >

Re: [PATCH v2 4/6] dt: bindings: add mt7621-pll dt binding documentation

2019-08-17 Thread Oleksij Rempel
Hi, Am 17.08.19 um 16:42 schrieb Chuanhong Guo: Hi! On Tue, Aug 13, 2019 at 11:51 PM Rob Herring wrote: [...] +Example: + pll { + compatible = "mediatek,mt7621-pll"; You didn't answer Stephen's question on v1. I thought he was asking why there's a syscon in compatible

Re: [PATCH v2 4/6] dt: bindings: add mt7621-pll dt binding documentation

2019-08-17 Thread Oleksij Rempel
Hi, Am 17.08.19 um 16:42 schrieb Chuanhong Guo: Hi! On Tue, Aug 13, 2019 at 11:51 PM Rob Herring wrote: [...] +Example: + pll { + compatible = "mediatek,mt7621-pll"; You didn't answer Stephen's question on v1. I thought he was asking why there's a syscon in compatible

Re: kernel BUG at include/linux/skbuff.h:LINE! (2)

2019-08-17 Thread syzbot
syzbot has bisected this bug to: commit bc389fd101e57b36aacfaec2df8fe479eabb44ea Author: David S. Miller Date: Tue Jul 2 21:12:30 2019 + Merge branch 'macsec-fix-some-bugs-in-the-receive-path' bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=125c5c4c60 start commit:

Re: [PATCH 1/1] Fix: trace sched switch start/stop racy updates

2019-08-17 Thread Steven Rostedt
On Sat, 17 Aug 2019 10:40:31 -0400 (EDT) Mathieu Desnoyers wrote: > > I'm now even more against adding the READ_ONCE() or WRITE_ONCE(). > > I'm not convinced by your arguments. Prove to me that there's an issue here beyond theoretical analysis, then I'll consider that patch. Show me a

Re: [PATCH 1/1] Fix: trace sched switch start/stop racy updates

2019-08-17 Thread Mathieu Desnoyers
- On Aug 17, 2019, at 4:44 AM, Linus Torvalds torva...@linux-foundation.org wrote: > > But I'm seeing a lot of WRITE_ONCE(x, constantvalue) kind of things > and don't seem to find a lot of reason to think that they are any > inherently better than "x = constantvalue". If the only states

  1   2   >