Re: [GIT PULL] SafeSetID LSM changes for 5.4

2019-09-23 Thread Linus Torvalds
On Mon, Sep 23, 2019 at 4:30 PM Paul E. McKenney wrote: > > I pushed some (untested) commits out to the dev branch of -rcu, the > overall effect of which is shown in the patch below. The series > adds a new rcu_replace() to avoid confusion with swap(), replaces > uses of rcu_swap_protected()

Re: pstore does not work under xen

2019-09-23 Thread Boris Ostrovsky
On 9/23/19 6:59 PM, Kees Cook wrote: > On Mon, Sep 23, 2019 at 03:42:27PM +, James Dingwall wrote: >> On Thu, Sep 19, 2019 at 12:37:40PM -0400, Boris Ostrovsky wrote: >>> On 9/19/19 12:14 PM, James Dingwall wrote: On Thu, Sep 19, 2019 at 03:51:33PM +, Luck, Tony wrote: >> I have

Re: [PATCH] thermal: qoriq: add thermal monitor unit version 2 support

2019-09-23 Thread Zhang Rui
On Mon, 2019-09-23 at 09:24 +, Andy Tang wrote: > Hi Rui, Edubezval, > > Would you please review this patch? > CC Anson Huang. I'd prefer all the qoriq thermal patches go through his review first. thanks, rui > BR, > Andy > > > -Original Message- > > From: Andy Tang > > Sent:

Re: [PATCH 15/17] KVM: retpolines: x86: eliminate retpoline from vmx.c exit handlers

2019-09-23 Thread Andrea Arcangeli
Hi Paolo, On Tue, Sep 24, 2019 at 02:15:39AM +0200, Paolo Bonzini wrote: > Do you really need that? Why couldn't the handle_* functions simply be > exported from nested.c to vmx.c? I prefer the direct call too indeed. If Sean doesn't want to export those generic names to the whole kernel it

Re: [PATCH 15/17] KVM: retpolines: x86: eliminate retpoline from vmx.c exit handlers

2019-09-23 Thread Paolo Bonzini
On 24/09/19 02:35, Sean Christopherson wrote: >> I agree. I think the way Andrea did it in his patch may not the nicest >> but is (a bit surprisingly) the easiest and most maintainable. > Heh, which patch? The original patch of special casing the high > priority exits? Yes. Paolo

Re: [PATCH 15/17] KVM: retpolines: x86: eliminate retpoline from vmx.c exit handlers

2019-09-23 Thread Sean Christopherson
On Tue, Sep 24, 2019 at 02:16:36AM +0200, Paolo Bonzini wrote: > On 23/09/19 23:08, Andrea Arcangeli wrote: > > The two most attractive options to me remains what I already have > > implemented under #ifdef CONFIG_RETPOLINE with direct calls > > (optionally replacing the "if" with a small "switch"

Re: [PATCH 2/2] x86/mm: replace a goto by merging two if clause

2019-09-23 Thread Wei Yang
On Mon, Sep 23, 2019 at 11:22:31AM +0200, Peter Zijlstra wrote: >On Thu, Sep 19, 2019 at 10:08:44AM +0800, Wei Yang wrote: >> There is only one place to use good_area jump, which could be reduced by >> merging the following two if clause. >> >> Signed-off-by: Wei Yang >> --- >>

Re: [PATCH 03/17] KVM: monolithic: x86: handle the request_immediate_exit variation

2019-09-23 Thread Andrea Arcangeli
On Mon, Sep 23, 2019 at 04:45:00PM -0700, Sean Christopherson wrote: > With a straight rename to kvm_x86_() instead of wrappers, we > shouldn't need kvm_ops.c. kvm_ops.h might be helpful, but it'd be just > as easy to keep them in kvm_host.h and would likely yield a more > insightful diff[*].

Re: [PATCH 1/1] MAINTAINERS: add Yanjun to FORCEDETH maintainers list

2019-09-23 Thread Zhu Yanjun
On 2019/9/23 22:37, rain.1986.08...@gmail.com wrote: From: Rain River Yanjun has been spending quite a lot of time fixing bugs in FORCEDETH source code. I'd like to add Yanjun to maintainers list. Signed-off-by: Rain River Acked-by: Zhu Yanjun Thanks a lot. Zhu Yanjun ---

Re: [PATCH 15/17] KVM: retpolines: x86: eliminate retpoline from vmx.c exit handlers

2019-09-23 Thread Paolo Bonzini
On 23/09/19 23:08, Andrea Arcangeli wrote: > The two most attractive options to me remains what I already have > implemented under #ifdef CONFIG_RETPOLINE with direct calls > (optionally replacing the "if" with a small "switch" still under > CONFIG_RETPOLINE if we give up the prioritization of the

Re: [PATCH 15/17] KVM: retpolines: x86: eliminate retpoline from vmx.c exit handlers

2019-09-23 Thread Paolo Bonzini
On 23/09/19 22:23, Sean Christopherson wrote: > > +int nested_vmx_handle_vmx_instruction(struct kvm_vcpu *vcpu) > +{ > + switch (to_vmx(vcpu)->exit_reason) { > + case EXIT_REASON_VMCLEAR: > + return handle_vmclear(vcpu); > + case EXIT_REASON_VMLAUNCH: > +

Re: [PATCH v4] platform/chrome: wilco_ec: Add debugfs test_event file

2019-09-23 Thread Benson Leung
Hi Daniel, Thanks for sending this. On Wed, Sep 18, 2019 at 02:43:16PM -0600, Daniel Campello wrote: > This change introduces a new debugfs file 'test_event' that when written > to causes the EC to generate a test event. Please mention that this adds a second sub cmd for the test event, and

RE: [GIT PULL] Kselftest update for Linux 5.4-rc1

2019-09-23 Thread Tim.Bird
> -Original Message- > From: Ingo Molnar on Sunday, September 22, 2019 1:26 AM > > * Linus Torvalds wrote: > > > On Fri, Sep 20, 2019 at 9:35 AM Brendan Higgins > > wrote: > > > > > > Sorry about that. I am surprised that none of the other reviewers > > > brought this up. > > > > I

Re: [PATCH 15/17] KVM: retpolines: x86: eliminate retpoline from vmx.c exit handlers

2019-09-23 Thread Sean Christopherson
On Mon, Sep 23, 2019 at 07:43:07PM -0400, Andrea Arcangeli wrote: > On Mon, Sep 23, 2019 at 02:24:35PM -0700, Sean Christopherson wrote: > > An extra CALL+RET isn't going to be noticeable, especially on modern > > hardware as the high frequency VMWRITE/VMREAD fields should hit the > > shadow VMCS.

Re: [PATCH] seccomp: remove unused arg from secure_computing()

2019-09-23 Thread Kees Cook
On Mon, Sep 23, 2019 at 09:34:46PM +0200, Borislav Petkov wrote: > On Mon, Sep 23, 2019 at 11:41:59AM -0700, Andy Lutomirski wrote: > > On Mon, Sep 23, 2019 at 2:49 AM Borislav Petkov wrote: > > > > > > On Fri, Sep 20, 2019 at 03:19:09PM +0200, Christian Brauner wrote: > > > > While touching

Re: [PATCH v2 -rcu dev 0/5] kfree_rcu() additions for -rcu

2019-09-23 Thread Paul E. McKenney
On Fri, Aug 30, 2019 at 12:36:28PM -0400, Joel Fernandes (Google) wrote: > Hi, > > This is a series on top of the patch "rcu/tree: Add basic support for > kfree_rcu() batching". > > It adds performance tests, some clean ups and removal of "lazy" RCU callbacks. > > Now that kfree_rcu() is

Re: [PATCH 03/17] KVM: monolithic: x86: handle the request_immediate_exit variation

2019-09-23 Thread Sean Christopherson
On Mon, Sep 23, 2019 at 07:06:26PM -0400, Andrea Arcangeli wrote: > On Mon, Sep 23, 2019 at 03:35:26PM -0700, Sean Christopherson wrote: > > On Fri, Sep 20, 2019 at 05:24:55PM -0400, Andrea Arcangeli wrote: > > > request_immediate_exit is one of those few cases where the pointer to > > > function

Re: [PATCH 15/17] KVM: retpolines: x86: eliminate retpoline from vmx.c exit handlers

2019-09-23 Thread Andrea Arcangeli
On Mon, Sep 23, 2019 at 02:24:35PM -0700, Sean Christopherson wrote: > An extra CALL+RET isn't going to be noticeable, especially on modern > hardware as the high frequency VMWRITE/VMREAD fields should hit the > shadow VMCS. In your last email with regard to the inlining optimizations made

Re: [GIT PULL] SafeSetID LSM changes for 5.4

2019-09-23 Thread James Morris
On Mon, 23 Sep 2019, Linus Torvalds wrote: > Should we just remove safesetid again? It's not really maintained, and > it's apparently not used. It was merged in March (with the first > commit in January), and here we are at end of September and this > happens. My understanding is that SafeSetID

[PATCH 3/3] perf, stat: Fix free memory access / memory leaks in metrics

2019-09-23 Thread Andi Kleen
From: Andi Kleen Make sure to not free the name passed in by the caller, but free all the allocated ids when parsing expressions. The loop at the end knows that the first entry shouldn't be freed, so make sure the caller name is the first entry. Fixes % perf stat -M

[PATCH 2/3] perf, expr: Remove assert usage

2019-09-23 Thread Andi Kleen
From: Andi Kleen My "compile perf statically" setup doesn't like this assert for unknown reasons. Replace it with a standard BUG_ON Signed-off-by: Andi Kleen --- tools/perf/util/expr.y | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/perf/util/expr.y

[PATCH 1/3] perf, evlist: Fix access of freed id arrays

2019-09-23 Thread Andi Kleen
From: Andi Kleen I'm not fully sure if this is the correct fix, but without this I get crashes on more complex perf stat metric usages. The problem is that part of the state gets freed when a weak group fails, but then is later still used. Just don't free the ids, we're going to reuse them

Re: [GIT PULL] SafeSetID LSM changes for 5.4

2019-09-23 Thread Paul E. McKenney
On Mon, Sep 23, 2019 at 12:01:49PM -0700, Linus Torvalds wrote: > On Wed, Sep 18, 2019 at 10:41 AM Micah Morton wrote: > > > > Fix for SafeSetID bug that was introduced in 5.3 > > So this seems to be a good fix, but the bug itself came from the fact that > > rcu_swap_protected(..) > > is

Re: [PATCH] x86: use the correct function type for native_set_fixmap

2019-09-23 Thread Kees Cook
On Fri, Sep 13, 2019 at 02:14:02PM -0700, Sami Tolvanen wrote: > We call native_set_fixmap indirectly through the function pointer > struct pv_mmu_ops::set_fixmap, which expects the first parameter to be > 'unsigned' instead of 'enum fixed_addresses'. This patch changes the > function type for

[tip:WIP.core/toplevel 4/6] drivers/sound/pci/hda/hda_proc.c:516:18: sparse: sparse: bad integer constant expression

2019-09-23 Thread kbuild test robot
tree: https://kernel.googlesource.com/pub/scm/linux/kernel/git/tip/tip.git WIP.core/toplevel head: 166a63584297d3e1e1d7d380ee13dfe1a871ab04 commit: 7eff58ad913615232613491bec0f54d34ce73bda [4/6] toplevel: Fix up drivers/sound/ movement effects reproduce: # apt-get install sparse

Re: [PATCH] mm: fix -Wmissing-prototypes warnings

2019-09-23 Thread Kees Cook
On Mon, Sep 09, 2019 at 09:52:40AM +0200, David Hildenbrand wrote: > On 28.08.19 09:42, Yi Wang wrote: > > We get two warnings when build kernel W=1: > > mm/shuffle.c:36:12: warning: no previous prototype for ‘shuffle_show’ > > [-Wmissing-prototypes] > > mm/sparse.c:220:6: warning: no previous

Re: [PATCH] efi/libstub/arm64: Report meaningful relocation errors

2019-09-23 Thread Kees Cook
On Fri, Sep 06, 2019 at 10:34:47AM -0700, Ard Biesheuvel wrote: > On Fri, 6 Sep 2019 at 03:44, Will Deacon wrote: > > > > On Wed, Sep 04, 2019 at 01:38:04PM -0700, Kees Cook wrote: > > > On Wed, Sep 04, 2019 at 11:38:03AM +0100, Will Deacon wrote: > > > > On Wed, Aug 14, 2019 at 01:55:50PM -0700,

Re: [PATCH] uaccess: Disallow > INT_MAX copy sizes

2019-09-23 Thread Kees Cook
On Sun, Aug 25, 2019 at 04:18:56PM -0700, Kees Cook wrote: > As we've done with VFS, string operations, etc, reject usercopy sizes > larger than INT_MAX, which would be nice to have for catching bugs > related to size calculation overflows[1]. > > This adds 10 bytes to x86_64 defconfig text and

[GIT PULL] MFD for v5.4

2019-09-23 Thread Lee Jones
Linus, Enjoy! The following changes since commit 5f9e832c137075045d15cd6899ab0505cfb2ca4b: Linus 5.3-rc1 (2019-07-21 14:05:38 -0700) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git mfd-next-5.4 for you to fetch changes up to

Re: [PATCH 03/17] KVM: monolithic: x86: handle the request_immediate_exit variation

2019-09-23 Thread Andrea Arcangeli
On Mon, Sep 23, 2019 at 03:35:26PM -0700, Sean Christopherson wrote: > On Fri, Sep 20, 2019 at 05:24:55PM -0400, Andrea Arcangeli wrote: > > request_immediate_exit is one of those few cases where the pointer to > > function of the method isn't fixed at build time and it requires > > special

[GIT PULL] Backlight for v5.4

2019-09-23 Thread Lee Jones
Linus, Enjoy! The following changes since commit 5f9e832c137075045d15cd6899ab0505cfb2ca4b: Linus 5.3-rc1 (2019-07-21 14:05:38 -0700) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/lee/backlight.git tags/backlight-next-5.4 for you to fetch changes

Re: pstore does not work under xen

2019-09-23 Thread Kees Cook
On Mon, Sep 23, 2019 at 03:42:27PM +, James Dingwall wrote: > On Thu, Sep 19, 2019 at 12:37:40PM -0400, Boris Ostrovsky wrote: > > On 9/19/19 12:14 PM, James Dingwall wrote: > > > On Thu, Sep 19, 2019 at 03:51:33PM +, Luck, Tony wrote: > > >>> I have been investigating a regression in our

[GIT PULL] PCI changes for v5.4

2019-09-23 Thread Bjorn Helgaas
The following changes since commit 5f9e832c137075045d15cd6899ab0505cfb2ca4b: Linus 5.3-rc1 (2019-07-21 14:05:38 -0700) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git tags/pci-v5.4-changes for you to fetch changes up to

[tip:WIP.core/toplevel 4/6] drivers/sound/soc/intel/skylake/skl-sst-ipc.c:14:10: fatal error: drivers/sound/hdaudio_ext.h: No such file or directory

2019-09-23 Thread kbuild test robot
tree: https://kernel.googlesource.com/pub/scm/linux/kernel/git/tip/tip.git WIP.core/toplevel head: 166a63584297d3e1e1d7d380ee13dfe1a871ab04 commit: 7eff58ad913615232613491bec0f54d34ce73bda [4/6] toplevel: Fix up drivers/sound/ movement effects config: x86_64-rhel-7.6 (attached as .config)

Re: general protection fault in xsk_map_update_elem

2019-09-23 Thread Daniel Borkmann
On Mon, Sep 23, 2019 at 08:49:11AM -0700, syzbot wrote: > Hello, > > syzbot found the following crash on: > > HEAD commit:b41dae06 Merge tag 'xfs-5.4-merge-7' of git://git.kernel.o.. > git tree: net-next > console output: https://syzkaller.appspot.com/x/log.txt?x=130b25ad60 >

[PATCH v2] netfilter: use __u8 instead of uint8_t in uapi header

2019-09-23 Thread Masahiro Yamada
When CONFIG_UAPI_HEADER_TEST=y, exported headers are compile-tested to make sure they can be included from user-space. Currently, linux/netfilter_bridge/ebtables.h is excluded from the test coverage. To make it join the compile-test, we need to fix the build errors attached below. For a case

Re: [PATCH 1/3] regulator: core: fix boot-on regulators use_count usage

2019-09-23 Thread Doug Anderson
Hi, On Mon, Sep 23, 2019 at 11:49 AM Mark Brown wrote: > > On Mon, Sep 23, 2019 at 11:36:11AM -0700, Doug Anderson wrote: > > On Mon, Sep 23, 2019 at 11:14 AM Mark Brown wrote: > > > > Boot on means that it's powered on when the kernel starts, it's > > > for regulators that we can't read back

[GIT PULL] Kselftest update for Linux 5.4-rc1

2019-09-23 Thread Shuah Khan
Hi Linus, Please pull the following Kselftest update for Linux 5.4-rc1. This Kselftest update for Linux 5.4-rc1 consists of several fixes to existing tests. diff is attached. This pull has just the ksleftest patches I sent in my previous pull request. I dropped the KUnit patches and rebased.

Re: [PATCH 03/17] KVM: monolithic: x86: handle the request_immediate_exit variation

2019-09-23 Thread Sean Christopherson
On Fri, Sep 20, 2019 at 05:24:55PM -0400, Andrea Arcangeli wrote: > request_immediate_exit is one of those few cases where the pointer to > function of the method isn't fixed at build time and it requires > special handling because hardware_setup() may override it at runtime. > > Signed-off-by:

Re: [PATCH 01/17] x86: spec_ctrl: fix SPEC_CTRL initialization after kexec

2019-09-23 Thread Sean Christopherson
On Mon, Sep 23, 2019 at 01:34:21PM -0400, Andrea Arcangeli wrote: > Per subject of the patch, 14 is also an optimization that while not a > strict requirement, is somewhat related to the monolithic conversion > because in fact it may naturally disappear if I rename the vmx/svm > functions

Re: Lease semantic proposal

2019-09-23 Thread Dave Chinner
On Mon, Sep 23, 2019 at 12:08:53PM -0700, Ira Weiny wrote: > > Since the last RFC patch set[1] much of the discussion of supporting RDMA with > FS DAX has been around the semantics of the lease mechanism.[2] Within that > thread it was suggested I try and write some documentation and/or tests

[PATCH] x86, realmode: explicitly set ENTRY in linker script

2019-09-23 Thread Nick Desaulniers
Linking with ld.lld via $ make LD=ld.lld produces the warning: ld.lld: warning: cannot find entry symbol _start; defaulting to 0x1000 Linking with ld.bfd shows the default entry is 0x1000: $ readelf -h arch/x86/realmode/rm/realmode.elf | grep Entry Entry point address: 0x1000

Re: [PATCH v8 9/9] leds: Update the lp55xx to use the multi color framework

2019-09-23 Thread Jacek Anaszewski
Dan, On 9/23/19 9:29 PM, Dan Murphy wrote: > Jacek > > On 9/21/19 1:06 PM, Jacek Anaszewski wrote: >> Dan, >> >> On 9/20/19 7:41 PM, Dan Murphy wrote: >>> Update the lp5523 to use the multi color framework. >>> >>> Signed-off-by: Dan Murphy >>> --- >>> drivers/leds/leds-lp5523.c

Re: [PATCH] NTB: fix IDT Kconfig typos/spellos

2019-09-23 Thread Jon Mason
On Wed, Sep 18, 2019 at 1:58 PM Randy Dunlap wrote: > > From: Randy Dunlap > > Fix typos in drivers/ntb/hw/idt/Kconfig. > Use consistent spelling and capitalization. > > Fixes: bf2a952d31d2 ("NTB: Add IDT 89HPESxNTx PCIe-switches support") > Signed-off-by: Randy Dunlap > Cc: Jon Mason > Cc:

Re: [PATCH 2/2] ntb_hw_amd: Add memory window support for new AMD hardware

2019-09-23 Thread Jon Mason
On Sun, Sep 15, 2019 at 10:08 AM Mehta, Sanju wrote: > > From: Sanjay R Mehta > > The AMD new hardware uses BAR23 and BAR45 as memory windows > as compared to previos where BAR1, BAR23 and BAR45 is used > for memory windows. > > This patch add support for both AMD hardwares. I pulled both of

Re: [PATCH] xen/trace: avoid clang warning on function pointers

2019-09-23 Thread Nick Desaulniers
On Mon, Sep 23, 2019 at 3:06 PM Nick Desaulniers wrote: > Steven, Ingo, would one of you mind picking up this fix, please? See > for multiple reports: > https://github.com/ClangBuiltLinux/linux/issues/216 Sorry, https://github.com/ClangBuiltLinux/linux/issues/97 is the link. -- Thanks, ~Nick

Re: [PATCH] xen/trace: avoid clang warning on function pointers

2019-09-23 Thread Nick Desaulniers
On Fri, Jul 12, 2019 at 10:41 AM Nathan Chancellor wrote: > > On Fri, Jul 12, 2019 at 10:58:48AM +0200, Arnd Bergmann wrote: > > clang-9 does not like the way that the is_signed_type() compares > > function pointers deep inside of the trace even macros: > > > > In file included from

Re: [PATCH] media: i2c: adv7180: fix adv7280 BT.656-4 compatibility

2019-09-23 Thread Tim Harvey
On Thu, Aug 29, 2019 at 7:29 AM Niklas Söderlund wrote: > > Hi, > > On 2019-08-29 13:43:49 +0200, Hans Verkuil wrote: > > Adding Niklas. > > > > Niklas, can you take a look at this? > > I'm happy to have a look at this. I'm currently moving so all my boards > are in a box somewhere. I hope to

Re: [PATCH 1/5] regulator: da9062: fix suspend_enable/disable preparation

2019-09-23 Thread Marco Felsch
Hi Adam, On 19-09-23 16:03, Adam Thomson wrote: > On 17 September 2019 13:43, Marco Felsch wrote: > > > Currently the suspend reg_field maps to the pmic voltage selection bits > > and is used during suspend_enabe/disable() and during get_mode(). This > > seems to be wrong for both use cases. > >

Re: [PATCH v8 8/9] leds: lp50xx: Add the LP50XX family of the RGB LED driver

2019-09-23 Thread Jacek Anaszewski
Dan, On 9/23/19 7:56 PM, Dan Murphy wrote: > Jacek > > On 9/21/19 10:11 AM, Jacek Anaszewski wrote: >> Dan, >> >> On 9/20/19 7:41 PM, Dan Murphy wrote: >>> Introduce the LP5036/30/24/18/12/9 RGB LED driver. >>> The difference in these parts are the number of >>> LED outputs where the: >>> >>>

Re: Fwd: [PATCH] fs: direct-io: Fixed a Documentation build warn

2019-09-23 Thread Shuah Khan
On 9/23/19 3:03 PM, Madhuparna Bhowmik wrote: Fixed Excess function parameters warning. warning: Excess function parameter 'offset' description in 'dio_complete'. Removed the description of the local variable offset from the description for arguments of a function and added it with the

Re: [PATCH v2 1/2] mmc: sdhci: Let drivers define their DMA mask

2019-09-23 Thread Ulf Hansson
On Mon, 23 Sep 2019 at 12:08, Thierry Reding wrote: > > From: Adrian Hunter > > Add host operation ->set_dma_mask() so that drivers can define their own > DMA masks. > > Signed-off-by: Adrian Hunter > Tested-by: Nicolin Chen > Signed-off-by: Thierry Reding Applied for fixes and adding a

Re: [PATCH v2 2/2] mmc: tegra: Implement ->set_dma_mask()

2019-09-23 Thread Ulf Hansson
On Mon, 23 Sep 2019 at 12:08, Thierry Reding wrote: > > From: Nicolin Chen > > The SDHCI controller on Tegra186 supports 40-bit addressing, which is > usually enough to address all of system memory. However, if the SDHCI > controller is behind an IOMMU, the address space can go beyond. This >

Re: [PATCH V8 7/8] Docs: misc: xilinx_sdfec: Add documentation

2019-09-23 Thread Kees Cook
On Sun, Jul 07, 2019 at 01:15:41AM +0100, Dragan Cvetic wrote: > Add SD-FEC driver documentation. > > Signed-off-by: Derek Kiernan > Signed-off-by: Dragan Cvetic > --- > Documentation/misc-devices/index.rst | 1 + > 1 file changed, 1 insertion(+) Hi! It looks like

Re: [PATCH] smack: include linux/watch_queue.h

2019-09-23 Thread Casey Schaufler
On 9/9/2019 1:46 PM, Arnd Bergmann wrote: > In some randconfig builds, the lack of an explicit #include > in smack_lsm.c causes a build failure: What tree/branch are you working with? I don't see this. > > security/smack/smack_lsm.c:4384:7: error: incomplete definition of type > 'struct

Re: [PATCH] smack: fix an compile error in smack_post_notification

2019-09-23 Thread Casey Schaufler
On 9/22/2019 8:16 PM, zhong jiang wrote: > I hit the following error when compile the kernel. What tree/branch are you working with? I don't see this. > > security/smack/smack_lsm.c: In function smack_post_notification: > security/smack/smack_lsm.c:4383:7: error: dereferencing pointer to

Re: [PATCH v8 7/9] dt: bindings: lp50xx: Introduce the lp50xx family of RGB drivers

2019-09-23 Thread Jacek Anaszewski
Dan, On 9/23/19 5:28 PM, Dan Murphy wrote: > Jacek > > On 9/21/19 10:13 AM, Jacek Anaszewski wrote: >> Dan, >> >> On 9/20/19 7:41 PM, Dan Murphy wrote: >>> Introduce the bindings for the Texas Instruments LP5036, LP5030, LP5024, >>> LP5018, LP5012 and LP5009 RGB LED device driver.  The >>>

Re: [PATCH V9 5/5] mmc: host: sdhci-pci: Add Genesys Logic GL975x support

2019-09-23 Thread Michael K. Johnson
On Wed, Sep 18, 2019 at 02:07:51PM +0300, Adrian Hunter wrote: > On 18/09/19 1:47 PM, Michael K. Johnson wrote: > > I see that the first four patches made it into Linus's kernel > > yesterday. Is there any chance of this final patch that actually > > enables the hardware making it into another

Re: [GIT PULL] Smack patches for v5.4 - retry

2019-09-23 Thread Linus Torvalds
On Mon, Sep 23, 2019 at 2:35 PM Linus Torvalds wrote: > > On Mon, Sep 23, 2019 at 1:14 PM Casey Schaufler > wrote: > > > > Thank for the instruction. I think this is correct. > > Looks fine, pulled. Oh, btw, can you get more signatures on your pgp key? I actually care more about having a key

Re: [PATCH v8 6/9] leds: multicolor: Introduce a multicolor class definition

2019-09-23 Thread Jacek Anaszewski
Dan, On 9/23/19 5:14 PM, Dan Murphy wrote: > Jacek > > On 9/21/19 8:30 AM, Jacek Anaszewski wrote: >> Dan, >> >> On 9/20/19 7:41 PM, Dan Murphy wrote: >>> Introduce a multicolor class that groups colored LEDs >>> within a LED node. >>> >>> The framework allows for dynamically setting individual

Re: [GIT PULL] Smack patches for v5.4 - retry

2019-09-23 Thread Linus Torvalds
On Mon, Sep 23, 2019 at 1:14 PM Casey Schaufler wrote: > > Thank for the instruction. I think this is correct. Looks fine, pulled. That said, when I look closer: > Jia-Ju Bai (1): > security: smack: Fix possible null-pointer dereferences in > smack_socket_sock_rcv_skb() This one seems

Re: [PATCH] base: soc: Export soc_device_to_device API

2019-09-23 Thread mnalajal
On 2019-09-19 23:10, Greg KH wrote: On Thu, Sep 19, 2019 at 08:36:51PM -0700, Bjorn Andersson wrote: On Thu 19 Sep 15:45 PDT 2019, Greg KH wrote: > On Thu, Sep 19, 2019 at 03:40:17PM -0700, Bjorn Andersson wrote: > > On Thu 19 Sep 15:25 PDT 2019, Greg KH wrote: > > > > > On Thu, Sep 19, 2019

Re: [PATCH RFC 1/2] perf tools: Support single perf.data file directory

2019-09-23 Thread Jiri Olsa
On Mon, Sep 16, 2019 at 11:56:45AM +0300, Adrian Hunter wrote: > Support directory output that contains a regular perf.data file. This is > preparation for adding support for putting a copy of /proc/kcore in that > directory. > > Distinguish the multiple file case from the regular (single)

Re: [PATCH] clk: at91: avoid sleeping early

2019-09-23 Thread Alexandre Belloni
On 23/09/2019 09:58:47-0700, Stephen Boyd wrote: > Quoting Alexandre Belloni (2019-09-20 08:39:06) > > It is not allowed to sleep to early in the boot process and this may lead > > to kernel issues if the bootloader didn't prepare the slow clock and main > > clock. > > > > This results in the

[PATCH 1/1] powerpc: kvm: Reduce calls to get current->mm by storing the value locally

2019-09-23 Thread Leonardo Bras
Reduces the number of calls to get_current() in order to get the value of current->mm by doing it once and storing the value, since it is not supposed to change inside the same process). Signed-off-by: Leonardo Bras --- Re-sending to all lists involved. (I missed kvm ones)

Re: [PATCH] kcm: use BPF_PROG_RUN

2019-09-23 Thread Eric Dumazet
On 9/6/19 10:06 AM, Alexei Starovoitov wrote: > On Fri, Sep 6, 2019 at 3:03 AM Yonghong Song wrote: >> >> >> >> On 9/5/19 2:15 PM, Sami Tolvanen wrote: >>> Instead of invoking struct bpf_prog::bpf_func directly, use the >>> BPF_PROG_RUN macro. >>> >>> Signed-off-by: Sami Tolvanen >> >>

Re: For review: pidfd_send_signal(2) manual page

2019-09-23 Thread Eric W. Biederman
"Michael Kerrisk (man-pages)" writes: > Hello Christian and all, > > Below, I have the rendered version of the current draft of > the pidfd_send_signal(2) manual page that I have written. > The page source can be found in a Git branch at: >

Re: "Pick the right alignment default when creating dax devices" failed to build on powerpc

2019-09-23 Thread Dan Williams
On Sun, Sep 22, 2019 at 5:04 AM Michael Ellerman wrote: > > > > On 21 September 2019 4:31:16 am AEST, Dan Williams > wrote: > >On Fri, Sep 20, 2019 at 11:18 AM Qian Cai wrote: > >> > >> On Fri, 2019-09-20 at 19:55 +0530, Aneesh Kumar K.V wrote: > >> > Qian Cai writes: > >> > > >> > > The

Re: [PATCH v5 0/7] hugetlb_cgroup: Add hugetlb_cgroup reservation limits

2019-09-23 Thread Mike Kravetz
On 9/23/19 12:18 PM, Mina Almasry wrote: > On Mon, Sep 23, 2019 at 10:47 AM Mike Kravetz wrote: >> >> On 9/19/19 3:24 PM, Mina Almasry wrote: >>> Patch series implements hugetlb_cgroup reservation usage and limits, which >>> track hugetlb reservations rather than hugetlb memory faulted in.

Re: [PATCH 15/17] KVM: retpolines: x86: eliminate retpoline from vmx.c exit handlers

2019-09-23 Thread Sean Christopherson
On Mon, Sep 23, 2019 at 05:08:38PM -0400, Andrea Arcangeli wrote: > Hello, > > On Mon, Sep 23, 2019 at 01:23:49PM -0700, Sean Christopherson wrote: > > The attached patch should do the trick. > > The two most attractive options to me remains what I already have > implemented under #ifdef

Re: threads-max observe limits

2019-09-23 Thread Eric W. Biederman
Michal, Thinking about this I have a hunch about what changed. I think at some point we changed from 4k to 8k kernel stacks. So I suspect if your client is seeing a lower threads-max it is because the size of the kernel data structures increased. Eric

Applied "regulator: da9062: fix suspend_enable/disable preparation" to the regulator tree

2019-09-23 Thread Mark Brown
The patch regulator: da9062: fix suspend_enable/disable preparation has been applied to the regulator tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-5.4 All being well this means that it will be integrated into the linux-next tree (usually sometime in

Applied "regulator: fixed: Prevent NULL pointer dereference when !CONFIG_OF" to the regulator tree

2019-09-23 Thread Mark Brown
The patch regulator: fixed: Prevent NULL pointer dereference when !CONFIG_OF has been applied to the regulator tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-5.4 All being well this means that it will be integrated into the linux-next tree (usually

Re: [PATCH v8 2/9] documention: leds: Add multicolor class documentation

2019-09-23 Thread Jacek Anaszewski
Dan, On 9/23/19 4:50 PM, Dan Murphy wrote: > Jacek > > Thanks for the review > > On 9/21/19 7:28 AM, Jacek Anaszewski wrote: >> Dan, >> >> On 9/20/19 7:41 PM, Dan Murphy wrote: >>> Add the support documentation on the multicolor LED framework. >>> This document defines the directores and file

Re: [PATCH v2 2/2] x86/boot/64: round memory hole size up to next PMD page.

2019-09-23 Thread Dave Hansen
On 9/23/19 11:15 AM, Steve Wahl wrote: > The kernel image map is created using PMD pages, which can include > some extra space beyond what's actually needed. Round the size of the > memory hole we search for up to the next PMD boundary, to be certain > all of the space to be mapped is usable RAM

Re: [PATCH v2 1/2] x86/boot/64: Make level2_kernel_pgt pages invalid outside kernel area.

2019-09-23 Thread Dave Hansen
On 9/23/19 11:15 AM, Steve Wahl wrote: > pmd = fixup_pointer(level2_kernel_pgt, physaddr); > - for (i = 0; i < PTRS_PER_PMD; i++) { > + for (i = 0; i < pmd_index((unsigned long)_text); i++) > + pmd[i] &= ~_PAGE_PRESENT; > + > + for (; i <= pmd_index((unsigned

Re: allow larger than require DMA masks

2019-09-23 Thread Sven Schnelle
Hi, On Fri, Feb 15, 2019 at 03:45:54PM +0100, Christoph Hellwig wrote: > Hi all, > > this series finishes off converting our dma mask model to split between > device capabilities (dev->dma_mask and dev->coherent_dma_mask) and system > limitations (dev->bus_dma_mask). We already accept larger

Re: [PATCH v3] tracing: Introduce trace event injection

2019-09-23 Thread Cong Wang
Hi, Steven Any reviews for V3? I've addressed your concern about Kconfig. Thanks.

Re: [GIT PULL] Kselftest update for Linux 5.4-rc1

2019-09-23 Thread Shuah Khan
On 9/23/19 2:53 PM, Ingo Molnar wrote: * Shuah Khan wrote: Right. What you suggesting is very similar to and more complete than what I have been thinking about and proposed at the KS kselftest track. i.e move tools/testing/selftests to kselftest at the root level. I like your idea of moving

Re: [PATCH 15/17] KVM: retpolines: x86: eliminate retpoline from vmx.c exit handlers

2019-09-23 Thread Andrea Arcangeli
Hello, On Mon, Sep 23, 2019 at 01:23:49PM -0700, Sean Christopherson wrote: > The attached patch should do the trick. The two most attractive options to me remains what I already have implemented under #ifdef CONFIG_RETPOLINE with direct calls (optionally replacing the "if" with a small "switch"

Re: [PATCH v4 1/3] led: make led_set_brightness_sync() use led_set_brightness_nosleep()

2019-09-23 Thread Jacek Anaszewski
Hi Jean, On 9/23/19 11:14 AM, Jean-Jacques Hiblot wrote: > Hi Jacek, > > On 20/09/2019 23:10, Jacek Anaszewski wrote: >> Hi Jean, >> >> On 9/20/19 2:25 PM, Jean-Jacques Hiblot wrote: >>> Making led_set_brightness_sync() use led_set_brightness_nosleep() has 2 >>> advantages: >>> - works for LED

Re: [PATCH v2 03/11] mm/gup: Applies counting method to monitor gup_pgd_range

2019-09-23 Thread Leonardo Bras
On Mon, 2019-09-23 at 13:27 -0700, John Hubbard wrote: > I'd also like a second opinion from the "core" -mm maintainers, but it seems > like > there is now too much code around the gup_pgd_range() call. Especially since > there > are two places where it's called--did you forget the other one in

Re: [PATCH v2 00/11] Introduces new count-based method for monitoring lockless pagetable wakls

2019-09-23 Thread Leonardo Bras
On Mon, 2019-09-23 at 13:51 -0700, John Hubbard wrote: > Also, which tree do these patches apply to, please? > > thanks, They should apply on top of v5.3 + one patch: https://patchwork.ozlabs.org/patch/1164925/ I was working on top of this patch, because I thought it would be merged fast. But

Re: For review: pidfd_open(2) manual page

2019-09-23 Thread Michael Kerrisk (man-pages)
Hello Florian, On 9/23/19 10:41 PM, Florian Weimer wrote: > * Michael Kerrisk: > static int pidfd_open(pid_t pid, unsigned int flags) { return syscall(__NR_pidfd_open, pid, flags); } >>> >>> Please call this function something else

Re: [PATCH 4/5] clk: meson: meson8b: don't register the XTAL clock when provided via OF

2019-09-23 Thread Martin Blumenstingl
On Mon, Sep 23, 2019 at 11:31 AM Jerome Brunet wrote: > > On Sat 21 Sep 2019 at 17:12, Martin Blumenstingl > wrote: > > > The XTAL clock is an actual crystal on the PCB. Thus the meson8b clock > > driver should not register the XTAL clock - instead it should be > > provided via .dts and then

Re: [PATCH 0/5] provide the XTAL clock via OF on Meson8/8b/8m2

2019-09-23 Thread Martin Blumenstingl
Hi Jerome, On Mon, Sep 23, 2019 at 11:29 AM Jerome Brunet wrote: > > On Sat 21 Sep 2019 at 17:12, Martin Blumenstingl > wrote: > > > So far the HHI clock controller has been providing the XTAL clock on > > Amlogic Meson8/Meson8b/Meson8m2 SoCs. > > This is not correct because the XTAL is

Re: [GIT PULL] Kselftest update for Linux 5.4-rc1

2019-09-23 Thread Ingo Molnar
* Shuah Khan wrote: > Right. What you suggesting is very similar to and more complete than > what I have been thinking about and proposed at the KS kselftest track. > > i.e move tools/testing/selftests to kselftest at the root level. I like > your idea of moving tools/testing up to root and

Re: [PATCH v2 01/11] powerpc/mm: Adds counting method to monitor lockless pgtable walks

2019-09-23 Thread Leonardo Bras
On Mon, 2019-09-23 at 13:42 -0700, John Hubbard wrote: > Somewhere, there should be a short comment that explains how the following > functions > are meant to be used. And it should include the interaction with irqs, so > maybe > if you end up adding that combined wrapper function that does

Re: [RFC patch 00/15] entry: Provide generic implementation for host and guest entry/exit work

2019-09-23 Thread Thomas Gleixner
On Fri, 20 Sep 2019, Mark Rutland wrote: > I've been working on converting the arm64 entry code to C for a while > now [1], gradually upstreaming the bits I can. > > James has picked up some of that [2] as a prerequisite for some RAS > error handling, and I think building the arm64 bits atop of

chaos generating driver was Re: Linux 5.3-rc8

2019-09-23 Thread Pavel Machek
Hi! > > => src/random-seed/random-seed.c: > > /* > > * Let's make this whole job asynchronous, i.e. let's make > > * ourselves a barrier for proper initialization of the > > * random pool. > > */ ... > > k = getrandom(buf, buf_size, GRND_NONBLOCK); > > if (k

Re: [PATCH 0/6] add the DDR clock controller on Meson8 and Meson8b

2019-09-23 Thread Martin Blumenstingl
Hi Jerome, On Mon, Sep 23, 2019 at 12:06 PM Jerome Brunet wrote: > > On Sat 21 Sep 2019 at 17:18, Martin Blumenstingl > wrote: > > > Meson8 and Meson8b SoCs embed a DDR clock controller in their MMCBUS > > registers. This series: > > - adds support for this DDR clock controller (patches 0 and

Re: [PATCH] staging: rtl8188eu: remove dead code in do-while conditional step

2019-09-23 Thread Connor Kuehl
On 9/23/19 1:38 PM, Larry Finger wrote: On 9/23/19 2:48 PM, Connor Kuehl wrote: The local variable 'bcmd_down' is always set to true almost immediately before the do-while's condition is checked. As a result, !bcmd_down evaluates to false which short circuits the logical AND operator meaning

Re: [PATCH v2 02/11] asm-generic/pgtable: Adds dummy functions to monitor lockless pgtable walks

2019-09-23 Thread Leonardo Bras
Thanks for the feedback, On Mon, 2019-09-23 at 13:39 -0700, John Hubbard wrote: > Please remember to include linux-mm if there is a v2. Sure, I will include on v3. > Nit: seems like it would be nicer to just put it all in one place, and use > positive logic, and also I think people normally

Re: [PATCH v2 0/2] Optimise io_uring completion waiting

2019-09-23 Thread Jens Axboe
On 9/23/19 10:32 AM, Pavel Begunkov wrote: > Sorry, mixed the threads. > >>> >>> I'm not sure an extension is needed for such a special interface, why not >>> just put a ->threshold value next to the ctx->wait field and use either >>> the regular wait_event() APIs with the proper condition, or

Re: [RFC patch 02/15] x86/entry: Remove _TIF_NOHZ from _TIF_WORK_SYSCALL_ENTRY

2019-09-23 Thread Thomas Gleixner
On Fri, 20 Sep 2019, Andy Lutomirski wrote: > On Thu, Sep 19, 2019 at 8:09 AM Thomas Gleixner wrote: > > > > Evaluating _TIF_NOHZ to decide whether to use the slow syscall entry path > > is not only pointless, it's actually counterproductive: > > > > 1) Context tracking code is invoked

Re: For review: pidfd_open(2) manual page

2019-09-23 Thread Florian Weimer
* Michael Kerrisk: >>>static >>>int pidfd_open(pid_t pid, unsigned int flags) >>>{ >>>return syscall(__NR_pidfd_open, pid, flags); >>>} >> >> Please call this function something else (not pidfd_open), so that the >> example continues to work if glibc

Re: [PATCH AUTOSEL 4.19 075/128] PM / devfreq: passive: Use non-devm notifiers

2019-09-23 Thread Leonard Crestez
On 22.09.2019 21:56, Sasha Levin wrote: > From: Leonard Crestez > > [ Upstream commit 0ef7c7cce43f6ecc2b96d447e69b2900a9655f7c ] This will introduce an "unused variable warning" unless you also cherry-pick commit 0465814831a9 ("PM / devfreq: passive: fix compiler warning"). > The devfreq

Re: [PATCH] dt-bindings: at24: convert the binding document to yaml

2019-09-23 Thread Rob Herring
On Mon, Sep 23, 2019 at 12:52 PM Bartosz Golaszewski wrote: > > From: Bartosz Golaszewski > > Convert the binding document for at24 EEPROMs from txt to yaml. The > compatible property uses a regex pattern to address all the possible > combinations of "vendor,model" strings. > > Signed-off-by:

Re: [PATCH] staging: rtl8188eu: remove dead code in do-while conditional step

2019-09-23 Thread Larry Finger
On 9/23/19 2:48 PM, Connor Kuehl wrote: The local variable 'bcmd_down' is always set to true almost immediately before the do-while's condition is checked. As a result, !bcmd_down evaluates to false which short circuits the logical AND operator meaning that the second operand is never reached

Re: [PATCH] Bluetooth: hidp: Fix assumptions on the return value of hidp_send_message

2019-09-23 Thread Andrey Smirnov
> I am taking this through my tree. And yes, I applied the updated patch, but > answered the other ;) > > Regards > > Marcel Are you also going to mark this patch for inclusion to stable tree? I haven't seen it in any of the stable queues (netdev, Greg's), so just wanted to check. Thanks,

<    1   2   3   4   5   6   7   8   >