[PATCH v2 1/5] perf cs-etm: Refactor instruction size handling

In cs-etm.c there have several functions need to know instruction size based on address, e.g. cs_etm__instr_addr() and cs_etm__copy_insn() these two functions both calculate the instruction size separately. Furthermore, if we consider to add new features later which also might require to calculate

Re: [PATCH v8 1/3] arm64: cpufeature: introduce helper cpu_has_hw_af()

On Sat, Sep 21, 2019 at 09:50:52PM +0800, Jia He wrote: > We unconditionally set the HW_AFDBM capability and only enable it on > CPUs which really have the feature. But sometimes we need to know > whether this cpu has the capability of HW AF. So decouple AF from > DBM by new helper cpu_has_hw_af().

Re: [PATCH] sched: fix migration to invalid cpu in __set_cpus_allowed_ptr

On 23/09/2019 16:43, Dietmar Eggemann wrote: > I'm not sure that CONFIG_DEBUG_PER_CPU_MAPS=y will help you here. > > __set_cpus_allowed_ptr(...) > { > ... > dest_cpu = cpumask_any_and(...) > ... > } > > With: > > #define cpumask_any_and(mask1, mask2) cpumask_first_and((mask1), (mask2

Re: [PATCH v2] mm: implement write-behind policy for sequential file writes

On 23/09/2019 18.36, Jens Axboe wrote: On 9/20/19 5:10 PM, Linus Torvalds wrote: On Fri, Sep 20, 2019 at 4:05 PM Linus Torvalds wrote: Now, I hear you say "those are so small these days that it doesn't matter". And maybe you're right. But particularly for slow media, triggering good streamin

Re: [PATCH] drivers/net/fjes: fix a potential NULL pointer dereference

If I'm looking at this right you are jumping to err_free_netdev without setting the err variable. It must had been set to 0 from the return of fjes_sw_init(). This means we will free the netdev, and return 0. This means probe will not fail and driver's remove function will be run at some point

RE: [PATCH 1/5] regulator: da9062: fix suspend_enable/disable preparation

On 17 September 2019 13:43, Marco Felsch wrote: > Currently the suspend reg_field maps to the pmic voltage selection bits > and is used during suspend_enabe/disable() and during get_mode(). This > seems to be wrong for both use cases. > > Use case one (suspend_enabe/disable): > Those callbacks are

[PATCH RT] posix-timers: Unlock expiry lock in the early return

Patch ("posix-timers: Add expiry lock") acquired a lock in run_posix_cpu_timers() but didn't drop the lock in the early return. Unlock the lock in the early return path. Reported-by: kbuild test robot Reported-by: Dan Carpenter Signed-off-by: Sebastian Andrzej Siewior --- kernel/time/posix-cp

Re: [PATCH 0/6] tools/lib/traceevent: Man page updates and some file movement

On Mon, 23 Sep 2019 11:12:48 -0400 Steven Rostedt wrote: > Yeah. Let's not apply this one yet till we figure out what broke. I'll > take a look at it too. Does this help? -- Steve diff --git a/tools/perf/Makefile.perf b/tools/perf/Makefile.perf index f9807d8c005b..7544166dd466 100644 --- a/too

Re: [PATCH v7 02/21] RISC-V: Add bitmap reprensenting ISA features common across CPUs

On Sat, 2019-09-21 at 03:01 -0700, Paul Walmsley wrote: > Hi Anup, > > Thanks for changing this to use a bitmap. A few comments below - > > On Wed, 4 Sep 2019, Anup Patel wrote: > > > This patch adds riscv_isa bitmap which represents Host ISA features > > common across all Host CPUs. The riscv_

Re: [PATCH v10 3/6] mm: Introduce Reported pages

On 23.09.19 17:50, Michael S. Tsirkin wrote: > On Mon, Sep 23, 2019 at 05:47:24PM +0200, David Hildenbrand wrote: >> On 23.09.19 17:45, David Hildenbrand wrote: >>> On 23.09.19 17:37, Michael S. Tsirkin wrote: On Mon, Sep 23, 2019 at 08:28:00AM -0700, Alexander Duyck wrote: > On Mon, Sep 2

[PATCH v2] RDMA: release allocated skb

In create_cq, the allocated skb buffer needs to be released on error path. Moved the kfree_skb(skb) under err4 label. Signed-off-by: Navid Emamdoost --- drivers/infiniband/hw/cxgb4/cq.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/infiniband/hw/cxgb4/cq.c b/drivers/infiniband/hw/c

Re: [PATCH v10 3/6] mm: Introduce Reported pages

On Mon, Sep 23, 2019 at 05:47:24PM +0200, David Hildenbrand wrote: > On 23.09.19 17:45, David Hildenbrand wrote: > > On 23.09.19 17:37, Michael S. Tsirkin wrote: > >> On Mon, Sep 23, 2019 at 08:28:00AM -0700, Alexander Duyck wrote: > >>> On Mon, Sep 23, 2019 at 8:00 AM Michael S. Tsirkin > >>> wr

[PATCH trivial] gpu: Fix Kconfig indentation

Adjust indentation from spaces to tab (+optional two spaces) as in coding style with command like: $ sed -e 's/^/\t/' -i */Kconfig Signed-off-by: Krzysztof Kozlowski --- drivers/gpu/drm/Kconfig | 10 +- drivers/gpu/drm/amd/display/Kconfig | 20 ++-- drivers/gp

[PATCH trivial] usb: Fix Kconfig indentation

Adjust indentation from spaces to tab (+optional two spaces) as in coding style with command like: $ sed -e 's/^/\t/' -i */Kconfig Signed-off-by: Krzysztof Kozlowski --- drivers/usb/dwc3/Kconfig | 4 +- drivers/usb/gadget/legacy/Kconfig | 20 - drivers/usb/gadget/

Re: [PATCH v10 3/6] mm: Introduce Reported pages

On Mon, Sep 23, 2019 at 05:45:29PM +0200, David Hildenbrand wrote: > On 23.09.19 17:37, Michael S. Tsirkin wrote: > > On Mon, Sep 23, 2019 at 08:28:00AM -0700, Alexander Duyck wrote: > >> On Mon, Sep 23, 2019 at 8:00 AM Michael S. Tsirkin wrote: > >>> > >>> On Mon, Sep 23, 2019 at 07:50:15AM -0700

general protection fault in xsk_map_update_elem

Hello, syzbot found the following crash on: HEAD commit:b41dae06 Merge tag 'xfs-5.4-merge-7' of git://git.kernel.o.. git tree: net-next console output: https://syzkaller.appspot.com/x/log.txt?x=130b25ad60 kernel config: https://syzkaller.appspot.com/x/.config?x=dfcf592db22b9132 da

[PATCH trivial] fs: Fix Kconfig indentation

Adjust indentation from spaces to tab (+optional two spaces) as in coding style with command like: $ sed -e 's/^/\t/' -i */Kconfig Signed-off-by: Krzysztof Kozlowski --- fs/9p/Kconfig | 20 ++-- fs/Kconfig| 4 ++-- fs/Kconfig.binfmt | 4 ++-- fs/fuse/Kco

Re: [PATCH v10 3/6] mm: Introduce Reported pages

On 23.09.19 17:45, David Hildenbrand wrote: > On 23.09.19 17:37, Michael S. Tsirkin wrote: >> On Mon, Sep 23, 2019 at 08:28:00AM -0700, Alexander Duyck wrote: >>> On Mon, Sep 23, 2019 at 8:00 AM Michael S. Tsirkin wrote: On Mon, Sep 23, 2019 at 07:50:15AM -0700, Alexander Duyck wrote: >>

Re: [PATCH v10 3/6] mm: Introduce Reported pages

On 23.09.19 17:37, Michael S. Tsirkin wrote: > On Mon, Sep 23, 2019 at 08:28:00AM -0700, Alexander Duyck wrote: >> On Mon, Sep 23, 2019 at 8:00 AM Michael S. Tsirkin wrote: >>> >>> On Mon, Sep 23, 2019 at 07:50:15AM -0700, Alexander Duyck wrote: >> +static inline void >> +page_reporting_re

Re: [patch V2 6/6] posix-cpu-timers: Return -EPERM if ptrace permission check fails

On Mon, Sep 23, 2019 at 04:54:41PM +0200, Thomas Gleixner wrote: > Returning -EINVAL when a permission check fails is not really intuitive and > can cause hard to diagnose problems. > > The POSIX specification for clock_gettime() and timer_create() requires to > obtain the clock id first by invoki

[PATCH trivial] sound: Fix Kconfig indentation

Adjust indentation from spaces to tab (+optional two spaces) as in coding style with command like: $ sed -e 's/^/\t/' -i */Kconfig Signed-off-by: Krzysztof Kozlowski --- sound/core/Kconfig | 28 ++-- sound/drivers/Kconfig | 20 +++--- soun

Re: [PATCH 5/6] vringh: fix copy direction of vringh_iov_push_kern()

On Mon, 23 Sep 2019 21:03:30 +0800 Jason Wang wrote: > We want to copy from iov to buf, so the direction was wrong. > > Signed-off-by: Jason Wang > --- > drivers/vhost/vringh.c | 8 +++- > 1 file changed, 7 insertions(+), 1 deletion(-) Why is this included in the series? Seems like an u

Re: [PATCH] epoll: simplify ep_poll_safewake() for CONFIG_DEBUG_LOCK_ALLOC

On 9/4/19 4:22 PM, Jason Baron wrote: > Currently, ep_poll_safewake() in the CONFIG_DEBUG_LOCK_ALLOC case uses > ep_call_nested() in order to pass the correct subclass argument to > spin_lock_irqsave_nested(). However, ep_call_nested() adds unnecessary > checks for epoll depth and loops that are

Re: [patch V2 5/6] posix-cpu-timers: Return PTR_ERR() from lookup_task()

On Mon, Sep 23, 2019 at 04:54:40PM +0200, Thomas Gleixner wrote: > To prepare for changing the return code to -EPERM when the ptrace > permission check fails, use PTR_ERR() to return the error information from > lookup_task() and fixup all call sites. > > Signed-off-by: Thomas Gleixner Reviewed-

Re: [PATCH] sched: fix migration to invalid cpu in __set_cpus_allowed_ptr

On 9/15/19 4:33 PM, Valentin Schneider wrote: > On 15/09/2019 09:21, shikemeng wrote: >>> It's more thoughtful to add check in cpumask_test_cpu.It can solve this >>> problem and can prevent other potential bugs.I will test it and resend >>> a new patch. >>> >> >> Think again and again. As cpumask_

Re: [PATCH] arm: export memblock_reserve()d regions via /proc/iomem

From: Yu Chen On Sat, 21 Sep 2019 15:51:38, Russell King - ARM Linux admin wrote: > On Sat, Sep 21, 2019 at 09:02:49PM +0800, Yu Chen wrote: > > From: Yu Chen > > > > memblock reserved regions are not reported via /proc/iomem on ARM, kexec's > > user-space doesn't know about memblock_reserve(

Re: pstore does not work under xen

On Thu, Sep 19, 2019 at 12:37:40PM -0400, Boris Ostrovsky wrote: > On 9/19/19 12:14 PM, James Dingwall wrote: > > On Thu, Sep 19, 2019 at 03:51:33PM +, Luck, Tony wrote: > >>> I have been investigating a regression in our environment where pstore > >>> (efi-pstore specifically but I suspect th

Re: [PATCH 00/17] KVM monolithic v1

On Fri, Sep 20, 2019 at 05:24:52PM -0400, Andrea Arcangeli wrote: > Andrea Arcangeli (17): > x86: spec_ctrl: fix SPEC_CTRL initialization after kexec > KVM: monolithic: x86: convert the kvm_x86_ops methods to external > functions > KVM: monolithic: x86: handle the request_immediate_exit v

Re: [LTP] 12abeb544d: ltp.read_all_dev.fail

Hi, > > FYI, we noticed the following commit (built with gcc-7): > > commit: 12abeb544d548f55f56323fc6e5e6c0fb74f58e1 ("horrible test hack") > > https://kernel.googlesource.com/pub/scm/linux/kernel/git/luto/linux.git > > random/kill-it ... > > tst_test.c:1108: INFO: Timeout per run is 0h 05m 00

Re: [PATCH v10 3/6] mm: Introduce Reported pages

On Mon, Sep 23, 2019 at 08:28:00AM -0700, Alexander Duyck wrote: > On Mon, Sep 23, 2019 at 8:00 AM Michael S. Tsirkin wrote: > > > > On Mon, Sep 23, 2019 at 07:50:15AM -0700, Alexander Duyck wrote: > > > > > +static inline void > > > > > +page_reporting_reset_boundary(struct zone *zone, unsigned i

Re: [GIT PULL] MIPS changes

On 9/22/2019 11:35 AM, Linus Torvalds wrote: > On Sat, Sep 21, 2019 at 4:10 PM Paul Burton wrote: >> >> Here are the main MIPS changes for v5.4; please pull. > > Hmm. I pulled and because initial tests didn't show any issues, I > already pushed out. > > But some unrelated further testing then

Re: [PATCH 2/3] KVM: x86: hyper-v: set NoNonArchitecturalCoreSharing CPUID bit when SMT is impossible

On Mon, Sep 16, 2019 at 06:22:57PM +0200, Vitaly Kuznetsov wrote: > Hyper-V 2019 doesn't expose MD_CLEAR CPUID bit to guests when it cannot > guarantee that two virtual processors won't end up running on sibling SMT > threads without knowing about it. This is done as an optimization as in > this ca

Re: [PATCH v2] mm: implement write-behind policy for sequential file writes

On 9/20/19 5:10 PM, Linus Torvalds wrote: > On Fri, Sep 20, 2019 at 4:05 PM Linus Torvalds > wrote: >> >> >> Now, I hear you say "those are so small these days that it doesn't >> matter". And maybe you're right. But particularly for slow media, >> triggering good streaming write behavior has been

Re: [PATCH RESEND v2] fs/epoll: Remove unnecessary wakeups of nested epoll that in ET mode

On 9/20/19 12:00 PM, Jason Baron wrote: > On 9/19/19 5:24 AM, hev wrote: >> From: Heiher >> >> Take the case where we have: >> >> t0 >> | (ew) >> e0 >> | (et) >> e1 >> | (lt) >> s0 >> >> t0: thread 0 >> e0: epoll fd 0 >> e1: epoll fd 1

Re: [PATCH 01/17] x86: spec_ctrl: fix SPEC_CTRL initialization after kexec

On Mon, Sep 23, 2019 at 12:22:23PM +0200, Paolo Bonzini wrote: > On 20/09/19 23:24, Andrea Arcangeli wrote: > > We can't assume the SPEC_CTRL msr is zero at boot because it could be > > left enabled by a previous kernel booted with > > spec_store_bypass_disable=on. > > > > Without this fix a boot

Re: [PATCH v10 3/6] mm: Introduce Reported pages

On Mon, Sep 23, 2019 at 8:00 AM Michael S. Tsirkin wrote: > > On Mon, Sep 23, 2019 at 07:50:15AM -0700, Alexander Duyck wrote: > > > > +static inline void > > > > +page_reporting_reset_boundary(struct zone *zone, unsigned int order, > > > > int mt) > > > > +{ > > > > + int index; > > > > + >

Re: [PATCH net v2 0/3] net/smc: move some definitions to UAPI

On 9/20/19 5:41 PM, Eugene Syromiatnikov wrote: > Hello. > > As of now, it's a bit difficult to use SMC protocol, as significant part > of definitions related to it are defined in private headers and are not > part of UAPI. The following commits move some definitions to UAPI, > making them read

s390 EAGAIN on send{msg,to}()/recvmsg() on small MTU and big packet size

Hi, I've found a bug on s390 on small MTU combined with big packet size, using ping (of course both within valid ranges, e.g. MTU 552 and packet size 61245). Below is full reproducer on netns. I tested it on vanilla: v5.3-rc8 and v4.16. I reproduced it on current iputils master which uses sendto

Re: [PATCH] ipv6: Properly check reference count flag before taking reference

Apparently even with this (certainly correct) patch attached, users are still experiencing problems. Bug hunting continues, and I'll report back if I figure something out.

Re: [PATCH v8 7/9] dt: bindings: lp50xx: Introduce the lp50xx family of RGB drivers

Jacek On 9/21/19 10:13 AM, Jacek Anaszewski wrote: Dan, On 9/20/19 7:41 PM, Dan Murphy wrote: Introduce the bindings for the Texas Instruments LP5036, LP5030, LP5024, LP5018, LP5012 and LP5009 RGB LED device driver. The LP5036/30/24/18/12/9 can control RGB LEDs individually or as part of a co

Re: [PATCH v9 07/11] dt-bindings: pwm: pwm-mediatek: add a property "num-pwms"

On Mon, Sep 23, 2019 at 11:11:55PM +0800, Sam Shih wrote: > On Mon, 2019-09-23 at 15:36 +0200, Thierry Reding wrote: > > On Mon, Sep 23, 2019 at 11:20:57AM +0800, Sam Shih wrote: > > > On Sat, 2019-09-21 at 02:21 +0200, Thierry Reding wrote: > > > > On Fri, Sep 20, 2019 at 06:49:07AM +0800, Sam Shi

Re: [PATCH v2] mm: implement write-behind policy for sequential file writes

Hello, On Mon, Sep 23, 2019 at 06:06:46PM +0300, Konstantin Khlebnikov wrote: > On 23/09/2019 17.52, Tejun Heo wrote: > >Hello, Konstantin. > > > >On Fri, Sep 20, 2019 at 10:39:33AM +0300, Konstantin Khlebnikov wrote: > >>With vm.dirty_write_behind 1 or 2 files are written even faster and > > > >I

Re: [PATCH 0/6] tools/lib/traceevent: Man page updates and some file movement

On Mon, 23 Sep 2019 11:52:49 -0300 Arnaldo Carvalho de Melo wrote: > Em Mon, Sep 23, 2019 at 11:39:27AM -0300, Arnaldo Carvalho de Melo escreveu: > > Em Mon, Sep 23, 2019 at 11:28:39AM -0300, Arnaldo Carvalho de Melo > > escreveu: > > > Em Thu, Sep 19, 2019 at 05:23:35PM -0400, Steven Rostedt

Re: [PATCH 13/36] drm/nouveau: use bpp instead of cpp for drm_format_info

On Mon, Sep 23, 2019 at 8:56 AM Sandy Huang wrote: > > cpp[BytePerPlane] can't describe the 10bit data format correctly, > So we use bpp[BitPerPlane] to instead cpp. > > Signed-off-by: Sandy Huang > --- > drivers/gpu/drm/nouveau/dispnv04/crtc.c | 7 --- > drivers/gpu/drm/nouveau/dispnv50

Re: KASAN: use-after-free Read in v4l2_release (2)

On Mon, Sep 23, 2019 at 4:31 PM syzbot wrote: > > Hello, > > syzbot found the following crash on: > > HEAD commit:e0bd8d79 usb-fuzzer: main usb gadget fuzzer driver > git tree: https://github.com/google/kasan.git usb-fuzzer > console output: https://syzkaller.appspot.com/x/log.txt?x=14d4

Re: [PATCH v9 07/11] dt-bindings: pwm: pwm-mediatek: add a property "num-pwms"

On Mon, 2019-09-23 at 15:36 +0200, Thierry Reding wrote: > On Mon, Sep 23, 2019 at 11:20:57AM +0800, Sam Shih wrote: > > On Sat, 2019-09-21 at 02:21 +0200, Thierry Reding wrote: > > > On Fri, Sep 20, 2019 at 06:49:07AM +0800, Sam Shih wrote: > > > > From: Ryder Lee > > > > > > > > This adds a pro

Re: [PATCH 10/73] libperf: Add perf_mmap struct

On Mon, Sep 23, 2019 at 12:05:33PM -0300, Arnaldo Carvalho de Melo wrote: > Em Fri, Sep 13, 2019 at 03:22:52PM +0200, Jiri Olsa escreveu: > > Add the perf_mmap to libperf. > > > > The definition is added into: > > > > include/internal/mmap.h > > > > which is not to be included by users, but sh

Re: [PATCH v5 0/3] Fix UART DMA freezes for i.MX SOCs

On Mon, 2019-09-23 at 17:06 +0200, Philipp Puschmann wrote: > Thanks for testing. > With my local setup i still have very few tx timeouts too. But i think they > have a different > cause and especially different consequences. When the problem addressed by > this series > appear you get a whole bu

Re: [PATCH v8 6/9] leds: multicolor: Introduce a multicolor class definition

Jacek On 9/21/19 8:30 AM, Jacek Anaszewski wrote: Dan, On 9/20/19 7:41 PM, Dan Murphy wrote: Introduce a multicolor class that groups colored LEDs within a LED node. The framework allows for dynamically setting individual LEDs or setting brightness levels of LEDs and updating them virtually s

Re: [PATCH] driver core: ensure a device has valid node id in device_add()

On Wed, Sep 11, 2019 at 08:49:26AM +0200, Michal Hocko wrote: > On Wed 11-09-19 14:15:51, Yunsheng Lin wrote: > > >> When passing the return value of dev_to_node() to cpumask_of_node() > > >> without checking the node id if the node id is not valid, there is > > >> global-out-of-bounds

Re: [PATCH v2 5/5] irqchip/irq-bcm7038-l1: Support brcm,int-fwd-mask

On 9/23/2019 7:57 AM, Marc Zyngier wrote: > On 23/09/2019 15:39, Florian Fainelli wrote: >> >> >> On 9/23/2019 1:52 AM, Marc Zyngier wrote: >>> On 22/09/2019 20:08, Florian Fainelli wrote: On 9/22/2019 5:38 AM, Marc Zyngier wrote: > On Fri, 13 Sep 2019 12:15:42 -0700 > Flo

Re: [PATCH v2] mm: implement write-behind policy for sequential file writes

On 23/09/2019 17.52, Tejun Heo wrote: Hello, Konstantin. On Fri, Sep 20, 2019 at 10:39:33AM +0300, Konstantin Khlebnikov wrote: With vm.dirty_write_behind 1 or 2 files are written even faster and Is the faster speed reproducible? I don't quite understand why this would be. Writing to disk

Re: [PATCH v5 0/3] Fix UART DMA freezes for i.MX SOCs

Hi Adam, Am 23.09.19 um 16:55 schrieb Adam Ford: > On Mon, Sep 23, 2019 at 8:58 AM Philipp Puschmann > wrote: >> >> For some years and since many kernel versions there are reports that >> RX UART DMA channel stops working at one point. So far the usual >> workaround was to disable RX DMA. This pa

Re: [PATCH v8 6/9] leds: multicolor: Introduce a multicolor class definition

Jacek On 9/21/19 1:08 PM, Jacek Anaszewski wrote: Dan, One more remark below. On 9/20/19 7:41 PM, Dan Murphy wrote: Introduce a multicolor class that groups colored LEDs within a LED node. The framework allows for dynamically setting individual LEDs or setting brightness levels of LEDs and u

Re: [PATCH 10/73] libperf: Add perf_mmap struct

Em Fri, Sep 13, 2019 at 03:22:52PM +0200, Jiri Olsa escreveu: > Add the perf_mmap to libperf. > > The definition is added into: > > include/internal/mmap.h > > which is not to be included by users, but shared > within perf and libperf. > diff --git a/tools/perf/lib/include/internal/mmap.h >

Re: [PATCH 1/2] mmc: sdhci: Check card status after reset

On Mon, Sep 23, 2019 at 03:31:59PM +0300, Adrian Hunter wrote: > Should have Acked this ages ago, sorry :-( > > Acked-by: Adrian Hunter Thanks, and no worries :) Ulf, The patch set is ready to merge now :)

Re: [PATCH] ipv6: Properly check reference count flag before taking reference

Hi, > People are reporting that WireGuard experiences erratic crashes on 5.3, > and bisected it down to 7d30a7f6424e. Casually flipping through that > commit I noticed that a flag is checked using `|` instead of `&`, which in > this current case, means that a reference is never incremented, which

linux-kernel@vger.kernel.org

On Mon, 23 Sep 2019, Ran Wang wrote: > USB 2.0 Embedded Host PET Automated Test (CH6) 6.7.23 A-UUT "Unsupported > Device" Message require to stop enumerating device with VID=0x1a0a PID=0x0201 > and pop message to declare this device is not supported. > > Signed-off-by: Ran Wang > --- > drivers/

Re: [PATCH v10 3/6] mm: Introduce Reported pages

On Mon, Sep 23, 2019 at 07:50:15AM -0700, Alexander Duyck wrote: > > > +static inline void > > > +page_reporting_reset_boundary(struct zone *zone, unsigned int order, int > > > mt) > > > +{ > > > + int index; > > > + > > > + if (order < PAGE_REPORTING_MIN_ORDER) > > > + return;

Re: [PATCH] usb: hub: Minor refactoring in usb_hub_init()

On Mon, 23 Sep 2019, Greg KH wrote: > On Mon, Sep 23, 2019 at 03:19:21PM +0900, Austin Kim wrote: > > Normally when creation of workqueue fails, exception handling takes place > > after the call to alloc_workqueue() is made. > > > > But looking into usb_hub_init() function, 'return 0' statement i

Re: [PATCH v2 5/5] irqchip/irq-bcm7038-l1: Support brcm,int-fwd-mask

On 23/09/2019 15:39, Florian Fainelli wrote: > > > On 9/23/2019 1:52 AM, Marc Zyngier wrote: >> On 22/09/2019 20:08, Florian Fainelli wrote: >>> >>> >>> On 9/22/2019 5:38 AM, Marc Zyngier wrote: On Fri, 13 Sep 2019 12:15:42 -0700 Florian Fainelli wrote: > On some specific chip

[patch V2 2/6] posix-cpu-timers: Restrict clock_gettime() permissions

From: Thomas Gleixner Similar to creating timers on a process there is no restriction at all to read the Posix CPU clocks of any process in the system. Per thread CPU clock access is limited to threads in the same thread group. The per process CPU clocks can be used to observe activity of tasks

[patch V2 3/6] posix-cpu-timers: Sanitize thread clock permissions

From: Thomas Gleixner The thread clock permissions are restricted to tasks of the same thread group, but that also prevents a ptracer from reading them. This is inconsistent vs. the process restrictions and unnecessary strict. Relax it to ptrace permissions in the same way as process permissions

[patch V2 0/6] posix-cpu-timers: Fix bogus permission checks

When cleaning up posix-cpu-timers I discovered that the permission checks for process clocks and process timers are completely bonkers. The only requirement is that the target PID is a group leader. Which means that any process can read the clocks and attach timers to any other process without priv

[patch V2 6/6] posix-cpu-timers: Return -EPERM if ptrace permission check fails

Returning -EINVAL when a permission check fails is not really intuitive and can cause hard to diagnose problems. The POSIX specification for clock_gettime() and timer_create() requires to obtain the clock id first by invoking clock_getcpuclockid(). clock_getcpuclockid() can return -EPERM if the c

[patch V2 4/6] posix-cpu-timers: Make PID=0 and PID=self handling consistent

From: Thomas Gleixner If the PID encoded into the clock id is 0 then the target is either the calling thread itself or the process to which it belongs. If the current thread encodes its own PID on a process wide clock then there is no reason not to treat it in the same way as the PID=0 case. Si

[patch V2 1/6] posix-cpu-timers: Restrict timer_create() permissions

From: Thomas Gleixner Right now there is no restriction at all to attach a Posix CPU timer to any process in the system. Per thread CPU timers are limited to be created by threads in the same thread group. Timers can be used to observe activity of tasks and also impose overhead on the process to

[patch V2 5/6] posix-cpu-timers: Return PTR_ERR() from lookup_task()

To prepare for changing the return code to -EPERM when the ptrace permission check fails, use PTR_ERR() to return the error information from lookup_task() and fixup all call sites. Signed-off-by: Thomas Gleixner --- V2: New patch --- kernel/time/posix-cpu-timers.c | 22 --

Re: [PATCH v5 0/3] Fix UART DMA freezes for i.MX SOCs

On Mon, Sep 23, 2019 at 8:58 AM Philipp Puschmann wrote: > > For some years and since many kernel versions there are reports that > RX UART DMA channel stops working at one point. So far the usual > workaround was to disable RX DMA. This patches fix the underlying > problem. > > When a running sdm

Re: [RFC PATCH for 5.4 0/7] Membarrier fixes and cleanups

- On Sep 23, 2019, at 5:06 AM, Peter Zijlstra pet...@infradead.org wrote: > On Thu, Sep 19, 2019 at 01:36:58PM -0400, Mathieu Desnoyers wrote: >> Hi, >> >> Those series of fixes and cleanups are initially motivated by the report >> of race in membarrier, which can load p->mm->membarrier_state

[PATCH] staging: android: ashmem: Fix zero area size return code

The previous inline comment stated that a size of zero would make the ashmem_read_iter function return EOF, but it returned 0 instead. Looking at other functions, such as ashmem_llseek or ashmem_mmap, it appears the convention is to return -EINVAL if the region size is unset or zero. To be consis

[PATCH] ipv6: Properly check reference count flag before taking reference

People are reporting that WireGuard experiences erratic crashes on 5.3, and bisected it down to 7d30a7f6424e. Casually flipping through that commit I noticed that a flag is checked using `|` instead of `&`, which in this current case, means that a reference is never incremented, which would result

Re: [PATCH v2] mm: implement write-behind policy for sequential file writes

Hello, Konstantin. On Fri, Sep 20, 2019 at 10:39:33AM +0300, Konstantin Khlebnikov wrote: > With vm.dirty_write_behind 1 or 2 files are written even faster and Is the faster speed reproducible? I don't quite understand why this would be. > during copying amount of dirty memory always stays arou

Re: [PATCH 0/6] tools/lib/traceevent: Man page updates and some file movement

Em Mon, Sep 23, 2019 at 11:39:27AM -0300, Arnaldo Carvalho de Melo escreveu: > Em Mon, Sep 23, 2019 at 11:28:39AM -0300, Arnaldo Carvalho de Melo escreveu: > > Em Thu, Sep 19, 2019 at 05:23:35PM -0400, Steven Rostedt escreveu: > > > Hi Arnaldo, > > > > > > This is a series of man page updates to t

Re: [PATCH v10 3/6] mm: Introduce Reported pages

On Mon, Sep 23, 2019 at 1:16 AM Michael S. Tsirkin wrote: > > On Wed, Sep 18, 2019 at 10:52:49AM -0700, Alexander Duyck wrote: > > From: Alexander Duyck > > > > In order to pave the way for free page reporting in virtualized > > environments we will need a way to get pages out of the free lists a

Re: linux 32bit kernel virtual space , lowmem , highmem , RAM size

On Wed 11-09-19 19:46:46, yoav rubin wrote: > Apologize in advance if I'm sending this to the wrong place. (It's my > first time using mailing list...) > > > I need some help understanding the exact relations between the linux > kernel virtual space , specifically LOWMEM area , and the available

Re: Do we need to correct barriering in circular-buffers.rst?

On Thu, Sep 19, 2019 at 02:59:06PM +0100, David Howells wrote: > But I don't agree with this. You're missing half the barriers. There should > be *four* barriers. The document mandates only 3 barriers, and uses > READ_ONCE() where the fourth should be, i.e.: > >thread #1thread

Re: [PATCH v8 3/9] dt: bindings: Add multicolor class dt bindings documention

Jacek On 9/21/19 7:57 AM, Jacek Anaszewski wrote: Dan, On 9/20/19 7:41 PM, Dan Murphy wrote: Add DT bindings for the LEDs multicolor class framework. Signed-off-by: Dan Murphy --- .../bindings/leds/leds-class-multicolor.txt | 95 +++ 1 file changed, 95 insertions(+) cr

Re: For review: pidfd_open(2) manual page

On Mon, Sep 23, 2019 at 12:53:09PM +0200, Florian Weimer wrote: > * Michael Kerrisk: > > > SYNOPSIS > >int pidfd_open(pid_t pid, unsigned int flags); > > Should this mention for pid_t? > > > ERRORS > >EINVAL flags is not 0. > > > >EINVAL pid is not valid. > > > >

Re: [PATCH v8 2/9] documention: leds: Add multicolor class documentation

Jacek Thanks for the review On 9/21/19 7:28 AM, Jacek Anaszewski wrote: Dan, On 9/20/19 7:41 PM, Dan Murphy wrote: Add the support documentation on the multicolor LED framework. This document defines the directores and file generated by the Now there will be one directory created. Apart fro

Re: [GIT PULL] Kselftest update for Linux 5.4-rc1

On 9/22/19 5:52 AM, Greg KH wrote: On Sun, Sep 22, 2019 at 01:25:55PM +0200, Ingo Molnar wrote: * Linus Torvalds wrote: On Fri, Sep 20, 2019 at 9:35 AM Brendan Higgins wrote: Sorry about that. I am surprised that none of the other reviewers brought this up. I think I'm "special". There

Re: [PATCH v2 5/5] irqchip/irq-bcm7038-l1: Support brcm,int-fwd-mask

On 9/23/2019 1:52 AM, Marc Zyngier wrote: > On 22/09/2019 20:08, Florian Fainelli wrote: >> >> >> On 9/22/2019 5:38 AM, Marc Zyngier wrote: >>> On Fri, 13 Sep 2019 12:15:42 -0700 >>> Florian Fainelli wrote: >>> On some specific chips like 7211 we need to leave some interrupts untouche

Re: [PATCH 0/6] tools/lib/traceevent: Man page updates and some file movement

Em Mon, Sep 23, 2019 at 11:28:39AM -0300, Arnaldo Carvalho de Melo escreveu: > Em Thu, Sep 19, 2019 at 05:23:35PM -0400, Steven Rostedt escreveu: > > Hi Arnaldo, > > > > This is a series of man page updates to the libtraceevent code, as > > well as a fix to one missing prototype and some movement

Re: For review: pidfd_open(2) manual page

On Mon, Sep 23, 2019 at 11:11:53AM +0200, Michael Kerrisk (man-pages) wrote: > Hello Christian and all, > > Below, I have the rendered version of the current draft of > the pidfd_open(2) manual page that I have written. > The page source can be found in a Git branch at: > https://git.kernel.org/pu

[PATCH 1/1] MAINTAINERS: add Yanjun to FORCEDETH maintainers list

From: Rain River Yanjun has been spending quite a lot of time fixing bugs in FORCEDETH source code. I'd like to add Yanjun to maintainers list. Signed-off-by: Rain River --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index a400af0501c9..336ad8fe8b

[PATCH v2 8/9] sh64: entry: Remove unneeded need_resched() loop

Since the enabling and disabling of IRQs within preempt_schedule_irq() is contained in a need_resched() loop, we don't need the outer arch code loop. Signed-off-by: Valentin Schneider Cc: Yoshinori Sato Cc: Rich Felker Cc: linux...@vger.kernel.org --- arch/sh/kernel/cpu/sh5/entry.S | 5 +

[PATCH v2 0/9] entry: preempt_schedule_irq() callers scrub

I've left this to ~rot~ age out in the sun for a while, apologies for that. One early new-year resolution for me is to maintain a shorter resend timeout on this. This is the continuation of [1] where I'm hunting down preempt_schedule_irq() callers because of [2]. I've looked at users of preempt_s

[PATCH v2 2/9] c6x: entry: Remove unneeded need_resched() loop

Since the enabling and disabling of IRQs within preempt_schedule_irq() is contained in a need_resched() loop, we don't need the outer arch code loop. Acked-by: Mark Salter Signed-off-by: Valentin Schneider Cc: Aurelien Jacquiot Cc: linux-c6x-...@linux-c6x.org --- arch/c6x/kernel/entry.S | 3 +-

[PATCH v2 7/9] sh: entry: Remove unneeded need_resched() loop

Since the enabling and disabling of IRQs within preempt_schedule_irq() is contained in a need_resched() loop, we don't need the outer arch code loop. Signed-off-by: Valentin Schneider Cc: Yoshinori Sato Cc: Rich Felker Cc: linux...@vger.kernel.org --- arch/sh/kernel/entry-common.S | 4 +--- 1

[PATCH v2 1/9] sched/core: Fix preempt_schedule() interrupt return comment

preempt_schedule_irq() is the one that should be called on return from interrupt, clean up the comment to avoid any ambiguity. Acked-by: Thomas Gleixner Signed-off-by: Valentin Schneider Cc: Ingo Molnar Cc: Peter Zijlstra --- kernel/sched/core.c | 7 +++ 1 file changed, 3 insertions(+), 4

[PATCH v2 4/9] h8300: entry: Remove unneeded need_resched() loop

Since the enabling and disabling of IRQs within preempt_schedule_irq() is contained in a need_resched() loop, we don't need the outer arch code loop. Signed-off-by: Valentin Schneider Cc: Yoshinori Sato Cc: uclinux-h8-de...@lists.sourceforge.jp --- arch/h8300/kernel/entry.S | 3 +-- 1 file chan

[PATCH v2 9/9] xtensa: entry: Remove unneeded need_resched() loop

Since the enabling and disabling of IRQs within preempt_schedule_irq() is contained in a need_resched() loop, we don't need the outer arch code loop. Acked-by: Max Filippov Signed-off-by: Valentin Schneider Cc: Chris Zankel Cc: linux-xte...@linux-xtensa.org --- arch/xtensa/kernel/entry.S | 2 +

[PATCH v2 3/9] csky: entry: Remove unneeded need_resched() loop

Since the enabling and disabling of IRQs within preempt_schedule_irq() is contained in a need_resched() loop, we don't need the outer arch code loop. Acked-by: Guo Ren Signed-off-by: Valentin Schneider --- arch/csky/kernel/entry.S | 4 1 file changed, 4 deletions(-) diff --git a/arch/csky

[PATCH v2 6/9] RISC-V: entry: Remove unneeded need_resched() loop

Since the enabling and disabling of IRQs within preempt_schedule_irq() is contained in a need_resched() loop, we don't need the outer arch code loop. Reviewed-by: Palmer Dabbelt Signed-off-by: Valentin Schneider Cc: Albert Ou Cc: linux-ri...@lists.infradead.org --- arch/riscv/kernel/entry.S |

[PATCH v2 5/9] microblaze: entry: Remove unneeded need_resched() loop

Since the enabling and disabling of IRQs within preempt_schedule_irq() is contained in a need_resched() loop, we don't need the outer arch code loop. Signed-off-by: Valentin Schneider Cc: Michal Simek --- arch/microblaze/kernel/entry.S | 5 - 1 file changed, 5 deletions(-) diff --git a/arc

Re: [PATCH] arm64: dts: mt8183: Add node for the Mali GPU

On 19/09/2019 13:32, Alyssa Rosenzweig wrote: >>> By the time MT8183 shows up in more concrete devices, it will, certainly >>> in kernel-space and likely in userspace as well. At present, the DDK can >>> be modified to run on top of the in-tree Mali drivers, i.e. "Bifrost on >>> mainline linux-next

Re: Linux 5.3.1

On 08:37 Sat 21 Sep 2019, Greg KH wrote: I'm announcing the release of the 5.3.1 kernel. All users of the 5.3 kernel series must upgrade. The updated 5.3.y git tree can be found at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git linux-5.3.y and can be browsed at

KASAN: use-after-free Read in v4l2_release (2)

Hello, syzbot found the following crash on: HEAD commit:e0bd8d79 usb-fuzzer: main usb gadget fuzzer driver git tree: https://github.com/google/kasan.git usb-fuzzer console output: https://syzkaller.appspot.com/x/log.txt?x=14d4b6a160 kernel config: https://syzkaller.appspot.com/x/.

WARNING in _chaoskey_fill/usb_submit_urb

Hello, syzbot found the following crash on: HEAD commit:e0bd8d79 usb-fuzzer: main usb gadget fuzzer driver git tree: https://github.com/google/kasan.git usb-fuzzer console output: https://syzkaller.appspot.com/x/log.txt?x=1452c6a160 kernel config: https://syzkaller.appspot.com/x/.

KASAN: use-after-free Read in appledisplay_bl_get_brightness

Hello, syzbot found the following crash on: HEAD commit:e0bd8d79 usb-fuzzer: main usb gadget fuzzer driver git tree: https://github.com/google/kasan.git usb-fuzzer console output: https://syzkaller.appspot.com/x/log.txt?x=13714ad960 kernel config: https://syzkaller.appspot.com/x/.

<    1   2   3   4   5   6   7   8   >