Re: [RFC PATCH 06/22] thunderbolt: Add support for lane bonding

2019-10-02 Thread Mika Westerberg
On Wed, Oct 02, 2019 at 04:21:06PM +0200, Oliver Neukum wrote: > Am Dienstag, den 01.10.2019, 15:53 +0300 schrieb Mika Westerberg: > > > > > > Are we only going to be allowed to "bond" two links together? Or will > > > we be doing more than 2 in the future? If more, then we might want to > > >

Re: [RFC PATCH 05/22] thunderbolt: Add helper macros to iterate over switch ports

2019-10-02 Thread Mika Westerberg
On Wed, Oct 02, 2019 at 04:17:54PM +0200, Oliver Neukum wrote: > Am Dienstag, den 01.10.2019, 14:38 +0300 schrieb Mika Westerberg: > > @@ -1975,10 +1972,8 @@ void tb_switch_suspend(struct tb_switch *sw) > > if (err) > > return; > > > > - for (i = 1; i <=

RE: [EXT] INFO: trying to register non-static key in del_timer_sync (2)

2019-10-02 Thread Ganapathi Bhat
Hi Andy, > I was wondering if you've posted the updated version of the fix? Sorry for the delay; I have started addressing the comment from community; It should be done in couple of days; Regards, Ganapathi

Re: [PATCH] si2157: Add support for Logilink VG0022A.

2019-10-02 Thread Sean Young
On Wed, Oct 02, 2019 at 04:13:59PM +0200, Gon Solo wrote: You need a message and a Signed-off-by: here. > --- > drivers/media/tuners/si2157.c | 68 +-- > drivers/media/tuners/si2157_priv.h| 1 + > drivers/media/usb/dvb-usb-v2/af9035.c | 47 ++

Re: [PATCH] scatterlist: Comment on pages for sg_set_page()

2019-10-02 Thread Jason Gunthorpe
On Tue, Oct 01, 2019 at 11:32:50AM -0700, Alan Mikhak wrote: > From: Alan Mikhak > > Update the description of sg_set_page() to communicate current > requirements for the page pointer parameter. > > Signed-off-by: Alan Mikhak > include/linux/scatterlist.h | 6 ++ > 1 file changed, 6

Re: [RESEND PATCH v5 3/4] ARM: dts: exynos: add initial data for coupled regulators for Exynos5422/5800

2019-10-02 Thread Krzysztof Kozlowski
On Thu, Aug 08, 2019 at 11:02:33AM +0200, Kamil Konieczny wrote: > From: Marek Szyprowski > > Declare Exynos5422/5800 voltage ranges for opp points for big cpu core and > bus wcore and couple their voltage supllies as vdd_arm and vdd_int should > be in 300mV range. > > Signed-off-by: Marek

Re: [PATCH v11 0/6] mm / virtio: Provide support for unused page reporting

2019-10-02 Thread Alexander Duyck
On Wed, Oct 2, 2019 at 3:37 AM Nitesh Narayan Lal wrote: > > > On 10/1/19 8:55 PM, Alexander Duyck wrote: > > On Tue, Oct 1, 2019 at 12:16 PM Nitesh Narayan Lal > > wrote: > >> > >> On 10/1/19 12:21 PM, Alexander Duyck wrote: > >>> On Tue, 2019-10-01 at 17:35 +0200, David Hildenbrand wrote: >

Re: [RFC PATCH 06/22] thunderbolt: Add support for lane bonding

2019-10-02 Thread Oliver Neukum
Am Dienstag, den 01.10.2019, 15:53 +0300 schrieb Mika Westerberg: > > > > Are we only going to be allowed to "bond" two links together? Or will > > we be doing more than 2 in the future? If more, then we might want to > > think of a different way to specify these... > > AFAICT only two lanes

Re: [kbuild-all] Re: [PATCH] serial: sh-sci: Use platform_get_irq_optional() for optional interrupts

2019-10-02 Thread Chen, Rong A
-for-optional-interrupts/20191002-171547 Oh, this is still the old tty/tty-testing before it was rebased to v5.4-rc1, i.e. still based on v5.3-rc4. That explains the build failure. That does not explain why you couldn't apply this patch to v5.4-rc1 and next-20191001, though. base: https

Re: [PATCH 1/6] dt-bindings: clock: add the Amlogic Meson8 DDR clock controller binding

2019-10-02 Thread Rob Herring
On Sat, Sep 21, 2019 at 05:18:30PM +0200, Martin Blumenstingl wrote: > Amlogic Meson8, Meson8b and Meson8m2 SoCs have a DDR clock controller in > the MMCBUS registers. There is no public documentation on this, but the > GPL u-boot sources from the Amlogic BSP show that: > - it uses the same XTAL

Re: [PATCH 4/4] dt-bindings: pwm: mxs-pwm: Increase #pwm-cells

2019-10-02 Thread Rob Herring
On Mon, 23 Sep 2019 10:13:48 +0200, Rasmus Villemoes wrote: > We need to increase the pwm-cells for the optional flags parameter, in > order to implement support for polarity setting via DT. > > Signed-off-by: Rasmus Villemoes > --- > Documentation/devicetree/bindings/pwm/mxs-pwm.txt | 4 ++-- >

Re: [PATCH] dt-bindings: iio: maxbotix,mb1232.yaml: transform to yaml

2019-10-02 Thread Rob Herring
On Mon, Sep 23, 2019 at 07:46:34PM +0200, Andreas Klinger wrote: > transform existing documentation of maxbotix,mb1232 ultrasonic ranger > from text documentation format into yaml. > > Signed-off-by: Andreas Klinger > --- > .../bindings/iio/proximity/maxbotix,mb1232.txt | 29 --- >

Re: [PATCH 1/5] dt-bindings: clock: meson8b: add the clock inputs

2019-10-02 Thread Rob Herring
On Sat, 21 Sep 2019 17:12:19 +0200, Martin Blumenstingl wrote: > The clock controller on Meson8/Meson8b/Meson8m2 has three (known) > inputs: > - "xtal": the main 24MHz crystal > - "ddr_pll": some of the audio clocks use the output of the DDR PLL as > input > - "clk_32k": an optional clock signal

Re: [PATCH 1/2] misc: add cc1101 devicetree binding

2019-10-02 Thread Rob Herring
On Sun, Sep 22, 2019 at 08:03:55AM +0200, Heiko Schocher wrote: > add devicetree binding for cc1101 misc driver. > > Signed-off-by: Heiko Schocher > --- > > .../devicetree/bindings/misc/cc1101.txt | 27 +++ > 1 file changed, 27 insertions(+) > create mode 100644

Re: [PATCH v3 3/4] iommu/ioasid: Add custom allocators

2019-10-02 Thread Jean-Philippe Brucker
Hi Jacob, There seem to be a mix-up here, the changes from your v2 are lost and patches 1 and 3 are back to v1. Assuming this isn't intended, I'll review v2 of this patch since it looked good to me overall. Thanks, Jean

Re: [PATCH v3 0/4] User API for nested shared virtual address (SVA)

2019-10-02 Thread Jacob Pan
Hi Jean, Just wondering if you have more comments on ioasid custom allocator, v3 is largely the same as v2 other than shuffling header within the set. Thanks, Jacob On Tue, 1 Oct 2019 16:33:21 -0700 Jacob Pan wrote: > This set consists of IOMMU APIs to support SVA in the guest, a.k.a >

Re: [RFC PATCH 05/22] thunderbolt: Add helper macros to iterate over switch ports

2019-10-02 Thread Oliver Neukum
Am Dienstag, den 01.10.2019, 14:38 +0300 schrieb Mika Westerberg: > @@ -1975,10 +1972,8 @@ void tb_switch_suspend(struct tb_switch *sw) > if (err) > return; > > - for (i = 1; i <= sw->config.max_port_number; i++) { > - if

[PATCH] clocksource: tsc: respect tsc bootparam for clocksource_tsc_early

2019-10-02 Thread Michael Zhivich
Introduction of clocksource_tsc_early broke functionality of "tsc=reliable" and "tsc=nowatchdog" boot params, since clocksource_tsc_early is *always* registered with CLOCK_SOURCE_MUST_VERIFY and thus put on the watchdog list. If CPU is very busy during boot, the watchdog clocksource may not be

Re: [PATCHSET v3 btrfs/for-next] btrfs: fix cgroup writeback support

2019-10-02 Thread David Sterba
On Fri, Sep 06, 2019 at 10:46:56AM -0700, Tejun Heo wrote: > On Thu, Sep 05, 2019 at 01:59:37PM +0200, David Sterba wrote: > > On Fri, Jul 26, 2019 at 05:13:21PM +0200, David Sterba wrote: > > > On Wed, Jul 10, 2019 at 12:28:13PM -0700, Tejun Heo wrote: > > > > This patchset contains only the

Re: [Xen-devel] [PATCH] x86/xen: Return from panic notifier

2019-10-02 Thread Boris Ostrovsky
On 10/2/19 9:42 AM, Jan Beulich wrote: > > I can only guess that the thinking probably was that e.g. external > dumping (by the tool stack) would be more reliable (including but > not limited to this meaning less change of state from when the > original crash reason was detected) than having the

[PATCH] si2157: Add support for Logilink VG0022A.

2019-10-02 Thread Gon Solo
--- drivers/media/tuners/si2157.c | 68 +-- drivers/media/tuners/si2157_priv.h| 1 + drivers/media/usb/dvb-usb-v2/af9035.c | 47 ++ 3 files changed, 90 insertions(+), 26 deletions(-) diff --git a/drivers/media/tuners/si2157.c

[PATCH] si2157: Add support for Logilink VG0022A.

2019-10-02 Thread Gon Solo
Dear Mauro! Thanks for your reply, I tried to address most of your concerns, so please bear with me (especially this is my first email with git send-email). :) > First of all, don't attach a patch. Instead, just send it with a decent > emailer (with won't mangle whitespaces) or use git

Re: [PATCH 1/3] tools/memory-model/Documentation: Fix typos in explanation.txt

2019-10-02 Thread Alan Stern
On Tue, 1 Oct 2019, Joel Fernandes wrote: > On Tue, Oct 01, 2019 at 01:39:47PM -0400, Alan Stern wrote: > > This patch fixes a few minor typos and improves word usage in a few > > places in the Linux Kernel Memory Model's explanation.txt file. > > > > Signed-off-by: Alan Stern > > > >

Re: [PATCH] net: stmmac: xgmac: add missing parentheses to fix precendence error

2019-10-02 Thread Dan Carpenter
On Wed, Oct 02, 2019 at 02:53:17PM +0100, Colin Ian King wrote: > On 02/10/2019 14:42, Dan Carpenter wrote: > > On Wed, Oct 02, 2019 at 04:33:57PM +0300, Dan Carpenter wrote: > >> On Wed, Oct 02, 2019 at 12:08:49PM +0100, Colin King wrote: > >>> From: Colin Ian King > >>> > >>> The expression

Re: [PATCH v6 11/19] PM / devfreq: tegra30: Use CPUFreq notifier

2019-10-02 Thread Dmitry Osipenko
02.10.2019 03:02, Chanwoo Choi пишет: > Hi, > > On 19. 8. 12. 오전 6:23, Dmitry Osipenko wrote: >> The CPU's client need to take into account that CPUFreq may change >> while memory activity not, staying high. Thus an appropriate frequency >> notifier should be used in addition to the clk-notifier.

[PATCH v2 1/5] clk: imx8mq: Add VIDEO2_PLL clock

2019-10-02 Thread Laurentiu Palcu
This clock is needed by DCSS when high resolutions are used. Signed-off-by: Laurentiu Palcu CC: Abel Vesa --- drivers/clk/imx/clk-imx8mq.c | 4 include/dt-bindings/clock/imx8mq-clock.h | 4 +++- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git

[PATCH v2 5/5] arm64: dts: imx8mq: add DCSS node

2019-10-02 Thread Laurentiu Palcu
This patch adds the node for iMX8MQ Display Controller Subsystem. Signed-off-by: Laurentiu Palcu --- arch/arm64/boot/dts/freescale/imx8mq.dtsi | 25 + 1 file changed, 25 insertions(+) diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi

Re: [PATCH 3/3] tpm: Fix TPM 1.2 Shutdown sequence to prevent future TPM operations

2019-10-02 Thread Greg KH
On Wed, Oct 02, 2019 at 04:14:44PM +0300, Jarkko Sakkinen wrote: > From: Vadim Sukhomlinov > > commit db4d8cb9c9f2af71c4d087817160d866ed572cc9 upstream > > TPM 2.0 Shutdown involve sending TPM2_Shutdown to TPM chip and disabling > future TPM operations. TPM 1.2 behavior was different, future

Re: [PATCH] kasan: fix the missing underflow in memmove and memcpy with CONFIG_KASAN_GENERIC=y

2019-10-02 Thread Dmitry Vyukov
On Wed, Oct 2, 2019 at 2:15 PM Walter Wu wrote: > > On Mon, 2019-09-30 at 12:36 +0800, Walter Wu wrote: > > On Fri, 2019-09-27 at 21:41 +0200, Dmitry Vyukov wrote: > > > On Fri, Sep 27, 2019 at 4:22 PM Walter Wu > > > wrote: > > > > > > > > On Fri, 2019-09-27 at 15:07 +0200, Dmitry Vyukov

Re: [PATCH v6 00/19] More improvements for Tegra30 devfreq driver

2019-10-02 Thread Dmitry Osipenko
02.10.2019 03:25, Chanwoo Choi пишет: > Hello Dmitry and Thierry, > > On 19. 10. 2. 오전 6:15, Dmitry Osipenko wrote: >> 12.08.2019 00:22, Dmitry Osipenko пишет: >>> Hello, >>> >>> This series addresses some additional review comments that were made by >>> Thierry Reding to [1], makes several

Re: [PATCH 10/15] static_call: Add basic static call infrastructure

2019-10-02 Thread Peter Zijlstra
On Fri, Jun 07, 2019 at 10:28:51AM +0200, Peter Zijlstra wrote: > On Thu, Jun 06, 2019 at 10:44:23PM +, Nadav Amit wrote: > > > + * Usage example: > > > + * > > > + * # Start with the following functions (with identical prototypes): > > > + * int func_a(int arg1, int arg2); > > > + * int

[PATCH] habanalabs: Fix typos

2019-10-02 Thread Tomer Tayar
s/paerser/parser/ s/requeusted/requested/ s/an JOB/a JOB/ Signed-off-by: Tomer Tayar --- drivers/misc/habanalabs/habanalabs.h | 2 +- drivers/misc/habanalabs/hw_queue.c | 4 ++-- include/uapi/misc/habanalabs.h | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git

Re: [PATCH] net: stmmac: xgmac: add missing parentheses to fix precendence error

2019-10-02 Thread Colin Ian King
On 02/10/2019 14:42, Dan Carpenter wrote: > On Wed, Oct 02, 2019 at 04:33:57PM +0300, Dan Carpenter wrote: >> On Wed, Oct 02, 2019 at 12:08:49PM +0100, Colin King wrote: >>> From: Colin Ian King >>> >>> The expression !(hw_cap & XGMAC_HWFEAT_RAVSEL) >> 10 is always zero, so >>> the masking

[Patch v2 1/3] media: ov5640: add PIXEL_RATE control

2019-10-02 Thread Benoit Parrot
Add v4l2 controls to report the pixel rates of each mode. This is needed by some CSI2 receiver in order to perform proper DPHY configuration. Signed-off-by: Benoit Parrot --- drivers/media/i2c/ov5640.c | 25 + 1 file changed, 25 insertions(+) diff --git

[Patch v2 0/3] media: ov5640: updates

2019-10-02 Thread Benoit Parrot
This patch series is a collection of patches we have been carrying for a while. First, it adds support for PIXEL_RATE control which is used by some CSI2 receiver driver to properly set-up their DPHY. Then we fix an issue related to having extra sensor enable/disable in the register array for the

[Patch v2 3/3] media: ov5640: Make 2592x1944 mode only available at 15 fps

2019-10-02 Thread Benoit Parrot
The sensor data sheet clearly state that 2592x1944 only works at 15 fps make sure we don't try to miss configure the pll out of acceptable range. Signed-off-by: Benoit Parrot --- drivers/media/i2c/ov5640.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/media/i2c/ov5640.c

[Patch v2 2/3] media: ov5640: Fix 1920x1080 mode to remove extra enable/disable

2019-10-02 Thread Benoit Parrot
In the 1920x1080 register array an extra pair of reset ctrl disable re-enable was causing unwanted init delays. Signed-off-by: Benoit Parrot --- drivers/media/i2c/ov5640.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/media/i2c/ov5640.c

[PATCH v3 7/7] drm/vmwgfx: Add surface dirty-tracking callbacks

2019-10-02 Thread VMware
From: Thomas Hellstrom Add the callbacks necessary to implement emulated coherent memory for surfaces. Add a flag to the gb_surface_create ioctl to indicate that surface memory should be coherent. Also bump the drm minor version to signal the availability of coherent surfaces. Cc: Andrew Morton

[PATCH v3 5/7] drm/vmwgfx: Use an RBtree instead of linked list for MOB resources

2019-10-02 Thread VMware
From: Thomas Hellstrom With emulated coherent memory we need to be able to quickly look up a resource from the MOB offset. Instead of traversing a linked list with O(n) worst case, use an RBtree with O(log n) worst case complexity. Cc: Andrew Morton Cc: Matthew Wilcox Cc: Will Deacon Cc:

[PATCH v3 6/7] drm/vmwgfx: Implement an infrastructure for read-coherent resources

2019-10-02 Thread VMware
From: Thomas Hellstrom Similar to write-coherent resources, make sure that from the user-space point of view, GPU rendered contents is automatically available for reading by the CPU. Cc: Andrew Morton Cc: Matthew Wilcox Cc: Will Deacon Cc: Peter Zijlstra Cc: Rik van Riel Cc: Minchan Kim

[PATCH v3 0/7] Emulated coherent graphics memory take 2

2019-10-02 Thread VMware
From: Thomas Hellström Graphics APIs like OpenGL 4.4 and Vulkan require the graphics driver to provide coherent graphics memory, meaning that the GPU sees any content written to the coherent memory on the next GPU operation that touches that memory, and the CPU sees any content written by the

[PATCH v3 3/7] mm: Add write-protect and clean utilities for address space ranges

2019-10-02 Thread VMware
From: Thomas Hellstrom Add two utilities to a) write-protect and b) clean all ptes pointing into a range of an address space. The utilities are intended to aid in tracking dirty pages (either driver-allocated system memory or pci device memory). The write-protect utility should be used in

[PATCH v3 4/7] drm/vmwgfx: Implement an infrastructure for write-coherent resources

2019-10-02 Thread VMware
From: Thomas Hellstrom This infrastructure will, for coherent resources, make sure that from the user-space point of view, data written by the CPU is immediately automatically available to the GPU at resource validation time. Cc: Andrew Morton Cc: Matthew Wilcox Cc: Will Deacon Cc: Peter

[PATCH v3 2/7] mm: Add a walk_page_mapping() function to the pagewalk code

2019-10-02 Thread VMware
From: Thomas Hellstrom For users that want to travers all page table entries pointing into a region of a struct address_space mapping, introduce a walk_page_mapping() function. The walk_page_mapping() function will be initially be used for dirty- tracking in virtual graphics drivers. Cc:

[PATCH v3 1/7] mm: Remove BUG_ON mmap_sem not held from xxx_trans_huge_lock()

2019-10-02 Thread VMware
From: Thomas Hellstrom The caller needs to make sure that the vma is not torn down during the lock operation and can also use the i_mmap_rwsem for file-backed vmas. Remove the BUG_ON. We could, as an alternative, add a test that either vma->vm_mm->mmap_sem or

Re: [RFC PATCH v2 3/3] livepatch: Clean up klp_update_object_relocations() return paths

2019-10-02 Thread Petr Mladek
On Thu 2019-09-05 14:45:14, Miroslav Benes wrote: > Signed-off-by: Miroslav Benes This might depend on personal preferences. What was the motivation for this patch, please? Did it just follow some common style in this source file? To make it clear. I have no real preference. I just want to

Re: [PATCH 2/5] dt-bindings: mfd: da9062: add regulator voltage selection documentation

2019-10-02 Thread Marco Felsch
On 19-09-30 09:53, Adam Thomson wrote: > On 26 September 2019 15:39, Marco Felsch wrote: > > > On 19-09-26 14:04, Adam Thomson wrote: > > > On 26 September 2019 12:44, Marco Felsch wrote: > > > > > > > On 19-09-26 10:17, Adam Thomson wrote: > > > > > On 26 September 2019 09:10, Marco Felsch

Re: [PATCH] net: stmmac: xgmac: add missing parentheses to fix precendence error

2019-10-02 Thread Dan Carpenter
On Wed, Oct 02, 2019 at 04:33:57PM +0300, Dan Carpenter wrote: > On Wed, Oct 02, 2019 at 12:08:49PM +0100, Colin King wrote: > > From: Colin Ian King > > > > The expression !(hw_cap & XGMAC_HWFEAT_RAVSEL) >> 10 is always zero, so > > the masking operation is incorrect. Fix this by adding the

Re: [Xen-devel] [PATCH] x86/xen: Return from panic notifier

2019-10-02 Thread Jan Beulich
On 02.10.2019 15:24, Boris Ostrovsky wrote: > On 10/2/19 3:40 AM, Jan Beulich wrote: >> On 01.10.2019 17:16, Boris Ostrovsky wrote: >>> Currently execution of panic() continues until Xen's panic notifier >>> (xen_panic_event()) is called at which point we make a hypercall that >>> never returns.

Re: [PATCH] net: stmmac: xgmac: add missing parentheses to fix precendence error

2019-10-02 Thread Colin Ian King
On 02/10/2019 14:33, Dan Carpenter wrote: > On Wed, Oct 02, 2019 at 12:08:49PM +0100, Colin King wrote: >> From: Colin Ian King >> >> The expression !(hw_cap & XGMAC_HWFEAT_RAVSEL) >> 10 is always zero, so >> the masking operation is incorrect. Fix this by adding the missing >> parentheses to

Re: [PATCH 2/3] watchdog: sam9x60_wdt: introduce sam9x60 watchdog timer driver

2019-10-02 Thread kbuild test robot
Hi, I love your patch! Perhaps something to improve: [auto build test WARNING on linus/master] [cannot apply to v5.4-rc1 next-20191002] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify

Re: [PATCH 0/7] add support for clocksource/clockevent DT selection

2019-10-02 Thread Claudiu.Beznea
Hi Daniel, Taking into account that Rob doesn't agree with the solution proposed in this series do you think there is a chance to merge this driver as is? If you have other suggestion I am open to try it. Thank you, Claudiu Beznea On 26.09.2019 11:42, Claudiu Beznea wrote: > > > On

Re: [PATCH 2/7] ASoC: amd: Registering device endpoints using MFD framework

2019-10-02 Thread Lee Jones
On Wed, 02 Oct 2019, Deucher, Alexander wrote: > > -Original Message- > > From: Lee Jones > > Sent: Wednesday, October 2, 2019 8:38 AM > > To: Deucher, Alexander > > Cc: RAVULAPATI, VISHNU VARDHAN RAO > > ; Liam Girdwood > > ; Mark Brown ; Jaroslav > > Kysela ; Takashi Iwai ; Mukunda, >

Re: [RFC PATCH v2 2/3] livepatch: Unify functions for writing and clearing object relocations

2019-10-02 Thread Petr Mladek
On Thu 2019-09-05 14:45:13, Miroslav Benes wrote: > Functions klp_write_object_relocations() and > klp_clear_object_relocations() share a lot of code. Take the code out to > a common function and provide the specific actions through callbacks. > > Signed-off-by: Miroslav Benes I would prefer

Re: [PATCH] net: stmmac: xgmac: add missing parentheses to fix precendence error

2019-10-02 Thread Dan Carpenter
On Wed, Oct 02, 2019 at 12:08:49PM +0100, Colin King wrote: > From: Colin Ian King > > The expression !(hw_cap & XGMAC_HWFEAT_RAVSEL) >> 10 is always zero, so > the masking operation is incorrect. Fix this by adding the missing > parentheses to correctly bind the negate operator on the entire

Re: [PATCH] pwm: sun4i: redundant assignment to variable pval

2019-10-02 Thread Colin Ian King
On 02/10/2019 14:29, Dan Carpenter wrote: > On Wed, Oct 02, 2019 at 04:25:06PM +0300, Dan Carpenter wrote: >> On Wed, Oct 02, 2019 at 11:08:44AM +0100, Colin King wrote: >>> From: Colin Ian King >>> >>> Variable pval is being assigned a value that is never read. The >>> assignment is redundant

Re: [PATCH] pwm: sun4i: redundant assignment to variable pval

2019-10-02 Thread Dan Carpenter
On Wed, Oct 02, 2019 at 04:25:06PM +0300, Dan Carpenter wrote: > On Wed, Oct 02, 2019 at 11:08:44AM +0100, Colin King wrote: > > From: Colin Ian King > > > > Variable pval is being assigned a value that is never read. The > > assignment is redundant and hence can be removed. > > > >

Re: Ack to merge through DRM? WAS Re: [PATCH v2 1/5] mm: Add write-protect and clean utilities for address space ranges

2019-10-02 Thread VMware
On 10/2/19 3:18 PM, Kirill A. Shutemov wrote: On Wed, Oct 02, 2019 at 11:21:01AM +0200, Thomas Hellström (VMware) wrote: On 9/26/19 10:16 PM, Linus Torvalds wrote: On Thu, Sep 26, 2019 at 1:09 PM Thomas Hellström (VMware) wrote: That said, if people are OK with me modifying the assert in

Re: [PATCH] pwm: sun4i: redundant assignment to variable pval

2019-10-02 Thread Colin Ian King
On 02/10/2019 14:25, Dan Carpenter wrote: > On Wed, Oct 02, 2019 at 11:08:44AM +0100, Colin King wrote: >> From: Colin Ian King >> >> Variable pval is being assigned a value that is never read. The >> assignment is redundant and hence can be removed. >> >> Addresses-Coverity: ("Unused value") >>

Re: [PATCH] pwm: sun4i: redundant assignment to variable pval

2019-10-02 Thread Dan Carpenter
On Wed, Oct 02, 2019 at 11:08:44AM +0100, Colin King wrote: > From: Colin Ian King > > Variable pval is being assigned a value that is never read. The > assignment is redundant and hence can be removed. > > Addresses-Coverity: ("Unused value") > Signed-off-by: Colin Ian King > --- >

Re: [Xen-devel] [PATCH] x86/xen: Return from panic notifier

2019-10-02 Thread Boris Ostrovsky
On 10/2/19 3:40 AM, Jan Beulich wrote: > On 01.10.2019 17:16, Boris Ostrovsky wrote: >> Currently execution of panic() continues until Xen's panic notifier >> (xen_panic_event()) is called at which point we make a hypercall that >> never returns. >> >> This means that any notifier that is supposed

Re: [RFC PATCH v2 1/3] livepatch: Clear relocation targets on a module removal

2019-10-02 Thread Petr Mladek
On Thu 2019-09-05 14:45:12, Miroslav Benes wrote: > We thus decided to reverse the relocation patching (clear all relocation > targets on x86_64, or return back nops on powerpc). The solution is not > universal and is too much arch-specific, but it may prove to be simpler > in the end. > > diff

Re: [PATCH] arm64: errata: Update stale comment

2019-10-02 Thread Marc Zyngier
On Mon, 23 Sep 2019 11:12:29 +0200 Thierry Reding wrote: > From: Thierry Reding > > Commit 73f381660959 ("arm64: Advertise mitigation of Spectre-v2, or lack > thereof") renamed the caller of the install_bp_hardening_cb() function > but forgot to update a comment, which can be confusing when

Re: [PATCH] media: uvc: Avoid cyclic entity chains due to malformed USB descriptors

2019-10-02 Thread Will Deacon
Hi Laurent, On Wed, Oct 02, 2019 at 04:09:13PM +0300, Laurent Pinchart wrote: > Thank you for the patch. And thank you for the quick response. > On Wed, Oct 02, 2019 at 12:27:53PM +0100, Will Deacon wrote: > > I don't have a way to reproduce the original issue, so this change is > > based

Re: [PATCH] libertas: remove redundant assignment to variable ret

2019-10-02 Thread Dan Carpenter
Added Lubomir Rintel to the CC list. On Wed, Oct 02, 2019 at 11:15:17AM +0100, Colin King wrote: > From: Colin Ian King > > The variable ret is being assigned a value that is never read and is > being re-assigned a little later on. The assignment is redundant and hence > can be removed. > >

Re: [PATCH 4.19 36/63] locking/lockdep: Add debug_locks check in __lock_downgrade()

2019-10-02 Thread Waiman Long
On 10/1/19 6:20 PM, Sasha Levin wrote: > On Mon, Sep 30, 2019 at 10:00:35AM -0400, Waiman Long wrote: >> On 9/29/19 9:46 PM, Tetsuo Handa wrote: >>> On 2019/09/30 9:28, Sasha Levin wrote: On Sun, Sep 29, 2019 at 11:43:38PM +0900, Tetsuo Handa wrote: > On 2019/09/29 22:54, Greg

Re: [PATCH 2/3] watchdog: sam9x60_wdt: introduce sam9x60 watchdog timer driver

2019-10-02 Thread Guenter Roeck
On 10/2/19 12:35 AM, eugen.hris...@microchip.com wrote: From: Eugen Hristev This is the driver for SAM9X60 watchdog timer. The offered functionality is the same as sama5d4_wdt. The difference comes in register map, way to configure the timeout and interrupts. Developed starting from

[PATCH 3/3] tpm: Fix TPM 1.2 Shutdown sequence to prevent future TPM operations

2019-10-02 Thread Jarkko Sakkinen
From: Vadim Sukhomlinov commit db4d8cb9c9f2af71c4d087817160d866ed572cc9 upstream TPM 2.0 Shutdown involve sending TPM2_Shutdown to TPM chip and disabling future TPM operations. TPM 1.2 behavior was different, future TPM operations weren't disabled, causing rare issues. This patch ensures that

[PATCH 0/3] tpm: Fix TPM 1.2 Shutdown sequence to prevent future TPM operations

2019-10-02 Thread Jarkko Sakkinen
commit db4d8cb9c9f2af71c4d087817160d866ed572cc9 upstream This backport is for v4.14 and v4.19 The backport requires non-racy behaviour from TPM 1.x sysfs code. Thus, the dependecies for that are included. NOTE: 1/3 is only needed for v4.14. v2: * Something happened when merging 3/3 that write

[PATCH 2/3] tpm: use tpm_try_get_ops() in tpm-sysfs.c.

2019-10-02 Thread Jarkko Sakkinen
commit 2677ca98ae377517930c183248221f69f771c921 upstream Use tpm_try_get_ops() in tpm-sysfs.c so that we can consider moving other decorations (locking, localities, power management for example) inside it. This direction can be of course taken only after other call sites for tpm_transmit() have

[PATCH 1/3] tpm: migrate pubek_show to struct tpm_buf

2019-10-02 Thread Jarkko Sakkinen
commit da379f3c1db0c9a1fd27b11d24c9894b5edc7c75 upstream Migrated pubek_show to struct tpm_buf and cleaned up its implementation. Previously the output parameter structure was declared but left completely unused. Now it is used to refer different fields of the output. We can move it to

RE: [PATCH 2/7] ASoC: amd: Registering device endpoints using MFD framework

2019-10-02 Thread Deucher, Alexander
> -Original Message- > From: Lee Jones > Sent: Wednesday, October 2, 2019 8:38 AM > To: Deucher, Alexander > Cc: RAVULAPATI, VISHNU VARDHAN RAO > ; Liam Girdwood > ; Mark Brown ; Jaroslav > Kysela ; Takashi Iwai ; Mukunda, > Vijendar ; Maruthi Srinivas Bayyavarapu > ; Mehta, Sanju > ;

Re: [PATCH v2 1/1] blk-mq: Inline request status checkers

2019-10-02 Thread Jens Axboe
On 9/30/19 2:12 PM, Pavel Begunkov wrote: > On 30/09/2019 22:53, Bart Van Assche wrote: >> On 9/30/19 12:43 PM, Pavel Begunkov (Silence) wrote: >>> @@ -282,7 +282,7 @@ static bool bt_tags_iter(struct sbitmap *bitmap, >>> unsigned int bitnr, void *data) >>> * test and set the bit before

Re: [PATCH] media: uvc: Avoid cyclic entity chains due to malformed USB descriptors

2019-10-02 Thread Laurent Pinchart
Hi Will, Thank you for the patch. On Wed, Oct 02, 2019 at 12:27:53PM +0100, Will Deacon wrote: > Way back in 2017, fuzzing the 4.14-rc2 USB stack with syzkaller kicked > up the following WARNING from the UVC chain scanning code: > > | list_add double add: new=880069084010,

Re: Lease semantic proposal

2019-10-02 Thread Dan Williams
On Tue, Oct 1, 2019 at 2:02 PM Ira Weiny wrote: > > On Mon, Sep 30, 2019 at 06:42:33PM +1000, Dave Chinner wrote: > > On Wed, Sep 25, 2019 at 04:46:03PM -0700, Ira Weiny wrote: > > > On Tue, Sep 24, 2019 at 08:26:20AM +1000, Dave Chinner wrote: > > > > Hence, AFIACT, the above definition of a

Re: [PATCH 1/4] iio: pressure: bmp280: use bulk regulator ops

2019-10-02 Thread kbuild test robot
Hi Bartosz, I love your patch! Yet something to improve: [auto build test ERROR on iio/togreg] [cannot apply to v5.4-rc1 next-20191002] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify

Re: [PATCH] mfd: intel-lpss: Add default I2C device properties for Gemini Lake

2019-10-02 Thread Lee Jones
On Wed, 04 Sep 2019, Jarkko Nikula wrote: > It turned out Intel Gemini Lake doesn't use the same I2C timing > parameters as Broxton. > > I got confirmation from the Windows team that Gemini Lake systems should > use updated timing parameters that differ from those used in Broxton > based

Re: [PATCH v2] ARM: add __always_inline to functions called from __get_user_check()

2019-10-02 Thread Masahiro Yamada
Hi Nick, On Wed, Oct 2, 2019 at 2:04 AM Nick Desaulniers wrote: > > Since that commit, all architectures can enable CONFIG_OPTIMIZE_INLINING. > > So, __always_inline is now the only guaranteed way of forcible inlining. > > No, the C preprocessor is the only guaranteed way of inlining. I do not

Re: [PATCH RFC 00/14] The new slab memory controller

2019-10-02 Thread Suleiman Souhlal
On Wed, Oct 2, 2019 at 11:09 AM Roman Gushchin wrote: > > On Tue, Oct 01, 2019 at 05:12:02PM +0200, Michal Koutný wrote: > > On Thu, Sep 05, 2019 at 02:45:44PM -0700, Roman Gushchin > > wrote: > > > Roman Gushchin (14): > > > [...] > > > mm: memcg/slab: use one set of kmem_caches for all

Re: [PATCH] compiler: enable CONFIG_OPTIMIZE_INLINING forcibly

2019-10-02 Thread Geert Uytterhoeven
Hi Nick, On Wed, Oct 2, 2019 at 6:33 AM Nick Desaulniers wrote: > On Tue, Oct 1, 2019 at 11:14 AM Russell King - ARM Linux admin > wrote: > > On Tue, Oct 01, 2019 at 11:00:11AM -0700, Nick Desaulniers wrote: > > > On Tue, Oct 1, 2019 at 10:55 AM Russell King - ARM Linux admin > > > wrote: > >

Re: [PATCH 4/7] iio: adc: max1027: Prepare the introduction of different resolutions

2019-10-02 Thread Miquel Raynal
Hello, Miquel Raynal wrote on Wed, 2 Oct 2019 14:30:22 +0200: > Maxim's max1027/29/31 series returns the measured voltages with a > resolution of 10 bits. There is a very similar series, max1227/29/31 > which works very similarly but uses a resolution of 12 bits. Prepare > the support for

[PATCH] nvme: fix uninitialized return of ret when sysfs_create_link fails

2019-10-02 Thread Colin King
From: Colin Ian King Currently when the call to sysfs_create_link fails the error exit path returns an uninitialized value in variable ret. Fix this by returning the error code returned from the failed call to sysfs_create_link. Addresses-Coverity: ("Uninitialized scalar variable") Fixes:

Re: [PATCH] tpm: Detach page allocation from tpm_buf

2019-10-02 Thread Mimi Zohar
On Fri, 2019-09-27 at 16:06 +0300, Jarkko Sakkinen wrote: > On Wed, Sep 25, 2019 at 10:03:46AM -0400, James Bottomley wrote: > > On Wed, 2019-09-25 at 16:48 +0300, Jarkko Sakkinen wrote: > > [...] > > > + data_page = alloc_page(GFP_HIGHUSER); > > > + if (!data_page) > > > + return -ENOMEM;

[RESEND PATCH] pinctrl: devicetree: Avoid taking direct reference to device name string

2019-10-02 Thread Will Deacon
When populating the pinctrl mapping table entries for a device, the 'dev_name' field for each entry is initialised to point directly at the string returned by 'dev_name()' for the device and subsequently used by 'create_pinctrl()' when looking up the mappings for the device being probed. This is

Re: [PATCHv2] ARM: drivers/amba: release the resource to allow for deferred probe

2019-10-02 Thread Russell King - ARM Linux admin
On Wed, Oct 02, 2019 at 07:33:49AM -0500, Dinh Nguyen wrote: > With commit "79bdcb202a35 ARM: 8906/1: drivers/amba: add reset control to > amba bus probe", the amba bus driver needs to be deferred probe because the > reset driver is probed later. However with a deferred probe, the call to >

Re: [PATCH 5/7] irqchip/irq-bcm2836: Add support for the 7211 interrupt controller

2019-10-02 Thread Marc Zyngier
On Tue, 1 Oct 2019 15:48:40 -0700 Florian Fainelli wrote: > The root interrupt controller on 7211 is about identical to the one > existing on BCM2836, except that the SMP cross call are done through the > standard ARM GIC-400 interrupt controller. This interrupt controller is > used for side

[PATCH v2 6/6] leds: core: Fix leds.h structure documentation

2019-10-02 Thread Dan Murphy
Update the leds.h structure documentation to define the correct arguments. Signed-off-by: Dan Murphy --- include/linux/leds.h | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/include/linux/leds.h b/include/linux/leds.h index 52e50183b963..242258f7d837 100644 ---

[PATCH v2 5/6] leds: core: Fix devm_classdev_match to reference correct structure

2019-10-02 Thread Dan Murphy
Fix the devm_classdev_match pointer initilization to the correct structure type. Signed-off-by: Dan Murphy --- drivers/leds/led-class.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/leds/led-class.c b/drivers/leds/led-class.c index 3f04334d59ee..438774315e6c 100644

[PATCH v2 2/6] leds: flash: Add devm_* functions to the flash class

2019-10-02 Thread Dan Murphy
Add the missing device managed API for registration and unregistration for the LED flash class. Signed-off-by: Dan Murphy --- drivers/leds/led-class-flash.c | 50 + include/linux/led-class-flash.h | 14 + 2 files changed, 64 insertions(+) diff --git

[PATCH v2 3/6] leds: lm3601x: Convert class registration to device managed

2019-10-02 Thread Dan Murphy
Convert LED flash class registration to device managed class registration API. Signed-off-by: Dan Murphy --- drivers/leds/leds-lm3601x.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/leds/leds-lm3601x.c b/drivers/leds/leds-lm3601x.c index

Re: [PATCH] tpm: Detach page allocation from tpm_buf

2019-10-02 Thread Mimi Zohar
On Thu, 2019-09-26 at 16:12 +0300, Jarkko Sakkinen wrote: > On Thu, Sep 26, 2019 at 03:46:35PM +0300, Jarkko Sakkinen wrote: > > On Wed, Sep 25, 2019 at 04:48:41PM +0300, Jarkko Sakkinen wrote: > > > - tpm_buf_reset(, TPM2_ST_NO_SESSIONS, TPM2_CC_GET_RANDOM); > > > +

[PATCH v2 4/6] leds: core: Remove extern from header

2019-10-02 Thread Dan Murphy
extern is implied and is not needed in the header file. Remove the extern keyword and re-align the code. Signed-off-by: Dan Murphy --- include/linux/leds.h | 95 1 file changed, 44 insertions(+), 51 deletions(-) diff --git a/include/linux/leds.h

[PATCH v2 1/6] leds: flash: Remove extern from the header file

2019-10-02 Thread Dan Murphy
extern is implied and is not needed in the header file. Remove the extern keyword and re-align the code. Signed-off-by: Dan Murphy --- include/linux/led-class-flash.h | 22 ++ 1 file changed, 10 insertions(+), 12 deletions(-) diff --git a/include/linux/led-class-flash.h

Re: [Patch 1/3] media: ov5640: add PIXEL_RATE control

2019-10-02 Thread Benoit Parrot
Sakari Ailus wrote on Wed [2019-Oct-02 15:35:13 +0300]: > Hi Benoit, > > On Wed, Oct 02, 2019 at 07:14:38AM -0500, Benoit Parrot wrote: > > Hi Jacopo, > > > > Maybe, I miss spoke when I mentioned a helper I did not intent a framework > > level generic function. Just a function to help in this

Re: [PATCH 2/7] ASoC: amd: Registering device endpoints using MFD framework

2019-10-02 Thread Lee Jones
On Tue, 01 Oct 2019, Deucher, Alexander wrote: > > -Original Message- > > From: Lee Jones > > Sent: Tuesday, October 1, 2019 8:00 AM > > To: RAVULAPATI, VISHNU VARDHAN RAO > > > > Cc: RAVULAPATI, VISHNU VARDHAN RAO > > ; Deucher, Alexander > > ; Liam Girdwood ; > > Mark Brown ; Jaroslav

Re: [PATCH v2] rtl8xxxu: add bluetooth co-existence support for single antenna

2019-10-02 Thread Chris Chiu
On Wed, Oct 2, 2019 at 12:29 PM Kalle Valo wrote: > Failed to apply, please rebase on top of wireless-drivers-next. > > fatal: sha1 information is lacking or useless > (drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.h). > error: could not build fake ancestor > Applying: rtl8xxxu: add bluetooth

Re: [PATCH] perf/x86/intel/uncore: fix integer overflow on shift of a u32 integer

2019-10-02 Thread Colin Ian King
On 02/10/2019 13:23, Mark Rutland wrote: > On Wed, Oct 02, 2019 at 12:55:45PM +0100, Colin King wrote: >> From: Colin Ian King >> >> Shifting the u32 integer result of (pci_dword & SNR_IMC_MMIO_BASE_MASK) >> will end up with an overflow when pci_dword greater than 0x1ff. Fix this >> by casting

[PATCH] panic: Ensure preemption is disabled during panic()

2019-10-02 Thread Will Deacon
Calling 'panic()' on a kernel with CONFIG_PREEMPT=y can leave the calling CPU in an infinite loop, but with interrupts and preemption enabled. From this state, userspace can continue to be scheduled, despite the system being "dead" as far as the kernel is concerned. This is easily reproducible on

Re: [Patch 1/3] media: ov5640: add PIXEL_RATE control

2019-10-02 Thread Sakari Ailus
Hi Benoit, On Wed, Oct 02, 2019 at 07:14:38AM -0500, Benoit Parrot wrote: > Hi Jacopo, > > Maybe, I miss spoke when I mentioned a helper I did not intent a framework > level generic function. Just a function to help in this case :) > > That being said, I re-read the thread you mentioned. And as

[PATCHv2] ARM: drivers/amba: release the resource to allow for deferred probe

2019-10-02 Thread Dinh Nguyen
With commit "79bdcb202a35 ARM: 8906/1: drivers/amba: add reset control to amba bus probe", the amba bus driver needs to be deferred probe because the reset driver is probed later. However with a deferred probe, the call to request_resource() in the driver returns -EBUSY. The reason is the driver

<    2   3   4   5   6   7   8   9   10   >