Re: [PATCH 3/3] arm64: dts: rockchip: fix RockPro64 sdmmc settings【请注意,邮件由linux-rockchip-bounces+shawn.lin=rock-chips....@lists.infradead.org代发】

2019-10-04 Thread Soeren Moch
Heiko, since you started to apply the first 2 Patches of this series (thanks for that!), now after all the discussions here (and the heads-up for the implemented mode detection) I think we should leave the vcc_sdio regulator settings unmodified. It still could make sense to remove the cap-mmc-hig

Re: [PATCH v2 6/7] intel-speed-select: Implement 'perf-profile info' on CascadeLake-N

2019-10-04 Thread Srinivas Pandruvada
On Thu, 2019-10-03 at 08:11 -0400, Prarit Bhargava wrote: > Add functionality for perf-profile info on CascadeLake-N. Also the display is not correct. It will show redundant info for both packages. #intel-speed-select perf-profile info Intel(R) Speed Select Technology Executing on CPU model:85[0x

Re: [PATCH] KEYS: asym_tpm: Switch to get_random_bytes()

2019-10-04 Thread Jerry Snitselaar
On Fri Oct 04 19, Jerry Snitselaar wrote: On Fri Oct 04 19, James Bottomley wrote: On Fri, 2019-10-04 at 11:33 -0700, Jerry Snitselaar wrote: On Fri Oct 04 19, James Bottomley wrote: On Fri, 2019-10-04 at 21:22 +0300, Jarkko Sakkinen wrote: > On Thu, Oct 03, 2019 at 04:59:37PM -0700, James Bot

Re: ARM: multi_v7_defconfig: Fix SPI_STM32_QSPI support

2019-10-04 Thread Olof Johansson
On Fri, Oct 4, 2019 at 5:40 AM wrote: > > From: Patrice Chotard > > SPI_STM32_QSPI must be set in buildin as rootfs can be > located on QSPI memory device. > > Signed-off-by: Patrice Chotard > --- > arch/arm/configs/multi_v7_defconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) App

Re: [RFC PATCH 00/13] XOM for KVM guest userspace

2019-10-04 Thread Edgecombe, Rick P
On Fri, 2019-10-04 at 07:56 -0700, Andy Lutomirski wrote: > On Thu, Oct 3, 2019 at 2:38 PM Rick Edgecombe > wrote: > > > > This patchset enables the ability for KVM guests to create execute-only (XO) > > memory by utilizing EPT based XO permissions. XO memory is currently > > supported > > on Int

Re: [PATCH 1/2] leds: Add flag to keep trigger always

2019-10-04 Thread Guru Das Srinagesh
On Mon, Sep 30, 2019 at 07:27:43PM +0200, Greg KH wrote: > On Mon, Sep 30, 2019 at 07:22:39PM +0200, Pavel Machek wrote: > > On Mon 2019-09-30 15:39:02, Greg KH wrote: > > > On Sat, Aug 10, 2019 at 09:13:22AM +0200, Pavel Machek wrote: > > > > On Fri 2019-08-09 17:52:46, Guru Das Srinagesh wrote: >

[PATCH] mwifiex: pcie: Fix memory leak in mwifiex_pcie_alloc_cmdrsp_buf

2019-10-04 Thread Navid Emamdoost
In mwifiex_pcie_alloc_cmdrsp_buf, a new skb is allocated which should be released if mwifiex_map_pci_memory() fails. The release is added. Fixes: fc3314609047 ("mwifiex: use pci_alloc/free_consistent APIs for PCIe") Signed-off-by: Navid Emamdoost --- drivers/net/wireless/marvell/mwifiex/pcie.c |

Re: [Linux-stm32] [PATCH] pwm: stm32: Fix the usage of uninitialized variable in stm32_pwm_config()

2019-10-04 Thread Uwe Kleine-König
Hello, Cc += Mark Brown who maintains regmap On Fri, Oct 04, 2019 at 09:09:51AM +, Benjamin GAIGNARD wrote: > > On 10/4/19 8:23 AM, Uwe Kleine-König wrote: > > Hello, > > > > On Thu, Oct 03, 2019 at 09:46:49PM -0700, Yizhuo wrote: > >> Inside function stm32_pwm_config(), variable "psc" and "

[GIT PULL] MIPS fixes

2019-10-04 Thread Paul Burton
Hi Linus, Here is a selection of fixes for arch/mips, mostly handling regressions introduced during the v5.4 merge window; please pull. Thanks, Paul The following changes since commit 54ecb8f7028c5eb3d740bb82b0f1d90f2df63c5c: Linux 5.4-rc1 (2019-09-30 10:35:40 -0700) are available in th

Re: [PATCH 2/3] arm64: dts: rockchip: fix RockPro64 sdhci settings

2019-10-04 Thread Heiko Stuebner
Am Donnerstag, 3. Oktober 2019, 23:50:35 CEST schrieb Soeren Moch: > The RockPro64 schematics [1], [2] show that the rk3399 EMMC_STRB pin is > connected to the RESET pin instead of the DATA_STROBE pin of the eMMC module. > So the data strobe cannot be used for its intended purpose on this board, >

Re: [PATCH 1/3] arm64: dts: rockchip: fix RockPro64 vdd-log regulator settings

2019-10-04 Thread Heiko Stuebner
Am Donnerstag, 3. Oktober 2019, 23:50:34 CEST schrieb Soeren Moch: > The RockPro64 schematic [1] page 18 states a min voltage of 0.8V and a > max voltage of 1.4V for the VDD_LOG pwm regulator. However, there is an > additional note that the pwm parameter needs to be modified. > From the schematics

[PATCH] staging: vt6655: Fix memory leak in vt6655_probe

2019-10-04 Thread Navid Emamdoost
In vt6655_probe, if vnt_init() fails the cleanup code needs to be called like other error handling cases. The call to device_free_info() is added. Fixes: 67013f2c0e58 ("staging: vt6655: mac80211 conversion add main mac80211 functions") Signed-off-by: Navid Emamdoost --- drivers/staging/vt6655/d

Re: [GIT PULL] usercopy structs for v5.4-rc2

2019-10-04 Thread Christian Brauner
On Fri, Oct 04, 2019 at 10:53:41AM -0700, Linus Torvalds wrote: > On Fri, Oct 4, 2019 at 3:42 AM Christian Brauner > wrote: > > > >The only separate fix we we had to apply > > was for a warning by clang when building the tests for using the result of > > an assignment as a condition wi

Re: [PATCH] arm64: dts: rockchip: add analog audio nodes on rk3399-rockpro64

2019-10-04 Thread Heiko Stuebner
Hi Katsuhiro, Am Freitag, 4. Oktober 2019, 19:26:00 CEST schrieb Katsuhiro Suzuki: > Past about 1 month, so I send a ping... > > On 2019/09/08 2:48, Katsuhiro Suzuki wrote: > > This patch adds audio codec (Everest ES8316) and I2S audio nodes for > > RK3399 RockPro64. > > > > Signed-off-by: Katsu

Re: e1000e regression - 5.4rc1

2019-10-04 Thread Tobias Klausmann
Hello, On 04.10.19 19:36, Kai-Heng Feng wrote: Hi Tobias On Oct 4, 2019, at 18:34, Tobias Klausmann wrote: Hello all, While testing the 5.4rc1 release, i noticed my Ethernet never coming fully up, seemingly having a timeout problem. While bisecting this i landed at the commit dee23594d58

[PATCH] rtlwifi: fix memory leak in rtl_usb_probe

2019-10-04 Thread Navid Emamdoost
In rtl_usb_probe, a new hw is allocated via ieee80211_alloc_hw(). This allocation should be released in case of allocation failure for rtlpriv->usb_data. Fixes: a7959c1394d4 ("rtlwifi: Preallocate USB read buffers and eliminate kalloc in read routine") Signed-off-by: Navid Emamdoost --- drivers

Re: [PATCH] arm64: dts: rockchip: add missing #msi-cells to rk3399

2019-10-04 Thread Heiko Stuebner
Am Dienstag, 17. September 2019, 10:36:25 CEST schrieb Heiko Stuebner: > The rk3399 gic-its was missing the #msi-cells property as found by > dt-schema checks, so add it. > > Signed-off-by: Heiko Stuebner applied for 5.5

[PATCH] rcu/nocb: Fix dump_tree hierarchy print always active

2019-10-04 Thread Stefan Reiter
Commit 18cd8c93e69e ("rcu/nocb: Print gp/cb kthread hierarchy if dump_tree") added print statements to rcu_organize_nocb_kthreads for debugging, but incorrectly guarded them, causing the function to always spew out its message. This patch fixes it by guarding both pr_alert statements with dump_tre

Re: [PATCH] PCI: Enhance the ACS quirk for Cavium devices

2019-10-04 Thread Bjorn Helgaas
On Mon, Sep 30, 2019 at 11:20:50PM +, Jayachandran Chandrasekharan Nair wrote: > On Mon, Sep 30, 2019 at 03:34:10PM -0500, Bjorn Helgaas wrote: > > On Thu, Sep 19, 2019 at 02:43:34AM +, George Cherian wrote: > > > Enhance the ACS quirk for Cavium Processors. Add the root port > > > vendor

Re: [PATCH] sata_gemini: Use devm_platform_ioremap_resource() in gemini_sata_probe()

2019-10-04 Thread Linus Walleij
On Wed, Sep 18, 2019 at 8:34 AM Markus Elfring wrote: > From: Markus Elfring > Date: Wed, 18 Sep 2019 08:28:09 +0200 > > Simplify this function implementation by using a known wrapper function. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring Look

Re: [GIT PULL] usercopy structs for v5.4-rc2

2019-10-04 Thread Nathan Chancellor
On Fri, Oct 04, 2019 at 10:53:41AM -0700, Linus Torvalds wrote: > On Fri, Oct 4, 2019 at 3:42 AM Christian Brauner > wrote: > > > >The only separate fix we we had to apply > > was for a warning by clang when building the tests for using the result of > > an assignment as a condition wi

[PATCH] nl80211: fix memory leak in nl80211_get_ftm_responder_stats

2019-10-04 Thread Navid Emamdoost
In nl80211_get_ftm_responder_stats, a new skb is created via nlmsg_new named msg. If nl80211hdr_put() fails, then msg should be released. The return statement should be replace by goto to error handling code. Fixes: 81e54d08d9d8 ("cfg80211: support FTM responder configuration/statistics") Signed-o

Re: [PATCH 3/5] regulator: da9062: add voltage selection gpio support

2019-10-04 Thread Linus Walleij
On Tue, Sep 17, 2019 at 2:43 PM Marco Felsch wrote: > + /* > +* We only must ensure that the gpio device is probed before the > +* regulator driver so no need to store the reference global. Luckily > +* devm_* releases the gpio upon a unbound action. > +*/ >

Re: [PATCH 03/15] mm: Add file_offset_of_ helpers

2019-10-04 Thread Matthew Wilcox
On Thu, Sep 26, 2019 at 05:02:11PM +0300, Kirill A. Shutemov wrote: > On Tue, Sep 24, 2019 at 05:52:02PM -0700, Matthew Wilcox wrote: > > From: "Matthew Wilcox (Oracle)" > > > > The page_offset function is badly named for people reading the functions > > which call it. The natural meaning of a f

Re: [PATCH 11/15] mm: Remove hpage_nr_pages

2019-10-04 Thread Matthew Wilcox
On Thu, Oct 03, 2019 at 01:08:59PM +0800, Hillf Danton wrote: > > On Tue, 24 Sep 2019 17:52:02 -0700 From: Matthew Wilcox (Oracle) > > > > @@ -354,7 +354,7 @@ vma_address(struct page *page, struct vm_area_struct > > *vma) > > unsigned long start, end; > > > > start = __vma_address(page,

Re: [PATCH 06/15] xfs: Pass a page to xfs_finish_page_writeback

2019-10-04 Thread Matthew Wilcox
On Thu, Oct 03, 2019 at 12:08:46PM +0800, Hillf Danton wrote: > > On Tue, 24 Sep 2019 17:52:02 -0700 From: Matthew Wilcox (Oracle) > > > > The only part of the bvec we were accessing was the bv_page, so just > > pass that instead of the whole bvec. > > Change is added in ABI without a bit of win

Re: [PATCH 04/15] iomap: Support large pages

2019-10-04 Thread Matthew Wilcox
On Wed, Oct 02, 2019 at 09:32:11PM +0800, Hillf Danton wrote: > > On Tue, 24 Sep 2019 17:52:02 -0700 From: Matthew Wilcox (Oracle) > > > > @@ -1415,6 +1415,8 @@ static inline void clear_page_pfmemalloc(struct page > > *page) > > extern void pagefault_out_of_memory(void); > > > > #define offs

Re: [PATCH 03/15] mm: Add file_offset_of_ helpers

2019-10-04 Thread Matthew Wilcox
Your mail program is still broken. This shows up as a reply to the 0/15 email instead of as a reply to the 3/15 email. On Wed, Oct 02, 2019 at 09:07:53PM +0800, Hillf Danton wrote: > On Tue, 24 Sep 2019 17:52:02 -0700 From: Matthew Wilcox (Oracle) > > +/** > > + * file_offset_of_page - File off

Re: [PATCH] serial: 8250_omap: Fix idling for unloaded serdev drivers

2019-10-04 Thread Adam Ford
On Tue, Jul 23, 2019 at 5:21 PM Tony Lindgren wrote: > > For many years omap variants have been setting the runtime PM > autosuspend delay to -1 to prevent unsafe policy with lossy first > character on wake-up. The user must specifically enable the timeout > for UARTs if desired. > > We must not e

Re: [PATCH 02/15] fs: Introduce i_blocks_per_page

2019-10-04 Thread Matthew Wilcox
On Wed, Sep 25, 2019 at 06:36:50PM +1000, Dave Chinner wrote: > I'm actually working on abstrcting this code from both block size > and page size via the helpers below. We ahve need to support block > size > page size, and so that requires touching a bunch of all the > same code as this patchset. I

Re: [PATCH] Remove GP_REPLAY state from rcu_sync

2019-10-04 Thread kbuild test robot
Hi "Joel, I love your patch! Yet something to improve: [auto build test ERROR on rcu/dev] [cannot apply to v5.4-rc1 next-20191004] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to s

Re: [PATCH][next] drm/komeda: remove redundant assignment to pointer disable_done

2019-10-04 Thread Liviu Dudau
On Fri, Oct 04, 2019 at 05:21:56PM +0100, Colin King wrote: > From: Colin Ian King > > The pointer disable_done is being initialized with a value that > is never read and is being re-assigned a little later on. The > assignment is redundant and hence can be removed. Not really true, isn't it? Th

Re: [PATCH v2 4/6] dt-bindings: pwm: mxs-pwm: Increase #pwm-cells

2019-10-04 Thread Uwe Kleine-König
On Fri, Oct 04, 2019 at 03:32:05PM +0200, Rasmus Villemoes wrote: > We need to increase the pwm-cells for the optional flags parameter, in > order to implement support for polarity setting via DT. > > Acked-by: Rob Herring Acked-by: Uwe Kleine-König Thanks Uwe -- Pengutronix e.K.

Re: [PATCH] rtc: snvs: fix uninitialized usage of "lpcr" in snvs_rtc_enable()

2019-10-04 Thread Alexandre Belloni
On 04/10/2019 11:52:06-0700, Yizhuo wrote: > Inside function snvs_rtc_enable(), variable "lpcr" could be > uninitialized if regmap_read() returns -EINVAL. However,"lpcr" > is used later in the if statement, which is potentially unsafe. > This is not true, regmap_read either lock up the cpu or not

Re: [RFC PATCH 12/13] mmap: Add XO support for KVM XO

2019-10-04 Thread Edgecombe, Rick P
On Fri, 2019-10-04 at 09:34 +0200, Paolo Bonzini wrote: > On 03/10/19 23:23, Rick Edgecombe wrote: > > + > > + protection_map[4] = PAGE_EXECONLY; > > + protection_map[12] = PAGE_EXECONLY; > > Can you add #defines for the bits in protection_map? Also perhaps you > can replace the p_xo/p_xr/s_x

HELLO PLEASE CAN I SPEAK WITH YOU?

2019-10-04 Thread Angel Helen
Hello dear, My name is Miss Helen i am a humble sincere single girl looking for true love, and a partner to assist me transfer my late father money, an amount of, (Four Million Two Hundred Thousand US Dollars) to your country for investment. I will give you 40% after the transfer, while the remaini

Re: [RFC PATCH 05/13] kvm: Add #PF injection for KVM XO

2019-10-04 Thread Edgecombe, Rick P
On Fri, 2019-10-04 at 09:42 +0200, Paolo Bonzini wrote: > On 03/10/19 23:23, Rick Edgecombe wrote: > > + if (!vcpu->arch.gva_available) > > + return 0; > > Please return RET_PF_* constants, RET_PF_EMULATE here. Ok. > > + if (error_code & PFERR_WRITE_MASK) > > + fault_erro

Re: [RFC PATCH 06/13] kvm: Add KVM_CAP_EXECONLY_MEM

2019-10-04 Thread Edgecombe, Rick P
On Fri, 2019-10-04 at 09:24 +0200, Paolo Bonzini wrote: > On 03/10/19 23:23, Rick Edgecombe wrote: > > Add a KVM capability for the KVM_MEM_EXECONLY memslot type. This memslot > > type is supported if the HW supports execute-only TDP. > > > > Signed-off-by: Rick Edgecombe > > --- > > arch/x86/in

Re: [GIT PULL] usercopy structs for v5.4-rc2

2019-10-04 Thread Aleksa Sarai
On 2019-10-04, Linus Torvalds wrote: > On Fri, Oct 4, 2019 at 3:42 AM Christian Brauner > wrote: > > > >The only separate fix we we had to apply > > was for a warning by clang when building the tests for using the result of > > an assignment as a condition without parantheses. > > Hm

[PATCH] mm: memcg/slab: fix panic in __free_slab() caused by premature memcg pointer release

2019-10-04 Thread Roman Gushchin
Karsten reported the following panic in __free_slab() happening on a s390x machine: 349.361168¨ Unable to handle kernel pointer dereference in virtual kernel address space 349.361210¨ Failing address: TEID: 0483 349.361223¨ Fault in home space mode while using kernel

Re: [RFC PATCH 03/13] kvm: Add XO memslot type

2019-10-04 Thread Edgecombe, Rick P
On Fri, 2019-10-04 at 09:27 +0200, Paolo Bonzini wrote: > On 03/10/19 23:23, Rick Edgecombe wrote: > > Add XO memslot type to create execute-only guest physical memory based on > > the RO memslot. Like the RO memslot, disallow changing the memslot type > > to/from XO. > > > > In the EPT case ACC_U

Re: [PATCH 0/4] HiSilicon hip08 uncore PMU events additions

2019-10-04 Thread Arnaldo Carvalho de Melo
Em Fri, Oct 04, 2019 at 05:30:46PM +0100, John Garry escreveu: > > > > > > > > > The missing events were originally mentioned in > > > > > > > https://lkml.org/lkml/2019/6/14/645, when upstreaming the JSONs > > > > > > > initially. > > > > > > > > > It also includes a fix for a DDRC eventname. >

Re: [RFC PATCH 00/13] XOM for KVM guest userspace

2019-10-04 Thread Edgecombe, Rick P
On Fri, 2019-10-04 at 09:22 +0200, Paolo Bonzini wrote: > On 03/10/19 23:23, Rick Edgecombe wrote: > > Since software would have previously received a #PF with the RSVD error code > > set, when the HW encountered any set bits in the region 51 to M, there was > > some > > internal discussion on whet

Re: [PATCH v3 2/2] tpm: Detach page allocation from tpm_buf

2019-10-04 Thread Jarkko Sakkinen
On Fri, Oct 04, 2019 at 09:37:42AM -0700, James Bottomley wrote: > On Thu, 2019-10-03 at 21:51 +0300, Jarkko Sakkinen wrote: > > As has been seen recently, binding the buffer allocation and tpm_buf > > together is sometimes far from optimal. > > Can you elaborate on this a bit more? I must have m

[PATCH] of: unittest: fix memory leak in unittest_data_add

2019-10-04 Thread Navid Emamdoost
In unittest_data_add, a copy buffer is created via kmemdup. This buffer is leaked if of_fdt_unflatten_tree fails. The release for the unittest_data buffer is added. Fixes: b951f9dc7f25 ("Enabling OF selftest to run without machine's devicetree") Signed-off-by: Navid Emamdoost --- drivers/of/unit

Re: [PATCH v22 07/24] x86/sgx: Add wrappers for ENCLS leaf functions

2019-10-04 Thread Jarkko Sakkinen
On Fri, Oct 04, 2019 at 11:45:13AM +0200, Borislav Petkov wrote: > On Tue, Sep 03, 2019 at 05:26:38PM +0300, Jarkko Sakkinen wrote: > > ENCLS is a ring 0 instruction that contains a set of leaf functions for > > managing enclaves [1]. Enclaves SGX hosted measured and signed software > > entities, w

[PATCH v6 13/17] kexec: add machine_kexec_post_load()

2019-10-04 Thread Pavel Tatashin
It is the same as machine_kexec_prepare(), but is called after segments are loaded. This way, can do processing work with already loaded relocation segments. One such example is arm64: it has to have segments loaded in order to create a page table, but it cannot do it during kexec time, because at

[PATCH v6 17/17] arm64: kexec: enable MMU during kexec relocation

2019-10-04 Thread Pavel Tatashin
Now, that we have transitional page tables configured, temporarily enable MMU to allow faster relocation of segments to final destination. The performance data: for a moderate size kernel + initramfs: 25M the relocation was taking 0.382s, with enabled MMU it now takes 0.019s only or x20 improvemen

[PATCH v6 12/17] arm64: trans_pgd: pass NULL instead of init_mm to *_populate functions

2019-10-04 Thread Pavel Tatashin
trans_pgd_* should be independent from mm context because the tables that are created by this code are used when there are no mm context around, as it is between kernels. Simply replace mm_init's with NULL. Signed-off-by: Pavel Tatashin --- arch/arm64/mm/trans_pgd.c | 12 ++-- 1 file cha

Re: [PATCH] mm/page_isolation: fix a deadlock with printk()

2019-10-04 Thread Qian Cai
On Fri, 2019-10-04 at 19:47 +0200, David Hildenbrand wrote: > On 04.10.19 18:42, Qian Cai wrote: > > It is unsafe to call printk() while zone->lock was held, i.e., > > > > zone->lock --> console_sem > > > > because the console could always allocate some memory in different code > > paths and form

Re: [PATCH v22 16/24] x86/vdso: Add support for exception fixup in vDSO functions

2019-10-04 Thread Jarkko Sakkinen
On Thu, Oct 03, 2019 at 05:15:00PM -0700, Sean Christopherson wrote: > I'll tackle this tomorrow. I've been working on the feature control MSR > series and will get that sent out tomorrow as well. I should also be able > to get you the multi-page EADD patch. Great I'll compose the patch set duri

[PATCH v6 06/17] arm64: hibernate: rename dst to page in create_safe_exec_page

2019-10-04 Thread Pavel Tatashin
create_safe_exec_page() allocates a safe page and maps it at a specific location, also this function returns the physical address of newly allocated page. The destination VA, and PA are specified in arguments: dst_addr, phys_dst_addr However, within the function it uses "dst" which has unsigned l

[PATCH v6 14/17] arm64: kexec: move relocation function setup and clean up

2019-10-04 Thread Pavel Tatashin
Currently, kernel relocation function is configured in machine_kexec() at the time of kexec reboot by using control_code_page. This operation, however, is more logical to be done during kexec_load, and thus remove from reboot time. Move, setup of this function to newly added machine_kexec_post_loa

[PATCH] rtc: snvs: fix uninitialized usage of "lpcr" in snvs_rtc_enable()

2019-10-04 Thread Yizhuo
Inside function snvs_rtc_enable(), variable "lpcr" could be uninitialized if regmap_read() returns -EINVAL. However,"lpcr" is used later in the if statement, which is potentially unsafe. Similar cases happened in function snvs_rtc_irq_handler() with variable "lpsr" and function snvs_rtc_read_alarm

Re: [PATCH v22 16/24] x86/vdso: Add support for exception fixup in vDSO functions

2019-10-04 Thread Jarkko Sakkinen
On Thu, Oct 03, 2019 at 05:03:48PM -0700, Sean Christopherson wrote: > On Thu, Oct 03, 2019 at 02:18:04AM +0300, Jarkko Sakkinen wrote: > > Also there is two space bars after *every* sentence. Your text editor is > > totally broken somehow. > > I completely misunderstood your earlier comment, I th

[PATCH v2] remoteproc: Add elf64 support in elf loader

2019-10-04 Thread Clement Leger
elf32 and elf64 mainly differ by their types. In order to avoid copy/pasting the whole loader code, generate static inline functions which will access values according to the elf class. It allows to keep a common loader basis. In order to accomodate both elf types sizes, the maximum size for a elf

Re: [PATCH] mtd: rawnand: au1550nd: Fix au_read_buf16() prototype

2019-10-04 Thread Boris Brezillon
On Fri, 4 Oct 2019 18:38:33 + Paul Burton wrote: > Commit 7e534323c416 ("mtd: rawnand: Pass a nand_chip object to > chip->read_xxx() hooks") modified the prototype of the struct nand_chip > read_buf function pointer. In the au1550nd driver we have 2 > implementations of read_buf. The previous

[PATCH v2] mtd: rawnand: au1550nd: Fix au_read_buf16() prototype

2019-10-04 Thread Paul Burton
Commit 7e534323c416 ("mtd: rawnand: Pass a nand_chip object to chip->read_xxx() hooks") modified the prototype of the struct nand_chip read_buf function pointer. In the au1550nd driver we have 2 implementations of read_buf. The previously mentioned commit modified the au_read_buf() implementation t

[PATCH] mtd: rawnand: au1550nd: Fix au_read_buf16() prototype

2019-10-04 Thread Paul Burton
Commit 7e534323c416 ("mtd: rawnand: Pass a nand_chip object to chip->read_xxx() hooks") modified the prototype of the struct nand_chip read_buf function pointer. In the au1550nd driver we have 2 implementations of read_buf. The previously mentioned commit modified the au_read_buf() implementation t

Re: Kernel Concurrency Sanitizer (KCSAN)

2019-10-04 Thread Dmitry Vyukov
" On Fri, Oct 4, 2019 at 8:08 PM Joel Fernandes wrote: > > > > > > > > Hi all, > > > > > > > > > > > > > > > > We would like to share a new data-race detector for the Linux > > > > > > > > kernel: > > > > > > > > Kernel Concurrency Sanitizer (KCSAN) -- > > > > > > > > https://github.com/google/kt

Re: [PATCH 3/4] riscv: Correct the handling of unexpected ebreak in do_trap_break()

2019-10-04 Thread Paul Walmsley
On Mon, 23 Sep 2019, Vincent Chen wrote: > For the kernel space, all ebreak instructions are determined at compile > time because the kernel space debugging module is currently unsupported. > Hence, it should be treated as a bug if an ebreak instruction which does > not belong to BUG_TRAP_TYPE_WAR

Re: [PATCH 2/4] rsicv: avoid sending a SIGTRAP to a user thread trapped in WARN()

2019-10-04 Thread Paul Walmsley
On Mon, 23 Sep 2019, Vincent Chen wrote: > On RISC-V, when the kernel runs code on behalf of a user thread, and the > kernel executes a WARN() or WARN_ON(), the user thread will be sent > a bogus SIGTRAP. Fix the RISC-V kernel code to not send a SIGTRAP when > a WARN()/WARN_ON() is executed. > >

Re: [PATCH] depmod: create and use System.map.no_namespaces

2019-10-04 Thread Lucas De Marchi
On Fri, Oct 4, 2019 at 2:57 AM Matthias Maennich wrote: > > depmod in its current version is not aware of symbol namespace in > ksymtab entries introduced with 8651ec01daed ("module: add support for > symbol namespaces."). They have the form > > __ksymtab_NAMESPACE.symbol_name > > A fix for kmod

Re: [PATCH 1/4] riscv: avoid kernel hangs when trapped in BUG()

2019-10-04 Thread Paul Walmsley
On Mon, 23 Sep 2019, Vincent Chen wrote: > When the CONFIG_GENERIC_BUG is disabled by disabling CONFIG_BUG, if a > kernel thread is trapped by BUG(), the whole system will be in the > loop that infinitely handles the ebreak exception instead of entering the > die function. To fix this problem, the

Re: [GIT PULL] process fixes for v5.4-rc2

2019-10-04 Thread pr-tracker-bot
The pull request you sent on Fri, 4 Oct 2019 11:39:47 +0200: > g...@gitolite.kernel.org:pub/scm/linux/kernel/git/brauner/linux > tags/for-linus-20191003 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/af0622f6ae416f9ac340d6d632be9879805c294a Thank you! -- Deet-doot

Re: [GIT PULL] xen: fixes and cleanups for 5.4-rc2

2019-10-04 Thread pr-tracker-bot
The pull request you sent on Fri, 4 Oct 2019 07:05:20 +0200: > git://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git > for-linus-5.4-rc2-tag has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/50dfd03d9579cde9150679e90f8f244c626b7a09 Thank you! -- Deet-doot-dot, I

Re: [GIT PULL] usercopy structs for v5.4-rc2

2019-10-04 Thread pr-tracker-bot
The pull request you sent on Fri, 4 Oct 2019 12:41:16 +0200: > g...@gitolite.kernel.org:pub/scm/linux/kernel/git/brauner/linux > tags/copy-struct-from-user-v5.4-rc2 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/e524d16e7e324039f2a9f82e302f0a39ac7d5812 Thank you! -

Re: [GIT PULL] KVM fixes for Linux 5.4-rc2

2019-10-04 Thread pr-tracker-bot
The pull request you sent on Fri, 4 Oct 2019 14:03:52 +0200: > https://git.kernel.org/pub/scm/virt/kvm/kvm.git tags/for-linus has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/b145b0eb2031a620ca010174240963e4d2c6ce26 Thank you! -- Deet-doot-dot, I am a bot. https://ko

Re: [PATCH v3 2/2] tpm: Detach page allocation from tpm_buf

2019-10-04 Thread Jerry Snitselaar
On Fri Oct 04 19, James Bottomley wrote: On Fri, 2019-10-04 at 13:37 -0400, Mimi Zohar wrote: On Fri, 2019-10-04 at 09:37 -0700, James Bottomley wrote: > On Thu, 2019-10-03 at 21:51 +0300, Jarkko Sakkinen wrote: > > As has been seen recently, binding the buffer allocation and > > tpm_buf > > tog

[PATCH v9 01/17] x86/ptrace: Prevent ptrace from clearing the FS/GS selector

2019-10-04 Thread Chang S. Bae
When a ptracer writes a ptracee's FS/GS base with a different value, the selector is also cleared. This behavior is not correct as the selector should be preserved. Update only the base value and leave the selector intact. To simplify the code further remove the conditional checking for the same v

[PATCH v9 03/17] x86/cpu: Add 'unsafe_fsgsbase' to enable CR4.FSGSBASE

2019-10-04 Thread Chang S. Bae
From: Andy Lutomirski This is temporary. It will allow the next few patches to be tested incrementally. Setting unsafe_fsgsbase is a root hole. Don't do it. Signed-off-by: Andy Lutomirski Signed-off-by: Chang S. Bae Reviewed-by: Tony Luck Cc: Thomas Gleixner Cc: Borislav Petkov Cc: Andy

[PATCH v9 02/17] selftests/x86/fsgsbase: Test GS selector on ptracer-induced GS base write

2019-10-04 Thread Chang S. Bae
The test validates that the selector is not changed when a ptracer writes the ptracee's GS base. Originally-by: Andy Lutomirski Signed-off-by: Chang S. Bae Reviewed-by: Tony Luck Cc: Thomas Gleixner Cc: Borislav Petkov Cc: Andy Lutomirski Cc: H. Peter Anvin Cc: Dave Hansen Cc: Tony Luck C

[PATCH v9 00/17] Enable FSGSBASE instructions

2019-10-04 Thread Chang S. Bae
Benefits: Currently a user process that wishes to read or write the FS/GS base must make a system call. But recent X86 processors have added new instructions for use in 64-bit mode that allow direct access to the FS and GS segment base addresses. The operating system controls whether applications

[PATCH v9 05/17] x86/entry/64: Switch CR3 before SWAPGS in paranoid entry

2019-10-04 Thread Chang S. Bae
When FSGSBASE is enabled, the GS base handling in paranoid entry will need to retrieve the kernel GS base which requires that the kernel page table is active. As the CR3 switch to the kernel page tables (PTI is active) does not depend on kernel GS base, move the CR3 switch in front of the GS base

[PATCH v9 10/17] x86/fsgsbase/64: Enable FSGSBASE instructions in helper functions

2019-10-04 Thread Chang S. Bae
Add CPU feature conditional FS/GS base access to the relevant helper functions. That allows accelerating certain FS/GS base operations in subsequent changes. Note, that while possible, the user space entry/exit GS base operations are not going to use the new FSGSBASE instructions. The reason is th

[PATCH v9 06/17] x86/entry/64: Introduce the FIND_PERCPU_BASE macro

2019-10-04 Thread Chang S. Bae
GS base is used to find per-CPU data in the kernel. But when GS base is unknown, the per-CPU base can be found from the per_cpu_offset table with a CPU NR. The CPU NR is extracted from the limit field of the CPUNODE entry in GDT, or by the RDPID instruction. This is a prerequisite for using FSGSBA

[PATCH v9 16/17] x86/elf: Enumerate kernel FSGSBASE capability in AT_HWCAP2

2019-10-04 Thread Chang S. Bae
From: Andi Kleen The kernel needs to explicitly enable FSGSBASE. So, the application needs to know if it can safely use these instructions. Just looking at the CPUID bit is not enough because it may be running in a kernel that does not enable the instructions. One way for the application would b

[PATCH v9 07/17] x86/entry/64: Handle FSGSBASE enabled paranoid entry/exit

2019-10-04 Thread Chang S. Bae
Without FSGSBASE, user space cannot change GS base other than through a PRCTL. The kernel enforces that the user space GS base value is positive as negative values are used for detecting the kernel space GS base value in the paranoid entry code. If FSGSBASE is enabled, user space can set arbitrary

[PATCH v9 08/17] x86/entry/64: Document GSBASE handling in the paranoid path

2019-10-04 Thread Chang S. Bae
On FSGSBASE systems, the way to handle GS base in the paranoid path is different from the existing SWAPGS-based entry/exit path handling. Document the reason and what has to be done for FSGSBASE enabled systems. Signed-off-by: Chang S. Bae Reviewed-by: Tony Luck Cc: Thomas Gleixner Cc: Borislav

[PATCH v9 09/17] x86/fsgsbase/64: Add intrinsics for FSGSBASE instructions

2019-10-04 Thread Chang S. Bae
From: Andi Kleen [ luto: Rename the variables from FS and GS to FSBASE and GSBASE and make safe to include on 32-bit kernels. ] Signed-off-by: Andi Kleen Signed-off-by: Andy Lutomirski Signed-off-by: Chang S. Bae Signed-off-by: Thomas Gleixner Reviewed-by: Andy Lutomirski Reviewed-by: An

[PATCH v9 12/17] x86/fsgsbase/64: Use FSGSBASE instructions on thread copy and ptrace

2019-10-04 Thread Chang S. Bae
When FSGSBASE is enabled, copying threads and reading FS/GS base using ptrace must read the actual values. When copying a thread, use fsgs_save() and copy the saved values. For ptrace, the bases must be read from memory regardless of the selector if FSGSBASE is enabled. Suggested-by: Andy Lutomir

[PATCH v9 17/17] Documentation/x86/64: Add documentation for GS/FS addressing mode

2019-10-04 Thread Chang S. Bae
From: Thomas Gleixner Explain how the GS/FS based addressing can be utilized in user space applications along with the differences between the generic prctl() based GS/FS base control and the FSGSBASE version available on newer CPUs. Originally-by: Andi Kleen Signed-off-by: Thomas Gleixner Sig

[PATCH v9 15/17] x86/fsgsbase/64: Enable FSGSBASE on 64bit by default and add a chicken bit

2019-10-04 Thread Chang S. Bae
From: Andy Lutomirski Now that FSGSBASE is fully supported, remove unsafe_fsgsbase, enable FSGSBASE by default, and add nofsgsbase to disable it. Signed-off-by: Andy Lutomirski Signed-off-by: Chang S. Bae Reviewed-by: Tony Luck Cc: Thomas Gleixner Cc: Borislav Petkov Cc: Andy Lutomirski Cc

[PATCH v9 14/17] selftests/x86/fsgsbase: Test ptracer-induced GS base write with FSGSBASE

2019-10-04 Thread Chang S. Bae
This validates that GS selector and base are independently preserved in ptrace commands. Suggested-by: Andy Lutomirski Signed-off-by: Chang S. Bae Reviewed-by: Tony Luck Cc: Thomas Gleixner Cc: Borislav Petkov Cc: Andy Lutomirski Cc: H. Peter Anvin Cc: Dave Hansen Cc: Tony Luck Cc: Andi K

Re: [PATCH v2] cxgb4: do not dma memory off of the stack

2019-10-04 Thread Jason Gunthorpe
On Tue, Oct 01, 2019 at 06:56:11PM +0200, Greg KH wrote: > Nicolas pointed out that the cxgb4 driver is doing dma off of the stack, > which is generally considered a very bad thing. On some architectures > it could be a security problem, but odds are none of them actually run > this driver, so it'

[PATCH v9 11/17] x86/fsgsbase/64: Use FSGSBASE in switch_to() if available

2019-10-04 Thread Chang S. Bae
From: Andy Lutomirski With the new FSGSBASE instructions, FS/GS base can be efficiently read and written in __switch_to(). Use that capability to preserve the full state. This will enable user code to do whatever it wants with the new instructions without any kernel-induced gotchas. (There can

[PATCH v9 04/17] x86/entry/64: Clean up paranoid exit

2019-10-04 Thread Chang S. Bae
From: Andy Lutomirski All that paranoid exit needs to do is to disable IRQs, handle IRQ tracing, then restore CR3, and restore GS base. Simply do those actions in that order. Cleaning up the spaghetti code. Signed-off-by: Andy Lutomirski Signed-off-by: Chang S. Bae Reviewed-by: Tony Luck Cc:

[PATCH v9 13/17] x86/speculation/swapgs: Check FSGSBASE in enabling SWAPGS mitigation

2019-10-04 Thread Chang S. Bae
From: Tony Luck Before enabling FSGSBASE the kernel could safely assume that the content of GS base was a user address. Thus any speculative access as the result of a mispredicted branch controlling the execution of SWAPGS would be to a user address. So systems with speculation-proof SMAP did not

Re: [PATCH v2] kheaders: making headers archive reproducible

2019-10-04 Thread Joel Fernandes
On Fri, Oct 04, 2019 at 10:40:07AM +, Dmitry Goldin wrote: > From: Dmitry Goldin > > In commit 43d8ce9d65a5 ("Provide in-kernel headers to make > extending kernel easier") a new mechanism was introduced, for kernels > >=5.2, which embeds the kernel headers in the kernel image or a module > an

Re: [RFC PATCH] interconnect: Replace of_icc_get() with icc_get() and reduce DT binding

2019-10-04 Thread Stephen Boyd
Quoting David Dai (2019-09-27 10:16:07) > > On 9/25/2019 6:28 AM, Stephen Boyd wrote: > > Quoting Bjorn Andersson (2019-09-24 22:59:33) > >> On Tue 24 Sep 22:41 PDT 2019, Stephen Boyd wrote: > >> > >>> The DT binding could also be simplified somewhat. Currently a path needs > >>> to be specified i

Re: [PATCH v3 2/5] dt-bindings: mfd: Document the Xylon LogiCVC multi-function device

2019-10-04 Thread Paul Kocialkowski
Hi, On Fri 04 Oct 19, 11:09, Rob Herring wrote: > On Fri, Oct 4, 2019 at 9:45 AM Lee Jones wrote: > > > > On Fri, 27 Sep 2019, Rob Herring wrote: > > > > > On Fri, Sep 27, 2019 at 12:04:04PM +0200, Paul Kocialkowski wrote: > > > > The LogiCVC is a display engine which also exposes GPIO functional

Re: [PATCH v2] RDMA: release allocated skb

2019-10-04 Thread Navid Emamdoost
Hi Leon and Potnuri, Based on the following call sequence, skb is passed along to uld_send(). c4iw_ref_send_wait c4iw_ofld_send cxgb4_ofld_send t4_ofld_send uld_send In uld_send() skb is consumed (released or added to

[PATCH] blk-wbt: fix performance regression in wbt scale_up/scale_down

2019-10-04 Thread Harshad Shirwadkar
scale_up wakes up waiters after scaling up. But after scaling max, it should not wake up more waiters as waiters will not have anything to do. This patch fixes this by making scale_up (and also scale_down) return when threshold is reached. This bug causes increased fdatasync latency when fdatasync

Re: Kernel Concurrency Sanitizer (KCSAN)

2019-10-04 Thread Joel Fernandes
On Fri, Oct 04, 2019 at 07:01:37PM +0200, Dmitry Vyukov wrote: > On Fri, Oct 4, 2019 at 6:57 PM Joel Fernandes wrote: > > > > On Fri, Oct 04, 2019 at 06:52:49PM +0200, Dmitry Vyukov wrote: > > > On Fri, Oct 4, 2019 at 6:49 PM Joel Fernandes > > > wrote: > > > > > > > > On Wed, Oct 02, 2019 at 09

Re: [rfc] mm, hugetlb: allow hugepage allocations to excessively reclaim

2019-10-04 Thread David Rientjes
On Fri, 4 Oct 2019, Michal Hocko wrote: > Requesting the userspace to drop _all_ page cache in order allocate a > number of hugetlb pages or any other affected __GFP_RETRY_MAYFAIL > requests is simply not reasonable IMHO. It can be used as a fallback when writing to nr_hugepages and the amount a

Re: [PATCH] RDMA/core: Fix an error handling path in 'res_get_common_doit()'

2019-10-04 Thread Jason Gunthorpe
On Sun, Aug 18, 2019 at 11:10:44AM +0200, Christophe JAILLET wrote: > According to surrounding error paths, it is likely that 'goto err_get;' is > expected here. Otherwise, a call to 'rdma_restrack_put(res);' would be > missing. > > Fixes: c5dfe0ea6ffa ("RDMA/nldev: Add resource tracker doit callb

Re: [GIT PULL] usercopy structs for v5.4-rc2

2019-10-04 Thread Linus Torvalds
On Fri, Oct 4, 2019 at 3:42 AM Christian Brauner wrote: > >The only separate fix we we had to apply > was for a warning by clang when building the tests for using the result of > an assignment as a condition without parantheses. Hmm. That code is ugly, both before and after the fix.

Applied "regulator: qcom-rpmh: Fix PMIC5 BoB min voltage" to the regulator tree

2019-10-04 Thread Mark Brown
The patch regulator: qcom-rpmh: Fix PMIC5 BoB min voltage has been applied to the regulator tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-5.4 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24

Re: [PATCH v2 03/11] dt-bindings: crypto: Add DT bindings documentation for sun8i-ce Crypto Engine

2019-10-04 Thread Corentin Labbe
On Wed, Oct 02, 2019 at 07:54:58AM +0200, Maxime Ripard wrote: > On Tue, Oct 01, 2019 at 08:41:33PM +0200, Corentin Labbe wrote: > > This patch adds documentation for Device-Tree bindings for the > > Crypto Engine cryptographic accelerator driver. > > > > Signed-off-by: Corentin Labbe > > --- > >

Applied "regulator: qcom-rpmh: add PM6150/PM6150L regulator support" to the regulator tree

2019-10-04 Thread Mark Brown
The patch regulator: qcom-rpmh: add PM6150/PM6150L regulator support has been applied to the regulator tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-5.5 All being well this means that it will be integrated into the linux-next tree (usually sometime in t

<    1   2   3   4   5   6   7   8   9   >