Re: [PATCH] mm/page_alloc: Add a reason for reserved pages in has_unmovable_pages()

2019-10-04 Thread Michal Hocko
On Fri 04-10-19 09:56:00, Qian Cai wrote: > On Fri, 2019-10-04 at 15:38 +0200, Michal Hocko wrote: > > On Fri 04-10-19 09:30:39, Qian Cai wrote: > > > On Fri, 2019-10-04 at 15:07 +0200, Michal Hocko wrote: > > > > On Fri 04-10-19 08:56:16, Qian Cai wrote: > > > > [...] > > > > > It might be a good

Re: [PATCH 2/6] net: can: xilinx_can: Fix flags field initialization for axi can and canps

2019-10-04 Thread Anssi Hannula
On 18.3.2019 13.32, Appana Durga Kedareswara rao wrote: > AXI CAN IP and CANPS IP supports tx fifo empty feature, this patch updates > the flags field for the same. > > Signed-off-by: Appana Durga Kedareswara rao > --- > drivers/net/can/xilinx_can.c | 2 ++ > 1 file changed, 2 insertions(+) > > d

Re: KASAN: use-after-free Read in rxrpc_release_call

2019-10-04 Thread David Howells
Hillf Danton wrote: > if (conn) { > - rxrpc_disconnect_call(call); > conn->security->free_call_crypto(call); > + rxrpc_disconnect_call(call); > } Better to cache the security pointer in the call struct, I think. David

Re: [PATCH] x86/mm: determine whether the fault address is canonical

2019-10-04 Thread Dave Hansen
On 10/4/19 6:45 AM, Changbin Du wrote: > +static inline bool is_canonical_addr(u64 addr) > +{ > +#ifdef CONFIG_X86_64 > + int shift = 64 - boot_cpu_data.x86_phys_bits; I think you mean to check the virtual bits member, not "phys_bits". BTW, I also prefer the IS_ENABLED(CONFIG_) checks to expl

Re: [PATCH v7 5/5] backlight: add led-backlight driver

2019-10-04 Thread Lee Jones
On Wed, 18 Sep 2019, Jean-Jacques Hiblot wrote: > From: Tomi Valkeinen > > This patch adds a led-backlight driver (led_bl), which is similar to > pwm_bl except the driver uses a LED class driver to adjust the > brightness in the HW. Multiple LEDs can be used for a single backlight. > > Signed-o

Re: [PATCH 0/4] HiSilicon hip08 uncore PMU events additions

2019-10-04 Thread Arnaldo Carvalho de Melo
Em Fri, Oct 04, 2019 at 11:36:58AM -0300, Arnaldo Carvalho de Melo escreveu: > Em Fri, Oct 04, 2019 at 03:30:07PM +0100, John Garry escreveu: > > On 04/09/2019 16:54, John Garry wrote: > > > This patchset adds some missing uncore PMU events for the hip08 arm64 > > > platform. > > > > > > The missi

Re: [PATCH v3 0/5] livepatch: new API to track system state changes

2019-10-04 Thread Joe Lawrence
On Thu, Oct 03, 2019 at 11:01:32AM +0200, Petr Mladek wrote: > Hi, > > this is another piece in the puzzle that helps to maintain more > livepatches. > > Especially pre/post (un)patch callbacks might change a system state. > Any newly installed livepatch has to somehow deal with system state > mo

Re: [PATCH 0/4] HiSilicon hip08 uncore PMU events additions

2019-10-04 Thread Arnaldo Carvalho de Melo
Em Fri, Oct 04, 2019 at 03:30:07PM +0100, John Garry escreveu: > On 04/09/2019 16:54, John Garry wrote: > > This patchset adds some missing uncore PMU events for the hip08 arm64 > > platform. > > > > The missing events were originally mentioned in > > https://lkml.org/lkml/2019/6/14/645, when upst

Re: [PATCH] mfd: max77620: Do not allocate IRQs upfront

2019-10-04 Thread Lee Jones
On Wed, 02 Oct 2019, Thierry Reding wrote: > From: Thierry Reding > > regmap_add_irq_chip() will try to allocate all of the IRQ descriptors > upfront if passed a non-zero irq_base parameter. However, the intention > is to allocate IRQ descriptors on an as-needed basis if possible. Pass 0 > inste

Re: [v1] e1000e: EEH on e1000e adapter detects io perm failure can trigger crash

2019-10-04 Thread Alexander Duyck
On Thu, Oct 3, 2019 at 5:02 PM David Z. Dai wrote: > > On Thu, 2019-10-03 at 13:39 -0700, Alexander Duyck wrote: > > On Thu, Oct 3, 2019 at 11:51 AM David Z. Dai > > wrote: > > > > > > On Thu, 2019-10-03 at 10:39 -0700, Alexander Duyck wrote: > > > > On Thu, Oct 3, 2019 at 9:59 AM David Dai >

Re: [PATCH v3 3/3] mfd: madera: Add support for requesting the supply clocks

2019-10-04 Thread Lee Jones
On Tue, 01 Oct 2019, Charles Keepax wrote: > Add the ability to get the clock for each clock input pin of the chip > and enable MCLK2 since that is expected to be a permanently enabled > 32kHz clock. > > Signed-off-by: Charles Keepax > --- > > Changes since v2: > - Use new devm_clk_bulk_get_op

Re: [PATCH] devpts: Fix NULL pointer dereference in dcache_readdir()

2019-10-04 Thread Christian Brauner
On Fri, Oct 04, 2019 at 03:27:48PM +0100, Al Viro wrote: > On Fri, Oct 04, 2019 at 04:05:03PM +0200, Christian Brauner wrote: > > From: Will Deacon > > > > Closing /dev/pts/ptmx removes the corresponding pty under /dev/pts/ > > without synchronizing against concurrent path walkers. This can lead

Re: [PATCH 0/4] HiSilicon hip08 uncore PMU events additions

2019-10-04 Thread John Garry
On 04/09/2019 16:54, John Garry wrote: This patchset adds some missing uncore PMU events for the hip08 arm64 platform. The missing events were originally mentioned in https://lkml.org/lkml/2019/6/14/645, when upstreaming the JSONs initially. It also includes a fix for a DDRC eventname. Hi guy

Re: [PATCH] devpts: Fix NULL pointer dereference in dcache_readdir()

2019-10-04 Thread Al Viro
On Fri, Oct 04, 2019 at 04:05:03PM +0200, Christian Brauner wrote: > From: Will Deacon > > Closing /dev/pts/ptmx removes the corresponding pty under /dev/pts/ > without synchronizing against concurrent path walkers. This can lead to > 'dcache_readdir()' tripping over a 'struct dentry' with a NULL

[PATCH v4] rtc: wilco-ec: Handle reading invalid times

2019-10-04 Thread Nick Crews
If the RTC HW returns an invalid time, the rtc_year_days() call would crash. This patch adds error logging in this situation, and removes the tm_yday and tm_wday calculations. These fields should not be relied upon by userspace according to man rtc, and thus we don't need to calculate them. Signed

RE: [RFC PATCH 17/22] thunderbolt: Add initial support for USB4

2019-10-04 Thread Mario.Limonciello
> -Original Message- > From: Limonciello, Mario > Sent: Friday, October 4, 2019 9:06 AM > To: 'Yehezkel Bernat'; Mika Westerberg > Cc: linux-...@vger.kernel.org; Andreas Noever; Michael Jamet; Rajmohan Mani; > nicholas.johnson-opensou...@outlook.com.au; Lukas Wunner; > gre...@linuxfoundatio

Re: [RFC PATCH 17/22] thunderbolt: Add initial support for USB4

2019-10-04 Thread Mika Westerberg
+Christian On Fri, Oct 04, 2019 at 02:05:46PM +, mario.limoncie...@dell.com wrote: > > > > On Fri, Oct 4, 2019 at 11:19 AM Mika Westerberg > > wrote: > > > > > > On Fri, Oct 04, 2019 at 11:07:34AM +0300, Yehezkel Bernat wrote: > > > > > Also if you can get the hw_vendor_id and hw_product_id

Re: [PATCH v2 3/6] pwm: mxs: add support for inverse polarity

2019-10-04 Thread Uwe Kleine-König
On Fri, Oct 04, 2019 at 03:32:04PM +0200, Rasmus Villemoes wrote: > If I'm reading of_pwm_xlate_with_flags() right, existing device trees > that set #pwm-cells = 2 will continue to work. Yes, that's what I expect, too. > Signed-off-by: Rasmus Villemoes > --- > drivers/pwm/pwm-mxs.c | 14 +++

Re: [PATCH 3/3] arm64: dts: rockchip: fix RockPro64 sdmmc settings【请注意,邮件由linux-rockchip-bounces+shawn.lin=rock-chips....@lists.infradead.org代发】

2019-10-04 Thread Robin Murphy
On 04/10/2019 04:39, Soeren Moch wrote: On 04.10.19 04:13, Shawn Lin wrote: On 2019/10/4 8:53, Soeren Moch wrote: On 04.10.19 02:01, Robin Murphy wrote: On 2019-10-03 10:50 pm, Soeren Moch wrote: According to the RockPro64 schematic [1] the rk3399 sdmmc controller is connected to a microS

Re: [PATCH v2 2/6] pwm: mxs: remove legacy methods

2019-10-04 Thread Uwe Kleine-König
On Fri, Oct 04, 2019 at 03:32:03PM +0200, Rasmus Villemoes wrote: > Since we now have ->apply, these are no longer relevant. > > Signed-off-by: Rasmus Villemoes nice and easy, Reviewed-by: Uwe Kleine-König Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König

Re: [PATCH v2 1/6] pwm: mxs: implement ->apply

2019-10-04 Thread Uwe Kleine-König
Hello, On Fri, Oct 04, 2019 at 03:32:02PM +0200, Rasmus Villemoes wrote: > In preparation for supporting setting the polarity, switch the driver > to support the ->apply method. > > Signed-off-by: Rasmus Villemoes > --- > drivers/pwm/pwm-mxs.c | 70 +++ >

Re: [PATCH] si2157: Add support for Logilink VG0022A.

2019-10-04 Thread Mauro Carvalho Chehab
Em Fri, 4 Oct 2019 15:50:18 +0200 JP escreveu: > On 10/4/19 2:08 PM, Mauro Carvalho Chehab wrote: > > Em Fri, 4 Oct 2019 13:50:43 +0200 > > JP escreveu: > > > >> On 10/3/19 10:03 PM, Mauro Carvalho Chehab wrote: > >>> Em Thu, 3 Oct 2019 21:51:35 +0200 > >>> Gonsolo escreveu: > >>> > >>

Re: [PATCH v2 6/6] pwm: update comment on struct pwm_ops::apply

2019-10-04 Thread Uwe Kleine-König
On Fri, Oct 04, 2019 at 03:32:07PM +0200, Rasmus Villemoes wrote: > Commit 71523d1812ac (pwm: Ensure pwm_apply_state() doesn't modify the > state argument) updated the kernel-doc for pwm_apply_state(), but not > for the ->apply callback in the pwm_ops struct. > > Signed-off-by: Rasmus Villemoes >

Re: [PATCH v2 5/6] pwm: mxs: avoid a division in mxs_pwm_apply()

2019-10-04 Thread Uwe Kleine-König
On Fri, Oct 04, 2019 at 03:32:06PM +0200, Rasmus Villemoes wrote: > Since the divisor is not a compile-time constant (unless gcc somehow > decided to unroll the loop PERIOD_CDIV_MAX times), this does a > somewhat expensive 32/32 division. Replace that with a right shift. > > We still have a 64/32

Re: [PATCH v5 0/3] mfd: mc13xxx: Fixes and enhancements for NXP's mc34708

2019-10-04 Thread Lee Jones
On Tue, 01 Oct 2019, Lukasz Majewski wrote: > > On Mon, 30 Sep 2019, Lukasz Majewski wrote: > > > > > Dear Lee, > > > > > > > This patch set provides several enhancements to mc13xxx MFD family > > > > of devices by introducing mc34708 as a separate device. > > > > > > > > This IC has dedicated

Re: DM3730 Bluetooth Performance differences between SERIAL_8250_OMAP vs SERIAL_OMAP

2019-10-04 Thread Adam Ford
On Fri, Oct 4, 2019 at 7:27 AM Yegor Yefremov wrote: > > Hi Adam, > > On Fri, Oct 4, 2019 at 12:39 PM Adam Ford wrote: > > > > On Fri, Oct 4, 2019 at 5:02 AM Adam Ford wrote: > > > > > > I am running Kernel 5.3.2 trying to troubleshoot some intermittent > > > Bluetooth issues, and I think I have

Re: [PATCH v2] mm/swap: piggyback lru_add_drain_all() calls

2019-10-04 Thread Konstantin Khlebnikov
On 04/10/2019 16.39, Michal Hocko wrote: On Fri 04-10-19 16:32:39, Konstantin Khlebnikov wrote: On 04/10/2019 16.12, Michal Hocko wrote: On Fri 04-10-19 16:09:22, Konstantin Khlebnikov wrote: This is very slow operation. There is no reason to do it again if somebody else already drained all pe

RE: [RFC PATCH 17/22] thunderbolt: Add initial support for USB4

2019-10-04 Thread Mario.Limonciello
> > On Fri, Oct 4, 2019 at 11:19 AM Mika Westerberg > wrote: > > > > On Fri, Oct 04, 2019 at 11:07:34AM +0300, Yehezkel Bernat wrote: > > > > Also if you can get the hw_vendor_id and hw_product_id from the kernel > > > > does that mean you don't need to do the two reads or you still need > > > >

Re: [PATCH] ARM: dts: stm32: add focaltech touchscreen on stm32mp157c-dk2 board

2019-10-04 Thread Alexandre Torgue
Hi yannick On 10/4/19 3:17 PM, Yannick Fertré wrote: Enable focaltech ft6236 touchscreen on STM32MP157C-DK2 board. Signed-off-by: Yannick Fertré --- arch/arm/boot/dts/stm32mp157c-dk2.dts | 13 + 1 file changed, 13 insertions(+) diff --git a/arch/arm/boot/dts/stm32mp157c-dk2.dts

[PATCH] devpts: Fix NULL pointer dereference in dcache_readdir()

2019-10-04 Thread Christian Brauner
From: Will Deacon Closing /dev/pts/ptmx removes the corresponding pty under /dev/pts/ without synchronizing against concurrent path walkers. This can lead to 'dcache_readdir()' tripping over a 'struct dentry' with a NULL 'd_inode' field: | BUG: kernel NULL pointer dereference, address: 000

Re: KASAN: use-after-free Read in rxrpc_put_peer

2019-10-04 Thread syzbot
Hello, syzbot has tested the proposed patch but the reproducer still triggered crash: KASAN: use-after-free Read in rxrpc_release_call == BUG: KASAN: use-after-free in rxrpc_release_call+0x973/0xaa0 net/rxrpc/call_object.c:498

[PATCH v3] io_uring: Fix reversed nonblock flag

2019-10-04 Thread Pavel Begunkov (Silence)
From: Pavel Begunkov io_queue_link_head() accepts @force_nonblock flag, but io_ring_submit() passes something opposite. v2: build error from test robot: Rebase to block-tree v3: simplify with Jens suggestion Reported-by: kbuild test robot Signed-off-by: Pavel Begunkov --- fs/io_uring.c | 2 +

[PATCH v4 3/4] xen: Mark "xen_nopvspin" parameter obsolete

2019-10-04 Thread Zhenzhong Duan
Map "xen_nopvspin" to "nopvspin", fix stale description of "xen_nopvspin" as we use qspinlock now. Signed-off-by: Zhenzhong Duan Cc: Jonathan Corbet Cc: Boris Ostrovsky Cc: Juergen Gross Cc: Stefano Stabellini Cc: Thomas Gleixner Cc: Ingo Molnar Cc: Borislav Petkov Cc: "H. Peter Anvin" --

[PATCH v4 2/4] x86/kvm: Change print code to use pr_*() format

2019-10-04 Thread Zhenzhong Duan
pr_*() is preferred than printk(KERN_* ...), after change all the print in arch/x86/kernel/kvm.c will have "kvm_guest: xxx" style. No functional change. Signed-off-by: Zhenzhong Duan Cc: Paolo Bonzini Cc: Radim Krcmar Cc: Sean Christopherson Cc: Vitaly Kuznetsov Cc: Wanpeng Li Cc: Jim Matts

[PATCH v4 1/4] x86/kvm: Add "nopvspin" parameter to disable PV spinlocks

2019-10-04 Thread Zhenzhong Duan
There are cases where a guest tries to switch spinlocks to bare metal behavior (e.g. by setting "xen_nopvspin" on XEN platform and "hv_nopvspin" on HYPER_V). That feature is missed on KVM, add a new parameter "nopvspin" to disable PV spinlocks for KVM guest. The new 'nopvspin' parameter will also

[PATCH v4 4/4] x86/hyperv: Mark "hv_nopvspin" parameter obsolete

2019-10-04 Thread Zhenzhong Duan
Map "hv_nopvspin" to "nopvspin". Signed-off-by: Zhenzhong Duan Cc: Jonathan Corbet Cc: "K. Y. Srinivasan" Cc: Haiyang Zhang Cc: Stephen Hemminger Cc: Sasha Levin Cc: Thomas Gleixner Cc: Ingo Molnar Cc: Borislav Petkov Cc: "H. Peter Anvin" --- Documentation/admin-guide/kernel-parameters.

[PATCH v4 0/4] Add a unified parameter "nopvspin"

2019-10-04 Thread Zhenzhong Duan
There are cases folks want to disable spinlock optimization for debug/test purpose. Xen and hyperv already have parameters "xen_nopvspin" and "hv_nopvspin" to support that, but kvm doesn't. The first patch adds that feature to KVM guest with "nopvspin". For compatibility reason original parameter

Re: [PATCH v5 1/3] mfd: mc13xxx: Add mc34708 adc support

2019-10-04 Thread Lee Jones
On Mon, 09 Sep 2019, Lukasz Majewski wrote: > From: Sascha Hauer > > The mc34708 has an improved adc. The older variants will always convert > a fixed order of channels. The mc34708 can do up to eight conversions > in arbitrary channel order. Currently this extended feature is not > supported. W

Re: [PATCH v2 00/21] Refine memblock API

2019-10-04 Thread Adam Ford
On Fri, Oct 4, 2019 at 8:23 AM Lucas Stach wrote: > > Am Freitag, den 04.10.2019, 10:27 +0100 schrieb Russell King - ARM > Linux admin: > > On Thu, Oct 03, 2019 at 02:30:10PM +0300, Mike Rapoport wrote: > > > On Thu, Oct 03, 2019 at 09:49:14AM +0100, Russell King - ARM Linux > > > admin wrote: > >

Re: general protection fault in veth_get_stats64

2019-10-04 Thread Willem de Bruijn
On Wed, Oct 2, 2019 at 5:45 PM syzbot wrote: > > Hello, > > syzbot found the following crash on: > > HEAD commit:a32db7e1 Add linux-next specific files for 20191002 > git tree: linux-next > console output: https://syzkaller.appspot.com/x/log.txt?x=175ab7cd60 > kernel config: https:/

Re: [PATCH] mm/page_alloc: Add a reason for reserved pages in has_unmovable_pages()

2019-10-04 Thread Qian Cai
On Fri, 2019-10-04 at 15:38 +0200, Michal Hocko wrote: > On Fri 04-10-19 09:30:39, Qian Cai wrote: > > On Fri, 2019-10-04 at 15:07 +0200, Michal Hocko wrote: > > > On Fri 04-10-19 08:56:16, Qian Cai wrote: > > > [...] > > > > It might be a good time to rethink if it is really a good idea to > > >

Re: [PATCH] kasan: fix the missing underflow in memmove and memcpy with CONFIG_KASAN_GENERIC=y

2019-10-04 Thread Dmitry Vyukov
On Fri, Oct 4, 2019 at 2:05 PM Walter Wu wrote: > > On Fri, 2019-10-04 at 11:54 +0200, Dmitry Vyukov wrote: > > > > "out-of-bounds" is the _least_ frequent KASAN bug type. So saying > > > > "out-of-bounds" has downsides of both approaches and won't prevent > > > > duplicate reports by syzbot... >

Re: [PATCH 1/6] dt-bindings: mfd: max77650: convert the binding document to yaml

2019-10-04 Thread Lee Jones
On Mon, 30 Sep 2019, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > Convert the binding document for max77650 core mfd module to yaml. MAX77650, MFD, YAML. > Signed-off-by: Bartosz Golaszewski > --- > .../devicetree/bindings/mfd/max77650.txt | 47 +-- > .../devicetre

[PATCH] tty: serial: Fix PORT_LINFLEXUART definition

2019-10-04 Thread Stefan-gabriel Mirea
The port type macros should have different values for different devices. Currently, PORT_LINFLEXUART conflicts with PORT_SUNIX. Fixes: 09864c1cdf5c ("tty: serial: Add linflexuart driver for S32V234") Signed-off-by: Stefan-Gabriel Mirea --- include/uapi/linux/serial_core.h | 2 +- 1 file changed,

Re: [PATCH] si2157: Add support for Logilink VG0022A.

2019-10-04 Thread JP
On 10/4/19 2:08 PM, Mauro Carvalho Chehab wrote: Em Fri, 4 Oct 2019 13:50:43 +0200 JP escreveu: On 10/3/19 10:03 PM, Mauro Carvalho Chehab wrote: Em Thu, 3 Oct 2019 21:51:35 +0200 Gonsolo escreveu: 1) The firmware file is likely at the Windows driver for this device (probably using a

Re: [PATCH] panic: Ensure preemption is disabled during panic()

2019-10-04 Thread Feng Tang
On Fri, Oct 04, 2019 at 01:15:21PM +0200, Petr Mladek wrote: > On Fri 2019-10-04 11:49:48, Will Deacon wrote: > > On Fri, Oct 04, 2019 at 10:29:17AM +0100, Russell King - ARM Linux admin > > wrote: > > > On Fri, Oct 04, 2019 at 11:11:42AM +0200, Petr Mladek wrote: > > > > On Thu 2019-10-03 21:56:3

Re: [PATCH] rsi: fix potential null dereference in rsi_probe()

2019-10-04 Thread Kalle Valo
Denis Efremov wrote: > The id pointer can be NULL in rsi_probe(). It is checked everywhere except > for the else branch in the idProduct condition. The patch adds NULL check > before the id dereference in the rsi_dbg() call. > > Fixes: 54fdb318c111 ("rsi: add new device model for 9116") > Cc: Am

Re: [PATCH 4.19 090/211] media: mceusb: fix (eliminate) TX IR signal length limit

2019-10-04 Thread Sasha Levin
On Fri, Oct 04, 2019 at 12:12:15PM +0200, Pavel Machek wrote: On Thu 2019-10-03 17:52:36, Greg Kroah-Hartman wrote: From: A Sun Other changes: The driver's write to USB device architecture change (async to sync I/O) is significant so we bump DRIVER_VERSION to "1.95" (from "1.94"). --- d

Memo from Orthopaedic Surgeon at Singapore General Hospital for Early Onset of Osteoarthritis

2019-10-04 Thread Turritopsis Dohrnii Teo En Ming
Subject: Memo from Orthopaedic Surgeon at Singapore General Hospital for Early Onset of Osteoarthritis Singapore General Hospital SingHealth 2 October 2019 Dear Sir/Madam TURRITOPSIS DOHRNII TEO EN MING -ZHANG ENMING , To Whom It May Concern, This gent has early osteoarthritis. He cannot st

Re: [PATCH v3 0/2] tcpm: AMS and Collision Avoidance

2019-10-04 Thread Kyle Tso
Hi Hans, It seems that there is a bug in the patch. Thank you for catching this! I will revise the patch and upload it again. On Thu, Oct 3, 2019 at 6:38 PM Hans de Goede wrote: > > Hi, > > On 03-10-2019 12:04, Kyle Tso wrote: > > Hi Hans > > > > Could you append the TCPM log? > > I've attac

Re: [RFC PATCH 2/3] perf tools: Add support for "report" for some spe events

2019-10-04 Thread James Clark
Hi Xiaojun, I wanted to ask if you are still working on this? I've noticed that it doesn't apply cleanly to perf/core anymore and I was working on re-basing it. Would you be interested in me posting my progress? I was also interested in decoding the "data source" of events and displaying that

Re: [PATCH] libertas: remove redundant assignment to variable ret

2019-10-04 Thread Kalle Valo
Colin King wrote: > From: Colin Ian King > > The variable ret is being assigned a value that is never read and is > being re-assigned a little later on. The assignment is redundant and hence > can be removed. > > Addresses-Coverity: ("Unused value") > Signed-off-by: Colin Ian King > Reviewed-

[PATCH] kmemleak: Do not corrupt the object_list during clean-up

2019-10-04 Thread Catalin Marinas
In case of an error (e.g. memory pool too small), kmemleak disables itself and cleans up the already allocated metadata objects. However, if this happens early before the RCU callback mechanism is available, put_object() skips call_rcu() and frees the object directly. This is not safe with the RCU

[PATCH] x86/mm: determine whether the fault address is canonical

2019-10-04 Thread Changbin Du
We know the answer, so don't ask the user. Signed-off-by: Changbin Du --- arch/x86/mm/extable.c | 5 - arch/x86/mm/mm_internal.h | 11 +++ 2 files changed, 15 insertions(+), 1 deletion(-) diff --git a/arch/x86/mm/extable.c b/arch/x86/mm/extable.c index 4d75bc656f97..5196e586756

Re: [PATCH] Make SPLIT_RSS_COUNTING configurable

2019-10-04 Thread Daniel Colascione
On Fri, Oct 4, 2019 at 6:26 AM Kirill A. Shutemov wrote: > On Fri, Oct 04, 2019 at 02:33:49PM +0200, Michal Hocko wrote: > > On Wed 02-10-19 19:08:16, Daniel Colascione wrote: > > > On Wed, Oct 2, 2019 at 6:56 PM Qian Cai wrote: > > > > > On Oct 2, 2019, at 4:29 PM, Daniel Colascione > > > > >

Re: [PATCH 1/3] x86/alternatives: Teach text_poke_bp() to emulate instructions

2019-10-04 Thread Masami Hiramatsu
Hi Peter, On Thu, 3 Oct 2019 13:01:06 +0200 Peter Zijlstra wrote: > On Thu, Oct 03, 2019 at 10:27:51AM +0200, Peter Zijlstra wrote: > > On Thu, Oct 03, 2019 at 02:00:50PM +0900, Masami Hiramatsu wrote: > > > > > > This fits almost all text_poke_bp() users, except > > > > arch_unoptimize_kprobe(

[PATCH v2] mmc: sdhci-iproc: fix spurious interrupts on Multiblock reads with bcm2711

2019-10-04 Thread Nicolas Saenz Julienne
The Raspberry Pi 4 SDHCI hardware seems to automatically issue CMD12 after multiblock reads even when ACMD12 is disabled. This triggers spurious interrupts after the data transfer is done with the following message: mmc1: Got data interrupt 0x0002 even though no data operation was in progre

Re: [PATCH 3/3] x86/ftrace: Use text_poke()

2019-10-04 Thread Steven Rostedt
On Fri, 4 Oct 2019 13:22:37 +0200 Peter Zijlstra wrote: > On Thu, Oct 03, 2019 at 06:10:45PM -0400, Steven Rostedt wrote: > > But still, we are going from 120 to 660 IPIs for every CPU. Not saying > > it's a problem, but something that we should note. Someone (those that > > don't like kernel int

Re: KASAN: use-after-free Read in rxrpc_put_peer

2019-10-04 Thread David Howells
#syz test: git://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git cc9604d48fc3b73d9665ae80a2f07dc3fc0574c4

Re: [PATCH 3/3] x86/ftrace: Use text_poke()

2019-10-04 Thread Steven Rostedt
On Fri, 4 Oct 2019 10:10:47 +0200 Daniel Bristot de Oliveira wrote: > [ In addition ] > > Currently, ftrace_rec entries are ordered inside the group of functions, but > "groups of function" are not ordered. So, the current int3 handler does a (*): > > for_each_group_of_functions: > check

Re: [PATCH v2] mm/swap: piggyback lru_add_drain_all() calls

2019-10-04 Thread Michal Hocko
On Fri 04-10-19 16:32:39, Konstantin Khlebnikov wrote: > On 04/10/2019 16.12, Michal Hocko wrote: > > On Fri 04-10-19 16:09:22, Konstantin Khlebnikov wrote: > > > This is very slow operation. There is no reason to do it again if somebody > > > else already drained all per-cpu vectors while we waite

[RFC 2/2] dirvers & fs: add sram driver and sramfs

2019-10-04 Thread Lukasz Luba
Add a driver for managing SRAM device toughether with dedicated file system. It is a work-in-progress patch which combines driver and file system. It was used for experiments and proof-of-concept. It should be split, when I find the proper way to do it. It also contains debugging prints which shoul

[RFC 0/2] SRAMFS a direct mapped SRAM pages into user space

2019-10-04 Thread Lukasz Luba
Hi all, This patch set tries to introduce a direct mapping mechanism of SRAM memory regions directly into user space. This is a draft of some reaserch work which I am going to continue. Since it is my last day in the office I have publish it as a RFC. Benefits of having SRAM memory in the user sp

[RFC 1/2] DT: ARM: exynos: change SRAM device node

2019-10-04 Thread Lukasz Luba
Signed-off-by: Lukasz Luba --- arch/arm/boot/dts/exynos54xx.dtsi | 12 +--- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/arch/arm/boot/dts/exynos54xx.dtsi b/arch/arm/boot/dts/exynos54xx.dtsi index 0b27bebf9528..1e43ad9f2d89 100644 --- a/arch/arm/boot/dts/exynos54xx.dtsi

Re: [PATCH] mm/page_alloc: Add a reason for reserved pages in has_unmovable_pages()

2019-10-04 Thread Michal Hocko
On Fri 04-10-19 09:30:39, Qian Cai wrote: > On Fri, 2019-10-04 at 15:07 +0200, Michal Hocko wrote: > > On Fri 04-10-19 08:56:16, Qian Cai wrote: > > [...] > > > It might be a good time to rethink if it is really a good idea to > > > dump_page() > > > at all inside has_unmovable_pages(). As it is r

[PATCH v2 2/6] pwm: mxs: remove legacy methods

2019-10-04 Thread Rasmus Villemoes
Since we now have ->apply, these are no longer relevant. Signed-off-by: Rasmus Villemoes --- drivers/pwm/pwm-mxs.c | 77 --- 1 file changed, 77 deletions(-) diff --git a/drivers/pwm/pwm-mxs.c b/drivers/pwm/pwm-mxs.c index 10efd3de0bb3..5a6835e18fc6 100644

Re: [PATCH v3] mfd: mt6360: add pmic mt6360 driver

2019-10-04 Thread Lee Jones
Wolfram, Would you be kind enough to grep for your name below? On Tue, 24 Sep 2019, Gene Chen wrote: > From: Gene Chen > > Add mfd driver for mt6360 pmic chip include > Battery Charger/USB_PD/Flash LED/RGB LED/LDO/Buck > > Signed-off-by: Gene Chen --- > drivers/mfd/Kconfig|

[PATCH v2 4/6] dt-bindings: pwm: mxs-pwm: Increase #pwm-cells

2019-10-04 Thread Rasmus Villemoes
We need to increase the pwm-cells for the optional flags parameter, in order to implement support for polarity setting via DT. Acked-by: Rob Herring Signed-off-by: Rasmus Villemoes --- Documentation/devicetree/bindings/pwm/mxs-pwm.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) d

[PATCH v2 6/6] pwm: update comment on struct pwm_ops::apply

2019-10-04 Thread Rasmus Villemoes
Commit 71523d1812ac (pwm: Ensure pwm_apply_state() doesn't modify the state argument) updated the kernel-doc for pwm_apply_state(), but not for the ->apply callback in the pwm_ops struct. Signed-off-by: Rasmus Villemoes --- include/linux/pwm.h | 5 + 1 file changed, 1 insertion(+), 4 deletio

[PATCH v2 5/6] pwm: mxs: avoid a division in mxs_pwm_apply()

2019-10-04 Thread Rasmus Villemoes
Since the divisor is not a compile-time constant (unless gcc somehow decided to unroll the loop PERIOD_CDIV_MAX times), this does a somewhat expensive 32/32 division. Replace that with a right shift. We still have a 64/32 division just below, but at least in that case the divisor is compile-time c

[PATCH v2 0/6] pwm: mxs: add support for setting polarity via DT

2019-10-04 Thread Rasmus Villemoes
This series adds support for setting the polarity via DT to the pwm-mxs driver. The DT binding is updated, but I'm not touching the existing .dts or .dtsi files - it seems that the same was done for bcm2835 in commits 46421d9d8e802e570dfa4d793a4938d2642ec7a7 and 8a88b2a2017d1e7e80db53080baff591fd4

[PATCH v2 1/6] pwm: mxs: implement ->apply

2019-10-04 Thread Rasmus Villemoes
In preparation for supporting setting the polarity, switch the driver to support the ->apply method. Signed-off-by: Rasmus Villemoes --- drivers/pwm/pwm-mxs.c | 70 +++ 1 file changed, 70 insertions(+) diff --git a/drivers/pwm/pwm-mxs.c b/drivers/pwm/pwm-

[PATCH v2 3/6] pwm: mxs: add support for inverse polarity

2019-10-04 Thread Rasmus Villemoes
If I'm reading of_pwm_xlate_with_flags() right, existing device trees that set #pwm-cells = 2 will continue to work. Signed-off-by: Rasmus Villemoes --- drivers/pwm/pwm-mxs.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/drivers/pwm/pwm-mxs.c b/drivers/pwm/p

Re: [PATCH v2] mm/swap: piggyback lru_add_drain_all() calls

2019-10-04 Thread Konstantin Khlebnikov
On 04/10/2019 16.12, Michal Hocko wrote: On Fri 04-10-19 16:09:22, Konstantin Khlebnikov wrote: This is very slow operation. There is no reason to do it again if somebody else already drained all per-cpu vectors while we waited for lock. Piggyback on drain started and finished while we waited f

Re: System hangs if NVMe/SSD is removed during suspend

2019-10-04 Thread Jens Axboe
On 10/4/19 5:01 AM, Mika Westerberg wrote: > On Fri, Oct 04, 2019 at 11:59:26AM +0200, Rafael J. Wysocki wrote: >> On Friday, October 4, 2019 10:03:40 AM CEST Mika Westerberg wrote: >>> On Thu, Oct 03, 2019 at 09:50:33AM -0700, Tejun Heo wrote: Hello, Mika. On Wed, Oct 02, 2019 at 03

Re: [PATCH] mm/page_alloc: Add a reason for reserved pages in has_unmovable_pages()

2019-10-04 Thread Qian Cai
On Fri, 2019-10-04 at 15:07 +0200, Michal Hocko wrote: > On Fri 04-10-19 08:56:16, Qian Cai wrote: > [...] > > It might be a good time to rethink if it is really a good idea to > > dump_page() > > at all inside has_unmovable_pages(). As it is right now, it is a a potential > > deadlock between con

Re: [PATCH] Make SPLIT_RSS_COUNTING configurable

2019-10-04 Thread Kirill A. Shutemov
On Fri, Oct 04, 2019 at 02:33:49PM +0200, Michal Hocko wrote: > On Wed 02-10-19 19:08:16, Daniel Colascione wrote: > > On Wed, Oct 2, 2019 at 6:56 PM Qian Cai wrote: > > > > On Oct 2, 2019, at 4:29 PM, Daniel Colascione wrote: > > > > > > > > Adding the correct linux-mm address. > > > > > > > > >

Re: [PATCH v3 2/7] mm: Add a walk_page_mapping() function to the pagewalk code

2019-10-04 Thread Kirill A. Shutemov
On Fri, Oct 04, 2019 at 02:58:59PM +0200, Thomas Hellström (VMware) wrote: > On 10/4/19 2:37 PM, Kirill A. Shutemov wrote: > > On Thu, Oct 03, 2019 at 01:32:45PM +0200, Thomas Hellström (VMware) wrote: > > > > > + * If @mapping allows faulting of huge pmds and puds, it is > > > > > desirable > >

Re: [PATCH v2 00/21] Refine memblock API

2019-10-04 Thread Lucas Stach
Am Freitag, den 04.10.2019, 10:27 +0100 schrieb Russell King - ARM Linux admin: > On Thu, Oct 03, 2019 at 02:30:10PM +0300, Mike Rapoport wrote: > > On Thu, Oct 03, 2019 at 09:49:14AM +0100, Russell King - ARM Linux > > admin wrote: > > > On Thu, Oct 03, 2019 at 08:34:52AM +0300, Mike Rapoport wrot

Re: [PATCH 1/2] bdi: Do not use freezable workqueue

2019-10-04 Thread Jens Axboe
On 10/4/19 4:00 AM, Mika Westerberg wrote: > A removable block device, such as NVMe or SSD connected over Thunderbolt > can be hot-removed any time including when the system is suspended. When > device is hot-removed during suspend and the system gets resumed, kernel > first resumes devices and the

[GIT PULL] Devicetree fixes for v5.4

2019-10-04 Thread Rob Herring
Hi Linus, Please pull a few DT fixes for 5.4. Rob The following changes since commit 54ecb8f7028c5eb3d740bb82b0f1d90f2df63c5c: Linux 5.4-rc1 (2019-09-30 10:35:40 -0700) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git tags/devicetree-fi

Re: [PATCH] ARM: dts: stm32: add focaltech touchscreen on stm32mp157c-dk2 board

2019-10-04 Thread Yannick FERTRE
Hi Alex, ok, i'll push only the dt patch link to the last version of driver touchscreen on display board MB1407. BR Yannick Fertré On 10/3/19 12:34 PM, Alexandre Torgue wrote: > Hi Yannick > > On 9/30/19 4:45 PM, Yannick Fertré wrote: >> Enable focaltech ft6236 touchscreen on STM32MP157C-DK2

[PATCH] ARM: dts: stm32: add focaltech touchscreen on stm32mp157c-dk2 board

2019-10-04 Thread Yannick Fertré
Enable focaltech ft6236 touchscreen on STM32MP157C-DK2 board. Signed-off-by: Yannick Fertré --- arch/arm/boot/dts/stm32mp157c-dk2.dts | 13 + 1 file changed, 13 insertions(+) diff --git a/arch/arm/boot/dts/stm32mp157c-dk2.dts b/arch/arm/boot/dts/stm32mp157c-dk2.dts index 20ea601..d

Re: [PATCH v4 0/2] drivers: make early_platform code SuperH-specific

2019-10-04 Thread Rich Felker
On Fri, Oct 04, 2019 at 03:00:31PM +0200, Greg Kroah-Hartman wrote: > On Thu, Oct 03, 2019 at 11:29:11AM +0200, Bartosz Golaszewski wrote: > > From: Bartosz Golaszewski > > > > Some time ago I started a discussion about the need for a proper early > > device > > probing mechanism[1]. One that wo

Re: [char-misc for v4.5-rc2 2/2] mei: avoid FW version request on Ibex Peak and earlier

2019-10-04 Thread Greg Kroah-Hartman
On Wed, Oct 02, 2019 at 02:59:58AM +0300, Tomas Winkler wrote: > From: Alexander Usyskin > > The fixed MKHI client on PCH 6 gen platforms > does not support fw version retrieval. > The error is not fatal, but it fills up the kernel logs and > slows down the driver start. > This patch disables req

[PATCH 1/4] media: si2168: use bits instead of bool for flags

2019-10-04 Thread Mauro Carvalho Chehab
Using bool on struct is not recommended, as it wastes lots of space. So, instead, let's use bits. While here, convert the comments to kernel-doc format. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/dvb-frontends/si2168.h | 47 +-- drivers/media/dvb-frontends/s

[PATCH 2/4] media: si2168: add support for not loading a firmware

2019-10-04 Thread Mauro Carvalho Chehab
Some devices (Logilink VG0022A) don't work properly with the standard firmware. Upgrading the firmware makes I2C transfers to fail when talking to the tuner. While we don't have a better alternative, add support to disable the firmware load on such devices. Signed-off-by: Mauro Carvalho Chehab -

[PATCH 4/4] media: af9035: add the formula used for the I2C speed

2019-10-04 Thread Mauro Carvalho Chehab
A very old patch sent to the media ML used to contain the I2C speed formula: https://lore.kernel.org/linux-media/1312539895.2763.33.camel@Jason-Linux/ When the ite9135 code was merged with af9035, the formula was lost. As we might need to slow down the speed for some devices, add the for

[PATCH 3/4] media: af9035: add support for Logilink VG0022A

2019-10-04 Thread Mauro Carvalho Chehab
This it930x-based device has an issue with si2068. When the si2168 firmware that came with the device is replaced by a new one, any I2C data received from the tuner will be replaced by 0xff. Probably, the vendor firmware has some patch specifically designed for this device. So, we can't replace b

Re: [PATCH] sched/fair: scale quota and period without losing quota/period ratio precision

2019-10-04 Thread Phil Auld
On Thu, Oct 03, 2019 at 07:05:56PM -0700 Xuewei Zhang wrote: > +cc neeln...@google.com and hao...@google.com, they helped a lot > for this issue. Sorry I forgot to include them when sending out the patch. > > On Thu, Oct 3, 2019 at 5:55 PM Phil Auld wrote: > > > > Hi, > > > > On Thu, Oct 03, 2019

Re: [PATCH v2] mm/swap: piggyback lru_add_drain_all() calls

2019-10-04 Thread Michal Hocko
On Fri 04-10-19 16:09:22, Konstantin Khlebnikov wrote: > This is very slow operation. There is no reason to do it again if somebody > else already drained all per-cpu vectors while we waited for lock. > > Piggyback on drain started and finished while we waited for lock: > all pages pended at the t

Re: [PATCH] tty/vt: Touch NMI watchdog in vt_console_print

2019-10-04 Thread Greg KH
On Fri, Sep 20, 2019 at 04:57:26PM +0800, Qiujun Huang wrote: > vt_console_print could trigger NMI watchdog in case writing slow: > > [2858736.789664] NMI watchdog: Watchdog detected hard LOCKUP on cpu 23 > ... > [2858736.790194] CPU: 23 PID: 32504 Comm: tensorflow_mode Not tainted > 4.4.131-1.el

Re: [PATCH 1/7] dt-bindings: watchdog: renesas-wdt: Document r8a774b1 support

2019-10-04 Thread Guenter Roeck
On 10/4/19 1:35 AM, Fabrizio Castro wrote: RZ/G2N (a.k.a. R8A774B1) watchdog implementation is compatible with R-Car Gen3, therefore add the relevant documentation. Signed-off-by: Fabrizio Castro Reviewed-by: Guenter Roeck --- Documentation/devicetree/bindings/watchdog/renesas,wdt.txt |

[PATCH v2] mm/swap: piggyback lru_add_drain_all() calls

2019-10-04 Thread Konstantin Khlebnikov
This is very slow operation. There is no reason to do it again if somebody else already drained all per-cpu vectors while we waited for lock. Piggyback on drain started and finished while we waited for lock: all pages pended at the time of our enter were drained from vectors. Callers like POSIX_F

Re: [PATCH v8 0/6] Patch series to support Thunderbolt without any BIOS support

2019-10-04 Thread Bjorn Helgaas
On Thu, Oct 03, 2019 at 03:19:46PM +0300, mika.westerb...@linux.intel.com wrote: > On Fri, Jul 26, 2019 at 12:52:58PM +, Nicholas Johnson wrote: > > Patch series rebased to 5.3-rc1. > > > > If possible, please have a quick read over while I am away (2019-07-27 > > to mid 2019-08-04), so I can

Re: [PATCH] mmc: sdhci-iproc: fix spurious interrupts on Multiblock reads with bcm2711

2019-10-04 Thread Stefan Wahren
Am 04.10.19 um 14:59 schrieb Nicolas Saenz Julienne: > On Fri, 2019-10-04 at 14:52 +0200, Nicolas Saenz Julienne wrote: >> The Raspberry Pi 4 SDHCI hardware seems to automatically issue CMD12 >> after multiblock reads even when ACMD12 is disabled. This triggers >> spurious interrupts after the data

Re: [PATCH] mm/page_alloc: Add a reason for reserved pages in has_unmovable_pages()

2019-10-04 Thread Michal Hocko
On Fri 04-10-19 08:56:16, Qian Cai wrote: [...] > It might be a good time to rethink if it is really a good idea to dump_page() > at all inside has_unmovable_pages(). As it is right now, it is a a potential > deadlock between console vs memory offline. More details are in this thread, > > https://

Re: [PATCH v2 0/2] PCI: Add missing link delays

2019-10-04 Thread Mika Westerberg
On Fri, Oct 04, 2019 at 02:57:21PM +0200, Matthias Andree wrote: > Am 04.10.19 um 14:39 schrieb Mika Westerberg: > > @Matthias, @Paul and @Nicholas, I appreciate if you could check that this > > does not cause any issues for your systems. > > Just to be sure: is this intended to be applied against

Re: [PATCH] serial: uartps: Fix uartps_major handling

2019-10-04 Thread Michal Simek
On 04. 10. 19 14:52, Greg Kroah-Hartman wrote: > On Fri, Sep 13, 2019 at 09:28:29AM +0200, Michal Simek wrote: >> There are two parts which should be fixed. The first one is to assigned >> uartps_major at the end of probe() to avoid complicated logic when >> something fails. >> The second part is i

[PATCH v2] serial: uartps: Fix uartps_major handling

2019-10-04 Thread Michal Simek
There are two parts which should be fixed. The first one is to assigned uartps_major at the end of probe() to avoid complicated logic when something fails. The second part is initialized uartps_major number to 0 when last device is removed. This will ensure that on next probe driver will ask for ne

<    1   2   3   4   5   6   7   8   9   >