Re: [PATCH v4 06/12] PCI: aardvark: Add FIXME comment for PCIE_CORE_CMD_STATUS_REG access

2020-05-07 Thread Rob Herring
On Thu, 30 Apr 2020 10:06:19 +0200, =?UTF-8?q?Pali=20Roh=C3=A1r?= wrote: > This register is applicable only when the controller is configured for > Endpoint mode, which is not the case for the current version of this > driver. > > Attempting to remove this code though caused some ath10k cards to

Re: [PATCH v4 05/12] PCI: aardvark: Issue PERST via GPIO

2020-05-07 Thread Rob Herring
On Thu, Apr 30, 2020 at 10:22:45AM +0200, Pali Rohár wrote: > On Thursday 30 April 2020 10:06:18 Pali Rohár wrote: > > +static void advk_pcie_issue_perst(struct advk_pcie *pcie) > > +{ > > + u32 reg; > > + > > + if (!pcie->reset_gpio) > > + return; > > + > > + /* PERST does not

Re: [PATCH v2 07/20] mips: Add MIPS Warrior P5600 support

2020-05-07 Thread Serge Semin
On Thu, May 07, 2020 at 01:17:35PM +0200, Thomas Bogendoerfer wrote: > On Wed, May 06, 2020 at 08:42:25PM +0300, sergey.se...@baikalelectronics.ru > wrote: > > > > +config CPU_P5600 > > + bool "MIPS Warrior P5600" > > + depends on SYS_HAS_CPU_P5600 > > + select CPU_HAS_PREFETCH > > +

Re: [PATCH 5/7] mm: move zone iterator outside of deferred_init_maxorder()

2020-05-07 Thread Alexander Duyck
On Thu, May 7, 2020 at 1:20 PM Daniel Jordan wrote: > > On Thu, May 07, 2020 at 08:26:26AM -0700, Alexander Duyck wrote: > > On Wed, May 6, 2020 at 3:39 PM Daniel Jordan > > wrote: > > > On Tue, May 05, 2020 at 08:27:52AM -0700, Alexander Duyck wrote: > > > > > Maybe it's better to leave

Re: [PATCH AUTOSEL 5.4 26/35] SUNRPC: defer slow parts of rpc_free_client() to a workqueue.

2020-05-07 Thread NeilBrown
On Thu, May 07 2020, Sasha Levin wrote: > From: NeilBrown > > [ Upstream commit 7c4310ff56422ea43418305d22bbc5fe19150ec4 ] This one is buggy - it introduces a use-after-free. Best delay it for now. NeilBrown > > The rpciod workqueue is on the write-out path for freeing dirty memory, > so it

Re: [RFC PATCH v3 2/3] docs: scheduler: Add scheduler overview documentation

2020-05-07 Thread Valentin Schneider
On 07/05/20 19:05, John Mathew wrote: > Add documentation for > -scheduler overview > -scheduler state transtion > -CFS overview > -scheduler data structs > > Add rst for scheduler APIs and modify sched/core.c > to add kernel-doc comments. > > Suggested-by: Lukas Bulwahn > Co-developed-by:

Re: [PATCH v5] iommu/arm-smmu-qcom: Request direct mapping for modem device

2020-05-07 Thread Stephen Boyd
Quoting Sibi Sankar (2020-05-07 12:21:57) > The modem remote processor has two modes of access to the DDR, a direct > mode and through a SMMU which requires direct mapping. The configuration > of the modem SIDs is handled in TrustZone. Is it "The configuration of the modem SIDs is typically

Re: [PATCH] mmc: meson-mx-sdio: trigger a soft reset after a timeout or CRC error

2020-05-07 Thread Martin Blumenstingl
Hi Ulf, On Thu, May 7, 2020 at 11:29 AM Ulf Hansson wrote: > > On Mon, 4 May 2020 at 00:28, Martin Blumenstingl > wrote: > > > > The vendor driver (from the 3.10 kernel) triggers a soft reset every > > time before starting a new command. While this fixes a problem where > > SDIO cards are not

Re: [PATCH] media: venus: Replace zero-length array with flexible-array

2020-05-07 Thread Gustavo A. R. Silva
On Thu, May 07, 2020 at 11:39:51PM +0300, Stanimir Varbanov wrote: > Hi Gustavo, > > Two patches from you are already queued in media_tree for v5.8. > Awesome. :) Thanks, Stanimir. -- Gustavo > 0f61e171e4bbac4595175070c75707f1b12f4e37 media: venus: hfi_msgs.h: > Replace zero-length array with

Re: [PATCH v4 04/12] PCI: aardvark: Improve link training

2020-05-07 Thread Rob Herring
On Thu, 30 Apr 2020 10:06:17 +0200, =?UTF-8?q?Pali=20Roh=C3=A1r?= wrote: > From: Marek Behún > > Currently the aardvark driver trains link in PCIe gen2 mode. This may > cause some buggy gen1 cards (such as Compex WLE900VX) to be unstable or > even not detected. Moreover when ASPM code tries to

Re: [PATCH v1] Add support for MediaTek regulator vibrator driver

2020-05-07 Thread Pavel Machek
On Thu 2020-05-07 22:45:35, Jacek Anaszewski wrote: > Hi Pavel, > > On 5/7/20 7:45 PM, Pavel Machek wrote: > > Hi! > > > > > This patchset add regulator vibrator driver for MTK Soc. The driver > > > controls vibrator through regulator's enable and disable. > > > > We'd prefer not to have

Re: [PATCH v4 03/12] PCI: of: Zero max-link-speed value is invalid

2020-05-07 Thread Rob Herring
On Thu, 30 Apr 2020 10:06:16 +0200, =?UTF-8?q?Pali=20Roh=C3=A1r?= wrote: > Interpret zero value of max-link-speed property as invalid, > as the device tree bindings documentation specifies. > > Signed-off-by: Pali Rohár > --- > drivers/pci/of.c | 2 +- > 1 file changed, 1 insertion(+), 1

Re: [PATCH v4 02/12] PCI: aardvark: Don't blindly enable ASPM L0s and don't write to read-only register

2020-05-07 Thread Rob Herring
On Thu, 30 Apr 2020 10:06:15 +0200, =?UTF-8?q?Pali=20Roh=C3=A1r?= wrote: > Trying to change Link Status register does not have any effect as this > is a read-only register. Trying to overwrite bits for Negotiated Link > Width does not make sense. > > In future proper change of link width can be

Re: [PATCH v3 10/19] mm: memcg/slab: deprecate memory.kmem.slabinfo

2020-05-07 Thread Johannes Weiner
On Wed, Apr 22, 2020 at 01:46:59PM -0700, Roman Gushchin wrote: > Deprecate memory.kmem.slabinfo. > > An empty file will be presented if corresponding config options are > enabled. > > The interface is implementation dependent, isn't present in cgroup v2, > and is generally useful only for core

Re: [PATCH v3] net: bpf: permit redirect from ingress L3 to egress L2 devices at near max mtu

2020-05-07 Thread Daniel Borkmann
On 5/7/20 6:46 PM, Maciej Żenczykowski wrote: (a) not clear why the max is SKB_MAX_ALLOC in the first place (this is PAGE_SIZE << 2, ie. 16K on x86), while lo mtu is 64k Agreed, tbh, it's not clear to me either atm. :) The SKB_MAX_ALLOC constant itself should be replaced with something more

Re: [PATCH v4 01/12] PCI: aardvark: Train link immediately after enabling training

2020-05-07 Thread Rob Herring
On Thu, 30 Apr 2020 10:06:14 +0200, =?UTF-8?q?Pali=20Roh=C3=A1r?= wrote: > Adding even 100ms (PCI_PM_D3COLD_WAIT) delay between enabling link > training and starting link training causes detection issues with some > buggy cards (such as Compex WLE900VX). > > Move the code which enables link

Re: [PATCH v3 06/19] mm: memcg/slab: obj_cgroup API

2020-05-07 Thread Johannes Weiner
On Wed, Apr 22, 2020 at 01:46:55PM -0700, Roman Gushchin wrote: > --- a/mm/memcontrol.c > +++ b/mm/memcontrol.c > @@ -257,6 +257,78 @@ struct cgroup_subsys_state *vmpressure_to_css(struct > vmpressure *vmpr) > } > > #ifdef CONFIG_MEMCG_KMEM > +extern spinlock_t css_set_lock; > + > +static

Re: [PATCH] PCI: amlogic: meson: Don't use FAST_LINK_MODE to set up link

2020-05-07 Thread Rob Herring
On Wed, 29 Apr 2020 17:42:30 +0100, Marc Zyngier wrote: > My vim3l board stubbornly refuses to play ball with a bog > standard PCIe switch (ASM1184e), spitting all kind of errors > ranging from link never coming up to crazy things like downstream > ports falling off the face of the planet. > >

Re: [PATCH] PCI: export and use pci_msi_get_hwirq in pci-hyperv.c

2020-05-07 Thread Rob Herring
On Wed, Apr 22, 2020 at 07:58:15PM +, Wei Liu wrote: > There is a functionally identical function in pci-hyperv.c. Drop it and > use pci_msi_get_hwirq instead. > > This requires exporting pci_msi_get_hwirq and declaring it in msi.h. > > No functional change intended. > > Signed-off-by: Wei

Re: [PATCH v2] ath10k: Replace zero-length array with flexible-array

2020-05-07 Thread Rajkumar Manoharan
On 2020-05-06 21:11, Gustavo A. R. Silva wrote: [...] static inline struct htt_stats_conf_item *htt_stats_conf_next_item( @@ -1674,7 +1674,7 @@ struct htt_tx_fetch_ind { __le16 num_resp_ids; __le16 num_records; struct htt_tx_fetch_record records[0]; - __le32

Re: [PATCH] tracing/probe: reverse arguments to list_add

2020-05-07 Thread Julia Lawall
On Thu, 7 May 2020, Steven Rostedt wrote: > On Thu, 7 May 2020 16:50:53 -0400 > Steven Rostedt wrote: > > > On Thu, 7 May 2020 21:30:08 +0200 > > Julia Lawall wrote: > > > > > Elsewhere in the file, the function trace_kprobe_has_same_kprobe uses > > > a trace_probe_event.probes object as

Re: [PATCH] fs/io_uring: fix O_PATH fds in openat, openat2, statx

2020-05-07 Thread Jens Axboe
On 5/7/20 1:29 PM, Al Viro wrote: > On Thu, May 07, 2020 at 01:05:23PM -0600, Jens Axboe wrote: >> On 5/7/20 1:01 PM, Al Viro wrote: >>> On Thu, May 07, 2020 at 08:57:25PM +0200, Max Kellermann wrote: If an operation's flag `needs_file` is set, the function io_req_set_file() calls

Re: [PATCH V3 15/15] kmap: Consolidate kmap_prot definitions

2020-05-07 Thread Andrew Morton
On Thu, 7 May 2020 08:00:03 -0700 ira.we...@intel.com wrote: > From: Ira Weiny > > Most architectures define kmap_prot to be PAGE_KERNEL. > > Let sparc and xtensa define there own and define PAGE_KERNEL as the > default if not overridden. > checkpatch considered useful ;) From: Andrew

Re: [PATCH V3 13/15] parisc/kmap: Remove duplicate kmap code

2020-05-07 Thread Andrew Morton
On Thu, 7 May 2020 08:00:01 -0700 ira.we...@intel.com wrote: > parisc reimplements the kmap calls except to flush it's dcache. This is > arguably an abuse of kmap but regardless it is messy and confusing. > > Remove the duplicate code and have parisc define > ARCH_HAS_FLUSH_ON_KUNMAP for a

RE: [Intel-wired-lan] [PATCH net-next] i40e: Make i40e_shutdown_adminq() return void

2020-05-07 Thread Bowers, AndrewX
-Original Message- From: Intel-wired-lan On Behalf Of Jason Yan Sent: Tuesday, May 5, 2020 11:19 PM To: Kirsher, Jeffrey T ; da...@davemloft.net; Azarewicz, Piotr ; intel-wired-...@lists.osuosl.org; net...@vger.kernel.org; linux-kernel@vger.kernel.org Cc: Jason Yan Subject:

Re: [PATCH] tracing/probe: reverse arguments to list_add

2020-05-07 Thread Steven Rostedt
On Thu, 7 May 2020 16:50:53 -0400 Steven Rostedt wrote: > On Thu, 7 May 2020 21:30:08 +0200 > Julia Lawall wrote: > > > Elsewhere in the file, the function trace_kprobe_has_same_kprobe uses > > a trace_probe_event.probes object as the second argument of > > list_for_each_entry, ie as a list

Re: [PATCH] tracing/probe: reverse arguments to list_add

2020-05-07 Thread Steven Rostedt
On Thu, 7 May 2020 21:30:08 +0200 Julia Lawall wrote: > Elsewhere in the file, the function trace_kprobe_has_same_kprobe uses > a trace_probe_event.probes object as the second argument of > list_for_each_entry, ie as a list head, while the list_for_each_entry > iterates over the list fields of

[PATCH] mm: vmscan: consistent update to pgsteal and pgscan

2020-05-07 Thread Shakeel Butt
One way to measure the efficiency of memory reclaim is to look at the ratio (pgscan+pfrefill)/pgsteal. However at the moment these stats are not updated consistently at the system level and the ratio of these are not very meaningful. The pgsteal and pgscan are updated for only global reclaim while

[PATCH] ARM: imx_v6_v7_defconfig: extend RN5T618 PMIC family support

2020-05-07 Thread Andreas Kemnade
There are new drivers for functionality of that family (RTC and ADC), so enable them, since they are used by various i.MX6 boards. Signed-off-by: Andreas Kemnade --- arch/arm/configs/imx_v6_v7_defconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm/configs/imx_v6_v7_defconfig

Re: [RFC][PATCH 1/3] evm: Move hooks outside LSM infrastructure

2020-05-07 Thread Mimi Zohar
On Thu, 2020-05-07 at 16:47 +, Roberto Sassu wrote: > > > > On Wed, 2020-05-06 at 15:44 -0400, Mimi Zohar wrote: > > > > > Since copying the EVM HMAC or original signature isn't applicable, I > > > > > would prefer exploring an EVM portable and immutable signature only > > > > > solution. > >

Re: [PATCH v1] Add support for MediaTek regulator vibrator driver

2020-05-07 Thread Jacek Anaszewski
Hi Pavel, On 5/7/20 7:45 PM, Pavel Machek wrote: Hi! This patchset add regulator vibrator driver for MTK Soc. The driver controls vibrator through regulator's enable and disable. We'd prefer not to have vibrators in led subsystem. Xing Zhang (3): dt-bindings: add regulator vibrator

RE: [Intel-wired-lan] [PATCH net-next] ixgbe: Use true, false for bool variable in __ixgbe_enable_sriov()

2020-05-07 Thread Bowers, AndrewX
-Original Message- From: Intel-wired-lan On Behalf Of Jason Yan Sent: Tuesday, May 5, 2020 12:44 AM To: Kirsher, Jeffrey T ; da...@davemloft.net; a...@kernel.org; dan...@iogearbox.net; k...@kernel.org; h...@kernel.org; john.fastab...@gmail.com; intel-wired-...@lists.osuosl.org;

Re: [PATCH] kernel: add panic_on_taint

2020-05-07 Thread Rafael Aquini
On Wed, May 06, 2020 at 10:50:19PM -0400, Qian Cai wrote: > > > > On May 6, 2020, at 6:28 PM, Rafael Aquini wrote: > > > > Analogously to the introduction of panic_on_warn, this patch > > introduces a kernel option named panic_on_taint in order to > > provide a simple and generic way to stop

Re: [PATCH v3 03/19] mm: memcg: convert vmstat slab counters to bytes

2020-05-07 Thread Johannes Weiner
On Wed, Apr 22, 2020 at 01:46:52PM -0700, Roman Gushchin wrote: > In order to prepare for per-object slab memory accounting, convert > NR_SLAB_RECLAIMABLE and NR_SLAB_UNRECLAIMABLE vmstat items to bytes. > > To make it obvious, rename them to NR_SLAB_RECLAIMABLE_B and > NR_SLAB_UNRECLAIMABLE_B

Re: [PATCH] media: venus: Replace zero-length array with flexible-array

2020-05-07 Thread Stanimir Varbanov
Hi Gustavo, Two patches from you are already queued in media_tree for v5.8. 0f61e171e4bbac4595175070c75707f1b12f4e37 media: venus: hfi_msgs.h: Replace zero-length array with flexible-array member 380f3bbd9562dc93be2e3cadc329b15284fbedae media: venus: hfi_cmds.h: Replace zero-length array with

RE: [Intel-wired-lan] [PATCH net-next] ixgbe: Remove conversion to bool in ixgbe_device_supports_autoneg_fc()

2020-05-07 Thread Bowers, AndrewX
-Original Message- From: Intel-wired-lan On Behalf Of Jason Yan Sent: Tuesday, May 5, 2020 12:42 AM To: Kirsher, Jeffrey T ; da...@davemloft.net; intel-wired-...@lists.osuosl.org; net...@vger.kernel.org; linux-kernel@vger.kernel.org Cc: Jason Yan Subject: [Intel-wired-lan] [PATCH

RE: [Intel-wired-lan] [PATCH net-next] ixgbe: Remove unused inline function ixgbe_irq_disable_queues

2020-05-07 Thread Bowers, AndrewX
-Original Message- From: Intel-wired-lan On Behalf Of YueHaibing Sent: Tuesday, May 5, 2020 1:36 AM To: Kirsher, Jeffrey T ; da...@davemloft.net Cc: net...@vger.kernel.org; YueHaibing ; intel-wired-...@lists.osuosl.org; linux-kernel@vger.kernel.org Subject: [Intel-wired-lan] [PATCH

RE: [Intel-wired-lan] [PATCH net-next] ixgbe: fix signed-integer-overflow warning

2020-05-07 Thread Bowers, AndrewX
-Original Message- From: Intel-wired-lan On Behalf Of Xie XiuQi Sent: Monday, May 4, 2020 7:45 PM To: Kirsher, Jeffrey T ; da...@davemloft.net Cc: net...@vger.kernel.org; intel-wired-...@lists.osuosl.org; linux-kernel@vger.kernel.org Subject: [Intel-wired-lan] [PATCH net-next] ixgbe:

Re: [PATCH v2] sched/fair: Fix enqueue_task_fair warning some more

2020-05-07 Thread Phil Auld
sched/fair: Fix enqueue_task_fair warning some more The recent patch, fe61468b2cb (sched/fair: Fix enqueue_task_fair warning) did not fully resolve the issues with the rq->tmp_alone_branch != >leaf_cfs_rq_list warning in enqueue_task_fair. There is a case where the first for_each_sched_entity

Re: [PATCH v3 02/19] mm: memcg: prepare for byte-sized vmstat items

2020-05-07 Thread Johannes Weiner
On Wed, Apr 22, 2020 at 01:46:51PM -0700, Roman Gushchin wrote: > To implement per-object slab memory accounting, we need to > convert slab vmstat counters to bytes. Actually, out of > 4 levels of counters: global, per-node, per-memcg and per-lruvec > only two last levels will require byte-sized

Re: [PATCH v2] kernel: add panic_on_taint

2020-05-07 Thread Luis Chamberlain
On Thu, May 07, 2020 at 02:47:05PM -0400, Rafael Aquini wrote: > On Thu, May 07, 2020 at 02:43:16PM -0400, Rafael Aquini wrote: > > On Thu, May 07, 2020 at 06:22:57PM +, Luis Chamberlain wrote: > > > On Thu, May 07, 2020 at 02:06:31PM -0400, Rafael Aquini wrote: > > > > diff --git

Re: [PATCH v3 01/19] mm: memcg: factor out memcg- and lruvec-level changes out of __mod_lruvec_state()

2020-05-07 Thread Johannes Weiner
On Wed, Apr 22, 2020 at 01:46:50PM -0700, Roman Gushchin wrote: > To convert memcg and lruvec slab counters to bytes there must be > a way to change these counters without touching node counters. > Factor out __mod_memcg_lruvec_state() out of __mod_lruvec_state(). > > Signed-off-by: Roman

[PATCH] scsi: lpfc: remove redundant initialization to variable rc

2020-05-07 Thread Colin King
From: Colin Ian King The variable rc is being initialized with a value that is never read and it is being updated later with a new value. The initialization is redundant and can be removed. Addresses-Coverity: ("Unused value") Signed-off-by: Colin Ian King --- drivers/scsi/lpfc/lpfc_attr.c |

Re: [PATCH 3/3] selftests/ftrace: Use /bin/echo instead of built-in echo

2020-05-07 Thread Zanussi, Tom
Hi, On 5/7/2020 12:25 PM, Steven Rostedt wrote: On Fri, 8 May 2020 00:50:28 +0900 Masami Hiramatsu wrote: Yes, I need Tom's review for this change. As far as I can test, this fixes the test failure. If this isn't acceptable, we can use "alias echo=echo" for this test case. I still

RE: [PATCH] platform/x86: dell-laptop: don't register platform::micmute if the related tokens don't exist.

2020-05-07 Thread Mario.Limonciello
> hi Andy, > it's dell g3 3590. OK, so this is released hardware in Inspiron. I think this patch generally makes good sense for that case.

Re: [PATCH] ALSA: Replace zero-length array with flexible-array

2020-05-07 Thread Takashi Iwai
On Thu, 07 May 2020 21:22:23 +0200, Gustavo A. R. Silva wrote: > > The current codebase makes use of the zero-length array language > extension to the C90 standard, but the preferred mechanism to declare > variable-length types such as these ones is a flexible array member[1][2], > introduced in

[PATCH] phy: cpcap-usb: Remove some useless code

2020-05-07 Thread Christophe JAILLET
Axe a clk that is unused in the driver. Signed-off-by: Christophe JAILLET --- drivers/phy/motorola/phy-cpcap-usb.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/phy/motorola/phy-cpcap-usb.c b/drivers/phy/motorola/phy-cpcap-usb.c index 12e71a315a2c..089db0dea703 100644 ---

Re: [PATCH] tools/bootconfig: fix resource leak in apply_xbc()

2020-05-07 Thread Markus Elfring
> The @data and @fd is leak in the error path of apply_xbc(), so this > patch fix it. I suggest to improve this change description. * Please use an imperative wording. * Would you like to add the tag “Fixes”? > +++ b/tools/bootconfig/main.c > @@ -314,6 +314,7 @@ int apply_xbc(const char

Re: [PATCH v2 4/4] PCI: cadence: Fix to read 32-bit Vendor ID/Device ID property from DT

2020-05-07 Thread Rob Herring
On Fri, 17 Apr 2020 17:13:22 +0530, Kishon Vijay Abraham I wrote: > The PCI Bus Binding specification (IEEE Std 1275-1994 Revision 2.1 [1]) > defines both Vendor ID and Device ID to be 32-bits. Fix > pcie-cadence-host.c driver to read 32-bit Vendor ID and Device ID > properties from device tree. >

Re: [PATCH v2 3/4] PCI: cadence: Remove "cdns,max-outbound-regions" DT property

2020-05-07 Thread Rob Herring
On Fri, 17 Apr 2020 17:13:21 +0530, Kishon Vijay Abraham I wrote: > "cdns,max-outbound-regions" device tree property provides the > maximum number of outbound regions supported by the Host PCIe > controller. However the outbound regions are configured based > on what is populated in the "ranges"

Re: [PATCH v2 2/4] PCI: cadence: Use "dma-ranges" instead of "cdns,no-bar-match-nbits" property

2020-05-07 Thread Rob Herring
On Wed, May 06, 2020 at 08:52:13AM +0530, Kishon Vijay Abraham I wrote: > Hi Robin, > > On 5/4/2020 6:23 PM, Kishon Vijay Abraham I wrote: > > Hi Robin, > > > > On 5/4/2020 4:24 PM, Robin Murphy wrote: > >> On 2020-05-04 9:44 am, Kishon Vijay Abraham I wrote: > >>> Hi Robin, > >>> > >>> On

Re: [PATCH -next] net: ipa: remove duplicate headers

2020-05-07 Thread David Miller
From: Chen Zhou Date: Thu, 7 May 2020 21:39:45 +0800 > Remove duplicate headers which are included twice. > > Signed-off-by: Chen Zhou The net-next tree already has this fixed.

Re: [PATCH -next] cxgb4: remove duplicate headers

2020-05-07 Thread David Miller
From: Chen Zhou Date: Thu, 7 May 2020 21:26:39 +0800 > Remove duplicate headers which are included twice. > > Signed-off-by: Chen Zhou Applied.

Re: [PATCH v3 2/4] arm64: dts: rockchip: Add RGA support to the PX30

2020-05-07 Thread Paul Kocialkowski
Hi, On Fri 01 May 20, 00:05, Johan Jonker wrote: > Hi Paul, > > > The PX30 features a RGA block: add the necessary node to support it. > > > > Signed-off-by: Paul Kocialkowski > > --- > > arch/arm64/boot/dts/rockchip/px30.dtsi | 11 +++ > > 1 file changed, 11 insertions(+) > > > >

Re: [PATCH v3 1/4] dt-bindings: rockchip-rga: Add PX30 compatible

2020-05-07 Thread Paul Kocialkowski
Hi, On Thu 30 Apr 20, 23:24, Johan Jonker wrote: > Hi Paul, > > > > > Add a new compatible for the PX30 Rockchip SoC, which also features > > a RGA block. It is compatible with the RK3288 RGA block. > > > > Signed-off-by: Paul Kocialkowski > > --- > >

[PATCH] drm/exynos: remove redundant initialization to variable 'start'

2020-05-07 Thread Colin King
From: Colin Ian King The variable 'start' is being initialized with a value that is never read and it is being updated later with a new value. The initialization is redundant and can be removed. Addresses-Coverity: ("Unused value") Signed-off-by: Colin Ian King ---

Re: [PATCH 5/7] mm: move zone iterator outside of deferred_init_maxorder()

2020-05-07 Thread Daniel Jordan
On Thu, May 07, 2020 at 08:26:26AM -0700, Alexander Duyck wrote: > On Wed, May 6, 2020 at 3:39 PM Daniel Jordan > wrote: > > On Tue, May 05, 2020 at 08:27:52AM -0700, Alexander Duyck wrote: > > > > Maybe it's better to leave deferred_init_maxorder alone and adapt the > > > > multithreading to

Re: [RFC PATCH bpf-next 3/3] bpf, arm64: Optimize ADD,SUB,JMP BPF_K using arm64 add/sub immediates

2020-05-07 Thread Daniel Borkmann
On 5/7/20 3:05 AM, Luke Nelson wrote: The current code for BPF_{ADD,SUB} BPF_K loads the BPF immediate to a temporary register before performing the addition/subtraction. Similarly, BPF_JMP BPF_K cases load the immediate to a temporary register before comparison. This patch introduces

Re: [PATCH v2 0/2] Add QRTR MHI client driver

2020-05-07 Thread David Miller
From: Manivannan Sadhasivam Date: Thu, 7 May 2020 18:23:04 +0530 > Here is the series adding MHI client driver support to Qualcomm IPC router > protocol. MHI is a newly added bus to kernel which is used to communicate to > external modems over a physical interface like PCI-E. This driver is

Re: [PATCH 2/3] remoteproc: Add inline coredump functionality

2020-05-07 Thread Bjorn Andersson
On Thu 16 Apr 11:38 PDT 2020, Rishabh Bhatnagar wrote: > This patch adds the inline coredump functionality. The current > coredump implementation uses vmalloc area to copy all the segments. > But this might put a lot of strain on low memory targets as the > firmware size sometimes is in ten's of

Re: [RFC PATCH bpf-next 2/3] bpf, arm64: Optimize AND,OR,XOR,JSET BPF_K using arm64 logical immediates

2020-05-07 Thread Daniel Borkmann
On 5/7/20 3:05 AM, Luke Nelson wrote: The current code for BPF_{AND,OR,XOR,JSET} BPF_K loads the immediate to a temporary register before use. This patch changes the code to avoid using a temporary register when the BPF immediate is encodable using an arm64 logical immediate instruction. If the

Re: [PATCH] sched/fair: Return true,false in voluntary_active_balance()

2020-05-07 Thread Joe Perches
On Thu, 2020-05-07 at 15:45 -0400, Steven Rostedt wrote: > On Thu, 07 May 2020 12:06:56 -0700 > Joe Perches wrote: > > > People describe changes as a "fix" all the time for stuff > > that isn't an actual fix for a logic defect but is instead > > an update to a particular style preference. > > >

Re: [PATCH] net/mlx5e: Use IS_ERR() to check and simplify code

2020-05-07 Thread David Miller
From: Tang Bin Date: Thu, 7 May 2020 19:50:10 +0800 > Use IS_ERR() and PTR_ERR() instead of PTR_ZRR_OR_ZERO() > to simplify code, avoid redundant judgements. > > Signed-off-by: Zhang Shengju > Signed-off-by: Tang Bin Saeed, please pick this up. Thank you.

Re: [PATCH] net: hisilicon: Make CONFIG_HNS invisible

2020-05-07 Thread David Miller
From: Geert Uytterhoeven Date: Thu, 7 May 2020 13:45:11 +0200 > The HNS config symbol enables the framework support for the Hisilicon > Network Subsystem. It is already selected by all of its users, so there > is no reason to make it visible. > > Signed-off-by: Geert Uytterhoeven Applied,

Re: [PATCH v3 1/4] PCI: brcmstb: Don't clk_put() a managed clock

2020-05-07 Thread Florian Fainelli
On 5/7/2020 1:15 PM, Jim Quinlan wrote: > From: Jim Quinlan > > clk_put() was being invoked on a clock obtained by > devm_clk_get_optional(). > > Signed-off-by: Jim Quinlan > Acked-by: Florian Fainelli > Acked-by: Nicolas Saenz Julienne This one should also have: Fixes: c0452137034b

RE: [PATCH 1/2] IB/sa: Resolving use-after-free in ib_nl_send_msg.

2020-05-07 Thread Wan, Kaike
> -Original Message- > From: Mark Bloch > Sent: Thursday, May 07, 2020 3:36 PM > To: Divya Indi ; linux-kernel@vger.kernel.org; linux- > r...@vger.kernel.org; Jason Gunthorpe ; Wan, Kaike > > Cc: Gerd Rausch ; Håkon Bugge > ; Srinivas Eeda ; > Rama Nichanamatlu ; Doug Ledford > >

[PATCH v3 4/4] PCI: brcmstb: Disable L0s component of ASPM if requested

2020-05-07 Thread Jim Quinlan
From: Jim Quinlan Some informal internal experiments has shown that the BrcmSTB ASPM L0s savings may introduce an undesirable noise signal on some customers' boards. In addition, L0s was found lacking in realized power savings, especially relative to the L1 ASPM component. This is BrcmSTB's

[PATCH v3 3/4] dt-bindings: PCI: brcmstb: New prop 'aspm-no-l0s'

2020-05-07 Thread Jim Quinlan
From: Jim Quinlan For various reasons, one may want to disable the ASPM L0s capability. Signed-off-by: Jim Quinlan --- Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml

Re: [PATCH] kgdboc: Be a bit more robust about handling earlycon leaving

2020-05-07 Thread Doug Anderson
Hi, On Mon, May 4, 2020 at 4:53 AM Daniel Thompson wrote: > > On Fri, May 01, 2020 at 10:36:14AM -0700, Doug Anderson wrote: > > Hi, > > > > On Fri, May 1, 2020 at 6:32 AM Daniel Thompson > > wrote: > > > > > > On Fri, May 01, 2020 at 12:49:43PM +0100, Daniel Thompson wrote: > > > > On Thu, Apr

Re: [PATCH v5 2/2] drm: Add support for the LogiCVC display controller

2020-05-07 Thread Paul Kocialkowski
Hi, On Mon 04 May 20, 13:45, Daniel Vetter wrote: > On Thu, Apr 30, 2020 at 09:10:07PM +0200, Paul Kocialkowski wrote: > > Hi Daniel, > > > > On Fri 03 Apr 20, 13:04, Daniel Vetter wrote: > > > On Fri, Apr 03, 2020 at 11:36:17AM +0200, Paul Kocialkowski wrote: > > > > Introduces a driver for the

[PATCH v3 1/4] PCI: brcmstb: Don't clk_put() a managed clock

2020-05-07 Thread Jim Quinlan
From: Jim Quinlan clk_put() was being invoked on a clock obtained by devm_clk_get_optional(). Signed-off-by: Jim Quinlan Acked-by: Florian Fainelli Acked-by: Nicolas Saenz Julienne --- drivers/pci/controller/pcie-brcmstb.c | 1 - 1 file changed, 1 deletion(-) diff --git

[PATCH v3 2/4] PCI: brcmstb: Fix window register offset from 4 to 8

2020-05-07 Thread Jim Quinlan
From: Jim Quinlan The outbound memory window registers were being referenced with an incorrect stride offset. This probably wasn't noticed previously as there was likely only one such window employed. Signed-off-by: Jim Quinlan Acked-by: Florian Fainelli Acked-by: Nicolas Saenz Julienne

[PATCH v3 0/4] PCI: brcmstb: Some minor fixes/features

2020-05-07 Thread Jim Quinlan
v3 -- A change was submitted to [1] to make 'aspm-no-l0s' a general property for PCIe devices. As such, the STB PCIe YAML file merely notes that it may be used. v2 -- Dropped commit concerning CRS. -- Chanded new prop 'brcm,aspm-en-l0s' to 'aspm-no-l0s'. -- Capitalize first

Re: [PATCH] PCI: Replace zero-length array with flexible-array

2020-05-07 Thread Bjorn Helgaas
On Thu, May 07, 2020 at 02:05:44PM -0500, Gustavo A. R. Silva wrote: > The current codebase makes use of the zero-length array language > extension to the C90 standard, but the preferred mechanism to declare > variable-length types such as these ones is a flexible array member[1][2], > introduced

RE: [PATCH] platform/x86: dell-laptop: don't register platform::micmute if the related tokens don't exist.

2020-05-07 Thread Mario.Limonciello
> -Original Message- > From: koba...@canonical.com > Sent: Thursday, May 7, 2020 7:27 AM > To: Matthew Garrett; Pali Rohár; Darren Hart; Andy Shevchenko; > platform-driver- > x...@vger.kernel.org; linux-kernel@vger.kernel.org; Limonciello, Mario > Subject: [PATCH] platform/x86:

Re: [PATCH v6 2/3] drm: Add support for the LogiCVC display controller

2020-05-07 Thread Paul Kocialkowski
Hi Emil, Thanks for the review! On Mon 04 May 20, 14:28, Emil Velikov wrote: > Just had a casual quick look for custom KMS properties, since new > drivers made that mistake in the past. > Thanks for not including any o/ Yeah I made sure not to include any, I know it easily gets very problematic

[PATCH v4 08/12] kgdboc: Add kgdboc_earlycon to support early kgdb using boot consoles

2020-05-07 Thread Douglas Anderson
We want to enable kgdb to debug the early parts of the kernel. Unfortunately kgdb normally is a client of the tty API in the kernel and serial drivers don't register to the tty layer until fairly late in the boot process. Serial drivers do, however, commonly register a boot console. Let's enable

[PATCH v4 12/12] serial: amba-pl011: Support kgdboc_earlycon

2020-05-07 Thread Douglas Anderson
From: Sumit Garg Implement the read() function in the early console driver. With recently added kgdboc_earlycon feature, this allows you to use kgdb to debug fairly early into the system boot. We only bother implementing this if polling is enabled since kgdb can't be enabled without that.

[PATCH v4 11/12] serial: 8250_early: Support kgdboc_earlycon

2020-05-07 Thread Douglas Anderson
Implement the read() function in the early console driver. With recent kgdb patches this allows you to use kgdb to debug fairly early into the system boot. We only bother implementing this if polling is enabled since kgdb can't be enabled without that. Signed-off-by: Douglas Anderson

[PATCH] tracing/probe: reverse arguments to list_add

2020-05-07 Thread Julia Lawall
Elsewhere in the file, the function trace_kprobe_has_same_kprobe uses a trace_probe_event.probes object as the second argument of list_for_each_entry, ie as a list head, while the list_for_each_entry iterates over the list fields of the trace_probe structures, making them the list elements. So,

[PATCH v4 01/12] kgdb: Disable WARN_CONSOLE_UNLOCKED for all kgdb

2020-05-07 Thread Douglas Anderson
In commit 81eaadcae81b ("kgdboc: disable the console lock when in kgdb") we avoided the WARN_CONSOLE_UNLOCKED() yell when we were in kgdboc. That still works fine, but it turns out that we get a similar yell when using other I/O drivers. One example is the "I/O driver" for the kgdb test suite

[PATCH v4 07/12] kgdboc: Remove useless #ifdef CONFIG_KGDB_SERIAL_CONSOLE in kgdboc

2020-05-07 Thread Douglas Anderson
This file is only ever compiled if that config is on since the Makefile says: obj-$(CONFIG_KGDB_SERIAL_CONSOLE) += kgdboc.o Let's get rid of the useless #ifdef. Reported-by: Daniel Thompson Signed-off-by: Douglas Anderson --- Changes in v4: - ("kgdboc: Remove useless #ifdef...") new for

[PATCH v4 02/12] Revert "kgdboc: disable the console lock when in kgdb"

2020-05-07 Thread Douglas Anderson
This reverts commit 81eaadcae81b4c1bf01649a3053d1f54e2d81cf1. Commit 81eaadcae81b ("kgdboc: disable the console lock when in kgdb") is no longer needed now that we have the patch ("kgdb: Disable WARN_CONSOLE_UNLOCKED for all kgdb"). Revert it. Signed-off-by: Douglas Anderson Reviewed-by: Greg

[PATCH v4 04/12] kgdb: Delay "kgdbwait" to dbg_late_init() by default

2020-05-07 Thread Douglas Anderson
Using kgdb requires at least some level of architecture-level initialization. If nothing else, it relies on the architecture to pass breakpoints / crashes onto kgdb. On some architectures this all works super early, specifically it starts working at some point in time before Linux parses

[PATCH v4 09/12] Documentation: kgdboc: Document new kgdboc_earlycon parameter

2020-05-07 Thread Douglas Anderson
The recent patch ("kgdboc: Add kgdboc_earlycon to support early kgdb using boot consoles") adds a new kernel command line parameter. Document it. Note that the patch adding the feature does some comparing/contrasting of "kgdboc_earlycon" vs. the existing "ekgdboc". See that patch for more

[PATCH v4 05/12] arm64: Add call_break_hook() to early_brk64() for early kgdb

2020-05-07 Thread Douglas Anderson
In order to make early kgdb work properly we need early_brk64() to be able to call into it. This is as easy as adding a call into call_break_hook() just like we do later in the normal brk_handler(). Once we do this we can let kgdb know that it can break into the debugger a little earlier

[PATCH v4 06/12] kgdb: Prevent infinite recursive entries to the debugger

2020-05-07 Thread Douglas Anderson
If we detect that we recursively entered the debugger we should hack our I/O ops to NULL so that the panic() in the next line won't actually cause another recursion into the debugger. The first line of kgdb_panic() will check this and return. Signed-off-by: Douglas Anderson Reviewed-by: Daniel

[PATCH v4 10/12] serial: qcom_geni_serial: Support kgdboc_earlycon

2020-05-07 Thread Douglas Anderson
Implement the read() function in the early console driver. With recent kgdb patches this allows you to use kgdb to debug fairly early into the system boot. We only bother implementing this if polling is enabled since kgdb can't be enabled without that. Signed-off-by: Douglas Anderson

[PATCH v4 00/12] kgdb: Support late serial drivers; enable early debug w/ boot consoles

2020-05-07 Thread Douglas Anderson
This whole pile of patches was motivated by me trying to get kgdb to work properly on a platform where my serial driver ended up being hit by the -EPROBE_DEFER virus (it wasn't practicing social distancing from other drivers). Specifically my serial driver's parent device depended on a resource

[PATCH v4 03/12] kgdboc: Use a platform device to handle tty drivers showing up late

2020-05-07 Thread Douglas Anderson
If you build CONFIG_KGDB_SERIAL_CONSOLE into the kernel then you should be able to have KGDB init itself at bootup by specifying the "kgdboc=..." kernel command line parameter. This has worked OK for me for many years, but on a new device I switched to it stopped working. The problem is that on

RE: [PATCH] treewide: Replace zero-length array with flexible-array

2020-05-07 Thread Winkler, Tomas
> -Original Message- > From: Gustavo A. R. Silva > Sent: Thursday, May 07, 2020 21:54 > To: Winkler, Tomas > Cc: linux-kernel@vger.kernel.org > Subject: [PATCH] treewide: Replace zero-length array with flexible-array Ack. > > The current codebase makes use of the zero-length

Re: [PATCH 0/2] memory: tegra: EMC scaling is not a clock provider

2020-05-07 Thread Thierry Reding
On Wed, May 06, 2020 at 02:32:34PM +0200, Geert Uytterhoeven wrote: > Hi all, > > The Tegra EMC scaling support code is not a clock provider, but merely a > clock consumer, and thus does not need to include > . > > However, drivers/memory/tegra/tegra210-emc-table.c relies on >

Re: [net-next] net:enetc: bug fix for qos sfi operate space after freed

2020-05-07 Thread David Miller
From: Po Liu Date: Thu, 7 May 2020 18:57:38 +0800 > 'Dan Carpenter' reported: > This code frees "sfi" and then dereferences it on the next line: >> kfree(sfi); >> clear_bit(sfi->index, epsfp.psfp_sfi_bitmap); > > This "sfi->index" should be "index". > >

Re: [PATCH net-next] net: tulip: de4x5: make PCI_signature() return void

2020-05-07 Thread David Miller
From: Jason Yan Date: Thu, 7 May 2020 19:08:47 +0800 > This function always return 0 now, we can make it return void to > simplify the code. This fixes the following coccicheck warning: > > drivers/net/ethernet/dec/tulip/de4x5.c:3908:11-17: Unneeded variable: > "status". Return "0" on line 3912

Re: [PATCH net-next] net: mlx4: remove unneeded variable "err" in mlx4_en_ethtool_add_mac_rule()

2020-05-07 Thread David Miller
From: Jason Yan Date: Thu, 7 May 2020 19:08:57 +0800 > Fix the following coccicheck warning: > > drivers/net/ethernet/mellanox/mlx4/en_ethtool.c:1396:5-8: Unneeded > variable: "err". Return "0" on line 1411 > > Signed-off-by: Jason Yan Applied.

Re: [PATCH net-next] net: atheros: remove dead code in atl1c_resume()

2020-05-07 Thread David Miller
From: Jason Yan Date: Thu, 7 May 2020 19:08:36 +0800 > This code has been marked dead for nearly 10 years. Remove it. > > Signed-off-by: Jason Yan Applied.

Re: [PATCH] sctp: Replace zero-length array with flexible-array

2020-05-07 Thread Neil Horman
On Thu, May 07, 2020 at 02:21:52PM -0500, Gustavo A. R. Silva wrote: > The current codebase makes use of the zero-length array language > extension to the C90 standard, but the preferred mechanism to declare > variable-length types such as these ones is a flexible array member[1][2], > introduced

Re: [PATCH net-next] net: encx24j600: make encx24j600_hw_init() return void

2020-05-07 Thread David Miller
From: Jason Yan Date: Thu, 7 May 2020 19:09:05 +0800 > This function always return 0 now, we can make it return void to > simplify the code. This fixes the following coccicheck warning: > > drivers/net/ethernet/microchip/encx24j600.c:609:5-8: Unneeded variable: > "ret". Return "0" on line 653 >

Re: [PATCH 1/2] of: Make self-contained

2020-05-07 Thread Thierry Reding
On Wed, May 06, 2020 at 02:32:35PM +0200, Geert Uytterhoeven wrote: > is not self-contained, as it uses > _OF_DECLARE() to define RESERVEDMEM_OF_DECLARE(), but does not include > . > > Fix this by adding the missing include. > > Signed-off-by: Geert Uytterhoeven > --- >

Re: [PATCH 2/2] memory: tegra: Drop

2020-05-07 Thread Thierry Reding
On Wed, May 06, 2020 at 02:32:36PM +0200, Geert Uytterhoeven wrote: > The Tegra EMC scaling support code is not a clock provider, but merely a > clock consumer, and thus does not need to include > . > > Fixes: ec37a9a17afbfad5 ("memory: tegra: Add EMC scaling support code for > Tegra210") >

<    1   2   3   4   5   6   7   8   9   10   >