[PATCH v3 1/1] powerpc/crash: Use NMI context for printk when starting to crash

2020-05-18 Thread Leonardo Bras
Currently, if printk lock (logbuf_lock) is held by other thread during crash, there is a chance of deadlocking the crash on next printk, and blocking a possibly desired kdump. At the start of default_machine_crash_shutdown, make printk enter NMI context, as it will use per-cpu buffers to store

Re: UBSAN: array-index-out-of-bounds in kernel/bpf/arraymap.c:177

2020-05-18 Thread Andrii Nakryiko
On Mon, May 18, 2020 at 5:09 PM Qian Cai wrote: > > On Mon, May 18, 2020 at 7:55 PM Andrii Nakryiko > wrote: > > > > On Sun, May 17, 2020 at 7:45 PM Qian Cai wrote: > > > > > > With Clang 9.0.1, > > > > > > return array->value + array->elem_size * (index & array->index_mask); > > > > > > but

Re: [PATCH] ARM: kprobes: Avoid fortify_panic() when copying optprobe template

2020-05-18 Thread Andrew Jeffery
On Mon, 18 May 2020, at 11:50, Masami Hiramatsu wrote: > On Sun, 17 May 2020 14:48:52 -0700 > Kees Cook wrote: > > > On Mon, May 18, 2020 at 01:09:59AM +0930, Andrew Jeffery wrote: > > > As mentioned, a couple of attempts have been made to address the issue > > > by casting a pointer to

Re: [PATCH 2/4] clk/soc: mediatek: mt6797: Bind clock driver from platform device

2020-05-18 Thread Chun-Kuang Hu
Hi, Matthias: 於 2020年5月18日 週一 下午7:32寫道: > > From: Matthias Brugger > > The mmsys driver is now the top level entry point for the multimedia > system (mmsys), we bind the clock driver by creating a platform device. > We also bind the MediaTek DRM driver which is not yet implement and > therefor

Re: [PATCH v3 05/14] remoteproc: Refactor function rproc_fw_boot()

2020-05-18 Thread Bjorn Andersson
On Fri 15 May 12:46 PDT 2020, Mathieu Poirier wrote: > On Wed, May 13, 2020 at 07:10:55PM -0700, Bjorn Andersson wrote: > > On Fri 08 May 14:27 PDT 2020, Mathieu Poirier wrote: > > > > > On Tue, May 05, 2020 at 05:33:41PM -0700, Bjorn Andersson wrote: > > > > On Fri 24 Apr 13:01 PDT 2020,

[PATCH 0/4] mm/gup, drm/i915: refactor gup_fast, convert to pin_user_pages()

2020-05-18 Thread John Hubbard
This needs to go through Andrew's -mm tree, due to adding a new gup.c routine. However, I would really love to have some testing from the drm/i915 folks, because I haven't been able to run-time test that part of it. Otherwise, though, the series has passed my basic run time testing: some LTP

[PATCH 4/4] drm/i915: convert get_user_pages() --> pin_user_pages()

2020-05-18 Thread John Hubbard
This code was using get_user_pages*(), in a "Case 2" scenario (DMA/RDMA), using the categorization from [1]. That means that it's time to convert the get_user_pages*() + put_page() calls to pin_user_pages*() + unpin_user_pages() calls. There is some helpful background in [2]: basically, this is a

[PATCH 3/4] mm/gup: introduce pin_user_pages_fast_only()

2020-05-18 Thread John Hubbard
This is the FOLL_PIN equivalent of __get_user_pages_fast(), except with a more descriptive name, and gup_flags instead of a boolean "write" in the argument list. Signed-off-by: John Hubbard --- include/linux/mm.h | 2 ++ mm/gup.c | 36 2 files

Re: [PATCH 1/4] clk/soc: mediatek: mt8183: Bind clock driver from platform device

2020-05-18 Thread Chun-Kuang Hu
Hi, Matthias: Matthias Brugger 於 2020年5月18日 週一 下午11:57寫道: > > > > On 18/05/2020 17:30, Chun-Kuang Hu wrote: > > Hi, Matthias: > > > > 於 2020年5月18日 週一 下午7:32寫道: > >> > >> From: Matthias Brugger > >> > >> The mmsys driver is now the top level entry point for the multimedia > >> system (mmsys),

[PATCH 2/4] mm/gup: refactor and de-duplicate gup_fast() code

2020-05-18 Thread John Hubbard
There were two nearly identical sets of code for gup_fast() style of walking the page tables with interrupts disabled. This has lead to the usual maintenance problems that arise from having duplicated code. There is already a core internal routine in gup.c for gup_fast(), so just enhance it very

[PATCH 1/4] mm/gup: move __get_user_pages_fast() down a few lines in gup.c

2020-05-18 Thread John Hubbard
This is in order to avoid a forward declaration of internal_get_user_pages_fast(), in the next patch. This is code movement only--all generated code should be identical. Signed-off-by: John Hubbard --- mm/gup.c | 112 +++ 1 file changed, 56

Re: [PATCH v2] usb: gadget: Fix issue with config_ep_by_speed function.

2020-05-18 Thread Peter Chen
Delete '.' at the end of subject. Reply-To: In-Reply-To: <20200518100844.28293-1-paw...@cadence.com> On 20-05-18 12:08:45, Pawel Laszczak wrote: > This patch adds new config_ep_by_speed_and_alt function which > extends the config_ep_by_speed about alt parameter. > This additional parameter

Re: UBSAN: array-index-out-of-bounds in kernel/bpf/arraymap.c:177

2020-05-18 Thread Qian Cai
On Mon, May 18, 2020 at 7:55 PM Andrii Nakryiko wrote: > > On Sun, May 17, 2020 at 7:45 PM Qian Cai wrote: > > > > With Clang 9.0.1, > > > > return array->value + array->elem_size * (index & array->index_mask); > > > > but array->value is, > > > > char value[0] __aligned(8); > > This, and ptrs

Re: [PATCH V3 07/15] arch/kunmap_atomic: Consolidate duplicate code

2020-05-18 Thread Ira Weiny
On Sun, May 17, 2020 at 09:29:32PM -0700, Guenter Roeck wrote: > On Sun, May 17, 2020 at 08:49:39PM -0700, Ira Weiny wrote: > > On Sat, May 16, 2020 at 03:33:06PM -0700, Guenter Roeck wrote: > > > On Thu, May 07, 2020 at 07:59:55AM -0700, ira.we...@intel.com wrote: > > > > From: Ira Weiny > > > >

drivers/iio/accel/bma400_i2c.c:21: undefined reference to `__devm_regmap_init_i2c'

2020-05-18 Thread kbuild test robot
://anongit.freedesktop.org/drm/drm-misc into drm-fixes date: 3 months ago config: arm64-randconfig-r024-20200518 (attached as .config) compiler: aarch64-linux-gcc (GCC) 9.3.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross

Re: [PATCH 1/4] exec: Change uselib(2) IS_SREG() failure to EACCES

2020-05-18 Thread Eric W. Biederman
Christian Brauner writes: > On Mon, May 18, 2020 at 04:43:20PM +0200, Jann Horn wrote: >> On Mon, May 18, 2020 at 3:03 PM Christian Brauner >> wrote: >> > Also - gulp (puts on flame proof suit) - may I suggest we check if there >> > are any distros out there that still set CONFIG_USELIB=y >>

Re: [PATCH v7 4/5] remoteproc: ingenic: Added remoteproc driver

2020-05-18 Thread Bjorn Andersson
On Fri 15 May 03:43 PDT 2020, Paul Cercueil wrote: > This driver is used to boot, communicate with and load firmwares to the > MIPS co-processor found in the VPU hardware of the JZ47xx SoCs from > Ingenic. > > Signed-off-by: Paul Cercueil > Acked-by: Mathieu Poirier Series applied Thanks,

Re: [patch V6 07/37] x86/entry: Provide helpers for execute on irqstack

2020-05-18 Thread Andy Lutomirski
On Mon, May 18, 2020 at 4:53 PM Thomas Gleixner wrote: > > Andy Lutomirski writes: > > Actually, I revoke my ack. Can you make one of two changes: > > > > Option A: Add an assertion to run_on_irqstack to verify that irq_count > > was -1 at the beginning? I suppose this also means you could

Re: UBSAN: array-index-out-of-bounds in kernel/bpf/arraymap.c:177

2020-05-18 Thread Andrii Nakryiko
On Sun, May 17, 2020 at 7:45 PM Qian Cai wrote: > > With Clang 9.0.1, > > return array->value + array->elem_size * (index & array->index_mask); > > but array->value is, > > char value[0] __aligned(8); This, and ptrs and pptrs, should be flexible arrays. But they are in a union, and unions don't

Re: [PATCH net-next] net: phy: simplify phy_link_change arguments

2020-05-18 Thread David Miller
From: Doug Berger Date: Mon, 18 May 2020 15:23:59 -0700 > This function was introduced to allow for different handling of > link up and link down events particularly with regard to the > netif_carrier. The third argument do_carrier allowed the flag to > be left unchanged. > > Since then the

Re: [PATCH 0/7] x86: Clean up percpu operations

2020-05-18 Thread Nick Desaulniers
On Mon, May 18, 2020 at 12:19 PM Nick Desaulniers wrote: > > On Sun, May 17, 2020 at 8:29 AM Brian Gerst wrote: > > > > The core percpu operations already have a switch on the width of the > > data type, which resulted in an extra amount of dead code being > > Thanks for the series Brian. The

Re: [patch V6 07/37] x86/entry: Provide helpers for execute on irqstack

2020-05-18 Thread Thomas Gleixner
Andy Lutomirski writes: > Actually, I revoke my ack. Can you make one of two changes: > > Option A: Add an assertion to run_on_irqstack to verify that irq_count > was -1 at the beginning? I suppose this also means you could just > explicitly write 0 instead of adding and subtracting. > > Option

Re: [patch V6 07/37] x86/entry: Provide helpers for execute on irqstack

2020-05-18 Thread Thomas Gleixner
Andy Lutomirski writes: > On Fri, May 15, 2020 at 5:10 PM Thomas Gleixner wrote: > > Have you tested by forcing a stack trace from the IRQ stack and making > sure it unwinds all the way out? Yes.

Re: [patch V6 09/37] x86/entry: Split idtentry_enter/exit()

2020-05-18 Thread Andy Lutomirski
On Fri, May 15, 2020 at 5:10 PM Thomas Gleixner wrote: > > > Split the implementation of idtentry_enter/exit() out into inline functions > so that variants of idtentry_enter/exit() can be implemented without > duplicating code. > After reading just this patch, I don't see how it helps anything.

Re: [patch V6 08/37] x86/entry/64: Move do_softirq_own_stack() to C

2020-05-18 Thread Andy Lutomirski
On Fri, May 15, 2020 at 5:10 PM Thomas Gleixner wrote: > > > The first step to get rid of the ENTER/LEAVE_IRQ_STACK ASM macro maze. Use > the new C code helpers to move do_softirq_own_stack() out of ASM code. > > Signed-off-by: Thomas Gleixner > > diff --git a/arch/x86/entry/entry_64.S

Re: [PATCH 1/7] x86/percpu: Introduce size abstraction macros

2020-05-18 Thread Nick Desaulniers
On Sun, May 17, 2020 at 8:29 AM Brian Gerst wrote: > > In preparation for cleaning up the percpu operations, define macros for > abstraction based on the width of the operation. > > Signed-off-by: Brian Gerst > --- > arch/x86/include/asm/percpu.h | 30 ++ > 1 file

[PATCH V5 4/4] x86/resctrl: Use appropriate API for strings terminated by newline

2020-05-18 Thread Reinette Chatre
The user input to files in the resctrl filesystem are expected to be terminated with a newline. Testing the user input includes a test for the presence of a newline and then replacing the newline with NUL byte followed by comparison using strcmp(). sysfs_streq() exists to test if strings are

Re: [PATCH v10 01/26] Documentation/x86: Add CET description

2020-05-18 Thread Yu-cheng Yu
On Fri, 2020-05-15 at 19:53 -0700, Yu-cheng Yu wrote: > On Fri, 2020-05-15 at 16:56 -0700, Dave Hansen wrote: > > On 5/15/20 4:29 PM, Yu-cheng Yu wrote: > > > [...] > > > I have run them with CET enabled. All of them pass, except for the > > > following: > > > Sigreturn from 64-bit to 32-bit

[PATCH V5 3/4] x86/resctrl: Enable per-thread MBA

2020-05-18 Thread Reinette Chatre
From: Fenghua Yu Current Memory Bandwidth Allocation (MBA) hardware has a limitation: all threads on the same core must have the same delay value. If there are different delay values across threads on one core, the original MBA implementation allocates the max delay value to the core and an

[PATCH V5 0/4] x86/resctrl: Enable user to view and select thread throttling mode

2020-05-18 Thread Reinette Chatre
V4 upstream submission available from: https://lore.kernel.org/lkml/cover.1589652468.git.reinette.cha...@intel.com Patches apply against x86/cache branch commit 0c4d5ba1b998e of tip repo at git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git Changes since V4: - Pick up Babu's "Reviewed-by"

[PATCH V5 2/4] x86/resctrl: Enumerate per-thread MBA

2020-05-18 Thread Reinette Chatre
From: Fenghua Yu Some systems support per-thread Memory Bandwidth Allocation (MBA) which applies a throttling delay value to each hardware thread instead of to a core. Per-thread MBA is enumerated by CPUID. No feature flag is shown in /proc/cpuinfo. User applications need to check a resctrl

[PATCH V5 1/4] x86/resctrl: Enable user to view and select thread throttling mode

2020-05-18 Thread Reinette Chatre
Intel Memory Bandwidth Allocation (MBA) control is provided per processor core. At the same time different CLOS, configured with different bandwidth percentages, can be assigned to the hardware threads sharing a core. In the original implementation of MBA the maximum throttling of the per-thread

Re: [patch V6 07/37] x86/entry: Provide helpers for execute on irqstack

2020-05-18 Thread Andy Lutomirski
On Mon, May 18, 2020 at 4:11 PM Andy Lutomirski wrote: > > On Fri, May 15, 2020 at 5:10 PM Thomas Gleixner wrote: > > > > > > Device interrupt handlers and system vector handlers are executed on the > > interrupt stack. The stack switch happens in the low level assembly entry > > code. This

Re: [RFC][PATCH 4/5] thermal: Add support for setting polling interval

2020-05-18 Thread Srinivas Pandruvada
On Mon, 2020-05-18 at 18:51 +0200, Daniel Lezcano wrote: > On 04/05/2020 20:16, Srinivas Pandruvada wrote: > > Add new attribute in the thermal syfs for setting temperature > > sampling > > interval when CONFIG_THERMAL_USER_EVENT_INTERFACE is defined. The > > default > > value is 0, which means no

Re: [PATCH 5/7] x86/percpu: Clean up percpu_add_return_op()

2020-05-18 Thread Brian Gerst
On Mon, May 18, 2020 at 6:46 PM Nick Desaulniers wrote: > > On Sun, May 17, 2020 at 8:29 AM Brian Gerst wrote: > > > > The core percpu macros already have a switch on the data size, so the switch > > in the x86 code is redundant and produces more dead code. > > > > Also use appropriate types for

[PATCH v6 2/2] powerpc/rtas: Implement reentrant rtas call

2020-05-18 Thread Leonardo Bras
Implement rtas_call_reentrant() for reentrant rtas-calls: "ibm,int-on", "ibm,int-off",ibm,get-xive" and "ibm,set-xive". On LoPAPR Version 1.1 (March 24, 2016), from 7.3.10.1 to 7.3.10.4, items 2 and 3 say: 2 - For the PowerPC External Interrupt option: The * call must be reentrant to the number

Re: [PATCH 4/7] x86/percpu: Clean up percpu_add_op()

2020-05-18 Thread Nick Desaulniers
On Sun, May 17, 2020 at 8:29 AM Brian Gerst wrote: > > The core percpu macros already have a switch on the data size, so the switch > in the x86 code is redundant and produces more dead code. > > Also use appropriate types for the width of the instructions. This avoids > errors when compiling

[PATCH v6 0/2] Implement reentrant rtas call

2020-05-18 Thread Leonardo Bras
Patch 2 implement rtas_call_reentrant() for reentrant rtas-calls: "ibm,int-on", "ibm,int-off",ibm,get-xive" and "ibm,set-xive", according to LoPAPR Version 1.1 (March 24, 2016). For that, it's necessary that every call uses a different rtas buffer (rtas_args). Paul Mackerras suggested using the

[PATCH v6 1/2] powerpc/rtas: Move type/struct definitions from rtas.h into rtas-types.h

2020-05-18 Thread Leonardo Bras
In order to get any rtas* struct into other headers, including rtas.h may cause a lot of errors, regarding include dependency needed for inline functions. Create rtas-types.h and move there all type/struct definitions from rtas.h, then include rtas-types.h into rtas.h. Also, as suggested by

Re: kernel BUG at mm/hugetlb.c:LINE!

2020-05-18 Thread Colin Walters
On Tue, May 12, 2020, at 11:04 AM, Miklos Szeredi wrote: > > However, in this syzbot test case the 'file' is in an overlayfs filesystem > > created as follows: > > > > mkdir("./file0", 000) = 0 > > mount(NULL, "./file0", "hugetlbfs", MS_MANDLOCK|MS_POSIXACL, NULL) = 0 > >

Re: [RFC][PATCH 3/5] thermal: Add support for setting notification thresholds

2020-05-18 Thread Srinivas Pandruvada
On Mon, 2020-05-18 at 18:37 +0200, Daniel Lezcano wrote: > On 04/05/2020 20:16, Srinivas Pandruvada wrote: > > Add new attributes in thermal syfs when a thermal drivers provides > > callbacks for them and CONFIG_THERMAL_USER_EVENT_INTERFACE is > > defined. > > > > These attribute allow user space

Re: [PATCH v5 2/2] powerpc/rtas: Implement reentrant rtas call

2020-05-18 Thread Leonardo Bras
On Sat, 2020-05-16 at 17:36 +1000, Nicholas Piggin wrote: > Good, I think this should work as you want now. Can you allocate it like > lppacas? Put it under PSERIES (and in the paca) and check for !HV? Sure, I will do that. > Oh and while there, could you prefix the name with rtas_? Sure,

Re: [PATCH] arm64: defconfig: enable Qualcomm IPA and RMNet modules

2020-05-18 Thread Bjorn Andersson
On Mon 18 May 14:54 PDT 2020, Alex Elder wrote: > Enable building the Qualcomm IPA driver as a kernel module. To be > useful, the IPA driver also requires RMNet, so enable building that > as a module as well. > > Signed-off-by: Alex Elder Applied Thanks, Bjorn > --- >

Re: [PATCH] arm64: dts: qcom: sc7180: add IPA information

2020-05-18 Thread Bjorn Andersson
On Mon 18 May 14:49 PDT 2020, Alex Elder wrote: > Add IPA-related nodes and definitions to "sc7180.dtsi". > > Signed-off-by: Alex Elder Applied Thanks, Bjorn > --- > arch/arm64/boot/dts/qcom/sc7180.dtsi | 51 > 1 file changed, 51 insertions(+) > > diff --git

Re: [PATCH] arm64: dts: qcom: sdm845-mtp: enable IPA

2020-05-18 Thread Bjorn Andersson
On Mon 18 May 14:48 PDT 2020, Alex Elder wrote: > Enable IPA on the SDM845 MTP. > > Signed-off-by: Alex Elder > --- > arch/arm64/boot/dts/qcom/sdm845-mtp.dts | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sdm845-mtp.dts >

Re: kernel BUG at mm/hugetlb.c:LINE!

2020-05-18 Thread Mike Kravetz
On 5/18/20 4:12 AM, Miklos Szeredi wrote: > On Sat, May 16, 2020 at 12:15 AM Mike Kravetz wrote: >> Any suggestions on how to move forward? It seems like there may be the >> need for a real_file() routine? I see a d_real dentry_op was added to >> deal with this issue for dentries. Might we

Re: [PATCH V2 3/3] thermal/int340x_thermal: Don't require IDSP to exist

2020-05-18 Thread Pandruvada, Srinivas
On Mon, 2020-04-13 at 19:09 -0700, Matthew Garrett wrote: > From: Matthew Garrett > > The IDSP method doesn't appear to exist on the most recent Intel > platforms: > instead, the IDSP data is included in the GDDV blob. Since we > probably don't > want to decompress and parse that in-kernel, just

Re: [PATCH V2 1/3] thermal/int340x_thermal: Export GDDV

2020-05-18 Thread Pandruvada, Srinivas
On Mon, 2020-04-13 at 19:09 -0700, Matthew Garrett wrote: > From: Matthew Garrett > > Implementing DPTF properly requires making use of firmware-provided > information associated with the INT3400 device. Calling GDDV provides > a > buffer of information which userland can then interpret to

Re: [PATCH V2 2/3] thermal/int340x_thermal: Export OEM vendor variables

2020-05-18 Thread Pandruvada, Srinivas
On Mon, 2020-04-13 at 19:09 -0700, Matthew Garrett wrote: > From: Matthew Garrett > > The platform vendor may expose an array of OEM-specific values to be > used > in determining DPTF policy. These are obtained via the ODVP method, > and > then simply exposed in sysfs. In addition, they are

Re: mmotm 2020-05-15-16-29 uploaded

2020-05-18 Thread Stephen Rothwell
Hi Andrew, On Sat, 16 May 2020 15:53:58 +1000 Stephen Rothwell wrote: > > On Fri, 15 May 2020 16:30:18 -0700 Andrew Morton > wrote: > > > > * mm-introduce-external-memory-hinting-api.patch > > The above patch should have > > #define __NR_process_madvise 443 > > not 442, in

Re: [PATCH v3 2/7] dt-bindings: mdf: ti,j721e-syscon.yaml: Add J721e system controller

2020-05-18 Thread Rob Herring
On Mon, May 18, 2020 at 8:51 AM Rob Herring wrote: > > On Fri, May 08, 2020 at 11:29:32AM +0300, Roger Quadros wrote: > > Add DT binding schema for J721e system controller. > > > > Signed-off-by: Roger Quadros > > --- > > .../bindings/mfd/ti,j721e-syscon.yaml | 69 +++ >

Re: [PATCH] seccomp: Add group_leader pid to seccomp_notif

2020-05-18 Thread Eric W. Biederman
Sargun Dhillon writes: > This includes the thread group leader ID in the seccomp_notif. This is > immediately useful for opening up a pidfd for the group leader, as > pidfds only work on group leaders. The code looks fine (except for the name of the test), but can you please talk and think

Re: [patch V6 07/37] x86/entry: Provide helpers for execute on irqstack

2020-05-18 Thread Andy Lutomirski
On Fri, May 15, 2020 at 5:10 PM Thomas Gleixner wrote: > > > Device interrupt handlers and system vector handlers are executed on the > interrupt stack. The stack switch happens in the low level assembly entry > code. This conflicts with the efforts to consolidate the exit code in C to > ensure

안녕하십니까

2020-05-18 Thread Ange Paul
안녕하세요 친애하는, 죄송하게 바지선으로 갑자기려는 우리가 서로를 알지 못하기 전에 나는 기도하시기 전에 연락하십시오,당신을 위해 하나님을 위해 표시되지 않 내 우편으로 당황하고 또한 인기는 세계에서,사람을 좋아하지 않는 사람들을 돕기 위해 실시 하지만 나는 강하게 믿는다는 단식과 기도 않았을 것이 보내 도우미로 나에게 하나님의 은혜 제가 가지고 있기 때문에 나는 문제는 나는 필요 진심으로 도움을 주라는 무시 나기 때문에 당신은 이메일에 대한 올바른 사람이 목적입니다. 내 이름은 안제 폴 23 세 아이보리 코스트에서 소녀,나는

Re: [patch V6 37/37] x86/entry: Remove the TRACE_IRQS cruft

2020-05-18 Thread Andy Lutomirski
On Fri, May 15, 2020 at 5:11 PM Thomas Gleixner wrote: > > > No more users. Hallelujah! Acked-by: Andy Lutomirski >

Re: [patch V6 06/37] genirq: Provde __irq_enter/exit_raw()

2020-05-18 Thread Andy Lutomirski
On Fri, May 15, 2020 at 5:10 PM Thomas Gleixner wrote: > Reviewed-by: Andy Lutomirski

Re: [patch V6 05/37] genirq: Provide irq_enter/exit_rcu()

2020-05-18 Thread Andy Lutomirski
On Fri, May 15, 2020 at 5:10 PM Thomas Gleixner wrote: > > > irq_enter()/exit() include the RCU handling. To properly separate the RCU > handling provide variants which contain only the non-RCU related > functionality. Reviewed-by: Andy Lutomirski

Re: [PATCH] mm: use only pidfd for process_madvise syscall

2020-05-18 Thread Andrew Morton
On Mon, 18 May 2020 14:13:50 -0700 Minchan Kim wrote: > Andrew, I sent this patch without folding into previous syscall introducing > patches because it could be arguable. If you want to fold it into each > patchset(i.e., introdcuing process_madvise syscall and introducing > compat_syscall), let

Re: [PATCH -next] iommu/arm-smmu-v3: remove set but not used variable 'smmu'

2020-05-18 Thread Will Deacon
On Fri, 8 May 2020 09:49:55 +0800, Chen Zhou wrote: > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/iommu/arm-smmu-v3.c:2989:26: > warning: variable ‘smmu’ set but not used [-Wunused-but-set-variable] > struct arm_smmu_device *smmu; Applied to will (for-joerg/arm-smmu/updates),

Re: objtool warning breaks build for fs/dlm/lock.o

2020-05-18 Thread Josh Poimboeuf
On Mon, May 18, 2020 at 05:53:28PM -0500, Josh Poimboeuf wrote: > > I'm now struggling with a clang -fintegrated-as related failure: > > > > arch/x86/kernel/ftrace_64.o: warning: objtool: missing symbol for insn at > > offset 0x16 > > make[4]: *** [/git/arm-soc/scripts/Makefile.build:355: > >

Re: [PATCH v2] arm64: stacktrace: Factor out some common code into on_stack()

2020-05-18 Thread Will Deacon
On Fri, 8 May 2020 11:15:45 +0800, Yunfeng Ye wrote: > There are some common codes for stack checking, so factors it out into > the function on_stack(). > > No functional change. Applied to arm64 (for-next/misc), thanks! [1/1] arm64: stacktrace: Factor out some common code into on_stack()

Re: [PATCH v4 6/6] ramoops: Add max_reason optional field to ramoops DT node

2020-05-18 Thread Kees Cook
On Mon, May 18, 2020 at 04:45:32PM -0600, Rob Herring wrote: > On Fri, May 15, 2020 at 12:44 PM Kees Cook wrote: > > > > From: Pavel Tatashin > > Subject still has 'max_reason'. > > > > > Currently, it is possible to dump kmsges for panic, or oops. > > With max_reason it is possible to dump

Re: [PATCH] arm64: Call debug_traps_init() from trap_init() to help early kgdb

2020-05-18 Thread Will Deacon
On Wed, 13 May 2020 16:06:37 -0700, Douglas Anderson wrote: > A new kgdb feature will soon land (kgdb_earlycon) that lets us run > kgdb much earlier. In order for everything to work properly it's > important that the break hook is setup by the time we process > "kgdbwait". > > Right now the

Re: [PATCH v6] iommu/arm-smmu-qcom: Request direct mapping for modem device

2020-05-18 Thread Will Deacon
On Mon, 11 May 2020 23:25:32 +0530, Sibi Sankar wrote: > The modem remote processor has two access paths to DDR. One path is > directly connected to DDR and another path goes through an SMMU. The > SMMU path is configured to be a direct mapping because it's used by > various peripherals in the

Re: [PATCH v12 00/18] Enable FSGSBASE instructions

2020-05-18 Thread Thomas Gleixner
Jarkko Sakkinen writes: > On Mon, 2020-05-18 at 08:34 -0700, Andi Kleen wrote: >> > Yes, for SGX this is functional feature because enclave entry points, >> > thread control structures (aka TCS's), reset FSBASE and GSBASE registers >> > to fixed (albeit user defined) values. And syscall's can be

Re: [PATCH 5.6 000/194] 5.6.14-rc1 review

2020-05-18 Thread Guenter Roeck
On Mon, May 18, 2020 at 07:34:50PM +0200, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 5.6.14 release. > There are 194 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me

Re: [PATCH v12 10/18] x86/fsgsbase/64: Enable FSGSBASE instructions in helper functions

2020-05-18 Thread Thomas Gleixner
Sasha, Sasha Levin writes: > Thank you for taking the time to review this. welcome and sorry for the explosion. > On Mon, May 18, 2020 at 08:20:08PM +0200, Thomas Gleixner wrote: >>Sasha Levin writes: >>This conditional irqsave gunk is clearly NOT what was in the tip tree >>before it got

Re: [PATCH] soc: fsl: qe: Replace one-element array and use struct_size() helper

2020-05-18 Thread Kees Cook
On Mon, May 18, 2020 at 05:19:04PM -0500, Gustavo A. R. Silva wrote: > The current codebase makes use of one-element arrays in the following > form: > > struct something { > int length; > u8 data[1]; > }; > > struct something *instance; > > instance = kmalloc(sizeof(*instance) + size,

Re: seccomp feature development

2020-05-18 Thread Andy Lutomirski
On Mon, May 18, 2020 at 2:05 PM Kees Cook wrote: > > Hi! > This is minor, but, if we grow seccomp_data, I would like to add the other 32 bits of the syscall nr to it. Syscall numbers are unsigned long, but they get munged into u32 for seccomp_data. Sure, no one uses those high bits yet, but if

Re: objtool warning breaks build for fs/dlm/lock.o

2020-05-18 Thread Josh Poimboeuf
On Mon, May 18, 2020 at 09:57:50PM +0200, Arnd Bergmann wrote: > On Fri, May 8, 2020 at 1:29 AM Josh Poimboeuf wrote: > > > > On Wed, May 06, 2020 at 04:07:25PM +0200, Arnd Bergmann wrote: > > > Hi, > > > > > > During randconfig testing with clang-10 I came across a number > > > of additional

Re: [PATCH v5 0/1] Add rga to rk322x device tree

2020-05-18 Thread Heiko Stuebner
On Sun, 19 Apr 2020 12:51:32 +, Justin Swartz wrote: > This patchset aims to enable use of Rockchip's RGA, a 2D raster > graphic acceleration unit, on rk322x based devices. > > Changes in v5: > - Remove the patch to rockchip-rga device tree binding documentation > as Johan Jonker has

KASAN: use-after-free Read in em28xx_release_resources

2020-05-18 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:806d8acc USB: dummy-hcd: use configurable endpoint naming .. git tree: https://github.com/google/kasan.git usb-fuzzer console output: https://syzkaller.appspot.com/x/log.txt?x=161ad20210 kernel config:

Re: [PATCH 5/7] x86/percpu: Clean up percpu_add_return_op()

2020-05-18 Thread Nick Desaulniers
On Sun, May 17, 2020 at 8:29 AM Brian Gerst wrote: > > The core percpu macros already have a switch on the data size, so the switch > in the x86 code is redundant and produces more dead code. > > Also use appropriate types for the width of the instructions. This avoids > errors when compiling

Re: [PATCH V4 1/4] x86/resctrl: Enable user to view and select thread throttling mode

2020-05-18 Thread Reinette Chatre
Hi Babu, On 5/18/2020 10:28 AM, Babu Moger wrote: > Hi Reinette, > Looks good most part. Few minor comments. Thank you very much for taking a look. > >> -Original Message- >> From: Reinette Chatre >> Sent: Saturday, May 16, 2020 1:29 PM >> To: t...@linutronix.de;

Re: [PATCH v4 6/6] ramoops: Add max_reason optional field to ramoops DT node

2020-05-18 Thread Rob Herring
On Fri, May 15, 2020 at 12:44 PM Kees Cook wrote: > > From: Pavel Tatashin Subject still has 'max_reason'. > > Currently, it is possible to dump kmsges for panic, or oops. > With max_reason it is possible to dump messages for other And here. > kmesg_dump events, for example reboot, halt,

Re: [PATCH v13 3/5] usb: xhci: Add support for Renesas controller with memory

2020-05-18 Thread Bjorn Andersson
On Mon 18 May 12:57 PDT 2020, Vinod Koul wrote: > Hi Anders, > > On 18-05-20, 19:53, Anders Roxell wrote: > > On Wed, 6 May 2020 at 08:01, Vinod Koul wrote: > > > > > > Some rensas controller like uPD720201 and uPD720202 need firmware to be > > > loaded. Add these devices in pci table and

Re: [PATCH V2] dt-bindings: reset: Convert i.MX7 reset to json-schema

2020-05-18 Thread Rob Herring
On Mon, May 11, 2020 at 6:07 AM Anson Huang wrote: > > Convert the i.MX7 reset binding to DT schema format using json-schema. > > Signed-off-by: Anson Huang > --- > Changes since V1: > - Improve description; > - Remove i.MX8MM and i.MX8MN compatible, they use i.MX8MQ's >

Re: [PATCH] ARM: dts: remove disable-wp from rk3229-xms6 emmc

2020-05-18 Thread Heiko Stübner
Am Montag, 6. April 2020, 15:50:05 CEST schrieb Justin Swartz: > Remove the disable-wp attribute from as it is, according to > Documentation/devicetree/bindings/mmc/mmc-controller.yaml: > > "Not used in combination with eMMC or SDIO." > > Suggested-by: Johan Jonker > Signed-off-by: Justin

Re: [PATCH v2] ARM: dts: enable WLAN for Mecer Xtreme Mini S6

2020-05-18 Thread Heiko Stuebner
On Mon, 6 Apr 2020 13:50:04 +, Justin Swartz wrote: > The Mecer Xtreme Mini S6 features a wireless module, based on a > Realtek 8723BS, which provides WLAN and Bluetooth connectivity via > SDIO and UART interfaces respectively. > > Define a simple MMC power sequence that declares the GPIO

Re: [PATCH] arm64: dts: rockchip: add bus-width properties to mmc nodes for px30.dtsi

2020-05-18 Thread Heiko Stuebner
On Thu, 16 Apr 2020 20:30:53 +0200, Johan Jonker wrote: > 'bus-width' and pinctrl containing the bus-pins > should be in the same file, so add them to > all mmc nodes in 'px30.dtsi'. Applied, thanks! [1/1] arm64: dts: rockchip: add bus-width properties to mmc nodes for px30 commit:

Re: seccomp feature development

2020-05-18 Thread Jann Horn
On Mon, May 18, 2020 at 11:05 PM Kees Cook wrote: > ## deep argument inspection > > Background: seccomp users would like to write filters that traverse > the user pointers passed into many syscalls, but seccomp can't do this > dereference for a variety of reasons (mostly involving race conditions

Re: [PATCH v3 3/3] mm: adjust vm_committed_as_batch according to vm overcommit policy

2020-05-18 Thread Andrew Morton
On Sat, 16 May 2020 14:47:40 +0800 Feng Tang wrote: > When checking a performance change for will-it-scale scalability > mmap test [1], we found very high lock contention for spinlock of > percpu counter 'vm_committed_as': > > 94.14% 0.35% [kernel.kallsyms] [k]

Re: [PATCH v13 3/5] usb: xhci: Add support for Renesas controller with memory

2020-05-18 Thread Anders Roxell
On Mon, 18 May 2020 at 21:57, Vinod Koul wrote: > > Hi Anders, Hi Vinod, > > On 18-05-20, 19:53, Anders Roxell wrote: > > On Wed, 6 May 2020 at 08:01, Vinod Koul wrote: > > > > > > Some rensas controller like uPD720201 and uPD720202 need firmware to be > > > loaded. Add these devices in pci

Re: [PATCH 1/2] arm64: dts: qcom: sc7180: Support ETMv4 power management

2020-05-18 Thread Bjorn Andersson
On Mon 18 May 12:08 PDT 2020, Sai Prakash Ranjan wrote: > Hi Bjorn, > > On 2020-05-19 00:21, Bjorn Andersson wrote: > > On Fri 15 May 03:55 PDT 2020, Sai Prakash Ranjan wrote: > > [...] > > > > > > > > > > The previous version of this patch in QCOM tree seems to have added > > > the > > >

Re: [PATCH v2 2/3] dt-bindings: leds: Add binding for aw2013

2020-05-18 Thread Rob Herring
On Mon, 11 May 2020 16:11:27 +0500, wrote: > From: Nikita Travkin > > Add YAML devicetree binding for AWINIC AW2013 3-channel led driver > > Signed-off-by: Nikita Travkin > --- > .../devicetree/bindings/leds/leds-aw2013.yaml | 91 +++ > 1 file changed, 91 insertions(+) >

Re: [PATCH] x86: mmiotrace: Use cpumask_available for cpumask_var_t variables

2020-05-18 Thread Steven Rostedt
On Mon, 18 May 2020 11:52:47 -0700 Nick Desaulniers wrote: > On Mon, May 18, 2020 at 2:31 AM Nathan Chancellor > wrote: > > > > On Wed, Apr 08, 2020 at 01:53:23PM -0700, Nathan Chancellor wrote: > > > When building with Clang + -Wtautological-compare and > > > CONFIG_CPUMASK_OFFSTACK unset: >

Re: [PATCH V2] arm64/cpuinfo: Move HWCAP name arrays alongside their bit definitions

2020-05-18 Thread Will Deacon
On Fri, May 15, 2020 at 08:58:05AM +0530, Anshuman Khandual wrote: > On 05/14/2020 01:06 PM, Will Deacon wrote: > > Why is it a change? We've never reported e.g. "java" on an arm64 kernel, so > > We already have "java" defined in existing compat_hwcap_str[] array even > though it might never get

linux-next: Signed-off-by missing for commit in the keys tree

2020-05-18 Thread Stephen Rothwell
Hi all, Commit 2a1dbdae70b5 ("Documentation: security: core.rst: add missing argument") is missing a Signed-off-by from its committer. -- Cheers, Stephen Rothwell pgpNC8bvGd5Ch.pgp Description: OpenPGP digital signature

Re: [PATCH] ceph: don't return -ESTALE if there's still an open file

2020-05-18 Thread Gregory Farnum
Maybe we resolved this conversation; I can't quite tell... On Fri, May 15, 2020 at 12:16 PM Jeff Layton wrote: > > On Fri, 2020-05-15 at 19:56 +0300, Amir Goldstein wrote: > > On Fri, May 15, 2020 at 2:38 PM Jeff Layton wrote: > > > On Fri, 2020-05-15 at 12:15 +0100, Luis Henriques wrote: > > >

Re: [PATCH v3 3/4] arm64: dts: rockchip: remove include for irq.h

2020-05-18 Thread Heiko Stübner
Hi Johan, Am Freitag, 3. April 2020, 20:01:58 CEST schrieb Johan Jonker: > The 'irq.h' file is already included through 'arm-gic.h', > so remove them from all Rockchip dtsi files. I disagree here ... we do use properties from both arm-gic.h and the main irq.h an therefore should not rely on the

Re: [PATCH v2 2/2] arm64: dts: rockchip: rk3399: fix pd_tcpc0 and pd_tcpc1 node position

2020-05-18 Thread Heiko Stübner
Hi Kever, Caesar, could you double check where the type-c power-domains are located in the power-tree, as Caesar did add them under pd_vio back in 2016. Thanks Heiko Am Dienstag, 28. April 2020, 22:30:03 CEST schrieb Johan Jonker: > The pd_tcpc0 and pd_tcpc1 nodes are currently a sub node of

Re: [PATCH 7/7] x86/percpu: Clean up percpu_cmpxchg_op()

2020-05-18 Thread Nick Desaulniers
On Sun, May 17, 2020 at 8:29 AM Brian Gerst wrote: > > The core percpu macros already have a switch on the data size, so the switch > in the x86 code is redundant and produces more dead code. > > Also use appropriate types for the width of the instructions. This avoids > errors when compiling

Re: [PATCH v2 1/2] arm64: dts: rockchip: fix defines in pd_vio node for rk3399

2020-05-18 Thread Heiko Stuebner
On Tue, 28 Apr 2020 22:30:02 +0200, Johan Jonker wrote: > A test with the command below gives for example this error: > > arch/arm64/boot/dts/rockchip/rk3399-evb.dt.yaml: pd_vio@15: > 'pd_tcpc0@RK3399_PD_TCPC0', 'pd_tcpc1@RK3399_PD_TCPC1' > do not match any of the regexes: > '.*-names$',

Re: [PATCH] arm64: dts: rockchip: remove disable-wp from rk3308-roc-cc emmc node

2020-05-18 Thread Heiko Stuebner
On Thu, 19 Dec 2019 13:19:54 +0100, Johan Jonker wrote: > The mmc-controller.yaml didn't explicitly say disable-wp is > for SD card slot only, but that is what it was designed for > in the first place. > Remove all disable-wp from emmc or sdio controllers. Applied, thanks! [1/1] arm64: dts:

Re: [PATCH v1 1/2] ARM: dts: rockchip: rename and label gpio-led subnodes

2020-05-18 Thread Heiko Stuebner
On Tue, 28 Apr 2020 16:49:32 +0200, Johan Jonker wrote: > Current dts files with 'gpio-led' nodes were manually verified. > In order to automate this process leds-gpio.txt > has been converted to yaml. With this conversion a check > for pattern properties was added. A test with the command > below

Re: [PATCH 1/3] arm64: dts: rockchip: replace RK_FUNC defines in rk3326-odroid-go2.dts

2020-05-18 Thread Heiko Stuebner
On Tue, 12 May 2020 22:35:22 +0200, Johan Jonker wrote: > The defines RK_FUNC_1 and RK_FUNC_2 are deprecated, > so replace them with the preferred form. > Restyle properties in the same line. Applied, thanks! [1/2] arm64: dts: rockchip: replace RK_FUNC defines in rk3326-odroid-go2 commit:

Re: [PATCH v3 1/4] ARM: dts: rockchip: remove identical #include from rk3288.dtsi

2020-05-18 Thread Heiko Stuebner
On Fri, 3 Apr 2020 20:01:56 +0200, Johan Jonker wrote: > There are 2 identical '#include' for 'rk3288-power.h', > so remove one of them. Applied, thanks! [1/1] ARM: dts: rockchip: remove identical #include from rk3288.dtsi Best regards, -- Heiko Stuebner

Re: [PATCH 1/6] arm64: dts: rockchip: fix phy nodename for rk3328

2020-05-18 Thread Heiko Stuebner
On Sat, 21 Mar 2020 22:54:18 +0100, Johan Jonker wrote: > A test with the command below gives for example this error: > > arch/arm64/boot/dts/rockchip/rk3328-evb.dt.yaml: phy@0: > '#phy-cells' is a required property > > The phy nodename is used by a phy-handle. > The parent node is compatible

Re: [PATCH v2] arm64: dts: rockchip: fix phy nodename for rk3328

2020-05-18 Thread Heiko Stuebner
On Tue, 5 May 2020 19:02:27 +0200, Johan Jonker wrote: > A test with the command below gives for example this error: > > arch/arm64/boot/dts/rockchip/rk3328-evb.dt.yaml: phy@0: > '#phy-cells' is a required property > > The phy nodename is normally used by a phy-handle. > This node is however

Re: [PATCH] x86/uv/time: Replace one-element array and save heap space

2020-05-18 Thread Gustavo A. R. Silva
On Mon, May 18, 2020 at 12:09:16PM -0700, Joe Perches wrote: > On Mon, 2020-05-18 at 14:01 -0500, Gustavo A. R. Silva wrote: > > The current codebase makes use of one-element arrays in the following > > form: > > > > struct something { > > int length; > > u8 data[1]; > > }; > [] > > This

<    1   2   3   4   5   6   7   8   9   10   >