Re: [PATCH] media: exynos4-is: Fix runtime PM imbalance in isp_video_open()

2020-05-31 Thread Markus Elfring
> pm_runtime_get_sync() increments the runtime PM usage counter even > when it returns an error code. Thus a pairing decrement is needed on > the error handling path to keep the counter balanced. How do you think about a wording variant like the following? Change description: The PM

[PATCH] staging:r8723bs: remove wrappers around skb_clone()

2020-05-31 Thread Ivan Safonov
Wrappers around skb_clone() do not simplify the driver code. Signed-off-by: Ivan Safonov --- drivers/staging/rtl8723bs/include/osdep_service.h | 3 --- drivers/staging/rtl8723bs/os_dep/osdep_service.c | 5 - drivers/staging/rtl8723bs/os_dep/recv_linux.c | 2 +- 3 files changed, 1

Re: [PATCH v2 3/4] iio: chemical: scd30: add serial interface driver

2020-05-31 Thread Tomasz Duszynski
On Sun, May 31, 2020 at 11:15:18AM +0100, Jonathan Cameron wrote: > On Sat, 30 May 2020 23:36:29 +0200 > Tomasz Duszynski wrote: > > > Add serial interface driver for the SCD30 sensor. > > > > Signed-off-by: Tomasz Duszynski > > Ah Now I see why you had those extra elements in the iio_priv >

Re: [RFC PATCH v4 00/13] riscv: Add vector ISA support

2020-05-31 Thread Guo Ren
Hi Greentime & Vincent, Thx for the dynamic vlen implementation. I've two suggestions: - Please give out glibc patches mail URL, we need to review them together. - We need to consider that not all processes need vectors. Most system processes do not have vector features, and we should not force

Re: [PATCH v2 4/4] dt-bindings: iio: scd30: add device binding file

2020-05-31 Thread Tomasz Duszynski
On Sun, May 31, 2020 at 11:19:14AM +0100, Jonathan Cameron wrote: > On Sat, 30 May 2020 23:36:30 +0200 > Tomasz Duszynski wrote: > > > Add SCD30 sensor binding file. > > > > Signed-off-by: Tomasz Duszynski > > --- > > .../iio/chemical/sensirion,scd30.yaml | 68 +++ > >

Re: [PATCH v2 3/3] iio: remove iio_triggered_buffer_postenable()/iio_triggered_buffer_predisable()

2020-05-31 Thread Jonathan Cameron
On Mon, 25 May 2020 14:38:55 +0300 Alexandru Ardelean wrote: > From: Lars-Peter Clausen > > This patch should be squashed into the first one, as the first one is > breaking the build (intentionally) to make the IIO core files easier to > review. > > Signed-off-by: Lars-Peter Clausen >

[RFC PATCH -rcu lkmm] tools/memory-model/README: Expand dependency of klitmus7

2020-05-31 Thread Akira Yokosawa
>From 87048d7212f6cb16b0a2b85fa6d2f34c28b078c0 Mon Sep 17 00:00:00 2001 From: Akira Yokosawa Date: Sun, 31 May 2020 20:04:32 +0900 Subject: [PATCH RFC] tools/memory-model/README: Expand dependency of klitmus7 klitmus7 is independent of the memory model but depends on the build-target kernel

Re: [PATCH 1/2] arm64: dts: Add a device tree for the Librem5 phone

2020-05-31 Thread Guido Günther
Hi, On Fri, May 29, 2020 at 06:28:50PM +0200, Pavel Machek wrote: > Hi! > > > From: "Angus Ainslie (Purism)" > > > > Add a devicetree description for the Librem 5 phone. The early batches > > that have been sold are supported as well as the mass-produced device > > available later this year,

Re: [RFC PATCH v4 10/13] riscv: Add task switch support for vector

2020-05-31 Thread Guo Ren
Hi Greentime, On Tue, May 26, 2020 at 3:03 PM Greentime Hu wrote: > > From: Guo Ren > > This patch adds task switch support for vector. It supports lazy > save and restore mechanism. It also supports all lengths of vlen. > > [greentime...@sifive.com: add support for dynamic vlen, fix >

Re: [RFC PATCH v4 12/13] riscv: Add sigcontext save/restore for vector

2020-05-31 Thread Guo Ren
Hi Greentime, On Tue, May 26, 2020 at 3:03 PM Greentime Hu wrote: > > From: Guo Ren > > This patch adds sigcontext save/restore for vector. The vector registers > will be saved in datap pointer. The datap pointer will be allocaed > dynamically when the task needs in kernel space. The datap

Re: [RFC PATCH 08/14] iio: core: use new common ioctl() mechanism

2020-05-31 Thread Jonathan Cameron
On Mon, 25 May 2020 07:27:43 + "Ardelean, Alexandru" wrote: > On Sun, 2020-05-24 at 17:47 +0100, Jonathan Cameron wrote: > > [External] > > > > On Fri, 8 May 2020 16:53:42 +0300 > > Alexandru Ardelean wrote: > > > > > This change makes use of the new centralized ioctl() mechanism. The

Re: [RFC PATCH 09/14] iio: buffer: split buffer sysfs creation to take buffer as primary arg

2020-05-31 Thread Jonathan Cameron
On Mon, 25 May 2020 07:28:18 + "Ardelean, Alexandru" wrote: > On Sun, 2020-05-24 at 17:49 +0100, Jonathan Cameron wrote: > > [External] > > > > On Fri, 8 May 2020 16:53:43 +0300 > > Alexandru Ardelean wrote: > > > > > Currently the iio_buffer_{alloc,free}_sysfs_and_mask() take

Re: [PATCH v2 0/4] Introduce the Counter character device interface

2020-05-31 Thread Jonathan Cameron
On Sun, 24 May 2020 13:54:39 -0400 William Breathitt Gray wrote: > On Sun, May 24, 2020 at 05:25:42PM +0100, Jonathan Cameron wrote: > > > > ... > > > > > The following are some questions I have about this patchset: > > > > > > 1. Should the data format of the character device be configured

Re: [PATCH] usb: common: usb-conn-gpio: Register optional charger

2020-05-31 Thread Paul Cercueil
Hi, Any feedback on this patch? Cheers, -Paul Le lun. 13 avril 2020 à 14:25, Paul Cercueil a écrit : Register a power supply charger, if the Kconfig option USB_CONN_GPIO_CHARGER is set, whose online state depends on whether the USB role is set to device or not. This is useful when the USB

Re: [PATCH v4 3/4] scsi: ufs: cleanup ufs initialization path

2020-05-31 Thread Bean Huo
On Sat, 2020-05-30 at 06:37 +, Avri Altman wrote: > > + /* Get the length of descriptor */ > > + ufshcd_map_desc_id_to_length(hba, desc_id, _len); > > + if (!buff_len) { > > + dev_err(hba->dev, "%s: Failed to get desc length", > > __func__); > > +

[PATCH v4 4/5] scsi: ufs: cleanup ufs initialization path

2020-05-31 Thread Bean Huo
From: Bean Huo At UFS initialization stage, to get the length of the descriptor, ufshcd_read_desc_length() being called 6 times. Instead, we will capture the descriptor size the first time we'll read it. Delete unnecessary redundant code, remove ufshcd_read_desc_length(),

[PATCH v4 5/5] scsi: ufs: add compatibility with 3.1 UFS unit descriptor length

2020-05-31 Thread Bean Huo
From: Bean Huo For UFS 3.1, the normal unit descriptor is 10 bytes larger than the RPMB unit, however, both descriptors share the same desc_idn, to cover both unit descriptors with one length, we choose the normal unit descriptor length by desc_index. Signed-off-by: Bean Huo Reviewed-by: Avri

[PATCH v4 3/5] scsi: ufs: fix potential access NULL pointer while memcpy

2020-05-31 Thread Bean Huo
From: Bean Huo If param_offset is not 0, the memcpy length shouldn't be the true descriptor length. Fixes: a4b0e8a4e92b ("scsi: ufs: Factor out ufshcd_read_desc_param") Signed-off-by: Bean Huo --- drivers/scsi/ufs/ufshcd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH v4 0/5] scsi: ufs: cleanup ufs initialization

2020-05-31 Thread Bean Huo
From: Bean Huo Cleanup UFS descriptor length initialization, and delete some unnecessary code. Changelog: v3 - v4: 1. add desc_id >= QUERY_DESC_IDN_MAX check in patch 4/5 (Avri Altman) 2. update buff_len to hold the true descriptor size in 4/5 (Avri Altman) 3. add new patch 3/5 v2

[PATCH v4 2/5] scsi: ufs: delete ufshcd_read_desc()

2020-05-31 Thread Bean Huo
From: Bean Huo Delete ufshcd_read_desc(). Instead, let caller directly call ufshcd_read_desc_param(). Signed-off-by: Bean Huo Reviewed-by: Avri Altman Reviewed-by: Bart van Assche Reviewed-by: Stanley Chu --- drivers/scsi/ufs/ufshcd.c | 27 --- 1 file changed, 8

[PATCH v4 1/5] scsi: ufs: remove max_t in ufs_get_device_desc

2020-05-31 Thread Bean Huo
From: Bean Huo For the UFS device, the maximum descriptor size is 255, max_t called in ufs_get_device_desc() is useless. Signed-off-by: Bart van Assche Signed-off-by: Bean Huo Acked-by: Avri Altman Reviewed-by: Stanley Chu --- drivers/scsi/ufs/ufshcd.c | 5 + 1 file changed, 1

[PATCH] platform/x86: touchscreen_dmi: Update Trekstor Twin 10.1 entry

2020-05-31 Thread Hans de Goede
Add minimum values for the x and y axis, correct the max value for the x-axis and add support for the capacitive home-button these tablets have. Signed-off-by: Hans de Goede --- drivers/platform/x86/touchscreen_dmi.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git

Re: [PATCH v2] power: supply: bq24190_charger: Fix runtime PM imbalance in bq24190_sysfs_store()

2020-05-31 Thread Markus Elfring
> pm_runtime_get_sync() increments the runtime PM usage counter even > it returns an error code. Thus a pairing decrement is needed on > the error handling path to keep the counter balanced. How do you think about a wording variant like the following? Change description: The PM runtime

Re: [PATCH 4/5] iio: light: lm3533-als: remove explicit parent assignment

2020-05-31 Thread Jonathan Cameron
On Fri, 29 May 2020 15:45:33 +0200 Johan Hovold wrote: > [ Trimming CC to something more reasonable... ] > > On Fri, May 29, 2020 at 11:08:38AM +, Ardelean, Alexandru wrote: > > On Fri, 2020-05-29 at 12:16 +0200, Johan Hovold wrote: > > > On Fri, May 22, 2020 at 11:22:07AM +0300,

Re: [PATCH v3] iio: stm32-adc: remove usage of iio_priv_to_dev() helper

2020-05-31 Thread Jonathan Cameron
On Tue, 26 May 2020 17:46:41 +0200 Fabrice Gasnier wrote: > On 5/26/20 3:44 PM, Alexandru Ardelean wrote: > > We may want to get rid of the iio_priv_to_dev() helper. The reason is that > > we will hide some of the members of the iio_dev structure (to prevent > > drivers from accessing them

Re: [PATCH v2] iio: stm32-dfsdm-adc: remove usage of iio_priv_to_dev() helper

2020-05-31 Thread Jonathan Cameron
On Mon, 25 May 2020 11:26:48 +0300 Alexandru Ardelean wrote: > We may want to get rid of the iio_priv_to_dev() helper. The reason is that > we will hide some of the members of the iio_dev structure (to prevent > drivers from accessing them directly), and that will also mean hiding the >

Re: [PATCH] iio: at91_adc: remove usage of iio_priv_to_dev() helper

2020-05-31 Thread Jonathan Cameron
On Mon, 25 May 2020 13:25:13 +0300 Alexandru Ardelean wrote: > We may want to get rid of the iio_priv_to_dev() helper. The reason is that > we will hide some of the members of the iio_dev structure (to prevent > drivers from accessing them directly), and that will also mean hiding the >

Re: [PATCH] iio: Kconfig: at91_adc: add COMPILE_TEST dependency to driver

2020-05-31 Thread Jonathan Cameron
On Mon, 25 May 2020 13:27:44 +0300 Alexandru Ardelean wrote: > Since changes can come from all sort of places, it may make sense to have > this symbol as a dependency to make sure that the 'make allmodconfig' && > 'make allyesconfig' build rules cover this driver as well for a >

Re: [PATCH] iio: at91-sama5d2_adc: remove usage of iio_priv_to_dev() helper

2020-05-31 Thread Jonathan Cameron
On Mon, 25 May 2020 13:53:41 +0300 Alexandru Ardelean wrote: > We may want to get rid of the iio_priv_to_dev() helper. The reason is that > we will hide some of the members of the iio_dev structure (to prevent > drivers from accessing them directly), and that will also mean hiding the >

Re: [PATCH] iio: dac: ad5592r: remove usage of iio_priv_to_dev() helper

2020-05-31 Thread Jonathan Cameron
On Mon, 25 May 2020 16:10:34 +0300 Alexandru Ardelean wrote: > This was partially removed when the mlock cleanup was done. Only one more > call is left in the ad5592r_alloc_channels() function. > This one is simple. We just need to pass the iio_dev object and get the > state via iio_priv(). > >

Re: [PATCH] perf libdw: Fix off-by 1 relative directory includes

2020-05-31 Thread Namhyung Kim
Hi Ian, On Sat, May 30, 2020 at 7:53 AM Ian Rogers wrote: > > This is currently working due to extra include paths in the build. > > Before: > $ cd tools/perf/arch/arm64/util > $ ls -la ../../util/unwind-libdw.h > ls: cannot access '../../util/unwind-libdw.h': No such file or directory > >

Re: [PATCH v4 4/5] iio: imu: bmi160: added regulator support

2020-05-31 Thread Jonathan Cameron
On Mon, 25 May 2020 18:46:03 +0200 Jonathan Albrieux wrote: > Add vdd-supply and vddio-supply support. > > While working on an msm8916 device and having explicit declarations for > regulators, without setting these regulators to regulators-always-on it > happened those lines weren't ready

Re: [PATCH v4 3/5] iio: imu: bmi160: fix typo

2020-05-31 Thread Jonathan Cameron
On Mon, 25 May 2020 18:46:02 +0200 Jonathan Albrieux wrote: > Fix a typo in MODULE_AUTHOR() argument. > > Signed-off-by: Jonathan Albrieux applied Thanks, J > --- > drivers/iio/imu/bmi160/bmi160_core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Re: [PATCH 01/27] vfs, afs, ext4: Make the inode hash table RCU searchable

2020-05-31 Thread David Howells
Al Viro wrote: > > + * The @test function is not permitted to take a ref on any inode presented > > + * unless the caller is holding the inode hashtable lock. It is also not > > + * permitted to sleep, since it may be called with the RCU read lock held. > > + * > > + * The caller must hold

Re: [PATCH v2] iio: magnetometer: ak8974: Fix runtime PM imbalance on error in ak8974_probe()

2020-05-31 Thread Markus Elfring
> When devm_regmap_init_i2c() returns an error code, a pairing > runtime PM usage counter decrement is needed to keep the > counter balanced. How do you think about to replace the word “pairing” by “corresponding”? > For error paths after ak8974_set_power(), > ak8974_detect() and

Re: [PATCH v4 2/5] dt-bindings: iio: imu: bmi160: add regulators and mount-matrix

2020-05-31 Thread Jonathan Cameron
On Fri, 29 May 2020 11:09:43 -0600 Rob Herring wrote: > On Mon, May 25, 2020 at 06:46:01PM +0200, Jonathan Albrieux wrote: > > Add vdd-supply and vddio-supply support. > > Add mount-matrix support. > > > > Signed-off-by: Jonathan Albrieux > > --- > > .../bindings/iio/imu/bosch,bmi160.yaml

Re: [PATCH v4 1/5] dt-bindings: iio: imu: bmi160: convert format to yaml, add maintainer

2020-05-31 Thread Jonathan Cameron
On Fri, 29 May 2020 11:08:34 -0600 Rob Herring wrote: > On Mon, 25 May 2020 18:46:00 +0200, Jonathan Albrieux wrote: > > Converts documentation from txt format to yaml. > > > > Signed-off-by: Jonathan Albrieux > > --- > > .../devicetree/bindings/iio/imu/bmi160.txt| 37 - > >

Re: [PATCH] [v2] iio: magnetometer: ak8974: Fix runtime PM imbalance on error

2020-05-31 Thread Jonathan Cameron
On Tue, 26 May 2020 13:13:56 +0200 Linus Walleij wrote: > On Tue, May 26, 2020 at 12:47 PM Dinghao Liu wrote: > > > When devm_regmap_init_i2c() returns an error code, a pairing > > runtime PM usage counter decrement is needed to keep the > > counter balanced. For error paths after

[GIT pull] x86/urgent for

2020-05-31 Thread Thomas Gleixner
Linus, please pull the latest x86/urgent branch from: git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git x86-urgent-2020-05-31 up to: aa61b7bb00f7: Merge branch 'fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs into x86/urgent A pile of x86 fixes: - Prevent a

[GIT pull] sched/urgent for v5.7

2020-05-31 Thread Thomas Gleixner
Linus, please pull the latest sched/urgent branch from: git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git sched-urgent-2020-05-31 up to: 18f855e574d9: sched/fair: Don't NUMA balance for kthreads A single scheduler fix preventing a crash in NUMA balancing. The current->mm check is

Re: [GIT PULL] Immutable branch between MFD, IIO and Power due for the v5.8 merge window

2020-05-31 Thread Jonathan Cameron
On Thu, 28 May 2020 09:09:39 +0200 Sebastian Reichel wrote: > Hi, > > Thanks for taking care of it Lee, merged! Thanks indeed. Given timing I'll probably only get this into IIO via a rebase after rc1. Thanks, Jonathan > > -- Sebastian > > On Tue, May 26, 2020 at 10:47:02AM +0100, Lee

Re: [PATCH] iio: cros_ec: Reapply range at resume

2020-05-31 Thread Jonathan Cameron
On Tue, 26 May 2020 21:35:17 -0700 Gwendal Grignou wrote: > EC does not currently preserve range across sensor reinit. > If sensor is powered down at suspend, it will default to the EC default > range at resume, not the range set by the host. > > Save range if modified, and apply at resume. >

Re: [PATCH] iio: accel: mxc4005: add support for mxc6655

2020-05-31 Thread Jonathan Cameron
On Sun, 31 May 2020 15:16:00 +0200 Christian Oder wrote: > Hi Jonathan, > > I tested the sensor on a Chuwi Hi10 X and only went by what I've seen in other > commits before[1]. > > I just ran another test to see what entry is necessary and it appears the > sensor > still works when removing

Re: [PATCH 5/6] iio: light: stk3310: Constify regmap_config

2020-05-31 Thread Jonathan Cameron
On Tue, 26 May 2020 23:02:22 +0200 Rikard Falkeborn wrote: > stk3310_regmap_config is not modified and can be made const to allow the > compiler to put it in read-only memory. > > Before: >textdata bss dec hex filename > 160275424 128 21579544b

Re: [PATCH 6/6] iio: magnetometer: mmc35240: Constify struct reg_default

2020-05-31 Thread Jonathan Cameron
On Tue, 26 May 2020 23:02:23 +0200 Rikard Falkeborn wrote: > mmc35240_reg_defaults is not modified and can be made const to allow the > compiler to put it in read-only memory. > > Before: >textdata bss dec hex filename >97593288 128 131753377

Re: [PATCH 3/6] iio: dac: ad5592r-base: Constify struct iio_chan_spec_ext_info

2020-05-31 Thread Jonathan Cameron
On Wed, 27 May 2020 04:22:46 + "Ardelean, Alexandru" wrote: > On Tue, 2020-05-26 at 23:02 +0200, Rikard Falkeborn wrote: > > [External] > > > > ad5592r_ext_info is not modified and can be made const to allow the > > compiler to put it in read-only memory. > > > > Before: > >text

Re: [PATCH 4/6] iio: dac: ad5686: Constify static struct iio_chan_spec

2020-05-31 Thread Jonathan Cameron
On Wed, 27 May 2020 04:50:46 + "Ardelean, Alexandru" wrote: > On Tue, 2020-05-26 at 23:02 +0200, Rikard Falkeborn wrote: > > [External] > > > > These are never modified and can be made const to allow the compiler to > > put it in read-only memory. > > > > Before: > >textdata

RE: [PATCH v2 1/5] scsi: ufs-mediatek: Fix imprecise waiting time for ref-clk control

2020-05-31 Thread Stanley Chu
Hi Avri, On Sun, 2020-05-31 at 07:10 +, Avri Altman wrote: > > > > Currently ref-clk control timeout is implemented by Jiffies. However > > jiffies is not accurate enough thus "false timeout" may happen. > > > > Use more accurate delay mechanism instead, for example, ktime. > > > >

Re: [PATCH 2/6] iio: dac: ad5380: Constify struct iio_chan_spec_ext_info

2020-05-31 Thread Jonathan Cameron
On Wed, 27 May 2020 04:22:30 + "Ardelean, Alexandru" wrote: > On Tue, 2020-05-26 at 23:02 +0200, Rikard Falkeborn wrote: > > [External] > > > > ad5380_ext_info is not modified and can be made const to allow the > > compiler to put it in read-only memory. > > > > Before: > >textdata

Re: [PATCH v2 2/3] media: rockchip: Introduce driver for Rockhip's camera interface

2020-05-31 Thread Ezequiel Garcia
Hi Maxime, Thanks for posting this patch. I think you can still improve it, but it's a neat first try! :-) On Fri, 29 May 2020 at 10:05, Maxime Chevallier wrote: > > Introduce a driver for the camera interface on some Rockchip platforms. > > This controller supports CSI2, Parallel and BT656

Re: [PATCH v2 4/4] docs: counter: Document character device interface

2020-05-31 Thread William Breathitt Gray
On Fri, May 29, 2020 at 03:26:04PM +0200, Pavel Machek wrote: > On Sat 2020-05-16 15:20:02, William Breathitt Gray wrote: > > This patch adds high-level documentation about the Counter subsystem > > character device interface. > > > > Signed-off-by: William Breathitt Gray > > --- > >

Re: [PATCH] iio: accel: mxc4005: add support for mxc6655

2020-05-31 Thread Christian Oder
Hi Jonathan, I tested the sensor on a Chuwi Hi10 X and only went by what I've seen in other commits before[1]. I just ran another test to see what entry is necessary and it appears the sensor still works when removing the i2c entry, but is not working anymore when removing the ACPI match. I got

[PATCH] drm/vkms: Optimize compute_crc(), blend()

2020-05-31 Thread Sidong Yang
Optimize looping pixels in compute_crc() and blend(). Calculate src_offset in start of looping horizontally and increase it. It's better than calculating in every pixels. Cc: Rodrigo Siqueira Cc: David Airlie Cc: dri-de...@lists.freedesktop.org Cc: linux-kernel@vger.kernel.org Signed-off-by:

Re: [PATCH 01/27] vfs, afs, ext4: Make the inode hash table RCU searchable

2020-05-31 Thread Al Viro
On Fri, May 29, 2020 at 11:00:07PM +0100, David Howells wrote: > @@ -1245,15 +1282,9 @@ static int test_inode_iunique(struct super_block *sb, > unsigned long ino) > struct inode *inode; > > spin_lock(_hash_lock); > - hlist_for_each_entry(inode, b, i_hash) { > - if

Re: [PATCH 1/6] iio: adc: max11100: Constify struct iio_chan_spec

2020-05-31 Thread Jonathan Cameron
On Tue, 26 May 2020 23:02:18 +0200 Rikard Falkeborn wrote: > max11100_channels is not modified and can therefore be made const to > allow the compiler to put it in read-only memory. > > Before: >textdata bss dec hex filename >37761168 049441350

Re: [PATCH v2 10/12] iio: imu: inv_icm42600: add accurate timestamping

2020-05-31 Thread Jonathan Cameron
On Wed, 27 May 2020 20:57:09 +0200 Jean-Baptiste Maneyrol wrote: > Add a timestamping mechanism for buffer that provides accurate > event timestamps when using watermark. This mechanism estimates > device internal clock by comparing FIFO interrupts delta time and > device elapsed time computed

Re: [PATCH 1/2] mm/gup: introduce pin_user_pages_locked()

2020-05-31 Thread Pankaj Gupta
Acked-by: Pankaj Gupta On Thu, 28 May 2020 at 00:32, John Hubbard wrote: > > Introduce pin_user_pages_locked(), which is nearly identical to > get_user_pages_locked() except that it sets FOLL_PIN and rejects > FOLL_GET. > > Signed-off-by: John Hubbard > --- > include/linux/mm.h | 2 ++ >

Re: [PATCH] mm/gup: documentation fix for pin_user_pages*() APIs

2020-05-31 Thread Pankaj Gupta
Acked-by: Pankaj Gupta

Re: [PATCH RFC] seccomp: Implement syscall isolation based on memory areas

2020-05-31 Thread Paul Gofman
On 5/31/20 03:59, Andy Lutomirski wrote: > > I’m suggesting that the kernel learn how to help you, maybe like this: > > prctl(PR_SET_SYSCALL_THUNK, target, address_of_unredirected_syscall, 0, 0, 0, > 0); > > This would be inherited on clone/fork and cleared on execve. > If we are talking about

Re: [PATCH v2 09/12] iio: imu: inv_icm42600: add buffer support in iio devices

2020-05-31 Thread Jonathan Cameron
On Wed, 27 May 2020 20:57:08 +0200 Jean-Baptiste Maneyrol wrote: > Add all FIFO parsing and reading functions. Add accel and gyro > kfifo buffer and FIFO data parsing. Use device interrupt for > reading data FIFO and launching accel and gyro parsing. > > Support hwfifo watermark by multiplexing

Re: [PATCH] lib: make a test module with get_count_order/long

2020-05-31 Thread Wei Yang
On Sun, May 31, 2020 at 12:56:29AM +0300, Andy Shevchenko wrote: >On Sun, May 31, 2020 at 12:23 AM Wei Yang wrote: >> On Sat, May 30, 2020 at 01:25:31PM +0300, Andy Shevchenko wrote: >> >On Sat, May 30, 2020 at 12:43:28AM +, Wei Yang wrote: >> >> A test module to make sure

Re: [PATCH RFCv2 9/9] arm64: Support async page fault

2020-05-31 Thread Marc Zyngier
On 2020-05-29 12:11, Paolo Bonzini wrote: On 29/05/20 11:41, Marc Zyngier wrote: For x86 the advantage is that the processor can take care of raising the stage2 page fault in the guest, so it's faster. I think there might be too much overhead if the page can be populated quickly by host.

Re: [PATCH RFC] seccomp: Implement syscall isolation based on memory areas

2020-05-31 Thread Paul Gofman
Hi! thanks for looking into this. On 5/31/20 08:56, Gabriel Krisman Bertazi wrote: > >> Is it possible to disassemble and instrument the Windows code to insert >> breakpoints (or emulation calls) at all the Windows syscall points? > Hi Kees, > > I considered instrumenting the syscall

Re: [PATCH] MIPS: ralink: bootrom: mark a function as __init to save some memory

2020-05-31 Thread Thomas Bogendoerfer
On Sun, May 31, 2020 at 12:06:03PM +0200, Christophe JAILLET wrote: > 'bootrom_setup()' is only called via 'postcore_initcall'. > It can be marked as __init to save a few bytes of memory. > > Signed-off-by: Christophe JAILLET > --- > arch/mips/ralink/bootrom.c | 2 +- > 1 file changed, 1

Re: [PATCH] MIPS: ralink: drop ralink_clk_init for mt7621

2020-05-31 Thread Thomas Bogendoerfer
On Sat, Mar 28, 2020 at 12:14:57PM +0800, Chuanhong Guo wrote: > ralink_clk_init is only called in arch/mips/ralink/clk.c which isn't > compiled for mt7621. And it doesn't export a proper cpu clock. > Drop this unused function. > > Signed-off-by: Chuanhong Guo > --- > arch/mips/ralink/mt7621.c

Re: [PATCH v8 0/3] perf arm-spe: Add support for synthetic events

2020-05-31 Thread Arnaldo Carvalho de Melo
Em Sat, May 30, 2020 at 08:24:39PM +0800, Leo Yan escreveu: > This patch set is to support synthetic events with enabling Arm SPE > decoder. This patch set is based Xiaojun Tan (Hisilicon) and > James Clark (Arm)'s previous patches who have contributed much for > the related task. Applied, will

Re: [PATCH 0/3] perf test: Unwind fixes

2020-05-31 Thread Arnaldo Carvalho de Melo
Em Sat, May 30, 2020 at 01:20:12AM -0700, Ian Rogers escreveu: > Fix stack frame count and memory sanitizer issues when running the > dwarf unwinding test with the elfutils/libdw unwinder (libunwind > disabled). Thanks, applied. > Ian Rogers (3): > tools compiler.h: Add attribute to disable

Re: [PATCH v2 08/12] iio: imu: inv_icm42600: add device interrupt

2020-05-31 Thread Jonathan Cameron
On Wed, 27 May 2020 20:57:07 +0200 Jean-Baptiste Maneyrol wrote: > Add INT1 interrupt support. Support interrupt edge and level, > active high or low. Push-pull or open-drain configurations. > > Interrupt will be used to read data from the FIFO. > > Signed-off-by: Jean-Baptiste Maneyrol Some

Re: next-20200515: Xorg killed due to "OOM"

2020-05-31 Thread Pavel Machek
On Thu 2020-05-28 14:07:50, Michal Hocko wrote: > On Thu 28-05-20 14:03:54, Pavel Machek wrote: > > On Thu 2020-05-28 11:05:17, Michal Hocko wrote: > > > On Tue 26-05-20 11:10:54, Pavel Machek wrote: > > > [...] > > > > [38617.276517] oom_reaper: reaped process 31769 (chromium), now > > > >

Re: drm/nouveau/clk/gm20b: Fix memory leaks after failed gk20a_clk_ctor() calls

2020-05-31 Thread Markus Elfring
> In this case, maybe we should check the return value of > gk20a_clk_ctor() and release clk if it returns -ENOMEM. All error situations (including failed memory allocations) can matter here. > And many other functions also have the same issue > (e.g. gm20b_clk_new_speedo0). I recommend to

Re: [PATCH v2 04/12] iio: imu: inv_icm42600: add gyroscope IIO device

2020-05-31 Thread Jonathan Cameron
On Wed, 27 May 2020 20:57:03 +0200 Jean-Baptiste Maneyrol wrote: > Add IIO device for gyroscope sensor with data polling interface. > Attributes: raw, scale, sampling_frequency, calibbias. > > Gyroscope in low noise mode. > > Signed-off-by: Jean-Baptiste Maneyrol Unusual to have a

[PATCH v3 1/4] seccomp: rename "usage" to "refs" and document

2020-05-31 Thread Christian Brauner
Naming the lifetime counter of a seccomp filter "usage" suggests a little too strongly that its about tasks that are using this filter while it also tracks other references such as the user notifier or ptrace. This also updates the documentation to note this fact. We'll be introducing an actual

[PATCH v3 4/4] tests: test seccomp filter notifications

2020-05-31 Thread Christian Brauner
This verifies we're correctly notified when a seccomp filter becomes unused when a notifier is in use. Signed-off-by: Christian Brauner --- /* v2 */ unchanged /* v3 */ At first it seemed sensible to add POLLHUP to all poll invocations but all checks test for revents to be equal to POLLIN.

[PATCH v3 2/4] seccomp: release filter after task is fully dead

2020-05-31 Thread Christian Brauner
The seccomp filter used to be released in free_task() which is called asynchronously via call_rcu() and assorted mechanisms. Since we need to inform tasks waiting on the seccomp notifier when a filter goes empty we will notify them as soon as a task has been marked fully dead in release_task(). To

[PATCH v3 3/4] seccomp: notify about unused filter

2020-05-31 Thread Christian Brauner
We've been making heavy use of the seccomp notifier to intercept and handle certain syscalls for containers. This patch allows a syscall supervisor listening on a given notifier to be notified when a seccomp filter has become unused. A container is often managed by a singleton supervisor process

Re: [PATCH v2 02/12] iio: imu: inv_icm42600: add I2C driver for inv_icm42600 driver

2020-05-31 Thread Jonathan Cameron
On Wed, 27 May 2020 20:57:01 +0200 Jean-Baptiste Maneyrol wrote: > Add I2C driver for InvenSense ICM-426xxx devices. > > Configure bus signal slew rates as indicated in the datasheet. > > Signed-off-by: Jean-Baptiste Maneyrol Looks fine to me. J > --- >

Re: [PATCH 5.6 086/126] virtio-balloon: Revert "virtio-balloon: Switch back to OOM handler for VIRTIO_BALLOON_F_DEFLATE_ON_OOM"

2020-05-31 Thread Greg Kroah-Hartman
On Sun, May 31, 2020 at 05:18:06AM -0400, Michael S. Tsirkin wrote: > On Tue, May 26, 2020 at 08:53:43PM +0200, Greg Kroah-Hartman wrote: > > From: Michael S. Tsirkin > > > > [ Upstream commit 835a6a649d0dd1b1f46759eb60fff2f63ed253a7 ] > > > > This reverts commit

Re: [PATCH v2 01/12] iio: imu: inv_icm42600: add core of new inv_icm42600 driver

2020-05-31 Thread Jonathan Cameron
On Wed, 27 May 2020 20:57:00 +0200 Jean-Baptiste Maneyrol wrote: > Core component of a new driver for InvenSense ICM-426xx devices. > It includes registers definition, main probe/setup, and device > utility functions. > > ICM-426xx devices are latest generation of 6-axis IMU, >

Re: [PATCH v2] iio: mma8452: Add missed iio_device_unregister() call in mma8452_probe()

2020-05-31 Thread Jonathan Cameron
On Thu, 28 May 2020 14:41:21 +0800 Chuhong Yuan wrote: > The function iio_device_register() was called in mma8452_probe(). > But the function iio_device_unregister() was not called after > a call of the function mma8452_set_freefall_mode() failed. > Thus add the missed function call for one

[tip:x86/entry 2/19] include/xen/interface/hvm/hvm_op.h:33:28: error: a parameter list without types is only allowed in a function definition

2020-05-31 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git x86/entry head: 5980d208e5ef28455e9e8b08f6250b443a2f0893 commit: 28447ea4154239025044381144f849ff749ee9ef [2/19] xen: Move xen_setup_callback_vector() definition to include/xen/hvm.h config: x86_64-randconfig-r036-20200531

Re: [PATCH] irqchip/gic-v3-its: Don't try to move a disabled irq

2020-05-31 Thread Marc Zyngier
On 2020-05-30 17:49, Marc Zyngier wrote: Hi Ali, On Fri, 29 May 2020 12:36:42 + "Saidi, Ali" wrote: Hi Marc, > On May 29, 2020, at 3:33 AM, Marc Zyngier wrote: > > Hi Ali, > >> On 2020-05-29 02:55, Ali Saidi wrote: >> If an interrupt is disabled the ITS driver has sent a discard

[PATCH] arm: allwinner: a20: Add Drejo DS167 initial support

2020-05-31 Thread stulluk
From: Sertac TULLUK Drejo DS167 is an Allwinner A20 based IoT device, which support - Allwinner A20 Cortex-A7 - Mali-400MP2 GPU - AXP209 PMIC - 1GB DDR3 RAM - 8GB eMMC - 10/100M Ethernet - SATA - HDMI - 10.1inch and 7.0inch LVDS LCD and Touch screens - CSI: OV5640 sensor - USB OTG - 2x USB2.0 -

Re: [PATCH v7 5/5] iio: magnetometer: ak8975: Add gpio reset support

2020-05-31 Thread Jonathan Cameron
On Thu, 28 May 2020 17:01:05 +0200 Jonathan Albrieux wrote: > According to AK09911 datasheet, if reset gpio is provided then > deassert reset on ak8975_power_on() and assert reset on ak8975_power_off(). > > Without reset's deassertion during ak8975_power_on(), driver's probe fails > on

[PATCH] staging:rtl8712: avoid skb_clone after skb allocation fail

2020-05-31 Thread Ivan Safonov
The skb allocated when out of memory is likely to be discarded during subsequent processing. Signed-off-by: Ivan Safonov --- drivers/staging/rtl8712/rtl8712_recv.c | 29 ++ 1 file changed, 11 insertions(+), 18 deletions(-) diff --git

Re: [PATCH v7 4/5] iio: magnetometer: ak8975: Fix typo, uniform measurement unit style

2020-05-31 Thread Jonathan Cameron
On Thu, 28 May 2020 17:00:17 +0200 Jonathan Albrieux wrote: > Minor comment style edits. > > Signed-off-by: Jonathan Albrieux > Reviewed-by: Andy Shevchenko Applied > --- > drivers/iio/magnetometer/ak8975.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git

Re: [PATCH v7 1/4] bitops: Introduce the the for_each_set_clump macro

2020-05-31 Thread Andy Shevchenko
On Sun, May 31, 2020 at 4:11 AM Syed Nayyar Waris wrote: > On Sat, May 30, 2020 at 2:50 PM Andy Shevchenko > wrote: > > On Sat, May 30, 2020 at 11:45 AM Syed Nayyar Waris > > wrote: > > > On Sat, May 30, 2020 at 3:49 AM Andy Shevchenko > > > wrote: ... > #if (l) == 0 > #define

Re: [PATCH v7 3/5] dt-bindings: iio: magnetometer: ak8975: add gpio reset support

2020-05-31 Thread Jonathan Cameron
On Thu, 28 May 2020 16:59:28 +0200 Jonathan Albrieux wrote: > Add reset-gpio support. > > Without reset's deassertion during ak8975_power_on(), driver's probe fails > on ak8975_who_i_am() while checking for device identity for AK09911 chip. > > AK09911 has an active low reset gpio to handle

[PATCH] arm64: debug: mark a function as __init to save some memory

2020-05-31 Thread Christophe JAILLET
'debug_monitors_init()' is only called via 'postcore_initcall'. It can be marked as __init to save a few bytes of memory. Signed-off-by: Christophe JAILLET --- arch/arm64/kernel/debug-monitors.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH V6 6/7] iio: adc: Update debug prints

2020-05-31 Thread Jonathan Cameron
On Thu, 28 May 2020 22:24:28 +0530 Jishnu Prakash wrote: > Change pr_err/pr_debug statements to dev_err/dev_dbg for > increased clarity. > > Signed-off-by: Jishnu Prakash > Reviewed-by: Andy Shevchenko Applied. Thanks, J > --- > drivers/iio/adc/qcom-spmi-adc5.c | 18 +- > 1

Re: [PATCH v6 3/6] irqchip: RISC-V per-HART local interrupt controller driver

2020-05-31 Thread Marc Zyngier
On 2020-05-31 11:06, Anup Patel wrote: On Sun, May 31, 2020 at 3:03 PM Marc Zyngier wrote: On 2020-05-31 06:36, Anup Patel wrote: > On Sat, May 30, 2020 at 5:31 PM Marc Zyngier wrote: [...] >> > plic_set_threshold(handler, PLIC_DISABLE_THRESHOLD); >> >> Why do you need to both

Re: [PATCH V6 7/7] iio: adc: Add a common read function for PMIC5 and PMIC7

2020-05-31 Thread Jonathan Cameron
On Thu, 28 May 2020 22:24:29 +0530 Jishnu Prakash wrote: > Add a common function used for read_raw callback for both PMIC5 > and PMIC7 ADCs. > > Signed-off-by: Jishnu Prakash Hmm. I'm not completely sold on this one. Suggestions below. Jonathan > --- > drivers/iio/adc/qcom-spmi-adc5.c |

Re: [PATCH] sh: Implement __get_user_u64() required for 64-bit get_user()

2020-05-31 Thread John Paul Adrian Glaubitz
Hi Geert! Thanks a lot for the explanation! On 5/31/20 12:43 PM, Geert Uytterhoeven wrote: >> Hmm, this change is not the case for __put_user_asm() vs. __put_user_u64(). >> But I have to admit, I don't know what the part below "3:\n\t" is for. > > It's part of the exception handling, in case

[PATCH v2] sh: Implement __get_user_u64() required for 64-bit get_user()

2020-05-31 Thread John Paul Adrian Glaubitz
Trying to build the kernel with CONFIG_INFINIBAND_USER_ACCESS enabled fails ERROR: "__get_user_unknown" [drivers/infiniband/core/ib_uverbs.ko] undefined! with on SH since the kernel misses a 64-bit implementation of get_user(). Implement the missing 64-bit get_user() as __get_user_u64(),

Re: [PATCH V6 5/7] iio: adc: Update return value checks

2020-05-31 Thread Jonathan Cameron
On Thu, 28 May 2020 22:24:27 +0530 Jishnu Prakash wrote: > Clean up some return value checks to make code more compact. > > Signed-off-by: Jishnu Prakash Applied. Thanks, J > --- > drivers/iio/adc/qcom-spmi-adc5.c | 10 -- > 1 file changed, 4 insertions(+), 6 deletions(-) > > diff

Re: [PATCH V6 3/7] iio: adc: Add info property under adc_data

2020-05-31 Thread Jonathan Cameron
On Thu, 28 May 2020 22:24:25 +0530 Jishnu Prakash wrote: > Add info property under adc_data to support adding ADC variants > which may use different iio_info than the one defined for PMIC5. > > Signed-off-by: Jishnu Prakash Applied. Thanks, Jonathan > --- >

Re: [PATCH V6 4/7] iio: adc: Add support for PMIC7 ADC

2020-05-31 Thread Jonathan Cameron
On Thu, 28 May 2020 22:24:26 +0530 Jishnu Prakash wrote: > The ADC architecture on PMIC7 is changed as compared to PMIC5. The > major change from PMIC5 is that all SW communication to ADC goes through > PMK8350, which communicates with other PMICs through PBS when the ADC > on PMK8350 works in

Re: [PATCH V6 2/7] iio: adc: Add PMIC7 ADC bindings

2020-05-31 Thread Jonathan Cameron
On Thu, 28 May 2020 22:24:24 +0530 Jishnu Prakash wrote: > Add documentation for PMIC7 ADC peripheral. > For the PMIC7-type PMICs, ADC peripheral is present in HW for the > following PMICs: PMK8350, PM8350, PM8350b, PMR735a and PMR735b. > Of these, only the ADC peripheral on PMK8350 is exposed

Re: [PATCH V6 1/7] iio: adc: Convert the QCOM SPMI ADC bindings to .yaml format

2020-05-31 Thread Jonathan Cameron
On Sun, 31 May 2020 11:36:12 +0100 Jonathan Cameron wrote: > On Thu, 28 May 2020 22:24:23 +0530 > Jishnu Prakash wrote: > > > Convert the adc bindings from .txt to .yaml format. > > > > Signed-off-by: Jishnu Prakash > > Reviewed-by: Amit Kucheria > > Reviewed-by: Rob Herring > > Acked-by:

Re: Re: drm/nouveau/clk/gm20b: Fix memory leak in gm20b_clk_new()

2020-05-31 Thread dinghao . liu
> > If gk20a_clk_ctor() never returns such an error code, > > we may need not to release this clock object. > > Would you like to achieve complete exception handling > also for this function implementation? > It seems that it's possible to get -ENOMEM from gk20a_clk_ctor(). The call chain is as

Re: [PATCH] sh: Implement __get_user_u64() required for 64-bit get_user()

2020-05-31 Thread Geert Uytterhoeven
Hi Adrian, On Sun, May 31, 2020 at 11:59 AM John Paul Adrian Glaubitz wrote: > On 5/31/20 11:54 AM, John Paul Adrian Glaubitz wrote: > > On 5/31/20 11:52 AM, Geert Uytterhoeven wrote: > >> As this is the 64-bit variant, I think this single move should be > >> replaced by a double move: > >> > >>

<    1   2   3   4   5   >