Re: [PATCH] nvme-fc: Only call nvme_cleanup_cmd() for normal operations

2020-06-02 Thread Hannes Reinecke
On 5/29/20 1:37 PM, Daniel Wagner wrote: Asynchronous event notifications do not have an request associated. When fcp_io() fails we unconditionally call nvme_cleanup_cmd() which leads to a crash. Fixes: 16686f3a6c3c ("nvme: move common call to nvme_cleanup_cmd to core layer") Cc: Max Gurtovoy

Re: [PATCH] ALSA: core: Fix control device release issue

2020-06-02 Thread Takashi Iwai
On Tue, 02 Jun 2020 11:48:04 +0200, 朱灿灿 wrote: > > From: zhucancan > Date: Tue, 2 Jun 2020 16:22:57 +0800 > Subject: [PATCH] ALSA: core: Fix control device release issue > > We use snd_pcm_add_usr_ctls() in component's .pcm_new(), > unfortunately snd_soc_dapm_add_routes() meets error during >

Re: [PATCH V4] pwm: tegra: dynamic clk freq configuration by PWM driver

2020-06-02 Thread Thierry Reding
On Mon, Jun 01, 2020 at 10:50:36AM +0530, Sandipan Patra wrote: > Added support for dynamic clock freq configuration in pwm kernel driver. > Earlier the pwm driver used to cache boot time clock rate by pwm clock > parent during probe. Hence dynamically changing pwm frequency was not > possible for

Re: [PATCH] sound: usb: pcm: fix incorrect power state when playing sound after PM_AUTO suspend

2020-06-02 Thread Takashi Iwai
On Tue, 02 Jun 2020 13:53:41 +0200, Macpaul Lin wrote: > > This patch fix incorrect power state changed by usb_audio_suspend() > when CONFIG_PM is enabled. > > After receiving suspend PM message with auto flag, usb_audio_suspend() > change card's power state to SNDRV_CTL_POWER_D3hot. Only when

Re: [PATCH] vimc: debayer: Add support for ARGB format

2020-06-02 Thread Laurent Pinchart
Hello, On Tue, Jun 02, 2020 at 08:31:26AM -0300, Helen Koike wrote: > On 6/2/20 8:24 AM, Kieran Bingham wrote: > > On 02/06/2020 11:55, Helen Koike wrote: > >> On 6/2/20 7:52 AM, Dafna Hirschfeld wrote: > >>> On 01.06.20 14:16, Kaaira Gupta wrote: > On Fri, May 29, 2020 at 05:43:57PM +0200,

Re: [RESEND PATCH v1 5/6] staging: greybus: audio: Add helper APIs for dynamic audio modules

2020-06-02 Thread Dan Carpenter
On Tue, Jun 02, 2020 at 10:51:14AM +0530, Vaibhav Agarwal wrote: > +static int gbaudio_remove_controls(struct snd_card *card, struct device *dev, > +const struct snd_kcontrol_new *controls, > +int num_controls, const char *prefix) >

[PATCH v2] f2fs: fix retry logic in f2fs_write_cache_pages()

2020-06-02 Thread Sahitya Tummala
In case a compressed file is getting overwritten, the current retry logic doesn't include the current page to be retried now as it sets the new start index as 0 and new end index as writeback_index - 1. This causes the corresponding cluster to be uncompressed and written as normal pages without

Re: linux-next test error: BUG: using smp_processor_id() in preemptible [ADDR] code: syz-fuzzer/6792

2020-06-02 Thread Ritesh Harjani
PID: 6927 Comm: syz-fuzzer Not tainted 5.7.0-next-20200602-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011 Call Trace: __dump_stack lib/dump_stack.c:77 [inline] dump_stack+0x18f/0x20d lib/dump_stack.c:118 check_preemption_disabled+0x20d/0x220

Re: Re: linux-next test error: BUG: using smp_processor_id() in preemptible [ADDR] code: syz-fuzzer/6792

2020-06-02 Thread syzbot
> #syz test: This crash does not have a reproducer. I cannot test it. > https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git > 0e21d4620dd047da7952f44a2e1ac777ded2d57e

Re: [PATCH v3 1/4] pwm: jz4740: Drop dependency on MACH_INGENIC

2020-06-02 Thread Thierry Reding
On Wed, May 27, 2020 at 01:52:22PM +0200, Paul Cercueil wrote: > Depending on MACH_INGENIC prevent us from creating a generic kernel that > works on more than one MIPS board. Instead, we just depend on MIPS being > set. > > Acked-by: Uwe Kleine-König > Signed-off-by: Paul Cercueil > --- > >

[PATCH] dt-bindings: usb: ti,keystone-dwc3.yaml: Improve schema

2020-06-02 Thread Roger Quadros
There were some review comments after the patch was integrated. Address those. Fixes: 1883a934e156 ("dt-bindings: usb: convert keystone-usb.txt to YAML") Signed-off-by: Roger Quadros --- .../bindings/usb/ti,keystone-dwc3.yaml| 47 ++- 1 file changed, 35 insertions(+), 12

Re: [RESEND PATCH v1 4/6] staging: greybus: audio: Resolve compilation error in topology parser

2020-06-02 Thread Dan Carpenter
On Tue, Jun 02, 2020 at 10:51:13AM +0530, Vaibhav Agarwal wrote: > Fix compilation errors for GB Audio topology parser code with recent > kernel versions. > > Signed-off-by: Vaibhav Agarwal > --- > drivers/staging/greybus/audio_topology.c | 130 +++ > 1 file changed, 61

Re: [PATCH] pwm: rockchip: simplify rockchip_pwm_get_state()

2020-06-02 Thread Thierry Reding
On Thu, Sep 19, 2019 at 11:17:27AM +0200, Rasmus Villemoes wrote: > The way state->enabled is computed is rather convoluted and hard to > read - both branches of the if() actually do the exact same thing. So > remove the if(), and further simplify " ? true : > false" to "". > > Signed-off-by:

Re: [PATCH v2] pwm: sun4i: direct clock output support for Allwinner A64

2020-06-02 Thread Thierry Reding
On Tue, Apr 28, 2020 at 06:41:50PM +0200, Peter Vasil wrote: > Allwinner A64 is capable of a direct clock output on PWM (see A64 > User Manual chapter 3.10). Add support for this in the sun4i PWM > driver. > > Signed-off-by: Peter Vasil > --- > drivers/pwm/pwm-sun4i.c | 9 + > 1 file

Re: [PATCH 1/3] dt-bindings: usb: convert keystone-usb.txt to YAML

2020-06-02 Thread Roger Quadros
Rob, Thanks for the review. Since this patch was already picked up I will address the issues in a follow up patch. cheers, -roger On 27/05/2020 04:37, Rob Herring wrote: On Wed, May 13, 2020 at 04:07:07PM +0300, Roger Quadros wrote: Convert keystone-usb documentation to YAML format.

[PATCH 3/4] io_uring: deduplicate io_openat{,2}_prep()

2020-06-02 Thread Pavel Begunkov
io_openat_prep() and io_openat2_prep() are identical except for how struct open_how is built. Deduplicate it with a helper. Signed-off-by: Pavel Begunkov --- fs/io_uring.c | 55 ++- 1 file changed, 19 insertions(+), 36 deletions(-) diff --git

[PATCH 2/4] io_uring: do build_open_how() only once

2020-06-02 Thread Pavel Begunkov
build_open_how() is just adjusting open_flags/mode. Do it once during prep. It looks better than storing raw values for the future. Signed-off-by: Pavel Begunkov --- fs/io_uring.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/fs/io_uring.c b/fs/io_uring.c

[PATCH 1/4] io_uring: fix open/close/statx with {SQ,IO}POLL

2020-06-02 Thread Pavel Begunkov
Trying to use them with IORING_SETUP_IOPOLL: RIP: 0010:io_iopoll_getevents+0x111/0x5a0 Call Trace: ? _raw_spin_unlock_irqrestore+0x24/0x40 ? do_send_sig_info+0x64/0x90 io_iopoll_reap_events.part.0+0x5e/0xa0 io_ring_ctx_wait_and_kill+0x132/0x1c0 io_uring_release+0x20/0x30 __fput+0xcd/0x230

[PATCH 4/4] io_uring: move send/recv IOPOLL check into prep

2020-06-02 Thread Pavel Begunkov
Fail recv/send in case of IORING_SETUP_IOPOLL earlier during prep, so it'd be done only once. Removes duplication as well Signed-off-by: Pavel Begunkov --- fs/io_uring.c | 18 ++ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/fs/io_uring.c b/fs/io_uring.c index

[PATCH 0/4] forbid using open/close/statx with {SQ,IO}POLL

2020-06-02 Thread Pavel Begunkov
The first one adds checks {SQPOLL,IOPOLL} for open, close, etc. And 3 others are just cleanups on top. notes: - it cures symptoms, but would be great what's with null-deref in [1/4] - need to look whether epoll and sfr are affected by {SQ,IO}POLL - it still allows statx with SQPOLL, because it

Re: [RESEND PATCH v1 3/6] staging: greybus: audio: Resolve compilation errors for GB codec module

2020-06-02 Thread Dan Carpenter
On Tue, Jun 02, 2020 at 10:51:12AM +0530, Vaibhav Agarwal wrote: > Due to dependencies on ASoC framework changes, GB dummy codec module > compilation is currently disabled. This patch updates codec driver as > per the latest ASoC APIs. > > Signed-off-by: Vaibhav Agarwal > --- >

[PATCH] pinctrl: sirf: add missing put_device() in error handling path in sirfsoc_gpio_probe()

2020-06-02 Thread yu kuai
in sirfsoc_gpio_probe(), if of_find_device_by_node() succeed, put_device() is missing in the error handling patch. Signed-off-by: yu kuai --- drivers/pinctrl/sirf/pinctrl-sirf.c | 20 ++-- 1 file changed, 14 insertions(+), 6 deletions(-) diff --git

[PATCH] thunderbolt: Improve USB4 config symbol help text

2020-06-02 Thread Geert Uytterhoeven
Fix the spelling of "specification", and add a missing "the" article. Fixes: 690ac0d20d4022bb ("thunderbolt: Update Kconfig entries to USB4") Signed-off-by: Geert Uytterhoeven --- drivers/thunderbolt/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [PATCH] Bluetooth: Check scan state before disabling during suspend

2020-06-02 Thread Alain Michaud
On Mon, Jun 1, 2020 at 9:49 PM Abhishek Pandit-Subedi wrote: > > Hey linux-bluetooth, > > We found this bug when reverting some Chromium maintained patches in > our repository that was conditionally dropping LE scan enable commands > if it wasn't toggling between true/false. On some Intel

RE: [PATCH v4 3/5] scsi: ufs: fix potential access NULL pointer while memcpy

2020-06-02 Thread Avri Altman
How about something like the untested attached? Thanks, Avri > -Original Message- > From: Bean Huo > Sent: Tuesday, June 2, 2020 2:36 PM > To: Avri Altman ; alim.akh...@samsung.com; > asuto...@codeaurora.org; j...@linux.ibm.com; > martin.peter...@oracle.com; stanley@mediatek.com; >

Re: [PATCH] pinctrl: msm: Add check for pinctrl group is valid

2020-06-02 Thread Mayank Grover
On Mon, May 25, 2020 at 11:02:14AM +0200, Linus Walleij wrote: > On Tue, May 19, 2020 at 3:39 AM Bjorn Andersson > wrote: > > > @Linus, we started off with something similar for GPIOs and ended up > > with the logic in the core code. Should we somehow try to do the same > > for pinctrl? > >

Re: [PATCH] ALSA: core: Fix control device release issue

2020-06-02 Thread Markus Elfring
> We use snd_pcm_add_usr_ctls() in component's .pcm_new(), > unfortunately snd_soc_dapm_add_routes() meets error during > adding card->dapm_routes/of_dapm_routes, it will goto probe_end > to call soc_cleanup_card_resources(). > > The commit dc82e52492f6 ("ALSA: core: Assure control device > to be

Re: [PATCH v4 4/5] regulator: qcom: Add labibb driver

2020-06-02 Thread Mark Brown
On Tue, Jun 02, 2020 at 05:40:45PM +0530, Sumit Semwal wrote: > On Tue, 2 Jun 2020 at 17:02, Mark Brown wrote: > > On Tue, Jun 02, 2020 at 03:39:23PM +0530, Sumit Semwal wrote: > > This should be a get_status() callback... > From my (limited) understanding of downstream code, it seemed like for

Re: [PATCH v6 03/14] videobuf2: handle V4L2 buffer cache flags

2020-06-02 Thread Hans Verkuil
On 02/06/2020 14:22, Tomasz Figa wrote: > Hi Hans, > > On Tue, Jun 2, 2020 at 11:51 AM Hans Verkuil wrote: >> >> Hi Sergey, >> >> While doing final testing for this patch series (together with the v4l-utils >> patch) >> I found one remaining issue: >> >> On 14/05/2020 18:01, Sergey Senozhatsky

Re: [PATCH v6 03/14] videobuf2: handle V4L2 buffer cache flags

2020-06-02 Thread Tomasz Figa
Hi Hans, On Tue, Jun 2, 2020 at 11:51 AM Hans Verkuil wrote: > > Hi Sergey, > > While doing final testing for this patch series (together with the v4l-utils > patch) > I found one remaining issue: > > On 14/05/2020 18:01, Sergey Senozhatsky wrote: > > From: Sergey Senozhatsky > > > > Set video

Re: [PATCH v6 03/14] videobuf2: handle V4L2 buffer cache flags

2020-06-02 Thread Hans Verkuil
On 02/06/2020 14:10, Sergey Senozhatsky wrote: > On (20/06/02 12:27), Hans Verkuil wrote: > [..] >>> Sorry, Hans, do you suggest to have something like this: >>> >>> if (q->memory == VB2_MEMORY_DMABUF) { >>> vb->need_cache_sync_on_finish = 0; >>>

Re: [PATCH] drm/vkms: Optimize compute_crc(), blend()

2020-06-02 Thread Emil Velikov
On Mon, 1 Jun 2020 at 01:25, Rodrigo Siqueira wrote: > > Hi, > > First of all, thanks a lot for all your patch. And thanks Emil for your > feedback. > > I have a suggestion here: > > Emil: > Could you give me your Acked-by or maybe Reviewed-by for the writeback > series? With that, I can finally

Re: [PATCH v4 5/5] regulator: qcom: labibb: Add SC interrupt handling

2020-06-02 Thread Mark Brown
On Tue, Jun 02, 2020 at 03:39:24PM +0530, Sumit Semwal wrote: > static int qcom_labibb_regulator_enable(struct regulator_dev *rdev) > { > - return regulator_enable_regmap(rdev); > + int ret; > + struct labibb_regulator *reg = rdev_get_drvdata(rdev); > + > + ret =

PROPOSITION

2020-06-02 Thread Richard Kabore
Dear Sir/Ma, Good day to you, i hope this message meet you in good fate. I have a proposition to offer which i know will be of immense benefit to both of us. I need you to work with me as my partner in executing a legitimate business deal. Kindly indicate your interest by replying to my

linux-next test error: BUG: using smp_processor_id() in preemptible [ADDR] code: systemd-rfkill/6731

2020-06-02 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:0e21d462 Add linux-next specific files for 20200602 git tree: linux-next console output: https://syzkaller.appspot.com/x/log.txt?x=102c59ce10 kernel config: https://syzkaller.appspot.com/x/.config?x=ecc1aef35f550ee3 dashboard

linux-next test error: BUG: using smp_processor_id() in preemptible [ADDR] code: kworker/u4:LINE/6740

2020-06-02 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:0e21d462 Add linux-next specific files for 20200602 git tree: linux-next console output: https://syzkaller.appspot.com/x/log.txt?x=13f3dcca10 kernel config: https://syzkaller.appspot.com/x/.config?x=ecc1aef35f550ee3 dashboard

linux-next test error: BUG: using smp_processor_id() in preemptible [ADDR] code: systemd-rfkill/6726

2020-06-02 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:0e21d462 Add linux-next specific files for 20200602 git tree: linux-next console output: https://syzkaller.appspot.com/x/log.txt?x=13a7ffe210 kernel config: https://syzkaller.appspot.com/x/.config?x=ecc1aef35f550ee3 dashboard

Re: [PATCH] sound: usb: pcm: fix incorrect power state when playing sound after PM_AUTO suspend

2020-06-02 Thread Macpaul Lin
On Tue, 2020-06-02 at 19:53 +0800, Macpaul Lin wrote: > This patch fix incorrect power state changed by usb_audio_suspend() > when CONFIG_PM is enabled. > > After receiving suspend PM message with auto flag, usb_audio_suspend() > change card's power state to SNDRV_CTL_POWER_D3hot. Only when the

[GIT PULL] thread changes for v5.8

2020-06-02 Thread Christian Brauner
Hi Linus, Here are the changes for v5.8: /* Summary */ We have been discussing using pidfds to attach to namespaces for quite a while and the patches have in one form or another already existed for about a year. But I wanted to wait to see how the general api would be received and adopted.

Re: [LKP] Re: 28307d938f ("percpu: make pcpu_alloc() aware of current gfp .."): BUG: kernel reboot-without-warning in boot stage

2020-06-02 Thread Filipe Manana
On 02/06/20 05:37, Li Zhijian wrote: > Hi Filipe, > > LKP checked blow dmesg as the indicator in this problem > >>> [    0.144174] RAMDISK: [mem 0x7fa2e000-0x7fff] >>> [    0.144559] ACPI: Early table checksum verification disabled >>> [    0.144985] ACPI: RSDP 0x000F5850 14

Re: [PATCH V4 3/3] drm/vkms: Add support for writeback

2020-06-02 Thread Emil Velikov
On Mon, 11 May 2020 at 12:55, Rodrigo Siqueira wrote: > # SPDX-License-Identifier: GPL-2.0-only > -vkms-y := vkms_drv.o vkms_plane.o vkms_output.o vkms_crtc.o vkms_gem.o > vkms_composer.o > +vkms-y := \ > + vkms_drv.o \ > + vkms_plane.o \ > + vkms_output.o \ > +

Re: Writeback bug causing writeback stalls

2020-06-02 Thread Martijn Coenen
On Mon, Jun 1, 2020 at 11:09 AM Jan Kara wrote: > Thanks for testing! My test run has completed fine so I'll submit patches > for review. But I'm curious what's causing the dips in throughput in your > test... It turned out to be unrelated to your patch. Sorry for the noise! We have the patch in

Re: [RESEND PATCH v1 2/6] staging: greybus: audio: Maintain jack list within GB Audio module

2020-06-02 Thread Dan Carpenter
On Tue, Jun 02, 2020 at 10:51:11AM +0530, Vaibhav Agarwal wrote: > As per the current implementation for GB codec driver, a jack list is > maintained for each module. And it expects the list to be populated by > the snd_soc_jack structure which would require modifications in > mainstream code. >

Re: linux-next: build failure after merge of the mmc tree

2020-06-02 Thread Kalle Valo
Stephen Rothwell writes: > Hi all, > > After merging the mmc tree, today's linux-next build (arm > multi_v7_defconfig) failed like this: > > drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c: In function > 'brcmf_sdiod_probe': >

Re: Security Random Number Generator support

2020-06-02 Thread Ard Biesheuvel
On Tue, 2 Jun 2020 at 10:15, Neal Liu wrote: > > These patch series introduce a security random number generator > which provides a generic interface to get hardware rnd from Secure > state. The Secure state can be Arm Trusted Firmware(ATF), Trusted > Execution Environment(TEE), or even EL2

[GIT PULL] scheduler changes for v5.8

2020-06-02 Thread Ingo Molnar
Linus, Please pull the latest sched/core git tree from: git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git sched-core-2020-06-02 # HEAD: 25de110d148666752dc0e0da7a0b69de31cd7098 irq_work: Define irq_work_single() on !CONFIG_IRQ_WORK too The changes in this cycle are: -

Re: [PATCH] scsi: megaraid_sas: fix kdump kernel boot hung caused by JBOD

2020-06-02 Thread Kai Liu
On 2020/05/28 Thu 15:31, xiakaixu1...@gmail.com wrote: From: Xiaoming Gao when kernel crash, and kexec into kdump kernel, megaraid_sas will hung and print follow error logs 24.1485901 sd 0:0:G:0: [sda 1 tag809 BRCfl Debug mfi stat 0x2(1, data len requested/conpleted 0X100 0/0x0)] 24.1867171

Re: [PATCH v6 03/14] videobuf2: handle V4L2 buffer cache flags

2020-06-02 Thread Sergey Senozhatsky
On (20/06/02 12:27), Hans Verkuil wrote: [..] > > Sorry, Hans, do you suggest to have something like this: > > > > if (q->memory == VB2_MEMORY_DMABUF) { > > vb->need_cache_sync_on_finish = 0; > > vb->need_cache_sync_on_prepare = 0; > > b->flags &=

kobject_init_and_add is easy to misuse

2020-06-02 Thread Matthew Wilcox
On Tue, Jun 02, 2020 at 07:50:33PM +0800, Wang Hai wrote: > syzkaller reports for memory leak when kobject_init_and_add() > returns an error in the function sysfs_slab_add() [1] > > When this happened, the function kobject_put() is not called for the > corresponding kobject, which potentially

Re: [PATCH v4 4/5] regulator: qcom: Add labibb driver

2020-06-02 Thread Sumit Semwal
Hi Mark, Thank you very much for reviewing. On Tue, 2 Jun 2020 at 17:02, Mark Brown wrote: > > On Tue, Jun 02, 2020 at 03:39:23PM +0530, Sumit Semwal wrote: > > > +static int qcom_labibb_regulator_is_enabled(struct regulator_dev *rdev) > > +{ > > + int ret; > > + unsigned int val; > >

Re: [PATCHv2] perf stat: Ensure group is defined on top of the same cpu mask

2020-06-02 Thread Jiri Olsa
On Tue, Jun 02, 2020 at 08:50:17PM +0900, Namhyung Kim wrote: > Hi Jiri, > > On Tue, Jun 2, 2020 at 5:16 PM Jiri Olsa wrote: > > > > On Tue, Jun 02, 2020 at 11:47:19AM +0900, Namhyung Kim wrote: > > > On Tue, Jun 2, 2020 at 1:21 AM Ian Rogers wrote: > > > > > > > > On Mon, Jun 1, 2020 at 1:20

[PATCH][next] clk: baikal-t1: fix spelling mistake "Uncompatible" -> "Incompatible"

2020-06-02 Thread Colin King
From: Colin Ian King There is a spelling mistake in a pr_err error message. Fix it. Signed-off-by: Colin Ian King --- drivers/clk/baikal-t1/clk-ccu-div.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/clk/baikal-t1/clk-ccu-div.c

[GIT pull] irq/core for v5.8

2020-06-02 Thread Thomas Gleixner
Linus, please pull the latest irq/core branch from: git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git irq-core-2020-06-02 up to: d77aeb5d403d: irqchip: Fix "Loongson HyperTransport Vector support" driver build on all non-MIPS platforms The generic interrupt departement provides:

Re: [PATCH 11/15] mmc: sdhci: use PCI_IRQ_MSI_TYPES where appropriate

2020-06-02 Thread Ulf Hansson
On Tue, 2 Jun 2020 at 11:21, Piotr Stankiewicz wrote: > > Seeing as there is shorthand available to use when asking for any type > of interrupt, or any type of message signalled interrupt, leverage it. > > Signed-off-by: Piotr Stankiewicz > Reviewed-by: Andy Shevchenko Acked-by: Ulf Hansson

[GIT pull] timers/core for v5.8

2020-06-02 Thread Thomas Gleixner
Linus, please pull the latest timers/core branch from: git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git timers-core-2020-06-02 up to: 809eb4e9bf9d: dt-bindings: timer: Add renesas,em-sti bindings The truly boring timer and clocksource updates for 5.8: - Not a single new

[PATCH] cxl: Fix kobject memleak

2020-06-02 Thread Wang Hai
Currently the error return path from kobject_init_and_add() is not followed by a call to kobject_put() - which means we are leaking the kobject. Fix it by adding a call to kobject_put() in the error path of kobject_init_and_add(). Fixes: b087e6190ddc ("cxl: Export optional AFU configuration

Re: linux-next: build failure after merge of the mmc tree

2020-06-02 Thread Ulf Hansson
+ Linus On Tue, 2 Jun 2020 at 05:44, Stephen Rothwell wrote: > > Hi all, > > After merging the mmc tree, today's linux-next build (arm > multi_v7_defconfig) failed like this: > > drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c: In function > 'brcmf_sdiod_probe': >

Re: [RFC PATCH v4 2/2] arm64: tlb: Use the TLBI RANGE feature in arm64

2020-06-02 Thread Zhenyu Ye
Hi all, Some optimizations to the codes: On 2020/6/1 22:47, Zhenyu Ye wrote: > - start = __TLBI_VADDR(start, asid); > - end = __TLBI_VADDR(end, asid); > + /* > + * The minimum size of TLB RANGE is 2 pages; > + * Use normal TLB instruction to handle odd pages. > + * If

Re: [PATCH v2 1/2] video: fbdev: amifb: add FIXME about dead APUS support

2020-06-02 Thread Geert Uytterhoeven
On Tue, Jun 2, 2020 at 1:50 PM Bartlomiej Zolnierkiewicz wrote: > On 5/14/20 10:21 PM, Geert Uytterhoeven wrote: > > These #ifdefs are relics from APUS (Amiga Power-Up System), which > > added a PPC board. APUS support was killed off a long time ago, > > when arch/ppc/ was still king, but these

Re: [PATCH v2 2/2] video: fbdev: amifb: add FIXMEs about {put,get}_user() failures

2020-06-02 Thread Geert Uytterhoeven
On Tue, Jun 2, 2020 at 1:52 PM Bartlomiej Zolnierkiewicz wrote: > Since we lack the hardware (or proper emulator setup) for > testing needed changes add FIXMEs to document the issues > (so at least they are not forgotten). > > Cc: Al Viro > Cc: Geert Uytterhoeven > Signed-off-by: Bartlomiej

Re: [PATCH 05/15] crypto: inside-secure - use PCI_IRQ_MSI_TYPES where appropriate

2020-06-02 Thread Herbert Xu
On Tue, Jun 02, 2020 at 01:32:49PM +0200, Antoine Tenart wrote: > > Quoting Piotr Stankiewicz (2020-06-02 11:20:19) > > Seeing as there is shorthand available to use when asking for any type > > of interrupt, or any type of message signalled interrupt, leverage it. > > > > Signed-off-by: Piotr

Re: [RESEND PATCH v1 1/6] staging: greybus: audio: Update snd_jack FW usage as per new APIs

2020-06-02 Thread Dan Carpenter
On Tue, Jun 02, 2020 at 10:51:10AM +0530, Vaibhav Agarwal wrote: > diff --git a/drivers/staging/greybus/audio_codec.c > b/drivers/staging/greybus/audio_codec.c > index 08746c85dea6..ebf8484f0ae7 100644 > --- a/drivers/staging/greybus/audio_codec.c > +++ b/drivers/staging/greybus/audio_codec.c >

sound/core/pcm_native.c:3412:24: error: implicit declaration of function 'pgprot_writecombine'; did you mean 'dma_free_writecombine'?

2020-06-02 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: f359287765c04711ff54fbd11645271d8e5ff763 commit: b0310c2f09bbe8aebefb97ed67949a3a7092aca6 USB: use genalloc for USB HCs with local memory config: m68k-randconfig-r002-20200602 (attached as .config) compiler

Re: [PATCH v4 1/5] regulator: Allow regulators to verify enabled during enable()

2020-06-02 Thread Sumit Semwal
Hi Mark, Thanks for the review! On Tue, 2 Jun 2020 at 16:54, Mark Brown wrote: > > On Tue, Jun 02, 2020 at 03:39:20PM +0530, Sumit Semwal wrote: > > > + > > + if (time_remaining <= 0) { > > + rdev_err(rdev, "Enabled check failed.\n"); > > +

[PATCH v5 04/11] PCI: qcom: Add missing reset for ipq806x

2020-06-02 Thread Ansuel Smith
Add missing ext reset used by ipq8064 SoC in PCIe qcom driver. Fixes: 82a823833f4e ("PCI: qcom: Add Qualcomm PCIe controller driver") Signed-off-by: Sham Muthayyan Signed-off-by: Ansuel Smith Cc: sta...@vger.kernel.org # v4.5+ Reviewed-by: Rob Herring Reviewed-by: Philipp Zabel ---

[PATCH v5 09/11] PCI: qcom: Add ipq8064 rev2 variant

2020-06-02 Thread Ansuel Smith
Ipq8064-v2 have tx term offset set to 0. Introduce this variant to permit different offset based on the revision. Signed-off-by: Ansuel Smith --- drivers/pci/controller/dwc/pcie-qcom.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/pci/controller/dwc/pcie-qcom.c

[PATCH v5 07/11] PCI: qcom: Define some PARF params needed for ipq8064 SoC

2020-06-02 Thread Ansuel Smith
Set some specific value for Tx De-Emphasis, Tx Swing and Rx equalization needed on some ipq8064 based device (Netgear R7800 for example). Without this the system locks on kernel load. Fixes: 82a823833f4e ("PCI: qcom: Add Qualcomm PCIe controller driver") Signed-off-by: Ansuel Smith Cc:

[PATCH v5 03/11] PCI: qcom: Change duplicate PCI reset to phy reset

2020-06-02 Thread Ansuel Smith
From: Abhishek Sahu The deinit issues reset_control_assert for PCI twice and does not contain phy reset. Signed-off-by: Abhishek Sahu Signed-off-by: Ansuel Smith Reviewed-by: Rob Herring --- drivers/pci/controller/dwc/pcie-qcom.c | 18 -- 1 file changed, 8 insertions(+), 10

[PATCH v5 01/11] PCI: qcom: Add missing ipq806x clocks in PCIe driver

2020-06-02 Thread Ansuel Smith
Aux and Ref clk are missing in PCIe qcom driver. Add support for this optional clks for ipq8064/apq8064 SoC. Fixes: 82a823833f4e ("PCI: qcom: Add Qualcomm PCIe controller driver") Signed-off-by: Sham Muthayyan Signed-off-by: Ansuel Smith Reviewed-by: Rob Herring ---

[PATCH v5 02/11] dt-bindings: PCI: qcom: Add missing clks

2020-06-02 Thread Ansuel Smith
Document missing clks used in ipq8064 SoC. Signed-off-by: Ansuel Smith Acked-by: Rob Herring --- Documentation/devicetree/bindings/pci/qcom,pcie.txt | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie.txt

[PATCH v5 08/11] PCI: qcom: Add support for tx term offset for rev 2.1.0

2020-06-02 Thread Ansuel Smith
Add tx term offset support to pcie qcom driver need in some revision of the ipq806x SoC. Ipq8064 needs tx term offset set to 7. Fixes: 82a823833f4e ("PCI: qcom: Add Qualcomm PCIe controller driver") Signed-off-by: Sham Muthayyan Signed-off-by: Ansuel Smith Cc: sta...@vger.kernel.org # v4.5+ ---

[PATCH] sound: usb: pcm: fix incorrect power state when playing sound after PM_AUTO suspend

2020-06-02 Thread Macpaul Lin
This patch fix incorrect power state changed by usb_audio_suspend() when CONFIG_PM is enabled. After receiving suspend PM message with auto flag, usb_audio_suspend() change card's power state to SNDRV_CTL_POWER_D3hot. Only when the other resume PM message with auto flag can change power state to

[PATCH v5 11/11] PCI: qcom: Add Force GEN1 support

2020-06-02 Thread Ansuel Smith
From: Sham Muthayyan Add Force GEN1 support needed in some ipq8064 board that needs to limit some PCIe line to gen1 for some hardware limitation. This is set by the max-link-speed binding and needed by some soc based on ipq8064. (for example Netgear R7800 router) Signed-off-by: Sham Muthayyan

[PATCH v5 06/11] PCI: qcom: Use bulk clk api and assert on error

2020-06-02 Thread Ansuel Smith
Rework 2.1.0 revision to use bulk clk api and fix missing assert on reset_control_deassert error. Signed-off-by: Ansuel Smith Reviewed-by: Rob Herring --- drivers/pci/controller/dwc/pcie-qcom.c | 131 + 1 file changed, 46 insertions(+), 85 deletions(-) diff --git

[PATCH v5 00/11] Multiple fixes in PCIe qcom driver

2020-06-02 Thread Ansuel Smith
This contains multiple fix for PCIe qcom driver. Some optional reset and clocks were missing. Fix a problem with no PARF programming that cause kernel lock on load. Add support to force gen 1 speed if needed. (due to hardware limitation) Add ipq8064 rev 2 support that use a different tx

[PATCH v5 10/11] dt-bindings: PCI: qcom: Add ipq8064 rev 2 variant

2020-06-02 Thread Ansuel Smith
Document qcom,pcie-ipq8064-v2 needed to use different phy_tx0_term_offset. In ipq8064 phy_tx0_term_offset is 7. In ipq8064 v2 other SoC it's set to 0 by default. Signed-off-by: Ansuel Smith Acked-by: Rob Herring --- Documentation/devicetree/bindings/pci/qcom,pcie.txt | 1 + 1 file changed, 1

[PATCH v5 05/11] dt-bindings: PCI: qcom: Add ext reset

2020-06-02 Thread Ansuel Smith
Document ext reset used in ipq8064 SoC by qcom PCIe driver. Signed-off-by: Ansuel Smith Acked-by: Rob Herring --- Documentation/devicetree/bindings/pci/qcom,pcie.txt | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie.txt

Re: [PATCH v6 0/5] Micron SLC NAND filling block

2020-06-02 Thread Boris Brezillon
On Tue, 02 Jun 2020 10:59:46 +0200 Bean Huo wrote: > On Tue, 2020-06-02 at 09:48 +0200, Boris Brezillon wrote: > > Hi Bean, > > > > On Mon, 01 Jun 2020 23:10:43 +0200 > > Bean Huo wrote: > > > > > Hi Richard > > > would you please help us confirm below question?? > > > > Miquel

[PATCH v2 2/2] video: fbdev: amifb: add FIXMEs about {put,get}_user() failures

2020-06-02 Thread Bartlomiej Zolnierkiewicz
Since we lack the hardware (or proper emulator setup) for testing needed changes add FIXMEs to document the issues (so at least they are not forgotten). Cc: Al Viro Cc: Geert Uytterhoeven Signed-off-by: Bartlomiej Zolnierkiewicz --- v2: - rebased on top of updated patch #1/2

[PATCH 10/13] perf tools: Release metric_events rblist

2020-06-02 Thread Jiri Olsa
We don't release metric_events rblist, add the missing delete hook and call the release before leaving cmd_stat. Signed-off-by: Jiri Olsa --- tools/perf/builtin-stat.c | 1 + tools/perf/util/metricgroup.c | 19 +++ tools/perf/util/metricgroup.h | 1 + 3 files changed, 21

[PATCH 06/13] perf tools: Add fake_pmu to parse_events function

2020-06-02 Thread Jiri Olsa
Allow to pass fake_pmu in parse_groups function so it can be used in parse_events call. It's set true by metricgroup__parse_groups_test function. Signed-off-by: Jiri Olsa --- tools/perf/util/metricgroup.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git

[PATCH 09/13] perf tools: Factor out prepare_metric function

2020-06-02 Thread Jiri Olsa
Factoring out prepare_metric functio so it can be used in test interface coming in following changes. Signed-off-by: Jiri Olsa --- tools/perf/util/stat-shadow.c | 53 ++- 1 file changed, 34 insertions(+), 19 deletions(-) diff --git

[PATCHv2 00/13] perf tests: Add metrics tests

2020-06-02 Thread Jiri Olsa
hi, changes for using metric result in another metric seem to change lot of core metric code, so it's better we have some more tests before we do that. v2 changes: - some of the patches got accepted - add missing free to patch 1 [Ian] - factor pmu-events test functions and reuse it in the

[PATCH 12/13] perf tests: Add parse metric test for ipc metric

2020-06-02 Thread Jiri Olsa
Adding new test that process metrics code and checks the expected results. Starting with easy ipc metric. Signed-off-by: Jiri Olsa --- tools/perf/tests/Build | 1 + tools/perf/tests/builtin-test.c | 4 + tools/perf/tests/parse-metric.c | 145

[PATCH 11/13] perf tools: Add test_generic_metric function

2020-06-02 Thread Jiri Olsa
Adding test_generic_metric that prepares and runs given metric over the data from psswd struct runtime_stat object. Signed-off-by: Jiri Olsa --- tools/perf/util/stat-shadow.c | 14 ++ tools/perf/util/stat.h| 3 +++ 2 files changed, 17 insertions(+) diff --git

[PATCH 01/13] perf tools: Add fake pmu support

2020-06-02 Thread Jiri Olsa
Adding the way to create pmu event without the actual PMU being in place. This way we can test metrics defined for any processors. The interface is to define fake_pmu in struct parse_events_state data. It will be used only in tests via special interface function added in following changes.

[PATCH 08/13] perf tools: Add metricgroup__parse_groups_test function

2020-06-02 Thread Jiri Olsa
Adding metricgroup__parse_groups_test function. It will be used as test's interface to metric parsing in following changes. Signed-off-by: Jiri Olsa --- tools/perf/util/metricgroup.c | 11 +++ tools/perf/util/metricgroup.h | 9 + 2 files changed, 20 insertions(+) diff --git

[PATCH 04/13] perf tests: Add another metric parsing test

2020-06-02 Thread Jiri Olsa
The test goes through all metrics compiled for arch within pmu events and try to parse them. This test is different from 'test_parsing' in that we go through all the events in the current arch, not just one defined for current CPU model. Using 'fake_pmu' to parse events which do not have PMUs

[PATCH 03/13] perf tests: Factor check_parse_id function

2020-06-02 Thread Jiri Olsa
Separating the generic part of check_parse_id function, so it can be used in following changes for the new test. Signed-off-by: Jiri Olsa --- tools/perf/tests/pmu-events.c | 21 +++-- 1 file changed, 15 insertions(+), 6 deletions(-) diff --git a/tools/perf/tests/pmu-events.c

[PATCH 02/13] perf tools: Add fake_pmu bool to parse_events interface

2020-06-02 Thread Jiri Olsa
Adding fake_pmu bool argument parse_events interface to parse events and use fake pmu event in case pmu event is parsed. This way it's possible to parse events from PMUs which are not present in the system. It's available only for testing purposes coming in following changes, so all the current

[PATCH 13/13] perf tests: Add parse metric test for frontend metric

2020-06-02 Thread Jiri Olsa
Adding new metri test for frontend metric. It's stolen from x86 pmu events. Signed-off-by: Jiri Olsa --- tools/perf/tests/parse-metric.c | 25 + 1 file changed, 25 insertions(+) diff --git a/tools/perf/tests/parse-metric.c b/tools/perf/tests/parse-metric.c index

[PATCH 05/13] perf tools: Factor out parse_groups function

2020-06-02 Thread Jiri Olsa
Factor out the parse_groups function, it will be used for new test interface coming in following changes. Signed-off-by: Jiri Olsa --- tools/perf/util/metricgroup.c | 22 -- 1 file changed, 16 insertions(+), 6 deletions(-) diff --git a/tools/perf/util/metricgroup.c

[PATCH 07/13] perf tools: Add map to parse_events function

2020-06-02 Thread Jiri Olsa
For testing purposes we need to pass our own map of events from parse_groups through metricgroup__add_metric. Signed-off-by: Jiri Olsa --- tools/perf/util/metricgroup.c | 23 +-- 1 file changed, 13 insertions(+), 10 deletions(-) diff --git a/tools/perf/util/metricgroup.c

[PATCH v2 1/2] video: fbdev: amifb: add FIXME about dead APUS support

2020-06-02 Thread Bartlomiej Zolnierkiewicz
On 5/14/20 10:21 PM, Geert Uytterhoeven wrote: > These #ifdefs are relics from APUS (Amiga Power-Up System), which > added a PPC board. APUS support was killed off a long time ago, > when arch/ppc/ was still king, but these #ifdefs were missed, because > they didn't test for CONFIG_APUS. Add

Re: [PATCHv2] perf stat: Ensure group is defined on top of the same cpu mask

2020-06-02 Thread Namhyung Kim
Hi Jiri, On Tue, Jun 2, 2020 at 5:16 PM Jiri Olsa wrote: > > On Tue, Jun 02, 2020 at 11:47:19AM +0900, Namhyung Kim wrote: > > On Tue, Jun 2, 2020 at 1:21 AM Ian Rogers wrote: > > > > > > On Mon, Jun 1, 2020 at 1:20 AM Jiri Olsa wrote: > > > > > > > > Jin Yao reported the issue (and posted

[PATCH] mm/slub: fix a memory leak in sysfs_slab_add()

2020-06-02 Thread Wang Hai
syzkaller reports for memory leak when kobject_init_and_add() returns an error in the function sysfs_slab_add() [1] When this happened, the function kobject_put() is not called for the corresponding kobject, which potentially leads to memory leak. This patch fixes the issue by calling

[PATCH] usb: host: ehci-exynos: Fix error check in exynos_ehci_probe()

2020-06-02 Thread Tang Bin
If the function platform_get_irq() failed, the negative value returned will not be detected here. So fix error handling in exynos_ehci_probe(). And when get irq failed, the function platform_get_irq() logs an error message, so remove redundant message here. Fixes: 1bcc5aa87f04 ("USB: Add initial

[PATCHv2 2/3] dt-binding: phy: ti,omap-usb2: Add quirk to disable charger detection

2020-06-02 Thread Roger Quadros
Add "ti,dis-chg-det-quirk" property to disable the USB2_PHY Charger Detect logic. Signed-off-by: Roger Quadros --- Documentation/devicetree/bindings/phy/ti,omap-usb2.yaml | 5 + 1 file changed, 5 insertions(+) diff --git a/Documentation/devicetree/bindings/phy/ti,omap-usb2.yaml

[PATCHv2 3/3] phy: omap-usb2-phy: disable PHY charger detect

2020-06-02 Thread Roger Quadros
AM654x PG1.0 has a silicon bug that D+ is pulled high after POR, which could cause enumeration failure with some USB hubs. Disabling the USB2_PHY Charger Detect function will put D+ into the normal state. Using property "ti,dis-chg-det-quirk" in the DT usb2-phy node to enable this workaround for

[PATCHv2 1/3] dt-binding: phy: convert ti,omap-usb2 to YAML

2020-06-02 Thread Roger Quadros
Move ti,omap-usb2 to its own YAML schema. Signed-off-by: Roger Quadros --- .../devicetree/bindings/phy/ti,omap-usb2.yaml | 69 +++ .../devicetree/bindings/phy/ti-phy.txt| 37 -- 2 files changed, 69 insertions(+), 37 deletions(-) create mode 100644

<    4   5   6   7   8   9   10   11   12   >