Re: [PATCH v2] block: Fix use-after-free in blkdev_get()

2020-06-05 Thread Dan Carpenter
On Fri, Jun 05, 2020 at 12:56:45PM +0200, Markus Elfring wrote: > > A lot of maintainers have blocked Markus and asked him to stop trying > > to help people write commit message. > > I am trying to contribute a bit of patch review as usual. > We have asked you again and again to stop commenting

Re: [PATCH] drm/i915/gvt: print actionable error message when gm runs out

2020-06-05 Thread Julian Stecklina
On Fri, 2020-06-05 at 12:54 +0800, Zhenyu Wang wrote: > On 2020.06.03 14:33:21 +0200, Julian Stecklina wrote: > > + gvt_err("vgpu%d: failed to allocate %s gm space from host\n", > > + vgpu->id, high_gm ? "high" : "low"); > > + gvt_err("vgpu%d: destroying

Re: [PATCH] soc: xilinx: Fix error code in zynqmp_pm_probe()

2020-06-05 Thread Michal Simek
On 05. 06. 20 13:00, Dan Carpenter wrote: > This should be returning PTR_ERR() but it returns IS_ERR() instead. > > Fixes: ffdbae28d9d1 ("drivers: soc: xilinx: Use mailbox IPI callback") > Signed-off-by: Dan Carpenter > --- > drivers/soc/xilinx/zynqmp_power.c | 2 +- > 1 file changed, 1

Fail to build tftpboot.img

2020-06-05 Thread Corentin Labbe
Hello For reinstalling an old SPARC machine , I need a netboot image. I tried to create it via make tftpboot.img but got: BUILD: sparc to /home/compile/crossbuild/next/sparc/sparc64/defconfig make[1]: Entering directory '/usr/src/crossbuild/next/sparc/sparc64/defconfig' GEN Makefile

Re: [PATCH v3] block: Fix use-after-free in blkdev_get()

2020-06-05 Thread Sedat Dilek
On Fri, Jun 5, 2020 at 12:23 PM Jason Yan wrote: > > In blkdev_get() we call __blkdev_get() to do some internal jobs and if > there is some errors in __blkdev_get(), the bdput() is called which > means we have released the refcount of the bdev (actually the refcount of > the bdev inode). This

kprobes string reading broken on s390

2020-06-05 Thread Sven Schnelle
Hi Christoph, with the latest linux-next i noticed that some tests in the ftrace test suites are failing on s390, namely: [FAIL] Kprobe event symbol argument [FAIL] Kprobe event with comm arguments The following doesn't work anymore: cd /sys/kernel/tracing echo 'p:testprobe _do_fork comm=$comm

[PATCH] cxlflash: remove an unnecessary NULL check

2020-06-05 Thread Dan Carpenter
The "cmd" pointer was already dereferenced a couple lines earlier so this NULL check is too late. Fortunately, the pointer can never be NULL and the check can be removed. Signed-off-by: Dan Carpenter --- drivers/scsi/cxlflash/main.c | 3 --- 1 file changed, 3 deletions(-) diff --git

Re: [PATCH v4] platform: x86: Add ACPI driver for ChromeOS

2020-06-05 Thread Rafael J. Wysocki
On Monday, April 13, 2020 4:12:59 PM CEST Greg Kroah-Hartman wrote: > Meta-comment to the ACPI developers, shouldn't all of this happen > "automatically" with the existing ACPI entries in sysfs? I'm not quite sure what you mean by "all of this" here. Can you please explain? > If not, is this

[PATCH] soc: xilinx: Fix error code in zynqmp_pm_probe()

2020-06-05 Thread Dan Carpenter
This should be returning PTR_ERR() but it returns IS_ERR() instead. Fixes: ffdbae28d9d1 ("drivers: soc: xilinx: Use mailbox IPI callback") Signed-off-by: Dan Carpenter --- drivers/soc/xilinx/zynqmp_power.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH 1/2] sched/uclamp: Add a new sysctl to control RT default boost value

2020-06-05 Thread Qais Yousef
On 06/04/20 14:40, Mel Gorman wrote: > > > > The diffs are smaller than on openSUSE Leap 15.1 and some of the > > > > uclamp taskgroup results are better? > > > > > > > > > > I don't see the stddev and coeff but these look close to borderline. > > > Sure, they are marked with a * so it passed a

Re: [PATCH v2] spi: bcm2835: Enable shared interrupt support

2020-06-05 Thread Nicolas Saenz Julienne
On Fri, 2020-06-05 at 10:46 +0200, Nicolas Saenz Julienne wrote: > Hi Florian, > Thanks for taking over this! > > On Thu, 2020-06-04 at 14:28 -0700, Florian Fainelli wrote: > > The 4 SPI controller instances added in BCM2711 and BCM7211 SoCs (SPI3, > > SPI4, SPI5 and SPI6) share the same

Дорогой друг, Меня зовут Барроберт Андерсон. Я адвокат и частный менеджер по работе с клиентами покойному клиенту. В 2015 году мой клиент по имени Мистер Карлос, скончался, причина, по которой я связа

2020-06-05 Thread robert

Re: [PATCH -tip v3 1/2] kcov: Make runtime functions noinstr-compatible

2020-06-05 Thread Dmitry Vyukov
On Fri, Jun 5, 2020 at 10:28 AM Marco Elver wrote: > > While we lack a compiler attribute to add to noinstr that would disable > KCOV, make the KCOV runtime functions return if the caller is in a > noinstr section, and mark them noinstr. > > Declare write_comp_data() as __always_inline to ensure

Re: BUG: kernel NULL pointer dereference from check_preempt_wakeup()

2020-06-05 Thread Peter Zijlstra
On Fri, Jun 05, 2020 at 12:38:59PM +0200, Peter Zijlstra wrote: > On Thu, Jun 04, 2020 at 03:54:45PM -0700, Paul E. McKenney wrote: > > Hello! > > > > I get the splat below at a rate of roughly two per thirty hours when > > running rcutorture scenario TREE03 on x86 at the June 3rd mainline

Re: [PATCH v2] block: Fix use-after-free in blkdev_get()

2020-06-05 Thread Markus Elfring
> A lot of maintainers have blocked Markus and asked him to stop trying > to help people write commit message. I am trying to contribute a bit of patch review as usual. > Saying "bdev" instead of "block device" is more clear I find this view interesting. > so your original message was

Re: [PATCH] gpio: arizona: put pm_runtime in case of failure

2020-06-05 Thread Charles Keepax
On Thu, Jun 04, 2020 at 10:00:52PM -0500, Navid Emamdoost wrote: > Calling pm_runtime_get_sync increments the counter even in case of > failure, causing incorrect ref count if pm_runtime_put is not called in > error handling paths. Call pm_runtime_put if pm_runtime_get_sync fails. > >

Re: [PATCH] gpio: arizona: handle pm_runtime_get_sync failure case

2020-06-05 Thread Charles Keepax
On Thu, Jun 04, 2020 at 09:52:07PM -0500, Navid Emamdoost wrote: > Calling pm_runtime_get_sync increments the counter even in case of > failure, causing incorrect ref count. Call pm_runtime_put if > pm_runtime_get_sync fails. > > Signed-off-by: Navid Emamdoost > --- Acked-by: Charles Keepax

Re: [PATCH] mfd: arizona: handle pm_runtime_get_sync failure case

2020-06-05 Thread Charles Keepax
On Thu, Jun 04, 2020 at 09:47:13PM -0500, Navid Emamdoost wrote: > Calling pm_runtime_get_sync increments the counter even in case of > failure, causing incorrect ref count. Call pm_runtime_put_sync if > pm_runtime_get_sync fails. > > Signed-off-by: Navid Emamdoost > --- Acked-by: Charles

Re: [PATCH v2 2/2] nvmem: add ONIE NVMEM cells support

2020-06-05 Thread Vadym Kochan
Hi Srinivas, On Mon, Jun 01, 2020 at 01:27:49PM +0300, Vadym Kochan wrote: > On Mon, Jun 01, 2020 at 10:13:05AM +0100, Srinivas Kandagatla wrote: > > > > > > On 01/06/2020 10:03, Vadym Kochan wrote: > > > > > + > > > > > + nvmem = of_nvmem_device_get(np, NULL); > > > > > + if

Re: [PATCH v2] spi: bcm2835: Enable shared interrupt support

2020-06-05 Thread Mark Brown
On Fri, Jun 05, 2020 at 10:46:57AM +0200, Nicolas Saenz Julienne wrote: > > -static irqreturn_t bcm2835_spi_interrupt(int irq, void *dev_id) > > +static inline irqreturn_t bcm2835_spi_interrupt_common(struct > > spi_controller > > *ctlr, > > + u32

Re: LTP: syscalls: regression on mainline - ioctl_loop01 mknod07 setns01

2020-06-05 Thread Naresh Kamboju
On Fri, 5 Jun 2020 at 13:58, Jan Stancek wrote: > > > > - Original Message - > > Following three test cases reported as regression on Linux mainline kernel > > on x86_64, arm64, arm and i386 > > > > ltp-syscalls-tests: > > * ioctl_loop01 > > * mknod07 > > Test updated: > >

Re: [PATCH v4 04/11] watchdog: add support for sl28cpld watchdog

2020-06-05 Thread Andy Shevchenko
On Fri, Jun 5, 2020 at 1:24 PM Michael Walle wrote: > Am 2020-06-05 10:14, schrieb Andy Shevchenko: > > On Fri, Jun 5, 2020 at 12:14 AM Michael Walle wrote: ... > >> +static bool nowayout = WATCHDOG_NOWAYOUT; > >> +module_param(nowayout, bool, 0); > >> +MODULE_PARM_DESC(nowayout, "Watchdog

Re: [PATCH v7 01/13] tools/libperf: introduce notion of static polled file descriptors

2020-06-05 Thread Jiri Olsa
On Wed, Jun 03, 2020 at 06:52:59PM +0300, Alexey Budankov wrote: > > Implement adding of file descriptors by fdarray__add_stat() to > fix-sized (currently 1) stat_entries array located at struct fdarray. > Append added file descriptors to the array used by poll() syscall > during fdarray__poll()

Re: [PATCH v2] spi: bcm2835: Enable shared interrupt support

2020-06-05 Thread Lukas Wunner
On Thu, Jun 04, 2020 at 02:28:19PM -0700, Florian Fainelli wrote: > The 4 SPI controller instances added in BCM2711 and BCM7211 SoCs (SPI3, > SPI4, SPI5 and SPI6) share the same interrupt line with SPI0. > > For the BCM2835 case which is deemed performance critical, we would like > to continue

Re: [PATCH v5 13/13] perf record: introduce --ctl-fd[-ack] options

2020-06-05 Thread Jiri Olsa
On Tue, Jun 02, 2020 at 04:43:58PM +0300, Adrian Hunter wrote: > On 2/06/20 12:12 pm, Alexey Budankov wrote: > > > > On 02.06.2020 11:32, Alexey Budankov wrote: > >> > >> On 02.06.2020 2:37, Andi Kleen wrote: > > or a pathname, or including also the event default of "disabled". > >

Re: [PATCH v4 02/11] mfd: Add support for Kontron sl28cpld management controller

2020-06-05 Thread Mark Brown
On Fri, Jun 05, 2020 at 07:57:09AM +0100, Lee Jones wrote: > On Thu, 04 Jun 2020, Michael Walle wrote: > > + sl28cpld->regmap = devm_regmap_init_i2c(i2c, _regmap_config); > > + if (IS_ERR(sl28cpld->regmap)) > > + return PTR_ERR(sl28cpld->regmap); > This is now a shared memory

Re: [PATCH RESEND v3 0/6] arm64: add the time namespace support

2020-06-05 Thread Mark Rutland
Hi Andrei, As a heads up, in mainline the arm64 vdso code has been refactored since v5.7, and this series will need to be rebased atop. Given we're in the middle of the merge window, I would suggest waiting until rc1 before posting a rebased series. In the meantime, the relevant patches can be

Re: [PATCH v4 02/11] mfd: Add support for Kontron sl28cpld management controller

2020-06-05 Thread Andy Shevchenko
On Fri, Jun 5, 2020 at 1:09 PM Michael Walle wrote: > Am 2020-06-05 10:01, schrieb Andy Shevchenko: > > On Fri, Jun 5, 2020 at 12:16 AM Michael Walle wrote: ... > >> + bool "Kontron sl28 core driver" > >> + depends on I2C=y > > > > Why not module? > > There are users of the

RE: [PATCH v2 1/4] ARC: allow to override default mcpu compiler flag

2020-06-05 Thread Alexey Brodkin
Hi Eugeniy, A couple of minor notes below. > -Original Message- > From: Eugeniy Paltsev > Sent: Thursday, June 4, 2020 8:39 PM > To: linux-snps-...@lists.infradead.org; Vineet Gupta > Cc: linux-kernel@vger.kernel.org; Alexey Brodkin ; > Eugeniy Paltsev > > Subject: [PATCH v2 1/4]

Re: [PATCH RFC v4 00/13] virtio-mem: paravirtualized memory

2020-06-05 Thread Alex Shi
在 2020/6/5 下午6:05, David Hildenbrand 写道: >> I guess I know what's happening here. In case we only have DMA memory >> when booting, we don't reserve swiotlb buffers. Once we hotplug memory >> and online ZONE_NORMAL, we don't have any swiotlb DMA bounce buffers to >> map such PFNs (total 0

Re: [PATCH 1/2] sched/uclamp: Add a new sysctl to control RT default boost value

2020-06-05 Thread Qais Yousef
On 06/04/20 14:14, Vincent Guittot wrote: > I have tried your patch and I don't see any difference compared to > previous tests. Let me give you more details of my setup: > I create 3 levels of cgroups and usually run the tests in the 4 levels > (which includes root). The result above are for the

Re: unable to compile after "module: Make module_enable_ro() static again"

2020-06-05 Thread Jessica Yu
+++ Anatoly Pugachev [05/06/20 13:21 +0300]: Hello! i'm unable to compile kernel on debian sid/unstable (tested on sparc64 and ppc64) after commit e6eff4376e2897c2e14b70d87bf7284cdb093830 There are some module changes that still need to be merged that should fix this issue. Please wait until

Re: [RFC PATCH] panic: fix deadlock in panic()

2020-06-05 Thread chengjian (D)
Hi, Petr On 2020/6/4 16:29, Petr Mladek wrote: It might cause double unlock (deadlock) on architectures that did not use NMI to stop the CPUs. I have created a conservative fix for this problem for SLES, see

Re: [PATCH v3 19/25] clk: bcm: rpi: Add DT provider for the clocks

2020-06-05 Thread Nicolas Saenz Julienne
On Wed, 2020-05-27 at 17:45 +0200, Maxime Ripard wrote: > For the upcoming registration of the clocks provided by the firmware, make > sure it's exposed to the device tree providers. > > Cc: Michael Turquette > Cc: linux-...@vger.kernel.org > Reviewed-by: Stephen Boyd > Signed-off-by: Maxime

Re: BUG: kernel NULL pointer dereference from check_preempt_wakeup()

2020-06-05 Thread Peter Zijlstra
On Thu, Jun 04, 2020 at 03:54:45PM -0700, Paul E. McKenney wrote: > Hello! > > I get the splat below at a rate of roughly two per thirty hours when > running rcutorture scenario TREE03 on x86 at the June 3rd mainline commit: > > cb8e59cc8720 ("Merge >

Re: [PATCH v3 18/25] clk: bcm: rpi: Make the PLLB registration function return a clk_hw

2020-06-05 Thread Nicolas Saenz Julienne
On Wed, 2020-05-27 at 17:45 +0200, Maxime Ripard wrote: > The raspberrypi_register_pllb has been returning an integer so far to > notify whether the functions has exited successfully or not. > > However, the OF provider functions in the clock framework require access to > the clk_hw structure so

Re: [PATCH] arm64: fpsimd: Added API to manage fpsimd state inside kernel

2020-06-05 Thread Mark Rutland
Hi Wooyeon, There are a *lot* of people Cc' here, many of whomo will find this irrelevant. Please try to keep the Cc list constrained to a reasonable number of interested parties. On Fri, Jun 05, 2020 at 04:30:52PM +0900, Wooyeon Kim wrote: > From: Wooki Min > > This is an patch to use

[PATCH v2 2/2] ASoC: dt-bindings: mediatek: mt6358: add dmic-mode property

2020-06-05 Thread Jiaxin Yu
Adds dmic-mode property and updates example. Signed-off-by: Jiaxin Yu --- Documentation/devicetree/bindings/sound/mt6358.txt | 6 ++ 1 file changed, 6 insertions(+) diff --git a/Documentation/devicetree/bindings/sound/mt6358.txt b/Documentation/devicetree/bindings/sound/mt6358.txt index

[PATCH v2 1/2] ASoC: mediatek: mt6358: support DMIC one-wire mode

2020-06-05 Thread Jiaxin Yu
Supports DMIC one-wire mode. Uses a DT property "dmic-mode" to select. Signed-off-by: Jiaxin Yu --- sound/soc/codecs/mt6358.c | 23 ++- 1 file changed, 22 insertions(+), 1 deletion(-) diff --git a/sound/soc/codecs/mt6358.c b/sound/soc/codecs/mt6358.c index 1b830ea..1f39d59

[PATCH v2 0/2] ASoC: mediatek: mt6358: support DMIC one-wire mode

2020-06-05 Thread Jiaxin Yu
v2 changes: 1. Uses a DT property to select DMIC mode instead of a mixer control. v1 changes: 1. Uses a mixer control to select DMIC mode. 2. patchwork list: https://patchwork.kernel.org/patch/11578309 Jiaxin Yu (2): ASoC: mediatek: mt6358: support DMIC

Re: [PATCH v3 17/25] clk: bcm: rpi: Split pllb clock hooks

2020-06-05 Thread Nicolas Saenz Julienne
On Wed, 2020-05-27 at 17:45 +0200, Maxime Ripard wrote: > The driver only supports the pllb for now and all the clock framework hooks > are a mix of the generic firmware interface and the specifics of the pllb. > Since we will support more clocks in the future let's split the generic and >

[PATCH RESEND 5/5] ifcvf: implement config interrupt in IFCVF

2020-06-05 Thread Zhu Lingshan
This commit implements config interrupt support in IFC VF Signed-off-by: Zhu Lingshan Acked-by: Jason Wang --- drivers/vdpa/ifcvf/ifcvf_base.c | 3 +++ drivers/vdpa/ifcvf/ifcvf_base.h | 4 drivers/vdpa/ifcvf/ifcvf_main.c | 23 ++- 3 files changed, 29 insertions(+), 1

[PATCH RESEND 3/5] vhost_vdpa: Support config interrupt in vdpa

2020-06-05 Thread Zhu Lingshan
This commit implements config interrupt support in vhost_vdpa layer. Signed-off-by: Zhu Lingshan Acked-by: Jason Wang --- drivers/vhost/vdpa.c | 47 ++ include/uapi/linux/vhost.h | 4 2 files changed, 51 insertions(+) diff --git

[PATCH RESEND 2/5] ifcvf: ignore continuous setting same staus value

2020-06-05 Thread Zhu Lingshan
User space may try to set status of same value for multiple times, this patch can handle this case more efficiently by ignoring the same value of status settings. Signed-off-by: Zhu Lingshan --- drivers/vdpa/ifcvf/ifcvf_main.c | 3 +++ 1 file changed, 3 insertions(+) diff --git

[PATCH RESEND 4/5] vhost: replace -1 with VHOST_FILE_UNBIND in iotcls

2020-06-05 Thread Zhu Lingshan
This commit replaces -1 with VHOST_FILE_UNBIND in ioctls since we have added such a macro in the uapi header for vdpa_host. Signed-off-by: Zhu Lingshan Acked-by: Jason Wang --- drivers/vhost/vhost.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git

[PATCH RESEND 1/5] ifcvf: move IRQ request/free to status change handlers

2020-06-05 Thread Zhu Lingshan
To comply with VIRTIO spec, this commit intends to move IRQ request and free operations from probe() to device status changing handler, would handle datapath start/stop in the handler as well. VIRTIO spec 1.1, section 2.1.2 Device Requirements: Device Status Field The device MUST NOT consume

[PATCH RESEND 0/5] vDPA:config interrupt support and IRQ improvements

2020-06-05 Thread Zhu Lingshan
This series intends to introduce: (1) config interrupt in vhost_vdpa and IFCVF. (2) handle datapath and IRQ managent in the status handler, so that it would comply to virtio spec, and more reliable Most patches already got ACKed, excepted for ifcvf: ignore continuous setting same staus value

Re: [PATCH 3/3] spi: bcm2835: Enable shared interrupt support

2020-06-05 Thread Mark Brown
On Thu, Jun 04, 2020 at 09:05:46AM -0700, Florian Fainelli wrote: > On 6/4/2020 5:32 AM, Mark Brown wrote: > > This feels hacky - it's essentially using the compatible string to set a > > boolean flag which isn't really about the IP but rather the platform > > integration. It might cause

sound/soc/amd/raven/acp3x-pcm-dma.c:305:23: warning: variable 'card' set but not used

2020-06-05 Thread kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 435faf5c218a47fd6258187f62d9bb1009717896 commit: 4a0434502191347ba8f99468f2fb2cdddc20d381 ASoC: amd: Removing unnecessary instance initialization date: 8 days ago config: i386-randconfig-r014-20200605

Re: [PATCH v4 04/11] watchdog: add support for sl28cpld watchdog

2020-06-05 Thread Michael Walle
Am 2020-06-05 10:14, schrieb Andy Shevchenko: On Fri, Jun 5, 2020 at 12:14 AM Michael Walle wrote: Add support for the watchdog of the sl28cpld board management controller. This is part of a multi-function device driver. ... +#include Didn't find a user of this. I guess

Re: [PATCH v5 0/4] introduction of migration_version attribute for VFIO live migration

2020-06-05 Thread Dr. David Alan Gilbert
* Alex Williamson (alex.william...@redhat.com) wrote: > On Wed, 3 Jun 2020 01:24:43 -0400 > Yan Zhao wrote: > > > On Tue, Jun 02, 2020 at 09:55:28PM -0600, Alex Williamson wrote: > > > On Tue, 2 Jun 2020 23:19:48 -0400 > > > Yan Zhao wrote: > > > > > > > On Tue, Jun 02, 2020 at 04:55:27PM

Re: [PATCH 0/2] overlayfs: C/R enhancements

2020-06-05 Thread Amir Goldstein
On Fri, Jun 5, 2020 at 11:41 AM Pavel Tikhomirov wrote: > > > > On 6/5/20 5:35 AM, Amir Goldstein wrote: > > On Fri, Jun 5, 2020 at 12:34 AM Alexander Mikhalitsyn > > wrote: > >> > >> Hello, > >> > >>> But overlayfs won't accept these "output only" options as input args, > >> which is a problem.

unable to compile after "module: Make module_enable_ro() static again"

2020-06-05 Thread Anatoly Pugachev
Hello! i'm unable to compile kernel on debian sid/unstable (tested on sparc64 and ppc64) after commit e6eff4376e2897c2e14b70d87bf7284cdb093830 ~/linux-2.6$ git bisect bad e6eff4376e2897c2e14b70d87bf7284cdb093830 is the first bad commit commit e6eff4376e2897c2e14b70d87bf7284cdb093830 Author: Josh

Re: system time goes weird in kvm guest after host suspend/resume

2020-06-05 Thread Miklos Szeredi
On Fri, Jun 5, 2020 at 12:12 PM Thomas Gleixner wrote: > > Paolo Bonzini writes: > > On 04/06/20 21:28, Miklos Szeredi wrote: > >> time(2) returns good time, while clock_gettime(2) returns bad time. > >> Here's an example: > >> > >> time=1591298725 RT=1591300383 MONO=39582 MONO_RAW=39582

Re: [PATCH] regulator: do not balance 'boot-on' coupled regulators without constraints

2020-06-05 Thread Mark Brown
On Fri, Jun 05, 2020 at 08:37:24AM +0200, Marek Szyprowski wrote: > Balancing of the 'boot-on' coupled regulators must wait until the clients > set their constraints, otherwise the balancing code might change the No, this is not what boot-on means at all. It is there for cases where we can't

mainline: v4l2 modules missing Kconfigs

2020-06-05 Thread Naresh Kamboju
The test v4l2-compliance modprobe-vivid failed Test error, VIDEO_DRIVER=vivid.ko v4l2-existence-check pass ln: failed to create symbolic link '/lib/modules/5.7.0+/' -> '': No such file or directory modprobe: FATAL: Module vivid not found in directory /lib/modules/5.7.0+ modprobe-vivid fail The

[PATCH v3] block: Fix use-after-free in blkdev_get()

2020-06-05 Thread Jason Yan
In blkdev_get() we call __blkdev_get() to do some internal jobs and if there is some errors in __blkdev_get(), the bdput() is called which means we have released the refcount of the bdev (actually the refcount of the bdev inode). This means we cannot access bdev after that point. But accually bdev

Re: [PATCH v2] scsi: st: convert convert get_user_pages() --> pin_user_pages()

2020-06-05 Thread Kai Mäkisara (Kolumbus)
> On 26. May 2020, at 21.27, John Hubbard wrote: > > This code was using get_user_pages*(), in a "Case 1" scenario > (Direct IO), using the categorization from [1]. That means that it's > time to convert the get_user_pages*() + put_page() calls to > pin_user_pages*() + unpin_user_pages()

Re: ARM: imx6: add missing put_device() call in imx6q_suspend_init()

2020-06-05 Thread Markus Elfring
>> Do you find a previous update suggestion useful? >> >> ARM: imx6: Add missing put_device() call in imx6q_suspend_init() >> https://lore.kernel.org/linux-arm-kernel/5acd7308-f6e1-4b1e-c744-bb2e5fdca...@web.de/ >> https://lore.kernel.org/patchwork/patch/1151158/ >>

Re: stress-ng --hrtimers hangs system

2020-06-05 Thread Vladimir Oltean
Hi Paul, On Fri, 5 Jun 2020 at 06:20, Paul E. McKenney wrote: > > > That agrees with my interpretation of the stall warning message. > > On the rest, I must defer to others. > > Thanx, Paul > Thanks, always good to have a confirmation

Re: system time goes weird in kvm guest after host suspend/resume

2020-06-05 Thread Thomas Gleixner
Paolo Bonzini writes: > On 04/06/20 21:28, Miklos Szeredi wrote: >> time(2) returns good time, while clock_gettime(2) returns bad time. >> Here's an example: >> >> time=1591298725 RT=1591300383 MONO=39582 MONO_RAW=39582 BOOT=39582 >> time=1591298726 RT=1591300383 MONO=39582 MONO_RAW=39582

Re: [PATCH v4 02/11] mfd: Add support for Kontron sl28cpld management controller

2020-06-05 Thread Michael Walle
Hi Andy, Am 2020-06-05 10:01, schrieb Andy Shevchenko: On Fri, Jun 5, 2020 at 12:16 AM Michael Walle wrote: Add the core support for the board management controller found on the SMARC-sAL28 board. It consists of the following functions: - watchdog - GPIO controller - PWM controller - fan

Re: [PATCH RFC v4 00/13] virtio-mem: paravirtualized memory

2020-06-05 Thread Alex Shi
在 2020/6/5 下午5:36, David Hildenbrand 写道: > I guess I know what's happening here. In case we only have DMA memory > when booting, we don't reserve swiotlb buffers. Once we hotplug memory > and online ZONE_NORMAL, we don't have any swiotlb DMA bounce buffers to > map such PFNs (total 0 (slots),

Re: [PATCH v3 1/7] mm: Add functions to track page directory modifications

2020-06-05 Thread Catalin Marinas
Hi Joerg, On Fri, May 15, 2020 at 04:00:17PM +0200, Joerg Roedel wrote: > diff --git a/include/linux/mm.h b/include/linux/mm.h > index 5a323422d783..022fe682af9e 100644 > --- a/include/linux/mm.h > +++ b/include/linux/mm.h > @@ -2078,13 +2078,54 @@ static inline pud_t *pud_alloc(struct mm_struct

[PATCH v1 2/2] ARM: dts: aspeed: mihawk: Add 8 tmp401 thermal sensor

2020-06-05 Thread Ben Pai
Signed-off-by: Ben Pai --- arch/arm/boot/dts/aspeed-bmc-opp-mihawk.dts | 40 + 1 file changed, 40 insertions(+) diff --git a/arch/arm/boot/dts/aspeed-bmc-opp-mihawk.dts b/arch/arm/boot/dts/aspeed-bmc-opp-mihawk.dts index 25ffe65fbdc0..5bf1f13dda3b 100644 ---

Re: [PATCH RFC v4 00/13] virtio-mem: paravirtualized memory

2020-06-05 Thread David Hildenbrand
On 05.06.20 11:36, David Hildenbrand wrote: > On 05.06.20 11:08, David Hildenbrand wrote: >> On 05.06.20 10:55, Alex Shi wrote: >>> >>> >>> 在 2020/1/9 下午9:48, David Hildenbrand 写道: Ping, I'd love to get some feedback on a) The remaining MM bits from MM folks (especially,

[PATCH v1 1/2] ARM: dts: aspeed: mihawk: IO expander uses TCA9554 driver

2020-06-05 Thread Ben Pai
Set smbus_en of IO expander to 1 in order to be able to read sensor. Signed-off-by: Ben Pai --- arch/arm/boot/dts/aspeed-bmc-opp-mihawk.dts | 112 1 file changed, 112 insertions(+) diff --git a/arch/arm/boot/dts/aspeed-bmc-opp-mihawk.dts

Re: [PATCH RFC v4 00/13] virtio-mem: paravirtualized memory

2020-06-05 Thread Alex Shi
在 2020/6/5 下午5:08, David Hildenbrand 写道: > Please use the virtio-mem-v4 branch for now, v5 is still under > construction (and might be scrapped completely if v4 goes upstream as is). > > Looks like a DMA issue. Your're hotplugging 1GB, which should not really > eat too much memory. There was a

Re: [PATCH RFC] uaccess: user_access_begin_after_access_ok()

2020-06-05 Thread Jason Wang
On 2020/6/5 上午12:49, Michael S. Tsirkin wrote: 2. Second argument to translate_desc is a GPA, isn't it? No, it's IOVA, this function will be called only when IOTLB is enabled. Thanks Right IOVA. Point stands how does it make sense to cast a userspace pointer to an IOVA? I guess it's just

Re: v5.7: new core kernel option missing help text

2020-06-05 Thread Valentin Schneider
On 05/06/20 09:15, Russell King - ARM Linux admin wrote: > On Thu, Jun 04, 2020 at 04:38:40PM +0100, Valentin Schneider wrote: >> diff --git a/init/Kconfig b/init/Kconfig >> index 74a5ac65644f..ba846f6e805b 100644 >> --- a/init/Kconfig >> +++ b/init/Kconfig >> @@ -439,8 +439,11 @@ config

Re: [PATCH] mm/vmalloc: track which page-table levels were modified

2020-06-05 Thread Mike Rapoport
On Fri, Jun 05, 2020 at 10:16:44AM +0200, Joerg Roedel wrote: > On Thu, Jun 04, 2020 at 02:12:14PM -0700, Linus Torvalds wrote: > > That said, the commentary about "why is p.._alloc_track() in such a > > core header file, when it's only used by two special cases" is > > probably still true

powerpc64le-linux-ld: mm/page_alloc.o:undefined reference to `node_reclaim_distance'

2020-06-05 Thread kernel test robot
: 3 months ago config: powerpc-randconfig-r006-20200605 (attached as .config) compiler: powerpc64le-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross

Re: [PATCH] kernel/modules: fix build without ARCH_HAS_STRICT_MODULE_RWX

2020-06-05 Thread Jessica Yu
+++ Miroslav Benes [05/06/20 09:50 +0200]: Hi, On Thu, 4 Jun 2020, Max Filippov wrote: On configurations with CONFIG_ARCH_HAS_STRICT_MODULE_RWX disabled kernel build fails with the following message: kernel/module.c:3593:2: error: implicit declaration of function ‘module_enable_ro’; Add

[v2, 1/2] ASoC: mediatek: mt6358: support DMIC one-wire mode

2020-06-05 Thread Jiaxin Yu
Supports DMIC one-wire mode. Uses a DT property "dmic-mode" to select. Signed-off-by: Jiaxin Yu --- sound/soc/codecs/mt6358.c | 23 ++- 1 file changed, 22 insertions(+), 1 deletion(-) diff --git a/sound/soc/codecs/mt6358.c b/sound/soc/codecs/mt6358.c index 1b830ea..1f39d59

[v2, 2/2] ASoC: dt-bindings: mediatek: mt6358: add dmic-mode property

2020-06-05 Thread Jiaxin Yu
Adds dmic-mode property and updates example. Signed-off-by: Jiaxin Yu --- Documentation/devicetree/bindings/sound/mt6358.txt | 6 ++ 1 file changed, 6 insertions(+) diff --git a/Documentation/devicetree/bindings/sound/mt6358.txt b/Documentation/devicetree/bindings/sound/mt6358.txt index

Re: [PATCH] ovl: explicitly initialize error in ovl_copy_xattr()

2020-06-05 Thread Miklos Szeredi
On Thu, Jun 4, 2020 at 5:57 PM Kees Cook wrote: > > On Thu, Jun 04, 2020 at 10:42:45AM +0200, gli...@google.com wrote: > > Under certain circumstances (we found this out running Docker on a > > Clang-built kernel with CONFIG_INIT_STACK_ALL) ovl_copy_xattr() may > > return uninitialized value of

Re: [PATCH v6 4/4] kdb: Switch to use safer dbg_io_ops over console APIs

2020-06-05 Thread Petr Mladek
On Thu 2020-06-04 15:31:19, Sumit Garg wrote: > In kgdb context, calling console handlers aren't safe due to locks used > in those handlers which could in turn lead to a deadlock. Although, using > oops_in_progress increases the chance to bypass locks in most console > handlers but it might not be

Re: [RFC PATCH] gpio: uapi: v2 proposal

2020-06-05 Thread Bartosz Golaszewski
czw., 4 cze 2020 o 18:00 Kent Gibson napisał(a): > [snip!] > > > + > > > +enum gpioline_edge { > > > + GPIOLINE_EDGE_NONE = 0, > > > + GPIOLINE_EDGE_RISING= 1, > > > + GPIOLINE_EDGE_FALLING = 2, > > > + GPIOLINE_EDGE_BOTH =

Re: [PATCH 1/2] MIPS: set page access bit with pgprot on some MIPS platform

2020-06-05 Thread maobibo
On 06/05/2020 05:39 PM, Jiaxun Yang wrote: > On Fri, 5 Jun 2020 17:11:05 +0800 > Bibo Mao wrote: > >> On MIPS system which has rixi hardware bit, page access bit is not >> set in pgrot. For memory reading, there will be one page fault to >> allocate physical page; however valid bit is not

Re: [PATCH v4 02/11] mfd: Add support for Kontron sl28cpld management controller

2020-06-05 Thread Michael Walle
Hi Lee, thanks for the review. Am 2020-06-05 08:57, schrieb Lee Jones: Mark, what do you think? On Thu, 04 Jun 2020, Michael Walle wrote: Add the core support for the board management controller found on the SMARC-sAL28 board. It consists of the following functions: - watchdog - GPIO

Re: linux-next: build failure after merge of the origin tree

2020-06-05 Thread Jessica Yu
+++ Josh Poimboeuf [04/06/20 19:04 -0500]: On Fri, Jun 05, 2020 at 08:37:15AM +1000, Stephen Rothwell wrote: Hi all, After merging the origin tree, today's linux-next build (powerpc ppc64_defconfig) failed like this: kernel/module.c: In function 'do_init_module': kernel/module.c:3593:2:

Re: [PATCH] ovl: explicitly initialize error in ovl_copy_xattr()

2020-06-05 Thread Alexander Potapenko
On Thu, Jun 4, 2020 at 5:57 PM Kees Cook wrote: > > On Thu, Jun 04, 2020 at 10:42:45AM +0200, gli...@google.com wrote: > > Under certain circumstances (we found this out running Docker on a > > Clang-built kernel with CONFIG_INIT_STACK_ALL) ovl_copy_xattr() may > > return uninitialized value of

Re: v5.7: new core kernel option missing help text

2020-06-05 Thread Valentin Schneider
On 05/06/20 08:03, Vincent Guittot wrote: > On Thu, 4 Jun 2020 at 17:38, Valentin Schneider > wrote: >> --- >> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig >> index 16fbf74030fe..1e92080dc275 100644 >> --- a/arch/arm/Kconfig >> +++ b/arch/arm/Kconfig >> @@ -46,6 +46,7 @@ config ARM >>

[PATCH v4 4/6] PCI: uniphier: Add iATU register support

2020-06-05 Thread Kunihiko Hayashi
This gets iATU register area from reg property. In Synopsys DWC version 4.80 or later, since iATU register area is separated from core register area, this area is necessary to get from DT independently. Signed-off-by: Kunihiko Hayashi --- drivers/pci/controller/dwc/pcie-uniphier.c | 5 + 1

[PATCH v4 5/6] PCI: uniphier: Add error message when failed to get phy

2020-06-05 Thread Kunihiko Hayashi
Even if phy driver doesn't probe, the error message can't be distinguished from other errors. This displays error message caused by the phy driver explicitly. Signed-off-by: Kunihiko Hayashi --- drivers/pci/controller/dwc/pcie-uniphier.c | 8 ++-- 1 file changed, 6 insertions(+), 2

[PATCH v4 2/6] PCI: uniphier: Add misc interrupt handler to invoke PME and AER

2020-06-05 Thread Kunihiko Hayashi
The misc interrupts consisting of PME, AER, and Link event, is handled by INTx handler, however, these interrupts should be also handled by MSI handler. This adds the function uniphier_pcie_misc_isr() that handles misc interrupts, which is called from both INTx and MSI handlers. This function

[PATCH v4 0/6] PCI: uniphier: Add features for UniPhier PCIe host controller

2020-06-05 Thread Kunihiko Hayashi
This series adds some features for UniPhier PCIe host controller. - Add support for PME and AER invoked by MSI interrupt - Add iATU register view support for PCIe version >= 4.80 - Add an error message when failing to get phy driver This adds a new function called by MSI handler in DesignWare

[PATCH v4 6/6] PCI: uniphier: Use devm_platform_ioremap_resource_byname()

2020-06-05 Thread Kunihiko Hayashi
Use devm_platform_ioremap_resource_byname() to simplify the code a bit. Signed-off-by: Kunihiko Hayashi --- drivers/pci/controller/dwc/pcie-uniphier.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/pci/controller/dwc/pcie-uniphier.c

[PATCH v4 3/6] dt-bindings: PCI: uniphier: Add iATU register description

2020-06-05 Thread Kunihiko Hayashi
In the dt-bindings, "atu" reg-names is required to get the register space for iATU in Synopsys DWC version 4.80 or later. Signed-off-by: Kunihiko Hayashi Acked-by: Rob Herring --- Documentation/devicetree/bindings/pci/uniphier-pcie.txt | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH v4 1/6] PCI: dwc: Add msi_host_isr() callback

2020-06-05 Thread Kunihiko Hayashi
This adds msi_host_isr() callback function support to describe SoC-dependent service triggered by MSI. For example, when AER interrupt is triggered by MSI, the callback function reads SoC-dependent registers and detects that the interrupt is from AER, and invoke AER interrupts related to MSI.

Re: [PATCH v2] block: Fix use-after-free in blkdev_get()

2020-06-05 Thread Dan Carpenter
A lot of maintainers have blocked Markus and asked him to stop trying to help people write commit message. Saying "bdev" instead of "block device" is more clear so your original message was better. The Fixes tag is a good idea though: Fixes: 89e524c04fa9 ("loop: Fix mount(2) failure due to race

Re: [RFC PATCH v5 2/3] docs: scheduler: Add scheduler overview documentation

2020-06-05 Thread John Mathew
On Fri, May 29, 2020 at 5:48 PM Vincent Guittot wrote: > > On Thu, 14 May 2020 at 11:26, john mathew wrote: > > > > From: John Mathew > > > > Add documentation for > > -scheduler overview > > -scheduler state transtion > > -CFS overview > > -scheduler data structs > > > > Add rst for

答复: 答复: [PATCH][v6] KVM: X86: support APERF/MPERF registers

2020-06-05 Thread Li,Rongqing
> -邮件原件- > 发件人: Like Xu [mailto:like...@linux.intel.com] > 发送时间: 2020年6月5日 13:29 > 收件人: Li,Rongqing ; like...@intel.com > 抄送: linux-kernel@vger.kernel.org; k...@vger.kernel.org; x...@kernel.org; > h...@zytor.com; b...@alien8.de; mi...@redhat.com; t...@linutronix.de; >

Re: [RFC PATCH v5 2/3] docs: scheduler: Add scheduler overview documentation

2020-06-05 Thread John Mathew
On Fri, May 29, 2020 at 2:00 PM Peter Zijlstra wrote: > > On Thu, May 14, 2020 at 12:26:36PM +0300, john mathew wrote: > > > += > > +CFS Overview > > += > > + > > +Linux 2.6.23 introduced a modular scheduler core and a Completely Fair > > +Scheduler (CFS) implemented as a

Re: [PATCH 1/2] MIPS: set page access bit with pgprot on some MIPS platform

2020-06-05 Thread Jiaxun Yang
On Fri, 5 Jun 2020 17:11:05 +0800 Bibo Mao wrote: > On MIPS system which has rixi hardware bit, page access bit is not > set in pgrot. For memory reading, there will be one page fault to > allocate physical page; however valid bit is not set, there will > be the second fast tlb-miss fault

Re: [RFC][PATCH 5/7] irq_work, smp: Allow irq_work on call_single_queue

2020-06-05 Thread Peter Zijlstra
On Fri, May 29, 2020 at 03:36:41PM +0200, Peter Zijlstra wrote: > Maybe I can anonymous-union my way around it, dunno. I'll think about > it. I'm certainly not proud of this. But at least the BUILD_BUG_ON()s > should catch the more blatant breakage here. How's this then? Differently ugly, but at

Re: slub freelist issue / BUG: unable to handle page fault for address: 000000003ffe0018

2020-06-05 Thread Vegard Nossum
On 2020-06-05 11:11, Vlastimil Babka wrote: On 6/4/20 8:46 PM, Vlastimil Babka wrote: On 6/4/20 7:57 PM, Kees Cook wrote: On Thu, Jun 04, 2020 at 07:20:18PM +0200, Vegard Nossum wrote: On 2020-06-04 19:18, Vlastimil Babka wrote: On 6/4/20 7:14 PM, Vegard Nossum wrote: Hi all, I ran into

Re: [PATCH 2/2] scripts/spelling: Add a few more typos

2020-06-05 Thread David Hildenbrand
On 05.06.20 11:25, SeongJae Park wrote: > From: SeongJae Park > > This commit adds typos I found from another works. > > Signed-off-by: SeongJae Park > --- > scripts/spelling.txt | 9 + > 1 file changed, 9 insertions(+) > > diff --git a/scripts/spelling.txt b/scripts/spelling.txt >

Re: [PATCH RFC v4 00/13] virtio-mem: paravirtualized memory

2020-06-05 Thread David Hildenbrand
On 05.06.20 11:08, David Hildenbrand wrote: > On 05.06.20 10:55, Alex Shi wrote: >> >> >> 在 2020/1/9 下午9:48, David Hildenbrand 写道: >>> Ping, >>> >>> I'd love to get some feedback on >>> >>> a) The remaining MM bits from MM folks (especially, patch #6 and #8). >>> b) The general virtio

Re: [PATCH] crypto: hisilicon - fix strncpy warning with strlcpy

2020-06-05 Thread Zhangfei Gao
On 2020/6/4 下午2:50, Herbert Xu wrote: On Thu, Jun 04, 2020 at 02:44:16PM +0800, Zhangfei Gao wrote: I think it is fine. 1. Currently the name size is 64, bigger enough. Simply grep in driver name, 64 should be enough. We can make it larger when there is a request. 2. it does not matter what

<    5   6   7   8   9   10   11   12   >