Re: [PATCH v1 3/6] serial: sunzilog: Return proper error code from console ->setup() hook

2020-06-18 Thread David Miller
From: Andy Shevchenko Date: Thu, 18 Jun 2020 19:47:48 +0300 > For unifying console ->setup() handling, which is pure documented, > return error code, rather than non-zero arbitrary number. > > Signed-off-by: Andy Shevchenko > Cc: "David S. Miller" Acked-by: David S. Miller

Re: [PATCH v1 2/6] serial: sunsab: Return proper error code from console ->setup() hook

2020-06-18 Thread David Miller
From: Andy Shevchenko Date: Thu, 18 Jun 2020 19:47:47 +0300 > For unifying console ->setup() handling, which is pure documented, > return error code, rather than non-zero arbitrary number. > > Signed-off-by: Andy Shevchenko > Cc: "David S. Miller" Acked-by: David S. Miller

Re: 回复: [PATCH] f2fs-tools: set cold flag for non-dir node

2020-06-18 Thread Chao Yu
On 2020/6/19 10:21, Zac wrote: >> On 2020/6/18 20:48, zhaowu...@wingtech.com wrote: >>> From: Wuyun Zhao >> >> Thanks for the patch. :) >> >> Please add commit message here. > > OK > >>> >>> Signed-off-by: Wuyun Zhao >>> --- >>> fsck/dir.c | 1 + >>> fsck/node.c | 1 + >>> fsck/node.h | 11

[GIT PULL] overflow helper addition for v5.8-rc2

2020-06-18 Thread Kees Cook
Hi Linus, Please pull this tiny overflow helper addition for v5.8-rc2. During the treewide clean-ups of zero-length "flexible arrays", the struct_size() helper was heavily used, but it was noticed that many times it would have been nice to have an additional helper to get the size of just the

Re: [PATCH net] net: dsa: bcm_sf2: Fix node reference count

2020-06-18 Thread David Miller
From: Andrew Lunn Date: Thu, 18 Jun 2020 14:56:40 +0200 > That if_find_node_by_name() does a put is not very intuitive. > Maybe document that as well in the kerneldocs? > > Reviewed-by: Andrew Lunn I've been complaining about the non-intuitiveness of the various OF interfaces for a long time.

Re: kernel BUG at mm/huge_memory.c:2613!

2020-06-18 Thread Andrea Arcangeli
Hello, On Thu, Jun 18, 2020 at 06:14:49PM -0700, Roman Gushchin wrote: > I agree. The whole > > page = alloc_pages_node(nid, alloc_flags, order); > if (!page) > continue; > if (!order) > break; > if (!PageCompound(page)) { >

[tip:x86/cpu] BUILD SUCCESS c9a1ff316bc9b1d1806a4366d0aef6e18833ba52

2020-06-18 Thread kernel test robot
allmodconfig powerpc allnoconfig i386 randconfig-a002-20200618 i386 randconfig-a006-20200618 i386 randconfig-a001-20200618 i386 randconfig-a004-20200618 i386 randconfig-a005

Re: [PATCH 2/2] nvmet: remove workarounds for gcc bug wrt unnamed fields in initializers

2020-06-18 Thread kernel test robot
Hi Niklas, I love your patch! Yet something to improve: [auto build test ERROR on block/for-next] [also build test ERROR on linus/master v5.8-rc1 next-20200618] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use as documented

[PATCH 0/2] Add new UniPhier AHCI PHY driver

2020-06-18 Thread Kunihiko Hayashi
This series adds support for AHCI PHY interface implemented in Socionext UniPhier SoCs. This driver supports PXs2 and PXs3 SoCs. Kunihiko Hayashi (2): dt-bindings: phy: Add UniPhier AHCI PHY description phy: socionext: Add UniPhier AHCI PHY driver support

[PATCH 1/2] dt-bindings: phy: Add UniPhier AHCI PHY description

2020-06-18 Thread Kunihiko Hayashi
Add DT bindings for PHY interface built into ahci controller implemented in UniPhier SoCs. Signed-off-by: Kunihiko Hayashi --- .../bindings/phy/socionext,uniphier-ahci-phy.yaml | 76 ++ 1 file changed, 76 insertions(+) create mode 100644

[PATCH 2/2] phy: socionext: Add UniPhier AHCI PHY driver support

2020-06-18 Thread Kunihiko Hayashi
Add a driver for PHY interface built into ahci controller implemented in UniPhier SoCs. This supports PXs2 and PXs3 SoCs. Signed-off-by: Kunihiko Hayashi --- drivers/phy/socionext/Kconfig | 10 + drivers/phy/socionext/Makefile| 1 +

Re: [PATCH net-next v8 2/5] net: phy: Add a helper to return the index for of the internal delay

2020-06-18 Thread kernel test robot
Hi Dan, I love your patch! Yet something to improve: [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Dan-Murphy/RGMII-Internal-delay-common-property/20200619-051238 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git

Re: [PATCH v8 0/5] support reserving crashkernel above 4G on arm64 kdump

2020-06-18 Thread John Donnelly
On 6/4/20 12:01 PM, Nicolas Saenz Julienne wrote: On Thu, 2020-06-04 at 01:17 +0530, Bhupesh Sharma wrote: Hi All, On Wed, Jun 3, 2020 at 9:03 PM John Donnelly wrote: On Jun 3, 2020, at 8:20 AM, chenzhou wrote: Hi, On 2020/6/3 19:47, Prabhakar Kushwaha wrote: Hi Chen, On Tue, Jun

Re: [PATCH v1 0/6] console: unify return codes from ->setup() hook

2020-06-18 Thread Sergey Senozhatsky
On (20/06/18 19:47), Andy Shevchenko wrote: > Some of the console providers treat error code, returned by ->setup() hook, > differently. Here is the unification of the behaviour. > > The drivers checked by one of the below criteria: > 1/ the driver has explicit struct console .setup assignment >

Re: [PATCH 0/2] Introduce PCI_FIXUP_IOMMU

2020-06-18 Thread Zhangfei Gao
Hi, Bjorn On 2020/6/16 上午7:52, Bjorn Helgaas wrote: On Sat, Jun 13, 2020 at 10:30:56PM +0800, Zhangfei Gao wrote: On 2020/6/11 下午9:44, Bjorn Helgaas wrote: +++ b/drivers/iommu/iommu.c @@ -2418,6 +2418,10 @@ int iommu_fwspec_init(struct device *dev, struct fwnode_handle *iommu_fwnode,

Re: [PATCH 1/2] nvme: remove workarounds for gcc bug wrt unnamed fields in initializers

2020-06-18 Thread kernel test robot
Hi Niklas, I love your patch! Yet something to improve: [auto build test ERROR on block/for-next] [also build test ERROR on linus/master v5.8-rc1 next-20200618] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use as documented

回复: [PATCH] f2fs-tools: set cold flag for non-dir node

2020-06-18 Thread Zac
> On 2020/6/18 20:48, zhaowu...@wingtech.com wrote: > > From: Wuyun Zhao > > Thanks for the patch. :) > > Please add commit message here. OK > > > > Signed-off-by: Wuyun Zhao > > --- > > fsck/dir.c | 1 + > > fsck/node.c | 1 + > > fsck/node.h | 11 +++ > > 3 files changed, 13

[PATCH] drm/rockchip: vop: fix vop full rgb24 r/b color error

2020-06-18 Thread Sandy Huang
RGB888 format msb is red component and the lsb is blue component, at vop full platform this is swapped, and this is different from vop lite and vop next, so add this patch to fix it. Signed-off-by: Sandy Huang --- drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 8 1 file changed, 8

RE: [PATCH v2 1/3] docs: IOMMU user API

2020-06-18 Thread Liu, Yi L
Hi Alex, > From: Alex Williamson > Sent: Friday, June 19, 2020 5:48 AM > > On Wed, 17 Jun 2020 08:28:24 + > "Tian, Kevin" wrote: > > > > From: Liu, Yi L > > > Sent: Wednesday, June 17, 2020 2:20 PM > > > > > > > From: Jacob Pan > > > > Sent: Tuesday, June 16, 2020 11:22 PM > > > > > > >

Re: [PATCH 3/3] rcu/trace: Add name of the source for gp_seq to prevent confusion

2020-06-18 Thread Joel Fernandes
On Thu, Jun 18, 2020 at 09:36:41PM -0400, Joel Fernandes (Google) wrote: [...] > @@ -2019,7 +2019,7 @@ static int __noreturn rcu_gp_kthread(void *unused) > cond_resched_tasks_rcu_qs(); > WRITE_ONCE(rcu_state.gp_activity, jiffies); >

Re: [PATCH] drm/lima: Expose job_hang_limit module parameter

2020-06-18 Thread Qiang Yu
On Thu, Jun 18, 2020 at 10:58 PM Andrey Lebedev wrote: > > From: Andrey Lebedev > > Some pp or gp jobs can be successfully repeated even after they time outs. > Introduce lima module parameter to specify number of times a job can hang > before being dropped. > > Signed-off-by: Andrey Lebedev >

Re: Re: [PATCH] [v3] dmaengine: tegra210-adma: Fix runtime PM imbalance on error

2020-06-18 Thread dinghao . liu
> > Why noidle? > _noidle is enough for fixing this bug. _sync may suspend the device beyond expectation. Regards, Dinghao

Re: [PATCH v2] tracing/boottime: Fix kprobe multiple events

2020-06-18 Thread Masami Hiramatsu
On Thu, 18 Jun 2020 18:33:01 +0200 Sascha Ortmann wrote: > Fix boottime kprobe events to report and abort after each failure when > adding probes. > > As an example, when we try to set multiprobe kprobe events in > bootconfig like this: > > ftrace.event.kprobes.vfsevents { > probes =

Re: [PATCH v4 1/3] virtio: add dma-buf support for exported objects

2020-06-18 Thread David Stevens
On Thu, Jun 18, 2020 at 9:29 PM Guennadi Liakhovetski wrote: > > Hi Michael, > > On Thu, Jun 04, 2020 at 03:05:23PM -0400, Michael S. Tsirkin wrote: > > On Tue, May 26, 2020 at 07:58:09PM +0900, David Stevens wrote: > > > This change adds a new flavor of dma-bufs that can be used by virtio > > >

[PATCH] hwmon: (dell-smm) Add Latitude 5480 to fan control whitelist

2020-06-18 Thread Jeffrey Lin
This allows manual PWM control without the BIOS fighting back on Dell Latitude 5480. Signed-off-by: Jeffrey Lin --- drivers/hwmon/dell-smm-hwmon.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/hwmon/dell-smm-hwmon.c b/drivers/hwmon/dell-smm-hwmon.c index

Re: [PATCH] Fix unwind_frame for clang-built kernels

2020-06-18 Thread Miles Chen
On Thu, 2020-06-18 at 13:22 -0700, Nick Desaulniers wrote: > On Tue, Jun 16, 2020 at 3:36 PM 'Nathan Huckleberry' via Clang Built > Linux wrote: > > > > Since clang does not push pc and sp in function prologues, the current > > implementation of unwind_frame does not work. By using the previous >

Re: [PATCH] RISC-V: Acquire mmap lock before invoking walk_page_range

2020-06-18 Thread Palmer Dabbelt
On Wed, 17 Jun 2020 13:37:32 PDT (-0700), Atish Patra wrote: As per walk_page_range documentation, mmap lock should be acquired by the caller before invoking walk_page_range. mmap_assert_locked gets triggered without that. The details can be found here.

[PATCH] thermal/drivers/cpufreq_cooling: Fix wrong frequency converted from power

2020-06-18 Thread Finley Xiao
The function cpu_power_to_freq is used to find a frequency and set the cooling device to consume at most the power to be converted. For example, if the power to be converted is 80mW, and the em table is as follow. struct em_cap_state table[] = { /* KHz mW */ { 1008000, 36, 0 },

[tip:x86/fsgsbase] BUILD SUCCESS 5e7ec8578fa3dada50c50f5b234fa8d154b76349

2020-06-18 Thread kernel test robot
rhel-kconfig powerpc allmodconfig powerpc allnoconfig powerpc defconfig i386 randconfig-a002-20200618 i386 randconfig-a006-20200618 i386 randconfig-a001-20200618

[RESEND PATCH v2 1/3] spi: altera: use regmap-mmio instead of direct mmio register access

2020-06-18 Thread Xu Yilun
This patch adds support for regmap. It makes preparation for supporting different ways to access the registers. Signed-off-by: Matthew Gerlach Signed-off-by: Wu Hao Signed-off-by: Xu Yilun Signed-off-by: Russ Weight Reviewed-by : Tom Rix --- drivers/spi/Kconfig | 1 +

[RESEND PATCH v2 2/3] spi: altera: support indirect access to the registers

2020-06-18 Thread Xu Yilun
This patch adds support for indirect access to the registers via parent regmap. The use case is, the spi master is a sub device of a Multifunction device, which is connected to host by some indirect bus. To support this device type, a new platform_device_id is introduced, and the driver tries to

[RESEND PATCH v2 3/3] spi: altera: fix size mismatch on 64 bit processors

2020-06-18 Thread Xu Yilun
From: Matthew Gerlach The spi-altera driver was originally written with a 32 bit processor, where sizeof(unsigned long) is 4. On a 64 bit processor sizeof(unsigned long) is 8. Change the structure member to u32 to match the actual size of the control register. Signed-off-by: Matthew Gerlach

[RESEND PATCH v2 0/3] add regmap & indirect access support

2020-06-18 Thread Xu Yilun
Updated the regmap & indirect access support for spi-altera. Patch #1 is an 1:1 replacement of of readl/writel with regmap_read/write Patch #2 introduced a new platform_device_id to support indirect access as a sub device. Patch #3 is a minor fix. Main changes from v1: - Split the

Re: Security Random Number Generator support

2020-06-18 Thread Neal Liu
Hi Marc, On Thu, 2020-06-18 at 10:50 +0100, Marc Zyngier wrote: > On 2020-06-03 08:54, Neal Liu wrote: > > Hi Neal, > > > Do you know which ARM expert could edict this standard? > > Or is there any chance that we can make one? And be reviewed by > > maintainers? > > It appears that ARM just

Re: [PATCH 1/5] f2fs: fix to wait page writeback before update

2020-06-18 Thread Chao Yu
Hi Jaegeuk, On 2020/6/19 7:59, Jaegeuk Kim wrote: > Hi Chao, > > On 06/18, Chao Yu wrote: >> to make page content stable for special device like raid. > > Could you elaborate the problem a bit? Some devices like raid5 wants page content to be stable, because it will calculate parity info based

Re: [PATCH][next] fpga: dfl: Use struct_size() in kzalloc()

2020-06-18 Thread Moritz Fischer
On Wed, Jun 17, 2020 at 05:10:39PM -0500, Gustavo A. R. Silva wrote: > Make use of the struct_size() helper instead of an open-coded version > in order to avoid any potential type mistakes. Also, remove unnecessary > function dfl_feature_platform_data_size(). > > This code was detected with the

Re: [PATCH v2 2/2] fpga: Fix dead store in fpga-bridge.c

2020-06-18 Thread Moritz Fischer
On Mon, Jun 08, 2020 at 05:54:46AM -0700, t...@redhat.com wrote: > From: Tom Rix > > Using clang's scan-build/view this issue was flagged > a dead store issue in fpga-bridge.c > > warning: Value stored to 'ret' is never read [deadcode.DeadStores] > ret = id; > >

Re: [PATCH v2 1/2] fpga: Fix dead store fpga-mgr.c

2020-06-18 Thread Moritz Fischer
On Mon, Jun 08, 2020 at 05:54:45AM -0700, t...@redhat.com wrote: > From: Tom Rix > > Using clang's scan-build/view this issue was flagged in fpga-mgr.c > > drivers/fpga/fpga-mgr.c:585:3: warning: Value stored to 'ret' is never read > [deadcode.DeadStores] > ret = id; > >

Re: [PATCH 3/5] fpga manager: xilinx-spi: remove unneeded, mistyped variables

2020-06-18 Thread Moritz Fischer
On Thu, Jun 11, 2020 at 11:11:42PM +0200, Luca Ceresoli wrote: > Using variables does not add readability here: parameters passed > to udelay*() are obviously in microseconds and their meaning is clear > from the context. > > The type is also wrong, udelay expects an unsigned long. > >

Re: [PATCH 2/5] fpga manager: xilinx-spi: valid for the 7 Series too

2020-06-18 Thread Moritz Fischer
On Thu, Jun 11, 2020 at 11:11:41PM +0200, Luca Ceresoli wrote: > The Xilinx 7-series uses the same protocol, mention that. > > Signed-off-by: Luca Ceresoli > --- > drivers/fpga/xilinx-spi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/fpga/xilinx-spi.c

Re: [PATCH 1/5] dt-bindings: fpga: xilinx-slave-serial: valid for the 7 Series too

2020-06-18 Thread Moritz Fischer
On Wed, Jun 17, 2020 at 04:38:41PM -0600, Rob Herring wrote: > On Thu, 11 Jun 2020 23:11:40 +0200, Luca Ceresoli wrote: > > The Xilinx 7-series uses the same protocol, mention that. > > > > Signed-off-by: Luca Ceresoli > > --- > > .../devicetree/bindings/fpga/xilinx-slave-serial.txt | 9

[PATCH 3/3] rcu/trace: Add name of the source for gp_seq to prevent confusion

2020-06-18 Thread Joel Fernandes (Google)
The gp_seq value can come from either of rdp, rsp or rnp. This makes the rcu_grace_period tracepoint extremely confusing since once if left constantly applying effort to reason about what a gp_seq means. Only the rsp is the global source of truth (most accurate GP info). The rnp can be off by ~1

[PATCH 1/3] rcu/trace: Print negative GP numbers correctly

2020-06-18 Thread Joel Fernandes (Google)
GP numbers start from -300 and gp_seq numbers start of -1200 (for a shift of 2). These negative numbers are printed as unsigned long which not only takes up more text space, but is rather confusing to the reader as they have to constantly expend energy to truncate the number. Just print the

[PATCH 2/3] rcu/trace: Use gp_seq_req in acceleration's rcu_grace_period tracepoint

2020-06-18 Thread Joel Fernandes (Google)
During acceleration of CB, the rsp's gp_seq is rcu_seq_snap'd. This is the value used for acceleration - it is the value of gp_seq at which it is safe the execute all callbacks in the callback list. The rdp's gp_seq is not very useful for this scenario. Make rcu_grace_period report the gp_seq_req

Re: [PATCH V3 (RESEND) 0/3] arm64: Enable vmemmap mapping from device memory

2020-06-18 Thread Anshuman Khandual
On 06/18/2020 02:26 PM, Mike Rapoport wrote: > On Thu, Jun 18, 2020 at 06:45:27AM +0530, Anshuman Khandual wrote: >> This series enables vmemmap backing memory allocation from device memory >> ranges on arm64. But before that, it enables vmemmap_populate_basepages() >> and

Re: [PATCH v6 4/6] mm/swapcache: support to handle the exceptional entries in swapcache

2020-06-18 Thread Joonsoo Kim
On Wed, Jun 17, 2020 at 05:17:17AM -0700, Matthew Wilcox wrote: > On Wed, Jun 17, 2020 at 02:26:21PM +0900, js1...@gmail.com wrote: > > From: Joonsoo Kim > > > > Swapcache doesn't handle the exceptional entries since there is no case > > Don't call them exceptional entries. > > The radix tree

Re: [PATCH] RISC-V: Acquire mmap lock before invoking walk_page_range

2020-06-18 Thread Atish Patra
On Wed, Jun 17, 2020 at 7:29 PM Zong Li wrote: > > On Thu, Jun 18, 2020 at 8:01 AM Michel Lespinasse wrote: > > > > On Wed, Jun 17, 2020 at 1:38 PM Atish Patra wrote: > > > As per walk_page_range documentation, mmap lock should be acquired by the > > > caller before invoking walk_page_range.

Re: [PATCH] f2fs-tools: set cold flag for non-dir node

2020-06-18 Thread Chao Yu
On 2020/6/18 20:48, zhaowu...@wingtech.com wrote: > From: Wuyun Zhao Thanks for the patch. :) Please add commit message here. > > Signed-off-by: Wuyun Zhao > --- > fsck/dir.c | 1 + > fsck/node.c | 1 + > fsck/node.h | 11 +++ > 3 files changed, 13 insertions(+) > > diff --git

Re: [PATCH v6 05/19] mm: memcontrol: decouple reference counting from page accounting

2020-06-18 Thread Shakeel Butt
On Mon, Jun 8, 2020 at 4:07 PM Roman Gushchin wrote: > > From: Johannes Weiner > > The reference counting of a memcg is currently coupled directly to how > many 4k pages are charged to it. This doesn't work well with Roman's > new slab controller, which maintains pools of objects and doesn't

Re: [PATCH v6 00/19] The new cgroup slab memory controller

2020-06-18 Thread Roman Gushchin
On Thu, Jun 18, 2020 at 11:31:21AM +0200, Jesper Dangaard Brouer wrote: > On Thu, 18 Jun 2020 10:43:44 +0200 > Jesper Dangaard Brouer wrote: > > > On Wed, 17 Jun 2020 18:29:28 -0700 > > Roman Gushchin wrote: > > > > > On Wed, Jun 17, 2020 at 01:24:21PM +0200, Vlastimil Babka wrote: > > > >

Re: [PATCH v2 0/6] add regmap & indirect access support

2020-06-18 Thread Xu Yilun
On Thu, Jun 18, 2020 at 04:35:39PM +0100, Mark Brown wrote: > On Thu, Jun 18, 2020 at 11:25:07PM +0800, Xu Yilun wrote: > > Updated the regmap & indirect access support for spi-altera. > > > > Patch #1, #2, #3 is already applied. > > The numbering for patches within a series is there *only* to

Re: [PATCH v6 00/19] The new cgroup slab memory controller

2020-06-18 Thread Roman Gushchin
On Thu, Jun 18, 2020 at 10:43:44AM +0200, Jesper Dangaard Brouer wrote: > On Wed, 17 Jun 2020 18:29:28 -0700 > Roman Gushchin wrote: > > > On Wed, Jun 17, 2020 at 01:24:21PM +0200, Vlastimil Babka wrote: > > > On 6/17/20 5:32 AM, Roman Gushchin wrote: > > > > On Tue, Jun 16, 2020 at 08:05:39PM

Re: kernel BUG at mm/huge_memory.c:2613!

2020-06-18 Thread Yang Shi
On Thu, Jun 18, 2020 at 6:15 PM Roman Gushchin wrote: > > On Thu, Jun 18, 2020 at 05:46:24PM -0700, Yang Shi wrote: > > On Thu, Jun 18, 2020 at 5:19 PM Roman Gushchin wrote: > > > > > > Hi! > > > > > > I was consistently hitting a VM_BUG_ON_PAGE() in split_huge_page_to_list() > > > when running

Re: [PATCH v6 05/19] mm: memcontrol: decouple reference counting from page accounting

2020-06-18 Thread Shakeel Butt
On Thu, Jun 18, 2020 at 6:08 PM Roman Gushchin wrote: > > On Thu, Jun 18, 2020 at 07:55:35AM -0700, Shakeel Butt wrote: > > Not sure if my email went through, so, re-sending. > > > > On Mon, Jun 8, 2020 at 4:07 PM Roman Gushchin wrote: > > > > > > From: Johannes Weiner > > > > > [...] > > > @@

Re: kernel BUG at mm/huge_memory.c:2613!

2020-06-18 Thread Roman Gushchin
On Thu, Jun 18, 2020 at 05:46:24PM -0700, Yang Shi wrote: > On Thu, Jun 18, 2020 at 5:19 PM Roman Gushchin wrote: > > > > Hi! > > > > I was consistently hitting a VM_BUG_ON_PAGE() in split_huge_page_to_list() > > when running vanilla 5.8-rc1 on my desktop. It was happening on every boot > >

Re: [PATCH v2] arm64: dts: qcom: sc7180: Add Display Port dt node

2020-06-18 Thread Stephen Boyd
Quoting Tanmay Shah (2020-06-18 16:21:13) > Enable DP driver for sc7180. Add DP device node on sc7180? This isn't a driver. > > This change depends-on following series: > https://patchwork.freedesktop.org/series/78583/ > and https://patchwork.freedesktop.org/patch/351990/ > > Changes in v2: >

Re: [PATCH v6 05/19] mm: memcontrol: decouple reference counting from page accounting

2020-06-18 Thread Roman Gushchin
On Thu, Jun 18, 2020 at 07:55:35AM -0700, Shakeel Butt wrote: > Not sure if my email went through, so, re-sending. > > On Mon, Jun 8, 2020 at 4:07 PM Roman Gushchin wrote: > > > > From: Johannes Weiner > > > [...] > > @@ -3003,13 +3004,16 @@ void __memcg_kmem_uncharge_page(struct page *page, >

Re: [PATCH 3/7] rcu/trace: Add name of the source for gp_seq

2020-06-18 Thread Joel Fernandes
On Thu, Jun 18, 2020 at 05:12:01PM -0700, Paul E. McKenney wrote: > On Thu, Jun 18, 2020 at 07:51:17PM -0400, Joel Fernandes wrote: > > On Thu, Jun 18, 2020 at 03:19:01PM -0700, Paul E. McKenney wrote: > > > On Thu, Jun 18, 2020 at 04:29:51PM -0400, Joel Fernandes (Google) wrote: > > > > The

Re: Parallel compilation performance regression

2020-06-18 Thread Matthew Wilcox
On Thu, Jun 18, 2020 at 11:52:55PM +, Derrick, Jonathan wrote: > Hi David, > > I've been experiencing a performance regression when running a parallel > compilation (eg, make -j72) on recent kernels. I bet you're using a version of make which predates 4.3:

Re: [PATCH 0/3] zone-append support in aio and io-uring

2020-06-18 Thread Damien Le Moal
On 2020/06/19 5:04, Matias Bjørling wrote: > On 18/06/2020 21.21, Kanchan Joshi wrote: >> On Thu, Jun 18, 2020 at 10:04:32AM +0200, Matias Bjørling wrote: >>> On 17/06/2020 19.23, Kanchan Joshi wrote: This patchset enables issuing zone-append using aio and io-uring direct-io interface.

Re: [PATCH 3/7] rcu/trace: Add name of the source for gp_seq

2020-06-18 Thread Joel Fernandes
On Thu, Jun 18, 2020 at 08:01:38PM -0400, Steven Rostedt wrote: > On Thu, 18 Jun 2020 15:19:01 -0700 > "Paul E. McKenney" wrote: > > > For future reference, the TPS() around strings is not optional. Without > > it, trace messages from crash dumps are garbled, if I remember correctly. > > When

Re: [PATCH 6/7] rcutorture: Add support to get the number of wakeups of main GP kthread

2020-06-18 Thread Joel Fernandes
On Thu, Jun 18, 2020 at 05:12:44PM -0700, Paul E. McKenney wrote: > On Thu, Jun 18, 2020 at 08:01:56PM -0400, Joel Fernandes wrote: > > On Thu, Jun 18, 2020 at 03:40:58PM -0700, Paul E. McKenney wrote: > > > On Thu, Jun 18, 2020 at 04:29:54PM -0400, Joel Fernandes (Google) wrote: > > > > This is

Re: [PATCH 3/7] rcu/trace: Add name of the source for gp_seq

2020-06-18 Thread Joel Fernandes
On Thu, Jun 18, 2020 at 05:12:01PM -0700, Paul E. McKenney wrote: > On Thu, Jun 18, 2020 at 07:51:17PM -0400, Joel Fernandes wrote: > > On Thu, Jun 18, 2020 at 03:19:01PM -0700, Paul E. McKenney wrote: > > > On Thu, Jun 18, 2020 at 04:29:51PM -0400, Joel Fernandes (Google) wrote: > > > > The

Re: [PATCH 1/1] iommu/vt-d: Fix misuse of iommu_domain_identity_map()

2020-06-18 Thread Jerry Snitselaar
On Fri Jun 19 20, Lu Baolu wrote: The iommu_domain_identity_map() helper takes start/end PFN as arguments. Fix a misuse case where the start and end addresses are passed. Fixes: e70b081c6f376 ("iommu/vt-d: Remove IOVA handling code from the non-dma_ops path") Cc: Tom Murphy Reported-by: Alex

Re: [PATCH 1/3] ARM: dts: change AM33XX_PADCONF macro separate conf and mux

2020-06-18 Thread kernel test robot
Hi Drew, Thank you for the patch! Yet something to improve: [auto build test ERROR on robh/for-next] [also build test ERROR on omap/for-next pinctrl/devel v5.8-rc1 next-20200618] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use

Re: [PATCH v5 3/3] net: phy: mscc: handle the clkout control on some phy variants

2020-06-18 Thread kernel test robot
Hi Heiko, I love your patch! Yet something to improve: [auto build test ERROR on robh/for-next] [also build test ERROR on sparc-next/master net-next/master net/master linus/master v5.8-rc1 next-20200618] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting

Re: [PATCH v6 35/36] videobuf2: use sgtable-based scatterlist wrappers

2020-06-18 Thread kernel test robot
Hi Marek, I love your patch! Yet something to improve: [auto build test ERROR on next-20200618] [also build test ERROR on v5.8-rc1] [cannot apply to linuxtv-media/master staging/staging-testing drm-exynos/exynos-drm-next drm-intel/for-linux-next linus/master v5.8-rc1 v5.7 v5.7-rc7] [If your

Re: [PATCH 2/2] riscv: Use PUD/PGDIR entries for linear mapping when possible

2020-06-18 Thread Atish Patra
On Wed, Jun 3, 2020 at 8:38 AM Alexandre Ghiti wrote: > > Improve best_map_size so that PUD or PGDIR entries are used for linear > mapping when possible as it allows better TLB utilization. > > Signed-off-by: Alexandre Ghiti > --- > arch/riscv/mm/init.c | 45

Re: kernel BUG at mm/huge_memory.c:2613!

2020-06-18 Thread Yang Shi
On Thu, Jun 18, 2020 at 5:19 PM Roman Gushchin wrote: > > Hi! > > I was consistently hitting a VM_BUG_ON_PAGE() in split_huge_page_to_list() > when running vanilla 5.8-rc1 on my desktop. It was happening on every boot > during the system start. I haven't seen this issue on 5.7. > > It looks like

Re: [PATCH 7/5] spi: spi-geni-qcom: Don't set {tx,rx}_rem_bytes unnecessarily

2020-06-18 Thread Doug Anderson
Hi, On Thu, Jun 18, 2020 at 4:40 PM Stephen Boyd wrote: > > We only need to test for these counters being non-zero when we see the > end of a transfer. If we're doing a CS change then they will already be > zero. This implies that we don't need to set these to 0 if we're > cancelling an in

Re: [PATCH 6/5] spi: spi-geni-qcom: Simplify setup_fifo_xfer()

2020-06-18 Thread Doug Anderson
Hi, On Thu, Jun 18, 2020 at 4:40 PM Stephen Boyd wrote: > > The definition of SPI_FULL_DUPLEX (3) is really SPI_TX_ONLY (1) ORed > with SPI_RX_ONLY (2). Let's drop the define and simplify the code here a > bit by collapsing the setting of 'm_cmd' into conditions that are the > same. > > This is

Re: [PATCH v4 5/5] spi: spi-geni-qcom: Don't keep a local state variable

2020-06-18 Thread Doug Anderson
Hi, On Thu, Jun 18, 2020 at 4:37 PM Stephen Boyd wrote: > > Quoting Doug Anderson (2020-06-18 15:00:10) > > On Thu, Jun 18, 2020 at 2:52 PM Stephen Boyd wrote: > > > > > > -8< > > > diff --git a/drivers/spi/spi-geni-qcom.c b/drivers/spi/spi-geni-qcom.c > > > index

Re: [PATCH] RISC-V: Don't allow write+exec only page mapping request in mmap

2020-06-18 Thread Palmer Dabbelt
On Tue, 16 Jun 2020 07:03:06 PDT (-0700), yash.s...@sifive.com wrote: As per the table 4.2 of the RISC-V instruction set manual[0], the PTE permission bit combination of "write+exec only" is invalid and reserved for future use. Hence, don't allow such mapping request in mmap call. An issue is

Re: severe proc dentry lock contention

2020-06-18 Thread Junxiao Bi
On 6/18/20 5:02 PM, ebied...@xmission.com wrote: Matthew Wilcox writes: On Thu, Jun 18, 2020 at 03:17:33PM -0700, Junxiao Bi wrote: When debugging some performance issue, i found that thousands of threads exit around same time could cause a severe spin lock contention on proc dentry

Re: [RFC PATCH stable] RDMA/qedr: qedr_iw_load_qp() can be static

2020-06-18 Thread Jason Gunthorpe
On Sat, Jun 13, 2020 at 04:19:03AM +0800, kernel test robot wrote: > > Fixes: 8a69220b659c ("RDMA/qedr: Fix synchronization methods and memory leaks > in qedr") > Signed-off-by: kernel test robot > --- > qedr_iw_cm.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) What is this

RE: [RFC PATCH v2 4/5] scsi: ufs: L2P map management for HPB read

2020-06-18 Thread Daejun Park
> > > + > > > > +static struct ufshpb_map_ctx *ufshpb_get_map_ctx(struct ufshpb_lu > > *hpb) > > > > +{ > > > > + struct ufshpb_map_ctx *mctx; > > > > + int i, j; > > > > + > > > > + mctx = mempool_alloc(ufshpb_drv.ufshpb_mctx_pool, GFP_KERNEL); > > > > + if (!mctx) > > > >

kernel BUG at mm/huge_memory.c:2613!

2020-06-18 Thread Roman Gushchin
Hi! I was consistently hitting a VM_BUG_ON_PAGE() in split_huge_page_to_list() when running vanilla 5.8-rc1 on my desktop. It was happening on every boot during the system start. I haven't seen this issue on 5.7. It looks like split_huge_page() expects the page to be locked, but it hasn't been

RE: [RFC PATCH v2 4/5] scsi: ufs: L2P map management for HPB read

2020-06-18 Thread Daejun Park
> +static void ufshpb_run_active_subregion_list(struct ufshpb_lu *hpb) > > +{ > > + struct ufshpb_region *rgn; > > + struct ufshpb_subregion *srgn; > > + struct ufshpb_map_ctx *mctx; > mctx doesn't really do anything here OK, I will delete it. > > + unsigned long flags;

Re: [PATCH 6/7] rcutorture: Add support to get the number of wakeups of main GP kthread

2020-06-18 Thread Paul E. McKenney
On Thu, Jun 18, 2020 at 08:01:56PM -0400, Joel Fernandes wrote: > On Thu, Jun 18, 2020 at 03:40:58PM -0700, Paul E. McKenney wrote: > > On Thu, Jun 18, 2020 at 04:29:54PM -0400, Joel Fernandes (Google) wrote: > > > This is useful to check for any improvements or degradation related to > > > number

Re: [PATCH 18/25] mm/riscv: Use mm_fault_accounting()

2020-06-18 Thread Peter Xu
On Thu, Jun 18, 2020 at 04:49:23PM -0700, Palmer Dabbelt wrote: > AFAICT this changes the behavior of the perf event: it used to count any > fault, > whereas now it only counts those that succeed successfully. If everyone else > is doing it that way then I'm happy to change us over, but this

Re: [PATCH 3/7] rcu/trace: Add name of the source for gp_seq

2020-06-18 Thread Paul E. McKenney
On Thu, Jun 18, 2020 at 07:51:17PM -0400, Joel Fernandes wrote: > On Thu, Jun 18, 2020 at 03:19:01PM -0700, Paul E. McKenney wrote: > > On Thu, Jun 18, 2020 at 04:29:51PM -0400, Joel Fernandes (Google) wrote: > > > The gp_seq value can come from either of rdp, rsp or rnp. > > > > > > Only the rsp

Re: severe proc dentry lock contention

2020-06-18 Thread Eric W. Biederman
Matthew Wilcox writes: > On Thu, Jun 18, 2020 at 03:17:33PM -0700, Junxiao Bi wrote: >> When debugging some performance issue, i found that thousands of threads >> exit around same time could cause a severe spin lock contention on proc >> dentry "/proc/$parent_process_pid/task/", that's because

Re: [PATCH 1/7] rcu/segcblist: Prevent useless GP start if no CBs to accelerate

2020-06-18 Thread Joel Fernandes
On Thu, Jun 18, 2020 at 04:09:34PM -0700, Paul E. McKenney wrote: > On Thu, Jun 18, 2020 at 03:11:19PM -0700, Paul E. McKenney wrote: > > On Thu, Jun 18, 2020 at 04:29:49PM -0400, Joel Fernandes (Google) wrote: > > > > First, this looks like a very nice optimization, thank you! Thanks! > > >

Re: [PATCH 6/7] rcutorture: Add support to get the number of wakeups of main GP kthread

2020-06-18 Thread Joel Fernandes
On Thu, Jun 18, 2020 at 03:40:58PM -0700, Paul E. McKenney wrote: > On Thu, Jun 18, 2020 at 04:29:54PM -0400, Joel Fernandes (Google) wrote: > > This is useful to check for any improvements or degradation related to > > number of GP kthread wakeups during testing. > > > > Signed-off-by: Joel

Re: [PATCH 3/7] rcu/trace: Add name of the source for gp_seq

2020-06-18 Thread Steven Rostedt
On Thu, 18 Jun 2020 15:19:01 -0700 "Paul E. McKenney" wrote: > For future reference, the TPS() around strings is not optional. Without > it, trace messages from crash dumps are garbled, if I remember correctly. When you pass in a string like this, only the pointer to the string is saved in the

Re: [PATCH 1/5] f2fs: fix to wait page writeback before update

2020-06-18 Thread Jaegeuk Kim
Hi Chao, On 06/18, Chao Yu wrote: > to make page content stable for special device like raid. Could you elaborate the problem a bit? > > Signed-off-by: Chao Yu > --- > fs/f2fs/dir.c | 2 ++ > fs/f2fs/extent_cache.c | 18 +- > fs/f2fs/f2fs.h | 2 +- >

Re: [PATCH 4/4] pci: export untrusted attribute in sysfs

2020-06-18 Thread Rajat Jain
Hi Bjorn, All, Thank you so much for your helpful review and inputs. On Mon, Jun 15, 2020 at 6:17 PM Rajat Jain wrote: > > This is needed to allow the userspace to determine when an untrusted > device has been added, and thus allowing it to bind the driver manually > to it, if it so wishes.

[for-linus][PATCH 09/17] tracing: Make ftrace packed events have align of 1

2020-06-18 Thread Steven Rostedt
From: "Steven Rostedt (VMware)" When using trace-cmd on 5.6-rt for the function graph tracer, the output was corrupted. It gave output like this: funcgraph_entry: func=0x depth=38982 funcgraph_entry: func=0x1 depth=16044 funcgraph_exit:func=0x

[for-linus][PATCH 00/17] tracing: Updates for 5.8

2020-06-18 Thread Steven Rostedt
Here's a list fixes and clean ups for tracing. -- Steve ` Jiri Olsa (1): kretprobe: Prevent triggering kretprobe from within kprobe_flush_task Kaitao Cheng (1): ftrace: Fix maybe-uninitialized compiler warning Kefeng Wang (2): sample-trace-array: Fix sleeping function called

[for-linus][PATCH 12/17] tracing: Remove unused event variable in tracing_iter_reset

2020-06-18 Thread Steven Rostedt
From: YangHui We do not use the event variable, just remove it. Signed-off-by: YangHui Signed-off-by: Steven Rostedt (VMware) --- kernel/trace/trace.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c index

[for-linus][PATCH 15/17] tools/bootconfig: Fix to return 0 if succeeded to show the bootconfig

2020-06-18 Thread Steven Rostedt
From: Masami Hiramatsu Fix bootconfig to return 0 if succeeded to show the bootconfig in initrd. Without this fix, "bootconfig INITRD" command returns !0 even if the command succeeded to show the bootconfig. Link: http://lkml.kernel.org/r/159230246566.6.11891772258543514487.stgit@devnote2

[for-linus][PATCH 10/17] trace: Fix typo in allocate_ftrace_ops()s comment

2020-06-18 Thread Steven Rostedt
From: Wei Yang No functional change, just correct the word. Link: https://lkml.kernel.org/r/20200610033251.31713-1-richard.weiy...@linux.alibaba.com Signed-off-by: Wei Yang Signed-off-by: Steven Rostedt (VMware) --- kernel/trace/trace_functions.c | 2 +- 1 file changed, 1 insertion(+), 1

[for-linus][PATCH 06/17] kretprobe: Prevent triggering kretprobe from within kprobe_flush_task

2020-06-18 Thread Steven Rostedt
From: Jiri Olsa Ziqian reported lockup when adding retprobe on _raw_spin_lock_irqsave. My test was also able to trigger lockdep output: WARNING: possible recursive locking detected 5.6.0-rc6+ #6 Not tainted

[for-linus][PATCH 05/17] kprobes: Remove redundant arch_disarm_kprobe() call

2020-06-18 Thread Steven Rostedt
From: Masami Hiramatsu Fix to remove redundant arch_disarm_kprobe() call in force_unoptimize_kprobe(). This arch_disarm_kprobe() will be invoked if the kprobe is optimized but disabled, but that means the kprobe (optprobe) is unused (and unoptimized) state. In that case, unoptimize_kprobe()

[for-linus][PATCH 13/17] proc/bootconfig: Fix to use correct quotes for value

2020-06-18 Thread Steven Rostedt
From: Masami Hiramatsu Fix /proc/bootconfig to select double or single quotes corrctly according to the value. If a bootconfig value includes a double quote character, we must use single-quotes to quote that value. This modifies if() condition and blocks for avoiding double-quote in value

[for-linus][PATCH 11/17] tracing/probe: Fix memleak in fetch_op_data operations

2020-06-18 Thread Steven Rostedt
From: Vamshi K Sthambamkadi kmemleak report: [<57dcc2ca>] __kmalloc_track_caller+0x139/0x2b0 [] kstrndup+0x37/0x80 [] parse_probe_arg.isra.7+0x3cc/0x630 [<055bf2ba>] traceprobe_parse_probe_arg+0x2f5/0x810 [<655a7766>] trace_kprobe_create+0x2ca/0x950 [<4fc6a02a>]

[for-linus][PATCH 17/17] ftrace: Fix maybe-uninitialized compiler warning

2020-06-18 Thread Steven Rostedt
From: Kaitao Cheng During build compiler reports some 'false positive' warnings about variables {'seq_ops', 'filtered_pids', 'other_pids'} may be used uninitialized. This patch silences these warnings. Also delete some useless spaces Link:

[for-linus][PATCH 14/17] tools/bootconfig: Fix to use correct quotes for value

2020-06-18 Thread Steven Rostedt
From: Masami Hiramatsu Fix bootconfig tool to select double or single quotes correctly according to the value. If a bootconfig value includes a double quote character, we must use single-quotes to quote that value. Link:

[for-linus][PATCH 16/17] tools/bootconfig: Add testcase for show-command and quotes test

2020-06-18 Thread Steven Rostedt
From: Masami Hiramatsu Add testcases for the return value of the command to show bootconfig in initrd, and double/single quotes selecting. Link: http://lkml.kernel.org/r/159230247428.6.2109472942519215104.stgit@devnote2 Signed-off-by: Masami Hiramatsu Signed-off-by: Steven Rostedt

[for-linus][PATCH 03/17] kprobes: Use non RCU traversal APIs on kprobe_tables if possible

2020-06-18 Thread Steven Rostedt
From: Masami Hiramatsu Current kprobes uses RCU traversal APIs on kprobe_tables even if it is safe because kprobe_mutex is locked. Make those traversals to non-RCU APIs where the kprobe_mutex is locked. Link: http://lkml.kernel.org/r/158927056452.27680.9710575332163005121.stgit@devnote2

<    1   2   3   4   5   6   7   8   9   10   >