[PATCH] ima_evm_utils: extended calc_bootaggr to PCRs 8 - 9

2020-06-18 Thread Maurizio Drocco
From: Maurizio If PCRs 8 - 9 are set (i.e. not all-zeros), cal_bootaggr should include them into the digest. Signed-off-by: Maurizio Drocco --- src/evmctl.c | 16 +++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/src/evmctl.c b/src/evmctl.c index 1d065ce..554571e

Re: [PATCH v5 3/7] fs: Add fd_install_received() wrapper for __fd_install_received()

2020-06-18 Thread Kees Cook
On Thu, Jun 18, 2020 at 05:49:19AM +, Sargun Dhillon wrote: > On Wed, Jun 17, 2020 at 03:03:23PM -0700, Kees Cook wrote: > > [...] > > static inline int fd_install_received_user(struct file *file, int __user > > *ufd, > >unsigned int o_flags) > > { >

Re: [PATCH v13] perf: Sharing PMU counters across compatible events

2020-06-18 Thread Song Liu
> On Jun 18, 2020, at 2:09 AM, Athira Rajeev > wrote: > > > >> On 02-May-2020, at 5:51 AM, Song Liu wrote: >> >> This patch tries to enable PMU sharing. When multiple perf_events are >> counting the same metric, they can share the hardware PMU counter. We >> call these events as

[PATCH] extend IMA boot_aggregate with kernel measurements

2020-06-18 Thread Maurizio Drocco
IMA is not considering TPM registers 8-9 when calculating the boot aggregate. When registers 8-9 are used to store measurements of the kernel and its command line (e.g., grub2 bootloader with tpm module enabled), IMA should include them in the boot aggregate. Signed-off-by: Maurizio Drocco ---

Re: [PATCH v4 5/5] spi: spi-geni-qcom: Don't keep a local state variable

2020-06-18 Thread Doug Anderson
Hi, On Thu, Jun 18, 2020 at 11:05 AM Stephen Boyd wrote: > > Quoting Douglas Anderson (2020-06-18 08:06:26) > > @@ -126,20 +120,23 @@ static void handle_fifo_timeout(struct spi_master > > *spi, > > struct geni_se *se = >se; > > > > spin_lock_irq(>lock); > > -

Re: [PATCH v3 2/6] dt-bindings: usb: Add Qualcomm PMIC type C controller dt-binding

2020-06-18 Thread Wesley Cheng
On 6/18/2020 11:33 AM, Rob Herring wrote: > On Wed, Jun 17, 2020 at 12:02 PM Wesley Cheng wrote: > > You are duplicating everything in usb-connector.yaml. You should have > a $ref to it. > Hi Rob, Sure, I will add a reference to that doc. > > This is wrong. The connector binding says port

Re: [PATCH 9/9] mm, slab/slub: move and improve cache_from_obj()

2020-06-18 Thread Roman Gushchin
On Thu, Jun 18, 2020 at 12:10:38PM +0200, Vlastimil Babka wrote: > > On 6/17/20 7:49 PM, Kees Cook wrote: > > On Wed, Jun 10, 2020 at 06:31:35PM +0200, Vlastimil Babka wrote: > >> The function cache_from_obj() was added by commit b9ce5ef49f00 ("sl[au]b: > >> always get the cache from its page in

Re: [PATCH v4 02/11] fs: Move __scm_install_fd() to __fd_install_received()

2020-06-18 Thread Kees Cook
On Thu, Jun 18, 2020 at 10:56:14AM +0200, Christian Brauner wrote: > On Mon, Jun 15, 2020 at 08:25:15PM -0700, Kees Cook wrote: > > In preparation for users of the "install a received file" logic outside > > of net/ (pidfd and seccomp), relocate and rename __scm_install_fd() from > >

[PATCH] MAINTAINERS: fix incorrect directory reference

2020-06-18 Thread Ralf Ramsauer
the below-mentioned commit moved headers to inlucde/linux/soc/mmp. MAINTAINERS was updated, but include/ was omitted. Fixes: 32adcaa010 ("ARM: mmp: move cputype.h to include/linux/soc/") Signed-off-by: Ralf Ramsauer --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

Re: [PATCH 1/2] video: ssd1307fb: Print PWM period using 64-bit format specifier

2020-06-18 Thread Guru Das Srinagesh
On Wed, Jun 17, 2020 at 09:18:34AM +0200, Geert Uytterhoeven wrote: > Hi Thierry, > > On Mon, Jun 15, 2020 at 4:17 PM Thierry Reding > wrote: > > The PWM core will soon change the duty cycle and period of PWMs to 64 > > bits to allow for a broader range of values. Use a 64-bit format > >

Re: [PATCH 0/3] zone-append support in aio and io-uring

2020-06-18 Thread Matias Bjørling
On 18/06/2020 21.21, Kanchan Joshi wrote: On Thu, Jun 18, 2020 at 10:04:32AM +0200, Matias Bjørling wrote: On 17/06/2020 19.23, Kanchan Joshi wrote: This patchset enables issuing zone-append using aio and io-uring direct-io interface. For aio, this introduces opcode IOCB_CMD_ZONE_APPEND.

Re: [PATCH v2 09/16] rcu/tree: Maintain separate array for vmalloc ptrs

2020-06-18 Thread Uladzislau Rezki
On Thu, Jun 18, 2020 at 10:35:27AM -0700, Matthew Wilcox wrote: > On Thu, Jun 18, 2020 at 07:30:49PM +0200, Uladzislau Rezki wrote: > > > I'd suggest: > > > > > > rcu_lock_acquire(_callback_map); > > > trace_rcu_invoke_kfree_bulk_callback(rcu_state.name, > > >

[PATCH v2 0/2] remove workarounds for gcc bug wrt unnamed fields in initializers

2020-06-18 Thread Niklas Cassel
Make the nvme code more uniform by initializing struct members at declaration time. This change is done both in drivers/nvme/host/ and drivers/nvme/target/. This is how the design pattern was in nvme, before workarounds for a gcc bug were introduced in commit e44ac588cd61

[PATCH v2 2/2] nvmet: remove workarounds for gcc bug wrt unnamed fields in initializers

2020-06-18 Thread Niklas Cassel
Workarounds for gcc issues with initializers and anon unions was first introduced in commit e44ac588cd61 ("drivers/block/nvme-core.c: fix build with gcc-4.4.4"). The gcc bug in question has been fixed since gcc 4.6.0: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=10676 The minimum gcc version for

[PATCH v2 1/2] nvme: remove workarounds for gcc bug wrt unnamed fields in initializers

2020-06-18 Thread Niklas Cassel
Workarounds for gcc issues with initializers and anon unions was first introduced in commit e44ac588cd61 ("drivers/block/nvme-core.c: fix build with gcc-4.4.4"). The gcc bug in question has been fixed since gcc 4.6.0: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=10676 The minimum gcc version for

Re: [LTP] [x86/entry] 2bbc68f837: ltp.ptrace08.fail

2020-06-18 Thread Thomas Gleixner
Cyril Hrubis writes: > What is does is to write: > > (void*)1 to u_debugreg[0] > (void*)1 to u_debugreg[7] > do_debug addr to u_debugreg[0] > > Looking at the kernel code the write to register 7 enables the breakpoints and > what we attempt here is to change an invalid address

2dd4d163cd9c ("drm/nouveau: remove open-coded version of remove_conflicting_pci_framebuffers()")

2020-06-18 Thread Borislav Petkov
Hi, my test box won't boot 5.8-rc1 all the way but stops at ... fb0: switching to nouveaufb from EFI VGA <-- EOF I've bisected it to the commit in $Subject, see below. Unfortunately, it doesn't revert cleanly so I can't really do the final test of reverting it ontop of 5.8-rc1 to confirm that

Re: [PATCH v2 2/4] ARC: ARCv2: support loop buffer (LPB) disabling

2020-06-18 Thread Vineet Gupta
On 6/18/20 12:50 PM, Eugeniy Paltsev wrote: > Hi Vineet, > > could you also peek this patch to for-curr as we don't have any disagreement > about it? > > I'll respin the rest of the patches later. Thanks. > --- > Eugeniy Paltsev Added ! -Vineet

Re: [PATCH 2/2] nvmet: remove workarounds for gcc bug wrt unnamed fields in initializers

2020-06-18 Thread Niklas Cassel
On Thu, Jun 18, 2020 at 05:29:00PM +, Chaitanya Kulkarni wrote: > I'm not against the code cleanup and it always welcome. > Please also have a look at other comment. > > >> What is the issue with existing code that we need this patch for ? > >> > > > > Hello Chaitanya, > > > > This is just

[PATCH] restore behaviour of CAP_SYS_ADMIN allowing the loading of net bpf program

2020-06-18 Thread Maciej Żenczykowski
From: Maciej Żenczykowski This is a 5.8-rc1 regression. Cc: Alexei Starovoitov Cc: Daniel Borkmann Fixes: 2c78ee898d8f ("bpf: Implement CAP_BPF") Signed-off-by: Maciej Żenczykowski --- kernel/bpf/syscall.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH] kunit: kunit_tool: Fix invalid result when build fails

2020-06-18 Thread Brendan Higgins
On Mon, Jun 15, 2020 at 11:47 PM David Gow wrote: > > When separating out different phases of running tests[1] > (build/exec/parse/etc), the format of the KunitResult tuple changed > (adding an elapsed_time variable). This is not populated during a build > failure, causing kunit.py to crash. > >

Re: [PATCH 9/9] mm, slab/slub: move and improve cache_from_obj()

2020-06-18 Thread Kees Cook
On Thu, Jun 18, 2020 at 12:10:38PM +0200, Vlastimil Babka wrote: > > On 6/17/20 7:49 PM, Kees Cook wrote: > > On Wed, Jun 10, 2020 at 06:31:35PM +0200, Vlastimil Babka wrote: > >> The function cache_from_obj() was added by commit b9ce5ef49f00 ("sl[au]b: > >> always get the cache from its page in

[PATCH] vfio: Cleanup allowed driver naming

2020-06-18 Thread Alex Williamson
No functional change, avoid non-inclusive naming schemes. Signed-off-by: Alex Williamson --- drivers/vfio/vfio.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/vfio/vfio.c b/drivers/vfio/vfio.c index 580099afeaff..833da937b7fc 100644 ---

Re: [Cocci] [PATCH] coccinelle: misc: add array_size_dup script to detect missed overlow checks

2020-06-18 Thread Julia Lawall
On Thu, 18 Jun 2020, Kees Cook wrote: > On Wed, Jun 17, 2020 at 08:54:03PM +0200, Julia Lawall wrote: > > > > > > On Wed, 17 Jun 2020, Kees Cook wrote: > > > > > On Mon, Jun 15, 2020 at 01:20:45PM +0300, Denis Efremov wrote: > > > > +@as@ > > > > +expression E1, E2; > > > > +@@ > > > > + > > >

Re: [PATCH 7/9] mm, slub: introduce kmem_cache_debug_flags()

2020-06-18 Thread Kees Cook
On Thu, Jun 18, 2020 at 10:37:07AM +0200, Vlastimil Babka wrote: > On 6/10/20 6:31 PM, Vlastimil Babka wrote: > > There are few places that call kmem_cache_debug(s) (which tests if any of > > debug > > flags are enabled for a cache) immediatelly followed by a test for a > > specific > > flag.

[PATCH 0/2] sched: Optionally skip uclamp logic in fast path

2020-06-18 Thread Qais Yousef
This series attempts to address the report that uclamp logic could be expensive sometimes and shows a regression in netperf UDP_STREAM under certain conditions. The first patch is a fix for how struct uclamp_rq is initialized which is required by the 2nd patch which contains the real 'fix'.

[PATCH 2/2] sched/uclamp: Protect uclamp fast path code with static key

2020-06-18 Thread Qais Yousef
There is a report that when uclamp is enabled, a netperf UDP test regresses compared to a kernel compiled without uclamp. https://lore.kernel.org/lkml/20200529100806.ga3...@suse.de/ While investigating the root cause, there were no sign that the uclamp code is doing anything particularly

[PATCH 1/2] sched/uclamp: Fix initialization of strut uclamp_rq

2020-06-18 Thread Qais Yousef
struct uclamp_rq was zeroed out entirely in assumption that in the first call to uclamp_rq_inc() they'd be initialized correctly in accordance to default settings. But when next patch introduces a static key to skip uclamp_rq_{inc,dec}() until userspace opts in to use uclamp, schedutil will fail

Re: [PATCH 7/9] mm, slub: introduce kmem_cache_debug_flags()

2020-06-18 Thread Roman Gushchin
On Thu, Jun 18, 2020 at 10:37:07AM +0200, Vlastimil Babka wrote: > On 6/10/20 6:31 PM, Vlastimil Babka wrote: > > There are few places that call kmem_cache_debug(s) (which tests if any of > > debug > > flags are enabled for a cache) immediatelly followed by a test for a > > specific > > flag.

Re: [PATCH v6 17/19] mm: memcg/slab: use a single set of kmem_caches for all allocations

2020-06-18 Thread Roman Gushchin
On Thu, Jun 18, 2020 at 09:33:08AM +0200, Vlastimil Babka wrote: > On 6/18/20 2:35 AM, Roman Gushchin wrote: > > On Wed, Jun 17, 2020 at 04:35:28PM -0700, Andrew Morton wrote: > >> On Mon, 8 Jun 2020 16:06:52 -0700 Roman Gushchin wrote: > >> > >> > Instead of having two sets of kmem_caches: one

Re: [Cocci] [PATCH] coccinelle: misc: add array_size_dup script to detect missed overlow checks

2020-06-18 Thread Kees Cook
On Wed, Jun 17, 2020 at 08:54:03PM +0200, Julia Lawall wrote: > > > On Wed, 17 Jun 2020, Kees Cook wrote: > > > On Mon, Jun 15, 2020 at 01:20:45PM +0300, Denis Efremov wrote: > > > +@as@ > > > +expression E1, E2; > > > +@@ > > > + > > > +array_size(E1, E2) > > > > BTW, is there a way yet in

Re: [PATCH v6 05/19] mm: memcontrol: decouple reference counting from page accounting

2020-06-18 Thread Roman Gushchin
On Thu, Jun 18, 2020 at 07:55:35AM -0700, Shakeel Butt wrote: > Not sure if my email went through, so, re-sending. No, I've got it, jut was busy with the other stuff. > > On Mon, Jun 8, 2020 at 4:07 PM Roman Gushchin wrote: > > > > From: Johannes Weiner > > > [...] > > @@ -3003,13 +3004,16 @@

Re: [PATCH v2 2/4] ARC: ARCv2: support loop buffer (LPB) disabling

2020-06-18 Thread Eugeniy Paltsev
Hi Vineet, could you also peek this patch to for-curr as we don't have any disagreement about it? I'll respin the rest of the patches later. Thanks. --- Eugeniy Paltsev From: Eugeniy Paltsev Sent: Thursday, June 4, 2020 20:39 To:

Re: rename probe_kernel_* and probe_user_*

2020-06-18 Thread Linus Torvalds
[ Explicitly added architecture lists and developers to the cc to make this more visible ] On Wed, Jun 17, 2020 at 12:38 AM Christoph Hellwig wrote: > > Andrew and I decided to drop the patches implementing your suggested > rename of the probe_kernel_* and probe_user_* helpers from -mm as there

Re: [PATCH v2 0/6] add regmap & indirect access support

2020-06-18 Thread Tom Rix
This set looks good to me. Reviewed-by : Tom Rix Tom On 6/18/20 8:25 AM, Xu Yilun wrote: > Updated the regmap & indirect access support for spi-altera. > > Patch #1, #2, #3 is already applied. > Patch #4 is an 1:1 replacement of of readl/writel with regmap_read/write > Patch #5 introduced a

[PATCH] ima: move APPRAISE_BOOTPARAM dependency on ARCH_POLICY to runtime

2020-06-18 Thread Bruno Meneguele
IMA_APPRAISE_BOOTPARAM has been marked as dependent on !IMA_ARCH_POLICY in compile time, enforcing the appraisal whenever the kernel had the arch policy option enabled. However it breaks systems where the option is actually set but the system wasn't booted in a "secure boot" platform. In this

Re: [PATCH v3 20/21] dyndbg: add user-flag, negating-flags, and filtering on flags

2020-06-18 Thread Jason Baron
On 6/18/20 3:11 PM, jim.cro...@gmail.com wrote: > On Thu, Jun 18, 2020 at 12:17 PM Jason Baron wrote: >> >> >> >> On 6/18/20 1:40 PM, Petr Mladek wrote: >>> On Thu 2020-06-18 18:19:12, Petr Mladek wrote: On Wed 2020-06-17 10:25:35, Jim Cromie wrote: > 1. Add a user-flag [u] which

Re: [PATCH] net/9p: Fix sparse rcu warnings in client.c

2020-06-18 Thread Alexander Kapshuk
On Thu, Jun 18, 2020 at 10:08 PM Dominique Martinet wrote: > > Alexander Kapshuk wrote on Thu, Jun 18, 2020: > > Address sparse nonderef rcu warnings: > > net/9p/client.c:790:17: warning: incorrect type in argument 1 (different > > address spaces) > > net/9p/client.c:790:17:expected struct

Re: [PATCH] [v3] dmaengine: tegra210-adma: Fix runtime PM imbalance on error

2020-06-18 Thread Jon Hunter
On 18/06/2020 11:57, Dinghao Liu wrote: > pm_runtime_get_sync() increments the runtime PM usage counter even > when it returns an error code. Thus a pairing decrement is needed on > the error handling path to keep the counter balanced. > > Signed-off-by: Dinghao Liu > --- > > Changelog: > >

Re: [PATCH 1/7] x86/entry: Fix #UD vs WARN more

2020-06-18 Thread Andy Lutomirski
> On Jun 18, 2020, at 12:02 PM, Peter Zijlstra wrote: > > On Thu, Jun 18, 2020 at 11:36:53AM -0700, Andy Lutomirski wrote: > >> I wasn't imagining going far down the rabbit hole at all -- I think >> that, at most, we should cover the path for when the fault wasn't a >> BUG/WARN in the first

[GIT PULL] perf tooling fixes for v5.8

2020-06-18 Thread Arnaldo Carvalho de Melo
Hi Linus Please consider pulling, Best regards, - Arnaldo The following changes since commit 69119673bd50b176ded34032fadd41530fb5af21: Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net (2020-06-16 17:44:54 -0700) are available in the Git repository at:

Re: [PATCH] net/9p: Fix sparse endian warning in trans_fd.c

2020-06-18 Thread Alexander Kapshuk
On Thu, Jun 18, 2020 at 10:09 PM Dominique Martinet wrote: > > Alexander Kapshuk wrote on Thu, Jun 18, 2020: > > Address sparse endian warning: > > net/9p/trans_fd.c:932:28: warning: incorrect type in assignment (different > > base types) > > net/9p/trans_fd.c:932:28:expected restricted

Re: [PATCH 0/3] zone-append support in aio and io-uring

2020-06-18 Thread Kanchan Joshi
On Thu, Jun 18, 2020 at 10:04:32AM +0200, Matias Bjørling wrote: On 17/06/2020 19.23, Kanchan Joshi wrote: This patchset enables issuing zone-append using aio and io-uring direct-io interface. For aio, this introduces opcode IOCB_CMD_ZONE_APPEND. Application uses start LBA of the zone to

Re: [Tee-dev] [PATCHv8 1/3] optee: use uuid for sysfs driver entry

2020-06-18 Thread James Bottomley
On Thu, 2020-06-18 at 10:42 +0530, Sumit Garg wrote: > On Thu, 18 Jun 2020 at 10:29, Sumit Garg > wrote: [...] > > > typedef struct > > > { > > > uint32_t timeLow; > > > uint16_t timeMid; > > > uint16_t timeHiAndVersion; > > > uint8_t clockSeqAndNode[8]; > > > }

[PATCH][next] vfio/type1: Use struct_size() helper

2020-06-18 Thread Gustavo A. R. Silva
Make use of the struct_size() helper instead of an open-coded version in order to avoid any potential type mistakes. This code was detected with the help of Coccinelle and, audited and fixed manually. Signed-off-by: Gustavo A. R. Silva --- drivers/vfio/vfio_iommu_type1.c | 2 +- 1 file

drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c:1884:21: sparse: sparse: incorrect type in argument 1 (different address spaces)

2020-06-18 Thread kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 1b5044021070efa3259f3e9548dc35d1eb6aa844 commit: 57430471e2fa60a412e220fa3014567e792aaa6f drm/amdgpu: Add support for USBC PD FW download date: 4 months ago config: riscv-randconfig-s032-20200618

[PATCH] vfio/type1: Fix migration info capability ID

2020-06-18 Thread Alex Williamson
ID 1 is already used by the IOVA range capability, use ID 2. Reported-by: Liu Yi L Cc: Kirti Wankhede Fixes: ad721705d09c ("vfio iommu: Add migration capability to report supported features") Signed-off-by: Alex Williamson --- include/uapi/linux/vfio.h |2 +- 1 file changed, 1

Re: [PATCH v3 20/21] dyndbg: add user-flag, negating-flags, and filtering on flags

2020-06-18 Thread jim . cromie
On Thu, Jun 18, 2020 at 12:17 PM Jason Baron wrote: > > > > On 6/18/20 1:40 PM, Petr Mladek wrote: > > On Thu 2020-06-18 18:19:12, Petr Mladek wrote: > >> On Wed 2020-06-17 10:25:35, Jim Cromie wrote: > >>> 1. Add a user-flag [u] which works like the [pfmlt] flags, but has no > >>> effect on

Re: [PATCH] net/9p: Fix sparse endian warning in trans_fd.c

2020-06-18 Thread Dominique Martinet
Alexander Kapshuk wrote on Thu, Jun 18, 2020: > Address sparse endian warning: > net/9p/trans_fd.c:932:28: warning: incorrect type in assignment (different > base types) > net/9p/trans_fd.c:932:28:expected restricted __be32 [addressable] > [assigned] [usertype] s_addr >

Re: [PATCH] net/9p: Fix sparse rcu warnings in client.c

2020-06-18 Thread Dominique Martinet
Alexander Kapshuk wrote on Thu, Jun 18, 2020: > Address sparse nonderef rcu warnings: > net/9p/client.c:790:17: warning: incorrect type in argument 1 (different > address spaces) > net/9p/client.c:790:17:expected struct spinlock [usertype] *lock > net/9p/client.c:790:17:got struct

[PATCH] sched/core: Remove mmdrop() definition

2020-06-18 Thread Sebastian Andrzej Siewior
Commit bf2c59fce4074 ("sched/core: Fix illegal RCU from offline CPUs") introduced a definition for mmdrop() but a a few lines above there is already mmdrop() defined as static inline. Remove the newly introduced mmdrop() definition. Signed-off-by: Sebastian Andrzej Siewior ---

Re: [RFC][PATCH 7/7] sched: Replace rq::wake_list

2020-06-18 Thread Guenter Roeck
On Thu, Jun 18, 2020 at 01:57:33PM -0400, Steven Rostedt wrote: > On Tue, Jun 09, 2020 at 02:25:09PM -0700, Guenter Roeck wrote: > > > > > > Still occurring on Linus' tree. This needs to be fixed. (And not by > > > removing > > > support for randstruct; that's not a "fix"...) > > > > > > >

[PATCH v3 1/2] media: tpg: Add function to return colors' order of test image

2020-06-18 Thread Kaaira Gupta
Currently there is no method to know the correct order of the colors for a test image generated by tpg. Write a function that returns a string of colors' order given a tpg. It returns a NULL pointer in case of test patterns which do not have a well defined colors' order. Hence add a NULL check for

[PATCH v3 0/2] media: Add colors' order and other info over test image

2020-06-18 Thread Kaaira Gupta
This patchset aims to add a method to display the correct order of colors for a test image generated. It does so by adding a function which returns a string of correct order of the colors for a test pattern. It then adds a control in vimc which displays the string over test image. It also

[PATCH v3 2/2] media: vimc: Add a control to display info on test image

2020-06-18 Thread Kaaira Gupta
Add a control in VIMC to display information such as the correct oder of colors for a given test pattern, brightness, hue, saturation, contrast and, width and height at sensor over test image; and display that information. Signed-off-by: Kaaira Gupta --- drivers/media/test-drivers/vimc/Kconfig

Re: [PATCH v2 09/16] rcu/tree: Maintain separate array for vmalloc ptrs

2020-06-18 Thread Paul E. McKenney
On Thu, Jun 18, 2020 at 08:34:48PM +0200, Uladzislau Rezki wrote: > > > > > > > > I suspect that he would like to keep the tracing. > > > > > > > > It might be worth trying the branches, given that they would be constant > > > > and indexed by "i". The compiler might well remove the

[tip: x86/cleanups] x86/mm/32: Fix -Wmissing prototypes warnings for init.c

2020-06-18 Thread tip-bot2 for Benjamin Thiel
The following commit has been merged into the x86/cleanups branch of tip: Commit-ID: 56ce93700eb630a8d894f5a578f166888ae8cba6 Gitweb: https://git.kernel.org/tip/56ce93700eb630a8d894f5a578f166888ae8cba6 Author:Benjamin Thiel AuthorDate:Sat, 06 Jun 2020 14:37:43 +02:00

Re: [PATCH 1/7] x86/entry: Fix #UD vs WARN more

2020-06-18 Thread Peter Zijlstra
On Thu, Jun 18, 2020 at 11:36:53AM -0700, Andy Lutomirski wrote: > I wasn't imagining going far down the rabbit hole at all -- I think > that, at most, we should cover the path for when the fault wasn't a > BUG/WARN in the first place. I admit that, for #UD in particular, > this isn't a big

Re: [PATCH] macvlan: Fix memory leak in macvlan_changelink_sources()

2020-06-18 Thread Markus Elfring
> -->If fail, need to free previous malloc memory I suggest to improve this change description. How does the proposed addition of the function call “macvlan_flush_sources” fit to this information? Regards, Markus

Re: [PATCH 1/2] dt-bindings: chrome: Add cros-ec-typec mux props

2020-06-18 Thread Prashant Malani
Hi Heikki and Rob, (trimming text): On Mon, Jun 15, 2020 at 04:22:07PM +0300, Heikki Krogerus wrote: > On Fri, Jun 12, 2020 at 10:34:06AM -0700, Prashant Malani wrote: > > Hi Rob, > > > Yes, but let's stop calling it a mux. It's a "USB Type C signal routing > > > blob". > > > > Ack. > > > >

Re: [PATCH] sparse: use identifiers to define address spaces

2020-06-18 Thread Luc Van Oostenryck
On Thu, Jun 18, 2020 at 09:59:05AM -0700, Linus Torvalds wrote: > > The new warnings don't seem to be due to the kernel test robot having > an old version of sparse, but just because the error strings changed, > and presumably the kernel test robot has some "ignore old sparse > warnings" logic. >

Re: [PATCH v2 09/16] rcu/tree: Maintain separate array for vmalloc ptrs

2020-06-18 Thread Uladzislau Rezki
On Thu, Jun 18, 2020 at 11:37:51AM -0700, Matthew Wilcox wrote: > On Thu, Jun 18, 2020 at 08:23:33PM +0200, Uladzislau Rezki wrote: > > > +void vfree_bulk(size_t count, void **addrs) > > > +{ > > > + unsigned int i; > > > + > > > + BUG_ON(in_nmi()); > > > + might_sleep_if(!in_interrupt()); > > > +

Re: [PATCH 4/4] pci: export untrusted attribute in sysfs

2020-06-18 Thread Greg Kroah-Hartman
On Thu, Jun 18, 2020 at 10:23:38AM -0700, Rajat Jain wrote: > Thanks Greg and Andy for your continued inputs, and thanks Ashok for chiming > in. > > On Thu, Jun 18, 2020 at 9:23 AM Raj, Ashok wrote: > > > > Hi Greg, > > > > > > On Thu, Jun 18, 2020 at 06:02:12PM +0200, Greg Kroah-Hartman wrote:

Re: [PATCH 2/2] nvmet: remove workarounds for gcc bug wrt unnamed fields in initializers

2020-06-18 Thread kernel test robot
Hi Niklas, I love your patch! Yet something to improve: [auto build test ERROR on block/for-next] [also build test ERROR on linus/master v5.8-rc1 next-20200618] [cannot apply to hch-configfs/for-next] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting

Re: [PATCH v3 1/4] dt-bindings: nvmem: qfprom: Convert to yaml

2020-06-18 Thread Rob Herring
On Wed, 17 Jun 2020 07:51:13 -0700, Douglas Anderson wrote: > From: Ravi Kumar Bokka > > This switches the bindings over from txt to yaml. > > Signed-off-by: Ravi Kumar Bokka > Signed-off-by: Douglas Anderson > --- > > Changes in v3: > - Split conversion to yaml into separate patch new in

Re: [PATCH] irq: Request and release resources for chained IRQs

2020-06-18 Thread Thomas Gleixner
David Heidelberg writes: > is there chance to get this patch included or could be this issue > solved with different approach? Included into what? This patch is incorrect as I pointed out in review here:

Re: [PATCH 1/3] fs,block: Introduce IOCB_ZONE_APPEND and direct-io handling

2020-06-18 Thread Kanchan Joshi
On Thu, Jun 18, 2020 at 07:16:19AM +, Damien Le Moal wrote: On 2020/06/18 2:27, Kanchan Joshi wrote: From: Selvakumar S Introduce IOCB_ZONE_APPEND flag, which is set in kiocb->ki_flags for zone-append. Direct I/O submission path uses this flag to send bio with append op. And completion

Re: [PATCH v2 09/16] rcu/tree: Maintain separate array for vmalloc ptrs

2020-06-18 Thread Matthew Wilcox
On Thu, Jun 18, 2020 at 08:23:33PM +0200, Uladzislau Rezki wrote: > > +void vfree_bulk(size_t count, void **addrs) > > +{ > > + unsigned int i; > > + > > + BUG_ON(in_nmi()); > > + might_sleep_if(!in_interrupt()); > > + > > + for (i = 0; i < count; i++) { > > + void *addr =

Re: [PATCH 1/7] x86/entry: Fix #UD vs WARN more

2020-06-18 Thread Andy Lutomirski
On Thu, Jun 18, 2020 at 8:50 AM Peter Zijlstra wrote: > > On Thu, Jun 18, 2020 at 07:57:35AM -0700, Andy Lutomirski wrote: > > > > > > > On Jun 18, 2020, at 7:50 AM, Peter Zijlstra wrote: > > > > > > vmlinux.o: warning: objtool: exc_invalid_op()+0x47: call to > > > probe_kernel_read() leaves

Re: [PATCH v1] doc: devicetree: bindings: fix spelling mistake

2020-06-18 Thread Rob Herring
On Mon, 15 Jun 2020 09:58:35 +0200, Flavio Suligoi wrote: > Fix typo: "triger" --> "trigger" > > Signed-off-by: Flavio Suligoi > Acked-by: Guo Ren > --- > > v1: add Acked-by: Guo Ren > > Documentation/devicetree/bindings/gpio/mediatek,mt7621-gpio.txt | 2 +- >

RE: [PATCH 8/8] Drivers: hv: vmbus: Remove the lock field from the vmbus_channel struct

2020-06-18 Thread Michael Kelley
From: Andrea Parri (Microsoft) Sent: Wednesday, June 17, 2020 9:47 AM > > The spinlock is (now) *not used to protect test-and-set accesses > to attributes of the structure or sc_list operations. > > There is, AFAICT, a distinct lack of {WRITE,READ}_ONCE()s in the > handling of channel->state,

RE: [PATCH 7/8] scsi: storvsc: Introduce the per-storvsc_device spinlock

2020-06-18 Thread Michael Kelley
From: Andrea Parri (Microsoft) Sent: Wednesday, June 17, 2020 9:47 AM > > storvsc uses the spinlock of the hv_device's primary channel to > serialize modifications of stor_chns[] performed by storvsc_do_io() > and storvsc_change_target_cpu(), when it could/should use a (per-) > storvsc_device

Re: [PATCH v2 09/16] rcu/tree: Maintain separate array for vmalloc ptrs

2020-06-18 Thread Uladzislau Rezki
> > > > > > I suspect that he would like to keep the tracing. > > > > > > It might be worth trying the branches, given that they would be constant > > > and indexed by "i". The compiler might well remove the indirection. > > > > > > The compiler guys brag about doing so, which of course might

[PATCH] net/9p: Fix sparse endian warning in trans_fd.c

2020-06-18 Thread Alexander Kapshuk
Address sparse endian warning: net/9p/trans_fd.c:932:28: warning: incorrect type in assignment (different base types) net/9p/trans_fd.c:932:28:expected restricted __be32 [addressable] [assigned] [usertype] s_addr net/9p/trans_fd.c:932:28:got unsigned long Signed-off-by: Alexander

[PATCH] net/9p: Fix sparse rcu warnings in client.c

2020-06-18 Thread Alexander Kapshuk
Address sparse nonderef rcu warnings: net/9p/client.c:790:17: warning: incorrect type in argument 1 (different address spaces) net/9p/client.c:790:17:expected struct spinlock [usertype] *lock net/9p/client.c:790:17:got struct spinlock [noderef] * net/9p/client.c:792:48: warning:

Re: [PATCH v3 2/6] dt-bindings: usb: Add Qualcomm PMIC type C controller dt-binding

2020-06-18 Thread Rob Herring
On Wed, Jun 17, 2020 at 12:02 PM Wesley Cheng wrote: > > Introduce the dt-binding for enabling USB type C orientation and role > detection using the PM8150B. The driver will be responsible for receiving > the interrupt at a state change on the CC lines, reading the orientation/role, > and

Re: WARNING with LBR + precise_ip=2 + bpf_get_stackid()

2020-06-18 Thread Peter Zijlstra
On Thu, Jun 18, 2020 at 05:25:24PM +, Song Liu wrote: > PID: 80430 TASK: 888d92c62a80 CPU: 24 COMMAND: "25_scheduler" > #0 [fe4cfd88] machine_kexec at 8104a646 > #1 [fe4cfdd8] __crash_kexec at 8114a82f > #2 [fe4cfea0] panic at 810ba99c >

RE: [PATCH 6/8] Drivers: hv: vmbus: Remove unnecessary channel->lock critical sections (sc_list updaters)

2020-06-18 Thread Michael Kelley
From: Andrea Parri (Microsoft) Sent: Wednesday, June 17, 2020 9:47 AM > > None of the readers/updaters of sc_list rely on channel->lock for > synchronization. > > Signed-off-by: Andrea Parri (Microsoft) > --- > drivers/hv/channel_mgmt.c | 25 ++--- > 1 file changed, 6

RE: [PATCH 5/8] Drivers: hv: vmbus: Use channel_mutex in channel_vp_mapping_show()

2020-06-18 Thread Michael Kelley
From: Andrea Parri (Microsoft) Sent: Wednesday, June 17, 2020 9:47 AM > > The primitive currently uses channel->lock to protect the loop over > sc_list w.r.t. list additions/deletions but it doesn't protect the > target_cpu(s) loads w.r.t. a concurrent target_cpu_store(): while the > data races

[PATCH v2] arm: dts: am335x-pocketbeagle: add gpio-line-names

2020-06-18 Thread Drew Fustini
The BeagleBoard.org PocketBeagle has P1 and P2 headers [0] which expose many of the TI AM3358 SoC balls to stacking expansion boards called "capes", or to other external connections like jumper wires connected to a breadboard. Note: the AM3358 die is actually embedded inside of the OSD335x-SM

Re: [PATCH v3 3/3] printk: use the lockless ringbuffer

2020-06-18 Thread kernel test robot
Hi John, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on linux/master] [also build test WARNING on linus/master v5.8-rc1 next-20200618] [cannot apply to pmladek/for-next] [If your patch is applied to the wrong git tree, kindly drop us a note. And when

Re: [PATCH v13 00/16] Enable FSGSBASE instructions

2020-06-18 Thread Thomas Gleixner
Andy Lutomirski writes: > Is there a plan to deal with: > > /* > * This function has some ABI oddities. > * > * A 32-bit ptracer probably expects that writing FS or GS will change > * FSBASE or GSBASE respectively. In the absence of FSGSBASE support, >

[RFC PATCH] printk: _printk_rb_static_dict can be static

2020-06-18 Thread kernel test robot
Signed-off-by: kernel test robot --- printk.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c index 7642ef634956f..d812ada06735f 100644 --- a/kernel/printk/printk.c +++ b/kernel/printk/printk.c @@ -434,7 +434,7 @@ static

Re: [PATCH v2 09/16] rcu/tree: Maintain separate array for vmalloc ptrs

2020-06-18 Thread Uladzislau Rezki
On Thu, Jun 18, 2020 at 11:15:41AM -0700, Matthew Wilcox wrote: > On Thu, Jun 18, 2020 at 07:56:23PM +0200, Uladzislau Rezki wrote: > > If we mix pointers, then we can do free per pointer only. I mean in that > > case we will not be able to use kfree_bulk() interface for freeing SLAB > > memory

Re: [LTP] [x86/entry] 2bbc68f837: ltp.ptrace08.fail

2020-06-18 Thread Andy Lutomirski
On Wed, Jun 17, 2020 at 6:17 AM Cyril Hrubis wrote: > > Hi! > > > >> FYI, we noticed the following commit (built with gcc-9): > > > >> > > > >> commit: 2bbc68f8373c0631ebf137f376fbea00e8086be7 ("x86/entry: Convert > > > >> Debug exception to IDTENTRY_DB") > > > >>

Re: [PATCH v9 1/2] ACPI / APEI: Add support to notify the vendor specific HW errors

2020-06-18 Thread James Morse
Hi Shiju, On 15/06/2020 10:53, Shiju Jose wrote: > Add support to notify the vendor specific non-fatal HW errors > to the drivers for the error recovery. This doesn't apply cleanly to v5.8-rc1... thanks for waiting for the merge window to finish, but please rebase onto the latest and greatest

Re: [PATCH v3 20/21] dyndbg: add user-flag, negating-flags, and filtering on flags

2020-06-18 Thread Jason Baron
On 6/18/20 1:40 PM, Petr Mladek wrote: > On Thu 2020-06-18 18:19:12, Petr Mladek wrote: >> On Wed 2020-06-17 10:25:35, Jim Cromie wrote: >>> 1. Add a user-flag [u] which works like the [pfmlt] flags, but has no >>> effect on callsite behavior; it allows incremental marking of >>> arbitrary sets

Re: [PATCH v3] IB/srpt: Remove WARN_ON from srpt_cm_req_recv

2020-06-18 Thread Jason Gunthorpe
On Wed, Jun 17, 2020 at 10:08:03PM +0800, Jing Xiangfeng wrote: > The callers pass the pointer '' or 'private_data' to > srpt_cm_req_recv(), and 'private_data' is initialized in srp_send_req(). > 'sdev' is allocated and stored in srpt_add_one(). It's easy to show that > sdev and req are always

Re: [PATCH v3 20/21] dyndbg: add user-flag, negating-flags, and filtering on flags

2020-06-18 Thread jim . cromie
On Thu, Jun 18, 2020 at 10:19 AM Petr Mladek wrote: > > On Wed 2020-06-17 10:25:35, Jim Cromie wrote: OK. Please tell me how this chunk of prose fails to explain a use case for the u-flag we can differ on how useful it looks. if u-flag is useful, then filtering on flags is also needed, to use

Re: [PATCH v2 09/16] rcu/tree: Maintain separate array for vmalloc ptrs

2020-06-18 Thread Matthew Wilcox
On Thu, Jun 18, 2020 at 07:56:23PM +0200, Uladzislau Rezki wrote: > If we mix pointers, then we can do free per pointer only. I mean in that > case we will not be able to use kfree_bulk() interface for freeing SLAB > memory and the code would converted to something like: > > > while

Re: [EXTERNAL] fs/cifs/transport.c:1284:2-8: preceding lock on line 1277 (fwd)

2020-06-18 Thread Julia Lawall
On Thu, 18 Jun 2020, Steven French wrote: > Wasn't this fixed last year by: It looks like it. I received the message today from kbuild, but I didn't look further than that. Perhaps it is an old tree somehow. julia > > commit 8bd3754cff3aa6e80e73cb56042cdc6f76d6510e > Author: Dan Carpenter

Re: [PATCH 2/2] integrity: Add errno field in audit message

2020-06-18 Thread Mimi Zohar
On Thu, 2020-06-18 at 11:05 -0700, Lakshmi Ramasubramanian wrote: > On 6/18/20 10:41 AM, Mimi Zohar wrote: > > > > > For the reasons that I mentioned previously, unless others are willing > > to add their Reviewed-by tag not for the audit aspect in particular, > > but IMA itself, I'm not

Re: [PATCH v13 00/16] Enable FSGSBASE instructions

2020-06-18 Thread Andy Lutomirski
On Thu, Jun 18, 2020 at 7:18 AM Thomas Gleixner wrote: > > Sasha, > > Sasha Levin writes: > > Changes from v12: > > - Reformat the series to be closer to the reverted codebase for easier > >review. > > - Drop a few of the changes introduced in v8 and v9. > > I've pushed the lot out to > >

Re: [PATCH 4/5] dt-bindings: fpga: xilinx-slave-serial: add optional INIT_B GPIO

2020-06-18 Thread Rob Herring
On Wed, Jun 17, 2020 at 11:47 PM Luca Ceresoli wrote: > > Hi Rob, Moritz, > > On 18/06/20 00:39, Rob Herring wrote: > > On Thu, Jun 11, 2020 at 11:11:43PM +0200, Luca Ceresoli wrote: > >> The INIT_B is used by the 6 and 7 series to report the programming status, > >> providing more control and

Re: [PATCH rdma-rc 0/2] Two small fixes to the mlx5_ib

2020-06-18 Thread Jason Gunthorpe
On Thu, Jun 18, 2020 at 02:25:05PM +0300, Leon Romanovsky wrote: > From: Leon Romanovsky > > Hi, > > The following two fixes are user-visible one. The first patch is needed > to continue to use RAW_PACKET QPs after PR [1] is merged and new FW will > be released. The second patch fixes wrongly

Re: [PATCH v4 5/5] spi: spi-geni-qcom: Don't keep a local state variable

2020-06-18 Thread Stephen Boyd
Quoting Douglas Anderson (2020-06-18 08:06:26) > @@ -126,20 +120,23 @@ static void handle_fifo_timeout(struct spi_master *spi, > struct geni_se *se = >se; > > spin_lock_irq(>lock); > - reinit_completion(>xfer_done); > - mas->cur_mcmd = CMD_CANCEL; > -

Re: [PATCH 2/2] integrity: Add errno field in audit message

2020-06-18 Thread Lakshmi Ramasubramanian
On 6/18/20 10:41 AM, Mimi Zohar wrote: For the reasons that I mentioned previously, unless others are willing to add their Reviewed-by tag not for the audit aspect in particular, but IMA itself, I'm not comfortable making this change all at once. Previously I suggested making the existing

Re: [PATCH] arm: dts: am335x-pocketbeagle: add gpio-line-names

2020-06-18 Thread Drew Fustini
On Thu, Jun 18, 2020 at 10:03:45AM -0700, Tony Lindgren wrote: > * Drew Fustini [200617 17:10]: > > Tony - does this look ok for 5.9? > > Yes looks OK to me. > > Just wondering, are the line with "NA" not used internally either? > If the "NA" lines are used internally, we should probably use >

Re: [PATCH] tracing: Use linker magic instead of recasting ftrace_ops_list_func()

2020-06-18 Thread Jann Horn
On Thu, Jun 18, 2020 at 6:42 PM Steven Rostedt wrote: > > On Thu, 18 Jun 2020 01:12:37 +0200 > Jann Horn wrote: > > > static ftrace_func_t ftrace_ops_get_list_func(struct ftrace_ops *ops) > > +static ftrace_asm_func_t ftrace_ops_get_list_func(struct ftrace_ops *ops) > > { > > +#if

Re: [PATCH v2 09/16] rcu/tree: Maintain separate array for vmalloc ptrs

2020-06-18 Thread Paul E. McKenney
On Thu, Jun 18, 2020 at 07:35:20PM +0200, Uladzislau Rezki wrote: > > > > > > I don't think that replacing direct function calls with indirect function > > > calls is a great suggestion with the current state of play around branch > > > prediction. > > > > > > I'd suggest: > > > > > >

<    1   2   3   4   5   6   7   8   9   10   >