Re: [RFC][PATCH 7/7] sched: Replace rq::wake_list

2020-06-18 Thread Steven Rostedt
On Tue, Jun 09, 2020 at 02:25:09PM -0700, Guenter Roeck wrote: > > > > Still occurring on Linus' tree. This needs to be fixed. (And not by > > removing > > support for randstruct; that's not a "fix"...) > > > > How about the hack below ? My test suite failed due to this bug (on my

Re: [PATCH v2 09/16] rcu/tree: Maintain separate array for vmalloc ptrs

2020-06-18 Thread Uladzislau Rezki
On Thu, Jun 18, 2020 at 10:32:06AM -0700, Paul E. McKenney wrote: > On Thu, Jun 18, 2020 at 07:25:04PM +0200, Uladzislau Rezki wrote: > > > > + // Handle two first channels. > > > > + for (i = 0; i < FREE_N_CHANNELS; i++) { > > > > + for (; bkvhead[i]; bkvhead[i] = bnext)

Re: KASAN: null-ptr-deref Write in media_request_close

2020-06-18 Thread syzbot
syzbot has bisected this bug to: commit 016baa59bf9f6c2550480b73f18100285e3a4fd2 Author: Ezequiel Garcia Date: Tue Apr 14 22:06:24 2020 + media: Kconfig: Don't expose the Request API option bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=108d714910 start commit:

Re: [PATCH 0/3] zone-append support in aio and io-uring

2020-06-18 Thread Kanchan Joshi
On Wed, Jun 17, 2020 at 11:56:34PM -0700, Christoph Hellwig wrote: On Wed, Jun 17, 2020 at 10:53:36PM +0530, Kanchan Joshi wrote: This patchset enables issuing zone-append using aio and io-uring direct-io interface. For aio, this introduces opcode IOCB_CMD_ZONE_APPEND. Application uses start

Re: [PATCH v4 5/5] spi: spi-geni-qcom: Don't keep a local state variable

2020-06-18 Thread Stephen Boyd
Quoting Douglas Anderson (2020-06-18 08:06:26) > The variable "cur_mcmd" kept track of our current state (idle, xfer, > cs, cancel). We don't really need it, so get rid of it. Instead: > * Use separate condition variables for "chip select done", "cancel > done", and "abort done". This is

Re: [PATCH 1/2] media: v4l UAPI: add V4L2_BUF_CAP_SUPPORTS_RO_REQUESTS

2020-06-18 Thread Tomasz Figa
Hi Yunfei, On Wed, Jun 17, 2020 at 09:49:27AM +0800, Yunfei Dong wrote: > This patch adds support for the V4L2_BUF_CAP_SUPPORTS_RO_REQUESTS > flag. This flag is used for RO Request. I think this patch series lacks two major things: - a cover letter explaining the feature and what it is

Re: [PATCH v4 2/5] spi: spi-geni-qcom: Mo' betta locking

2020-06-18 Thread Stephen Boyd
Quoting Douglas Anderson (2020-06-18 08:06:23) > If you added a bit of a delay (like a trace_printk) into the ISR for > the spi-geni-qcom driver, you would suddenly start seeing some errors > spit out. The problem was that, though the ISR itself held a lock, > other parts of the driver didn't

Re: [PATCH v3 2/6] drm: msm: a6xx: send opp instead of a frequency

2020-06-18 Thread Rob Clark
On Fri, Jun 5, 2020 at 9:26 PM Sharat Masetty wrote: > > This patch changes the plumbing to send the devfreq recommended opp rather > than the frequency. Also consolidate and rearrange the code in a6xx to set > the GPU frequency and the icc vote in preparation for the upcoming > changes for

Re: [PATCH 1/2] nvme: remove workarounds for gcc bug wrt unnamed fields in initializers

2020-06-18 Thread kernel test robot
Hi Niklas, I love your patch! Yet something to improve: [auto build test ERROR on block/for-next] [also build test ERROR on linus/master v5.8-rc1 next-20200618] [cannot apply to hch-configfs/for-next] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting

Re: [PATCH] dma-mapping: DMA_COHERENT_POOL should select GENERIC_ALLOCATOR

2020-06-18 Thread David Rientjes
On Thu, 18 Jun 2020, Christoph Hellwig wrote: > The dma coherent pool code needs genalloc. Move the select over > from DMA_REMAP, which doesn't actually need it. > > Fixes: dbed452a078d ("dma-pool: decouple DMA_REMAP from DMA_COHERENT_POOL") > Reported-by: kernel test robot Acked-by: David

PC speaker

2020-06-18 Thread R.F. Burns
Is it possible to write a kernel module which, when loaded, will blow the PC speaker?

Re: [PATCH] usbip: tools: fix module name in man page

2020-06-18 Thread Shuah Khan
On 6/18/20 10:56 AM, Shuah Khan wrote: On 6/17/20 6:08 PM, Antonio Borneo wrote: Commit 64e62426f40d ("staging: usbip: edit Kconfig and rename CONFIG options") renamed the module usbip as usbip-host, but the example in the man page still reports the old module name. Fix the module name in

Re: [PATCH 2/2] integrity: Add errno field in audit message

2020-06-18 Thread Mimi Zohar
On Wed, 2020-06-17 at 13:44 -0700, Lakshmi Ramasubramanian wrote: > Error code is not included in the audit messages logged by > the integrity subsystem. Add "errno" field in the audit messages > logged by the integrity subsystem and set the value to the error code > passed to

Re: [PATCH v3 20/21] dyndbg: add user-flag, negating-flags, and filtering on flags

2020-06-18 Thread Petr Mladek
On Thu 2020-06-18 18:19:12, Petr Mladek wrote: > On Wed 2020-06-17 10:25:35, Jim Cromie wrote: > > 1. Add a user-flag [u] which works like the [pfmlt] flags, but has no > > effect on callsite behavior; it allows incremental marking of > > arbitrary sets of callsites. > > > > 2. Add [PFMLTU]

Re: [PATCH] usbip: tools: fix build error for multiple definition

2020-06-18 Thread Shuah Khan
On 6/17/20 6:08 PM, Antonio Borneo wrote: With GCC 10, building usbip triggers error for multiple definition of 'udev_context', in: - libsrc/vhci_driver.c:18 and - libsrc/usbip_host_common.c:27. Declare as extern the definition in libsrc/usbip_host_common.c. Signed-off-by: Antonio Borneo ---

KMSAN: uninit-value in hash_ip6_add

2020-06-18 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:f0d5ec90 kmsan: apply __no_sanitize_memory to dotraplinkag.. git tree: https://github.com/google/kmsan.git master console output: https://syzkaller.appspot.com/x/log.txt?x=126592fa10 kernel config:

Re: [PATCH v2 09/16] rcu/tree: Maintain separate array for vmalloc ptrs

2020-06-18 Thread Matthew Wilcox
On Thu, Jun 18, 2020 at 07:30:49PM +0200, Uladzislau Rezki wrote: > > I'd suggest: > > > > rcu_lock_acquire(_callback_map); > > trace_rcu_invoke_kfree_bulk_callback(rcu_state.name, > > bkvhead[i]->nr_records,

Re: [PATCH v2 09/16] rcu/tree: Maintain separate array for vmalloc ptrs

2020-06-18 Thread Uladzislau Rezki
> > > > I don't think that replacing direct function calls with indirect function > > calls is a great suggestion with the current state of play around branch > > prediction. > > > > I'd suggest: > > > > rcu_lock_acquire(_callback_map); > >

Re: [PATCH v2 1/3] mfd: core: Make a best effort attempt to match devices with the correct of_nodes

2020-06-18 Thread Frank Rowand
On 2020-06-15 04:26, Lee Jones wrote: > On Sun, 14 Jun 2020, Frank Rowand wrote: > >> Hi Lee, >> >> I'm looking at 5.8-rc1. >> >> The only use of OF_MFD_CELL() where the same compatible is specified >> for multiple elements of a struct mfd_cell array is for compatible >> "stericsson,ab8500-pwm"

Re: [PATCH] driver core:Export the symbol device_is_bound

2020-06-18 Thread Rob Herring
On Thu, Jun 18, 2020 at 10:51 AM Matthias Kaehlcke wrote: > > On Thu, Jun 18, 2020 at 05:58:20PM +0200, Greg Kroah-Hartman wrote: > > On Thu, Jun 18, 2020 at 08:45:55AM -0700, Matthias Kaehlcke wrote: > > > Hi Greg, > > > > > > On Thu, Jun 18, 2020 at 10:14:43AM +0200, Greg Kroah-Hartman wrote: >

Re: [PATCH 1/2] nvme: remove workarounds for gcc bug wrt unnamed fields in initializers

2020-06-18 Thread Niklas Cassel
On Thu, Jun 18, 2020 at 07:11:24PM +0200, Daniel Wagner wrote: > On Thu, Jun 18, 2020 at 04:32:40PM +0200, Niklas Cassel wrote: > > If, for some reason, we want to allow builds with gcc < 4.6.0 > > even though the minimum gcc version is now 4.8.0, > > Just one thing to watch out: the stable trees

Re: [PATCH v2 09/16] rcu/tree: Maintain separate array for vmalloc ptrs

2020-06-18 Thread Paul E. McKenney
On Thu, Jun 18, 2020 at 07:25:04PM +0200, Uladzislau Rezki wrote: > > > + // Handle two first channels. > > > + for (i = 0; i < FREE_N_CHANNELS; i++) { > > > + for (; bkvhead[i]; bkvhead[i] = bnext) { > > > + bnext = bkvhead[i]->next; > > > +

Re: [pipe] 566d136289: stress-ng.tee.ops_per_sec -84.7% regression

2020-06-18 Thread Linus Torvalds
On Wed, Jun 17, 2020 at 10:18 PM Tetsuo Handa wrote: > > This would be because the test case shows higher performance if the pipe > writer does busy wait. > This commit fixed an unkillable busy wait bug when the pipe reader does not > try to read. > > > If you fix the issue, kindly add

Re: [PATCH v2 09/16] rcu/tree: Maintain separate array for vmalloc ptrs

2020-06-18 Thread Uladzislau Rezki
> > > > Not an emergency, but did you look into replacing this "if" statement > > with an array of pointers to functions implementing the legs of the > > "if" statement? If nothing else, this would greatly reduced indentation. > > I don't think that replacing direct function calls with indirect

Re: [Linaro-mm-sig] [PATCH 04/18] dma-fence: prime lockdep annotations

2020-06-18 Thread Jason Gunthorpe
On Thu, Jun 18, 2020 at 05:00:51PM +0200, Daniel Vetter wrote: > On Wed, Jun 17, 2020 at 12:28:35PM -0300, Jason Gunthorpe wrote: > > On Wed, Jun 17, 2020 at 08:48:50AM +0200, Daniel Vetter wrote: > > > > > Now my understanding for rdma is that if you don't have hw page fault > > > support, > >

Re: [PATCH v4 06/17] media: mtk-jpeg: Get rid of mtk_smi_larb_get/put

2020-06-18 Thread Rick Chang
Hi Yong, On Thu, 2020-06-18 at 17:32 +0800, Yong Wu wrote: > + Rick > > On Sat, 2020-05-30 at 16:10 +0800, Yong Wu wrote: > > > > MediaTek IOMMU has already added device_link between the consumer > > and smi-larb device. If the jpg device call the > > pm_runtime_get_sync, > > the smi-larb's

Re: [PATCH 2/2] nvmet: remove workarounds for gcc bug wrt unnamed fields in initializers

2020-06-18 Thread Chaitanya Kulkarni
I'm not against the code cleanup and it always welcome. Please also have a look at other comment. >> What is the issue with existing code that we need this patch for ? >> > > Hello Chaitanya, > > This is just a cleanup patch, no functional change intended. > I can see that. > It simply

[PATCH v9 9/9] firmware: arm_scmi: Add Base notifications support

2020-06-18 Thread Cristian Marussi
Make SCMI Base protocol register with the notification core. Reviewed-by: Jonathan Cameron Signed-off-by: Cristian Marussi --- V8 --> V9 - moved pr_info to pr_debug - removed switch() - use SCMI_PROTO_QUEUE_SZ V6 --> V7 - fixed report.timestamp type - fix max_payld_sz initialization - fix

[PATCH v9 1/9] firmware: arm_scmi: Add notification protocol-registration

2020-06-18 Thread Cristian Marussi
Add core SCMI Notifications protocol-registration support: allow protocols to register their own set of supported events, during their initialization phase. Notification core can track multiple platform instances by their handles. Reviewed-by: Jonathan Cameron Signed-off-by: Cristian Marussi

[PATCH v9 3/9] firmware: arm_scmi: Add notification dispatch and delivery

2020-06-18 Thread Cristian Marussi
Add core SCMI Notifications dispatch and delivery support logic which is able, at first, to dispatch well-known received events from the RX ISR to the dedicated deferred worker, and then, from there, to final deliver the events to the registered users' callbacks. Dispatch and delivery is just

[PATCH v9 2/9] firmware: arm_scmi: Add notification callbacks-registration

2020-06-18 Thread Cristian Marussi
Add core SCMI Notifications callbacks-registration support: allow users to register their own callbacks against the desired events. Whenever a registration request is issued against a still non existent event, mark such request as pending for later processing, in order to account for possible late

[PATCH v9 5/9] firmware: arm_scmi: Add Power notifications support

2020-06-18 Thread Cristian Marussi
Make SCMI Power protocol register with the notification core. Reviewed-by: Jonathan Cameron Signed-off-by: Cristian Marussi --- V8 --> V9 - moved pr_info to pr_debug - removed switch() - use SCMI_PROTO_QUEUE_SZ V6 --> V7 - fixed report.timestamp type - removed POWER_STATE_CHANGE_REQUESTED

[PATCH v9 7/9] firmware: arm_scmi: Add Sensor notifications support

2020-06-18 Thread Cristian Marussi
Make SCMI Sensor protocol register with the notification core. Reviewed-by: Jonathan Cameron Signed-off-by: Cristian Marussi --- V8 --> V9 - moved pr_info to pr_debug - removed switch() - use SCMI_PROTO_QUEUE_SZ V6 --> V7 - fixed report.timestamp type - removed trip_point_notify from

[PATCH v9 4/9] firmware: arm_scmi: Enable notification core

2020-06-18 Thread Cristian Marussi
Initialize and enable SCMI Notifications core support during bus/driver probe phase, so that protocols can start registering their supported events during their initialization. Reviewed-by: Jonathan Cameron Signed-off-by: Cristian Marussi --- V3 --> V4 - simplified core initialization:

[PATCH v9 6/9] firmware: arm_scmi: Add Perf notifications support

2020-06-18 Thread Cristian Marussi
Make SCMI Perf protocol register with the notification core. Reviewed-by: Jonathan Cameron Signed-off-by: Cristian Marussi --- V8 --> V9 - moved pr_info to pr_debug - inlined MAP_EVT_TO_ENABLE_CMD - use SCMI_PROTO_QUEUE_SZ V6 --> V7 - fixed report.timestamp type - fixed max_payld_sz

[PATCH v9 8/9] firmware: arm_scmi: Add Reset notifications support

2020-06-18 Thread Cristian Marussi
Make SCMI Reset protocol register with the notification core. Reviewed-by: Jonathan Cameron Signed-off-by: Cristian Marussi --- V8 --> V9 - moved pr_info to pr_debug - removed switch() - use SCMI_PROTO_QUEUE_SZ V6 --> V7 - fixed report.timestamp type - added agent_id notification field - fixed

[PATCH v9 0/9] SCMI Notifications Core Support

2020-06-18 Thread Cristian Marussi
Hi all, this series wants to introduce SCMI Notification Support, built on top of the standard Kernel notification chain subsystem. At initialization time each SCMI Protocol takes care to register with the new SCMI notification core the set of its own events which it intends to support. Using

[PATCH] Revert "ARM: sti: Implement dummy L2 cache's write_sec"

2020-06-18 Thread patrice.chotard
From: Patrice Chotard This reverts commit 7b8e0188fa717cd9abc4fb52587445b421835c2a. Initially, STiH410-B2260 was supposed to be secured, that's why l2c_write_sec was stubbed to avoid secure register access from non secure world. But by default, STiH410-B2260 is running in non secure mode, so

Re: [PATCH v2 09/16] rcu/tree: Maintain separate array for vmalloc ptrs

2020-06-18 Thread Uladzislau Rezki
> > + // Handle two first channels. > > + for (i = 0; i < FREE_N_CHANNELS; i++) { > > + for (; bkvhead[i]; bkvhead[i] = bnext) { > > + bnext = bkvhead[i]->next; > > + debug_rcu_bhead_unqueue(bkvhead[i]); > > + > > +

WARNING with LBR + precise_ip=2 + bpf_get_stackid()

2020-06-18 Thread Song Liu
Hi, We are debugging some WARNING with LBR, precise_ip=2 and bpf_get_stackid(), like: [36000.334284] WARNING: stack recursion on stack type 1 [36000.334288] WARNING: can't access registers at syscall_return_via_sysret+0x12/0x7f This happens when we attach BPF program to perf_event with:

Re: [PATCH v3 2/4] dt-bindings: nvmem: Add properties needed for blowing fuses

2020-06-18 Thread Doug Anderson
Hi, On Thu, Jun 18, 2020 at 9:55 AM Stephen Boyd wrote: > > Quoting Doug Anderson (2020-06-18 08:32:20) > > Hi, > > > > On Thu, Jun 18, 2020 at 7:01 AM Srinivas Kandagatla > > > > > > On the other note: > > > > > > clock-names are not mandatory according to > > >

Re: [PATCH 4/4] pci: export untrusted attribute in sysfs

2020-06-18 Thread Rajat Jain
Thanks Greg and Andy for your continued inputs, and thanks Ashok for chiming in. On Thu, Jun 18, 2020 at 9:23 AM Raj, Ashok wrote: > > Hi Greg, > > > On Thu, Jun 18, 2020 at 06:02:12PM +0200, Greg Kroah-Hartman wrote: > > On Thu, Jun 18, 2020 at 08:03:49AM -0700, Rajat Jain wrote: > > > Hello, >

Re: [PATCH v8 9/9] firmware: arm_scmi: Add Base notifications support

2020-06-18 Thread Cristian Marussi
On Mon, Jun 08, 2020 at 06:02:39PM +0100, Sudeep Holla wrote: > On Wed, May 20, 2020 at 09:11:18AM +0100, Cristian Marussi wrote: > > Make SCMI Base protocol register with the notification core. > > > > Reviewed-by: Jonathan Cameron > > Signed-off-by: Cristian Marussi > > --- > > V6 --> V7 > > -

Re: [PATCH 27/29] docs: dt: minor adjustments at writing-schema.rst

2020-06-18 Thread Rob Herring
On Mon, Jun 15, 2020 at 08:47:06AM +0200, Mauro Carvalho Chehab wrote: > There are two literal blocks that aren't mark as such. Mark them, > in order to make the document to produce a better html output. > > While here, also add a SPDX header to it. > > Signed-off-by: Mauro Carvalho Chehab >

[PATCH v4] xfs: Fix false positive lockdep warning with sb_internal & fs_reclaim

2020-06-18 Thread Waiman Long
Depending on the workloads, the following circular locking dependency warning between sb_internal (a percpu rwsem) and fs_reclaim (a pseudo lock) may show up: == WARNING: possible circular locking dependency detected 5.0.0-rc1+ #60 Tainted: G

Re: [PATCH 15/29] dt: fix reference to olpc,xo1.75-ec.txt

2020-06-18 Thread Rob Herring
On Mon, 15 Jun 2020 08:46:54 +0200, Mauro Carvalho Chehab wrote: > This file was converted and renamed. > > Fixes: 7882d822b3f9 ("dt-bindings: spi: Convert spi-pxa2xx to json-schema") > Signed-off-by: Mauro Carvalho Chehab > --- > Documentation/devicetree/bindings/misc/olpc,xo1.75-ec.txt | 2 +-

Re: [PATCH v3 05/15] arm64: kvm: Build hyp-entry.S separately for VHE/nVHE

2020-06-18 Thread Marc Zyngier
Hi David, On 2020-06-18 13:25, David Brazdil wrote: This patch is part of a series which builds KVM's non-VHE hyp code separately from VHE and the rest of the kernel. The above comment doesn't really belong here, and us only fit for the cover letter. hyp-entry.S contains implementation

Re: [PATCH 07/25] mm/csky: Use mm_fault_accounting()

2020-06-18 Thread Linus Torvalds
On Thu, Jun 18, 2020 at 7:38 AM Peter Xu wrote: > > GUP needs the per-task accounting, but not the perf events. We can do that by > slightly changing the new approach into: > > bool major = (ret & VM_FAULT_MAJOR) || (flags & FAULT_FLAG_TRIED); > > if (major) >

Re: [PATCH v2] Revert "zram: convert remaining CLASS_ATTR() to CLASS_ATTR_RO()"

2020-06-18 Thread Steffen Maier
On 6/17/20 1:49 PM, Greg Kroah-Hartman wrote: From: Wade Mealing Turns out that the permissions for 0400 really are what we want here, otherwise any user can read from this file. [fixed formatting, added changelog, and made attribute static - gregkh] Reported-by: Wade Mealing Cc: stable

Re: [PATCH 1/2] nvme: remove workarounds for gcc bug wrt unnamed fields in initializers

2020-06-18 Thread Daniel Wagner
On Thu, Jun 18, 2020 at 04:32:40PM +0200, Niklas Cassel wrote: > If, for some reason, we want to allow builds with gcc < 4.6.0 > even though the minimum gcc version is now 4.8.0, Just one thing to watch out: the stable trees are still using older version of gcc. Note sure how relevant this is

Re: [PATCH] usbip: tools: add in man page how to load the client's module

2020-06-18 Thread Shuah Khan
On 6/17/20 6:08 PM, Antonio Borneo wrote: While the man page usbipd.8 already informs the user on which kernel module has to be used on server side, the man page usbip.8 does not provide any equivalent information on client side. Also, it could be hard for a newby to identify the proper usbip

Re: New mode DM-Verity error handling

2020-06-18 Thread Mike Snitzer
On Thu, Jun 18 2020 at 12:50pm -0400, Sami Tolvanen wrote: > On Thu, Jun 18, 2020 at 11:44:45AM -0400, Mike Snitzer wrote: > > I do not accept that panicing the system because of verity failure is > > reasonable. > > > > In fact, even rebooting (via DM_VERITY_MODE_RESTART) looks very wrong. > >

Re: [PATCH 14/29] dt: Fix broken references to renamed docs

2020-06-18 Thread Rob Herring
On Mon, 15 Jun 2020 08:46:53 +0200, Mauro Carvalho Chehab wrote: > Some files got renamed. Those were all fixed automatically by > > ./scripts/documentation-file-ref-check --fix > > Signed-off-by: Mauro Carvalho Chehab > --- > Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt

Re: [PATCH v3 04/15] arm64: kvm: Handle calls to prefixed hyp functions

2020-06-18 Thread kernel test robot
Hi David, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on linus/master] [also build test WARNING on v5.8-rc1 next-20200618] [cannot apply to kvmarm/next arm64/for-next/core arm-perf/for-next/perf] [If your patch is applied to the wrong git tree, kindly drop us

Re: [PATCH v6 4/5] cpufreq: qcom: Update the bandwidth levels on frequency change

2020-06-18 Thread Matthias Kaehlcke
On Wed, Jun 17, 2020 at 10:13:21PM +0530, Sibi Sankar wrote: > On 2020-06-17 03:41, Matthias Kaehlcke wrote: > > Hi Sibi, > > > > after doing the review I noticed that Viresh replied on the cover letter > > that he picked the series up for v5.9, so I'm not sure if it makes sense > > to send a v7.

Re: [PATCH v10 2/2] PCI: hip: Add handling of HiSilicon HIP PCIe controller errors

2020-06-18 Thread Andy Shevchenko
On Thu, Jun 18, 2020 at 04:35:31PM +, Shiju Jose wrote: > >-Original Message- > >From: Andy Shevchenko [mailto:andriy.shevche...@linux.intel.com] > >Sent: 18 June 2020 16:56 > >To: Shiju Jose > >Cc: linux-a...@vger.kernel.org; linux-...@vger.kernel.org; linux- >

Re: [PATCH] arm: dts: am335x-pocketbeagle: add gpio-line-names

2020-06-18 Thread Tony Lindgren
* Drew Fustini [200617 17:10]: > Tony - does this look ok for 5.9? Yes looks OK to me. Just wondering, are the line with "NA" not used internally either? If the "NA" lines are used internally, we should probably use "Reserved" or "Internal" or something like that to avoid later on having to

Re: [PATCH] sparse: use identifiers to define address spaces

2020-06-18 Thread Linus Torvalds
On Thu, Jun 18, 2020 at 3:06 AM kernel test robot wrote: > > I love your patch! Perhaps something to improve: The new warnings don't seem to be due to the kernel test robot having an old version of sparse, but just because the error strings changed, and presumably the kernel test robot has some

Re: [PATCH] sparse: use identifiers to define address spaces

2020-06-18 Thread kernel test robot
Hi Luc, I love your patch! Perhaps something to improve: [auto build test WARNING on linux/master] [also build test WARNING on linus/master v5.8-rc1 next-20200618] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use as documented

Re: [PATCH v2 02/12] ocxl: Change type of pasid to unsigned int

2020-06-18 Thread Frederic Barrat
Le 18/06/2020 à 17:37, Fenghua Yu a écrit : The first 3 patches clean up pasid and flag defitions to prepare for following patches. If you think this patch can be dropped, we will drop it. Yes, I think that's the case. Thanks, Fred

Re: [PATCH] usbip: tools: fix module name in man page

2020-06-18 Thread Shuah Khan
On 6/17/20 6:08 PM, Antonio Borneo wrote: Commit 64e62426f40d ("staging: usbip: edit Kconfig and rename CONFIG options") renamed the module usbip as usbip-host, but the example in the man page still reports the old module name. Fix the module name in usbipd.8 Signed-off-by: Antonio Borneo

Re: [PATCH v2 2/8] iommu: arm-smmu-impl: Use qcom impl for sm8150 and sm8250 compatibles

2020-06-18 Thread Robin Murphy
On 2020-06-09 20:40, Jonathan Marek wrote: Use the qcom implementation for IOMMU hardware on sm8150 and sm8250 SoCs. Given a promise that anyone who wants to add more of these in future converts it into an of_device_id table exported from arm-smmu-qcom, Reviewed-by Robin Murphy

Re: [PATCH v3 04/15] arm64: kvm: Handle calls to prefixed hyp functions

2020-06-18 Thread Marc Zyngier
Hi David, On 2020-06-18 13:25, David Brazdil wrote: From: Andrew Scull This patch is part of a series which builds KVM's non-VHE hyp code separately from VHE and the rest of the kernel. Once hyp functions are moved to a hyp object, they will have prefixed symbols. This change declares and

Re: [PATCH] driver core:Export the symbol device_is_bound

2020-06-18 Thread Matthias Kaehlcke
On Thu, Jun 18, 2020 at 05:58:20PM +0200, Greg Kroah-Hartman wrote: > On Thu, Jun 18, 2020 at 08:45:55AM -0700, Matthias Kaehlcke wrote: > > Hi Greg, > > > > On Thu, Jun 18, 2020 at 10:14:43AM +0200, Greg Kroah-Hartman wrote: > > > On Wed, Jun 03, 2020 at 12:09:52AM +0530, Sandeep Maheswaram

Re: [dm-devel] New mode DM-Verity error handling

2020-06-18 Thread Sami Tolvanen
On Thu, Jun 18, 2020 at 11:44:45AM -0400, Mike Snitzer wrote: > I do not accept that panicing the system because of verity failure is > reasonable. > > In fact, even rebooting (via DM_VERITY_MODE_RESTART) looks very wrong. > > The device should be put in a failed state and left for admin

[PATCH v1 2/6] serial: sunsab: Return proper error code from console ->setup() hook

2020-06-18 Thread Andy Shevchenko
For unifying console ->setup() handling, which is pure documented, return error code, rather than non-zero arbitrary number. Signed-off-by: Andy Shevchenko Cc: "David S. Miller" --- drivers/tty/serial/sunsab.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH v1 0/6] console: unify return codes from ->setup() hook

2020-06-18 Thread Andy Shevchenko
Some of the console providers treat error code, returned by ->setup() hook, differently. Here is the unification of the behaviour. The drivers checked by one of the below criteria: 1/ the driver has explicit struct console .setup assignment 2/ the driver has assigned callback to the setup member

Re: [PATCH] ASoC: rockchip: Fix a reference count leak.

2020-06-18 Thread Mark Brown
On Sat, 13 Jun 2020 15:51:58 -0500, wu000...@umn.edu wrote: > Calling pm_runtime_get_sync increments the counter even in case of > failure, causing incorrect ref count if pm_runtime_put is not called in > error handling paths. Call pm_runtime_put if pm_runtime_get_sync fails. Applied to

[PATCH v1 6/6] console: Fix trivia typo 'change' -> 'chance'

2020-06-18 Thread Andy Shevchenko
I bet the word 'chance' has to be used in 'had a chance to be called', but, alas, I'm not native speaker... Signed-off-by: Andy Shevchenko Cc: Benjamin Herrenschmidt --- kernel/printk/printk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/printk/printk.c

[PATCH v1 3/6] serial: sunzilog: Return proper error code from console ->setup() hook

2020-06-18 Thread Andy Shevchenko
For unifying console ->setup() handling, which is pure documented, return error code, rather than non-zero arbitrary number. Signed-off-by: Andy Shevchenko Cc: "David S. Miller" --- drivers/tty/serial/sunzilog.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH v3 0/5] spi: spi-geni-qcom: Fixes / perf improvements

2020-06-18 Thread Mark Brown
On Tue, 16 Jun 2020 03:40:45 -0700, Douglas Anderson wrote: > This patch series is a new version of the previous patch posted: > [PATCH v2] spi: spi-geni-qcom: Speculative fix of "nobody cared" about > interrupt > >

[PATCH v1 4/6] tty: hvc: Return proper error code from console ->setup() hook

2020-06-18 Thread Andy Shevchenko
For unifying console ->setup() handling, which is pure documented, return error code, rather than non-zero arbitrary number. Signed-off-by: Andy Shevchenko --- drivers/tty/hvc/hvsi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/tty/hvc/hvsi.c

[PATCH v1 1/6] mips: Return proper error code from console ->setup() hook

2020-06-18 Thread Andy Shevchenko
For unifying console ->setup() handling, which is pure documented, return error code, rather than non-zero arbitrary number. Signed-off-by: Andy Shevchenko Cc: Thomas Bogendoerfer --- arch/mips/fw/arc/arc_con.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git

Re: [PATCH 1/2] spi: spidev: fix a race between spidev_release and spidev_remove

2020-06-18 Thread Mark Brown
On Thu, 18 Jun 2020 11:21:24 +0800, Zhenzhong Duan wrote: > Imagine below scene, spidev is referenced after it's freed. > > spidev_release()spidev_remove() > ... > spin_lock_irq(>spi_lock); > spidev->spi = NULL; >

[PATCH v1 5/6] console: Propagate error code from console ->setup()

2020-06-18 Thread Andy Shevchenko
Since console ->setup() hook returns meaningful error codes, propagate it to the caller of try_enable_new_console(). Signed-off-by: Andy Shevchenko Cc: Benjamin Herrenschmidt --- kernel/printk/printk.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

Re: [PATCH 13/29] dt: fix broken links due to txt->yaml renames

2020-06-18 Thread Rob Herring
On Mon, 15 Jun 2020 08:46:52 +0200, Mauro Carvalho Chehab wrote: > There are some new broken doc links due to yaml renames > at DT. Developers should really run: > > ./scripts/documentation-file-ref-check > > in order to solve those issues while submitting patches. > This tool can even fix

Re: [PATCH] tracing: Use linker magic instead of recasting ftrace_ops_list_func()

2020-06-18 Thread Steven Rostedt
On Thu, 18 Jun 2020 01:12:37 +0200 Jann Horn wrote: > static ftrace_func_t ftrace_ops_get_list_func(struct ftrace_ops *ops) > +static ftrace_asm_func_t ftrace_ops_get_list_func(struct ftrace_ops *ops) > { > +#if FTRACE_FORCE_LIST_FUNC > + return ftrace_ops_list_func; > +#else > /*

Re: [PATCH 12/29] dt: update a reference for reneases pcar file renamed to yaml

2020-06-18 Thread Rob Herring
On Mon, 15 Jun 2020 08:46:51 +0200, Mauro Carvalho Chehab wrote: > This file was renamed, but its reference at pfc-pinctl.txt is > still pointing to the old file. > > Fixes: 7f7d408e5a00 ("dt-bindings: gpio: rcar: Convert to json-schema") > Signed-off-by: Mauro Carvalho Chehab > --- >

Re: [PATCH v5 3/3] net: phy: mscc: handle the clkout control on some phy variants

2020-06-18 Thread Russell King - ARM Linux admin
On Thu, Jun 18, 2020 at 06:01:29PM +0200, Heiko Stübner wrote: > Am Donnerstag, 18. Juni 2020, 17:47:48 CEST schrieb Russell King - ARM Linux > admin: > > On Thu, Jun 18, 2020 at 05:41:54PM +0200, Heiko Stübner wrote: > > > Though I'm not sure how this fits in the whole bringup of ethernet phys.

Re: [Cluster-devel] [PATCH v11 16/25] fs: Convert mpage_readpages to mpage_readahead

2020-06-18 Thread Andreas Gruenbacher
On Thu, Jun 18, 2020 at 5:03 PM Matthew Wilcox wrote: > > On Thu, Jun 18, 2020 at 02:46:03PM +0200, Andreas Gruenbacher wrote: > > On Wed, Jun 17, 2020 at 4:22 AM Matthew Wilcox wrote: > > > On Wed, Jun 17, 2020 at 02:57:14AM +0200, Andreas Grünbacher wrote: > > > > Right, the approach from the

RE: [PATCH] x86/asm/64: Align start of __clear_user() loop to 16-bytes

2020-06-18 Thread David Laight
From: Alexey Dobriyan > Sent: 18 June 2020 14:17 ... > > > diff --git a/arch/x86/lib/usercopy_64.c b/arch/x86/lib/usercopy_64.c > > > index fff28c6f73a2..b0dfac3d3df7 100644 > > > --- a/arch/x86/lib/usercopy_64.c > > > +++ b/arch/x86/lib/usercopy_64.c > > > @@ -24,6 +24,7 @@ unsigned long

Re: [PATCH v3 1/2] mfd: da9063: Fix revision handling to correctly select reg tables

2020-06-18 Thread Lee Jones
On Thu, 18 Jun 2020, Adam Thomson wrote: > On 18 June 2020 12:15, Lee Jones wrote: > > > > > > The current implementation performs checking in the i2c_probe() > > > > > function of the variant_code but does this immediately after the > > > > > containing struct has been initialised as all zero.

RE: [PATCH v10 2/2] PCI: hip: Add handling of HiSilicon HIP PCIe controller errors

2020-06-18 Thread Shiju Jose
Hi Andy, >-Original Message- >From: Andy Shevchenko [mailto:andriy.shevche...@linux.intel.com] >Sent: 18 June 2020 16:56 >To: Shiju Jose >Cc: linux-a...@vger.kernel.org; linux-...@vger.kernel.org; linux- >ker...@vger.kernel.org; r...@rjwysocki.net; helg...@kernel.org; >b...@alien8.de;

Re: [PATCH v3 03/15] arm64: kvm: Add build rules for separate nVHE object files

2020-06-18 Thread Marc Zyngier
Hi David, On 2020-06-18 13:25, David Brazdil wrote: Add new folder arch/arm64/kvm/hyp/nvhe and a Makefile for building code that runs in EL2 under nVHE KVM. Compile each source file into a `.hyp.tmp.o` object first, then prefix all its symbols with "__kvm_nvhe_" using `objcopy` and produce

[PATCH v2] tracing/boottime: Fix kprobe multiple events

2020-06-18 Thread Sascha Ortmann
Fix boottime kprobe events to report and abort after each failure when adding probes. As an example, when we try to set multiprobe kprobe events in bootconfig like this: ftrace.event.kprobes.vfsevents { probes = "vfs_read $arg1 $arg2,, !error! not reported;?", // leads

Re: [PATCH v5 9/9] arm64: dts: renesas: salvator: add a connection from adv748x codec (HDMI input) to the R-Car SoC

2020-06-18 Thread Kieran Bingham
Hi Alex, On 02/04/2020 19:35, Alex Riesen wrote: > As all known variants of the Salvator board have the HDMI decoder > chip (the ADV7482) connected to the SSI4 on R-Car SoC, the ADV7482 > endpoint and the connection definitions are placed in the common board > file. > > For the same reason, the

Re: [PATCH v4 1/2] thermal: add support for the MCU controlled FAN on Khadas boards

2020-06-18 Thread Lee Jones
On Thu, 18 Jun 2020, Neil Armstrong wrote: > The new Khadas VIM2 and VIM3 boards controls the cooling fan via the > on-board microcontroller. > > This implements the FAN control as thermal devices and as cell of the Khadas > MCU MFD driver. > > Signed-off-by: Neil Armstrong > Reviewed-by: Amit

Re: [PATCH v5 8/9] dt-bindings: adv748x: add information about serial audio interface (I2S/TDM)

2020-06-18 Thread Kieran Bingham
Hi Alex, On 02/04/2020 19:35, Alex Riesen wrote: > As the driver has some support for the audio interface of the device, > the bindings file should mention it. > > Signed-off-by: Alexander Riesen > Reviewed-by: Rob Herring > Reviewed-by: Laurent Pinchart Reviewed-by: Kieran Bingham > -- >

Re: [PATCH 6/6] smp: Cleanup smp_call_function*()

2020-06-18 Thread Peter Zijlstra
On Wed, Jun 17, 2020 at 11:51:07PM -0700, Christoph Hellwig wrote: > Much better. Although if we touch all the callers we might as well > pass the csd as the argument to the callback, as with that we can > pretty trivially remove the private data field later. My plan was to introduce a new

Re: [PATCH 4/4] pci: export untrusted attribute in sysfs

2020-06-18 Thread Raj, Ashok
Hi Greg, On Thu, Jun 18, 2020 at 06:02:12PM +0200, Greg Kroah-Hartman wrote: > On Thu, Jun 18, 2020 at 08:03:49AM -0700, Rajat Jain wrote: > > Hello, > > > > On Thu, Jun 18, 2020 at 2:14 AM Andy Shevchenko > > wrote: > > > > > > On Thu, Jun 18, 2020 at 11:36 AM Greg Kroah-Hartman > > > wrote:

Re: [PATCH v5 6/9] media: adv748x: prepare/enable mclk when the audio is used

2020-06-18 Thread Kieran Bingham
Hi Alex, On 02/04/2020 19:34, Alex Riesen wrote: > As there is nothing else (the consumers are supposed to do that) which > enables the clock, do it in the driver. > > Signed-off-by: Alexander Riesen > -- > > v3: added > --- > drivers/media/i2c/adv748x/adv748x-dai.c | 14 +- > 1

Re: [PATCH -next] lib: fix test_hmm.c reference after free

2020-06-18 Thread Ralph Campbell
On 6/17/20 10:31 PM, Randy Dunlap wrote: From: Randy Dunlap Coccinelle scripts report the following errors: lib/test_hmm.c:523:20-26: ERROR: reference preceded by free on line 521 lib/test_hmm.c:524:21-27: ERROR: reference preceded by free on line 521 lib/test_hmm.c:523:28-35: ERROR: devmem

[PATCH 1/2] sched: fix thread_union::task visibility

2020-06-18 Thread Masahiro Yamada
When CONFIG_ARCH_TASK_STRUCT_ON_STACK=y (i.e. ARCH=ia64), task_struct and the thread stack are shared. The ifdef condition of CONFIG_ARCH_TASK_STRUCT_ON_STACK is opposite. Now that the init thread stack is constructed by the linker script, this is not a practical problem, but let's fix the code

Re: [PATCH v3 20/21] dyndbg: add user-flag, negating-flags, and filtering on flags

2020-06-18 Thread Petr Mladek
On Wed 2020-06-17 10:25:35, Jim Cromie wrote: > 1. Add a user-flag [u] which works like the [pfmlt] flags, but has no > effect on callsite behavior; it allows incremental marking of > arbitrary sets of callsites. > > 2. Add [PFMLTU] flags, which negate their counterparts; P===!p etc. > And in

Re: [PATCH] sparse: use identifiers to define address spaces

2020-06-18 Thread kernel test robot
Hi Luc, I love your patch! Perhaps something to improve: [auto build test WARNING on linux/master] [also build test WARNING on linus/master v5.8-rc1 next-20200618] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use as documented

[PATCH v2] ARM: dts: imx6qdl-gw: add Gateworks System Controller support

2020-06-18 Thread Tim Harvey
Add Gateworks System Controller support to Gateworks Ventana boards: - add dt bindings for GSC mfd driver and hwmon driver for ADC's and fan controllers. - add dt bindings for gpio-keys driver for push-button and interrupt events Signed-off-by: Tim Harvey --- v2: - use keycode bindings from

[PATCH 2/2] init: annotate init_task as __init_task_data for all arches

2020-06-18 Thread Masahiro Yamada
__init_task_data is no-op when CONFIG_ARCH_TASK_STRUCT_ON_STACK=n, so you can always annotate init_task as __init_task_data. Signed-off-by: Masahiro Yamada --- init/init_task.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/init/init_task.c b/init/init_task.c index

Re: [PATCH net] net: dsa: bcm_sf2: Fix node reference count

2020-06-18 Thread Florian Fainelli
On 6/18/2020 5:56 AM, Andrew Lunn wrote: > On Wed, Jun 17, 2020 at 08:42:44PM -0700, Florian Fainelli wrote: >> of_find_node_by_name() will do an of_node_put() on the "from" argument. > >> Fixes: afa3b592953b ("net: dsa: bcm_sf2: Ensure correct sub-node is parsed") >> Signed-off-by: Florian

Re: [PATCH v5 7/9] media: adv748x: only activate DAI if it is described in device tree

2020-06-18 Thread Kieran Bingham
Hi Alex, On 02/04/2020 19:34, Alex Riesen wrote: > To avoid setting it up even if the hardware is not actually connected > to anything physically. > > Besides, the bindings explicitly notes that port definitions are > "optional if they are not connected to anything at the hardware level". > >

Re: [PATCH v6 6/7] clk: mediatek: add UART0 clock support

2020-06-18 Thread Hanks Chen
On Thu, 2020-06-18 at 17:51 +0200, Matthias Brugger wrote: > > On 18/06/2020 13:33, Hanks Chen wrote: > > Add MT6779 UART0 clock support. > > > > Please a dd fixes tag: > > Fixes: 710774e04861 ("clk: mediatek: Add MT6779 clock support") Got it, I'll add it in next version. > > >

<    1   2   3   4   5   6   7   8   9   10   >