Re: [PATCH 1/2] net: ethernet: mvneta: Fix Serdes configuration for SoCs without comphy

2020-06-22 Thread Russell King - ARM Linux admin
On Tue, Jun 16, 2020 at 10:31:39AM +0200, Sascha Hauer wrote: > The MVNETA_SERDES_CFG register is only available on older SoCs like the > Armada XP. On newer SoCs like the Armada 38x the fields are moved to > comphy. This patch moves the writes to this register next to the comphy > initialization,

[PATCH] RISC-V: Use a local variable instead of smp_processor_id()

2020-06-22 Thread Atish Patra
From: Greentime Hu Store the smp_processor_id() in a local variable to save some pointer chasing. Signed-off-by: Greentime Hu Signed-off-by: Atish Patra --- arch/riscv/kernel/smpboot.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/arch/riscv/kernel/smpboot.c b/arc

[PATCH 01/17] fork: fold legacy_clone_args_valid() into _do_fork()

2020-06-22 Thread Christian Brauner
This separate helper only existed to guarantee the mutual exclusivity of CLONE_PIDFD and CLONE_PARENT_SETTID for legacy clone since CLONE_PIDFD abuses the parent_tid field to return the pidfd. But we can actually handle this uniformely thus removing the helper. For legacy clone we can detect that C

[PATCH v2 0/3] Preventing job distribution to isolated CPUs

2020-06-22 Thread Nitesh Narayan Lal
Testing === * Patch 1:

Re: [PATCH v2 00/11] KVM: Support guest MAXPHYADDR < host MAXPHYADDR

2020-06-22 Thread Andy Lutomirski
On 6/19/20 4:07 PM, Paolo Bonzini wrote: > On 19/06/20 23:52, Tom Lendacky wrote: >>> A more subtle issue is when the host MAXPHYADDR is larger than that >>> of the guest. Page faults caused by reserved bits on the guest won't >>> cause an EPT violation/NPF and hence we also check guest MAXPHYADDR

Re: kprobe: __blkdev_put probe is missed

2020-06-22 Thread Masami Hiramatsu
On Mon, 22 Jun 2020 09:01:48 -0400 Steven Rostedt wrote: > On Mon, 22 Jun 2020 08:27:53 +0800 > Ming Lei wrote: > > > Can you kprobe guys improve the implementation for covering this case? > > For example, put probe on 3) in case the above situation is recognized. > > To do so would require so

[PATCH 11/17] hexagon: switch to copy_thread_tls()

2020-06-22 Thread Christian Brauner
Use the copy_thread_tls() calling convention which passes tls through a register. This is required so we can remove the copy_thread{_tls}() split and remove the HAVE_COPY_THREAD_TLS macro. Cc: Brian Cain Cc: linux-hexa...@vger.kernel.org Signed-off-by: Christian Brauner --- arch/hexagon/Kconfig

[PATCH 12/17] microblaze: switch to copy_thread_tls()

2020-06-22 Thread Christian Brauner
Use the copy_thread_tls() calling convention which passes tls through a register. This is required so we can remove the copy_thread{_tls}() split and remove the HAVE_COPY_THREAD_TLS macro. Cc: Michal Simek Signed-off-by: Christian Brauner --- arch/microblaze/Kconfig | 1 + arch/microbl

[PATCH 02/17] sparc64: enable HAVE_COPY_THREAD_TLS

2020-06-22 Thread Christian Brauner
This is part of a larger series that aims at getting rid of the copy_thread()/copy_thread_tls() split that makes the process creation codepaths in the kernel more convoluted and error-prone than they need to be. It also unblocks implementing clone3() on architectures not support copy_thread_tls().

[PATCH 15/17] unicore: switch to copy_thread_tls()

2020-06-22 Thread Christian Brauner
Use the copy_thread_tls() calling convention which passes tls through a register. This is required so we can remove the copy_thread{_tls}() split and remove the HAVE_COPY_THREAD_TLS macro. Cc: Guan Xuetao Signed-off-by: Christian Brauner --- arch/unicore32/Kconfig | 1 + arch/unicore32

[Patch v2 3/3] net: Restrict receive packets queuing to housekeeping CPUs

2020-06-22 Thread Nitesh Narayan Lal
From: Alex Belits With the existing implementation of store_rps_map(), packets are queued in the receive path on the backlog queues of other CPUs irrespective of whether they are isolated or not. This could add a latency overhead to any RT workload that is running on the same CPU. Ensure that st

[PATCH 14/17] sh: switch to copy_thread_tls()

2020-06-22 Thread Christian Brauner
Use the copy_thread_tls() calling convention which passes tls through a register. This is required so we can remove the copy_thread{_tls}() split and remove the HAVE_COPY_THREAD_TLS macro. Cc: Rich Felker Cc: Yoshinori Sato Cc: linux...@vger.kernel.org Signed-off-by: Christian Brauner --- arch

[PATCH 10/17] c6x: switch to copy_thread_tls()

2020-06-22 Thread Christian Brauner
Use the copy_thread_tls() calling convention which passes tls through a register. This is required so we can remove the copy_thread{_tls}() split and remove the HAVE_COPY_THREAD_TLS macro. CC: Mark Salter Cc: Aurelien Jacquiot Cc: linux-c6x-...@linux-c6x.org Signed-off-by: Christian Brauner ---

[PATCH 05/17] ia64: enable HAVE_COPY_THREAD_TLS, switch to kernel_clone_args

2020-06-22 Thread Christian Brauner
This is part of a larger series that aims at getting rid of the copy_thread()/copy_thread_tls() split that makes the process creation codepaths in the kernel more convoluted and error-prone than they need to be. I'm converting all the remaining arches that haven't yet switched and am collecting ind

[PATCH 03/17] sparc: share process creation helpers between sparc and sparc64

2020-06-22 Thread Christian Brauner
As promised in the previous patch, this moves the process creation helpers into a common process.c file that is shared between sparc and sparc64. It allows us to get rid of quite a bit custom assembler and the to remove the separe 32bit specific sparc_do_fork() call. One thing to note, is that whe

[PATCH 09/17] alpha: switch to copy_thread_tls()

2020-06-22 Thread Christian Brauner
Use the copy_thread_tls() calling convention which passes tls through a register. This is required so we can remove the copy_thread{_tls}() split and remove the HAVE_COPY_THREAD_TLS macro. Cc: linux-al...@vger.kernel.org Signed-off-by: Christian Brauner --- arch/alpha/Kconfig | 1 + arc

[PATCH 06/17] nios2: enable HAVE_COPY_THREAD_TLS, switch to kernel_clone_args

2020-06-22 Thread Christian Brauner
This is part of a larger series that aims at getting rid of the copy_thread()/copy_thread_tls() split that makes the process creation codepaths in the kernel more convoluted and error-prone than they need to be. I'm converting all the remaining arches that haven't yet switched and am collecting ind

[PATCH 08/17] fork: remove do_fork()

2020-06-22 Thread Christian Brauner
Now that all architectures have been switched to use _do_fork() and the new struct kernel_clone_args calling convention we can remove the legacy do_fork() helper completely. The calling convention used to be brittle and do_fork() didn't buy us anything. The only calling convention accepted should b

[PATCH 07/17] h8300: select HAVE_COPY_THREAD_TLS, switch to kernel_clone_args

2020-06-22 Thread Christian Brauner
This is part of a larger series that aims at getting rid of the copy_thread()/copy_thread_tls() split that makes the process creation codepaths in the kernel more convoluted and error-prone than they need to be. I'm converting all the remaining arches that haven't yet switched and am collecting ind

[PATCH 13/17] nds32: switch to copy_thread_tls()

2020-06-22 Thread Christian Brauner
Use the copy_thread_tls() calling convention which passes tls through a register. This is required so we can remove the copy_thread{_tls}() split and remove the HAVE_COPY_THREAD_TLS macro. Cc: Greentime Hu Cc: Nick Hu Cc: Vincent Chen Signed-off-by: Christian Brauner --- arch/nds32/Kconfig

[PATCH 04/17] sparc: unconditionally enable HAVE_COPY_THREAD_TLS

2020-06-22 Thread Christian Brauner
Now that both sparc and sparc64 support copy_thread_tls() and don't rely on do_fork() anymore, turn on HAVE_COPY_THREAD_TLS unconditionally. Once all architectures are switched over this macro will be removed and the old do_fork() calling convention fully abandoned in favor of the cleaner struct ke

[Patch v2 1/3] lib: Restrict cpumask_local_spread to houskeeping CPUs

2020-06-22 Thread Nitesh Narayan Lal
From: Alex Belits The current implementation of cpumask_local_spread() does not respect the isolated CPUs, i.e., even if a CPU has been isolated for Real-Time task, it will return it to the caller for pinning of its IRQ threads. Having these unwanted IRQ threads on an isolated CPU adds up to a la

[Patch v2 2/3] PCI: Restrict probe functions to housekeeping CPUs

2020-06-22 Thread Nitesh Narayan Lal
From: Alex Belits pci_call_probe() prevents the nesting of work_on_cpu() for a scenario where a VF device is probed from work_on_cpu() of the PF. Replace the cpumask used in pci_call_probe() from all online CPUs to only housekeeping CPUs. This is to ensure that there are no additional latency ov

[PATCH 00/17] arch: remove do_fork() and HAVE_COPY_THREAD_TLS

2020-06-22 Thread Christian Brauner
Hey, This is a series I had announced some time back (cf. [2]) when we reworked a chunk of the process creation paths in the kernel and switched to struct {kernel_}clone_args. I've been sitting on this for a while due to lack of time and because testing on all architectures that are non-trivially

[RESEND PATCH 2/3] nouveau: fix mixed normal and device private page migration

2020-06-22 Thread Ralph Campbell
The OpenCL function clEnqueueSVMMigrateMem(), without any flags, will migrate memory in the given address range to device private memory. The source pages might already have been migrated to device private memory. In that case, the source struct page is not checked to see if it is a device private

[RESEND PATCH 1/3] nouveau: fix migrate page regression

2020-06-22 Thread Ralph Campbell
The patch to add zero page migration to GPU memory inadvertantly included part of a future change which broke normal page migration to GPU memory by copying too much data and corrupting GPU memory. Fix this by only copying one page instead of a byte count. Fixes: 9d4296a7d4b3 ("drm/nouveau/nouveau

[RESEND PATCH 3/3] nouveau: make nvkm_vmm_ctor() and nvkm_mmu_ptp_get() static

2020-06-22 Thread Ralph Campbell
The functions nvkm_vmm_ctor() and nvkm_mmu_ptp_get() are not called outside of the file defining them so make them static. Signed-off-by: Ralph Campbell --- drivers/gpu/drm/nouveau/nvkm/subdev/mmu/base.c | 2 +- drivers/gpu/drm/nouveau/nvkm/subdev/mmu/vmm.c | 2 +- drivers/gpu/drm/nouveau/nvkm/

[RESEND PATCH 0/3] nouveau: fixes for SVM

2020-06-22 Thread Ralph Campbell
These are based on 5.8.0-rc2 and intended for Ben Skeggs' nouveau tree. I believe the changes can be queued for 5.8-rcX after being reviewed. These were part of a larger series but I'm resending them separately as suggested by Jason Gunthorpe. https://lore.kernel.org/linux-mm/20200619215649.32297-1

Hello Dear

2020-06-22 Thread Lisa Tofan
Hello Dear, This is Miss Lisa Tofan, How are you today hope all is well with you, please I will need your urgent attention regarding this important discussion kindly contact me back here my Email: lisatofan...@gmail.com: for more details, Thanks, Miss Lisa Tofan

Re: [PATCH] usbnet: smsc95xx: Fix use-after-free after removal

2020-06-22 Thread David Miller
From: Tuomas Tynkkynen Date: Sun, 21 Jun 2020 13:43:26 +0300 > Syzbot reports an use-after-free in workqueue context: > > BUG: KASAN: use-after-free in mutex_unlock+0x19/0x40 > kernel/locking/mutex.c:737 > mutex_unlock+0x19/0x40 kernel/locking/mutex.c:737 > __smsc95xx_mdio_read drivers/net/us

Re: [PATCH v2 net 0/3] net: ethtool: netdev_features_strings[] cleanup

2020-06-22 Thread David Miller
From: Alexander Lobakin Date: Sun, 21 Jun 2020 09:55:50 + > This little series adds the last forgotten feature string for > NETIF_F_GSO_TUNNEL_REMCSUM and attempts to prevent such losses > in future. > > Patches 2-3 seem more like net-next candidates rather than net-fixes, > but for me it se

Re: [PATCH v2 1/3] vmlinux.lds.h: Add .gnu.version* to DISCARDS

2020-06-22 Thread Kees Cook
On Mon, Jun 22, 2020 at 04:04:40PM -0700, Fāng-ruì Sòng wrote: > On Mon, Jun 22, 2020 at 3:57 PM Kees Cook wrote: > > > > On Mon, Jun 22, 2020 at 03:52:37PM -0700, Fangrui Song wrote: > > > > And it's not in the output: > > > > > > > > $ readelf -Vs arch/x86/boot/compressed/vmlinux | grep version

[PATCH] crypto, x86: aesni: add compatibility with IAS

2020-06-22 Thread Jian Cai
Clang's integrated assembler complains "invalid reassignment of non-absolute variable 'var_ddq_add'" while assembling arch/x86/crypto/aes_ctrby8_avx-x86_64.S. It was because var_ddq_add was reassigned with non-absolute values several times, which IAS did not support. We can avoid the reassignment b

[PATCH][next] libperf: Use struct_size() helper

2020-06-22 Thread Gustavo A. R. Silva
Make use of the struct_size() helper instead of an open-coded version in order to avoid any potential type mistakes. Also, remove unnecessary variable _size_. This code was detected with the help of Coccinelle and, audited and fixed manually. Signed-off-by: Gustavo A. R. Silva --- tools/lib/per

Re: [PATCH 09/16] mm/hmm: add output flag for compound page mapping

2020-06-22 Thread Ralph Campbell
On 6/22/20 4:18 PM, Jason Gunthorpe wrote: On Mon, Jun 22, 2020 at 11:10:05AM -0700, Ralph Campbell wrote: On 6/22/20 10:25 AM, Jason Gunthorpe wrote: On Fri, Jun 19, 2020 at 02:56:42PM -0700, Ralph Campbell wrote: hmm_range_fault() returns an array of page frame numbers and flags for how t

Re: [PATCH 0/2] prepare dwmac-meson8b for G12A specific initialization

2020-06-22 Thread David Miller
From: Martin Blumenstingl Date: Sat, 20 Jun 2020 21:26:39 +0200 > Some users are reporting that RGMII (and sometimes also RMII) Ethernet > is not working for them on G12A/G12B/SM1 boards. Upon closer inspection > of the vendor code for these SoCs new register bits are found. > > It's not clear y

Re: [PATCH] rcu/tree: Remove CONFIG_PREMPT_RCU check in force_qs_rnp

2020-06-22 Thread Paul E. McKenney
On Mon, Jun 22, 2020 at 11:37:03PM +0530, Neeraj Upadhyay wrote: > Remove CONFIG_PREMPT_RCU check in force_qs_rnp(). Originally, > this check was required to skip executing fqs failsafe > for rcu-sched, which was added in commit a77da14ce9af ("rcu: > Yet another fix for preemption and CPU hotplug")

Re: [PATCH 09/16] mm/hmm: add output flag for compound page mapping

2020-06-22 Thread Jason Gunthorpe
On Mon, Jun 22, 2020 at 11:10:05AM -0700, Ralph Campbell wrote: > > On 6/22/20 10:25 AM, Jason Gunthorpe wrote: > > On Fri, Jun 19, 2020 at 02:56:42PM -0700, Ralph Campbell wrote: > > > hmm_range_fault() returns an array of page frame numbers and flags for > > > how the pages are mapped in the req

Re: [PATCH] vmlinux.lds: consider .text.{hot|unlikely}.* part of .text too

2020-06-22 Thread Fāng-ruì Sòng
On 2020-06-22, Nick Desaulniers wrote: On Wed, Jun 17, 2020 at 2:27 PM Fāng-ruì Sòng wrote: On 2020-06-17, Nick Desaulniers wrote: >ld.bfd's internal linker script considers .text.hot AND .text.hot.* to >be part of .text, as well as .text.unlikely and .text.unlikely.*. >ld.lld will produce .

[PATCH] ima: extend boot_aggregate with kernel measurements

2020-06-22 Thread Maurizio Drocco
IMA is not considering TPM registers 8-9 when calculating the boot aggregate. When registers 8-9 are used to store measurements of the kernel and its command line (e.g., grub2 bootloader with tpm module enabled), IMA should include them in the boot aggregate. Registers 8-9 are only included in non-

Re: [PATCH net v3] net: phy: smsc: fix printing too many logs

2020-06-22 Thread David Miller
From: Dejin Zheng Date: Sat, 20 Jun 2020 22:55:34 +0800 > Commit 7ae7ad2f11ef47 ("net: phy: smsc: use phy_read_poll_timeout() > to simplify the code") will print a lot of logs as follows when Ethernet > cable is not connected: > > [4.473105] SMSC LAN8710/LAN8720 2188000.ethernet-1:00: > lan

Re: [Resend PATCH net] bridge: uapi: mrp: Fix MRP_PORT_ROLE

2020-06-22 Thread David Miller
From: Horatiu Vultur Date: Sat, 20 Jun 2020 15:14:03 +0200 > Currently the MRP_PORT_ROLE_NONE has the value 0x2 but this is in conflict > with the IEC 62439-2 standard. The standard defines the following port > roles: primary (0x0), secondary(0x1), interconnect(0x2). > Therefore remove the port r

Re: [PATCH v4 3/5] stack: Optionally randomize kernel stack offset each syscall

2020-06-22 Thread Kees Cook
On Mon, Jun 22, 2020 at 06:56:15PM -0400, Arvind Sankar wrote: > On Mon, Jun 22, 2020 at 12:31:44PM -0700, Kees Cook wrote: > > + > > +#define add_random_kstack_offset() do { > > \ > > + if (static_branch_maybe(CONFIG_RANDOMIZE_KSTACK_OFFSET_DEFAULT, \ > > +

Re: [PATCH] vmlinux.lds: consider .text.{hot|unlikely}.* part of .text too

2020-06-22 Thread Nick Desaulniers
On Wed, Jun 17, 2020 at 2:27 PM Fāng-ruì Sòng wrote: > > > On 2020-06-17, Nick Desaulniers wrote: > >ld.bfd's internal linker script considers .text.hot AND .text.hot.* to > >be part of .text, as well as .text.unlikely and .text.unlikely.*. > > >ld.lld will produce .text.hot.*/.text.unlikely.* sec

Re: [PATCH v2 1/3] vmlinux.lds.h: Add .gnu.version* to DISCARDS

2020-06-22 Thread Fāng-ruì Sòng
On Mon, Jun 22, 2020 at 3:57 PM Kees Cook wrote: > > On Mon, Jun 22, 2020 at 03:52:37PM -0700, Fangrui Song wrote: > > > And it's not in the output: > > > > > > $ readelf -Vs arch/x86/boot/compressed/vmlinux | grep version > > > No version information found in this file. > > > > > > So... for the

[PATCH][next] net: ipv6: Use struct_size() helper and kcalloc()

2020-06-22 Thread Gustavo A. R. Silva
Make use of the struct_size() helper instead of an open-coded version in order to avoid any potential type mistakes. Also, remove unnecessary function ipv6_rpl_srh_alloc_size() and replace kzalloc() with kcalloc(), which has a 2-factor argument form for multiplication. This code was detected with

Re: [PATCH 13/16] mm: support THP migration to device private memory

2020-06-22 Thread John Hubbard
On 2020-06-22 15:33, Yang Shi wrote: On Mon, Jun 22, 2020 at 3:30 PM Yang Shi wrote: On Mon, Jun 22, 2020 at 2:53 PM Zi Yan wrote: On 22 Jun 2020, at 17:31, Ralph Campbell wrote: On 6/22/20 1:10 PM, Zi Yan wrote: On 22 Jun 2020, at 15:36, Ralph Campbell wrote: On 6/21/20 4:20 PM, Zi Yan wr

Re: [PATCH 3/4] pci: acs: Enable PCI_ACS_TB for untrusted/external-facing devices

2020-06-22 Thread Rajat Jain
Hi Ashok, On Fri, Jun 19, 2020 at 9:10 AM Raj, Ashok wrote: > > Hi Rajat > > > On Mon, Jun 15, 2020 at 06:17:41PM -0700, Rajat Jain wrote: > > When enabling ACS, currently the bit "translation blocking" was > > not getting changed at all. Set it to disable translation blocking > > Maybe you meant

Re: [PATCH v2 3/3] x86/boot: Warn on orphan section placement

2020-06-22 Thread Kees Cook
On Mon, Jun 22, 2020 at 03:49:28PM -0700, Fangrui Song wrote: > On 2020-06-22, Kees Cook wrote: > > On Mon, Jun 22, 2020 at 03:06:28PM -0700, Fangrui Song wrote: > > > LLD may report warnings for 3 synthetic sections if they are orphans: > > > > > > ld.lld: warning: :(.symtab) is being placed in '

[PATCH 2/2] HID: wiimote: Don't use device IDs for Wii Balance Boards.

2020-06-22 Thread David Korth
Wii Balance Boards only have a single LED, so the player number can't be displayed on the board itself. Don't bother allocating a device ID in this case. Note that on the actual Wii system, only one board can usually be connected at a time, and it's listed as Player 4 on the HOME Menu. Signed-off

[PATCH 1/2] HID: wiimote: Initialize the controller LEDs with a device ID value

2020-06-22 Thread David Korth
Based on a similar commit for Sony Sixaxis and DualShock 4 controllers: HID: sony: Initialize the controller LEDs with a device ID value Wii remotes have the same player LED layout as Sixaxis controllers, so the wiimote setup is based on the Sixaxis code. Signed-off-by: David Korth --- drivers/

Re: [PATCH v2 1/3] vmlinux.lds.h: Add .gnu.version* to DISCARDS

2020-06-22 Thread Kees Cook
On Mon, Jun 22, 2020 at 03:52:37PM -0700, Fangrui Song wrote: > > And it's not in the output: > > > > $ readelf -Vs arch/x86/boot/compressed/vmlinux | grep version > > No version information found in this file. > > > > So... for the kernel we need to silence it right now. > > Re-link with -M (or

Re: [PATCH v4 3/5] stack: Optionally randomize kernel stack offset each syscall

2020-06-22 Thread Arvind Sankar
On Mon, Jun 22, 2020 at 12:31:44PM -0700, Kees Cook wrote: > + > +#define add_random_kstack_offset() do { > \ > + if (static_branch_maybe(CONFIG_RANDOMIZE_KSTACK_OFFSET_DEFAULT, \ > + &randomize_kstack_offset)) {\ > +

Re: [PATCH net-next v5 0/3] net: dsa: qca8k: Improve SGMII interface handling

2020-06-22 Thread David Miller
From: Jonathan McDowell Date: Sat, 20 Jun 2020 11:30:03 +0100 > This 3 patch series migrates the qca8k switch driver over to PHYLINK, > and then adds the SGMII clean-ups (i.e. the missing initialisation) on > top of that as a second patch. The final patch is a simple spelling fix > in a comment.

Re: [PATCH] rcu/tree: Force quiescent state on callback overload

2020-06-22 Thread Paul E. McKenney
On Mon, Jun 22, 2020 at 09:16:24AM +0530, Neeraj Upadhyay wrote: > Hi Paul, > > On 6/22/2020 8:43 AM, Paul E. McKenney wrote: > > On Mon, Jun 22, 2020 at 01:30:31AM +0530, Neeraj Upadhyay wrote: > > > Hi Paul, > > > > > > On 6/22/2020 1:20 AM, Paul E. McKenney wrote: > > > > On Mon, Jun 22, 2020

Re: [PATCH v2 1/3] vmlinux.lds.h: Add .gnu.version* to DISCARDS

2020-06-22 Thread Fangrui Song
On 2020-06-22, Kees Cook wrote: On Mon, Jun 22, 2020 at 03:00:43PM -0700, Fangrui Song wrote: On 2020-06-22, Kees Cook wrote: > For vmlinux linking, no architecture uses the .gnu.version* section, > so remove it via the common DISCARDS macro in preparation for adding > --orphan-handling=warn mor

Re: [PATCH v2 3/3] x86/boot: Warn on orphan section placement

2020-06-22 Thread Fangrui Song
On 2020-06-22, Kees Cook wrote: On Mon, Jun 22, 2020 at 03:06:28PM -0700, Fangrui Song wrote: LLD may report warnings for 3 synthetic sections if they are orphans: ld.lld: warning: :(.symtab) is being placed in '.symtab' ld.lld: warning: :(.shstrtab) is being placed in '.shstrtab' ld.lld: warni

Re: LTP: crypto: af_alg02 regression on linux-next 20200621 tag

2020-06-22 Thread Luis Chamberlain
On Tue, Jun 23, 2020 at 12:04:06AM +0530, Naresh Kamboju wrote: > LTP crypto regressions noticed on linux next 20200621. > > The common case for all tests is timeout after 15 minutes which > means tests got hung and LTP timers killed those test runs after > timeout. > The root cause of the failure

Re: [PATCH 03/11] net: devres: relax devm_register_netdev()

2020-06-22 Thread Jakub Kicinski
On Mon, 22 Jun 2020 12:00:48 +0200 Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > This devres helper registers a release callback that only unregisters > the net_device. It works perfectly fine with netdev structs that are > not managed on their own. There's no reason to check this -

Re: [PATCH] [objtoo] fix memory leak in special_get_alts

2020-06-22 Thread Josh Poimboeuf
On Sun, Jun 21, 2020 at 10:04:34PM -0400, Gaurav Singh wrote: > Free alt before returning to avoid memory leak. > > Signed-off-by: Gaurav Singh Hi Gaurav, Since objtool is a short-lived (and performance sensitive) process, we don't care about memory leaks. In fact we intentionally don't fix th

[PATCH 01/15] KVM: x86: Rename "shared_msrs" to "user_return_msrs"

2020-06-22 Thread Sean Christopherson
Rename the "shared_msrs" mechanism, which is used to defer restoring MSRs that are only consumed when running in userspace, to a more banal but less likely to be confusing "user_return_msrs". The "shared" nomenclature is confusing as it's not obvious who is sharing what, e.g. reasonable interpreta

[PATCH 10/15] KVM: VMX: Move uret MSR lookup into update_transition_efer()

2020-06-22 Thread Sean Christopherson
Move checking for the existence of MSR_EFER in the uret MSR array into update_transition_efer() so that the lookup and manipulation of the array in setup_msrs() occur back-to-back. This paves the way toward adding a helper to wrap the lookup and manipulation. To avoid unnecessary overhead, defer

[PATCH 02/15] KVM: VMX: Prepend "MAX_" to MSR array size defines

2020-06-22 Thread Sean Christopherson
Add "MAX" to the LOADSTORE and so called SHARED MSR defines to make it more clear that the define controls the array size, as opposed to the actual number of valid entries that are in the array. No functional change intended. Signed-off-by: Sean Christopherson --- arch/x86/kvm/vmx/nested.c | 2

[PATCH 08/15] KVM: VMX: Rename "__find_msr_index" to "__vmx_find_uret_msr"

2020-06-22 Thread Sean Christopherson
Rename "__find_msr_index" to scope it to VMX, associate it with guest_uret_msrs, and to avoid conflating "MSR's ECX index" with "MSR's array index". Similarly, don't use "slot" in the name so as to avoid colliding the common x86's half of "user_return_msrs" (the slot in kvm_user_return_msrs is not

[PATCH 05/15] KVM: VMX: Rename vcpu_vmx's "nmsrs" to "nr_uret_msrs"

2020-06-22 Thread Sean Christopherson
Rename vcpu_vmx.nsmrs to vcpu_vmx.nr_uret_msrs to explicitly associate it with the guest_uret_msrs array. No functional change intended. Signed-off-by: Sean Christopherson --- arch/x86/kvm/vmx/vmx.c | 6 +++--- arch/x86/kvm/vmx/vmx.h | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) dif

Re: [PATCH] sparc: piggyback: handle invalid image

2020-06-22 Thread David Miller
From: Corentin Labbe Date: Wed, 10 Jun 2020 07:55:19 + > With an old elftoaout, the generation of tftpboot.img fail with "lseek: > invalid argument". > This is due to offset being negative. > > Instead of printing this error message, let's print a better one. > > Signed-off-by: Corentin Lab

[PATCH 09/15] KVM: VMX: Check guest support for RDTSCP before processing MSR_TSC_AUX

2020-06-22 Thread Sean Christopherson
Check for RDTSCP support prior to checking if MSR_TSC_AUX is in the uret MSRs array so that the array lookup and manipulation are back-to-back. This paves the way toward adding a helper to wrap the lookup and manipulation. No functional change intended. Signed-off-by: Sean Christopherson --- ar

[PATCH 12/15] KVM: VMX: Rename "find_msr_entry" to "vmx_find_uret_msr"

2020-06-22 Thread Sean Christopherson
Rename "find_msr_entry" to scope it to VMX and to associate it with guest_uret_msrs. Drop the "entry" so that the function name pairs with the existing __vmx_find_uret_msr(), which intentionally uses a double underscore prefix instead of appending "index" or "slot" as those names are already claim

[PATCH v3 01/14] tools headers: Add kprobes.h header

2020-06-22 Thread Sasha Levin
This is now needed by liblockdep as a result of 2f43c6022d84 ("kprobes: Prohibit probing on lockdep functions"). Signed-off-by: Sasha Levin --- tools/include/linux/kprobes.h | 7 +++ 1 file changed, 7 insertions(+) create mode 100644 tools/include/linux/kprobes.h diff --git a/tools/include

[PATCH 13/15] KVM: VMX: Rename "vmx_set_guest_msr" to "vmx_set_guest_uret_msr"

2020-06-22 Thread Sean Christopherson
Add "uret" to vmx_set_guest_msr() to explicitly associate it with the guest_uret_msrs array, and to differentiate it from vmx_set_msr() as well as VMX's load/store MSRs. No functional change intended. Signed-off-by: Sean Christopherson --- arch/x86/kvm/vmx/vmx.c | 7 --- 1 file changed, 4 i

[PATCH 06/15] KVM: VMX: Rename vcpu_vmx's "save_nmsrs" to "nr_active_uret_msrs"

2020-06-22 Thread Sean Christopherson
Add "uret" into the name of "save_nmsrs" to explicitly associate it with the guest_uret_msrs array, and replace "save" with "active" (for lack of a better word) to better describe what is being tracked. While "save" is more or less accurate when viewed as a literal description of the field, e.g. i

[PATCH 11/15] KVM: VMX: Add vmx_setup_uret_msr() to handle lookup and swap

2020-06-22 Thread Sean Christopherson
Add vmx_setup_uret_msr() to wrap the lookup and manipulation of the uret MSRs array during setup_msrs(). In addition to consolidating code, this eliminates move_msr_up(), which while being a very literally description of the function, isn't exacly helpful in understanding the net effect of the cod

[PATCH v3 09/14] tools/lib/lockdep: New stacktrace API

2020-06-22 Thread Sasha Levin
The kernel switched to using kernel/stacktrace.c, and the API slightly changed. Adjust it to make stack traces work again. Signed-off-by: Sasha Levin --- tools/include/linux/stacktrace.h | 8 1 file changed, 8 insertions(+) diff --git a/tools/include/linux/stacktrace.h b/tools/include

[PATCH 04/15] KVM: VMX: Rename the "shared_msr_entry" struct to "vmx_uret_msr"

2020-06-22 Thread Sean Christopherson
Rename struct "shared_msr_entry" to "vmx_uret_msr" to align with x86's rename of "shared_msrs" to "user_return_msrs", and to call out that the struct is specific to VMX, i.e. not part of the generic "shared_msrs" framework. Abbreviate "user_return" as "uret" to keep line lengths marginally sane an

[PATCH v3 06/14] tools bitmap: add bitmap_clear definition

2020-06-22 Thread Sasha Levin
This is needed as a result of de4643a77356 ("locking/lockdep: Reuse lock chains that have been freed"). Signed-off-by: Sasha Levin --- tools/lib/bitmap.c | 20 1 file changed, 20 insertions(+) diff --git a/tools/lib/bitmap.c b/tools/lib/bitmap.c index b6bc037623fc1..873176c

[PATCH v3 02/14] tools headers: Add rcupdate.h header

2020-06-22 Thread Sasha Levin
This is now needed by liblockdep as a result of a0b0fd53e1e6 ("locking/lockdep: Free lock classes that are no longer in use"). Signed-off-by: Sasha Levin --- tools/include/linux/rcupdate.h | 12 1 file changed, 12 insertions(+) create mode 100644 tools/include/linux/rcupdate.h dif

[PATCH v3 07/14] tools/lib/lockdep: Hook up vsprintf, find_bit, hweight libraries

2020-06-22 Thread Sasha Levin
They already exist in tools/lib/, and are now required by liblockdep, so just add them to the build manifest. Signed-off-by: Sasha Levin --- tools/lib/lockdep/Build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/lib/lockdep/Build b/tools/lib/lockdep/Build index 219a9e2

[PATCH 14/15] KVM: VMX: Rename "vmx_msr_index" to "vmx_uret_msrs_list"

2020-06-22 Thread Sean Christopherson
Rename "vmx_msr_index" to "vmx_uret_msrs_list" to associate it with the uret MSRs array, and to avoid conflating "MSR's ECX index" with "MSR's index into an array". Similarly, don't use "slot" in the name as that terminology is claimed by the common x86 "user_return_msrs" mechanism. No functional

[PATCH v3 11/14] tools/lib/lockdep: switch to using lockdep_init_map_waits

2020-06-22 Thread Sasha Levin
As of de8f5e4f2dc1 ("lockdep: Introduce wait-type checks") lockdep exports lockdep_init_map_waits() instead of lockdep_init_map() for initialization. Signed-off-by: Sasha Levin --- tools/include/linux/kernel.h | 2 ++ tools/include/linux/lockdep.h | 1 + tools/li

[PATCH v3 10/14] tools/lib/lockdep: call lockdep_init_task on init

2020-06-22 Thread Sasha Levin
We now have to explicitly call lockdep_init_task() when starting up. Signed-off-by: Sasha Levin --- tools/lib/lockdep/preload.c | 4 1 file changed, 4 insertions(+) diff --git a/tools/lib/lockdep/preload.c b/tools/lib/lockdep/preload.c index 8f1adbe887b2f..578fdeda9422c 100644 --- a/tools/

Re: [PATCH v2 3/3] x86/boot: Warn on orphan section placement

2020-06-22 Thread Kees Cook
On Mon, Jun 22, 2020 at 03:06:28PM -0700, Fangrui Song wrote: > LLD may report warnings for 3 synthetic sections if they are orphans: > > ld.lld: warning: :(.symtab) is being placed in '.symtab' > ld.lld: warning: :(.shstrtab) is being placed in '.shstrtab' > ld.lld: warning: :(.strtab) is being p

Re: [PATCH][next] sparc64: viohs: Use struct_size() helper

2020-06-22 Thread David Miller
From: "Gustavo A. R. Silva" Date: Fri, 19 Jun 2020 20:14:06 -0500 > Make use of the struct_size() helper instead of an open-coded version > in order to avoid any potential type mistakes. Also, remove unnecessary > variable _len_. > > This code was detected with the help of Coccinelle and, audite

[PATCH v3 04/14] tools bitmap: add bitmap_andnot definition

2020-06-22 Thread Sasha Levin
Add definition of bitmap_andnot() and wire tools/lib/bitmap.c into liblockdep. This is needed as a result of de4643a77356 ("locking/lockdep: Reuse lock chains that have been freed"). Signed-off-by: Sasha Levin --- tools/include/linux/bitmap.h | 10 ++ tools/lib/bitmap.c | 15 +

[PATCH v3 05/14] tools/lib/lockdep: add definition required for IRQ flag tracing

2020-06-22 Thread Sasha Levin
We are going to start building with CONFIG_TRACE_IRQFLAGS defined, so let's wire up a few dummy variables in our task_struct. This isn't needed in userspace, but due to some refactoring in kernel-side lockdep it's easier to just wire it up and enable CONFIG_TRACE_IRQFLAGS. Signed-off-by: Sasha Le

[PATCH v3 00/14] Fix up liblockdep for 5.8-rc

2020-06-22 Thread Sasha Levin
Hi Peter, This series fixes up most of liblockdep to work with the current kernel tree. Change in v3: - Rebase on top of the 5.8 merge window work. Sasha Levin (14): tools headers: Add kprobes.h header tools headers: Add rcupdate.h header tools/kernel.h: extend with dummy RCU functions

[PATCH v3 12/14] tools/kernel.h: hide noinstr

2020-06-22 Thread Sasha Levin
After 65538943 ("vmlinux.lds.h: Create section for protection against instrumentation") we need to ignore "noinstr" in userspace. Signed-off-by: Sasha Levin --- tools/include/linux/kernel.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tools/include/linux/kernel.h b/tools/include/lin

[PATCH v3 08/14] tools/lib/lockdep: Enable building with CONFIG_TRACE_IRQFLAGS

2020-06-22 Thread Sasha Levin
At this point it's always enabled with CONFIG_PROVE_LOCKING, so it's easier to enable it in liblockdep as well rather than try and fix up the lockdep code. Signed-off-by: Sasha Levin --- tools/lib/lockdep/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/lib/lock

[PATCH v3 13/14] tools/lib/lockdep: explicitly declare lockdep_init_task()

2020-06-22 Thread Sasha Levin
Avoid a warning as we can't pull the decleration for lockdep's header. Signed-off-by: Sasha Levin --- tools/lib/lockdep/preload.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tools/lib/lockdep/preload.c b/tools/lib/lockdep/preload.c index 5bd58c51066c4..2928c712f87f8 100644 --- a/tools/

[PATCH v3 14/14] tools/kernel.h: hide task_struct.hardirq_chain_key

2020-06-22 Thread Sasha Levin
As a result of c86e9b987cea ("lockdep: Prepare for noinstr sections") we need to hide hardirq_chain_key from userspace to avoid a build error. Signed-off-by: Sasha Levin --- tools/include/linux/lockdep.h | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/include/linux/lockdep.h b/tools/in

[PATCH 07/15] KVM: VMX: Rename vcpu_vmx's "guest_msrs_ready" to "guest_uret_msrs_loaded"

2020-06-22 Thread Sean Christopherson
Add "uret" to "guest_msrs_ready" to explicitly associate it with the "guest_uret_msrs" array, and replace "ready" with "loaded" to more precisely reflect what it tracks, e.g. "ready" could be interpreted as meaning ready for processing (setup_msrs() has run), which is wrong. "loaded" also aligns wi

[PATCH 00/15] KVM: x86: VMX: Fix MSR namespacing

2020-06-22 Thread Sean Christopherson
This series attempts to clean up VMX's MSR namespacing, which is in unimitigated disaster (keeping things PG). There are a variety of ways VMX saves and restores guest MSRs, all with unique properties and mechanisms, but with haphazard namespacing (assuming there is any namespacing at all). Some

[PATCH v3 03/14] tools/kernel.h: extend with dummy RCU functions

2020-06-22 Thread Sasha Levin
These calls were added by 108c14858b9e ("locking/lockdep: Add support for dynamic keys") and require no special handling in userspace, so just add empty function definitions. Signed-off-by: Sasha Levin --- tools/include/linux/kernel.h | 7 +++ 1 file changed, 7 insertions(+) diff --git a/to

[PATCH 15/15] KVM: VMX: Rename vmx_uret_msr's "index" to "slot"

2020-06-22 Thread Sean Christopherson
Rename "index" to "slot" in struct vmx_uret_msr to align with the terminology used by common x86's kvm_user_return_msrs, and to avoid conflating "MSR's ECX index" with "MSR's index into an array". No functional change intended. Signed-off-by: Sean Christopherson --- arch/x86/kvm/vmx/vmx.c | 8 +

[PATCH 03/15] KVM: VMX: Rename "vmx_find_msr_index" to "vmx_find_loadstore_msr_slot"

2020-06-22 Thread Sean Christopherson
Add "loadstore" to vmx_find_msr_index() to differentiate it from the so called shared MSRs helpers (which will soon be renamed), and replace "index" with "slot" to better convey that the helper returns slot in the array, not the MSR index (the value that gets stuffed into ECX). No functional chang

Re: [PATCH net-next v9 1/5] dt-bindings: net: Add tx and rx internal delays

2020-06-22 Thread David Miller
From: Dan Murphy Date: Fri, 19 Jun 2020 11:18:09 -0500 > @@ -162,6 +162,19 @@ properties: > description: >Specifies a reference to a node representing a SFP cage. > > + > + rx-internal-delay-ps: Do you really want two empty lines between these two sections?

Re: [PATCH net-next v9 2/5] net: phy: Add a helper to return the index for of the internal delay

2020-06-22 Thread David Miller
From: Dan Murphy Date: Fri, 19 Jun 2020 11:18:10 -0500 > +s32 phy_get_internal_delay(struct phy_device *phydev, struct device *dev, > +const int *delay_values, int size, bool is_rx) > +{ > + int i; > + s32 delay; Please use reverse christmas tree ordering for loca

Re: [PATCH net-next v3 0/4] bonding: initial support for hardware crypto offload

2020-06-22 Thread David Miller
From: Jarod Wilson Date: Fri, 19 Jun 2020 10:31:51 -0400 > This is an initial functional implementation for doing pass-through of > hardware encryption from bonding device to capable slaves, in active-backup > bond setups. This was developed and tested using ixgbe-driven Intel x520 > interfaces w

Re: [PATCH v2 3/3] x86/boot: Warn on orphan section placement

2020-06-22 Thread Kees Cook
On Mon, Jun 22, 2020 at 03:06:28PM -0700, Fangrui Song wrote: > On 2020-06-22, Kees Cook wrote: > > We don't want to depend on the linker's orphan section placement > > heuristics as these can vary between linkers, and may change between > > versions. All sections need to be explicitly named in the

Re: [PATCH 13/16] mm: support THP migration to device private memory

2020-06-22 Thread Yang Shi
On Mon, Jun 22, 2020 at 3:30 PM Yang Shi wrote: > > On Mon, Jun 22, 2020 at 2:53 PM Zi Yan wrote: > > > > On 22 Jun 2020, at 17:31, Ralph Campbell wrote: > > > > > On 6/22/20 1:10 PM, Zi Yan wrote: > > >> On 22 Jun 2020, at 15:36, Ralph Campbell wrote: > > >> > > >>> On 6/21/20 4:20 PM, Zi Yan wr

Re: [PATCH 13/16] mm: support THP migration to device private memory

2020-06-22 Thread Yang Shi
On Mon, Jun 22, 2020 at 2:53 PM Zi Yan wrote: > > On 22 Jun 2020, at 17:31, Ralph Campbell wrote: > > > On 6/22/20 1:10 PM, Zi Yan wrote: > >> On 22 Jun 2020, at 15:36, Ralph Campbell wrote: > >> > >>> On 6/21/20 4:20 PM, Zi Yan wrote: > On 19 Jun 2020, at 17:56, Ralph Campbell wrote: >

<    1   2   3   4   5   6   7   8   9   10   >