Re: [PATCH 1/6] fs/minix: check return value of sb_getblk()

2020-07-07 Thread Eric Biggers
On Tue, Jul 07, 2020 at 12:26:12PM -0700, Andrew Morton wrote: > On Sat, 27 Jun 2020 23:08:40 -0700 Eric Biggers wrote: > > > From: Eric Biggers > > > > sb_getblk() can fail, so check its return value. > > > > This fixes a NULL pointer dereference. > > > > Reported-by:

[PATCH net-next] net: sfp: add error checking with sfp_irq_name

2020-07-07 Thread Chris Healy
Add error checking with sfp_irq_name before use. Signed-off-by: Chris Healy --- drivers/net/phy/sfp.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/phy/sfp.c b/drivers/net/phy/sfp.c index 7bdfcde98266..eef458ab0e5b 100644 --- a/drivers/net/phy/sfp.c +++

[PATCH] Replace HTTP links with HTTPS ones: user-mode Linux

2020-07-07 Thread Alexander A. Klimov
Rationale: Reduces attack surface on kernel devs opening the links for MITM as HTTPS traffic is much harder to manipulate. Deterministic algorithm: For each file: If not .svg: For each line: If doesn't contain `\bxmlns\b`: For each link, `\bhttp://[^# \t\r\n]*(?:\w|/)`:

[PATCH][next] Bluetooth: Use fallthrough pseudo-keyword

2020-07-07 Thread Gustavo A. R. Silva
Replace the existing /* fall through */ comments and its variants with the new pseudo-keyword macro fallthrough[1]. Also, remove unnecessary fall-through markings when it is the case. [1]

Re: [RFC PATCH v2 11/18] media: tegra-video: Add support for external sensor capture

2020-07-07 Thread Sowjanya Komatineni
On 7/7/20 12:35 PM, Hans Verkuil wrote: On 07/07/2020 21:25, Sowjanya Komatineni wrote: On 7/7/20 12:01 PM, Sowjanya Komatineni wrote: On 7/6/20 2:10 AM, Hans Verkuil wrote: +static void tegra_vi_graph_cleanup(struct tegra_vi *vi) +{ + struct tegra_vi_channel *chan; + +

Re: [PATCH] Replace HTTP links with HTTPS ones: security

2020-07-07 Thread James Morris
On Sun, 5 Jul 2020, Alexander A. Klimov wrote: > Rationale: > Reduces attack surface on kernel devs opening the links for MITM > as HTTPS traffic is much harder to manipulate. > > Deterministic algorithm: > For each file: > If not .svg: > For each line: > If doesn't contain

Re: [PATCH v4 3/3] prctl: Allow ptrace capable processes to change /proc/self/exe

2020-07-07 Thread Cyrill Gorcunov
On Tue, Jul 07, 2020 at 05:45:04PM +0200, Christian Brauner wrote: ... > > Ok, so the original patch proposal was presented in [4] in 2014. The > final version of that patch added the PR_SET_MM_MAP we know today. The > initial version presented in [4] did not require _any_ privilege. > True. I

[PATCH] regmap: add missing dependency on SoundWire

2020-07-07 Thread Pierre-Louis Bossart
CONFIG_REGMAP is not selected when no other serial bus is supported. It's largely academic since CONFIG_I2C is usually selected e.g. by DRM, but still this can break randconfig so let's be explicit. Signed-off-by: Pierre-Louis Bossart --- drivers/base/regmap/Kconfig | 2 +- 1 file changed, 1

Re: [PATCH v10 02/14] KVM: Cache as_id in kvm_memory_slot

2020-07-07 Thread Sean Christopherson
On Tue, Jul 07, 2020 at 04:15:08PM -0400, Peter Xu wrote: > On Tue, Jul 07, 2020 at 12:56:58PM -0700, Sean Christopherson wrote: > > > > It's a single line of code, and there's more than one > > > > "shouldn't" in the above. > > > > > > If you want, I can both set it and add the comment. Thanks,

Re: [PATCH v3 4/4] io_uring: add support for zone-append

2020-07-07 Thread Kanchan Joshi
On Tue, Jul 07, 2020 at 04:52:37PM +0100, Matthew Wilcox wrote: On Tue, Jul 07, 2020 at 08:41:05PM +0530, Kanchan Joshi wrote: On Mon, Jul 06, 2020 at 03:32:08PM +0100, Matthew Wilcox wrote: > On Mon, Jul 06, 2020 at 08:27:17AM -0600, Jens Axboe wrote: > > On 7/6/20 8:10 AM, Matthew Wilcox

[GIT PULL] Second batch of perf tooling fixes for v5.8

2020-07-07 Thread Arnaldo Carvalho de Melo
Hi Linus, Please consider pulling, Best regards, - Arnaldo The following changes since commit cdd3bb54332f82295ed90cd0c09c78cd0c0ee822: Merge tag 'm68knommu-for-v5.8-rc4' of git://git.kernel.org/pub/scm/linux/kernel/git/gerg/m68knommu (2020-07-02 22:56:29 -0700) are available in

Re: stop using ->read and ->write for kernel access v3

2020-07-07 Thread Linus Torvalds
On Tue, Jul 7, 2020 at 10:48 AM Christoph Hellwig wrote: > > Hi Al and Linus (and Stephen, see below), > > as part of removing set_fs entirely (for which I have a working > prototype), we need to stop calling ->read and ->write with kernel > pointers under set_fs. I'd be willing to pick up

Re: BUG: sleeping function called from invalid context in do_user_addr_fault

2020-07-07 Thread Eric Biggers
On Tue, Jul 07, 2020 at 01:16:25PM -0700, syzbot wrote: > syzbot has found a reproducer for the following crash on: > > HEAD commit:7cc2a8ea Merge tag 'block-5.8-2020-07-01' of git://git.ker.. > git tree: upstream > console output:

Re: ath9k broken [was: Linux 5.7.3]

2020-07-07 Thread Viktor Jägersküpper
Greg Kroah-Hartman wrote: > On Fri, Jun 26, 2020 at 04:40:18PM +0200, Gabriel C wrote: >> Am Fr., 26. Juni 2020 um 15:51 Uhr schrieb Gabriel C >> : >>> >>> Am Fr., 26. Juni 2020 um 15:40 Uhr schrieb Greg Kroah-Hartman >>> : On Fri, Jun 26, 2020 at 01:48:59PM +0200, Gabriel C wrote: >

Re: [PATCH v2 0/8] virt: vbox: Add support for the new VBG_IOCTL_ACQUIRE_GUEST_CAPABILITIES ioctl

2020-07-07 Thread Arnd Bergmann
On Tue, Jul 7, 2020 at 5:37 PM Hans de Goede wrote: > > Hi Arnd, > > On 6/23/20 4:23 PM, Hans de Goede wrote: > > Hi All, > > > > Here is v2 of my vboxguest driver patch-set adding support for the > > new VBG_IOCTL_ACQUIRE_GUEST_CAPABILITIES ioctl which is necessary to > > make guest resizing

Re: [PATCH v12 07/11] KVM: vmx/pmu: Unmask LBR fields in the MSR_IA32_DEBUGCTLMSR emualtion

2020-07-07 Thread Sean Christopherson
On Sat, Jun 13, 2020 at 05:42:50PM +0800, Xu, Like wrote: > On 2020/6/13 17:14, Xiaoyao Li wrote: > >On 6/13/2020 4:09 PM, Like Xu wrote: > >>When the LBR feature is reported by the vmx_get_perf_capabilities(), > >>the LBR fields in the [vmx|vcpu]_supported debugctl should be unmasked. > >> >

[PATCH 0/2] spi: spi-qcom-qspi: Avoid some per-transfer overhead

2020-07-07 Thread Douglas Anderson
Not to be confused with the similar series I posed for the _other_ Qualcomm SPI controller (spi-geni-qcom) [1], this one avoids the overhead on the Quad SPI controller. It's based atop the current Qualcomm tree including Rajendra's ("spi: spi-qcom-qspi: Use OPP API to set clk/perf state"). As

[PATCH 1/2] spi: spi-qcom-qspi: Avoid clock setting if not needed

2020-07-07 Thread Douglas Anderson
As per recent changes to the spi-qcom-qspi, now when we set the clock we'll call into the interconnect framework and also call the OPP API. Those are expensive operations. Let's avoid calling them if possible. This has a big impact on getting transfer rates back up to where they were (or maybe

[PATCH 2/2] spi: spi-qcom-qspi: Set an autosuspend delay of 250 ms

2020-07-07 Thread Douglas Anderson
In commit cff80645d6d3 ("spi: spi-qcom-qspi: Add interconnect support") the spi_geni_runtime_suspend() and spi_geni_runtime_resume() became a bit slower. Measuring on my hardware I see numbers in the hundreds of microseconds now. Let's use autosuspend to help avoid some of the overhead. Now if

Re: BUG: sleeping function called from invalid context in do_user_addr_fault

2020-07-07 Thread syzbot
syzbot has found a reproducer for the following crash on: HEAD commit:7cc2a8ea Merge tag 'block-5.8-2020-07-01' of git://git.ker.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=14ed01a310 kernel config:

[PATCH for 5.8] sched: Fix unreliable rseq cpu_id for new tasks

2020-07-07 Thread Mathieu Desnoyers
While integrating rseq into glibc and replacing glibc's sched_getcpu implementation with rseq, glibc's tests discovered an issue with incorrect __rseq_abi.cpu_id field value right after the first time a newly created process issues sched_setaffinity. For the records, it triggers after building

Re: [PATCH v2 2/2] devicetree: hwmon: shtc1: Add sensirion,shtc1.yaml

2020-07-07 Thread Rob Herring
On Sun, 05 Jul 2020 11:47:26 +0800, Chris Ruehl wrote: > Add documentation for the newly added DTS support in the shtc1 driver. > To align with the drivers logic to have high precision by default > a boolean sensirion,low_precision is used to switch to low precision. > > Signed-off-by: Chris

Re: [PATCH v10 02/14] KVM: Cache as_id in kvm_memory_slot

2020-07-07 Thread Peter Xu
On Tue, Jul 07, 2020 at 12:56:58PM -0700, Sean Christopherson wrote: > > > It's a single line of code, and there's more than one > > > "shouldn't" in the above. > > > > If you want, I can both set it and add the comment. Thanks, > > Why bother with the comment? It'd be wrong in the sense that

[RFC PATCH v2] kvm,x86: Exit to user space in case of page fault error

2020-07-07 Thread Vivek Goyal
Page fault error handling behavior in kvm seems little inconsistent when page fault reports error. If we are doing fault synchronously then we capture error (-EFAULT) returned by __gfn_to_pfn_memslot() and exit to user space and qemu reports error, "error: kvm run failed Bad address". But if we

Re: [PATCH v19 07/12] landlock: Support filesystem access-control

2020-07-07 Thread Randy Dunlap
Hi-- On 7/7/20 11:09 AM, Mickaël Salaün wrote: > --- > arch/Kconfig | 7 + > arch/um/Kconfig | 1 + > include/uapi/linux/landlock.h | 78 + > security/landlock/Kconfig | 2 +- > security/landlock/Makefile| 2 +- > security/landlock/fs.c

Re: [PATCH] usbip: Use fallthrough pseudo-keyword

2020-07-07 Thread Shuah Khan
On 7/7/20 1:52 PM, Gustavo A. R. Silva wrote: Replace the existing /* fall through */ comments and its variants with the new pseudo-keyword macro fallthrough[1]. Also, remove unnecessary fall-through markings when it is the case. [1]

[PATCH] ACPI: Use fallthrough pseudo-keyword

2020-07-07 Thread Gustavo A. R. Silva
Replace the existing /* fall through */ comments and its variants with the new pseudo-keyword macro fallthrough[1]. Also, remove unnecessary fall-through markings when it is the case. [1]

Re: [PATCH V3] mm/vmstat: Add events for THP migration without split

2020-07-07 Thread Andrew Morton
On Tue, 7 Jul 2020 05:36:55 +0530 Anshuman Khandual wrote: > Add following new vmstat events which will help in validating THP migration > without split. Statistics reported through these new VM events will help in > performance debugging. > > 1. THP_MIGRATION_SUCCESS > 2.

Re: [PATCH net-next] mvpp2: fix pointer check

2020-07-07 Thread David Miller
From: Matteo Croce Date: Tue, 7 Jul 2020 15:19:13 +0200 > From: Matteo Croce > > priv->page_pool is an array, so comparing against it will always return true. > Do a meaningful check by checking priv->page_pool[0] instead. > While at it, clear the page_pool pointers on deallocation, or when

[PATCH][next] ACPICA: Use fallthrough pseudo-keyword

2020-07-07 Thread Gustavo A. R. Silva
Replace the existing /* fall through */ comments and its variants with the new pseudo-keyword macro fallthrough[1]. Also, remove unnecessary fall-through markings when it is the case. [1]

Re: [RFC v5 03/11] mm/damon-test: Add more unit tests for 'init_regions'

2020-07-07 Thread Brendan Higgins
On Tue, Jul 7, 2020 at 7:47 AM SeongJae Park wrote: > > From: SeongJae Park > > This commit adds more test cases for the new feature, 'init_regions'. > > Signed-off-by: SeongJae Park Reviewed-by: Brendan Higgins

[PATCH] xfs: Use fallthrough pseudo-keyword

2020-07-07 Thread Gustavo A. R. Silva
Replace the existing /* fall through */ comments and its variants with the new pseudo-keyword macro fallthrough[1]. Also, remove unnecessary fall-through markings when it is the case. [1]

Re: [PATCH v2 1/2] kbuild: introduce ccflags-remove-y and asflags-remove-y

2020-07-07 Thread Brendan Higgins
On Tue, Jul 7, 2020 at 2:22 AM Masahiro Yamada wrote: > > CFLAGS_REMOVE_.o filters out flags when compiling a particular > object, but there is no convenient way to do that for every object in > a directory. > > Add ccflags-remove-y and asflags-remove-y to make it easily. > > Use ccflags-remove-y

Re: [PATCH] net: usb: qmi_wwan: add support for Quectel EG95 LTE modem

2020-07-07 Thread David Miller
From: AceLan Kao Date: Tue, 7 Jul 2020 16:14:45 +0800 > Add support for Quectel Wireless Solutions Co., Ltd. EG95 LTE modem > > T: Bus=01 Lev=01 Prnt=01 Port=02 Cnt=02 Dev#= 5 Spd=480 MxCh= 0 > D: Ver= 2.00 Cls=ef(misc ) Sub=02 Prot=01 MxPS=64 #Cfgs= 1 > P: Vendor=2c7c ProdID=0195

Re: [PATCH net-next] sun/niu: add __maybe_unused attribute to PM functions

2020-07-07 Thread David Miller
From: Vaibhav Gupta Date: Tue, 7 Jul 2020 13:11:22 +0530 > The upgraded .suspend() and .resume() throw > "defined but not used [-Wunused-function]" warning for certain > configurations. > > Mark them with "__maybe_unused" attribute. > > Compile-tested only. > > Fixes: b0db0cc2f695 ("sun/niu:

[PATCH] x86: Use fallthrough pseudo-keyword

2020-07-07 Thread Gustavo A. R. Silva
Replace the existing /* fall through */ comments and its variants with the new pseudo-keyword macro fallthrough[1]. Also, remove unnecessary fall-through markings when it is the case. [1]

Re: [PATCH v10 02/14] KVM: Cache as_id in kvm_memory_slot

2020-07-07 Thread Sean Christopherson
On Tue, Jul 07, 2020 at 03:50:09PM -0400, Peter Xu wrote: > On Mon, Jul 06, 2020 at 11:17:32PM -0700, Sean Christopherson wrote: > > On Fri, Jul 03, 2020 at 02:41:22PM -0400, Peter Xu wrote: > > > On Thu, Jul 02, 2020 at 04:08:49PM -0700, Sean Christopherson wrote: > > > > This technically needs

Re: [PATCH] net: atlantic: Add support for firmware v4

2020-07-07 Thread David Miller
From: Alexander Lobakin Date: Tue, 7 Jul 2020 11:46:57 +0300 > From: Kai-Heng Feng > Date: Tue, 7 Jul 2020 14:38:28 +0800 > >> We have a new ethernet card that is supported by the atlantic driver: >> 01:00.0 Ethernet controller [0200]: Aquantia Corp. AQC107 NBase-T/IEEE >> 802.3bz

Re: [PATCH v3] mm/hugetlb: avoid hardcoding while checking if cma is enable

2020-07-07 Thread Andrew Morton
On Tue, 7 Jul 2020 16:02:04 +1200 Barry Song wrote: > hugetlb_cma[0] can be NULL due to various reasons, for example, node0 has > no memory. so NULL hugetlb_cma[0] doesn't necessarily mean cma is not > enabled. gigantic pages might have been reserved on other nodes. I'm trying to figure out

[PATCH] usb: phy: Use fallthrough pseudo-keyword

2020-07-07 Thread Gustavo A. R. Silva
Replace the existing /* fall through */ comments and its variants with the new pseudo-keyword macro fallthrough[1]. Also, remove unnecessary fall-through markings when it is the case. [1]

Re: [RFC PATCH for 5.8 3/4] rseq: Introduce RSEQ_FLAG_RELIABLE_CPU_ID

2020-07-07 Thread Florian Weimer
* Carlos O'Donell: > It's not a great fit IMO. Just let the kernel version be the arbiter of > correctness. For manual review, sure. But checking it programmatically does not yield good results due to backports. Even those who use the stable kernel series sometimes pick up critical fixes

Re: Bug Report High CPU Usage events_power_efficient

2020-07-07 Thread Martin Zaharinov
And this is log from /sys/kernel/debug/tracing/trace # entries-in-buffer/entries-written: 32410/32410 #P:64 # # _-=> irqs-off # / _=> need-resched #| / _---=> hardirq/softirq #

Re: [PATCH v2 14/14] phy/rockchip: inno-hdmi: Support more pre-pll configuration

2020-07-07 Thread Johan Jonker
Hi, What's the status for this patch? This is just what I needed for A95X Z2 to get the vop+hdmi and monitor working. ;) Could this become applied to mainline already? The ack is already there. Thanks, Johan Jonker https://lore.kernel.org/lkml/20200620134659.4592-1-jbx6...@gmail.com/ On

[PATCH] USB: serial: Use fallthrough pseudo-keyword

2020-07-07 Thread Gustavo A. R. Silva
Replace the existing /* fall through */ comments and its variants with the new pseudo-keyword macro fallthrough[1]. Also, remove unnecessary fall-through markings when it is the case. [1]

Re: [PATCH net-next v3] net: sfp: Unique GPIO interrupt names

2020-07-07 Thread Chris Healy
On Mon, Jul 6, 2020 at 11:52 PM Andy Shevchenko wrote: > > > > On Tuesday, July 7, 2020, Chris Healy wrote: >> >> From: Chris Healy >> >> Dynamically generate a unique GPIO interrupt name, based on the >> device name and the GPIO name. For example: >> >> 103: 0 sx1503q 12 Edge

Re: [PATCH v3 2/3] Fix undefined operation fault that can hang a cpu on crash or panic

2020-07-07 Thread David P. Reed
On Tuesday, July 7, 2020 3:24pm, "Sean Christopherson" said: > On Tue, Jul 07, 2020 at 03:09:38PM -0400, David P. Reed wrote: >> >> On Tuesday, July 7, 2020 1:09am, "Sean Christopherson" >> said: >> Sean, are you the one who would get this particular fix pushed into Linus's >> tree, by the

Re: general protection fault in batadv_iv_ogm_schedule_buff (2)

2020-07-07 Thread Sven Eckelmann
On Tuesday, 7 July 2020 17:30:14 CEST syzbot wrote: > general protection fault, probably for non-canonical address > 0xdc0e: [#1] PREEMPT SMP KASAN > KASAN: null-ptr-deref in range [0x0070-0x0077] > CPU: 1 PID: 9126 Comm: kworker/u4:9 Not tainted

[PATCH] Replace HTTP links with HTTPS ones: NFS, SUNRPC, and LOCKD clients

2020-07-07 Thread Alexander A. Klimov
Rationale: Reduces attack surface on kernel devs opening the links for MITM as HTTPS traffic is much harder to manipulate. Deterministic algorithm: For each file: If not .svg: For each line: If doesn't contain `\bxmlns\b`: For each link, `\bhttp://[^# \t\r\n]*(?:\w|/)`:

[PATCH] usb: Use fallthrough pseudo-keyword

2020-07-07 Thread Gustavo A. R. Silva
Replace the existing /* fall through */ comments and its variants with the new pseudo-keyword macro fallthrough[1]. Also, remove unnecessary fall-through markings when it is the case. [1]

Re: [PATCH v10 02/14] KVM: Cache as_id in kvm_memory_slot

2020-07-07 Thread Peter Xu
On Mon, Jul 06, 2020 at 11:17:32PM -0700, Sean Christopherson wrote: > On Fri, Jul 03, 2020 at 02:41:22PM -0400, Peter Xu wrote: > > On Thu, Jul 02, 2020 at 04:08:49PM -0700, Sean Christopherson wrote: > > > On Mon, Jun 01, 2020 at 07:59:45AM -0400, Peter Xu wrote: > > > > Cache the address space

[PATCH] Replace HTTP links with HTTPS ones: kprobes

2020-07-07 Thread Alexander A. Klimov
Rationale: Reduces attack surface on kernel devs opening the links for MITM as HTTPS traffic is much harder to manipulate. Deterministic algorithm: For each file: If not .svg: For each line: If doesn't contain `\bxmlns\b`: For each link, `\bhttp://[^# \t\r\n]*(?:\w|/)`:

Re: [PATCH 1/7] PCI/portdrv: Create a platform device for the perf uncore driver

2020-07-07 Thread Bjorn Helgaas
[+cc Stephane in case he has thoughts on the perf driver claim issue] On Thu, Jul 02, 2020 at 10:05:11AM -0700, kan.li...@linux.intel.com wrote: > From: Kan Liang > > On Snow Ridge server, several performance monitoring counters are added > in the Root Port Configuration Space of CPU Complex

[PATCH] USB: OHCI: Use fallthrough pseudo-keyword

2020-07-07 Thread Gustavo A. R. Silva
Replace the existing /* fall through */ comments and its variants with the new pseudo-keyword macro fallthrough[1]. Also, remove unnecessary fall-through markings when it is the case. [1]

[PATCH] usbip: Use fallthrough pseudo-keyword

2020-07-07 Thread Gustavo A. R. Silva
Replace the existing /* fall through */ comments and its variants with the new pseudo-keyword macro fallthrough[1]. Also, remove unnecessary fall-through markings when it is the case. [1]

Re: [PATCH] MIPS: Prevent READ_IMPLIES_EXEC propagation

2020-07-07 Thread Maciej W. Rozycki
On Tue, 7 Jul 2020, Tiezhu Yang wrote: > In the MIPS architecture, we should clear the security-relevant > flag READ_IMPLIES_EXEC in the function SET_PERSONALITY2() of the > file arch/mips/include/asm/elf.h. > > Otherwise, with this flag set, PROT_READ implies PROT_EXEC for > mmap to make memory

Re: [PATCH net-next v3] net: sfp: Unique GPIO interrupt names

2020-07-07 Thread David Miller
From: Chris Healy Date: Mon, 6 Jul 2020 18:27:07 -0700 > From: Chris Healy > > Dynamically generate a unique GPIO interrupt name, based on the > device name and the GPIO name. For example: > > 103: 0 sx1503q 12 Edge sff2-los > 104: 0 sx1503q 13 Edge

[PATCH] usb: host: Use fallthrough pseudo-keyword

2020-07-07 Thread Gustavo A. R. Silva
Replace the existing /* fall through */ comments and its variants with the new pseudo-keyword macro fallthrough[1]. Also, remove unnecessary fall-through markings when it is the case. [1]

Re: Bug Report High CPU Usage events_power_efficient

2020-07-07 Thread Martin Zaharinov
the problem is hear with kernel 5.7.7 last work kernel without this problem is 5.6.7 hear is more info: cat /proc/57259/stack root@megacableamarilis:~# cat /proc/57259/stack [<0>] gc_worker+0x1be/0x380 [nf_conntrack] [<0>] process_one_work+0x1bc/0x3b0 [<0>] worker_thread+0x4d/0x460 [<0>]

Re: [PATCH net 0/3] net: ipa: fix warning-reported errors

2020-07-07 Thread David Miller
From: Alex Elder Date: Mon, 6 Jul 2020 18:10:07 -0500 > Building the kernel with W=1 produces numerous warnings for the IPA > code. Some of those warnings turn out to flag real problems, and > this series fixes them. The first patch fixes the most important > ones, but the second and third

[PATCH][next] netfilter: nf_tables: Use fallthrough pseudo-keyword

2020-07-07 Thread Gustavo A. R. Silva
Replace the existing /* fall through */ comments and its variants with the new pseudo-keyword macro fallthrough[1]. Also, remove unnecessary fall-through markings when it is the case. [1]

Re: [PATCH net-next] net: systemport: Add support for VLAN transmit acceleration

2020-07-07 Thread David Miller
From: Florian Fainelli Date: Mon, 6 Jul 2020 14:29:39 -0700 > SYSTEMPORT is capable of performing VLAN transmit acceleration, support > that by configuring it appropriately, providing the VLAN ID and PCP/DEI > where necessary. > > Signed-off-by: Florian Fainelli Applied, thanks Florian.

[PATCH] staging: vt6655: Use fallthrough pseudo-keyword

2020-07-07 Thread Gustavo A. R. Silva
Replace the existing /* fall through */ comments and its variants with the new pseudo-keyword macro fallthrough[1]. Also, remove unnecessary fall-through markings when it is the case. [1]

Re: [RFC PATCH v2 11/18] media: tegra-video: Add support for external sensor capture

2020-07-07 Thread Hans Verkuil
On 07/07/2020 21:25, Sowjanya Komatineni wrote: > > On 7/7/20 12:01 PM, Sowjanya Komatineni wrote: >> >> >> On 7/6/20 2:10 AM, Hans Verkuil wrote: +static void tegra_vi_graph_cleanup(struct tegra_vi *vi) +{ + struct tegra_vi_channel *chan; + + list_for_each_entry(chan,

Re: [PATCH 2/2] kunit: kmemleak integration

2020-07-07 Thread Qian Cai
On Tue, Jul 07, 2020 at 12:26:52PM -0500, Uriel Guajardo wrote: > On Mon, Jul 6, 2020 at 6:17 PM Qian Cai wrote: > > > > On Mon, Jul 06, 2020 at 05:48:21PM -0500, Uriel Guajardo wrote: > > > On Mon, Jul 6, 2020 at 4:39 PM Qian Cai wrote: > > > > > > > > On Mon, Jul 06, 2020 at 09:13:09PM +,

Re: [PATCH v2 2/3] xen/privcmd: Mark pages as dirty

2020-07-07 Thread John Hubbard
On 2020-07-07 04:43, Jürgen Groß wrote: On 07.07.20 13:30, Souptick Joarder wrote: On Tue, Jul 7, 2020 at 3:08 PM Jürgen Groß wrote: ... diff --git a/drivers/xen/privcmd.c b/drivers/xen/privcmd.c index 33677ea..f6c1543 100644 --- a/drivers/xen/privcmd.c +++ b/drivers/xen/privcmd.c @@ -612,8

Re: linux-next: manual merge of the seccomp tree with the kselftest tree

2020-07-07 Thread Shuah Khan
On 7/7/20 2:26 AM, Kees Cook wrote: On Tue, Jul 07, 2020 at 02:57:20PM +1000, Stephen Rothwell wrote: Hi all, Today's linux-next merge of the seccomp tree got a conflict in: tools/testing/selftests/seccomp/seccomp_bpf.c between commit: 9847d24af95c ("selftests/harness: Refactor XFAIL

Re: [PATCH 06/11] ASoC: q6asm: add support to remove intial and trailing silence

2020-07-07 Thread Pierre-Louis Bossart
+int q6asm_stream_remove_initial_silence(struct audio_client *ac, + uint32_t stream_id, + uint32_t initial_samples) +{ + return q6asm_stream_remove_silence(ac, stream_id, +

Re: [PATCH 10/11] ASoC: qdsp6-dai: add gapless support

2020-07-07 Thread Pierre-Louis Bossart
On 7/7/20 11:36 AM, Srinivas Kandagatla wrote: Add support to gapless playback by implementing metadata, next_track, drain and partial drain support. Gapless on Q6ASM is implemented by opening 2 streams in a single asm stream What does 'in a single asm stream' means? and toggling them on

Re: [PATCH 07/11] ASoC: q6asm: add support to gapless flag in asm open

2020-07-07 Thread Pierre-Louis Bossart
diff --git a/sound/soc/qcom/qdsp6/q6asm-dai.c b/sound/soc/qcom/qdsp6/q6asm-dai.c index c3558288242a..8c214436a2c2 100644 --- a/sound/soc/qcom/qdsp6/q6asm-dai.c +++ b/sound/soc/qcom/qdsp6/q6asm-dai.c @@ -258,7 +258,7 @@ static int q6asm_dai_prepare(struct snd_soc_component *component,

Re: [PATCH 03/11] ASoC: q6asm: make commands specific to streams

2020-07-07 Thread Pierre-Louis Bossart
@@ -184,8 +186,8 @@ static void event_handler(uint32_t opcode, uint32_t token, switch (opcode) { case ASM_CLIENT_EVENT_CMD_RUN_DONE: if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK) - q6asm_write_async(prtd->audio_client, -

Re: [PATCH v4 4/4] printk: use the lockless ringbuffer

2020-07-07 Thread kernel test robot
Hi John, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on linux/master] [also build test WARNING on linus/master v5.8-rc4 next-20200707] [cannot apply to pmladek/for-next] [If your patch is applied to the wrong git tree, kindly drop us a note. And when

Re: [PATCH 1/6] fs/minix: check return value of sb_getblk()

2020-07-07 Thread Andrew Morton
On Sat, 27 Jun 2020 23:08:40 -0700 Eric Biggers wrote: > From: Eric Biggers > > sb_getblk() can fail, so check its return value. > > This fixes a NULL pointer dereference. > > Reported-by: syzbot+4a88b2b9dc280f47b...@syzkaller.appspotmail.com > Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") > Cc:

Re: [PATCH v3 2/3] Fix undefined operation fault that can hang a cpu on crash or panic

2020-07-07 Thread Sean Christopherson
On Tue, Jul 07, 2020 at 03:09:38PM -0400, David P. Reed wrote: > > On Tuesday, July 7, 2020 1:09am, "Sean Christopherson" > said: > Sean, are you the one who would get this particular fix pushed into Linus's > tree, by the way? The "maintainership" is not clear to me. Nope, I'm just here to

[PATCH 1/3] ASoC: Intel: Skylake: remove comparison always false warning

2020-07-07 Thread Pierre-Louis Bossart
Fix W=1 warnings: skl-sst-dsp.c: In function ‘skl_dsp_get_enabled_cores’: include/linux/bits.h:26:28: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits] cast the core number to a long to avoid checking if an unsigned value is lower than zero. Signed-off-by:

[PATCH 2/3] ASoC: meson: axg-pdm: remove comparison always false warning

2020-07-07 Thread Pierre-Louis Bossart
Fix W=1 warning. sound/soc/meson/axg-pdm.c: In function ‘axg_pdm_set_channel_mask’: include/linux/bits.h:26:28: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits] cast the channel number to an int to avoid checking if an unsigned value is lower than zero.

[PATCH 3/3] ASoC: meson: axg-spdifin: remove comparison always false warning

2020-07-07 Thread Pierre-Louis Bossart
Fix W=1 warning: sound/soc/meson/axg-spdifin.c: In function ‘axg_spdifin_write_mode_param’: include/linux/bits.h:26:28: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits] Cast width to an int to avoid checking if an unsigned value is lower than zero. Signed-off-by:

[PATCH v3 03/10] ASoC: sunxi: sun4i-spdif: fix kernel-doc

2020-07-07 Thread Pierre-Louis Bossart
Fix W=1 warning - typo in field description Signed-off-by: Pierre-Louis Bossart --- sound/soc/sunxi/sun4i-spdif.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/sunxi/sun4i-spdif.c b/sound/soc/sunxi/sun4i-spdif.c index 86779a99df75..326dd45e39da 100644 ---

[PATCH v3 05/10] ASoC: ux500: ux500_msp_i2s: Remove unused variables 'reg_val_DR' and 'reg_val_TSTDR'

2020-07-07 Thread Pierre-Louis Bossart
From: Lee Jones Looks like these have been unchecked since the driver's inception in 2012. Fixes the following W=1 kernel build warning(s): sound/soc/ux500/ux500_msp_i2s.c: In function ‘flush_fifo_rx’: sound/soc/ux500/ux500_msp_i2s.c:398:6: warning: variable ‘reg_val_DR’ set but not used

[PATCH v3 06/10] ASoC: sti: uniperif: fix 'defined by not used' warning

2020-07-07 Thread Pierre-Louis Bossart
Fix W=1 warning. The table uni_tdm_hw is declared in a header included by multiple C file. This isn't really a good practice but for now using __maybe_unused makes the following warning go away. sound/soc/sti/sti_uniperif.c:12: sound/soc/sti/uniperif.h:1351:38: warning: ‘uni_tdm_hw’ defined but

[PATCH v3 07/10] ASoC: codecs: rt5631: fix kernel-doc

2020-07-07 Thread Pierre-Louis Bossart
Fix W=1 warning, spurious kernel-doc start and missing arguments Signed-off-by: Pierre-Louis Bossart --- sound/soc/codecs/rt5631.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/sound/soc/codecs/rt5631.c b/sound/soc/codecs/rt5631.c index b5184f0e10e3..653da3eaf355

[PATCH v3 09/10] ASoC: codecs: tlv320aic26: fix kernel-doc warning

2020-07-07 Thread Pierre-Louis Bossart
Fix W=1 warning. Remove spurious /** since there isn't any kernel-doc comment in this file. Signed-off-by: Pierre-Louis Bossart --- sound/soc/codecs/tlv320aic26.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/codecs/tlv320aic26.c b/sound/soc/codecs/tlv320aic26.c

[PATCH v3 04/10] ASoC: pxa: pxa-ssp: Demote seemingly unintentional kerneldoc header

2020-07-07 Thread Pierre-Louis Bossart
From: Lee Jones This is the only use of kerneldoc in the sourcefile and full descriptions are not provided. Fixes the following W=1 kernel build warning(s): sound/soc/pxa/pxa-ssp.c:186: warning: Function parameter or member 'ssp' not described in 'pxa_ssp_set_scr' Cc: Daniel Mack Cc:

[PATCH v3 10/10] ASoC: codecs: ak4458: Remove set but never checked variable 'ret'

2020-07-07 Thread Pierre-Louis Bossart
From: Lee Jones Looks as though the result of snd_soc_update_bits() has never been checked. Fixes the following W=1 kernel build warning(s): sound/soc/codecs/ak4458.c: In function ‘ak4458_set_dai_mute’: sound/soc/codecs/ak4458.c:408:16: warning: variable ‘ret’ set but not used

[PATCH v3 02/10] ASoC: sunxi: sun4i-i2s: fix kernel-doc

2020-07-07 Thread Pierre-Louis Bossart
Fix W=1 warnings - missing fields in description Signed-off-by: Pierre-Louis Bossart --- sound/soc/sunxi/sun4i-i2s.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/sound/soc/sunxi/sun4i-i2s.c b/sound/soc/sunxi/sun4i-i2s.c index d0a8d5810c0a..f23ff29e7c1d 100644

[PATCH v3 08/10] ASoC: codecs: rt5659: Remove many unused const variables

2020-07-07 Thread Pierre-Louis Bossart
From: Lee Jones Looks as though they've never been used. Fixes the following W=1 kernel build warning(s): In file included from sound/soc/codecs/rt5659.c:25: In file included from sound/soc/codecs/rt5659.c:25: sound/soc/codecs/rt5659.c:1232:2: warning: ‘rt5659_ad_monor_asrc_enum’ defined

[PATCH v6] xfs: Fix false positive lockdep warning with sb_internal & fs_reclaim

2020-07-07 Thread Waiman Long
Depending on the workloads, the following circular locking dependency warning between sb_internal (a percpu rwsem) and fs_reclaim (a pseudo lock) may show up: == WARNING: possible circular locking dependency detected 5.0.0-rc1+ #60 Tainted: G

[PATCH v3 01/10] ASoC: qcom: q6asm: fix kernel-doc

2020-07-07 Thread Pierre-Louis Bossart
Fix W=1 warning - missing parameter description Signed-off-by: Pierre-Louis Bossart --- sound/soc/qcom/qdsp6/q6asm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/qcom/qdsp6/q6asm.c b/sound/soc/qcom/qdsp6/q6asm.c index ae4b2cabdf2d..d67b23a5f397 100644 ---

[GIT PULL] mtd: Fixes for v5.8-rc5

2020-07-07 Thread Miquel Raynal
Hello Linus, This is the MTD PR for the next -rc. Thanks, Miquèl The following changes since commit b3a9e3b9622ae10064826dccb4f7a52bd88c7407: Linux 5.8-rc1 (2020-06-14 12:45:04 -0700) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git

Re: [PATCH v3 2/3] Fix undefined operation fault that can hang a cpu on crash or panic

2020-07-07 Thread David P. Reed
On Tuesday, July 7, 2020 1:09am, "Sean Christopherson" said: > On Sat, Jul 04, 2020 at 04:38:08PM -0400, David P. Reed wrote: >> Fix: Mask undefined operation fault during emergency VMXOFF that must be >> attempted to force cpu exit from VMX root operation. >> Explanation: When a cpu may be

[PATCH v4 0/2] Add character device interface to remoteproc

2020-07-07 Thread Siddharth Gupta
This patch series adds a character device interface to remoteproc framework. Currently there is only a sysfs interface which the userspace clients can use. If a usersapce application crashes after booting the remote processor through the sysfs interface the remote processor does not get any

[PATCH v4 1/2] remoteproc: Add remoteproc character device interface

2020-07-07 Thread Siddharth Gupta
Add the character device interface into remoteproc framework. This interface can be used in order to boot/shutdown remote subsystems and provides a basic ioctl based interface to implement supplementary functionality. An ioctl call is implemented to enable the shutdown on release feature which

[PATCH v4 2/2] remoteproc: core: Register the character device interface

2020-07-07 Thread Siddharth Gupta
Add the character device during rproc_add. This would create a character device node at /dev/remoteproc. Userspace applications can interact with the remote processor using this interface. Signed-off-by: Rishabh Bhatnagar Signed-off-by: Siddharth Gupta --- drivers/remoteproc/remoteproc_core.c

[PATCH v3 03/13] ASoC: samsung: pcm: fix kernel-doc

2020-07-07 Thread Pierre-Louis Bossart
Fix W=1 warnings - missing fields in structure Credits to Sylwester Nawrocki for the pclk and cclk descriptions. Reviewed-by: Sylwester Nawrocki Signed-off-by: Pierre-Louis Bossart --- sound/soc/samsung/pcm.c | 5 + 1 file changed, 5 insertions(+) diff --git a/sound/soc/samsung/pcm.c

[PATCH v3 11/13] ASoC: codecs: es8316: fix 'defined but not used' warning

2020-07-07 Thread Pierre-Louis Bossart
Fix W=1 warning sound/soc/codecs/es8316.c:842:36: warning: 'es8316_acpi_match' defined but not used [-Wunused-const-variable=] 842 | static const struct acpi_device_id es8316_acpi_match[] = { |^ Signed-off-by: Pierre-Louis Bossart ---

[PATCH v3 06/13] ASoC: codecs: da7210: fix kernel-doc

2020-07-07 Thread Pierre-Louis Bossart
Fix W=1 warning, the kernel-doc syntax was probably from Doxygen? Acked-by: Adam Thomson Signed-off-by: Pierre-Louis Bossart --- sound/soc/codecs/da7210.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/sound/soc/codecs/da7210.c b/sound/soc/codecs/da7210.c

[PATCH v3 13/13] ASoC: codecs: rt*: fix 'defined but not used' warning

2020-07-07 Thread Pierre-Louis Bossart
Fix W=1 warning when ACPI is not defined Signed-off-by: Pierre-Louis Bossart --- sound/soc/codecs/rt274.c | 2 ++ sound/soc/codecs/rt286.c | 2 ++ sound/soc/codecs/rt298.c | 2 ++ sound/soc/codecs/rt5660.c | 2 ++ sound/soc/codecs/rt5677-spi.c | 2 ++ 5 files changed, 10

[PATCH v3 02/13] ASoC: samsung: spdif: fix kernel-doc

2020-07-07 Thread Pierre-Louis Bossart
Fix W=1 warnings - typos with structure fields Reviewed-by: Sylwester Nawrocki Signed-off-by: Pierre-Louis Bossart --- sound/soc/samsung/spdif.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/sound/soc/samsung/spdif.c b/sound/soc/samsung/spdif.c index

[PATCH v3 01/13] ASoC: atmel: fix kernel-doc

2020-07-07 Thread Pierre-Louis Bossart
Fix W=1 warning Kernel-doc is not used in one file and missing argument in the second. Acked-by: Alexandre Belloni Signed-off-by: Pierre-Louis Bossart --- sound/soc/atmel/atmel-pcm-dma.c | 2 +- sound/soc/atmel/atmel_ssc_dai.c | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git

[PATCH v3 10/13] ASoC: codecs: cros_ec_codec: fix 'defined but not used' warning

2020-07-07 Thread Pierre-Louis Bossart
fix W=1 warning sound/soc/codecs/cros_ec_codec.c:1056:36: warning: 'cros_ec_codec_acpi_id' defined but not used [-Wunused-const-variable=] 1056 | static const struct acpi_device_id cros_ec_codec_acpi_id[] = { |^ Signed-off-by:

[PATCH v3 04/13] ASoC: tegra: tegra20_das: remove always-true comparison

2020-07-07 Thread Pierre-Louis Bossart
Fix W=1 warning: sound/soc//tegra/tegra20_das.c:101:11: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits] 101 | if ((reg >= TEGRA20_DAS_DAP_CTRL_SEL) && | ^~ Reviewed-by: Jon Hunter Signed-off-by: Pierre-Louis Bossart ---

<    1   2   3   4   5   6   7   8   9   10   >