Re: [net-next v3 3/6] net: marvell: prestera: Add basic devlink support

2020-07-26 Thread Jiri Pirko
Sat, Jul 25, 2020 at 05:06:48PM CEST, vadym.koc...@plvision.eu wrote: >Add very basic support for devlink interface: > >- driver name >- fw version >- devlink ports > >Signed-off-by: Vadym Kochan Reviewed-by: Jiri Pirko

Re: [PATCH 12/19] perf metric: Add events for the current list

2020-07-26 Thread kajoljain
On 7/20/20 4:04 AM, Ian Rogers wrote: > On Sun, Jul 19, 2020 at 11:14 AM Jiri Olsa wrote: >> >> There's no need to iterate the whole list of groups, >> when adding new events. The currently created groups >> are the ones we want to add. >> >> Signed-off-by: Jiri Olsa > > Acked-by: Ian Rogers

Re: [PATCH 11/19] perf metric: Compute referenced metrics

2020-07-26 Thread kajoljain
On 7/19/20 11:43 PM, Jiri Olsa wrote: > Adding computation (expr__parse call) of referenced metric at > the point when it needs to be resolved during the parent metric > computation. > > Once the inner metric is computed, the result is stored and > used if there's another usage of that metric.

Re: [PATCH 13/19] perf metric: Add cache_miss_cycles to metric parse test

2020-07-26 Thread kajoljain
On 7/19/20 11:43 PM, Jiri Olsa wrote: > Adding test that compute metric with other metrics in it. > > cache_miss_cycles = metric:dcache_miss_cpi + metric:icache_miss_cycles > > Acked-by: Ian Rogers > Signed-off-by: Jiri Olsa Reviewed-By : Kajol Jain Thanks, Kajol Jain > --- >

Re: [PATCH 14/19] perf metric: Add DCache_L2 to metric parse test

2020-07-26 Thread kajoljain
On 7/19/20 11:43 PM, Jiri Olsa wrote: > Adding test that compute DCache_L2 metrics with other related metrics in it. > > Acked-by: Ian Rogers > Signed-off-by: Jiri Olsa Reviewed-By : Kajol Jain Thanks, Kajol Jain > --- > tools/perf/tests/parse-metric.c | 71

Re: [PATCH 10/19] perf metric: Add referenced metrics to hash data

2020-07-26 Thread kajoljain
On 7/20/20 4:02 AM, Ian Rogers wrote: > On Sun, Jul 19, 2020 at 11:14 AM Jiri Olsa wrote: >> >> Adding referenced metrics to the parsing context so they >> can be resolved during the metric processing. >> >> Adding expr__add_ref function to store referenced metrics >> into parse context. >> >>

Re: [PATCH 07/19] perf metric: Rename __metricgroup__add_metric to __add_metric

2020-07-26 Thread kajoljain
On 7/19/20 11:43 PM, Jiri Olsa wrote: > Renaming __metricgroup__add_metric to __add_metric > to fit in the current function names. > > Acked-by: Ian Rogers > Signed-off-by: Jiri Olsa Reviewed-By : Kajol Jain Thanks, Kajol Jain > --- > tools/perf/util/metricgroup.c | 17 ++--- >

Re: [PATCH v3 1/4] staging: media: atomisp: fix style of block comments

2020-07-26 Thread Rohit K Bharadwaj
On 26/07/20 2:42 pm, Greg KH wrote: > On Sun, Jul 26, 2020 at 02:35:10PM +0530, Rohit K Bharadwaj wrote: >> this patch fixes the coding style of block comments. >> >> Signed-off-by: Rohit K Bharadwaj >> --- >> v3: change patch subject prefix >> v2: split patch into sequence of patches >> v1: fix

Re: [PATCH 08/19] perf metric: Collect referenced metrics in struct metric_ref_node

2020-07-26 Thread kajoljain
On 7/20/20 3:48 AM, Ian Rogers wrote: > On Sun, Jul 19, 2020 at 11:13 AM Jiri Olsa wrote: >> >> Collecting referenced metrics in struct metric_ref_node object, >> so we can process them later on. >> >> The change will parse nested metric names out of expression and >> 'resolve' them. >> >> All

Re: [PATCH v6 08/13] hwmon: add support for the sl28cpld hardware monitoring controller

2020-07-26 Thread Andy Shevchenko
On Sun, Jul 26, 2020 at 01:18:29AM +0200, Michael Walle wrote: > Add support for the hardware monitoring controller of the sl28cpld board > management controller. This driver is part of a multi-function device. FWIW, Reviewed-by: Andy Shevchenko > Signed-off-by: Michael Walle > Acked-by:

Re: [PATCH 06/19] perf metric: Add add_metric function

2020-07-26 Thread kajoljain
On 7/19/20 11:43 PM, Jiri Olsa wrote: > Decouple metric adding logging into add_metric function, > so it can be used from other places in following changes. > > Acked-by: Ian Rogers > Signed-off-by: Jiri Olsa > --- Reviewed-By : Kajol Jain Thanks, Kajol Jain >

Re: [PATCH 09/19] perf metric: Collect referenced metrics in struct metric_expr

2020-07-26 Thread kajoljain
On 7/19/20 11:43 PM, Jiri Olsa wrote: > Add referenced metrics into struct metric_expr object, > so they are accessible when computing the metric. > > Storing just name and expression itself, so the metric > can be resolved and computed. > > Acked-by: Ian Rogers > Signed-off-by: Jiri Olsa

Re: [PATCH 05/19] perf metric: Add macros for iterating map events

2020-07-26 Thread kajoljain
On 7/19/20 11:43 PM, Jiri Olsa wrote: > Adding following macros to iterate events and metric: > map_for_each_event(__pe, __idx, __map) > - iterates over all pmu_events_map events > map_for_each_metric(__pe, __idx, __map, __metric) > - iterates over all metrics that match __metric

Re: [PATCH 04/19] perf metric: Add expr__del_id function

2020-07-26 Thread kajoljain
On 7/19/20 11:43 PM, Jiri Olsa wrote: > Adding expr__del_id function to remove ID from hashmap. > It will save us few lines in following changes. > > Acked-by: Ian Rogers > Signed-off-by: Jiri Olsa Reviewed-By : Kajol Jain Thanks, Kajol Jain > --- > tools/perf/util/expr.c | 21

Re: [PATCH 02/19] perf metric: Add expr__add_id function

2020-07-26 Thread kajoljain
On 7/19/20 11:43 PM, Jiri Olsa wrote: > Adding expr__add_id function to data for ID > with zero value, which is used when scanning > the expression for IDs. > Reviewed-By : Kajol Jain Thanks, Kajol Jain > Acked-by: Ian Rogers > Signed-off-by: Jiri Olsa > --- > tools/perf/util/expr.c | 31

Re: [PATCH 03/19] perf metric: Change expr__get_id to return struct expr_id_data

2020-07-26 Thread kajoljain
On 7/19/20 11:43 PM, Jiri Olsa wrote: > Changing expr__get_id to use and return struct expr_id_data > pointer as value for the ID. This way we can access data other > than value for given ID in following changes. > > Acked-by: Ian Rogers > Signed-off-by: Jiri Olsa > --- Reviewed-By : Kajol

Re: [PATCH v6 07/13] gpio: add support for the sl28cpld GPIO controller

2020-07-26 Thread Andy Shevchenko
On Sun, Jul 26, 2020 at 01:18:28AM +0200, Michael Walle wrote: > Add support for the GPIO controller of the sl28 board management > controller. This driver is part of a multi-function device. > > A controller has 8 lines. There are three different flavors: > full-featured GPIO with interrupt

[PATCH v3 4/4] staging: media: atomisp: fix line length exceeds

2020-07-26 Thread Rohit K Bharadwaj
this patch fixes the line length exceeded error from checkpatch.pl Signed-off-by: Rohit K Bharadwaj --- v3: change patch subject prefix v2: split patch into sequence of patches v1: fix all coding style issues in single patch drivers/staging/media/atomisp/pci/sh_css_firmware.c | 3 ++- 1 file

Re: [PATCHv3 00/19] perf metric: Add support to reuse metric

2020-07-26 Thread kajoljain
On 7/25/20 5:21 PM, Jiri Olsa wrote: > On Fri, Jul 24, 2020 at 11:22:28AM +0530, kajoljain wrote: > > SNIP > >> >> Hi Jiri, >>The change looks good to me. I tried with adding this patch on top of >> your perf/metric branch. It did resolve the issue of not printing >> all chips data.

[PATCH v3 3/4] staging: media: atomisp: fix trailing statement of if

2020-07-26 Thread Rohit K Bharadwaj
this patch fixes the error from checkpatch.pl which says that trailing statements after if keyword to be on next line Signed-off-by: Rohit K Bharadwaj --- v3: change patch subject prefix v2: split patch into sequence of patches v1: fix all coding style issues in single patch

Re: [PATCH RFC 2/6] pwm: core: Add option to config PWM duty/period with u64 data length

2020-07-26 Thread Martin Botka
> And all divisions go mad on 32-bit CPU, right? > Please, if you thought about it carefully, update a commit message to > clarify that. Hello, This patch will be dropped in V2 since another series already made these u64. See a9d887dc1c60ed67f2271d66560cdcf864c4a578 in linux-next. I have not

Re: [PATCH v3 1/4] staging: media: atomisp: fix style of block comments

2020-07-26 Thread Greg KH
On Sun, Jul 26, 2020 at 02:35:10PM +0530, Rohit K Bharadwaj wrote: > this patch fixes the coding style of block comments. > > Signed-off-by: Rohit K Bharadwaj > --- > v3: change patch subject prefix > v2: split patch into sequence of patches > v1: fix all coding style issues in single patch >

Re: [PATCH v1 0/5] irqdomain: clean up, add irq_domain_create_legacy()

2020-07-26 Thread Andy Shevchenko
On Wed, Jul 08, 2020 at 07:21:30PM +0300, Andy Shevchenko wrote: > In order to make users OF independent provide irq_domain_create_legacy() API. > Last patch is an example of such user. First three patches are little > cleanups. > > Since regmap patch is dependent to what is now in regmap tree,

[PATCH] iomap: Ensure iop->uptodate matches PageUptodate

2020-07-26 Thread Matthew Wilcox (Oracle)
If the filesystem has block size < page size and we end up calling iomap_page_create() in iomap_page_mkwrite_actor(), the uptodate bits would be zero, which causes us to skip writeback of blocks which are !uptodate in iomap_writepage_map(). This can lead to user data loss. Found using

[PATCH v3 2/4] staging: media: atomisp: fix style of open brace

2020-07-26 Thread Rohit K Bharadwaj
this patch fixes style of open brace after functions and if statements Signed-off-by: Rohit K Bharadwaj --- v3: change patch subject prefix v2: split patch into sequence of patches v1: fix all coding style issues in single patch .../media/atomisp/pci/sh_css_firmware.c | 29

[PATCH v3 1/4] staging: media: atomisp: fix style of block comments

2020-07-26 Thread Rohit K Bharadwaj
this patch fixes the coding style of block comments. Signed-off-by: Rohit K Bharadwaj --- v3: change patch subject prefix v2: split patch into sequence of patches v1: fix all coding style issues in single patch .../media/atomisp/pci/sh_css_firmware.c | 28 +-- 1 file

Re: [PATCH] fork: fix pid refcount leaks when destroying file

2020-07-26 Thread Christian Brauner
On Sun, Jul 26, 2020 at 12:49:59PM +0800, Xin Xiong wrote: > When clone_flags & CLONE_PIDFD is true,the function creates a new file > object called pidfile,and invokes get_pid(),which increases the refcnt > of pid for pidfile to hold. > > The reference counting issues take place in the error

[PATCH] ASoC: SOF: imx: use resource_size

2020-07-26 Thread Julia Lawall
Use resource_size rather than a verbose computation on the end and start fields. The semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) @@ struct resource ptr; @@ - (ptr.end - ptr.start + 1) + resource_size() Signed-off-by: Julia Lawall ---

Re: [PATCH RFC 2/6] pwm: core: Add option to config PWM duty/period with u64 data length

2020-07-26 Thread Andy Shevchenko
On Sat, Jul 25, 2020 at 12:40 AM Martin Botka wrote: > > From: Fenglin Wu > > Currently, PWM core driver provides interfaces for configuring PWM > period and duty length in nanoseconds with an integer data type, so > the max period can be only set to ~2.147 seconds. Add interfaces which > can

Re: [PATCH 09/14] bdi: remove BDI_CAP_CGROUP_WRITEBACK

2020-07-26 Thread Wols Lists
On 22/07/20 08:45, Johannes Thumshirn wrote: > On 22/07/2020 08:27, Christoph Hellwig wrote: >> it is know to support cgroup writeback, or the bdi comes from the block > knwon ~^ > Whoops - "known" > Apart from that, > Reviewed-by: Johannes Thumshirn > Cheers, Wol

Re: [PATCH] io: Fix return type of _inb and _inl

2020-07-26 Thread Andy Shevchenko
On Sun, Jul 26, 2020 at 6:14 AM Stafford Horne wrote: > > The return type of functions _inb, _inw and _inl are all u16 which looks > wrong. This patch makes them u8, u16 and u32 respectively. > > The original commit text for these does not indicate that these should > be all forced to u16. Is

Re: [RFC 0/7] Add support to process rx packets in thread

2020-07-26 Thread Felix Fietkau
On 2020-07-26 10:32, Hillf Danton wrote: > > On Sun, 26 Jul 2020 10:10:15 +0200 Felix Fietkau wrote: >> On 2020-07-26 03:22, Hillf Danton wrote: >> > >> > Feel free to do that. Is it likely for me to select a Cc? >> > >> Shall I use Signed-off-by: Hillf Danton ? > > s/Signed-off-by/Cc/ > >>

Re: [PATCH] [video/fbdev] fb_flashcursor: Remove redundant null check

2020-07-26 Thread Andy Shevchenko
On Sun, Jul 26, 2020 at 8:17 AM Gaurav Singh wrote: > > ops cannot be NULL as its being accessed later without it's > checks. Remove the redundant NULL check. Commit message doesn't clarify why your fix is the correct one. Maybe it's the other way around, missed check in the rest of the code

Re: [PATCH v2 1/4] fix style of block comments

2020-07-26 Thread Rohit K Bharadwaj
On 26/07/20 2:18 pm, Rohit K Bharadwaj wrote: > this patch fixes the coding style of block comments. > > Signed-off-by: Rohit K Bharadwaj > --- > v2: split patch into sequence of patches > v1: fix all coding style issues in single patch > > .../media/atomisp/pci/sh_css_firmware.c | 28

Re: [PATCH] [video/fbdev] mbxfb_remove: fix null pointer dereference

2020-07-26 Thread Andy Shevchenko
On Sun, Jul 26, 2020 at 8:26 AM Gaurav Singh wrote: > > Function mbxfb_debugfs_remove() accesses fbi->par without NULL check, > hence do the NULL check in the caller mbxfb_remove(). ... > @@ -1012,11 +1012,10 @@ static int mbxfb_remove(struct platform_device *dev) > >

Re: [PATCH] tty: fix pid refcount leak in tty_signal_session_leader

2020-07-26 Thread Andy Shevchenko
On Sun, Jul 26, 2020 at 8:30 AM Xin Xiong wrote: > > In the loop, every time when p->signal->leader is true, the function > tty_signal_session_leader() will invoke get_pid() and return a > reference of tty->pgrp with increased refcount to the local variable > tty_pgrp or return NULL if it fails.

[PATCH v2 1/4] fix style of block comments

2020-07-26 Thread Rohit K Bharadwaj
this patch fixes the coding style of block comments. Signed-off-by: Rohit K Bharadwaj --- v2: split patch into sequence of patches v1: fix all coding style issues in single patch .../media/atomisp/pci/sh_css_firmware.c | 28 +-- 1 file changed, 19 insertions(+), 9

Re: [blk] 6e6fcbc27e: ltp.fs_fill.fail

2020-07-26 Thread Ming Lei
On Sun, Jul 26, 2020 at 03:55:11PM +0800, kernel test robot wrote: > Greeting, > > FYI, we noticed the following commit (built with gcc-9): > > commit: 6e6fcbc27e7788af54139c53537395d95560f2ef ("blk-mq: support batching > dispatch in case of io") >

Re: [PATCH v2 3/4] dt-bindings: usb: Add Microchip USB47xx/USB49xx support

2020-07-26 Thread Greg Kroah-Hartman
On Thu, Jul 23, 2020 at 09:29:01PM +0200, Christian Eggers wrote: > Add DT bindings for Microchip USB47xx/USB49xx driver. > > Signed-off-by: Christian Eggers > --- > > My bot found errors running 'make dt_binding_check' on your patch: > > >

Re: [RESEND PATCH] usb: common: usb-conn-gpio: Register optional charger

2020-07-26 Thread Greg Kroah-Hartman
On Sat, Jul 25, 2020 at 07:51:14PM +0200, Paul Cercueil wrote: > Hi Greg, > > Le mar. 21 juil. 2020 à 13:41, Greg Kroah-Hartman > a écrit : > > On Mon, Jun 22, 2020 at 12:48:07AM +0200, Paul Cercueil wrote: > > > Register a power supply charger, if the Kconfig option > > >

Re: [net-next v3 1/6] net: marvell: prestera: Add driver for Prestera family ASIC devices

2020-07-26 Thread Jiri Pirko
Sat, Jul 25, 2020 at 05:06:46PM CEST, vadym.koc...@plvision.eu wrote: >Marvell Prestera 98DX326x integrates up to 24 ports of 1GbE with 8 >ports of 10GbE uplinks or 2 ports of 40Gbps stacking for a largely >wireless SMB deployment. > >The current implementation supports only boards designed for

Re: [net-next v3 5/6] net: marvell: prestera: Add Switchdev driver implementation

2020-07-26 Thread Jiri Pirko
Sat, Jul 25, 2020 at 05:06:50PM CEST, vadym.koc...@plvision.eu wrote: >The following features are supported: > >- VLAN-aware bridge offloading >- VLAN-unaware bridge offloading >- FDB offloading (learning, ageing) >- Switchport configuration > >Currently there are some limitations

Re: [PATCH 0/6] mips: delete duplicated words

2020-07-26 Thread Thomas Bogendoerfer
On Sat, Jul 25, 2020 at 05:34:23PM -0700, Randy Dunlap wrote: > Delete duplicated words in arch/mips/ header files. > > Cc: Thomas Bogendoerfer > Cc: linux-m...@vger.kernel.org > > arch/mips/include/asm/io.h |2 +- > arch/mips/include/asm/octeon/cvmx-l2c.h |2 +- >

Re: [PATCH v2 1/2] MIPS: Set page access bit with pgprot on platforms with RIXI

2020-07-26 Thread Thomas Bogendoerfer
On Sat, Jun 06, 2020 at 12:02:48PM +0800, Bibo Mao wrote: > @@ -158,23 +158,23 @@ void __update_cache(unsigned long address, pte_t pte) > static inline void setup_protection_map(void) > { > if (cpu_has_rixi) { > - protection_map[0] = __pgprot(_page_cachable_default | >

Re: [PATCH] MIPS: ingenic: JZ4725B: Add IPU node

2020-07-26 Thread Thomas Bogendoerfer
On Sat, Jul 25, 2020 at 07:43:07PM +0200, Paul Cercueil wrote: > Add a devicetree node for the Image Processing Unit (IPU) found in the > JZ4725B. Connect it with graph nodes to the LCD node. The LCD driver > will expect the IPU node to be accessed through graph port #8, as stated > in the

Re: [PATCH] devices.txt: document rfkill allocation

2020-07-26 Thread Greg KH
On Sun, Jul 26, 2020 at 09:53:27AM +0200, Pavel Machek wrote: > Document rfkill allocation. > > Signed-off-by: Pavel Machek (CIP) > > diff --git a/Documentation/admin-guide/devices.txt > b/Documentation/admin-guide/devices.txt > index 2a97aaec8b12..763fedd94d7d 100644 > ---

Re: [PATCH] staging: rtl8723bs: include: Fix coding style errors

2020-07-26 Thread Greg KH
On Sun, Jul 26, 2020 at 01:32:15PM +0530, Aditya Jain wrote: > Fixing ERROR: "foo * bar" should be "foo *bar" in hal_phy_cfg.h > as reported by checkpatch.pl > > Signed-off-by: Aditya Jain > --- > .../staging/rtl8723bs/include/hal_phy_cfg.h| 18 +- > 1 file changed, 9

Re: [PATCHv8 0/6] n_gsm serdev support and GNSS driver for droid4

2020-07-26 Thread Pavel Machek
Hi! > > Here's the updated set of these patches fixed up for Johan's and > > Pavel's earlier comments. > > > > This series does the following: > > > > 1. Adds functions to n_gsm.c for serdev-ngsm.c driver to use > > > > 2. Adds a generic serdev-ngsm.c driver that brings up the TS 27.010 > >

Re: [PATCH 04/21] devtmpfs: refactor devtmpfsd()

2020-07-26 Thread Christoph Hellwig
On Sun, Jul 26, 2020 at 09:43:06AM +0200, Greg Kroah-Hartman wrote: > On Sun, Jul 26, 2020 at 09:13:39AM +0200, Christoph Hellwig wrote: > > Split the main worker loop into a separate function. This allows > > devtmpfsd itself and devtmpfsd_setup to be marked __init, which will > > allows us to

Re: [PATCH v5 5/6] kprobes: Use text_alloc() and text_free()

2020-07-26 Thread Mike Rapoport
On Sat, Jul 25, 2020 at 06:16:48AM +0300, Jarkko Sakkinen wrote: > On Fri, Jul 24, 2020 at 11:27:46AM +0200, Ingo Molnar wrote: > > > > * Jarkko Sakkinen wrote: > > > > > Use text_alloc() and text_free() instead of module_alloc() and > > > module_memfree() when an arch provides them. > > > > >

Re: [PATCH] iio: sx9310: Fixes dropped on initial commit

2020-07-26 Thread Andy Shevchenko
On Sat, Jul 25, 2020 at 3:41 AM Daniel Campello wrote: > > This patch brings back fixes on v9 of initial patch that got dropped > when v8 was taken instead. > - Updated Copyright > - Updated macro definitions > - Simplified return condition checks > - Removed ACPI and of table macros

Re: [RFC 0/7] Add support to process rx packets in thread

2020-07-26 Thread Felix Fietkau
On 2020-07-26 03:22, Hillf Danton wrote: >> - add a state bit for threaded NAPI >> - make netif_threaded_napi_add inline >> - run queue_work outside of local_irq_save/restore (it does that >> internally already) >> >> If you don't mind, I'd like to propose this to netdev soon. Can I have >> your

[PATCH 2/2] mm, util: account_locked_vm() does not hold mmap_lock

2020-07-26 Thread Pengfei Li
Since mm->locked_vm is already an atomic counter, account_locked_vm() does not need to hold mmap_lock. Signed-off-by: Pengfei Li --- drivers/vfio/vfio_iommu_type1.c | 8 ++-- mm/util.c | 15 +++ 2 files changed, 5 insertions(+), 18 deletions(-) diff --git

Re: [v3 1/2] iio: gyro: Add driver support for ADXRS290

2020-07-26 Thread Andy Shevchenko
On Fri, Jul 24, 2020 at 2:02 PM Nishant Malpani wrote: > > ADXRS290 is a high performance MEMS pitch and roll (dual-axis in-plane) > angular rate sensor (gyroscope) designed for use in stabilization > applications. It also features an internal temperature sensor and > programmable high-pass and

BUG: unable to handle kernel NULL pointer dereference in do_syscall_32_irqs_on

2020-07-26 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:23ee3e4e Merge tag 'pci-v5.8-fixes-2' of git://git.kernel... git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=14a4c7d890 kernel config: https://syzkaller.appspot.com/x/.config?x=f87a5e4232fdb267

[PATCH 1/2] mm: make mm->locked_vm an atomic64 counter

2020-07-26 Thread Pengfei Li
Like commit 70f8a3ca68d3 ("mm: make mm->pinned_vm an atomic64 counter"). By making mm->locked_vm an atomic64 counter, we can safely modify it without holding mmap_lock. The reason for using atomic64 instead of atomic_long is to keep the same as mm->pinned_vm, and there is no need to worry about

[PATCH] staging: rtl8723bs: include: Fix coding style errors

2020-07-26 Thread Aditya Jain
Fixing ERROR: "foo *bar" should be "foo *bar" in hal_phy_cfg.h as reported by checkpatch.pl Signed-off-by: Aditya Jain --- .../staging/rtl8723bs/include/hal_phy_cfg.h| 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git

Poor windows VFIO performance, GPU stalls (bisected)

2020-07-26 Thread Geoffrey McRae
Hi All, The commit 22540ca3d00d2990a4148a13b92209c3dc5422db causes a Windows KVM guest running under QEMU with a VFIO passthrough GPU to randomly stall when using the GPU leading to the guest assuming that the driver has hung. Reverting this commit resolves the problem. The host system is

[PATCH] udf: use common error code for unclean filesystem

2020-07-26 Thread Pavel Machek
Use common error code for unclean filesystem, and warn when incosistency is detected. Signed-off-by: Pavel Machek (CIP) diff --git a/fs/udf/inode.c b/fs/udf/inode.c index adaba8e8b326..8e74c7b5b8d0 100644 --- a/fs/udf/inode.c +++ b/fs/udf/inode.c @@ -1395,7 +1395,10 @@ static int

Re: [PATCH] net: ipv6: fix slab-out-of-bounds Read in __xfrm6_tunnel_spi_check

2020-07-26 Thread kernel test robot
/ipsec.git master config: x86_64-randconfig-r032-20200726 (attached as .config) compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project 8bf4c1f4fb257774f66c8cda07adc6c5e8668326) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin

[PATCH] devices.txt: document rfkill allocation

2020-07-26 Thread Pavel Machek
Document rfkill allocation. Signed-off-by: Pavel Machek (CIP) diff --git a/Documentation/admin-guide/devices.txt b/Documentation/admin-guide/devices.txt index 2a97aaec8b12..763fedd94d7d 100644 --- a/Documentation/admin-guide/devices.txt +++ b/Documentation/admin-guide/devices.txt @@ -375,8

[PATCHv2 2/2] perf tools: Fix term parsing for raw syntax

2020-07-26 Thread Jiri Olsa
Jin Yao reported issue with possible conflict between raw events and term values in pmu event syntax. Currently following syntax is resolved as raw event with 0xead value: uncore_imc_free_running/read/ instead of using 'read' term from uncore_imc_free_running pmu, because 'read' is correct raw

[PATCHv2 1/2] perf tools: Allow r0x event syntax

2020-07-26 Thread Jiri Olsa
Adding support to specify raw event with 'r0' syntax within pmu term syntax like: -e cpu/r0xdead/ It will be used to specify raw events in cases where they conflict with real pmu terms, like 'read', which is valid raw event syntax, but also a possible pmu term name as reported by Jin Yao.

Re: [PATCH 2/2] perf tools: Fix term parsing for raw syntax

2020-07-26 Thread Jiri Olsa
On Sat, Jul 25, 2020 at 09:58:13AM -0700, Ian Rogers wrote: SNIP > > ret = parse_events_terms(, t->str); > > if (ret) { > > pr_debug("failed to parse terms '%s', err %d\n", > > diff --git a/tools/perf/util/parse-events.c b/tools/perf/util/parse-events.c > > index

Re: get rid of the address_space override in setsockopt v2

2020-07-26 Thread David Miller
From: Christoph Hellwig Date: Sun, 26 Jul 2020 09:03:11 +0200 > On Fri, Jul 24, 2020 at 03:43:42PM -0700, David Miller wrote: >> > Changes since v1: >> > - check that users don't pass in kernel addresses >> > - more bpfilter cleanups >> > - cosmetic mptcp tweak >> >> Series applied to

Re: Re: Re: Re: checkpatch: support deprecated terms checking

2020-07-26 Thread SeongJae Park
On Sun, 26 Jul 2020 00:29:05 -0700 Joe Perches wrote: > On Sun, 2020-07-26 at 09:18 +0200, SeongJae Park wrote: > > On Sat, 25 Jul 2020 21:27:07 -0700 Joe Perches wrote: > > > > > On Sun, 2020-07-26 at 01:35 +0200, SeongJae Park wrote: > > > > On Sat, 25 Jul 2020 10:29:23 -0700 Joe Perches

Re: [PATCH 04/21] devtmpfs: refactor devtmpfsd()

2020-07-26 Thread Greg Kroah-Hartman
On Sun, Jul 26, 2020 at 09:13:39AM +0200, Christoph Hellwig wrote: > Split the main worker loop into a separate function. This allows > devtmpfsd itself and devtmpfsd_setup to be marked __init, which will > allows us to call __init routines for the setup work. > > Signed-off-by: Christoph

Re: [PATCH 1/2] lockdep: improve current->(hard|soft)irqs_enabled synchronisation with actual irq state

2020-07-26 Thread Alexey Kardashevskiy
On 24/07/2020 15:59, Nicholas Piggin wrote: > Excerpts from Alexey Kardashevskiy's message of July 24, 2020 2:16 pm: >> >> >> On 23/07/2020 23:11, Nicholas Piggin wrote: >>> Excerpts from Peter Zijlstra's message of July 23, 2020 9:40 pm: On Thu, Jul 23, 2020 at 08:56:14PM +1000, Nicholas

Re: [PATCH v2] net: ipv6: fix use-after-free Read in __xfrm6_tunnel_spi_lookup

2020-07-26 Thread kernel test robot
. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/B-K-Karthik/net-ipv6-fix-use-after-free-Read-in-__xfrm6_tunnel_spi_lookup/20200726-111019 base: https://git.kernel.org/pub/scm/linux

Re: Re: Re: checkpatch: support deprecated terms checking

2020-07-26 Thread Joe Perches
On Sun, 2020-07-26 at 09:18 +0200, SeongJae Park wrote: > On Sat, 25 Jul 2020 21:27:07 -0700 Joe Perches wrote: > > > On Sun, 2020-07-26 at 01:35 +0200, SeongJae Park wrote: > > > On Sat, 25 Jul 2020 10:29:23 -0700 Joe Perches wrote: > > > > > > > On Sat, 2020-07-25 at 15:02 +0200, Michał

Re: Re: Re: checkpatch: support deprecated terms checking

2020-07-26 Thread SeongJae Park
On Sat, 25 Jul 2020 21:27:07 -0700 Joe Perches wrote: > On Sun, 2020-07-26 at 01:35 +0200, SeongJae Park wrote: > > On Sat, 25 Jul 2020 10:29:23 -0700 Joe Perches wrote: > > > > > On Sat, 2020-07-25 at 15:02 +0200, Michał Mirosław wrote: > > > > Hello, > > > > > > > > I see that this patch

Re: [PATCH] Module argument to control whether intel-spi-pci attempts to turn the SPI flash chip writeable

2020-07-26 Thread Greg Kroah-Hartman
On Sat, Jul 25, 2020 at 02:20:03PM -0300, Daniel Gutson wrote: > El sáb., 25 jul. 2020 2:56 a. m., Greg Kroah-Hartman < > gre...@linuxfoundation.org> escribió: > > > On Fri, Jul 24, 2020 at 06:28:53PM -0300, Daniel Gutson wrote: > > > Currently, intel-spi has a module argument that controls

[PATCH 01/21] fs: refactor do_mount

2020-07-26 Thread Christoph Hellwig
Factor out a path_mount helper that takes a struct path * instead of the actual file name. This will allow to convert the init and devtmpfs code to properly mount based on a kernel pointer instead of relying on the implicit set_fs(KERNEL_DS) during early init. Signed-off-by: Christoph Hellwig

[PATCH 05/21] init: initialize ramdisk_execute_command at compile time

2020-07-26 Thread Christoph Hellwig
Set ramdisk_execute_command to "/init" at compile time. The command line can still override it, but this saves a few instructions and removes a NULL check. Signed-off-by: Christoph Hellwig --- init/main.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/init/main.c

[PATCH 17/21] init: add an init_symlink helper

2020-07-26 Thread Christoph Hellwig
Add a simple helper to symlink with a kernel space file name and switch the early init code over to it. Remove the now unused ksys_symlink. Signed-off-by: Christoph Hellwig --- fs/for_init.c | 16 fs/internal.h | 2 -- fs/namei.c

[PATCH 21/21] init: add an init_utimes helper

2020-07-26 Thread Christoph Hellwig
Add a simple helper to set timestamps with a kernel space file name and switch the early init code over to it. Signed-off-by: Christoph Hellwig --- fs/for_init.c | 13 + include/linux/init_syscalls.h | 1 + init/initramfs.c | 3 +-- 3 files changed, 15

[PATCH 14/21] init: add an init_chmod helper

2020-07-26 Thread Christoph Hellwig
Add a simple helper to chmod with a kernel space file name and switch the early init code over to it. Signed-off-by: Christoph Hellwig --- fs/for_init.c | 13 + fs/internal.h | 2 +- fs/open.c | 4 ++--

[PATCH 08/21] init: add an init_umount helper

2020-07-26 Thread Christoph Hellwig
Like ksys_umount, but takes a kernel pointer for the destination path. Switch over the umount in the init code, which just happen to work due to the implicit set_fs(KERNEL_DS) during early init right now. Signed-off-by: Christoph Hellwig --- fs/for_init.c | 14 ++

[PATCH 10/21] init: add an init_rmdir helper

2020-07-26 Thread Christoph Hellwig
Add a simple helper to rmdir with a kernel space file name and switch the early init code over to it. Remove the now unused ksys_rmdir. Signed-off-by: Christoph Hellwig --- fs/for_init.c | 5 + include/linux/init_syscalls.h | 1 + include/linux/syscalls.h | 7 ---

[PATCH 15/21] init: add an init_eaccess helper

2020-07-26 Thread Christoph Hellwig
Add a simple helper to check if a file exists based on kernel space file name and switch the early init code over to it. Note that this theoretically changes behavior as it always is based on the effective permissions. But during early init that doesn't make a difference. Signed-off-by:

[PATCH 02/21] fs: refactor ksys_umount

2020-07-26 Thread Christoph Hellwig
Factor out a path_umount helper that takes a struct path * instead of the actual file name. This will allow to convert the init and devtmpfs code to properly mount based on a kernel pointer instead of relying on the implicit set_fs(KERNEL_DS) during early init. Signed-off-by: Christoph Hellwig

[PATCH 13/21] init: add an init_chown helper

2020-07-26 Thread Christoph Hellwig
Add a simple helper to chown with a kernel space file name and switch the early init code over to it. Signed-off-by: Christoph Hellwig --- fs/for_init.c | 18 ++ fs/internal.h | 2 +- fs/open.c | 2 +-

[PATCH 20/21] init: add an init_stat helper

2020-07-26 Thread Christoph Hellwig
Add a simple helper to stat with a kernel space file name and switch the early init code over to it. Signed-off-by: Christoph Hellwig --- drivers/md/md-autodetect.c| 3 ++- fs/for_init.c | 15 +++ include/linux/init_syscalls.h | 1 + init/initramfs.c

[PATCH 04/21] devtmpfs: refactor devtmpfsd()

2020-07-26 Thread Christoph Hellwig
Split the main worker loop into a separate function. This allows devtmpfsd itself and devtmpfsd_setup to be marked __init, which will allows us to call __init routines for the setup work. Signed-off-by: Christoph Hellwig --- drivers/base/devtmpfs.c | 47

[PATCH 03/21] fs: push the getname from do_rmdir into the callers

2020-07-26 Thread Christoph Hellwig
This mirrors do_unlinkat and will make life a little easier for the init code to reuse the whole function with a kernel filename. Signed-off-by: Christoph Hellwig --- fs/internal.h| 2 +- fs/namei.c | 10 -- include/linux/syscalls.h | 4 ++-- 3 files changed,

[PATCH 18/21] init: add an init_mkdir helper

2020-07-26 Thread Christoph Hellwig
Add a simple helper to mkdir with a kernel space file name and switch the early init code over to it. Remove the now unused ksys_mkdir. Signed-off-by: Christoph Hellwig --- fs/for_init.c | 18 ++ fs/internal.h | 1 - fs/namei.c

[PATCH 16/21] init: add an init_link helper

2020-07-26 Thread Christoph Hellwig
Add a simple helper to link with a kernel space file name and switch the early init code over to it. Remove the now unused ksys_link. Signed-off-by: Christoph Hellwig --- fs/for_init.c | 33 + fs/internal.h | 3 +-- fs/namei.c

[PATCH 19/21] init: add an init_mknod helper

2020-07-26 Thread Christoph Hellwig
Add a simple helper to mknod with a kernel space file name and switch the early init code over to it. Remove the now unused ksys_mknod. Signed-off-by: Christoph Hellwig --- fs/for_init.c | 25 + fs/internal.h | 2 -- fs/namei.c

[PATCH 12/21] init: add an init_chroot helper

2020-07-26 Thread Christoph Hellwig
Add a simple helper to chroot with a kernel space file name and switch the early init code over to it. Remove the now unused ksys_chroot. Signed-off-by: Christoph Hellwig --- drivers/base/devtmpfs.c | 2 +- fs/for_init.c | 24 fs/open.c

[PATCH 09/21] init: add an init_unlink helper

2020-07-26 Thread Christoph Hellwig
Add a simple helper to unlink with a kernel space file name and switch the early init code over to it. Remove the now unused ksys_unlink. Signed-off-by: Christoph Hellwig --- fs/for_init.c | 5 + include/linux/init_syscalls.h | 1 + include/linux/syscalls.h | 7 ---

[PATCH 11/21] init: add an init_chdir helper

2020-07-26 Thread Christoph Hellwig
Add a simple helper to chdir with a kernel space file name and switch the early init code over to it. Remove the now unused ksys_chdir. Signed-off-by: Christoph Hellwig --- drivers/base/devtmpfs.c | 2 +- fs/for_init.c | 16 fs/open.c

[PATCH 07/21] init: add an init_mount helper

2020-07-26 Thread Christoph Hellwig
Like do_mount, but takes a kernel pointer for the destination path. Switch over the mounts in the init code and devtmpfs to it, which just happen to work due to the implicit set_fs(KERNEL_DS) during early init right now. Signed-off-by: Christoph Hellwig --- drivers/base/devtmpfs.c | 5

[PATCH 06/21] init: mark create_dev as __init

2020-07-26 Thread Christoph Hellwig
The helper is only used for the early init code. Signed-off-by: Christoph Hellwig --- init/do_mounts.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/init/do_mounts.h b/init/do_mounts.h index c855b3f0e06d19..021e2f60223e25 100644 --- a/init/do_mounts.h +++

add file system helpers that take kernel pointers for the init code v3

2020-07-26 Thread Christoph Hellwig
Hi Al and Linus, currently a lot of the file system calls in the early in code (and the devtmpfs kthread) rely on the implicit set_fs(KERNEL_DS) during boot. This is one of the few last remaining places we need to deal with to kill off set_fs entirely, so this series adds new helpers that take

Re: [PATCH v2 04/20] unify generic instances of csum_partial_copy_nocheck()

2020-07-26 Thread Christoph Hellwig
On Fri, Jul 24, 2020 at 01:30:40PM +0100, Al Viro wrote: > > Sorry, I meant csum_and_copy_from_nocheck, just as in this patch. > > > > Merging your branch into the net-next tree thus will conflict in > > the nios2 and asm-geneeric/checksum.h as well as lib/checksum.c. > > Noted, but that

Re: WARNING in ipvlan_l3s_unregister

2020-07-26 Thread syzbot
syzbot has found a reproducer for the following issue on: HEAD commit:23ee3e4e Merge tag 'pci-v5.8-fixes-2' of git://git.kernel... git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=17a1e4c490 kernel config:

Re: [PATCH v3] usb: dwc3: Add support for VBUS power control

2020-07-26 Thread Mike Looijmans
Met vriendelijke groet / kind regards, Mike Looijmans System Expert TOPIC Embedded Products B.V. Materiaalweg 4, 5681 RJ Best The Netherlands T: +31 (0) 499 33 69 69 E: mike.looijm...@topicproducts.com W: www.topicproducts.com Please consider the environment before printing this e-mail On

Re: get rid of the address_space override in setsockopt v2

2020-07-26 Thread Andreas Schwab
On Jul 26 2020, Christoph Hellwig wrote: > From 6601732f7a54db5f04efba08f7e9224e5b757112 Mon Sep 17 00:00:00 2001 > From: Christoph Hellwig > Date: Sun, 26 Jul 2020 09:00:09 +0200 > Subject: mISDN: remove a debug printk in data_sock_setsockopt > > The %p won't work with the new sockptr_t type.

Re: [PATCH] tty: fix pid refcount leak in tty_signal_session_leader

2020-07-26 Thread Greg Kroah-Hartman
On Sun, Jul 26, 2020 at 01:28:04PM +0800, Xin Xiong wrote: > In the loop, every time when p->signal->leader is true, the function > tty_signal_session_leader() will invoke get_pid() and return a > reference of tty->pgrp with increased refcount to the local variable > tty_pgrp or return NULL if it

net/ipv6/ip6mr.c:1772:21: sparse: sparse: incorrect type in argument 1 (different address spaces)

2020-07-26 Thread kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 04300d66f0a06d572d9f2ad6768c38cabde22179 commit: 670d0a4b10704667765f7d18f7592993d02783aa sparse: use identifiers to define address spaces date: 5 weeks ago config: sh-randconfig-s031-20200726 (attached

<    1   2   3   4   5   6   7   >