Re: [PATCH v3 11/19] LSM: Introduce kernel_post_load_data() hook

2020-07-28 Thread Kees Cook
On Mon, Jul 27, 2020 at 06:49:11AM -0400, Mimi Zohar wrote: > On Fri, 2020-07-24 at 14:36 -0700, Kees Cook wrote: > > There are a few places in the kernel where LSMs would like to have > > visibility into the contents of a kernel buffer that has been loaded or > > read. While

Re: [PATCH 10/15] iio: sx9310: Simplify error return handling

2020-07-28 Thread Stephen Boyd
Quoting Daniel Campello (2020-07-28 08:12:53) > @@ -368,13 +368,13 @@ static int sx9310_wait_for_sample(struct sx9310_data > *data) > static int sx9310_read_proximity(struct sx9310_data *data, > const struct iio_chan_spec *chan, int *val) > { > - int ret =

Re: [PATCH v10 4/5] locking/qspinlock: Introduce starvation avoidance into CNA

2020-07-28 Thread Waiman Long
On 4/3/20 4:59 PM, Alex Kogan wrote: Keep track of the number of intra-node lock handoffs, and force inter-node handoff once this number reaches a preset threshold. The default value for the threshold can be overridden with the new kernel boot command-line option "numa_spinlock_threshold".

Re: [RFC PATCH v5 13/14] media: tegra-video: Add CSI MIPI pads calibration

2020-07-28 Thread Sowjanya Komatineni
On 7/28/20 8:59 AM, Sowjanya Komatineni wrote: On 7/28/20 3:30 AM, Dmitry Osipenko wrote: 27.07.2020 23:57, Sowjanya Komatineni пишет: +    /* + * TRM has incorrectly documented to wait for done status from + * calibration logic after CSI interface power on. + * As per the

Re: [PATCH 08/15] iio: sx9310: Use regmap_read_poll_timeout() for compensation

2020-07-28 Thread Stephen Boyd
Quoting Daniel Campello (2020-07-28 08:12:51) > diff --git a/drivers/iio/proximity/sx9310.c b/drivers/iio/proximity/sx9310.c > index 2465064971d0a7..3956fd679c6db9 100644 > --- a/drivers/iio/proximity/sx9310.c > +++ b/drivers/iio/proximity/sx9310.c > @@ -810,22 +810,17 @@ static int

Re: [PATCH v2 8/8] x86/kaslr: Don't use 64-bit mem_vector for 32-bit kernel

2020-07-28 Thread Kees Cook
On Mon, Jul 27, 2020 at 07:08:01PM -0400, Arvind Sankar wrote: > Commit > f28442497b5c ("x86/boot: Fix KASLR and memmap= collision") > converted mem_vector type to use 64-bit on the 32-bit kernel as well, > based on Thomas's review [0]. However: > - the code still doesn't consistently use 64-bit

Re: [PATCH 07/15] iio: sx9310: Use long instead of int for channel bitmaps

2020-07-28 Thread Stephen Boyd
Quoting Daniel Campello (2020-07-28 08:12:50) > diff --git a/drivers/iio/proximity/sx9310.c b/drivers/iio/proximity/sx9310.c > index fb5c16f2aa6b1a..2465064971d0a7 100644 > --- a/drivers/iio/proximity/sx9310.c > +++ b/drivers/iio/proximity/sx9310.c > @@ -538,13 +540,13 @@ static void

Re: [PATCH v10 5/5] locking/qspinlock: Avoid moving certain threads between waiting queues in CNA

2020-07-28 Thread Waiman Long
On 4/3/20 4:59 PM, Alex Kogan wrote: Prohibit moving certain threads (e.g., in irq and nmi contexts) to the secondary queue. Those prioritized threads will always stay in the primary queue, and so will have a shorter wait time for the lock. Signed-off-by: Alex Kogan Reviewed-by: Steve Sistare

Re: [PATCH v2 7/8] x86/kaslr: Clean up slot handling

2020-07-28 Thread Kees Cook
On Mon, Jul 27, 2020 at 07:08:00PM -0400, Arvind Sankar wrote: > The number of slots and slot areas can be unsigned int, since on 64-bit, > the maximum amount of memory is 2^52, the minimum alignment is 2^21, so > the slot number cannot be greater than 2^31. The slot areas are limited > by

Re: [RESEND PATCH v5 06/11] ppc64/kexec_file: restrict memory usage of kdump kernel

2020-07-28 Thread Hari Bathini
On 28/07/20 7:14 pm, Michael Ellerman wrote: Hari Bathini writes: diff --git a/arch/powerpc/kexec/file_load_64.c b/arch/powerpc/kexec/file_load_64.c index 2df6f4273ddd..8df085a22fd7 100644 --- a/arch/powerpc/kexec/file_load_64.c +++ b/arch/powerpc/kexec/file_load_64.c @@ -17,9 +17,21 @@

Re: [PATCH 05/15] iio: sx9310: Change from .probe to .probe_new

2020-07-28 Thread Stephen Boyd
Quoting Daniel Campello (2020-07-28 08:12:48) > Uses .probe_new in place of .probe. Also uses device_get_match_data() > for whoami matching. > > Signed-off-by: Daniel Campello > --- Reviewed-by: Stephen Boyd

[Linux-kernel-mentees] [PATCH] drm/amdgpu: Prevent kernel-infoleak in amdgpu_info_ioctl()

2020-07-28 Thread Peilin Ye
Compiler leaves a 4-byte hole near the end of `dev_info`, causing amdgpu_info_ioctl() to copy uninitialized kernel stack memory to userspace when `size` is greater than 356. In 2015 we tried to fix this issue by doing `= {};` on `dev_info`, which unfortunately does not initialize that 4-byte

Re: [PATCH v2 6/8] x86/kaslr: Simplify process_gb_huge_pages

2020-07-28 Thread Kees Cook
On Mon, Jul 27, 2020 at 07:07:59PM -0400, Arvind Sankar wrote: > Short-circuit the whole function on 32-bit. > > Replace the loop to determine the number of 1Gb pages with arithmetic. > > Fix one minor bug: if the end of the region is aligned on a 1Gb > boundary, the current code will not use

Re: [PATCH v2 5/8] x86/kaslr: Simplify __process_mem_region

2020-07-28 Thread Kees Cook
On Mon, Jul 27, 2020 at 07:07:58PM -0400, Arvind Sankar wrote: > Get rid of unnecessary temporary variables and redundant tests in > __process_mem_region. > > Fix one minor bug: in case of an overlap, the beginning of the region > should be used even if it is exactly image_size, not just strictly

Re: [RESEND PATCH v5 07/11] ppc64/kexec_file: enable early kernel's OPAL calls

2020-07-28 Thread Hari Bathini
On 28/07/20 7:16 pm, Michael Ellerman wrote: Hari Bathini writes: Kernel built with CONFIG_PPC_EARLY_DEBUG_OPAL enabled expects r8 & r9 to be filled with OPAL base & entry addresses respectively. Setting these registers allows the kernel to perform OPAL calls before the device tree is

[PATCH 2/2] PCI/switechtec: Add missing __iomem tag to fix sparse warnings

2020-07-28 Thread Logan Gunthorpe
Fix a missing __iomem tag in the init_pfn() function. This fixes a sparse warning of the form: sparse: sparse: incorrect type assignment(different address spaces) Fixes: 080b47def5e5 ("MicroSemi Switchtec management interface driver") Signed-off-by: Logan Gunthorpe ---

[PATCH 1/2] PCI/switechtec: Add missing __iomem and __user tags to fix sparse warnings

2020-07-28 Thread Logan Gunthorpe
Fix a number of missing __iomem and __user tags in the ioctl functions of the switchtec driver. This fixes a number of sparse warnings of the form: sparse: sparse: incorrect type in ... (different address spaces) Fixes: 52eabba5bcdb ("switchtec: Add IOCTLs to the Switchtec driver")

[char-misc-next V3] mei: add device kind to sysfs

2020-07-28 Thread Tomas Winkler
From: Alexander Usyskin Some of the mei device heads are not generic and have a specific purpose, we need to announce it to the user space so it is possible to detect the correct device node via matching attributes. Generic heads are marked as 'mei' while special purpose heads have their own

Re: [PATCH v4 0/6] mm/migrate: avoid device private invalidations

2020-07-28 Thread Jason Gunthorpe
On Thu, Jul 23, 2020 at 03:29:58PM -0700, Ralph Campbell wrote: > The goal for this series is to avoid device private memory TLB > invalidations when migrating a range of addresses from system > memory to device private memory and some of those pages have already > been migrated. The approach

Re: bdi cleanups v3

2020-07-28 Thread Jens Axboe
On 7/28/20 9:41 AM, Jens Axboe wrote: > On 7/24/20 1:32 AM, Christoph Hellwig wrote: >> Hi Jens, >> >> this series contains a bunch of different BDI cleanups. The biggest item >> is to isolate block drivers from the BDI in preparation of changing the >> lifetime of the block device BDI in a

Re: [PATCH v4 6/6] mm/migrate: remove range invalidation in migrate_vma_pages()

2020-07-28 Thread Jason Gunthorpe
On Thu, Jul 23, 2020 at 03:30:04PM -0700, Ralph Campbell wrote: > When migrating the special zero page, migrate_vma_pages() calls > mmu_notifier_invalidate_range_start() before replacing the zero page > PFN in the CPU page tables. This is unnecessary since the range was > invalidated in

Re: [PATCH 1/2] dt-bindings: sound: add DT bindings for Microchip S/PDIF TX Controller

2020-07-28 Thread Rob Herring
On Tue, 28 Jul 2020 13:07:43 +0300, Codrin Ciubotariu wrote: > This patch adds DT bindings for the new Microchip S/PDIF TX Controller > embedded inside sama7g5 SoCs. > > Signed-off-by: Codrin Ciubotariu > --- > .../bindings/sound/mchp,spdiftx.yaml | 76 +++ > 1 file

Re: [PATCH 0/4] arm64: Initial support for Texas Instrument's J7200 Platform

2020-07-28 Thread Grygorii Strashko
On 23/07/2020 11:46, Lokesh Vutla wrote: This series adds initial support for latest new SoC, J7200, from Texas Instruments. The J7200 SoC is a part of the K3 Multicore SoC architecture platform. It is targeted for for automotive gateway, vehicle compute systems, Vehicle-to-Vehicle (V2V)

Re: [PATCH v6 5/6] iommu/uapi: Handle data and argsz filled by users

2020-07-28 Thread Alex Williamson
On Thu, 23 Jul 2020 10:25:39 -0700 Jacob Pan wrote: > IOMMU user APIs are responsible for processing user data. This patch > changes the interface such that user pointers can be passed into IOMMU > code directly. Separate kernel APIs without user pointers are introduced > for in-kernel users of

Re: [PATCH v6 1/6] docs: IOMMU user API

2020-07-28 Thread Alex Williamson
On Thu, 23 Jul 2020 10:25:35 -0700 Jacob Pan wrote: > IOMMU UAPI is newly introduced to support communications between guest > virtual IOMMU and host IOMMU. There has been lots of discussions on how > it should work with VFIO UAPI and userspace in general. > > This document is intended to

Re: [PATCH v5 3/3] usb: dwc2: don't use ID/Vbus detection if usb-role-switch on STM32MP15 SoCs

2020-07-28 Thread Martin Blumenstingl
Hi Amelie, On Tue, Jul 28, 2020 at 9:46 AM Amelie Delaunay wrote: > > If usb-role-switch is present in the device tree, it means that ID and Vbus > signals are not connected to the OTG controller but to an external > component (GPIOs, Type-C controller). In this configuration, usb role > switch

Re: [PATCH v2 1/9] dt-bindings: arm: mstar: Add binding details for mstar,pmsleep

2020-07-28 Thread Rob Herring
On Tue, Jul 28, 2020 at 07:03:13PM +0900, Daniel Palmer wrote: > This adds a YAML description of the pmsleep node used by > MStar/SigmaStar Armv7 SoCs. > > Signed-off-by: Daniel Palmer > --- > .../bindings/arm/mstar/mstar,pmsleep.yaml | 43 +++ > MAINTAINERS

Re: [PATCH net-next RFC 01/13] devlink: Add reload level option to devlink reload command

2020-07-28 Thread Jacob Keller
On 7/28/2020 11:44 AM, Jakub Kicinski wrote: > On Tue, 28 Jul 2020 09:47:00 -0700 Jacob Keller wrote: >> On 7/28/2020 6:58 AM, Jiri Pirko wrote: >>> But this is needed to maintain the existing behaviour which is different >>> for different drivers. >> >> Which drivers behave differently here? >

Re: [PATCH] ARM: socfpga: PM: add missing put_device() call in socfpga_setup_ocram_self_refresh()

2020-07-28 Thread Dinh Nguyen
On 7/21/20 8:45 AM, Yu Kuai wrote: > if of_find_device_by_node() succeed, socfpga_setup_ocram_self_refresh > doesn't have a corresponding put_device(). Thus add a jump target to > fix the exception handling for this function implementation. > > Fixes: 44fd8c7d4005 ("ARM: socfpga: support

Re: [PATCH] dma-buf: heaps: Introduce dma_heap_add_cma() for non-default CMA heap

2020-07-28 Thread John Stultz
On Thu, Jul 16, 2020 at 6:10 PM Kunihiko Hayashi wrote: > > Current dma-buf heaps can handle only default CMA. This introduces > dma_heap_add_cma() function to attach CMA heaps that belongs to a device. > > At first, the driver calls of_reserved_mem_device_init() to set > memory-region property

Re: [PATCH bpf-next v2 27/35] bpf: eliminate rlimit-based memory accounting infra for bpf maps

2020-07-28 Thread Andrii Nakryiko
On Tue, Jul 28, 2020 at 12:09 PM Roman Gushchin wrote: > > On Mon, Jul 27, 2020 at 11:06:42PM -0700, Song Liu wrote: > > On Mon, Jul 27, 2020 at 10:58 PM Andrii Nakryiko > > wrote: > > > > > > On Mon, Jul 27, 2020 at 10:47 PM Song Liu wrote: > > > > > > > > On Mon, Jul 27, 2020 at 12:26 PM

Re: [PATCH v2 1/9] dt-bindings: arm: mstar: Add binding details for mstar, pmsleep

2020-07-28 Thread Rob Herring
On Tue, 28 Jul 2020 19:03:13 +0900, Daniel Palmer wrote: > This adds a YAML description of the pmsleep node used by > MStar/SigmaStar Armv7 SoCs. > > Signed-off-by: Daniel Palmer > --- > .../bindings/arm/mstar/mstar,pmsleep.yaml | 43 +++ > MAINTAINERS

Re: [PATCH 3/4] arm64: dts: ti: Add support for J7200 SoC

2020-07-28 Thread Grygorii Strashko
On 23/07/2020 11:46, Lokesh Vutla wrote: The J7200 SoC is a part of the K3 Multicore SoC architecture platform. It is targeted for automotive gateway, vehicle compute systems, Vehicle-to-Vehicle (V2V) and Vehicle-to-Everything (V2X) applications. The SoC aims to meet the complex processing

RE: [char-misc-next V2] mei: add device kind to sysfs

2020-07-28 Thread Winkler, Tomas
> > On Tue, Jul 28, 2020 at 09:28:36PM +0300, Tomas Winkler wrote: > > +/** > > + * kind_show - display device kind > > + * > > + * @device: device pointer > > + * @attr: attribute pointer > > + * @buf: char out buffer > > + * > > + * Return: number of the bytes printed into buf or error > >

Re: [PATCH v2 2/2] clk: imx: imx8m: use devm_of_clk_add_hw_provider()

2020-07-28 Thread Stephen Boyd
Quoting peng@nxp.com (2020-07-28 02:03:19) > From: Peng Fan > > Use devm_of_clk_add_hw_provider() to simplify code. > To i.MX8MP, also add err handling. > > Signed-off-by: Peng Fan > --- Reviewed-by: Stephen Boyd

Re: [PATCH v2 1/2] clk: imx: imx8m: avoid memory leak

2020-07-28 Thread Stephen Boyd
Quoting peng@nxp.com (2020-07-28 02:03:18) > From: Peng Fan > > Use devm_kzalloc() to avoid memory leak when probe fail. > > Signed-off-by: Peng Fan > --- Reviewed-by: Stephen Boyd

Re: [PATCH v4 3/6] mm/notifier: add migration invalidation type

2020-07-28 Thread Jason Gunthorpe
On Thu, Jul 23, 2020 at 03:30:01PM -0700, Ralph Campbell wrote: > static inline int mm_has_notifiers(struct mm_struct *mm) > @@ -513,6 +519,7 @@ static inline void mmu_notifier_range_init(struct > mmu_notifier_range *range, > range->start = start; > range->end = end; >

Re: [PATCH][next] bpf: fix swapped arguments in calls to check_buffer_access

2020-07-28 Thread Yonghong Song
On 7/28/20 3:43 AM, Daniel Borkmann wrote: On 7/27/20 11:39 PM, Yonghong Song wrote: On 7/27/20 10:54 AM, Colin King wrote: From: Colin Ian King There are a couple of arguments of the boolean flag zero_size_allowed and the char pointer buf_info when calling to function

BUG in iscisd with 5.8-rc kernels

2020-07-28 Thread Marc Dionne
Since some point in the current 5.8 cycle, iscsid sometimes crashes and fails to come up after a reboot. Here is a sample BUG: kernel: BUG: scheduling while atomic: iscsid/763/0x0200 kernel: Call Trace: kernel: dump_stack+0x6b/0x88 kernel: __schedule_bug.cold+0x4c/0x58 kernel:

Re: [PATCH bpf-next v2 27/35] bpf: eliminate rlimit-based memory accounting infra for bpf maps

2020-07-28 Thread Roman Gushchin
On Mon, Jul 27, 2020 at 11:06:42PM -0700, Song Liu wrote: > On Mon, Jul 27, 2020 at 10:58 PM Andrii Nakryiko > wrote: > > > > On Mon, Jul 27, 2020 at 10:47 PM Song Liu wrote: > > > > > > On Mon, Jul 27, 2020 at 12:26 PM Roman Gushchin wrote: > > > > > > > > Remove rlimit-based accounting

Re: linux-next: Tree for Jul 27 (kernel/bpf/syscall.o)

2020-07-28 Thread Andrii Nakryiko
On Mon, Jul 27, 2020 at 11:01 PM Randy Dunlap wrote: > > On 7/27/20 10:48 PM, Andrii Nakryiko wrote: > > On Mon, Jul 27, 2020 at 11:58 AM Randy Dunlap wrote: > >> > >> On 7/27/20 6:23 AM, Stephen Rothwell wrote: > >>> Hi all, > >>> > >>> Changes since 20200724: > >>> > >> > >> on i386: > >> when

Re: [GIT PULL] asm-generic: bugfix for v5.8

2020-07-28 Thread pr-tracker-bot
The pull request you sent on Tue, 28 Jul 2020 14:42:19 +0200: > git://git.kernel.org/pub/scm/linux/kernel/git/arnd/asm-generic.git > tags/asm-generic-fixes-5.8 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/6ba1b005ffc388c2aeaddae20da29e4810dea298 Thank you! --

Re: [GIT PULL] arch/sh additional critical fixes 5.8

2020-07-28 Thread pr-tracker-bot
The pull request you sent on Mon, 27 Jul 2020 18:09:24 -0400: > git://git.libc.org/linux-sh tags/sh-for-5.8-part2 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/4764e61e1d57c0bc3569dbc540af8bb28e18d2e6 Thank you! -- Deet-doot-dot, I am a bot.

Re: [PATCH v1 0/4] [RFC] Implement Trampoline File Descriptor

2020-07-28 Thread Madhavan T. Venkataraman
I am working on a response to this. I will send it soon. Thanks. Madhavan On 7/28/20 12:31 PM, Andy Lutomirski wrote: >> On Jul 28, 2020, at 6:11 AM, madve...@linux.microsoft.com wrote: >> >> From: "Madhavan T. Venkataraman" >> >> The kernel creates the trampoline mapping without any

Re: [PATCH v4 2/4] power: supply: bq27xxx_battery: Add the BQ27561 Battery monitor

2020-07-28 Thread Dan Murphy
Sebastian On 7/28/20 1:17 PM, Sebastian Reichel wrote: Hi, On Tue, Jul 28, 2020 at 09:11:11AM -0500, Dan Murphy wrote: Add the Texas Instruments BQ27561 battery monitor. The register address map is laid out the same as compared to other devices within the file. The battery status register

Re: [PATCH] mm: memcontrol: don't count limit-setting reclaim as memory pressure

2020-07-28 Thread Roman Gushchin
On Tue, Jul 28, 2020 at 09:52:10AM -0400, Johannes Weiner wrote: > When an outside process lowers one of the memory limits of a cgroup > (or uses the force_empty knob in cgroup1), direct reclaim is performed > in the context of the write(), in order to directly enforce the new > limit and have it

Re: [char-misc-next V2] mei: add device kind to sysfs

2020-07-28 Thread Greg Kroah-Hartman
On Tue, Jul 28, 2020 at 09:28:36PM +0300, Tomas Winkler wrote: > +/** > + * kind_show - display device kind > + * > + * @device: device pointer > + * @attr: attribute pointer > + * @buf: char out buffer > + * > + * Return: number of the bytes printed into buf or error No need for kernel doc for

Re: [PATCH v1 0/4] [RFC] Implement Trampoline File Descriptor

2020-07-28 Thread Madhavan T. Venkataraman
On 7/28/20 12:16 PM, Andy Lutomirski wrote: > On Tue, Jul 28, 2020 at 9:32 AM Madhavan T. Venkataraman > wrote: >> Thanks. See inline.. >> >> On 7/28/20 10:13 AM, David Laight wrote: >>> From: madve...@linux.microsoft.com Sent: 28 July 2020 14:11 >>> ... The kernel creates the

Re: [PATCH v2 4/8] x86/kaslr: Initialize mem_limit to the real maximum address

2020-07-28 Thread Kees Cook
On Mon, Jul 27, 2020 at 07:07:57PM -0400, Arvind Sankar wrote: > On 64-bit, the kernel must be placed below MAXMEM (64TiB with 4-level > paging or 4PiB with 5-level paging). This is currently not enforced by > KASLR, which thus implicitly relies on physical memory being limited to > less than

Re: [PATCH v3 00/19] Introduce partial kernel_read_file() support

2020-07-28 Thread Mimi Zohar
On Mon, 2020-07-27 at 12:18 -0700, Scott Branden wrote: > Hi Mimi/Kees, > > On 2020-07-27 4:16 a.m., Mimi Zohar wrote: > > On Fri, 2020-07-24 at 14:36 -0700, Kees Cook wrote: > >> v3: > >> - add reviews/acks > >> - add "IMA: Add support for file reads without contents" patch > >> - trim CC list,

Re: [PATCH V3fix ghak120] audit: initialize context values in case of mandatory events

2020-07-28 Thread Paul Moore
On Tue, Jul 28, 2020 at 12:27 PM Richard Guy Briggs wrote: > On 2020-07-27 22:14, Paul Moore wrote: > > On Mon, Jul 27, 2020 at 5:30 PM Richard Guy Briggs wrote: > > > Issue ghak120 enabled syscall records to accompany required records when > > > no rules are present to trigger the storage of

Re: [PATCH] mwifiex: don't call del_timer_sync() on uninitialized timer

2020-07-28 Thread Brian Norris
Hi, On Mon, Jul 27, 2020 at 6:45 PM Tetsuo Handa wrote: > > syzbot is reporting that del_timer_sync() is called from > mwifiex_usb_cleanup_tx_aggr() from mwifiex_unregister_dev() without > checking timer_setup() from mwifiex_usb_tx_init() was called [1]. > Since mwifiex_usb_prepare_tx_aggr_skb()

Re: [PATCH net-next RFC 01/13] devlink: Add reload level option to devlink reload command

2020-07-28 Thread Jakub Kicinski
On Tue, 28 Jul 2020 09:47:00 -0700 Jacob Keller wrote: > On 7/28/2020 6:58 AM, Jiri Pirko wrote: > > But this is needed to maintain the existing behaviour which is different > > for different drivers. > > Which drivers behave differently here? I think Jiri refers to mlxsw vs mlx5. mlxsw loads

Re: [PATCH] staging: android: ashmem: used const keyword

2020-07-28 Thread Dhiraj Sharma
Alright, I have understood now that I should not trust on checkpatch.pl script fully but partially it is indeed helpful. Please don't criticize this script, it was my fault instead. Before submitting code changes I would test them all, sorry for wasting your time please ignore this patch changes

Re: [PATCH 13/15] iio: sx9310: Add newlines to printks

2020-07-28 Thread Andy Shevchenko
On Tue, Jul 28, 2020 at 9:24 PM Joe Perches wrote: > On Tue, 2020-07-28 at 21:19 +0300, Andy Shevchenko wrote: > > On Tue, Jul 28, 2020 at 6:14 PM Daniel Campello > > wrote: > > > From: Stephen Boyd > > > > > > Printks in the kernel have newlines at the end. Add them to the few > > > >

Re: [PATCH v1] Bluetooth: hci_qca: Stop collecting memdump again for command timeout during SSR

2020-07-28 Thread Marcel Holtmann
Hi Venkata, > Setting memdump state to idle prior to setting of callback function > pointer for command timeout to NULL,causing the issue.Now moved the > initialisation of memdump state to qca_setup(). > > Fixes: d841502c79e3 ("Bluetooth: hci_qca: Collect controller memory dump > during SSR") >

[REGRESSION] omapdrm/N900 display broken

2020-07-28 Thread Aaro Koskinen
Hi, Looks like N900 display support has broken after v5.6. When using v5.7, or the current mainline (v5.8-rc7), the boot hangs at: [6.269500] omapdss_dss 4805.dss: 4805.dss supply vdda_video not found, using dummy regulator [6.321685] DSS: OMAP DSS rev 2.0 [6.328002]

Re: [PATCH bpf-next v2 32/35] bpf: selftests: delete bpf_rlimit.h

2020-07-28 Thread Andrii Nakryiko
On Mon, Jul 27, 2020 at 11:11 PM Song Liu wrote: > > > > > On Jul 27, 2020, at 11:06 PM, Andrii Nakryiko > > wrote: > > > > On Mon, Jul 27, 2020 at 12:25 PM Roman Gushchin wrote: > >> > >> As rlimit-based memory accounting is not used by bpf anymore, > >> there are no more reasons to play with

Re: [PATCH v3] Bluetooth: Fix suspend notifier race

2020-07-28 Thread Marcel Holtmann
Hi Abhishek, > Unregister from suspend notifications and cancel suspend preparations > before running hci_dev_do_close. Otherwise, the suspend notifier may > race with unregister and cause cmd_timeout even after hdev has been > freed. > > Below is the trace from when this panic was seen: > > [

[char-misc-next V2] mei: add device kind to sysfs

2020-07-28 Thread Tomas Winkler
From: Alexander Usyskin Some of the mei device heads are not generic and have a specific purpose, we need to announce it to the user space so it is possible to detect the correct device node via matching attributes. Generic heads are marked as 'mei' while special purpose heads have their own

Re: [PATCH] gpiolib: of: reset name variable in of_gpiochip_add_hog

2020-07-28 Thread Andy Shevchenko
On Tue, Jul 28, 2020 at 4:44 PM wrote: > > From: Tom Rix > > Clang static analysis reports this error > > gpiolib-of.c:664:9: warning: 2nd function call argument > is an uninitialized value [core.CallAndMessage] > ret = gpiod_hog(desc, name, lflags, dflags); > > name is sometimes set

Re: [PATCH v2 3/8] x86/kaslr: Fix process_efi_entries comment

2020-07-28 Thread Kees Cook
On Mon, Jul 27, 2020 at 07:07:56PM -0400, Arvind Sankar wrote: > Since commit > 0982adc74673 ("x86/boot/KASLR: Work around firmware bugs by excluding > EFI_BOOT_SERVICES_* and EFI_LOADER_* from KASLR's choice") > process_efi_entries will return true if we have an EFI memmap, not just > if it

[PATCH] staging: qlge: qlge_dbg: removed comment repition

2020-07-28 Thread Dhiraj Sharma
Inside function ql_get_dump comment statement had a repition of word "to" which I removed and checkpatch.pl ouputs zero error or warnings now. Signed-off-by: Dhiraj Sharma --- drivers/staging/qlge/qlge_dbg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH] cpufreq: intel_pstate: Implement passive mode with HWP enabled

2020-07-28 Thread Rafael J. Wysocki
On Tuesday, July 28, 2020 4:32:22 AM CEST Francisco Jerez wrote: > > "Rafael J. Wysocki" writes: > > > On Tuesday, July 21, 2020 1:20:14 AM CEST Francisco Jerez wrote: > > > > [cut] > > > >> > > >> > However, in the active mode the only updater of hwp_req_cached is > >> > intel_pstate_hwp_set()

Re: [PATCH v2 2/8] x86/kaslr: Remove bogus warning and unnecessary goto

2020-07-28 Thread Kees Cook
On Mon, Jul 27, 2020 at 07:07:55PM -0400, Arvind Sankar wrote: > Drop the warning on seeing "--" in handle_mem_options. This will trigger > whenever one of the memory options is present in the command line > together with "--", but there's no problem if that is the case. > > Replace goto with

Re: [PATCH v2 1/8] x86/kaslr: Make command line handling safer

2020-07-28 Thread Kees Cook
On Mon, Jul 27, 2020 at 07:07:54PM -0400, Arvind Sankar wrote: > Handle the possibility that the command line is NULL. > > Replace open-coded strlen with a function call. > > Signed-off-by: Arvind Sankar Reviewed-by: Kees Cook -- Kees Cook

Re: [PATCH] staging: android: ashmem: used const keyword

2020-07-28 Thread Greg KH
On Tue, Jul 28, 2020 at 11:29:35PM +0530, Dhiraj Sharma wrote: > I ran checkpatch.pl script which reported a warning to use const keyword > on line 370.Therefore I made this change. > > Signed-off-by: Dhiraj Sharma > --- > drivers/staging/android/ashmem.c | 2 +- > 1 file changed, 1

Re: [PATCH 13/15] iio: sx9310: Add newlines to printks

2020-07-28 Thread Joe Perches
On Tue, 2020-07-28 at 21:19 +0300, Andy Shevchenko wrote: > On Tue, Jul 28, 2020 at 6:14 PM Daniel Campello wrote: > > From: Stephen Boyd > > > > Printks in the kernel have newlines at the end. Add them to the few > > Printk()s > > > printks in this driver. > > printk()s Random kernel

Re: [PATCH 5.7 000/179] 5.7.11-rc1 review

2020-07-28 Thread Guenter Roeck
On Mon, Jul 27, 2020 at 04:02:55PM +0200, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 5.7.11 release. > There are 179 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me

Re: [PATCH 5.4 000/138] 5.4.54-rc1 review

2020-07-28 Thread Guenter Roeck
On Mon, Jul 27, 2020 at 04:03:15PM +0200, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 5.4.54 release. > There are 138 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me

Re: [PATCH 4.19 00/86] 4.19.135-rc3 review

2020-07-28 Thread Guenter Roeck
On Tue, Jul 28, 2020 at 05:51:19PM +0200, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 4.19.135 release. > There are 86 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me

Re: [PATCH 4.14 00/64] 4.14.190-rc1 review

2020-07-28 Thread Guenter Roeck
On Mon, Jul 27, 2020 at 04:03:39PM +0200, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 4.14.190 release. > There are 64 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me

Re: [PATCH v2] soc: qcom: rpmh-rsc: Sleep waiting for tcs slots to be free

2020-07-28 Thread Stanimir Varbanov
Hi Doug, On 7/28/20 5:48 PM, Doug Anderson wrote: > Hi, > > On Sun, Jul 26, 2020 at 2:44 AM Stanimir Varbanov > wrote: >> >> Hi Stephen, >> >> On 7/25/20 12:17 AM, Stephen Boyd wrote: >>> From: Stephen Boyd >>> >>> The busy loop in rpmh_rsc_send_data() is written with the assumption >>> that

Re: [PATCH 15/15] iio: sx9310: Enable vdd and svdd regulators at probe

2020-07-28 Thread Andy Shevchenko
On Tue, Jul 28, 2020 at 6:14 PM Daniel Campello wrote: > > From: Stephen Boyd > > Enable the main power supply (vdd) and digital IO power supply (svdd) > during probe so that the i2c communication and device works properly on > boards that aggressively power gate these supplies. > > Reviewed-by:

Re: [PATCH 14/15] iio: sx9310: Drop channel_users[]

2020-07-28 Thread Andy Shevchenko
On Tue, Jul 28, 2020 at 6:14 PM Daniel Campello wrote: > > From: Stephen Boyd > > This struct member isn't used. Drop it. > > Fixes: 72ad02b15d63 ("iio: Add SEMTECH SX9310/9311 sensor driver") > Signed-off-by: Stephen Boyd > Reviewed-by: Douglas Anderson > Reviewed-by: Daniel Campello >

Re: [PATCH 13/15] iio: sx9310: Add newlines to printks

2020-07-28 Thread Andy Shevchenko
On Tue, Jul 28, 2020 at 6:14 PM Daniel Campello wrote: > > From: Stephen Boyd > > Printks in the kernel have newlines at the end. Add them to the few Printk()s > printks in this driver. printk()s > Reviewed-by: Daniel Campello > Reviewed-by: Douglas Anderson > Fixes: 72ad02b15d63 ("iio:

Re: [RFC][PATCH] exec: Freeze the other threads during a multi-threaded exec

2020-07-28 Thread Linus Torvalds
On Tue, Jul 28, 2020 at 6:23 AM Eric W. Biederman wrote: > > For exec all I care about are user space threads. So it appears the > freezer infrastructure adds very little. Yeah. 99% of the freezer stuff is for just adding the magic notations for kernel threads, and for any user space threads it

Re: [PATCH v4 2/4] power: supply: bq27xxx_battery: Add the BQ27561 Battery monitor

2020-07-28 Thread Sebastian Reichel
Hi, On Tue, Jul 28, 2020 at 09:11:11AM -0500, Dan Murphy wrote: > Add the Texas Instruments BQ27561 battery monitor. The register address > map is laid out the same as compared to other devices within the file. > The battery status register has differing bits to determine if the > battery is

Re: [PATCH 11/15] iio: sx9310: Use variable to hold >dev

2020-07-28 Thread Andy Shevchenko
On Tue, Jul 28, 2020 at 6:14 PM Daniel Campello wrote: > > Improves readability by storing >dev in a local variable. Reviewed-by: Andy Shevchenko > Signed-off-by: Daniel Campello > --- > > drivers/iio/proximity/sx9310.c | 30 +++--- > 1 file changed, 15 insertions(+),

Re: [PATCH 12/15] iio: sx9310: Miscellaneous format fixes

2020-07-28 Thread Andy Shevchenko
On Tue, Jul 28, 2020 at 6:14 PM Daniel Campello wrote: > > Miscellaneous format fixes throughout the whole file. Reviewed-by: Andy Shevchenko > Signed-off-by: Daniel Campello > --- > > drivers/iio/proximity/sx9310.c | 28 ++-- > 1 file changed, 10 insertions(+), 18

Re: [PATCH 10/15] iio: sx9310: Simplify error return handling

2020-07-28 Thread Andy Shevchenko
On Tue, Jul 28, 2020 at 6:14 PM Daniel Campello wrote: > > Checks for non-zero return values to signal error conditions. Reviewed-by: Andy Shevchenko > Signed-off-by: Daniel Campello > --- > > drivers/iio/proximity/sx9310.c | 52 +- > 1 file changed, 26

Re: [PATCH 08/15] iio: sx9310: Use regmap_read_poll_timeout() for compensation

2020-07-28 Thread Andy Shevchenko
On Tue, Jul 28, 2020 at 6:15 PM Daniel Campello wrote: > > Simplify compensation stage by using regmap_read_poll_timeout(). Reviewed-by: Andy Shevchenko > Signed-off-by: Daniel Campello > --- > > drivers/iio/proximity/sx9310.c | 25 ++--- > 1 file changed, 10

Re: [PATCH 07/15] iio: sx9310: Use long instead of int for channel bitmaps

2020-07-28 Thread Andy Shevchenko
On Tue, Jul 28, 2020 at 6:14 PM Daniel Campello wrote: > > Uses for_each_set_bit() macro to loop over channel bitmaps. > Reviewed-by: Andy Shevchenko > Signed-off-by: Daniel Campello > --- > > drivers/iio/proximity/sx9310.c | 24 +--- > 1 file changed, 13 insertions(+),

Re: [PATCH 06/15] iio: sx9310: Align memory

2020-07-28 Thread Andy Shevchenko
On Tue, Jul 28, 2020 at 6:15 PM Daniel Campello wrote: > > Use __aligned(8) to ensure that the timestamp is correctly aligned > when we call push_to_buffers > > Signed-off-by: Daniel Campello > --- > > drivers/iio/proximity/sx9310.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-)

Re: [PATCH 05/15] iio: sx9310: Change from .probe to .probe_new

2020-07-28 Thread Andy Shevchenko
On Tue, Jul 28, 2020 at 6:15 PM Daniel Campello wrote: > > Uses .probe_new in place of .probe. Also uses device_get_match_data() > for whoami matching. Good one! Reviewed-by: Andy Shevchenko > Signed-off-by: Daniel Campello > --- > > drivers/iio/proximity/sx9310.c | 37

Re: [PATCH 04/15] iio: sx9310: Remove acpi and of table macros

2020-07-28 Thread Andy Shevchenko
On Tue, Jul 28, 2020 at 6:16 PM Daniel Campello wrote: > > Avoids unused warnings due to acpi/of table macros. > At the same time I would check if mod_devicetable.h is included. > Signed-off-by: Daniel Campello > Reported-by: kbuild test robot -- With Best Regards, Andy Shevchenko

RE: [char-misc-next] mei: add device type

2020-07-28 Thread Winkler, Tomas
> -Original Message- > From: Greg Kroah-Hartman > Sent: Tuesday, July 28, 2020 18:54 > To: Winkler, Tomas > Cc: Usyskin, Alexander ; linux- > ker...@vger.kernel.org > Subject: Re: [char-misc-next] mei: add device type > > On Tue, Jul 28, 2020 at 06:25:46PM +0300, Tomas Winkler wrote:

[PATCH 2/2] ftrace: skip special ftrace_ops when enable module

2020-07-28 Thread Chengming Zhou
When enable module, we find all ftrace_ops referenced it on the ftrace_ops_list. But FTRACE_OPS_FL_DIRECT and FTRACE_OPS_FL_IPMODIFY flag are special, and should not be set automatically. So warn and skip ftrace_ops that have these two flags. Also check if only one ftrace_ops references the

[PATCH 1/2] ftrace: setup correct FTRACE_FL_REGS flags for module

2020-07-28 Thread Chengming Zhou
When module loaded and enabled, we will use __ftrace_replace_code for module if any ftrace_ops referenced it found. But we will get wrong ftrace_addr for module rec in ftrace_get_addr_new, because rec->flags has not been setup correctly. It can cause the callback function of a ftrace_ops has

Re: [PATCH 03/15] iio: sx9310: Fix irq handling

2020-07-28 Thread Andy Shevchenko
On Tue, Jul 28, 2020 at 6:14 PM Daniel Campello wrote: > > Fixes enable/disable irq handling at various points. The driver needs to > only enable/disable irqs if there is an actual irq handler installed. > - enable_irq(data->client->irq); > + if (!ret) > +

Re: [PATCH v4 2/6] media: v4l2: Add extended buffer operations

2020-07-28 Thread Stanimir Varbanov
Hi Tomasz, On 7/27/20 3:35 PM, Tomasz Figa wrote: > Hi Stanimir, > > On Fri, Jul 24, 2020 at 3:17 PM Stanimir Varbanov > wrote: >> >> >> >> On 7/21/20 5:40 PM, Helen Koike wrote: >>> >>> >>> On 7/21/20 11:30 AM, Stanimir Varbanov wrote: Hi Helen, On 7/21/20 4:54 PM, Helen Koike

Re: [PATCH v7 7/8] scsi: ufs: Move dumps in IRQ handler to error handler

2020-07-28 Thread Asutosh Das (asd)
On 7/27/2020 10:00 PM, Can Guo wrote: Sometime dumps in IRQ handler are heavy enough to cause system stability issues, move them to error handler. Signed-off-by: Can Guo --- drivers/scsi/ufs/ufshcd.c | 31 +++ 1 file changed, 15 insertions(+), 16 deletions(-)

Re: [PATCH] staging: android: ashmem: used const keyword

2020-07-28 Thread Joe Perches
On Tue, 2020-07-28 at 23:29 +0530, Dhiraj Sharma wrote: > I ran checkpatch.pl script which reported a warning to use const keyword > on line 370.Therefore I made this change. checkpatch is a brainless script. Not everything it suggests is appropriate. > diff --git

Re: [PATCH v2 2/2] iio: light: as73211: New driver

2020-07-28 Thread Jonathan Cameron
On Tue, 28 Jul 2020 08:28:31 +0200 Christian Eggers wrote: > Support for AMS AS73211 JENCOLOR(R) Digital XYZ Sensor. > > This driver has no built-in trigger. In order for making triggered > measurements, an external (software) trigger driver like > iio-trig-hrtimer or iio-trig-sysfs is

Re: [PATCH v4 2/6] media: v4l2: Add extended buffer operations

2020-07-28 Thread Stanimir Varbanov
Hi Helen, On 7/27/20 3:01 PM, Helen Koike wrote: > > > On 7/24/20 10:16 AM, Stanimir Varbanov wrote: >> >> >> On 7/21/20 5:40 PM, Helen Koike wrote: >>> >>> >>> On 7/21/20 11:30 AM, Stanimir Varbanov wrote: Hi Helen, On 7/21/20 4:54 PM, Helen Koike wrote: > Hi, > > On

Re: [PATCH v7 4/8] scsi: ufs: Add some debug infos to ufshcd_print_host_state

2020-07-28 Thread Asutosh Das (asd)
On 7/27/2020 10:00 PM, Can Guo wrote: The infos of the last interrupt status and its timestamp are very helpful when debug system stability issues, e.g. IRQ starvation, so add them to ufshcd_print_host_state. Meanwhile, UFS device infos like model name and its FW version also come in handy

Re: [PATCH v2 2/2] iio: light: as73211: New driver

2020-07-28 Thread Andy Shevchenko
On Tue, Jul 28, 2020 at 9:32 AM Christian Eggers wrote: > > Support for AMS AS73211 JENCOLOR(R) Digital XYZ Sensor. > > This driver has no built-in trigger. In order for making triggered > measurements, an external (software) trigger driver like > iio-trig-hrtimer or iio-trig-sysfs is required. >

[PATCH] staging: android: ashmem: used const keyword

2020-07-28 Thread Dhiraj Sharma
I ran checkpatch.pl script which reported a warning to use const keyword on line 370.Therefore I made this change. Signed-off-by: Dhiraj Sharma --- drivers/staging/android/ashmem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/android/ashmem.c

Re: [PATCH] sched: Make select_idle_sibling search domain configurable

2020-07-28 Thread Xi Wang
On Tue, Jul 28, 2020 at 3:39 AM wrote: > > On Tue, Jul 28, 2020 at 12:01:31AM -0700, Xi Wang wrote: > > The scope of select_idle_sibling idle cpu search is LLC. This > > becomes a problem for the AMD CCX architecture, as the sd_llc is only > > 4 cores. On a many core machine, the range of search

Re: [PATCH v5 5/6] kprobes: Use text_alloc() and text_free()

2020-07-28 Thread Ard Biesheuvel
On Tue, 28 Jul 2020 at 16:35, Masami Hiramatsu wrote: > > On Tue, 28 Jul 2020 13:56:43 +0300 > Ard Biesheuvel wrote: > > > On Tue, 28 Jul 2020 at 11:17, Masami Hiramatsu wrote: > > > > Masami or Peter should correct me if I am wrong, but it seems to me > > > > that the way kprobes uses these

<    1   2   3   4   5   6   7   8   9   10   >