Re: [PATCH] rtw88: fix spelling mistake: "unsupport" -> "unsupported"

2020-08-18 Thread Kalle Valo
Colin King wrote: > From: Colin Ian King > > There are some spelling mistakes in rtw_info messages. Fix these. > > Signed-off-by: Colin Ian King Patch applied to wireless-drivers-next.git, thanks. 86c96422a3b3 rtw88: fix spelling mistake: "unsupport" -> "unsupported" -- https://patchwork.

Re: file metadata via fs API

2020-08-18 Thread Miklos Szeredi
On Tue, Aug 18, 2020 at 12:44 AM Linus Torvalds wrote: > So please. Can we just make a simple extended statfs() and be done > with it, instead of this hugely complex thing that does five different > things with the same interface and makes it really odd as a result? How do you propose handling v

Re: [PATCH] wl1251, wlcore: fix spelling mistake "buld" -> "build"

2020-08-18 Thread Kalle Valo
Colin King wrote: > From: Colin Ian King > > There are spelling mistakes in warning messages. Fix these. > > Signed-off-by: Colin Ian King Patch applied to wireless-drivers-next.git, thanks. db8655c6299c wl1251, wlcore: fix spelling mistake "buld" -> "build" -- https://patchwork.kernel.or

Re: [PATCH] brcmfmac: check ndev pointer

2020-08-18 Thread Kalle Valo
t...@redhat.com wrote: > From: Tom Rix > > Clang static analysis reports this error > > brcmfmac/core.c:490:4: warning: Dereference of null pointer > (*ifp)->ndev->stats.rx_errors++; > ^~~ > > In this block of code > > if (ret || !(*ifp) || !(

[RFC PATCH v2 1/3] add mikrobus descriptors to greybus_manifest

2020-08-18 Thread Vaishnav M A
This patch adds new descriptors used in the manifest parsing inside the mikrobus driver, the device descriptor help to describe the devices on a mikroBUS port, mikrobus descriptor is used to set up the mikrobus port pinmux and GPIO states and property descriptor to pass named properties to device d

[PATCH v6 3/6] tcp: use sendpage_ok() to detect misused .sendpage

2020-08-18 Thread Coly Li
commit a10674bf2406 ("tcp: detecting the misuse of .sendpage for Slab objects") adds the checks for Slab pages, but the pages don't have page_count are still missing from the check. Network layer's sendpage method is not designed to send page_count 0 pages neither, therefore both PageSlab() and pa

[RFC PATCH v2 3/3] Add Device Tree Bindings for mikroBUS port

2020-08-18 Thread Vaishnav M A
This patch adds device tree bindings for the mikroBUS port, device tree overlays for the mikrobus Port on the BeagleBoard.org PocketBeagle is available here : github.com/beagleboard/bb.org-overlays/blob/master/src/arm/PB-MIKROBUS-0.dts Signed-off-by: Vaishnav M A --- .../bindings/misc/linux,mikr

[PATCH v6 5/6] scsi: libiscsi: use sendpage_ok() in iscsi_tcp_segment_map()

2020-08-18 Thread Coly Li
In iscsci driver, iscsi_tcp_segment_map() uses the following code to check whether the page should or not be handled by sendpage: if (!recv && page_count(sg_page(sg)) >= 1 && !PageSlab(sg_page(sg))) The "page_count(sg_page(sg)) >= 1 && !PageSlab(sg_page(sg)" part is to make sure the page can b

[PATCH v6 6/6] libceph: use sendpage_ok() in ceph_tcp_sendpage()

2020-08-18 Thread Coly Li
In libceph, ceph_tcp_sendpage() does the following checks before handle the page by network layer's zero copy sendpage method, if (page_count(page) >= 1 && !PageSlab(page)) This check is exactly what sendpage_ok() does. This patch replace the open coded checks by sendpage_ok() as a code cl

[RFC PATCH v2 2/3] mikroBUS driver for add-on boards on mikrobus ports

2020-08-18 Thread Vaishnav M A
The mikrobus driver is updated to add mikrobus ports from device-tree overlays, the debug interfaces for adding mikrobus ports through sysFS is removed, and the driver considers the extended usage of mikrobus port pins from their standard purpose, for example an SHT15 add-on board will need the I2C

[RFC PATCH v2 0/3] mikroBUS driver for add-on boards

2020-08-18 Thread Vaishnav M A
Hi, This Patch series is an update to the mikroBUS driver RFC v1 Patch : https://lkml.org/lkml/2020/7/24/518 . The mikrobus driver is updated to add mikrobus ports from device-tree overlays, the debug interfaces for adding mikrobus ports through sysFS is removed, and the driver considers the exten

Re: [PATCH] coresight: cti: remove pm_runtime_get_sync() from CPU hotplug

2020-08-18 Thread Mike Leach
On Tue, 18 Aug 2020 at 12:11, Tingwei Zhang wrote: > > Below BUG is triggered by call pm_runtime_get_sync() in > cti_cpuhp_enable_hw(). It's in CPU hotplug callback with interrupt > disabled. Pm_runtime_get_sync() calls clock driver to enable clock > which could sleep. Remove pm_runtime_get_sync()

[PATCH v6 0/6] Introduce sendpage_ok() to detect misused sendpage in network related drivers

2020-08-18 Thread Coly Li
This series was original by a bug fix in nvme-over-tcp driver which only checked whether a page was allocated from slab allcoator, but forgot to check its page_count: The page handled by sendpage should be neither a Slab page nor 0 page_count page. As Sagi Grimberg suggested, the original fix is r

[PATCH v6 2/6] nvme-tcp: check page by sendpage_ok() before calling kernel_sendpage()

2020-08-18 Thread Coly Li
Currently nvme_tcp_try_send_data() doesn't use kernel_sendpage() to send slab pages. But for pages allocated by __get_free_pages() without __GFP_COMP, which also have refcount as 0, they are still sent by kernel_sendpage() to remote end, this is problematic. The new introduced helper sendpage_ok()

[PATCH v6 4/6] drbd: code cleanup by using sendpage_ok() to check page for kernel_sendpage()

2020-08-18 Thread Coly Li
In _drbd_send_page() a page is checked by following code before sending it by kernel_sendpage(), (page_count(page) < 1) || PageSlab(page) If the check is true, this page won't be send by kernel_sendpage() and handled by sock_no_sendpage(). This kind of check is exactly what macro sendpage_

[PATCH v6 1/6] net: introduce helper sendpage_ok() in include/linux/net.h

2020-08-18 Thread Coly Li
The original problem was from nvme-over-tcp code, who mistakenly uses kernel_sendpage() to send pages allocated by __get_free_pages() without __GFP_COMP flag. Such pages don't have refcount (page_count is 0) on tail pages, sending them by kernel_sendpage() may trigger a kernel panic from a corrupte

Re: [PATCH] efi: discover ESRT table on Xen PV too

2020-08-18 Thread Roger Pau Monné
On Tue, Aug 18, 2020 at 02:01:35PM +0200, Marek Marczykowski-Górecki wrote: > On Mon, Aug 17, 2020 at 11:00:13AM +0200, Roger Pau Monné wrote: > > On Sun, Aug 16, 2020 at 02:19:49AM +0200, Marek Marczykowski-Górecki wrote: > > > In case of Xen PV dom0, Xen passes along info about system tables (see

Re: [PATCH net-next] brcm80211: fix possible memleak in brcmf_proto_msgbuf_attach

2020-08-18 Thread Kalle Valo
Wang Yufen wrote: > When brcmf_proto_msgbuf_attach fail and msgbuf->txflow_wq != NULL, > we should destroy the workqueue. > > Reported-by: Hulk Robot > Signed-off-by: Wang Yufen Patch applied to wireless-drivers-next.git, thanks. 6c151410d5b5 brcm80211: fix possible memleak in brcmf_proto_ms

Re: [PATCH] perf top: Skip side-band event setup if HAVE_LIBBPF_SUPPORT is not set

2020-08-18 Thread Arnaldo Carvalho de Melo
Em Tue, Aug 18, 2020 at 08:30:37PM +0800, Tiezhu Yang escreveu: > When I execute perf top without HAVE_LIBBPF_SUPPORT, there exists the > following segmentation fault, skip the side-band event setup to fix it, > this is similar with commit 1101c872c8c7 ("perf record: Skip side-band > event setup if

Re: [PATCH] MIPS: Loongson64: Fix build error about redeclaration of enumerator 'VIRTUAL' and "CONFIG_DM_THIN_PROVISIONING"

2020-08-18 Thread Huacai Chen
Hi, Youling, On Tue, Aug 18, 2020 at 7:35 PM Youling Tang wrote: > > After commit 39c1485c8baa (MIPS: KVM: Add kvm guestsupport for Loongson-3) > > Fix the following build error: > > drivers/md/dm-thin.c:116:2: error: redeclaration of enumerator ‘VIRTUAL’ > VIRTUAL, > ^ > In file included fro

Re: [PATCH] block: rnbd: rnbd-srv: silence uninitialized variable warning

2020-08-18 Thread Brooke Basile
On 8/18/20 1:29 AM, Nathan Chancellor wrote: I don't think this is a proper fix since the root cause of the warning appears to be that we are ignoring the return value of rnbd_bio_map_kern. Should we not set err to that value like this (completely untested)? Cheers, Nathan diff --git a/drivers/

Re: [PATCH] p54: avoid accessing the data mapped to streaming DMA

2020-08-18 Thread Kalle Valo
Jia-Ju Bai wrote: > In p54p_tx(), skb->data is mapped to streaming DMA on line 337: > mapping = pci_map_single(..., skb->data, ...); > > Then skb->data is accessed on line 349: > desc->device_addr = ((struct p54_hdr *)skb->data)->req_id; > > This access may cause data inconsistency between

Re: [powerpc] 5.9.0-rc1 boot failure on POWER9 PowerVM LPAR

2020-08-18 Thread Michael Ellerman
Sachin Sant writes: > 5.9.0-rc1 fails to boot on POWER9 PowerVM LPAR with following message Looks like: https://lore.kernel.org/linuxppc-dev/20200814150509.225615-1-vaib...@linux.ibm.com/ cheers > Starting udev Kernel Device Manager... > [ OK ] Started udev Kernel Device Manager.

Good morning

2020-08-18 Thread Lisa Dennis
-- Hello. Greetings dd you received my previous email?

[PATCH v6] mm/zswap: move to use crypto_acomp API for hardware acceleration

2020-08-18 Thread Barry Song
Right now, all new ZIP drivers are adapted to crypto_acomp APIs rather than legacy crypto_comp APIs. Tradiontal ZIP drivers like lz4,lzo etc have been also wrapped into acomp via scomp backend. But zswap.c is still using the old APIs. That means zswap won't be able to work on any new ZIP drivers in

[PATCH] perf top: Skip side-band event setup if HAVE_LIBBPF_SUPPORT is not set

2020-08-18 Thread Tiezhu Yang
When I execute perf top without HAVE_LIBBPF_SUPPORT, there exists the following segmentation fault, skip the side-band event setup to fix it, this is similar with commit 1101c872c8c7 ("perf record: Skip side-band event setup if HAVE_LIBBPF_SUPPORT is not set"). [yangtiezhu@linux perf]$ ./perf top

Re: [RFC PATCH v1 1/2] ASoC: rockchip-spdif: add description for rk3308

2020-08-18 Thread Mark Brown
On Sat, Aug 15, 2020 at 01:24:36PM +0200, Johan Jonker wrote: > A test with the command below shows that the compatible string > > "rockchip,rk3308-spdif", "rockchip,rk3328-spdif" This doesn't apply against current code, please check and resend. signature.asc Description: PGP signature

[PATCH] libceph: Convert to use the preferred fallthrough macro

2020-08-18 Thread Miaohe Lin
Convert the uses of fallthrough comments to fallthrough macro. Signed-off-by: Miaohe Lin --- net/ceph/ceph_hash.c| 20 ++-- net/ceph/crush/mapper.c | 2 +- net/ceph/messenger.c| 4 ++-- net/ceph/mon_client.c | 2 +- net/ceph/osd_client.c | 4 ++-- 5 files changed,

Re: [PATCH 1/2] arm64/mm: Change THP helpers to comply with generic MM semantics

2020-08-18 Thread Jonathan Cameron
On Tue, 18 Aug 2020 15:11:58 +0530 Anshuman Khandual wrote: > On 08/18/2020 02:43 PM, Jonathan Cameron wrote: > > On Mon, 17 Aug 2020 14:49:43 +0530 > > Anshuman Khandual wrote: > > > >> pmd_present() and pmd_trans_huge() are expected to behave in the following > >> manner during various phas

Re: [PATCH STABLE 4.9] mm: Avoid calling build_all_zonelists_init under hotplug context

2020-08-18 Thread David Hildenbrand
On 18.08.20 13:00, Oscar Salvador wrote: > Recently a customer of ours experienced a crash when booting the > system while enabling memory-hotplug. > > The problem is that Normal zones on different nodes don't get their private > zone->pageset allocated, and keep sharing the initial boot_pageset.

Re: [PATCH STABLE 4.9] mm: Avoid calling build_all_zonelists_init under hotplug context

2020-08-18 Thread Michal Hocko
On Tue 18-08-20 13:00:46, Oscar Salvador wrote: > Recently a customer of ours experienced a crash when booting the > system while enabling memory-hotplug. > > The problem is that Normal zones on different nodes don't get their private > zone->pageset allocated, and keep sharing the initial boot_pa

[PATCH] Harden autofs ioctl table

2020-08-18 Thread Matthew Wilcox
The table of ioctl functions should be marked const in order to put them in read-only memory, and we should use array_index_nospec() to avoid speculation disclosing the contents of kernel memory to userspace. Signed-off-by: Matthew Wilcox (Oracle) diff --git a/fs/autofs/dev-ioctl.c b/fs/autofs/d

out of bounds access on array error_text[] because of -ETIMEDOUT return from __send_command()

2020-08-18 Thread Colin Ian King
Hi, static analysis with coverity has found a buffer overflow issue with the brcmstb driver, I believe it may have been introduced with the following commit: commit a7c25759d8d84b64c437a78f05df7314b02934e5 Author: Markus Mayer Date: Tue Apr 2 16:01:00 2019 -0700 memory: brcmstb: dpfe: wai

Re: [PATCH v2] soc: fsl: enable acpi support

2020-08-18 Thread kernel test robot
Hi Ran, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on linus/master] [also build test WARNING on v5.9-rc1 next-20200818] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as

Re: [PATCH v3 3/3] selinux: add permission names to trace event

2020-08-18 Thread Stephen Smalley
On Tue, Aug 18, 2020 at 4:11 AM peter enderborg wrote: > > On 8/17/20 10:16 PM, Stephen Smalley wrote: > > On 8/17/20 1:07 PM, Thiébaud Weksteen wrote: > > > >> From: Peter Enderborg > >> > >> In the print out add permissions, it will look like: > >> <...>-1042 [007] 201.965142: seli

drivers/mtd/devices/pmc551.c:783:53: sparse: sparse: incorrect type in argument 2 (different address spaces)

2020-08-18 Thread kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 06a4ec1d9dc652e17ee3ac2ceb6c7cf6c2b75cdd commit: 670d0a4b10704667765f7d18f7592993d02783aa sparse: use identifiers to define address spaces date: 9 weeks ago config: arm-randconfig-s032-20200818 (attached

ATM

2020-08-18 Thread Company

[char-misc-next 08/13] mei: handle tx queue flushing for vtag connections

2020-08-18 Thread Tomas Winkler
From: Alexander Usyskin Since multiple file pointers (fp) can be associated with a single host client, upon close() only objects associated with the fp has to flushed from the tx queues. The control queues should be flushed only when all the connections are closed and the client is disconnected.

[char-misc-next 04/13] mei: add support for mei extended header.

2020-08-18 Thread Tomas Winkler
Add an extend header beyond existing 4 bytes of the mei message header. The extension is of variable length, starting with meta header that contains the number of headers and the overall size of the extended headers excluding meta header itself followed by TLV list of extended headers. Currently on

[char-misc-next 06/13] mei: add a spin lock to protect rd_completed queue

2020-08-18 Thread Tomas Winkler
From: Alexander Usyskin In order to support vtags we need to access read completed queue out of driver big lock. Add a spin lock to protect rd_completed queue. Signed-off-by: Alexander Usyskin Signed-off-by: Tomas Winkler --- drivers/misc/mei/bus.c | 6 ++--- drivers/misc/mei/client.c |

[char-misc-next 10/13] mei: bus: unconditionally enable clients with vtag support

2020-08-18 Thread Tomas Winkler
From: Alexander Usyskin The list of clients is only visible via mei client bus. Enabling vtag clients on the mei client bus allows user-space to enumerate clients with vtag support by traversing the mei bus on sysfs. This feature is required for ACRN device model service. Signed-off-by: Alexande

[char-misc-next 12/13] mei: docs: add vtag ioctl documentation

2020-08-18 Thread Tomas Winkler
Add structured documenation for the new vtag ioctl Signed-off-by: Tomas Winkler --- Documentation/driver-api/mei/mei.rst | 37 1 file changed, 37 insertions(+) diff --git a/Documentation/driver-api/mei/mei.rst b/Documentation/driver-api/mei/mei.rst index c800d8e5f4

[char-misc-next 09/13] mei: bus: use zero vtag for bus clients.

2020-08-18 Thread Tomas Winkler
From: Alexander Usyskin The zero vtag is required for the read flow to work also for devices on the mei client bus. Signed-off-by: Alexander Usyskin Signed-off-by: Tomas Winkler --- drivers/misc/mei/bus.c | 72 +- 1 file changed, 71 insertions(+), 1 del

[char-misc-next 13/13] mei: virtio: virtualization frontend driver

2020-08-18 Thread Tomas Winkler
This frontend driver implements MEI hw interface based on virtio framework to let MEI driver work without changes under virtualization. It requires a backend service in the ACRN device-model on the service OS side to make it work. The backend service will emulate mei routing and assign vtags for ea

[char-misc-next 11/13] mei: add connect with vtag ioctl

2020-08-18 Thread Tomas Winkler
From: Alexander Usyskin This IOCTL is used to associate the current file descriptor with a FW Client (given by UUID), and virtual tag (vtag). The IOCTL opens a communication channel between a host client and a FW client on a tagged channel. From this point on, every reader and write will communi

[char-misc-next 05/13] mei: bump hbm version to 2.2

2020-08-18 Thread Tomas Winkler
From: Alexander Usyskin Bump HBM version to 2.2 to indicate vtag support. Signed-off-by: Alexander Usyskin Signed-off-by: Tomas Winkler --- drivers/misc/mei/hw.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/misc/mei/hw.h b/drivers/misc/mei/hw.h index c3c628132b5

Re: [PATCH 2/2] soundwire: fix port_ready[] dynamic allocation in mipi_disco and ASoC codecs

2020-08-18 Thread Pierre-Louis Bossart
On 8/18/20 1:36 AM, Vinod Koul wrote: On 18-08-20, 01:47, Bard Liao wrote: From: Pierre-Louis Bossart The existing code allocates memory for the total number of ports. This only works if the ports are contiguous, but will break if e.g. a Devices uses port0, 1, and 14. The port_ready[] array

[char-misc-next 03/13] mei: add vtag support bit in client properties

2020-08-18 Thread Tomas Winkler
From: Alexander Usyskin Vtag support is on a client basis, meaning not every client supports it. The vtag capability is communicated via the client properties structure during client enumeration process. Export the propertiy via sysfs. Signed-off-by: Alexander Usyskin Signed-off-by: Tomas Winkl

[char-misc-next 02/13] mei: restrict vtag support to hbm version 2.2

2020-08-18 Thread Tomas Winkler
From: Alexander Usyskin The vtag allows partitioning the mei messages into virtual groups/channels. Vtags are supported for firmwares with HBM version 2.2 and newer and only when a firmware confirms the support via capability handshake. This change only define vtag restrictions in order to make t

[char-misc-next 07/13] mei: add a vtag map for each client

2020-08-18 Thread Tomas Winkler
From: Alexander Usyskin Vtag map is a list of tuples of vtag and file pointer (struct mei_cl_vtag) associated with a particular me host client. Signed-off-by: Alexander Usyskin Signed-off-by: Tomas Winkler --- drivers/misc/mei/client.c | 168 - drivers/mis

[PATCH][next] drm/amd/display: fix potential integer overflow when shifting 32 bit variable bl_pwm

2020-08-18 Thread Colin King
From: Colin Ian King The 32 bit unsigned integer bl_pwm is being shifted using 32 bit arithmetic and then being assigned to a 64 bit unsigned integer. There is a potential for a 32 bit overflow so cast bl_pwm to enforce a 64 bit shift operation to avoid this. Addresses-Coverity: ("unintentional

[char-misc-next 01/13] mei: hbm: add capabilities message

2020-08-18 Thread Tomas Winkler
From: Alexander Usyskin The new capabilities command in HBM version 2.2 allows performing capabilities handshake between the firmware and the host driver. The driver requests a capability by setting the appropriate bit in 24bit wide bitmask and the fw responses with the bit set providing the requ

[char-misc-next 00/13] mei: add support for virtual tags

2020-08-18 Thread Tomas Winkler
Add support for mei virtualization for ACRN but might be used for other purposes such as sandboxing. ACRN is an open-source hypervisor maintained by The Linux Foundation. The support for ACRN was added in kernel in v5.3. The patches were part of the ACRN service OS kernel for a while. https://gith

[PATCH] net: tipc: Convert to use the preferred fallthrough macro

2020-08-18 Thread Miaohe Lin
Convert the uses of fallthrough comments to fallthrough macro. Signed-off-by: Miaohe Lin --- net/tipc/bearer.c | 2 +- net/tipc/link.c | 2 +- net/tipc/socket.c | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/net/tipc/bearer.c b/net/tipc/bearer.c index 808b147df7d5..65

drivers/media/cec/platform/tegra/tegra_cec.c:455:34: warning: unused variable 'tegra_cec_of_match'

2020-08-18 Thread kernel test robot
months ago config: x86_64-randconfig-r006-20200818 (attached as .config) compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project 790878f291fa5dc58a1c560cb6cc76fd1bfd1c5a) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin

Re: [PATCH v2] HID: usbhid: do not sleep when opening device

2020-08-18 Thread Johannes Hirte
On 2020 Jun 09, Dmitry Torokhov wrote: > usbhid tries to give the device 50 milliseconds to drain its queues when > opening the device, but dies it naively by simply sleeping in open handler, > which slows down device probing (and thus may affect overall boot time). > > However we do not need to s

[PATCH] habanalabs: Include linux/bitfield.h only in habanalabs.h

2020-08-18 Thread Tomer Tayar
Include linux/bitfield.h only in habanalabs.h, instead of in each and every file that needs it, as habanalabs.h is already included by all. Signed-off-by: Tomer Tayar --- drivers/misc/habanalabs/common/habanalabs.h | 1 + drivers/misc/habanalabs/common/hw_queue.c | 1 - drivers

[PATCH rdma-next 00/14] Cleanup locking and events in ucma

2020-08-18 Thread Leon Romanovsky
From: Leon Romanovsky >From Jason: Rework how the uevents for new connections are handled so all the locking ends up simpler and a work queue can be removed. This should also speed up destruction of ucma_context's as a flush_workqueue() was replaced with cancel_work_sync(). The simpler locking

Re: [PATCH] lockdep: Introduce CONFIG_LOCKDEP_LARGE

2020-08-18 Thread Dmitry Vyukov
On Tue, Aug 18, 2020 at 1:07 PM Tetsuo Handa wrote: > > On 2020/08/18 18:57, Dmitry Vyukov wrote: > > On Tue, Aug 4, 2020 at 4:36 AM Tetsuo Handa > > wrote: > >> > >> Hello, Peter, Ingo and Will. > >> > >> (Q1) Can we change the capacity using kernel config? > >> > >> (Q2) If we can change the ca

Re: [PATCH] mm/memory.c: Replace vmf->vma with variable vma

2020-08-18 Thread Matthew Wilcox
On Tue, Aug 18, 2020 at 04:46:07PM +0800, yanfei...@windriver.com wrote: > From: Yanfei Xu > > The code has declared a vma_struct named vma which is assigned a > value of vmf->vma. Thus, use variable vma directly here. > > Signed-off-by: Yanfei Xu Reviewed-by: Matthew Wilcox (Oracle)

Re: [PATCH] efi: discover ESRT table on Xen PV too

2020-08-18 Thread Marek Marczykowski-Górecki
On Mon, Aug 17, 2020 at 11:00:13AM +0200, Roger Pau Monné wrote: > On Sun, Aug 16, 2020 at 02:19:49AM +0200, Marek Marczykowski-Górecki wrote: > > In case of Xen PV dom0, Xen passes along info about system tables (see > > arch/x86/xen/efi.c), but not the memory map from EFI. > > I think that's bec

[PATCH] net: Relax the npages test against MAX_SKB_FRAGS

2020-08-18 Thread Miaohe Lin
The npages test against MAX_SKB_FRAGS can be relaxed if we succeed to allocate high order pages as the note in comment said. Signed-off-by: Miaohe Lin --- net/core/skbuff.c | 11 --- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/net/core/skbuff.c b/net/core/skbuff.c index

PROBLEM: Long Workqueue delays V2

2020-08-18 Thread Jim Baxter
I am asking this question again to include the fs-devel list. We have issues with the workqueue of the kernel overloading the CPU 0 when we we disconnect a USB stick. This results in other items on the shared workqueue being delayed by around 6.5 seconds with a default kernel configuration and

[PATCH -next] dmaengine: iop-adma: Fix pointer cast warnings

2020-08-18 Thread YueHaibing
drivers/dma/iop-adma.c: In function ‘iop_adma_alloc_chan_resources’: drivers/dma/iop-adma.c:447:13: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] hw_desc = (char *) iop_chan->device->dma_desc_pool; ^ drivers/dma/iop-adma.c:449:4: warning: cast from

Re: [PATCH v2] perf sched timehist: Fix use of CPU list with summary option

2020-08-18 Thread Arnaldo Carvalho de Melo
Em Tue, Aug 18, 2020 at 10:29:29AM +0900, Namhyung Kim escreveu: > Hi David, > > On Tue, Aug 18, 2020 at 2:09 AM David Ahern wrote: > > > > Do not update thread stats or show idle summary unless CPU is in > > the list of interest. > > > > Fixes: c30d630d1bcf ("perf sched timehist: Add support for

Re: [PATCH 1/8] tty: n_gsm, eliminate indirection for gsm->{output,error}()

2020-08-18 Thread Greg KH
On Tue, Aug 18, 2020 at 10:56:48AM +0200, Jiri Slaby wrote: > gsm->output and ->error are set only to gsmld_output and gsm_error, > respectively. Call these functions directly and remove error and output > function pointers from struct gsm_mux completely. > > Note: we need a forward declaration of

Re: [PATCH v5 5/6] kprobes: Use text_alloc() and text_free()

2020-08-18 Thread Mike Rapoport
On Tue, Aug 18, 2020 at 08:30:29AM +0300, Jarkko Sakkinen wrote: > On Sun, Jul 26, 2020 at 11:14:08AM +0300, Mike Rapoport wrote: > > > > > > I'm not still sure that I fully understand this feedback as I don't see > > > any inherent and obvious difference to the v4. In that version fallbacks > > >

Re: [PATCH RFC v2 00/18] Add VFIO mediated device support and DEV-MSI support for the idxd driver

2020-08-18 Thread Jason Gunthorpe
On Tue, Aug 18, 2020 at 01:09:01AM +, Tian, Kevin wrote: > The difference in my reply is not just about the implementation gap > of growing a userspace DMA framework to a passthrough framework. > My real point is about the different goals that each wants to achieve. > Userspace DMA is purely ab

[PATCH -next] vdpa: Remove duplicate include

2020-08-18 Thread YueHaibing
Remove duplicate include file Signed-off-by: YueHaibing --- drivers/vhost/vdpa.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/vhost/vdpa.c b/drivers/vhost/vdpa.c index 3fab94f88894..95e2b8307a2a 100644 --- a/drivers/vhost/vdpa.c +++ b/drivers/vhost/vdpa.c @@ -22,7 +22,6 @@ #includ

Re: [PATCH v2 16/17] arm64: dts: imx8mp: Add media_blk_ctrl node

2020-08-18 Thread Dong Aisheng
On Fri, Aug 14, 2020 at 8:12 PM Abel Vesa wrote: > > Some of the features of the media_ctrl will be used by some > different drivers in a way those drivers will know best, so adding the > syscon compatible we allow those to do just that. Only the resets > and the clocks are registered bit the clk-

Re: [PATCH v2 15/17] arm64: dts: imx8mp: Add audio_blk_ctrl node

2020-08-18 Thread Dong Aisheng
On Fri, Aug 14, 2020 at 8:12 PM Abel Vesa wrote: > > Some of the features of the audio_ctrl will be used by some > different drivers in a way those drivers will know best, so adding the > syscon compatible we allow those to do just that. Only the resets > and the clocks are registered bit the clk-

[PATCH -next] phy: ti: j721e-wiz: Remove duplicate include

2020-08-18 Thread YueHaibing
Remove duplicate include file Signed-off-by: YueHaibing --- drivers/phy/ti/phy-j721e-wiz.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/phy/ti/phy-j721e-wiz.c b/drivers/phy/ti/phy-j721e-wiz.c index 33c4cf0105a4..c9cfafe89cbf 100644 --- a/drivers/phy/ti/phy-j721e-wiz.c +++ b/drivers

Re: [PATCH v2] ASoC: hdac_hdmi: support 'ELD' mixer

2020-08-18 Thread Kai Vehmanen
Hey, a general comment first. We are trying to move development to patch_hdmi, but given we still have platforms using hdac_hdmi, this patch seems like a useful addition. On Tue, 18 Aug 2020, Brent Lu wrote: > Add an binary mixer 'ELD' to each HDMI PCM device so user space > could read the ELD

[PATCH -next] vdpa/mlx5: Remove duplicate include

2020-08-18 Thread YueHaibing
Remove duplicate include file Signed-off-by: YueHaibing --- drivers/vdpa/mlx5/net/mlx5_vnet.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/vdpa/mlx5/net/mlx5_vnet.c b/drivers/vdpa/mlx5/net/mlx5_vnet.c index 9df69d5efe8c..12fb83dc1de9 100644 --- a/drivers/vdpa/mlx5/net/mlx5_vnet.c

Re: [PATCH] efi: discover ESRT table on Xen PV too

2020-08-18 Thread Marek Marczykowski-Górecki
On Mon, Aug 17, 2020 at 10:16:07AM +0200, Ard Biesheuvel wrote: > > @@ -331,7 +333,8 @@ void __init efi_esrt_init(void) > > > > end = esrt_data + size; > > pr_info("Reserving ESRT space from %pa to %pa.\n", &esrt_data, > > &end); > > - if (md.type == EFI_BOOT_SERVICES_DATA) >

[PATCH -next] mm/madvise: Remove duplicate include

2020-08-18 Thread YueHaibing
Remove duplicate header which is included twice. Signed-off-by: YueHaibing --- mm/madvise.c | 1 - 1 file changed, 1 deletion(-) diff --git a/mm/madvise.c b/mm/madvise.c index 843f6fad3b89..fda6164db356 100644 --- a/mm/madvise.c +++ b/mm/madvise.c @@ -29,7 +29,6 @@ #include #include #inclu

Re: [PATCH v2 12/17] clk: imx8mp: Add audio blk_ctrl clocks and resets

2020-08-18 Thread Dong Aisheng
On Fri, Aug 14, 2020 at 8:12 PM Abel Vesa wrote: > > Add audio blk_ctrl clocks and resets in the i.MX8MP clock > driver to be picked up by the clk-blk-ctrl driver. > > Signed-off-by: Abel Vesa > --- > drivers/clk/imx/clk-blk-ctrl.c | 4 ++ > drivers/clk/imx/clk-imx8mp.c | 138 >

Re: [PATCH 02/16] vt: declare xy for get/putconsxy properly

2020-08-18 Thread Greg KH
On Tue, Aug 18, 2020 at 10:56:52AM +0200, Jiri Slaby wrote: > That is: > 1) call the parameter 'xy' to denote what it really is, not generic 'p' > 2) tell the compiler and users that we expect an array: >* with at least 2 chars (static 2) >* which we don't modify in putconsxy (const) > > S

[PATCH] scsi: libfc: Fix passing zero to 'PTR_ERR' warning

2020-08-18 Thread YueHaibing
drivers/scsi/libfc/fc_disc.c:304 fc_disc_error() warn: passing zero to 'PTR_ERR' fc_disc_error() expect a ERR_PTR pointer, so pass ERR_PTR(err) to fix this. Signed-off-by: YueHaibing --- drivers/scsi/libfc/fc_disc.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/dri

Re: [RFC PATCH V3 04/21] mmc: core: UHS-II support, try to select UHS-II interface

2020-08-18 Thread Ulf Hansson
On Fri, 10 Jul 2020 at 13:08, Ben Chuang wrote: > > From: Ben Chuang > > The flow of "interface selection and initialization" was a bit modified > for UHS-II card. This commit follows the sequence defined in SD > specification (Part 1). > See section 7.2.3 in "UHS-II Simplified Addendum." > > Sig

[PATCH -next] mm: slab: Remove duplicate include

2020-08-18 Thread YueHaibing
Remove duplicate header which is included twice. Signed-off-by: YueHaibing --- mm/slab.h | 1 - 1 file changed, 1 deletion(-) diff --git a/mm/slab.h b/mm/slab.h index 6cc323f1313a..95e5cc1bb2a3 100644 --- a/mm/slab.h +++ b/mm/slab.h @@ -46,7 +46,6 @@ struct kmem_cache { #include #include #

[PATCH] net: Avoid strcmp current->comm with warncomm when warned >= 5

2020-08-18 Thread Miaohe Lin
We can possibly avoid strcmp warncomm with current->comm by check warned first. Signed-off-by: Miaohe Lin --- net/core/sock.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/core/sock.c b/net/core/sock.c index e4f40b175acb..51e13bc42791 100644 --- a/net/core/sock.c +++ b/

Re: [PATCH v2 11/17] clk: imx: Add blk_ctrl combo driver

2020-08-18 Thread Dong Aisheng
On Fri, Aug 14, 2020 at 8:12 PM Abel Vesa wrote: > > On i.MX8MP, there is a new type of IP which is called BLK_CTRL in > RM and usually is comprised of some GPRs that are considered too > generic to be part of any dedicated IP from that specific subsystem. > > In general, some of the GPRs have som

[RFC][PATCH v2 06/10] irq_work: Provide irq_work_queue_remote_static()

2020-08-18 Thread Peter Zijlstra
Provide the same horrible semantics provided by smp_call_function_single_async(), doing so allows skiping a bunch of atomic ops. API wise this is horrible crap as it relies on external serialization. Signed-off-by: Peter Zijlstra (Intel) --- include/linux/irq_work.h |3 ++- kernel/irq_work.

[PATCH v2 05/10] irq_work: Provide irq_work_queue_remote()

2020-08-18 Thread Peter Zijlstra
While the traditional irq_work relies on the ability to self-IPI, it makes sense to provide an unconditional irq_work_queue_remote() interface. This can be used to replace the plagued smp_call_function_single_async(). Signed-off-by: Peter Zijlstra (Intel) --- include/linux/irq_work.h | 17 +++

[RFC][PATCH v2 10/10] irq_work: Add a few comments

2020-08-18 Thread Peter Zijlstra
Signed-off-by: Peter Zijlstra (Intel) --- include/linux/irq_work.h | 80 +-- kernel/irq_work.c| 10 + 2 files changed, 80 insertions(+), 10 deletions(-) --- a/include/linux/irq_work.h +++ b/include/linux/irq_work.h @@ -4,15 +4,6 @@

[RFC][PATCH v2 08/10] smp,irq_work: Use the new irq_work API

2020-08-18 Thread Peter Zijlstra
Convert the performance sensitive users of smp_call_single_function_async() over to the new irq_work_queue_remote_static(). The new API is marginally less crap but taking these users away allows fixing up smp_call_single_function_async() without risk of performance regressions. Signed-off-by: Pet

[PATCH v2 03/10] irq_work: Optimize irq_work_single()

2020-08-18 Thread Peter Zijlstra
Trade one atomic op for a full memory barrier. Signed-off-by: Peter Zijlstra (Intel) --- include/linux/irqflags.h |8 kernel/irq_work.c| 29 + 2 files changed, 21 insertions(+), 16 deletions(-) --- a/include/linux/irqflags.h +++ b/include/linux

[PATCH v2 02/10] smp: Cleanup smp_call_function*()

2020-08-18 Thread Peter Zijlstra
Get rid of the __call_single_node union and cleanup the API a little to avoid external code relying on the structure layout as much. Signed-off-by: Peter Zijlstra (Intel) --- arch/mips/kernel/process.c |5 +-- arch/mips/kernel/smp.c | 25 +++---

[PATCH] MIPS: Loongson64: Fix build error about redeclaration of enumerator 'VIRTUAL' and "CONFIG_DM_THIN_PROVISIONING"

2020-08-18 Thread Youling Tang
After commit 39c1485c8baa (MIPS: KVM: Add kvm guestsupport for Loongson-3) Fix the following build error: drivers/md/dm-thin.c:116:2: error: redeclaration of enumerator ‘VIRTUAL’ VIRTUAL, ^ In file included from ./arch/mips/include/asm/mach-loongson64/mmzone.h:12:0, from ./ar

[RFC][PATCH v2 09/10] smp: Make smp_call_function_single_async() safer

2020-08-18 Thread Peter Zijlstra
Make smp_call_function_single_async() a safer and more convenient interface by using an atomic op for setting CSD_FLAG_LOCK. This allows safe concurrent use of this function as would be expected by the -EBUSY return value. Signed-off-by: Peter Zijlstra (Intel) --- kernel/smp.c | 28 +++

Re: [PATCH v3] sched/fair: simplfy the work when reweighting entity

2020-08-18 Thread peterz
On Tue, Aug 18, 2020 at 11:07:37AM +0200, Vincent Guittot wrote: > On Tue, 11 Aug 2020 at 13:32, Jiang Biao wrote: > > > > From: Jiang Biao > > > > The code in reweight_entity() can be simplified. > > > > For a sched entity on the rq, the entity accounting can be replaced by > > cfs_rq instantane

Re: [PATCH] char: ipmi: convert tasklets to use new tasklet_setup() API

2020-08-18 Thread Corey Minyard
On Tue, Aug 18, 2020 at 02:46:23PM +0530, Allen wrote: > > > > > > Signed-off-by: Romain Perier > > > Signed-off-by: Allen Pais > > > > This looks good to me. > > > > Reviewed-by: Corey Minyard > > > > Are you planning to push this, or do you want me to take it? If you > > want me to take it, w

[PATCH v2 00/10] smp: irq_work / smp_call_function rework

2020-08-18 Thread Peter Zijlstra
Hi, Here is a new version of the irq_work / smp_call_function integration / cleanup. I'm thinking the first (5?) patches should be ready to go in, all the dependents (i915, block) landed this merge window. The rest attempts to 'fix' smp_call_function_single_async() while migrating a number of pe

[PATCH v2 01/10] irq_work: Cleanup

2020-08-18 Thread Peter Zijlstra
Get rid of the __call_single_node union and clean up the API a little to avoid external code relying on the structure layout as much. Signed-off-by: Peter Zijlstra (Intel) --- drivers/gpu/drm/i915/i915_request.c |4 ++-- include/linux/irq_work.h| 33 +---

[RFC][PATCH v2 07/10] sched/fair: Exclude the current CPU from find_new_ilb()

2020-08-18 Thread Peter Zijlstra
It is possible for find_new_ilb() to select the current CPU, however, this only happens from newidle balancing, in which case need_resched() will be true, and consequently nohz_csd_func() will not trigger the softirq. Exclude the current CPU from becoming an ILB target. Signed-off-by: Peter Zijls

Re: [PATCH] bfq: fix blkio cgroup leakage v4

2020-08-18 Thread Дмитрий Монахов
11.08.2020, 09:43, "Dmitry Monakhov" : > Changes from v1: > - update commit description with proper ref-accounting justification Ping paolo.valente@, please take a look at the patch proposed, it works fine on our fleet. Current situation is bad, it is impossible to use bfq with cgroup bec

[PATCH v3 1/2] tty/sysrq: Extend the sysrq_key_table to cover capital letters

2020-08-18 Thread Andrzej Pietrasiewicz
All slots in sysrq_key_table[] are either used, reserved or at least commented with their intended use. This patch adds capital letter versions available, which means adding 26 more entries. For already existing SysRq operations the user presses Alt-SysRq-, and for the newly added ones Alt-Shift-S

[PATCH v3 0/2] Add configurable handler to execute a compound action

2020-08-18 Thread Andrzej Pietrasiewicz
This is a follow-up of this thread: https://www.spinics.net/lists/linux-input/msg68446.html It only touches DRM (dri-devel) in such a way that it changes the help message of sysrq_drm_fb_helper_restore_op, otherwise it is unrelated to DRM. Patch 2/2 adds a configurable handler to execute a compo

[PATCH v2 04/10] irq_work: Unconditionally build on SMP

2020-08-18 Thread Peter Zijlstra
Signed-off-by: Peter Zijlstra (Intel) --- kernel/Makefile |1 + kernel/irq_work.c |3 +++ 2 files changed, 4 insertions(+) --- a/kernel/Makefile +++ b/kernel/Makefile @@ -105,6 +105,7 @@ obj-$(CONFIG_TRACE_CLOCK) += trace/ obj-$(CONFIG_RING_BUFFER) += trace/ obj-$(CONFIG_TRACEPOINT

<    5   6   7   8   9   10   11   12   13   14   >