Re: [PATCH 0/5] bio: Direct IO: convert to pin_user_pages_fast()

2020-08-24 Thread John Hubbard
On 8/24/20 7:07 PM, Al Viro wrote: On Tue, Aug 25, 2020 at 02:54:28AM +0100, Al Viro wrote: On Fri, Aug 21, 2020 at 09:20:54PM -0700, John Hubbard wrote: Direct IO behavior: ITER_IOVEC: pin_user_pages_fast(); break; ITER_KVEC:// already elevated page

Re: [PATCH v2 02/17] dt-bindings: reset: imx8mp: Add audio blk_ctrl reset IDs

2020-08-24 Thread Rob Herring
On Fri, 14 Aug 2020 15:09:11 +0300, Abel Vesa wrote: > These will be used by the imx8mp for blk-ctrl driver. > > Signed-off-by: Abel Vesa > --- > include/dt-bindings/reset/imx8mp-reset.h | 5 + > 1 file changed, 5 insertions(+) > Acked-by: Rob Herring

Re: [PATCH v2 01/17] dt-bindings: clocks: imx8mp: Rename audiomix ids clocks to audio_blk_ctrl

2020-08-24 Thread Rob Herring
On Fri, 14 Aug 2020 15:09:10 +0300, Abel Vesa wrote: > In the reference manual the actual name is Audio BLK_CTRL. > Lets make it more obvious here by renaming from audiomix to audio_blk_ctrl. > > Signed-off-by: Abel Vesa > --- > include/dt-bindings/clock/imx8mp-clock.h | 120 >

Re: [PATCH] sched/fair: Fix wrong cpu selecting from isolated domain

2020-08-24 Thread xunlei
On 2020/8/24 PM9:38, Srikar Dronamraju wrote: > * Xunlei Pang [2020-08-24 20:30:19]: > >> We've met problems that occasionally tasks with full cpumask >> (e.g. by putting it into a cpuset or setting to full affinity) >> were migrated to our isolated cpus in production environment. >> >> After

Re: [PATCH v2 02/10] mm/memory_hotplug: enforce section granularity when onlining/offlining

2020-08-24 Thread Wei Yang
On Mon, Aug 24, 2020 at 12:39:18PM +0200, Oscar Salvador wrote: >On Wed, Aug 19, 2020 at 07:59:49PM +0200, David Hildenbrand wrote: >> Already two people (including me) tried to offline subsections, because >> the function looks like it can deal with it. But we really can only >> online/offline

Re: [PATCH V3 1/3] dt-bindings: vendor-prefixes: Add GalaxyCore

2020-08-24 Thread Rob Herring
On Fri, 14 Aug 2020 12:44:53 +0800, Xingyu Wu wrote: > From: Hao He > > Add vendor prefix for GalaxyCore, Inc. > > Signed-off-by: Hao He > Signed-off-by: Xingyu Wu > --- > Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ > 1 file changed, 2 insertions(+) > Acked-by: Rob

Re: [PATCH v5 0/3] Add Actions Semi Owl family sirq support

2020-08-24 Thread Manivannan Sadhasivam
On 23 August 2020 4:35:13 AM IST, Cristian Ciocaltea wrote: >Hi Mani, > >On Sat, Aug 22, 2020 at 06:47:12PM +0530, Manivannan Sadhasivam wrote: >> Hi Cristi, >> >> On Wed, Aug 19, 2020 at 07:37:55PM +0300, Cristian Ciocaltea wrote: >> > This patch series adds support for the external

Re: [PATCH v5 22/36] dt-bindings: host1x: Document new interconnect properties

2020-08-24 Thread Rob Herring
On Fri, 14 Aug 2020 03:06:07 +0300, Dmitry Osipenko wrote: > Most of Host1x devices have at least one memory client. These clients > are directly connected to the memory controller. The new interconnect > properties represent the memory client's connection to the memory > controller. > >

[PATCH v1 1/2] scsi: ufs: Abort tasks before clear them from doorbell

2020-08-24 Thread Can Guo
To recovery non-fatal errors, no full reset is required, err_handler only clears those pending TRs/TMRs so that scsi layer can re-issue them. In current err_handler, TRs are directly cleared from UFS host's doorbell but not aborted from device side. However, according to the UFSHCI JEDEC spec, the

Re: [PATCH v3 02/10] dt-bindings: power: supply: Add device-tree binding for Summit SMB3xx

2020-08-24 Thread Rob Herring
On Fri, 14 Aug 2020 00:34:01 +0300, Dmitry Osipenko wrote: > From: David Heidelberg > > Summit SMB3xx series is a Programmable Switching Li+ Battery Charger. > This patch adds device-tree binding for Summit SMB345, SMB347 and SMB358 > chargers. > > Signed-off-by: David Heidelberg >

Re: [PATCH 0/5] bio: Direct IO: convert to pin_user_pages_fast()

2020-08-24 Thread Al Viro
On Tue, Aug 25, 2020 at 02:54:28AM +0100, Al Viro wrote: > On Fri, Aug 21, 2020 at 09:20:54PM -0700, John Hubbard wrote: > > > Direct IO behavior: > > > > ITER_IOVEC: > > pin_user_pages_fast(); > > break; > > > > ITER_KVEC:// already elevated page refcount, leave

Re: [RFC PATCH 2/3] sched: membarrier: cover kthread_use_mm (v2)

2020-08-24 Thread Boqun Feng
On Mon, Aug 24, 2020 at 11:27:49AM -0400, Mathieu Desnoyers wrote: > - On Aug 16, 2020, at 11:29 AM, Boqun Feng boqun.f...@gmail.com wrote: > > > On Fri, Aug 14, 2020 at 12:43:57PM -0400, Mathieu Desnoyers wrote: > >> Add comments and memory barrier to kthread_use_mm and kthread_unuse_mm > >>

[PATCH v1 2/2] scsi: ufs: Handle LINERESET indication in err handler

2020-08-24 Thread Can Guo
PA Layer issues a LINERESET to the PHY at the recovery step in the Power Mode change operation. If it happens during auto or mannual hibern8 enter, even if hibern8 enter succeeds, UFS power mode shall be set to PWM-G1 mode and kept in that mode after exit from hibern8, leading to bad performance.

Re: [PATCH 0/5] bio: Direct IO: convert to pin_user_pages_fast()

2020-08-24 Thread John Hubbard
On 8/24/20 6:54 PM, Al Viro wrote: On Fri, Aug 21, 2020 at 09:20:54PM -0700, John Hubbard wrote: Direct IO behavior: ITER_IOVEC: pin_user_pages_fast(); break; ITER_KVEC:// already elevated page refcount, leave alone ITER_BVEC:// already elevated page

Re: [PATCH v2 00/13] extcon: ptn5150: Improvements and fixes

2020-08-24 Thread Ramuthevar, Vadivel MuruganX
Hi, On 24/8/2020 6:38 pm, Krzysztof Kozlowski wrote: On Mon, Aug 24, 2020 at 06:36:04PM +0800, Ramuthevar, Vadivel MuruganX wrote: Hi, Thank you for the patches and optimized the code as well. I have applied your patches and tested, it's working fine with few minor changes as per

Re: [PATCH v3 01/10] dt-bindings: battery: Add temperature properties

2020-08-24 Thread Rob Herring
On Fri, 14 Aug 2020 00:34:00 +0300, Dmitry Osipenko wrote: > Document generic battery temperature properties. > > Signed-off-by: Dmitry Osipenko > --- > .../bindings/power/supply/battery.yaml| 24 +++ > 1 file changed, 24 insertions(+) > Reviewed-by: Rob Herring

[PATCH 3/6] phy: phy-bcm-sr-usb: convert to readl_poll_timeout_atomic()

2020-08-24 Thread Chunfeng Yun
Use readl_poll_timeout_atomic() to simplify code Signed-off-by: Chunfeng Yun --- drivers/phy/broadcom/phy-bcm-sr-usb.c | 19 --- 1 file changed, 8 insertions(+), 11 deletions(-) diff --git a/drivers/phy/broadcom/phy-bcm-sr-usb.c b/drivers/phy/broadcom/phy-bcm-sr-usb.c index

[PATCH 4/6] phy: phy-qcom-apq8064-sata: convert to readl_relaxed_poll_timeout()

2020-08-24 Thread Chunfeng Yun
Use readl_relaxed_poll_timeout() to simplify code, rename local function read_poll_timeout() as poll_timeout() to avoid repeated definition Signed-off-by: Chunfeng Yun --- drivers/phy/qualcomm/phy-qcom-apq8064-sata.c | 21 - 1 file changed, 8 insertions(+), 13 deletions(-)

[PATCH 5/6] phy: phy-pxa-28nm-hsic: convert to readl_poll_timeout()

2020-08-24 Thread Chunfeng Yun
Use readl_poll_timeout() to simplify code Signed-off-by: Chunfeng Yun --- drivers/phy/marvell/phy-pxa-28nm-hsic.c | 40 - 1 file changed, 20 insertions(+), 20 deletions(-) diff --git a/drivers/phy/marvell/phy-pxa-28nm-hsic.c

[PATCH 6/6] phy: phy-pxa-28nm-usb2: convert to readl_poll_timeout()

2020-08-24 Thread Chunfeng Yun
Use readl_poll_timeout() to simplify code Signed-off-by: Chunfeng Yun --- drivers/phy/marvell/phy-pxa-28nm-usb2.c | 33 +++-- 1 file changed, 15 insertions(+), 18 deletions(-) diff --git a/drivers/phy/marvell/phy-pxa-28nm-usb2.c

Re: [Resend PATCH 1/6] mm/memcg: warning on !memcg after readahead page charged

2020-08-24 Thread Hugh Dickins
On Tue, 25 Aug 2020, Alex Shi wrote: > reproduce using our linux-mm random bug collection on NUMA systems. > >> > >> OK, I must have missed that this was on ppc. The order makes more sense > >> now. I will have a look at this next week. > > > > OK, so I've had a look and I know what's going on

[PATCH 2/6] phy: phy-bcm-ns2-usbdrd: convert to readl_poll_timeout_atomic()

2020-08-24 Thread Chunfeng Yun
Use readl_poll_timeout_atomic() to simplify code Signed-off-by: Chunfeng Yun --- drivers/phy/broadcom/phy-bcm-ns2-usbdrd.c | 13 - 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/drivers/phy/broadcom/phy-bcm-ns2-usbdrd.c b/drivers/phy/broadcom/phy-bcm-ns2-usbdrd.c

[PATCH 1/6] phy: phy-bcm-ns-usb3: convert to readl_poll_timeout_atomic()

2020-08-24 Thread Chunfeng Yun
Use readl_poll_timeout_atomic() to simplify code Signed-off-by: Chunfeng Yun --- drivers/phy/broadcom/phy-bcm-ns-usb3.c | 22 +- 1 file changed, 9 insertions(+), 13 deletions(-) diff --git a/drivers/phy/broadcom/phy-bcm-ns-usb3.c b/drivers/phy/broadcom/phy-bcm-ns-usb3.c

Re: [PATCH v2 2/2] dt-bindings: cpufreq: add bindings for MediaTek cpufreq HW

2020-08-24 Thread Rob Herring
On Thu, Aug 13, 2020 at 03:07:55PM +0800, Hector Yuan wrote: > From: "Hector.Yuan" > > Add devicetree bindings for MediaTek HW driver. > > Signed-off-by: Hector.Yuan > --- > .../bindings/cpufreq/cpufreq-mediatek-hw.yaml | 61 > > 1 file changed, 61 insertions(+) >

Re: [PATCH net-next 0/6] MAINTAINERS: Remove self from PHY LIBRARY

2020-08-24 Thread Florian Fainelli
On 8/24/2020 6:21 PM, David Miller wrote: From: Florian Fainelli Date: Mon, 24 Aug 2020 17:43:37 -0700 On 8/24/2020 4:19 PM, David Miller wrote: From: Florian Fainelli Date: Sat, 22 Aug 2020 13:11:20 -0700 Hi David, Heiner, Andrew, Russell, This patch series aims at allowing myself

[PATCH v3 6/6] kasan: update documentation for generic kasan

2020-08-24 Thread Walter Wu
Generic KASAN also supports to record the last two timer and workqueue stacks and print them in KASAN report. So that need to update documentation. Signed-off-by: Walter Wu Suggested-by: Marco Elver Cc: Andrey Ryabinin Cc: Dmitry Vyukov Cc: Alexander Potapenko Cc: Jonathan Corbet --- v3: -

[PATCH v3 5/6] kasan: add tests for workqueue stack recording

2020-08-24 Thread Walter Wu
Adds a test to verify workqueue stack recording and print it in KASAN report. The KASAN report was as follows(cleaned up slightly): BUG: KASAN: use-after-free in kasan_workqueue_uaf Freed by task 54: kasan_save_stack+0x24/0x50 kasan_set_track+0x24/0x38 kasan_set_free_info+0x20/0x40

[PATCH v3 4/6] kasan: add tests for timer stack recording

2020-08-24 Thread Walter Wu
Adds a test to verify timer stack recording and print it in KASAN report. The KASAN report was as follows(cleaned up slightly): BUG: KASAN: use-after-free in kasan_timer_uaf Freed by task 0: kasan_save_stack+0x24/0x50 kasan_set_track+0x24/0x38 kasan_set_free_info+0x20/0x40

[PATCH v3 3/6] kasan: print timer and workqueue stack

2020-08-24 Thread Walter Wu
The aux_stack[2] is reused to record the call_rcu() call stack, timer init call stack, and enqueuing work call stacks. So that we need to change the auxiliary stack title for common title, print them in KASAN report. Signed-off-by: Walter Wu Suggested-by: Marco Elver Cc: Andrey Ryabinin Cc:

[PATCH v3 1/6] timer: kasan: record timer stack

2020-08-24 Thread Walter Wu
When analyze use-after-free or double-free issue, recording the timer stacks is helpful to to preserve usage history which potentially gives a hint about the affected code. Record the most recent two timer init calls in KASAN which are printed on failure in the KASAN report. For timers it has

[PATCH v3 2/6] workqueue: kasan: record workqueue stack

2020-08-24 Thread Walter Wu
Records the last two enqueuing work call stacks in order to print them in KASAN report. It is useful for programmers to solve use-after-free or double-free memory workqueue issue. For workqueue it has turned out to be useful to record the enqueuing work call stacks. Because user can see KASAN

[PATCH v3 0/6] kasan: add workqueue and timer stack for generic KASAN

2020-08-24 Thread Walter Wu
Syzbot reports many UAF issues for workqueue or timer, see [1] and [2]. In some of these access/allocation happened in process_one_work(), we see the free stack is useless in KASAN report, it doesn't help programmers to solve UAF on workqueue. The same may stand for times. This patchset improves

Re: [PATCH v3] PCI: Add pci_iounmap

2020-08-24 Thread kernel test robot
Hi George, I love your patch! Yet something to improve: [auto build test ERROR on pci/next] [also build test ERROR on linux/master linus/master asm-generic/master v5.9-rc2 next-20200824] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we

Re: [PATCH 0/5] bio: Direct IO: convert to pin_user_pages_fast()

2020-08-24 Thread Al Viro
On Fri, Aug 21, 2020 at 09:20:54PM -0700, John Hubbard wrote: > Direct IO behavior: > > ITER_IOVEC: > pin_user_pages_fast(); > break; > > ITER_KVEC:// already elevated page refcount, leave alone > ITER_BVEC:// already elevated page refcount, leave alone >

Re: [PATCH v2] module: Harden STRICT_MODULE_RWX

2020-08-24 Thread Masahiro Yamada
On Tue, Aug 25, 2020 at 12:24 AM Jessica Yu wrote: > > +++ Ard Biesheuvel [22/08/20 15:47 +0200]: > >(+ Masahiro) > > > >On Fri, 21 Aug 2020 at 14:30, Will Deacon wrote: > >> > >> On Fri, Aug 21, 2020 at 02:27:05PM +0200, Ard Biesheuvel wrote: > >> > On Fri, 21 Aug 2020 at 14:20, Will Deacon

Re: [PATCH v18 00/32] per memcg lru_lock

2020-08-24 Thread Daniel Jordan
On Mon, Aug 24, 2020 at 01:24:20PM -0700, Hugh Dickins wrote: > On Mon, 24 Aug 2020, Andrew Morton wrote: > > On Mon, 24 Aug 2020 20:54:33 +0800 Alex Shi > > wrote: > Andrew demurred on version 17 for lack of review. Alexander Duyck has > been doing a lot on that front since then. I have

Re: [RFC PATCH v2 0/3] mikroBUS driver for add-on boards

2020-08-24 Thread Frank Rowand
Hi Vaishnav, Apologies in advance -- I expect to be very slow in responding this week. Linux Plumbers will take some of my time and I am moving to a new home. -Frank On 2020-08-18 15:38, Frank Rowand wrote: > Hi Vaishnav, > > +me +devicetree > > Please add these two recipients to future

Re: [RESEND 1/3] venus: core: handle race condititon for core ops

2020-08-24 Thread mansur
On 2020-08-21 16:29, Stanimir Varbanov wrote: Hi Mansur, On 8/10/20 12:50 PM, Stanimir Varbanov wrote: Hi Mansur, Thanks for the patches! On 8/7/20 9:24 AM, Mansur Alisha Shaik wrote: For core ops we are having only write protect but there is no read protect, because of this in

linux-next: manual merge of the amdgpu tree with Linus' tree

2020-08-24 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the amdgpu tree got a conflict in: drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c between commit: 3b2e973dff59 ("drm/amd/display: add dmcub check on RENOIR") from Linus' tree and commit: 4a580877bdcb ("drm/amdgpu: Get DRM dev from adev by

Re: [PATCH 8/9] iomap: Convert iomap_write_end types

2020-08-24 Thread Dave Chinner
On Tue, Aug 25, 2020 at 02:06:05AM +0100, Matthew Wilcox wrote: > On Tue, Aug 25, 2020 at 10:12:23AM +1000, Dave Chinner wrote: > > > -static int > > > -__iomap_write_end(struct inode *inode, loff_t pos, unsigned len, > > > - unsigned copied, struct page *page) > > > +static size_t

Re: linux-next: manual merge of the reset tree with the kspp-gustavo tree

2020-08-24 Thread Stephen Rothwell
Hi all, On Wed, 19 Aug 2020 10:28:19 +1000 Stephen Rothwell wrote: > > Today's linux-next merge of the reset tree got a conflict in: > > drivers/reset/reset-imx7.c > > between commit: > > 58e813cceabd ("treewide: Use fallthrough pseudo-keyword") > > from the kspp-gustavo tree and

Re: [PATCH v2] mm : sync ra->ra_pages with bdi->ra_pages

2020-08-24 Thread Zhaoyang Huang
On Fri, Aug 21, 2020 at 7:57 PM Matthew Wilcox wrote: > > On Fri, Aug 21, 2020 at 05:31:52PM +0800, Zhaoyang Huang wrote: > > This patch has been verified on an android system and reduces 15% of > > UNITERRUPTIBLE_SLEEP_BLOCKIO which was used to be caused by wrong > > ra->ra_pages. > > Wait,

[PATCH v2] soundwire: intel: fix intel_suspend/resume defined but not used warning

2020-08-24 Thread Bard Liao
When CONFIG_PM_SLEEP is not defined, GCC throws compilation warnings: drivers/soundwire/intel.c:1799:12: warning: ‘intel_resume’ defined but not used [-Wunused-function] static int intel_resume(struct device *dev) ^~~~ drivers/soundwire/intel.c:1683:12: warning:

Re: [Resend PATCH 1/6] mm/memcg: warning on !memcg after readahead page charged

2020-08-24 Thread Alex Shi
reproduce using our linux-mm random bug collection on NUMA systems. >> >> OK, I must have missed that this was on ppc. The order makes more sense >> now. I will have a look at this next week. > > OK, so I've had a look and I know what's going on there. The > move_pages12 is migrating hugetlb

Re: linux-next: build failure after merge of the bpf-next tree

2020-08-24 Thread Alexei Starovoitov
On Mon, Aug 24, 2020 at 6:20 PM Stephen Rothwell wrote: > > Hi all, > > On Fri, 21 Aug 2020 11:11:11 +1000 Stephen Rothwell > wrote: > > > > Hi all, > > > > After merging the bpf-next tree, today's linux-next build (x86_64 > > allmodconfig) failed like this: > > > > Auto-detecting system

Re: [PATCH net-next 0/6] MAINTAINERS: Remove self from PHY LIBRARY

2020-08-24 Thread David Miller
From: Florian Fainelli Date: Mon, 24 Aug 2020 17:43:37 -0700 > > > On 8/24/2020 4:19 PM, David Miller wrote: >> From: Florian Fainelli >> Date: Sat, 22 Aug 2020 13:11:20 -0700 >> >>> Hi David, Heiner, Andrew, Russell, >>> >>> This patch series aims at allowing myself to keep track of the >>>

Re: linux-next: build failure after merge of the bpf-next tree

2020-08-24 Thread Stephen Rothwell
Hi all, On Fri, 21 Aug 2020 11:11:11 +1000 Stephen Rothwell wrote: > > Hi all, > > After merging the bpf-next tree, today's linux-next build (x86_64 > allmodconfig) failed like this: > > Auto-detecting system features: > ...libelf: [ OFF ] > ...

[PATCH v2] fs/ceph: use pipe_get_pages_alloc() for pipe

2020-08-24 Thread John Hubbard
This reduces, by one, the number of callers of iov_iter_get_pages(). That's helpful because these calls are being audited and converted over to use iov_iter_pin_user_pages(), where applicable. And this one here is already known by the caller to be only for ITER_PIPE, so let's just simplify it now.

Re: [PATCH] net: Use helper macro RT_TOS() in __icmp_send()

2020-08-24 Thread David Miller
From: Miaohe Lin Date: Mon, 24 Aug 2020 07:44:37 -0400 > Use helper macro RT_TOS() to get tos in __icmp_send(). > > Signed-off-by: Miaohe Lin Applied to net-next, thanks.

Re: [PATCH] net: Avoid access icmp_err_convert when icmp code is ICMP_FRAG_NEEDED

2020-08-24 Thread David Miller
From: Miaohe Lin Date: Mon, 24 Aug 2020 07:15:04 -0400 > There is no need to fetch errno and fatal info from icmp_err_convert when > icmp code is ICMP_FRAG_NEEDED. > > Signed-off-by: Miaohe Lin Applied to net-next, thanks.

Re: [net-next v4] seg6: using DSCP of inner IPv4 packets

2020-08-24 Thread David Miller
From: Ahmed Abdelsalam Date: Mon, 24 Aug 2020 08:51:24 + > This patch allows copying the DSCP from inner IPv4 header to the > outer IPv6 header, when doing SRv6 Encapsulation. > > This allows forwarding packet across the SRv6 fabric based on their > original traffic class. > >

Re: [PATCH 8/9] iomap: Convert iomap_write_end types

2020-08-24 Thread Matthew Wilcox
On Tue, Aug 25, 2020 at 10:12:23AM +1000, Dave Chinner wrote: > > -static int > > -__iomap_write_end(struct inode *inode, loff_t pos, unsigned len, > > - unsigned copied, struct page *page) > > +static size_t __iomap_write_end(struct inode *inode, loff_t pos, size_t > > len, > > +

Re: [PATCH] net: ocelot: Add of_node_put() before return statement

2020-08-24 Thread David Miller
From: Sumera Priyadarsini Date: Sun, 23 Aug 2020 19:22:45 +0530 > Every iteration of for_each_available_child_of_node() decrements > the reference count of the previous node, however when control > is transferred from the middle of the loop, as in the case of > a return or break or goto, there

Re: [PATCH] firestream: Fix memleak in fs_open

2020-08-24 Thread David Miller
From: Dinghao Liu Date: Sun, 23 Aug 2020 19:29:35 +0800 > When make_rate() fails, vcc should be freed just > like other error paths in fs_open(). > > Signed-off-by: Dinghao Liu Applied, thank you.

RE: [PATCH v2 1/3] platform/x86: Add Intel Input Output Manager (IOM) driver

2020-08-24 Thread Mani, Rajmohan
Hi Prashant, ... > > > > + > > > > + reg = iom->regbar + IOM_PORT_STATUS_OFFSET + IOM_REG_LEN * > > > port; > > > > + > > > > + *status = ioread32(reg); > > > > > > Perhaps just inline reg within the parentheses? > > > > Kept this way to increase readability. Let me know if you feel

Re: [PATCH bpf-next v1 6/8] bpf: Introduce bpf_per_cpu_ptr()

2020-08-24 Thread Hao Luo
On Sat, Aug 22, 2020 at 12:55 AM Andrii Nakryiko wrote: > > On Sat, Aug 22, 2020 at 12:49 AM Hao Luo wrote: > > > > On Fri, Aug 21, 2020 at 8:31 PM Andrii Nakryiko > > wrote: > > > > > > On Fri, Aug 21, 2020 at 8:26 PM Andrii Nakryiko > > > wrote: > > > > > > > > On Wed, Aug 19, 2020 at 3:42

RE: [PATCH v2 0/5] cpufreq: intel_pstate: Address some HWP-related oddities

2020-08-24 Thread Doug Smythies
Hi Srinivas, I think there is a disconnect between your written description of what is going on and your supporting MSR reads. On 2020.08.24 16:56 Srinivas Pandruvada wrote: > On Mon, 2020-08-24 at 19:39 +0200, Rafael J. Wysocki wrote: > > Hi All, > > > > The v2 is here to address feedback from

Re: [PATCH] net: arc_emac: Fix memleak in arc_mdio_probe

2020-08-24 Thread David Miller
From: Dinghao Liu Date: Sun, 23 Aug 2020 16:56:47 +0800 > When devm_gpiod_get_optional() fails, bus should be > freed just like when of_mdiobus_register() fails. > > Fixes: 1bddd96cba03d ("net: arc_emac: support the phy reset for emac driver") > Signed-off-by: Dinghao Liu Applied, thank you.

Re: [PATCH v2 1/2] KVM: LAPIC: Return 0 when getting the tscdeadline timer if the lapic is hw disabled

2020-08-24 Thread Sean Christopherson
On Wed, Aug 12, 2020 at 02:30:37PM +0800, Wanpeng Li wrote: > From: Wanpeng Li > > Return 0 when getting the tscdeadline timer if the lapic is hw disabled. > > Suggested-by: Paolo Bonzini > Signed-off-by: Wanpeng Li > --- Reviewed-by: Sean Christopherson

Re: [PATCH v2 2/2] KVM: LAPIC: Guarantee the timer is in tsc-deadline mode when setting

2020-08-24 Thread Sean Christopherson
On Wed, Aug 12, 2020 at 02:30:38PM +0800, Wanpeng Li wrote: > From: Wanpeng Li > > Check apic_lvtt_tscdeadline() mode directly instead of apic_lvtt_oneshot() > and apic_lvtt_period() to guarantee the timer is in tsc-deadline mode when > wrmsr MSR_IA32_TSCDEADLINE. > > Signed-off-by: Wanpeng Li

[GIT PULL] libnvdimm fixes for v5.9-rc3

2020-08-24 Thread Verma, Vishal L
Hi Linus, please pull from: git://git.kernel.org/pub/scm/linux/kernel/git/nvdimm/nvdimm.git tags/libnvdimm-fix-v5.9-rc3 ...to receive a couple of minor fixes for things merged in 5.9-rc1. One is an out-of-bounds access caught by KASAN, and the second is a tweak to some overzealous logging about

Re: [PATCH] chelsio: switch from 'pci_' to 'dma_' API

2020-08-24 Thread David Miller
From: Christophe JAILLET Date: Sun, 23 Aug 2020 10:36:48 +0200 > The wrappers in include/linux/pci-dma-compat.h should go away. > > The patch has been generated with the coccinelle script below and has been > hand modified to replace GFP_ with a correct flag. > It has been compile tested. > >

Re: [PATCH bpf-next v9 4/7] bpf: Split bpf_local_storage to bpf_sk_storage

2020-08-24 Thread Martin KaFai Lau
On Sun, Aug 23, 2020 at 06:56:09PM +0200, KP Singh wrote: > From: KP Singh > > A purely mechanical change: > > bpf_sk_storage.c = bpf_sk_storage.c + bpf_local_storage.c > bpf_sk_storage.h = bpf_sk_storage.h + bpf_local_storage.h > > Signed-off-by: KP Singh Acked-by: Martin KaFai

Re: [PATCH bpf-next v9 3/7] bpf: Generalize bpf_sk_storage

2020-08-24 Thread Martin KaFai Lau
On Sun, Aug 23, 2020 at 06:56:08PM +0200, KP Singh wrote: > From: KP Singh > > Refactor the functionality in bpf_sk_storage.c so that concept of > storage linked to kernel objects can be extended to other objects like > inode, task_struct etc. > > Each new local storage will still be a separate

[PATCH v4 0/2] Expose new feature for Intel processor

2020-08-24 Thread Cathy Zhang
This patchset is to introduce TSX suspend load tracking feature and expose it to KVM CPUID for processors which support it. KVM reports this information and guests can make use of it finally. Detailed information on the instruction and CPUID feature flag can be found in the latest "extensions"

[PATCH v4 2/2] x86/kvm: Expose TSX Suspend Load Tracking feature

2020-08-24 Thread Cathy Zhang
TSX suspend load tracking instruction is supported by Intel processor, Sapphire Rapids. It aims to give a way to choose which memory accesses do not need to be tracked in the TSX read set. It's availability is indicated as CPUID.(EAX=7,ECX=0):EDX[bit 16]. Expose TSX Suspend Load Address Tracking

[PATCH v4 1/2] x86/cpufeatures: Enumerate TSX suspend load address tracking instructions

2020-08-24 Thread Cathy Zhang
From: Kyung Min Park Intel TSX suspend load tracking instructions aim to give a way to choose which memory accesses do not need to be tracked in the TSX read set. Add TSX suspend load tracking CPUID feature flag TSXLDTRK for enumeration. A processor supports Intel TSX suspend load address

Re: [PATCH bpf-next v9 5/7] bpf: Implement bpf_local_storage for inodes

2020-08-24 Thread Martin KaFai Lau
On Sun, Aug 23, 2020 at 06:56:10PM +0200, KP Singh wrote: > From: KP Singh > > Similar to bpf_local_storage for sockets, add local storage for inodes. > The life-cycle of storage is managed with the life-cycle of the inode. > i.e. the storage is destroyed along with the owning inode. > > The

Re: general protection fault in security_inode_getattr

2020-08-24 Thread Yonghong Song
On 8/24/20 5:32 PM, syzbot wrote: syzbot has bisected this issue to: commit 35697c12d7ffd31a56d3c9604066a166b75d0169 Author: Yonghong Song Date: Thu Jan 16 17:40:04 2020 + selftests/bpf: Fix test_progs send_signal flakiness with nmi mode The above patch changed file:

Re: [REGRESSION] x86/cpu fsgsbase breaks TLS in 32 bit rr tracees on a 64 bit system

2020-08-24 Thread Kyle Huey
On Mon, Aug 24, 2020 at 5:31 PM Andy Lutomirski wrote: > > On Mon, Aug 24, 2020 at 4:52 PM H. Peter Anvin wrote: > > > > On 2020-08-24 14:10, Andy Lutomirski wrote: > > > > > > PTRACE_READ_SEGMENT_DESCRIPTOR to read a segment descriptor. > > > > > > PTRACE_SET_FS / PTRACE_SET_GS: Sets FS or GS

linux-next: build warning after merge of the btrfs tree

2020-08-24 Thread Stephen Rothwell
uot;Merge branch 'ext/nikbor/seed-cleanups-v2' into for-next-next-v5.9-20200824") which should have removed the declaration. -- Cheers, Stephen Rothwell pgpx6zCBW4KbW.pgp Description: OpenPGP digital signature

Re: [PATCH bpf-next v1 1/8] bpf: Introduce pseudo_btf_id

2020-08-24 Thread Yonghong Song
On 8/24/20 5:05 PM, Hao Luo wrote: Yonghong, An update on this thread. I successfully reproduced this issue on a 8.2.0 gcc compiler, It looks like gcc 4.9 did not have this issue. I was also using clang which did not show this bug. It seems having a DW_AT_specification that refers to

Re: [PATCH net-next 0/6] MAINTAINERS: Remove self from PHY LIBRARY

2020-08-24 Thread Florian Fainelli
On 8/24/2020 4:19 PM, David Miller wrote: From: Florian Fainelli Date: Sat, 22 Aug 2020 13:11:20 -0700 Hi David, Heiner, Andrew, Russell, This patch series aims at allowing myself to keep track of the Ethernet PHY and MDIO bus drivers that I authored or contributed to without being listed

Re: [PATCH] iomap: Fix the write_count in iomap_add_to_ioend().

2020-08-24 Thread Dave Chinner
On Mon, Aug 24, 2020 at 11:48:41AM -0400, Brian Foster wrote: > On Mon, Aug 24, 2020 at 04:04:17PM +0100, Christoph Hellwig wrote: > > On Mon, Aug 24, 2020 at 10:28:23AM -0400, Brian Foster wrote: > > > Do I understand the current code (__bio_try_merge_page() -> > > > page_is_mergeable())

Re: [PATCH v5] kernel/trace: Add DISALLOW_TRACE_PRINTK make option

2020-08-24 Thread Nicolas Boichat
On Mon, Aug 24, 2020 at 9:30 PM Steven Rostedt wrote: > > On Mon, 24 Aug 2020 10:59:13 +0800 > Nicolas Boichat wrote: > > > --- > > > > +ifeq ($(KBUILD_DISALLOW_TRACE_PRINTK),1) > > +KBUILD_CFLAGS += -DDISALLOW_TRACE_PRINTK > > +endif > > + > > KBUILD_CFLAGS += $(DEBUG_CFLAGS) > > export

Re: [PATCH v11 25/25] x86/cet/shstk: Add arch_prctl functions for shadow stack

2020-08-24 Thread Andy Lutomirski
On Mon, Aug 24, 2020 at 5:30 PM Yu-cheng Yu wrote: > arch_prctl(ARCH_X86_CET_MMAP_SHSTK, u64 *args) > Allocate a new shadow stack. > > The parameter 'args' is a pointer to a user buffer. > > *args = desired size > *(args + 1) = MAP_32BIT or MAP_POPULATE > > On returning,

Re: [PATCH v2] usb: storage: initialize variable

2020-08-24 Thread Alan Stern
On Mon, Aug 24, 2020 at 02:31:01PM -0700, Tom Rix wrote: > > On 8/24/20 2:18 PM, Vito Caputo wrote: > > On Mon, Aug 24, 2020 at 02:10:27PM -0700, t...@redhat.com wrote: > >> From: Tom Rix > >> > >> clang static analysis reports this representative problem > >> > >> transport.c:495:15: warning:

Re: [PATCH] NFC: st95hf: Fix memleak in st95hf_in_send_cmd

2020-08-24 Thread David Miller
From: Dinghao Liu Date: Sun, 23 Aug 2020 15:23:43 +0800 > When down_killable() fails, skb_resp should be freed > just like when st95hf_spi_send() fails. > > Signed-off-by: Dinghao Liu Applied, thank you.

Re: [PATCH v2] usb: storage: initialize variable

2020-08-24 Thread Alan Stern
On Mon, Aug 24, 2020 at 02:18:39PM -0700, Vito Caputo wrote: > On Mon, Aug 24, 2020 at 02:10:27PM -0700, t...@redhat.com wrote: > > From: Tom Rix > > > > clang static analysis reports this representative problem > > > > transport.c:495:15: warning: Assigned value is garbage or > > undefined >

[PATCH v11 02/25] x86/cpufeatures: Add CET CPU feature flags for Control-flow Enforcement Technology (CET)

2020-08-24 Thread Yu-cheng Yu
Add CPU feature flags for Control-flow Enforcement Technology (CET). CPUID.(EAX=7,ECX=0):ECX[bit 7] Shadow stack CPUID.(EAX=7,ECX=0):EDX[bit 20] Indirect Branch Tracking Signed-off-by: Yu-cheng Yu Reviewed-by: Borislav Petkov Reviewed-by: Kees Cook --- arch/x86/include/asm/cpufeatures.h | 2

Re: [PATCH] net: atheros: switch from 'pci_' to 'dma_' API

2020-08-24 Thread David Miller
From: Christophe JAILLET Date: Sun, 23 Aug 2020 10:03:53 +0200 > The wrappers in include/linux/pci-dma-compat.h should go away. > > The patch has been generated with the coccinelle script below and has been > hand modified to replace GFP_ with a correct flag. > It has been compile tested. > >

Re: [PATCH] typhoon: switch from 'pci_' to 'dma_' API

2020-08-24 Thread David Miller
From: Christophe JAILLET Date: Sun, 23 Aug 2020 08:11:50 +0200 > The wrappers in include/linux/pci-dma-compat.h should go away. > > The patch has been generated with the coccinelle script below and has been > hand modified to replace GFP_ with a correct flag. > It has been compile tested. > >

Re: [PATCH] starfire: switch from 'pci_' to 'dma_' API

2020-08-24 Thread David Miller
From: Christophe JAILLET Date: Sun, 23 Aug 2020 08:26:41 +0200 > The wrappers in include/linux/pci-dma-compat.h should go away. > > The patch has been generated with the coccinelle script below and has been > hand modified to replace GFP_ with a correct flag. > It has been compile tested. > >

Re: [PATCH v11 8/9] x86/vdso: Insert endbr32/endbr64 to vDSO

2020-08-24 Thread Andy Lutomirski
On Mon, Aug 24, 2020 at 5:30 PM Yu-cheng Yu wrote: > > From: "H.J. Lu" > > When Indirect Branch Tracking (IBT) is enabled, vDSO functions may be > called indirectly, and must have ENDBR32 or ENDBR64 as the first > instruction. The compiler must support -fcf-protection=branch so that it > can be

[PATCH v11 04/25] x86/cet: Add control-protection fault handler

2020-08-24 Thread Yu-cheng Yu
A control-protection fault is triggered when a control-flow transfer attempt violates Shadow Stack or Indirect Branch Tracking constraints. For example, the return address for a RET instruction differs from the copy on the Shadow Stack; or an indirect JMP instruction, without the NOTRACK prefix,

[PATCH] arm64: dts: qcom: sc7180-trogdor: add initial trogdor and lazor dt

2020-08-24 Thread Rob Clark
From: Rob Clark This is essentialy a squash of a bunch of history of trogdor and lazor dt updates from the chromium kernel tree. I don't claim any credit other than wanting to more easily boot upstream kernel on these devices. I've tried to add cc tags for all the original authors. Cc:

Re: [PATCH] ftrace: Fixup lockdep assert held of text_mutex

2020-08-24 Thread Palmer Dabbelt
On Thu, 13 Aug 2020 08:37:43 PDT (-0700), rost...@goodmis.org wrote: On Wed, 12 Aug 2020 22:13:19 -0700 (PDT) Palmer Dabbelt wrote: Sorry, I'm not really sure what's going on here. I'm not really seeing code that matches this in our port right now, so maybe this is aginst some other tree?

[PATCH v11 03/25] x86/fpu/xstate: Introduce CET MSR XSAVES supervisor states

2020-08-24 Thread Yu-cheng Yu
Control-flow Enforcement Technology (CET) adds five MSRs. Introduce them and their XSAVES supervisor states: MSR_IA32_U_CET (user-mode CET settings), MSR_IA32_PL3_SSP (user-mode Shadow Stack pointer), MSR_IA32_PL0_SSP (kernel-mode Shadow Stack pointer), MSR_IA32_PL1_SSP

[PATCH v11 00/25] Control-flow Enforcement: Shadow Stack

2020-08-24 Thread Yu-cheng Yu
Control-flow Enforcement (CET) is a new Intel processor feature that blocks return/jump-oriented programming attacks. Details are in "Intel 64 and IA-32 Architectures Software Developer's Manual" [1]. CET can protect applications and the kernel. This series enables only application-level

[PATCH v11 09/25] drm/i915/gvt: Change _PAGE_DIRTY to _PAGE_DIRTY_BITS

2020-08-24 Thread Yu-cheng Yu
After the introduction of _PAGE_COW, a modified page's PTE can have either _PAGE_DIRTY_HW or _PAGE_COW. Change _PAGE_DIRTY to _PAGE_DIRTY_BITS. Signed-off-by: Yu-cheng Yu Reviewed-by: Kees Cook Cc: David Airlie Cc: Joonas Lahtinen Cc: Jani Nikula Cc: Daniel Vetter Cc: Rodrigo Vivi Cc:

[PATCH v11 14/25] x86/mm: Update maybe_mkwrite() for shadow stack

2020-08-24 Thread Yu-cheng Yu
Shadow stack memory is writable, but its VMA has VM_SHSTK instead of VM_WRITE. Update maybe_mkwrite() to include the shadow stack. Signed-off-by: Yu-cheng Yu --- arch/x86/Kconfig| 4 arch/x86/mm/pgtable.c | 18 ++ include/linux/mm.h | 2 ++

[PATCH v11 05/25] x86/cet/shstk: Add Kconfig option for user-mode Shadow Stack

2020-08-24 Thread Yu-cheng Yu
Shadow Stack provides protection against function return address corruption. It is active when the processor supports it, the kernel has CONFIG_X86_INTEL_SHADOW_STACK_USER, and the application is built for the feature. This is only implemented for the 64-bit kernel. When it is enabled, legacy

[PATCH v11 11/25] x86/mm: Update ptep_set_wrprotect() and pmdp_set_wrprotect() for transition from _PAGE_DIRTY_HW to _PAGE_COW

2020-08-24 Thread Yu-cheng Yu
When shadow stack is introduced, [R/O + _PAGE_DIRTY_HW] PTE is reserved for shadow stack. Copy-on-write PTEs have [R/O + _PAGE_COW]. When a PTE goes from [R/W + _PAGE_DIRTY_HW] to [R/O + _PAGE_COW], it could become a transient shadow stack PTE in two cases: The first case is that some

[PATCH v11 07/25] x86/mm: Remove _PAGE_DIRTY_HW from kernel RO pages

2020-08-24 Thread Yu-cheng Yu
Kernel read-only PTEs are setup as _PAGE_DIRTY_HW. Since these become shadow stack PTEs, remove the dirty bit. Signed-off-by: Yu-cheng Yu Cc: "H. Peter Anvin" Cc: Kees Cook Cc: Thomas Gleixner Cc: Dave Hansen Cc: Christoph Hellwig Cc: Andy Lutomirski Cc: Ingo Molnar Cc: Borislav Petkov

[PATCH v11 13/25] x86/mm: Shadow Stack page fault error checking

2020-08-24 Thread Yu-cheng Yu
Shadow stack accesses are those that are performed by the CPU where it expects to encounter a shadow stack mapping. These accesses are performed implicitly by CALL/RET at the site of the shadow stack pointer. These accesses are made explicitly by shadow stack management instructions like WRUSSQ.

Re: [PATCH v11 9/9] x86: Disallow vsyscall emulation when CET is enabled

2020-08-24 Thread Andy Lutomirski
On Mon, Aug 24, 2020 at 5:30 PM Yu-cheng Yu wrote: > > From: "H.J. Lu" > > Emulation of the legacy vsyscall page is required by some programs built > before 2013. Newer programs after 2013 don't use it. Disallow vsyscall > emulation when Control-flow Enforcement (CET) is enabled to enhance >

[PATCH v11 5/9] x86/cet/ibt: Update arch_prctl functions for Indirect Branch Tracking

2020-08-24 Thread Yu-cheng Yu
From: "H.J. Lu" Update ARCH_X86_CET_STATUS and ARCH_X86_CET_DISABLE for Indirect Branch Tracking. Signed-off-by: H.J. Lu Signed-off-by: Yu-cheng Yu --- arch/x86/kernel/cet_prctl.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/arch/x86/kernel/cet_prctl.c

[PATCH v11 8/9] x86/vdso: Insert endbr32/endbr64 to vDSO

2020-08-24 Thread Yu-cheng Yu
From: "H.J. Lu" When Indirect Branch Tracking (IBT) is enabled, vDSO functions may be called indirectly, and must have ENDBR32 or ENDBR64 as the first instruction. The compiler must support -fcf-protection=branch so that it can be used to compile vDSO. Signed-off-by: H.J. Lu Signed-off-by:

[PATCH v11 4/9] x86/cet/ibt: ELF header parsing for Indirect Branch Tracking

2020-08-24 Thread Yu-cheng Yu
Update arch_setup_elf_property() for Indirect Branch Tracking. Signed-off-by: Yu-cheng Yu --- v9: - Change cpu_feature_enabled() to static_cpu_has(). arch/x86/Kconfig | 2 ++ arch/x86/kernel/process_64.c | 8 2 files changed, 10 insertions(+) diff --git a/arch/x86/Kconfig

Re: general protection fault in security_inode_getattr

2020-08-24 Thread syzbot
syzbot has bisected this issue to: commit 35697c12d7ffd31a56d3c9604066a166b75d0169 Author: Yonghong Song Date: Thu Jan 16 17:40:04 2020 + selftests/bpf: Fix test_progs send_signal flakiness with nmi mode bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=1303213990

<    1   2   3   4   5   6   7   8   9   10   >