Re: [PATCH bpf-next v4 07/30] bpf: refine memcg-based memory accounting for devmap maps

2020-08-26 Thread Shakeel Butt
On Fri, Aug 21, 2020 at 8:18 AM Roman Gushchin wrote: > > Include map metadata and the node size (struct bpf_dtab_netdev) on > element update into the accounting. > > Signed-off-by: Roman Gushchin > Acked-by: Song Liu Reviewed-by: Shakeel Butt

Re: [PATCH] block: convert tasklets to use new tasklet_setup() API

2020-08-26 Thread Allen
On Wed, Aug 26, 2020 at 8:43 PM Kees Cook wrote: > > On Wed, Aug 26, 2020 at 12:55:28PM +0300, Dan Carpenter wrote: > > On Wed, Aug 26, 2020 at 07:21:35AM +0530, Allen Pais wrote: > > > On Thu, Aug 20, 2020 at 3:09 AM James Bottomley > > > wrote: > > > > > > > > On Wed, 2020-08-19 at 21:54

Re: Is: virtio_gpu_object_shmem_init issues? Was:Re: upstream boot error: general protection fault in swiotlb_map

2020-08-26 Thread Thomas Tai
Hello, I had a similiar panic when booting an ARM VM with kernel v5.9-rc1. git bisect identified following bad commit. After reverting the bad commit, the VM boot ok. Maybe we should look into the following commit. d323bb44e4d23802eb25d13de1f93f2335bd60d0 is the first bad commit commit

[PATCH] linux/kernel.h: add container_from()

2020-08-26 Thread Allen Pais
Introduce container_from() as a generic helper instead of sub-systems defining a private from_* API (Eg: from_tasklets recently introduced in 12cc923f1ccc: Tasklet: Introduce new initialization API) The helper is similar to container_of() in argument order with the difference of naming the

Re: [PATCH] drm/vkms: fix warning in vkms_get_vblank_timestamp

2020-08-26 Thread Sidong Yang
On Wed, Aug 26, 2020 at 05:49:54PM -0300, Melissa Wen wrote: Hi Melissa! Thanks for review. > Hi Sidong, > > Thanks for this patch. > > The code looks good to me; however, I see some issues in the patch > format and commit message. Please, see inline comments. > > On 08/25, Sidong Yang wrote:

Re: [PATCH v2 1/2] IB/qib: remove superfluous fallthrough statements

2020-08-26 Thread Gustavo A. R. Silva
On Wed, Aug 26, 2020 at 09:11:49PM -0300, Jason Gunthorpe wrote: > On Wed, Aug 26, 2020 at 02:18:59PM -0500, Gustavo A. R. Silva wrote: > > Hi, > > > > On Tue, Aug 25, 2020 at 02:33:27PM -0500, Gustavo A. R. Silva wrote: > > > On Tue, Aug 25, 2020 at 06:12:42PM +0100, Alex Dewar wrote: > > > >

Re: [PATCH bpf-next v4 06/30] bpf: memcg-based memory accounting for cgroup storage maps

2020-08-26 Thread Shakeel Butt
On Fri, Aug 21, 2020 at 8:17 AM Roman Gushchin wrote: > > Account memory used by cgroup storage maps including the percpu memory > for the percpu flavor of cgroup storage and map metadata. > > Signed-off-by: Roman Gushchin > Acked-by: Song Liu Reviewed-by: Shakeel Butt

Re: [PATCH v2 03/11] sched,idle,rcu: Push rcu_idle deeper into the idle path

2020-08-26 Thread Joel Fernandes
On Wed, Aug 26, 2020 at 09:18:26PM -0400, Joel Fernandes wrote: > On Fri, Aug 21, 2020 at 10:47:41AM +0200, Peter Zijlstra wrote: > > Lots of things take locks, due to a wee bug, rcu_lockdep didn't notice > > that the locking tracepoints were using RCU. > > > > Push rcu_idle_{enter,exit}() as

Re: [PATCH bpf-next v4 05/30] bpf: refine memcg-based memory accounting for cpumap maps

2020-08-26 Thread Shakeel Butt
On Fri, Aug 21, 2020 at 8:11 AM Roman Gushchin wrote: > > Include metadata and percpu data into the memcg-based memory accounting. > > Signed-off-by: Roman Gushchin > Acked-by: Song Liu Reviewed-by: Shakeel Butt

Re: [RFC PATCH 00/16] Core scheduling v6

2020-08-26 Thread Vineeth Pillai
Hi Alex, > > As discussed during Linux Plumbers, here is a small repo with test > scripts and applications that I've used to look at core scheduling > unfairness: > >https://github.com/agraf/schedgaps > Thanks for sharing :). > Please let me know if it's unclear how to use it or if you see

Re: [PATCH bpf-next v4 04/30] bpf: refine memcg-based memory accounting for arraymap maps

2020-08-26 Thread Shakeel Butt
On Fri, Aug 21, 2020 at 8:11 AM Roman Gushchin wrote: > > Include percpu arrays and auxiliary data into the memcg-based memory > accounting. > > Signed-off-by: Roman Gushchin > Acked-by: Song Liu > --- > kernel/bpf/arraymap.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > >

Re: [PATCH v2 03/11] sched,idle,rcu: Push rcu_idle deeper into the idle path

2020-08-26 Thread Joel Fernandes
On Fri, Aug 21, 2020 at 10:47:41AM +0200, Peter Zijlstra wrote: > Lots of things take locks, due to a wee bug, rcu_lockdep didn't notice > that the locking tracepoints were using RCU. > > Push rcu_idle_{enter,exit}() as deep as possible into the idle paths, > this also resolves a lot of

Re: [PATCH 1/2] usb typec: mt6360: Add support for mt6360 Type-C driver

2020-08-26 Thread 啟原黃
Guenter Roeck 於 2020年8月27日 週四 上午9:02寫道: > > On 8/26/20 5:59 PM, 啟原黃 wrote: > [ ... ] > >>> +static int mt6360_tcpc_remove(struct platform_device *pdev) > >>> +{ > >>> + struct mt6360_tcpc_info *mti = platform_get_drvdata(pdev); > >>> + > >>> + tcpci_unregister_port(mti->tcpci); > >> > >>

Re: KASAN: use-after-free Write in afs_manage_cell

2020-08-26 Thread syzbot
syzbot has bisected this issue to: commit c99c2171fc61476afac0dfb59fb2c447a01fb1e0 Author: David Howells Date: Thu Nov 1 23:07:27 2018 + afs: Use fs_context to pass parameters over automount bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=10679fa990 start commit:

Re: [PATCH v2 02/11] cpuidle: Fixup IRQ state

2020-08-26 Thread Joel Fernandes
On Fri, Aug 21, 2020 at 07:36:43PM +0200, Rafael J. Wysocki wrote: > On Friday, August 21, 2020 10:47:40 AM CEST Peter Zijlstra wrote: > > Match the pattern elsewhere in this file. > > > > Signed-off-by: Peter Zijlstra (Intel) > > Reviewed-by: Steven Rostedt (VMware) > > Tested-by: Marco Elver

Re: [PATCH v2 01/11] lockdep: Use raw_cpu_*() for per-cpu variables

2020-08-26 Thread Joel Fernandes
On Fri, Aug 21, 2020 at 10:47:39AM +0200, Peter Zijlstra wrote: > Sven reported that commit a21ee6055c30 ("lockdep: Change > hardirq{s_enabled,_context} to per-cpu variables") caused trouble on > s390 because their this_cpu_*() primitives disable preemption which > then lands back tracing. > > On

Re: [PATCH 1/2] veth: Initialize dev->perm_addr

2020-08-26 Thread Mira Ressel
On Wed, Aug 26, 2020 at 09:33:29AM -0700, David Miller wrote: > From: Mira Ressel > Date: Wed, 26 Aug 2020 16:29:01 + > > > On Wed, Aug 26, 2020 at 08:28:57AM -0700, David Miller wrote: > >> From: Mira Ressel > >> Date: Wed, 26 Aug 2020 15:20:00 + > >> > >> > I'm setting the

Re: [PATCH 1/2] usb typec: mt6360: Add support for mt6360 Type-C driver

2020-08-26 Thread Guenter Roeck
On 8/26/20 5:59 PM, 啟原黃 wrote: [ ... ] >>> +static int mt6360_tcpc_remove(struct platform_device *pdev) >>> +{ >>> + struct mt6360_tcpc_info *mti = platform_get_drvdata(pdev); >>> + >>> + tcpci_unregister_port(mti->tcpci); >> >> That leaves interrupts enabled, which might be racy >>

Re: [PATCH 1/2] usb typec: mt6360: Add support for mt6360 Type-C driver

2020-08-26 Thread 啟原黃
Guenter Roeck 於 2020年8月27日 週四 上午4:44寫道: > > On 8/26/20 4:16 AM, cy_huang wrote: > > From: ChiYuan Huang > > > > Mediatek MT6360 is a multi-functional IC that includes USB Type-C. > > It works with Type-C Port Controller Manager to provide USB PD > > and USB Type-C functionalities. > > > >

Re: [PATCH v2] staging: qlge: fix build breakage with dumping enabled

2020-08-26 Thread Benjamin Poirier
On 2020-08-27 07:27 +0800, Coiby Xu wrote: > This fixes commit 0107635e15ac > ("staging: qlge: replace pr_err with netdev_err") which introduced an > build breakage of missing `struct ql_adapter *qdev` for some functions > and a warning of type mismatch with dumping enabled, i.e., > > $ make

[PATCH 1/3] sched: Allow hrticks to work with core scheduling

2020-08-26 Thread Alexander Graf
The core scheduling logic bypasses the scheduling class's pick_next_task() which starts the hrtick logic usually. Instead, it explicitly calls set_next_task() or leaves the current task running without any callback into the CFS scheduler. To ensure that we still configure the hrtick timer

[PATCH 2/3] sched: Trigger new hrtick if timer expires too fast

2020-08-26 Thread Alexander Graf
When an hrtick timer event occurs too quickly, we just bail out and don't attempt to set a new hrtick timeout. That means that the time slice for that particular task grows until the next HZ tick occurs. That again may create significant jitter for the respective task, as it will not get scheduled

[PATCH 3/3] sched: Use hrticks even with >sched_nr_latency tasks

2020-08-26 Thread Alexander Graf
When hrticks are enabled, we configure an hrtimer fire at the exact point in time when we would like to have a rescheduling event occur. However, the current code disables that logic when the number of currently running tasks exceeds sched_nr_latency. sched_nr_latency describes the point at which

[PATCH 0/3] Add HRTICK support to Core Scheduling

2020-08-26 Thread Alexander Graf
CFS supports a feature called "HRTICK" which allows scheduling decisions to be made independent of the HZ tick. That means that we can achieve much more fine grained time slices and thus be more fair in distributing time to different workloads. Unfortunately, HRTICK currently does not work with

linux-next: manual merge of the net-next tree with the net tree

2020-08-26 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the net-next tree got a conflict in: drivers/net/ethernet/ibm/ibmvnic.c between commit: 9f1345737790 ("ibmvnic fix NULL tx_pools and rx_tools issue at do_reset") from the net tree and commit: 507ebe6444a4 ("ibmvnic: Fix use-after-free of VNIC login

Re: [RFC PATCH 00/16] Core scheduling v6

2020-08-26 Thread Alexander Graf
Hi Vineeth, On 30.06.20 23:32, Vineeth Remanan Pillai wrote: Sixth iteration of the Core-Scheduling feature. Core scheduling is a feature that allows only trusted tasks to run concurrently on cpus sharing compute resources (eg: hyperthreads on a core). The goal is to mitigate the core-level

Re: [PATCH v2 05/23] arm64: use asm-generic/mmu_context.h for no-op implementations

2020-08-26 Thread kernel test robot
Hi Nicholas, I love your patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v5.9-rc2 next-20200826] [cannot apply to sparc/master asm-generic/master sparc-next/master xtensa/for_next] [If your patch is applied to the wrong git tree, kindly drop us

Re: [PATCH 3/3] usb: cdns3: Enable workaround for USB2.0 PHY Rx compliance test PHY lockup

2020-08-26 Thread Peter Chen
On 20-08-26 15:49:57, Roger Quadros wrote: > Peter, > > On 26/08/2020 11:07, Peter Chen wrote: > > > > > > > > > > > > > > On 20-08-26 04:04:01, Pawel Laszczak wrote: > > > > > > On 20-08-25 15:00:59, Roger Quadros wrote: > > > > > > > From: Pawel Laszczak > > > > > > > > > > > > > > USB2.0

Re: [PATCH 1/4] dt-bindings: arm: ti: Add bindings for J7200 SoC

2020-08-26 Thread Nishanth Menon
On 14:16-20200723, Lokesh Vutla wrote: > The J7200 SoC is a part of the K3 Multicore SoC architecture platform. > It is targeted for automotive gateway, vehicle compute systems, > Vehicle-to-Vehicle (V2V) and Vehicle-to-Everything (V2X) applications. > The SoC aims to meet the complex processing

drivers/dma/fsl-dpaa2-qdma/dpaa2-qdma.c:183:18: sparse: sparse: incorrect type in assignment (different base types)

2020-08-26 Thread kernel test robot
: arm64-randconfig-s031-20200826 (attached as .config) compiler: aarch64-linux-gcc (GCC) 9.3.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # apt-get install sparse # sparse

Re: [PATCH] m68k: Revive _TIF_* masks

2020-08-26 Thread Greg Ungerer
Hi Geert, On 26/8/20 10:29 pm, Geert Uytterhoeven wrote: While the core m68k code does not use the _TIF_* masks anymore, there exists generic code that relies on their presence. Fortunately none of that code is used on m68k, currently. Re-add the various _TIF_* masks, which were removed in

Re: [PATCH] m68k: mm: Remove superfluous memblock_alloc*() casts

2020-08-26 Thread Greg Ungerer
Hi Geert, On 26/8/20 11:04 pm, Geert Uytterhoeven wrote: The return type of memblock_alloc*() is a void pointer, so there is no need to cast it to "void *" or some other pointer type, before assigning it to a pointer variable. Signed-off-by: Geert Uytterhoeven Acked-by: Greg Ungerer

Re: [PATCH v2 1/2] IB/qib: remove superfluous fallthrough statements

2020-08-26 Thread Jason Gunthorpe
On Wed, Aug 26, 2020 at 02:18:59PM -0500, Gustavo A. R. Silva wrote: > Hi, > > On Tue, Aug 25, 2020 at 02:33:27PM -0500, Gustavo A. R. Silva wrote: > > On Tue, Aug 25, 2020 at 06:12:42PM +0100, Alex Dewar wrote: > > > Commit 36a8f01cd24b ("IB/qib: Add congestion control agent > > >

Re: [PATCH 1/4] drivers: hv: dxgkrnl: core code

2020-08-26 Thread Iouri Tarassov
Hello On 8/14/2020 6:18 AM, Wei Liu wrote: On Fri, Aug 14, 2020 at 08:38:53AM -0400, Sasha Levin wrote: [...] > + > +#include "dxgkrnl.h" > + > +int dxgadapter_init(struct dxgadapter *adapter, struct hv_device *hdev) > +{ > + int ret = 0; > + char s[80]; > + > + UNUSED(s); If s is not used,

Re: [PATCH v3] lib/string.c: implement stpcpy

2020-08-26 Thread Joe Perches
On Wed, 2020-08-26 at 16:38 -0700, Kees Cook wrote: > On Thu, Aug 27, 2020 at 07:59:45AM +0900, Masahiro Yamada wrote: [] > > OK, then stpcpy(), strcpy() and sprintf() > > have the same level of unsafety. > > Yes. And even snprintf() is dangerous because its return value is how > much it WOULD

Re: [PATCH v3] lib/string.c: implement stpcpy

2020-08-26 Thread Kees Cook
On Thu, Aug 27, 2020 at 07:59:45AM +0900, Masahiro Yamada wrote: > On Thu, Aug 27, 2020 at 1:58 AM Nick Desaulniers > wrote: > > > > On Wed, Aug 26, 2020 at 9:57 AM Joe Perches wrote: > > > > > > On Thu, 2020-08-27 at 01:49 +0900, Masahiro Yamada wrote: > > > > I do not have time to keep track

[PATCH] usb: musb: Fix NULL check on struct musb_request field

2020-08-26 Thread Paul Cercueil
The 'request' variable is a pointer to the 'request' field of the struct musb_request 'req' pointer. It only worked until now because the 'request' field is the first one in the musb_request structure, but as soon as that changes, the check will be invalid. Fix it preventively by doing the

[PATCH v2] staging: qlge: fix build breakage with dumping enabled

2020-08-26 Thread Coiby Xu
This fixes commit 0107635e15ac ("staging: qlge: replace pr_err with netdev_err") which introduced an build breakage of missing `struct ql_adapter *qdev` for some functions and a warning of type mismatch with dumping enabled, i.e., $ make CFLAGS_MODULE="QL_ALL_DUMP=1 QL_OB_DUMP=1 QL_CB_DUMP=1 \

Re: [PATCH net-next 0/6] drivers/net: constify static ops-variables

2020-08-26 Thread David Miller
From: Rikard Falkeborn Date: Thu, 27 Aug 2020 00:56:02 +0200 > This series constifies a number of static ops variables, to allow the > compiler to put them in read-only memory. Compile-tested only. Series applied, thank you.

Re: [PATCH v2 3/9] ASoC: audio-graph: Identify 'no_pcm' DAI links for DPCM

2020-08-26 Thread Kuninori Morimoto
Hi Sameer > Sure. BTW, there are more such candidates which require 'lock' version > of these helpers. > For example: soc_find_component(), snd_soc_add/remove_pcm_runtime() > and snd_soc_register_dai(). soc_find_component() is static function, no need to care about mutex. other functions are

Re: linux-next: build warnings from perf build in Linus' tree

2020-08-26 Thread Stephen Rothwell
Hi all, On Thu, 27 Aug 2020 08:38:39 +1000 Stephen Rothwell wrote: > > /home/sfr/next/next/tools/perf/util/namespaces.c: In function 'nsinfo__new': > /home/sfr/next/next/tools/perf/util/namespaces.c:139:12: note: the layout of > aggregates containing vectors with 8-byte alignment has changed

Re: [PATCH -next] drm/mediatek: remove duplicate include

2020-08-26 Thread Chun-Kuang Hu
Hi, Wang Hai: Chun-Kuang Hu 於 2020年8月21日 週五 上午7:23寫道: > > Hi, Wang Hai: > > Wang Hai 於 2020年8月19日 週三 上午11:00寫道: > > > > Remove mtk_drm_ddp.h which is included more than once > > > > Reviewed-by: Chun-Kuang Hu > Applied to mediatek-drm-fixes [1], thanks. [1]

[PATCH 2/2 v5] rseq/selftests: test MEMBARRIER_CMD_PRIVATE_EXPEDITED_RSEQ

2020-08-26 Thread Peter Oskolkov
Based on Google-internal RSEQ work done by Paul Turner and Andrew Hunter. This patch adds a selftest for MEMBARRIER_CMD_PRIVATE_EXPEDITED_RSEQ. The test quite often fails without the previous patch in this patchset, but consistently passes with it. v3: added rseq_offset_deref_addv() to x86_64 to

[PATCH 1/2 v5] rseq/membarrier: add MEMBARRIER_CMD_PRIVATE_EXPEDITED_RSEQ

2020-08-26 Thread Peter Oskolkov
This patchset is based on Google-internal RSEQ work done by Paul Turner and Andrew Hunter. When working with per-CPU RSEQ-based memory allocations, it is sometimes important to make sure that a global memory location is no longer accessed from RSEQ critical sections. For example, there can be two

Re: [PATCH v2] drm/mediatek: dsi: fix scrolling of panel with small hfp or hbp

2020-08-26 Thread Chun-Kuang Hu
Hi, Jitao: Chun-Kuang Hu 於 2020年8月18日 週二 下午10:45寫道: > > Hi, Jitao: > > Jitao Shi 於 2020年8月18日 週二 上午10:41寫道: > > > > On Tue, 2020-08-18 at 07:42 +0800, Chun-Kuang Hu wrote: > > > Hi, Jitao: > > > > > > Jitao Shi 於 2020年8月17日 週一 下午9:07寫道: > > > > > > > > horizontal_backporch_byte should be hbp *

Re: [PATCH v3] lib/string.c: implement stpcpy

2020-08-26 Thread Masahiro Yamada
On Thu, Aug 27, 2020 at 1:58 AM Nick Desaulniers wrote: > > On Wed, Aug 26, 2020 at 9:57 AM Joe Perches wrote: > > > > On Thu, 2020-08-27 at 01:49 +0900, Masahiro Yamada wrote: > > > I do not have time to keep track of the discussion fully, > > > but could you give me a little more context why >

[PATCH net-next 3/6] net: renesas: sh_eth: constify bb_ops

2020-08-26 Thread Rikard Falkeborn
The only usage of bb_ops is to assign its address to the ops field in the mdiobb_ctrl struct, which is a const pointer. Make it const to allow the compiler to put it in read-only memory. Signed-off-by: Rikard Falkeborn --- drivers/net/ethernet/renesas/sh_eth.c | 2 +- 1 file changed, 1

[PATCH net-next 6/6] net: ath11k: constify ath11k_thermal_ops

2020-08-26 Thread Rikard Falkeborn
The only usage of ath11k_thermal_ops is to pass its address to thermal_cooling_device_register() which takes a const pointer. Make it const to allow the compiler to put it in read-only memory. Signed-off-by: Rikard Falkeborn --- drivers/net/wireless/ath/ath11k/thermal.c | 2 +- 1 file changed,

[PATCH net-next 4/6] net: phy: at803x: constify static regulator_ops

2020-08-26 Thread Rikard Falkeborn
The only usage of vddio_regulator_ops and vddh_regulator_ops is to assign their address to the ops field in the regulator_desc struct, which is a const pointer. Make them const to allow the compiler to put them in read-only memory. Signed-off-by: Rikard Falkeborn --- drivers/net/phy/at803x.c |

[PATCH net-next 1/6] net: ethernet: qualcomm: constify qca_serdev_ops

2020-08-26 Thread Rikard Falkeborn
The only usage of qca_serdev_ops is to pass its address to serdev_device_set_client_ops() which takes a const pointer. Make it const to allow the compiler to put it in read-only memory. Signed-off-by: Rikard Falkeborn --- drivers/net/ethernet/qualcomm/qca_uart.c | 2 +- 1 file changed, 1

[PATCH net-next 0/6] drivers/net: constify static ops-variables

2020-08-26 Thread Rikard Falkeborn
This series constifies a number of static ops variables, to allow the compiler to put them in read-only memory. Compile-tested only. Rikard Falkeborn (6): net: ethernet: qualcomm: constify qca_serdev_ops net: ethernet: ravb: constify bb_ops net: renesas: sh_eth: constify bb_ops net: phy:

[PATCH net-next 5/6] net: phy: mscc: macsec: constify vsc8584_macsec_ops

2020-08-26 Thread Rikard Falkeborn
The only usage of vsc8584_macsec_ops is to assign its address to the macsec_ops field in the phydev struct, which is a const pointer. Make it const to allow the compiler to put it in read-only memory. Signed-off-by: Rikard Falkeborn --- drivers/net/phy/mscc/mscc_macsec.c | 2 +- 1 file changed,

[PATCH net-next 2/6] net: ethernet: ravb: constify bb_ops

2020-08-26 Thread Rikard Falkeborn
The only usage of bb_ops is to assign its address to the ops field in the mdiobb_ctrl struct, which is a const pointer. Make it const to allow the compiler to put it in read-only memory. Signed-off-by: Rikard Falkeborn --- drivers/net/ethernet/renesas/ravb_main.c | 2 +- 1 file changed, 1

Re: x86/irq: Unbreak interrupt affinity setting

2020-08-26 Thread Alexander Graf
On 26.08.20 23:47, David Laight wrote: From: David Laight Sent: 26 August 2020 22:37 From: Thomas Gleixner Sent: 26 August 2020 21:22 ... Moving interrupts on x86 happens in several steps. A new vector on a different CPU is allocated and the relevant interrupt source is reprogrammed to

Re: [PATCH net] drivers/net/wan/lapbether: Set network_header before transmitting

2020-08-26 Thread David Miller
From: Xie He Date: Tue, 25 Aug 2020 20:03:53 -0700 > Set the skb's network_header before it is passed to the underlying > Ethernet device for transmission. > > This patch fixes the following issue: > > When we use this driver with AF_PACKET sockets, there would be error > messages of: >

Re: [PATCH] Bluetooth: Clear suspend tasks on unregister

2020-08-26 Thread Abhishek Pandit-Subedi
Please disregard this earlier email without the Fixes tag. On Wed, Aug 26, 2020 at 3:26 PM Abhishek Pandit-Subedi wrote: > > While unregistering, make sure to clear the suspend tasks before > cancelling the work. If the unregister is called during resume from > suspend, this will unnecessarily

Re: [PATCH v5 1/3] dt-bindings: interrupt-controller: Add Actions SIRQ controller binding

2020-08-26 Thread Rob Herring
On Wed, Aug 26, 2020 at 3:42 PM Cristian Ciocaltea wrote: > > Hi Rob, > > Thanks for the review! > > On Tue, Aug 25, 2020 at 04:09:13PM -0600, Rob Herring wrote: > > On Wed, Aug 19, 2020 at 07:37:56PM +0300, Cristian Ciocaltea wrote: > > > Actions Semi Owl SoCs SIRQ interrupt controller is found

[PATCH] Bluetooth: Clear suspend tasks on unregister

2020-08-26 Thread Abhishek Pandit-Subedi
While unregistering, make sure to clear the suspend tasks before cancelling the work. If the unregister is called during resume from suspend, this will unnecessarily add 2s to the resume time otherwise. Fixes: 4e8c36c3b0d73d (Bluetooth: Fix suspend notifier race) Signed-off-by: Abhishek

Re: [PATCH 4/4] i915: POC use dynamic_debug_exec_queries to control pr_debugs in gvt

2020-08-26 Thread kernel test robot
Hi Jim, I love your patch! Yet something to improve: [auto build test ERROR on drm-intel/for-linux-next] [also build test ERROR on linux/master tegra-drm/drm/tegra/for-next drm-tip/drm-tip linus/master v5.9-rc2 next-20200826] [cannot apply to drm/drm-next] [If your patch is applied to the wrong

kernel BUG at fs/ext4/page-io.c:LINE!

2020-08-26 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:4af7b32f Merge git://git.kernel.org/pub/scm/linux/kernel/g.. git tree: bpf console output: https://syzkaller.appspot.com/x/log.txt?x=1425b64990 kernel config: https://syzkaller.appspot.com/x/.config?x=3d400a47d1416652

linux-next: build warnings from perf build in Linus' tree

2020-08-26 Thread Stephen Rothwell
Hi all, Doing the perf native (PowerPC le) build today produces these warnings: util/dsos.c: In function 'dsos__findnew_id': util/dsos.c:39:14: note: the layout of aggregates containing vectors with 8-byte alignment has changed in GCC 5 39 | dso->id.maj = id->maj; |

Re: [PATCH v2 2/2] soc: qcom: rpmh: Allow RPMH driver to be loaded as a module

2020-08-26 Thread Stephen Boyd
Quoting Maulik Shah (2020-08-25 04:21:22) > From: John Stultz > > This patch allow the rpmh driver to be loaded as a permenent > module. Meaning it can be loaded from a module, but then cannot > be unloaded. > > Ideally, it would include a remove hook and related logic, but > the rpmh driver is

[PATCH v3] i2c: mv64xxx: Add bus error recovery

2020-08-26 Thread Mark Tomlinson
This adds i2c bus recovery to the mv64xxx driver. Implement bus recovery to recover from SCL/SDA stuck low. This uses the generic recovery function, setting the clock/data lines as GPIO pins, and sending 9 clocks to try and recover the bus. Signed-off-by: Mark Tomlinson --- Changes in v2: -

Re: [PATCH 1/2 v4] rseq/membarrier: add MEMBARRIER_CMD_PRIVATE_EXPEDITED_RSEQ

2020-08-26 Thread kernel test robot
Hi Peter, Thank you for the patch! Yet something to improve: [auto build test ERROR on kselftest/next] [also build test ERROR on tip/sched/core linux/master linus/master v5.9-rc2 next-20200826] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we

Re: [PATCH v2] i2c: mv64xxx: Add bus error recovery

2020-08-26 Thread Mark Tomlinson
On Tue, 2020-08-25 at 11:26 +0200, Wolfram Sang wrote: > On Tue, Aug 25, 2020 at 10:52:54AM +1200, Mark Tomlinson wrote: > > This adds i2c bus recovery to the mv64xxx driver. > > Implement bus recovery to recover from SCL/SDA stuck low. > > This uses the generic recovery function, setting the

Re: fsl_espi errors on v5.7.15

2020-08-26 Thread Chris Packham
(adding Nicholas) On 26/08/20 6:38 pm, Heiner Kallweit wrote: > On 26.08.2020 08:07, Chris Packham wrote: >> On 26/08/20 1:48 pm, Chris Packham wrote: >>> On 26/08/20 10:22 am, Chris Packham wrote: On 25/08/20 7:22 pm, Heiner Kallweit wrote: > I've been staring at

[PATCH] Bluetooth: Clear suspend tasks on unregister

2020-08-26 Thread Abhishek Pandit-Subedi
While unregistering, make sure to clear the suspend tasks before cancelling the work. If the unregister is called during resume from suspend, this will unnecessarily add 2s to the resume time otherwise. Signed-off-by: Abhishek Pandit-Subedi --- This was discovered with RT8822CE using the btusb

Re: Issue with iwd + Linux 5.8.3 + WPA Enterprise

2020-08-26 Thread Herbert Xu
On Wed, Aug 26, 2020 at 05:42:27PM +0200, Ard Biesheuvel wrote: > > I still get a failure in aes_siv_encrypt(), which does not occur with > the kernel side fix applied. Where is this test from? I can't find it in the ell git tree. Thanks, -- Email: Herbert Xu Home Page:

Re: [PATCH v9 5/5] remoteproc: Add initial zynqmp R5 remoteproc driver

2020-08-26 Thread Michael Auchter
Hello Ben, On Wed, Aug 26, 2020 at 09:13:07AM -0700, Ben Levinsky wrote: > R5 is included in Xilinx Zynq UltraScale MPSoC so by adding this > remotproc driver, we can boot the R5 sub-system in different 2 > configurations: split or lock-step. > > The Xilinx R5 Remoteproc Driver boots the R5's

Re: [PATCH 8/9] rpmsg: virtio: use rpmsg_ns driver to manage ns announcement

2020-08-26 Thread Mathieu Poirier
On Wed, Aug 26, 2020 at 09:42:46AM +0200, Arnaud POULIQUEN wrote: > Hi mathieu, > > I Sent my V2 few seconds before receiving your comment :) > Please find my answer below Seconds! > > On 8/25/20 6:54 PM, Mathieu Poirier wrote: > > Hi Arnaud, > > > > On Fri, Jul 31, 2020 at 01:47:31PM +0200,

Re: [PATCH v2] hwmon (pmbus/max20730): add device monitoring via debugfs

2020-08-26 Thread Guenter Roeck
On Wed, Aug 26, 2020 at 09:06:04PM +, Ugur Usug wrote: > Add debugfs interface support for accessing device specific registers > (MFR_VOUT_MIN, MFR_DEVSET1 and MFR_DEVSET2) and others including OPERATION, > ON_OFF_CONFIG, SMB_ALERT_MASK, VOUT_MODE, VOUT_COMMAND and VOUT_MAX. > >

RE: x86/irq: Unbreak interrupt affinity setting

2020-08-26 Thread Thomas Gleixner
On Wed, Aug 26 2020 at 21:37, David Laight wrote: > From: Thomas Gleixner >> Sent: 26 August 2020 21:22 > ... >> Moving interrupts on x86 happens in several steps. A new vector on a >> different CPU is allocated and the relevant interrupt source is >> reprogrammed to that. But that's racy and

Re: [PATCH 06/14] block: lift setting the readahead size into the block layer

2020-08-26 Thread Mike Snitzer
On Sun, Jul 26 2020 at 11:03am -0400, Christoph Hellwig wrote: > Drivers shouldn't really mess with the readahead size, as that is a VM > concept. Instead set it based on the optimal I/O size by lifting the > algorithm from the md driver when registering the disk. Also set > bdi->io_pages

Re: [PATCH v6 2/2] soc: mediatek: add mt6779 devapc driver

2020-08-26 Thread Chun-Kuang Hu
Hi, Neal: Neal Liu 於 2020年8月26日 週三 下午5:59寫道: > > Hi Chun-Kuang, > > On Tue, 2020-08-18 at 14:20 +0800, Neal Liu wrote: > > Hi Chun-Kuang, > > > > On Tue, 2020-08-18 at 10:44 +0800, Neal Liu wrote: > > > Hi Chun-Kuang, > > > > > > On Mon, 2020-08-17 at 23:13 +0800, Chun-Kuang Hu wrote: > > > >

Re: [PATCH 1/2] power: supply: Add support for RN5T618/RC5T619 charger and fuel gauge

2020-08-26 Thread Sebastian Reichel
Hi, On Wed, Aug 26, 2020 at 08:28:34PM +0200, Andreas Kemnade wrote: > On Wed, 26 Aug 2020 19:48:17 +0200 > Sebastian Reichel wrote: > > On Sat, Aug 15, 2020 at 06:56:09PM +0200, Andreas Kemnade wrote: > > > [...] > > > +static int rn5t618_battery_current_now(struct rn5t618_power_info *info, > >

[PATCH] drm/ingenic: Fix driver not probing when IPU port is missing

2020-08-26 Thread Paul Cercueil
Even if support for the IPU was compiled in, we may run on a device (e.g. the Qi LB60) where the IPU is not available, or simply with an old devicetree without the IPU node. In that case the ingenic-drm refused to probe. Fix the driver so that it will probe even if the IPU node is not present in

Re: [PATCH v2 00/13] extcon: ptn5150: Improvements and fixes

2020-08-26 Thread Suman Anna
Hi Chanwoo, On 8/24/20 6:28 AM, Chanwoo Choi wrote: > Hi, > > On 8/24/20 7:36 PM, Ramuthevar, Vadivel MuruganX wrote: >> Hi, >> >>  Thank you for the patches and optimized the code as well. >>  I have applied your patches and tested, it's working fine >>  with few minor changes as per Intel's

RE: x86/irq: Unbreak interrupt affinity setting

2020-08-26 Thread David Laight
From: David Laight > Sent: 26 August 2020 22:37 > > From: Thomas Gleixner > > Sent: 26 August 2020 21:22 > ... > > Moving interrupts on x86 happens in several steps. A new vector on a > > different CPU is allocated and the relevant interrupt source is > > reprogrammed to that. But that's racy and

Re: [PATCH] PCI/ASPM: Enable ASPM for links under VMD domain

2020-08-26 Thread Derrick, Jonathan
On Tue, 2020-08-25 at 06:23 +, Christoph Hellwig wrote: > On Fri, Aug 21, 2020 at 08:32:20PM +0800, Kai-Heng Feng wrote: > > New Intel laptops with VMD cannot reach deeper power saving state, > > renders very short battery time. > > So what about just disabling VMD given how bloody pointless

Re: [PATCH v5 1/3] dt-bindings: interrupt-controller: Add Actions SIRQ controller binding

2020-08-26 Thread Cristian Ciocaltea
Hi Rob, Thanks for the review! On Tue, Aug 25, 2020 at 04:09:13PM -0600, Rob Herring wrote: > On Wed, Aug 19, 2020 at 07:37:56PM +0300, Cristian Ciocaltea wrote: > > Actions Semi Owl SoCs SIRQ interrupt controller is found in S500, S700 > > and S900 SoCs and provides support for handling up to 3

Re: [PATCH] compiler-clang: add build check for clang 10.0.1

2020-08-26 Thread Nathan Chancellor
On Wed, Aug 26, 2020 at 01:14:19PM -0700, Nick Desaulniers wrote: > During Plumbers 2020, we voted to just support the latest release of > Clang for now. Add a compile time check for this. > > Older clang's may work, but we will likely drop workarounds for older > versions. I think this part of

Re: [PATCH 1/6] dt-bindings: timers: sp-804: Convert to json-schema

2020-08-26 Thread Rob Herring
On Wed, Aug 26, 2020 at 12:38 PM Andre Przywara wrote: > > This converts the DT binding documentation for the ARM SP-804 timer IP > over to json-schema. > Most properties are just carried over, the clocks property requirement > (either one or three clocks) is now formalised and enforced. > As the

RE: x86/irq: Unbreak interrupt affinity setting

2020-08-26 Thread David Laight
From: Thomas Gleixner > Sent: 26 August 2020 21:22 ... > Moving interrupts on x86 happens in several steps. A new vector on a > different CPU is allocated and the relevant interrupt source is > reprogrammed to that. But that's racy and there might be an interrupt > already in flight to the old

RE: [PATCH v9 5/5] remoteproc: Add initial zynqmp R5 remoteproc driver

2020-08-26 Thread Ben Levinsky
Hi Michael, Thanks for the catch, will update in v10 > -Original Message- > From: Michael Auchter > Sent: Wednesday, August 26, 2020 2:32 PM > To: Ben Levinsky > Cc: Stefano Stabellini ; Michal Simek > ; devicet...@vger.kernel.org; > mathieu.poir...@linaro.org; Ed T. Mooring ; linux-

Re: [patch V2 29/46] irqdomain/msi: Allow to override msi_domain_alloc/free_irqs()

2020-08-26 Thread Marc Zyngier
On Wed, 26 Aug 2020 20:47:38 +0100, Thomas Gleixner wrote: > > On Wed, Aug 26 2020 at 20:06, Marc Zyngier wrote: > > On Wed, 26 Aug 2020 12:16:57 +0100, > > Thomas Gleixner wrote: > >> /** > >> - * msi_domain_free_irqs - Free interrupts from a MSI interrupt @domain > >> associated tp @dev >

Re: [PATCH v1 5/9] phy: qcom-qmp: Get dp_com I/O resource by index

2020-08-26 Thread Stephen Boyd
Quoting Bjorn Andersson (2020-08-25 21:36:16) > On Tue 25 Aug 21:47 CDT 2020, Stephen Boyd wrote: > > > The dp_com resource is always at index 1 according to the dts files in > > the kernel. Get this resource by index so that we don't need to make > > future additions to the DT binding use

Re: [patch V2 04/46] genirq/chip: Use the first chip in irq_chip_compose_msi_msg()

2020-08-26 Thread Marc Zyngier
On Wed, 26 Aug 2020 22:19:56 +0100, Thomas Gleixner wrote: > > On Wed, Aug 26 2020 at 20:50, Marc Zyngier wrote: > > On Wed, 26 Aug 2020 12:16:32 +0100, > > Thomas Gleixner wrote: > >> --- > >> V2: New patch. Note, that this might break other stuff which relies on the > >> current

[PATCH] perf tools: Add bpf image check to __map__is_kmodule

2020-08-26 Thread Jiri Olsa
When validating kcore modules the do_validate_kcore_modules function checks on every kernel module dso against modules record. The __map__is_kmodule check is used to get only kernel module dso objects through. Currently the bpf images are slipping through the check and making the validation to

Re: [PATCH 3/6] ARM: dts: broadcom: Fix SP804 node

2020-08-26 Thread Rob Herring
On Wed, Aug 26, 2020 at 12:54 PM André Przywara wrote: > > On 26/08/2020 19:42, Florian Fainelli wrote: > > Hi, > > > On 8/26/20 11:38 AM, Andre Przywara wrote: > >> The DT binding for SP804 requires to have an "arm,primecell" compatible > >> string. > >> Add this string so that the Linux

Re: [PATCH v5 04/12] KVM: SVM: Modify intercept_exceptions to generic intercepts

2020-08-26 Thread Babu Moger
On 8/26/20 3:55 PM, Jim Mattson wrote: > On Wed, Aug 26, 2020 at 12:14 PM Babu Moger wrote: >> >> Modify intercept_exceptions to generic intercepts in vmcb_control_area. Use >> the generic vmcb_set_intercept, vmcb_clr_intercept and vmcb_is_intercept to >> set/clear/test the

Re: [patch V2 34/46] PCI/MSI: Make arch_.*_msi_irq[s] fallbacks selectable

2020-08-26 Thread Thomas Gleixner
On Wed, Aug 26 2020 at 22:14, Marc Zyngier wrote: > On Wed, 26 Aug 2020 12:17:02 +0100, > Thomas Gleixner wrote: >> @@ -103,6 +105,7 @@ config PCIE_XILINX_CPM >> bool "Xilinx Versal CPM host bridge support" >> depends on ARCH_ZYNQMP || COMPILE_TEST >> select PCI_HOST_COMMON >> +

Re: [PATCH] compiler-clang: add build check for clang 10.0.1

2020-08-26 Thread Nathan Chancellor
On Wed, Aug 26, 2020 at 11:17:34PM +0200, Miguel Ojeda wrote: > On Wed, Aug 26, 2020 at 10:14 PM Nick Desaulniers > wrote: > > > > During Plumbers 2020, we voted to just support the latest release of > > Clang for now. Add a compile time check for this. > > Since this effectively enforces a

Re: [patch V2 41/46] platform-msi: Provide default irq_chip:: Ack

2020-08-26 Thread Marc Zyngier
On Wed, 26 Aug 2020 12:17:09 +0100, Thomas Gleixner wrote: > > From: Thomas Gleixner > > For the upcoming device MSI support it's required to have a default > irq_chip::ack implementation (irq_chip_ack_parent) so the drivers do not > need to care. > > Signed-off-by: Thomas Gleixner > > ---

[PATCH] kconfig: streamline_config.pl: check defined(ENV variable) before using it

2020-08-26 Thread Randy Dunlap
From: Randy Dunlap A user reported: 'Use of uninitialized value $ENV{"LMC_KEEP"} in split at ./scripts/kconfig/streamline_config.pl line 596.' so first check that $ENV{LMC_KEEP} is defined before trying to use it. Fixes: c027b02d89fd ("streamline_config.pl: add LMC_KEEP to preserve some

Re: [PATCH] kcsan: Use tracing-safe version of prandom

2020-08-26 Thread Paul E. McKenney
On Wed, Aug 26, 2020 at 02:17:57PM +0200, Marco Elver wrote: > On Fri, 21 Aug 2020 at 14:31, Marco Elver wrote: > > In the core runtime, we must minimize any calls to external library > > functions to avoid any kind of recursion. This can happen even though > > instrumentation is disabled for

Re: [patch V2 04/46] genirq/chip: Use the first chip in irq_chip_compose_msi_msg()

2020-08-26 Thread Thomas Gleixner
On Wed, Aug 26 2020 at 20:50, Marc Zyngier wrote: > On Wed, 26 Aug 2020 12:16:32 +0100, > Thomas Gleixner wrote: >> --- >> V2: New patch. Note, that this might break other stuff which relies on the >> current behaviour, but the hierarchy composition of DT based chips is >> really hard to

Re: [PATCH] Platform lockdown information in sysfs (v2)

2020-08-26 Thread Daniel Gutson
Hi, any chance someone could review this patch please? I tried to follow Arnd's and Greg's directions so now drivers can register a device in the platform-lockdown class directory, then device attributes under it, making a 2 levels depth tree. Thanks! Daniel. On Thu, Aug 20, 2020 at

Re: [PATCH] compiler-clang: add build check for clang 10.0.1

2020-08-26 Thread Miguel Ojeda
On Wed, Aug 26, 2020 at 10:14 PM Nick Desaulniers wrote: > > During Plumbers 2020, we voted to just support the latest release of > Clang for now. Add a compile time check for this. Since this effectively enforces a minimum version for Clang, I'd also update `Documentation/process/changes.rst`

Re: INFO: rcu detected stall in smp_call_function

2020-08-26 Thread Paul E. McKenney
On Wed, Aug 26, 2020 at 07:07:33AM -0700, Paul E. McKenney wrote: > On Wed, Aug 26, 2020 at 11:51:44AM +0200, pet...@infradead.org wrote: > > On Tue, Aug 25, 2020 at 08:48:41AM -0700, Paul E. McKenney wrote: > > > > > > Paul, I wanted to use this function, but found it has very weird > > > >

Re: [patch V2 34/46] PCI/MSI: Make arch_.*_msi_irq[s] fallbacks selectable

2020-08-26 Thread Marc Zyngier
On Wed, 26 Aug 2020 12:17:02 +0100, Thomas Gleixner wrote: > > From: Thomas Gleixner > > The arch_.*_msi_irq[s] fallbacks are compiled in whether an architecture > requires them or not. Architectures which are fully utilizing hierarchical > irq domains should never call into that code. > >

<    1   2   3   4   5   6   7   8   9   10   >