Re: [PATCH v2] x86/asm: Replace __force_order with memory clobber

2020-09-02 Thread Arvind Sankar
On Wed, Sep 02, 2020 at 03:58:38PM +, David Laight wrote: > From: Arvind Sankar > > Sent: 02 September 2020 16:34 > > > > The CRn accessor functions use __force_order as a dummy operand to > > prevent the compiler from reordering the inline asm. > > > > The fact that the asm is volatile

Re: [PATCH net-next 0/1] Support for VLAN interface over HSR/PRP

2020-09-02 Thread Murali Karicheri
All, On 9/1/20 3:54 PM, Murali Karicheri wrote: This series add support for creating VLAN interface over HSR or PRP interface. Typically industrial networks uses VLAN in deployment and this capability is needed to support these networks. This is tested using two TI AM572x IDK boards connected

[PATCH 30/38] media: atomisp: don't check for ISP version for includes

2020-09-02 Thread Mauro Carvalho Chehab
As there aren't duplicated names anymore, and the end goal is to do runtime checks between ISP2400 and ISP2401, remove the part of the Makefile which changes the include places based on the compile-time version. This shouldn't cause any effect, but it will make easier for further patches meant to

Re: [PATCH 4/5] Add manpage for fsopen(2) and fsmount(2)

2020-09-02 Thread David Howells
Michael Kerrisk (man-pages) wrote: > The term "filesystem configuration context" is introduced, but never > really explained. I think it would be very helpful to have a sentence > or three that explains this concept at the start of the page. Does that need a .7 manpage? David

[PATCH 21/38] media: dvb-ttusb-budget: don't use stack for USB transfers

2020-09-02 Thread Mauro Carvalho Chehab
As reported by smatch: drivers/media/usb/ttusb-budget/dvb-ttusb-budget.c:311 ttusb_boot_dsp() error: doing dma on the stack (b) drivers/media/usb/ttusb-budget/dvb-ttusb-budget.c:321 ttusb_boot_dsp() error: doing dma on the stack (b)

[PATCH 00/38] media sparse/smatch warn fixes

2020-09-02 Thread Mauro Carvalho Chehab
While I was lately relying on Jenkins to report smatch/sparse issues, I discovered this week that the reports were missing such warnings I got it fixed already at builder.linuxtv.org, but there are several new warnings that got added over time. This series is meant to solve the ones that are

Re: [PATCH v6 3/3] drm/vkms: Add support for writeback

2020-09-02 Thread Liviu Dudau
On Sun, Aug 30, 2020 at 10:20:00AM -0400, Rodrigo Siqueira wrote: > This patch implements the necessary functions to add writeback support > for vkms. This feature is useful for testing compositors if you don't > have hardware with writeback support. > > Change in V4 (Emil and Melissa): > - Move

[PATCH 22/38] media: dvb-ttusb-budget: cleanup printk logic

2020-09-02 Thread Mauro Carvalho Chehab
Instead of calling printk(), use pr_foo() macros. While here, do some cleanup at the printed messages, as some has __func__, while others have the module name (sometimes spelled as "ttusb_dvb"). Signed-off-by: Mauro Carvalho Chehab --- .../media/usb/ttusb-budget/dvb-ttusb-budget.c | 118

[PATCH 36/38] media: atomisp: csi_rx.c: add a missing includes

2020-09-02 Thread Mauro Carvalho Chehab
Due to that, smatch warns with: drivers/staging/media/atomisp/pci/css_2401_system/host/csi_rx.c:18:11: warning: symbol 'N_SHORT_PACKET_LUT_ENTRIES' was not declared. Should it be static? drivers/staging/media/atomisp/pci/css_2401_system/host/csi_rx.c:24:11: warning: symbol

[PATCH 14/38] media: vivid: move the devnode creation logic to a separate function

2020-09-02 Thread Mauro Carvalho Chehab
In order to reduce even further the size of the big vivid_create_instance() function, let's place the part of the logic which creates the device nodes into a separate function. With this and the past patches, those warnings finally vanishes:

[PATCH 26/38] media: atomisp: cleanup ifdefs from ia_css_debug.c

2020-09-02 Thread Mauro Carvalho Chehab
There are lots of code dependency there. Get rid of most of them. We can't remove everything, as there are some structs that are conditionally built if ISP2401. So, keep ifdefs only on such cases. Signed-off-by: Mauro Carvalho Chehab --- .../runtime/debug/interface/ia_css_debug.h| 6 -

[PATCH 33/38] media: atomisp: reorder functions at pixelgen_private.h

2020-09-02 Thread Mauro Carvalho Chehab
Reorder functions in order to declare before usage. Signed-off-by: Mauro Carvalho Chehab --- .../css_2401_system/host/pixelgen_private.h | 73 ++- 1 file changed, 37 insertions(+), 36 deletions(-) diff --git

[PATCH 24/38] media: atomisp: fix casts at atomisp_compat_ioctl32.c

2020-09-02 Thread Mauro Carvalho Chehab
There are several warnings reported by sparse with regards to wrong typecasts: drivers/staging/media/atomisp/pci/atomisp_compat_ioctl32.c:73:13: warning: incorrect type in assignment (different address spaces) drivers/staging/media/atomisp/pci/atomisp_compat_ioctl32.c:73:13:

[PATCH 28/38] media: atomisp: get rid of isys_dma.h and isys_dma_local.h

2020-09-02 Thread Mauro Carvalho Chehab
There aren't much on this abstraction. Just move the defines to isys_dma_private.h and isys_dma_public.h, cleaning up the includes. Signed-off-by: Mauro Carvalho Chehab --- .../pci/css_2401_system/host/isys_dma.c | 10 +--- .../pci/css_2401_system/host/isys_dma_local.h | 21 -

[PATCH 25/38] media: atomisp: get rid of some unused code

2020-09-02 Thread Mauro Carvalho Chehab
Now that the defines which are common for both ISP2400 and ISP2401 are at system_global.h, we can get rid of the code not used by those versions. Signed-off-by: Mauro Carvalho Chehab --- .../staging/media/atomisp/pci/ia_css_mipi.h | 2 - .../staging/media/atomisp/pci/ia_css_stream.h | 4

[PATCH 31/38] media: atomisp: unify INPUT error return type

2020-09-02 Thread Mauro Carvalho Chehab
There is a typedef for INPUT errors. This is different between ISP2401 and ISP2400. Place both at the same struct, at the global header file. Signed-off-by: Mauro Carvalho Chehab --- .../pci/css_2401_system/ibuf_ctrl_global.h| 2 +- .../hive_isp_css_common/host/input_system.c | 56

[PATCH 32/38] media: atomisp: de-duplicate names at *_input_system_global.h

2020-09-02 Thread Mauro Carvalho Chehab
There are some duplicated names between the ISP2401 and ISP2400 for the input system, with different meanings. In order to avoid ubiquity, let's prepend those with the name of the ISP. Signed-off-by: Mauro Carvalho Chehab --- .../pci/css_2401_system/ibuf_ctrl_global.h| 6 +-

[PATCH 27/38] media: atomisp: get rid of version-dependent globals

2020-09-02 Thread Mauro Carvalho Chehab
Replace all occurrences along the atomisp tree for the conditional compilation macros found at system_global.h, replacing them by tests wheather ISP2401 is defined or not. Signed-off-by: Mauro Carvalho Chehab --- .../pci/css_2401_system/host/isys_irq_local.h | 4 +-

Re: [PATCH V2 3/6] perf tools: Use AsciiDoc formatting for --control option documentation

2020-09-02 Thread Alexey Budankov
On 01.09.2020 12:37, Adrian Hunter wrote: > The --control option does not display well in man pages unless AsciiDoc > formatting is used. > > Signed-off-by: Adrian Hunter > --- > tools/perf/Documentation/perf-record.txt | 46 > tools/perf/Documentation/perf-stat.txt

[PATCH 37/38] media: atomisp: atomisp_gmin_platform: check before use

2020-09-02 Thread Mauro Carvalho Chehab
solve this smatch warning: drivers/staging/media/atomisp/pci/atomisp_gmin_platform.c:842 gmin_v1p8_ctrl() warn: variable dereferenced before check 'gs' (see line 832) By moving the check to happen before its usage. Signed-off-by: Mauro Carvalho Chehab ---

[PATCH 35/38] media: atomisp: fix some bad indents

2020-09-02 Thread Mauro Carvalho Chehab
As smatch reports, there are several bad indents: drivers/staging/media/atomisp/pci/hmm/hmm.c:271 hmm_alloc() warn: inconsistent indenting drivers/staging/media/atomisp/pci/runtime/bufq/src/bufq.c:390 ia_css_bufq_enqueue_psys_event() warn: inconsistent indenting

[PATCH 38/38] media: atomisp: cleanup isys_irq headers

2020-09-02 Thread Mauro Carvalho Chehab
Don't need to declare those functions with extern: drivers/staging/media/atomisp/pci/css_2401_system/host/isys_irq_private.h:51:35: warning: function 'isys_irqc_state_dump' with external linkage has definition

Re: [PATCH -v2] scipts/tags.sh: Add custom sort order

2020-09-02 Thread Masahiro Yamada
On Thu, Sep 3, 2020 at 12:58 AM Masahiro Yamada wrote: > > On Fri, Aug 7, 2020 at 2:28 AM wrote: > > > > > > One long standing annoyance I have with using vim-tags is that our tags > > file is not properly sorted. That is, the sorting exhuberant Ctags does > > is only on the tag itself. > > > >

[PATCH 12/38] media: vivid: place dt timings init code on a separate function

2020-09-02 Thread Mauro Carvalho Chehab
Move those out of the big vivid_create_instance() function. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/test-drivers/vivid/vivid-core.c | 76 +++ 1 file changed, 44 insertions(+), 32 deletions(-) diff --git a/drivers/media/test-drivers/vivid/vivid-core.c

Re: [PATCH V2 2/6] perf tools: Handle read errors from ctl_fd

2020-09-02 Thread Alexey Budankov
On 01.09.2020 12:37, Adrian Hunter wrote: > Handle read errors from ctl_fd such as EINTR, EAGAIN and EWOULDBLOCK. > > Signed-off-by: Adrian Hunter > --- > tools/perf/util/evlist.c | 16 +++- > 1 file changed, 11 insertions(+), 5 deletions(-) Acked-by: Alexei Budankov Regards,

[PATCH 19/38] media: cx88-alsa: number of pages should be unsigned long

2020-09-02 Thread Mauro Carvalho Chehab
As reported by smatch: drivers/media/pci/cx88/cx88-alsa.c:286 cx88_alsa_dma_init() warn: should 'nr_pages << 12' be a 64 bit type? the number of patches should be unsigned long. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/pci/cx88/cx88-alsa.c | 13 +++-- 1 file

[PATCH 03/38] media: qt1010: fix usage of unititialized value

2020-09-02 Thread Mauro Carvalho Chehab
As pointed by smatch: drivers/media/tuners/qt1010.c:239 qt1010_init_meas1() error: uninitialized symbol 'val2'. drivers/media/tuners/qt1010.c:273 qt1010_init_meas2() error: uninitialized symbol 'val'. The logic is ok, but it is hard for static analyzers to parse it, as it

[PATCH 34/38] media: atomisp: remove compile-time tests from input_system_global.h

2020-09-02 Thread Mauro Carvalho Chehab
Now that there's no duplication between ISP2400 and ISP2401 input system functions, we can include both at the system global. Signed-off-by: Mauro Carvalho Chehab --- drivers/staging/media/atomisp/pci/input_system_global.h | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git

[PATCH 05/38] media: wl128x: get rid of a potential spectre issue

2020-09-02 Thread Mauro Carvalho Chehab
As reported by smatch: drivers/media/radio/wl128x/fmdrv_common.c:736 fm_irq_handle_rdsdata_getcmd_resp() warn: potential spectre issue 'rds_fmt.data.groupdatabuff.buff> Address it by using array_index_nospec(). While here, reorder the linux/ includes. Signed-off-by: Mauro Carvalho

Re: [PATCH v33 11/21] x86/sgx: Linux Enclave Driver

2020-09-02 Thread Sean Christopherson
On Tue, Sep 01, 2020 at 10:06:32PM -0500, Haitao Huang wrote: > On Fri, 03 Jul 2020 22:31:10 -0500, Jarkko Sakkinen > wrote: > > > On Wed, Jul 01, 2020 at 08:59:02PM -0700, Sean Christopherson wrote: > > > On Thu, Jun 18, 2020 at 01:08:33AM +0300, Jarkko Sakkinen wrote: > > > > +static int

[PATCH 06/38] media: venus: place extern venus_fw_debug on a header file

2020-09-02 Thread Mauro Carvalho Chehab
Sparse warns about this symbol: drivers/media/platform/qcom/venus/hfi_venus.c:133:5: warning: symbol 'venus_fw_debug' was not declared. Should it be static? Because hfi_venus.c doesn't include a header file with the extern. So, move it to core.h, with is included by both hfi_venus.c

Re: [PATCH -next] perf bench: fix return value check in do_run_multi_threaded()

2020-09-02 Thread Ian Rogers
On Wed, Sep 2, 2020 at 7:06 AM YueHaibing wrote: > > In case of error, the function perf_session__new() returns ERR_PTR() > and never returns NULL. The NULL test in the return value check > should be replaced with IS_ERR() > > Fixes: 13edc237200c ("perf bench: Add a multi-threaded synthesize

Re: [PATCH v2] x86/asm: Replace __force_order with memory clobber

2020-09-02 Thread Arvind Sankar
On Wed, Sep 02, 2020 at 11:33:46AM -0400, Arvind Sankar wrote: > Fix this by: > - Using a memory clobber for the write functions to additionally prevent > caching/reordering memory accesses across CRn writes. > - Using a dummy input operand with an arbitrary constant address for the > read

Re: WARNING: suspicious RCU usage - sdhci-pltfm: SDHCI platform and OF driver helper

2020-09-02 Thread Ulf Hansson
On Wed, 2 Sep 2020 at 15:52, Paul E. McKenney wrote: > > On Wed, Sep 02, 2020 at 08:49:11AM +0200, Ulf Hansson wrote: > > On Tue, 1 Sep 2020 at 17:00, Paul E. McKenney wrote: > > [ . . . ] > > > > Here is the list, though it is early in the morning here: > > > > > > 1. RCU_NONIDLE(). > > >

Re: [PATCH V2 1/6] perf tools: Consolidate --control option parsing into one function

2020-09-02 Thread Alexey Budankov
On 01.09.2020 12:37, Adrian Hunter wrote: > Consolidate --control option parsing into one function, in preparation for > adding FIFO file name options. > > Signed-off-by: Adrian Hunter > --- > tools/perf/builtin-record.c | 22 ++ > tools/perf/builtin-stat.c | 22

[PATCH v7 3/5] perf jevents: Add support for parsing perchip/percore events

2020-09-02 Thread Kajol Jain
Initially, every time we want to add new terms like chip, core thread etc, we need to create corrsponding fields in pmu_events and event struct. This patch adds an enum called 'aggr_mode_class' which store all these aggregation like perchip/percore. It also adds new field 'aggr_mode' to capture

Re: [PATCH 04/10] dt-bindings: mfd: syscon: Document Samsung Exynos compatibles

2020-09-02 Thread Krzysztof Kozlowski
On Sat, Aug 29, 2020 at 04:24:55PM +0200, Krzysztof Kozlowski wrote: > Samsung Exynos SoCs use syscon for system registers so document its > compatibles. > > Signed-off-by: Krzysztof Kozlowski > --- > Documentation/devicetree/bindings/mfd/syscon.yaml | 4 > 1 file changed, 4 insertions(+)

Re: [PATCHv2 net-next] dropwatch: Support monitoring of dropped frames

2020-09-02 Thread Izabela Bakollari
Thank you for your review. I am working on a patch v3 and will apply your suggestions where possible. Best, Izabela On Mon, Aug 31, 2020 at 3:18 PM Michal Schmidt wrote: > > Dne 04. 08. 20 v 18:09 izabela.bakoll...@gmail.com napsala: > > From: Izabela Bakollari > > > > Dropwatch is a utility

[PATCH v7 5/5] perf/tools/pmu_events/powerpc: Add hv_24x7 core level metric events

2020-09-02 Thread Kajol Jain
This patch adds hv_24x7 core level events in nest_metric.json file and also add PerChip/PerCore field in metric events. Result: power9 platform: command:# ./perf stat --metric-only -M PowerBUS_Frequency -C 0 -I 1000 1.706011.92.0

[PATCH v7 1/5] perf/jevents: Remove jevents.h file

2020-09-02 Thread Kajol Jain
This patch removes jevents.h file. Signed-off-by: Kajol Jain --- tools/perf/pmu-events/jevents.c | 1 - tools/perf/pmu-events/jevents.h | 23 --- 2 files changed, 24 deletions(-) delete mode 100644 tools/perf/pmu-events/jevents.h diff --git

[PATCH v7 2/5] perf/jevents: Add new structure to pass json fields.

2020-09-02 Thread Kajol Jain
This patch adds new structure called 'json_event' inside jevents.h file to improve the callback prototype inside jevent files. Initially, whenever user want to add new field, they need to update in all function callback which make it more and more complex with increased number of parmeters. With

[PATCH v7 4/5] perf/tools: Pass pmu_event structure as a parameter for arch_get_runtimeparam

2020-09-02 Thread Kajol Jain
This patch adds passing of pmu_event as a parameter in function 'arch_get_runtimeparam' which can be used to get details like if the event is percore/perchip. Signed-off-by: Kajol Jain Acked-by: Ian Rogers --- tools/perf/arch/powerpc/util/header.c | 7 +-- tools/perf/util/metricgroup.c

[PATCH v7 0/5] powerpc/perf: Add json file support for hv_24x7 core level events

2020-09-02 Thread Kajol Jain
Patchset enhance current runtime parameter support. It introduces new fields like "PerChip" and "PerCore" similar to the field "PerPkg" which is used to specify perpkg events. The "PerCore" and "PerChip" specifies whether its core or chip events. Based on which we can decide which runtime

Re: [PATCH v2] scsi: Don't call memset after dma_alloc_coherent()

2020-09-02 Thread Alex Dewar
On Tue, Sep 01, 2020 at 09:22:44PM -0400, Martin K. Petersen wrote: > > Alex, > > > dma_alloc_coherent() already zeroes memory, so the extra call to > > memset() is unnecessary. > > One patch per driver, please. Nvm, someone's already beaten me to the punch! > > Thanks! > > -- > Martin K.

[PATCH] lockdep: Fix "USED" <- "IN-NMI" inversions

2020-09-02 Thread peterz
During the LPC RCU BoF Paul asked how come the "USED" <- "IN-NMI" detector doesn't trip over rcu_read_lock()'s lockdep annotation. Looking into this I found a very embarrasing typo in verify_lock_unused(): - if (!(class->usage_mask & LOCK_USED)) + if (!(class->usage_mask &

Re: [PATCH v1 6/6] clk: rockchip: rk3399: Support module build

2020-09-02 Thread Robin Murphy
On 2020-09-02 07:50, Elaine Zhang wrote: support CLK_OF_DECLARE and builtin_platform_driver_probe double clk init method. add module author, description and license to support building Soc Rk3399 clock driver as module. Signed-off-by: Elaine Zhang --- drivers/clk/rockchip/clk-rk3399.c | 40

Re: Boot failure on gru-scarlet-inx with 5.9-rc2

2020-09-02 Thread Lorenzo Pieralisi
On Tue, Sep 01, 2020 at 02:33:56PM -0400, Samuel Dionne-Riel wrote: > On Tue, 1 Sep 2020 17:42:49 +0100 > Lorenzo Pieralisi wrote: > > > On Tue, Sep 01, 2020 at 04:37:42PM +0100, Marc Zyngier wrote: > > > On 2020-09-01 04:45, Samuel Dionne-Riel wrote: > > > > - if

[PATCH] ASoC: dt-bindings: aries-wm8994: Match compatibles with enum

2020-09-02 Thread Krzysztof Kozlowski
The common pattern for enumerating compatibles is enum, not oneOf. Signed-off-by: Krzysztof Kozlowski --- .../bindings/sound/samsung,aries-wm8994.yaml | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git

Re: WARNING: suspicious RCU usage - sdhci-pltfm: SDHCI platform and OF driver helper

2020-09-02 Thread Ulf Hansson
On Wed, 2 Sep 2020 at 14:14, wrote: > > On Wed, Sep 02, 2020 at 09:03:37AM +0200, Ulf Hansson wrote: > > Lots of cpuidle drivers are using CPU_PM notifiers (grep for > > cpu_pm_enter and you will see) from their idlestates ->enter() > > callbacks. And for those we are already calling > >

[PATCH] x86/mm/32: Bring back vmalloc faulting on x86_32

2020-09-02 Thread Joerg Roedel
From: Joerg Roedel One can not simply remove vmalloc faulting on x86-32. Upstream commit: 7f0a002b5a21 ("x86/mm: remove vmalloc faulting") removed it on x86 alltogether because previously the arch_sync_kernel_mappings() interface was introduced. This interface added synchronization of

Re: [PATCH -v2] scipts/tags.sh: Add custom sort order

2020-09-02 Thread Masahiro Yamada
On Fri, Aug 7, 2020 at 2:28 AM wrote: > > > One long standing annoyance I have with using vim-tags is that our tags > file is not properly sorted. That is, the sorting exhuberant Ctags does > is only on the tag itself. > > The problem with that is that, for example, the tag 'mutex' appears a >

Re: [PATCH] perf/core: Fix hung issue on perf stat command during cpu hotplug

2020-09-02 Thread kajoljain
On 9/2/20 8:35 PM, Arnaldo Carvalho de Melo wrote: > Em Thu, Aug 27, 2020 at 12:17:32PM +0530, Kajol Jain escreveu: >> Commit 2ed6edd33a21 ("perf: Add cond_resched() to task_function_call()") >> added assignment of ret value as -EAGAIN in case function >> call to 'smp_call_function_single'

RE: [PATCH v2] x86/asm: Replace __force_order with memory clobber

2020-09-02 Thread David Laight
From: Arvind Sankar > Sent: 02 September 2020 16:34 > > The CRn accessor functions use __force_order as a dummy operand to > prevent the compiler from reordering the inline asm. > > The fact that the asm is volatile should be enough to prevent this > already, however older versions of GCC had a

Re: [PATCH 01/13] x86/entry: Fix AC assertion

2020-09-02 Thread Brian Gerst
On Wed, Sep 2, 2020 at 9:38 AM Peter Zijlstra wrote: > > From: Peter Zijlstra > > The WARN added in commit 3c73b81a9164 ("x86/entry, selftests: Further > improve user entry sanity checks") unconditionally triggers on my IVB > machine because it does not support SMAP. > > For !SMAP hardware we

Re: [PATCH v7 6/6] Documentation: ACPI: Document allow-low-power-probe _DSD property

2020-09-02 Thread Rafael J. Wysocki
On Tue, Sep 1, 2020 at 11:03 PM Sakari Ailus wrote: > > Document the probe-low-power _DSD property and how it is used with I²C > drivers. I would reorder the series to make this go right after the [1/6] or maybe even fold it into that patch. The point is that the changes in [1/6] clearly depend

[PATCH v2 1/2] ARM: dts: exynos: Remove I2C9 samsung,i2c-slave-addr from Exynos5250 boards

2020-09-02 Thread Krzysztof Kozlowski
The property samsung,i2c-slave-addr in I2C9 controller on Exynos5250 Arndale and SMDK5250 boards, is not actually needed. There is only one master on this bus. It's not clear why this property was added at first place. Tested-by: Marek Szyprowski Signed-off-by: Krzysztof Kozlowski ---

[PATCH v2 2/2] ARM: dts: exynos: Silence SATA PHY warning in Exynos5250

2020-09-02 Thread Krzysztof Kozlowski
The SATA PHY in Exynos5250 SoCs has two interfaces and two device nodes: 1. sata-phy@1217 2. i2c-9/i2c@38 The first node represents the actual SATA PHY device with phy-cells. The second represents an additional I2C interface, needed by the driver to communicate with the SATA PHY device. It

Uli Behringer is a racist and a sexist. Worked at Music Tribe for 30 years (it's name has changed repeatedly).

2020-09-02 Thread formermusictribemember
Uli Behringer is a racist and a sexist. Worked at Music Tribe for 30 years (it's name has changed repeatedly) Cons of working at Music Tribe: Uli Behringer, the CEO, is a racist and a sexist. You can tell by the way he presents himself: plastic surgery to uphold his boyish youthful looks;

[ANNOUNCE] v5.9-rc3-rt3

2020-09-02 Thread Sebastian Andrzej Siewior
Dear RT folks! I'm pleased to announce the v5.9-rc3-rt3 patch set. Changes since v5.9-rc3-rt2: - Correct a compile issue in the i915 driver. Reported by Carsten Emde and Daniel Wagner. - Mark Marshall reported a crash on PowerPC. The reason for the crash is a race in exec_mmap()

Re: [git pull] epoll fixup

2020-09-02 Thread Marc Zyngier
On 2020-09-02 16:37, Al Viro wrote: Fixup for epoll regression; there's a better solution longer term, but this is the least intrusive fix. The following changes since commit 52c479697c9b73f628140dcdfcd39ea302d05482: do_epoll_ctl(): clean the failure exits up a bit (2020-08-22 18:25:52

Re: [PATCH 19/19] block: remove check_disk_change

2020-09-02 Thread Johannes Thumshirn
Looks good, Reviewed-by: Johannes Thumshirn

Re: [RFC PATCH 3/6] mm: Push readahead_control down into force_page_cache_readahead() [ver #2]

2020-09-02 Thread Matthew Wilcox
On Wed, Sep 02, 2020 at 04:44:38PM +0100, David Howells wrote: > +++ b/mm/fadvise.c > @@ -104,7 +104,10 @@ int generic_fadvise(struct file *file, loff_t offset, > loff_t len, int advice) > if (!nrpages) > nrpages = ~0UL; > > -

Re: Question on task_blocks_on_rt_mutex()

2020-09-02 Thread Paul E. McKenney
On Tue, Sep 01, 2020 at 06:51:28PM -0700, Davidlohr Bueso wrote: > On Tue, 01 Sep 2020, Paul E. McKenney wrote: > > > And it appears that a default-niced CPU-bound SCHED_OTHER process is > > not preempted by a newly awakened MAX_NICE SCHED_OTHER process. OK, > > OK, I never waited for more than

Re: [PATCH v1 1/6] clk: rockchip: Use clk_hw_register_composite instead of clk_register_composite calls

2020-09-02 Thread Robin Murphy
On 2020-09-02 07:48, Elaine Zhang wrote: clk_hw_register_composite it's already exported. Preparation for compilation of rK common clock drivers into modules. Signed-off-by: Elaine Zhang --- drivers/clk/rockchip/clk-half-divider.c | 12 + drivers/clk/rockchip/clk.c | 35

Re: [PATCH 18/19] sr: simplify sr_block_revalidate_disk

2020-09-02 Thread Johannes Thumshirn
Looks good, Reviewed-by: Johannes Thumshirn

Re: [PATCH 17/19] sr: use bdev_check_media_change

2020-09-02 Thread Johannes Thumshirn
Looks good, Reviewed-by: Johannes Thumshirn

Re: [PATCH 16/19] sd: use bdev_check_media_change

2020-09-02 Thread Johannes Thumshirn
On 02/09/2020 16:21, Christoph Hellwig wrote: > call cd_revalidate_disk manually. As sd also calls sd_revalidate_disk ^~ sd_revalidate_disk Otherwise, Reviewed-by: Johannes Thumshirn

Re: [PATCH v2] scsi: Don't call memset after dma_alloc_coherent()

2020-09-02 Thread Alex Dewar
On Tue, Sep 01, 2020 at 09:22:44PM -0400, Martin K. Petersen wrote: > > Alex, > > > dma_alloc_coherent() already zeroes memory, so the extra call to > > memset() is unnecessary. > > One patch per driver, please. There's a single patch for QLA2XXX already submitted:

Re: [PATCH v2] mmc: mmc_spi: Allow the driver to be built when CONFIG_HAS_DMA is unset

2020-09-02 Thread Geert Uytterhoeven
Hi Rich, On Wed, Sep 2, 2020 at 5:43 PM Rich Felker wrote: > On Wed, Sep 02, 2020 at 10:31:47AM +0200, Ulf Hansson wrote: > > On Tue, 1 Sep 2020 at 17:40, Christoph Hellwig wrote: > > > On Tue, Sep 01, 2020 at 05:36:17PM +0200, Ulf Hansson wrote: > > > > > I still don't think this makes sense,

Re: [PATCH][next] charger-manager: fix incorrect check on charging_duration_ms

2020-09-02 Thread Randy Dunlap
On 9/2/20 6:31 AM, Colin King wrote: > From: Colin Ian King > > Currently the duration check on the discharging duration setting is > checking the charging duration rather than the discharging duration > due to a cut-n-paste coding error. Fix this by checking the value >

Re: [PATCH 15/19] md: use bdev_check_media_change

2020-09-02 Thread Johannes Thumshirn
On 02/09/2020 16:16, Christoph Hellwig wrote: > The pcd driver does not have a ->revalidate_disk method, so it can just md ~^ Otherwise looks good, Reviewed-by: Johannes Thumshirn

Re: [PATCH 2/5] input: misc: Add IBM Operation Panel driver

2020-09-02 Thread Eddie James
On 9/1/20 1:11 AM, Wolfram Sang wrote: + switch (event) { + case I2C_SLAVE_STOP: + command_size = panel->idx; + fallthrough; + case I2C_SLAVE_WRITE_REQUESTED: + panel->idx = 0; + break; + case

Re: [PATCH v5 3/5] cpufreq: report whether cpufreq supports Frequency Invariance (FI)

2020-09-02 Thread Sudeep Holla
On Tue, Sep 01, 2020 at 09:55:47PM +0100, Ionela Voinescu wrote: > Now that the update of the FI scale factor is done in cpufreq core for > selected functions - target(), target_index() and fast_switch(), > we can provide feedback to the task scheduler and architecture code > on whether cpufreq

Re: [PATCH 24/33] ARM: dts: exynos: Correct compatible of fixed clocks in Midas boards

2020-09-02 Thread Krzysztof Kozlowski
On Sun, Aug 30, 2020 at 03:51:51PM +0200, Krzysztof Kozlowski wrote: > The fixed clocks implemented by Samsung clock drivers use only one > compatible so drop the additional "fixed-clock" to fix dtbs_check > warnings like: > > arch/arm/boot/dts/exynos4412-i9300.dt.yaml: xxti: compatible:0: >

Re: [PATCH 13/19] ide-cd: remove idecd_revalidate_disk

2020-09-02 Thread Johannes Thumshirn
Looks good, Reviewed-by: Johannes Thumshirn

Re: [PATCH 12/19] ide-cd: use bdev_check_media_changed

2020-09-02 Thread Johannes Thumshirn
Looks good, Reviewed-by: Johannes Thumshirn

Re: [PATCH v5 00/21] kprobes: Unify kretprobe trampoline handlers and make kretprobe lockless

2020-09-02 Thread Masami Hiramatsu
On Wed, 2 Sep 2020 11:36:13 +0200 pet...@infradead.org wrote: > On Wed, Sep 02, 2020 at 05:17:55PM +0900, Masami Hiramatsu wrote: > > > > Ok, but then lockdep will yell at you if you have that enabled and run > > > the unoptimized things. > > > > Oh, does it warn for all spinlock things in

[PATCH v3 6/6] perf tests tsc: Add checking helper is_supported()

2020-09-02 Thread Leo Yan
So far tsc is enabled on x86_64, i386 and Arm64 architectures, add checking helper to skip this testing for other architectures. Signed-off-by: Leo Yan --- tools/perf/tests/builtin-test.c | 1 + tools/perf/tests/perf-time-to-tsc.c | 13 + tools/perf/tests/tests.h|

[PATCH 1/2] ASoC: codec: tlv320aic32x4: fix missing aic32x4_disable_regulators() in error path

2020-09-02 Thread Matthias Schiffer
The regulators need to be disabled in the aic32x4_register_clocks() failure case as well. Fixes: 9d4befff5a95 ("ASoC: codec: tlv3204: Moving GPIO reset and add ADC reset") Signed-off-by: Matthias Schiffer --- sound/soc/codecs/tlv320aic32x4.c | 10 +++--- 1 file changed, 7 insertions(+), 3

[PATCH][next] charger-manager: fix incorrect check on charging_duration_ms

2020-09-02 Thread Colin King
From: Colin Ian King Currently the duration check on the discharging duration setting is checking the charging duration rather than the discharging duration due to a cut-n-paste coding error. Fix this by checking the value desc->charging_max_duration_ms. Addresses-Coverity: ("Copy-paste-error")

Re: [GIT PULL] perf tools fixes for v5.9

2020-09-02 Thread Arnaldo Carvalho de Melo
Em Tue, Sep 01, 2020 at 07:43:33PM -0700, Linus Torvalds escreveu: > On Tue, Sep 1, 2020 at 3:42 PM Arnaldo Carvalho de Melo > wrote: > > > > - The SNOOPX and REMOTE offsets in the data_src bitmask in perf records were > > were both 37, SNOOPX is 38, fix it. > > The kernel uapi side thinks

[PATCH net-next] net: dp83869: Add ability to advertise Fiber connection

2020-09-02 Thread Dan Murphy
Add the ability to advertise the Fiber connection if the strap or the op-mode is configured for 100Base-FX. Auto negotiation is not supported on this PHY when in fiber mode. Signed-off-by: Dan Murphy --- drivers/net/phy/dp83869.c | 35 +++ 1 file changed, 35

[PATCH 2/2] ASoC: codec: tlv320aic32x4: do software reset before clock registration

2020-09-02 Thread Matthias Schiffer
To avoid the actual PLL settings to differ from the state expected by the clock driver, the codec should only be fully reset before the clocks are registered. But we also need to ensure that the software reset happens at all before clock registration, as not all boards have a reset GPIO. Move the

Re: [PATCH v5 2/5] cpufreq: move invariance setter calls in cpufreq core

2020-09-02 Thread Sudeep Holla
On Tue, Sep 01, 2020 at 09:55:46PM +0100, Ionela Voinescu wrote: > To properly scale its per-entity load-tracking signals, the task scheduler > needs to be given a frequency scale factor, i.e. some image of the current > frequency the CPU is running at. Currently, this scale can be computed >

Re: [PATCH v5 1/5] arch_topology: validate input frequencies to arch_set_freq_scale()

2020-09-02 Thread Sudeep Holla
On Tue, Sep 01, 2020 at 09:55:45PM +0100, Ionela Voinescu wrote: > The current frequency passed to arch_set_freq_scale() could end up > being 0, signaling an error in setting a new frequency. Also, if the > maximum frequency in 0, this will result in a division by 0 error. > > Therefore, validate

[PATCH] staging/emxx_udc: Remove pointless variable assignments

2020-09-02 Thread Alex Dewar
In a number of places in emxx_udc.c, there are variables which are assigned to without that value ever being used. Remove these pointless assignments. Reported-by: kernel test robot Fixes: 33aa8d45a4fe ("staging: emxx_udc: Add Emma Mobile USB Gadget driver") Signed-off-by: Alex Dewar ---

[PATCH v3 5/6] perf tests tsc: Make tsc testing as a common testing

2020-09-02 Thread Leo Yan
x86 arch provides the testing for conversion between tsc and perf time, the testing is located in x86 arch folder. Move this testing out from x86 arch folder and place it into the common testing folder, so allows to execute tsc testing on other architectures (e.g. Arm64). Signed-off-by: Leo Yan

Re: general protection fault in snd_ctl_release

2020-09-02 Thread Takashi Iwai
On Wed, 02 Sep 2020 17:35:30 +0200, Al Viro wrote: > > On Wed, Sep 02, 2020 at 05:22:00PM +0200, Takashi Iwai wrote: > > > Marc, Al, could you guys check this bug? > > That's racy; the first one should be get_file_rcu() instead of > file_count()+get_file(), the second is not needed at all (we >

Re: [PATCH v2 11/11] lockdep,trace: Expose tracepoints

2020-09-02 Thread Guenter Roeck
On 9/2/20 12:24 AM, pet...@infradead.org wrote: > On Tue, Sep 01, 2020 at 08:51:46PM -0700, Guenter Roeck wrote: >> On Fri, Aug 21, 2020 at 10:47:49AM +0200, Peter Zijlstra wrote: >>> The lockdep tracepoints are under the lockdep recursion counter, this >>> has a bunch of nasty side effects: >>>

[RFC PATCH 5/6] mm: Fold ra_submit() into do_sync_mmap_readahead() [ver #2]

2020-09-02 Thread David Howells
Fold ra_submit() into its last remaining user and pass the previously added readahead_control struct down into __do_page_cache_readahead(). Signed-off-by: David Howells --- mm/filemap.c |6 +++--- mm/internal.h | 10 -- 2 files changed, 3 insertions(+), 13 deletions(-) diff

[PATCH 00/13] x86/debug: Untangle handle_debug()

2020-09-02 Thread Peter Zijlstra
Hi, The first two patches probably ought to go in x86/urgent, the rest (!RFC) can go into x86/core and wait a bit. handle_debug() is a mess, and now that we have separate user and kernel paths, try and clean it up a bit. There's two RFC patches at the end that impact the

[RFC][PATCH 12/13] x86/debug: Support negative polarity DR6 bits

2020-09-02 Thread Peter Zijlstra
DR6 has a whole bunch of bits that have negative polarity; they were architecturally reserved and defined to be 1 and are now getting used. Since they're 1 by default, 0 becomes the signal value. Handle this by xor'ing the read DR6 value by the reserved mask, this will flip them around such that

[PATCH 09/13] x86/debug: Remove the historical junk

2020-09-02 Thread Peter Zijlstra
Remove the historical junk and replace it with a WARN and a comment. The problem is that even though the kernel only uses TF single-step in kprobes and KGDB, both of which consume the event before this, QEMU/KVM has bugs in this area that can trigger this state so we have to deal with it.

[RFC PATCH 0/6] mm: Make more use of readahead_control [ver #2]

2020-09-02 Thread David Howells
Hi Willy, Here's a set of patches to expand the use of the readahead_control struct, essentially from do_sync_mmap_readahead() down. It's on top of: http://git.infradead.org/users/willy/pagecache.git Also pass file_ra_state into force_page_cache_readahead(). The bugfix for

Re: [PATCH 11/19] gdrom: use bdev_check_media_change

2020-09-02 Thread Johannes Thumshirn
Looks good, Reviewed-by: Johannes Thumshirn

[RFC PATCH 4/6] mm: Pass readahead_control into page_cache_{sync,async}_readahead() [ver #2]

2020-09-02 Thread David Howells
Pass struct readahead_control into the page_cache_{sync,async}_readahead() functions in preparation for making do_sync_mmap_readahead() pass down an RAC struct. Signed-off-by: David Howells --- fs/btrfs/free-space-cache.c |4 +++- fs/btrfs/ioctl.c|9 ++---

Re: [PATCH 22/33] ARM: dts: exynos: Align MHL GPIO pin configuration with dtschema on Galaxy I9100

2020-09-02 Thread Krzysztof Kozlowski
On Sun, Aug 30, 2020 at 03:51:49PM +0200, Krzysztof Kozlowski wrote: > Align the name of mag-mhl-gpio node to avoid dtschema confusion and > dtbs_check warning: > > arch/arm/boot/dts/exynos4210-i9100.dt.yaml: pinctrl@1100: mag-mhl-gpio: > {'samsung,pins': ['gpd0-2'],

[RFC PATCH 6/6] mm: Pass a file_ra_state struct into force_page_cache_readahead() [ver #2]

2020-09-02 Thread David Howells
Pass a file_ra_state struct into force_page_cache_readahead(). One caller has one that should be passed in and the other doesn't, but the former needs to pass its in. Signed-off-by: David Howells --- mm/fadvise.c |3 ++- mm/internal.h |3 ++- mm/readahead.c |5 ++--- 3 files

[RFC PATCH 3/6] mm: Push readahead_control down into force_page_cache_readahead() [ver #2]

2020-09-02 Thread David Howells
Push readahead_control down into force_page_cache_readahead() from its callers in preparation for making do_sync_mmap_readahead() pass down an RAC struct. Signed-off-by: David Howells --- mm/fadvise.c |5 - mm/internal.h |3 +-- mm/readahead.c | 19 +++ 3 files

[RFC PATCH 1/6] Fix khugepaged's request size in collapse_file() [ver #2]

2020-09-02 Thread David Howells
collapse_file() in khugepaged passes PAGE_SIZE as the number of pages to be read ahead to page_cache_sync_readahead(). It seems this was expressed as a number of bytes rather than a number of pages. Fix it to use the number of pages to the end of the window instead. Fixes: 99cb0dbd47a1

<    2   3   4   5   6   7   8   9   10   11   >