On Tue, Sep 08, 2020 at 06:36:19AM +0100, Christoph Hellwig wrote:
> On Mon, Sep 07, 2020 at 09:18:50PM +0100, Tom Murphy wrote:
> > Yeah we talked about passing an attr to map_sg to disable merging at
> > the following microconfernce:
> > https://linuxplumbersconf.org/event/7/contributions/846/
>
Device Feature List (DFL) is a linked list of feature headers within the
device MMIO space. It is used by FPGA to enumerate multiple sub features
within it. Each feature can be uniquely identified by DFL type and
feature id, which can be read out from feature headers.
A dfl bus helps DFL
In order to support MODULE_DEVICE_TABLE() for dfl device driver, this
patch moves struct dfl_device_id to mod_devicetable.h
Signed-off-by: Xu Yilun
Signed-off-by: Wu Hao
Signed-off-by: Matthew Gerlach
Signed-off-by: Russ Weight
---
drivers/fpga/dfl.h | 13 +
On Mon, Sep 07, 2020 at 03:53:02PM +0200, Daniel Vetter wrote:
> On Mon, Sep 7, 2020 at 1:24 PM Gerd Hoffmann wrote:
> >
> > Add drm_device argument to drm_prime_pages_to_sg(), so we can
> > call dma_max_mapping_size() to figure the segment size limit
> > and call into
Hi Peter
On 9/7/2020 6:23 PM, pet...@infradead.org wrote:
According to the original comment in __crash_kexec, the mutex was used to
prevent a sys_kexec_load, while crash_kexec is executed. Your proposed patch
does not lock the mutex in crash_kexec.
Sure, but any mutex taker will (spin) wait
t...@redhat.com wrote:
> clang static analyzer reports this problem
>
> mac.c:6204:2: warning: Attempt to free released memory
> kfree(ar->mac.sbands[NL80211_BAND_2GHZ].channels);
> ^
>
> The channels pointer is allocated in
Rakesh Pillai wrote:
> Add an additional regulator supply as an optional
> property for WCN3990.
>
> Tested-on: WCN3990 hw1.0 SNOC WLAN.HL.3.1-01040-QCAHLSWMTPLZ-1
>
> Signed-off-by: Rakesh Pillai
> Reviewed-by: Douglas Anderson
> Acked-by: Rob Herring
> Signed-off-by: Kalle Valo
2
On Mon, 2020-09-07 at 16:09 +0200, Greg Kroah-Hartman wrote:
> On Mon, Sep 07, 2020 at 09:51:15PM +0800, Frankie Chang wrote:
> > On Mon, 2020-09-07 at 14:25 +0200, Greg Kroah-Hartman wrote:
> > > On Mon, Sep 07, 2020 at 08:00:55PM +0800, Frankie Chang wrote:
> > > > From: "Frankie.Chang"
> > > >
Hi all,
After merging the rcu tree, today's linux-next build (x86_64 allmodconfig)
failed like this:
ERROR: modpost: "resched_cpu" [kernel/scftorture.ko] undefined!
Caused by commit
20c881d0592c ("scftorture: Add an alternative IPI vector")
I have reverted that commit for today.
--
On Mon, Sep 07, 2020 at 09:18:50PM +0100, Tom Murphy wrote:
> Yeah we talked about passing an attr to map_sg to disable merging at
> the following microconfernce:
> https://linuxplumbersconf.org/event/7/contributions/846/
> As far as I can remember everyone seemed happy with that solution. I
>
From: "Isaac J. Manjarres"
Older chipsets may not be allowed to configure certain LLCC registers
as that is handled by the secure side software. However, this is not
the case for newer chipsets and they must configure these registers
according to the contents of the SCT table, while keeping in
Le 07/09/2020 à 22:12, Mike Rapoport a écrit :
On Mon, Sep 07, 2020 at 08:00:55PM +0200, Gerald Schaefer wrote:
This is v2 of an RFC previously discussed here:
https://lore.kernel.org/lkml/20200828140314.8556-1-gerald.schae...@linux.ibm.com/
Patch 1 is a fix for a regression in gup_fast on
Le 07/09/2020 à 20:00, Gerald Schaefer a écrit :
From: Alexander Gordeev
Since pXd_addr_end() macros take pXd page-table entry as a
parameter it makes sense to check the entry type on compile.
Even though most archs do not make use of page-table entries
in pXd_addr_end() calls, checking the
Le 07/09/2020 à 20:00, Gerald Schaefer a écrit :
From: Alexander Gordeev
Unlike all other page-table abstractions pXd_addr_end() do not take
into account a particular table entry in which context the functions
are called. On architectures with dynamic page-tables folding that
might lead to
On 09/07/2020 05:46 PM, Will Deacon wrote:
> On Mon, Aug 17, 2020 at 05:34:23PM +0530, Anshuman Khandual wrote:
>> HWCAP name arrays (hwcap_str, compat_hwcap_str, compat_hwcap2_str) that are
>> scanned for /proc/cpuinfo are detached from their bit definitions making it
>> vulnerable and
> Subject: RE: [PATCH V2 2/3] pinctrl: imx: Support building SCU pinctrl core
> driver as module
>
> > From: Anson Huang
> > Sent: Monday, September 7, 2020 8:33 PM
> >
> > Change PINCTR_IMX_SCU to tristate, remove unnecessary #ifdef and add
> > module author, description and license to
Le 07/09/2020 à 20:00, Gerald Schaefer a écrit :
From: Alexander Gordeev
Commit 1a42010cdc26 ("s390/mm: convert to the generic get_user_pages_fast
code") introduced a subtle but severe bug on s390 with gup_fast, due to
dynamic page table folding.
The question "What would it require for the
On 27-08-20, 15:28, Swapnil Jakhade wrote:
> Cadence Torrent PHY is a multiprotocol PHY supporting different multilink
> PHY configurations including DisplayPort, PCIe, USB, SGMII, QSGMII etc.
> Existing Torrent PHY driver supports only DisplayPort. This patch series
> prepares Torrent PHY driver
> Subject: RE: [PATCH V2 1/3] pinctrl: imx: Use function callbacks for SCU
> related functions
>
> > From: Anson Huang
> > Sent: Monday, September 7, 2020 8:33 PM
> >
> > Use function callbacks for SCU related functions in pinctrl-imx.c in
> > order to support the scenario of PINCTRL_IMX is
On Mon, Sep 07, 2020 at 06:00:29PM +0200, Corentin Labbe wrote:
>
> The put_unaligned should be _le32.
>
> This fix the modprobe tcrypt fail.
Thanks. Yes the original code was correct.
---8<---
This patch also fixes the incorrect endianness markings in the
sun4i-ss driver. It should have no
On 07-09-20, 15:27, Pali Rohár wrote:
> CONFIG_ARM_ARMADA_37XX_CPUFREQ is tristate option and therefore this
> cpufreq driver can be compiled as a module. This patch adds missing
> MODULE_DEVICE_TABLE which generates correct modalias for automatic
> loading of this cpufreq driver when is compiled
Christian Brauner writes:
> On Fri, Sep 04, 2020 at 04:31:39PM -0400, Gabriel Krisman Bertazi wrote:
>> index afe01e232935..3511c98a7849 100644
>> --- a/include/linux/sched.h
>> +++ b/include/linux/sched.h
>> @@ -959,7 +959,11 @@ struct task_struct {
>> kuid_t
Got it.
will investigate asap
On Wed, Sep 2, 2020 at 3:42 AM kernel test robot wrote:
>
> Greeting,
>
> FYI, we noticed the following commit (built with gcc-9):
>
> commit: 70f06a871f5d40ca8f977eb412358ab03b6804da ("[PATCH v3 3/3] dyndbg: fix
> problem parsing format="foo bar"")
> url:
>
Hi all,
Today's linux-next merge of the mmc tree got a conflict in:
drivers/mmc/host/Kconfig
between commits:
cb6c03019cdd ("ARM: exynos: stop selecting PLAT_SAMSUNG")
db8230d29c3a ("ARM: s5pv210: don't imply CONFIG_PLAT_SAMSUNG")
from the samsung-krzk tree and commit:
54d8454436a2
On 9/7/20 3:32 PM, Stephen Smalley wrote:
Signed-off-by: Lakshmi Ramasubramanian
Suggested-by: Stephen Smalley
Reported-by: kernel test robot # error: implicit declaration
of function 'vfree'
Reported-by: kernel test robot # error: implicit declaration
of function 'crypto_alloc_shash'
Le 07/09/2020 à 20:00, Gerald Schaefer a écrit :
This is v2 of an RFC previously discussed here:
https://lore.kernel.org/lkml/20200828140314.8556-1-gerald.schae...@linux.ibm.com/
Patch 1 is a fix for a regression in gup_fast on s390, after our conversion
to common gup_fast code. It will
On Mon, Sep 07, 2020 at 12:12:30PM -0400, Arvind Sankar wrote:
> On Wed, Sep 02, 2020 at 03:59:04PM -0700, Nick Desaulniers wrote:
> > Adds a compile time #error to compiler-clang.h setting the effective
> > minimum supported version to clang 10.0.1. A separate patch has already
> > been picked up
It'll multiply given events for cgroups A, B and C.
$ ./perf test -v 68
68: Event multiplication for cgroups :
--- start ---
test child forked, pid 983140
metric expr 1 / IPC for CPI
metric expr instructions / cycles for IPC
found event instructions
found
The metricgroup__copy_metric_events() is to handle metrics events when
multiplying event for cgroups. As the metric events keep pointers to
evsel, it should be refreshed when events are cloned during the
operation.
The perf_stat__collect_metric_expr() is also called in case an event
has a metric
Hello,
When we profile cgroup events with perf stat, it's very annoying to
specify events and cgroups on the command line as it requires the
mapping between events and cgroups. (Note that perf record can use
cgroup sampling but it's not usable for perf stat).
I guess most cases we just want to
The evsel__clone() is to create an exactly same evsel from same
attributes. Note that metric events will be handled by later patch.
It will be used by perf stat to generate separate events for each
cgroup.
Signed-off-by: Namhyung Kim
---
tools/perf/util/evsel.c | 57
The --multiply-cgroup option is a syntax sugar to monitor large number
of cgroups easily. Current command line requires to list all the
events and cgroups even if users want to monitor same events for each
cgroup. This patch addresses that usage by copying given events for
each cgroup on user's
On Mon, Aug 31, 2020 at 12:37 PM Kees Cook wrote:
>
> On Fri, Aug 28, 2020 at 09:56:13PM -0400, Rich Felker wrote:
> > Asynchronous termination of a thread outside of the userspace thread
> > library's knowledge is an unsafe operation that leaves the process in
> > an inconsistent, corrupt, and
There was a request to preprocess the module linker script like we
do for the vmlinux one. (https://lkml.org/lkml/2020/8/21/512)
The difference between vmlinux.lds and module.lds is that the latter
is needed for external module builds, thus must be cleaned up by
'make mrproper' instead of 'make
On Mon, Sep 07, 2020 at 08:32:25AM -0700, t...@redhat.com wrote:
> From: Tom Rix
>
> clang static analyzer reports this problem
>
> sb_edac.c:959:2: warning: Undefined or garbage value
> returned to caller
> return type;
> ^~~
>
> This is a false positive.
>
>
On Sun, Sep 06, 2020 at 02:26:25PM -0700, t...@redhat.com wrote:
> From: Tom Rix
>
> clang static analyzer reports this problem
>
> mac.c:6204:2: warning: Attempt to free released memory
> kfree(ar->mac.sbands[NL80211_BAND_2GHZ].channels);
>
On 25-08-20, 10:03, Chunfeng Yun wrote:
> Use readl_poll_timeout_atomic() to simplify code
Applied all, thanks
--
~Vinod
On Sun, Sep 06, 2020 at 01:05:48PM -0700, t...@redhat.com wrote:
> From: Tom Rix
>
> clang static analyzer reports this problem
>
> init.c:739:8: warning: Called function pointer
> is null (null dereference)
> ret = adapter->if_ops.check_fw_status( ...
>
--
Lieber Freund (Assalamu Alaikum),
Ich bin vor einer privaten Suche auf Ihren E-Mail-Kontakt gestoßen
Ihre Hilfe. Mein Name ist Aisha Al-Qaddafi, eine alleinerziehende
Mutter und eine Witwe
mit drei Kindern. Ich bin die einzige leibliche Tochter des Spätlibyschen
Präsident (verstorbener Oberst
Hi all,
After merging the drm-misc tree, today's linux-next build (x86_64
allmodconfig) produced this warning:
WARNING: modpost: missing MODULE_LICENSE() in
drivers/gpu/drm/panel/panel-samsung-s6e63m0.o
Introduced by commit
b7b23e447687 ("drm/panel: s6e63m0: Break out SPI transport")
--
On Mon, 7 Sep 2020 00:13:39 -0700 Dexuan Cui wrote:
> mlx5_suspend()/resume() keep the network interface, so during hibernation
> netvsc_unregister_vf() and netvsc_register_vf() are not called, and hence
> netvsc_resume() should call netvsc_vf_changed() to switch the data path
> back to the VF
Hi all,
Today's linux-next merge of the drm-intel tree got a conflict in:
drivers/gpu/drm/i915/display/intel_panel.c
between commit:
f8bd54d21904 ("drm/i915: panel: Use atomic PWM API for devs with an external
PWM controller")
from Linus' tree and commit:
6b51e7d23aa8 ("drm/i915:
Following up my yesterdays mail:
This is 5.9.0-rc3-00091-ge28f0104343d on Lenovo t460s that has ran fine up to
5.8.0.
Today I tried reproducing my linking problem with git kernel on my laptop and
got segmentation faults in gcc. This is probably the corresponding dmesg part:
Fixes the following W=1 kernel build warning(s):
drivers/net/ethernet/smsc/smsc911x.c: In function ‘smsc911x_rx_fastforward’:
drivers/net/ethernet/smsc/smsc911x.c:1199:16: warning: variable ‘temp’ set but
not used [-Wunused-but-set-variable]
drivers/net/ethernet/smsc/smsc911x.c: In function
On Tue, 8 Sep 2020 13:00:00 +1000 Stephen Rothwell wrote:
> Hi all,
>
> After merging the net-next tree, today's linux-next build (powerpc
> ppc64_defconfig) produced this warning:
>
> net/bridge/br_multicast.c: In function 'br_multicast_find_port':
> net/bridge/br_multicast.c:1818:21: warning:
Currently we are voting for venus0-ebi path during buffer processing
with an average bandwidth of all the instances and unvoting during
session release.
While video streaming when we try to do XO-SD using the command
"echo mem > /sys/power/state command" , device is not entering
to suspend state
Currently video driver is voting after clk enable and un voting
before clk disable. Basically we should vote before clk enable
and un vote after clk disable.
Corrected this by changing the order of clk enable and clk disable.
Signed-off-by: Mansur Alisha Shaik
---
The intention of this patchset is to correct clock enable and disable
order and vote for venus-ebi and cpucfg paths with average bandwidht
instad of peakbandwidht since with current implementation we are seeing
"video_cc_venus_ctl_axi_clk status stuck at 'off' " warnings and XO-SD
failures while
On Wed, Aug 26, 2020 at 01:16:28PM +0200, Thomas Gleixner wrote:
> This is the second version of providing a base to support device MSI (non
> PCI based) and on top of that support for IMS (Interrupt Message Storm)
> based devices in a halfways architecture independent way.
Booted with quick
Am 2020-09-06 um 12:08 p.m. schrieb Deucher, Alexander:
> [AMD Official Use Only - Internal Distribution Only]
>
>> -Original Message-
>> From: Joerg Roedel
>> Sent: Friday, September 4, 2020 6:06 AM
>> To: Deucher, Alexander
>> Cc: jroe...@suse.de; Kuehling, Felix ;
>>
Hi all,
After merging the nand tree, today's linux-next build (arm
multi_v7_defconfig) failed like this:
drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c: In function
'common_nfc_set_geometry':
drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c:513:33: error: 'chip' undeclared
(first use in this function)
On 2020/9/8 10:40, Guenter Roeck wrote:
> On 9/7/20 12:50 AM, Leizhen (ThunderTown) wrote:
>> Hi, Wim Van Sebroeck, Guenter Roeck:
>> What's your opinion? Guenter Roeck given "Reviewed-by" two weeks ago.
>>
>
> The patch is in my watchdog-next branch, and Wim usually picks it up
> from
On 2020/9/8 9:21, Dave Young wrote:
> Hi,
>
> On 09/07/20 at 09:47pm, Chen Zhou wrote:
>> CONFIG_PHYSICAL_ALIGN can be selected from 2M to 16M and default
>> value is 2M, so move CRASH_ALIGN to 2M, with smaller value reservation
>> can have more chance to succeed.
> Seems still some
On 04/09/2020 16:04, Leonardo Bras wrote:
On Thu, 2020-09-03 at 14:41 +1000, Alexey Kardashevskiy wrote:
I am new to this, so I am trying to understand how a memory page mapped
as DMA, and used for something else could be a problem.
From the device prospective, there is PCI space and
On 09/08/2020 08:37 AM, Huacai Chen wrote:
Hi, all
This patch should be backported to 5.4.
Hi,
Commit 61eee4a7fc40 ("ALSA: hda: Add support for Loongson
7A1000 controller") has been not yet merged into 5.4, so no
need to backport.
Fixed a coding style issue by merging split quoted strings in qlge_main.c
to fix checkpatch warnings.
Signed-off-by: Ross Schmidt
---
drivers/staging/qlge/qlge_main.c | 12 +---
1 file changed, 5 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/qlge/qlge_main.c
Hi all,
After merging the bpf-next tree, today's linux-next build (powerpcle perf)
failed like this:
util/bpf-loader.c: In function 'config_bpf_program':
util/bpf-loader.c:331:2: error: 'bpf_program__title' is deprecated: BPF program
title is confusing term; please use
From: Guangbin Huang
The member link of struct hclge_mac stores the link status of
MAC and PHY if PHY exists, but its annotation uses word "exit",
so fix it.
Signed-off-by: Guangbin Huang
Signed-off-by: Huazhong Tan
---
drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.h | 2 +-
1 file
Since variable send_msg and ret only used in if branch, so move
their definition into the if branch.
Signed-off-by: Huazhong Tan
---
drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_main.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git
From: Guojia Liao
hns3_update_promisc_mode is defined, but not be used, so remove it.
Signed-off-by: Guojia Liao
Signed-off-by: Huazhong Tan
---
drivers/net/ethernet/hisilicon/hns3/hns3_enet.c | 14 --
drivers/net/ethernet/hisilicon/hns3/hns3_enet.h | 1 -
2 files changed, 15
There are some misc updates for the HNS3 ethernet driver.
#1 narrows two local variable range in hclgevf_reset_prepare_wait().
#2 adds reset failure check in periodic service task.
#3~#7 adds some cleanups.
Guangbin Huang (2):
net: hns3: skip periodic service task if reset failed
net: hns3:
From: Guangbin Huang
When reset fails, if there are some pending jobs for the periodic
service task, it does not do anything except print error each
time the task is scheduled. So skip the periodic service task if
reset failed.
Signed-off-by: Guangbin Huang
Signed-off-by: Huazhong Tan
---
'tc_num_last_time' is defined, but never used, so remove it.
Reported-by: Jian Shen
Signed-off-by: Huazhong Tan
---
drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.h
There are several macros related queue defined, but never
used, so remove them.
Signed-off-by: Huazhong Tan
---
drivers/net/ethernet/hisilicon/hns3/hns3_enet.h | 5 -
1 file changed, 5 deletions(-)
diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3_enet.h
'io_base' has been defined and initialized, but never used,
so remove it.
Signed-off-by: Huazhong Tan
---
drivers/net/ethernet/hisilicon/hns3/hns3_enet.c | 2 --
drivers/net/ethernet/hisilicon/hns3/hns3_enet.h | 1 -
2 files changed, 3 deletions(-)
diff --git
Hi all,
After merging the net-next tree, today's linux-next build (powerpc
ppc64_defconfig) produced this warning:
net/bridge/br_multicast.c: In function 'br_multicast_find_port':
net/bridge/br_multicast.c:1818:21: warning: unused variable 'br'
[-Wunused-variable]
1818 | struct net_bridge *br
This patch set the init remote_id to zero, otherwise it will be a random
number.
Then it added the missing subflow's remote_id setting code both in
__mptcp_subflow_connect and in subflow_ulp_clone.
Fixes: 01cacb00b35cb ("mptcp: add netlink-based PM")
Fixes: ec3edaa7ca6ce ("mptcp: Add handling of
On Mon, 07 Sep 2020 13:44:19 -0400
f...@redhat.com (Frank Ch. Eigler) wrote:
> Masami Hiramatsu writes:
>
> > Sorry, for noticing this point, I Cc'd to systemtap. Is systemtap taking
> > care of spinlock too?
>
> On PRREMPT_RT configurations, systemtap uses the raw_spinlock_t
>
In mptcp_pm_nl_get_local_id, skc_local is the same as msk_local, so it
always return 0. Thus every subflow's local_id is 0. It's incorrect.
This patch fixed this issue.
Also, we need to ignore the zero address here, like 0.0.0.0 in IPv4. When
we use the zero address as a local address, it means
v2:
- add Fixes tags;
- simply with 'return addresses_equal';
- use 'reversed Xmas tree' way.
Geliang Tang (2):
mptcp: fix subflow's local_id issues
mptcp: fix subflow's remote_id issues
net/mptcp/pm_netlink.c | 17 +++--
net/mptcp/subflow.c| 7 +--
2 files changed,
> From: Anson Huang
> Sent: Monday, September 7, 2020 8:33 PM
>
> Change PINCTRL_IMX to tristate to support loadable module build.
>
> And i.MX common pinctrl driver should depend on CONFIG_OF to make sure no
> build error when i.MX common pinctrl driver is enabled for different
> architectures
From: Daeho Jeong
The returned integer is not required anywhere. So we need to change
the return value to bool type.
Signed-off-by: Daeho Jeong
---
fs/f2fs/data.c | 2 +-
fs/f2fs/f2fs.h | 17 ++---
fs/f2fs/file.c | 4 ++--
3 files changed, 9 insertions(+), 14 deletions(-)
diff
From: Daeho Jeong
writepages() can be concurrently invoked for the same file by different
threads such as a thread fsyncing the file and a kworker kernel thread.
So, changing i_compr_blocks without protection is racy and we need to
protect it by changing it with atomic type value. Plus, we don't
> From: Anson Huang
> Sent: Monday, September 7, 2020 8:33 PM
>
> Change PINCTR_IMX_SCU to tristate, remove unnecessary #ifdef and add
> module author, description and license to support building SCU pinctrl core
> driver as module.
>
> Signed-off-by: Anson Huang
> ---
> Changes since V1:
>
Thanks Dmitry. I will remove this.
On 9/2/20 4:33 AM, Dmitry Osipenko wrote:
> 31.08.2020 07:40, JC Kuo пишет:
>> +err = devm_request_threaded_irq(>dev, tegra->padctl_irq,
>> +NULL,
>> +tegra_xusb_padctl_irq,
>> +IRQF_ONESHOT |
>
>> +
On 9/7/20 12:50 AM, Leizhen (ThunderTown) wrote:
> Hi, Wim Van Sebroeck, Guenter Roeck:
> What's your opinion? Guenter Roeck given "Reviewed-by" two weeks ago.
>
The patch is in my watchdog-next branch, and Wim usually picks it up
from there.
Guenter
>
> On 2020/8/27 21:40, Guenter Roeck
> From: Anson Huang
> Sent: Monday, September 7, 2020 8:33 PM
>
> Use function callbacks for SCU related functions in pinctrl-imx.c in order to
> support the scenario of PINCTRL_IMX is built in while PINCTRL_IMX_SCU is built
> as module, all drivers using SCU pinctrl driver need to initialize
On 2020/9/7 23:35, Willem de Bruijn wrote:
On Mon, Sep 7, 2020 at 3:38 PM tanhuazhong wrote:
On 2020/9/7 17:22, Willem de Bruijn wrote:
On Sun, Sep 6, 2020 at 8:42 PM Jakub Kicinski wrote:
On Sat, 5 Sep 2020 14:11:11 +0800 Huazhong Tan wrote:
There are two updates relates to UDP
Hi Thierry,
Thanks for review. I will amend accordingly and submit a new revision.
JC
On 8/31/20 8:50 PM, Thierry Reding wrote:
> On Mon, Aug 31, 2020 at 12:40:43PM +0800, JC Kuo wrote:
>> This commit implements the complete programming sequence for ELPG
>> entry and exit.
>>
>> 1. At ELPG
On 8/31/20 8:42 PM, Thierry Reding wrote:
> On Mon, Aug 31, 2020 at 12:40:42PM +0800, JC Kuo wrote:
>> This commit unlinks xhci-tegra platform device with ss/host power
>> domain devices. Reasons for this change is - at elpg entry, phy
>> sleepwalk and wake configuration need to be done before
Register both gpio driver and device as part of driver model, so that
the '-gpio'/'-gpios' dependency in dts can be correctly handled by
of_devlink/of_fwlink.
Signed-off-by: Jianqun Xu
---
drivers/pinctrl/pinctrl-rockchip.c | 305 +
1 file changed, 175 insertions(+),
Hello!
This series performs refactoring of the Tegra I2C driver code and hardens
the atomic-transfer mode.
Changelog:
v6: - Added new patch that adds missing RPM puts, thanks to Andy Shevchenko
for the suggestion.
- Improved commit messages by extending them with more a more detailed
It doesn't make sense to conditionalize the div-clk rate changes because
rate is fixed and it won't ever change once it's set at the driver's probe
time. All further changes are NO-OPs because CCF caches rate and skips
rate-change if rate is unchanged.
Reviewed-by: Michał Mirosław
Signed-off-by:
Use clk-bulk helpers and factor out clocks initialization into separate
function in order to make code cleaner.
The clocks initialization now performed after reset-control initialization
in order to avoid a noisy -PROBE_DEFER errors on T186+ from the clk-bulk
helper which doesn't silence this
The "non_hs_mode" divisor value is fixed, thus there is no need to have
the variable i2c_dev.clk_divisor_non_hs_mode struct member. Let's remove
it and move the mode selection into tegra_i2c_init() where it can be
united with the timing selection.
Reviewed-by: Michał Mirosław
Signed-off-by:
The runtime PM is guaranteed to be always available on Tegra after commit
40b2bb1b132a ("ARM: tegra: enforce PM requirement"). Hence let's remove
all the RPM-availability checking and handling from the code.
Reviewed-by: Michał Mirosław
Signed-off-by: Dmitry Osipenko
---
The error message prints number of vIRQ, which isn't a useful information.
In practice devm_request_irq() never fails, hence let's remove the bogus
message in order to make code cleaner.
Reviewed-by: Michał Mirosław
Signed-off-by: Dmitry Osipenko
---
drivers/i2c/busses/i2c-tegra.c | 4 +---
1
Driver now uses devm_platform_get_and_ioremap_resource() which replaces
the typical boilerplate code and makes code cleaner.
Reviewed-by: Michał Mirosław
Signed-off-by: Dmitry Osipenko
---
drivers/i2c/busses/i2c-tegra.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git
The tegra_i2c_wait_for_config_load() checks for 'has_config_load_reg' by
itself, hence there is no need to duplicate the check.
Signed-off-by: Dmitry Osipenko
---
drivers/i2c/busses/i2c-tegra.c | 9 -
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git
The driver's probe function code is a bit difficult to read. This patch
reorders code of the probe function, forming groups of code that are easy
to work with.
The probe tear-down order now matches the driver-removal order.
All dev/>dev are replaced with i2c_dev->dev in order to have uniform
The barrier() was intended to reduce possibility of racing with the
interrupt handler, but driver's code evolved significantly and today's
driver enables interrupt only when it waits for completion notification.
Hence barrier() has no good use anymore, let's remove it.
Reviewed-by: Michał
Use common helper for retrieval of the interrupt number in order to make
code cleaner. Note that platform_get_irq() prints error message by itself.
Reviewed-by: Michał Mirosław
Signed-off-by: Dmitry Osipenko
---
drivers/i2c/busses/i2c-tegra.c | 9 +++--
1 file changed, 3 insertions(+), 6
Use a single reset_control_reset() instead of assert/deasset couple in
order to make code cleaner a tad. Note that the reset_control_reset()
uses 1 microsecond delay instead of 2 that was used previously, but this
shouldn't matter because one microsecond is a default reset time for most
of Tegra
Move out code related to device-tree parsing from the probe function into
tegra_i2c_parse_dt() in order to make code more consistent.
Reviewed-by: Michał Mirosław
Signed-off-by: Dmitry Osipenko
---
drivers/i2c/busses/i2c-tegra.c | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
Factor out error recovery code from tegra_i2c_xfer_msg() in order to
make this function easier to read and follow.
Reviewed-by: Michał Mirosław
Signed-off-by: Dmitry Osipenko
---
drivers/i2c/busses/i2c-tegra.c | 46 ++
1 file changed, 30 insertions(+), 16
The "dma" variable of tegra_i2c_xfer_msg() function doesn't bring much in
regards to readability and generation of the code.
Besides readability, it's also not very nice that the is_curr_dma_xfer
is initialized in tegra_i2c_xfer_msg() and then could be overridden by
tegra_i2c_config_fifo_trig().
Don't use signed types for unsigned values and use consistent types
for sibling variables.
Signed-off-by: Dmitry Osipenko
---
drivers/i2c/busses/i2c-tegra.c | 38 +-
1 file changed, 19 insertions(+), 19 deletions(-)
diff --git a/drivers/i2c/busses/i2c-tegra.c
The DMA code path has been tested well enough and the DMA configuration
performed by tegra_i2c_config_fifo_trig() shouldn't ever fail in practice.
Hence let's remove the obscure transfer-mode switching in order to have a
cleaner and simpler code. Now I2C transfer will be failed if DMA
The likely/unlikely annotations should be used only in a hot paths of
performance-critical code. The I2C driver doesn't have such paths, and
thus, there is no justification for usage of likely/unlikely annotations
in the code. Hence remove them.
Reviewed-by: Michał Mirosław
Signed-off-by: Dmitry
Factor out register polling into a separate function in order to remove
boilerplate code and make code cleaner.
Reviewed-by: Michał Mirosław
Signed-off-by: Dmitry Osipenko
---
drivers/i2c/busses/i2c-tegra.c | 43 +++---
1 file changed, 19 insertions(+), 24
1 - 100 of 1482 matches
Mail list logo