Re: REGRESSION: 37f4a24c2469: blk-mq: centralise related handling into blk_mq_get_driver_tag

2020-09-25 Thread Shakeel Butt
On Fri, Sep 25, 2020 at 10:22 AM Shakeel Butt wrote: > > On Fri, Sep 25, 2020 at 10:17 AM Linus Torvalds > wrote: > > > > On Fri, Sep 25, 2020 at 9:19 AM Ming Lei wrote: > > > > > > git bisect shows the first bad commit: > > > > > > [10befea91b61c4e2c2d1df06a2e978d182fcf792] mm:

Re: [PATCH] Bluetooth: Fix the vulnerable issue on enc key size

2020-09-25 Thread Marcel Holtmann
Hi Alex, >>> When someone attacks the service provider, it creates connection, >>> authenticates. Then it requests key size of one byte and it identifies >>> the key with brute force methods. >>> >>> After l2cap info req/resp exchange is complete. the attacker sends l2cap >>> connect with

Re: [PATCH v2 0/2] INVD intercept change to skip instruction

2020-09-25 Thread Paolo Bonzini
On 24/09/20 23:20, Jim Mattson wrote: > On Thu, Sep 24, 2020 at 11:42 AM Tom Lendacky wrote: >> >> From: Tom Lendacky >> >> This series updates the INVD intercept support for both SVM and VMX to >> skip the instruction rather than emulating it, since emulation of this >> instruction is just a

Re: [RFC V2 0/9] x86/mmu:Introduce parallel memory virtualization to boost performance

2020-09-25 Thread Ben Gardon
On Fri, Sep 25, 2020 at 5:04 AM yulei zhang wrote: > > On Fri, Sep 25, 2020 at 1:14 AM Ben Gardon wrote: > > > > On Wed, Sep 23, 2020 at 11:28 PM Wanpeng Li wrote: > > > > > > Any comments? Paolo! :) > > > > Hi, sorry to be so late in replying! I wanted to post the first part > > of the TDP MMU

Re: [RFC PATCH v2] tools/x86: add kcpuid tool to show raw CPU features

2020-09-25 Thread Borislav Petkov
On Tue, Sep 22, 2020 at 12:38:30PM -0700, Dave Hansen wrote: > or something. It also needs a "-f" argument to override this default > location. Yah, the -f thing is almost mandatory. I can imagine simply downloading the latest cpuid.leafs or so and then running kcpuid on it. Can't get any better

Re: [RFC PATCH v2] tools/x86: add kcpuid tool to show raw CPU features

2020-09-25 Thread Dave Hansen
On 9/25/20 10:24 AM, Borislav Petkov wrote: > # LEAF,SUBLEAF,register, bits,short name, long name > 1,0, EBX, 7:0,brand,Brand Index > 1,0, EBX, 15:8,clflush_size,CLFLUSH line size (value * 8) > in bytes >1, 0, EBX, 23:16,max_cpu_id,Maxim

Re: [Cocci] coccinelle: Convert comma to semicolons (was Re: [PATCH] checkpatch: Add test for comma use that should be semicolon)

2020-09-25 Thread Joe Perches
On Fri, 2020-09-25 at 19:06 +0200, Julia Lawall wrote: > On Thu, 24 Sep 2020, Joe Perches wrote: > > On Thu, 2020-09-24 at 23:53 +0200, Thomas Gleixner wrote: > > > On Thu, Sep 24 2020 at 13:33, Joe Perches wrote: > > > > On Thu, 2020-09-24 at 22:19 +0200, Thomas Gleixner wrote: > > > > > On Sat,

Re: [RFC PATCH 3/3] KVM: x86: Use KVM_BUG/KVM_BUG_ON to handle bugs that are fatal to the VM

2020-09-25 Thread Sean Christopherson
On Fri, Sep 25, 2020 at 11:50:38AM +0200, Vitaly Kuznetsov wrote: > Sean Christopherson writes: > > > On Thu, Sep 24, 2020 at 02:34:14PM +0200, Vitaly Kuznetsov wrote: > >> Sean Christopherson writes: > >> > diff --git a/arch/x86/kvm/vmx/vmx.c b/arch/x86/kvm/vmx/vmx.c > >> > index

Re: [RFC PATCH v2] tools/x86: add kcpuid tool to show raw CPU features

2020-09-25 Thread Borislav Petkov
On Tue, Sep 22, 2020 at 01:27:50PM +0800, Feng Tang wrote: > +++ b/tools/arch/x86/kcpuid/cpuid.txt > @@ -0,0 +1,58 @@ > +# Leaf 00H > + > +LEAF[],SUBLEAF[00],EAX[ 31:0],max_basic_leafs, Max input value for > supported subleafs > + > + > +# Leaf 01H > + > +LEAF[0001],SUBLEAF[00],EAX[

Re: [PATCH v38 10/24] mm: Add vm_ops->mprotect()

2020-09-25 Thread Dave Hansen
Thanks for the walkthrough. The thing that clicked for me seeing those examples was how the earlier ioctl(ADD_PAGE) is "bound" to later enforcement actions at enclave PTE creation time. On 9/24/20 5:00 PM, Sean Christopherson wrote: > My concern is that if we merge this > >

Re: REGRESSION: 37f4a24c2469: blk-mq: centralise related handling into blk_mq_get_driver_tag

2020-09-25 Thread Roman Gushchin
On Fri, Sep 25, 2020 at 09:47:43AM -0700, Shakeel Butt wrote: > On Fri, Sep 25, 2020 at 9:32 AM Shakeel Butt wrote: > > > > On Fri, Sep 25, 2020 at 9:19 AM Ming Lei wrote: > > > > > > On Fri, Sep 25, 2020 at 03:31:45PM +0800, Ming Lei wrote: > > > > On Thu, Sep 24, 2020 at 09:13:11PM -0400,

Re: REGRESSION: 37f4a24c2469: blk-mq: centralise related handling into blk_mq_get_driver_tag

2020-09-25 Thread Shakeel Butt
On Fri, Sep 25, 2020 at 10:17 AM Linus Torvalds wrote: > > On Fri, Sep 25, 2020 at 9:19 AM Ming Lei wrote: > > > > git bisect shows the first bad commit: > > > > [10befea91b61c4e2c2d1df06a2e978d182fcf792] mm: memcg/slab: use a > > single set of > > kmem_caches for all

Re: REGRESSION: 37f4a24c2469: blk-mq: centralise related handling into blk_mq_get_driver_tag

2020-09-25 Thread Linus Torvalds
On Fri, Sep 25, 2020 at 9:19 AM Ming Lei wrote: > > git bisect shows the first bad commit: > > [10befea91b61c4e2c2d1df06a2e978d182fcf792] mm: memcg/slab: use a > single set of > kmem_caches for all allocations > > And I have double checked that the above commit is really

Re: [RFC PATCH v2] tools/x86: add kcpuid tool to show raw CPU features

2020-09-25 Thread Borislav Petkov
On Wed, Sep 23, 2020 at 10:45:29AM +0800, Feng Tang wrote: > > Rather than a tool, would additional file(s) in, say, > > /sys/devices/system/cpu/cpu be nicer? They could show the raw CPUID > > features, one file per leaf or sub-leaf, maybe even along with whether > > they were disabled at

Re: [PATCH v7 00/10] NTFS read-write driver GPL implementation by Paragon Software

2020-09-25 Thread Joe Perches
(adding cc's to Anton Altaparmakov and linux-ntfs-dev) On Fri, 2020-09-25 at 18:55 +0300, Konstantin Komarov wrote: > This patch adds NTFS Read-Write driver to fs/ntfs3. This code should eventually supplant the existing NTFS implementation right? Unless there is some specific reason you have

[PATCH] bus: mhi: core: debugfs: Use correct format specifiers for addresses

2020-09-25 Thread Manivannan Sadhasivam
For exposing the addresses of read/write pointers and doorbell register, let's use the correct format specifiers. This fixes the following issues generated using W=1 build in ARM32 and reported by Kbuild bot: All warnings (new ones prefixed by >>): >> drivers/bus/mhi/core/debugfs.c:75:7:

Re: [f2fs-dev] [PATCH] f2fs: fix uninit-value in f2fs_lookup

2020-09-25 Thread Eric Biggers
On Fri, Sep 25, 2020 at 11:19:26PM +0800, Chao Yu wrote: > From: Chao Yu > > As syzbot reported: > > Call Trace: > __dump_stack lib/dump_stack.c:77 [inline] > dump_stack+0x21c/0x280 lib/dump_stack.c:118 > kmsan_report+0xf7/0x1e0 mm/kmsan/kmsan_report.c:122 > __msan_warning+0x58/0xa0

[PATCH] habanalabs/gaudi: use correct define for qman init

2020-09-25 Thread Oded Gabbay
There was a copy-paste error, and the wrong define was used for initializing the QMAN. Signed-off-by: Oded Gabbay --- drivers/misc/habanalabs/gaudi/gaudi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/misc/habanalabs/gaudi/gaudi.c

[PATCH v13 26/26] mm: Introduce PROT_SHSTK for shadow stack

2020-09-25 Thread Yu-cheng Yu
There are three possible options to create a shadow stack allocation API: an arch_prctl, a new syscall, or adding PROT_SHSTK to mmap()/mprotect(). Each has its advantages and compromises. An arch_prctl() is the least intrusive. However, the existing x86 arch_prctl() takes only two parameters.

Re: [PATCH v3 1/1] PCI/ERR: Fix reset logic in pcie_do_recovery() call

2020-09-25 Thread Kuppuswamy, Sathyanarayanan
On 9/25/20 9:55 AM, Sinan Kaya wrote: On 9/25/2020 1:11 AM, Kuppuswamy, Sathyanarayanan wrote: On 9/24/20 1:52 PM, Sinan Kaya wrote: On 9/24/2020 12:06 AM, Kuppuswamy, Sathyanarayanan wrote: So, this is a matter of moving the save/restore logic from the hotplug driver into common code

Re: [PATCH v2 2/2] locktorture: call percpu_free_rwsem() to do percpu-rwsem cleanup

2020-09-25 Thread Paul E. McKenney
On Thu, Sep 24, 2020 at 10:18:54PM +0800, Hou Tao wrote: > When do percpu-rwsem writer lock torture, the RCU callback > rcu_sync_func() may still be pending after locktorture module > is removed, and it will lead to the following Oops: > > BUG: unable to handle page fault for address:

Re: [Cocci] coccinelle: Convert comma to semicolons (was Re: [PATCH] checkpatch: Add test for comma use that should be semicolon)

2020-09-25 Thread Julia Lawall
On Thu, 24 Sep 2020, Joe Perches wrote: > On Thu, 2020-09-24 at 23:53 +0200, Thomas Gleixner wrote: > > On Thu, Sep 24 2020 at 13:33, Joe Perches wrote: > > > On Thu, 2020-09-24 at 22:19 +0200, Thomas Gleixner wrote: > > > > On Sat, Aug 22 2020 at 09:07, Julia Lawall wrote: > > > > > On Fri,

Re: [PATCH 1/2] tracepoints: Add helper to test if tracepoint is enabled in a header

2020-09-25 Thread Mathieu Desnoyers
- On Sep 25, 2020, at 12:26 PM, rostedt rost...@goodmis.org wrote: > On Fri, 25 Sep 2020 11:30:06 -0400 (EDT) > Mathieu Desnoyers wrote: > >> > Anyway, I don't see any issues with the current patch set as is >> > (besides the documentation fix, which I already updated locally). And >> >

Re: [PATCH] mmc: host: fix depends for MMC_MESON_GX w/ COMPILE_TEST

2020-09-25 Thread Krzysztof Kozlowski
> Cc: Krzysztof Kozlowski > --- > drivers/mmc/host/Kconfig |1 + > 1 file changed, 1 insertion(+) > > --- linux-next-20200925.orig/drivers/mmc/host/Kconfig > +++ linux-next-20200925/drivers/mmc/host/Kconfig > @@ -425,6 +425,7 @@ config MMC_SDHCI_IPROC > config

Re: [RFC PATCH 0/3] KVM: Introduce "VM bugged" concept

2020-09-25 Thread Sean Christopherson
On Fri, Sep 25, 2020 at 05:32:53PM +0100, Marc Zyngier wrote: > Hi Sean, > > On Wed, 23 Sep 2020 23:45:27 +0100, > Sean Christopherson wrote: > > > > This series introduces a concept we've discussed a few times in x86 land. > > The crux of the problem is that x86 has a few cases where KVM could

[PATCH v13 04/26] x86/cet: Add control-protection fault handler

2020-09-25 Thread Yu-cheng Yu
A control-protection fault is triggered when a control-flow transfer attempt violates Shadow Stack or Indirect Branch Tracking constraints. For example, the return address for a RET instruction differs from the copy on the Shadow Stack; or an indirect JMP instruction, without the NOTRACK prefix,

[PATCH][next] dpaa2-mac: Fix potential null pointer dereference

2020-09-25 Thread Gustavo A. R. Silva
There is a null-check for _pcs_, but it is being dereferenced prior to this null-check. So, if _pcs_ can actually be null, then there is a potential null pointer dereference that should be fixed by null-checking _pcs_ before being dereferenced. Addresses-Coverity-ID: 1497159 ("Dereference before

Re: [PATCH v3 1/1] PCI/ERR: Fix reset logic in pcie_do_recovery() call

2020-09-25 Thread Sinan Kaya
On 9/25/2020 1:11 AM, Kuppuswamy, Sathyanarayanan wrote: > > > On 9/24/20 1:52 PM, Sinan Kaya wrote: >> On 9/24/2020 12:06 AM, Kuppuswamy, Sathyanarayanan wrote: >> >> So, this is a matter of moving the save/restore logic from the hotplug >> driver into common code so that DPC slot reset takes

Can we credibly make vdso_sgx_enter_enclave() pleasant to use?

2020-09-25 Thread Andy Lutomirski
vdso_sgx_enter_enclave() sucks. I don't think anyone seriously likes it, but maybe it's the best we can do. I'm wondering if it's worth trying to do better. Here's what I'd like if I could wave a magic wand: struct sgx_enclave_run { __u64 tcs; __u32 flags; __u32

Re: [RFC] mm: Allow 64-bit mmap syscalls to access higher addresses.

2020-09-25 Thread Derek Lesho
For some reason, git send-email cut off the first paragprah in my first email, so I'm resending it now: Hello everyone, I am sending this mostly as a discussion starter/curiosity. I would like to be able to use the 48-bit address range while in long mode on an IA32 process. However, these

Re: [Intel-gfx] [PATCH] i915: Introduce quirk for shifting eDP brightness.

2020-09-25 Thread Lyude Paul
On Thu, 2020-09-24 at 17:46 -0600, Kevin Chowski wrote: > cc back a few others who were unintentionally dropped from the thread > earlier. > > Someone (at Google) helped me dig into this a little more and they > found a document titled "eDP Backlight Brightness bit alignment" sent > out for

[GIT PULL] Power management fixes for v5.9-rc7

2020-09-25 Thread Rafael J. Wysocki
Hi Linus, Please pull from the tag git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git \ pm-5.9-rc7 with top-most commit 6040723009060ed356dc93dd9a27e80b2206e59b Merge branch 'pm-cpuidle' on top of commit ba4f184e126b751d1bffad5897f263108befc780 Linux 5.9-rc6 to receive

Re: [PATCH] ALSA: rockchip: fix a possible divide-by-zero bug in rockchip_i2s_hw_params()

2020-09-25 Thread Mark Brown
On Sun, Aug 30, 2020 at 05:51:06PM +0800, Tuo Li wrote: > The variable bclk_rate is checked in: > if (bclk_rate && mclk_rate % bclk_rate) Please submit patches using subject lines reflecting the style for the subsystem, this makes it easier for people to identify relevant patches. Look at what

Re: [PATCH 4.19 23/37] ipv4: Update exception handling for multipath routes via same device

2020-09-25 Thread Pavel Machek
Hi! > [ Upstream commit 2fbc6e89b2f1403189e624cabaf73e189c5e50c6 ] > > Kfir reported that pmtu exceptions are not created properly for > deployments where multipath routes use the same device. This is mismerged (in a way that does not affect functionality): > @@ -779,6 +779,8 @@ static void

Re: [PATCH 7/9] sched: Add migrate_disable()

2020-09-25 Thread Sebastian Andrzej Siewior
On 2020-09-21 18:36:04 [+0200], Peter Zijlstra wrote: > --- a/kernel/sched/core.c > +++ b/kernel/sched/core.c > @@ -1700,6 +1700,68 @@ void check_preempt_curr(struct rq *rq, s > > #ifdef CONFIG_SMP > > +#ifdef CONFIG_PREEMPT_RT … > +static inline bool is_migration_disabled(struct task_struct

Re: [PATCH v13 8/8] x86/vsyscall/64: Fixup Shadow Stack and Indirect Branch Tracking for vsyscall emulation

2020-09-25 Thread Andy Lutomirski
> On Sep 25, 2020, at 9:48 AM, Yu, Yu-cheng wrote: > > On 9/25/2020 9:31 AM, Andy Lutomirski wrote: >>> On Fri, Sep 25, 2020 at 7:58 AM Yu-cheng Yu wrote: >>> > > [...] > >>> @@ -286,6 +289,37 @@ bool emulate_vsyscall(unsigned long error_code, >>> /* Emulate a ret instruction. */

Re: [PATCH v3 2/3] misc: bcm-vk: add Broadcom VK driver

2020-09-25 Thread Scott Branden
Hi Greg, On 2020-09-24 10:10 p.m., Greg Kroah-Hartman wrote: > On Thu, Sep 24, 2020 at 02:40:08PM -0700, Scott Branden wrote: >>> Ugh, yes, it is uncommon because those are two different things. Why do >>> you need/want a misc driver to control a tty device? Why do you need a >>> tty device?

[PATCH v2 2/2] ASoC: lpass-platform: use devm_regmap_field_bulk_alloc

2020-09-25 Thread Srinivas Kandagatla
use new devm_regmap_field_bulk_alloc to allocate fields as it make the code more readable! Signed-off-by: Srinivas Kandagatla Tested-by: Srinivasa Rao Mandadapu --- sound/soc/qcom/lpass-platform.c | 31 +++ 1 file changed, 7 insertions(+), 24 deletions(-) diff

[PATCH v2 0/2] regmap: add support to regmap_field_bulk_alloc/free

2020-09-25 Thread Srinivas Kandagatla
Usage of regmap_field_alloc becomes much overhead when number of fields exceed more than 3. Most of driver seems to totally covered up with these allocs/free making to very hard to read the code! On such driver is QCOM LPASS driver has extensively converted to use regmap_fields. This patchset add

[PATCH v2 1/2] regmap: add support to regmap_field_bulk_alloc/free apis

2020-09-25 Thread Srinivas Kandagatla
Usage of regmap_field_alloc becomes much overhead when number of fields exceed more than 3. QCOM LPASS driver has extensively converted to use regmap_fields. Using new bulk api to allocate fields makes it much more cleaner code to read! Signed-off-by: Srinivas Kandagatla Tested-by: Srinivasa

Re: REGRESSION: 37f4a24c2469: blk-mq: centralise related handling into blk_mq_get_driver_tag

2020-09-25 Thread Shakeel Butt
On Fri, Sep 25, 2020 at 9:32 AM Shakeel Butt wrote: > > On Fri, Sep 25, 2020 at 9:19 AM Ming Lei wrote: > > > > On Fri, Sep 25, 2020 at 03:31:45PM +0800, Ming Lei wrote: > > > On Thu, Sep 24, 2020 at 09:13:11PM -0400, Theodore Y. Ts'o wrote: > > > > On Thu, Sep 24, 2020 at 10:33:45AM -0400,

Re: [PATCH v13 8/8] x86/vsyscall/64: Fixup Shadow Stack and Indirect Branch Tracking for vsyscall emulation

2020-09-25 Thread Yu, Yu-cheng
On 9/25/2020 9:31 AM, Andy Lutomirski wrote: On Fri, Sep 25, 2020 at 7:58 AM Yu-cheng Yu wrote: [...] @@ -286,6 +289,37 @@ bool emulate_vsyscall(unsigned long error_code, /* Emulate a ret instruction. */ regs->ip = caller; regs->sp += 8; + +#ifdef CONFIG_X86_CET

Re: [PATCH v2 seccomp 3/6] seccomp/cache: Add "emulator" to check if filter is arg-dependent

2020-09-25 Thread YiFei Zhu
On Thu, Sep 24, 2020 at 10:04 PM YiFei Zhu wrote: > > Why do the prepare here instead of during attach? (And note that it > > should not be written to fail.) > > Right. During attach a spinlock (current->sighand->siglock) is held. Do we really want to put the emulator in the "atomic section"?

Re: [f2fs-dev] KMSAN: uninit-value in f2fs_lookup

2020-09-25 Thread Eric Biggers
On Fri, Sep 25, 2020 at 09:38:19AM -0700, Eric Biggers wrote: > On Fri, Sep 25, 2020 at 05:06:33PM +0800, Chao Yu wrote: > > Hi, > > > > I don't see any problem here, thanks for your report. :) > > > > Thanks, > > What about if max_depth == 0 in __f2fs_find_entry()? Then __f2fs_find_entry() >

Re: [PATCH 2/5] PCI: pciehp: check and wait port status out of DPC before handling DLLSC and PDC

2020-09-25 Thread Andy Shevchenko
On Thu, Sep 24, 2020 at 10:34:20PM -0400, Ethan Zhao wrote: > When root port has DPC capability and it is enabled, then triggered by > errors, DPC > DLLSC and PDC interrupts will be sent to DPC driver, pciehp driver at the > same time. > That will cause following result: > > 1. Link and device

Re: [RFC PATCH v2] sched/fair: select idle cpu from idle cpumask in sched domain

2020-09-25 Thread Vincent Guittot
Le vendredi 25 sept. 2020 à 17:21:46 (+0800), Li, Aubrey a écrit : > Hi Vicent, > > On 2020/9/24 21:09, Vincent Guittot wrote: > > Would you mind share uperf(netperf load) result on your side? That's the > workload I have seen the most benefit this patch contributed under heavy >

[PATCH][next] net/mlx5e: Fix potential null pointer dereference

2020-09-25 Thread Gustavo A. R. Silva
Calls to kzalloc() and kvzalloc() should be null-checked in order to avoid any potential failures. In this case, a potential null pointer dereference. Fix this by adding null checks for _parse_attr_ and _flow_ right after allocation. Addresses-Coverity-ID: 1497154 ("Dereference before null

Re: [PATCH v4 2/2] ovl: introduce new "uuid=off" option for inodes index feature

2020-09-25 Thread Amir Goldstein
On Fri, Sep 25, 2020 at 11:35 AM Pavel Tikhomirov wrote: > > This replaces uuid with null in overelayfs file handles and thus relaxes typo: overelayfs > uuid checks for overlay index feature. It is only possible in case there > is only one filesystem for all the work/upper/lower directories and

[PATCH] mmc: host: fix depends for MMC_MESON_GX w/ COMPILE_TEST

2020-09-25 Thread Randy Dunlap
by: Randy Dunlap Cc: Kevin Hilman Cc: linux-amlo...@lists.infradead.org Cc: linux-arm-ker...@lists.infradead.org Cc: Ulf Hansson Cc: linux-...@vger.kernel.org Cc: Krzysztof Kozlowski --- drivers/mmc/host/Kconfig |1 + 1 file changed, 1 insertion(+) --- linux-next-20200925.orig/drivers/mmc/hos

Re: [PATCH 2/3] ASoC: cs4234: Add support for Cirrus Logic CS4234 codec

2020-09-25 Thread Mark Brown
On Fri, Sep 25, 2020 at 11:59:07AM +0100, Richard Fitzgerald wrote: This looks very good, a couple of small nits below which should be easy to address: > @@ -282,7 +283,6 @@ config SND_SOC_ALL_CODECS > uses them is also built since they are only usable with a machine > driver.

Re: [PATCH 1/9] lib: string_helpers: provide kfree_strarray()

2020-09-25 Thread Andy Shevchenko
On Fri, Sep 25, 2020 at 01:32:01PM +0200, Bartosz Golaszewski wrote: > On Fri, Sep 25, 2020 at 11:01 AM Andy Shevchenko > wrote: > > > > On Thu, Sep 24, 2020 at 01:38:34PM +0200, Bartosz Golaszewski wrote: > > > From: Bartosz Golaszewski > > > > > > There's a common pattern of dynamically

Re: [PATCH 8/9] gpio: mockup: use the generic 'gpio-line-names' property

2020-09-25 Thread Andy Shevchenko
On Fri, Sep 25, 2020 at 01:40:10PM +0200, Bartosz Golaszewski wrote: > On Fri, Sep 25, 2020 at 11:03 AM Andy Shevchenko > wrote: > > On Thu, Sep 24, 2020 at 01:38:41PM +0200, Bartosz Golaszewski wrote: > > > From: Bartosz Golaszewski > > > > > > GPIO line names are currently created by the

Re: [PATCH 3/5] PCI/ERR: get device before call device driver to avoid null pointer reference

2020-09-25 Thread Andy Shevchenko
On Thu, Sep 24, 2020 at 10:34:21PM -0400, Ethan Zhao wrote: > During DPC error injection test we found there is race condition between > pciehp and DPC driver, null pointer reference caused panic as following null -> NULL > > # setpci -s 64:02.0 0x196.w=000a > // 64:02.0 is rootport has DPC

Re: [PATCH v2 seccomp 2/6] asm/syscall.h: Add syscall_arches[] array

2020-09-25 Thread YiFei Zhu
On Thu, Sep 24, 2020 at 10:28 PM YiFei Zhu wrote: > Ah. Makes sense. > > > Ironicailly, that's the only place I actually know for sure where people > > using x32 because it shows measurable (10%) speed-up for builders: > >

Re: [PATCH 1/5] PCI: define a function to check and wait till port finish DPC handling

2020-09-25 Thread Andy Shevchenko
On Thu, Sep 24, 2020 at 10:34:19PM -0400, Ethan Zhao wrote: > Once root port DPC capability is enabled and triggered, at the beginning > of DPC is triggered, the DPC status bits are set by hardware and then > sends DPC/DLLSC/PDC interrupts to OS DPC and pciehp drivers, it will > take the port and

Re: [PATCH v8 1/8] KVM: x86: Return -ENOENT on unimplemented MSRs

2020-09-25 Thread Jim Mattson
On Fri, Sep 25, 2020 at 7:34 AM Alexander Graf wrote: > > When we find an MSR that we can not handle, bubble up that error code as > MSR error return code. Follow up patches will use that to expose the fact > that an MSR is not handled by KVM to user space. > > Suggested-by: Aaron Lewis >

Re: [PATCH 4/5] PCI: only return true when dev io state is really changed

2020-09-25 Thread Andy Shevchenko
On Thu, Sep 24, 2020 at 10:34:22PM -0400, Ethan Zhao wrote: > When uncorrectable error happens, AER driver and DPC driver interrupt > handlers likely call >pcie_do_recovery()->pci_walk_bus()->report_frozen_detected() with > pci_channel_io_frozen the same time. Call chains are better to read

RE: [PATCH v3 04/10] fs/ntfs3: Add file operations and implementation

2020-09-25 Thread Konstantin Komarov
From: Pali Rohár Sent: Monday, September 21, 2020 4:37 PM > > On Friday 11 September 2020 16:52:50 Konstantin Komarov wrote: > > From: Pali Rohár > > Sent: Friday, September 4, 2020 2:51 PM > > > > > > Hello Konstantin! > > > > > > On Friday 28 August 2020 07:39:32 Konstantin Komarov wrote: > >

Re: [PATCH 3/9] sched/hotplug: Ensure only per-cpu kthreads run during hotplug

2020-09-25 Thread Dietmar Eggemann
On 21/09/2020 18:36, Peter Zijlstra wrote: [...] > This replaces the unlikely(rq->balance_callbacks) test at the tail of > context_switch with an unlikely(rq->balance_work), the fast path is While looking for why BALANCE_WORK is needed: Shouldn't this be unlikely(rq->balance_callback) and

Re: [f2fs-dev] KMSAN: uninit-value in f2fs_lookup

2020-09-25 Thread Eric Biggers
On Fri, Sep 25, 2020 at 05:06:33PM +0800, Chao Yu wrote: > Hi, > > I don't see any problem here, thanks for your report. :) > > Thanks, What about if max_depth == 0 in __f2fs_find_entry()? Then __f2fs_find_entry() would return NULL without initializing *res_page. A fix could be: diff --git

Re: [PATCH v4 1/2] ovl: propagate ovl_fs to ovl_decode_real_fh and ovl_encode_real_fh

2020-09-25 Thread Amir Goldstein
On Fri, Sep 25, 2020 at 11:35 AM Pavel Tikhomirov wrote: > > This will be used in next patch to be able to change uuid checks and > add uuid nullification based on ofs->config.index for a new "uuid=off" > mode. > > CC: Amir Goldstein > CC: Vivek Goyal > CC: Miklos Szeredi > CC:

[PATCH] sched,fair: fix the spelling of enqueued

2020-09-25 Thread Hui Su
just fix the spelling of enqueued. Signed-off-by: Hui Su --- kernel/sched/fair.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index 1a68a0536add..fadee2b05df3 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -753,7

Re: [PATCH v3] Bluetooth: Check for encryption key size on connect

2020-09-25 Thread Marcel Holtmann
Hi Archie, > When receiving connection, we only check whether the link has been > encrypted, but not the encryption key size of the link. > > This patch adds check for encryption key size, and reject L2CAP > connection which size is below the specified threshold (default 7) > with security

[PATCH v2 1/2] ASoC: qdsp6: add ifdef CONFIG_OF around of_device_id

2020-09-25 Thread Srinivas Kandagatla
Add ifdef CONFIG_OF around of_device_id table to fix below W=1 compile test warning with !CONFIG_OF: sound/soc/qcom/qdsp6/q6afe-clocks.c:254:34: warning: unused variable 'q6afe_clock_device_id' [-Wunused-const-variable] Fix this warning for across all qdsp6 drivers. Reported-by: kernel test

[PATCH v2 2/2] ASoC: q6asm: fix kernel doc warnings

2020-09-25 Thread Srinivas Kandagatla
This patch fixes below kernel doc warnings on not describing all the parmeters sound/soc/qcom/qdsp6/q6asm.c:927: warning: Function parameter or member 'stream_id' not described in 'q6asm_open_write' sound/soc/qcom/qdsp6/q6asm.c:927: warning: Function parameter or member 'is_gapless' not

[PATCH v2 0/2] ASoC: qdsp6: fix some warnings when build without CONFIG_OF

2020-09-25 Thread Srinivas Kandagatla
Here are fixes for two warnings types discovered while building qdsp6 drivers without CONFIG_OF and with W=1 One of them was reported by Intel kernel test robot on q6afe-clocks patch, which equally applies to rest of the qdsp6 drivers. changes since v1: - added ifdef CONFIG_OF instead of

[PATCH v13 25/26] x86/cet/shstk: Add arch_prctl functions for shadow stack

2020-09-25 Thread Yu-cheng Yu
arch_prctl(ARCH_X86_CET_STATUS, u64 *args) Get CET feature status. The parameter 'args' is a pointer to a user buffer. The kernel returns the following information: *args = shadow stack/IBT status *(args + 1) = shadow stack base address *(args + 2) = shadow stack size

Re: [RFC PATCH 0/3] KVM: Introduce "VM bugged" concept

2020-09-25 Thread Marc Zyngier
Hi Sean, On Wed, 23 Sep 2020 23:45:27 +0100, Sean Christopherson wrote: > > This series introduces a concept we've discussed a few times in x86 land. > The crux of the problem is that x86 has a few cases where KVM could > theoretically encounter a software or hardware bug deep in a call stack >

Re: REGRESSION: 37f4a24c2469: blk-mq: centralise related handling into blk_mq_get_driver_tag

2020-09-25 Thread Shakeel Butt
On Fri, Sep 25, 2020 at 9:19 AM Ming Lei wrote: > > On Fri, Sep 25, 2020 at 03:31:45PM +0800, Ming Lei wrote: > > On Thu, Sep 24, 2020 at 09:13:11PM -0400, Theodore Y. Ts'o wrote: > > > On Thu, Sep 24, 2020 at 10:33:45AM -0400, Theodore Y. Ts'o wrote: > > > > HOWEVER, thanks to a hint from a

Re: [PATCH v13 8/8] x86/vsyscall/64: Fixup Shadow Stack and Indirect Branch Tracking for vsyscall emulation

2020-09-25 Thread Andy Lutomirski
On Fri, Sep 25, 2020 at 7:58 AM Yu-cheng Yu wrote: > > Vsyscall entry points are effectively branch targets. Mark them with > ENDBR64 opcodes. When emulating the RET instruction, unwind shadow stack > and reset IBT state machine. > > Signed-off-by: Yu-cheng Yu > --- > v13: > - Check shadow

Re: [v3 1/2] mm: khugepaged: recalculate min_free_kbytes after memory hotplug as expected by khugepaged

2020-09-25 Thread Vijay Balakrishna
On 9/25/2020 12:42 AM, Michal Hocko wrote: On Wed 16-09-20 18:21:48, Vijay Balakrishna wrote: When memory is hotplug added or removed the min_free_kbytes must be recalculated based on what is expected by khugepaged. Currently after hotplug, min_free_kbytes will be set to a lower default and

[PATCH v12 3/6] iommu/uapi: Use named union for user data

2020-09-25 Thread Jacob Pan
IOMMU UAPI data size is filled by the user space which must be validated by the kernel. To ensure backward compatibility, user data can only be extended by either re-purpose padding bytes or extend the variable sized union at the end. No size change is allowed before the union. Therefore, the

[PATCH v12 4/6] iommu/uapi: Rename uapi functions

2020-09-25 Thread Jacob Pan
User APIs such as iommu_sva_unbind_gpasid() may also be used by the kernel. Since we introduced user pointer to the UAPI functions, in-kernel callers cannot share the same APIs. In-kernel callers are also trusted, there is no need to validate the data. We plan to have two flavors of the same API

[PATCH v12 1/6] docs: IOMMU user API

2020-09-25 Thread Jacob Pan
IOMMU UAPI is newly introduced to support communications between guest virtual IOMMU and host IOMMU. There has been lots of discussions on how it should work with VFIO UAPI and userspace in general. This document is intended to clarify the UAPI design and usage. The mechanics of how future

[PATCH v12 2/6] iommu/uapi: Add argsz for user filled data

2020-09-25 Thread Jacob Pan
As IOMMU UAPI gets extended, user data size may increase. To support backward compatibiliy, this patch introduces a size field to each UAPI data structures. It is *always* the responsibility for the user to fill in the correct size. Padding fields are adjusted to ensure 8 byte alignment. Specific

[PATCH v12 6/6] iommu/vt-d: Check UAPI data processed by IOMMU core

2020-09-25 Thread Jacob Pan
IOMMU generic layer already does sanity checks on UAPI data for version match and argsz range based on generic information. This patch adjusts the following data checking responsibilities: - removes the redundant version check from VT-d driver - removes the check for vendor specific data size -

[PATCH v12 5/6] iommu/uapi: Handle data and argsz filled by users

2020-09-25 Thread Jacob Pan
IOMMU user APIs are responsible for processing user data. This patch changes the interface such that user pointers can be passed into IOMMU code directly. Separate kernel APIs without user pointers are introduced for in-kernel users of the UAPI functionality. IOMMU UAPI data has a user filled

Re: [PATCH] fs/affs: Fix basic permission bits to actually work

2020-09-25 Thread Max Staudt
On 9/25/20 12:07 PM, John Paul Adrian Glaubitz wrote: > Has there already been any progress on reviewing this? It has already been merged, and the maintainers have been so kind as to backport it to all maintained stable branches. Thanks for your help, everyone! Max

[PATCH v12 0/6] IOMMU user API enhancement

2020-09-25 Thread Jacob Pan
IOMMU user API header was introduced to support nested DMA translation and related fault handling. The current UAPI data structures consist of three areas that cover the interactions between host kernel and guest: - fault handling - cache invalidation - bind guest page tables, i.e. guest PASID

Re: [PATCH v13 7/8] x86/vdso: Insert endbr32/endbr64 to vDSO

2020-09-25 Thread Yu, Yu-cheng
On 9/25/2020 9:18 AM, Andy Lutomirski wrote: On Fri, Sep 25, 2020 at 7:58 AM Yu-cheng Yu wrote: From: "H.J. Lu" When Indirect Branch Tracking (IBT) is enabled, vDSO functions may be called indirectly, and must have ENDBR32 or ENDBR64 as the first instruction. The compiler must support

Re: [PATCH] net: ethernet: cavium: octeon_mgmt: use phy_start and phy_stop

2020-09-25 Thread Andrew Lunn
On Fri, Sep 25, 2020 at 03:44:39PM +0300, Ivan Khoronzhuk wrote: > To start also "phy state machine", with UP state as it should be, > the phy_start() has to be used, in another case machine even is not > triggered. After this change negotiation is supposed to be triggered > by SM workqueue. > >

RE: [PATCH v5 08/10] fs/ntfs3: Add Kconfig, Makefile and doc

2020-09-25 Thread Konstantin Komarov
From: Pali Rohár Sent: Monday, September 21, 2020 4:27 PM > To: Konstantin Komarov > Cc: linux-fsde...@vger.kernel.org; v...@zeniv.linux.org.uk; > linux-kernel@vger.kernel.org; dste...@suse.cz; aap...@suse.com; > wi...@infradead.org; rdun...@infradead.org; j...@perches.com; >

Re: [PATCH v2] : Add nitems() and snitems() macros

2020-09-25 Thread Alejandro Colomar
Hello Jonathan, On 2020-09-25 16:48, Jonathan Wakely wrote: > Do you really need to provide snitems? > > Users can use (ptrdiff_t)nitems if needed, can't they? They can, but that adds casts in the code, which makes longer lines that are somewhat harder to read. To avoid that, users may

Re: [PATCH 1/2] tracepoints: Add helper to test if tracepoint is enabled in a header

2020-09-25 Thread Steven Rostedt
On Fri, 25 Sep 2020 11:30:06 -0400 (EDT) Mathieu Desnoyers wrote: > > Anyway, I don't see any issues with the current patch set as is > > (besides the documentation fix, which I already updated locally). And > > will add this to my queue for linux-next. > > The only thing I would change in

Re: [PATCH v4] cper, apei, mce: Pass x86 CPER through the MCA handling chain

2020-09-25 Thread Borislav Petkov
On Fri, Sep 25, 2020 at 11:19:40AM -0500, Yazen Ghannam wrote: > This patch is checking if an MSR context info structure lines up with > the MCAX register space used on Scalable MCA systems. This register > space is defined in the AMD Processor Programming Reference for various > products. This is

Re: [PATCH v1] Bluetooth: Enforce key size of 16 bytes on FIPS level

2020-09-25 Thread Marcel Holtmann
Hi Archie, > According to the spec Ver 5.2, Vol 3, Part C, Sec 5.2.2.8: > Device in security mode 4 level 4 shall enforce: > 128-bit equivalent strength for link and encryption keys required > using FIPS approved algorithms (E0 not allowed, SAFER+ not allowed, > and P-192 not allowed; encryption

[PATCH] ARM: dts: cros-ec-keyboard: Add alternate keymap for KEY_LEFTMETA

2020-09-25 Thread Stephen Boyd
On newer keyboards this key is in a different place. Add both options to the keymap so that both new and old keyboards work. Cc: Douglas Anderson Signed-off-by: Stephen Boyd --- arch/arm/boot/dts/cros-ec-keyboard.dtsi | 1 + 1 file changed, 1 insertion(+) diff --git

Re: [PATCH] KVM: VMX: Explicitly check for hv_remote_flush_tlb when loading pgd()

2020-09-25 Thread Sean Christopherson
On Fri, Sep 25, 2020 at 11:59:00AM +0200, Vitaly Kuznetsov wrote: > Sean Christopherson writes: > > +#if IS_ENABLED(CONFIG_HYPERV) > > enum ept_pointers_status ept_pointers_match; > > spinlock_t ept_pointer_lock; > > +#endif > > Reviewed-by: Vitaly Kuznetsov > > In case

Re: [PATCH 1/2] ASoC: qdsp6: Drop of_match_ptr to fix -Wunused-const-variable

2020-09-25 Thread Srinivas Kandagatla
On 25/09/2020 17:17, Mark Brown wrote: On Fri, Sep 25, 2020 at 09:49:24AM +0100, Srinivas Kandagatla wrote: The of_device_id is included unconditionally by of.h header and used in the driver as well. Remove of_match_ptr to fix W=1 compile test warning with !CONFIG_OF: It's better to fix

[PATCH] mm: fix some comments in page_alloc.c and mempolicy.c

2020-09-25 Thread Hui Su
1. the cpuset.c has been moved from kernel/cpuset.c to kernel/cgroup/cpuset.c long time ago, but the comment is stale, so we update it. 2. get_page_from_freelist() may alloc many pages according to order, we may use pages for better. Signed-off-by: Hui Su --- kernel/cgroup/cpuset.c | 2 +-

[PATCH v4] sched/deadline: Fix sched_dl_global_validate()

2020-09-25 Thread Peng Liu
I created another root domain(contains 2 CPUs) besides the default one, and the global default rt bandwidth is 95%. Then launched a DL process which need 25% bandwidth and moved it to the new root domain, so far so good. Then I tried to change global rt bandwidth to 20% with cmd: echo

Re: REGRESSION: 37f4a24c2469: blk-mq: centralise related handling into blk_mq_get_driver_tag

2020-09-25 Thread Ming Lei
On Fri, Sep 25, 2020 at 03:31:45PM +0800, Ming Lei wrote: > On Thu, Sep 24, 2020 at 09:13:11PM -0400, Theodore Y. Ts'o wrote: > > On Thu, Sep 24, 2020 at 10:33:45AM -0400, Theodore Y. Ts'o wrote: > > > HOWEVER, thanks to a hint from a colleague at $WORK, and realizing > > > that one of the stack

Re: [PATCH 1/8] dma-mapping: add DMA_ATTR_LOW_ADDRESS attribute

2020-09-25 Thread Christoph Hellwig
> #define DMA_ATTR_PRIVILEGED (1UL << 9) > +/* > + * DMA_ATTR_LOW_ADDRESS: used to indicate that the buffer should be allocated > + * at the lowest possible DMA address, usually just at the beginning of the > + * DMA/IOVA address space ('first-fit' allocation algorithm). > + */ >

Re: [PATCH v4] cper, apei, mce: Pass x86 CPER through the MCA handling chain

2020-09-25 Thread Yazen Ghannam
On Fri, Sep 25, 2020 at 09:54:06AM +0900, Punit Agrawal wrote: > Borislav Petkov writes: > > > On Thu, Sep 24, 2020 at 12:23:27PM -0500, Smita Koralahalli Channabasappa > > wrote: > >> > Even though it's not defined in the UEFI spec, it doesn't mean a > >> > structure definition cannot be

Re: [PATCH v13 7/8] x86/vdso: Insert endbr32/endbr64 to vDSO

2020-09-25 Thread Andy Lutomirski
On Fri, Sep 25, 2020 at 7:58 AM Yu-cheng Yu wrote: > > From: "H.J. Lu" > > When Indirect Branch Tracking (IBT) is enabled, vDSO functions may be > called indirectly, and must have ENDBR32 or ENDBR64 as the first > instruction. The compiler must support -fcf-protection=branch so that it > can be

Re: [PATCH 1/2] ASoC: qdsp6: Drop of_match_ptr to fix -Wunused-const-variable

2020-09-25 Thread Mark Brown
On Fri, Sep 25, 2020 at 09:49:24AM +0100, Srinivas Kandagatla wrote: > The of_device_id is included unconditionally by of.h header and used > in the driver as well. Remove of_match_ptr to fix W=1 compile test > warning with !CONFIG_OF: It's better to fix this by adding #ifdefs around the table

Re: [PATCH 08/18] dma-mapping: add a new dma_alloc_noncoherent API

2020-09-25 Thread Christoph Hellwig
On Fri, Sep 25, 2020 at 12:15:37PM +0100, Robin Murphy wrote: > On 2020-09-15 16:51, Christoph Hellwig wrote: > [...] >> +These APIs allow to allocate pages in the kernel direct mapping that are >> +guaranteed to be DMA addressable. This means that unlike >> dma_alloc_coherent, >> +virt_to_page

Re: [RFC-PATCH 2/4] mm: Add __rcu_alloc_page_lockless() func.

2020-09-25 Thread Mel Gorman
On Fri, Sep 25, 2020 at 05:31:29PM +0200, Uladzislau Rezki wrote: > > > > > > > > > > All good points! > > > > > > > > > > On the other hand, duplicating a portion of the allocator > > > > > functionality > > > > > within RCU increases the amount of reserved memory, and needlessly > > > > >

Re: linux-next: Tree for Sep 25 [kernel/bpf/preload/bpf_preload.ko]

2020-09-25 Thread Randy Dunlap
On 9/25/20 3:55 AM, Stephen Rothwell wrote: > Hi all, > > Changes since 20200924: > on x86_64: ERROR: modpost: "bpf_preload_ops" [kernel/bpf/preload/bpf_preload.ko] undefined! Full randconfig file is attached. -- ~Randy Reported-by: Randy Dunlap # # Automatically generated file; DO NOT

Re: [PATCH v6 1/9] kernel: Support TIF_SYSCALL_INTERCEPT flag

2020-09-25 Thread Gabriel Krisman Bertazi
Thomas Gleixner writes: > On Wed, Sep 23 2020 at 13:49, Kees Cook wrote: >> On Wed, Sep 23, 2020 at 04:18:26PM -0400, Gabriel Krisman Bertazi wrote: >>> Kees Cook writes: >>> Yes, we can, and I'm happy to follow up with that as part of my TIF >>> clean up work, but can we not block the current

<    1   2   3   4   5   6   7   8   9   10   >