[PATCH] mm/zswap: Fix passing zero to 'PTR_ERR' warning

2020-10-30 Thread YueHaibing
Fix smatch warning: mm/zswap.c:425 zswap_cpu_comp_prepare() warn: passing zero to 'PTR_ERR' crypto_alloc_comp() never return NULL, use IS_ERR instead of IS_ERR_OR_NULL to fix this. Fixes: f1c54846ee45 ("zswap: dynamic pool creation") Signed-off-by: YueHaibing --- mm/zswap.c | 2 +- 1 file

ltp::mmap05 --> BUG: using __this_cpu_read() in preemptible

2020-10-30 Thread Mike Galbraith
[ 138.620544] BUG: using __this_cpu_read() in preemptible [] code: mmap05/4858 [ 138.620737] caller is lockdep_hardirqs_on_prepare+0x2f/0x1b0 [ 138.620880] CPU: 2 PID: 4858 Comm: mmap05 Kdump: loaded Tainted: G S E 5.10.0.g07e0887-master #18 [ 138.621097] Hardware name:

kernel/trace/bpf_trace.c:1181:23: warning: Uninitialized variable: t

2020-10-30 Thread kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 5fc6b075e165f641fbc366b58b578055762d5f8c commit: c4d0bfb45068d853a478b9067a95969b1886a30f bpf: Add bpf_snprintf_btf helper date: 5 weeks ago compiler: gcc-9 (Debian 9.3.0-15) 9.3.0 If you fix the issue,

Re: [PATCH 0/3] Fix kernfs node reference count leak issues

2020-10-30 Thread Xiaochen Shen
Hi Reinette, Thank you for correcting this! The subject of this "cover letter" should be: x86/resctrl: Fix kernfs node reference count leak issues On 10/31/2020 5:18, Reinette Chatre wrote: Apologies, the Subject intended to have a "x86/resctrl:" prefix. On 10/30/2020 12:02 PM, Xiaochen Shen

Re: [PATCH net-next 00/19] net: phy: add support for shared interrupts (part 1)

2020-10-30 Thread Ioana Ciornei
On Fri, Oct 30, 2020 at 10:56:24PM +0100, Heiner Kallweit wrote: > On 29.10.2020 11:07, Ioana Ciornei wrote: > > From: Ioana Ciornei > > > > This patch set aims to actually add support for shared interrupts in > > phylib and not only for multi-PHY devices. While we are at it, > > streamline the

Re: [PATCH net-next 00/19] net: phy: add support for shared interrupts (part 1)

2020-10-30 Thread Ioana Ciornei
On Sat, Oct 31, 2020 at 12:36:27AM +0100, Andrew Lunn wrote: > > > - Every PHY driver gains a .handle_interrupt() implementation that, for > > > the most part, would look like below: > > > > > > irq_status = phy_read(phydev, INTR_STATUS); > > > if (irq_status < 0) { > > >

Re: [PATCH v4 11/14] clk: imx: Add blk-ctl driver for i.MX8MP

2020-10-30 Thread Adam Ford
On Mon, Oct 26, 2020 at 2:33 PM Abel Vesa wrote: > > This driver is intended to work with the following BLK_CTL IPs found in > i.MX8MP: > - Audio > - Media > - HDMI > > Signed-off-by: Abel Vesa > --- > drivers/clk/imx/Makefile | 2 +- > drivers/clk/imx/clk-blk-ctl-imx8mp.c |

Re: [PATCH net-next] net: dlci: Deprecate the DLCI driver (aka the Frame Relay layer)

2020-10-30 Thread Xie He
On Fri, Oct 30, 2020 at 8:07 PM Jakub Kicinski wrote: > > This code has only seen cleanup patches since the git era begun - > do you think that it may still have users? Or is it completely unused? I don't think it is still used. But I don't have solid evidence. So I asked people in the warning

Re: [PATCH 1/1] Fonts: font_acorn_8x8: Replace discarded const qualifier

2020-10-30 Thread Peilin Ye
Hi Lee, On Fri, Oct 30, 2020 at 06:18:22PM +, Lee Jones wrote: > Commit 09e5b3fd5672 ("Fonts: Support FONT_EXTRA_WORDS macros for > built-in fonts") introduced the following error when building > rpc_defconfig (only this build appears to be affected): > > `acorndata_8x8' referenced in

Re: [PATCH] checkpatch: improve handling of email comments

2020-10-30 Thread Joe Perches
On Fri, 2020-10-30 at 12:58 +0100, Lukas Bulwahn wrote: > > On Fri, 30 Oct 2020, Joe Perches wrote: > > > On Fri, 2020-10-30 at 14:37 +0530, Dwaipayan Ray wrote: > > > checkpatch has limited support for parsing email comments. It only > > > support single name comments or single after address

Re: [PATCH v11 01/14] s390/vfio-ap: No need to disable IRQ after queue reset

2020-10-30 Thread Halil Pasic
On Fri, 30 Oct 2020 16:37:04 -0400 Tony Krowiak wrote: > On 10/30/20 1:42 PM, Halil Pasic wrote: > > On Thu, 29 Oct 2020 19:29:35 -0400 > > Tony Krowiak wrote: > > > @@ -1177,7 +1166,10 @@ static int vfio_ap_mdev_reset_queues(struct > mdev_device *mdev) >

Re: [PATCH] kunit: tool: fix extra trailing \n in raw + parsed test output

2020-10-30 Thread David Gow
On Sat, Oct 31, 2020 at 6:39 AM Daniel Latypov wrote: > > For simplcity, strip all trailing whitespace from parsed output. > I imagine no one is printing out meaningful trailing whitespace via > KUNIT_FAIL() or similar, and that if they are, they really shouldn't. > > `isolate_kunit_output()`

[PATCH] spi: spi-mem: Fix passing zero to 'PTR_ERR' warning

2020-10-30 Thread YueHaibing
Fix smatch warning: drivers/spi/spi-mem.c:746 spi_mem_probe() warn: passing zero to 'PTR_ERR' Fixes: 5d27a9c8ea9e ("spi: spi-mem: Extend the SPI mem interface to set a custom memory name") Signed-off-by: YueHaibing --- drivers/spi/spi-mem.c | 2 +- 1 file changed, 1 insertion(+), 1

Re: [PATCH 1/4] dt-bindings: clock: Add SDX55 GCC clock bindings

2020-10-30 Thread Manivannan Sadhasivam
Hi Rob, On Fri, Oct 30, 2020 at 02:22:25PM -0500, Rob Herring wrote: > On Wed, Oct 28, 2020 at 01:12:29PM +0530, Manivannan Sadhasivam wrote: > > From: Vinod Koul > > > > Add device tree bindings for global clock controller on SDX55 SoCs. > > > > Signed-off-by: Vinod Koul > > This should

[PATCH] drm/bridge: tpd12s015: Fix irq registering in tpd12s015_probe

2020-10-30 Thread YueHaibing
gpiod_to_irq() return negative value in case of error, the existing code handle negative error codes wrongly. Fixes: cff5e6f7e83f ("drm/bridge: Add driver for the TI TPD12S015 HDMI level shifter") Signed-off-by: YueHaibing --- drivers/gpu/drm/bridge/ti-tpd12s015.c | 2 +- 1 file changed, 1

Re: [PATCH RFC v3 4/4] Documentation/admin-guide: Change doc for split_lock_detect parameter

2020-10-30 Thread Randy Dunlap
Hi, On 10/30/20 5:27 PM, Fenghua Yu wrote: > Since #DB for bus lock detect changes the split_lock_detect parameter, > update the documentation for the changes. > > Signed-off-by: Fenghua Yu > Reviewed-by: Tony Luck > --- > Change Log: > - Simplify the documentation (Randy). > >

ld.lld: error: undefined symbol: bpf_preload_ops

2020-10-30 Thread kernel test robot
. date: 2 months ago config: x86_64-randconfig-r021-20201030 (attached as .config) compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project fa5a13276764a2657b3571fa3c57b07ee5d2d661) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master

[PATCH] sfp: Fix error handing in sfp_probe()

2020-10-30 Thread YueHaibing
gpiod_to_irq() never return 0, but returns negative in case of error, check it and set gpio_irq to 0. Fixes: 73970055450e ("sfp: add SFP module support") Signed-off-by: YueHaibing --- drivers/net/phy/sfp.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

Re: Using fixed LPI number for some Device ID

2020-10-30 Thread Dongjiu Geng
On 2020/10/31 10:59, Thomas Gleixner wrote: > On Sat, Oct 31 2020 at 10:19, Dongjiu Geng wrote: >> Hi Marc, >> Sorry to disturb you, Currently the LPI number is not fixed for >> the device. The LPI number is dynamically allocated start from 8092. >> For two OS which shares the ITS, One OS

Re: [PATCH net-next] net: dlci: Deprecate the DLCI driver (aka the Frame Relay layer)

2020-10-30 Thread Jakub Kicinski
On Wed, 28 Oct 2020 00:05:04 -0700 Xie He wrote: > I wish to deprecate the Frame Relay layer (dlci.c) in the kernel because > we already have a newer and better "HDLC Frame Relay" layer (hdlc_fr.c). > > Reasons why hdlc_fr.c is better than dlci.c include: > > 1. > dlci.c is dated 1997, while

[PATCH] serial: mctrl_gpio: Fix passing zero to 'ERR_PTR' warning

2020-10-30 Thread YueHaibing
drivers/tty/serial/serial_mctrl_gpio.c:214 mctrl_gpio_init() warn: passing zero to 'ERR_PTR' gpiod_to_irq() never return 0, so remove the useless test and make code more clear. Signed-off-by: YueHaibing --- drivers/tty/serial/serial_mctrl_gpio.c | 2 +- 1 file changed, 1 insertion(+), 1

Re: [PATCH v11 4/4] bus: mhi: Add userspace client interface driver

2020-10-30 Thread Manivannan Sadhasivam
hi Hemant, On Fri, Oct 30, 2020 at 06:26:38PM -0700, Hemant Kumar wrote: > Hi Mani, > > On 10/30/20 3:34 AM, Manivannan Sadhasivam wrote: > > Hi Hemant, > > > > On Thu, Oct 29, 2020 at 07:45:46PM -0700, Hemant Kumar wrote: > > > This MHI client driver allows userspace clients to transfer > > >

[PATCH 5.9.y] erofs: avoid duplicated permission check for "trusted." xattrs

2020-10-30 Thread Gao Xiang
From: Gao Xiang commit d578b46db69d125a654f509bdc9091d84e924dc8 upstream. Don't recheck it since xattr_permission() already checks CAP_SYS_ADMIN capability. Just follow 5d3ce4f70172 ("f2fs: avoid duplicated permission check for "trusted." xattrs") Reported-by: Hongyu Jin [ Gao Xiang: since

[PATCH 5.8.y] erofs: avoid duplicated permission check for "trusted." xattrs

2020-10-30 Thread Gao Xiang
From: Gao Xiang commit d578b46db69d125a654f509bdc9091d84e924dc8 upstream. Don't recheck it since xattr_permission() already checks CAP_SYS_ADMIN capability. Just follow 5d3ce4f70172 ("f2fs: avoid duplicated permission check for "trusted." xattrs") Reported-by: Hongyu Jin [ Gao Xiang: since

[PATCH 5.4.y] erofs: avoid duplicated permission check for "trusted." xattrs

2020-10-30 Thread Gao Xiang
From: Gao Xiang commit d578b46db69d125a654f509bdc9091d84e924dc8 upstream. Don't recheck it since xattr_permission() already checks CAP_SYS_ADMIN capability. Just follow 5d3ce4f70172 ("f2fs: avoid duplicated permission check for "trusted." xattrs") Reported-by: Hongyu Jin [ Gao Xiang: since

Re: Using fixed LPI number for some Device ID

2020-10-30 Thread Thomas Gleixner
On Sat, Oct 31 2020 at 10:19, Dongjiu Geng wrote: > Hi Marc, > Sorry to disturb you, Currently the LPI number is not fixed for > the device. The LPI number is dynamically allocated start from 8092. > For two OS which shares the ITS, One OS needs to configure the device > interrupt required

Re: [PATCH v5 05/15] mm/frame-vector: Use FOLL_LONGTERM

2020-10-30 Thread John Hubbard
On 10/30/20 3:08 AM, Daniel Vetter wrote: This is used by media/videbuf2 for persistent dma mappings, not just for a single dma operation and then freed again, so needs FOLL_LONGTERM. Unfortunately current pup_locked doesn't support FOLL_LONGTERM due to locking issues. Rework the code to pull

Re: [PATCH] opp: Reduce the size of critical section in _opp_table_kref_release()

2020-10-30 Thread Stephen Boyd
Quoting Viresh Kumar (2020-10-29 21:20:00) > On 29-10-20, 09:40, Viresh Kumar wrote: > > Thanks a lot. I was a bit worried about the crazy idea I had to solve > > this :) > > Hmm, I thought this is the other patch where I had that crazy idea. > This one was quite straight forward :) > What's

Re: [PATCH v4 00/17] Add VFIO mediated device support and DEV-MSI support for the idxd driver

2020-10-30 Thread Thomas Gleixner
Ashok, On Fri, Oct 30 2020 at 13:43, Ashok Raj wrote: > On Fri, Oct 30, 2020 at 04:30:45PM -0300, Jason Gunthorpe wrote: >> On Fri, Oct 30, 2020 at 12:23:25PM -0700, Raj, Ashok wrote: >> It is a different subsystem, different maintainer, and different >> reviewers. >> >> It is a development

[PATCH net-next] net/mlx5e: Remove duplicated include

2020-10-30 Thread YueHaibing
Remove duplicated include. Signed-off-by: YueHaibing --- drivers/net/ethernet/mellanox/mlx5/core/en_rx.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_rx.c b/drivers/net/ethernet/mellanox/mlx5/core/en_rx.c index 599f5b5ebc97..58c177756dc4 100644

[PATCH net-next] net: hns3: Remove duplicated include

2020-10-30 Thread YueHaibing
Remove duplicated include. Signed-off-by: YueHaibing --- drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_dcb.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_dcb.c b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_dcb.c index

[PATCH net-next] liquidio: cn68xx: Remove duplicated include

2020-10-30 Thread YueHaibing
Remove duplicated include. Signed-off-by: YueHaibing --- drivers/net/ethernet/cavium/liquidio/cn68xx_device.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ethernet/cavium/liquidio/cn68xx_device.c b/drivers/net/ethernet/cavium/liquidio/cn68xx_device.c index

Re: [PATCH v11 00/10] NTFS read-write driver GPL implementation by Paragon Software

2020-10-30 Thread Eric Biggers
On Fri, Oct 30, 2020 at 07:42:09PM -0700, Eric Biggers wrote: > Hi Konstantin, > > On Fri, Oct 30, 2020 at 06:02:29PM +0300, Konstantin Komarov wrote: > > This patch adds NTFS Read-Write driver to fs/ntfs3. > > > > Having decades of expertise in commercial file systems development and huge > >

Re: [PATCH -next] drm/rockchip: cdn-dp: Mark cdn_dp_core_suspend/resume __maybe_unused

2020-10-30 Thread Yuehaibing
ping... On 2020/8/11 10:12, YueHaibing wrote: > If CONFIG_PM is not set, gcc warns: > > drivers/gpu/drm/rockchip/cdn-dp-core.c:1124:12: > warning: ‘cdn_dp_resume’ defined but not used [-Wunused-function] > > Mark them __maybe_unused to fix this. > > Reported-by: Hulk Robot > Signed-off-by:

Re: [PATCH v11 00/10] NTFS read-write driver GPL implementation by Paragon Software

2020-10-30 Thread Eric Biggers
Hi Konstantin, On Fri, Oct 30, 2020 at 06:02:29PM +0300, Konstantin Komarov wrote: > This patch adds NTFS Read-Write driver to fs/ntfs3. > > Having decades of expertise in commercial file systems development and huge > test coverage, we at Paragon Software GmbH want to make our contribution to >

Hello/Hallo

2020-10-30 Thread Mr. John Galvan
-- Sir/Madam, I have access to very vital information that can be used to move a huge amount of money. I have done my homework very well and I have the machineries in place to get it done since I am still in active service. If it was possible for me to do it alone I would not have bothered

Re: Using fixed LPI number for some Device ID

2020-10-30 Thread Dongjiu Geng
Hi Marc, Sorry to disturb you, Currently the LPI number is not fixed for the device. The LPI number is dynamically allocated start from 8092. For two OS which shares the ITS, One OS needs to configure the device interrupt required by another OS, and the other OS uses a fixed interrupt ID

[PATCH] scsi: qla2xxx: add missing iounmap() on error in qlafx00_iospace_config

2020-10-30 Thread Qinglang Miao
Add the missing iounmap() before return from qlafx00_iospace_config in the error handling case when os failed to do ioremap for ha->iobase. Signed-off-by: Qinglang Miao --- drivers/scsi/qla2xxx/qla_mr.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git

Re: [PATCH -next v2] usb: Mark sync_all_pins() with static keyword

2020-10-30 Thread Florian Fainelli
On 10/30/2020 6:48 PM, Zou Wei wrote: > Fix the following sparse warning: > > ./brcmstb-usb-pinmap.c:219:6: warning: symbol 'sync_all_pins' was not > declared. Should it be static? > > The sync_all_pins has only call site within brcmstb-usb-pinmap.c > Mark it static as suggested. > > Fixes:

Re: [PATCH] soc: mediatek: cmdq: fixup possible timeout issue

2020-10-30 Thread Nicolas Boichat
Thanks for the patch. On Thu, Oct 22, 2020 at 5:44 PM Houlong Wei wrote: > > Fixes: 576f1b4bc802 ("soc: mediatek: Add Mediatek CMDQ helper") nit: This belongs right next to the Sob line, but I guess/hope Matthias can help you fix that ,-) > > There may be possible timeout issue when lots of

Re: [Y2038][time namespaces] Question regarding CLOCK_REALTIME support plans in Linux time namespaces

2020-10-30 Thread Thomas Gleixner
Carlos, On Fri, Oct 30 2020 at 18:19, Carlos O'Donell wrote: > On 10/30/20 4:06 PM, Thomas Gleixner wrote: >> On Fri, Oct 30 2020 at 12:58, Carlos O'Donell wrote: >>> I expect that more requests for further time isolation will happen >>> given the utility of this in containers. >> >> There was a

[PATCH -next v2] usb: Mark sync_all_pins() with static keyword

2020-10-30 Thread Zou Wei
Fix the following sparse warning: ./brcmstb-usb-pinmap.c:219:6: warning: symbol 'sync_all_pins' was not declared. Should it be static? The sync_all_pins has only call site within brcmstb-usb-pinmap.c Mark it static as suggested. Fixes: 517c4c44b323 ("usb: Add driver to allow any GPIO to be

[rcu:rcu/next] BUILD SUCCESS 76b43ef30dc30f8d5f9ac91ccd562159995f5879

2020-10-30 Thread kernel test robot
defconfig mips allyesconfig mips allmodconfig powerpc allyesconfig powerpc allmodconfig powerpc allnoconfig x86_64 randconfig-a005-20201030 x86_64

November Equity Investment 20-20

2020-10-30 Thread JOHN PHIL
How are you doing today I have a proposal which i think may interest you and benefit you.I will like to give you full details of this via email: gerradfinancialplann...@gmail.com Thanks. John PHIL

Re: [PATCH net-next 0/5] L2 multicast forwarding for Ocelot switch

2020-10-30 Thread Jakub Kicinski
On Thu, 29 Oct 2020 04:27:33 +0200 Vladimir Oltean wrote: > This series enables the mscc_ocelot switch to forward raw L2 (non-IP) > mdb entries as configured by the bridge driver after this patch: > >

Re: [PATCH v11 4/4] bus: mhi: Add userspace client interface driver

2020-10-30 Thread Hemant Kumar
Hi Mani, On 10/30/20 3:34 AM, Manivannan Sadhasivam wrote: Hi Hemant, On Thu, Oct 29, 2020 at 07:45:46PM -0700, Hemant Kumar wrote: This MHI client driver allows userspace clients to transfer raw data between MHI device and host using standard file operations. Driver instantiates UCI device

Re: [PATCH v11 09/10] fs/ntfs3: Add NTFS3 in fs/Kconfig and fs/Makefile

2020-10-30 Thread kernel test robot
Hi Konstantin, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on linus/master] [also build test WARNING on v5.10-rc1 next-20201030] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base

[PATCH -next v3] platform/x86/dell-wmi-sysman: Make some symbols static

2020-10-30 Thread Zou Wei
Fix the following sparse warnings: ./passobj-attributes.c:38:23: warning: symbol 'po_is_pass_set' was not declared. Should it be static? ./passobj-attributes.c:70:23: warning: symbol 'po_current_password' was not declared. Should it be static? ./passobj-attributes.c:99:23: warning: symbol

ERROR: modpost: "__irq_set_affinity" undefined!

2020-10-30 Thread kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 5fc6b075e165f641fbc366b58b578055762d5f8c commit: 8d58f222e85f01da0c0e1fc1e77986c86de889e2 ubsan: disable UBSAN_ALIGNMENT under COMPILE_TEST date: 6 months ago config: mips-randconfig-r024-20201030

Re: [PATCH net-next 4/5] net: mscc: ocelot: make entry_type a member of struct ocelot_multicast

2020-10-30 Thread Jakub Kicinski
On Thu, 29 Oct 2020 04:27:37 +0200 Vladimir Oltean wrote: > + mc = devm_kzalloc(ocelot->dev, sizeof(*mc), GFP_KERNEL); > + if (!mc) > + return -ENOMEM; > + > + mc->entry_type = ocelot_classify_mdb(mdb->addr); > +

Re: [PATCH v20 04/20] mm/thp: use head for head page in lru_add_page_tail

2020-10-30 Thread Alex Shi
在 2020/10/30 下午9:52, Johannes Weiner 写道: > >> From a9ee63a213f40eb4d5a69b52fbb348ff9cd7cf6c Mon Sep 17 00:00:00 2001 >> From: Alex Shi >> Date: Tue, 26 May 2020 16:49:22 +0800 >> Subject: [PATCH v21 04/20] mm/thp: use head for head page in >> lru_add_page_tail >> >> Since the first parameter

Re: [PATCH v20 02/20] mm/memcg: bail early from swap accounting if memcg disabled

2020-10-30 Thread Alex Shi
在 2020/10/30 下午10:04, Johannes Weiner 写道: >>> Acked-by: Johannes Weiner >>> >>> This should go in before the previous patch that adds the WARN for it. >> Right, but than the long ops may not weird. Should I remove the ops and >> resend the whole patchset? > You mean the warning in the

[PATCH] drm: panel: simple: add missing platform_driver_unregister() in panel_simple_init

2020-10-30 Thread Qinglang Miao
Add the missing platform_driver_unregister() before return from panel_simple_init in the error handling case when failed to register panel_simple_dsi_driver with CONFIG_DRM_MIPI_DSI enabled. Signed-off-by: Qinglang Miao --- drivers/gpu/drm/panel/panel-simple.c | 4 +++- 1 file changed, 3

[PATCH] cpufreq: mediatek: add missing platform_driver_unregister() on error in mtk_cpufreq_driver_init

2020-10-30 Thread Qinglang Miao
Add the missing platform_driver_unregister() before return from mtk_cpufreq_driver_init in the error handling case when failed to register mtk-cpufreq platform device Signed-off-by: Qinglang Miao --- drivers/cpufreq/mediatek-cpufreq.c | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH] serial: txx9: add missing platform_driver_unregister() on error in serial_txx9_init

2020-10-30 Thread Qinglang Miao
Add the missing platform_driver_unregister() before return from serial_txx9_init in the error handling case when failed to register serial_txx9_pci_driver with macro ENABLE_SERIAL_TXX9_PCI defined. Signed-off-by: Qinglang Miao --- drivers/tty/serial/serial_txx9.c | 7 +-- 1 file changed, 5

Re: [PATCH net-next] net: bridge: explicitly convert between mdb entry state and port group flags

2020-10-30 Thread Jakub Kicinski
On Thu, 29 Oct 2020 01:48:15 +0200 Vladimir Oltean wrote: > When creating a new multicast port group, there is implicit conversion > between the __u8 state member of struct br_mdb_entry and the unsigned > char flags member of struct net_bridge_port_group. This implicit > conversion relies on the

Re: [PATCH v4 net-next] net: bridge: mcast: add support for raw L2 multicast groups

2020-10-30 Thread Jakub Kicinski
On Thu, 29 Oct 2020 01:38:31 +0200 Vladimir Oltean wrote: > From: Nikolay Aleksandrov > > Extend the bridge multicast control and data path to configure routes > for L2 (non-IP) multicast groups. > > The uapi struct br_mdb_entry union u is extended with another variant, > mac_addr, which does

[PATCH net-next v6 5/5] net: hdlc_fr: Add support for any Ethertype

2020-10-30 Thread Xie He
Change the fr_rx function to make this driver support any Ethertype when receiving skbs on normal (non-Ethernet-emulating) PVC devices. (This driver is already able to handle any Ethertype when sending.) Originally in the fr_rx function, the code that parses the long (10-byte) header only

[PATCH net-next v6 0/5] net: hdlc_fr: Improve fr_rx and add support for any Ethertype

2020-10-30 Thread Xie He
The main purpose of this series is the last patch. The previous 4 patches are just code clean-ups so that the last patch will not make the code too messy. The patches must be applied in sequence. The receiving code of this driver doesn't support arbitrary Ethertype values. It only recognizes a

[PATCH net-next v6 2/5] net: hdlc_fr: Change the use of "dev" in fr_rx to make the code cleaner

2020-10-30 Thread Xie He
The eth_type_trans function is called when we receive frames carrying Ethernet frames. This function expects a non-NULL pointer as an argument, and assigns it directly to skb->dev. However, the code handling other types of frames first assigns the pointer to "dev", and then at the end checks

[PATCH net-next v6 3/5] net: hdlc_fr: Do skb_reset_mac_header for skbs received on normal PVC devices

2020-10-30 Thread Xie He
When an skb is received on a normal (non-Ethernet-emulating) PVC device, call skb_reset_mac_header before we pass it to upper layers. This is because normal PVC devices don't have header_ops, so any header we have would not be visible to upper layer code when sending, so the header shouldn't be

[PATCH net-next v6 4/5] net: hdlc_fr: Improve the initial checks when we receive an skb

2020-10-30 Thread Xie He
1. Change the skb->len check from "<= 4" to "< 4". At first we only need to ensure a 4-byte header is present. We indeed normally need the 5th byte, too, but it'd be more logical and cleaner to check its existence when we actually need it. 2. Add an fh->ea2 check to the initial checks in fr_rx.

[PATCH net-next v6 1/5] net: hdlc_fr: Simpify fr_rx by using "goto rx_drop" to drop frames

2020-10-30 Thread Xie He
When the fr_rx function drops a received frame (because the protocol type is not supported, or because the PVC virtual device that corresponds to the DLCI number and the protocol type doesn't exist), the function frees the skb and returns. The code for freeing the skb and returning is repeated

Re: [PATCH v8 -tip 19/26] sched: Add a second-level tag for nested CGroup usecase

2020-10-30 Thread Josh Don
On Mon, Oct 19, 2020 at 6:45 PM Joel Fernandes (Google) wrote: > > +static unsigned long cpu_core_get_group_cookie(struct task_group *tg) > +{ > + unsigned long color = 0; > + > + if (!tg) > + return 0; > + > + for (; tg; tg = tg->parent) { > + if

[PATCH net-next v5 3/5] net: hdlc_fr: Do skb_reset_mac_header for skbs received on normal PVC devices

2020-10-30 Thread Xie He
When an skb is received on a normal (non-Ethernet-emulating) PVC device, call skb_reset_mac_header before we pass it to upper layers. This is because normal PVC devices don't have header_ops, so any header we have would not be visible to upper layer code when sending, so the header shouldn't be

[PATCH v5 2/2] firmware: QCOM_SCM: Allow qcom_scm driver to be loadable as a permenent module

2020-10-30 Thread John Stultz
Allow the qcom_scm driver to be loadable as a permenent module. This still uses the "depends on QCOM_SCM || !QCOM_SCM" bit to ensure that drivers that call into the qcom_scm driver are also built as modules. While not ideal in some cases its the only safe way I can find to avoid build errors

[PATCH net-next v5 1/5] net: hdlc_fr: Simpify fr_rx by using "goto rx_drop" to drop frames

2020-10-30 Thread Xie He
When the fr_rx function drops a received frame (because the protocol type is not supported, or because the PVC virtual device that corresponds to the DLCI number and the protocol type doesn't exist), the function frees the skb and returns. The code for freeing the skb and returning is repeated

[PATCH net-next v5 2/5] net: hdlc_fr: Change the use of "dev" in fr_rx to make the code cleaner

2020-10-30 Thread Xie He
The eth_type_trans function is called when we receive frames carrying Ethernet frames. This function expects a non-NULL pointer as an argument, and assigns it directly to skb->dev. However, the code handling other types of frames first assigns the pointer to "dev", and then at the end checks

[PATCH net-next v5 5/5] net: hdlc_fr: Add support for any Ethertype

2020-10-30 Thread Xie He
Change the fr_rx function to make this driver support any Ethertype when receiving skbs on normal (non-Ethernet-emulating) PVC devices. (This driver is already able to handle any Ethertype when sending.) Originally in the fr_rx function, the code that parses the long (10-byte) header only

[PATCH net-next v5 0/5] net: hdlc_fr: Improve fr_rx and add support for any Ethertype

2020-10-30 Thread Xie He
The main purpose of this series is the last patch. The previous 4 patches are just code clean-ups so that the last patch will not make the code too messy. The patches must be applied in sequence. The receiving code of this driver doesn't support arbitrary Ethertype values. It only recognizes a

[PATCH net-next v5 4/5] net: hdlc_fr: Improve the initial checks when we receive an skb

2020-10-30 Thread Xie He
1. Change the skb->len check from "<= 4" to "< 4". At first we only need to ensure a 4-byte header is present. We indeed normally need the 5th byte, too, but it'd be more logical and cleaner to check its existence when we actually need it. 2. Add an fh->ea2 check to the initial checks in fr_rx.

[PATCH v5 1/2] pinctrl: qcom: Allow pinctrl-msm code to be loadable as a module

2020-10-30 Thread John Stultz
Tweaks to allow pinctrl-msm code to be loadable as a module. This is needed in order to support having the qcom-scm driver, which pinctrl-msm calls into, configured as a module. This requires that we tweak Kconfigs selecting PINCTRL_MSM to also depend on QCOM_SCM || QCOM_SCM=n so that we match

[RFC][PATCH 1/2] arm-smmu-qcom: Ensure the qcom_scm driver has finished probing

2020-10-30 Thread John Stultz
Robin Murphy pointed out that if the arm-smmu driver probes before the qcom_scm driver, we may call qcom_scm_qsmmu500_wait_safe_toggle() before the __scm is initialized. Now, getting this to happen is a bit contrived, as in my efforts it required enabling asynchronous probing for both drivers,

[RFC][PATCH 2/2] iommu: Avoid crash if iommu_group is null

2020-10-30 Thread John Stultz
In trying to handle a possible driver probe ordering issue brought up by Robin Murphy, I ran across a separate null pointer crash in the iommu core in iommu_group_remove_device(): [2.732803] dwc3-qcom a6f8800.usb: failed to get usb-ddr path: -517 [2.739281] Unable to handle kernel NULL

Re: [PATCH v11 4/4] bus: mhi: Add userspace client interface driver

2020-10-30 Thread Hemant Kumar
Hi Randy, On 10/29/20 10:48 PM, Randy Dunlap wrote: On 10/29/20 7:45 PM, Hemant Kumar wrote: diff --git a/drivers/bus/mhi/Kconfig b/drivers/bus/mhi/Kconfig index e841c10..476cc55 100644 --- a/drivers/bus/mhi/Kconfig +++ b/drivers/bus/mhi/Kconfig @@ -20,3 +20,16 @@ config MHI_BUS_DEBUG

Re: [f2fs-dev] [PATCH v2] f2fs: move ioctl interface definitions to separated file

2020-10-30 Thread Chao Yu
On 2020/10/31 0:55, Eric Biggers wrote: On Fri, Oct 30, 2020 at 03:26:10PM +0800, Chao Yu wrote: + +struct f2fs_gc_range { + u32 sync; + u64 start; + u64 len; +}; Userspace headers need to use __u32, __u64, etc. instead of u32, u64, etc. Correct. Did you try installing

[PATCH RFC v3 0/4] x86/bus_lock: Enable bus lock detection

2020-10-30 Thread Fenghua Yu
A bus lock [1] is acquired either through split locked access to writeback (WB) memory or by using locks to uncacheable (UC) memory (e.g. direct device assignment). This is typically >1000 cycles slower than an atomic operation within a cache line. It also disrupts performance on other cores.

Re: [PATCH] stop_machine: Mark functions as notrace

2020-10-30 Thread Steven Rostedt
On Fri, 30 Oct 2020 14:47:56 -0700 Atish Patra wrote: > > Look at arm64, they __kprobes flag and I guess it would also prevent > > ftrace call site. > > > > Are you sure about that ? __kprobes puts the code in .kprobes.text section > which is under whitelist sections in recordmcount.pl &

[PATCH RFC v3 2/4] x86/bus_lock: Handle warn and fatal in #DB for bus lock

2020-10-30 Thread Fenghua Yu
#DB for bus lock is enabled by bus lock detection bit 2 in DEBUGCTL MSR while #AC for split lock is enabled by split lock detection bit 29 in TEST_CTRL MSR. Delivery of #DB for bus lock in userspace clears DR6[11]. To avoid confusion in identifying #DB, #DB handler sets the bit to 1 before

[PATCH RFC v3 3/4] x86/bus_lock: Set rate limit for bus lock

2020-10-30 Thread Fenghua Yu
To enforce user application throttling or mitigations, extend the existing split lock detect kernel parameter: split_lock_detect=ratelimit:N It limits bus lock rate to N per second for non root users. Signed-off-by: Fenghua Yu Reviewed-by: Tony Luck --- arch/x86/kernel/cpu/intel.c |

[PATCH RFC v3 1/4] x86/cpufeatures: Enumerate #DB for bus lock detection

2020-10-30 Thread Fenghua Yu
A bus lock is acquired either through split locked access to writeback (WB) memory or by using locks to uncacheable (UC) memory (e.g. direct device assignment). This is typically >1000 cycles slower than an atomic operation within a cache line. It also disrupts performance on other cores. Some

[PATCH RFC v3 4/4] Documentation/admin-guide: Change doc for split_lock_detect parameter

2020-10-30 Thread Fenghua Yu
Since #DB for bus lock detect changes the split_lock_detect parameter, update the documentation for the changes. Signed-off-by: Fenghua Yu Reviewed-by: Tony Luck --- Change Log: - Simplify the documentation (Randy). .../admin-guide/kernel-parameters.txt | 28 +++ 1

Re: [PATCH v2 net 0/5] net: ipa: minor bug fixes

2020-10-30 Thread Jakub Kicinski
On Thu, 29 Oct 2020 11:50:52 -0500 Alex Elder wrote: > On 10/29/20 11:11 AM, Jakub Kicinski wrote: > > On Wed, 28 Oct 2020 14:41:43 -0500 Alex Elder wrote: > >> This series fixes several bugs. They are minor, in that the code > >> currently works on supported platforms even without these

Re: [PATCH net-next v4] net: dec: tulip: de2104x: Add shutdown handler to stop NIC

2020-10-30 Thread Jakub Kicinski
On Wed, 28 Oct 2020 10:21:25 -0700 Moritz Fischer wrote: > The driver does not implement a shutdown handler which leads to issues > when using kexec in certain scenarios. The NIC keeps on fetching > descriptors which gets flagged by the IOMMU with errors like this: > > DMAR: DMAR:[DMA read]

Re: [PATCH v2 5/5] firmware: QCOM_SCM: Allow qcom_scm driver to be loadable as a permenent module

2020-10-30 Thread John Stultz
On Fri, Oct 30, 2020 at 7:12 AM Robin Murphy wrote: > On 2020-10-30 01:02, John Stultz wrote: > > On Wed, Oct 28, 2020 at 7:51 AM Robin Murphy wrote: > >> Hmm, perhaps I'm missing something here, but even if the config options > >> *do* line up, what prevents arm-smmu probing before qcom-scm and

Re: [PATCH] fix for potential NULL pointer dereference with bare lan743x

2020-10-30 Thread Jakub Kicinski
On Thu, 29 Oct 2020 03:28:45 +0300 Sergej Bauer wrote: > This is just a minor fix which prevents a kernel NULL pointer > dereference when using phy-less lan743x. > > Signed-off-by: Sergej Bauer I take you mean when the device is down netdev->phydev will be NULL? > diff --git

Re: [PATCH bpf-next 1/5] bpf: Implement task local storage

2020-10-30 Thread Song Liu
On Fri, Oct 30, 2020 at 4:07 AM KP Singh wrote: > > " > > On Fri, Oct 30, 2020 at 12:28 AM Song Liu wrote: > > > > On Wed, Oct 28, 2020 at 9:17 AM KP Singh wrote: > > > > > > From: KP Singh > > > > > > Similar to bpf_local_storage for sockets and inodes add local storage > > > for task_struct.

Re: [PATCH v2 0/3] gpiolib: cdev: allow edge event timestamps to be configured as REALTIME

2020-10-30 Thread Kent Gibson
On Fri, Oct 30, 2020 at 03:52:24PM +0100, Bartosz Golaszewski wrote: > On Fri, Oct 30, 2020 at 3:49 PM Bartosz Golaszewski > wrote: > > > > On Thu, Oct 29, 2020 at 12:22 AM Kent Gibson wrote: > > > > > > On Wed, Oct 28, 2020 at 05:01:49PM +0100, Linus Walleij wrote: > > > > On Thu, Oct 15, 2020

[PATCH] perf: increase size of buf in perf_evsel__hists_browse()

2020-10-30 Thread Song Liu
Making perf with gcc-9.1.1 generates the following warning: CC ui/browsers/hists.o ui/browsers/hists.c: In function 'perf_evsel__hists_browse': ui/browsers/hists.c:3078:61: error: '%d' directive output may be \ truncated writing between 1 and 11 bytes into a region of size \ between 2 and

Re: [patch V2 00/18] mm/highmem: Preemptible variant of kmap_atomic & friends

2020-10-30 Thread Thomas Gleixner
On Sat, Oct 31 2020 at 00:26, Thomas Gleixner wrote: > On Fri, Oct 30 2020 at 15:46, Linus Torvalds wrote: >> On Fri, Oct 30, 2020 at 3:26 PM Thomas Gleixner wrote: >> To me, your patch series has two big advantages: >> >> - more common code >> >> - kmap_local() becomes more of a no-op >> >>

[PATCH v2 4/6] dt-bindings: arm: sunxi: add Elimo bindings

2020-10-30 Thread Matteo Scordino
Document board compatible names for Elimo Engineering Impetus and Initium Signed-off-by: Matteo Scordino --- Documentation/devicetree/bindings/arm/sunxi.yaml | 13 + 1 file changed, 13 insertions(+) diff --git a/Documentation/devicetree/bindings/arm/sunxi.yaml

[PATCH v2 2/6] ARM: dts: sun8i: V3/S3: Add UART1 pin definitions to the V3/S3 dtsi

2020-10-30 Thread Matteo Scordino
The Allwinner V3 and S3 can use PG6/7 as RX/TX for UART1. Since no other functions are assigned to those pins, they are a convenient choice for a debugging or application UART. This is specific to V3/S3 as the V3s's non-BGA package did not have those pins. Signed-off-by: Matteo Scordino ---

[PATCH v2 0/6] Elimo Impetus and Initium support - rework

2020-10-30 Thread Matteo Scordino
Hi, I applied the suggestions from the discussion that stemmed from V1, i.e.: - using "sochip,s3", "allwinner,sun8i-v3" in the compatible string - add a patch to do the same for the Pine64 PineCube - alphabetic order in the dt-binding file - match the dt-binding file with the actual dts files

[PATCH v2 3/6] ARM: dts: sun8i: s3: Add dtsi for the Elimo Impetus SoM

2020-10-30 Thread Matteo Scordino
The Elimo Engineering Impetus is an Open Source Hardware System-on-Module based on the SoChip S3 SoC. It is meant for integration into carrier boards or, more generally, larger designs, and uses an M2 connector to facilitate that. Interfaces on the M.2/NGFF 42mm connector: WiFi IEEE 802. 11abgn

[PATCH v2 1/6] dt-bindings: vendors: add Elimo Engineering vendor prefix

2020-10-30 Thread Matteo Scordino
Add elimo as vendor prefix for dt bindings, since we are adding a dtsi for a SoM and a dts for an SBC Signed-off-by: Matteo Scordino --- Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git

[PATCH v2 6/6] ARM: dts: sunxi: align pinecube compatible property to other S3 boards

2020-10-30 Thread Matteo Scordino
The compatible string in the Pine64 Pincube dts diverges from the ones used in other S3 based boards, like the LicheePi and the Elimo Impetus and Initium. Discussion on LKML decided the PineCube should align to the others. Signed-off-by: Matteo Scordino ---

[PATCH v2 5/6] ARM: dts: sun8i: s3: Add dts for the Elimo Initium SBC

2020-10-30 Thread Matteo Scordino
The Elimo Engineering Initium is an Open Source Hardware Single Board Computer based on the Elimo Impetus SoM. It is meant as the first development platform for the Impetus, providing convenient access to the peripherals on the Impetus. It provides: USB-C power input UART-to-USB bridge on the

Re: [PATCH v4 2/3] bindings: pm8941-misc: Add support for VBUS detection

2020-10-30 Thread Guru Das Srinagesh
On Fri, Oct 30, 2020 at 08:36:12AM -0500, Rob Herring wrote: > On Wed, Oct 28, 2020 at 12:18:53AM -0700, Guru Das Srinagesh wrote: > > Add compatible string that adds support for reporting VBUS detection > > status that can be detected via a dedicated PMIC pin. > > > > Signed-off-by: Anirudh

Re: [PATCH net-next 00/19] net: phy: add support for shared interrupts (part 1)

2020-10-30 Thread Andrew Lunn
> > - Every PHY driver gains a .handle_interrupt() implementation that, for > > the most part, would look like below: > > > > irq_status = phy_read(phydev, INTR_STATUS); > > if (irq_status < 0) { > > phy_error(phydev); > > return IRQ_NONE; > > } > > > >

Re: [PATCH 1/3] x86/resctrl: Remove superfluous kernfs_get() calls to prevent refcount leak

2020-10-30 Thread Willem de Bruijn
On Fri, Oct 30, 2020 at 2:45 PM Xiaochen Shen wrote: > > Willem reported growing of kernfs_node_cache entries in slabtop when > repeatedly creating and removing resctrl subdirectories as well as when > repeatedly mounting and unmounting resctrl filesystem. > > On resource group (control as well

  1   2   3   4   5   6   7   8   9   10   >