Re: [PATCH v4 06/11] clk: at91: clk-sam9x60-pll: allow runtime changes for pll

2020-11-17 Thread Stephen Boyd
Quoting claudiu.bez...@microchip.com (2020-11-16 03:24:54) > > > On 14.11.2020 23:14, Stephen Boyd wrote: > > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > > content is safe > > > > Quoting Claudiu Beznea (2020-11-06 01:46:23) > >> diff --git

Re: [RFC] Are you good with Lockdep?

2020-11-17 Thread Boqun Feng
Hi Matthew, On Mon, Nov 16, 2020 at 03:37:29PM +, Matthew Wilcox wrote: [...] > > It's not just about lockdep for semaphores. Mutexes will spin if the > current owner is still running, so to convert an interrupt-released > semaphore to a mutex, we need a way to mark the mutex as being

[PATCH] Documentation/admin-guide: mark memmap parameter is supported by a few architectures

2020-11-17 Thread Barry Song
early_param memmap is only implemented on X86, MIPS and XTENSA. To avoid wasting users’ time on trying this on platform like ARM, mark it clearly. Signed-off-by: Barry Song --- * the background was that I spent one hour on using memmap on arm64, only to find memmap= is not implemented on

Re: [PATCH] (v2) drivers: clk: make gpio-gated clock support optional

2020-11-17 Thread Stephen Boyd
Quoting Enrico Weigelt, metux IT consult (2020-11-17 08:03:06) > diff --git a/drivers/clk/Kconfig b/drivers/clk/Kconfig > index c715d4681a0b..99e0188a15be 100644 > --- a/drivers/clk/Kconfig > +++ b/drivers/clk/Kconfig > @@ -38,6 +38,14 @@ menuconfig COMMON_CLK > > if COMMON_CLK > > +config

Re: [PATCH] dt-bindings: arm: add additionalProperties

2020-11-17 Thread Chunfeng Yun
On Tue, 2020-11-17 at 11:37 +0100, Geert Uytterhoeven wrote: > Hi Chunfeng, > > On Tue, Nov 17, 2020 at 11:32 AM Chunfeng Yun > wrote: > > Add an explicit "additionalProperties: true" to avoid > > dt_binding_check error caused by: > > 'additionalProperties' is a required property > > > > This

Re: [PATCH 2/2] fpga: dfl: look for vendor specific capability

2020-11-17 Thread Tom Rix
>> Is this really an either/or ? >> >> Could there be a base functionality on bar0 and a skew functionality on >> vendor bars? > > For simplicity I think either or is better.  If skew functionality is in > vendor bars, why not just use the vendor bars all the time. > >> >> If vendor is going

Re: [PATCH bpf-next v6 06/34] bpf: prepare for memcg-based memory accounting for bpf maps

2020-11-17 Thread Roman Gushchin
On Tue, Nov 17, 2020 at 05:11:00PM -0800, Alexei Starovoitov wrote: > On Tue, Nov 17, 2020 at 5:07 PM Roman Gushchin wrote: > > > > On Tue, Nov 17, 2020 at 04:46:34PM -0800, Roman Gushchin wrote: > > > On Wed, Nov 18, 2020 at 01:06:17AM +0100, Daniel Borkmann wrote: > > > > On 11/17/20 4:40 AM,

Re: [PATCH AUTOSEL 5.9 13/21] lockdep: Avoid to modify chain keys in validate_chain()

2020-11-17 Thread Boqun Feng
Hi Sasha, I don't think this commit should be picked by stable, since the problem it fixes is caused by commit f611e8cf98ec ("lockdep: Take read/write status in consideration when generate chainkey"), which just got merged in the merge window of 5.10. So 5.9 and 5.4 don't have the problem.

RE: [PATCH net-next] r8153_ecm: avoid to be prior to r8152 driver

2020-11-17 Thread Hayes Wang
Jakub Kicinski > Sent: Wednesday, November 18, 2020 12:12 AM [...] > Something like this? > > config USB_RTL8153_ECM > tristate > select MII > select USB_NET_CDCETHER > depends on USB_RTL8152 || USB_RTL8152=n > help > > > > select clauses will pull

Re: [LKP] Re: [block, scsi, ide] 3e3b42fee6: kmsg.sd#:#:#:#:[sdf]Asking_for_cache_data_failed

2020-11-17 Thread Philip Li
On Tue, Nov 17, 2020 at 08:46:46AM -0800, Bart Van Assche wrote: > On 11/17/20 8:00 AM, kernel test robot wrote: > > on test machine: 4 threads Intel(R) Core(TM) i5-6500 CPU @ 3.20GHz with 32G > > memory > > > > caused below changes (please refer to attached dmesg/kmsg for entire > >

drivers/net/phy/mscc/mscc_ptp.c:138:12: warning: Redundant condition: cond. '!cond || (cond && upper)' is equivalent to '!cond || upper'

2020-11-17 Thread kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 9c87c9f41245baa3fc4716cf39141439cf405b01 commit: ab2bf933935710ac545f94e49d16b5eab01f846f net: phy: mscc: 1588 block initialization compiler: h8300-linux-gcc (GCC) 9.3.0 If you fix the issue, kindly add

Re: [PATCH v2 4/4] mtd: parsers: afs: Fix freeing the part name memory in failure

2020-11-17 Thread Linus Walleij
On Tue, Nov 17, 2020 at 6:49 PM Manivannan Sadhasivam wrote: > In the case of failure while parsing the partitions, the iterator should > be pre decremented by one before starting to free the memory allocated > by kstrdup(). Because in the failure case, kstrdup() will not succeed > and thus no

Re: [PATCH v5 7/7] scsi: ufs: show lba and length for unmap commands

2020-11-17 Thread Can Guo
On 2020-11-18 00:58, Jaegeuk Kim wrote: From: Leo Liou We have lba and length for unmap commands. Signed-off-by: Leo Liou Reviewed-by: Stanley Chu Signed-off-by: Jaegeuk Kim Reviewed-by: Can Guo --- drivers/scsi/ufs/ufshcd.c | 5 + 1 file changed, 5 insertions(+) diff --git

[PATCH v3 5/6] ibmvfc: add support for target_wwpn field in v2 MADs and vfcFrame

2020-11-17 Thread Tyrel Datwyler
Several version 2 MADs and the version 2 vfcFrame structures introduced a new targetWWPN field for better identification of a target over the scsi_id. Set this field and MAD versioning fields when the VIOS advertises the IBMVFC_HANDLE_VF_WWPN capability. Signed-off-by: Tyrel Datwyler ---

[PATCH v3 2/6] ibmvfc: add new fields for version 2 of several MADs

2020-11-17 Thread Tyrel Datwyler
Introduce a target_wwpn field to several MADs. Its possible that a scsi ID of a target can change due to some fabric changes. The WWPN of the scsi target provides a better way to identify the target. Also, add flags for receiving MAD versioning information and advertising client support for

[PATCH v3 3/6] ibmvfc: add helper for testing capability flags

2020-11-17 Thread Tyrel Datwyler
Testing the NPIV Login response capabilities is a long winded process of dereferencing the vhost->login_buf->resp.capabilities field, then byte swapping that value to host endian, and performing the bitwise test. Currently we only ever check this in ibmvfc_cancel_all(), but follow-up patches will

[PATCH v3 4/6] ibmvfc: add FC payload retrieval routines for versioned vfcFrames

2020-11-17 Thread Tyrel Datwyler
The FC iu and response payloads are located at different offsets depending on the ibmvfc_cmd version. This is a result of the version 2 vfcFrame definition adding an extra 64bytes of reserved space to the structure prior to the payloads. Add helper routines to determine the current vfcFrame

[PATCH v3 6/6] ibmvfc: advertise client support for targetWWPN using v2 commands

2020-11-17 Thread Tyrel Datwyler
The previous patch added support for the targetWWPN field in version 2 MADs and vfcFrame structures. Set the IBMVFC_CAN_SEND_VF_WWPN bit in our capabailites flag during NPIV Login to inform the VIOS that this client supports the feature. Signed-off-by: Tyrel Datwyler ---

[PATCH v3 1/6] ibmvfc: deduplicate common ibmvfc_cmd init code

2020-11-17 Thread Tyrel Datwyler
The virtual FC frame command exchanged with the VIOS is used for device reset and command abort TMF as well as normally queued commands. When initializing the ibmvfc_cmd there are several elements of the command that are set the same way regardless of the command type. Deduplicate code by moving

[PATCH v3 0/6] ibmvfc: Protocol definition updates and new targetWWPN Support

2020-11-17 Thread Tyrel Datwyler
Several Management Datagrams (MADs) have been reversioned to add a targetWWPN field that is intended to better identify a target over in place of the scsi_id. This patchset adds the new protocol definitions and implements support for using the new targetWWPN field and exposing the capability to

Re: [PATCH bpf-next v6 06/34] bpf: prepare for memcg-based memory accounting for bpf maps

2020-11-17 Thread Alexei Starovoitov
On Tue, Nov 17, 2020 at 5:07 PM Roman Gushchin wrote: > > On Tue, Nov 17, 2020 at 04:46:34PM -0800, Roman Gushchin wrote: > > On Wed, Nov 18, 2020 at 01:06:17AM +0100, Daniel Borkmann wrote: > > > On 11/17/20 4:40 AM, Roman Gushchin wrote: > > > > In the absolute majority of cases if a process is

Re: [PATCH] tracepoint: Do not fail unregistering a probe due to memory allocation

2020-11-17 Thread Steven Rostedt
On Tue, 17 Nov 2020 18:08:19 -0500 (EST) Mathieu Desnoyers wrote: > Because of this end-of-loop condition ^ > which is also testing for a NULL func. So if we reach a stub, we end up > stopping > iteration and not firing the following tracepoint probes. Ah right. OK, since it's looking like

Re: [PATCH] bpf: don't fail kmalloc while releasing raw_tp

2020-11-17 Thread Steven Rostedt
On Tue, 17 Nov 2020 16:42:44 -0800 Matt Mullins wrote: > > Indeed with a stub function, I don't see any need for READ_ONCE/WRITE_ONCE. > > > > I'm not sure if this is a practical issue, but without WRITE_ONCE, can't > the write be torn? A racing __traceiter_ could potentially see a >

Re: [PATCH bpf-next v6 06/34] bpf: prepare for memcg-based memory accounting for bpf maps

2020-11-17 Thread Roman Gushchin
On Tue, Nov 17, 2020 at 04:46:34PM -0800, Roman Gushchin wrote: > On Wed, Nov 18, 2020 at 01:06:17AM +0100, Daniel Borkmann wrote: > > On 11/17/20 4:40 AM, Roman Gushchin wrote: > > > In the absolute majority of cases if a process is making a kernel > > > allocation, it's memory cgroup is getting

Re: [PATCH v2 6/8] platform/chrome: cros_ec_typec: Use Thunderbolt 3 cable discover mode VDO in USB4 mode

2020-11-17 Thread Prashant Malani
On Tue, Nov 17, 2020 at 10:19 AM Prashant Malani wrote: > > Hi Utkarsh, > > On Fri, Nov 13, 2020 at 12:25:01PM -0800, Utkarsh Patel wrote: > > Configure Thunderbolt3/USB4 cable generation value by filing Thunderbolt 3 > > cable discover mode VDO to support rounded and non-rounded Thunderbolt3/

Re: [PATCH v2] drm/sun4i: dw-hdmi: fix error return code in sun8i_dw_hdmi_bind()

2020-11-17 Thread Xiongfeng Wang
On 2020/11/18 1:47, Jernej Škrabec wrote: > Dne ponedeljek, 16. november 2020 ob 02:09:29 CET je Xiongfeng Wang > napisal(a): >> Fix to return a negative error code from the error handling case instead >> of 0 in function sun8i_dw_hdmi_bind(). >> >> Fixes: b7c7436a5ff0 ("drm/sun4i: Implement

RE: [PATCH v1 1/1] mmc: sdhci-of-arasan: Specify .clk_ops for Keem Bay SOC

2020-11-17 Thread Zulkifli, Muhammad Husaini
Hi Ulf, >-Original Message- >From: Ulf Hansson >Sent: Wednesday, November 18, 2020 1:14 AM >To: Zulkifli, Muhammad Husaini >Cc: linux-...@vger.kernel.org; Linux ARM ker...@lists.infradead.org>; Linux Kernel Mailing List ker...@vger.kernel.org>; Hunter, Adrian ; Raja >Subramanian,

Re: [PATCH v1] spi: fix client driver breakages when using GPIO descriptors

2020-11-17 Thread Linus Walleij
On Mon, Nov 16, 2020 at 10:06 PM Mark Brown wrote: > On Wed, Nov 11, 2020 at 02:36:07PM +0100, Linus Walleij wrote: > > I don't know if we ever formalized it, there is nowadays a rule akin to > > > "if a property can be determined from the compatible-string, and if the > > compatible-string is

[PATCH v1 1/1] ASoC: qcom: sc7180: fix 32 bit format for adau7002

2020-11-17 Thread xuyuqing
the microphone is attached to external codec(adau7002) instead of rt5682.We need to always use 32 bit format on sc7180 to meet the clock requirement of adau7002: The ADAU7002 requires a BCLK rate that is a minimum of 64× the LRCLK sample rate Signed-off-by: xuyuqing --- sound/soc/qcom/sc7180.c

[PATCH v1 0/1] Fix 32 bit format for adau7002

2020-11-17 Thread xuyuqing
the microphone is attached to external codec(adau7002) instead of rt5682.We need to always use 32 bit format on sc7180 to meet the clock requirement of adau7002: The ADAU7002 requires a BCLK rate that is a minimum of 64× the LRCLK sample rate xuyuqing (1): ASoC: qcom: sc7180: fix 32 bit format

[PATCH v4 net-next 2/3] ICMPv6: define PROBE message types

2020-11-17 Thread Andreas Roeseler
The types of ICMPV6 Extended Echo Request and ICMPV6 Extended Echo Reply are defined in sections 2 and 3 of RFC8335. Signed-off-by: Andreas Roeseler --- Changes since v1: - Switch to correct base tree Changes since v2: - Switch to net-next tree 67c70b5eb2bf7d0496fcb62d308dc3096bc11553

[PATCH v4 net-next 3/3] net: add support for sending RFC8335 PROBE

2020-11-17 Thread Andreas Roeseler
Modifying the ping_supported function to support probe message types allows the user to send probe requests through the existing framework for sending ping requests. Signed-off-by: Andreas Roeseler --- Changes since v1: - Switch to correct base tree Changes since v2: - Switch to net-next tree

[PATCH v4 net-next 0/3] add support for sending RFC8335 PROBE

2020-11-17 Thread Andreas Roeseler
The popular utility ping has several severe limitations such as the inability to query specific interfaces on a node and requiring bidirectional connectivity between the probing and the probed interfaces. RFC8335 attempts to solve these limitations by creating the new utility PROBE which is a

[PATCH v4 net-next 1/3] icmp: define PROBE message types

2020-11-17 Thread Andreas Roeseler
The types of ICMP Extended Echo Request and ICMP Extended Echo Reply are defined in sections 2 and 3 of RFC8335. Signed-off-by: Andreas Roeseler --- Changes since v1: - Switch to correct base tree Changes since v2: - Switch to net-next tree 67c70b5eb2bf7d0496fcb62d308dc3096bc11553 Changes

Re: [PATCH bpf-next v6 06/34] bpf: prepare for memcg-based memory accounting for bpf maps

2020-11-17 Thread Roman Gushchin
On Wed, Nov 18, 2020 at 01:06:17AM +0100, Daniel Borkmann wrote: > On 11/17/20 4:40 AM, Roman Gushchin wrote: > > In the absolute majority of cases if a process is making a kernel > > allocation, it's memory cgroup is getting charged. > > > > Bpf maps can be updated from an interrupt context and

Re: Same problem for 4.14.y and a concern: Re: [PATCH 4.19 056/191] powerpc: select ARCH_WANT_IRQS_OFF_ACTIVATE_MM

2020-11-17 Thread Sasha Levin
On Tue, Nov 17, 2020 at 10:51:16AM -0800, Kamal Mostafa wrote: On Tue, Nov 3, 2020 at 4:22 PM Michael Ellerman wrote: Greg Kroah-Hartman writes: > From: Nicholas Piggin > > [ Upstream commit 66acd46080bd9e5ad2be4b0eb1d498d5145d058e ] > > powerpc uses IPIs in some situations to switch a

Re: [PATCH v2 0/6] ibmvfc: Protocol definition updates and new targetWWPN Support

2020-11-17 Thread Tyrel Datwyler
On 11/17/20 11:16 AM, Tyrel Datwyler wrote: > Several Management Datagrams (MADs) have been reversioned to add a targetWWPN > field that is intended to better identify a target over a scsi_id. Further, a > couple new MADs have been introduced to the protocol to be used for > negotiation > of

Re: [PATCH v2 5/8] usb: typec: Use Thunderbolt 3 cable discover mode VDO in Enter_USB message

2020-11-17 Thread Prashant Malani
On Tue, Nov 17, 2020 at 1:16 PM Prashant Malani wrote: > > Hi Utkarsh, > > On Fri, Nov 13, 2020 at 12:25:00PM -0800, Utkarsh Patel wrote: > > USB4 also uses same cable properties as Thunderbolt 3 so use Thunderbolt 3 > > cable discover mode VDO to fill details such as active cable plug link > >

Re: [PATCH] bpf: don't fail kmalloc while releasing raw_tp

2020-11-17 Thread Matt Mullins
On Tue, Nov 17, 2020 at 06:05:51PM -0500, Mathieu Desnoyers wrote: > - On Nov 16, 2020, at 5:10 PM, rostedt rost...@goodmis.org wrote: > > > On Mon, 16 Nov 2020 16:34:41 -0500 (EST) > > Mathieu Desnoyers wrote: > > [...] > > >> I think you'll want a WRITE_ONCE(old[i].func, tp_stub_func)

Re: [LINUX PATCH V3 0/9] gpio-xilinx: Update on xilinx gpio driver

2020-11-17 Thread Linus Walleij
On Thu, Nov 12, 2020 at 6:13 PM Srinivas Neeli wrote: > Srinivas Neeli (9): > gpio: gpio-xilinx: Arrange headers in sorting order > dt-bindings: gpio: gpio-xilinx: Add clk support to xilinx soft gpio IP > gpio: gpio-xilinx: Add clock support > gpio: gpio-xilinx: Reduce spinlock array to

Re: [LINUX PATCH V3 9/9] MAINTAINERS: add fragment for xilinx GPIO drivers

2020-11-17 Thread Linus Walleij
On Thu, Nov 12, 2020 at 6:13 PM Srinivas Neeli wrote: > Added entry for xilinx GPIO drivers. > > Signed-off-by: Srinivas Neeli > Acked-by: Shubhrajyoti Datta Patch applied. Yours, Linus Walleij

Re: [LINUX PATCH V3 8/9] gpio: gpio-xilinx: Check return value of of_property_read_u32

2020-11-17 Thread Linus Walleij
On Thu, Nov 12, 2020 at 6:13 PM Srinivas Neeli wrote: > In two different instances the return value of "of_property_read_u32" > API was neither captured nor checked. > Fixed it by capturing the return value and then checking for any error. > > Addresses-Coverity: "check_return" > Signed-off-by:

Re: [PATCH 4/6] ibmvfc: add FC payload retrieval routines for versioned vfcFrames

2020-11-17 Thread Tyrel Datwyler
On 11/17/20 2:21 PM, Brian King wrote: > On 11/17/20 4:14 PM, Brian King wrote: >> On 11/11/20 7:04 PM, Tyrel Datwyler wrote: >>> The FC iu and response payloads are located at different offsets >>> depending on the ibmvfc_cmd version. This is a result of the version 2 >>> vfcFrame definition

Re: [PATCH bpf-next v4 1/2] bpf: Add bpf_bprm_opts_set helper

2020-11-17 Thread patchwork-bot+netdevbpf
Hello: This series was applied to bpf/bpf-next.git (refs/heads/master): On Tue, 17 Nov 2020 23:29:28 + you wrote: > From: KP Singh > > The helper allows modification of certain bits on the linux_binprm > struct starting with the secureexec bit which can be updated using the >

Re: [LINUX PATCH V3 7/9] gpio: gpio-xilinx: Add support for suspend and resume

2020-11-17 Thread Linus Walleij
Hi Srinivas, On Thu, Nov 12, 2020 at 6:13 PM Srinivas Neeli wrote: > Add support for suspend and resume, pm runtime suspend and resume. > Added free and request calls. > > Signed-off-by: Srinivas Neeli > --- > Changes in V3: > -Created new patch for suspend and resume. (...) I'm following

Re: [PATCH v7 1/8] block: ensure bios are not split in middle of crypto data unit

2020-11-17 Thread Satya Tangirala
On Tue, Nov 17, 2020 at 03:31:23PM -0800, Eric Biggers wrote: > On Tue, Nov 17, 2020 at 02:07:01PM +, Satya Tangirala wrote: > > Introduce blk_crypto_bio_sectors_alignment() that returns the required > > alignment for the number of sectors in a bio. Any bio split must ensure > > that the

Re: [PATCH 4/6] ibmvfc: add FC payload retrieval routines for versioned vfcFrames

2020-11-17 Thread Tyrel Datwyler
On 11/17/20 2:14 PM, Brian King wrote: > On 11/11/20 7:04 PM, Tyrel Datwyler wrote: >> The FC iu and response payloads are located at different offsets >> depending on the ibmvfc_cmd version. This is a result of the version 2 >> vfcFrame definition adding an extra 64bytes of reserved space to the

Re: [PATCH] input: mouse: elan_i2c_core: Move header inclusion inside

2020-11-17 Thread Dmitry Torokhov
On Thu, Nov 12, 2020 at 10:44:20AM +, Lee Jones wrote: > The same clause as its use. > > Fixes the following W=1 kernel build warning(s): > > include/linux/input/elan-i2c-ids.h:26:36: warning: ‘elan_acpi_id’ defined > but not used [-Wunused-const-variable=] > > Cc: Dmitry Torokhov > Cc:

Re: [PATCH net-next v3] net/tun: Call netdev notifiers

2020-11-17 Thread Jakub Kicinski
On Mon, 16 Nov 2020 11:41:21 +0100 Martin Schiller wrote: > Call netdev notifiers before and after changing the device type. > > Signed-off-by: Martin Schiller > --- > > Change from v2: > use subject_prefix 'net-next' to fix 'fixes_present' issue > > Change from v1: > fix 'subject_prefix' and

Re: [PATCH] Input: ads7846 - fix unaligned access on 7845

2020-11-17 Thread Dmitry Torokhov
On Thu, Nov 12, 2020 at 09:04:23AM +0100, Oleksij Rempel wrote: > Hello Dmitry, > > Am 12.11.20 um 02:27 schrieb Dmitry Torokhov: > > req->sample[1] is not naturally aligned at word boundary, and therefore > > we should use get_unaligned_be16() when accessing it. > > > > Fixes: 3eac5c7e44f3

Re: [PATCH v1] Input: touchscreen: ads7846.c: fix integer overflow on Rt calculation

2020-11-17 Thread Dmitry Torokhov
On Fri, Nov 13, 2020 at 12:22:40PM +0100, Oleksij Rempel wrote: > In some rare cases the 32 bit Rt value will overflow if z2 and x is max, > z1 is minimal value and x_plate_ohms is relatively high (for example 800 > ohm). This would happen on some screen age with low pressure. > > There are two

Re: [PATCH v2 1/2] Input: ads7846: convert to full duplex

2020-11-17 Thread Dmitry Torokhov
On Tue, Nov 10, 2020 at 09:50:40AM +0100, Oleksij Rempel wrote: > Starting with following patch, the ads7845 was partially converted to > full duplex mode: > 3eac5c7e44f3 Input: ads7846 - extend the driver for ads7845 controller support > > Since it is not touchscreen controller specific, it is

Re: [PATCH v2 2/2] Input: ads7846: convert to one message

2020-11-17 Thread Dmitry Torokhov
On Tue, Nov 10, 2020 at 09:50:41AM +0100, Oleksij Rempel wrote: > Convert multiple full duplex transfers in to a single transfer to reduce > CPU load. > > Current driver version support following filtering modes: > - ads7846_no_filter() - not filtered > - ads7846_debounce_filter() - driver

Re: [PATCH v2] Input: touchscreen: ads7846.c: Fix race that causes missing releases

2020-11-17 Thread Dmitry Torokhov
On Thu, Nov 12, 2020 at 12:48:51PM +0100, Oleksij Rempel wrote: > On Wed, Nov 11, 2020 at 11:07:40AM -0800, Dmitry Torokhov wrote: > > Hi Oleksij, > > > > On Tue, Oct 27, 2020 at 11:54:16AM +0100, Oleksij Rempel wrote: > > > From: David Jander > > > > > > If touchscreen is released while busy

Re: [PATCH 13/24] x86/resctrl: Allow different CODE/DATA configurations to be staged

2020-11-17 Thread Reinette Chatre
Hi James, On 10/30/2020 9:11 AM, James Morse wrote: Now that the configuration is staged via an array, allow resctrl to stage more than configuration at a time for a single resource and s/more than/more than one/ ? closid. To detect that the same schema is being specified twice when the

Re: [PATCH 1/9] platform/surface: Add Surface Aggregator subsystem

2020-11-17 Thread Barnabás Pőcze
Hi I have attached some thoughts and comments inline. 2020. november 15., vasárnap 20:21 keltezéssel, Maximilian Luz írta: > [...] > +/* -- Event notifier/callbacks. > - */ > +/* > + * The notifier system is based on linux/notifier.h, specifically

Re: [PATCH 3/6] ibmvfc: add new fields for version 2 of several MADs

2020-11-17 Thread Tyrel Datwyler
On 11/17/20 2:06 PM, Brian King wrote: > On 11/11/20 7:04 PM, Tyrel Datwyler wrote: >> @@ -211,7 +214,9 @@ struct ibmvfc_npiv_login_resp { >> __be64 capabilities; >> #define IBMVFC_CAN_FLUSH_ON_HALT0x08 >> #define IBMVFC_CAN_SUPPRESS_ABTS0x10 >> -#define IBMVFC_CAN_SUPPORT_CHANNELS

[PATCH 1/3] rtc: pcf8523: switch to devm_rtc_allocate_device

2020-11-17 Thread Alexandre Belloni
Switch to devm_rtc_allocate_device/devm_rtc_register_device, this allows for further improvement of the driver. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-pcf8523.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/rtc/rtc-pcf8523.c

[PATCH 2/3] rtc: pcf8523: set range

2020-11-17 Thread Alexandre Belloni
Set the th RTC range, it is a classic BCD RTC, considering 00 as a leap year. Let the core handle range checking. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-pcf8523.c | 13 ++--- 1 file changed, 2 insertions(+), 11 deletions(-) diff --git a/drivers/rtc/rtc-pcf8523.c

[PATCH 3/3] rtc: pcf8523: use BIT

2020-11-17 Thread Alexandre Belloni
Use the BIT macro to define register bits. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-pcf8523.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/rtc/rtc-pcf8523.c b/drivers/rtc/rtc-pcf8523.c index d5f913cb2ec9..5e1e7b2a8c9a 100644 ---

Re: [PATCH v2 1/3] powerpc: boot: include compiler_attributes.h

2020-11-17 Thread Miguel Ojeda
On Wed, Nov 18, 2020 at 1:08 AM Nick Desaulniers wrote: > > It was also noted in 6a9dc5fd6170 that we could -D__KERNEL__ and > -include compiler_types.h like the main kernel does, though testing that > produces a whole sea of warnings to cleanup. (Re; for Gustavo to consider since he took it

[PATCH] NFS: Retry the CLOSE if the embedded GETATTR is rejected with ERR_STALE

2020-11-17 Thread Anchal Agarwal
If our CLOSE RPC call is rejected with an ERR_STALE error, then we should remove the GETATTR call from the compound RPC and retry. This could happen in a scenario where two clients tries to access the same file. One client opens the file and the other client removes the file while it's opened by

Re: [RFC] Add kernel-doc test script

2020-11-17 Thread Randy Dunlap
On 11/17/20 2:36 PM, Eduardo Habkost wrote: > Add a kernel-doc test script to tools/testing/kernel-doc. > > radix_tree_lookup_slot test case provided by Matthew Wilcox. > > Signed-off-by: Eduardo Habkost Very good idea. I have had a kernel-doc test source file for (?) 10-12 years, while I was

RE: [PATCH] video: hyperv_fb: Fix the cache type when mapping the VRAM

2020-11-17 Thread Michael Kelley
From: Dexuan Cui Sent: Tuesday, November 17, 2020 4:03 PM > > x86 Hyper-V used to essentially always overwrite the effective cache type > of guest memory accesses to WB. This was problematic in cases where there > is a physical device assigned to the VM, since that often requires that > the VM

Re: [PATCH net] inet_diag: Fix error path to cancel the meseage in inet_req_diag_fill()

2020-11-17 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Mon, 16 Nov 2020 16:20:18 +0800 you wrote: > nlmsg_cancel() needs to be called in the error path of > inet_req_diag_fill to cancel the message. > > Fixes: d545caca827b ("net: inet: diag: expose the socket mark to privileged

Re: [LINUX PATCH V3 6/9] gpio: gpio-xilinx: Add remove function

2020-11-17 Thread Linus Walleij
On Thu, Nov 12, 2020 at 6:13 PM Srinivas Neeli wrote: > Added remove function support. > > Signed-off-by: Srinivas Neeli > --- > Changes in V3: > -Created new patch for remove function. Patch applied despite not applying 4 or 5: this needs to go in with the clock support. Yours, Linus Walleij

Re: [PATCH v5 6/6] fpga: m10bmc-sec: add max10 get_hw_errinfo callback func

2020-11-17 Thread Russ Weight
On 11/15/20 6:20 AM, Tom Rix wrote: > On 11/13/20 4:55 PM, Russ Weight wrote: >> Extend the MAX10 BMC Secure Update driver to include >> a function that returns 64 bits of additional HW specific >> data for errors that require additional information. >> This callback function enables the

Re: [LINUX PATCH V3 5/9] gpio: gpio-xilinx: Add interrupt support

2020-11-17 Thread Linus Walleij
Hi Srinivas! On Thu, Nov 12, 2020 at 6:12 PM Srinivas Neeli wrote: > Adds interrupt support to the Xilinx GPIO driver so that rising and > falling edge line events can be supported. Since interrupt support is > an optional feature in the Xilinx IP, the driver continues to support > devices

Re: [PATCH v5 5/6] fpga: m10bmc-sec: add max10 secure update functions

2020-11-17 Thread Russ Weight
On 11/15/20 6:17 AM, Tom Rix wrote: > On 11/13/20 4:55 PM, Russ Weight wrote: >> Extend the MAX10 BMC Secure Update driver to include >> the functions that enable secure updates of BMC images, >> FPGA images, etc. >> >> Signed-off-by: Russ Weight >> --- >> v5: >> - No change >> v4: >> - No

[PATCH v2 1/3] powerpc: boot: include compiler_attributes.h

2020-11-17 Thread Nick Desaulniers
The kernel uses `-include` to include include/linux/compiler_types.h into all translation units (see scripts/Makefile.lib), which #includes compiler_attributes.h. arch/powerpc/boot/ uses different compiler flags from the rest of the kernel. As such, it doesn't contain the definitions from these

[PATCH v2 3/3] powerpc: fix -Wimplicit-fallthrough

2020-11-17 Thread Nick Desaulniers
The "fallthrough" pseudo-keyword was added as a portable way to denote intentional fallthrough. Clang will still warn on cases where there is a fallthrough to an immediate break. Add explicit breaks for those cases. Signed-off-by: Nick Desaulniers Tested-by: Nathan Chancellor Reviewed-by:

[PATCH v2 2/3] Revert "lib: Revert use of fallthrough pseudo-keyword in lib/"

2020-11-17 Thread Nick Desaulniers
This reverts commit 6a9dc5fd6170 ("lib: Revert use of fallthrough pseudo-keyword in lib/") Now that we can build arch/powerpc/boot/ free of -Wimplicit-fallthrough, re-enable these fixes for lib/. Reformats HUF_compress1X_usingCTable() in lib/zstd/huf_compress.c to avoid a smatch warning on

[PATCH v2 0/3] PPC: Fix -Wimplicit-fallthrough for clang

2020-11-17 Thread Nick Desaulniers
While cleaning up the last few -Wimplicit-fallthrough warnings in tree for Clang, I noticed commit 6a9dc5fd6170d ("lib: Revert use of fallthrough pseudo-keyword in lib/") which seemed to undo a bunch of fixes in lib/ due to breakage in arch/powerpc/boot/ not including compiler_types.h. We don't

Re: [PATCH v5 8/8] rpmsg: Turn name service into a stand alone driver

2020-11-17 Thread Mathieu Poirier
On Tue, Nov 17, 2020 at 05:44:05PM +0100, Arnaud POULIQUEN wrote: > > > On 11/17/20 5:03 PM, Guennadi Liakhovetski wrote: > > On Tue, Nov 17, 2020 at 12:42:30PM +0100, Arnaud POULIQUEN wrote: > > > > [snip] > > > >> diff --git a/drivers/rpmsg/rpmsg_ns.c b/drivers/rpmsg/rpmsg_ns.c > >> index

Re: [PATCH bpf-next v6 06/34] bpf: prepare for memcg-based memory accounting for bpf maps

2020-11-17 Thread Daniel Borkmann
On 11/17/20 4:40 AM, Roman Gushchin wrote: In the absolute majority of cases if a process is making a kernel allocation, it's memory cgroup is getting charged. Bpf maps can be updated from an interrupt context and in such case there is no process which can be charged. It makes the memory

sound/pci/hda/patch_ca0132.c:8214:10: warning: no case matching constant switch condition '0'

2020-11-17 Thread kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 9c87c9f41245baa3fc4716cf39141439cf405b01 commit: bf2aa9ccc8e598d788132ded9c7e94c6af3a9d1e ALSA: hda/ca0132 - Cleanup ca0132_mmio_init function. date: 3 months ago config: arm64-randconfig-r005-20201117

[PATCH] video: hyperv_fb: Fix the cache type when mapping the VRAM

2020-11-17 Thread Dexuan Cui
x86 Hyper-V used to essentially always overwrite the effective cache type of guest memory accesses to WB. This was problematic in cases where there is a physical device assigned to the VM, since that often requires that the VM should have control over cache types. Thus, on newer Hyper-V since

Re: [LINUX PATCH V3 4/9] gpio: gpio-xilinx: Reduce spinlock array to single

2020-11-17 Thread Linus Walleij
On Thu, Nov 12, 2020 at 6:12 PM Srinivas Neeli wrote: > Changed spinlock array to single. It is preparation for irq support which > is shared between two channels that's why spinlock should be only one. > > Signed-off-by: Srinivas Neeli This patch does not apply to my "devel" tree. Yours,

Re: [LINUX PATCH V3 3/9] gpio: gpio-xilinx: Add clock support

2020-11-17 Thread Linus Walleij
On Wed, Nov 18, 2020 at 12:53 AM Linus Walleij wrote: > On Thu, Nov 12, 2020 at 6:13 PM Srinivas Neeli > wrote: > > > Adds clock support to the Xilinx GPIO driver. > > > > Signed-off-by: Srinivas Neeli > > (...) > > + chip->clk = devm_clk_get_optional(>dev, NULL); > > + if

Re: [LINUX PATCH V3 1/9] gpio: gpio-xilinx: Arrange headers in sorting order

2020-11-17 Thread Linus Walleij
On Thu, Nov 12, 2020 at 6:12 PM Srinivas Neeli wrote: > Arrange header files in sorted order. > > Signed-off-by: Srinivas Neeli > --- > Changes in V3: > -Created new patch for sorting header files. Patch applied. Yours, Linus Walleij

Re: [LINUX PATCH V3 2/9] dt-bindings: gpio: gpio-xilinx: Add clk support to xilinx soft gpio IP

2020-11-17 Thread Linus Walleij
On Thu, Nov 12, 2020 at 6:12 PM Srinivas Neeli wrote: > Specify clock property in binding. > > Signed-off-by: Srinivas Neeli Patch applied, consider rewriting this binding in YAML. Yours, Linus Walleij

Re: [RFC bpf-next 1/3] bpf: add module support to btf display helpers

2020-11-17 Thread Andrii Nakryiko
On Sun, Nov 15, 2020 at 2:53 AM Alan Maguire wrote: > > On Sat, 14 Nov 2020, Yonghong Song wrote: > > > > > > > On 11/14/20 8:04 AM, Alexei Starovoitov wrote: > > > On Fri, Nov 13, 2020 at 10:59 PM Andrii Nakryiko > > > wrote: > > >> > > >> On Fri, Nov 13, 2020 at 10:11 AM Alan Maguire > > >>

Re: [LINUX PATCH V3 3/9] gpio: gpio-xilinx: Add clock support

2020-11-17 Thread Linus Walleij
On Thu, Nov 12, 2020 at 6:13 PM Srinivas Neeli wrote: > Adds clock support to the Xilinx GPIO driver. > > Signed-off-by: Srinivas Neeli (...) > + chip->clk = devm_clk_get_optional(>dev, NULL); > + if (IS_ERR(chip->clk)) { > + if (PTR_ERR(chip->clk) != -EPROBE_DEFER) >

[PATCH v1 2/3] Documentation: Update the new SIGBUS behaviour for tasks

2020-11-17 Thread Balbir Singh
Update the documentation to mention that a SIGBUS will be sent to tasks that opt-into L1D flushing and execute on non-SMT cores. Signed-off-by: Balbir Singh --- To be applied on top of tip commit id 767d46ab566dd489733666efe48732d523c8c332 Documentation/admin-guide/hw-vuln/l1d_flush.rst | 8

Re: [PATCH v7 2/8] blk-crypto: don't require user buffer alignment

2020-11-17 Thread Eric Biggers
On Tue, Nov 17, 2020 at 02:07:02PM +, Satya Tangirala wrote: > Previously, blk-crypto-fallback required the offset and length of each bvec > in a bio to be aligned to the crypto data unit size. This patch enables > blk-crypto-fallback to work even if that's not the case - the requirement > now

[PATCH v1 3/3] Documentation/l1d_flush: Fix up warning with labels

2020-11-17 Thread Balbir Singh
Add a label to spec_set_ctrl to remove the build warning. Signed-off-by: Balbir Singh --- To be applied on top of tip commit id 767d46ab566dd489733666efe48732d523c8c332 Documentation/admin-guide/hw-vuln/l1d_flush.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH v1 1/3] x86/mm: change l1d flush runtime prctl behaviour

2020-11-17 Thread Balbir Singh
Detection of task affinities at API opt-in time is not the best approach, the approach is to kill the task if it runs on a SMT enable core. This is better than not flushing the L1D cache when the task switches from a non-SMT core to an SMT enabled core. Signed-off-by: Balbir Singh --- To be

[PATCH v1 0/3] Fixes to L1D flushing (on top of linux-next and

2020-11-17 Thread Balbir Singh
There were concerns with the current interface (checking for the state of SMT of the core at opt-in time [1]). These patches change the interface to send a SIGBUS to the task if a. It opts into L1D flushing b. Runs on a core with SMT enabled There are also documentation fixes. I've tested the

Re: [PATCH 2/3] Revert "lib: Revert use of fallthrough pseudo-keyword in lib/"

2020-11-17 Thread Michael Ellerman
"Gustavo A. R. Silva" writes: > On Tue, Nov 17, 2020 at 11:10:26AM -0800, Nick Desaulniers wrote: >> On Mon, Nov 16, 2020 at 7:02 PM Nathan Chancellor >> wrote: >> > >> > On Sun, Nov 15, 2020 at 08:35:31PM -0800, Nick Desaulniers wrote: >> > > This reverts commit 6a9dc5fd6170 ("lib: Revert use

Re: [PATCH v5 3/6] fpga: m10bmc-sec: expose max10 flash update count

2020-11-17 Thread Russ Weight
On 11/15/20 12:03 PM, Moritz Fischer wrote: > On Fri, Nov 13, 2020 at 04:55:56PM -0800, Russ Weight wrote: >> Extend the MAX10 BMC Secure Update driver to provide a >> sysfs file to expose the flash update count for the FPGA >> user image. >> >> Signed-off-by: Russ Weight >> Reviewed-by: Tom

Re: [PATCH 12/24] x86/resctrl: Add closid to the staged config

2020-11-17 Thread Reinette Chatre
Hi James, On 10/30/2020 9:11 AM, James Morse wrote: Once the L2/L2CODE/L2DATA resources are merged, there may be two configurations staged for one resource when CDP is enabled. The closid should always be passed with the type of configuration to the arch code. Because update_domains() will

Re: [PATCH 3/3] powerpc: fix -Wimplicit-fallthrough

2020-11-17 Thread Michael Ellerman
Nick Desaulniers writes: > The "fallthrough" pseudo-keyword was added as a portable way to denote > intentional fallthrough. Clang will still warn on cases where there is a > fallthrough to an immediate break. Add explicit breaks for those cases. > > Link:

Re: [PATCH 1/3] powerpc: boot: include compiler_attributes.h

2020-11-17 Thread Michael Ellerman
Nick Desaulniers writes: > The kernel uses `-include` to include include/linux/compiler_types.h > into all translation units (see scripts/Makefile.lib), which #includes > compiler_attributes.h. > > arch/powerpc/boot/ uses different compiler flags from the rest of the > kernel. As such, it doesn't

Re: [PATCH 2/3] Revert "lib: Revert use of fallthrough pseudo-keyword in lib/"

2020-11-17 Thread Gustavo A. R. Silva
On Tue, Nov 17, 2020 at 02:28:43PM -0800, Nick Desaulniers wrote: > On Tue, Nov 17, 2020 at 2:16 PM Gustavo A. R. Silva > wrote: > > > > I'm happy to take this series in my tree. I'm planing to send a > > pull-request for -rc5 with more related changes. So, I can include > > this in the same PR.

Re: [PATCH v4 00/16] Overhaul multi-page lookups for THP

2020-11-17 Thread Matthew Wilcox
On Tue, Nov 17, 2020 at 07:15:13PM +, Matthew Wilcox wrote: > I find both of these functions exceptionally confusing. Does this > make it easier to understand? Never mind, this is buggy. I'll send something better tomorrow.

Re: [PATCH v5] perf_event_open.2: Update man page with recent changes

2020-11-17 Thread Alejandro Colomar (man-pages)
On 11/17/20 8:37 AM, Namhyung Kim wrote: > From: Namhyung Kim > > There are lots of changes as usual. I've tried to fill some missing > bits in the man page but it'd be nice if you could take a look and put > more info there. > > Signed-off-by: Namhyung Kim > [alx: ffix + tfix] >

Re: [PATCH v5 2/6] fpga: m10bmc-sec: create max10 bmc secure update driver

2020-11-17 Thread Russ Weight
On 11/15/20 5:44 AM, Tom Rix wrote: > On 11/13/20 4:55 PM, Russ Weight wrote: >> Create a platform driver that can be invoked as a sub >> driver for the Intel MAX10 BMC in order to support >> secure updates. This sub-driver will invoke an >> instance of the FPGA Security Manager class driver >>

Re: [RESEND][PATCH] ima: Set and clear FMODE_CAN_READ in ima_calc_file_hash()

2020-11-17 Thread Linus Torvalds
On Tue, Nov 17, 2020 at 3:29 PM Linus Torvalds wrote: > > On Tue, Nov 17, 2020 at 3:24 PM Mimi Zohar wrote: > > > > I really wish it wasn't needed. > > Seriously, I get the feeling that IMA is completely mis-designed, and > is doing actively bad things. > > Who uses this "feature", and who

Re: [PATCH bpf-next v3 1/2] bpf: Add bpf_lsm_set_bprm_opts helper

2020-11-17 Thread KP Singh
On Tue, Nov 17, 2020 at 11:41 PM Daniel Borkmann wrote: > > On 11/17/20 3:13 AM, KP Singh wrote: > > From: KP Singh > > > > The helper allows modification of certain bits on the linux_binprm > > struct starting with the secureexec bit which can be updated using the > > BPF_LSM_F_BPRM_SECUREEXEC

Re: [PATCH 06/24] perf tools: Add build_id__is_defined function

2020-11-17 Thread Arnaldo Carvalho de Melo
Em Tue, Nov 17, 2020 at 09:53:59PM +0100, Jiri Olsa escreveu: > On Tue, Nov 17, 2020 at 11:00:37AM -0800, Ian Rogers wrote: > > On Tue, Nov 17, 2020 at 3:01 AM Jiri Olsa wrote: > > > > > Adding build_id__is_defined helper to check build id > > > is defined and is != zero build id. > > > > > >

<    1   2   3   4   5   6   7   8   9   10   >