Re: crypto: sun4i-ss: error with kmap

2020-12-02 Thread Corentin Labbe
On Tue, Dec 01, 2020 at 04:15:08PM +0100, Thomas Gleixner wrote: > On Tue, Dec 01 2020 at 15:45, Corentin Labbe wrote: > > On Tue, Dec 01, 2020 at 03:16:36PM +0100, Thomas Gleixner wrote: > > In fact the warn was a bit later so I added: > >preempt_disable(); > > idx = arch_kmap_loca

Re: [PATCH v3 00/17] Introducing Linux root partition support for Microsoft Hypervisor

2020-12-02 Thread Enrico Weigelt, metux IT consult
On 24.11.20 18:07, Wei Liu wrote: Hi, > There will be a subsequent patch series to provide a > device node (/dev/mshv) such that userspace programs can create and run > virtual > machines. Any chance of using the already existing /dev/kvm interface ? --mtx -- --- Hinweis: unverschlüsselte E

RE: [PATCH] iommu/hyper-v: Fix panic on a host without the 15-bit APIC ID support

2020-12-02 Thread Dexuan Cui
> From: Thomas Gleixner > Sent: Wednesday, December 2, 2020 1:56 AM > > On Tue, Dec 01 2020 at 16:45, Dexuan Cui wrote: > > The commit f36a74b9345a itself is good, but it causes a panic in a > > Linux VM that runs on a Hyper-V host that doesn't have the 15-bit > > Extended APIC ID support: > >

Re: [PATCH 09/17] ath: regd: Provide description for ath_reg_apply_ir_flags's 'reg' param

2020-12-02 Thread Kalle Valo
Lee Jones wrote: > Fixes the following W=1 kernel build warning(s): > > drivers/net/wireless/ath/regd.c:378: warning: Function parameter or member > 'reg' not described in 'ath_reg_apply_ir_flags' > > Cc: Kalle Valo > Cc: "David S. Miller" > Cc: Jakub Kicinski > Cc: linux-wirel...@vger.ker

Re: [PATCH v2] arm64: defconfig: Enable REGULATOR_PF8X00

2020-12-02 Thread Jagan Teki
On Thu, Dec 3, 2020 at 1:18 AM Krzysztof Kozlowski wrote: > > On Thu, Dec 03, 2020 at 01:11:49AM +0530, Jagan Teki wrote: > > Enable PF8X00 regulator driver by default as it used in some of > > i.MX8MM hardware platforms like Engicam i.Core MX8M Mini SoM. > > > > Cc: Catalin Marinas > > Cc: Will

Re: [PATCH 1/2] ASoC: fsl-asoc-card: Add support for si476x codec

2020-12-02 Thread Nicolin Chen
On Mon, Nov 30, 2020 at 11:57:47AM +0800, Shengjiu Wang wrote: > The si476x codec is used for FM radio function on i.MX6 > auto board, it only supports recording function. > > Signed-off-by: Shengjiu Wang Acked-by: Nicolin Chen

Re: [PATCH v2] arm64: defconfig: Enable REGULATOR_PF8X00

2020-12-02 Thread Krzysztof Kozlowski
On Thu, Dec 03, 2020 at 01:11:49AM +0530, Jagan Teki wrote: > Enable PF8X00 regulator driver by default as it used in some of > i.MX8MM hardware platforms like Engicam i.Core MX8M Mini SoM. > > Cc: Catalin Marinas > Cc: Will Deacon > Signed-off-by: Jagan Teki You will have to send v2 of entir

Re: [RFC 1/2] perf core: Add PERF_COUNT_SW_CGROUP_SWITCHES event

2020-12-02 Thread Stephane Eranian
On Wed, Dec 2, 2020 at 11:28 AM Andi Kleen wrote: > > > + prev_cgrp = task_css_check(prev, perf_event_cgrp_id, 1)->cgroup; > > + next_cgrp = task_css_check(next, perf_event_cgrp_id, 1)->cgroup; > > + > > + if (prev_cgrp != next_cgrp) > > + perf_sw_event_sched(PERF_COUNT_SW_

Re: [PATCH] blk-throttle: don't check whether or not lower limit is valid if CONFIG_BLK_DEV_THROTTLING_LOW is off

2020-12-02 Thread Jens Axboe
On 11/25/20 8:18 PM, Yu Kuai wrote: > blk_throtl_update_limit_valid() will search for descendants to see if > 'LIMIT_LOW' of bps/iops and READ/WRITE is nonzero. However, they're always > zero if CONFIG_BLK_DEV_THROTTLING_LOW is not set, furthermore, a lot of > time will be wasted to iterate descend

Re: [PATCH] arch/riscv: enable XIP

2020-12-02 Thread Vitaly Wool
On Wed, Dec 2, 2020 at 7:06 PM Nicolas Pitre wrote: > > On Wed, 2 Dec 2020, Vitaly Wool wrote: > > > Introduce XIP (eXecute In Place) support for RISC-V platforms. > > It allows code to be executed directly from non-volatile storage > > directly addressable by the CPU, such as QSPI NOR flash which

[PROBLEM] drivers:hid 2 memory leaks suspected

2020-12-02 Thread Jeffrin Jose T
hello, 2 new suspected memory leaks. $sudo cat /sys/kernel/debug/kmemleak [sudo] password for jeffrin: unreferenced object 0x88813128bee0 (size 16): comm "irq/109-ELAN130", pid 152, jiffies 4294931163 (age 9576.624s) hex dump (first 16 bytes): 04 03 08 0a eb 03 24 e7 01 80 13 44 00 00 00 0

Re: [PATCH v2 3/4] membarrier: Explicitly sync remote cores when SYNC_CORE is requested

2020-12-02 Thread Mathieu Desnoyers
- On Dec 2, 2020, at 10:35 AM, Andy Lutomirski l...@kernel.org wrote: > membarrier() does not explicitly sync_core() remote CPUs; instead, it > relies on the assumption that an IPI will result in a core sync. On > x86, I think this may be true in practice, but it's not architecturally > relia

[PATCH v2] arm64: defconfig: Enable REGULATOR_PF8X00

2020-12-02 Thread Jagan Teki
Enable PF8X00 regulator driver by default as it used in some of i.MX8MM hardware platforms like Engicam i.Core MX8M Mini SoM. Cc: Catalin Marinas Cc: Will Deacon Signed-off-by: Jagan Teki --- Changes for v2: - update the commit message. arch/arm64/configs/defconfig | 1 + 1 file changed, 1 i

Re: [PATCH net v2] bonding: fix feature flag setting at init time

2020-12-02 Thread Jarod Wilson
On Wed, Dec 2, 2020 at 2:23 PM Jakub Kicinski wrote: > > On Wed, 2 Dec 2020 14:03:53 -0500 Jarod Wilson wrote: > > On Wed, Dec 2, 2020 at 12:53 PM Jakub Kicinski wrote: > > > > > > On Wed, 2 Dec 2020 12:30:53 -0500 Jarod Wilson wrote: > > > > + if (bond->dev->reg_state != NETREG_REGISTERED)

Re: [PATCH v2 2/4] membarrier: Add an actual barrier before rseq_preempt()

2020-12-02 Thread Mathieu Desnoyers
- On Dec 2, 2020, at 10:35 AM, Andy Lutomirski l...@kernel.org wrote: > It seems to me that most RSEQ membarrier users will expect any > stores done before the membarrier() syscall to be visible to the > target task(s). While this is extremely likely to be true in > practice, nothing actually

Re: [PATCH 04/10] arm64: dts: imx8mm: Add Engicam i.Core MX8M Mini SOM

2020-12-02 Thread Jagan Teki
On Thu, Dec 3, 2020 at 1:07 AM Krzysztof Kozlowski wrote: > > On Thu, Dec 03, 2020 at 01:00:59AM +0530, Jagan Teki wrote: > > Hi Krzysztof, > > > > On Wed, Dec 2, 2020 at 11:04 PM Krzysztof Kozlowski wrote: > > > > > > On Wed, Dec 02, 2020 at 05:42:35PM +0530, Jagan Teki wrote: > > > > i.Core MX8

Re: [PATCH v3] x86/pci: fix the function type for check_reserved_t

2020-12-02 Thread Kees Cook
On Mon, Nov 30, 2020 at 11:39:00AM -0800, Sami Tolvanen wrote: > e820__mapped_all is passed as a callback to is_mmconf_reserved, > which expects a function of type: > > typedef bool (*check_reserved_t)(u64 start, u64 end, unsigned type); > > However, e820__mapped_all accepts enum e820_type as the

Re: [PATCH v2 4/4] membarrier: Execute SYNC_CORE on the calling thread

2020-12-02 Thread Mathieu Desnoyers
- On Dec 2, 2020, at 10:35 AM, Andy Lutomirski l...@kernel.org wrote: > membarrier()'s MEMBARRIER_CMD_PRIVATE_EXPEDITED_SYNC_CORE is documented > as syncing the core on all sibling threads but not necessarily the > calling thread. This behavior is fundamentally buggy and cannot be used > safe

Re: wl1251: remove trailing semicolon in macro definition

2020-12-02 Thread Kalle Valo
t...@redhat.com wrote: > From: Tom Rix > > The macro use will already have a semicolon. > > Signed-off-by: Tom Rix Patch applied to wireless-drivers-next.git, thanks. fc6877b87982 wl1251: remove trailing semicolon in macro definition -- https://patchwork.kernel.org/project/linux-wireless/p

Re: airo: remove trailing semicolon in macro definition

2020-12-02 Thread Kalle Valo
t...@redhat.com wrote: > From: Tom Rix > > The macro use will already have a semicolon. > > Signed-off-by: Tom Rix > Reviewed-by: Kieran Bingham Patch applied to wireless-drivers-next.git, thanks. a460b0e1bab8 airo: remove trailing semicolon in macro definition -- https://patchwork.kernel

Re: [PATCH v3] brcmfmac: expose firmware config files through modinfo

2020-12-02 Thread Kalle Valo
matthias@kernel.org wrote: > From: Matthias Brugger > > Apart from a firmware binary the chip needs a config file used by the > FW. Add the config files to modinfo so that they can be read by > userspace. > > Signed-off-by: Matthias Brugger > Reviewed-by: Hans de Goede Patch applied to w

Re: [PATCH 04/10] arm64: dts: imx8mm: Add Engicam i.Core MX8M Mini SOM

2020-12-02 Thread Krzysztof Kozlowski
On Thu, Dec 03, 2020 at 01:00:59AM +0530, Jagan Teki wrote: > Hi Krzysztof, > > On Wed, Dec 2, 2020 at 11:04 PM Krzysztof Kozlowski wrote: > > > > On Wed, Dec 02, 2020 at 05:42:35PM +0530, Jagan Teki wrote: > > > i.Core MX8M Mini is an EDIMM SOM based on NXP i.MX8MM from Engicam. > > > > s/SOM/So

Re: [PATCH 08/10] arm64: dts: imx8mm: Add Engicam i.Core MX8M Mini C.TOUCH 2.0

2020-12-02 Thread Jagan Teki
On Thu, Dec 3, 2020 at 12:55 AM Krzysztof Kozlowski wrote: > > On Thu, Dec 03, 2020 at 12:50:37AM +0530, Jagan Teki wrote: > > Hi Krzysztof, > > > > On Wed, Dec 2, 2020 at 11:15 PM Krzysztof Kozlowski wrote: > > > > > > On Wed, Dec 02, 2020 at 05:42:39PM +0530, Jagan Teki wrote: > > > > i.Core MX

Re: [PATCH] scsi: iscsi: fix inappropriate use of put_device

2020-12-02 Thread Mike Christie
On 11/20/20 1:48 AM, Qinglang Miao wrote: > kfree(conn) is called inside put_device(&conn->dev) so that > another one would cause use-after-free. Besides, device_unregister > should be used here rather than put_device. > > Fixes: f3c893e3dbb5 ("scsi: iscsi: Fail session and connection on transport

Re: [PATCH 2/5] s390/vtime: Use the generic IRQ entry accounting

2020-12-02 Thread Christian Borntraeger
On 02.12.20 12:57, Frederic Weisbecker wrote: > s390 has its own version of IRQ entry accounting because it doesn't > account the idle time the same way the other architectures do. Only > the actual idle sleep time is accounted as idle time, the rest of the > idle task execution is accounted as

Re: [PATCH v8 3/4] doc: trusted-encrypted: updates with TEE as a new trust source

2020-12-02 Thread gmail Elaine Palmer
Hi Sumit, Thank you for the detailed descriptions and examples of trust sources for Trusted Keys. A group of us in IBM (Stefan Berger, Ken Goldman, Zhongshu Gu, Nayna Jain, Elaine Palmer, George Wilson, Mimi Zohar) have been doing related work for quite some time, and we have one primary

Re: [EXT] Re: [PATCH v2 1/2] mmc: Support kmsg dumper based on pstore/blk

2020-12-02 Thread Kees Cook
On Wed, Dec 02, 2020 at 06:36:21AM +, Bhaskara Budiredla wrote: > >From: Kees Cook > >On Mon, Nov 23, 2020 at 04:49:24PM +0530, Bhaskara Budiredla wrote: > >Why isn't this just written as: > > > >config MMC_PSTORE > > bool "Log panic/oops to a MMC buffer" > > depends on MMC_BLOCK > >

Re: [PATCH v2] iio: sx9310: Fix semtech,avg-pos-strength setting when > 16

2020-12-02 Thread Stephen Boyd
Quoting Jonathan Cameron (2020-11-21 07:02:45) > On Sat, 21 Nov 2020 14:58:49 + > Jonathan Cameron wrote: > > > On Fri, 20 Nov 2020 10:29:44 -0800 > > Stephen Boyd wrote: > > > diff --git a/drivers/iio/proximity/sx9310.c > > > b/drivers/iio/proximity/sx9310.c > > > index a2f820997afc..ee1b4

Re: [PATCH 04/10] arm64: dts: imx8mm: Add Engicam i.Core MX8M Mini SOM

2020-12-02 Thread Jagan Teki
Hi Krzysztof, On Wed, Dec 2, 2020 at 11:04 PM Krzysztof Kozlowski wrote: > > On Wed, Dec 02, 2020 at 05:42:35PM +0530, Jagan Teki wrote: > > i.Core MX8M Mini is an EDIMM SOM based on NXP i.MX8MM from Engicam. > > s/SOM/SoM/ > > > > > General features: > > - NXP i.MX8MM > > i.MX 8M Mini > as named

Re: [RFC 1/2] perf core: Add PERF_COUNT_SW_CGROUP_SWITCHES event

2020-12-02 Thread Andi Kleen
> + prev_cgrp = task_css_check(prev, perf_event_cgrp_id, 1)->cgroup; > + next_cgrp = task_css_check(next, perf_event_cgrp_id, 1)->cgroup; > + > + if (prev_cgrp != next_cgrp) > + perf_sw_event_sched(PERF_COUNT_SW_CGROUP_SWITCHES, 1, 0); Seems to be the perf cgroup only, not

Re: [PATCH 1/5] sched/cputime: Remove symbol exports from IRQ time accounting

2020-12-02 Thread Christian Borntraeger
On 02.12.20 12:57, Frederic Weisbecker wrote: > account_irq_enter_time() and account_irq_exit_time() are not called > from modules. EXPORT_SYMBOL_GPL() can be safely removed from the IRQ > cputime accounting functions called from there. > > Signed-off-by: Frederic Weisbecker > Cc: Peter Zijlst

Re: [PATCH v2 2/4] mm: introduce cma_alloc_bulk API

2020-12-02 Thread Minchan Kim
On Wed, Dec 02, 2020 at 07:51:07PM +0100, Michal Hocko wrote: > On Wed 02-12-20 09:54:29, Minchan Kim wrote: > > On Wed, Dec 02, 2020 at 05:48:34PM +0100, Michal Hocko wrote: > > > On Wed 02-12-20 08:15:49, Minchan Kim wrote: > > > > On Wed, Dec 02, 2020 at 04:49:15PM +0100, Michal Hocko wrote: > >

Re: [PATCH 08/10] arm64: dts: imx8mm: Add Engicam i.Core MX8M Mini C.TOUCH 2.0

2020-12-02 Thread Krzysztof Kozlowski
On Thu, Dec 03, 2020 at 12:50:37AM +0530, Jagan Teki wrote: > Hi Krzysztof, > > On Wed, Dec 2, 2020 at 11:15 PM Krzysztof Kozlowski wrote: > > > > On Wed, Dec 02, 2020 at 05:42:39PM +0530, Jagan Teki wrote: > > > i.Core MX8M Mini is an EDIMM SOM based on NXP i.MX8MM from Engicam. > > > > > > C.TO

Re: [PATCH] scsi: qedi: fix missing destroy_workqueue() on error in __qedi_probe

2020-12-02 Thread Mike Christie
On 11/9/20 3:15 AM, Qinglang Miao wrote: > Add the missing destroy_workqueue() before return from > __qedi_probe in the error handling case when fails to > create workqueue qedi->offload_thread. > > Fixes: ace7f46ba5fd ("scsi: qedi: Add QLogic FastLinQ offload iSCSI driver > framework.") > Signed

Re: [PATCH] pstore: Tidy up an error check

2020-12-02 Thread Kees Cook
On Wed, Dec 02, 2020 at 09:45:31AM +0300, Dan Carpenter wrote: > The crypto_alloc_comp() function never returns NULL, it returns error > pointers on error. > > Signed-off-by: Dan Carpenter I replied to an identical patch yesterday, actually: https://lore.kernel.org/lkml/202012011215.B9BF24A6D@ke

Re: [PATCH net v2] bonding: fix feature flag setting at init time

2020-12-02 Thread Jarod Wilson
On Wed, Dec 2, 2020 at 12:55 PM Jay Vosburgh wrote: > > Jarod Wilson wrote: > > >Don't try to adjust XFRM support flags if the bond device isn't yet > >registered. Bad things can currently happen when netdev_change_features() > >is called without having wanted_features fully filled in yet. Basica

[tip: irq/core] s390/vtime: Use the generic IRQ entry accounting

2020-12-02 Thread tip-bot2 for Frederic Weisbecker
The following commit has been merged into the irq/core branch of tip: Commit-ID: 2b91ec9f551b56751cde48792f1c0a1130358844 Gitweb: https://git.kernel.org/tip/2b91ec9f551b56751cde48792f1c0a1130358844 Author:Frederic Weisbecker AuthorDate:Wed, 02 Dec 2020 12:57:29 +01:00 Comm

[tip: irq/core] irqtime: Move irqtime entry accounting after irq offset incrementation

2020-12-02 Thread tip-bot2 for Frederic Weisbecker
The following commit has been merged into the irq/core branch of tip: Commit-ID: d3759e7184f8f6187e62f8c4e7dcb1f6c47c075a Gitweb: https://git.kernel.org/tip/d3759e7184f8f6187e62f8c4e7dcb1f6c47c075a Author:Frederic Weisbecker AuthorDate:Wed, 02 Dec 2020 12:57:31 +01:00 Comm

[tip: irq/core] sched/vtime: Consolidate IRQ time accounting

2020-12-02 Thread tip-bot2 for Frederic Weisbecker
The following commit has been merged into the irq/core branch of tip: Commit-ID: 8a6a5920d3286eb0eae9f36a4ec4fc9df511eccb Gitweb: https://git.kernel.org/tip/8a6a5920d3286eb0eae9f36a4ec4fc9df511eccb Author:Frederic Weisbecker AuthorDate:Wed, 02 Dec 2020 12:57:30 +01:00 Comm

[tip: irq/core] sched/cputime: Remove symbol exports from IRQ time accounting

2020-12-02 Thread tip-bot2 for Frederic Weisbecker
The following commit has been merged into the irq/core branch of tip: Commit-ID: 7197688b2006357da75a014e0a76be89ca9c2d46 Gitweb: https://git.kernel.org/tip/7197688b2006357da75a014e0a76be89ca9c2d46 Author:Frederic Weisbecker AuthorDate:Wed, 02 Dec 2020 12:57:28 +01:00 Comm

[tip: irq/core] irq: Call tick_irq_enter() inside HARDIRQ_OFFSET

2020-12-02 Thread tip-bot2 for Frederic Weisbecker
The following commit has been merged into the irq/core branch of tip: Commit-ID: d14ce74f1fb376ccbbc0b05ded477ada51253729 Gitweb: https://git.kernel.org/tip/d14ce74f1fb376ccbbc0b05ded477ada51253729 Author:Frederic Weisbecker AuthorDate:Wed, 02 Dec 2020 12:57:32 +01:00 Comm

Re: [PATCH net v2] bonding: fix feature flag setting at init time

2020-12-02 Thread Jakub Kicinski
On Wed, 2 Dec 2020 14:03:53 -0500 Jarod Wilson wrote: > On Wed, Dec 2, 2020 at 12:53 PM Jakub Kicinski wrote: > > > > On Wed, 2 Dec 2020 12:30:53 -0500 Jarod Wilson wrote: > > > + if (bond->dev->reg_state != NETREG_REGISTERED) > > > + goto noreg; > > > + > > > if (newval->

Re: [PATCH 1/2] x86: make vmware support optional

2020-12-02 Thread Borislav Petkov
On Wed, Dec 02, 2020 at 08:17:23PM +0100, Enrico Weigelt, metux IT consult wrote: > Reducing the kernel size. Think of very high density virtualization > (w/ specially stripped-down workloads) or embedded systems. > > For example, I'm running bare minimum kernels w/ only kvm and virtio > (not eve

Re: [PATCH] selftests/seccomp: Update kernel config

2020-12-02 Thread Kees Cook
On Wed, 2 Dec 2020 17:26:43 +0100, Mickaël Salaün wrote: > seccomp_bpf.c uses unshare(CLONE_NEWPID), which requires CONFIG_PID_NS > to be set. Applied to for-next/seccomp, thanks! [1/1] selftests/seccomp: Update kernel config https://git.kernel.org/kees/c/2c07343abd89 -- Kees Cook

Re: [PATCH] rtc: adapt allowed RTC update error

2020-12-02 Thread Thomas Gleixner
On Wed, Dec 02 2020 at 12:27, Jason Gunthorpe wrote: > On Wed, Dec 02, 2020 at 02:44:53PM +0100, Thomas Gleixner wrote: >> if (IS_ENABLED(CONFIG_GENERIC_CMOS_UPDATE) || >> IS_ENABLED(CONFIG_RTC_SYSTOHC)) >> -queue_delayed_work(system_power_efficient_wq, &sync_work, 0); >>

Re: [PATCH 01/10] arm64: defconfig: Enable REGULATOR_PF8X00

2020-12-02 Thread Jagan Teki
On Wed, Dec 2, 2020 at 10:52 PM Krzysztof Kozlowski wrote: > > On Wed, Dec 02, 2020 at 05:42:32PM +0530, Jagan Teki wrote: > > Enable PF8X00 regulator driver by default as it used in > > some of i.MX8MM hardware platforms. > > Could you mention names (one is enough) of platforms this could be foun

Re: [PATCH 08/10] arm64: dts: imx8mm: Add Engicam i.Core MX8M Mini C.TOUCH 2.0

2020-12-02 Thread Jagan Teki
Hi Krzysztof, On Wed, Dec 2, 2020 at 11:15 PM Krzysztof Kozlowski wrote: > > On Wed, Dec 02, 2020 at 05:42:39PM +0530, Jagan Teki wrote: > > i.Core MX8M Mini is an EDIMM SOM based on NXP i.MX8MM from Engicam. > > > > C.TOUCH 2.0 is a general purpose carrier board with capacitive > > touch interfa

Re: [PATCH 1/2] x86: make vmware support optional

2020-12-02 Thread Enrico Weigelt, metux IT consult
On 17.11.20 21:31, Borislav Petkov wrote: > On Tue, Nov 17, 2020 at 09:23:07PM +0100, Enrico Weigelt, metux IT consult > wrote: >> Make it possible to opt-out from vmware support > > Why? Reducing the kernel size. Think of very high density virtualization (w/ specially stripped-down workloads) o

Re: [PATCH v1 bpf-next 06/11] bpf: Introduce two attach types for BPF_PROG_TYPE_SK_REUSEPORT.

2020-12-02 Thread Martin KaFai Lau
On Tue, Dec 01, 2020 at 06:04:50PM -0800, Andrii Nakryiko wrote: > On Tue, Dec 1, 2020 at 6:49 AM Kuniyuki Iwashima wrote: > > > > This commit adds new bpf_attach_type for BPF_PROG_TYPE_SK_REUSEPORT to > > check if the attached eBPF program is capable of migrating sockets. > > > > When the eBPF pr

Re: [PATCH v1 3/7] spi: qspi-tegra: Add support for Tegra210 QSPI controller

2020-12-02 Thread Sowjanya Komatineni
On 12/2/20 9:27 AM, Mark Brown wrote: On Tue, Dec 01, 2020 at 01:12:44PM -0800, Sowjanya Komatineni wrote: Tegra SoC has a Quad SPI controller starting from Tegra210. This patch adds support for Tegra210 QSPI controller. This looks pretty clean but I've got a few questions below about how th

RE: [PATCH v3 2/2] fpga: dfl: look for vendor specific capability

2020-12-02 Thread matthew . gerlach
On Wed, 2 Dec 2020, Wu, Hao wrote: + } + + offset = dfl_res & PCI_VNDR_DFLS_RES_OFF_MASK; + if (offset >= len) { + dev_err(&pcidev->dev, "%s bad offset %u >= %pa\n", + __func__, offset, &len); +

Re: [RFC PATCH] checkpatch: correctly detect lines of help text

2020-12-02 Thread Joe Perches
On Wed, 2020-12-02 at 10:59 -0800, Randy Dunlap wrote: > On 12/2/20 10:54 AM, Joe Perches wrote: [] > > Indentation can vary in the help blocks. For instance: > > > > arch/Kconfig: help > > arch/Kconfig- Functions will have the stack-protector canary logic > > added in> > > arch/Kconfig-

Re: power-off delay/hang due to commit 6d25be57 (mainline)

2020-12-02 Thread Rafael J. Wysocki
On Wed, Dec 2, 2020 at 7:31 PM Rafael J. Wysocki wrote: > > On Wed, Dec 2, 2020 at 7:03 PM Sebastian Andrzej Siewior > wrote: > > > > On 2020-10-26 18:20:59 [+0100], To Rafael J. Wysocki wrote: > > > > > > > Done as Bug 208877. > > > > > Rafael, do you have any suggestions? > > > > > > > > I've l

Re: [PATCH 2/5] kunit: tool: fix unit test so it can run from non-root dir

2020-12-02 Thread Daniel Latypov
On Tue, Dec 1, 2020 at 8:41 PM David Gow wrote: > > On Wed, Dec 2, 2020 at 3:00 AM Daniel Latypov wrote: > > > > On Mon, Nov 30, 2020 at 11:33 PM David Gow wrote: > > > > > > On Tue, Dec 1, 2020 at 7:33 AM Daniel Latypov wrote: > > > > > > > > get_absolute_path() makes an attempt to allow for t

Re: [PATCH] blk-throttle: don't check whether or not lower limit is valid if CONFIG_BLK_DEV_THROTTLING_LOW is off

2020-12-02 Thread Tejun Heo
On Thu, Nov 26, 2020 at 11:18:34AM +0800, Yu Kuai wrote: > blk_throtl_update_limit_valid() will search for descendants to see if > 'LIMIT_LOW' of bps/iops and READ/WRITE is nonzero. However, they're always > zero if CONFIG_BLK_DEV_THROTTLING_LOW is not set, furthermore, a lot of > time will be wast

[PATCH v2 1/4] kunit: tool: fix unit test cleanup handling

2020-12-02 Thread Daniel Latypov
* Stop leaking file objects. * Use self.addCleanup() to ensure we call cleanup functions even if setUp() fails. * use mock.patch.stopall instead of more error-prone manual approach Signed-off-by: Daniel Latypov --- tools/testing/kunit/kunit_tool_test.py | 14 ++ 1 file changed, 6 ins

[PATCH v2 2/4] kunit: tool: stop using bare asserts in unit test

2020-12-02 Thread Daniel Latypov
Use self.assertEqual/assertNotEqual() instead. Besides being more appropriate in a unit test, it'll also give a better error message by show the unexpected values. Also * Delete redundant check of exception types. self.assertRaises does this. * s/kall/call. There's no reason to name it this way.

[PATCH v2 4/4] minor: kunit: tool: fix unit test so it can run from non-root dir

2020-12-02 Thread Daniel Latypov
Also take this time to rename get_absolute_path() to test_data_path(). 1. the name is currently a lie. It gives relative paths, e.g. if I run from the same dir as the test file, it gives './test_data/' See https://docs.python.org/3/reference/import.html#__file__, which doesn't stipulate that impl

[PATCH v2 3/4] kunit: tool: use `with open()` in unit test

2020-12-02 Thread Daniel Latypov
The use of manual open() and .close() calls seems to be an attempt to keep the contents in scope. But Python doesn't restrict variables like that, so we can introduce new variables inside of a `with` and use them outside. Do so to make the code more Pythonic. Signed-off-by: Daniel Latypov --- t

Re: [RFC PATCH] common/rc: Fix _check_s_dax() for kernel 5.10

2020-12-02 Thread Ira Weiny
On Wed, Dec 02, 2020 at 11:10:50AM -0600, Eric Sandeen wrote: > On 12/2/20 10:07 AM, ira.we...@intel.com wrote: > > From: Ira Weiny > > > > There is a conflict with the user visible statx bits 'mount root' and > > 'dax'. The kernel is shifting the dax bit.[1] > > > > Adjust _check_s_dax() to us

Re: [PATCH 1/3] x86/sev-es: Fix not using prefixes.nbytes for loop over prefixes.bytes

2020-12-02 Thread Kees Cook
On Wed, Dec 02, 2020 at 09:31:57AM -0600, Tom Lendacky wrote: > On 12/2/20 2:51 AM, Masami Hiramatsu wrote: > > Since the insn.prefixes.nbytes can be bigger than the size of > > insn.prefixes.bytes[] when a same prefix is repeated, we have to > > check whether the insn.prefixes.bytes[i] != 0 and i

RE: [PATCH v3 2/2] fpga: dfl: look for vendor specific capability

2020-12-02 Thread matthew . gerlach
On Wed, 2 Dec 2020, Wu, Hao wrote: Subject: Re: [PATCH v3 2/2] fpga: dfl: look for vendor specific capability Hi Matthew, On Mon, Nov 30, 2020 at 04:45:20PM -0800, matthew.gerl...@linux.intel.com wrote: On Sat, 28 Nov 2020, Wu, Hao wrote: Subject: [PATCH v3 2/2] fpga: dfl: look for ven

Re: [PATCH V2] uapi: fix statx attribute value overlap for DAX & MOUNT_ROOT

2020-12-02 Thread Greg Kroah-Hartman
On Wed, Dec 02, 2020 at 06:41:43PM +0100, Miklos Szeredi wrote: > On Wed, Dec 2, 2020 at 5:24 PM David Howells wrote: > > > > Miklos Szeredi wrote: > > > > > Stable cc also? > > > > > > Cc: # 5.8 > > > > That seems to be unnecessary, provided there's a Fixes: tag. > > Is it? > > Fixes: means i

Re: [PATCH net v2] bonding: fix feature flag setting at init time

2020-12-02 Thread Jarod Wilson
On Wed, Dec 2, 2020 at 12:53 PM Jakub Kicinski wrote: > > On Wed, 2 Dec 2020 12:30:53 -0500 Jarod Wilson wrote: > > + if (bond->dev->reg_state != NETREG_REGISTERED) > > + goto noreg; > > + > > if (newval->value == BOND_MODE_ACTIVEBACKUP) > > bond->dev->wanted_f

Re: [PATCH 2/3] x86/uprobes: Fix not using prefixes.nbytes for loop over prefixes.bytes

2020-12-02 Thread Kees Cook
On Wed, Dec 02, 2020 at 05:51:16PM +0900, Masami Hiramatsu wrote: > Since the insn.prefixes.nbytes can be bigger than the size of > insn.prefixes.bytes[] when a same prefix is repeated, we have to > check whether the insn.prefixes.bytes[i] != 0 and i < 4 instead > of insn.prefixes.nbytes. > > Fixe

Re: [PATCH RFC 10/39] KVM: x86/xen: support upcall vector

2020-12-02 Thread David Woodhouse
On Wed, 2020-12-02 at 18:34 +, Joao Martins wrote: > On 12/2/20 4:47 PM, David Woodhouse wrote: > > On Wed, 2020-12-02 at 13:12 +, Joao Martins wrote: > > > On 12/2/20 11:17 AM, David Woodhouse wrote: > > > > I might be more inclined to go for a model where the kernel handles the > > > > ev

Re: [PATCH] gcc-plugins: remove code for GCC versions older than 4.9

2020-12-02 Thread Kees Cook
On Wed, Dec 02, 2020 at 10:49:29PM +0900, Masahiro Yamada wrote: > Documentation/process/changes.rst says the minimal GCC version is 4.9. > Hence, BUILDING_GCC_VERSION is greater than or equal to 4009. > > Signed-off-by: Masahiro Yamada Acked-by: Kees Cook Do you want to carry this in the kbui

Re: [PATCH] mm: mmap_lock: fix use-after-free race and css ref leak in tracepoints

2020-12-02 Thread Tejun Heo
Hello, On Tue, Dec 01, 2020 at 12:53:46PM -0800, Shakeel Butt wrote: > The writeback tracepoint in include/trace/events/writeback.h is > already using the cgroup IDs. Actually it used to use cgroup_path but > converted to cgroup_ino. > > Tejun, how do you use these tracepoints? There've been som

Re: [PATCH 03/22] keembay-ipc: Add Keem Bay IPC module

2020-12-02 Thread Greg KH
On Wed, Dec 02, 2020 at 09:42:00AM -0800, mark gross wrote: > On Wed, Dec 02, 2020 at 07:16:20AM +0100, Greg KH wrote: > > On Tue, Dec 01, 2020 at 02:34:52PM -0800, mgr...@linux.intel.com wrote: > > > --- a/MAINTAINERS > > > +++ b/MAINTAINERS > > > @@ -8955,6 +8955,14 @@ M: Deepak Saxena > > > S:

Re: [RFC PATCH] checkpatch: correctly detect lines of help text

2020-12-02 Thread Randy Dunlap
On 12/2/20 10:54 AM, Joe Perches wrote: > On Wed, 2020-12-02 at 19:27 +0100, Nicolai Fischer wrote: >> Currently, checkpatch uses keywords to determine the end >> of a Kconfig help message which leads to false positives: >> > > I believe all the '---help---' lines have been converted to just 'hel

RE: [PATCH Xilinx Alveo 2/8] fpga: xrt: Add UAPI header files

2020-12-02 Thread Sonal Santan
Hi Moritz, > -Original Message- > From: Moritz Fischer > Sent: Monday, November 30, 2020 8:27 PM > To: Sonal Santan > Cc: linux-kernel@vger.kernel.org; linux-f...@vger.kernel.org; Max Zhen > ; Lizhi Hou ; Michal Simek > ; Stefano Stabellini ; > devicet...@vger.kernel.org > Subject: Re: [

Re: [GIT PULL 2/2] Kconfig updates for v5.10-rc1

2020-12-02 Thread Kees Cook
On Wed, Dec 02, 2020 at 10:03:47PM +0900, Masahiro Yamada wrote: > On Wed, Dec 2, 2020 at 9:53 PM Masahiro Yamada wrote: > > > > Hi Linus, > > > > On Sun, Nov 29, 2020 at 3:28 AM Linus Torvalds > > wrote: > > > > > > On Fri, Nov 27, 2020 at 11:05 PM Masahiro Yamada > > > wrote: > > > > > > > >

Re: [PATCH -mmots] checkpatch: add fix for non-standard signature - co-authored-by

2020-12-02 Thread Joe Perches
On Thu, 2020-12-03 at 00:00 +0530, Aditya Srivastava wrote: > Currently, checkpatch.pl warns us for BAD_SIGN_OFF on the usage of > non-standard signatures. > > An evaluation on v4.13..v5.8 showed that out of 539 warnings due to > non-standard signatures, 43 are due to the use of 'Co-authored-by' >

Re: [PATCH v2 2/2] kbuild: Disable CONFIG_LD_ORPHAN_WARN for ld.lld 10.0.1

2020-12-02 Thread Kees Cook
On Wed, Dec 02, 2020 at 11:37:38AM +0900, Masahiro Yamada wrote: > On Wed, Dec 2, 2020 at 5:56 AM Kees Cook wrote: > > > > On Tue, Dec 01, 2020 at 10:31:37PM +0900, Masahiro Yamada wrote: > > > On Wed, Nov 25, 2020 at 7:22 AM Kees Cook wrote: > > > > > > > > On Thu, Nov 19, 2020 at 01:13:27PM -08

Re: your mail

2020-12-02 Thread Andy Shevchenko
On Wed, Dec 02, 2020 at 08:51:27PM +0200, Andy Shevchenko wrote: > On Thu, Dec 03, 2020 at 03:27:33AM +0900, Yun Levi wrote: > > On Thu, Dec 3, 2020 at 2:36 AM Andy Shevchenko > > wrote: > > > On Wed, Dec 02, 2020 at 09:26:05AM -0800, Yury Norov wrote: ... > > > Side note: speaking of performanc

Re: [PATCH v6 4/4] mmc: sdhci-of-arasan: Enable UHS-1 support for Keem Bay SOC

2020-12-02 Thread Linus Walleij
Hi Muhammad, thanks for your patch! On Wed, Dec 2, 2020 at 8:04 AM wrote: > Keem Bay SOC can support dual voltage operations for GPIO SD Pins to > either 1.8V or 3.3V for bus IO line power. In order to operate the GPIOs > line for Clk,Cmd and Data on Keem Bay Hardware, it is important to > conf

Re: [RFC PATCH] checkpatch: correctly detect lines of help text

2020-12-02 Thread Joe Perches
On Wed, 2020-12-02 at 19:27 +0100, Nicolai Fischer wrote: > Currently, checkpatch uses keywords to determine the end > of a Kconfig help message which leads to false positives: > > 1) if a line of the help text starts with any of the keywords, e.g. if: > > +config FOO > + help > + help

Re: [PATCH] mm/vmalloc: randomize vmalloc() allocations

2020-12-02 Thread Matthew Wilcox
On Tue, Dec 01, 2020 at 11:45:47PM +0200, Topi Miettinen wrote: > + /* Randomize allocation */ > + if (randomize_vmalloc) { > + voffset = get_random_long() & (roundup_pow_of_two(vend - > vstart) - 1); > + voffset = PAGE_ALIGN(voffset); > + if (voffset +

Re: [PATCH -tip 26/32] sched: Add a second-level tag for nested CGroup usecase

2020-12-02 Thread Tejun Heo
Hello, On Wed, Dec 02, 2020 at 09:02:11AM +0100, Peter Zijlstra wrote: > > the user might only want subsets of {B, C, D, E} to share. For > > instance, the user might only want {B,C} and {D, E} to share. One way > > to solve this would be to allow the user to write the group cookie > > directly.

[PATCH v3 4/4] mmc: sdhci-xenon: introduce ACPI support

2020-12-02 Thread Marcin Wojtas
Previous patches dropped the strict dependency on the OF_* in the sdhci-xenon driver. As a result the ACPI support can be introduced (except for the XENON_A3700 variant) by adding the necessary ID's in the acpi_match_table. Signed-off-by: Marcin Wojtas Acked-by: Adrian Hunter --- drivers/mmc/ho

[PATCH v3 2/4] mmc: sdhci-xenon: switch to device_* API

2020-12-02 Thread Marcin Wojtas
In order to support both ACPI and DT, modify the driver to use device_* routines for obtaining the properties values. Signed-off-by: Marcin Wojtas Acked-by: Adrian Hunter --- drivers/mmc/host/sdhci-xenon.h | 4 +-- drivers/mmc/host/sdhci-xenon-phy.c | 36 +++- drivers/mmc/h

Re: [PATCH v7 00/17] Add support for Clang LTO

2020-12-02 Thread Kees Cook
On Wed, Dec 02, 2020 at 11:42:21AM +0900, Masahiro Yamada wrote: > On Wed, Dec 2, 2020 at 2:31 AM Kees Cook wrote: > > > > On Mon, Nov 30, 2020 at 12:01:31PM +, Will Deacon wrote: > > > Hi Sami, > > > > > > On Wed, Nov 18, 2020 at 02:07:14PM -0800, Sami Tolvanen wrote: > > > > This patch serie

[PATCH v3 3/4] mmc: sdhci-xenon: use clk only with DT

2020-12-02 Thread Marcin Wojtas
As a preparation for supporting ACPI, modify the driver to use the clk framework only when booting with DT - otherwise rely on the configuration done by firmware. For that purpose introduce also a custom SDHCI get_max_clock callback. Signed-off-by: Marcin Wojtas Acked-by: Adrian Hunter --- driv

[PATCH v3 0/4] sdhci-xenon ACPI support

2020-12-02 Thread Marcin Wojtas
Hi, The third version of the sdhci-xenon ACPI support addresses a comment regarding clk_disable_unprepare dependency on DT. The MacchiatoBin firmware for testing can be obtained from: https://drive.google.com/file/d/1Y8BhyaCrksQgT_GPfpqqiYHpQ41kP8Kp Changelog: v2->v3 * Call clk_disable_unprepa

[PATCH v3 1/4] mmc: sdhci-xenon: use match data for controllers variants

2020-12-02 Thread Marcin Wojtas
As a part of the ACPI support preparation resign from checking compatible strings in the driver. Instead of that use a new enum and assign the values to match data accordingly. Signed-off-by: Marcin Wojtas Acked-by: Adrian Hunter --- drivers/mmc/host/sdhci-xenon.h | 8 drivers/mmc

Re: your mail

2020-12-02 Thread Andy Shevchenko
On Thu, Dec 03, 2020 at 03:27:33AM +0900, Yun Levi wrote: > On Thu, Dec 3, 2020 at 2:36 AM Andy Shevchenko > wrote: > > On Wed, Dec 02, 2020 at 09:26:05AM -0800, Yury Norov wrote: ... > > Side note: speaking of performance, any plans to fix for_each_*_bit*() for > > cases when the nbits is known

Re: [PATCH v2 2/4] mm: introduce cma_alloc_bulk API

2020-12-02 Thread Michal Hocko
On Wed 02-12-20 09:54:29, Minchan Kim wrote: > On Wed, Dec 02, 2020 at 05:48:34PM +0100, Michal Hocko wrote: > > On Wed 02-12-20 08:15:49, Minchan Kim wrote: > > > On Wed, Dec 02, 2020 at 04:49:15PM +0100, Michal Hocko wrote: > > [...] > > > > Well, what I can see is that this new interface is an a

Re: [PATCH 01/17] wil6210: wmi: Correct misnamed function parameter 'ptr_'

2020-12-02 Thread Kalle Valo
Lee Jones wrote: > Fixes the following W=1 kernel build warning(s): > > drivers/net/wireless/ath/wil6210/wmi.c:279: warning: Function parameter or > member 'ptr_' not described in 'wmi_buffer_block' > drivers/net/wireless/ath/wil6210/wmi.c:279: warning: Excess function > parameter 'ptr' desc

Re: [RFC PATCH v2 3/4] RISC-V: Initial DTS for Microchip ICICLE board

2020-12-02 Thread Atish Patra
On Wed, 2020-12-02 at 16:20 +, daire.mcnam...@microchip.com wrote: > > > From: Atish Patra > Sent: Friday 13 November 2020 20:25 > To: linux-kernel@vger.kernel.org > Cc: Atish Patra ; Albert Ou < > a...@eecs.berkeley.edu>; Alistair Francis ; > Anup Patel ; devicet...@vger.kernel.org < > d

Re: [PATCH 03/17] ath9k: ar9330_1p1_initvals: Remove unused const variable 'ar9331_common_tx_gain_offset1_1'

2020-12-02 Thread Kalle Valo
Lee Jones wrote: > Fixes the following W=1 kernel build warning(s): > > drivers/net/wireless/ath/ath9k/ar9330_1p1_initvals.h:1013:18: warning: > ‘ar9331_common_tx_gain_offset1_1’ defined but not used > [-Wunused-const-variable=] > > Cc: QCA ath9k Development > Cc: Kalle Valo > Cc: "David S

Re: [PATCH] mm/vmalloc: randomize vmalloc() allocations

2020-12-02 Thread Topi Miettinen
On 1.12.2020 23.45, Topi Miettinen wrote: Memory mappings inside kernel allocated with vmalloc() are in predictable order and packed tightly toward the low addresses. With new kernel boot parameter 'randomize_vmalloc=1', the entire area is used randomly to make the allocations less predictable an

[PATCH v2] PCI: aardvark: Update comment about disabling link training

2020-12-02 Thread Pali Rohár
It is not HW bug or workaround for some cards but it is requirement by PCI Express spec. After fundamental reset is needed 100ms delay prior enabling link training. So update comment in code to reflect this requirement. Signed-off-by: Pali Rohár --- Changes in v2: * Add reference to the PCI Expre

Re: [PATCH 2/2] kernfs: remove mutex in kernfs_dop_revalidate

2020-12-02 Thread Tejun Heo
Hello, On Wed, Dec 02, 2020 at 10:58:37PM +0800, Fox Chen wrote: > There is a big mutex in kernfs_dop_revalidate which slows down the > concurrent performance of kernfs. > > Since kernfs_dop_revalidate only does some checks, the lock is > largely unnecessary. Also, according to kernel filesystem

Re: [PROBLEM] mm : kmemleaks related detected

2020-12-02 Thread Matthew Wilcox
On Thu, Dec 03, 2020 at 12:04:22AM +0530, Jeffrin Jose T wrote: > hello, > > > 2 new suspected  memory leaks.   See  below... You've reported this to the wrong place. It looks like the HID driver would be the place which is leaking memory, and is probably a better place to report it. > ---

Re: [PATCH v1 1/1] mfd: intel-m10-bmc: expose mac address and count

2020-12-02 Thread Tom Rix
On 12/2/20 10:26 AM, Russ Weight wrote: > > On 12/2/20 5:44 AM, Tom Rix wrote: >> On 12/1/20 12:36 PM, Russ Weight wrote: >>> Create two sysfs entries for exposing the MAC address >>> and count from the MAX10 BMC register space. >>> >>> Signed-off-by: Russ Weight >>> Signed-off-by: Xu Yilun >>>

[PATCH v4 07/26] arm64: Make cpu_logical_map() take unsigned int

2020-12-02 Thread David Brazdil
CPU index should never be negative. Change the signature of (set_)cpu_logical_map to take an unsigned int. This still works even if the users treat the CPU index as an int, and will allow the hypervisor's implementation to check that the index is valid with a single upper-bound check. Signed-off-

[PATCH v4 08/26] arm64: Extract parts of el2_setup into a macro

2020-12-02 Thread David Brazdil
When a CPU is booted in EL2, the kernel checks for VHE support and initializes the CPU core accordingly. For nVHE it also installs the stub vectors and drops down to EL1. Once KVM gains the ability to boot cores without going through the kernel entry point, it will need to initialize the CPU the s

[PATCH v4 25/26] kvm: arm64: Trap host SMCs in protected mode

2020-12-02 Thread David Brazdil
While protected KVM is installed, start trapping all host SMCs. For now these are simply forwarded to EL3, except PSCI CPU_ON/CPU_SUSPEND/SYSTEM_SUSPEND which are intercepted and the hypervisor installed on newly booted cores. Create new constant HCR_HOST_NVHE_PROTECTED_FLAGS with the new set of H

[PATCH v4 24/26] kvm: arm64: Keep nVHE EL2 vector installed

2020-12-02 Thread David Brazdil
KVM by default keeps the stub vector installed and installs the nVHE vector only briefly for init and later on demand. Change this policy to install the vector at init and then never uninstall it if the kernel was given the protected KVM command line parameter. Signed-off-by: David Brazdil --- a

[PATCH v4 26/26] kvm: arm64: Fix EL2 mode availability checks

2020-12-02 Thread David Brazdil
With protected nVHE hyp code interception host's PSCI SMCs, the host starts seeing new CPUs boot in EL1 instead of EL2. The kernel logic that keeps track of the boot mode needs to be adjusted. Add a static key enabled if KVM protected mode initialization is successful. When the key is enabled, is

<    2   3   4   5   6   7   8   9   10   11   >