Re: [PATCH v8 3/4] arm64: dts: imx8m: add NVMEM provider and consumer to read soc unique ID

2020-12-20 Thread Krzysztof Kozlowski
On Mon, Dec 21, 2020 at 03:10:52AM +, Alice Guo (OSS) wrote: > > > > -Original Message- > > From: Krzysztof Kozlowski > > Sent: 2020年12月19日 20:17 > > To: Alice Guo (OSS) > > Cc: robh...@kernel.org; shawn...@kernel.org; s.ha...@pengutronix.de; > > ker...@pengutronix.de;

Re: [PATCH v3 3/5] ipmi: kcs: aspeed: Adapt to new LPC DTS layout

2020-12-20 Thread Haiyue Wang
On 12/21/2020 13:56, Chia-Wei, Wang wrote: Add check against LPC device v2 compatible string to ensure that the fixed device tree layout is adopted. The LPC register offsets are also fixed accordingly. Signed-off-by: Chia-Wei, Wang --- drivers/char/ipmi/kcs_bmc_aspeed.c | 35

Re: [PATCH 9/9] mfd: sec-irq: Do not enforce (incorrect) interrupt trigger type

2020-12-20 Thread Krzysztof Kozlowski
On Mon, Dec 21, 2020 at 08:36:02AM +0100, Marek Szyprowski wrote: > Hi Krzysztof, > > On 18.12.2020 15:22, Krzysztof Kozlowski wrote: > > On Fri, Dec 18, 2020 at 02:25:39PM +0100, Marek Szyprowski wrote: > >> On 10.12.2020 22:29, Krzysztof Kozlowski wrote: > >>> Interrupt line can be configured

[PATCH] docs: driver-model: bus.rst: Clean up the formatting, expound, modernize

2020-12-20 Thread Michael Witten
* The reStructuredText had some indentation issues. * The HTML output was not properly formatted in places. * Some of the details were lacking or needed clarification (especially with regard to how a `struct bus_type` object should be defined). * The sysfs example hierarchy appeared outdated;

Re: [PATCH v2] docs/zh_CN: Improve Cinese transolation quality.

2020-12-20 Thread Alex Shi
在 2020/12/19 上午11:42, Ran Wang 写道: > Hi Jonathan, > > On Tuesday, December 8, 2020 11:00 PM Jonathan Corbet wrote: >   >> On Tue,  8 Dec 2020 21:16:04 +0800 >> Ran Wang wrote: >> >>> Signed-off-by: Ran Wang >>> --- >>> Change in v2: >>>    - For 'cn_development_coding' part, change back

[PATCH RFC v3 1/1] scsi: ufs: Fix ufs power down/on specs violation

2020-12-20 Thread Ziqi Chen
As per specs, e.g, JESD220E chapter 7.2, while powering off/on the ufs device, RST_N signal and REF_CLK signal should be between VSS(Ground) and VCCQ/VCCQ2. To flexibly control device reset line, re-name the function ufschd_vops_device_reset(sturct ufs_hba *hba) to ufshcd_

[PATCH RFC v2 1/1] scsi: ufs: Fix ufs power down/on specs violation

2020-12-20 Thread Ziqi Chen
As per specs, e.g, JESD220E chapter 7.2, while powering off/on the ufs device, RST_N signal and REF_CLK signal should be between VSS(Ground) and VCCQ/VCCQ2. To flexibly control device reset line, re-name the function ufschd_vops_device_reset(sturct ufs_hba *hba) to ufshcd_

Re: [RFC PATCH 0/5] iio: move 'modes' initialization to core

2020-12-20 Thread Alexandru Ardelean
On Sat, Dec 5, 2020 at 8:42 PM Jonathan Cameron wrote: > > On Thu, 3 Dec 2020 12:04:18 +0200 > Alexandru Ardelean wrote: > > > I stumbled over this, while trying to implement some changes to the IIO > > buffer logic. > > Seems that most drivers have a INDIO_DIRECT_MODE, and some have > >

Re: [PATCH] dmaengine: qcom: bam_dma: Add LOCK and UNLOCK flag bit support

2020-12-20 Thread mdalam
On 2020-12-19 09:05, Thara Gopinath wrote: On 12/17/20 9:37 AM, Md Sadre Alam wrote: This change will add support for LOCK & UNLOCK flag bit support on CMD descriptor. If DMA_PREP_LOCK flag passed in prep_slave_sg then requester of this transaction wanted to lock the DMA controller for this

Re: [PATCH 9/9] mfd: sec-irq: Do not enforce (incorrect) interrupt trigger type

2020-12-20 Thread Marek Szyprowski
Hi Krzysztof, On 18.12.2020 15:22, Krzysztof Kozlowski wrote: > On Fri, Dec 18, 2020 at 02:25:39PM +0100, Marek Szyprowski wrote: >> On 10.12.2020 22:29, Krzysztof Kozlowski wrote: >>> Interrupt line can be configured on different hardware in different way, >>> even inverted. Therefore driver

Re: [PATCH] bcache: Trivial fix to bdput

2020-12-20 Thread Coly Li
On 12/21/20 11:17 AM, Yi Li wrote: > Trivial fix to bdput. > > Signed-off-by: Yi Li e Hi Yi, Indeed these two fixes are not that trivial. I suggest to describe more detail about why your fixes are necessary and what problems are fixed by your patches. Thanks. Coly Li > --- >

Re: [PATCH] mm/userfaultfd: fix memory corruption due to writeprotect

2020-12-20 Thread Yu Zhao
On Sun, Dec 20, 2020 at 09:39:06PM -0800, Nadav Amit wrote: > > On Dec 20, 2020, at 9:25 PM, Nadav Amit wrote: > > > >> On Dec 20, 2020, at 9:12 PM, Yu Zhao wrote: > >> > >> On Sun, Dec 20, 2020 at 08:36:15PM -0800, Nadav Amit wrote: > On Dec 19, 2020, at 6:20 PM, Andrea Arcangeli >

[PATCH 1/2] tools/power/x86/intel-speed-select: Set scaling_max_freq to base_frequency

2020-12-20 Thread Srinivas Pandruvada
When BIOS disables turbo, The scaling_max_freq in cpufreq sysfs will be limited to config level 0 base frequency. But when user selects a higher config levels, this will result in higher base frequency. But since scaling_max_freq is still old base frequency, the performance will still be limited.

[PATCH 2/2] tools/power/x86/intel-speed-select: Set higher of cpuinfo_max_freq or base_frequency

2020-12-20 Thread Srinivas Pandruvada
In some case when BIOS disabled turbo, cpufreq cpuinfo_max_freq can be lower than base_frequency at higher config level. So, in that case set scaling_min_freq to base_frequency. Signed-off-by: Srinivas Pandruvada --- tools/power/x86/intel-speed-select/isst-config.c | 11 +++ 1 file

tools/power/x86/intel-speed-select: Fixes for regression

2020-12-20 Thread Srinivas Pandruvada
One side-effect of fixing the scaling frequency limits using the commit eacc9c5a927e ("cpufreq: intel_pstate: Fix intel_pstate_get_hwp_max() for turbo disabled") causes stale HWP_CAP.GUARANTEED to be used as max. Without processing HWP interrupts, user space needs to be able to update a new max

drivers/block/loop.c:1729:1: warning: the frame size of 1072 bytes is larger than 1024 bytes

2020-12-20 Thread kernel test robot
Hi Martijn, FYI, the error/warning still remains. tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 467f8165a2b0e6accf3d0dd9c8089b1dbde29f7f commit: 3448914e8cc550ba792d4ccc74471d1ca4293aae loop: Add LOOP_CONFIGURE ioctl date: 7 months ago config:

[PATCH] kconfig: doc: fix $(fileno) to $(filename)

2020-12-20 Thread Masahiro Yamada
This is a typo. Signed-off-by: Masahiro Yamada --- Documentation/kbuild/kconfig-macro-language.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/kbuild/kconfig-macro-language.rst b/Documentation/kbuild/kconfig-macro-language.rst index

[PATCH 1/3] perf tools: Use /proc//task//status for synthesis

2020-12-20 Thread Namhyung Kim
To save memory usage, it needs to reduce number of entries in the proc filesystem. It's using /proc//task directory to traverse threads in the process and then kernel creates /proc//task/ entries. After that it checks the thread info using the /proc//status file rather than /proc//task//status.

[PATCH] kconfig: doc: fix $(fileno) to $(filename)

2020-12-20 Thread Masahiro Yamada
This is a typo. Signed-off-by: Masahiro Yamada --- Documentation/kbuild/kconfig-macro-language.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/kbuild/kconfig-macro-language.rst b/Documentation/kbuild/kconfig-macro-language.rst index

[PATCH 3/3] perf tools: Use scandir() to iterate threads

2020-12-20 Thread Namhyung Kim
Like in __event__synthesize_thread(), I think it's better to use scandir() instead of the readdir() loop. In case some malicious task continues to create new threads, the readdir() loop will run over and over to collect tids. The scandir() also has the problem but the window is much smaller

[PATCH 2/3] perf tools: Skip MMAP record synthesis for kernel threads

2020-12-20 Thread Namhyung Kim
To synthesize information to resolve sample IPs, it needs to scan task and mmap info from the /proc filesystem. For each process, it opens (and reads) status and maps file respectively. But as kernel threads don't have memory maps so we can skip the maps file. To find kernel threads, check

[PATCH 0/3] perf tools: Minor improvements in event synthesis

2020-12-20 Thread Namhyung Kim
Hello, This is to optimize the event synthesis during perf record. The first patch is to reduce memory usage when many threads are used. The second is to avoid unncessary syscalls for kernel threads. And the last one is to reduce the number of threads to iterate when new threads are being

drivers/gpu/drm/msm/dp/dp_display.c:496:19: warning: variable 'hpd' set but not used

2020-12-20 Thread kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 467f8165a2b0e6accf3d0dd9c8089b1dbde29f7f commit: c58eb1b54feefc3a47fab78addd14083bc941c44 drm/msm/dp: fix connect/disconnect handled at irq_hpd date: 3 weeks ago config: arm-randconfig-r035-20201220

Re: [PATCH V2 XRT Alveo 2/6] fpga: xrt: infrastructure support for xmgmt driver

2020-12-20 Thread kernel test robot
Hi Sonal, Thank you for the patch! Yet something to improve: [auto build test ERROR on linux/master] [also build test ERROR on linus/master v5.10 next-20201218] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as

Re: [PATCH v2 5/5] mm: remove unneeded local variable in free_area_init_core

2020-12-20 Thread Mike Rapoport
On Sun, Dec 20, 2020 at 04:27:54PM +0800, Baoquan He wrote: > Local variable 'zone_start_pfn' is not needed since there's only > one call site in free_area_init_core(). Let's remove it and pass > zone->zone_start_pfn directly to init_currently_empty_zone(). > > Signed-off-by: Baoquan He

Re: [PATCH v2 4/5] mm: simplify parameter of setup_usemap()

2020-12-20 Thread Mike Rapoport
On Sun, Dec 20, 2020 at 04:27:53PM +0800, Baoquan He wrote: > Parameter 'zone' has got needed information, let's remove other > unnecessary parameters. > > Signed-off-by: Baoquan He Reviewed-by: Mike Rapoport > --- > mm/page_alloc.c | 17 +++-- > 1 file changed, 7 insertions(+),

Re: [PATCH v2 3/5] mm: simplify parater of function memmap_init_zone()

2020-12-20 Thread Mike Rapoport
On Sun, Dec 20, 2020 at 04:27:52PM +0800, Baoquan He wrote: > As David suggested, simply passing 'struct zone *zone' is enough. We can > get all needed information from 'struct zone*' easily. > > Suggested-by: David Hildenbrand > Signed-off-by: Baoquan He Reviewed-by: Mike Rapoport > --- >

Re: [PATCH v2 2/5] mm: rename memmap_init() and memmap_init_zone()

2020-12-20 Thread Mike Rapoport
On Sun, Dec 20, 2020 at 04:27:51PM +0800, Baoquan He wrote: > The current memmap_init_zone() only handles memory region inside one zone, > actually memmap_init() does the memmap init of one zone. So rename both of > them accordingly. > > And also rename the function parameter 'range_start_pfn'

Re: [PATCH v2] security: apparmor: delete repeated words in comments

2020-12-20 Thread John Johansen
On 12/20/20 7:27 PM, Randy Dunlap wrote: > Drop repeated words in comments. > {a, then, to} > > Signed-off-by: Randy Dunlap > Cc: John Johansen > Cc: appar...@lists.ubuntu.com > Cc: James Morris > Cc: "Serge E. Hallyn" > Cc: linux-security-mod...@vger.kernel.org > Reviewed-By: Seth Arnold

Re: [PATCH v2 1/5] mm: memmap defer init dosn't work as expected

2020-12-20 Thread Mike Rapoport
On Sun, Dec 20, 2020 at 04:27:50PM +0800, Baoquan He wrote: > VMware observed a performance regression during memmap init on their platform, > and bisected to commit 73a6e474cb376 ("mm: memmap_init: iterate over memblock > regions rather that check each PFN") causing it. > > Before the commit: >

Re: [PATCH v1] kbuild: enforce -Werror=unused-result

2020-12-20 Thread Masahiro Yamada
On Tue, Dec 1, 2020 at 7:42 PM Masahiro Yamada wrote: > > On Tue, Nov 17, 2020 at 7:47 PM Olaf Hering wrote: > > > > It is a hard error if a return value is ignored. > > In case the return value has no meaning, remove the attribute. > > > > Signed-off-by: Olaf Hering > > Applied to

Re: [PATCH] ide: pci: Fix memleak in ide_pci_init_two

2020-12-20 Thread Kari Argillander
On Sun, Dec 20, 2020 at 03:05:40PM +0800, Dinghao Liu wrote: > When do_ide_setup_pci_device() fails, host allocated > by ide_host_alloc() may not have been freed, which > leads to memleak. > > Signed-off-by: Dinghao Liu > --- > drivers/ide/setup-pci.c | 8 > 1 file changed, 4

[PATCH v2] KVM/x86: Move definition of __ex to x86.h

2020-12-20 Thread Uros Bizjak
Merge __kvm_handle_fault_on_reboot with its sole user and move the definition of __ex to a common include to be shared between VMX and SVM. v2: Rebase to latest kvm/queue. Cc: Paolo Bonzini Cc: Sean Christopherson Signed-off-by: Uros Bizjak Reviewed-by: Krish Sadhukhan ---

Re: [PATCH v2] ovl: fix dentry leak in ovl_get_redirect

2020-12-20 Thread Al Viro
On Sun, Dec 20, 2020 at 08:09:27PM +0800, Liangyan wrote: > +++ b/fs/overlayfs/dir.c > @@ -973,6 +973,7 @@ static char *ovl_get_redirect(struct dentry *dentry, bool > abs_redirect) > for (d = dget(dentry); !IS_ROOT(d);) { > const char *name; > int thislen; > +

mm/filemap.c:2439:9: warning: stack frame size of 2096 bytes in function 'generic_file_buffered_read'

2020-12-20 Thread kernel test robot
config: powerpc-randconfig-r002-20201220 (attached as .config) compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project cee1e7d14f4628d6174b33640d502bff3b54ae45) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin

RE: [PATCH v3 2/3] fpga: dfl: add the userspace I/O device support for DFL devices

2020-12-20 Thread Wu, Hao
> Subject: Re: [PATCH v3 2/3] fpga: dfl: add the userspace I/O device support > for DFL devices > > On Fri, Dec 18, 2020 at 05:59:17AM -0800, Tom Rix wrote: > > > > On 12/18/20 12:05 AM, Wu, Hao wrote: > > >> Subject: [PATCH v3 2/3] fpga: dfl: add the userspace I/O device support > for > > >> DFL

Re: [PATCH v3] Compiler Attributes: remove CONFIG_ENABLE_MUST_CHECK

2020-12-20 Thread Masahiro Yamada
On Mon, Dec 14, 2020 at 12:27 AM Miguel Ojeda wrote: > > On Sun, Dec 13, 2020 at 4:16 PM Greg KH wrote: > > > > Because if you get a report of something breaking for your change, you > > need to work to resolve it, not argue about it. Otherwise it needs to > > be dropped/reverted. > > Nobody

[PATCH] powerpc/32: Fix vmap stack - Properly set r1 before activating MMU on syscall too

2020-12-20 Thread Christophe Leroy
We need r1 to be properly set before activating MMU, otherwise any new exception taken while saving registers into the stack in syscall prologs will use the user stack, which is wrong and will even lockup or crash when KUAP is selected. Do that by switching the meaning of r11 and r1 until we have

Re: [PATCH v2] ovl: fix dentry leak in ovl_get_redirect

2020-12-20 Thread Liangyan
Guys, any comments on this patch? This issue should exist in latest upstream. On 20/12/20 下午8:09, Liangyan wrote: We need to lock d_parent->d_lock before dget_dlock, or this may have d_lockref updated parallelly like calltrace below which will cause dentry->d_lockref leak and risk a crash.

[PATCH v3 2/2] arm64: dts: mt8192: add eFuse support for MT8192 SoC

2020-12-20 Thread Yz.Wu
From: Ryan Wu Add eFuse node to read Mediatek eFuse Signed-off-by: Ryan Wu --- This patch dependents on "arm64: dts: Add Mediatek SoC MT8192 and evaluation board dts and Makefile"[1] mt8192.dtsi file is needed for this patch. Please also accept this patch together with [1].

[PATCH v3 1/2] dt-bindings: nvmem: mediatek: add support for MediaTek mt8192 SoC

2020-12-20 Thread Yz.Wu
From: Ryan Wu This updates dt-binding documentation for MediaTek mt8192 Signed-off-by: Ryan Wu --- This patch is based on v5.10-rc7. --- Documentation/devicetree/bindings/nvmem/mtk-efuse.txt | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH v3 0/2] Add Mediatek Efuse Device Node for MT8192 SoC

2020-12-20 Thread Yz.Wu
From: Ryan Wu This patch adds efuse to read via NVMEM. Ryan Wu (2): dt-bindings: nvmem: mediatek: add support for MediaTek mt8192 SoC arm64: dts: mt8192: add eFuse support for MT8192 SoC Documentation/devicetree/bindings/nvmem/mtk-efuse.txt | 1 + arch/arm64/boot/dts/mediatek/mt8192.dtsi

Re: [PATCH v2] regulators: bd718x7: Add enable times

2020-12-20 Thread Vaittinen, Matti
On Fri, 2020-12-18 at 19:38 +0100, Guido Günther wrote: > Use the typical startup times from the data sheet so boards get a > reasonable default. Not setting any enable time can lead to board > hangs > when e.g. clocks are enabled too soon afterwards. > > This fixes gpu power domain resume on

[ANNOUNCE] iproute2-5.10

2020-12-20 Thread Stephen Hemminger
Just in time for the holidays, new iproute2! This update is smaller than usual, not a lot of new features. It does NOT include libbpf, that will be merged in 5.11 (iproute2-next). Download: https://www.kernel.org/pub/linux/utils/net/iproute2/iproute2-5.10.0.tar.gz Repository for upcoming

Re: [PATCH] [v11] wireless: Initial driver submission for pureLiFi STA devices

2020-12-20 Thread Kalle Valo
Srinivasan Raju writes: >> I see lots of magic numbers in the driver like 2, 0x33 and 0x34 here. >> Please convert the magic numbers to proper defines explaining the >> meaning. And for vendor commands you could even use enum to group >> them better in .h file somewhere. > > Hi Kalle, > > Thanks

[PATCH v3 5/5] soc: aspeed: Adapt to new LPC device tree layout

2020-12-20 Thread Chia-Wei, Wang
Add check against LPC device v2 compatible string to ensure that the fixed device tree layout is adopted. The LPC register offsets are also fixed accordingly. Signed-off-by: Chia-Wei, Wang --- drivers/soc/aspeed/aspeed-lpc-ctrl.c | 20 ++-- drivers/soc/aspeed/aspeed-lpc-snoop.c

Re: [PATCH] block: aoe: replace use of __constant_htons to htons

2020-12-20 Thread 'Amey Narkhede'
--- Begin Message --- On 20/12/20 07:35PM, David Laight wrote: > From: Amey Narkhede > > Sent: 20 December 2020 16:46 > > > > The macro htons expands to __swab16 which has special > > case for constants in little endian case. In big > > endian case both __constant_htons and htons macros > > expand

[PATCH v3 3/5] ipmi: kcs: aspeed: Adapt to new LPC DTS layout

2020-12-20 Thread Chia-Wei, Wang
Add check against LPC device v2 compatible string to ensure that the fixed device tree layout is adopted. The LPC register offsets are also fixed accordingly. Signed-off-by: Chia-Wei, Wang --- drivers/char/ipmi/kcs_bmc_aspeed.c | 35 ++ 1 file changed, 21

[PATCH v3 4/5] pinctrl: aspeed-g5: Adapt to new LPC device tree layout

2020-12-20 Thread Chia-Wei, Wang
Add check against LPC device v2 compatible string to ensure that the fixed device tree layout is adopted. The LPC register offsets are also fixed accordingly. Signed-off-by: Chia-Wei, Wang --- drivers/pinctrl/aspeed/pinctrl-aspeed-g5.c | 19 +-- 1 file changed, 13 insertions(+),

[PATCH v3 1/5] dt-bindings: aspeed-lpc: Remove LPC partitioning

2020-12-20 Thread Chia-Wei, Wang
The LPC controller has no concept of the BMC and the Host partitions. This patch fixes the documentation by removing the description on LPC partitions. The register offsets illustrated in the DTS node examples are also fixed to adapt to the LPC DTS change. Signed-off-by: Chia-Wei, Wang ---

[PATCH v3 2/5] ARM: dts: Remove LPC BMC and Host partitions

2020-12-20 Thread Chia-Wei, Wang
The LPC controller has no concept of the BMC and the Host partitions. A concrete instance is that the HICRB[5:4] are for the I/O port address configurtaion of KCS channel 1/2. However, the KCS driver cannot access HICRB for channel 1/2 initialization via syscon regmap interface due to the

[PATCH v3 0/5] Remove LPC register partitioning

2020-12-20 Thread Chia-Wei, Wang
The LPC controller has no concept of the BMC and the Host partitions. The incorrect partitioning can impose unnecessary range restrictions on register access through the syscon regmap interface. For instance, HICRB contains the I/O port address configuration of KCS channel 1/2. However, the

RE: [PATCH] [v11] wireless: Initial driver submission for pureLiFi STA devices

2020-12-20 Thread Srinivasan Raju
> I see lots of magic numbers in the driver like 2, 0x33 and 0x34 here. > Please convert the magic numbers to proper defines explaining the meaning. > And for vendor commands you could even use enum to group them better in .h > file somewhere. Hi Kalle, Thanks for reviewing the driver, We

[PATCH v2] bcache: Trivial fix to register_bcache

2020-12-20 Thread Yi Li
Trivial fix to no need to check the bdev and do bdput. Fixes: 4e7b5671c6a8("block: remove i_bdev") Signed-off-by: Yi Li --- drivers/md/bcache/super.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/md/bcache/super.c b/drivers/md/bcache/super.c index f7ad1e26b013..4edf666860ad

[PATCH] net: lantiq_etop: check the result of request_irq()

2020-12-20 Thread Masahiro Yamada
The declaration of request_irq() in is marked as __must_check. Without the return value check, I see the following warnings: drivers/net/ethernet/lantiq_etop.c: In function 'ltq_etop_hw_init': drivers/net/ethernet/lantiq_etop.c:273:4: warning: ignoring return value of 'request_irq', declared

Re: [PATCH 01/23] kernel: irq: irqdescs: warn on spurious IRQ

2020-12-20 Thread Michael Ellerman
Andy Shevchenko writes: > On Fri, Dec 18, 2020 at 4:37 PM Enrico Weigelt, metux IT consult > wrote: > >> + if (printk_ratelimit()) >> + pr_warn("spurious IRQ: irq=%d hwirq=%d nr_irqs=%d\n", >> + irq, hwirq, nr_irqs); > > Perhaps

Re: [PATCH] mm/userfaultfd: fix memory corruption due to writeprotect

2020-12-20 Thread Nadav Amit
> On Dec 20, 2020, at 9:25 PM, Nadav Amit wrote: > >> On Dec 20, 2020, at 9:12 PM, Yu Zhao wrote: >> >> On Sun, Dec 20, 2020 at 08:36:15PM -0800, Nadav Amit wrote: On Dec 19, 2020, at 6:20 PM, Andrea Arcangeli wrote: On Sat, Dec 19, 2020 at 02:06:02PM -0800, Nadav Amit wrote:

Fwd: Re: [PATCH] block: aoe: replace use of __constant_htons to htons

2020-12-20 Thread 'Amey Narkhede'
--- Begin Message --- On 20/12/20 07:35PM, David Laight wrote: > From: Amey Narkhede > > Sent: 20 December 2020 16:46 > > > > The macro htons expands to __swab16 which has special > > case for constants in little endian case. In big > > endian case both __constant_htons and htons macros > > expand

Re: [PATCH] epoll: fix compat syscall wire up of epoll_pwait2

2020-12-20 Thread Linus Torvalds
On Sun, Dec 20, 2020 at 10:22 AM Willem de Bruijn wrote: > > Slightly tangential, it's not immediately clear to me why in > arch/x86/entry/syscalls/syscall_32.tbl epoll_pwait does not need a > compat entry, unlike on other architectures and unlike signalfd. Hmm. Good question. That looks like a

Re: [PATCH] epoll: fix compat syscall wire up of epoll_pwait2

2020-12-20 Thread Linus Torvalds
On Sun, Dec 20, 2020 at 12:14 PM Arnd Bergmann wrote: > > The sigset_t argument is actually compatible between x86-32 and x86-64 Well, random high bits in size_t or the pointer value aren't. So it still looks a bit iffy to me. But it might end up working almost by accident. Linus

Re: [PATCH] mm/userfaultfd: fix memory corruption due to writeprotect

2020-12-20 Thread Nadav Amit
> On Dec 20, 2020, at 9:12 PM, Yu Zhao wrote: > > On Sun, Dec 20, 2020 at 08:36:15PM -0800, Nadav Amit wrote: >>> On Dec 19, 2020, at 6:20 PM, Andrea Arcangeli wrote: >>> >>> On Sat, Dec 19, 2020 at 02:06:02PM -0800, Nadav Amit wrote: > On Dec 19, 2020, at 1:34 PM, Nadav Amit wrote: >

Re: [PATCH v6 1/5] counter: Internalize sysfs interface code

2020-12-20 Thread William Breathitt Gray
On Sun, Dec 13, 2020 at 05:15:00PM -0600, David Lechner wrote: > On 11/22/20 2:29 PM, William Breathitt Gray wrote: > > > 14 files changed, 1806 insertions(+), 2546 deletions(-) > > It would be really nice if we could break this down into smaller > pieces and start getting it merged. It is

[PATCH V2 3/3] phy: phy-brcm-usb: support PHY on the BCM4908

2020-12-20 Thread Rafał Miłecki
From: Rafał Miłecki BCM4908 seems to have slightly different registers but works when programmed just like the STB one. Signed-off-by: Rafał Miłecki --- V2: Update Kconfig as well --- drivers/phy/broadcom/Kconfig| 3 ++- drivers/phy/broadcom/phy-brcm-usb.c | 4 2 files changed, 6

[PATCH V2 2/3] dt-bindings: phy: brcm,brcmstb-usb-phy: add BCM4908 binding

2020-12-20 Thread Rafał Miłecki
From: Rafał Miłecki BCM4908 uses the same PHY and may require just a slightly different programming. Signed-off-by: Rafał Miłecki Acked-by: Florian Fainelli --- .../devicetree/bindings/phy/brcm,brcmstb-usb-phy.yaml| 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git

[PATCH V2 1/3] dt-bindings: phy: brcm,brcmstb-usb-phy: convert to the json-schema

2020-12-20 Thread Rafał Miłecki
From: Rafał Miłecki Changes that require mentioning: 1. interrupt-names Name "wakeup" was changed to the "wake". It matches example and what Linux driver looks for in the first place 2. brcm,ipp and brcm,ioc Both were described as booleans with 0 / 1 values. In examples they were

Re: [PATCH v4 1/5] soc: mediatek: pwrap: use BIT() macro

2020-12-20 Thread Nicolas Boichat
On Wed, Nov 18, 2020 at 8:08 PM Hsin-Hsiung Wang wrote: > > Use a better BIT() marco for the bit definition. > No functional changes, cleanup only. > > Signed-off-by: Hsin-Hsiung Wang Reviewed-by: Nicolas Boichat > --- > drivers/soc/mediatek/mtk-pmic-wrap.c | 4 ++-- > 1 file changed, 2

[PATCH v2] staging: rtl8192e: fix bool comparison in expressions

2020-12-20 Thread Aditya Srivastava
There are certain conditional expressions in rtl8192e, where a boolean variable is compared with true/false, in forms such as (foo == true) or (false != bar), which does not comply with checkpatch.pl (CHECK: BOOL_COMPARISON), according to which boolean variables should be themselves used in the

linux-next: build failure after merge of the akpm tree

2020-12-20 Thread Stephen Rothwell
Hi all, After merging the akpm tree, today's linux-next build (arm64 allmodconfig) failed like this: ./include/uapi/asm-generic/unistd.h:867:27: error: array index in initializer exceeds array bounds Caused by commit 390e5073c473 ("arch, mm: wire up memfd_secret system call where relevant")

Re: [PATCH] MAINTAINERS: adjust GCC PLUGINS after gcc-plugin.sh removal

2020-12-20 Thread Masahiro Yamada
On Sun, Dec 20, 2020 at 1:25 AM Lukas Bulwahn wrote: > > Commit 1e860048c53e ("gcc-plugins: simplify GCC plugin-dev capability test") > removed ./scripts/gcc-plugin.sh, but missed to adjust MAINTAINERS. > > Hence, ./scripts/get_maintainers.pl --self-test=patterns warns: > > warning: no file

[PATCH] cpufreq: intel_pstate: remove obsolete functions

2020-12-20 Thread Lukas Bulwahn
percent_fp() was used in intel_pstate_pid_reset(), which was removed in commit 9d0ef7af1f2d ("cpufreq: intel_pstate: Do not use PID-based P-state selection") and hence, percent_fp() is unused since then. percent_ext_fp() was last used in intel_pstate_update_perf_limits(), which was refactored in

Re: [PATCH] mm/userfaultfd: fix memory corruption due to writeprotect

2020-12-20 Thread Yu Zhao
On Sun, Dec 20, 2020 at 08:36:15PM -0800, Nadav Amit wrote: > > On Dec 19, 2020, at 6:20 PM, Andrea Arcangeli wrote: > > > > On Sat, Dec 19, 2020 at 02:06:02PM -0800, Nadav Amit wrote: > >>> On Dec 19, 2020, at 1:34 PM, Nadav Amit wrote: > >>> > >>> [ cc’ing some more people who have

Re: [v5,2/3] PCI: mediatek-gen3: Add MediaTek Gen3 driver for MT8192

2020-12-20 Thread Nicolas Boichat
On Wed, Dec 2, 2020 at 9:39 PM Jianjun Wang wrote: > > MediaTek's PCIe host controller has three generation HWs, the new > generation HW is an individual bridge, it supports Gen3 speed and > up to 256 MSI interrupt numbers for multi-function devices. > > Add support for new Gen3 controller which

Re: [PATCH v4 9/9] media: uvcvideo: Implement UVC_QUIRK_PRIVACY_DURING_STREAM

2020-12-20 Thread Ricardo Ribalda
HI On Sun, Dec 20, 2020 at 6:22 PM Laurent Pinchart wrote: > > Hi Ricardo, > > Thank you for the patch. > > On Tue, Dec 15, 2020 at 04:44:39PM +0100, Ricardo Ribalda wrote: > > Some devices, can only read the privacy_pin if the device is > > streaming. > > :-( :"-( > > > This patch implement a

Re: [PATCH v4 2/5] soc: mediatek: pwrap: add arbiter capability

2020-12-20 Thread Nicolas Boichat
On Wed, Nov 18, 2020 at 8:08 PM Hsin-Hsiung Wang wrote: > > Add arbiter capability for pwrap driver. > The arbiter capability uses new design to judge the priority and latency > for multi-channel. > This patch is preparing for adding mt6873/8192 pwrap support. > > Signed-off-by: Hsin-Hsiung Wang

Re: [PATCH v5 2/7] media: v4l2: Add extended buffer operations

2020-12-20 Thread Tomasz Figa
On Thu, Dec 17, 2020 at 10:20 PM Helen Koike wrote: > > Hi Tomasz, > > Thanks for your comments, I have a few questions below. > > On 12/16/20 12:13 AM, Tomasz Figa wrote: > > On Tue, Dec 15, 2020 at 11:37 PM Helen Koike > > wrote: > >> > >> Hi Tomasz, > >> > >> On 12/14/20 7:46 AM, Tomasz Figa

[PATCH] KVM/SVM: Remove leftover __svm_vcpu_run prototype from svm.c

2020-12-20 Thread Uros Bizjak
Commit 16809ecdc1e8a moved __svm_vcpu_run the prototype to svm.h, but forgot to remove the original from svm.c. Fixes: 16809ecdc1e8a ("KVM: SVM: Provide an updated VMRUN invocation for SEV-ES guests") Cc: Tom Lendacky Cc: Paolo Bonzini Signed-off-by: Uros Bizjak --- arch/x86/kvm/svm/svm.c |

Re: [PATCH] dma/qcom/gpi: Fixes a format mismatch

2020-12-20 Thread Bjorn Andersson
On Fri 18 Dec 02:41 PST 2020, Xiaoming Ni wrote: > drivers/dma/qcom/gpi.c:1419:3: warning: format '%lu' expects argument of > type 'long unsigned int', but argument 8 has type 'size_t {aka unsigned > int}' [-Wformat=] > drivers/dma/qcom/gpi.c:1427:31: warning: format '%lu' expects argument of >

Re: [v6,2/4] dt-binding: mediatek: mt8192: update mtk-wdt document

2020-12-20 Thread Nicolas Boichat
On Mon, Nov 16, 2020 at 8:27 PM Crystal Guo wrote: > > Hi Maintainers, > > Gentle pin for this patch. > > Thanks > > On Wed, 2020-10-14 at 21:19 +0800, Crystal Guo wrote: > > update mtk-wdt document for MT8192 platform Rob: I assume your input is required here? Any chance we could have your

Re: [RFC PATCH v2 0/8] Adding the Sparx5 Switch Driver

2020-12-20 Thread Florian Fainelli
On 12/16/2020 11:51 PM, Steen Hegelund wrote: > This series provides the Microchip Sparx5 Switch Driver > > The Sparx5 Carrier Ethernet and Industrial switch family delivers 64 > Ethernet ports and up to 200 Gbps of switching bandwidth. > > It provides a rich set of Ethernet switching

Re: [PATCH v4 9/9] media: uvcvideo: Implement UVC_QUIRK_PRIVACY_DURING_STREAM

2020-12-20 Thread Ricardo Ribalda
Hi Laurent On Mon, Dec 21, 2020 at 3:08 AM Laurent Pinchart wrote: > > Hi Ricardo, > > On Mon, Dec 21, 2020 at 02:10:18AM +0100, Ricardo Ribalda wrote: > > On Sun, Dec 20, 2020 at 6:22 PM Laurent Pinchart wrote: > > > On Tue, Dec 15, 2020 at 04:44:39PM +0100, Ricardo Ribalda wrote: > > > > Some

Re: [PATCH 2/3] arm64: dts: qcom: sm8150: Add PSCI idle states

2020-12-20 Thread Bjorn Andersson
On Sun 20 Dec 16:29 PST 2020, Danny Lin wrote: > Like other Qualcomm SoCs, sm8150 exposes CPU and cluster idle states > through PSCI. Define the idle states to save power when the CPU is not > in active use. > > These idle states, latency, and residency values match the downstream > 4.14 kernel

Re: [PATCH] iio:light:apds9960 add detection for MSHW0184 ACPI device in apds9960 driver

2020-12-20 Thread Matt Ranostay
On Sat, Dec 19, 2020 at 5:51 PM Max Leiter wrote: > > The device is used in the Microsoft Surface Book 3 and Surface Pro 7 > > Signed-off-by: Max Leiter Reviewed-by: Matt Ranostay > --- > drivers/iio/light/apds9960.c | 8 > 1 file changed, 8 insertions(+) > > diff --git

Re: [PATCH] genirq/msi: Initialize msi_alloc_info to zero for msi_prepare API

2020-12-20 Thread Zenghui Yu
Hi Marc, On 2020/12/19 1:38, Marc Zyngier wrote: Hi Zenghui, On Fri, 18 Dec 2020 06:00:39 +, Zenghui Yu wrote: Since commit 5fe71d271df8 ("irqchip/gic-v3-its: Tag ITS device as shared if allocating for a proxy device"), some of the devices are wrongly marked as "shared" by the ITS

Re: [PATCH v4 5/9] media: uvcvideo: Implement UVC_EXT_GPIO_UNIT

2020-12-20 Thread Ricardo Ribalda
HI Laurent Thanks for your review! On Sun, Dec 20, 2020 at 5:49 PM Laurent Pinchart wrote: > > Hi Ricardo, > > Thank you for the patch. > > On Tue, Dec 15, 2020 at 04:44:35PM +0100, Ricardo Ribalda wrote: > > Some devices can implement a physical switch to disable the input of the > > camera on

Re: [GIT PULL] CIFS/SMB3 Fixes

2020-12-20 Thread pr-tracker-bot
The pull request you sent on Sun, 20 Dec 2020 13:47:32 -0600: > git://git.samba.org/sfrench/cifs-2.6.git tags/5.11-rc-smb3-part2 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/582888130702b86daa44ff6bfee585e4d4050ba0 Thank you! -- Deet-doot-dot, I am a bot.

Re: [PATCH] mm/userfaultfd: fix memory corruption due to writeprotect

2020-12-20 Thread Yu Zhao
On Sun, Dec 20, 2020 at 07:33:09PM -0800, Nadav Amit wrote: > > On Dec 20, 2020, at 1:54 AM, Yu Zhao wrote: > > > > On Sun, Dec 20, 2020 at 12:06:38AM -0800, Nadav Amit wrote: > >>> On Dec 19, 2020, at 10:05 PM, Yu Zhao wrote: > >>> > >>> On Sat, Dec 19, 2020 at 01:34:29PM -0800, Nadav Amit

[PATCH v2 2/2] platform/chrome: cros_ec_sysfs: Add cold-ap-off to sysfs reboot.

2020-12-20 Thread Pi-Hsun Shih
Add cold-ap-off to ChromeOS EC sysfs reboot file option, corresponds to the EC_REBOOT_COLD_AP_OFF flag, that will reset EC and keep AP off. Signed-off-by: Pi-Hsun Shih --- drivers/platform/chrome/cros_ec_sysfs.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

Re: [PATCH v1] arm64: dts: qcom: sdm845-db845c: Fix reset-pin of ov8856 node

2020-12-20 Thread Bjorn Andersson
On Thu 17 Dec 07:12 PST 2020, Robert Foss wrote: > Switch reset pin of ov8856 node from GPIO_ACTIVE_HIGH to GPIO_ACTIVE_LOW, > this issue prevented the ov8856 from probing properly as it does not respond > to I2C messages. > > Fixes: d4919a44564b ("arm64: dts: qcom: sdm845-db845c: Add ov8856 &

[PATCH v2] kernel: locking: delete repeated words in comments

2020-12-20 Thread Randy Dunlap
Drop repeated words in kernel/locking/. {it, no, the} Signed-off-by: Randy Dunlap Cc: Peter Zijlstra Cc: Ingo Molnar Cc: Will Deacon --- v2: rebase, resend kernel/locking/rtmutex.c |4 ++-- kernel/locking/rwsem.c |2 +- kernel/locking/semaphore.c |2 +- 3 files changed, 4

Re: [PATCH v4 5/9] media: uvcvideo: Implement UVC_EXT_GPIO_UNIT

2020-12-20 Thread Ricardo Ribalda
HI Laurent On Mon, Dec 21, 2020 at 12:24 AM Laurent Pinchart wrote: > > Hi Ricardo, > > On Sun, Dec 20, 2020 at 11:56:12PM +0100, Ricardo Ribalda wrote: > > On Sun, Dec 20, 2020 at 5:49 PM Laurent Pinchart wrote: > > > On Tue, Dec 15, 2020 at 04:44:35PM +0100, Ricardo Ribalda wrote: > > > > Some

[PATCH v2] kernel: sched: delete repeated words in comments

2020-12-20 Thread Randy Dunlap
Drop repeated words in kernel/sched/. {in, not} Signed-off-by: Randy Dunlap Cc: Mathieu Desnoyers Cc: "Paul E. McKenney" Cc: Ingo Molnar Cc: Peter Zijlstra Cc: Juri Lelli Cc: Vincent Guittot --- v2: rebase, resend kernel/sched/fair.c |2 +- kernel/sched/membarrier.c |2 +-

[PATCH v2] kernel: events: delete repeated words in comments

2020-12-20 Thread Randy Dunlap
Drop repeated words in kernel/events/. {if, the, that, with, time} Signed-off-by: Randy Dunlap Cc: Peter Zijlstra Cc: Ingo Molnar Cc: Arnaldo Carvalho de Melo --- v2: rebase, resend kernel/events/core.c|8 kernel/events/uprobes.c |2 +- 2 files changed, 5 insertions(+),

[PATCH v2 1/2] platform/chrome: cros_ec: Add host command to keep AP off after EC reset.

2020-12-20 Thread Pi-Hsun Shih
Add command to EC_CMD_REBOOT_EC to reset EC but don't boot AP. Signed-off-by: Pi-Hsun Shih --- include/linux/platform_data/cros_ec_commands.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/linux/platform_data/cros_ec_commands.h b/include/linux/platform_data/cros_ec_commands.h

Re: [PATCH] mm/userfaultfd: fix memory corruption due to writeprotect

2020-12-20 Thread Nadav Amit
> On Dec 19, 2020, at 6:20 PM, Andrea Arcangeli wrote: > > On Sat, Dec 19, 2020 at 02:06:02PM -0800, Nadav Amit wrote: >>> On Dec 19, 2020, at 1:34 PM, Nadav Amit wrote: >>> >>> [ cc’ing some more people who have experience with similar problems ] >>> On Dec 19, 2020, at 11:15 AM, Andrea

Re: [RFC PATCH v2 1/8] dt-bindings: net: sparx5: Add sparx5-switch bindings

2020-12-20 Thread Florian Fainelli
On 12/16/2020 11:51 PM, Steen Hegelund wrote: > Document the Sparx5 switch device driver bindings > > Signed-off-by: Steen Hegelund > Signed-off-by: Lars Povlsen > --- [snip] > + max-speed: > +maxItems: 1 > +description: Bandwidth allocated to this port > +

Re: [PATCH v6 0/5] Introduce the Counter character device interface

2020-12-20 Thread William Breathitt Gray
On Sun, Dec 13, 2020 at 05:15:14PM -0600, David Lechner wrote: > On 11/22/20 2:29 PM, William Breathitt Gray wrote: > > > > 1. Should standard Counter component data types be defined as u8 or u32? > > > > Many standard Counter component types such COUNTER_COMP_SIGNAL_LEVEL > > have

Re: [PATCH] mm/userfaultfd: fix memory corruption due to writeprotect

2020-12-20 Thread Nadav Amit
> On Dec 20, 2020, at 1:54 AM, Yu Zhao wrote: > > On Sun, Dec 20, 2020 at 12:06:38AM -0800, Nadav Amit wrote: >>> On Dec 19, 2020, at 10:05 PM, Yu Zhao wrote: >>> >>> On Sat, Dec 19, 2020 at 01:34:29PM -0800, Nadav Amit wrote: [ cc’ing some more people who have experience with similar

[GIT PULL] CIFS/SMB3 Fixes

2020-12-20 Thread Steve French
Please pull the following changes since commit e13300bdaa68f5487000e66baed1ff69bcb510bf: Merge tag '5.11-rc-smb3' of git://git.samba.org/sfrench/cifs-2.6 (2020-12-17 17:41:37 -0800) are available in the Git repository at: git://git.samba.org/sfrench/cifs-2.6.git tags/5.11-rc-smb3-part2 for

[PATCH] mm: zswap: clean up confusing comment

2020-12-20 Thread Randy Dunlap
Correct wording and change one duplicated word (it) to "it is". Fixes: 0ab0abcf5115 ("mm/zswap: refactor the get/put routines") Signed-off-by: Randy Dunlap Cc: Weijie Yang Cc: Seth Jennings Cc: Seth Jennings Cc: Andrew Morton Cc: Dan Streetman Cc: Vitaly Wool Cc: linux...@kvack.org ---

Re: [PATCH v4 4/5] soc: mediatek: pwrap: add pwrap driver for MT6873/8192 SoCs

2020-12-20 Thread Nicolas Boichat
On Wed, Nov 18, 2020 at 8:08 PM Hsin-Hsiung Wang wrote: > > MT6873/8192 are highly integrated SoCs and use PMIC_MT6359 for > power management. This patch adds pwrap master driver to > access PMIC_MT6359. > > Signed-off-by: Hsin-Hsiung Wang > --- > drivers/soc/mediatek/mtk-pmic-wrap.c | 29

  1   2   3   4   >