[PATCH] power: supply: remove duplicated argument in power_supply_hwmon_info

2021-01-11 Thread menglong8 . dong
From: Menglong Dong 'HWMON_T_INPUT' and 'HWMON_T_MIN_ALARM' in power_supply_hwmon_info are duplicated and can be removed. Signed-off-by: Menglong Dong --- drivers/power/supply/power_supply_hwmon.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/power/supply/power_supply_hwmon.c

Re: [PATCH] net: macb: Add default usrio config to default gem config

2021-01-11 Thread Atish Patra
On Mon, 2021-01-11 at 15:13 -0800, Jakub Kicinski wrote: > On Mon, 11 Jan 2021 11:55:53 -0800 Atish Patra wrote: > > There is no usrio config defined for default gem config leading to > > a kernel panic devices that don't define a data. This issue can be > > reprdouced with microchip polar fire

[PATCH] drm: Removes invalid function return value comment information

2021-01-11 Thread Zhaoge Zhang
Signed-off-by: Zhaoge Zhang --- drivers/gpu/drm/drm_file.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/gpu/drm/drm_file.c b/drivers/gpu/drm/drm_file.c index b50380f..8548e8b 100644 --- a/drivers/gpu/drm/drm_file.c +++ b/drivers/gpu/drm/drm_file.c @@ -240,9 +240,6 @@ static void

Re: [PATCH v4 3/6] ASoC: audio-graph-card: Support setting component plls and sysclks

2021-01-11 Thread Kuninori Morimoto
Hi Richard > Some codecs need plls and/or sysclks to be configured using the > snd_soc_component_set_[sysclk|pll] functions. These drivers cannot > necessarily be converted to use the clock framework. If the codec is on > a I2C/SPI bus, a nested clk_get would be needed to enable the bus clock.

Re: [PATCH 4/5] security: DH - use KDF implementation from crypto API

2021-01-11 Thread Jarkko Sakkinen
On Mon, 2021-01-04 at 22:49 +0100, Stephan Müller wrote: > The kernel crypto API provides the SP800-108 counter KDF implementation. > Thus, the separate implementation provided as part of the keys subsystem > can be replaced with calls to the KDF offered by the kernel crypto API. > > The keys

[PATCH 2/2] arm64: dts: qcom: sm8250: Add CPU capacities and energy model

2021-01-11 Thread Danny Lin
Power and performance measurements were made using my freqbench [1] benchmark coordinator, which isolates, offlines, and disables the timer tick on test CPUs to maximize accuracy. It uses EEMBC CoreMark [2] as the workload and measures power usage using the PM8150B PMIC's fuel gauge. The energy

Re: [f2fs-dev] [PATCH v3 1/5] f2fs: compress: add compress_inode to cache compressed blocks

2021-01-11 Thread Chao Yu
On 2021/1/11 19:45, Chao Yu wrote: On 2021/1/11 18:31, Chao Yu wrote: On 2021/1/11 17:48, Jaegeuk Kim wrote: Hi Chao, After quick test of fsstress w/ fault injection, it gave wrong block address errors. Could you please run the test a bit? Jaegeuk, Oh, I've covered with fstest cases and

[PATCH 1/2] arm64: dts: qcom: sm8250: Define CPU topology

2021-01-11 Thread Danny Lin
sm8250 has a big.LITTLE CPU setup with DynamIQ, so all cores are within the same CPU cluster and LLC (Last-Level Cache) domain. Define this topology to help the scheduler make decisions. Signed-off-by: Danny Lin --- arch/arm64/boot/dts/qcom/sm8250.dtsi | 36 1 file

[PATCH] arm64: dts: qcom: sdm660: Fix CPU capacities

2021-01-11 Thread Danny Lin
sdm660 has a big.LITTLE 4+4 CPU setup with CPUs 0-3 being little cores and CPUs 4-7 being big cores. The big cores have higher IPC, so they should have the higher capacity-dmips-mhz, not the other way around as the device tree currently describes it. Fix the incorrect CPU map to improve EAS

Re: [PATCH] lib/hexdump: introduce DUMP_PREFIX_UNHASHED for unhashed addresses

2021-01-11 Thread Andrew Morton
On Mon, 11 Jan 2021 11:10:56 +0100 Petr Mladek wrote: > Adding Kees into CC because it is security related. > Adding Andrew into CC because he usually takes patches for hexdump. > > On Wed 2021-01-06 15:35:47, Timur Tabi wrote: > > Hashed addresses are useless in hexdumps unless you're

Re: [PATCH] Fix whitespace in uapi/linux/tcp.h.

2021-01-11 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Fri, 8 Jan 2021 22:21:04 + you wrote: > From: Danilo Carvalho > > List of things fixed: > - Two of the socket options were idented with spaces instead of tabs. > - Trailing whitespace in some lines. > -

[PATCH -next] phy: mediatek: Mark mtk_mipi_tx_driver with static keyword

2021-01-11 Thread Zou Wei
Fix the following sparse warning: drivers/phy/mediatek/phy-mtk-mipi-dsi.c:237:24: warning: symbol 'mtk_mipi_tx_driver' was not declared. Should it be static? Signed-off-by: Zou Wei --- drivers/phy/mediatek/phy-mtk-mipi-dsi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH v2 1/1] mm/madvise: replace ptrace attach requirement for process_madvise

2021-01-11 Thread Andrew Morton
On Mon, 11 Jan 2021 09:06:22 -0800 Suren Baghdasaryan wrote: > process_madvise currently requires ptrace attach capability. > PTRACE_MODE_ATTACH gives one process complete control over another > process. It effectively removes the security boundary between the > two processes (in one direction).

Re: [PATCH] of: unittest: Statically apply overlays using fdtoverlay

2021-01-11 Thread Bill Mills
On 1/11/21 5:06 PM, Frank Rowand wrote: On 1/8/21 2:41 AM, Viresh Kumar wrote: Now that fdtoverlay is part of the kernel build, start using it to test the unitest overlays we have by applying them statically. The file overlay_base.dtb have symbols of its own and we need to apply overlay.dtb

Re: [PATCH v3 4/6] mm: hugetlb: add return -EAGAIN for dissolve_free_huge_page

2021-01-11 Thread Mike Kravetz
On 1/10/21 4:40 AM, Muchun Song wrote: > There is a race between dissolve_free_huge_page() and put_page(), > and the race window is quite small. Theoretically, we should return > -EBUSY when we encounter this race. In fact, we have a chance to > successfully dissolve the page if we do a retry.

Re: [PATCH v13 11/15] s390/vfio-ap: implement in-use callback for vfio_ap driver

2021-01-11 Thread Halil Pasic
On Tue, 22 Dec 2020 20:16:02 -0500 Tony Krowiak wrote: > Let's implement the callback to indicate when an APQN > is in use by the vfio_ap device driver. The callback is > invoked whenever a change to the apmask or aqmask would > result in one or more queue devices being removed from the driver.

Re: [PATCH 0/6] fs: deduplicate compat logic

2021-01-11 Thread Willem de Bruijn
On Mon, Jan 11, 2021 at 7:58 PM Al Viro wrote: > > On Mon, Jan 11, 2021 at 07:30:11PM -0500, Willem de Bruijn wrote: > > From: Willem de Bruijn > > > > Use in_compat_syscall() to differentiate compat handling exactly > > where needed, including in nested function calls. Then remove > >

[PATCH -next] media: ti-vpe: cal: Mark cal_camerarx_media_ops with static keyword

2021-01-11 Thread Zou Wei
Fix the following sparse warning: drivers/media/platform/ti-vpe/cal-camerarx.c:783:32: warning: symbol 'cal_camerarx_media_ops' was not declared. Should it be static? Signed-off-by: Zou Wei --- drivers/media/platform/ti-vpe/cal-camerarx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [PATCH v3] x86/entry: emit a symbol for register restoring thunk

2021-01-11 Thread Nick Desaulniers
On Mon, Jan 11, 2021 at 5:00 PM Borislav Petkov wrote: > > On Mon, Jan 11, 2021 at 04:41:52PM -0800, Fāng-ruì Sòng wrote: > > To be fair: we cannot use > > Who's "we"? > > > .L-prefixed local because of the objtool limitation. > > What objtool limitation? I thought clang's assembler removes .text

Re: [PATCH v2] powerpc/vdso: fix clock_gettime_fallback for vdso32

2021-01-11 Thread Michael Ellerman
Christophe Leroy writes: > From: Andreas Schwab > > The second argument of __kernel_clock_gettime64 points to a struct > __kernel_timespec, with 64-bit time_t, so use the clock_gettime64 syscall > in the fallback function for the 32-bit vdso. Similarily, > clock_getres_fallback should use the

Re: [PATCH v13 09/15] s390/vfio-ap: allow hot plug/unplug of AP resources using mdev device

2021-01-11 Thread Halil Pasic
On Tue, 22 Dec 2020 20:16:00 -0500 Tony Krowiak wrote: > Let's allow adapters, domains and control domains to be hot plugged into > and hot unplugged from a KVM guest using a matrix mdev when: > > * The adapter, domain or control domain is assigned to or unassigned from > the matrix mdev > >

Re: [RFC PATCH v3 16/16] MAINTAINERS: Add maintainers of the CXL driver

2021-01-11 Thread Joe Perches
On Mon, 2021-01-11 at 14:51 -0800, Ben Widawsky wrote: > diff --git a/MAINTAINERS b/MAINTAINERS [] > @@ -4459,6 +4459,16 @@ F: fs/configfs/ >  F: include/linux/configfs.h >  F: samples/configfs/ >   > +COMPUTE EXPRESS LINK (CXL) > +M: Vishal Verma > +M: Ira Weiny > +M: Ben Widawsky

Re: [PATCH v3 3/6] mm: hugetlb: fix a race between freeing and dissolving the page

2021-01-11 Thread Mike Kravetz
On 1/10/21 4:40 AM, Muchun Song wrote: > There is a race condition between __free_huge_page() > and dissolve_free_huge_page(). > > CPU0: CPU1: > > // page_count(page) == 1 > put_page(page) > __free_huge_page(page) >

Re: [PATCH v3] x86/entry: emit a symbol for register restoring thunk

2021-01-11 Thread Borislav Petkov
On Mon, Jan 11, 2021 at 04:41:52PM -0800, Fāng-ruì Sòng wrote: > To be fair: we cannot use Who's "we"? > .L-prefixed local because of the objtool limitation. What objtool limitation? I thought clang's assembler removes .text which objtool uses. It worked fine with GNU as so far. > The LLVM

Re: [PATCH 0/6] fs: deduplicate compat logic

2021-01-11 Thread Al Viro
On Mon, Jan 11, 2021 at 07:30:11PM -0500, Willem de Bruijn wrote: > From: Willem de Bruijn > > Use in_compat_syscall() to differentiate compat handling exactly > where needed, including in nested function calls. Then remove > duplicated code in callers. IMO it's a bad idea. Use of

Re: [PATCH v3 0/2] mm: fix initialization of struct page for holes in memory layout

2021-01-11 Thread Andrew Morton
On Mon, 11 Jan 2021 21:40:15 +0200 Mike Rapoport wrote: > Commit 73a6e474cb37 ("mm: memmap_init: iterate over > memblock regions rather that check each PFN") exposed several issues with > the memory map initialization and these patches fix those issues. > > Initially there were crashes during

Re: [PATCH net ] net: mvpp2: Remove Pause and Asym_Pause support

2021-01-11 Thread Jakub Kicinski
On Tue, 12 Jan 2021 01:47:27 +0100 Andrew Lunn wrote: > On Mon, Jan 11, 2021 at 04:36:53PM -0800, Jakub Kicinski wrote: > > On Sun, 10 Jan 2021 21:23:02 +0200 stef...@marvell.com wrote: > > > From: Stefan Chulski > > > > > > Packet Processor hardware not connected to MAC flow control unit and

Re: [PATCH V3 2/2] scripts: dtc: Build fdtoverlay and fdtdump tools

2021-01-11 Thread Frank Rowand
Hi Viresh, I may have an email hiccup, but I don't see a "[PATCH V3 1/2]" email, I only see this "V3 2/2" email. Please start each new version of a patch series as a stand alone email instead of a reply to an email in a previous version of the series. That way each patch series discussion stands

Re: [PATCH v5 mips-next 0/9] MIPS: vmlinux.lds.S sections fixes & cleanup

2021-01-11 Thread Thomas Bogendoerfer
On Mon, Jan 11, 2021 at 08:57:25PM +, Alexander Lobakin wrote: > From: Kees Cook > Date: Mon, 11 Jan 2021 11:53:39 -0800 > > > On Sun, Jan 10, 2021 at 11:53:50AM +, Alexander Lobakin wrote: > >> This series hunts the problems discovered after manual enabling of > >>

Re: 5.11-rc device reordering breaks ThinkPad rmi4 suspend

2021-01-11 Thread Saravana Kannan
On Mon, Jan 11, 2021 at 8:57 AM Rafael J. Wysocki wrote: > > On Mon, Jan 11, 2021 at 5:12 PM Thierry Reding wrote: > > > > On Mon, Jan 11, 2021 at 03:57:37PM +0100, Rafael J. Wysocki wrote: > > > On Mon, Jan 11, 2021 at 2:43 PM Thierry Reding wrote: > > > > > > > > On Sun, Jan 10, 2021 at

Re: [RFC PATCH 0/2] userfaultfd: handle minor faults, add UFFDIO_CONTINUE

2021-01-11 Thread Mike Kravetz
On 1/7/21 11:04 AM, Axel Rasmussen wrote: > Overview > > > This series adds a new userfaultfd registration mode, > UFFDIO_REGISTER_MODE_MINOR. This allows userspace to intercept "minor" faults. > By "minor" fault, I mean the following situation: > > Let there exist two mappings (i.e.,

Re: UBSAN: shift-out-of-bounds in kvm_vcpu_after_set_cpuid

2021-01-11 Thread Jim Mattson
It looks like userspace can possibly induce this by providing guest CPUID information with a "physical address width" of 64 in leaf 0x8008. Perhaps cpuid_query_maxphyaddr() should just look at the low 5 bits of CPUID.8008H:EAX? Better would be to return an error for out-of-range values,

Re: [PATCH 2/2] scsi: ufs: Remove unnecessary devm_kfree

2021-01-11 Thread Eric Biggers
On Mon, Jan 11, 2021 at 11:32:02PM +0100, Bean Huo wrote: > From: Bean Huo > > The memory allocated with devm_kzalloc() is freed automatically > no need to explicitly call devm_kfree. > > Signed-off-by: Bean Huo > --- > drivers/scsi/ufs/ufshcd-crypto.c | 4 +--- > 1 file changed, 1

Re: [PATCH bpf-next 2/4] selftests/bpf: add non-BPF_LSM test for task local storage

2021-01-11 Thread Song Liu
> On Jan 11, 2021, at 9:30 AM, Yonghong Song wrote: > > > > On 1/8/21 3:19 PM, Song Liu wrote: >> Task local storage is enabled for tracing programs. Add a test for it >> without CONFIG_BPF_LSM. >> Signed-off-by: Song Liu >> --- >> .../bpf/prog_tests/test_task_local_storage.c | 34

Re: [PATCH -tip V3 0/8] workqueue: break affinity initiatively

2021-01-11 Thread Valentin Schneider
On 11/01/21 21:23, Peter Zijlstra wrote: > On Mon, Jan 11, 2021 at 07:21:06PM +, Valentin Schneider wrote: >> I'm less fond of the workqueue pcpu flag toggling, but it gets us what >> we want: allow those threads to run on !active CPUs during online, but >> move them away before !online during

Re: [PATCH bpf-next 2/4] selftests/bpf: add non-BPF_LSM test for task local storage

2021-01-11 Thread Song Liu
> On Jan 11, 2021, at 9:44 AM, KP Singh wrote: > > On Mon, Jan 11, 2021 at 6:31 PM Yonghong Song wrote: >> >> >> >> On 1/8/21 3:19 PM, Song Liu wrote: >>> Task local storage is enabled for tracing programs. Add a test for it >>> without CONFIG_BPF_LSM. > > Can you also explain what the

Re: [PATCH v13 07/15] s390/vfio-ap: introduce shadow APCB

2021-01-11 Thread Halil Pasic
On Tue, 22 Dec 2020 20:15:58 -0500 Tony Krowiak wrote: > The APCB is a field within the CRYCB that provides the AP configuration > to a KVM guest. Let's introduce a shadow copy of the KVM guest's APCB and > maintain it for the lifespan of the guest. > > Signed-off-by: Tony Krowiak >

[RFC PATCH v3 00/16] CXL 2.0 Support

2021-01-11 Thread Ben Widawsky
Changes since v2 [1] - Rebased onto v5.11-rc2 - fixes for sparse (Ben) - Add (and modify) IOCTL number to ioctl-number.rst. (Randy) - Change @enable to @flags with enable field. (Dan) - Move command "name" to UAPI enum. (Dan) - Make command array use designated initializer. (Dan) -

[RFC PATCH v3 03/16] cxl/acpi: add OSC support

2021-01-11 Thread Ben Widawsky
From: Vishal Verma Add support to advertise OS capabilities, and request OS control for CXL features using the ACPI _OSC mechanism. Advertise support for all possible CXL features, and attempt to request control for all possible features. Based on a patch by Sean Kelley. Signed-off-by: Vishal

[RFC PATCH v3 02/16] cxl/acpi: Add an acpi_cxl module for the CXL interconnect

2021-01-11 Thread Ben Widawsky
From: Vishal Verma Add an acpi_cxl module to coordinate the ACPI portions of the CXL (Compute eXpress Link) interconnect. This driver binds to ACPI0017 objects in the ACPI tree, and coordinates access to the resources provided by the ACPI CEDT (CXL Early Discovery Table). It also coordinates

[RFC PATCH v3 01/16] docs: cxl: Add basic documentation

2021-01-11 Thread Ben Widawsky
This starts a new cxl directory because CXL is a new bus and it is expected that the documentation will grow large over time. Currently only memory devices are documented as they are all that's supported. Signed-off-by: Ben Widawsky --- Documentation/cxl/index.rst | 12

[RFC PATCH v3 04/16] cxl/mem: Introduce a driver for CXL-2.0-Type-3 endpoints

2021-01-11 Thread Ben Widawsky
From: Dan Williams The CXL.mem protocol allows a device to act as a provider of "System RAM" and/or "Persistent Memory" that is fully coherent as if the memory was attached to the typical CPU memory controller. With the CXL-2.0 specification a PCI endpoint can implement a "Type-3" device

[RFC PATCH v3 06/16] cxl/mem: Find device capabilities

2021-01-11 Thread Ben Widawsky
CXL devices contain an array of capabilities that describe the interactions software can have with the device or firmware running on the device. A CXL compliant device must implement the device status and the mailbox capability. A CXL compliant memory device must implement the memory device

[RFC PATCH v3 05/16] cxl/mem: Map memory device registers

2021-01-11 Thread Ben Widawsky
All the necessary bits are initialized in order to find and map the register space for CXL Memory Devices. This is accomplished by using the Register Locator DVSEC (CXL 2.0 - 8.1.9.1) to determine which PCI BAR to use, and how much of an offset from that BAR should be added. If the memory device

[RFC PATCH v3 14/16] cxl/mem: Use CEL for enabling commands

2021-01-11 Thread Ben Widawsky
The Command Effects Log (CEL) is specified in the CXL 2.0 specification. The CEL is one of two types of logs, the other being vendor specific. They are distinguished in hardware/spec via UUID. The CEL is immediately useful for 2 things: 1. Determine which optional commands are supported by the CXL

[RFC PATCH v3 07/16] cxl/mem: Implement polled mode mailbox

2021-01-11 Thread Ben Widawsky
Provide enough functionality to utilize the mailbox of a memory device. The mailbox is used to interact with the firmware running on the memory device. The CXL specification defines separate capabilities for the mailbox and the memory device. While we can confirm the mailbox is ready, in order to

[RFC PATCH v3 13/16] cxl/mem: Create concept of enabled commands

2021-01-11 Thread Ben Widawsky
CXL devices must implement the Device Command Interface (described in 8.2.9 of the CXL 2.0 spec). While the driver already maintains a list of commands it supports, there is still a need to be able to distinguish between commands that the driver knows about from commands that may not be supported

[RFC PATCH v3 12/16] cxl/mem: Add a "RAW" send command

2021-01-11 Thread Ben Widawsky
The CXL memory device send interface will have a number of supported commands. The raw command is not such a command. Raw commands allow userspace to send a specified opcode to the underlying hardware and bypass all driver checks on the command. This is useful for a couple of usecases, mainly: 1.

[RFC PATCH v3 09/16] cxl/mem: Add basic IOCTL interface

2021-01-11 Thread Ben Widawsky
Add a straightforward IOCTL that provides a mechanism for userspace to query the supported memory device commands. CXL commands as they appear to userspace are described as part of the UAPI kerneldoc. The command list returned via this IOCTL will contain the full set of commands that the driver

[RFC PATCH v3 10/16] cxl/mem: Add send command

2021-01-11 Thread Ben Widawsky
The send command allows userspace to issue mailbox commands directly to the hardware. The driver will verify basic properties of the command and possible inspect the input (or output) payload to determine whether or not the command is allowed (or might taint the kernel). The list of allowed

[RFC PATCH v3 08/16] cxl/mem: Register CXL memX devices

2021-01-11 Thread Ben Widawsky
From: Dan Williams Create the /sys/bus/cxl hierarchy to enumerate memory devices (per-endpoint control devices), memory address space devices (platform address ranges with interleaving, performance, and persistence attributes), and memory regions (active provisioned memory from an address space

[RFC PATCH v3 11/16] taint: add taint for unfettered hardware access

2021-01-11 Thread Ben Widawsky
Make notes about why we use this. Signed-off-by: Ben Widawsky --- Documentation/admin-guide/sysctl/kernel.rst | 1 + Documentation/admin-guide/tainted-kernels.rst | 6 +- include/linux/kernel.h| 3 ++- kernel/panic.c| 1 + 4 files

[RFC PATCH v3 11/16] taint: add taint for direct hardware access

2021-01-11 Thread Ben Widawsky
For drivers that moderate access to the underlying hardware it is sometimes desirable to allow userspace to bypass restrictions. Once userspace has done this, the driver can no longer guarantee the sanctity of either the OS or the hardware. When in this state, it is helpful for kernel developers

[RFC PATCH v3 15/16] cxl/mem: Add limited Get Log command (0401h)

2021-01-11 Thread Ben Widawsky
The Get Log command returns the actual log entries that are advertised via the Get Supported Logs command (0400h). CXL device logs are selected by UUID which is part of the CXL spec. Because the driver tries to sanitize what is sent to hardware, there becomes a need to restrict the types of logs

Re: [PATCH bpf-next 4/4] bpf: runqslower: use task local storage

2021-01-11 Thread Song Liu
> On Jan 11, 2021, at 9:49 AM, Yonghong Song wrote: > > > > On 1/8/21 3:19 PM, Song Liu wrote: >> Replace hashtab with task local storage in runqslower. This improves the >> performance of these BPF programs. The following table summarizes average >> runtime of these programs, in

[RFC PATCH v3 16/16] MAINTAINERS: Add maintainers of the CXL driver

2021-01-11 Thread Ben Widawsky
Cc: Dan Williams Cc: Vishal Verma Cc: Ira Weiny Signed-off-by: Ben Widawsky --- MAINTAINERS | 10 ++ 1 file changed, 10 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 6eff4f720c72..70c7ec4b2921 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -4459,6 +4459,16 @@ F:

Re: [PATCH] xen/privcmd: allow fetching resource sizes

2021-01-11 Thread Andrew Cooper
On 11/01/2021 22:09, boris.ostrov...@oracle.com wrote: > On 1/11/21 10:29 AM, Roger Pau Monne wrote: >> >> +xdata.domid = kdata.dom; >> +xdata.type = kdata.type; >> +xdata.id = kdata.id; >> + >> +if (!kdata.addr && !kdata.num) { > > I think we should not allow only one of them to

Re: [PATCH v13 08/15] s390/vfio-ap: sysfs attribute to display the guest's matrix

2021-01-11 Thread Halil Pasic
On Tue, 22 Dec 2020 20:15:59 -0500 Tony Krowiak wrote: > The matrix of adapters and domains configured in a guest's APCB may > differ from the matrix of adapters and domains assigned to the matrix mdev, > so this patch introduces a sysfs attribute to display the matrix of > adapters and domains

Re: UBSAN: shift-out-of-bounds in kvm_vcpu_after_set_cpuid

2021-01-11 Thread Sean Christopherson
On Mon, Jan 11, 2021, Jim Mattson wrote: > It looks like userspace can possibly induce this by providing guest > CPUID information with a "physical address width" of 64 in leaf > 0x8008. It was actually the opposite, where userspace provides '0' and caused '63 - 0 + 1' to overflow. KVM

Re: linux-next: Fixes tag needs some work in the spi tree

2021-01-11 Thread Mark Brown
On Tue, Jan 12, 2021 at 02:28:12AM +0530, Pratyush Yadav wrote: > I meant this one. My mistake. Copied the wrong hash. Any way to fix this > now? Not without rebasing which I generally avoid. signature.asc Description: PGP signature

Re: [RFC PATCH] tracing: Merge irqflags + preemt counter, add RT bits

2021-01-11 Thread Steven Rostedt
On Wed, 16 Dec 2020 18:22:05 +0100 Sebastian Andrzej Siewior wrote: > PREEMPT_RT never reported "serving softirq". I took a look to see if it > could be changed. The tracing infrastructure examinates the preemtion "preemption" > counter

Re: [PATCH v3 2/6] mm: hugetlbfs: fix cannot migrate the fallocated HugeTLB page

2021-01-11 Thread Mike Kravetz
On 1/10/21 4:40 AM, Muchun Song wrote: > If a new hugetlb page is allocated during fallocate it will not be > marked as active (set_page_huge_active) which will result in a later > isolate_huge_page failure when the page migration code would like to > move that page. Such a failure would be

[PATCH v17 04/26] x86/cpufeatures: Introduce X86_FEATURE_CET and setup functions

2021-01-11 Thread Yu-cheng Yu
Introduce a software-defined X86_FEATURE_CET, which indicates either Shadow Stack or Indirect Branch Tracking (or both) is present. Also introduce related cpu init/setup functions. Signed-off-by: Yu-cheng Yu --- arch/x86/include/asm/cpufeatures.h | 2 +-

Re: [RFC PATCH 0/2] userfaultfd: handle minor faults, add UFFDIO_CONTINUE

2021-01-11 Thread Peter Xu
On Mon, Jan 11, 2021 at 02:42:48PM -0800, Mike Kravetz wrote: > On 1/7/21 11:04 AM, Axel Rasmussen wrote: > > Overview > > > > > > This series adds a new userfaultfd registration mode, > > UFFDIO_REGISTER_MODE_MINOR. This allows userspace to intercept "minor" > > faults. > > By "minor"

Re: Old platforms: bring out your dead

2021-01-11 Thread chase rayfield
> Sparc has a runtime relocation I've never understood but did manage to break > once, resulting in a long thread to fix: > > http://lists.landley.net/pipermail/aboriginal-landley.net/2011-December/001964.html > > Between that and the weird save half the stack register thing with function > calls

[PATCH v4 01/21] ibmvfc: add vhost fields and defaults for MQ enablement

2021-01-11 Thread Tyrel Datwyler
Introduce several new vhost fields for managing MQ state of the adapter as well as initial defaults for MQ enablement. Signed-off-by: Tyrel Datwyler --- drivers/scsi/ibmvscsi/ibmvfc.c | 8 drivers/scsi/ibmvscsi/ibmvfc.h | 9 + 2 files changed, 17 insertions(+) diff --git

[PATCH v2 0/2] Remove unnecessary devm_kfree

2021-01-11 Thread Bean Huo
From: Bean Huo Changelog: V1-V2: 1. Remove unused variable i in patch 1/2 2. Add Eric Biggers review tag in patch 2/2 Bean Huo (2): scsi: hisi_sas: Remove unnecessary devm_kfree scsi: ufs: Remove unnecessary devm_kfree drivers/scsi/hisi_sas/hisi_sas_v3_hw.c | 28

[PATCH v2 1/2] scsi: hisi_sas: Remove unnecessary devm_kfree

2021-01-11 Thread Bean Huo
From: Bean Huo The memory allocated with devm_kzalloc() is freed automatically no need to explicitly call devm_kfree. Signed-off-by: Bean Huo --- drivers/scsi/hisi_sas/hisi_sas_v3_hw.c | 28 +- 1 file changed, 1 insertion(+), 27 deletions(-) diff --git

[PATCH v4 06/21] ibmvfc: add Subordinate CRQ definitions

2021-01-11 Thread Tyrel Datwyler
Subordinate Command Response Queues (Sub CRQ) are used in conjunction with the primary CRQ when more than one queue is needed by the virtual IO adapter. Recent phyp firmware versions support Sub CRQ's with ibmvfc adapters. This feature is a prerequisite for supporting multiple hardware backed

[PATCH v4 00/21] ibmvfc: initial MQ development

2021-01-11 Thread Tyrel Datwyler
Recent updates in pHyp Firmware and VIOS releases provide new infrastructure towards enabling Subordinate Command Response Queues (Sub-CRQs) such that each Sub-CRQ is a channel backed by an actual hardware queue in the FC stack on the partner VIOS. Sub-CRQs are registered with the firmware via

[PATCH v2 2/2] scsi: ufs: Remove unnecessary devm_kfree

2021-01-11 Thread Bean Huo
From: Bean Huo The memory allocated with devm_kzalloc() is freed automatically no need to explicitly call devm_kfree. Reviewed-by: Eric Biggers Signed-off-by: Bean Huo --- drivers/scsi/ufs/ufshcd-crypto.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git

[PATCH v4 12/21] ibmvfc: implement channel enquiry and setup commands

2021-01-11 Thread Tyrel Datwyler
New NPIV_ENQUIRY_CHANNEL and NPIV_SETUP_CHANNEL management datagrams (MADs) were defined in a previous patchset. If the client advertises a desire to use channels and the partner VIOS is channel capable then the client must proceed with channel enquiry to determine the maximum number of channels

[PATCH v4 10/21] ibmvfc: define Sub-CRQ interrupt handler routine

2021-01-11 Thread Tyrel Datwyler
Simple handler that calls Sub-CRQ drain routine directly. Signed-off-by: Tyrel Datwyler --- drivers/scsi/ibmvscsi/ibmvfc.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/scsi/ibmvscsi/ibmvfc.c b/drivers/scsi/ibmvscsi/ibmvfc.c index f3cd092478ee..51bcafad9490 100644 ---

[PATCH v4 03/21] ibmvfc: init/free event pool during queue allocation/free

2021-01-11 Thread Tyrel Datwyler
The event pool and CRQ used to be separate entities of the adapter host structure and as such were allocated and freed independently of each other. Recent work as defined a generic queue structure with an event pool specific to each queue. As such the event pool for each queue shouldn't be

Re: [PATCH net-next] net: marvell: prestera: Correct typo

2021-01-11 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Fri, 8 Jan 2021 21:06:22 -0800 you wrote: > The function was incorrectly named with a trailing 'r' at the end of > prestera. > > Signed-off-by: Florian Fainelli > --- > Jakub, David, > > [...] Here is the summary

[PATCH v4 05/21] ibmvfc: define hcall wrapper for registering a Sub-CRQ

2021-01-11 Thread Tyrel Datwyler
Sub-CRQs are registred with firmware via a hypercall. Abstract that interface into a simpler helper function. Signed-off-by: Tyrel Datwyler --- drivers/scsi/ibmvscsi/ibmvfc.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/drivers/scsi/ibmvscsi/ibmvfc.c

[PATCH v4 14/21] ibmvfc: set and track hw queue in ibmvfc_event struct

2021-01-11 Thread Tyrel Datwyler
Extract the hwq id from a SCSI command and store it in the ibmvfc_event structure to identify which Sub-CRQ to send the command down when channels are being utilized. Signed-off-by: Tyrel Datwyler --- drivers/scsi/ibmvscsi/ibmvfc.c | 5 + drivers/scsi/ibmvscsi/ibmvfc.h | 1 + 2 files

[PATCH v4 09/21] ibmvfc: add handlers to drain and complete Sub-CRQ responses

2021-01-11 Thread Tyrel Datwyler
The logic for iterating over the Sub-CRQ responses is similiar to that of the primary CRQ. Add the necessary handlers for processing those responses. Signed-off-by: Tyrel Datwyler --- drivers/scsi/ibmvscsi/ibmvfc.c | 86 ++ 1 file changed, 86 insertions(+) diff

SLUB: percpu partial object count is highly inaccurate, causing some memory wastage and maybe also worse tail latencies?

2021-01-11 Thread Jann Horn
[This is not something I intend to work on myself. But since I stumbled over this issue, I figured I should at least document/report it, in case anyone is willing to pick it up.] Hi! I was poking around in SLUB internals and noticed that the estimate of how many free objects exist on a percpu

[PATCH v4 02/21] ibmvfc: move event pool init/free routines

2021-01-11 Thread Tyrel Datwyler
The next patch in this series reworks the event pool allocation calls to happen within the individual queue allocation routines instead of as independent calls. Move the init/free routines earlier in ibmvfc.c to prevent undefined reference errors when calling these functions from the queue

[PATCH v4 13/21] ibmvfc: advertise client support for using hardware channels

2021-01-11 Thread Tyrel Datwyler
Previous patches have plumbed the necessary Sub-CRQ interface and channel negotiation MADs to fully channelize via hardware backed queues. Advertise client support via NPIV Login capability IBMVFC_CAN_USE_CHANNELS when the client bits have MQ enabled via vhost->mq_enabled, or when channels were

[PATCH v4 19/21] ibmvfc: purge scsi channels after transport loss/reset

2021-01-11 Thread Tyrel Datwyler
Grab the queue and list lock for each Sub-CRQ and add any uncompleted events to the host purge list. Signed-off-by: Tyrel Datwyler --- drivers/scsi/ibmvscsi/ibmvfc.c | 16 1 file changed, 16 insertions(+) diff --git a/drivers/scsi/ibmvscsi/ibmvfc.c

[PATCH v4 17/21] ibmvfc: add cancel mad initialization helper

2021-01-11 Thread Tyrel Datwyler
Add a helper routine for initializing a Cancel MAD. This will be useful for a channelized client that needs to send Cancel commands down every channel commands were sent for a particular LUN. Signed-off-by: Tyrel Datwyler --- drivers/scsi/ibmvscsi/ibmvfc.c | 68

Re: [PATCH 1/6] thermal/core: Remove the 'forced_passive' option

2021-01-11 Thread Thara Gopinath
On 12/14/20 6:38 PM, Daniel Lezcano wrote: The code was reorganized in 2012 with the commit 0c01ebbfd3caf1. The main change is a loop on the trip points array and a unconditional call to the throttle() ops of the governors for each of them even if the trip temperature is not reached yet.

[PATCH v4 20/21] ibmvfc: enable MQ and set reasonable defaults

2021-01-11 Thread Tyrel Datwyler
Turn on MQ by default and set sane values for the upper limit on hw queues for the scsi host, and number of hw scsi channels to request from the partner VIOS. Signed-off-by: Tyrel Datwyler --- drivers/scsi/ibmvscsi/ibmvfc.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

[PATCH v4 21/21] ibmvfc: provide modules parameters for MQ settings

2021-01-11 Thread Tyrel Datwyler
Add the various module parameter toggles for adjusting the MQ characteristics at boot/load time as well as a device attribute for changing the client scsi channel request amount. Signed-off-by: Tyrel Datwyler --- drivers/scsi/ibmvscsi/ibmvfc.c | 75 ++ 1 file

[PATCH v4 18/21] ibmvfc: send Cancel MAD down each hw scsi channel

2021-01-11 Thread Tyrel Datwyler
In general the client needs to send Cancel MADs and task management commands down the same channel as the command(s) intended to cancel or abort. The client assigns cancel keys per LUN and thus must send a Cancel down each channel commands were submitted for that LUN. Further, the client then must

[PATCH v4 16/21] ibmvfc: register Sub-CRQ handles with VIOS during channel setup

2021-01-11 Thread Tyrel Datwyler
If the ibmvfc client adapter requests channels it must submit a number of Sub-CRQ handles matching the number of channels being requested. The VIOS in its response will overwrite the actual number of channel resources allocated which may be less than what was requested. The client then must store

[PATCH v4 08/21] ibmvfc: add Sub-CRQ IRQ enable/disable routine

2021-01-11 Thread Tyrel Datwyler
Each Sub-CRQ has its own interrupt. A hypercall is required to toggle the IRQ state. Provide the necessary mechanism via a helper function. Signed-off-by: Tyrel Datwyler --- drivers/scsi/ibmvscsi/ibmvfc.c | 20 1 file changed, 20 insertions(+) diff --git

[PATCH v4 11/21] ibmvfc: map/request irq and register Sub-CRQ interrupt handler

2021-01-11 Thread Tyrel Datwyler
Create an irq mapping for the hw_irq number provided from phyp firmware. Request an irq assigned our Sub-CRQ interrupt handler. Unmap these irqs at Sub-CRQ teardown. Signed-off-by: Tyrel Datwyler --- drivers/scsi/ibmvscsi/ibmvfc.c | 25 + 1 file changed, 25 insertions(+)

Re: [PATCH] net: macb: Add default usrio config to default gem config

2021-01-11 Thread Jakub Kicinski
On Mon, 11 Jan 2021 11:55:53 -0800 Atish Patra wrote: > There is no usrio config defined for default gem config leading to > a kernel panic devices that don't define a data. This issue can be > reprdouced with microchip polar fire soc where compatible string > is defined as "cdns,macb". > >

[PATCH v4 15/21] ibmvfc: send commands down HW Sub-CRQ when channelized

2021-01-11 Thread Tyrel Datwyler
When the client has negotiated the use of channels all vfcFrames are required to go down a Sub-CRQ channel or it is a protocoal violation. If the adapter state is channelized submit vfcFrames to the appropriate Sub-CRQ via the h_send_sub_crq() helper. Signed-off-by: Tyrel Datwyler ---

[PATCH v4 07/21] ibmvfc: add alloc/dealloc routines for SCSI Sub-CRQ Channels

2021-01-11 Thread Tyrel Datwyler
Allocate a set of Sub-CRQs in advance. During channel setup the client and VIOS negotiate the number of queues the VIOS supports and the number that the client desires to request. Its possible that the final channel resources allocated is less than requested, but the client is still responsible

[PATCH v4 04/21] ibmvfc: add size parameter to ibmvfc_init_event_pool

2021-01-11 Thread Tyrel Datwyler
With the upcoming addition of Sub-CRQs the event pool size may vary per-queue. Add a size parameter to ibmvfc_init_event_pool such that different size event pools can be requested by ibmvfc_alloc_queue. Signed-off-by: Tyrel Datwyler --- drivers/scsi/ibmvscsi/ibmvfc.c | 25

[tip:x86/cache] BUILD SUCCESS 6d3b47ddffed70006cf4ba360eef61e9ce097d8f

2021-01-11 Thread kernel test robot
i386defconfig powerpc allyesconfig powerpc allmodconfig powerpc allnoconfig x86_64 randconfig-a004-20210111 x86_64 randconfig-a006-20210111 x86_64

Re: [PATCH v0 net-next 1/1] Allow user to set metric on default route learned via Router Advertisement.

2021-01-11 Thread Jakub Kicinski
On Mon, 11 Jan 2021 13:58:29 -0800 Praveen Chaudhary wrote: > For IPv4, default route is learned via DHCPv4 and user is allowed to change > metric using config etc/network/interfaces. But for IPv6, default route can > be learned via RA, for which, currently a fixed metric value 1024 is used. > >

Re: [PATCH 2/6] thermal/core: Remove unused functions rebind/unbind exception

2021-01-11 Thread Thara Gopinath
On 12/14/20 6:38 PM, Daniel Lezcano wrote: The functions thermal_zone_device_rebind_exception and thermal_zone_device_unbind_exception are not used from anywhere. Remove that code. Signed-off-by: Daniel Lezcano Reviewed-by: Thara Gopinath --- drivers/thermal/thermal_core.c | 37

Re: [PATCH bpf-next 1/4] bpf: enable task local storage for tracing programs

2021-01-11 Thread Song Liu
> On Jan 11, 2021, at 2:14 AM, KP Singh wrote: > > On Sat, Jan 9, 2021 at 12:35 AM Song Liu wrote: >> >> To access per-task data, BPF program typically creates a hash table with >> pid as the key. This is not ideal because: >> 1. The use need to estimate requires size of the hash table,

Re: [PATCH 3/6] thermal/core: Remove pointless test with the THERMAL_TRIPS_NONE macro

2021-01-11 Thread Thara Gopinath
On 12/14/20 6:38 PM, Daniel Lezcano wrote: The THERMAL_TRIPS_NONE is equal to -1, it is pointless to do a conversion in this function. It is pointless because you have removed force_passive and will be removing THERMAL_TRIPS_NONE in the following patches. Maybe that should be mentioned in

Re: [PATCH net ] net: mvpp2: Remove Pause and Asym_Pause support

2021-01-11 Thread Andrew Lunn
On Mon, Jan 11, 2021 at 04:36:53PM -0800, Jakub Kicinski wrote: > On Sun, 10 Jan 2021 21:23:02 +0200 stef...@marvell.com wrote: > > From: Stefan Chulski > > > > Packet Processor hardware not connected to MAC flow control unit and > > cannot support TX flow control. > > This patch disable flow

<    1   2   3   4   5   6   7   8   9   10   >