Re: [PATCH] mm: cma: support sysfs

2021-02-04 Thread John Hubbard
On 2/4/21 4:12 PM, Minchan Kim wrote: ... Then, how to know how often CMA API failed? Why would you even need to know that, *in addition* to knowing specific page allocation numbers that failed? Again, there is no real-world motivation cited yet, just "this is good data". Need more stories and

Re: [PATCH] ARM: kexec: Fix panic after TLB are invalidated

2021-02-04 Thread Russell King - ARM Linux admin
On Thu, Feb 04, 2021 at 11:48:42PM +, Giancarlo Ferrari wrote: > Can I ask about having it integrated ? Thanks for testing. Are you willing for me to add: Tested-by: Giancarlo Ferrari to the commit log? I can move it into the fixes branch which I want to send to Linus by Saturday at the

Re: [PATCH v2 2/2] dmabuf: Add dmabuf inode number to /proc/*/fdinfo

2021-02-04 Thread Randy Dunlap
On 2/4/21 3:28 PM, Kalesh Singh wrote: > If a FD refers to a DMA buffer add the DMA buffer inode number to > /proc//fdinfo/ and /proc//task//fdindo/. > > The dmabuf inode number allows userspace to uniquely identify the buffer > and avoids a dependency on /proc//fd/* when accounting per-process >

Re: [PATCH] mm: cma: support sysfs

2021-02-04 Thread Minchan Kim
On Thu, Feb 04, 2021 at 03:14:56PM -0800, John Hubbard wrote: > On 2/4/21 12:07 PM, Minchan Kim wrote: > > On Thu, Feb 04, 2021 at 12:50:58AM -0800, John Hubbard wrote: > > > On 2/3/21 7:50 AM, Minchan Kim wrote: > > > > Since CMA is getting used more widely, it's more important to > > > > keep

Re: [PATCH 1/2] x86/hw_breakpoint: Prevent data breakpoints on __per_cpu_offset

2021-02-04 Thread Andy Lutomirski
On Thu, Feb 4, 2021 at 6:26 AM Lai Jiangshan wrote: > > From: Lai Jiangshan > > When FSGSBASE is enabled, paranoid_entry() fetches the per-CPU > GSBASE value via __per_cpu_offset or pcpu_unit_offsets. > > When data breakpoint is set on __per_cpu_offset[cpu] (read-write > operation), the specific

Re: [RFC][PATCH 2/2] x86: add extra serialization for non-serializing MSRs

2021-02-04 Thread Andy Lutomirski
On Thu, Feb 4, 2021 at 3:37 PM Andrew Cooper wrote: > > On 05/03/2020 17:47, Dave Hansen wrote: > > Jan Kiszka reported that the x2apic_wrmsr_fence() function uses a > > plain "mfence" while the Intel SDM (10.12.3 MSR Access in x2APIC > > Mode) calls for "mfence;lfence". > > > > Short summary: we

Re: [PATCH v19 06/25] x86/cet: Add control-protection fault handler

2021-02-04 Thread Yu, Yu-cheng
On 2/4/2021 12:09 PM, Kees Cook wrote: On Wed, Feb 03, 2021 at 02:55:28PM -0800, Yu-cheng Yu wrote: [...] diff --git a/arch/x86/kernel/traps.c b/arch/x86/kernel/traps.c index 7f5aec758f0e..f5354c35df32 100644 --- a/arch/x86/kernel/traps.c +++ b/arch/x86/kernel/traps.c @@ -606,6 +606,66 @@

Re: [PATCH v5 05/11] crypto: qce: skcipher: Return error for zero length messages

2021-02-04 Thread Thara Gopinath
Hi Eric, On 2/4/21 5:48 PM, Eric Biggers wrote: On Thu, Feb 04, 2021 at 04:43:53PM -0500, Thara Gopinath wrote: Crypto engine BAM dma does not support 0 length data. Return unsupported if zero length messages are passed for transformation. Signed-off-by: Thara Gopinath ---

Re: [RFC PATCH v2] taskstats: add /proc/taskstats to fetch pid/tgid status

2021-02-04 Thread Balbir Singh
On Thu, Feb 04, 2021 at 10:37:20PM +0800, Weiping Zhang wrote: > On Thu, Feb 4, 2021 at 6:20 PM Balbir Singh wrote: > > > > On Sun, Jan 31, 2021 at 05:16:47PM +0800, Weiping Zhang wrote: > > > On Wed, Jan 27, 2021 at 7:13 PM Balbir Singh > > > wrote: > > > > > > > > On Fri, Jan 22, 2021 at

Re: [PATCH] x86: efi: avoid BUILD_BUG_ON() for non-constant p4d_index

2021-02-04 Thread Arvind Sankar
On Thu, Feb 04, 2021 at 11:13:18PM +0100, Borislav Petkov wrote: > On Thu, Feb 04, 2021 at 04:43:58PM -0500, Arvind Sankar wrote: > > This should check EFI_VA_END instead of EFI_VA_START, and maybe throw in > > a BUG_ON if EFI_VA_END >= EFI_VA_START. > > No need: > > if (efi_va <

Re: [GIT PULL] PCI fixes for v5.11

2021-02-04 Thread pr-tracker-bot
The pull request you sent on Thu, 4 Feb 2021 17:00:58 -0600: > git://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git > pci-v5.11-fixes-2 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/dd86e7fa07a3ec33c92c957ea7b642c4702516a0 Thank you! -- Deet-doot-dot, I

Re: [PATCH] drm/msm/disp/mdp5: mdp5_cfg: Fix msm8974v2 max_clk

2021-02-04 Thread abhinavk
On 2021-02-03 15:15, Konrad Dybcio wrote: The maximum mdp clock rate on msm8974v2 is 320MHz. Fix it. Signed-off-by: Konrad Dybcio Reviewed-by: Abhinav Kumar --- drivers/gpu/drm/msm/disp/mdp5/mdp5_cfg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH v19 02/25] x86/cet/shstk: Add Kconfig option for user-mode control-flow protection

2021-02-04 Thread Yu, Yu-cheng
On 2/4/2021 11:56 AM, Kees Cook wrote: On Wed, Feb 03, 2021 at 02:55:24PM -0800, Yu-cheng Yu wrote: Shadow Stack provides protection against function return address corruption. It is active when the processor supports it, the kernel has CONFIG_X86_CET enabled, and the application is built for

Re: [PATCH v5 0/3] Kbuild: DWARF v5 support

2021-02-04 Thread Nick Desaulniers
Moving a bunch of folks + lists to BCC. On Thu, Feb 4, 2021 at 3:54 PM Andrii Nakryiko wrote: > > On Wed, Feb 3, 2021 at 7:13 PM Nick Desaulniers > wrote: > > > > On Wed, Feb 3, 2021 at 6:58 PM Andrii Nakryiko > > wrote: > > > > > > On Wed, Feb 3, 2021 at 5:31 PM Nick Desaulniers > > >

Re: [PATCH] KVM: VMX: Optimize flushing the PML buffer

2021-02-04 Thread Ben Gardon
On Thu, Feb 4, 2021 at 2:51 PM Peter Xu wrote: > > Hi, Ben, > > On Thu, Feb 04, 2021 at 02:19:59PM -0800, Ben Gardon wrote: > > The average time for each run demonstrated a strange bimodal distribution, > > with clusters around 2 seconds and 2.5 seconds. This may have been a > > result of vCPU

Re: ANNOUNCE: pahole v1.20 (gcc11 DWARF5's default, lots of ELF sections, BTF)

2021-02-04 Thread Andrii Nakryiko
On Thu, Feb 4, 2021 at 2:09 PM Arnaldo Carvalho de Melo wrote: > > Hi, > > The v1.20 release of pahole and its friends is out, mostly > addressing problems related to gcc 11 defaulting to DWARF5 for -g, > available at the usual places: Great, thanks, Arnaldo! Do you plan to build RPMs

Re: [PATCH v6 3/3] dt-bindings: input: Fix the keymap for LOCK key

2021-02-04 Thread Philip Chen
Hi maintainers, Friendly ping - can we actually land patch series v6? Or do you expect any update from me? On Fri, Jan 15, 2021 at 2:39 PM Stephen Boyd wrote: > > Quoting Philip Chen (2021-01-15 14:36:17) > > Decouple LOCK from F13 and directly map the LOCK key (KSI3/KSO9) to > > KEY_SLEEP

Re: [PATCH v7 2/2] Input: cros-ec-keyb - Expose function row physical map to userspace

2021-02-04 Thread Philip Chen
Hi maintainers, Friendly ping - can we actually land patch series v7? Or do you expect any update from me? On Fri, Jan 15, 2021 at 12:34 PM Stephen Boyd wrote: > > Quoting Philip Chen (2021-01-15 12:24:30) > > The top-row keys in a keyboard usually have dual functionalities. > > E.g. A function

Re: [PATCH 05/18] tty: serial: samsung_tty: add support for Apple UARTs

2021-02-04 Thread kernel test robot
Hi Hector, I love your patch! Perhaps something to improve: [auto build test WARNING on arm64/for-next/core] [also build test WARNING on robh/for-next linus/master v5.11-rc6 next-20210125] [cannot apply to tip/irq/core] [If your patch is applied to the wrong git tree, kindly drop us a note. And

Re: [PATCH v5 0/3] Kbuild: DWARF v5 support

2021-02-04 Thread Andrii Nakryiko
On Wed, Feb 3, 2021 at 7:13 PM Nick Desaulniers wrote: > > On Wed, Feb 3, 2021 at 6:58 PM Andrii Nakryiko > wrote: > > > > On Wed, Feb 3, 2021 at 5:31 PM Nick Desaulniers > > wrote: > > > > > > On Sun, Jan 17, 2021 at 12:14 PM Arnaldo Carvalho de Melo > > > wrote: > > > > > > > > Em Fri, Jan

[PATCH v3 1/2] tpm: fix reference counting for struct tpm_chip

2021-02-04 Thread Lino Sanfilippo
From: Lino Sanfilippo The following sequence of operations results in a refcount warning: 1. Open device /dev/tpmrm 2. Remove module tpm_tis_spi 3. Write a TPM command to the file descriptor opened at step 1. [ cut here ] WARNING: CPU: 3 PID: 1161 at lib/refcount.c:25

Re: [PATCH 0/2] docs: Add support for relative paths in automarkup

2021-02-04 Thread Jonathan Corbet
Randy Dunlap writes: > I just sent a patch for file name changes in > Documentation/input/ff.rst > (https://lore.kernel.org/linux-input/20210203050842.24190-1-rdun...@infradead.org/T/#u). > > I sent it to the INPUT maintainer because I thought that he would > want to review the changes. > > I

[PATCH v3 2/2] tpm: in tpm2_del_space check if ops pointer is still valid

2021-02-04 Thread Lino Sanfilippo
From: Lino Sanfilippo In tpm2_del_space() chip->ops is used for flushing the sessions. However this function may be called after tpm_chip_unregister() which sets the chip->ops pointer to NULL. Avoid a possible NULL pointer dereference by checking if chip->ops is still valid before accessing it.

Re: [PATCH v2 1/3] bus: mhi: core: Clear devices when moving execution environments

2021-02-04 Thread Bhaumik Bhatt
Hi Mani, On 2021-01-20 11:50 PM, Manivannan Sadhasivam wrote: On Thu, Jan 14, 2021 at 11:16:33AM -0800, Bhaumik Bhatt wrote: When moving from SBL to mission mode execution environment, there is no remove callback notification to MHI client drivers which operate on SBL mode only. Client driver

[PATCH v3 0/2] TPM fixes

2021-02-04 Thread Lino Sanfilippo
Changes in v3 - drop the patch that introduces the new function tpm_chip_free() - rework the commit messages for the patches (style, typos, etc.) - add fixes tag to patch 2 - add James Bottomley to cc list - add stable mailing list to cc list Changes in v2: - drop the patch that erroneously

Re: [PATCH 0/2] docs: Add support for relative paths in automarkup

2021-02-04 Thread Randy Dunlap
On 2/4/21 3:28 PM, Jonathan Corbet wrote: > Nícolas F. R. A. Prado writes: > >> As Jon previously noted [1], it would be nice if automarkup supported >> relative >> paths as well when cross-referencing to other documents. This adds the >> support >> for it, and documents it. >> >> Jon, after

Re: [PATCH] dma-mapping: benchmark: pretend DMA is transmitting

2021-02-04 Thread Robin Murphy
On 2021-02-04 22:58, Barry Song wrote: In a real dma mapping user case, after dma_map is done, data will be transmit. Thus, in multi-threaded user scenario, IOMMU contention should not be that severe. For example, if users enable multiple threads to send network packets through 1G/10G/100Gbps

Re: [PATCH] ARM: kexec: Fix panic after TLB are invalidated

2021-02-04 Thread Giancarlo Ferrari
Hi all, On Mon, Feb 01, 2021 at 10:18:26PM +, Giancarlo Ferrari wrote: > Russell, > > On Mon, Feb 01, 2021 at 08:16:33PM +, Russell King - ARM Linux admin > wrote: > > On Mon, Feb 01, 2021 at 08:07:37PM +, Giancarlo Ferrari wrote: > > > Hi, > > > > Hi, > > > > > Why we should

Re: [PATCH] mm: cma: support sysfs

2021-02-04 Thread Suren Baghdasaryan
On Thu, Feb 4, 2021 at 3:43 PM Suren Baghdasaryan wrote: > > On Thu, Feb 4, 2021 at 3:14 PM John Hubbard wrote: > > > > On 2/4/21 12:07 PM, Minchan Kim wrote: > > > On Thu, Feb 04, 2021 at 12:50:58AM -0800, John Hubbard wrote: > > >> On 2/3/21 7:50 AM, Minchan Kim wrote: > > >>> Since CMA is

Re: [PATCH 03/18] ovl: stack miscattr

2021-02-04 Thread Vivek Goyal
On Wed, Feb 03, 2021 at 01:40:57PM +0100, Miklos Szeredi wrote: > Add stacking for the miscattr operations. > > Signed-off-by: Miklos Szeredi > --- > fs/overlayfs/dir.c | 2 ++ > fs/overlayfs/inode.c | 43 > fs/overlayfs/overlayfs.h | 2 ++ >

Re: [PATCH bpf-next] samples/bpf: Add hello world sample for newbies

2021-02-04 Thread Andrii Nakryiko
On Thu, Feb 4, 2021 at 11:27 AM Song Liu wrote: > > On Thu, Feb 4, 2021 at 3:42 AM Tiezhu Yang wrote: > > > > The program is made in a way that everytime an execve syscall > > is executed it prints Hello, BPF World! > > > > This is inspired and based on the code example for the book > > Linux

Re: [PATCH v16 11/12] powerpc: Use OF alloc and free for FDT

2021-02-04 Thread Lakshmi Ramasubramanian
On 2/4/21 3:36 PM, Rob Herring wrote: On Thu, Feb 4, 2021 at 5:23 PM Lakshmi Ramasubramanian wrote: On 2/4/21 11:26 AM, Rob Herring wrote: On Thu, Feb 4, 2021 at 10:42 AM Lakshmi Ramasubramanian wrote: of_alloc_and_init_fdt() and of_free_fdt() have been defined in drivers/of/kexec.c to

Re: [PATCH] mm: cma: support sysfs

2021-02-04 Thread Suren Baghdasaryan
On Thu, Feb 4, 2021 at 3:14 PM John Hubbard wrote: > > On 2/4/21 12:07 PM, Minchan Kim wrote: > > On Thu, Feb 04, 2021 at 12:50:58AM -0800, John Hubbard wrote: > >> On 2/3/21 7:50 AM, Minchan Kim wrote: > >>> Since CMA is getting used more widely, it's more important to > >>> keep monitoring CMA

Re: [PATCH v19 24/25] x86/cet/shstk: Add arch_prctl functions for shadow stack

2021-02-04 Thread Yu, Yu-cheng
On 2/4/2021 12:35 PM, Kees Cook wrote: On Wed, Feb 03, 2021 at 02:55:46PM -0800, Yu-cheng Yu wrote: arch_prctl(ARCH_X86_CET_STATUS, u64 *args) Get CET feature status. The parameter 'args' is a pointer to a user buffer. The kernel returns the following information: *args =

Re: [PATCH 1/4] mm/gup: add compound page list iterator

2021-02-04 Thread John Hubbard
On 2/4/21 11:53 AM, Jason Gunthorpe wrote: On Wed, Feb 03, 2021 at 03:00:01PM -0800, John Hubbard wrote: +static inline void compound_next(unsigned long i, unsigned long npages, +struct page **list, struct page **head, +unsigned

Re: [RFC][PATCH 2/2] x86: add extra serialization for non-serializing MSRs

2021-02-04 Thread Andrew Cooper
On 05/03/2020 17:47, Dave Hansen wrote: > Jan Kiszka reported that the x2apic_wrmsr_fence() function uses a > plain "mfence" while the Intel SDM (10.12.3 MSR Access in x2APIC > Mode) calls for "mfence;lfence". > > Short summary: we have special MSRs that have weaker ordering > than all the rest.

Re: [PATCH V3 1/2] dt-bindings: power: bq27xxx: add bq78z10

2021-02-04 Thread Rob Herring
On Wed, 03 Feb 2021 10:40:59 +, LI Qingwu wrote: > Add bindings for TI BQ78Z100. An I2C interface gas gauge. > It provides a fully integrated safety protection > and authentication for 1 to 2-series cell Li-Ion and > Li-Polymer battery packs. > > Signed-off-by: LI Qingwu > --- >

Re: [PATCH v16 11/12] powerpc: Use OF alloc and free for FDT

2021-02-04 Thread Rob Herring
On Thu, Feb 4, 2021 at 5:23 PM Lakshmi Ramasubramanian wrote: > > On 2/4/21 11:26 AM, Rob Herring wrote: > > On Thu, Feb 4, 2021 at 10:42 AM Lakshmi Ramasubramanian > > wrote: > >> > >> of_alloc_and_init_fdt() and of_free_fdt() have been defined in > >> drivers/of/kexec.c to allocate and free

RE: [PATCH v3] x86/Hyper-V: Support for free page reporting

2021-02-04 Thread Michael Kelley
From: Sunil Muthuswamy Sent: Wednesday, January 6, 2021 3:21 PM > > Linux has support for free page reporting now (36e66c554b5c) for > virtualized environment. On Hyper-V when virtually backed VMs are > configured, Hyper-V will advertise cold memory discard capability, > when supported. This

[PATCH v2 1/2] procfs: Allow reading fdinfo with PTRACE_MODE_READ

2021-02-04 Thread Kalesh Singh
Android captures per-process system memory state when certain low memory events (e.g a foreground app kill) occur, to identify potential memory hoggers. In order to measure how much memory a process actually consumes, it is necessary to include the DMA buffer sizes for that process in the memory

[PATCH v2 2/2] dmabuf: Add dmabuf inode number to /proc/*/fdinfo

2021-02-04 Thread Kalesh Singh
If a FD refers to a DMA buffer add the DMA buffer inode number to /proc//fdinfo/ and /proc//task//fdindo/. The dmabuf inode number allows userspace to uniquely identify the buffer and avoids a dependency on /proc//fd/* when accounting per-process DMA buffer sizes. Signed-off-by: Kalesh Singh

Re: [PATCH 1/2] PCI/AER: Disable AER interrupt during suspend

2021-02-04 Thread Bjorn Helgaas
[+cc Alex] On Thu, Jan 28, 2021 at 12:09:37PM +0800, Kai-Heng Feng wrote: > On Thu, Jan 28, 2021 at 4:51 AM Bjorn Helgaas wrote: > > On Thu, Jan 28, 2021 at 01:31:00AM +0800, Kai-Heng Feng wrote: > > > Commit 50310600ebda ("iommu/vt-d: Enable PCI ACS for platform opt in > > > hint") enables ACS,

Re: [PATCH 0/2] docs: Add support for relative paths in automarkup

2021-02-04 Thread Jonathan Corbet
Nícolas F. R. A. Prado writes: > As Jon previously noted [1], it would be nice if automarkup supported relative > paths as well when cross-referencing to other documents. This adds the support > for it, and documents it. > > Jon, after applying this, 43bc3ed73639 ("docs: dt: Use full path to

Re: [PATCH v2 4/4] hugetlb: Do early cow when page pinned on src mm

2021-02-04 Thread Mike Kravetz
On 2/4/21 6:50 AM, Peter Xu wrote: > This is the last missing piece of the COW-during-fork effort when there're > pinned pages found. One can reference 70e806e4e645 ("mm: Do early cow for > pinned pages during fork() for ptes", 2020-09-27) for more information, since > we do similar things here

Re: [PATCH v3 1/2] dt-bindings: iommu: add bindings for sprd iommu

2021-02-04 Thread Rob Herring
On Wed, Feb 03, 2021 at 05:07:26PM +0800, Chunyan Zhang wrote: > From: Chunyan Zhang > > This iommu module can be used by Unisoc's multimedia devices, such as > display, Image codec(jpeg) and a few signal processors, including > VSP(video), GSP(graphic), ISP(image), and CPP(camera pixel

Re: [PATCH v16 11/12] powerpc: Use OF alloc and free for FDT

2021-02-04 Thread Lakshmi Ramasubramanian
On 2/4/21 11:26 AM, Rob Herring wrote: On Thu, Feb 4, 2021 at 10:42 AM Lakshmi Ramasubramanian wrote: of_alloc_and_init_fdt() and of_free_fdt() have been defined in drivers/of/kexec.c to allocate and free memory for FDT. Use of_alloc_and_init_fdt() and of_free_fdt() to allocate and

Re: [PATCH v2 2/2] drm: bridge: Add SN65DSI84 DSI to LVDS bridge

2021-02-04 Thread Marek Vasut
On 2/4/21 11:29 PM, Laurent Pinchart wrote: Hi Jagan, Thank you for the patch. On Wed, Feb 03, 2021 at 12:42:56PM +0530, Jagan Teki wrote: SN65DSI84 is a Single Channel DSI to Dual-link LVDS bridge from Texas Instruments. SN65DSI83, SN65DSI85 are variants of the same family of bridge

Re: [PATCH v2 3/4] mm: Introduce page_needs_cow_for_dma() for deciding whether cow

2021-02-04 Thread Jason Gunthorpe
On Thu, Feb 04, 2021 at 09:50:32AM -0500, Peter Xu wrote: > We've got quite a few places (pte, pmd, pud) that explicitly checked against > whether we should break the cow right now during fork(). It's easier to > provide a helper, especially before we work the same thing on hugetlbfs. > > Since

Re: [PATCH] mm: cma: support sysfs

2021-02-04 Thread John Hubbard
On 2/4/21 12:07 PM, Minchan Kim wrote: On Thu, Feb 04, 2021 at 12:50:58AM -0800, John Hubbard wrote: On 2/3/21 7:50 AM, Minchan Kim wrote: Since CMA is getting used more widely, it's more important to keep monitoring CMA statistics for system health since it's directly related to user

Re: [PATCH v3 1/1] x86,sched: On AMD EPYC set freq_max = max_boost in schedutil invariant formula

2021-02-04 Thread Michael Larabel
On 2/4/21 7:40 AM, Rafael J. Wysocki wrote: On Thu, Feb 4, 2021 at 12:36 AM Michael Larabel wrote: On 2/3/21 12:25 PM, Rafael J. Wysocki wrote: On Wednesday, February 3, 2021 3:11:37 PM CET Rafael J. Wysocki wrote: On Wed, Feb 3, 2021 at 2:53 PM Giovanni Gherdovich wrote: [cut] Fixes:

[PATCH] dma-mapping: benchmark: pretend DMA is transmitting

2021-02-04 Thread Barry Song
In a real dma mapping user case, after dma_map is done, data will be transmit. Thus, in multi-threaded user scenario, IOMMU contention should not be that severe. For example, if users enable multiple threads to send network packets through 1G/10G/100Gbps NIC, usually the steps will be: map ->

[GIT PULL] PCI fixes for v5.11

2021-02-04 Thread Bjorn Helgaas
The following changes since commit 7c53f6b671f4aba70ff15e1b05148b10d58c2837: Linux 5.11-rc3 (2021-01-10 14:34:50 -0800) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git pci-v5.11-fixes-2 for you to fetch changes up to

Re: [PATCH] staging: qlge/qlge_main: Use min_t instead of min

2021-02-04 Thread Nathan Chancellor
On Fri, Feb 05, 2021 at 03:24:51AM +0530, ameynarkhed...@gmail.com wrote: > From: Amey Narkhede > > Use min_t instead of min function in qlge/qlge_main.c > Fixes following checkpatch.pl warning: > WARNING: min() should probably be min_t(int, MAX_CPUS, num_online_cpus()) > > Signed-off-by: Amey

Re: [PATCH] lib/vsprintf: make-printk-non-secret printks all addresses as unhashed

2021-02-04 Thread Pavel Machek
On Thu 2021-02-04 23:51:36, Pavel Machek wrote: > On Thu 2021-02-04 14:17:13, Kees Cook wrote: > > On Thu, Feb 04, 2021 at 11:11:43PM +0100, Pavel Machek wrote: > > > On Thu 2021-02-04 15:59:21, Timur Tabi wrote: > > > > On 2/4/21 3:49 PM, Pavel Machek wrote: > > > > >This machine is insecure. Yet

[PATCH v2] ARM: imx: avic: Convert to using IRQCHIP_DECLARE

2021-02-04 Thread Saravana Kannan
Remove a lot of boilerplate code. Also address boot issues on imx25 with fw_devlink=on that were reported by Martin. Fixes: e590474768f1 ("driver core: Set fw_devlink=on by default") Reported-by: Martin Kaiser Signed-off-by: Saravana Kannan Tested-by: Martin Kaiser --- v1 -> v2: - Fixed up

[PATCH v3 3/3] kunit: tool: fix unintentional statefulness in run_kernel()

2021-02-04 Thread Daniel Latypov
This is a bug that has been present since the first version of this code. Using [] as a default parameter is dangerous, since it's mutable. Example using the REPL: >>> def bad(param = []): ... param.append(len(param)) ... print(param) ... >>> bad() [0] >>> bad() [0, 1] This wasn't a

[PATCH v3 2/3] kunit: tool: add support for filtering suites by glob

2021-02-04 Thread Daniel Latypov
This allows running different subsets of tests, e.g. $ ./tools/testing/kunit/kunit.py build $ ./tools/testing/kunit/kunit.py exec 'list*' $ ./tools/testing/kunit/kunit.py exec 'kunit*' This passes the "kunit_filter.glob" commandline option to the UML kernel, which currently only supports

[PATCH v3 1/3] kunit: add kunit.filter_glob cmdline option to filter suites

2021-02-04 Thread Daniel Latypov
E.g. specifying this would run suites with "list" in their name. kunit.filter_glob=list* Note: the executor prints out a TAP header that includes the number of suites we intend to run. So unless we want to report empty results for filtered-out suites, we need to do the filtering here in the

[PATCH v3 0/3] kunit: support running subsets of test suites from kunit.py

2021-02-04 Thread Daniel Latypov
When using `kunit.py run` to run tests, users must populate a `kunitconfig` file to select the options the tests are hidden behind and all their dependencies. The patch [1] to allow specifying a path to kunitconfig promises to make this nicer as we can have checked in files corresponding to

[PATCH] drm/msm: Fix legacy relocs path

2021-02-04 Thread Rob Clark
From: Rob Clark In moving code around, we ended up using the same pointer to copy_from_user() the relocs tables as we used for the cmd table entry, which is clearly not right. This went unnoticed because modern mesa on non-ancent kernels does not actually use relocs. But this broke ancient mesa

Re: [PATCH] lib/vsprintf: make-printk-non-secret printks all addresses as unhashed

2021-02-04 Thread Pavel Machek
On Thu 2021-02-04 14:17:13, Kees Cook wrote: > On Thu, Feb 04, 2021 at 11:11:43PM +0100, Pavel Machek wrote: > > On Thu 2021-02-04 15:59:21, Timur Tabi wrote: > > > On 2/4/21 3:49 PM, Pavel Machek wrote: > > > >This machine is insecure. Yet I don't see ascii-art *** all around.. > > > > > > >

Re: [PATCH] KVM: VMX: Optimize flushing the PML buffer

2021-02-04 Thread Peter Xu
Hi, Ben, On Thu, Feb 04, 2021 at 02:19:59PM -0800, Ben Gardon wrote: > The average time for each run demonstrated a strange bimodal distribution, > with clusters around 2 seconds and 2.5 seconds. This may have been a > result of vCPU migration between NUMA nodes. Have you thought about using

linux-next: build warning after merge of the cifs tree

2021-02-04 Thread Stephen Rothwell
Hi all, After merging the cifs tree, today's linux-next build (powerpc ppc64_defconfig) produced this warning: fs/cifs/file.c:4290:13: warning: 'cifs_is_cache_enabled' defined but not used [-Wunused-function] 4290 | static bool cifs_is_cache_enabled(struct inode *inode) |

Re: [PATCH v5 06/11] crypto: qce: skcipher: Return error for non-blocksize data(ECB/CBC algorithms)

2021-02-04 Thread Eric Biggers
On Thu, Feb 04, 2021 at 04:43:54PM -0500, Thara Gopinath wrote: > + /* > + * ECB and CBC algorithms require message lengths to be > + * multiples of block size. > + * TODO: The spec says AES CBC mode for certain versions > + * of crypto engine can handle partial blocks as

Re: [PATCH v5 05/11] crypto: qce: skcipher: Return error for zero length messages

2021-02-04 Thread Eric Biggers
On Thu, Feb 04, 2021 at 04:43:53PM -0500, Thara Gopinath wrote: > Crypto engine BAM dma does not support 0 length data. Return unsupported > if zero length messages are passed for transformation. > > Signed-off-by: Thara Gopinath > --- > drivers/crypto/qce/skcipher.c | 5 + > 1 file

Re: linux-next: manual merge of the pidfd tree with the overlayfs tree

2021-02-04 Thread Stephen Rothwell
Hi all, On Mon, 25 Jan 2021 17:04:26 +1100 Stephen Rothwell wrote: > > Today's linux-next merge of the pidfd tree got a conflict in: > > fs/overlayfs/copy_up.c > > between commit: > > 06896fa3193d ("ovl: skip getxattr of security labels") > > from the overlayfs tree and commit: > >

Re: [PATCH v3 08/13] vdpa: add return value to get_config/set_config callbacks

2021-02-04 Thread Stefano Garzarella
/kernel/git/mst/vhost.git linux-next config: parisc-randconfig-r005-20210204 (attached as .config) compiler: hppa-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin

Re: linux-next: manual merge of the pidfd tree with the overlayfs tree

2021-02-04 Thread Stephen Rothwell
Hi all, On Mon, 25 Jan 2021 17:07:16 +1100 Stephen Rothwell wrote: > > Today's linux-next merge of the pidfd tree got a conflict in: > > fs/overlayfs/inode.c > > between commit: > > 9c09be9e71c4 ("ovl: perform vfs_getxattr() with mounter creds") > > from the overlayfs tree and commit: >

[PATCH v3 3/4] driver core: Add fw_devlink.strict kernel param

2021-02-04 Thread Saravana Kannan
This param allows forcing all dependencies to be treated as mandatory. This will be useful for boards in which all optional dependencies like IOMMUs and DMAs need to be treated as mandatory dependencies. Signed-off-by: Saravana Kannan --- Documentation/admin-guide/kernel-parameters.txt | 5

[PATCH v3 4/4] of: property: Add fw_devlink support for optional properties

2021-02-04 Thread Saravana Kannan
Not all DT bindings are mandatory bindings. Add support for optional DT bindings and mark iommus, iommu-map, dmas as optional DT bindings. Signed-off-by: Saravana Kannan --- drivers/of/property.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git

[PATCH v3 1/4] driver core: fw_devlink: Detect supplier devices that will never be added

2021-02-04 Thread Saravana Kannan
During the initial parsing of firmware by fw_devlink, fw_devlink might infer that some supplier firmware nodes would get populated as devices. But the inference is not always correct. This patch tries to logically detect and fix such mistakes as boot progresses or more devices probe. fw_devlink

[PATCH v3 2/4] of: property: Don't add links to absent suppliers

2021-02-04 Thread Saravana Kannan
If driver core marks a firmware node as not a device, don't add fwnode links where it's a supplier. Fixes: e590474768f1 ("driver core: Set fw_devlink=on by default") Signed-off-by: Saravana Kannan --- drivers/of/property.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git

[PATCH v3 0/4] Make fw_devlink=on more forgiving

2021-02-04 Thread Saravana Kannan
I dropped a few patches from v2 of the series that are still work in progress. So v3 of the series only includes definitive patches and the patch numbering has changed. Patch 1/4 and 2/4 addresses the issue of firmware nodes that look like they'll have struct devices created for them, but will

[PATCH] MAINTAINERS: Update Andrey Ryabinin's email address

2021-02-04 Thread Andrey Ryabinin
Update my email, @virtuozzo.com will stop working shortly. Signed-off-by: Andrey Ryabinin --- .mailmap| 1 + MAINTAINERS | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/.mailmap b/.mailmap index 632700cee55c..b325d3c79725 100644 --- a/.mailmap +++ b/.mailmap @@ -40,6

Re: [PATCH v7 1/2] Kbuild: make DWARF version a choice

2021-02-04 Thread Fangrui Song
On 2021-02-04, Nick Desaulniers wrote: On Thu, Feb 4, 2021 at 12:28 PM Mark Wielaard wrote: On Thu, 2021-02-04 at 12:04 -0800, Nick Desaulniers wrote: > On Thu, Feb 4, 2021 at 11:56 AM Mark Wielaard wrote: > > I agree with Jakub. Now that GCC has defaulted to DWARF5 all the > > tools > >

Re: [PATCH] arch:powerpc simple_write_to_buffer return check

2021-02-04 Thread Oliver O'Halloran
On Fri, Feb 5, 2021 at 5:17 AM Mayank Suman wrote: > > Signed-off-by: Mayank Suman commit messages aren't optional > --- > arch/powerpc/kernel/eeh.c| 8 > arch/powerpc/platforms/powernv/eeh-powernv.c | 4 ++-- > 2 files changed, 6 insertions(+), 6 deletions(-) > >

Re: [PATCH v3 08/13] vdpa: add return value to get_config/set_config callbacks

2021-02-04 Thread kernel test robot
-20210204 (attached as .config) compiler: hppa-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit

Re: [PATCH v2 2/2] drm: bridge: Add SN65DSI84 DSI to LVDS bridge

2021-02-04 Thread Laurent Pinchart
Hi Jagan, Thank you for the patch. On Wed, Feb 03, 2021 at 12:42:56PM +0530, Jagan Teki wrote: > SN65DSI84 is a Single Channel DSI to Dual-link LVDS bridge from > Texas Instruments. > > SN65DSI83, SN65DSI85 are variants of the same family of bridge > controllers. > > Right now the bridge

Re: [PATCH] drm/bridge: anx7625: enable DSI EOTP

2021-02-04 Thread Nicolas Boichat
On Thu, Feb 4, 2021 at 8:59 PM Andrzej Hajda wrote: > > > W dniu 04.02.2021 o 13:34, Nicolas Boichat pisze: > > On Thu, Feb 4, 2021 at 8:07 PM Robert Foss wrote: > >> Hi Xin, > >> > >> Thanks for the patch. > >> > >> On Thu, 28 Jan 2021 at 12:17, Xin Ji wrote: > >>> Enable DSI EOTP feature for

Re: [EXT] Re: [PATCH 04/14] cxl/mem: Implement polled mode mailbox

2021-02-04 Thread Ben Widawsky
On 21-02-04 21:53:29, John Groves (jgroves) wrote: >Micron Confidential > > > >From: Dan Williams >Date: Monday, February 1, 2021 at 1:28 PM >To: Ben Widawsky >Cc: Konrad Rzeszutek Wilk , >linux-...@vger.kernel.org , Linux ACPI >, Linux Kernel Mailing List >,

Re: [PATCH 1/2] PCI: also set up legacy files only after sysfs init

2021-02-04 Thread Pali Rohár
On Thursday 04 February 2021 15:50:19 Bjorn Helgaas wrote: > [+cc Oliver, Pali, Krzysztof] Just to note that extending or using sysfs_initialized introduces another race condition into kernel code which results in PCI fatal errors. Details are in email discussion which Bjorn already sent. >

Re: [PATCH 1/3] tty: serial: Add UART driver for Cortina-Access platform

2021-02-04 Thread Alex Nemirovsky
Thanks Greg. Will fix this and add a change history. > On Feb 4, 2021, at 7:49 AM, Greg Kroah-Hartman > wrote: > > On Wed, Feb 03, 2021 at 11:58:47PM -0800, Alex Nemirovsky wrote: >> +static uintptr_t *cortina_uart_ports; > > Note, "uintptr_t" is not a valid kernel type. > > Please use a

Re: [PATCH v2 0/3] Rename audio graph export functions

2021-02-04 Thread Kuninori Morimoto
Hi Sameer > This series renames exported functions from audio graph for a better > global visibility. In doing so update the references in audio graph > and Tegra audio graph card drivers. I guess [1/3] and [2/3] should be merged/squashed ? Otherwise, there is git-bisect error. Except it

Re: [PATCH] lib/vsprintf: make-printk-non-secret printks all addresses as unhashed

2021-02-04 Thread Timur Tabi
On 2/4/21 4:17 PM, Kees Cook wrote: It's just semantics. Printing addresses DOES weaken the security of a system, especially when we know attackers have and do use stuff from dmesg to tune their attacks. How about "reduces the security of your system"? I think we're bikeshedding now, but I

[PATCH] KVM: VMX: Optimize flushing the PML buffer

2021-02-04 Thread Ben Gardon
vmx_flush_pml_buffer repeatedly calls kvm_vcpu_mark_page_dirty, which SRCU-derefrences kvm->memslots. In order to give the compiler more freedom to optimize the function, SRCU-dereference the pointer kvm->memslots only once. Reviewed-by: Makarand Sonare Signed-off-by: Ben Gardon --- Tested by

Re: [PATCH] lib/vsprintf: make-printk-non-secret printks all addresses as unhashed

2021-02-04 Thread Kees Cook
On Thu, Feb 04, 2021 at 11:11:43PM +0100, Pavel Machek wrote: > On Thu 2021-02-04 15:59:21, Timur Tabi wrote: > > On 2/4/21 3:49 PM, Pavel Machek wrote: > > >This machine is insecure. Yet I don't see ascii-art *** all around.. > > > > > >"Kernel memory addresses are exposed, which is bad for

Re: [PATCH] x86: efi: avoid BUILD_BUG_ON() for non-constant p4d_index

2021-02-04 Thread Borislav Petkov
On Thu, Feb 04, 2021 at 04:43:58PM -0500, Arvind Sankar wrote: > This should check EFI_VA_END instead of EFI_VA_START, and maybe throw in > a BUG_ON if EFI_VA_END >= EFI_VA_START. No need: if (efi_va < EFI_VA_END) { pr_warn(FW_WARN "VA address range overflow!\n");

Re: [PATCH] lib/vsprintf: make-printk-non-secret printks all addresses as unhashed

2021-02-04 Thread Pavel Machek
On Thu 2021-02-04 15:59:21, Timur Tabi wrote: > On 2/4/21 3:49 PM, Pavel Machek wrote: > >This machine is insecure. Yet I don't see ascii-art *** all around.. > > > >"Kernel memory addresses are exposed, which is bad for security." > > I'll use whatever wording everyone can agree on, but I really

Re: ANNOUNCE: pahole v1.20 (gcc11 DWARF5's default, lots of ELF sections, BTF)

2021-02-04 Thread Sedat Dilek
On Thu, Feb 4, 2021 at 11:07 PM Arnaldo Carvalho de Melo wrote: > > Hi, > > The v1.20 release of pahole and its friends is out, mostly > addressing problems related to gcc 11 defaulting to DWARF5 for -g, > available at the usual places: > Congrats and thanks for v1.20 and to all involved

Re: [PATCH] jfs: Remove unneeded return variable

2021-02-04 Thread Dave Kleikamp
On 2/3/21 9:39 PM, Yang Li wrote: This patch removes unneeded return variables, using only '0' instead. It fixes the following warning detected by coccinelle: ./fs/jfs/jfs_txnmgr.c:1370:5-7: Unneeded variable: "rc". Return "0" on line 1417 Looks good. I wonder if we should take it a step

ANNOUNCE: pahole v1.20 (gcc11 DWARF5's default, lots of ELF sections, BTF)

2021-02-04 Thread Arnaldo Carvalho de Melo
Hi, The v1.20 release of pahole and its friends is out, mostly addressing problems related to gcc 11 defaulting to DWARF5 for -g, available at the usual places: Main git repo: git://git.kernel.org/pub/scm/devel/pahole/pahole.git Mirror git repo:

[PATCH] PCI: Run platform power transition on initial D0 entry

2021-02-04 Thread Maximilian Luz
On some devices and platforms, the initial platform power state is not in sync with the power state of the PCI device. pci_enable_device_flags() updates the state of a PCI device by reading from the PCI_PM_CTRL register. This may change the stored power state of the device without running the

Re: [PATCH v7 1/2] Kbuild: make DWARF version a choice

2021-02-04 Thread Nick Desaulniers
On Thu, Feb 4, 2021 at 12:28 PM Mark Wielaard wrote: > > On Thu, 2021-02-04 at 12:04 -0800, Nick Desaulniers wrote: > > On Thu, Feb 4, 2021 at 11:56 AM Mark Wielaard wrote: > > > I agree with Jakub. Now that GCC has defaulted to DWARF5 all the > > > tools > > > have adopted to the new default

Re: [PATCH] lib/vsprintf: make-printk-non-secret printks all addresses as unhashed

2021-02-04 Thread Steven Rostedt
On Thu, 4 Feb 2021 15:59:21 -0600 Timur Tabi wrote: > I think the reason behind the large banner has less to do how insecure > the system is, and more about making sure vendors and sysadmins don't > enable it by default everywhere. +100 -- Steve

Re: [PATCH] lib/vsprintf: make-printk-non-secret printks all addresses as unhashed

2021-02-04 Thread Steven Rostedt
On Thu, 4 Feb 2021 22:49:44 +0100 Pavel Machek wrote: > This machine is insecure. Yet I don't see ascii-art *** all around.. > > "Kernel memory addresses are exposed, which is bad for security." > would be quite enough, I'd say... Well, the alternative is that you go back to patching your own

Re: [PATCH v2] pwm: sunxi: Add Allwinner SoC PWM controller driver

2021-02-04 Thread Thierry Reding
On Thu, Feb 04, 2021 at 02:54:36PM +0100, Uwe Kleine-König wrote: > Hello Thierry, > > On Thu, Feb 04, 2021 at 02:38:40PM +0100, Thierry Reding wrote: > > All I'm saying is that I don't think we need to require everyone to > > adopt a prefix, especially if this hasn't been followed consistently,

Re: [PATCH 15/18] irqchip/apple-aic: Add support for the Apple Interrupt Controller

2021-02-04 Thread Hector Martin 'marcan'
On 05/02/2021 06.37, Arnd Bergmann wrote: On Thu, Feb 4, 2021 at 9:39 PM Hector Martin wrote: + * - This driver creates one IRQ domain for HW IRQs and the timer FIQs + * - FIQ hwirq numbers are assigned after true hwirqs, and are per-cpu + * - DT bindings use 3-cell form (like GIC): + * - <0

Re: [PATCH 2/2] kvfree_rcu: Use same set of flags as for single-argument

2021-02-04 Thread Paul E. McKenney
On Fri, Jan 29, 2021 at 09:05:05PM +0100, Uladzislau Rezki (Sony) wrote: > Running an rcuscale stress-suite can lead to "Out of memory" > of a system. This can happen under high memory pressure with > a small amount of physical memory. > > For example a KVM test configuration with 64 CPUs and 512

Re: [PATCH v11 0/6] arm64: MMU enabled kexec relocation

2021-02-04 Thread Eric W. Biederman
Pavel Tatashin writes: >> > I understand that having an extra set of page tables could potentially >> > waste memory, especially if VAs are sparse, but in this case we use >> > page tables exclusively for contiguous VA space (copy [src, src + >> > size]). Therefore, the extra memory usage is

Re: [PATCH v2 1/5] docs: arm: marvell: drop some dead links

2021-02-04 Thread Andrew Lunn
On Thu, Feb 04, 2021 at 02:29:11PM -0700, Jonathan Corbet wrote: > Lubomir Rintel writes: > > > Just remove these; there's good chance there wasn't anything useful > > there anyway. > > > > Signed-off-by: Lubomir Rintel > > > > --- > > Changes since v1: > > - Adjust for removal of "[PATCH 1/5]

<    1   2   3   4   5   6   7   8   9   10   >