RE: [PATCH net-next] misc: Add Renesas Synchronization Management Unit (SMU) support

2021-02-12 Thread Min Li
> > Ah, so if this is for a PTP related driver, it should probably be integrated > into > the PTP subsystem rather than being a separate class. > I was trying to add these functions to PHC subsystem but was not accepted because the functions are specific to Renesas device and there is no

Re: [PATCH] RFC: x86/jump_label: Mark arguments as const to satisfy asm constraints

2021-02-12 Thread Josh Poimboeuf
On Thu, Feb 11, 2021 at 01:48:48PM -0800, Jason Gerecke wrote: > When compiling an external kernel module with `-O0` or `-O1`, the following > compile error may be reported: > > ./arch/x86/include/asm/jump_label.h:25:2: error: impossible constraint in > ‘asm’ >25 |

Re: [PATCH] cpufreq: schedutil: Don't use the limits_changed flag any more

2021-02-12 Thread Rafael J. Wysocki
On Mon, Feb 8, 2021 at 4:08 AM Yue Hu wrote: > > From: Yue Hu > > The limits_changed flag was introduced by commit 600f5badb78c > ("cpufreq: schedutil: Don't skip freq update when limits change") due > to race condition where need_freq_update is cleared in get_next_freq() > which causes reducing

Re: [PATCH v5 4/6] dm: new ioctl DM_DEV_REMAP_CMD

2021-02-12 Thread Mike Snitzer
On Tue, Feb 09 2021 at 9:30am -0500, Sergei Shtepa wrote: > New ioctl DM_DEV_REMAP_CMD allow to remap bio requests > from regular block device to dm device. I really dislike the (ab)use of "REMAP" for this. DM is and always has been about remapping IO. Would prefer DM_DEV_INTERPOSE_CMD

Re: possible deadlock in dquot_commit

2021-02-12 Thread Theodore Ts'o
>From: Theodore Ts'o On Fri, Feb 12, 2021 at 12:01:51PM +0100, Dmitry Vyukov wrote: > > > > > > There is a reproducer for 4.19 available on the dashboard. Maybe it will > > > help. > > > I don't why it did not pop up on upstream yet, there lots of potential > > > reasons for this. > > > > The

Re: [PATCH v2 5/5] ACPI: property: Refactor acpi_data_prop_read_single()

2021-02-12 Thread Rafael J. Wysocki
On Fri, Feb 12, 2021 at 5:01 PM Andy Shevchenko wrote: > > On Fri, Feb 12, 2021 at 03:31:24PM +0100, Rafael J. Wysocki wrote: > > On Fri, Feb 12, 2021 at 3:14 PM Andy Shevchenko > > wrote: > > > > Refactor acpi_data_prop_read_single() for less LOCs and better > > > maintenance. > > Thanks for

Re: [PATCH v5 5/6] dm: add 'noexcl' option for dm-linear

2021-02-12 Thread Mike Snitzer
On Fri, Feb 12 2021 at 6:34am -0500, Sergei Shtepa wrote: > The 02/11/2021 20:51, Mike Snitzer wrote: > > On Tue, Feb 09 2021 at 9:30am -0500, > > Sergei Shtepa wrote: > > > > > The 'noexcl' option allow to open underlying block-device > > > without FMODE_EXCL. > > > > > > Signed-off-by:

RE: [PATCH net-next v2] misc: Add Renesas Synchronization Management Unit (SMU) support

2021-02-12 Thread Min Li
> > > > If I come up with an rsmu.rst under Documentation/driver-api, is that > something you are looking for? > > No, all sysfs files need to be documented in Documentation/ABI/ > > thanks, > > greg k-h Hi Greg I decided to follow Arnd's suggestion and drop the extra sysfs attributes

RE: [PATCH net-next v2] misc: Add Renesas Synchronization Management Unit (SMU) support

2021-02-12 Thread Min Li
> > xilinx_sdfec.c has: > > static int xsdfec_dev_open(struct inode *iptr, struct file *fptr) > { > return 0; > } > > Which isn't even needed at all, but it is NOT trying to keep people from > calling open multiple times. > > As for why the above logic does not

Re: [PATCH v2 5/5] ACPI: property: Refactor acpi_data_prop_read_single()

2021-02-12 Thread Andy Shevchenko
On Fri, Feb 12, 2021 at 03:31:24PM +0100, Rafael J. Wysocki wrote: > On Fri, Feb 12, 2021 at 3:14 PM Andy Shevchenko > wrote: > > Refactor acpi_data_prop_read_single() for less LOCs and better maintenance. Thanks for review, my answers below. ... > > + if (ret) > > +

Re: [PATCH v5 net-next 03/10] net: bridge: don't print in br_switchdev_set_port_flag

2021-02-12 Thread Nikolay Aleksandrov
On 12/02/2021 17:15, Vladimir Oltean wrote: > From: Vladimir Oltean > > For the netlink interface, propagate errors through extack rather than > simply printing them to the console. For the sysfs interface, we still > print to the console, but at least that's one layer higher than in >

Re: [PATCH v5 net-next 01/10] net: switchdev: propagate extack to port attributes

2021-02-12 Thread Nikolay Aleksandrov
On 12/02/2021 17:15, Vladimir Oltean wrote: > From: Vladimir Oltean > > When a struct switchdev_attr is notified through switchdev, there is no > way to report informational messages, unlike for struct switchdev_obj. > > Signed-off-by: Vladimir Oltean > Reviewed-by: Ido Schimmel >

Re: [PATCH][next] bcache: Use 64-bit arithmetic instead of 32-bit

2021-02-12 Thread Coly Li
On 2/12/21 11:31 PM, David Laight wrote: >>> if (c->gc_stats.in_use <= BCH_WRITEBACK_FRAGMENT_THRESHOLD_MID) >>> { >>> - fp_term = dc->writeback_rate_fp_term_low * >>> + fp_term = (int64_t)dc->writeback_rate_fp_term_low * >>>

Re: [PATCH 1/6] fs: Add flag to file_system_type to indicate content is generated

2021-02-12 Thread Ian Lance Taylor
On Fri, Feb 12, 2021 at 7:45 AM Greg KH wrote: > > On Fri, Feb 12, 2021 at 07:33:57AM -0800, Ian Lance Taylor wrote: > > On Fri, Feb 12, 2021 at 12:38 AM Greg KH wrote: > > > > > > Why are people trying to use copy_file_range on simple /proc and /sys > > > files in the first place? They can not

Re: [PATCH v5 net-next 02/10] net: bridge: offload all port flags at once in br_setport

2021-02-12 Thread Nikolay Aleksandrov
On 12/02/2021 17:15, Vladimir Oltean wrote: > From: Vladimir Oltean > > If for example this command: > > ip link set swp0 type bridge_slave flood off mcast_flood off learning off > > succeeded at configuring BR_FLOOD and BR_MCAST_FLOOD but not at > BR_LEARNING, there would be no attempt to

Re: [PATCH] MAINTAINERS: cpuidle: exynos: include header in file pattern

2021-02-12 Thread Rafael J. Wysocki
On Wed, Feb 10, 2021 at 6:23 PM Krzysztof Kozlowski wrote: > > Inclue the platform data header in Exynos cpuidle maintainer entry. > > Cc: Bartlomiej Zolnierkiewicz > Cc: Daniel Lezcano > Cc: Rafael J. Wysocki > Signed-off-by: Krzysztof Kozlowski > --- > MAINTAINERS | 1 + > 1 file changed,

Re: [PATCH] RFC: x86/jump_label: Mark arguments as const to satisfy asm constraints

2021-02-12 Thread Jason Gerecke
On Fri, Feb 12, 2021 at 7:27 AM Peter Zijlstra wrote: > > On Fri, Feb 12, 2021 at 09:40:59AM -0500, Steven Rostedt wrote: > > On Thu, 11 Feb 2021 13:48:48 -0800 > > Jason Gerecke wrote: > > > > > When compiling an external kernel module with `-O0` or `-O1`, the > > > following > > > compile

Re: [PATCH net-next v2] misc: Add Renesas Synchronization Management Unit (SMU) support

2021-02-12 Thread Greg KH
On Fri, Feb 12, 2021 at 03:44:52PM +, Min Li wrote: > > > > > > -set combomode > > > -get dpll's state > > > -get dpll's ffo > > > > > > This driver must work with Renesas MFD driver to access SMU through > > > I2C/SPI. > > > > > > Changes since v1: > > > -Provide more background for purpose

Re: [PATCH 1/2] powercap/intel_rapl: Use topology interface in rapl_add_package()

2021-02-12 Thread Rafael J. Wysocki
On Sat, Jan 23, 2021 at 11:07 AM Yunfeng Ye wrote: > > It's not a good way to access phys_proc_id and cpu_die_id directly. > So using topology_physical_package_id(cpu) and topology_die_id(cpu) > instead. > > Signed-off-by: Yunfeng Ye > --- > drivers/powercap/intel_rapl_common.c | 6 +++--- > 1

Re: [PATCH net v1 1/3] net: phy: mscc: adding LCPLL reset to VSC8514

2021-02-12 Thread Andrew Lunn
On Fri, Feb 12, 2021 at 03:06:41PM +0100, Bjarni Jonasson wrote: > At Power-On Reset, transients may cause the LCPLL to lock onto a > clock that is momentarily unstable. This is normally seen in QSGMII > setups where the higher speed 6G SerDes is being used. > This patch adds an initial LCPLL

Re: [PATCH v2 2/8] cxl/mem: Find device capabilities

2021-02-12 Thread Ben Widawsky
On 21-02-12 13:27:06, Jonathan Cameron wrote: > On Thu, 11 Feb 2021 07:55:29 -0800 > Ben Widawsky wrote: > > > On 21-02-11 09:55:48, Jonathan Cameron wrote: > > > On Wed, 10 Feb 2021 10:16:05 -0800 > > > Ben Widawsky wrote: > > > > > > > On 21-02-10 08:55:57, Ben Widawsky wrote: > > > > >

Re: [PATCH] PM: Constify static struct attribute_group

2021-02-12 Thread Rafael J. Wysocki
On Mon, Feb 1, 2021 at 11:58 PM Rikard Falkeborn wrote: > > The only usage of suspend_attr_group is to put its address in an array of > pointers to const attribute_group structs. Make it const to allow the > compiler to put it in read-only memory. > > Signed-off-by: Rikard Falkeborn > --- >

Re: [PATCH net-next v2] misc: Add Renesas Synchronization Management Unit (SMU) support

2021-02-12 Thread Greg KH
On Fri, Feb 12, 2021 at 03:39:03PM +, Min Li wrote: > > > + > > > + /* Only one open per device at a time */ > > > + if (!atomic_dec_and_test(>open_count)) { > > > + atomic_inc(>open_count); > > > + return -EBUSY; > > > > This does not do what you think it does, and does not

[PATCH] mtd: spi-nor: sfdp: Fix out of bound array access

2021-02-12 Thread Mathieu Dubois-Briand
Fix array index: explicitly use the array length to access the last element, instead of an incorrectly set iteration variable. It seems this code was correct before following commit, were the iteration counter is reused, leading to a value that may be out of bound. Fixes: dc92843159a7 ("mtd:

Re: [PATCH 1/6] fs: Add flag to file_system_type to indicate content is generated

2021-02-12 Thread Greg KH
On Fri, Feb 12, 2021 at 07:33:57AM -0800, Ian Lance Taylor wrote: > On Fri, Feb 12, 2021 at 12:38 AM Greg KH wrote: > > > > Why are people trying to use copy_file_range on simple /proc and /sys > > files in the first place? They can not seek (well most can not), so > > that feels like a "oh

Re: [PATCH v5] kvfree_rcu: Release page cache under memory pressure

2021-02-12 Thread Uladzislau Rezki
> From: Zqiang > > Add free per-cpu existing krcp's page cache operation in shrink callback > function, and also during shrink period, simple delay schedule fill page > work, to avoid refill page while free krcp page cache. > > Signed-off-by: Zqiang > Co-developed-by: Uladzislau Rezki (Sony)

RE: [PATCH net-next v2] misc: Add Renesas Synchronization Management Unit (SMU) support

2021-02-12 Thread Min Li
> > > > -set combomode > > -get dpll's state > > -get dpll's ffo > > > > This driver must work with Renesas MFD driver to access SMU through > > I2C/SPI. > > > > Changes since v1: > > -Provide more background for purpose of the change. > > -Provide compat_ioctl support > > -Fix ioctl cmd

Re: [PATCH 1/2] PM / EM: update Kconfig description and drop "default n" option

2021-02-12 Thread Rafael J. Wysocki
On Tue, Feb 9, 2021 at 11:58 AM Lukasz Luba wrote: > > Energy Model supports now other devices like GPUs, DSPs, not only CPUs. > Thus, update the description in the config option. Remove also unneeded > "default n". If the "default" line is removed, it defaults to 'n'. > > Signed-off-by: Lukasz

Re: possible deadlock in start_this_handle (2)

2021-02-12 Thread Michal Hocko
On Fri 12-02-21 21:58:15, Tetsuo Handa wrote: > On 2021/02/12 21:30, Michal Hocko wrote: > > On Fri 12-02-21 12:22:07, Matthew Wilcox wrote: > >> On Fri, Feb 12, 2021 at 08:18:11PM +0900, Tetsuo Handa wrote: > >>> On 2021/02/12 1:41, Michal Hocko wrote: > But I suspect we have drifted away

Re: [PATCH 1/1] iscsi_ibft: KASAN false positive failure occurs in ibft_init()

2021-02-12 Thread David Hildenbrand
On 12.02.21 14:51, Dmitry Vyukov wrote: On Fri, Feb 12, 2021 at 2:31 PM George Kennedy wrote: On 2/10/2021 4:51 PM, George Kennedy wrote: On 2/3/2021 2:35 PM, Dmitry Vyukov wrote: On Wed, Feb 3, 2021 at 8:29 PM Konrad Rzeszutek Wilk wrote: Hey Dmitry, Rafael, George, please see below.. On

[PATCH v2] staging: wimax/i2400m: fix some byte order issues found by sparse

2021-02-12 Thread Anirudh Rayabharam
Fix sparse byte-order warnings in the i2400m_bm_cmd_prepare() function: wimax/i2400m/fw.c:194:36: warning: restricted __le32 degrades to integer wimax/i2400m/fw.c:195:34: warning: invalid assignment: += wimax/i2400m/fw.c:195:34:left side has type unsigned int wimax/i2400m/fw.c:195:34:

Re: Memory keys and io_uring.

2021-02-12 Thread Jens Axboe
On 2/12/21 8:33 AM, Aneesh Kumar K.V wrote: > On 2/12/21 8:45 PM, Jens Axboe wrote: >> On 2/11/21 11:59 PM, Aneesh Kumar K.V wrote: >>> >>> Hi, >>> >>> I am trying to estabilish the behaviour we should expect when passing a >>> buffer with memory keys attached to io_uring syscalls. As show in the

RE: [PATCH net-next v2] misc: Add Renesas Synchronization Management Unit (SMU) support

2021-02-12 Thread Min Li
> > + > > + /* Only one open per device at a time */ > > + if (!atomic_dec_and_test(>open_count)) { > > + atomic_inc(>open_count); > > + return -EBUSY; > > This does not do what you think it does, and does not prevent multiple > applications from talking to your device at

Re: [PATCH v7 28/28] coresight: Add support for v8.4 SelfHosted tracing

2021-02-12 Thread Suzuki K Poulose
Hi Mike On 2/12/21 10:34 AM, Mike Leach wrote: Hi Mathieu, Suzuki, Sorry for the really late response on this patch, but I noticed a problem while doing a review of the ETE / TRBE set. (TRBE specs mention TRFCR_ELx, so I was confirming a couple of things). On Sun, 10 Jan 2021 at 22:49, Suzuki

Re: Memory keys and io_uring.

2021-02-12 Thread Aneesh Kumar K.V
On 2/12/21 8:45 PM, Jens Axboe wrote: On 2/11/21 11:59 PM, Aneesh Kumar K.V wrote: Hi, I am trying to estabilish the behaviour we should expect when passing a buffer with memory keys attached to io_uring syscalls. As show in the blow test /* * gcc -Wall -O2 -D_GNU_SOURCE -o pkey_uring

usb: cdc-acm: BUG kmalloc-128 Poison overwritten

2021-02-12 Thread Bruno Thomsen
Hi, I have been experience random kernel oops in the cdc-acm driver on imx7 (arm arch). Normally it happens during the first 1-3min runtime after power-on. Below oops is from 5.8.17 mainline kernel with an extra patch back-ported in an attempt to fix it: 38203b8385 ("usb: cdc-acm: fix cooldown

Re: [PATCH 1/6] fs: Add flag to file_system_type to indicate content is generated

2021-02-12 Thread Ian Lance Taylor
On Fri, Feb 12, 2021 at 12:38 AM Greg KH wrote: > > Why are people trying to use copy_file_range on simple /proc and /sys > files in the first place? They can not seek (well most can not), so > that feels like a "oh look, a new syscall, let's use it everywhere!" > problem that userspace should

Re: [External] [PATCH v2 0/4] platform/surface: Add platform profile driver for Surface devices

2021-02-12 Thread Mark Pearson
On 11/02/2021 15:16, Maximilian Luz wrote: > This series adds a driver to provide platform profile support on 5th- > and later generation Microsoft Surface devices with a Surface System > Aggregator Module. On those devices, the platform profile can be used to > influence cooling behavior and

Re: linux-next: manual merge of the rcu tree with the block tree

2021-02-12 Thread Frederic Weisbecker
On Fri, Feb 12, 2021 at 08:30:27AM -0700, Jens Axboe wrote: > On 2/12/21 8:18 AM, Frederic Weisbecker wrote: > > On Thu, Feb 11, 2021 at 04:48:52PM +1100, Stephen Rothwell wrote: > >> Hi all, > >> > >> Today's linux-next merge of the rcu tree got conflicts in: > >> > >> include/linux/rcupdate.h

Re: [PATCH v3 3/3] tracing: Add ptr-hash option to show the hashed pointer value

2021-02-12 Thread Steven Rostedt
Hi Masami, I noticed theses sitting in my patchwork and I said I was going to hold off to the next merge window, and these got pushed down in my stack :-/ On Thu, 15 Oct 2020 23:55:25 +0900 Masami Hiramatsu wrote: > Add tracefs/options/hash-ptr option to show hashed pointer > value by %p in

Re: [PATCH v15 4/8] mm: hugetlb: alloc the vmemmap pages associated with each HugeTLB page

2021-02-12 Thread Michal Hocko
On Mon 08-02-21 16:50:09, Muchun Song wrote: > When we free a HugeTLB page to the buddy allocator, we should allocate the > vmemmap pages associated with it. But we may cannot allocate vmemmap pages > when the system is under memory pressure, in this case, we just refuse to > free the HugeTLB page

Re: [PATCH net-next 2/2] ptp: ptp_clockmatrix: Add alignment of 1 PPS to idtcm_perout_enable.

2021-02-12 Thread Richard Cochran
On Thu, Feb 11, 2021 at 11:38:45PM -0500, vincent.cheng...@renesas.com wrote: > From: Vincent Cheng > > When enabling output using PTP_CLK_REQ_PEROUT, need to align the output > clock to the internal 1 PPS clock. > > Signed-off-by: Vincent Cheng Acked-by: Richard Cochran

Re: [PATCH net-next 1/2] ptp: ptp_clockmatrix: Add wait_for_sys_apll_dpll_lock.

2021-02-12 Thread Richard Cochran
On Thu, Feb 11, 2021 at 11:38:44PM -0500, vincent.cheng...@renesas.com wrote: > +static int wait_for_sys_apll_dpll_lock(struct idtcm *idtcm) > +{ > + char *fmt = "%d ms SYS lock timeout: APLL Loss Lock %d DPLL state %d"; Probably you want: const char *fmt > diff --git

RE: [PATCH][next] bcache: Use 64-bit arithmetic instead of 32-bit

2021-02-12 Thread David Laight
> > if (c->gc_stats.in_use <= BCH_WRITEBACK_FRAGMENT_THRESHOLD_MID) > > { > > - fp_term = dc->writeback_rate_fp_term_low * > > + fp_term = (int64_t)dc->writeback_rate_fp_term_low * > > (c->gc_stats.in_use - > >

Re: linux-next: manual merge of the rcu tree with the block tree

2021-02-12 Thread Jens Axboe
On 2/12/21 8:18 AM, Frederic Weisbecker wrote: > On Thu, Feb 11, 2021 at 04:48:52PM +1100, Stephen Rothwell wrote: >> Hi all, >> >> Today's linux-next merge of the rcu tree got conflicts in: >> >> include/linux/rcupdate.h >> kernel/rcu/tree.c >> kernel/rcu/tree_plugin.h >> >> between

Re: [tip: objtool/urgent] objtool: Fix seg fault with Clang non-section symbols

2021-02-12 Thread Greg Kroah-Hartman
On Thu, Feb 11, 2021 at 10:46:05AM -0800, Nick Desaulniers wrote: > On Thu, Feb 11, 2021 at 5:55 AM Greg Kroah-Hartman > wrote: > > > > On Thu, Feb 11, 2021 at 09:32:03PM +0800, Xi Ruoyao wrote: > > > Hi all, > > > > > > The latest GNU assembler (binutils-2.36.1) is removing unused section > > >

[PATCH v4] printk: Userspace format enumeration support

2021-02-12 Thread Chris Down
We have a number of systems industry-wide that have a subset of their functionality that works as follows: 1. Receive a message from local kmsg, serial console, or netconsole; 2. Apply a set of rules to classify the message; 3. Do something based on this classification (like scheduling a

Re: [PATCH] RFC: x86/jump_label: Mark arguments as const to satisfy asm constraints

2021-02-12 Thread Peter Zijlstra
On Fri, Feb 12, 2021 at 09:40:59AM -0500, Steven Rostedt wrote: > On Thu, 11 Feb 2021 13:48:48 -0800 > Jason Gerecke wrote: > > > When compiling an external kernel module with `-O0` or `-O1`, the following > > compile error may be reported: > > > > ./arch/x86/include/asm/jump_label.h:25:2:

Re: linux-next: manual merge of the rcu tree with the block tree

2021-02-12 Thread Jens Axboe
On 2/11/21 10:38 AM, Paul E. McKenney wrote: > On Thu, Feb 11, 2021 at 04:48:52PM +1100, Stephen Rothwell wrote: >> Hi all, >> >> Today's linux-next merge of the rcu tree got conflicts in: >> >> include/linux/rcupdate.h >> kernel/rcu/tree.c >> kernel/rcu/tree_plugin.h >> >> between commits:

BUG: broken overlay causes very strange kernel crash

2021-02-12 Thread Enrico Weigelt, metux IT consult
Hi folks, while playing around with overlays, I've encountered a funny crash, that even seems to affect the filesystem. No idea what really happens, as oftree code detected the broken phandle. What I did: * i've written a driver that loads a builtin oftree overlay and tries to apply it. *

Re: [PATCH v6 3/7] usb: typec: tcpm: Determine common SVDM Version

2021-02-12 Thread Guenter Roeck
On 2/4/21 7:34 PM, Kyle Tso wrote: > PD Spec Revision 3.0 Version 2.0 + ECNs 2020-12-10 > 6.4.4.2.3 Structured VDM Version > "The Structured VDM Version field of the Discover Identity Command > sent and received during VDM discovery Shall be used to determine the > lowest common Structured

Re: linux-next: manual merge of the rcu tree with the block tree

2021-02-12 Thread Frederic Weisbecker
On Thu, Feb 11, 2021 at 09:38:02AM -0800, Paul E. McKenney wrote: > On Thu, Feb 11, 2021 at 04:48:52PM +1100, Stephen Rothwell wrote: > > Hi all, > > > > Today's linux-next merge of the rcu tree got conflicts in: > > > > include/linux/rcupdate.h > > kernel/rcu/tree.c > >

Re: [PATCH] Documentation: connector: Update the description of sink-vdos

2021-02-12 Thread Guenter Roeck
On Fri, Feb 12, 2021 at 03:37:43PM +0800, Kyle Tso wrote: > Remove the acronym "VDM" and replace it with the full name "Vendor > Defined Message". > > Signed-off-by: Kyle Tso Reviewed-by: Guenter Roeck > --- > .../devicetree/bindings/connector/usb-connector.yaml | 7 --- > 1 file

Re: [PATCH 5.4 00/24] 5.4.98-rc1 review

2021-02-12 Thread Naresh Kamboju
On Thu, 11 Feb 2021 at 20:36, Greg Kroah-Hartman wrote: > > This is the start of the stable review cycle for the 5.4.98 release. > There are 24 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me know. > >

Re: [PATCH net v1 1/3] net: phy: mscc: adding LCPLL reset to VSC8514

2021-02-12 Thread Andrew Lunn
On Fri, Feb 12, 2021 at 03:06:41PM +0100, Bjarni Jonasson wrote: > +static u32 vsc85xx_csr_read(struct phy_device *phydev, > + enum csr_target target, u32 reg); > +static int vsc85xx_csr_write(struct phy_device *phydev, > + enum csr_target target,

Re: linux-next: manual merge of the rcu tree with the block tree

2021-02-12 Thread Frederic Weisbecker
On Thu, Feb 11, 2021 at 04:48:52PM +1100, Stephen Rothwell wrote: > Hi all, > > Today's linux-next merge of the rcu tree got conflicts in: > > include/linux/rcupdate.h > kernel/rcu/tree.c > kernel/rcu/tree_plugin.h > > between commits: > > 3a7b5c87a0b2 ("rcu/nocb: Perform deferred wake

Re: [PATCH v6 3/7] usb: typec: tcpm: Determine common SVDM Version

2021-02-12 Thread Guenter Roeck
On Fri, Feb 12, 2021 at 03:24:22PM +0800, Kyle Tso wrote: > On Fri, Feb 12, 2021 at 3:10 PM Kyle Tso wrote: > > > Unless every time the local variable "svdm_version" is updated when > > "typec_partner_set_svdm_version" is called. > > > > I can do that if it is clearer to do so. > It just needs

Re: [PATCH] scripts/dtc: Update to upstream version v1.6.0-51-g183df9e9c2b9

2021-02-12 Thread Guenter Roeck
On Fri, Feb 12, 2021 at 08:16:04AM -0600, Rob Herring wrote: > On Thu, Feb 11, 2021 at 9:31 PM Guenter Roeck wrote: > > > > Hi Rob, > > > > On Wed, Feb 03, 2021 at 03:26:03PM -0600, Rob Herring wrote: > > > This adds the following commits from upstream: > > > > > > 183df9e9c2b9 gitignore: Ignore

[PATCH v5 net-next 10/10] net: dsa: sja1105: offload bridge port flags to device

2021-02-12 Thread Vladimir Oltean
From: Vladimir Oltean The chip can configure unicast flooding, broadcast flooding and learning. Learning is per port, while flooding is per {ingress, egress} port pair and we need to configure the same value for all possible ingress ports towards the requested one. While multicast flooding is

[PATCH v5 net-next 07/10] net: dsa: felix: restore multicast flood to CPU when NPI tagger reinitializes

2021-02-12 Thread Vladimir Oltean
From: Vladimir Oltean ocelot_init sets up PGID_MC to include the CPU port module, and that is fine, but the ocelot-8021q tagger removes the CPU port module from the unknown multicast replicator. So after a transition from the default ocelot tagger towards ocelot-8021q and then again towards

[PATCH v5 net-next 09/10] net: mscc: ocelot: offload bridge port flags to device

2021-02-12 Thread Vladimir Oltean
From: Vladimir Oltean We should not be unconditionally enabling address learning, since doing that is actively detrimential when a port is standalone and not offloading a bridge. Namely, if a port in the switch is standalone and others are offloading the bridge, then we could enter a situation

[PATCH v5 net-next 08/10] net: mscc: ocelot: use separate flooding PGID for broadcast

2021-02-12 Thread Vladimir Oltean
From: Vladimir Oltean In preparation of offloading the bridge port flags which have independent settings for unknown multicast and for broadcast, we should also start reserving one destination Port Group ID for the flooding of broadcast packets, to allow configuring it individually.

[PATCH v5 net-next 05/10] net: switchdev: pass flags and mask to both {PRE_,}BRIDGE_FLAGS attributes

2021-02-12 Thread Vladimir Oltean
From: Vladimir Oltean This switchdev attribute offers a counterproductive API for a driver writer, because although br_switchdev_set_port_flag gets passed a "flags" and a "mask", those are passed piecemeal to the driver, so while the PRE_BRIDGE_FLAGS listener knows what changed because it has

[PATCH v5 net-next 06/10] net: dsa: act as passthrough for bridge port flags

2021-02-12 Thread Vladimir Oltean
From: Vladimir Oltean There are multiple ways in which a PORT_BRIDGE_FLAGS attribute can be expressed by the bridge through switchdev, and not all of them can be emulated by DSA mid-layer API at the same time. One possible configuration is when the bridge offloads the port flags using a mask

[PATCH v5 net-next 04/10] net: dsa: configure better brport flags when ports leave the bridge

2021-02-12 Thread Vladimir Oltean
From: Vladimir Oltean For a DSA switch port operating in standalone mode, address learning doesn't make much sense since that is a bridge function. In fact, address learning even breaks setups such as this one: +-+ |

[PATCH v5 net-next 03/10] net: bridge: don't print in br_switchdev_set_port_flag

2021-02-12 Thread Vladimir Oltean
From: Vladimir Oltean For the netlink interface, propagate errors through extack rather than simply printing them to the console. For the sysfs interface, we still print to the console, but at least that's one layer higher than in switchdev, which also allows us to silently ignore the offloading

[PATCH v5 net-next 02/10] net: bridge: offload all port flags at once in br_setport

2021-02-12 Thread Vladimir Oltean
From: Vladimir Oltean If for example this command: ip link set swp0 type bridge_slave flood off mcast_flood off learning off succeeded at configuring BR_FLOOD and BR_MCAST_FLOOD but not at BR_LEARNING, there would be no attempt to revert the partial state in any way. Arguably, if the user

[PATCH v5 net-next 01/10] net: switchdev: propagate extack to port attributes

2021-02-12 Thread Vladimir Oltean
From: Vladimir Oltean When a struct switchdev_attr is notified through switchdev, there is no way to report informational messages, unlike for struct switchdev_obj. Signed-off-by: Vladimir Oltean Reviewed-by: Ido Schimmel Reviewed-by: Florian Fainelli --- Changes in v5: Rebased on top of

Re: Memory keys and io_uring.

2021-02-12 Thread Jens Axboe
On 2/11/21 11:59 PM, Aneesh Kumar K.V wrote: > > Hi, > > I am trying to estabilish the behaviour we should expect when passing a > buffer with memory keys attached to io_uring syscalls. As show in the > blow test > > /* > * gcc -Wall -O2 -D_GNU_SOURCE -o pkey_uring pkey_uring.c -luring > */

[PATCH v5 net-next 00/10] Cleanup in brport flags switchdev offload for DSA

2021-02-12 Thread Vladimir Oltean
From: Vladimir Oltean The initial goal of this series was to have better support for standalone ports mode on the DSA drivers like ocelot/felix and sja1105. This turned out to require some API adjustments in both directions: to the information presented to and by the switchdev notifier, and to

[PATCH v2] psi: Use ONCPU state tracking machinery to detect reclaim

2021-02-12 Thread Chengming Zhou
Move the reclaim detection from the timer tick to the task state tracking machinery using the recently added ONCPU state. And we also add task psi_flags changes checking in the psi_task_switch() optimization to update the parents properly. In terms of performance and cost, this ONCPU task state

[PATCH net-next 1/2] net: mvneta: Remove per-cpu queue mapping for Armada 3700

2021-02-12 Thread Maxime Chevallier
According to Errata #23 "The per-CPU GbE interrupt is limited to Core 0", we can't use the per-cpu interrupt mechanism on the Armada 3700 familly. This is correctly checked for RSS configuration, but the initial queue mapping is still done by having the queues spread across all the CPUs in the

Re: [PATCH 02/27] x86/syscalls: fix -Wmissing-prototypes warnings from COND_SYSCALL()

2021-02-12 Thread Mickaël Salaün
Could you please push this patch to Linus? Thanks. On 04/02/2021 15:16, Mickaël Salaün wrote: > > On 28/01/2021 01:50, Masahiro Yamada wrote: >> Building kernel/sys_ni.c with W=1 omits tons of -Wmissing-prototypes >> warnings. >> >> $ make W=1 kernel/sys_ni.o >> [ snip ] >> CC

[PATCH net-next 2/2] net: mvneta: Implement mqprio support

2021-02-12 Thread Maxime Chevallier
Implement a basic MQPrio support, inserting rules in RX that translate the TC to prio mapping into vlan prio to queues. The TX logic stays the same as when we don't offload the qdisc. Signed-off-by: Maxime Chevallier --- drivers/net/ethernet/marvell/mvneta.c | 65 +++ 1

[PATCH net-next 0/2] net: mvneta: Implement basic MQPrio support

2021-02-12 Thread Maxime Chevallier
Hi everyone, This small series adds basic support for mqprio offloading, by having the rx queueing mirroring the TCs based on VLAN prio fields. This was tested on Armada 3700, and proves useful to make sure high-priority traffic has a better chance not getting dropped when there's lots of

Re: [PATCH] drivers/perf: Replace spin_lock_irqsave to spin_lock

2021-02-12 Thread Will Deacon
On Tue, 9 Feb 2021 17:42:22 +0800, Qi Liu wrote: > There is no need to do spin_lock_irqsave in context of hard IRQ, so > replace them with spin_lock. Applied to will (for-next/perf), thanks! [1/1] drivers/perf: Replace spin_lock_irqsave to spin_lock

Re: [PATCH] [v13] wireless: Initial driver submission for pureLiFi STA devices

2021-02-12 Thread kernel test robot
git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Srinivasan-Raju/wireless-Initial-driver-submission-for-pureLiFi-STA-devices/20210212-195451 base

[PATCH v2][next] octeontx2-pf: Fix out-of-bounds read warning in otx2_get_fecparam()

2021-02-12 Thread Gustavo A. R. Silva
Line at 967 implies that rsp->fwdata.supported_fec may be up to 4: if (rsp->fwdata.supported_fec <= FEC_MAX_INDEX) which would cause an out-of-bounds read at line 971: fecparam->fec = fec[rsp->fwdata.supported_fec]; However, the range of values for rsp->fwdata.supported_fec is 0 to 3. Fix the

Re: [GIT PULL tip/core/rcu] RCU, LKMM, and KCSAN commits for v5.12

2021-02-12 Thread Paul E. McKenney
On Fri, Feb 12, 2021 at 01:31:09PM +0100, Ingo Molnar wrote: > > * Paul E. McKenney wrote: > > > Hello, Ingo! > > > > This pull request contains changes for RCU, KCSAN, LKMM, and nolibc. > > You can pull the entire group using branch for-mingo. Or, if you prefer, > > you can pull them

RE: [RESEND RFC PATCH v2] arm64: Exposes support for 32-bit syscalls

2021-02-12 Thread David Laight
> > Any user space adaption layer would have to know which actual > > driver has been opened and what internal structures it has. > > Getting that right is hard and difficult. > > The recent changes to move (IIRC) sockopt compatibility down > > into the protocol code found quite a few places where

[ANNOUNCE] util-linux v2.36.2

2021-02-12 Thread Karel Zak
The util-linux stable maintenance release v2.36.2 is available at http://www.kernel.org/pub/linux/utils/util-linux/v2.36/ Feedback and bug reports, as always, are welcomed. Karel util-linux 2.36.2 Release Notes === agetty: - tty eol defaults to REPRINT

Re: [PATCH] Fix space prohibited issue in fbtft-bus.c

2021-02-12 Thread Greg KH
On Fri, Feb 12, 2021 at 04:58:33PM +0200, Alaa Emad wrote: > This change fixes a checkpatch error for "space prohibited before that close > parenthesis ')'" > > Signed-off-by: Alaa Emad > --- > certs/x509_revocation_list| 0 > drivers/staging/fbtft/fbtft-bus.c | 4 ++-- > 2 files

Re: [PATCH v2 4/4] arm: dts: visconti: Add DT support for Toshiba Visconti5 ethernet controller

2021-02-12 Thread Nobuhiro Iwamatsu
Hi, Thanks for your review. On Fri, Feb 12, 2021 at 10:32:09AM +0100, Arnd Bergmann wrote: > On Fri, Feb 12, 2021 at 4:03 AM Nobuhiro Iwamatsu > wrote: > > @@ -384,6 +398,16 @@ spi6: spi@28146000 { > > #size-cells = <0>; > > status = "disabled"; >

Re: [PATCH 1/6] fs: Add flag to file_system_type to indicate content is generated

2021-02-12 Thread Luis Henriques
Greg KH writes: > On Fri, Feb 12, 2021 at 12:41:48PM +, Luis Henriques wrote: >> Greg KH writes: ... >> >> >> Our option now are: >> >> >> - Restore the cross-fs restriction into generic_copy_file_range() >> >> > >> >> > Yes. >> >> > >> >> >> >> Restoring this restriction will actually

[PATCH] Fix space prohibited issue in fbtft-bus.c

2021-02-12 Thread Alaa Emad
This change fixes a checkpatch error for "space prohibited before that close parenthesis ')'" Signed-off-by: Alaa Emad --- certs/x509_revocation_list| 0 drivers/staging/fbtft/fbtft-bus.c | 4 ++-- 2 files changed, 2 insertions(+), 2 deletions(-) create mode 100644

Re: [PATCH v2 4/4] arm64: dts: ti: k3-am65-main: Add device_type to pcie*_rc nodes

2021-02-12 Thread Kishon Vijay Abraham I
On 12/02/21 1:02 am, Jan Kiszka wrote: > From: Jan Kiszka > > This is demanded by the parent binding of ti,am654-pcie-rc, see > Documentation/devicetree/bindings/pci/designware-pcie.txt. > > Signed-off-by: Jan Kiszka Reviewed-by: Kishon Vijay Abraham I > --- >

RE: [PATCH v2] iommu: Check dev->iommu in iommu_dev_xxx functions

2021-02-12 Thread Shameerali Kolothum Thodi
Hi Robin/Joerg, > -Original Message- > From: Shameer Kolothum [mailto:shameerali.kolothum.th...@huawei.com] > Sent: 01 February 2021 12:41 > To: linux-kernel@vger.kernel.org; io...@lists.linux-foundation.org > Cc: j...@8bytes.org; robin.mur...@arm.com; jean-phili...@linaro.org; >

Re: [PATCH] mtd: physmap: physmap-bt1-rom: Fix unintentional stack access

2021-02-12 Thread Miquel Raynal
Hi Gustavo, "Gustavo A. R. Silva" wrote on Fri, 12 Feb 2021 08:45:33 -0600: > On 2/12/21 08:12, Miquel Raynal wrote: > > Hi Gustavo, > > > > "Gustavo A. R. Silva" wrote on Fri, 12 Feb 2021 > > 04:40:22 -0600: > > > >> Cast to (char *) in order to avoid unintentionally accessing > >> the

[PATCH][next] octeontx2-pf: Fix out-of-bounds read in otx2_get_fecparam()

2021-02-12 Thread Hariprasad Kelam
Hi Gustavo , Please see inline, > -Original Message- > From: Gustavo A. R. Silva > Sent: Friday, February 12, 2021 5:53 PM > To: Sunil Kovvuri Goutham ; Geethasowjanya > Akula ; Subbaraya Sundeep Bhatta > ; Hariprasad Kelam ; David > S. Miller ; Jakub Kicinski ; Jesse > Brandeburg ;

Re: [PATCH v13 3/7] kasan: Add report for async mode

2021-02-12 Thread Andrey Konovalov
On Fri, Feb 12, 2021 at 12:21 PM Vincenzo Frascino wrote: > > Hi Andrey, > > On 2/11/21 8:13 PM, Andrey Konovalov wrote: > riscv64-linux-ld: report.c:(.text+0x5c4): undefined reference to > `kasan_flag_async' > > Let's do something like this (untested): > > > >

Re: [PATCH 5/6] tracefs: Add FS_GENERATED_CONTENT to filesystem flags

2021-02-12 Thread Steven Rostedt
On Fri, 12 Feb 2021 12:44:04 +0800 Nicolas Boichat wrote: > tracefs content is generated at runtime. > > Signed-off-by: Nicolas Boichat Acked-by: Steven Rostedt (VMware) -- Steve > --- > > fs/tracefs/inode.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/fs/tracefs/inode.c

[PATCH 7/7] perf cs-etm: Suppress printing when resetting decoder

2021-02-12 Thread James Clark
The decoder is quite noisy when being reset. Now that dump-raw-trace uses a code path that resets the decoder rather than creating a new one, printing has to be suppressed to not flood the output. Signed-off-by: James Clark --- tools/perf/util/cs-etm-decoder/cs-etm-decoder.c | 10 +++--- 1

[PATCH 5/7] perf cs-etm: split decode by aux records.

2021-02-12 Thread James Clark
The trace data between aux records is not continuous, so the decoder must be reset between each record to ensure that parsing happens correctly and without any early exits. Signed-off-by: James Clark --- tools/perf/util/cs-etm.c | 109 +++ 1 file changed, 64

[PATCH 3/7] perf cs-etm: Save aux records in each etm queue

2021-02-12 Thread James Clark
The aux records will be used set the bounds of decoding in a later commit. In the future we may also want to use the flags of each record to control decoding. Do these need to be saved in their entirety, or can pointers to each record safely be saved instead for later access? Signed-off-by:

[PATCH 6/7] perf cs-etm: Use existing decode code path for --dump-raw-trace

2021-02-12 Thread James Clark
Previously the dump mode created a new decoder for each buffer and had a different decode loop to the main code paths. This change uses more of the existing code path which tracks aux records and resets the decoder between each one. Unfortunately the decoder is quite noisy when being reset, so

[PATCH 4/7] perf cs-etm: don't process queues until cs_etm__flush_events

2021-02-12 Thread James Clark
To make sure processing happens in the correct order, queue processing shouldn't start until every aux queue has had its first timestamp found. Now that we're only searching for timestamps within each aux record, we need to wait until all aux records are delivered before starting the processing.

[PATCH 2/7] perf cs-etm: Only search timestamp in current sample's queue.

2021-02-12 Thread James Clark
Change initial timestamp search to only operate on the queue related to the current event. In a later change the bounds of the aux record will also be used to reset the decoder and the record is only relevant to a single queue. This change makes some files that had coresight data but didn't

[PATCH 0/7] Split Coresight decode by aux records

2021-02-12 Thread James Clark
Hi All, Since my previous RFC, I've fixed --per-thread mode and solved most of the open questions. I've also changed --dump-raw-trace to use the same code path so it's also working now. I think the only open questions are: * General approach * If aux records need to be saved, or if they can

[PATCH 1/7] perf cs-etm: Split up etm queue setup function

2021-02-12 Thread James Clark
Refactor the function into separate allocation and timestamp search parts. Later the timestamp search will be done multiple times. Signed-off-by: James Clark --- tools/perf/util/cs-etm.c | 60 +--- 1 file changed, 31 insertions(+), 29 deletions(-) diff --git

[GIT PULL] tracing: Check length before giving out the filter buffer

2021-02-12 Thread Steven Rostedt
Steven Rostedt (VMware) Linus, tracing: Fix buffer overflow in trace event filter It was reported that if a trace event was larger than a page and was filtered, that it caused memory corruption. The reason is that filtered events first go into a buffer to test the filter before being written

<    1   2   3   4   5   6   7   8   9   10   >