[PATCH v2] PCI: quirk for preventing bus reset on TI C667X

2021-02-28 Thread Antti Järvinen
Some TI keystone C667X devices do no support bus/hot reset. Its PCIESS automatically disables LTSSM when secondary bus reset is received and device stops working. Prevent bus reset by adding quirk_no_bus_reset to the device. With this change device can be assigned to VMs with VFIO, but it will leak

Re: [PATCH v3 2/2] mm: Make alloc_contig_range handle in-use hugetlb pages

2021-02-28 Thread Oscar Salvador
On Fri, Feb 26, 2021 at 01:46:21PM +0100, Michal Hocko wrote: > Well, I will leave it to others. I do not feel strongly about this but > to me it makes the code harder to think about because the situation is > unstable and any of those condition can change as they are evaluated. So > an explicit ch

Re: BUG: KASAN: use-after-free in __list_add_valid+0x81/0xa0 (5.11-rc4)

2021-02-28 Thread Mikhail Gavrilov
On Sat, 13 Feb 2021 at 08:03, Hillf Danton wrote: > > The comment below shows a race instance, though I failed to put things > together to see how within two hours. Cut it and see what will come up. > > --- a/mm/z3fold.c > +++ b/mm/z3fold.c > @@ -1129,19 +1129,22 @@ retry: > page = NULL; >

[PATCH 11/11] arm64: dts: qcom: msm8996: Clean up the SDHCI2 node

2021-02-28 Thread Konrad Dybcio
Fix the indentation, add pinctrl and move status="disabled" down. Signed-off-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/msm8996.dtsi | 33 +++ 1 file changed, 19 insertions(+), 14 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/

[PATCH 08/11] arm64: dts: qcom: pm8994: Add RESIN node

2021-02-28 Thread Konrad Dybcio
Add a RESIN node to support RESIN-connected buttons on some devices. Signed-off-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/apq8096-db820c.dtsi | 19 +-- arch/arm64/boot/dts/qcom/pm8994.dtsi | 8 +++- 2 files changed, 12 insertions(+), 15 deletions(-) diff --git

[PATCH 07/11] arm64: dts: qcom: msm8996: Disable Venus by default

2021-02-28 Thread Konrad Dybcio
Disable Venus by default to allow booting without closed firmware and enable it on the boards that didn't previously disable it. This commit brings no functional difference. Signed-off-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/apq8096-db820c.dtsi | 4 arch/arm64/boot/dts/qcom/apq8096-i

[PATCH 10/11] arm64: dts: qcom: pmi8994: Add WLED node

2021-02-28 Thread Konrad Dybcio
Add and configure WLED node to enable backlight control on WLED-enabled devices. Signed-off-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/pmi8994.dtsi | 13 + 1 file changed, 13 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/pmi8994.dtsi b/arch/arm64/boot/dts/qcom/pmi8994.dts

[PATCH 09/11] arm64: dts: qcom: msm8996: Add DSI0 nodes

2021-02-28 Thread Konrad Dybcio
Add required nodes to support DSI displays connected to the primary interface. Signed-off-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/msm8996.dtsi | 78 +++ 1 file changed, 78 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom

[PATCH 04/11] arm64: dts: qcom: msm8996: Add SDHCI1

2021-02-28 Thread Konrad Dybcio
Add SDHCI1 device to allow for usage of (more often than not) eMMC. Signed-off-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/msm8996.dtsi | 23 +++ 1 file changed, 23 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi i

[PATCH 06/11] arm64: dts: qcom: msm8996: Disable MDSS and Adreno by default

2021-02-28 Thread Konrad Dybcio
Disable them by default to allow for booting without a display and proprietary firmware. Then, enable them on boards that didn't previously disable them. Hence, this commit brings no functional difference. Signed-off-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/apq8096-db820c.dtsi | 4 ar

[PATCH 02/11] arm64: dts: qcom: msm8996-*: Clean up QUP and UART names

2021-02-28 Thread Konrad Dybcio
QUP and UART names start from 1. There are 6 QUPs and 2 UARTs per BLSP. Let's not further confuse programmers by stating otherwise. Signed-off-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/apq8096-db820c.dtsi | 36 ++-- arch/arm64/boot/dts/qcom/apq8096-ifc6640.dts | 4 +-- arch

[PATCH 05/11] arm64: dts: qcom: msm8996: Add BLSP2_I2C5 and BLSP2_I2C6

2021-02-28 Thread Konrad Dybcio
Add the fifth and sixth I2C host on the second BLSP, used for various board-specific peripherals. Signed-off-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/msm8996.dtsi | 29 +++ 1 file changed, 29 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/

[PATCH 03/11] arm64: dts: qcom: msm8996: Enlarge tcsr_mutex_regs size

2021-02-28 Thread Konrad Dybcio
Set the tcsr_mutex_regs size to 0x4 to allow for accessing all required registers that will be needed to support modem. Signed-off-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/msm8996.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/qcom/msm8996.

[PATCH 01/11] arm64: dts: qcom: msm8996: Sanitize pins

2021-02-28 Thread Konrad Dybcio
In order to prepare for feature development, the DTs have to be workable with.. To achieve that: - Rename msmgpio to tlmm (consistency with newer DTs) - Rid msm8996-pins.dtsi and add the contents to msm8996.dtsi - Modernize the pin nodes, make them more concise - Add generic pin configuration for

[PATCH] drm/msm/dsi: Uncomment core_mmss clock for MSM8996

2021-02-28 Thread Konrad Dybcio
From: AngeloGioacchino Del Regno The MSM8996 core_mmss clock was commented out due to some strange issues that others were experiencing. At least SONY Tone family is working perfectly fine with this clock declared and gets it up and running without any error. Signed-off-by: AngeloGioacchino Del

[PATCH 1/2] dt-bindings: leds: backlight: qcom-wled: Add PMI8994 compatible

2021-02-28 Thread Konrad Dybcio
Document the newly added PMI8994 compatible. Signed-off-by: Konrad Dybcio --- Documentation/devicetree/bindings/leds/backlight/qcom-wled.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/leds/backlight/qcom-wled.yaml b/Documentation/devicetree/bindings/l

[PATCH 2/2] video: backlight: qcom-wled: Add PMI8994 compatible

2021-02-28 Thread Konrad Dybcio
Add a compatible for PMI8994 WLED. It uses the V4 of WLED IP. Signed-off-by: Konrad Dybcio --- drivers/video/backlight/qcom-wled.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/video/backlight/qcom-wled.c b/drivers/video/backlight/qcom-wled.c index 3bc7800eb0a9..497b9035a908 10064

[PATCH] drm/msm/adreno: a5xx_power: Don't apply A540 lm_setup to other GPUs

2021-02-28 Thread Konrad Dybcio
While passing the A530-specific lm_setup func to A530 and A540 to !A530 was fine back when only these two were supported, it certainly is not a good idea to send A540 specifics to smaller GPUs like A508 and friends. Signed-off-by: Konrad Dybcio --- drivers/gpu/drm/msm/adreno/a5xx_power.c | 2 +-

[PATCH] iwlegacy: Add missing check in il4965_commit_rxon

2021-02-28 Thread Dinghao Liu
There is one il_set_tx_power() call in this function without return value check. Print error message and return error code on failure just like the other il_set_tx_power() call. Signed-off-by: Dinghao Liu --- drivers/net/wireless/intel/iwlegacy/4965.c | 6 +- 1 file changed, 5 insertions(+),

Re: [PATCH v6 9/9] ALSA: virtio: introduce device suspend/resume support

2021-02-28 Thread Takashi Iwai
On Sat, 27 Feb 2021 09:59:56 +0100, Anton Yakovlev wrote: > > All running PCM substreams are stopped on device suspend and restarted > on device resume. > > Signed-off-by: Anton Yakovlev > --- > sound/virtio/virtio_card.c| 56 +++ > sound/virtio/virtio_pcm.c

Re: [PATCH v3 1/2] mtd: spi-nor: add OTP support

2021-02-28 Thread Tudor.Ambarus
Hi, Michael, On 2/16/21 6:28 PM, Michael Walle wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > SPI flashes sometimes have a special OTP area, which can (and is) used to > store immutable properties like board serial number or vendor assig

[PATCH] i40e: Fix error handling in i40e_vsi_open

2021-02-28 Thread Dinghao Liu
When vsi->type == I40E_VSI_FDIR, we have caught the return value of i40e_vsi_request_irq() but without further handling. Check and execute memory clean on failure just like the other i40e_vsi_request_irq(). Fixes: 8a9eb7d3cbcab ("i40e: rework fdir setup and teardown") Signed-off-by: Dinghao Liu -

Re: [PATCH 11/20] hwmon: Manual replacement of the deprecated strlcpy() with return values

2021-02-28 Thread Joe Perches
On Mon, 2021-02-22 at 07:46 -0800, Guenter Roeck wrote: > On 2/22/21 7:12 AM, Romain Perier wrote: > > The strlcpy() reads the entire source buffer first, it is dangerous if > > the source buffer lenght is unbounded or possibility non NULL-terminated. > > length > > > It can lead to linear read o

Re: [BISECTED] Kernel 5.11.x breaks pulseaudio

2021-02-28 Thread Heinz Diehl
On 28.02.2021, Takashi Iwai wrote: > The fix I merged today can also work around your problem. > Please give it a try. > > https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git/commit/?id=5f5e6a3e8b1df52f79122e447855cffbf1710540 Applied on top of 5.11.2 - now pulseaudio works perfec

Re: [PATCH v6 6/9] ALSA: virtio: PCM substream operators

2021-02-28 Thread Takashi Iwai
On Sat, 27 Feb 2021 09:59:53 +0100, Anton Yakovlev wrote: > > +static int virtsnd_pcm_trigger(struct snd_pcm_substream *substream, int > command) > +{ > + struct virtio_pcm_substream *vss = snd_pcm_substream_chip(substream); > + struct virtio_snd *snd = vss->snd; > + struct virtio_snd

Re: [PATCH v6 5/9] ALSA: virtio: handling control and I/O messages for the PCM device

2021-02-28 Thread Takashi Iwai
On Sat, 27 Feb 2021 09:59:52 +0100, Anton Yakovlev wrote: > +/** > + * virtsnd_pcm_event() - Handle the PCM device event notification. > + * @snd: VirtIO sound device. > + * @event: VirtIO sound event. > + * > + * Context: Interrupt context. OK, then nonatomic PCM flag is invalid... > +/** > + *

Re: [PATCH v5 0/4] Introduce pcim_alloc_irq_vectors()

2021-02-28 Thread Dejin Zheng
On Fri, Feb 26, 2021 at 08:20:55PM +0100, Robert Richter wrote: > On 26.02.21 23:50:52, Dejin Zheng wrote: > > Introduce pcim_alloc_irq_vectors(), a device-managed version of > > pci_alloc_irq_vectors(), In some i2c drivers, If pcim_enable_device() > > has been called before, then pci_alloc_irq_vec

Re: [PATCH v5 1/4] PCI: Introduce pcim_alloc_irq_vectors()

2021-02-28 Thread Dejin Zheng
On Fri, Feb 26, 2021 at 06:23:02PM +0200, Andy Shevchenko wrote: > On Fri, Feb 26, 2021 at 11:50:53PM +0800, Dejin Zheng wrote: > > Introduce pcim_alloc_irq_vectors(), a device-managed version of > > pci_alloc_irq_vectors(). Introducing this function can simplify > > the error handling path in many

Re: [PATCH v6 4/9] ALSA: virtio: build PCM devices and substream hardware descriptors

2021-02-28 Thread Takashi Iwai
On Sat, 27 Feb 2021 09:59:51 +0100, Anton Yakovlev wrote: > +static int virtsnd_pcm_build_hw(struct virtio_pcm_substream *vss, > + struct virtio_snd_pcm_info *info) > +{ > + for (i = 0; i < ARRAY_SIZE(g_v2a_format_map); ++i) > + if (values & (1ULL <<

Re: [RFC PATCH 3/4] KVM: arm64: Install the block entry before unmapping the page mappings

2021-02-28 Thread wangyanan (Y)
On 2021/2/8 19:22, Yanan Wang wrote: When KVM needs to coalesce the normal page mappings into a block mapping, we currently invalidate the old table entry first followed by invalidation of TLB, then unmap the page mappings, and install the block entry at last. It will cost a long time to unmap

[PATCH] riscv: fix bugon.cocci warnings

2021-02-28 Thread Julia Lawall
From: kernel test robot Use BUG_ON instead of a if condition followed by BUG. Generated by: scripts/coccinelle/misc/bugon.cocci Fixes: c22b0bcb1dd0 ("riscv: Add kprobes supported") CC: Guo Ren Reported-by: kernel test robot Signed-off-by: kernel test robot Signed-off-by: Julia Lawall --- t

Re: [PATCH v6 3/9] ALSA: virtio: handling control messages

2021-02-28 Thread Takashi Iwai
On Sat, 27 Feb 2021 09:59:50 +0100, Anton Yakovlev wrote: > > --- a/sound/virtio/virtio_card.c > +++ b/sound/virtio/virtio_card.c > @@ -11,6 +11,10 @@ > > #include "virtio_card.h" > > +int msg_timeout_ms = MSEC_PER_SEC; > +module_param(msg_timeout_ms, int, 0644); > +MODULE_PARM_DESC(msg_timeo

[PATCH v3 6/6] can: c_can: add support to 64 message objects

2021-02-28 Thread Dario Binacchi
D_CAN controller supports 16, 32, 64 or 128 message objects, comparing to 32 on C_CAN. AM335x/AM437x Sitara processors and DRA7 SOC all instantiate a D_CAN controller with 64 message objects, as described in the "DCAN features" subsection of the CAN chapter of their technical reference manuals. Th

[PATCH v3 3/6] can: c_can: fix control interface used by c_can_do_tx

2021-02-28 Thread Dario Binacchi
According to commit 640916db2bf7 ("can: c_can: Make it SMP safe") let RX use IF1 (i.e. IF_RX) and TX use IF2 (i.e. IF_TX). Signed-off-by: Dario Binacchi --- (no changes since v1) drivers/net/can/c_can/c_can.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/can/c

[PATCH v3 2/6] can: c_can: fix indentation

2021-02-28 Thread Dario Binacchi
Commit 524369e2391f ("can: c_can: remove obsolete STRICT_FRAME_ORDERING Kconfig option") left behind wrong indentation, fix it. Signed-off-by: Dario Binacchi --- (no changes since v1) drivers/net/can/c_can/c_can.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net

[PATCH v3 4/6] can: c_can: use 32-bit write to set arbitration register

2021-02-28 Thread Dario Binacchi
The arbitration register is already set up with 32-bit writes in the other parts of the code except for this point. Signed-off-by: Dario Binacchi --- (no changes since v1) drivers/net/can/c_can/c_can.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/can/c_can/

[PATCH v3 5/6] can: c_can: prepare to up the message objects number

2021-02-28 Thread Dario Binacchi
As pointed by commit c0a9f4d396c9 ("can: c_can: Reduce register access") the "driver casts the 16 message objects in stone, which is completely braindead as contemporary hardware has up to 128 message objects". The patch prepares the module to extend the number of message objects beyond the 32 cur

[PATCH v3 1/6] can: c_can: remove unused code

2021-02-28 Thread Dario Binacchi
Commit 9d23a9818cb1 ("can: c_can: Remove unused inline function") left behind C_CAN_MSG_OBJ_TX_LAST constant. Commit fa39b54ccf28 ("can: c_can: Get rid of pointless interrupts") left behind C_CAN_MSG_RX_LOW_LAST and C_CAN_MSG_OBJ_RX_SPLIT constants. The removed code also made a comment useless an

[PATCH v3 0/6] can: c_can: add support to 64 message objects

2021-02-28 Thread Dario Binacchi
The D_CAN controller supports up to 128 messages. Until now the driver only managed 32 messages although Sitara processors and DRA7 SOC can handle 64. The series was tested on a beaglebone board. Note: I have not changed the type of tx_field (belonging to the c_can_priv structure) to atomic64_t

Re: [PATCH v2 3/6] can: c_can: fix control interface used by c_can_do_tx

2021-02-28 Thread Dario Binacchi
Hi Marc, > Il 26/02/2021 09:44 Marc Kleine-Budde ha scritto: > > > On 25.02.2021 22:51:52, Dario Binacchi wrote: > > According to commit 640916db2bf7 ("can: c_can: Make it SMP safe") let RX use > > IF1 (i.e. IF_RX) and TX use IF2 (i.e. IF_TX). > > Is this a fix? > I think that If I consider

Re: [PATCH v2 5/6] can: c_can: prepare to up the message objects number

2021-02-28 Thread Dario Binacchi
Hi Marc, > Il 26/02/2021 09:33 Marc Kleine-Budde ha scritto: > > > On 25.02.2021 22:51:54, Dario Binacchi wrote: > > As pointed by commit c0a9f4d396c9 ("can: c_can: Reduce register access") > > the "driver casts the 16 message objects in stone, which is completely > > braindead as contemporary

KASAN: use-after-free Read in tctx_task_work

2021-02-28 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:29c395c7 Merge tag 'x86-entry-2021-02-24' of git://git.ker.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=11cd05cad0 kernel config: https://syzkaller.appspot.com/x/.config?x=c581c545cb4ffac7 das

KASAN: null-ptr-deref Read in __fget_light

2021-02-28 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:3b9cdafb Merge tag 'pinctrl-v5.12-1' of git://git.kernel.o.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=114ac832d0 kernel config: https://syzkaller.appspot.com/x/.config?x=22008533485b2c35 das

[PATCH] e1000e: Fix error handling in e1000_set_d0_lplu_state_82571

2021-02-28 Thread Dinghao Liu
There is one e1e_wphy() call in e1000_set_d0_lplu_state_82571 that we have caught its return value but lack further handling. Check and terminate the execution flow just like other e1e_wphy() in this function. Signed-off-by: Dinghao Liu --- drivers/net/ethernet/intel/e1000e/82571.c | 2 ++ 1 fil

Re: [PATCH 2/2] drivers: misc: add ripple counter driver

2021-02-28 Thread Andy Shevchenko
On Sun, Feb 28, 2021 at 11:29 AM Andy Shevchenko wrote: > > On Sun, Feb 28, 2021 at 11:07 AM Andy Shevchenko > wrote: > > On Friday, February 26, 2021, Rasmus Villemoes > > wrote: > >> > >> The only purpose of this driver is to serve as a consumer of the input > >> clock, to prevent it from bei

Re: [drm/i915/gt] 8c3b1ba0e7: perf-sanity-tests.Parse_event_definition_strings.fail

2021-02-28 Thread Jiri Olsa
On Sat, Feb 27, 2021 at 11:21:25AM +0100, Jiri Olsa wrote: > On Fri, Feb 26, 2021 at 08:41:26AM +0800, Jin, Yao wrote: > > SNIP > > > > + SET_SYMBOL(prefix, PMU_EVENT_SYMBOL); > > > len++; > > > } > > >

[PATCH] tpm: Add missing check in tpm_inf_recv

2021-02-28 Thread Dinghao Liu
The use of wait() in tpm_inf_recv() is almost the same. It's odd that we only check the return value and terminate execution flow of one call. Signed-off-by: Dinghao Liu --- drivers/char/tpm/tpm_infineon.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/char/tpm/tp

Re: [PATCH 2/2] drivers: misc: add ripple counter driver

2021-02-28 Thread Andy Shevchenko
On Sun, Feb 28, 2021 at 11:07 AM Andy Shevchenko wrote: > On Friday, February 26, 2021, Rasmus Villemoes > wrote: >> >> The only purpose of this driver is to serve as a consumer of the input >> clock, to prevent it from being disabled by clk_disable_unused(). > > We have a clock API to do the sa

net/ceph/messenger_v1.c:1355:5: warning: stack frame size of 1136 bytes in function 'ceph_con_v1_try_write'

2021-02-28 Thread kernel test robot
-r026-20210228 (attached as .config) compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project e0b1df924ae06d6d88582334087d2eacc6702e8f) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod

Re: [RFC 1/6] vdso/extable: fix calculation of base

2021-02-28 Thread Nadav Amit
> On Feb 26, 2021, at 9:47 AM, Sean Christopherson wrote: > > On Fri, Feb 26, 2021, Nadav Amit wrote: >> >>> On Feb 25, 2021, at 1:16 PM, Sean Christopherson wrote: >>> It's been literally years since I wrote this code, but I distinctly >>> remember the >>> addresses being relative to the ba

Re: [PATCH 19/20] usbip: usbip_host: Manual replacement of the deprecated strlcpy() with return values

2021-02-28 Thread Sergei Shtylyov
Hello! On 22.02.2021 18:12, Romain Perier wrote: The strlcpy() reads the entire source buffer first, it is dangerous if the source buffer lenght is unbounded or possibility non NULL-terminated. Length. Possibly? It can lead to linear read overflows, crashes, etc... As recommended in the

Re: [PATCH v2 2/2] memblock: do not start bottom-up allocations with kernel_end

2021-02-28 Thread Mike Rapoport
Hi Florian, On Sat, Feb 27, 2021 at 08:18:47PM -0800, Florian Fainelli wrote: > > On 12/17/2020 12:12 PM, Roman Gushchin wrote: > > With kaslr the kernel image is placed at a random place, so starting > > the bottom-up allocation with the kernel_end can result in an > > allocation failure and a w

Re: [PATCH v6 20/24] iio: buffer: add ioctl() to support opening extra buffers for IIO device

2021-02-28 Thread Lars-Peter Clausen
On 2/15/21 11:40 AM, Alexandru Ardelean wrote: With this change, an ioctl() call is added to open a character device for a buffer. The ioctl() number is 'i' 0x91, which follows the IIO_GET_EVENT_FD_IOCTL ioctl. The ioctl() will return an FD for the requested buffer index. The indexes are the sam

hppa64-linux-ld: mm/slab.o(.init.text+0x450): cannot reach mutex_lock

2021-02-28 Thread kernel test robot
date: 7 months ago config: parisc-randconfig-s031-20210228 (attached as .config) compiler: hppa64-linux-gcc (GCC) 9.3.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # apt-get inst

Re: drivers/leds/blink/leds-lgm-sso.c:123:19: error: field has incomplete type 'struct gpio_chip'

2021-02-28 Thread Pavel Machek
Hi! > >> drivers/leds/blink/leds-lgm-sso.c:263:3: error: implicit declaration of > >> function 'gpiod_set_value' [-Werror,-Wimplicit-function-declaration] >gpiod_set_value(led->gpiod, val); >^ >drivers/leds/blink/leds-lgm-sso.c:263:3: note: did you mean

Re: [PATCH v6 19/24] iio: buffer: introduce support for attaching more IIO buffers

2021-02-28 Thread Lars-Peter Clausen
On 2/15/21 11:40 AM, Alexandru Ardelean wrote: static ssize_t iio_show_scan_index(struct device *dev, struct device_attribute *attr, char *buf) @@ -1451,11 +1465,13 @@ static void __iio_buffer_free_sysfs_and_mask(struct iio_

Re: [BISECTED] Kernel 5.11.x breaks pulseaudio

2021-02-28 Thread Takashi Iwai
On Fri, 26 Feb 2021 10:23:55 +0100, Heinz Diehl wrote: > > On 25.02.2021, Takashi Iwai wrote: > > > Check which streams are running when you get the unexpected sample > > rate by inspecting /proc/asound/card*/pcm* entries. > > I see, thanks for explaining! Pulseaudio no longer works properly fo

Re: [PATCH v2] ALSA: hda/realtek: Enable headset mic of Acer SWIFT with ALC256

2021-02-28 Thread Takashi Iwai
On Fri, 26 Feb 2021 02:04:40 +0100, chris.c...@canonical.com wrote: > > From: Chris Chiu > > The Acer SWIFT Swift SF314-54/55 laptops with ALC256 cannot detect > both the headset mic and the internal mic. Introduce new fixup > to enable the jack sense and the headset mic. However, the internal >

Re: [PATCH] ALSA: ctxfi: cthw20k2: fix mask on conf to allow 4 bits

2021-02-28 Thread Takashi Iwai
On Sat, 27 Feb 2021 01:15:27 +0100, Colin King wrote: > > From: Colin Ian King > > Currently the mask operation on variable conf is just 3 bits so > the switch statement case value of 8 is unreachable dead code. > The function daio_mgr_dao_init can be passed a 4 bit value, > function dao_rsc_ini

Re: [PATCH v6 02/24] iio: kfifo: add devm_iio_kfifo_buffer_setup() helper

2021-02-28 Thread Lars-Peter Clausen
On 2/15/21 11:40 AM, Alexandru Ardelean wrote: +int devm_iio_kfifo_buffer_setup(struct device *dev, + struct iio_dev *indio_dev, + int mode_flags, + const struct iio_buffer_setup_ops *setup_ops) +{ + s

Re: [PATCH 2/9] tpm: Allow PCR 23 to be restricted to kernel-only use

2021-02-28 Thread Matthew Garrett
On Wed, Feb 24, 2021 at 10:00:53AM -0800, James Bottomley wrote: > On Sat, 2021-02-20 at 01:32 +, Matthew Garrett wrote: > > Under certain circumstances it might be desirable to enable the > > creation of TPM-backed secrets that are only accessible to the > > kernel. In an ideal world this coul

Re: [PATCH v6 20/24] iio: buffer: add ioctl() to support opening extra buffers for IIO device

2021-02-28 Thread Lars-Peter Clausen
On 2/15/21 11:40 AM, Alexandru Ardelean wrote: [...] /** * iio_buffer_wakeup_poll - Wakes up the buffer waitqueue * @indio_dev: The IIO device @@ -1343,6 +1371,96 @@ static void iio_buffer_unregister_legacy_sysfs_groups(struct iio_dev *indio_dev) kfree(iio_dev_opaque->legacy_scan

<    1   2   3   4