[PATCH V3 0/2] arm64/mm: Fix pfn_valid() for ZONE_DEVICE based memory

2021-03-04 Thread Anshuman Khandual
This series fixes pfn_valid() for ZONE_DEVICE based memory and also improves its performance for normal hotplug memory. While here, it also reorganizes pfn_valid() on CONFIG_SPARSEMEM. This series is based on v5.12-rc1. Cc: Catalin Marinas Cc: Will Deacon Cc: Ard Biesheuvel Cc: Mark Rutland

Re: [PATCH 057/141] watchdog: Fix fall-through warnings for Clang

2021-03-04 Thread Gustavo A. R. Silva
On Thu, Mar 04, 2021 at 08:15:12PM -0800, Guenter Roeck wrote: > On Thu, Mar 04, 2021 at 05:04:06PM -0600, Gustavo A. R. Silva wrote: > > Hi all, > > > > It's been more than 3 months; who can take this, please? :) > > > > I am not in favor of cosmetic patches for old drivers, Me either.

RE: [PATCH] usb: cdnsp: Fixes incorrect value in ISOC TRB

2021-03-04 Thread Pawel Laszczak
Hi, Please ignore this patch. I put incorrect address to Peter. I have sent again this patch with correct email address. >-Original Message- >From: Pawel Laszczak >Sent: Friday, March 5, 2021 6:00 AM >To: peter.c...@nxp.com >Cc: gre...@linuxfoundation.org; linux-...@vger.kernel.org;

Re: [PATCH] arm64: dts: ti: k3-j721e-main: Update the speed modes supported and their itap delay values for MMCSD subsystems

2021-03-04 Thread Nishanth Menon
On 10:59-20210301, Kishon Vijay Abraham I wrote: > On 25/02/21 6:57 pm, Aswath Govindraju wrote: > > According to latest errata of J721e [1], HS400 mode is not supported > > in MMCSD0 subsystem (i2024) and SDR104 mode is not supported in MMCSD1/2 > > subsystems (i2090). Therefore, replace

[PATCH] usb: cdnsp: Fixes incorrect value in ISOC TRB

2021-03-04 Thread Pawel Laszczak
From: Pawel Laszczak The value "start_cycle ? 0 : 1" in assignment caused implicit truncation whole value to 1 byte. To fix the issue, an explicit casting has been added. Fixes: commit 3d82904559f4 ("usb: cdnsp: cdns3 Add main part of Cadence USBSSP DRD Driver") Signed-off-by: Pawel Laszczak

BUG: soft lockup in corrupted

2021-03-04 Thread Palash Oswal
Hello, I was running syzkaller and I found the following issue : Head Commit : 27e543cca13fab05689b2d0d61d200a83cfb00b6 ( v5.11.2 ) Git Tree : stable Console logs: watchdog: BUG: soft lockup - CPU#0 stuck for 23s! [syz-executor497:423] Modules linked in: CPU: 0 PID: 423 Comm: syz-executor497 Not

security/integrity/platform_certs/keyring_handler.c:62:30: warning: no previous prototype for function 'get_handler_for_db'

2021-03-04 Thread kernel test robot
Hi Atish, First bad commit (maybe != root cause): tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 3cb60ee6323968b694208c4cbd56a7176396e931 commit: d7071743db31b4f6898b1c742e4b451bb4bc4b02 RISC-V: Add EFI stub support. date: 5 months ago config:

[PATCH v3 7/7] Documentation: PCI: endpoint/pci-endpoint-cfs: Guide to use SR-IOV

2021-03-04 Thread Kishon Vijay Abraham I
Add Documentation to help users use PCI endpoint to create virtual functions using configfs. An endpoint function is designated as a virtual endpoint function device when it is linked to a physical endpoint function device (instead of a endpoint controller). Signed-off-by: Kishon Vijay Abraham I

[PATCH v3 6/7] misc: pci_endpoint_test: Populate sriov_configure ops to configure SR-IOV device

2021-03-04 Thread Kishon Vijay Abraham I
Populate sriov_configure ops with pci_sriov_configure_simple to configure SR-IOV device. Signed-off-by: Kishon Vijay Abraham I --- drivers/misc/pci_endpoint_test.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/misc/pci_endpoint_test.c b/drivers/misc/pci_endpoint_test.c index

[PATCH v3 5/7] PCI: cadence: Add support to configure virtual functions

2021-03-04 Thread Kishon Vijay Abraham I
Now that support for SR-IOV is added in PCIe endpoint core, add support to configure virtual functions in the Cadence PCIe EP driver. Signed-off-by: Kishon Vijay Abraham I --- .../pci/controller/cadence/pcie-cadence-ep.c | 207 -- drivers/pci/controller/cadence/pcie-cadence.h |

[PATCH v3 4/7] PCI: endpoint: Add virtual function number in pci_epc ops

2021-03-04 Thread Kishon Vijay Abraham I
Add virtual function number in pci_epc ops. EPC controller driver can perform virtual function specific initialization based on the virtual function number. Signed-off-by: Kishon Vijay Abraham I --- .../pci/controller/cadence/pcie-cadence-ep.c | 44 +++---

[PATCH v3 3/7] PCI: endpoint: Add support to link a physical function to a virtual function

2021-03-04 Thread Kishon Vijay Abraham I
While the physical function has to be linked to endpoint controller, the virtual function has to be linked to a physical function. Add support to link a physical function to a virtual function in pci-ep-cfs. Signed-off-by: Kishon Vijay Abraham I --- drivers/pci/endpoint/pci-ep-cfs.c | 24

[PATCH v3 0/7] Add SR-IOV support in PCIe Endpoint Core

2021-03-04 Thread Kishon Vijay Abraham I
Patch series *) Adds support to add virtual functions to enable endpoint controller which supports SR-IOV capability *) Add support in Cadence endpoint driver to configure virtual functions *) Enable pci_endpoint_test driver to create pci_device for virtual functions v1 of the patch series

[PATCH v3 2/7] PCI: endpoint: Add support to add virtual function in endpoint core

2021-03-04 Thread Kishon Vijay Abraham I
Add support to add virtual function in endpoint core. The virtual function can only be associated with a physical function instead of a endpoint controller. Provide APIs to associate a virtual function with a physical function here. Signed-off-by: Kishon Vijay Abraham I ---

[PATCH v3 1/7] dt-bindings: PCI: pci-ep: Add binding to specify virtual function

2021-03-04 Thread Kishon Vijay Abraham I
Add binding to specify virtual function (associated with each physical function) in endpoint mode. Signed-off-by: Kishon Vijay Abraham I --- Documentation/devicetree/bindings/pci/pci-ep.yaml | 9 + 1 file changed, 9 insertions(+) diff --git

Re: [RFC PATCH v1] powerpc: Enable KFENCE for PPC32

2021-03-04 Thread Michael Ellerman
Marco Elver writes: > On Thu, Mar 04, 2021 at 12:48PM +0100, Christophe Leroy wrote: >> Le 04/03/2021 à 12:31, Marco Elver a écrit : >> > On Thu, 4 Mar 2021 at 12:23, Christophe Leroy >> > wrote: >> > > Le 03/03/2021 à 11:56, Marco Elver a écrit : >> > > > >> > > > Somewhat tangentially, I also

Re: [PATCH v8 4/5] dma-buf: system_heap: Add drm pagepool support to system heap

2021-03-04 Thread kernel test robot
Hi John, I love your patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v5.12-rc1 next-20210304] [cannot apply to linux/master drm-intel/for-linux-next drm-tip/drm-tip] [If your patch is applied to the wrong git tree, kindly drop us a note

[PATCH] usb: cdnsp: Fixes incorrect value in ISOC TRB

2021-03-04 Thread Pawel Laszczak
From: Pawel Laszczak The value "start_cycle ? 0 : 1" in assignment caused implicit truncation whole value to 1 byte. To fix the issue, an explicit casting has been added. Fixes: commit 3d82904559f4 ("usb: cdnsp: cdns3 Add main part of Cadence USBSSP DRD Driver") Signed-off-by: Pawel Laszczak

Re: [PATCH -next] phy: ralink: phy-mt7621-pci: fix return value check in mt7621_pci_phy_probe()

2021-03-04 Thread Sergio Paracuellos
On Fri, Mar 5, 2021 at 4:40 AM 'Wei Yongjun wrote: > > From: Wei Yongjun > > Fix the return value check which testing the wrong variable > in mt7621_pci_phy_probe(). > > Fixes: d87da32372a0 ("phy: ralink: Add PHY driver for MT7621 PCIe PHY") > Reported-by: Hulk Robot > Signed-off-by: Wei

Re: [PATCH net-next 5/6] net: qualcomm: rmnet: don't use C bit-fields in rmnet checksum trailer

2021-03-04 Thread Bjorn Andersson
On Thu 04 Mar 16:34 CST 2021, Alex Elder wrote: > Replace the use of C bit-fields in the rmnet_map_dl_csum_trailer > structure with a single one-byte field, using constant field masks > to encode or get at embedded values. > Reviewed-by: Bjorn Andersson Regards, Bjorn > Signed-off-by: Alex

Re: [PATCH net-next 0/6] net: qualcomm: rmnet: stop using C bit-fields

2021-03-04 Thread Alex Elder
On 3/4/21 9:44 PM, subas...@codeaurora.org wrote: Can you share what all tests have been done with these patches I'm testing with all of them applied and "it works." On the first three I think they're simple enough that you can see by inspection they should be OK. For the rest I tested more

Re: [PATCH net-next 4/6] net: qualcomm: rmnet: use field masks instead of C bit-fields

2021-03-04 Thread Bjorn Andersson
On Thu 04 Mar 16:34 CST 2021, Alex Elder wrote: > The actual layout of bits defined in C bit-fields (e.g. int foo : 3) > is implementation-defined. Structures defined in > address this by specifying all bit-fields twice, to cover two > possible layouts. > > I think this pattern is repetitive

kernel/trace/trace_events_hist.c:3495:12: warning: stack frame size of 2112 bytes in function 'action_create'

2021-03-04 Thread kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 3cb60ee6323968b694208c4cbd56a7176396e931 commit: bd82631d7ccdc894af2738e47abcba2cb6e7dea9 tracing: Add support for dynamic strings to synthetic events date: 5 months ago config:

Re: [PATCH] [v2] Input: Add "Share" button to Microsoft Xbox One controller.

2021-03-04 Thread Roderick Colenbrander
(resend in plain text) +benjamin in a more explicit way Hi Chris, I see the need for the Record button. I wonder what makes sense from the Linux kernel perspective. For DualShock 4 and DualSense there is a Share button too (it introduced it). For DualShock 4 that was mapped to 'Select' I think

Re: [External] Re: [PATCH v17 3/9] mm: hugetlb: free the vmemmap pages associated with each HugeTLB page

2021-03-04 Thread Muchun Song
On Fri, Mar 5, 2021 at 7:50 AM Singh, Balbir wrote: > > On 26/2/21 12:21 am, Muchun Song wrote: > > Every HugeTLB has more than one struct page structure. We __know__ that > > we only use the first 4(HUGETLB_CGROUP_MIN_ORDER) struct page structures > > to store metadata associated with each

Re: [PATCH] perf pmu: Validate raw event with sysfs exported format bits

2021-03-04 Thread Jin, Yao
Hi Andi, On 3/5/2021 9:10 AM, Andi Kleen wrote: Single event: # ./perf stat -e cpu/r031234/ -a -- sleep 1 WARNING: event config '31234' not valid (bits 16 17 not supported by kernel)! Just noticed that again. Can you please print the original event as string in the message? While it's

Re: [PATCH] perf pmu: Validate raw event with sysfs exported format bits

2021-03-04 Thread Jin, Yao
Hi Jiri, On 3/5/2021 4:17 AM, Jiri Olsa wrote: On Wed, Mar 03, 2021 at 01:17:36PM +0800, Jin Yao wrote: SNIP The set bits in 'bits' indicate the invalid bits used in config. Finally use strbuf to report the invalid bits. Some architectures may not export supported bits through sysfs, so if

[PATCH v4 25/25] cachefiles: Switch to wait_page_key

2021-03-04 Thread Matthew Wilcox (Oracle)
Cachefiles was relying on wait_page_key and wait_bit_key being the same layout, which is fragile. Now that wait_page_key is exposed in the pagemap.h header, we can remove that fragility. Also switch it to use the folio directly instead of the page. Signed-off-by: Matthew Wilcox (Oracle) ---

[PATCH v4 24/25] mm/filemap: Convert page wait queues to be folios

2021-03-04 Thread Matthew Wilcox (Oracle)
Reinforce that if we're waiting for a bit in a struct page, that's actually in the head page by changing the type from page to folio. Signed-off-by: Matthew Wilcox (Oracle) --- include/linux/pagemap.h | 6 +++--- mm/filemap.c| 30 -- 2 files changed, 19

[PATCH v4 23/25] mm/page-writeback: Convert test_clear_page_writeback to take a folio

2021-03-04 Thread Matthew Wilcox (Oracle)
The one caller of test_clear_page_writeback() already has a folio, so rename it to test_clear_folio_writeback() to make it clear that it operates on the entire folio. This removes a few calls to compound_head() but actually grows the function by 49 bytes because it now accounts for the number of

[PATCH v4 22/25] mm/filemap: Convert wake_up_page_bit to wake_up_folio_bit

2021-03-04 Thread Matthew Wilcox (Oracle)
All callers have a folio, so use it directly. Signed-off-by: Matthew Wilcox (Oracle) --- mm/filemap.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/mm/filemap.c b/mm/filemap.c index 76c97cb9cbbe..e91fa14c86c7 100644 --- a/mm/filemap.c +++ b/mm/filemap.c @@

[PATCH v4 21/25] mm/filemap: Add __lock_folio_or_retry

2021-03-04 Thread Matthew Wilcox (Oracle)
Convert __lock_page_or_retry() to __lock_folio_or_retry(). This actually saves 4 bytes in the only caller of lock_page_or_retry() (due to better register allocation) and saves the 20 byte cost of calling page_folio() in __lock_folio_or_retry() for a total saving of 24 bytes. Signed-off-by:

[PATCH v4 20/25] mm/filemap: Convert wait_on_page_bit to wait_on_folio_bit

2021-03-04 Thread Matthew Wilcox (Oracle)
We must always wait on the folio, otherwise we won't be woken up. This commit shrinks the kernel by 695 bytes, mostly due to moving the page waitqueue lookup into wait_on_folio_bit_common(). Signed-off-by: Matthew Wilcox (Oracle) --- fs/afs/write.c | 21

[PATCH v4 19/25] mm/page-writeback: Add wait_for_stable_folio

2021-03-04 Thread Matthew Wilcox (Oracle)
Move wait_for_stable_page() into the folio compatibility file. wait_for_stable_folio() avoids a call to compound_head() and is 14 bytes smaller than wait_for_stable_page() was. The net text size grows by 24 bytes as a result of this patch. Signed-off-by: Matthew Wilcox (Oracle) ---

[PATCH v4 18/25] mm/page-writeback: Add wait_on_folio_writeback

2021-03-04 Thread Matthew Wilcox (Oracle)
This eliminates a call to compound_head() by turning PageWriteback() into FolioWriteback(), which saves 8 bytes. That is more than offset by adding the wait_on_page_writeback compatibility wrapper for a net increase in text of 30 bytes. Signed-off-by: Matthew Wilcox (Oracle) ---

[PATCH v4 17/25] mm/filemap: Add wait_on_folio_locked & wait_on_folio_locked_killable

2021-03-04 Thread Matthew Wilcox (Oracle)
Turn wait_on_page_locked() and wait_on_page_locked_killable() into wrappers. This eliminates a call to compound_head() from each call-site, reducing text size by 207 bytes for me. Signed-off-by: Matthew Wilcox (Oracle) --- include/linux/pagemap.h | 26 ++ mm/filemap.c

[PATCH v4 16/25] mm/filemap: Convert end_page_writeback to end_folio_writeback

2021-03-04 Thread Matthew Wilcox (Oracle)
Add a wrapper function for users that are not yet converted to folios. end_folio_writeback() is less than half the size of end_page_writeback() at just 105 bytes compared to 213 bytes, due to removing all the compound_head() calls. The 30 byte wrapper function makes this a net saving of 70

[PATCH v4 15/25] mm/filemap: Convert lock_page_async to lock_folio_async

2021-03-04 Thread Matthew Wilcox (Oracle)
There aren't any actual callers of lock_page_async(), but convert filemap_update_page() to call __lock_folio_async(). __lock_folio_async() is 21 bytes smaller than __lock_page_async(), but the real savings come from using a folio in filemap_update_page(), shrinking it from 514 bytes to 403 bytes,

Re: [PATCH] opp: Invalidate current opp when draining the opp list

2021-03-04 Thread Viresh Kumar
On 04-03-21, 15:07, Beata Michalska wrote: > The current_opp when set, grabs additional reference on the opp, > which is then supposed to be dropped upon releasing the opp table. > Still both dev_pm_opp_remove_table and dev_pm_opp_remove_all_dynamic > will completely drain the OPPs list, including

[PATCH v4 14/25] mm/filemap: Add lock_folio_killable

2021-03-04 Thread Matthew Wilcox (Oracle)
This is like lock_page_killable() but for use by callers who know they have a folio. Convert __lock_page_killable() to be __lock_folio_killable(). This saves one call to compound_head() per contended call to lock_page_killable(). __lock_folio_killable() is 20 bytes smaller than

[PATCH v4 13/25] mm/filemap: Add lock_folio

2021-03-04 Thread Matthew Wilcox (Oracle)
This is like lock_page() but for use by callers who know they have a folio. Convert __lock_page() to be __lock_folio(). This saves one call to compound_head() per contended call to lock_page(). Saves 362 bytes of text; mostly from improved register allocation and inlining decisions.

[PATCH v4 12/25] mm/filemap: Add unlock_folio

2021-03-04 Thread Matthew Wilcox (Oracle)
Convert unlock_page() to call unlock_folio(). By using a folio we avoid a call to compound_head(). This shortens the function from 39 bytes to 25 and removes 4 instructions on x86-64. Because we still have unlock_page(), it's a net increase of 24 bytes of text. Signed-off-by: Matthew Wilcox

[PATCH v4 11/25] mm/memcg: Add folio wrappers for various memcontrol functions

2021-03-04 Thread Matthew Wilcox (Oracle)
Add new functions folio_memcg(), lock_folio_memcg(), unlock_folio_memcg() and mem_cgroup_folio_lruvec(). These will all be used by other functions later. Signed-off-by: Matthew Wilcox (Oracle) --- include/linux/memcontrol.h | 30 ++ 1 file changed, 30 insertions(+)

[PATCH] MIPS: Support large stack.

2021-03-04 Thread HongJieDeng
From: Hongjie Deng We need more stack space, xori/ori no longer apply when _THREAD_MASK exceeds 16 bits Signed-off-by: Hongjie Deng --- arch/mips/include/asm/stackframe.h | 8 arch/mips/kernel/genex.S | 6 ++ 2 files changed, 14 insertions(+) diff --git

[PATCH v4 10/25] mm/util: Add folio_mapping and folio_file_mapping

2021-03-04 Thread Matthew Wilcox (Oracle)
These are the folio equivalent of page_mapping() and page_file_mapping(). Add an out-of-line page_mapping() wrapper around folio_mapping() in order to prevent the page_folio() call from bloating every caller of page_mapping(). Adjust page_file_mapping() and page_mapping_file() to use folios

[PATCH v4 09/25] mm: Add folio_index, folio_page and folio_contains

2021-03-04 Thread Matthew Wilcox (Oracle)
folio_index() is the equivalent of page_index() for folios. folio_page() finds the page in a folio for a page cache index. folio_contains() tells you whether a folio contains a particular page cache index. Signed-off-by: Matthew Wilcox (Oracle) --- include/linux/pagemap.h | 23

Re: [PATCH V2 1/2] arm64/mm: Fix pfn_valid() for ZONE_DEVICE based memory

2021-03-04 Thread Anshuman Khandual
On 3/4/21 3:06 PM, Will Deacon wrote: > On Thu, Mar 04, 2021 at 09:12:31AM +0100, David Hildenbrand wrote: >> On 04.03.21 04:31, Anshuman Khandual wrote: >>> On 3/4/21 2:54 AM, Will Deacon wrote: On Wed, Mar 03, 2021 at 07:04:33PM +, Catalin Marinas wrote: > On Thu, Feb 11, 2021 at

[PATCH v4 08/25] mm: Handle per-folio private data

2021-03-04 Thread Matthew Wilcox (Oracle)
Add folio_private() and set_folio_private() which mirror page_private() and set_page_private() -- ie folio private data is the same as page private data. Turn attach_page_private() into attach_folio_private() and reimplement attach_page_private() as a wrapper. No filesystem which uses page

Re: [PATCH 5/7] printk: Make %pS and friends print module build ID

2021-03-04 Thread Stephen Boyd
Quoting Rasmus Villemoes (2021-03-04 15:11:47) > On 04/03/2021 20.15, Stephen Boyd wrote: > > Quoting Matthew Wilcox (2021-03-04 09:00:52) > >> On Mon, Mar 01, 2021 at 09:47:47AM -0800, Stephen Boyd wrote: > >>> Example: > >>> > >>> WARNING: CPU: 4 PID: 3255 at drivers/misc/lkdtm/bugs.c:83 > >>>

[PATCH v4 07/25] mm: Create FolioFlags

2021-03-04 Thread Matthew Wilcox (Oracle)
These new functions are the folio analogues of the PageFlags functions. If CONFIG_DEBUG_VM_PGFLAGS is enabled, we check the folio is not a tail page at every invocation. Note that this will also catch the PagePoisoned case as a poisoned page has every bit set, which would include PageTail. This

[PATCH v4 06/25] mm: Add get_folio

2021-03-04 Thread Matthew Wilcox (Oracle)
If we know we have a folio, we can call get_folio() instead of get_page() and save the overhead of calling compound_head(). Signed-off-by: Matthew Wilcox (Oracle) Reviewed-by: Zi Yan --- include/linux/mm.h | 19 ++- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git

Re: [PATCH] ibmvnic: remove excessive irqsave

2021-03-04 Thread Sukadev Bhattiprolu
angkery [angk...@163.com] wrote: > From: Junlin Yang > > ibmvnic_remove locks multiple spinlocks while disabling interrupts: > spin_lock_irqsave(>state_lock, flags); > spin_lock_irqsave(>rwi_lock, flags); > > there is no need for the second irqsave,since interrupts are disabled > at that point,

[PATCH v4 05/25] mm: Add put_folio

2021-03-04 Thread Matthew Wilcox (Oracle)
If we know we have a folio, we can call put_folio() instead of put_page() and save the overhead of calling compound_head(). Also skips the devmap checks. This commit looks like it should be a no-op, but actually saves 1714 bytes of text with the distro-derived config that I'm testing. Some

[PATCH v4 04/25] mm/debug: Add VM_BUG_ON_FOLIO and VM_WARN_ON_ONCE_FOLIO

2021-03-04 Thread Matthew Wilcox (Oracle)
These are the folio equivalents of VM_BUG_ON_PAGE and VM_WARN_ON_ONCE_PAGE. Signed-off-by: Matthew Wilcox (Oracle) Reviewed-by: Zi Yan --- include/linux/mmdebug.h | 20 1 file changed, 20 insertions(+) diff --git a/include/linux/mmdebug.h b/include/linux/mmdebug.h index

[PATCH v4 00/25] Page folios

2021-03-04 Thread Matthew Wilcox (Oracle)
Our type system does not currently distinguish between tail pages and head or single pages. This is a problem because we call compound_head() multiple times (and the compiler cannot optimise it out), bloating the kernel. It also makes programming hard as it is often unclear whether a function

[PATCH v4 02/25] mm: Add folio_pgdat and folio_zone

2021-03-04 Thread Matthew Wilcox (Oracle)
These are just convenience wrappers for callers with folios; pgdat and zone can be reached from tail pages as well as head pages. Signed-off-by: Matthew Wilcox (Oracle) Reviewed-by: Zi Yan --- include/linux/mm.h | 10 ++ 1 file changed, 10 insertions(+) diff --git a/include/linux/mm.h

[PATCH v4 03/25] mm/vmstat: Add functions to account folio statistics

2021-03-04 Thread Matthew Wilcox (Oracle)
Allow page counters to be more readily modified by callers which have a folio. Name these wrappers with 'stat' instead of 'state' as requested by Linus here: https://lore.kernel.org/linux-mm/CAHk-=wj847sudr-kt+46ft3+xffgiwpgthvm7djwgdi4cvr...@mail.gmail.com/ Signed-off-by: Matthew Wilcox

[PATCH v4 01/25] mm: Introduce struct folio

2021-03-04 Thread Matthew Wilcox (Oracle)
A struct folio refers to an entire (possibly compound) page. A function which takes a struct folio argument declares that it will operate on the entire compound page, not just PAGE_SIZE bytes. In return, the caller guarantees that the pointer it is passing does not point to a tail page.

Re: [PATCH net-next 3/6] net: qualcomm: rmnet: kill RMNET_MAP_GET_*() accessor macros

2021-03-04 Thread Bjorn Andersson
On Thu 04 Mar 16:34 CST 2021, Alex Elder wrote: > The following macros, defined in "rmnet_map.h", assume a socket > buffer is provided as an argument without any real indication this > is the case. > RMNET_MAP_GET_MUX_ID() > RMNET_MAP_GET_CD_BIT() > RMNET_MAP_GET_PAD() >

Re: [PATCH 057/141] watchdog: Fix fall-through warnings for Clang

2021-03-04 Thread Guenter Roeck
On Thu, Mar 04, 2021 at 05:04:06PM -0600, Gustavo A. R. Silva wrote: > Hi all, > > It's been more than 3 months; who can take this, please? :) > I am not in favor of cosmetic patches for old drivers, and I am not going to provide tags for them anymore. The driver should be converted to use the

Re: [PATCH net-next 2/6] net: qualcomm: rmnet: simplify some byte order logic

2021-03-04 Thread Bjorn Andersson
On Thu 04 Mar 16:34 CST 2021, Alex Elder wrote: > In rmnet_map_ipv4_ul_csum_header() and rmnet_map_ipv6_ul_csum_header() > the offset within a packet at which checksumming should commence is > calculated. This calculation involves byte swapping and a forced type > conversion that makes it hard

Re: [PATCH] md: bcache: fix error return code of cached_dev_cache_miss()

2021-03-04 Thread Coly Li
On 3/5/21 10:46 AM, Jia-Ju Bai wrote: > When bch_bio_alloc_pages() fails, no error return code of > cached_dev_cache_miss() is assigned. > To fix this bug, ret is assigned with -ENOMEN as error return code. > > Reported-by: TOTE Robot > Signed-off-by: Jia-Ju Bai > --- >

Re: [PATCH v22 09/10] fs/ntfs3: Add NTFS3 in fs/Kconfig and fs/Makefile

2021-03-04 Thread kernel test robot
Hi Konstantin, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on fe07bfda2fb9cdef8a4d4008a409bb02f35f1bd8] url: https://github.com/0day-ci/linux/commits/Konstantin-Komarov/NTFS-read-write-driver-GPL-implementation-by-Paragon-Software/20210302-000938 base:

Re: [PATCH net-next 1/6] net: qualcomm: rmnet: mark trailer field endianness

2021-03-04 Thread Bjorn Andersson
On Thu 04 Mar 16:34 CST 2021, Alex Elder wrote: > The fields in the checksum trailer structure used for QMAP protocol > RX packets are all big-endian format, so define them that way. > > It turns out these fields are never actually used by the RMNet code. > The start offset is always assumed to

RE: [PATCH] gpu: drm: swsmu: fix error return code of smu_v11_0_set_allowed_mask()

2021-03-04 Thread Quan, Evan
[AMD Public Use] Thanks. Reviewed-by: Evan Quan -Original Message- From: Jia-Ju Bai Sent: Friday, March 5, 2021 11:54 AM To: Deucher, Alexander ; Koenig, Christian ; airl...@linux.ie; dan...@ffwll.ch; Quan, Evan ; Zhang, Hawking ; Wang, Kevin(Yang) ; Gao, Likun Cc:

[PATCH] gpu: drm: swsmu: fix error return code of smu_v11_0_set_allowed_mask()

2021-03-04 Thread Jia-Ju Bai
When bitmap_empty() or feature->feature_num triggers an error, no error return code of smu_v11_0_set_allowed_mask() is assigned. To fix this bug, ret is assigned with -EINVAL as error return code. Reported-by: TOTE Robot Signed-off-by: Jia-Ju Bai ---

Re: [git pull] drm fixes for 5.12-rc2

2021-03-04 Thread pr-tracker-bot
The pull request you sent on Fri, 5 Mar 2021 12:50:16 +1000: > git://anongit.freedesktop.org/drm/drm tags/drm-fixes-2021-03-05 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/280d542f6ffac0e6d65dc267f92191d509b13b64 Thank you! -- Deet-doot-dot, I am a bot.

"struct perf_sample_data" alignment

2021-03-04 Thread Linus Torvalds
Sp there's a note about new warnings in 5.12-rc1 that I looked at, and many of the warnings made me go "Whaaa?". They were all of the type warning: 'perf_event_aux_event' uses dynamic stack allocation and then when I go look, I see nothing that looks like a dynamic stack allocation at all.

Re: [PATCH net-next 0/6] net: qualcomm: rmnet: stop using C bit-fields

2021-03-04 Thread subashab
On 2021-03-04 15:34, Alex Elder wrote: This series converts data structures defined in so they use integral field values with bitfield masks rather than rely on C bit-fields. I first proposed doing something like this long ago when my confusion about this code (and the memory layout it was

Re: [PATCH v2 3/4] ALSA: hda/cirrus: Add jack detect interrupt support from CS42L42 companion codec.

2021-03-04 Thread kernel test robot
Hi Vitaly, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on sound/for-next] [also build test WARNING on v5.12-rc1 next-20210304] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base

[PATCH] scsi: wd719x: fix error return code of wd719x_pci_probe()

2021-03-04 Thread Jia-Ju Bai
When dma_set_mask() or pci_iomap() fails, no error return code of wd719x_pci_probe() is assigned. To fix this bug, err is assigned with -EIO as error return code. Reported-by: TOTE Robot Signed-off-by: Jia-Ju Bai --- drivers/scsi/wd719x.c | 2 ++ 1 file changed, 2 insertions(+) diff --git

[PATCH -next] regulator: rt4831: Fix return value check in rt4831_regulator_probe()

2021-03-04 Thread 'Wei Yongjun
From: Wei Yongjun In case of error, the function dev_get_regmap() returns NULL pointer not ERR_PTR(). The IS_ERR() test in the return value check should be replaced with NULL test. Fixes: 9351ab8b0cb6 ("regulator: rt4831: Adds support for Richtek RT4831 DSV regulator") Reported-by: Hulk Robot

[PATCH -next] phy: ingenic: Fix a typo in ingenic_usb_phy_probe()

2021-03-04 Thread 'Wei Yongjun
From: Wei Yongjun Fix the return value check typo which testing the wrong variable in ingenic_usb_phy_probe(). Fixes: 31de313dfdcf ("PHY: Ingenic: Add USB PHY driver using generic PHY framework.") Reported-by: Hulk Robot Signed-off-by: Wei Yongjun --- drivers/phy/ingenic/phy-ingenic-usb.c |

[PATCH -next] phy: ralink: phy-mt7621-pci: fix return value check in mt7621_pci_phy_probe()

2021-03-04 Thread 'Wei Yongjun
From: Wei Yongjun Fix the return value check which testing the wrong variable in mt7621_pci_phy_probe(). Fixes: d87da32372a0 ("phy: ralink: Add PHY driver for MT7621 PCIe PHY") Reported-by: Hulk Robot Signed-off-by: Wei Yongjun --- drivers/phy/ralink/phy-mt7621-pci.c | 4 ++-- 1 file

linux-next: Tree for Mar 5

2021-03-04 Thread Stephen Rothwell
Hi all, Changes since 20210304: The tty tree gained a conflict against the powerpc-fixes tree. The pinctrl tree lost its build failure. Non-merge commits (relative to Linus' tree): 1820 1789 files changed, 45567 insertions(+), 33563 deletions

[PATCH] marvell: libertas_tf: fix error return code of if_usb_prog_firmware()

2021-03-04 Thread Jia-Ju Bai
When check_fwfile_format() fails, no error return code of if_usb_prog_firmware() is assigned. To fix this bug, ret is assigned with -EINVAL as error return code. Reported-by: TOTE Robot Signed-off-by: Jia-Ju Bai --- drivers/net/wireless/marvell/libertas_tf/if_usb.c | 4 +++- 1 file changed, 3

Re: [PATCH 3/3] netfilter: x_tables: Use correct memory barriers.

2021-03-04 Thread Mark Tomlinson
On Thu, 2021-03-04 at 08:46 +0100, Florian Westphal wrote: > Mark Tomlinson wrote: > > Changing to using smp_mb() instead of smp_wmb() fixes the kernel panic > > reported in cc00bcaa5899, > > Can you reproduce the crashes without this change? Yes. In our test environment we were seeing a kernel

Re: [PATCH] configfs: Fix use-after-free issue in __configfs_open_file

2021-03-04 Thread Chao Yu
+Cc fsdevel Ping, Any comments one this patch? On 2021/3/1 14:10, Chao Yu wrote: From: Daiyue Zhang Commit b0841eefd969 ("configfs: provide exclusion between IO and removals") uses ->frag_dead to mark the fragment state, thus no bothering with extra refcount on config_item when opening a

[PATCH V3] mm: Generalize HUGETLB_PAGE_SIZE_VARIABLE

2021-03-04 Thread Anshuman Khandual
HUGETLB_PAGE_SIZE_VARIABLE need not be defined for each individual platform subscribing it. Instead just make it generic. Cc: Michael Ellerman Cc: Benjamin Herrenschmidt Cc: Paul Mackerras Cc: Andrew Morton Cc: Christoph Hellwig Cc: Christophe Leroy Cc: linux-i...@vger.kernel.org Cc:

Re: [PATCH v1 0/3] driver core: Set fw_devlink=on take II

2021-03-04 Thread Saravana Kannan
On Wed, Mar 3, 2021 at 2:21 AM Michael Walle wrote: > > Am 2021-03-03 10:28, schrieb Saravana Kannan: > > On Wed, Mar 3, 2021 at 12:59 AM Michael Walle wrote: > >> > >> Am 2021-03-02 23:47, schrieb Saravana Kannan: > >> > On Tue, Mar 2, 2021 at 2:42 PM Saravana Kannan > >> > wrote: > >> >> > >>

[PATCH v3] security/loadpin: Replace "kernel_read_file_str[j]" with function "kernel_read_file_id_str(j)".

2021-03-04 Thread Jiele zhao
Actually Linux kernel already provide function "kernel_read_file_id_str()" for secure access in "kernel_read_file.h". And, in "parse_exclude()" function, it's better to use BUILD_BUG_ON(ARRAY_SIZE(kernel_read_file_str) - 1 != ARRAY_SIZE(ignore_read_file_id)); to make sure

Re: [PATCH 4/4] nfc: Avoid endless loops caused by repeated llcp_sock_connect()(Internet mail)

2021-03-04 Thread Xiaoming Ni
On 2021/3/3 17:28, kiyin(尹亮) wrote: Hi xiaoming, the path can only fix the endless loop problem. it can't fix the meaningless llcp_sock->service_name problem. if we set llcp_sock->service_name to meaningless string, the connect will be failed. and sk->sk_state will not be LLCP_CONNECTED.

[PATCH] media: i2c: imx274: fix error return code of imx274_s_frame_interval()

2021-03-04 Thread Jia-Ju Bai
When __v4l2_ctrl_modify_range() fails, no error return code of imx274_s_frame_interval() is assigned. To fix this bug, ret is assigned with the return valye of __v4l2_ctrl_modify_range(), and then ret is checked. Reported-by: TOTE Robot Signed-off-by: Jia-Ju Bai --- drivers/media/i2c/imx274.c

Re: [PATCH 5.4 000/337] 5.4.102-rc5 review

2021-03-04 Thread Samuel Zou
On Tue, 02 Mar 2021 20:28:34 +0100, Greg Kroah-Hartman wrote: This is the start of the stable review cycle for the 5.4.102 release. There are 337 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.

[PATCH] net: intel: iavf: fix error return code of iavf_init_get_resources()

2021-03-04 Thread Jia-Ju Bai
When iavf_process_config() fails, no error return code of iavf_init_get_resources() is assigned. To fix this bug, err is assigned with the return value of iavf_process_config(), and then err is checked. Reported-by: TOTE Robot Signed-off-by: Jia-Ju Bai ---

Re: [PATCH v6] i2c: virtio: add a virtio i2c frontend driver

2021-03-04 Thread Viresh Kumar
On 05-03-21, 09:46, Jie Deng wrote: > On 2021/3/4 14:06, Viresh Kumar wrote: > > depends on I2C as well ? > No need that. The dependency of I2C is included in the Kconfig in its parent > directory. Sorry about that, I must have figured that out myself. (Though a note on the way we reply to

Re: [f2fs-dev] [PATCH v4] f2fs: compress: add compress_inode to cache compressed blockst

2021-03-04 Thread Chao Yu
On 2021/3/5 4:20, Jaegeuk Kim wrote: On 02/27, Jaegeuk Kim wrote: On 02/04, Chao Yu wrote: Jaegeuk, On 2021/2/2 16:00, Chao Yu wrote: - for (i = 0; i < dic->nr_cpages; i++) { + for (i = 0; i < cc->nr_cpages; i++) { struct page *page = dic->cpages[i];

Re: [virtio-dev] Re: [PATCH] vdpa/mlx5: set_features should allow reset to zero

2021-03-04 Thread Jason Wang
On 2021/3/4 9:50 下午, Cornelia Huck wrote: On Thu, 4 Mar 2021 16:24:16 +0800 Jason Wang wrote: On 2021/3/3 4:29 下午, Cornelia Huck wrote: On Wed, 3 Mar 2021 12:01:01 +0800 Jason Wang wrote: On 2021/3/2 8:08 下午, Cornelia Huck wrote: On Mon, 1 Mar 2021 11:51:08 +0800 Jason Wang wrote:

[PATCH] PCI: designware-ep: Fix NULL pointer dereference error

2021-03-04 Thread Kishon Vijay Abraham I
commit 281f1f99cf3a ("PCI: dwc: Detect number of iATU windows") detected the number of inbound and outbound windows dynamically at runtime in dw_pcie_setup(). However pcie-designware-ep.c accessed the variables holding the number of inbound and outbound windows even before dw_pcie_setup() was

RE: [PATCH v3 1/3] platform/x86: dell-privacy: Add support for Dell hardware privacy

2021-03-04 Thread Yuan, Perry
Hi Pierre > -Original Message- > From: Pierre-Louis Bossart > Sent: 2021年2月17日 22:24 > To: Perry Yuan; Yuan, Perry; oder_ch...@realtek.com; pe...@perex.cz; > ti...@suse.com; hdego...@redhat.com; mgr...@linux.intel.com > Cc: alsa-de...@alsa-project.org; Limonciello, Mario; linux- >

Re: [PATCH v3 9/9] KVM: x86: Add XSAVE Support for Architectural LBRs

2021-03-04 Thread Xu, Like
On 2021/3/5 0:31, Sean Christopherson wrote: Paolo, any thoughts on how to keep supported_xss aligned with support_xcr0, without spreading the logic around too much? From 58be4152ced441395dfc439f446c5ad53bd48576 Mon Sep 17 00:00:00 2001 From: Like Xu Date: Thu, 4 Mar 2021 13:21:38 +0800

Re: [PATCH v2 7/7] ASoC: dt-bindings: imx-rpmsg: Add binding doc for rpmsg machine driver

2021-03-04 Thread Shengjiu Wang
Hi On Fri, Mar 5, 2021 at 4:05 AM Rob Herring wrote: > > On Thu, Feb 18, 2021 at 1:23 AM Shengjiu Wang wrote: > > > > On Thu, Feb 11, 2021 at 6:18 AM Rob Herring wrote: > > > > > > On Sun, Feb 07, 2021 at 06:23:55PM +0800, Shengjiu Wang wrote: > > > > Imx-rpmsg is a new added machine driver

[git pull] drm fixes for 5.12-rc2

2021-03-04 Thread Dave Airlie
Hi Linus, More may show up but this is what I have at this staged. These are based on the commit in your tree where the swapfile issue is fixed, and neither of the merged trees are in the bad area. Otherwise just a single nouveau regression fix, and a bunch of amdgpu fixes. Dave.

Re: [PATCH RFC] gcc-plugins: Handle GCC version mismatch for OOT modules

2021-03-04 Thread Linus Torvalds
On Thu, Mar 4, 2021 at 6:41 PM Josh Poimboeuf wrote: > > This thread is making me dizzy, but I think the patch you NAK'ed from me > was different. It just added an error on GCC mismatch with external > modules: > > >

[PATCH v2] security/loadpin: Replace "kernel_read_file_str[j]" with function "kernel_read_file_id_str(j)".

2021-03-04 Thread Jiele zhao
Actually Linux kernel already provide function "kernel_read_file_id_str()" for secure access in "kernel_read_file.h". And, in "parse_exclude()" function, it's better to use BUILD_BUG_ON(ARRAY_SIZE(kernel_read_file_str) - 1 == ARRAY_SIZE(ignore_read_file_id)); to make sure

Re: [PATCH] MIPS: Add comment about CONFIG_MIPS32_O32 in loongson3_defconfig when build with Clang

2021-03-04 Thread Maciej W. Rozycki
On Fri, 5 Mar 2021, Jiaxun Yang wrote: > > Huh? Is that a joke? From the o32 psABI's point of view a MIPS64 CPU is > > exactly the same as a MIPS32 one (for whatever ISA revision), so there's > > nothing to support there really other than the CPU/ISA name. > > Clang treat MIPS32 as a

[PATCH] md: bcache: fix error return code of cached_dev_cache_miss()

2021-03-04 Thread Jia-Ju Bai
When bch_bio_alloc_pages() fails, no error return code of cached_dev_cache_miss() is assigned. To fix this bug, ret is assigned with -ENOMEN as error return code. Reported-by: TOTE Robot Signed-off-by: Jia-Ju Bai --- drivers/md/bcache/request.c | 4 +++- 1 file changed, 3 insertions(+), 1

[BUG] memstick: core: missing error return code in msb_resume()

2021-03-04 Thread Jia-Ju Bai
My static analysis tool reports that no error return code is assigned in error handling code of msb_resume(). However, many other drivers assign error return code in xxx_resume(), such as sky2_resume() and e1000_resume(). I wonder whether this is intentional? Best wishes, Jia-Ju Bai

Re: [PATCH RFC] gcc-plugins: Handle GCC version mismatch for OOT modules

2021-03-04 Thread Josh Poimboeuf
On Thu, Mar 04, 2021 at 11:12:42AM -0800, Linus Torvalds wrote: > On Thu, Mar 4, 2021 at 7:36 AM Masahiro Yamada wrote: > > > > All the kernel-space objects are rebuilt > > when the compiler is upgraded. > > I very much NAK'ed that one. Why did that go in? > > Or maybe I NAK'ed another version

Re: [PATCH] KVM: arm64: Disable LTO in hyp

2021-03-04 Thread Sami Tolvanen
On Thu, Mar 4, 2021 at 2:34 PM Sami Tolvanen wrote: > > On Thu, Mar 4, 2021 at 2:17 PM Marc Zyngier wrote: > > > > On Thu, 04 Mar 2021 21:25:41 +, > > Sami Tolvanen wrote: > > > > > > On Thu, Mar 4, 2021 at 11:15 AM Marc Zyngier wrote: > > > > > > > > On Thu, 04 Mar 2021 18:45:44 +, >

<    1   2   3   4   5   6   7   8   9   10   >