Re: [PATCH v3 5/9] KVM: vmx/pmu: Add MSR_ARCH_LBR_DEPTH emulation for Arch LBR

2021-03-04 Thread Xu, Like
On 2021/3/5 0:12, Sean Christopherson wrote: On Thu, Mar 04, 2021, Xu, Like wrote: Hi Sean, Thanks for your detailed review on the patch set. On 2021/3/4 0:58, Sean Christopherson wrote: On Wed, Mar 03, 2021, Like Xu wrote: @@ -348,10 +352,26 @@ static bool

Re: [PATCH 2/2] MIPS: Loongson64: Move loongson_system_configuration to loongson.h

2021-03-04 Thread Jiaxun Yang
在 2021/3/4 下午7:00, Qing Zhang 写道: The purpose of separating loongson_system_configuration from boot_param.h is to keep the other structure consistent with the firmware. Signed-off-by: Jiaxun Yang Signed-off-by: Qing Zhang Acked-by: Jiaxun Yang - Jiaxun ---

Re: [PATCH 1/2] MIPS: Loongson64: Remove unused sysconf members

2021-03-04 Thread Jiaxun Yang
在 2021/3/4 下午7:00, Qing Zhang 写道: We don't need them anymore, They are uniform on all Loongson64 systems and have been fixed in DeviceTree.loongson3_platform_init is replaced with DTS + driver. Signed-off-by: Jiaxun Yang Signed-off-by: Qing Zhang Acked-by: Jiaxun Yang Hmm, why it comes

Re: [PATCH] clocksource: don't run watchdog forever

2021-03-04 Thread Feng Tang
On Thu, Mar 04, 2021 at 03:15:13PM +0100, Thomas Gleixner wrote: > Feng, > > On Thu, Mar 04 2021 at 15:43, Feng Tang wrote: > > On Wed, Mar 03, 2021 at 04:50:31PM +0100, Thomas Gleixner wrote: > >> Anything pre TSC_ADJUST wants the watchdog on. With TSC ADJUST available > >> we can probably avoid

Re: [PATCH] [v2] Input: Add "Share" button to Microsoft Xbox One controller.

2021-03-04 Thread Chris Ye
Hi Bastien, just want to follow up again on this. I've checked again with the Xbox team that the "Share button" is given for the product, the HID usage profile and mapping to RECORD is what Xbox team expects and they want the same mapping for USB. Thanks! Chris On Tue, Mar 2, 2021 at 3:57 PM

Re: [PATCH] kbuild: rebuild GCC plugins when the compiler is upgraded

2021-03-04 Thread Josh Poimboeuf
On Thu, Mar 04, 2021 at 03:37:14PM -0800, Linus Torvalds wrote: > On Thu, Mar 4, 2021 at 3:20 PM Kees Cook wrote: > > > > This seems fine to me, but I want to make sure Josh has somewhere to > > actually go with this. Josh, does this get you any closer? No, this doesn't seem to help me at all.

[PATCH v2] f2fs: add sysfs nodes to get accumulated compression info

2021-03-04 Thread Daeho Jeong
From: Daeho Jeong Added acc_compr_inodes to show accumulated compressed inode count and acc_compr_blocks to show accumulated secured block count with compression in sysfs. These can be re-initialized to "0" by writing "0" value in one of both. Signed-off-by: Daeho Jeong --- v2: thanks to

Re: [PATCH] MIPS: Add comment about CONFIG_MIPS32_O32 in loongson3_defconfig when build with Clang

2021-03-04 Thread Jiaxun Yang
在 2021/3/5 上午7:08, Maciej W. Rozycki 写道: On Thu, 4 Mar 2021, Tiezhu Yang wrote: This is a known bug [2] with Clang, as Simon Atanasyan said, "There is no plan on support O32 for MIPS64 due to lack of resources". Huh? Is that a joke? From the o32 psABI's point of view a MIPS64 CPU is

Re: [PATCH] RTIC: selinux: ARM64: Move selinux_state to a separate page

2021-03-04 Thread Paul Moore
On Tue, Feb 16, 2021 at 5:19 AM Preeti Nagar wrote: > > The changes introduce a new security feature, RunTime Integrity Check > (RTIC), designed to protect Linux Kernel at runtime. The motivation > behind these changes is: > 1. The system protection offered by Security Enhancements(SE) for >

Re: [PATCH v3 RFC 14/14] mm: speedup page alloc for MPOL_PREFERRED_MANY by adding a NO_SLOWPATH gfp bit

2021-03-04 Thread Feng Tang
On Thu, Mar 04, 2021 at 01:59:40PM +0100, Michal Hocko wrote: > On Thu 04-03-21 16:14:14, Feng Tang wrote: > > On Wed, Mar 03, 2021 at 09:22:50AM -0800, Ben Widawsky wrote: > > > On 21-03-03 18:14:30, Michal Hocko wrote: > > > > On Wed 03-03-21 08:31:41, Ben Widawsky wrote: > > > > > On 21-03-03

Re: [f2fs-dev] [PATCH] f2fs: expose # of overprivision segments

2021-03-04 Thread Chao Yu
On 2021/3/5 1:50, Jaegeuk Kim wrote: On 03/04, Chao Yu wrote: On 2021/3/3 2:44, Jaegeuk Kim wrote: On 03/02, Jaegeuk Kim wrote: On 03/02, Chao Yu wrote: On 2021/3/2 13:42, Jaegeuk Kim wrote: This is useful when checking conditions during checkpoint=disable in Android. This sysfs entry is

[PATCH] KVM: x86: Ensure deadline timer has truly expired before posting its IRQ

2021-03-04 Thread Sean Christopherson
When posting a deadline timer interrupt, open code the checks guarding __kvm_wait_lapic_expire() in order to skip the lapic_timer_int_injected() check in kvm_wait_lapic_expire(). The injection check will always fail since the interrupt has not yet be injected. Moving the call after injection

[PATCH] docs: livepatch: Fix a typo in the file shadow-vars.rst

2021-03-04 Thread Bhaskar Chowdhury
s/ varibles/variables/ Signed-off-by: Bhaskar Chowdhury --- Documentation/livepatch/shadow-vars.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/livepatch/shadow-vars.rst b/Documentation/livepatch/shadow-vars.rst index c05715aeafa4..8464866d18ba 100644

[PATCH] KVM: SVM: Connect 'npt' module param to KVM's internal 'npt_enabled'

2021-03-04 Thread Sean Christopherson
Directly connect the 'npt' param to the 'npt_enabled' variable so that runtime adjustments to npt_enabled are reflected in sysfs. Move the !PAE restriction to a runtime check to ensure NPT is forced off if the host is using 2-level paging, and add a comment explicitly stating why NPT requires a

Re: [PATCH v3] selinux: measure state and policy capabilities

2021-03-04 Thread Lakshmi Ramasubramanian
On 3/4/21 5:45 PM, Paul Moore wrote: On Thu, Mar 4, 2021 at 2:20 PM Lakshmi Ramasubramanian wrote: On 2/12/21 8:37 AM, Lakshmi Ramasubramanian wrote: Hi Paul, SELinux stores the configuration state and the policy capabilities in kernel memory. Changes to this data at runtime would have an

Re: [PATCH v3 4/4] clk: rockchip: add clock controller for rk3568

2021-03-04 Thread Kever Yang
On 2021/3/1 下午2:47, Elaine Zhang wrote: Add the clock tree definition for the new rk3568 SoC. Signed-off-by: Elaine Zhang Patch looks good to me. Reviewed-by: Kever Yang Thanks, - Kever --- drivers/clk/rockchip/Kconfig |7 + drivers/clk/rockchip/Makefile |1 +

Re: [PATCH v3 2/4] clk: rockchip: add dt-binding header for rk3568

2021-03-04 Thread Kever Yang
On 2021/3/1 下午2:47, Elaine Zhang wrote: Add the dt-bindings header for the rk3568, that gets shared between the clock controller and the clock references in the dts. Add softreset ID for rk3568. Signed-off-by: Elaine Zhang Patch looks good to me. Reviewed-by: Kever Yang Thanks, - Kever

Re: [PATCH v3 3/4] clk: rockchip: support more core div setting

2021-03-04 Thread Kever Yang
On 2021/3/1 下午2:47, Elaine Zhang wrote: Use arrays to support more core independent div settings. A55 supports each core to work at different frequencies, and each core has an independent divider control. Signed-off-by: Elaine Zhang Patch looks good to me. Reviewed-by: Kever Yang

[PATCH] memstick: core: fix error return code of mspro_block_resume()

2021-03-04 Thread Jia-Ju Bai
When mspro_block_init_card() fails, no error return code of mspro_block_resume() is assigned. To fix this bug, rc is assigned with the return value of mspro_block_init_card(), and then rc is checked. Reported-by: TOTE Robot Signed-off-by: Jia-Ju Bai --- drivers/memstick/core/mspro_block.c |

Re: linux-next: build failure after merge of the pinctrl tree

2021-03-04 Thread Stephen Rothwell
Hi, On Fri, 5 Mar 2021 08:46:46 +0800 "jay...@rock-chips.com" wrote: > > Thanks,and I think i have miss to upstream the changes, > I have resend them in a new thread. > > --- a/arch/arm64/Kconfig.platforms > +++ b/arch/arm64/Kconfig.platforms > @@ -155,9 +155,7 @@ config ARCH_REALTEK > config

[PATCH] net: tehuti: fix error return code in bdx_probe()

2021-03-04 Thread Jia-Ju Bai
When bdx_read_mac() fails, no error return code of bdx_probe() is assigned. To fix this bug, err is assigned with -EFAULT as error return code. Reported-by: TOTE Robot Signed-off-by: Jia-Ju Bai --- drivers/net/ethernet/tehuti/tehuti.c | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH] arch: mips: bcm63xx: Spello fix in the file clk.c

2021-03-04 Thread Bhaskar Chowdhury
s/revelant/relevant/ Signed-off-by: Bhaskar Chowdhury --- arch/mips/bcm63xx/clk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/mips/bcm63xx/clk.c b/arch/mips/bcm63xx/clk.c index 164115944a7f..5a3e325275d0 100644 --- a/arch/mips/bcm63xx/clk.c +++

[PATCH] input: s6sy761: fix coordinate read bit shift

2021-03-04 Thread Caleb Connolly
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 The touch coordinates are read by shifting a value left by 3, this is incorrect and effectively causes the coordinates to be half of the correct value. Shift by 4 bits instead to report the correct value. This matches downstream examples, and has

Re: [PATCH] squashfs: fix inode lookup sanity checks

2021-03-04 Thread Phillip Lougher
On 26/02/2021 09:29, Sean Nyekjaer wrote: When mouting a squashfs image created without inode compression it fails with: "unable to read inode lookup table" It turns out that the BLOCK_OFFSET is missing when checking the SQUASHFS_METADATA_SIZE agaist the actual size. Fixes: eabac19e40c0

[PATCH] crypto: allwinner: sun8i-ce: fix error return code in sun8i_ce_prng_generate()

2021-03-04 Thread Jia-Ju Bai
When dma_mapping_error() returns an error, no error return code of sun8i_ce_prng_generate() is assigned. To fix this bug, err is assigned with -EFAULT as error return code. Reported-by: TOTE Robot Signed-off-by: Jia-Ju Bai --- drivers/crypto/allwinner/sun8i-ce/sun8i-ce-prng.c | 1 + 1 file

[PATCH] thermal: Fix a typo in the file soctherm.c

2021-03-04 Thread Bhaskar Chowdhury
s/calibaration/calibration/ Signed-off-by: Bhaskar Chowdhury --- drivers/thermal/tegra/soctherm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/thermal/tegra/soctherm.c b/drivers/thermal/tegra/soctherm.c index 66e0639da4bf..8b8fbd49679b 100644 ---

[PATCH] drm/nouveau/kms/nve4-nv108: Limit cursors to 128x128

2021-03-04 Thread Lyude Paul
While Kepler does technically support 256x256 cursors, it turns out that Kepler actually has some additional requirements for scanout surfaces that we're not enforcing correctly, which aren't present on Maxwell and later. Cursor surfaces must always use small pages (4K), and overlay surfaces must

RE: [PATCH] Input: elan_i2c - Reduce the resume time for new dev ices

2021-03-04 Thread jingle
HI Dmitry: 1. You mean to let all devices ignore skipping reset/sleep part of device initialization? 2. The test team found that some old firmware will have errors (invalid report etc...), so ELAN can only ensure that the new device can meet the newer parts. Thanks jingle -Original

Re: [PATCH v6] i2c: virtio: add a virtio i2c frontend driver

2021-03-04 Thread Jie Deng
On 2021/3/4 14:06, Viresh Kumar wrote: Please always supply version history, it makes it difficult to review otherwise. I will add the history. drivers/i2c/busses/Kconfig | 11 ++ drivers/i2c/busses/Makefile | 3 + drivers/i2c/busses/i2c-virtio.c | 289

Re: [PATCH v3] selinux: measure state and policy capabilities

2021-03-04 Thread Paul Moore
On Thu, Mar 4, 2021 at 2:20 PM Lakshmi Ramasubramanian wrote: > On 2/12/21 8:37 AM, Lakshmi Ramasubramanian wrote: > > Hi Paul, > > > SELinux stores the configuration state and the policy capabilities > > in kernel memory. Changes to this data at runtime would have an impact > > on the security

[PATCH] thermal: Fix couple of spellos in the file sun8i_thermal.c

2021-03-04 Thread Bhaskar Chowdhury
s/calibartion/calibration/ s/undocummented/undocumented/ Signed-off-by: Bhaskar Chowdhury --- drivers/thermal/sun8i_thermal.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/thermal/sun8i_thermal.c b/drivers/thermal/sun8i_thermal.c index

Re: [PATCH v3 1/4] dt-binding: clock: Document rockchip,rk3568-cru bindings

2021-03-04 Thread Kever Yang
On 2021/3/1 下午2:47, Elaine Zhang wrote: Document the device tree bindings of the rockchip Rk3568 SoC clock driver in Documentation/devicetree/bindings/clock/rockchip,rk3568-cru.yaml. Signed-off-by: Elaine Zhang Patch looks good to me. Reviewed-by: Kever Yang

Re: [PATCH] mm,hwpoison: return -EBUSY when page already poisoned

2021-03-04 Thread Aili Yao
On Fri, 5 Mar 2021 09:30:16 +0800 Aili Yao wrote: > On Thu, 4 Mar 2021 15:57:20 -0800 > "Luck, Tony" wrote: > > > On Thu, Mar 04, 2021 at 02:45:24PM +0800, Aili Yao wrote: > > > > > if your methods works, should it be like this? > > > > > > > > > > 1582 pteval = > > >

Re: [PATCH mm] kfence, slab: fix cache_alloc_debugcheck_after() for bulk allocations

2021-03-04 Thread Andrew Morton
On Thu, 4 Mar 2021 22:05:48 +0100 Alexander Potapenko wrote: > On Thu, Mar 4, 2021 at 9:53 PM Marco Elver wrote: > > > > cache_alloc_debugcheck_after() performs checks on an object, including > > adjusting the returned pointer. None of this should apply to KFENCE > > objects. While for non-bulk

Re: [PATCH] Input: elan_i2c - Reduce the resume time for new dev ices

2021-03-04 Thread 'Dmitry Torokhov'
Hi Jingle, On Fri, Mar 05, 2021 at 09:24:05AM +0800, jingle wrote: > HI Dmitry: > > In this case (in the newer parts behavior regarding need to reset after > powering them on), it is consistent with the original driver behavior with > any new or old device > (be called

Re: [PATCH] mm,hwpoison: return -EBUSY when page already poisoned

2021-03-04 Thread Aili Yao
On Thu, 4 Mar 2021 15:57:20 -0800 "Luck, Tony" wrote: > On Thu, Mar 04, 2021 at 02:45:24PM +0800, Aili Yao wrote: > > > > if your methods works, should it be like this? > > > > > > > > 1582 pteval = > > > > swp_entry_to_pte(make_hwpoison_entry(subpage)); > > > > 1583

Re: [PATCH 3/4] kbuild: check the minimum assembler version in Kconfig

2021-03-04 Thread Nick Desaulniers
On Wed, Mar 3, 2021 at 10:34 AM Masahiro Yamada wrote: > > Documentation/process/changes.rst defines the minimum assembler version > (binutils version), but we have never checked it in the build time. > > Kbuild never invokes 'as' directly because all assembly files in the > kernel tree are *.S,

RE: [PATCH] Input: elan_i2c - Reduce the resume time for new dev ices

2021-03-04 Thread jingle
HI Dmitry: In this case (in the newer parts behavior regarding need to reset after powering them on), it is consistent with the original driver behavior with any new or old device (be called data->ops->initialize(client) : usleep(100) , etc.. , because this times "data->quirks" is equal 0 at

Re: [PATCH 1/2] units: Add the HZ_PER_KHZ macro

2021-03-04 Thread Andrew Morton
On Thu, 4 Mar 2021 13:41:27 +0100 Daniel Lezcano wrote: > > Also, why make them signed types? Negative Hz is physically > > nonsensical. If that upsets some code somewhere because it was dealing > > with signed types then, well, that code needed fixing anyway. > > > > Ditto

Re: [f2fs-dev] [PATCH] f2fs: fix a redundant call to f2fs_balance_fs if an error occurs

2021-03-04 Thread Chao Yu
On 2021/3/4 17:21, Colin King wrote: From: Colin Ian King The uninitialized variable dn.node_changed does not get set when a call to f2fs_get_node_page fails. This uninitialized value gets used in the call to f2fs_balance_fs() that may or not may not balances dirty node and dentry pages

Re: XDP socket rings, and LKMM litmus tests

2021-03-04 Thread Boqun Feng
On Thu, Mar 04, 2021 at 11:11:42AM -0500, Alan Stern wrote: > On Thu, Mar 04, 2021 at 02:33:32PM +0800, Boqun Feng wrote: > > > Right, I was thinking about something unrelated.. but how about the > > following case: > > > > local_v = > > r1 = READ_ONCE(*x); // f > > > > if (r1 ==

[PATCH v2 17/17] KVM: x86/mmu: WARN on NULL pae_root or lm_root, or bad shadow root level

2021-03-04 Thread Sean Christopherson
WARN if KVM is about to dereference a NULL pae_root or lm_root when loading an MMU, and convert the BUG() on a bad shadow_root_level into a WARN (now that errors are handled cleanly). With nested NPT, botching the level and sending KVM down the wrong path is all too easy, and the on-demand

[PATCH v2 16/17] KVM: x86/mmu: Sync roots after MMU load iff load as successful

2021-03-04 Thread Sean Christopherson
For clarity, explicitly skip syncing roots if the MMU load failed instead of relying on the !VALID_PAGE check in kvm_mmu_sync_roots(). Signed-off-by: Sean Christopherson --- arch/x86/kvm/mmu/mmu.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/arch/x86/kvm/mmu/mmu.c

[PATCH v2 15/17] KVM: x86/mmu: Unexport MMU load/unload functions

2021-03-04 Thread Sean Christopherson
Unexport the MMU load and unload helpers now that they are no longer used (incorrectly) in vendor code. Opportunistically move the kvm_mmu_sync_roots() declaration into mmu.h, it should not be exposed to vendor code. No functional change intended. Signed-off-by: Sean Christopherson ---

[PATCH v2 13/17] KVM: nVMX: Defer the MMU reload to the normal path on an EPTP switch

2021-03-04 Thread Sean Christopherson
Defer reloading the MMU after a EPTP successful EPTP switch. The VMFUNC instruction itself is executed in the previous EPTP context, any side effects, e.g. updating RIP, should occur in the old context. Practically speaking, this bug is benign as VMX doesn't touch the MMU when skipping an

[PATCH v2 14/17] KVM: x86: Defer the MMU unload to the normal path on an global INVPCID

2021-03-04 Thread Sean Christopherson
Defer unloading the MMU after a INVPCID until the instruction emulation has completed, i.e. until after RIP has been updated. On VMX, this is a benign bug as VMX doesn't touch the MMU when skipping an emulated instruction. However, on SVM, if nrip is disabled, the emulator is used to skip an

[PATCH v2 12/17] KVM: SVM: Don't strip the C-bit from CR2 on #PF interception

2021-03-04 Thread Sean Christopherson
Don't strip the C-bit from the faulting address on an intercepted #PF, the address is a virtual address, not a physical address. Fixes: 0ede79e13224 ("KVM: SVM: Clear C-bit from the page fault address") Cc: sta...@vger.kernel.org Cc: Brijesh Singh Cc: Tom Lendacky Signed-off-by: Sean

[PATCH v2 11/17] KVM: x86/mmu: Mark the PAE roots as decrypted for shadow paging

2021-03-04 Thread Sean Christopherson
Set the PAE roots used as decrypted to play nice with SME when KVM is using shadow paging. Explicitly skip setting the C-bit when loading CR3 for PAE shadow paging, even though it's completely ignored by the CPU. The extra documentation is nice to have. Note, there are several subtleties at

[PATCH v2 09/17] KVM: x86/mmu: Use '0' as the one and only value for an invalid PAE root

2021-03-04 Thread Sean Christopherson
Use '0' to denote an invalid pae_root instead of '0' or INVALID_PAGE. Unlike root_hpa, the pae_roots hold permission bits and thus are guaranteed to be non-zero. Having to deal with both values leads to bugs, e.g. failing to set back to INVALID_PAGE, warning on the wrong value, etc...

[PATCH v2 10/17] KVM: x86/mmu: Set the C-bit in the PDPTRs and LM pseudo-PDPTRs

2021-03-04 Thread Sean Christopherson
Set the C-bit in SPTEs that are set outside of the normal MMU flows, specifically the PDPDTRs and the handful of special cased "LM root" entries, all of which are shadow paging only. Note, the direct-mapped-root PDPTR handling is needed for the scenario where paging is disabled in the guest, in

[PATCH v2 08/17] KVM: x86/mmu: Fix and unconditionally enable WARNs to detect PAE leaks

2021-03-04 Thread Sean Christopherson
Exempt NULL PAE roots from the check to detect leaks, since kvm_mmu_free_roots() doesn't set them back to INVALID_PAGE. Stop hiding the WARNs to detect PAE root leaks behind MMU_WARN_ON, the hidden WARNs obviously didn't do their job given the hilarious number of bugs that could lead to PAE roots

[PATCH v2 07/17] KVM: x86/mmu: Check PDPTRs before allocating PAE roots

2021-03-04 Thread Sean Christopherson
Check the validity of the PDPTRs before allocating any of the PAE roots, otherwise a bad PDPTR will cause KVM to leak any previously allocated roots. Signed-off-by: Sean Christopherson --- arch/x86/kvm/mmu/mmu.c | 20 ++-- 1 file changed, 14 insertions(+), 6 deletions(-) diff

[PATCH v2 06/17] KVM: x86/mmu: Ensure MMU pages are available when allocating roots

2021-03-04 Thread Sean Christopherson
Hold the mmu_lock for write for the entire duration of allocating and initializing an MMU's roots. This ensures there are MMU pages available and thus prevents root allocations from failing. That in turn fixes a bug where KVM would fail to free valid PAE roots if a one of the later roots failed

[PATCH v2 05/17] KVM: x86/mmu: Allocate pae_root and lm_root pages in dedicated helper

2021-03-04 Thread Sean Christopherson
Move the on-demand allocation of the pae_root and lm_root pages, used by nested NPT for 32-bit L1s, into a separate helper. This will allow a future patch to hold mmu_lock while allocating the non-special roots so that make_mmu_pages_available() can be checked once at the start of root

[PATCH v2 04/17] KVM: x86/mmu: Allocate the lm_root before allocating PAE roots

2021-03-04 Thread Sean Christopherson
Allocate lm_root before the PAE roots so that the PAE roots aren't leaked if the memory allocation for the lm_root happens to fail. Note, KVM can still leak PAE roots if mmu_check_root() fails on a guest's PDPTR, or if mmu_alloc_root() fails due to MMU pages not being available. Those issues will

[PATCH v2 03/17] KVM: x86/mmu: Capture 'mmu' in a local variable when allocating roots

2021-03-04 Thread Sean Christopherson
Grab 'mmu' and do s/vcpu->arch.mmu/mmu to shorten line lengths and yield smaller diffs when moving code around in future cleanup without forcing the new code to use the same ugly pattern. No functional change intended. Signed-off-by: Sean Christopherson --- arch/x86/kvm/mmu/mmu.c | 58

[PATCH v2 02/17] KVM: x86/mmu: Alloc page for PDPTEs when shadowing 32-bit NPT with 64-bit

2021-03-04 Thread Sean Christopherson
Allocate the so called pae_root page on-demand, along with the lm_root page, when shadowing 32-bit NPT with 64-bit NPT, i.e. when running a 32-bit L1. KVM currently only allocates the page when NPT is disabled, or when L0 is 32-bit (using PAE paging). Note, there is an existing memory leak

[PATCH v2 01/17] KVM: nSVM: Set the shadow root level to the TDP level for nested NPT

2021-03-04 Thread Sean Christopherson
Override the shadow root level in the MMU context when configuring NPT for shadowing nested NPT. The level is always tied to the TDP level of the host, not whatever level the guest happens to be using. Fixes: 096586fda522 ("KVM: nSVM: Correctly set the shadow NPT root level in its MMU role")

[PATCH v2 00/17] KVM: x86/mmu: Lots of bug fixes

2021-03-04 Thread Sean Christopherson
Fix nested NPT (nSVM) with 32-bit L1 and SME with shadow paging, which are completely broken. Opportunistically fix theoretical bugs related to prematurely reloading/unloading the MMU. If nNPT is enabled, L1 can crash the host simply by using 32-bit NPT to trigger a null pointer dereference on

Re: [PATCH] perf pmu: Validate raw event with sysfs exported format bits

2021-03-04 Thread Andi Kleen
> Single event: > > # ./perf stat -e cpu/r031234/ -a -- sleep 1 > WARNING: event config '31234' not valid (bits 16 17 not supported by > kernel)! Just noticed that again. Can you please print the original event as string in the message? While it's obvious with rXXX which one it is, it may

Re: [PATCH net-next v2 3/3] net: phy: broadcom: Allow BCM54210E to configure APD

2021-03-04 Thread Vladimir Oltean
On Tue, Mar 02, 2021 at 07:37:34PM -0800, Florian Fainelli wrote: > Took a while but for the 54210E reference board here are the numbers, > your mileage will vary depending on the supplies, regulator efficiency > and PCB design around the PHY obviously: > > BMCR.PDOWN: 86.12 mW

linux-next: manual merge of the tty tree with the powerpc-fixes tree

2021-03-04 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the tty tree got a conflict in: drivers/tty/hvc/hvcs.c between commit: 386a966f5ce7 ("vio: make remove callback return void") from the powerpc-fixes tree and commit: fb8d350c291c ("tty: hvc, drop unneeded forward declarations") from the tty tree. I

Re: [PATCH v2] sched: Optimize __calc_delta.

2021-03-04 Thread Josh Don
On Thu, Mar 4, 2021 at 9:34 AM Nick Desaulniers wrote: > > > Hi Josh, Thanks for helping get this patch across the finish line. > Would you mind updating the commit message to point to > https://bugs.llvm.org/show_bug.cgi?id=20197? Sure thing, just saw that it got marked as a dup. Peter, since

mm/filemap.c:2409:9: warning: stack frame size of 2704 bytes in function 'filemap_read'

2021-03-04 Thread kernel test robot
-20210304 (attached as .config) compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project eec7f8f7b1226be422a76542cb403d02538f453a) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x

Re: [PATCH v8 4/5] dma-buf: system_heap: Add drm pagepool support to system heap

2021-03-04 Thread kernel test robot
/linux.git 3cb60ee6323968b694208c4cbd56a7176396e931 config: openrisc-randconfig-p001-20210304 (attached as .config) compiler: or1k-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross

Re: [PATCH] Input: elan_i2c - Reduce the resume time for new dev ices

2021-03-04 Thread Dmitry Torokhov
Hi Jingle, On Tue, Mar 02, 2021 at 09:04:57AM +0800, jingle.wu wrote: > HI Dmitry: > > So data->ops->initialize(client) essentially performs reset of the > controller (we may want to rename it even) and as far as I understand > you would want to avoid resetting the controller on newer devices, >

Re: [PATCH v3 05/11] x86/entry: Convert ret_from_fork to C

2021-03-04 Thread Brian Gerst
On Thu, Mar 4, 2021 at 2:16 PM Andy Lutomirski wrote: > > ret_from_fork is written in asm, slightly differently, for x86_32 and > x86_64. Convert it to C. > > This is a straight conversion without any particular cleverness. As a > further cleanup, the code that sets up the ret_from_fork

Re: [PATCH v10 0/9] Add support for x509 certs with NIST P384/256/192 keys

2021-03-04 Thread Stefan Berger
Herbert,    you can take patches 1-8. 9 will not apply without Nayna's series as mentioned in the patch. Regards,    Stefan On 3/4/21 7:51 PM, Stefan Berger wrote: From: Stefan Berger This series of patches adds support for x509 certificates signed by a CA that uses NIST P384, P256 or

[PATCH v6] ARM: Implement SLS mitigation

2021-03-04 Thread Jian Cai
This patch adds CONFIG_HARDEN_SLS_ALL that can be used to turn on -mharden-sls=all, which mitigates the straight-line speculation vulnerability, speculative execution of the instruction following some unconditional jumps. Notice -mharden-sls= has other options as below, and this config turns on

[PATCH v10 4/9] ecdsa: Register NIST P384 and extend test suite

2021-03-04 Thread Stefan Berger
From: Saulo Alessandre * crypto/ecdsa.c - add ecdsa_nist_p384_init_tfm - register and unregister P384 tfm * crypto/testmgr.c - add test vector for P384 on vector of tests * crypto/testmgr.h - add test vector params for P384(sha1, sha224, sha256, sha384 and sha512) Signed-off-by:

[PATCH v10 8/9] x509: Add OID for NIST P384 and extend parser for it

2021-03-04 Thread Stefan Berger
From: Saulo Alessandre * crypto/asymmetric_keys/x509_cert_parser.c - prepare x509 parser to load nist_secp384r1 * include/linux/oid_registry.h - add OID_id_secp384r1 Signed-off-by: Saulo Alessandre Tested-by: Stefan Berger --- crypto/asymmetric_keys/x509_cert_parser.c | 3 +++

[PATCH v10 3/9] crypto: Add math to support fast NIST P384

2021-03-04 Thread Stefan Berger
From: Saulo Alessandre * crypto/ecc.c - add vli_mmod_fast_384 - change some routines to pass ecc_curve forward until vli_mmod_fast * crypto/ecc.h - add ECC_CURVE_NIST_P384_DIGITS - change ECC_MAX_DIGITS to P384 size Signed-off-by: Saulo Alessandre Tested-by: Stefan Berger ---

[PATCH v10 2/9] crypto: Add NIST P384 curve parameters

2021-03-04 Thread Stefan Berger
From: Saulo Alessandre * crypto/ecc_curve_defs.h - add nist_p384 params * include/crypto/ecdh.h - add ECC_CURVE_NIST_P384 * crypto/ecc.c - change ecc_get_curve to accept nist_p384 Signed-off-by: Saulo Alessandre Tested-by: Stefan Berger --- crypto/ecc.c| 2 ++

[for-linus][PATCH 1/3] tracing: Fix memory leak in __create_synth_event()

2021-03-04 Thread Steven Rostedt
From: Vamshi K Sthambamkadi kmemleak report: unreferenced object 0xc5a6f708 (size 8): comm "ftracetest", pid 1209, jiffies 4294911500 (age 6.816s) hex dump (first 8 bytes): 00 c1 3d 60 14 83 1f 8a ..=` backtrace: [] __kmalloc_track_caller+0x2a6/0x460

[for-linus][PATCH 2/3] tracing: Skip selftests if tracing is disabled

2021-03-04 Thread Steven Rostedt
From: "Steven Rostedt (VMware)" If tracing is disabled for some reason (traceoff_on_warning, command line, etc), the ftrace selftests are guaranteed to fail, as their results are defined by trace data in the ring buffers. If the ring buffers are turned off, the tests will fail, due to lack of

[for-linus][PATCH 0/3] More tracing fixes for 5.12

2021-03-04 Thread Steven Rostedt
Functional fix: - Memory leak in __create_synth_event() - Skip selftests if tracing is disabled Non functional fix: - Fix stale comment about the trace_event_call flags. Steven Rostedt (VMware) (2): tracing: Skip selftests if tracing is disabled tracing: Fix comment about the

[for-linus][PATCH 3/3] tracing: Fix comment about the trace_event_call flags

2021-03-04 Thread Steven Rostedt
From: "Steven Rostedt (VMware)" In the declaration of the struct trace_event_call, the flags has the bits defined in the comment above it. But these bits are also defined by the TRACE_EVENT_FL_* enums just above the declaration of the struct. As the comment about the flags in the struct has

[PATCH v10 7/9] ima: Support EC keys for signature verification

2021-03-04 Thread Stefan Berger
From: Stefan Berger Add support for IMA signature verification for EC keys. Since SHA type of hashes can be used by RSA and ECDSA signature schemes we need to look at the key and derive from the key which signature scheme to use. Since this can be applied to all types of keys, we change the

[PATCH v10 9/9] certs: Add support for using elliptic curve keys for signing modules

2021-03-04 Thread Stefan Berger
From: Stefan Berger This patch adds support for using elliptic curve keys for signing modules. It uses a NIST P384 (secp384r1) key if the user chooses an elliptic curve key and will have ECDSA support built into the kernel. Note: A developer choosing an ECDSA key for signing modules has to

[PATCH v10 1/9] crypto: Add support for ECDSA signature verification

2021-03-04 Thread Stefan Berger
From: Stefan Berger Add support for parsing the parameters of a NIST P256 or NIST P192 key. Enable signature verification using these keys. The new module is enabled with CONFIG_ECDSA: Elliptic Curve Digital Signature Algorithm (NIST P192, P256 etc.) is A NIST cryptographic standard

[PATCH v10 0/9] Add support for x509 certs with NIST P384/256/192 keys

2021-03-04 Thread Stefan Berger
From: Stefan Berger This series of patches adds support for x509 certificates signed by a CA that uses NIST P384, P256 or P192 keys for signing. It also adds support for certificates where the public key is one of this type of a key. The math for ECDSA signature verification is also added as

[PATCH v10 5/9] x509: Detect sm2 keys by their parameters OID

2021-03-04 Thread Stefan Berger
From: Stefan Berger Detect whether a key is an sm2 type of key by its OID in the parameters array rather than assuming that everything under OID_id_ecPublicKey is sm2, which is not the case. Cc: David Howells Cc: keyri...@vger.kernel.org Signed-off-by: Stefan Berger Reviewed-by: Tianjia Zhang

[PATCH v10 6/9] x509: Add support for parsing x509 certs with ECDSA keys

2021-03-04 Thread Stefan Berger
From: Stefan Berger This patch adds support for parsing of x509 certificates that contain ECDSA keys, such as NIST P256, that have been signed by a CA using any of the current SHA hash algorithms. Cc: David Howells Cc: keyri...@vger.kernel.org Signed-off-by: Stefan Berger --- v7->v8: - do

[PATCH] ASoC: codecs: lpass-wsa-macro: fix RX MIX input controls

2021-03-04 Thread Jonathan Marek
Attempting to use the RX MIX path at 48kHz plays at 96kHz, because these controls are incorrectly toggling the first bit of the register, which is part of the FS_RATE field. Fix the problem by using the same method used by the "WSA RX_MIX EC0_MUX" control, which is to use SND_SOC_NOPM as the

Re: Re: linux-next: build failure after merge of the pinctrl tree

2021-03-04 Thread Linus Walleij
On Fri, Mar 5, 2021 at 1:13 AM jay...@rock-chips.com wrote: > Could you show me the issue log ? It's attached to Stephen's original mail in this thread. Yours, Linus Walleij

RE: [PATCH V3 4/5] dt-bindings: mmc: fsl-imx-esdhc: add clock bindings

2021-03-04 Thread Peng Fan
Hi Rob, > Subject: Re: [PATCH V3 4/5] dt-bindings: mmc: fsl-imx-esdhc: add clock > bindings > > On Wed, Feb 24, 2021 at 9:23 PM wrote: > > > > From: Peng Fan > > > > Add clock bindings for fsl-imx-esdhc yaml > > > > Signed-off-by: Peng Fan > > --- > >

Re: [RFC PATCH 05/10] vfio: Create a vfio_device from vma lookup

2021-03-04 Thread Jason Gunthorpe
On Thu, Mar 04, 2021 at 05:07:31PM -0700, Alex Williamson wrote: > On Thu, 4 Mar 2021 19:16:33 -0400 > Jason Gunthorpe wrote: > > > On Thu, Mar 04, 2021 at 02:37:57PM -0700, Alex Williamson wrote: > > > > > Therefore unless a bus driver opts-out by replacing vm_private_data, we > > > can

Re: [PATCH] arm64: dts: ls1028a: add interrupt to Root Complex Event Collector

2021-03-04 Thread Shawn Guo
On Tue, Feb 09, 2021 at 01:52:59AM +0100, Michael Walle wrote: > The legacy interrupt INT_A is hardwired to the event collector. RCEC is > bascially supported starting with v5.11. Having a correct interrupt, will > make RCEC at least probe correctly. > > There are still issues with how RCEC is

RE: Re: [PATCH v26 4/4] scsi: ufs: Add HPB 2.0 support

2021-03-04 Thread Daejun Park
Hi Bean, > > + > > +static inline int ufshpb_get_read_id(struct ufshpb_lu *hpb) > > +{ > > + if (++hpb->cur_read_id >= MAX_HPB_READ_ID) > > + hpb->cur_read_id = 0; > > + return hpb->cur_read_id; > > +} > > + > > +static int ufshpb_execute_pre_req(struct ufshpb_lu *hpb,

[PATCH] clk: use clk_core_enable_lock() a bit more

2021-03-04 Thread Rasmus Villemoes
Use clk_core_enable_lock() and clk_core_disable_lock() in a few places rather than open-coding them. Signed-off-by: Rasmus Villemoes --- drivers/clk/clk.c | 18 +++--- 1 file changed, 3 insertions(+), 15 deletions(-) diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c index

RE: Re: [PATCH v26 4/4] scsi: ufs: Add HPB 2.0 support

2021-03-04 Thread Daejun Park
Hi, Can Guo > > diff --git a/drivers/scsi/ufs/ufs-sysfs.c > > b/drivers/scsi/ufs/ufs-sysfs.c > > index 2546e7a1ac4f..00fb519406cf 100644 > > --- a/drivers/scsi/ufs/ufs-sysfs.c > > +++ b/drivers/scsi/ufs/ufs-sysfs.c > > @@ -841,6 +841,7 @@ out:

Re: linux-next: rebase of the scsi-mkp tree

2021-03-04 Thread Stephen Rothwell
Hi James, On Thu, 04 Mar 2021 16:21:20 -0800 James Bottomley wrote: > > On Fri, 2021-03-05 at 11:04 +1100, Stephen Rothwell wrote: > > > > I notice that you have rebased the scsi-mkp tree. Unfotunately James > > has already merged part of the old version of the scsi-mkp tree int > > the scsi

Re: linux-next: Fixes tag needs some work in the block tree

2021-03-04 Thread Jens Axboe
On 3/4/21 4:52 PM, Stephen Rothwell wrote: > Hi all, > > In commit > > 284e4cdb0c0b ("nvme-hwmon: Return error code when registration fails") > > Fixes tag > > Fixes: ec420cdcfab4 ("nvme/hwmon: rework to avoid devm allocation") > > has these problem(s): > > - Target SHA1 does not exist

RE: Re: [PATCH v26 4/4] scsi: ufs: Add HPB 2.0 support

2021-03-04 Thread Daejun Park
Hi Bean, > > + > > +static inline void ufshpb_put_pre_req(struct ufshpb_lu *hpb, > > + struct ufshpb_req *pre_req) > > +{ > > + pre_req->req = NULL; > > + pre_req->bio = NULL; > > + list_add_tail(_req->list_req, >lh_pre_req_free); > > +

Re: [PATCH] pinctrl: qcom: lpass lpi: use default pullup/strength values

2021-03-04 Thread Jonathan Marek
On 3/4/21 7:05 PM, Bjorn Andersson wrote: On Thu 04 Mar 13:48 CST 2021, Jonathan Marek wrote: If these fields are not set in dts, the driver will use these variables uninitialized to set the fields. Not only will it set garbage values for these fields, but it can overflow into other fields and

Re: linux-next: rebase of the scsi-mkp tree

2021-03-04 Thread James Bottomley
On Fri, 2021-03-05 at 11:04 +1100, Stephen Rothwell wrote: > Hi Martin, > > I notice that you have rebased the scsi-mkp tree. Unfotunately James > has already merged part of the old version of the scsi-mkp tree int > the scsi tree so that commits f69d02e37a85..39ae3edda325 in the scsi- > mkp

[PATCH] x86: kprobes: orc: Fix ORC walks in kretprobes

2021-03-04 Thread Daniel Xu
Getting a stack trace from inside a kretprobe used to work with frame pointer stack walks. After the default unwinder was switched to ORC, stack traces broke because ORC did not know how to skip the `kretprobe_trampoline` "frame". Frame based stack walks used to work with kretprobes because

Re: [RFC PATCH 05/10] vfio: Create a vfio_device from vma lookup

2021-03-04 Thread Alex Williamson
On Thu, 4 Mar 2021 19:16:33 -0400 Jason Gunthorpe wrote: > On Thu, Mar 04, 2021 at 02:37:57PM -0700, Alex Williamson wrote: > > > Therefore unless a bus driver opts-out by replacing vm_private_data, we > > can identify participating vmas by the vm_ops and have flags indicating > > if the vma

Re: [PATCH] pinctrl: qcom: lpass lpi: use default pullup/strength values

2021-03-04 Thread Bjorn Andersson
On Thu 04 Mar 13:48 CST 2021, Jonathan Marek wrote: > If these fields are not set in dts, the driver will use these variables > uninitialized to set the fields. Not only will it set garbage values for > these fields, but it can overflow into other fields and break those. > > In the current

Re: [PATCH] crypto: ccp - Don't initialize SEV support without the SEV feature

2021-03-04 Thread Brijesh Singh
On 3/3/21 4:31 PM, Tom Lendacky wrote: > From: Tom Lendacky > > If SEV has been disabled (e.g. through BIOS), the driver probe will still > issue SEV firmware commands. The SEV INIT firmware command will return an > error in this situation, but the error code is a general error code that >

<    1   2   3   4   5   6   7   8   9   10   >