Re: [PATCH v1 5/8] software node: Imply kobj_to_swnode() to be no-op

2021-03-28 Thread Andy Shevchenko
On Sun, Mar 28, 2021 at 11:47 AM Greg Kroah-Hartman wrote: > > On Sun, Mar 28, 2021 at 12:20:09AM +0200, Andy Shevchenko wrote: > > Since we don't use structure field layout randomization > > the manual shuffling can affect some macros, in particular > > kobj_to_swnode(), which becomes a no-op

Re: [PATCH v1 6/8] software node: Simplify swnode_register() a bit

2021-03-28 Thread Andy Shevchenko
On Sun, Mar 28, 2021 at 11:48 AM Greg Kroah-Hartman wrote: > > On Sun, Mar 28, 2021 at 12:20:10AM +0200, Andy Shevchenko wrote: > > By introducing two temporary variables simplify swnode_register() a bit. > > No functional change intended. > > > > Signed-off-by: Andy Shevchenko > > --- > >

Re: [PATCH v7 5/5] docs: ABI: Add sysfs documentation interface of dw-xdata-pcie driver

2021-03-28 Thread Greg Kroah-Hartman
On Sat, Mar 27, 2021 at 04:06:55AM +0100, Gustavo Pimentel wrote: > This patch describes the sysfs interface implemented on the dw-xdata-pcie > driver. > > Signed-off-by: Gustavo Pimentel > --- > Documentation/ABI/testing/sysfs-driver-xdata | 46 > > 1 file

Re: [PATCH v7 2/5] misc: Add Synopsys DesignWare xData IP driver to Makefile and Kconfig

2021-03-28 Thread Greg Kroah-Hartman
On Sat, Mar 27, 2021 at 04:06:52AM +0100, Gustavo Pimentel wrote: > Add Synopsys DesignWare xData IP driver to Makefile and Kconfig. > > This driver enables/disables the PCIe traffic generator module > pertain to the Synopsys DesignWare prototype. > > Signed-off-by: Gustavo Pimentel > --- >

Re: [PATCH v7 1/5] misc: Add Synopsys DesignWare xData IP driver

2021-03-28 Thread Greg Kroah-Hartman
On Sat, Mar 27, 2021 at 04:06:51AM +0100, Gustavo Pimentel wrote: > Add Synopsys DesignWare xData IP driver. This driver enables/disables > the PCI traffic generator module pertain to the Synopsys DesignWare > prototype. > > Signed-off-by: Gustavo Pimentel > --- > drivers/misc/dw-xdata-pcie.c |

Re: [PATCH v7 0/5] misc: Add Add Synopsys DesignWare xData IP driver

2021-03-28 Thread Greg Kroah-Hartman
On Sat, Mar 27, 2021 at 04:06:50AM +0100, Gustavo Pimentel wrote: > This patch series adds a new driver called xData-pcie for the Synopsys > DesignWare PCIe prototype. > > The driver configures and enables the Synopsys DesignWare PCIe traffic > generator IP inside of prototype Endpoint which will

Re: [PATCH] scripts/spdxcheck.py: Fix a typo

2021-03-28 Thread Greg KH
On Fri, Mar 26, 2021 at 02:44:43PM +0530, Bhaskar Chowdhury wrote: > > s/Initilize/Initialize/ > > Signed-off-by: Bhaskar Chowdhury Now queued up, thanks. greg k-h

Re: [PATCH] kgdbts: Switch to do_sys_openat2() for breakpoint testing

2021-03-28 Thread Greg Kroah-Hartman
On Thu, Mar 25, 2021 at 09:48:07AM +, Daniel Thompson wrote: > Currently kgdbts can get stuck waiting for do_sys_open() to be called > in some of the current tests. This is because C compilers often > automatically inline this function, which is a very thin wrapper around > do_sys_openat2(),

Re: Testers wanted: Atom netbooks with x86_64 disabled by BIOS

2021-03-28 Thread Mateusz Jończyk
W dniu 28.03.2021 o 00:25, Willy Tarreau pisze: FWIW I tested on my ASUS 1025C which runs on an Atom N2600 forced to 32-bit. I had already tried in the past but wanted to give it a try again in case I'd have missed anything. Sadly it didn't work, I'm still getting the "requires an x86-64 CPU"

Re: [PATCH v10 2/6] arm64: kvm: Introduce MTE VM feature

2021-03-28 Thread Catalin Marinas
On Sat, Mar 27, 2021 at 03:23:24PM +, Catalin Marinas wrote: > On Fri, Mar 12, 2021 at 03:18:58PM +, Steven Price wrote: > > diff --git a/arch/arm64/kvm/mmu.c b/arch/arm64/kvm/mmu.c > > index 77cb2d28f2a4..b31b7a821f90 100644 > > --- a/arch/arm64/kvm/mmu.c > > +++ b/arch/arm64/kvm/mmu.c >

Re: [PATCH next 2/2] misc: Add Renesas Synchronization Management Unit (SMU) support

2021-03-28 Thread Greg KH
On Fri, Mar 26, 2021 at 11:34:11AM -0400, min.li...@renesas.com wrote: > From: Min Li > > This driver is developed for the IDT ClockMatrix(TM) and 82P33xxx families > of timing and synchronization devices.It will be used by Renesas PTP Clock > Manager for Linux (pcm4l) software to provide

Re: [PATCH v2 19/20] staging: rtl8723bs: include macro in a do - while loop in core/rtw_security.c

2021-03-28 Thread Greg KH
On Sat, Mar 27, 2021 at 03:24:18PM +0100, Fabio Aiuto wrote: > fix the following checkpatch warning: > > ERROR: Macros with multiple statements should be enclosed > in a do - while loop > 2014: FILE: drivers/staging/rtl8723bs/core/rtw_security.c:2014: > +#define ROUND(i, d, s) \ > >

Re: [PATCH v2 09/20] staging: rtl8723bs: put parentheses on macros with complex values in include/rtw_debug.h

2021-03-28 Thread Greg KH
On Sat, Mar 27, 2021 at 03:24:08PM +0100, Fabio Aiuto wrote: > fix the following checkpatch warning: > > ERROR: Macros starting with if should be enclosed by a > do - while loop to avoid possible if/else logic defects > + #define RT_PRINT_DATA(_Comp, _Level, > _TitleString, _HexData,

[PATCH bpf-next] bpf: tcp: Remove comma which is causing build error

2021-03-28 Thread Atul Gopinathan
Currently, building the bpf-next source with the CONFIG_BPF_SYSCALL enabled is causing a compilation error: "net/ipv4/bpf_tcp_ca.c:209:28: error: expected identifier or '(' before ',' token" Fix this by removing an unnecessary comma. Reported-by:

Re: [PATCH v4 1/2] char: xillybus: Move class-related functions to new xillybus_class.c

2021-03-28 Thread Greg KH
On Tue, Mar 23, 2021 at 02:05:23PM +0200, Eli Billauer wrote: > On 22/03/21 13:11, Greg KH wrote: > > > > > XILLYBUS and XILLYBUS_PCIE are currently enabled as M in several Linux > > > distributions. Making them depend on, rather than select XILLYBUS_CLASS is > > > likely to disable the driver in

Re: [PATCH v5 4/7] powerpc/qspinlock: Add ARCH_USE_QUEUED_SPINLOCKS_XCHG32

2021-03-28 Thread Guo Ren
On Sun, Mar 28, 2021 at 7:14 PM Christophe Leroy wrote: > > > > Le 28/03/2021 à 08:30, guo...@kernel.org a écrit : > > From: Guo Ren > > > > We don't have native hw xchg16 instruction, so let qspinlock > > generic code to deal with it. > > We have lharx/sthcx pair on some versions of powerpc. >

Re: [PATCH mvebu v3 00/10] Armada 37xx: Fix cpufreq changing base CPU speed to 800 MHz from 1000 MHz

2021-03-28 Thread Pali Rohár
On Friday 12 March 2021 10:12:06 Gregory CLEMENT wrote: > Hello Pali, > > > Hello Gregory! > > > > Patches are the for almost two months and more people have tested them. > > They are marked with Fixed/CC-stable tags, they should go also into > > stable trees as they are fixing CPU scaling and

Re: [PATCH v4 2/5] powercap/drivers/dtpm: Create a registering system

2021-03-28 Thread Greg KH
On Sun, Mar 28, 2021 at 01:11:30PM +0200, Daniel Lezcano wrote: > > Hi Greg, > > On 28/03/2021 08:50, Greg KH wrote: > > [ ... ] > > >>> And any reason why you are not using "real" struct devices in this > >>> subsystem? You seem to be rolling your own infrastructure for no good > >>> reason.

Re: [PATCH v5 4/7] powerpc/qspinlock: Add ARCH_USE_QUEUED_SPINLOCKS_XCHG32

2021-03-28 Thread Christophe Leroy
Le 28/03/2021 à 08:30, guo...@kernel.org a écrit : From: Guo Ren We don't have native hw xchg16 instruction, so let qspinlock generic code to deal with it. We have lharx/sthcx pair on some versions of powerpc. See

Re: [PATCH] arm64: move --fix-cortex-a53-843419 linker test to Kconfig

2021-03-28 Thread Catalin Marinas
On Sun, Mar 28, 2021 at 03:59:29PM +0900, Masahiro Yamada wrote: > On Fri, Mar 26, 2021 at 11:36 PM Catalin Marinas > wrote: > > On Wed, Mar 24, 2021 at 04:11:28PM +0900, Masahiro Yamada wrote: > > > $(call ld-option, --fix-cortex-a53-843419) in arch/arm64/Makefile is > > > evaluated every time

Re: [PATCH v4 2/5] powercap/drivers/dtpm: Create a registering system

2021-03-28 Thread Daniel Lezcano
Hi Greg, On 28/03/2021 08:50, Greg KH wrote: [ ... ] >>> And any reason why you are not using "real" struct devices in this >>> subsystem? You seem to be rolling your own infrastructure for no good >>> reason. I imagine you want sysfs support next, right? >> >> Actually, the framework is on

[PATCH] ASoC: audio-graph-card: Add audio mixer for Motorola mdm6600

2021-03-28 Thread Pavel Machek
motmdm.c handles audio configuration on "gsmtty2"; it needs to know whether we are in call or not; that part is in motmdm-state.c and listens on "gsmtty1". To configure Alsamixer for voice calls do for example: Speaker Right -> Voice Call Noise Cancellation -> Unmute Call Output -> Speakerphone

Re: [PATCH] powerpc: Fix HAVE_HARDLOCKUP_DETECTOR_ARCH build configuration

2021-03-28 Thread Christophe Leroy
Le 27/03/2021 à 10:49, Chen Huang a écrit : When compiling the powerpc with the SMP disabled, it shows the issue: arch/powerpc/kernel/watchdog.c: In function ‘watchdog_smp_panic’: arch/powerpc/kernel/watchdog.c:177:4: error: implicit declaration of function ‘smp_send_nmi_ipi’; did you mean

[GIT PULL] x86 fixes

2021-03-28 Thread Ingo Molnar
Linus, Please pull the latest x86/urgent git tree from: git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git x86-urgent-2021-03-28 # HEAD: 9fcb51c14da2953de585c5c6e50697b8a6e91a7b x86/build: Turn off -fcf-protection for realmode targets Two fixes: - Fix build failure on Ubuntu

Re: [PATCH] kconfig: nconf: stop endless search-up loops

2021-03-28 Thread Joe Perches
On Sun, 2021-03-28 at 11:27 +0200, Mihai Moldovan wrote: > * On 3/27/21 11:26 PM, Randy Dunlap wrote: > > There is a test for it in checkpatch.pl but I also used checkpatch.pl > > without it complaining, so I don't know what it takes to make the script > > complain. > > > > if

Re: [PATCH] kconfig: nconf: stop endless search-up loops

2021-03-28 Thread Joe Perches
On Sat, 2021-03-27 at 15:26 -0700, Randy Dunlap wrote: > On 3/27/21 3:12 PM, Mihai Moldovan wrote: > > * On 3/27/21 4:58 PM, Randy Dunlap wrote: > > > On 3/27/21 5:01 AM, Mihai Moldovan wrote: > > > > + if ((-1 == index) && (index == match_start)) > > > > > > checkpatch doesn't

[GIT PULL] locking fix

2021-03-28 Thread Ingo Molnar
Linus, Please pull the latest locking/urgent git tree from: git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git locking-urgent-2021-03-28 # HEAD: 291da9d4a9eb3a1cb0610b7f4480f5b52b1825e7 locking/mutex: Fix non debug version of mutex_lock_io_nested() Fix the non-debug

[PATCH v3 3/4] scsi: sd: use expecting_media_change for BLIST_MEDIA_CHANGE devices

2021-03-28 Thread Martin Kepplinger
For SD cardreader devices that have the BLIST_MEDIA_CHANGE flag set, ignore one MEDIA CHANGE unit attention after resuming from runtime suspend. These devices issue said unit attention when resuming even when no medium changed. expecting_media_change is the device flag that is being clearing in

[PATCH v3 1/4] scsi: add expecting_media_change flag to error path

2021-03-28 Thread Martin Kepplinger
SD Cardreaders (especially) sometimes lose the state during suspend and deliver a "media changed" unit attention when really only a (runtime) suspend/resume cycle has been done. For such devices, I/O fails when runtime PM is enabled, see below. That's the motivation to add this flag. If set by a

[PATCH v3 2/4] scsi: devinfo: add new flag BLIST_MEDIA_CHANGE

2021-03-28 Thread Martin Kepplinger
add a new flag for devices that issue MEDIA CHANGE unit attentions when actually no medium changed. Drivers can for example set the expecting_media_change device flag in order to ignore the next following MEDIA CHANGE unit attention. Signed-off-by: Martin Kepplinger ---

[PATCH v3 4/4] scsi: devinfo: add BLIST_MEDIA_CHANGE for Ultra HS-SD/MMC usb cardreaders

2021-03-28 Thread Martin Kepplinger
This cardreader device issues a MEDIA CHANGE unit attention not only when actually a medium changed but also simply when resuming from suspend. (probably because the device can't know what happens during suspend and want to say "medium could have changed"). Signed-off-by: Martin Kepplinger ---

[PATCH v3 0/4] scsi: add runtime PM workaround for SD cardreaders

2021-03-28 Thread Martin Kepplinger
hi, In short: there are SD cardreaders that send MEDIA_CHANGED on (runtime) resume. We cannot use runtime PM with these devices as I/O always fails. I'd like to discuss a way to fix this or at least allow us to work around this problem: For the full background, the discussion started in June

Re: [PATCH v2 1/3] iommu: io-pgtable: add DART pagetable format

2021-03-28 Thread Sven Peter
Hi, On Sun, Mar 28, 2021, at 11:42, kernel test robot wrote: > > All errors (new ones prefixed by >>): > > >> nios2-linux-ld: drivers/iommu/io-pgtable.o:(.rodata+0x1c): undefined > >> reference to `io_pgtable_apple_dart_init_fns' > > That one was me not being careful enough when removing the

Re: [PATCH v2 3/3] iommu: dart: Add DART iommu driver

2021-03-28 Thread Sven Peter
Hi, On Sun, Mar 28, 2021, at 11:34, kernel test robot wrote: > > All error/warnings (new ones prefixed by >>): > >drivers/iommu/apple-dart-iommu.c: In function 'apple_dart_finalize_domain': > >> drivers/iommu/apple-dart-iommu.c:427:34: error: implicit declaration of > >> function

Re: [PATCH v2 1/3] iommu: io-pgtable: add DART pagetable format

2021-03-28 Thread kernel test robot
patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Sven-Peter/Apple-M1-DART-IOMMU-driver/20210328-154437 base: https://git.kernel.org/pub/scm/linux/kernel/git/will/linux.git for-next/perf config: m68k

Re: [1/5] reporting-issues: header and TLDR

2021-03-28 Thread Greg KH
On Sun, Mar 28, 2021 at 11:23:30AM +0200, Thorsten Leemhuis wrote: > On 26.03.21 07:15, Thorsten Leemhuis wrote: > > On 26.03.21 07:13, Thorsten Leemhuis wrote: > >> > >> Lo! Since a few months mainline in > >> Documentation/admin-guide/reporting-issues.rst contains a text written > >> to obsolete

Re: [PATCH v2 1/1] PCI: pciehp: Skip DLLSC handling if DPC is triggered

2021-03-28 Thread Lukas Wunner
On Wed, Mar 17, 2021 at 01:02:07PM -0700, Kuppuswamy, Sathyanarayanan wrote: > On 3/17/21 12:01 PM, Lukas Wunner wrote: > > If the events are ignored, the driver of the device in the hotplug slot > > is not unbound and rebound. So the driver must be able to cope with > > loss of TLPs during DPC

[PATCH v2] kconfig: nconf: stop endless search-up loops

2021-03-28 Thread Mihai Moldovan
If the user selects the very first entry in a page and performs a search-up operation (e.g., via [/][a][Up Arrow]), nconf will never terminate searching the page. The reason is that in this case, the starting point will be set to -1, which is then translated into (n - 1) (i.e., the last entry of

Re: [PATCH v2 1/3] iommu: io-pgtable: add DART pagetable format

2021-03-28 Thread kernel test robot
patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Sven-Peter/Apple-M1-DART-IOMMU-driver/20210328-154437 base: https://git.kernel.org/pub/scm/linux/kernel/git/will/linux.git for-next/perf config: nios2

Re: [PATCH v2 3/3] iommu: dart: Add DART iommu driver

2021-03-28 Thread kernel test robot
, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Sven-Peter/Apple-M1-DART-IOMMU-driver/20210328-154437 base: https://git.kernel.org/pub/scm/linux/kernel/git/will/linux.git for-next/perf config: sparc

Re: [PATCH] kconfig: nconf: stop endless search-up loops

2021-03-28 Thread Mihai Moldovan
* On 3/27/21 11:26 PM, Randy Dunlap wrote: > There is a test for it in checkpatch.pl but I also used checkpatch.pl > without it complaining, so I don't know what it takes to make the script > complain. > > if ($lead !~ /(?:$Operators|\.)\s*$/ && >

Re: [PATCH v2 2/3] dt-bindings: iommu: add DART iommu bindings

2021-03-28 Thread Sven Peter
On Sun, Mar 28, 2021, at 10:16, Arnd Bergmann wrote: > On Sun, Mar 28, 2021 at 9:40 AM Sven Peter wrote: > > I noticed only one detail here: > > > + - |+ > > +dart2a: dart2a@82f0 { > > + compatible = "apple,t8103-dart"; > > + reg = <0x82f0 0x4000>; > > +

Re: [1/5] reporting-issues: header and TLDR

2021-03-28 Thread Thorsten Leemhuis
On 26.03.21 07:15, Thorsten Leemhuis wrote: > On 26.03.21 07:13, Thorsten Leemhuis wrote: >> >> Lo! Since a few months mainline in >> Documentation/admin-guide/reporting-issues.rst contains a text written >> to obsolete the good old reporting-bugs text. For now, the new document >> still contains

Re: [PATCH v3] coccinelle: misc: add swap script

2021-03-28 Thread Denis Efremov
Ping? On 3/5/21 1:09 PM, Denis Efremov wrote: Check for opencoded swap() implementation. Signed-off-by: Denis Efremov --- Changes in v2: - additional patch rule to drop excessive {} - fix indentation in patch mode by anchoring ; Changes in v3: - Rule added for simple (without var init)

[BUG] fs/notify/mark: A potential use after free in fsnotify_put_mark_wake

2021-03-28 Thread lyl2019
Hi, My static analyzer tool reported a use after free in fsnotify_put_mark_wake of the file: fs/notify/mark.c. In fsnotify_put_mark_wake, it calls fsnotify_put_mark(mark). Inside the function fsnotify_put_mark(), if conn is NULL, it will call fsnotify_final_mark_destroy(mark) to free

Re: [PATCH v2 1/1] PCI: pciehp: Skip DLLSC handling if DPC is triggered

2021-03-28 Thread Lukas Wunner
On Sat, Mar 27, 2021 at 10:49:45PM -0700, Kuppuswamy, Sathyanarayanan wrote: > On 3/16/21 9:13 PM, Lukas Wunner wrote: > > --- a/drivers/pci/hotplug/pciehp_hpc.c > > +++ b/drivers/pci/hotplug/pciehp_hpc.c > > @@ -707,6 +707,17 @@ static irqreturn_t pciehp_ist(int irq, void *dev_id) > > } > >

Re: [PATCH v2] lib: fix kconfig dependency on ARCH_WANT_FRAME_POINTERS

2021-03-28 Thread Andreas Schwab
On Mär 28 2021, Julian Braha wrote: > diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug > index 2779c29d9981..8d53ed423899 100644 > --- a/lib/Kconfig.debug > +++ b/lib/Kconfig.debug > @@ -1665,7 +1665,7 @@ config LATENCYTOP > depends on DEBUG_KERNEL > depends on STACKTRACE_SUPPORT >

Re: [PATCH] tty: fix memory leak in vc_deallocate

2021-03-28 Thread Pavel Skripkin
Hi! On Sun, 2021-03-28 at 10:45 +0200, Greg KH wrote: > On Sun, Mar 28, 2021 at 12:44:43AM +0300, Pavel Skripkin wrote: > > syzbot reported memory leak in tty/vt. > > The problem was in VT_DISALLOCATE ioctl cmd. > > After allocating unimap with PIO_UNIMAP it wasn't > > freed via VT_DISALLOCATE,

Re: [PATCH] tty: fix memory leak in vc_deallocate

2021-03-28 Thread Greg KH
On Sun, Mar 28, 2021 at 12:44:43AM +0300, Pavel Skripkin wrote: > syzbot reported memory leak in tty/vt. > The problem was in VT_DISALLOCATE ioctl cmd. > After allocating unimap with PIO_UNIMAP it wasn't > freed via VT_DISALLOCATE, but vc_cons[currcons].d was > zeroed. > > Signed-off-by: Pavel

Re: [PATCH v2] lib: fix kconfig dependency on ARCH_WANT_FRAME_POINTERS

2021-03-28 Thread Geert Uytterhoeven
Hi Julian, On Sun, Mar 28, 2021 at 6:14 AM Julian Braha wrote: > When LATENCYTOP is enabled and ARCH_WANT_FRAME_POINTERS > is disabled, Kbuild gives the following warning: > > WARNING: unmet direct dependencies detected for FRAME_POINTER > Depends on [n]: DEBUG_KERNEL [=y] && (M68K || UML ||

Re: [PATCH v1 6/8] software node: Simplify swnode_register() a bit

2021-03-28 Thread Greg Kroah-Hartman
On Sun, Mar 28, 2021 at 12:20:10AM +0200, Andy Shevchenko wrote: > By introducing two temporary variables simplify swnode_register() a bit. > No functional change intended. > > Signed-off-by: Andy Shevchenko > --- > drivers/base/swnode.c | 11 +-- > 1 file changed, 5 insertions(+), 6

Re: [PATCH v1 5/8] software node: Imply kobj_to_swnode() to be no-op

2021-03-28 Thread Greg Kroah-Hartman
On Sun, Mar 28, 2021 at 12:20:09AM +0200, Andy Shevchenko wrote: > Since we don't use structure field layout randomization > the manual shuffling can affect some macros, in particular > kobj_to_swnode(), which becomes a no-op when kobj member > is the first one in the struct swnode. > >

Re: [PATCH v2 09/20] staging: rtl8723bs: put parentheses on macros with complex values in include/rtw_debug.h

2021-03-28 Thread Joe Perches
On Sat, 2021-03-27 at 15:24 +0100, Fabio Aiuto wrote: > fix the following checkpatch warning: > > ERROR: Macros starting with if should be enclosed by a > do - while loop to avoid possible if/else logic defects > + #define RT_PRINT_DATA(_Comp, _Level, > _TitleString, _HexData,

Re: [PATCH v2 2/3] dt-bindings: iommu: add DART iommu bindings

2021-03-28 Thread Arnd Bergmann
On Sun, Mar 28, 2021 at 9:40 AM Sven Peter wrote: I noticed only one detail here: > + - |+ > +dart2a: dart2a@82f0 { > + compatible = "apple,t8103-dart"; > + reg = <0x82f0 0x4000>; > + interrupts = <1 781 4>; > + #iommu-cells = <1>; > +}; The name of the

[PATCH] scsi/bnx2fc/bnx2fx_fcore: Fix a double free in bnx2fc_rcv

2021-03-28 Thread Lv Yunlong
In bnx2fc_rcv, it calls skb_share_check(skb,GFP_ATOMIC) to clone the skb. But if skb_clone() failed, skb_share_check() will free the skb in the first time and return NULL. Then skb_share_check() returns NULL and goto err. Unfortunately, the same skb is freed in the second time in err. I think

Re: [PATCH bpf-next 3/5] libbpf: add low level TC-BPF API

2021-03-28 Thread Kumar Kartikeya Dwivedi
On Sun, Mar 28, 2021 at 10:12:40AM IST, Andrii Nakryiko wrote: > Is there some succinct but complete enough documentation/tutorial/etc > that I can reasonably read to understand kernel APIs provided by TC > (w.r.t. BPF, of course). I'm trying to wrap my head around this and > whether API makes

[PATCH] media: cx23885: switch from 'pci_' to 'dma_' API

2021-03-28 Thread Christophe JAILLET
The wrappers in include/linux/pci-dma-compat.h should go away. The patch has been generated with the coccinelle script below and has been hand modified to replace GFP_ with a correct flag. It has been compile tested. When memory is allocated in 'cx23885_risc_buffer()' GFP_KERNEL can be used

[syzbot] bpf-next build error (3)

2021-03-28 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:fddbf4b6 Merge branch 'bpf: Support calling kernel function' git tree: bpf-next console output: https://syzkaller.appspot.com/x/log.txt?x=11e7a362d0 kernel config: https://syzkaller.appspot.com/x/.config?x=7eff0f22b8563a5f

[PATCH] drivers/net/wan/hdlc_fr: Fix a double free in pvc_xmit

2021-03-28 Thread Lv Yunlong
In pvc_xmit, if __skb_pad(skb, pad, false) failed, it will free the skb in the first time and goto drop. But the same skb is freed by kfree_skb(skb) in the second time in drop. Maintaining the original function unchanged, my patch adds a new label out to avoid the double free if __skb_pad()

[PATCH v2 2/3] dt-bindings: iommu: add DART iommu bindings

2021-03-28 Thread Sven Peter
DART (Device Address Resolution Table) is the iommu found on Apple ARM SoCs such as the M1. Signed-off-by: Sven Peter --- .../devicetree/bindings/iommu/apple,dart.yaml | 81 +++ MAINTAINERS | 6 ++ 2 files changed, 87 insertions(+) create mode

[PATCH v2 3/3] iommu: dart: Add DART iommu driver

2021-03-28 Thread Sven Peter
Apple's new SoCs use iommus for almost all peripherals. These Device Address Resolution Tables must be setup before these peripherals can act as DMA masters. Signed-off-by: Sven Peter --- MAINTAINERS | 1 + drivers/iommu/Kconfig| 14 + drivers/iommu/Makefile

[PATCH v2 0/3] Apple M1 DART IOMMU driver

2021-03-28 Thread Sven Peter
Hi, Here's v2 of my Apple M1 DART IOMMU driver series as a follow up to the original version [1]. Short summary: this series adds support for the iommu found in Apple's new M1 SoC which is required to use DMA on most peripherals. So far this code has been tested with dwc3 in host and device mode

[PATCH v2 1/3] iommu: io-pgtable: add DART pagetable format

2021-03-28 Thread Sven Peter
Apple's DART iommu uses a pagetable format that shares some similarities with the ones already implemented by io-pgtable.c. Add a new format variant to support the required differences so that we don't have to duplicate the pagetable handling code. Signed-off-by: Sven Peter ---

[PATCH] net:tipc: Fix a double free in tipc_sk_mcast_rcv

2021-03-28 Thread Lv Yunlong
In the if(skb_peek(arrvq) == skb) branch, it calls __skb_dequeue(arrvq) to get the skb by skb = skb_peek(arrvq). Then __skb_dequeue() unlinks the skb from arrvq and returns the skb which equals to skb_peek(arrvq). After __skb_dequeue(arrvq) finished, the skb is freed by

RE: [PATCH 1/1] scsi: ufs: Remove duplicated header file inclusion

2021-03-28 Thread Avri Altman
> > The header file is already included above and can be > removed here. Already removed, see https://lore.kernel.org/lkml/20210306114706.217873-1-zhang.yun...@zte.com.cn/ Thanks, Avri > > Signed-off-by: Zhen Lei > --- > drivers/scsi/ufs/ufshcd.c | 1 - > 1 file changed, 1 deletion(-) > >

Re: [PATCH] tools: Remove duplicate definition of ia64_mf() on ia64

2021-03-28 Thread John Paul Adrian Glaubitz
Hello! On 3/23/21 7:25 PM, John Paul Adrian Glaubitz wrote: > The ia64_mf() macro defined in tools/arch/ia64/include/asm/barrier.h > is already defined in on ia64 which causes libbpf > failing to build: > > CC /usr/src/linux/tools/bpf/bpftool//libbpf/staticobjs/libbpf.o > In file

Re: [PATCH, v2] tools: Remove inclusion of ia64-specific version of errno.h header

2021-03-28 Thread John Paul Adrian Glaubitz
Hello! On 3/23/21 7:04 PM, John Paul Adrian Glaubitz wrote: > There is no longer an ia64-specific version of the errno.h header > below arch/ia64/include/uapi/asm/, so trying to build tools/bpf > fails with: > > CC /usr/src/linux/tools/bpf/bpftool/btf_dumper.o > In file included from

Re: [PATCH] arm64: move --fix-cortex-a53-843419 linker test to Kconfig

2021-03-28 Thread Masahiro Yamada
On Fri, Mar 26, 2021 at 11:36 PM Catalin Marinas wrote: > > Hi Masahiro, > > On Wed, Mar 24, 2021 at 04:11:28PM +0900, Masahiro Yamada wrote: > > $(call ld-option, --fix-cortex-a53-843419) in arch/arm64/Makefile is > > evaluated every time even for Make targets that do not need the linker, > >

Re: [PATCH v4 2/5] powercap/drivers/dtpm: Create a registering system

2021-03-28 Thread Greg KH
On Sat, Mar 27, 2021 at 08:41:24PM +0100, Daniel Lezcano wrote: > On 27/03/2021 13:50, Greg KH wrote: > > On Fri, Mar 12, 2021 at 02:04:08PM +0100, Daniel Lezcano wrote: > >> A SoC can be differently structured depending on the platform and the > >> kernel can not be aware of all the combinations,

[PATCH 1/1] net: sched: extend lifetime of new action in replace mode

2021-03-28 Thread Kumar Kartikeya Dwivedi
When creating an action in replace mode, in tcf_action_add, the refcount of existing actions is rightly raised during tcf_idr_check_alloc call, but for new actions a dummy placeholder entry is created. This is then replaced with the actual action during tcf_idr_insert_many, but between this and

Re: [PATCH v1 3/8] software node: Show properties and their values in sysfs

2021-03-28 Thread Greg Kroah-Hartman
On Sun, Mar 28, 2021 at 12:20:07AM +0200, Andy Shevchenko wrote: > It's very convenient to see what properties and their values > are currently being assigned in the registered software nodes. > > Show properties and their values in sysfs. > > Signed-off-by: Andy Shevchenko > --- >

[PATCH v5 7/7] xtensa: qspinlock: Add ARCH_USE_QUEUED_SPINLOCKS_XCHG32

2021-03-28 Thread guoren
From: Guo Ren We don't have native hw xchg16 instruction, so let qspinlock generic code to deal with it. Using the full-word atomic xchg instructions implement xchg16 has the semantic risk for atomic operations. This patch cancels the dependency of on qspinlock generic code on architecture's

[PATCH v5 6/7] sparc: qspinlock: Add ARCH_USE_QUEUED_SPINLOCKS_XCHG32

2021-03-28 Thread guoren
From: Guo Ren We don't have native hw xchg16 instruction, so let qspinlock generic code to deal with it. Using the full-word atomic xchg instructions implement xchg16 has the semantic risk for atomic operations. This patch cancels the dependency of on qspinlock generic code on architecture's

[PATCH v5 5/7] openrisc: qspinlock: Add ARCH_USE_QUEUED_SPINLOCKS_XCHG32

2021-03-28 Thread guoren
From: Guo Ren We don't have native hw xchg16 instruction, so let qspinlock generic code to deal with it. Using the full-word atomic xchg instructions implement xchg16 has the semantic risk for atomic operations. This patch cancels the dependency of on qspinlock generic code on architecture's

[PATCH v5 3/7] csky: Convert custom spinlock/rwlock to generic qspinlock/qrwlock

2021-03-28 Thread guoren
From: Guo Ren Update the C-SKY port to use the generic qspinlock and qrwlock. C-SKY only support ldex.w/stex.w with word(double word) size & align access. So it must select XCHG32 to let qspinlock only use word atomic xchg_tail. Signed-off-by: Guo Ren Cc: Waiman Long Cc: Peter Zijlstra Cc:

[PATCH v5 4/7] powerpc/qspinlock: Add ARCH_USE_QUEUED_SPINLOCKS_XCHG32

2021-03-28 Thread guoren
From: Guo Ren We don't have native hw xchg16 instruction, so let qspinlock generic code to deal with it. Using the full-word atomic xchg instructions implement xchg16 has the semantic risk for atomic operations. This patch cancels the dependency of on qspinlock generic code on architecture's

[PATCH v5 2/7] riscv: Convert custom spinlock/rwlock to generic qspinlock/qrwlock

2021-03-28 Thread guoren
From: Michael Clark Update the RISC-V port to use the generic qspinlock and qrwlock. This patch requires support for xchg_xtail for full-word which are added by a previous patch: Guo added select ARCH_USE_QUEUED_SPINLOCKS_XCHG32 in Kconfig Guo fixed up compile error which made by below

[PATCH v5 1/7] locking/qspinlock: Add ARCH_USE_QUEUED_SPINLOCKS_XCHG32

2021-03-28 Thread guoren
From: Guo Ren Some architectures don't have sub-word swap atomic instruction, they only have the full word's one. The sub-word swap only improve the performance when: NR_CPUS < 16K * 0- 7: locked byte * 8: pending * 9-15: not used * 16-17: tail index * 18-31: tail cpu (+1) The 9-15

[PATCH v5 0/7] riscv: Add qspinlock/qrwlock

2021-03-28 Thread guoren
From: Guo Ren Current riscv is still using baby spinlock implementation. It'll cause fairness and cache line bouncing problems. Many people are involved and pay the efforts to improve it: - The first version of patch was made in 2019.1:

Re: Testers wanted: Atom netbooks with x86_64 disabled by BIOS

2021-03-28 Thread Willy Tarreau
Hi Thomas, On Sun, Mar 28, 2021 at 03:07:24AM +0200, Thomas Gleixner wrote: > On Sun, Mar 28 2021 at 00:25, Willy Tarreau wrote: > > On Sat, Mar 27, 2021 at 10:13:22PM +0100, Mateusz Jonczyk wrote: > > FWIW I tested on my ASUS 1025C which runs on an Atom N2600 forced to > > 32-bit. I had already

<    1   2   3   4   5