Re: Compiling Linux kernel into a build directory

2021-04-02 Thread Randy Dunlap
On 4/2/21 11:29 AM, James Courtier-Dutton wrote: > Hi, > > Currently, when one builds the linux kernel, it places .o files all > over the source code tree. > Is there a way to have the linux kernel build, but place all the .o > files into a separate build folder? > Similar to how cmake or ninja

Re: [PATCH V2 3/5] arm64: dts: qcom: pmk8350: Add PMIC peripherals for pmk8350

2021-04-02 Thread Matthias Kaehlcke
On Thu, Apr 01, 2021 at 02:43:14PM +0530, satya priya wrote: > subject: arm64: dts: qcom: pmk8350: Add PMIC peripherals for pmk8350 same nit as for 1/5: maybe just 'arm64: dts: qcom: Add pml7350 support/.dtsi' or similar since this adds the initial .dtsi for the pmk8350? > Add PON, GPIO, RTC and

Re: [PATCH] qemu_fw_cfg: Make fw_cfg_rev_attr a proper kobj_attribute

2021-04-02 Thread Sedat Dilek
On Fri, Apr 2, 2021 at 8:31 PM Nathan Chancellor wrote: > > On Fri, Apr 02, 2021 at 11:25:42AM -0700, Kees Cook wrote: > > On Fri, Apr 02, 2021 at 08:42:07AM +0200, Sedat Dilek wrote: > > > On Thu, Feb 25, 2021 at 10:25 PM Kees Cook wrote: > > > > > > > > On Thu, 11 Feb 2021 12:42:58 -0700,

Re: [PATCH RESEND 0/3] x86/sgx: eextend ioctl

2021-04-02 Thread Dave Hansen
On 4/2/21 11:31 AM, Jethro Beekman wrote: > On 2021-04-02 17:53, Dave Hansen wrote: >> On 4/2/21 1:38 AM, Jethro Beekman wrote: So, we're talking here about pages that have been EEADDED, but for which we do not want to include the entire contents of the page? Do these contents

Re: [PATCH 14/16] staging: rtl8723bs: remove all RT_TRACE logs in core/rtw_wlan_util.c

2021-04-02 Thread Joe Perches
On Fri, 2021-04-02 at 19:40 +0200, Fabio Aiuto wrote: > On Fri, Apr 02, 2021 at 08:20:17AM -0700, Joe Perches wrote: > > On Fri, 2021-04-02 at 14:51 +0200, Fabio Aiuto wrote: > > > On Fri, Apr 02, 2021 at 03:37:57AM -0700, Joe Perches wrote: > > > > On Fri, 2021-04-02 at 12:01 +0200, Fabio Aiuto

Re: [PATCH] riscv: Bump COMMAND_LINE_SIZE value to 1024

2021-04-02 Thread Maciej W. Rozycki
On Fri, 2 Apr 2021, David Abdurachmanov wrote: > > > > This macro is exported as a part of the user API so it must not depend > > > > on > > > > Kconfig. Also changing it (rather than say adding COMMAND_LINE_SIZE_V2 > > > > or > > > > switching to an entirely new data object that has its

Re: [PATCH bpf-next 3/5] libbpf: add low level TC-BPF API

2021-04-02 Thread Alexei Starovoitov
On Fri, Apr 2, 2021 at 8:27 AM Kumar Kartikeya Dwivedi wrote: > > This would be fine, because it's not a fast path or anything, but right now we > return the id using the netlink response, otherwise for query we have to open > the socket, prepare the msg, send and recv again. So it's a minor >

Re: [PATCH RESEND 0/3] x86/sgx: eextend ioctl

2021-04-02 Thread Jethro Beekman
On 2021-04-02 17:53, Dave Hansen wrote: > On 4/2/21 1:38 AM, Jethro Beekman wrote: >>> So, we're talking here about pages that have been EEADDED, but for >>> which we do not want to include the entire contents of the page? >>> Do these contents always include the beginning of the page, or can >>>

Re: [PATCH] qemu_fw_cfg: Make fw_cfg_rev_attr a proper kobj_attribute

2021-04-02 Thread Nathan Chancellor
On Fri, Apr 02, 2021 at 11:25:42AM -0700, Kees Cook wrote: > On Fri, Apr 02, 2021 at 08:42:07AM +0200, Sedat Dilek wrote: > > On Thu, Feb 25, 2021 at 10:25 PM Kees Cook wrote: > > > > > > On Thu, 11 Feb 2021 12:42:58 -0700, Nathan Chancellor wrote: > > > > fw_cfg_showrev() is called by an

Re: [PATCH 1/2] zram: fix crashes due to use of cpu hotplug multistate

2021-04-02 Thread Luis Chamberlain
On Fri, Apr 02, 2021 at 09:54:12AM +0200, Greg KH wrote: > On Thu, Apr 01, 2021 at 11:59:25PM +, Luis Chamberlain wrote: > > As for the syfs deadlock possible with drivers, this fixes it in a generic > > way: > > > > commit fac43d8025727a74f80a183cc5eb74ed902a5d14 > > Author: Luis

Compiling Linux kernel into a build directory

2021-04-02 Thread James Courtier-Dutton
Hi, Currently, when one builds the linux kernel, it places .o files all over the source code tree. Is there a way to have the linux kernel build, but place all the .o files into a separate build folder? Similar to how cmake or ninja work when building C source code. One possible advantage of

Re: [PATCH 1/4] mm/page_reporting: Introduce free page reported counters

2021-04-02 Thread Alexander Duyck
On Fri, Mar 26, 2021 at 2:45 AM Xunlei Pang wrote: > > It's useful to know how many memory has been actually reported, > so add new zone::reported_pages to record that. > > Add "/sys/kernel/mm/page_reporting/reported_kbytes" for the > actual memory has been reported. > > Add

[PATCH v4 2/4] drivers/tty/serial/8250: refactor sirq and lpc address setting code

2021-04-02 Thread Zev Weiss
This splits dedicated aspeed_vuart_set_{sirq,lpc_address}() functions out of the sysfs store functions in preparation for adding DT properties that will be poking the same registers. While we're at it, these functions now provide some basic bounds-checking on their arguments. Signed-off-by: Zev

[PATCH v4 1/4] dt-bindings: serial: 8250: deprecate aspeed,sirq-polarity-sense

2021-04-02 Thread Zev Weiss
This property ties SIRQ polarity to SCU register bits that don't necessarily have any direct relationship to it; the only use of it was removed in commit c82bf6e133d30e0f9172a20807814fa28aef0f67. Signed-off-by: Zev Weiss Reviewed-by: Joel Stanley ---

[PATCH v4 4/4] dt-bindings: serial: 8250: add aspeed,lpc-io-reg and aspeed,lpc-interrupts

2021-04-02 Thread Zev Weiss
These correspond to the existing lpc_address, sirq, and sirq_polarity sysfs attributes; the second element of aspeed,lpc-interrupts provides a replacement for the deprecated aspeed,sirq-polarity-sense property. Signed-off-by: Zev Weiss --- .../devicetree/bindings/serial/8250.yaml | 27

[PATCH v4 3/4] drivers/tty/serial/8250: add aspeed,lpc-io-reg and aspeed,lpc-interrupts DT properties

2021-04-02 Thread Zev Weiss
These allow describing all the Aspeed VUART attributes currently available via sysfs. aspeed,sirq provides a replacement for the deprecated aspeed,sirq-polarity-sense property. Signed-off-by: Zev Weiss --- drivers/tty/serial/8250/8250_aspeed_vuart.c | 44 - 1 file changed,

[PATCH v4 0/4] aspeed-vuart: generalized DT properties

2021-04-02 Thread Zev Weiss
This series generalizes the aspeed-vuart driver's device tree properties to cover all the attributes it currently exposes via sysfs. The aspeed,sirq-polarity-sense property was a bit of a design mistake in that it ties Aspeed VUART SIRQ polarity to SCU register bits that aren't really inherently

[PATCH] wireless: marvell: mwl8k: Fix a double Free in mwl8k_probe_hw

2021-04-02 Thread Lv Yunlong
In mwl8k_probe_hw, hw->priv->txq is freed at the first time by dma_free_coherent() in the call chain: if(!priv->ap_fw)->mwl8k_init_txqs(hw)->mwl8k_txq_init(hw, i). Then in err_free_queues of mwl8k_probe_hw, hw->priv->txq is freed at the second time by mwl8k_txq_deinit(hw, i)->dma_free_coherent().

Re: [PATCH] qemu_fw_cfg: Make fw_cfg_rev_attr a proper kobj_attribute

2021-04-02 Thread Kees Cook
On Fri, Apr 02, 2021 at 08:42:07AM +0200, Sedat Dilek wrote: > On Thu, Feb 25, 2021 at 10:25 PM Kees Cook wrote: > > > > On Thu, 11 Feb 2021 12:42:58 -0700, Nathan Chancellor wrote: > > > fw_cfg_showrev() is called by an indirect call in kobj_attr_show(), > > > which violates clang's CFI checking

Re: [PATCH v2 00/10] ipmi_si: Set of clean ups

2021-04-02 Thread Corey Minyard
On Fri, Apr 02, 2021 at 08:43:24PM +0300, Andy Shevchenko wrote: > The series contains set of clean ups, main parts of which are: > - use ne platform_get_mem_or_io() API > - use match_string() API As I have already said, a very nice set of cleanups. Thank you. These are applied and in the ipmi

Re: [PATCH] lib/string: Introduce sysfs_streqcase

2021-04-02 Thread Kees Cook
On Fri, Apr 02, 2021 at 11:17:13AM -0700, Nick Desaulniers wrote: > Thanks for the patch! > > + akpm (please remember to run ./scripts/get_maintainer.pl on your patch > files) > > On Fri, Apr 2, 2021 at 2:41 AM Gioh Kim wrote: > > > > As the name shows, it checks if strings are equal in case

Re: [PATCH 1/1] dmaengine: idxd: Add IDXD performance monitor support

2021-04-02 Thread kernel test robot
Hi Tom, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on vkoul-dmaengine/next] [also build test WARNING on linux/master linus/master v5.12-rc5 next-20210401] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we

[PATCH net-next v2 5/5] mvneta: recycle buffers

2021-04-02 Thread Matteo Croce
From: Matteo Croce Use the new recycling API for page_pool. In a drop rate test, the packet rate increased di 10%, from 269 Kpps to 296 Kpps. perf top on a stock system shows: Overhead Shared Object Symbol 21.78% [kernel] [k] __pi___inval_dcache_area 21.66% [mvneta]

Re: [PATCH net v2] atl1c: move tx cleanup processing out of interrupt

2021-04-02 Thread Eric Dumazet
On 4/2/21 7:20 PM, Gatis Peisenieks wrote: > Tx queue cleanup happens in interrupt handler on same core as rx queue > processing. > Both can take considerable amount of processing in high packet-per-second > scenarios. > ... > @@ -2504,6 +2537,7 @@ static int atl1c_init_netdev(struct

Re: [RESEND PATCH] bus: mhi: core: Remove pre_init flag used for power purposes

2021-04-02 Thread Hemant Kumar
On 4/1/21 2:41 PM, Bhaumik Bhatt wrote: Some controllers can choose to skip preparation for power up. In that case, device context is initialized based on the pre_init flag not being set during mhi_prepare_for_power_up(). There is no reason MHI host driver should maintain and provide

[PATCH net-next v2 4/5] mvpp2: recycle buffers

2021-04-02 Thread Matteo Croce
From: Matteo Croce Use the new recycling API for page_pool. In a drop rate test, the packet rate is more than doubled, from 962 Kpps to 2047 Kpps. perf top on a stock system shows: Overhead Shared Object Symbol 30.67% [kernel] [k] page_pool_release_page 8.37% [kernel]

[PATCH net-next v2 3/5] page_pool: Allow drivers to hint on SKB recycling

2021-04-02 Thread Matteo Croce
From: Ilias Apalodimas Up to now several high speed NICs have custom mechanisms of recycling the allocated memory they use for their payloads. Our page_pool API already has recycling capabilities that are always used when we are running in 'XDP mode'. So let's tweak the API and the kernel

Re: [PATCH v6 00/21] Miscellaneous fixes for resctrl selftests

2021-04-02 Thread Fenghua Yu
Hi, Shuah, On Fri, Apr 02, 2021 at 12:17:17PM -0600, Shuah Khan wrote: > On 3/26/21 1:45 PM, Fenghua Yu wrote: > > Hi, Shuah, > > > > On Wed, Mar 17, 2021 at 02:22:34AM +, Fenghua Yu wrote: > > > This patch set has several miscellaneous fixes to resctrl selftest tool > > > that are easily

Re: [PATCH net-next v8 2/2] net: Add Qcom WWAN control driver

2021-04-02 Thread Loic Poulain
On Fri, 2 Apr 2021 at 17:43, Greg KH wrote: > > On Fri, Apr 02, 2021 at 05:41:01PM +0200, Loic Poulain wrote: > > On Fri, 2 Apr 2021 at 16:05, Greg KH wrote: > > > > > > On Fri, Apr 02, 2021 at 04:06:37PM +0200, Loic Poulain wrote: > > > > The MHI WWWAN control driver allows MHI QCOM-based

[PATCH net-next v2 2/5] mm: add a signature in struct page

2021-04-02 Thread Matteo Croce
From: Matteo Croce This is needed by the page_pool to avoid recycling a page not allocated via page_pool. Signed-off-by: Matteo Croce --- include/linux/mm_types.h | 1 + include/net/page_pool.h | 2 ++ net/core/page_pool.c | 4 3 files changed, 7 insertions(+) diff --git

[PATCH net-next v2 1/5] xdp: reduce size of struct xdp_mem_info

2021-04-02 Thread Matteo Croce
From: Jesper Dangaard Brouer It is possible to compress/reduce the size of struct xdp_mem_info. This change reduce struct xdp_mem_info from 8 bytes to 4 bytes. The member xdp_mem_info.id can be reduced to u16, as the mem_id_ht rhashtable in net/core/xdp.c is already limited by MEM_ID_MAX=0xFFFE

Re: [PATCH 0/4] mm/page_reporting: Some knobs and fixes

2021-04-02 Thread Alexander Duyck
On Thu, Apr 1, 2021 at 9:09 PM Xunlei Pang wrote: > > On 3/26/21 5:44 PM, Xunlei Pang wrote: > > Add the following knobs in PATCH 1~3: > > /sys/kernel/mm/page_reporting/reported_kbytes > > /sys/kernel/mm/page_reporting/refault_kbytes > > /sys/kernel/mm/page_reporting/reporting_factor > > > >

[PATCH net-next v2 0/5] page_pool: recycle buffers

2021-04-02 Thread Matteo Croce
From: Matteo Croce This is a respin of [1] This patchset shows the plans for allowing page_pool to handle and maintain DMA map/unmap of the pages it serves to the driver. For this to work a return hook in the network core is introduced. The overall purpose is to simplify drivers, by

Re: [RFC v2] KVM: x86: Support KVM VMs sharing SEV context

2021-04-02 Thread Sean Christopherson
On Tue, Mar 16, 2021, Nathan Tempelman wrote: > diff --git a/arch/x86/kvm/svm/sev.c b/arch/x86/kvm/svm/sev.c > index 874ea309279f..b2c90c67a0d9 100644 > --- a/arch/x86/kvm/svm/sev.c > +++ b/arch/x86/kvm/svm/sev.c > @@ -66,6 +66,11 @@ static int sev_flush_asids(void) > return ret; > } > >

Re: [PATCH] lib/string: Introduce sysfs_streqcase

2021-04-02 Thread Nick Desaulniers
Thanks for the patch! + akpm (please remember to run ./scripts/get_maintainer.pl on your patch files) On Fri, Apr 2, 2021 at 2:41 AM Gioh Kim wrote: > > As the name shows, it checks if strings are equal in case insensitive > manner. I found some cases using strncasecmp to check the entire >

Re: [PATCH v6 00/21] Miscellaneous fixes for resctrl selftests

2021-04-02 Thread Shuah Khan
On 3/26/21 1:45 PM, Fenghua Yu wrote: Hi, Shuah, On Wed, Mar 17, 2021 at 02:22:34AM +, Fenghua Yu wrote: This patch set has several miscellaneous fixes to resctrl selftest tool that are easily visible to user. V1 had fixes to CAT test and CMT test but they were dropped in V2 because having

Re: [PATCH v2 3/6] soc: actions: Add Actions Semi Owl socinfo driver

2021-04-02 Thread Manivannan Sadhasivam
On Tue, Mar 30, 2021 at 04:48:18PM +0300, Cristian Ciocaltea wrote: > The driver provides information about the Action Semi Owl family of > SoCs (S500, S700 and S900) to user space via sysfs: machine, family, > soc_id, serial_number. > > Note the serial number is currently provided only for the

Re: [PATCH v1 0/2] Add imx8m power domain driver

2021-04-02 Thread Adrien Grassein
Le ven. 2 avr. 2021 à 19:58, Abel Vesa a écrit : > > On 21-04-02 19:48:41, Adrien Grassein wrote: > > Hi, > > > > Le ven. 2 avr. 2021 à 19:42, Abel Vesa a écrit : > > > > > > On 21-04-02 18:45:04, Adrien Grassein wrote: > > > > Hi, > > > > > > > > this patch et aims to add the support of the

Re: [PATCH v2] psi: allow unprivileged users with CAP_SYS_RESOURCE to write psi files

2021-04-02 Thread Kees Cook
On Thu, Apr 01, 2021 at 10:58:33PM -0400, Josh Hunt wrote: > Currently only root can write files under /proc/pressure. Relax this to > allow tasks running as unprivileged users with CAP_SYS_RESOURCE to be > able to write to these files. > > Signed-off-by: Josh Hunt Reviewed-by: Kees Cook --

Re: [PATCH] net: initialize local variables in net/ipv6/mcast.c and net/ipv4/igmp.c

2021-04-02 Thread Phillip Potter
On Fri, Apr 02, 2021 at 07:49:44PM +0200, Eric Dumazet wrote: > > > On 4/2/21 7:36 PM, Phillip Potter wrote: > > Use memset to initialize two local buffers in net/ipv6/mcast.c, > > and another in net/ipv4/igmp.c. Fixes a KMSAN found uninit-value > > bug reported by syzbot at: > >

Re: [PATCH v5 00/21] Miscellaneous fixes for resctrl selftests

2021-04-02 Thread Shuah Khan
On 3/12/21 3:11 PM, Fenghua Yu wrote: Hi, Babu, On Fri, Mar 12, 2021 at 01:08:11PM -0600, Babu Moger wrote: Hi Fenghua, Thanks for the patches. Sanity tested them on AMD systems. Appears to work fine. Few minor comments in few patches. Tested-by: Babu Moger I will add Tested-by: Babu Moger

Re: [PATCH v2 1/6] dt-bindings: reserved-memory: Add Owl SoC serial number binding

2021-04-02 Thread Manivannan Sadhasivam
On Thu, Apr 01, 2021 at 08:40:01PM +0300, Cristian Ciocaltea wrote: > On Thu, Apr 01, 2021 at 12:07:04PM -0500, Rob Herring wrote: > > On Tue, Mar 30, 2021 at 04:48:16PM +0300, Cristian Ciocaltea wrote: > > > Add devicetree binding for the Actions Semi Owl SoC serial number > > > reserved-memory

Re: [PATCH net v2] atl1c: move tx cleanup processing out of interrupt

2021-04-02 Thread Eric Dumazet
On 4/2/21 7:20 PM, Gatis Peisenieks wrote: > Tx queue cleanup happens in interrupt handler on same core as rx queue > processing. > Both can take considerable amount of processing in high packet-per-second > scenarios. > > Sending big amounts of packets can stall the rx processing which is

Re: [PATCH v2 2/6] dt-bindings: soc: actions: Add Actions Semi Owl socinfo binding

2021-04-02 Thread Manivannan Sadhasivam
On Tue, Mar 30, 2021 at 04:48:17PM +0300, Cristian Ciocaltea wrote: > Add devicetree binding for the Actions Semi Owl socinfo driver. > Devicetree binding shouldn't be added for a driver instead for an IP or hw. > Signed-off-by: Cristian Ciocaltea > --- >

Re: fs/gfs2/rgrp.c:1772:53: warning: Possible null pointer dereference: minext [nullPointer]

2021-04-02 Thread Andreas Gruenbacher
gfs2: Silence possible null pointer dereference warning In gfs2_rbm_find, rs is always NULL when minext is NULL, so gfs2_reservation_check_and_update will never be called on a NULL minext. This isn't immediately obvious though, so also check for a NULL minext for better code readability.

Re: [PATCH net-next v8 1/2] net: Add a WWAN subsystem

2021-04-02 Thread kernel test robot
Hi Loic, I love your patch! Perhaps something to improve: [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Loic-Poulain/net-Add-a-WWAN-subsystem/20210402-220002 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git

[PATCH] net: fix err_cast.cocci warnings

2021-04-02 Thread kernel test robot
-by: kernel test robot --- url: https://github.com/0day-ci/linux/commits/Loic-Poulain/net-Add-a-WWAN-subsystem/20210402-220002 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git bd78980be1a68d14524c51c4b4170782fada622b wwan_core.c |2 +- 1 file changed, 1 insertion(+), 1

Re: [PATCH] lib/string: Introduce sysfs_streqcase

2021-04-02 Thread kernel test robot
' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Gioh-Kim/lib-string-Introduce-sysfs_streqcase/20210402-174251 base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 5e46d1b78a03d52306f21f77a4e4a144b6d31486 config: mips

Re: [PATCH] kunit: tool: make --kunitconfig accept dirs, add lib/kunit fragment

2021-04-02 Thread Shuah Khan
On 4/2/21 3:32 AM, Brendan Higgins wrote: TL;DR $ ./tools/testing/kunit/kunit.py run --kunitconfig=lib/kunit Per suggestion from Ted [1], we can reduce the amount of typing by assuming a convention that these files are named '.kunitconfig'. In the case of [1], we now have $

Re: [PATCH v1 0/2] Add imx8m power domain driver

2021-04-02 Thread Abel Vesa
On 21-04-02 19:48:41, Adrien Grassein wrote: > Hi, > > Le ven. 2 avr. 2021 à 19:42, Abel Vesa a écrit : > > > > On 21-04-02 18:45:04, Adrien Grassein wrote: > > > Hi, > > > > > > this patch et aims to add the support of the i.MX 8 Power Domain driver. > > > Some devices (like usbotg2) can't work

Re: [PATCH v6 3/4] x86/vmemmap: Handle unpopulated sub-pmd ranges

2021-04-02 Thread Oscar Salvador
On Tue, Mar 30, 2021 at 03:29:50AM +0100, Matthew Wilcox wrote: > I can reproduce this with next-20210329. > > .config attached. Hi Matthew, Thanks for the report. I tried to reproduce this with the attached config on next-20210401 and I had no luck. You still see it on that one? Thanks --

[PATCH v1] Bluetooth: Return whether a connection is outbound

2021-04-02 Thread Yu Liu
When an MGMT_EV_DEVICE_CONNECTED event is reported back to the user space we will set the flags to tell if the established connection is outbound or not. This is useful for the user space to log better metrics and error messages. Reviewed-by: Miao-chen Chou Reviewed-by: Alain Michaud

Re: [PATCH v2] psi: allow unprivileged users with CAP_SYS_RESOURCE to write psi files

2021-04-02 Thread Johannes Weiner
On Thu, Apr 01, 2021 at 10:58:33PM -0400, Josh Hunt wrote: > Currently only root can write files under /proc/pressure. Relax this to > allow tasks running as unprivileged users with CAP_SYS_RESOURCE to be > able to write to these files. > > Signed-off-by: Josh Hunt > Acked-by: Johannes Weiner

Re: [PATCH v4 1/2] kunit: support failure from dynamic analysis tools

2021-04-02 Thread Shuah Khan
On 4/2/21 2:55 AM, Brendan Higgins wrote: On Thu, Mar 11, 2021 at 7:23 AM Daniel Latypov wrote: From: Uriel Guajardo Add a kunit_fail_current_test() function to fail the currently running test, if any, with an error message. This is largely intended for dynamic analysis tools like UBSAN

Re: [PATCH] net: initialize local variables in net/ipv6/mcast.c and net/ipv4/igmp.c

2021-04-02 Thread Eric Dumazet
On 4/2/21 7:36 PM, Phillip Potter wrote: > Use memset to initialize two local buffers in net/ipv6/mcast.c, > and another in net/ipv4/igmp.c. Fixes a KMSAN found uninit-value > bug reported by syzbot at: > https://syzkaller.appspot.com/bug?id=0766d38c656abeace60621896d705743aeefed51 According

[PATCH v2 1/2] iio: trigger: Replace explicit casting and wrong specifier with proper one

2021-04-02 Thread Andy Shevchenko
By unknown reason device name is set with an index casted from int to unsigned long while at the same time with "%ld" specifier. Both parts seems wrong to me, thus replace replace explicit casting and wrong specifier with proper one, i.e. "%d". Signed-off-by: Andy Shevchenko --- v2: used %d

[PATCH v2 2/2] iio: trigger: Fix strange (ladder-type) indentation

2021-04-02 Thread Andy Shevchenko
In some cases indentation looks a bit weird with starting from = sign and being in a ladder-type style. Unify it across the module. While at it, add blank line after definition block where it needed, Signed-off-by: Andy Shevchenko --- v2: fixed typo in the commit message (tupe->type)

Re: [PATCH v1 0/2] Add imx8m power domain driver

2021-04-02 Thread Adrien Grassein
Hi, Le ven. 2 avr. 2021 à 19:42, Abel Vesa a écrit : > > On 21-04-02 18:45:04, Adrien Grassein wrote: > > Hi, > > > > this patch et aims to add the support of the i.MX 8 Power Domain driver. > > Some devices (like usbotg2) can't work without this patch as their > > attached power domain are

Re: [PATCH] kunit: make KUNIT_EXPECT_STREQ() quote values, don't print literals

2021-04-02 Thread Shuah Khan
On 4/2/21 3:35 AM, Brendan Higgins wrote: On Fri, Feb 5, 2021 at 2:18 PM Daniel Latypov wrote: Before: Expected str == "world", but str == hello "world" == world After: Expected str == "world", but str == "hello" Note: like the literal ellision for integers, this

Re: [PATCH v1 1/2] iio: trigger: Replace explicit casting and wrong specifier with proper one

2021-04-02 Thread Andy Shevchenko
On Fri, Apr 2, 2021 at 4:25 PM Andy Shevchenko wrote: > On Friday, April 2, 2021, Jonathan Cameron wrote: >> On Thu, 1 Apr 2021 17:54:56 +0300 >> Andy Shevchenko wrote: >> >> > By unknown reason device name is set with an index casted from int >> > to unsigned long while at the same time with

[PATCH v2 10/10] ipmi_si: Join string literals back

2021-04-02 Thread Andy Shevchenko
For easy grepping on debug purposes join string literals back in the messages. No functional change. Signed-off-by: Andy Shevchenko --- drivers/char/ipmi/ipmi_msghandler.c | 3 +- drivers/char/ipmi/ipmi_si_hardcode.c | 50 +--- drivers/char/ipmi/ipmi_si_hotmod.c |

[PATCH v2 05/10] ipmi_si: Introduce ipmi_panic_event_str[] array

2021-04-02 Thread Andy Shevchenko
Instead of repeating twice the constant literals, introduce ipmi_panic_event_str[] array. It allows to simplify the code with help of match_string() API. Signed-off-by: Andy Shevchenko --- drivers/char/ipmi/ipmi_msghandler.c | 51 +++-- 1 file changed, 19 insertions(+),

[PATCH v2 07/10] ipmi_si: Get rid of ->addr_source_cleanup()

2021-04-02 Thread Andy Shevchenko
The ->addr_source_cleanup() callback is solely used by PCI driver and only for one purpose, i.e. to disable device. Get rid of ->addr_source_cleanup() by switching to PCI managed API. Signed-off-by: Andy Shevchenko --- drivers/char/ipmi/ipmi_si.h | 2 -- drivers/char/ipmi/ipmi_si_intf.c |

[PATCH v2 06/10] ipmi_si: Reuse si_to_str[] array in ipmi_hardcode_init_one()

2021-04-02 Thread Andy Shevchenko
Instead of making the comparison one by one, reuse si_to_str[] array in ipmi_hardcode_init_one() in conjunction with match_string() API. Signed-off-by: Andy Shevchenko --- drivers/char/ipmi/ipmi_si.h | 6 +- drivers/char/ipmi/ipmi_si_hardcode.c | 23 +--

[PATCH v2 08/10] ipmi_si: Use strstrip() to remove surrounding spaces

2021-04-02 Thread Andy Shevchenko
Instead of home grown analogue, use strstrip() from the kernel library. Signed-off-by: Andy Shevchenko --- drivers/char/ipmi/ipmi_si_hotmod.c | 16 1 file changed, 4 insertions(+), 12 deletions(-) diff --git a/drivers/char/ipmi/ipmi_si_hotmod.c

[PATCH v2 09/10] ipmi_si: Drop redundant check before calling put_device()

2021-04-02 Thread Andy Shevchenko
put_device() is NULL aware, drop redundant check before calling it. Signed-off-by: Andy Shevchenko --- drivers/char/ipmi/ipmi_si_hotmod.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/char/ipmi/ipmi_si_hotmod.c b/drivers/char/ipmi/ipmi_si_hotmod.c index

[PATCH v2 01/10] ipmi_si: Switch to use platform_get_mem_or_io()

2021-04-02 Thread Andy Shevchenko
Switch to use new platform_get_mem_or_io() instead of home grown analogue. Note, we also introduce ipmi_set_addr_data_and_space() helper here. Signed-off-by: Andy Shevchenko --- drivers/char/ipmi/ipmi_si_platform.c | 34 1 file changed, 14 insertions(+), 20

[PATCH v2 00/10] ipmi_si: Set of clean ups

2021-04-02 Thread Andy Shevchenko
The series contains set of clean ups, main parts of which are: - use ne platform_get_mem_or_io() API - use match_string() API Since v2: - patch 3: rephrased commit message (Corey) - patch 5: added a comment that array maps to enum (Corey) - patch 5: added "ipmi" prefix to the name of the array

[PATCH v2 02/10] ipmi_si: Remove bogus err_free label

2021-04-02 Thread Andy Shevchenko
There is no more 'free' in the error path, so drop the label and return errors inline. Signed-off-by: Andy Shevchenko --- drivers/char/ipmi/ipmi_si_platform.c | 17 + 1 file changed, 5 insertions(+), 12 deletions(-) diff --git a/drivers/char/ipmi/ipmi_si_platform.c

[PATCH v2 03/10] ipmi_si: Utilize temporary variable to hold device pointer

2021-04-02 Thread Andy Shevchenko
Introduce a temporary variable to hold a device pointer. It can be utilized in the ->probe() and save a bit of LOCs. Signed-off-by: Andy Shevchenko --- drivers/char/ipmi/ipmi_si_platform.c | 15 +++ 1 file changed, 7 insertions(+), 8 deletions(-) diff --git

[PATCH v2 04/10] ipmi_si: Use proper ACPI macros to check error code for failures

2021-04-02 Thread Andy Shevchenko
Instead of direct comparison, use proper ACPI macros to check error code for failures. While at it, drop unneeded 'else' keyword. Signed-off-by: Andy Shevchenko --- drivers/char/ipmi/ipmi_si_platform.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git

[PATCH] iio: buffer: use sysfs_attr_init() on allocated attrs

2021-04-02 Thread Alexandru Ardelean
When dynamically allocating sysfs attributes, it's a good idea to call sysfs_attr_init() on them to initialize lock_class_keys. This change does that. The lock_class_keys are set when the CONFIG_DEBUG_LOCK_ALLOC symbol is enabled. Which is [likely] one reason why I did not see this during

Re: [PATCH v1 0/2] Add imx8m power domain driver

2021-04-02 Thread Abel Vesa
On 21-04-02 18:45:04, Adrien Grassein wrote: > Hi, > > this patch et aims to add the support of the i.MX 8 Power Domain driver. > Some devices (like usbotg2) can't work without this patch as their > attached power domain are down. > > The original drivr was taken from le imx kernel and aapted to

Re: [PATCH v5 15/19] regulator: Support ROHM BD71815 regulators

2021-04-02 Thread Mark Brown
On Mon, Mar 29, 2021 at 03:59:51PM +0300, Matti Vaittinen wrote: Acked-by: Mark Brown but... > @@ -0,0 +1,676 @@ > +// SPDX-License-Identifier: GPL-2.0-only > +/* > + * Copyright 2014 Embest Technology Co. Ltd. Inc. Please make the entire comment a C++ one so things look more intentional. >

[PATCH] net: broadcom: bcm4908enet: Fix a double free in bcm4908_enet_dma_alloc

2021-04-02 Thread Lv Yunlong
In bcm4908_enet_dma_alloc, if callee bcm4908_dma_alloc_buf_descs() failed, it will free the ring->cpu_addr by dma_free_coherent() and return error. Then bcm4908_enet_dma_free() will be called, and free the same cpu_addr by dma_free_coherent() again. My patch set ring->cpu_addr to NULL after it is

Re: [PATCH v2 0/9] KVM: my debug patch queue

2021-04-02 Thread Paolo Bonzini
On 01/04/21 15:54, Maxim Levitsky wrote: Hi! I would like to publish two debug features which were needed for other stuff I work on. One is the reworked lx-symbols script which now actually works on at least gdb 9.1 (gdb 9.2 was reported to fail to load the debug symbols from the kernel for

Re: [PATCH 6/8] drivers: firmware: efi: libstub: enable generic commandline

2021-04-02 Thread Christophe Leroy
Le 30/03/2021 à 19:57, Daniel Walker a écrit : This adds code to handle the generic command line changes. The efi code appears that it doesn't benefit as much from this design as it could. For example, if you had a prepend command line with "nokaslr" then you might be helpful to re-enable it

[PATCH] net: initialize local variables in net/ipv6/mcast.c and net/ipv4/igmp.c

2021-04-02 Thread Phillip Potter
Use memset to initialize two local buffers in net/ipv6/mcast.c, and another in net/ipv4/igmp.c. Fixes a KMSAN found uninit-value bug reported by syzbot at: https://syzkaller.appspot.com/bug?id=0766d38c656abeace60621896d705743aeefed51 Reported-by:

Re: [PATCH V2 1/5] arm64: dts: qcom: pm7325: Add PMIC peripherals for pm7325

2021-04-02 Thread Matthias Kaehlcke
On Thu, Apr 01, 2021 at 02:43:12PM +0530, satya priya wrote: > subject: arm64: dts: qcom: pm7325: Add PMIC peripherals for pm7325 nit: maybe just 'arm64: dts: qcom: Add pm7325 support/.dtsi' or similar? > Add temp-alarm and GPIO support for pm7325. nit: it's more than that, you are adding the

Re: [PATCH 4/8] CMDLINE: powerpc: convert to generic builtin command line

2021-04-02 Thread Christophe Leroy
Le 30/03/2021 à 19:56, Daniel Walker a écrit : This updates the powerpc code to use the CONFIG_GENERIC_CMDLINE option. This includes a scripted mass convert of the config files to use the new generic cmdline. There is a bit of a trim effect here. It would seems that some of the config

Re: [PATCH v5 14/19] regulator: bd718x7, bd71828: Use ramp-delay helper

2021-04-02 Thread Mark Brown
On Mon, Mar 29, 2021 at 03:59:28PM +0300, Matti Vaittinen wrote: > Use generic regamp ramp-delay helper function instead of implementing own. > Acked-by: Mark Brown signature.asc Description: PGP signature

Re: [PATCH 3/8] powerpc: convert strcpy to strlcpy in prom_init

2021-04-02 Thread Christophe Leroy
Le 30/03/2021 à 19:56, Daniel Walker a écrit : There's only two users of strcpy and one is the command line handling. The generic command line handling uses strlcpy and it makes sense to convert this one other user to strlcpy to keep prom_init size consistent. Cc: xe-linux-exter...@cisco.com

Re: [PATCH 2/8] CMDLINE: drivers: of: ifdef out cmdline section

2021-04-02 Thread Christophe Leroy
Le 30/03/2021 à 19:56, Daniel Walker a écrit : It looks like there's some seepage of cmdline stuff into the generic device tree code. This conflicts with the generic cmdline implementation so I remove it in the case when that's enabled. Cc: xe-linux-exter...@cisco.com Signed-off-by: Ruslan

Re: [PATCH v5 11/19] regulator: rohm-regulator: linear voltage support

2021-04-02 Thread Mark Brown
On Mon, Mar 29, 2021 at 03:58:03PM +0300, Matti Vaittinen wrote: > The helper for obtaining HW-state based DVS voltage levels currently only > works for regulators using linear-ranges. Extend support to regulators with > simple linear mappings and add also proper error path if pickable-ranges >

Re: [PATCH v5 12/19] regulator: rohm-regulator: Support SNVS HW state.

2021-04-02 Thread Mark Brown
On Mon, Mar 29, 2021 at 03:58:33PM +0300, Matti Vaittinen wrote: > The ROHM BD71815 supports setting voltage levels/regulator status > for HW-states "RUN", "SUSPEND", "LPSR" and "SNVS". Add DT parsing > helper also for SNVS state. Acked-by: Mark Brown signature.asc Description: PGP signature

[PATCH v2 30/30] staging: rtl8723bs: add spaces around operators

2021-04-02 Thread Fabio Aiuto
fix post-commit hook checkpatch issues: CHECK: spaces preferred around that '+' (ctx:VxV) 161: FILE: drivers/staging/rtl8723bs/core/rtw_ieee80211.c:648: + *wpa_len = in_ie[cnt+1]+2; ^ CHECK: spaces preferred around that '+'

[PATCH v2 29/30] staging: rtl8723bs: remove RT_TRACE logs in core/rtw_ieee80211.c

2021-04-02 Thread Fabio Aiuto
remove all RT_TRACE logs Signed-off-by: Fabio Aiuto --- .../staging/rtl8723bs/core/rtw_ieee80211.c| 90 --- 1 file changed, 15 insertions(+), 75 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_ieee80211.c b/drivers/staging/rtl8723bs/core/rtw_ieee80211.c index

[PATCH v2 28/30] staging: rtl8723bs: remove RT_TRACE logs in core/rtw_sta_mgt.c

2021-04-02 Thread Fabio Aiuto
remove all RT_TRACE logs Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/core/rtw_sta_mgt.c | 25 1 file changed, 25 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_sta_mgt.c b/drivers/staging/rtl8723bs/core/rtw_sta_mgt.c index

Re: [RESEND PATCH v4 0/3] Introduce the for_each_set_nbits macro

2021-04-02 Thread Andy Shevchenko
On Fri, Apr 2, 2021 at 7:36 PM Syed Nayyar Waris wrote: > > Hello Bartosz, > > Since this patchset primarily affects GPIO drivers, would you like > to pick it up through your GPIO tree? > > This patchset introduces a new generic version of for_each_set_nbits. > The previous version of

[PATCH v2 27/30] staging: rtl8723bs: remove all RT_TRACE logs in core/rtw_wlan_util.c

2021-04-02 Thread Fabio Aiuto
remove all RT_TRACE logs Signed-off-by: Fabio Aiuto --- .../staging/rtl8723bs/core/rtw_wlan_util.c| 24 --- 1 file changed, 4 insertions(+), 20 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_wlan_util.c b/drivers/staging/rtl8723bs/core/rtw_wlan_util.c index

[PATCH v2 26/30] staging: rtl8723bs: place constant on the right side of the test

2021-04-02 Thread Fabio Aiuto
fix posst-commit checkpatch issues: WARNING: Comparisons should place the constant on the right side of the test 40: FILE: drivers/staging/rtl8723bs/core/rtw_ioctl_set.c:71: + if (_SUCCESS != ret) WARNING: Comparisons should place the constant on the right side of the test

[PATCH v2 25/30] staging: rtl8723bs: remove RT_TRACE logs in core/rtw_ioctl_set.c

2021-04-02 Thread Fabio Aiuto
remove all RT_TRACE logs Signed-off-by: Fabio Aiuto --- .../staging/rtl8723bs/core/rtw_ioctl_set.c| 76 +-- 1 file changed, 4 insertions(+), 72 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_ioctl_set.c b/drivers/staging/rtl8723bs/core/rtw_ioctl_set.c index

[PATCH v2 24/30] staging: rtl8723bs: remove commented RT_TRACE call in core/rtw_ioctl_set.c

2021-04-02 Thread Fabio Aiuto
remove commented RT_TRACE call in core/rtw_ioctl_set.c Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/core/rtw_ioctl_set.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_ioctl_set.c b/drivers/staging/rtl8723bs/core/rtw_ioctl_set.c index

[PATCH v2 22/30] staging: rtl8723bs: remove unnecessary parentheses

2021-04-02 Thread Fabio Aiuto
fix post-commit checkpatch issue: CHECK: Unnecessary parentheses around 'psecuritypriv->bcheck_grpkey == false' 24: FILE: drivers/staging/rtl8723bs/core/rtw_recv.c:381: + if ((psecuritypriv-> bcheck_grpkey == false) && +

[PATCH v2 21/30] staging: rtl8723bs: split long line

2021-04-02 Thread Fabio Aiuto
fix post-commit hook checkpatch issue: WARNING: line length of 113 exceeds 100 columns 110: FILE: drivers/staging/rtl8723bs/core/rtw_recv.c:381: + if ((psecuritypriv->bcheck_grpkey == false) && (IS_MCAST(prxattrib->ra) == true)) Signed-off-by: Fabio Aiuto

[PATCH v2 23/30] staging: rtl8723bs: fix comparison in if condition

2021-04-02 Thread Fabio Aiuto
fix post-commit checkpatch issue: CHECK: Using comparison to false is error prone 27: FILE: drivers/staging/rtl8723bs/core/rtw_recv.c:381: + if (psecuritypriv-> bcheck_grpkey == false && Signed-off-by: Fabio Aiuto ---

[PATCH v2 20/30] staging: rtl8723bs: added spaces around operator

2021-04-02 Thread Fabio Aiuto
fix post-commit hook issue: CHECK: spaces preferred around that '+' (ctx:VxV) 60: FILE: drivers/staging/rtl8723bs/core/rtw_recv.c:359: + if (miccode[i] != *(pframemic+i)) ^ Signed-off-by: Fabio Aiuto ---

[PATCH v2 19/30] staging: rtl8723bs: remove RT_TRACE logs in core/rtw_recv.c

2021-04-02 Thread Fabio Aiuto
remove all RT_TRACE logs Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/core/rtw_recv.c | 134 +- 1 file changed, 6 insertions(+), 128 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_recv.c b/drivers/staging/rtl8723bs/core/rtw_recv.c index

[PATCH v2 18/30] staging: rtl8723bs: remove commented RT_TRACE calls in core/rtw_recv.c

2021-04-02 Thread Fabio Aiuto
remove commented RT_TRACE calls in core/rtw_recv.c Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/core/rtw_recv.c | 12 1 file changed, 12 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_recv.c b/drivers/staging/rtl8723bs/core/rtw_recv.c index

[PATCH v2 17/30] staging: rtl8723bs: remove RT_TRACE logs in core/rtw_mlme_ext.c

2021-04-02 Thread Fabio Aiuto
remove all RT_TRACE logs Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 39 +++ 1 file changed, 5 insertions(+), 34 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c index

<    1   2   3   4   5   6   7   8   9   >