Re: [RFC/PATCH] powerpc/smp: Add SD_SHARE_PKG_RESOURCES flag to MC sched-domain

2021-04-02 Thread Gautham R Shenoy
(Missed cc'ing Cc Peter in the original posting) On Fri, Apr 02, 2021 at 11:07:54AM +0530, Gautham R. Shenoy wrote: > From: "Gautham R. Shenoy" > > On POWER10 systems, the L2 cache is at the SMT4 small core level. The > following commits ensure that L2 cache gets correctly discovered and > the

[PATCH -next] driver: aoe: use DEFINE_SPINLOCK() for spinlock

2021-04-02 Thread Zucheng Zheng
spinlock can be initialized automatically with DEFINE_SPINLOCK() rather than explicitly calling spin_lock_init(). Reported-by: Hulk Robot Signed-off-by: Zucheng Zheng --- drivers/block/aoe/aoenet.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/block/aoe/aoenet.c

Re: [PATCH] power: reset: at91-reset: free resources on exit path

2021-04-02 Thread Nicolas Ferre
On 01/04/2021 at 16:42, Claudiu Beznea - M18063 wrote: +unmap: +    iounmap(reset->rstc_base); +    for (idx = 0; idx < ARRAY_SIZE(reset->ramc_base); idx++) +    iounmap(reset->ramc_base[idx]); But if we keep this loop, I have the feeling that some kind of "of_node_put()" is needed as well.

RE: [PATCH V4 05/18] iommu/ioasid: Redefine IOASID set and allocation APIs

2021-04-02 Thread Tian, Kevin
> From: Jason Gunthorpe > Sent: Friday, April 2, 2021 12:04 AM > > On Thu, Apr 01, 2021 at 02:08:17PM +, Liu, Yi L wrote: > > > DMA page faults are delivered to root-complex via page request message > and > > it is per-device according to PCIe spec. Page request handling flow is: > > > > 1)

Re: [PATCH] crypto: hisilicon/hpre - delete redundant log

2021-04-02 Thread Herbert Xu
On Sat, Mar 27, 2021 at 04:32:26PM +0800, Hui Tang wrote: > 'hpre_cfg_by_dsm' has checked and printed error path, so it is not > necessary at all. > > Signed-off-by: Hui Tang > --- > drivers/crypto/hisilicon/hpre/hpre_main.c | 5 + > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff

Re: [PATCH 2/4] KVM: x86: separate pending and injected exception

2021-04-02 Thread Paolo Bonzini
On 02/04/21 01:05, Sean Christopherson wrote: +struct kvm_queued_exception { + bool valid; + u8 nr; If we're refactoring all this code anyways, maybe change "nr" to something a bit more descriptive? E.g. vector. "nr" is part of the userspace structure, so consistency is an

Re: [PATCH 3/9] sched: Trivial core scheduling cookie management

2021-04-02 Thread Peter Zijlstra
On Thu, Apr 01, 2021 at 01:04:58PM -0700, Josh Don wrote: > > +/* > > + * sched_core_update_cookie - Common helper to update a task's core > > cookie. This > > + * updates the selected cookie field. > > + * @p: The task whose cookie should be updated. > > + * @cookie: The new cookie. > > + *

Re: [PATCH] crypto: hisilicon/hpre - rsa key should not be empty

2021-04-02 Thread Herbert Xu
On Fri, Mar 26, 2021 at 02:13:32PM +0800, Meng Yu wrote: > We should ensure key is not empty before we set key. > > Signed-off-by: Meng Yu > --- > drivers/crypto/hisilicon/hpre/hpre_crypto.c | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git

[PATCH v2] drbd: Fix a use after free in get_initial_state

2021-04-02 Thread Lv Yunlong
In get_initial_state, it calls notify_initial_state_done(skb,..) if cb->args[5]==1. I see that if genlmsg_put() failed in notify_initial_state_done(), the skb will be freed by nlmsg_free(skb). Then get_initial_state will goto out and the freed skb will be used by return value skb->len. My patch

Re: [PATCH 0/3] crypto: replace memset by memzero_explicit

2021-04-02 Thread Herbert Xu
On Fri, Mar 26, 2021 at 09:20:45AM +0800, Kai Ye wrote: > use memzero_explicit instead of memset to clear sensitive data, > such as buffer or key. Does this fix a real issue? If not then it's just unnecessary churn. Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/

[PATCH] tools: Fix a typo in kernel-chktaint

2021-04-02 Thread Masanari Iida
This patch fixes a spelling typo in kernel-chktaint Signed-off-by: Masanari Iida --- tools/debugging/kernel-chktaint | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/debugging/kernel-chktaint b/tools/debugging/kernel-chktaint index 607b2b280945..719f18b1edf0 100755 ---

[RFC PATCH 2/2] drivers: soc: qcom: Add SDPM clock monitor driver

2021-04-02 Thread Manaf Meethalavalappu Pallikunhi
Add SDPM clock monitor driver, which will register for clock rate change notification and write the clock rate into SDPM CSR register. Signed-off-by: Ram Chandrasekar Signed-off-by: Manaf Meethalavalappu Pallikunhi --- drivers/soc/qcom/Kconfig| 8 ++ drivers/soc/qcom/Makefile

[RFC PATCH 1/2] dt-bindings: soc: qcom: Add SDPM clock monitor driver documentation in yaml

2021-04-02 Thread Manaf Meethalavalappu Pallikunhi
Add yaml documentation for SDPM clock monitor driver which will register for clock rate change notification and writes the clock rate into SDPM CSR register. Signed-off-by: Ram Chandrasekar Signed-off-by: Manaf Meethalavalappu Pallikunhi --- .../devicetree/bindings/soc/qcom/qcom-sdpm.yaml|

[RFC PATCH 0/2] Add SDPM clock monitor driver

2021-04-02 Thread Manaf Meethalavalappu Pallikunhi
RDPM (Rail digital power meter) hardware for a shared rail will monitor for peak current management. It allocates one simple digital power monitor(SDPM) for each major consumer of that rail. Each SDPM estimates the power consumption of the consumer based on operating frequency for that consumer.

Re: [PATCH v2 1/2] mmc: core: Let sanitize timeout readable/writable via sysfs

2021-04-02 Thread Bean Huo
On Fri, 2021-04-02 at 00:48 +0200, Ulf Hansson wrote: > On Thu, 1 Apr 2021 at 15:29, Bean Huo wrote: > > > From: Bean Huo > > As the density increases, the 4-minute timeout value for > > sanitize is no longer feasible. At the same time, devices > > of different densities have different timeout

Re: [PATCH] crypto: hisilicon/qm - delete redundant code

2021-04-02 Thread Herbert Xu
On Fri, Mar 26, 2021 at 09:14:32AM +0800, Kai Ye wrote: > The memory not needed to clear that will be freed. and the memset is useless > after the dma is freed. I don't doubt that this memory probably doesn't need to be zeroed since all it contains is a bunch of pointers instead of actual data.

Re: [PATCH v2] firmware: qcom_scm: Only compile legacy calls on ARM

2021-04-02 Thread Stephen Boyd
Quoting Elliot Berman (2021-04-01 18:12:14) > > It might be a good idea to wrap these lines from qcom_scm_call with #if > IS_ENABLED(CONFIG_ARM), and the corresponding ones in qcom_scm_call_atomic: > >case SMC_CONVENTION_LEGACY: >return scm_legacy_call(dev, desc, res); > > If

[RFC/PATCH] powerpc/smp: Add SD_SHARE_PKG_RESOURCES flag to MC sched-domain

2021-04-02 Thread Gautham R. Shenoy
From: "Gautham R. Shenoy" On POWER10 systems, the L2 cache is at the SMT4 small core level. The following commits ensure that L2 cache gets correctly discovered and the Last-Level-Cache domain (LLC) is set to the SMT sched-domain. 790a166 powerpc/smp: Parse ibm,thread-groups with multiple

[PATCH v2 3/3] arm64: dts: meson: add initial device-tree for MeCool KIII Pro

2021-04-02 Thread Christian Hewitt
MeCool (Videostrong) KIII Pro is based on the Amlogic Q200 reference board with an S912 chip and the following specs: - 3GB DDR3 RAM - 16GB eMMC - 10/100/1000 Base-T Ethernet - BCM4335 Wireless (802.11 b/g/n/ac, BT 4.0) - DVB-C/T/T2/S/S2 (AVL6862TA demod + R912 tuner) - HDMI 2.0a video - S/PDIF

[PATCH v2 2/3] arm64: dts: meson: add initial device-tree for MeCool KII Pro

2021-04-02 Thread Christian Hewitt
MeCool (Videostrong) KII Pro is based on the Amlogic P230 reference board with an S905D chip and the following specs: - 2GB DDR3 RAM - 16GB eMMC - 10/100 Base-T Ethernet - BCM4335 Wireless (802.11 b/g/n/ac, BT 4.0) - DVB-C/T/T2/S/S2 (AVL6862TA demod + R848 tuner) - HDMI 2.0a video - S/PDIF

[PATCH v2 0/3] arm64: dts: meson: add support for MeCool KII-Pro/KIII-Pro

2021-04-02 Thread Christian Hewitt
This series adds support for the MeCool (Videostrong) KII Pro (GXL) and KIII Pro (GXM) Android STB devices. These are quite popular due to the embedded multi-standard tuner card (which is sadly not-yet supported in the kernel). Both devices closely follow the Amlogic reference designs with

[PATCH v2 1/3] dt-bindings: arm: amlogic: add MeCool KII/KIII Pro bindings

2021-04-02 Thread Christian Hewitt
Add the board bindings for the MeCool (Videostrong Technology Co., Ltd) KII-Pro (S905D) and KIII-Pro (S912) devices. Signed-off-by: Christian Hewitt Acked-by: Rob Herring --- Documentation/devicetree/bindings/arm/amlogic.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git

Re: [PATCH] qemu_fw_cfg: Make fw_cfg_rev_attr a proper kobj_attribute

2021-04-02 Thread Sedat Dilek
On Thu, Feb 25, 2021 at 10:25 PM Kees Cook wrote: > > On Thu, 11 Feb 2021 12:42:58 -0700, Nathan Chancellor wrote: > > fw_cfg_showrev() is called by an indirect call in kobj_attr_show(), > > which violates clang's CFI checking because fw_cfg_showrev()'s second > > parameter is 'struct attribute',

Re: [PATCH v3 0/2] mtd: spi-nor: Cleanup patches

2021-04-02 Thread Tudor Ambarus
On Mon, 22 Mar 2021 09:51:29 +0200, Tudor Ambarus wrote: > Various cleanup patches done while reviewing contributions. > > Tudor Ambarus (2): > mtd: spi-nor: Move Software Write Protection logic out of the core > mtd: spi-nor: swp: Improve code around spi_nor_check_lock_status_sr() > >

Re: [PATCH v5 0/3] mtd: spi-nor: OTP support

2021-04-02 Thread Tudor Ambarus
On Mon, 22 Mar 2021 00:51:37 +0100, Michael Walle wrote: > This patchset implements the MTD OTP functions to allow access to the SPI > OTP data. Specific support is added for Winbond flash chips. > > In the past there was already an attempt by Rahul Bedarkar to add this, but > there was no

Re: [PATCH v5 03/18] mm: add generic function_nocfi macro

2021-04-02 Thread Christoph Hellwig
Thanks, this looks much better than the earlier naming: Acked-by: Christoph Hellwig

Re: [PATCH v4 3/3] sysfs: Unconditionally use vmalloc for buffer

2021-04-02 Thread Christoph Hellwig
On Thu, Apr 01, 2021 at 03:13:20PM -0700, Kees Cook wrote: > The sysfs interface to seq_file continues to be rather fragile > (seq_get_buf() should not be used outside of seq_file), as seen with > some recent exploits[1]. Move the seq_file buffer to the vmap area > (while retaining the accounting

Re: [RFC] Convert sysv filesystem to use folios exclusively

2021-04-02 Thread Amir Goldstein
On Thu, Mar 25, 2021 at 5:43 AM Matthew Wilcox wrote: > > > I decided to see what a filesystem free from struct page would look > like. I chose sysv more-or-less at random; I wanted a relatively simple > filesystem, but I didn't want a toy. The advantage of sysv is that the > maintainer is

[PATCH V1 2/2] soc: qcom: aoss: Add debugfs entry

2021-04-02 Thread Deepak Kumar Singh
It can be useful to control the different power states of various parts of hardware for device testing. Add a debugfs node for qmp so messages can be sent to aoss for debugging and testing purposes. Signed-off-by: Chris Lew Signed-off-by: Deepak Kumar Singh --- drivers/soc/qcom/qcom_aoss.c |

[PATCH V1 1/2] soc: qcom: aoss: Expose send for generic usecase

2021-04-02 Thread Deepak Kumar Singh
Not all upcoming usecases will have an interface to allow the aoss driver to hook onto. Expose the send api and create a get function to enable drivers to send their own messages to aoss. Signed-off-by: Chris Lew Signed-off-by: Deepak Kumar Singh --- drivers/soc/qcom/qcom_aoss.c | 36

[PATCH V1 0/2] soc: qcom: aoss: Expose send for generic usecase

2021-04-02 Thread Deepak Kumar Singh
[Change from V0] Update qmp_get to parse qmp handle with binding qcom,qmp Deepak Kumar Singh (2): soc: qcom: aoss: Expose send for generic usecase soc: qcom: aoss: Add debugfs entry drivers/soc/qcom/qcom_aoss.c | 77 +++- 1 file changed, 76

[PATCH -next] PM: runtime: Replace inline function pm_runtime_callbacks_present()

2021-04-02 Thread YueHaibing
commit 9a7875461fd0 ("PM: runtime: Replace pm_runtime_callbacks_present()") forget to change the inline version. Fixes: 9a7875461fd0 ("PM: runtime: Replace pm_runtime_callbacks_present()") Signed-off-by: YueHaibing --- include/linux/pm_runtime.h | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH -next] ide: Remove unused inline function ide_dma_verbose()

2021-04-02 Thread YueHaibing
commit 3ab7efe8e2cb ("ide: DMA reporting and validity checking fixes (take 3)") left behind this, so can remove it. Signed-off-by: YueHaibing --- include/linux/ide.h | 1 - 1 file changed, 1 deletion(-) diff --git a/include/linux/ide.h b/include/linux/ide.h index 6bc6ba57b505..0242a66158fb

<    4   5   6   7   8   9