[PATCH 4.4 37/38] perf map: Tighten snprintf() string precision to pass gcc check on some 32-bit arches

2021-04-15 Thread Greg Kroah-Hartman
From: Arnaldo Carvalho de Melo commit 77d02bd00cea9f1a87afe58113fa75b983d6c23a upstream. Noticed on a debian:experimental mips and mipsel cross build build environment: perfbuilder@ec265a086e9b:~$ mips-linux-gnu-gcc --version | head -1 mips-linux-gnu-gcc (Debian 10.2.1-3) 10.2.1 20201224

[PATCH 4.4 28/38] net: ieee802154: fix nl802154 del llsec key

2021-04-15 Thread Greg Kroah-Hartman
From: Alexander Aring commit 37feaaf5ceb2245e474369312bb7b922ce7bce69 upstream. This patch fixes a nullpointer dereference if NL802154_ATTR_SEC_KEY is not set by the user. If this is the case nl802154 will return -EINVAL. Reported-by: syzbot+ac5c11d2959a8b3c4...@syzkaller.appspotmail.com

[PATCH 4.4 00/38] 4.4.267-rc1 review

2021-04-15 Thread Greg Kroah-Hartman
This is the start of the stable review cycle for the 4.4.267 release. There are 38 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made by Sat, 17 Apr 2021 14:44:01 +. Anything

[PATCH 4.4 09/38] ia64: fix user_stack_pointer() for ptrace()

2021-04-15 Thread Greg Kroah-Hartman
From: Sergei Trofimovich commit 7ad1e366167837daeb93d0bacb57dee820b0b898 upstream. ia64 has two stacks: - memory stack (or stack), pointed at by by r12 - register backing store (register stack), pointed at by ar.bsp/ar.bspstore with complications around dirty register frame on CPU.

Re: [PATCH v4 1/6] perf arm-spe: Remove unused enum value ARM_SPE_PER_CPU_MMAPS

2021-04-15 Thread James Clark
On 15/04/2021 17:41, Leo Yan wrote: > Hi James, > > On Thu, Apr 15, 2021 at 05:13:36PM +0300, James Clark wrote: >> On 12/04/2021 12:10, Leo Yan wrote: >>> The enum value 'ARM_SPE_PER_CPU_MMAPS' is never used so remove it. >> >> Hi Leo, >> >> I think this causes an error when attempting to

[PATCH 4.4 08/38] net: ipv6: check for validity before dereferencing cfg->fc_nlinfo.nlh

2021-04-15 Thread Greg Kroah-Hartman
From: Muhammad Usama Anjum commit 864db232dc7036aa2de19749c3d5be0143b24f8f upstream. nlh is being checked for validtity two times when it is dereferenced in this function. Check for validity again when updating the flags through nlh pointer to make the dereferencing safe. CC:

[PATCH 4.4 07/38] xen/evtchn: Change irq_info lock to raw_spinlock_t

2021-04-15 Thread Greg Kroah-Hartman
From: Luca Fancellu commit d120198bd5ff1d41808b6914e1eb89aff937415c upstream. Unmask operation must be called with interrupt disabled, on preempt_rt spin_lock_irqsave/spin_unlock_irqrestore don't disable/enable interrupts, so use raw_* implementation and change lock variable in struct irq_info

[PATCH 4.4 06/38] nfc: Avoid endless loops caused by repeated llcp_sock_connect()

2021-04-15 Thread Greg Kroah-Hartman
From: Xiaoming Ni commit 4b5db93e7f2afbdfe3b78e37879a85290187e6f1 upstream. When sock_wait_state() returns -EINPROGRESS, "sk->sk_state" is LLCP_CONNECTING. In this case, llcp_sock_connect() is repeatedly invoked, nfc_llcp_sock_link() will add sk to local->connecting_sockets twice.

[PATCH 4.4 05/38] nfc: fix memory leak in llcp_sock_connect()

2021-04-15 Thread Greg Kroah-Hartman
From: Xiaoming Ni commit 7574fcdbdcb335763b6b322f6928dc0fd5730451 upstream. In llcp_sock_connect(), use kmemdup to allocate memory for "llcp_sock->service_name". The memory is not released in the sock_unlink label of the subsequent failure branch. As a result, memory leakage occurs. fix

[PATCH 4.4 04/38] nfc: fix refcount leak in llcp_sock_connect()

2021-04-15 Thread Greg Kroah-Hartman
From: Xiaoming Ni commit 8a4cd82d62b5ec7e5482333a72b58a4eea4979f0 upstream. nfc_llcp_local_get() is invoked in llcp_sock_connect(), but nfc_llcp_local_put() is not invoked in subsequent failure branches. As a result, refcount leakage occurs. To fix it, add calling nfc_llcp_local_put(). fix

[PATCH 4.4 26/38] net: mac802154: Fix general protection fault

2021-04-15 Thread Greg Kroah-Hartman
From: Pavel Skripkin commit 1165affd484889d4986cf3b724318935a0b120d8 upstream. syzbot found general protection fault in crypto_destroy_tfm()[1]. It was caused by wrong clean up loop in llsec_key_alloc(). If one of the tfm array members is in IS_ERR() range it will cause general protection fault

[PATCH 4.4 03/38] nfc: fix refcount leak in llcp_sock_bind()

2021-04-15 Thread Greg Kroah-Hartman
From: Xiaoming Ni commit c33b1cc62ac05c1dbb1cdafe2eb66da01c76ca8d upstream. nfc_llcp_local_get() is invoked in llcp_sock_bind(), but nfc_llcp_local_put() is not invoked in subsequent failure branches. As a result, refcount leakage occurs. To fix it, add calling nfc_llcp_local_put(). fix

[PATCH 4.4 25/38] drivers: net: fix memory leak in peak_usb_create_dev

2021-04-15 Thread Greg Kroah-Hartman
From: Pavel Skripkin commit a0b96b4a62745397aee662670cfc2157bac03f55 upstream. syzbot reported memory leak in peak_usb. The problem was in case of failure after calling ->dev_init()[2] in peak_usb_create_dev()[1]. The data allocated int dev_init() wasn't freed, so simple ->dev_free() call fix

[PATCH 4.4 24/38] drivers: net: fix memory leak in atusb_probe

2021-04-15 Thread Greg Kroah-Hartman
From: Pavel Skripkin commit 6b9fbe16955152626557ec6f439f3407b7769941 upstream. syzbot reported memory leak in atusb_probe()[1]. The problem was in atusb_alloc_urbs(). Since urb is anchored, we need to release the reference to correctly free the urb backtrace: [] kmalloc

[PATCH 4.4 22/38] cfg80211: remove WARN_ON() in cfg80211_sme_connect

2021-04-15 Thread Greg Kroah-Hartman
From: Du Cheng commit 1b5ab825d9acc0f27d2f25c6252f3526832a9626 upstream. A WARN_ON(wdev->conn) would trigger in cfg80211_sme_connect(), if multiple send_msg(NL80211_CMD_CONNECT) system calls are made from the userland, which should be anticipated and handled by the wireless driver. Remove this

[PATCH 4.4 23/38] net: tun: set tun->dev->addr_len during TUNSETLINK processing

2021-04-15 Thread Greg Kroah-Hartman
From: Phillip Potter commit cca8ea3b05c972ffb5295367e6c544369b45fbdd upstream. When changing type with TUNSETLINK ioctl command, set tun->dev->addr_len to match the appropriate type, using new tun_get_addr_len utility function which returns appropriate address length for given type. Fixes a

[PATCH 4.4 21/38] clk: socfpga: fix iomem pointer cast on 64-bit

2021-04-15 Thread Greg Kroah-Hartman
From: Krzysztof Kozlowski commit 2867b9746cef78745c594894aece6f8ef826e0b4 upstream. Pointers should be cast with uintptr_t instead of integer. This fixes warning when compile testing on ARM64: drivers/clk/socfpga/clk-gate.c: In function ‘socfpga_clk_recalc_rate’:

[PATCH 4.4 20/38] RDMA/cxgb4: check for ipv6 address properly while destroying listener

2021-04-15 Thread Greg Kroah-Hartman
From: Potnuri Bharat Teja [ Upstream commit 603c4690b01aaffe3a6c3605a429f6dac39852ae ] ipv6 bit is wrongly set by the below which causes fatal adapter lookup engine errors for ipv4 connections while destroying a listener. Fix it to properly check the local address for ipv6. Fixes:

[PATCH 4.4 02/38] ALSA: aloop: Fix initialization of controls

2021-04-15 Thread Greg Kroah-Hartman
From: Jonas Holmberg commit 168632a495f49f33a18c2d502fc249d7610375e9 upstream. Add a control to the card before copying the id so that the numid field is initialized in the copy. Otherwise the numid field of active_id, format_id, rate_id and channels_id will be the same (0) and snd_ctl_notify()

[PATCH 4.4 19/38] s390/cpcmd: fix inline assembly register clobbering

2021-04-15 Thread Greg Kroah-Hartman
From: Alexander Gordeev [ Upstream commit 7a2f91441b2c1d81b77c1cd816a4659f4abc9cbe ] Register variables initialized using arithmetic. That leads to kasan instrumentaton code corrupting the registers contents. Follow GCC guidlines and use temporary variables for assigning init values to register

[PATCH 4.4 18/38] workqueue: Move the position of debug_work_activate() in __queue_work()

2021-04-15 Thread Greg Kroah-Hartman
From: Zqiang [ Upstream commit 0687c66b5f666b5ad433f4e94251590d9bc9d10e ] The debug_work_activate() is called on the premise that the work can be inserted, because if wq be in WQ_DRAINING status, insert work may be failed. Fixes: e41e704bc4f4 ("workqueue: improve destroy_workqueue()

[PATCH 4.4 16/38] net:tipc: Fix a double free in tipc_sk_mcast_rcv

2021-04-15 Thread Greg Kroah-Hartman
From: Lv Yunlong [ Upstream commit 6bf24dc0cc0cc43b29ba344b66d78590e687e046 ] In the if(skb_peek(arrvq) == skb) branch, it calls __skb_dequeue(arrvq) to get the skb by skb = skb_peek(arrvq). Then __skb_dequeue() unlinks the skb from arrvq and returns the skb which equals to skb_peek(arrvq).

[PATCH 4.4 17/38] clk: fix invalid usage of list cursor in unregister

2021-04-15 Thread Greg Kroah-Hartman
From: Lukasz Bartosik [ Upstream commit 7045465500e465b09f09d6e5bdc260a9f1aab97b ] Fix invalid usage of a list_for_each_entry cursor in clk_notifier_unregister(). When list is empty or if the list is completely traversed (without breaking from the loop on one of the entries) then the list

[PATCH 4.4 15/38] gianfar: Handle error code at MAC address change

2021-04-15 Thread Greg Kroah-Hartman
From: Claudiu Manoil [ Upstream commit bff5b62585123823842833ab20b1c0a7fa437f8c ] Handle return error code of eth_mac_addr(); Fixes: 3d23a05c75c7 ("gianfar: Enable changing mac addr when if up") Signed-off-by: Claudiu Manoil Signed-off-by: David S. Miller Signed-off-by: Sasha Levin ---

[PATCH 4.4 14/38] sch_red: fix off-by-one checks in red_check_params()

2021-04-15 Thread Greg Kroah-Hartman
From: Eric Dumazet [ Upstream commit 3a87571f0ffc51ba3bf3ecdb6032861d0154b164 ] This fixes following syzbot report: UBSAN: shift-out-of-bounds in ./include/net/red.h:237:23 shift exponent 32 is too large for 32-bit type 'unsigned int' CPU: 1 PID: 8418 Comm: syz-executor170 Not tainted

[PATCH 4.4 13/38] net: sched: sch_teql: fix null-pointer dereference

2021-04-15 Thread Greg Kroah-Hartman
From: Pavel Tikhomirov commit 1ffbc7ea91606e4abd10eb60de5367f1c86daf5e upstream. Reproduce: modprobe sch_teql tc qdisc add dev teql0 root teql0 This leads to (for instance in Centos 7 VM) OOPS: [ 532.366633] BUG: unable to handle kernel NULL pointer dereference at 00a8 [

Re: [PATCH v3 01/12] drm/bridge: Fix the stop condition of drm_bridge_chain_pre_enable()

2021-04-15 Thread Doug Anderson
Hi, On Wed, Apr 14, 2021 at 6:56 PM Laurent Pinchart wrote: > > Hi Doug, > > On Wed, Apr 14, 2021 at 06:19:13PM -0700, Doug Anderson wrote: > > On Sun, Apr 4, 2021 at 5:50 PM Laurent Pinchart wrote: > > > On Fri, Apr 02, 2021 at 03:28:35PM -0700, Douglas Anderson wrote: > > > > The

[PATCH 4.4 11/38] parisc: parisc-agp requires SBA IOMMU driver

2021-04-15 Thread Greg Kroah-Hartman
From: Helge Deller commit 9054284e8846b0105aad43a4e7174ca29fffbc44 upstream. Add a dependency to the SBA IOMMU driver to avoid: ERROR: modpost: "sba_list" [drivers/char/agp/parisc-agp.ko] undefined! Reported-by: kernel test robot Cc: sta...@vger.kernel.org Signed-off-by: Helge Deller

[PATCH 4.4 12/38] batman-adv: initialize "struct batadv_tvlv_tt_vlan_data"->reserved field

2021-04-15 Thread Greg Kroah-Hartman
From: Tetsuo Handa commit 08c27f3322fec11950b8f1384aa0f3b11d028528 upstream. KMSAN found uninitialized value at batadv_tt_prepare_tvlv_local_data() [1], for commit ced72933a5e8ab52 ("batman-adv: use CRC32C instead of CRC16 in TT code") inserted 'reserved' field into "struct batadv_tvlv_tt_data"

[PATCH 4.4 10/38] fs: direct-io: fix missing sdio->boundary

2021-04-15 Thread Greg Kroah-Hartman
From: Jack Qiu commit df41872b68601059dd4a84858952dcae58acd331 upstream. I encountered a hung task issue, but not a performance one. I run DIO on a device (need lba continuous, for example open channel ssd), maybe hungtask in below case: DIO:

[PATCH 4.4 01/38] iio: hid-sensor-prox: Fix scale not correct issue

2021-04-15 Thread Greg Kroah-Hartman
From: Ye Xiang commit d68c592e02f6f49a88e705f13dfc1883432cf300 upstream Currently, the proxy sensor scale is zero because it just return the exponent directly. To fix this issue, this patch use hid_sensor_format_scale to process the scale first then return the output. Fixes: 39a3a0138f61

Re: [PATCH v4 4/7] arm64: dts: renesas: r8a77970: Add csi40 port@0

2021-04-15 Thread Laurent Pinchart
Hi Jacopo, Thank you for the patch. On Thu, Apr 15, 2021 at 02:25:59PM +0200, Jacopo Mondi wrote: > Declare port@0 in the csi40 device node and leave it un-connected. > Each board .dts file will connect the port as it requires. > > Signed-off-by: Jacopo Mondi The port exists at the hardware

Re: [PATCH 1/2] x86/events/amd/iommu: Fix sysfs type mismatch

2021-04-15 Thread Nathan Chancellor
On Thu, Apr 15, 2021 at 08:53:35AM +0100, Christoph Hellwig wrote: > On Wed, Apr 14, 2021 at 05:11:11PM -0700, Nathan Chancellor wrote: > > dev_attr_show() calls _iommu_event_show() via an indirect call but > > _iommu_event_show()'s type does not currently match the type of the > > show() member

Re: [PATCH v4 4/6] perf arm-spe: Assign kernel time to synthesized event

2021-04-15 Thread James Clark
On 12/04/2021 12:10, Leo Yan wrote: > In current code, it assigns the arch timer counter to the synthesized > samples Arm SPE trace, thus the samples don't contain the kernel time > but only contain the raw counter value. > > To fix the issue, this patch converts the timer counter to kernel

[PATCH] iommu/fsl-pamu: Fix uninitialized variable warning

2021-04-15 Thread Joerg Roedel
From: Joerg Roedel The variable 'i' in the function update_liodn_stash() is not initialized and only used in a debug printk(). So it has no meaning at all, remove it. Reported-by: kernel test robot Signed-off-by: Joerg Roedel --- drivers/iommu/fsl_pamu_domain.c | 5 ++--- 1 file changed, 2

Re: [v2 1/2] dt-bindings: Add bindings for aspeed pwm-tach and pwm.

2021-04-15 Thread Rob Herring
On Wed, Apr 14, 2021 at 10:44 PM Billy Tsai wrote: > > Hi Rob, > > On 2021/4/15, 6:16 AM,Rob Herringwrote: > > On Wed, Apr 14, 2021 at 06:49:38PM +0800, Billy Tsai wrote: > >> This patch adds device bindings for aspeed pwm-tach device which is a > >> multi-function device include pwn

Re: [RFC PATCH] USB:XHCI:skip hub registration

2021-04-15 Thread Alan Stern
On Thu, Apr 15, 2021 at 08:22:38PM +0800, Longfang Liu wrote: > When the number of ports on the USB hub is 0, skip the registration > operation of the USB hub. > > The current Kunpeng930's XHCI hardware controller is defective. The number > of ports on its USB3.0 bus controller is 0, and the

Re: [PATCH v4 0/6] perf arm-spe: Enable timestamp

2021-04-15 Thread James Clark
Hi Leo, I was looking at testing this on N1SDP and I thought I would try the round trip with perf inject and then perf report but saw that perf inject with SPE always results in an error (unrelated to your change) -> ./perf report -i per-thread-spe-time.inject.data 0x1328

Re: [PATCH] sched,psi: fix the 'int' underflow for psi

2021-04-15 Thread Johannes Weiner
On Thu, Apr 15, 2021 at 07:59:41PM +0530, Charan Teja Reddy wrote: > psi_group_cpu->tasks, represented by the unsigned int, stores the number > of tasks that could be stalled on a psi resource(io/mem/cpu). > Decrementing these counters at zero leads to wrapping which further > leads to the

Re: [PATCH v4 1/7] dt-bindings: media: max9286: Re-indent example

2021-04-15 Thread Laurent Pinchart
Hi Jacopo, Thank you for the patch. On Thu, Apr 15, 2021 at 02:25:56PM +0200, Jacopo Mondi wrote: > The dt-bindings examples are usually indented with 4 spaces. > > The maxim,max9286 schema has the example indented with only > 2 spaces, re-indent it. > > Cosmetic change only. > >

Re: [PATCH v4 1/6] perf arm-spe: Remove unused enum value ARM_SPE_PER_CPU_MMAPS

2021-04-15 Thread Leo Yan
Hi James, On Thu, Apr 15, 2021 at 05:13:36PM +0300, James Clark wrote: > On 12/04/2021 12:10, Leo Yan wrote: > > The enum value 'ARM_SPE_PER_CPU_MMAPS' is never used so remove it. > > Hi Leo, > > I think this causes an error when attempting to open a newly recorded file > with an old version of

Re: [PATCH 2/2] iommu/amd: Remove performance counter pre-initialization test

2021-04-15 Thread David Coe
I think you've put your finger on it, Suravee! On 15/04/2021 10:28, Suthikulpanit, Suravee wrote: David, On 4/14/2021 10:33 PM, David Coe wrote: Hi Suravee! I've re-run your revert+update patch on Ubuntu's latest kernel 5.11.0-14 partly to check my mailer's 'mangling' hadn't also reached

[PATCH] ACPI: APEI: remove redundant assignment to variable rc

2021-04-15 Thread Colin King
From: Colin Ian King The variable rc is being assigned a value that is never read, the assignment is redundant and can be removed. Addresses-Coverity: ("Unused value") Signed-off-by: Colin Ian King --- drivers/acpi/apei/einj.c | 1 - 1 file changed, 1 deletion(-) diff --git

Re: [PATCH bpf-next 1/2] bpf: Remove bpf_jit_enable=2 debugging mode

2021-04-15 Thread Daniel Borkmann
On 4/15/21 11:32 AM, Jianlin Lv wrote: For debugging JITs, dumping the JITed image to kernel log is discouraged, "bpftool prog dump jited" is much better way to examine JITed dumps. This patch get rid of the code related to bpf_jit_enable=2 mode and update the proc handler of bpf_jit_enable,

Re: UBSAN: array-index-out-of-bounds in ehci_hub_control

2021-04-15 Thread Alan Stern
On Thu, Apr 15, 2021 at 04:10:45PM +0200, Dmitry Vyukov wrote: > Hi, > > I've got this report while booting v5.10.13 kernel, but upstream code > seems to be the same. > The access to port_status, the code is: > > struct ehci_regs { > u32 port_status[0]; /* up to N_PORTS */ > u32

[PATCH v1 1/1] libnvdimm: Don't use GUID APIs against raw buffer

2021-04-15 Thread Andy Shevchenko
Strictly speaking the comparison between guid_t and raw buffer is not correct. Return to plain memcmp() since the data structures haven't changed to use uuid_t / guid_t the current state of affairs is inconsistent. Either it should be changed altogether or left as is. Signed-off-by: Andy

Re: [PATCH 11/13] ARM: dts: stm32: fix LTDC port node on STM32 MCU ad MPU

2021-04-15 Thread Alexandre TORGUE
On 4/15/21 4:30 PM, Marek Vasut wrote: On 4/15/21 3:34 PM, Alexandre TORGUE wrote: Hi Marek Hello Alexandre, diff --git a/arch/arm/boot/dts/stm32mp157c-dk2.dts b/arch/arm/boot/dts/stm32mp157c-dk2.dts index 2bc92ef3aeb9..19ef475a48fc 100644 --- a/arch/arm/boot/dts/stm32mp157c-dk2.dts +++

Re: [PATCH] PM / EM: Inefficient OPPs detection

2021-04-15 Thread Vincent Donnefort
On Thu, Apr 15, 2021 at 01:16:35PM +, Quentin Perret wrote: > On Thursday 08 Apr 2021 at 18:10:29 (+0100), Vincent Donnefort wrote: > > --- a/kernel/sched/cpufreq_schedutil.c > > +++ b/kernel/sched/cpufreq_schedutil.c > > @@ -10,6 +10,7 @@ > > > > #include "sched.h" > > > > +#include > >

Re: [PATCH][next] net: stmmac: replace redundant comparison with true

2021-04-15 Thread Dan Carpenter
On Thu, Apr 15, 2021 at 09:37:57AM +0100, Colin King wrote: > From: Colin Ian King > > The comparison of the u32 variable queue with <= zero is always true > since an unsigned can never be negative. Replace the conditional > check with the boolean true to simplify the code. The while loop >

Re: [PATCH 2/2] drm/ttm: optimize the pool shrinker a bit v2

2021-04-15 Thread Huang Rui
On Thu, Apr 15, 2021 at 07:56:24PM +0800, Christian König wrote: > Switch back to using a spinlock again by moving the IOMMU unmap outside > of the locked region. > > v2: Add a comment explaining why we need sync_shrinkers(). > > Signed-off-by: Christian König Series look good for me as well.

Re: [tip: core/rcu] softirq: Don't try waking ksoftirqd before it has been spawned

2021-04-15 Thread Uladzislau Rezki
> > Another approach is to move the spawning of ksoftirqd earlier. This > still leaves a window of vulnerability, but the window is smaller, and > thus the probablity of something needing to happen there is smaller. > Uladzislau sent out a patch that did this some weeks back. > See below the

Re: [RFC PATCH 1/5] tracing/hwlat: Add a cpus file specific for hwlat_detector

2021-04-15 Thread Daniel Bristot de Oliveira
On 4/15/21 3:49 PM, Steven Rostedt wrote: > OK, for osnoise, I can see how it is useful. But as you said above, for > hwlat tracer, it's not as useful. I agree, it is not as useful. -- Daniel

Re: [PATCH 2/2] perf cs-etm: Set time on synthesised samples to preserve ordering

2021-04-15 Thread Leo Yan
Hi James, On Thu, Apr 15, 2021 at 03:51:46PM +0300, James Clark wrote: [...] > > For the orignal perf data file with "--per-thread" option, the decoder > > runs into the condition for "etm->timeless_decoding"; and it doesn't > > contain ETM timestamp. > > > > Afterwards, the injected perf data

Re: [PATCH 3/3] sched: Use cpu_dying() to fix balance_push vs hotplug-rollback

2021-04-15 Thread Valentin Schneider
On 15/04/21 10:59, Peter Zijlstra wrote: > Can't make sense of what I did.. I've removed that hunk. Patch now looks > like this. > Small nit below, but regardless feel free to apply to the whole lot: Reviewed-by: Valentin Schneider @VincentD, ISTR you had tested the initial version of this with

Re: [PATCH 1/5] mm/swapfile: add percpu_ref support for swap

2021-04-15 Thread Dennis Zhou
On Thu, Apr 15, 2021 at 01:24:31PM +0800, Huang, Ying wrote: > Dennis Zhou writes: > > > On Wed, Apr 14, 2021 at 01:44:58PM +0800, Huang, Ying wrote: > >> Dennis Zhou writes: > >> > >> > On Wed, Apr 14, 2021 at 11:59:03AM +0800, Huang, Ying wrote: > >> >> Dennis Zhou writes: > >> >> > >> >>

Re: [PATCH 11/13] ARM: dts: stm32: fix LTDC port node on STM32 MCU ad MPU

2021-04-15 Thread Marek Vasut
On 4/15/21 3:34 PM, Alexandre TORGUE wrote: Hi Marek Hello Alexandre, diff --git a/arch/arm/boot/dts/stm32mp157c-dk2.dts b/arch/arm/boot/dts/stm32mp157c-dk2.dts index 2bc92ef3aeb9..19ef475a48fc 100644 --- a/arch/arm/boot/dts/stm32mp157c-dk2.dts +++ b/arch/arm/boot/dts/stm32mp157c-dk2.dts @@

[PATCH] sched,psi: fix the 'int' underflow for psi

2021-04-15 Thread Charan Teja Reddy
psi_group_cpu->tasks, represented by the unsigned int, stores the number of tasks that could be stalled on a psi resource(io/mem/cpu). Decrementing these counters at zero leads to wrapping which further leads to the psi_group_cpu->state_mask is being set with the respective pressure state. This

[PATCH] locking/qrwlock: Fix ordering in queued_write_lock_slowpath

2021-04-15 Thread Ali Saidi
While this code is executed with the wait_lock held, a reader can acquire the lock without holding wait_lock. The writer side loops checking the value with the atomic_cond_read_acquire(), but only truly acquires the lock when the compare-and-exchange is completed successfully which isn’t ordered.

Re: [PATCH v1] ASoC: Intel: kbl_da7219_max98927: Fix kabylake_ssp_fixup function

2021-04-15 Thread Pierre-Louis Bossart
On 4/15/21 7:43 AM, Lukasz Majczak wrote: kabylake_ssp_fixup function uses snd_soc_dpcm to identify the codecs DAIs. The HW parameters are changed based on the codec DAI of the stream. The earlier approach to get snd_soc_dpcm was using container_of() macro on snd_pcm_hw_params. The

[PATCH 1/1] char: hpet: Remove unused local variable 'm' in hpet_interrupt()

2021-04-15 Thread Zhen Lei
Commit 273ef9509b79 ("drivers/char/hpet.c: fix periodic-emulation for delayed interrupt") removed the reference to local variable 'm', but forgot to remove the definition and assignment of it. Due to read_counter() indirectly calls "read barrier", the performance is slightly degraded. Since the

[PATCH v1 1/1] lightnvm: pblk: Import GUID before use

2021-04-15 Thread Andy Shevchenko
Strictly speaking the comparison between guid_t and raw buffer is not correct. Import GUID to variable of guid_t type and then compare. Signed-off-by: Andy Shevchenko --- drivers/lightnvm/pblk-recovery.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git

Re: [PATCH 1/1] perf map: Fix error return code in maps__clone()

2021-04-15 Thread Leizhen (ThunderTown)
On 2021/4/15 20:42, Arnaldo Carvalho de Melo wrote: > Em Thu, Apr 15, 2021 at 05:27:44PM +0800, Zhen Lei escreveu: >> Although 'err' has been initialized to -ENOMEM, but it will be reassigned >> by the "err = unwind__prepare_access(...)" statement in the for loop. So >> that, the value of 'err'

[PATCH V2] dt-bindings: mailbox: ti,message-manager: Convert to json schema

2021-04-15 Thread Nishanth Menon
Convert the ti,message-manager to yaml for better checks and documentation. Differences being mostly in the examples: - I've dropped the example usage of mailbox client, it is better done in tisci node definition - included header in example for buildable example NOTE: The following checkpatch

Re: [PATCH 2/3] habanalabs: support legacy and new pll indexes

2021-04-15 Thread Nathan Chancellor
On Sun, Mar 21, 2021 at 10:11:29PM +0200, Oded Gabbay wrote: > From: Ohad Sharabi > > In order to use minimum of hard coded values common to LKD and F/W > a dynamic method to work with PLLs is introduced in this patch. > Formerly asic specific PLL numbering is now common for all asics. > To be

Re: [PATCH 00/13] tty.h cleanups

2021-04-15 Thread Johan Hovold
On Thu, Apr 15, 2021 at 10:21:54AM +0200, Greg Kroah-Hartman wrote: > On Fri, Apr 09, 2021 at 09:32:45AM +0200, Johan Hovold wrote: > > On Thu, Apr 08, 2021 at 08:01:08PM +0200, Greg Kroah-Hartman wrote: > > > On Thu, Apr 08, 2021 at 04:25:22PM +0200, Johan Hovold wrote: > > > > On Thu, Apr 08,

Re: [PATCH RFC 01/22] asm-generic/hyperv: add HV_STATUS_ACCESS_DENIED definition

2021-04-15 Thread Wei Liu
On Tue, Apr 13, 2021 at 02:26:09PM +0200, Vitaly Kuznetsov wrote: > From TLFSv6.0b, this status means: "The caller did not possess sufficient > access rights to perform the requested operation." > > Signed-off-by: Vitaly Kuznetsov This can be applied to hyperv-next right away. Let me know what

Re: [PATCH v4 1/6] perf arm-spe: Remove unused enum value ARM_SPE_PER_CPU_MMAPS

2021-04-15 Thread James Clark
On 12/04/2021 12:10, Leo Yan wrote: > The enum value 'ARM_SPE_PER_CPU_MMAPS' is never used so remove it. Hi Leo, I think this causes an error when attempting to open a newly recorded file with an old version of perf. The value ARM_SPE_AUXTRACE_PRIV_MAX is used here: size_t min_sz =

Re: [PATCH] dt-bindings: mailbox: ti,message-manager: Convert to yaml

2021-04-15 Thread Nishanth Menon
On 19:32-20210415, Lokesh Vutla wrote: > [..snip..] > > > diff --git > > a/Documentation/devicetree/bindings/mailbox/ti,message-manager.yaml > > b/Documentation/devicetree/bindings/mailbox/ti,message-manager.yaml > > new file mode 100644 > > index

Re: [PATCH v2] iommu/vt-d: Force to flush iotlb before creating superpage

2021-04-15 Thread Joerg Roedel
On Thu, Apr 15, 2021 at 08:46:28AM +0800, Longpeng(Mike) wrote: > Fixes: 6491d4d02893 ("intel-iommu: Free old page tables before creating > superpage") > Cc: # v3.0+ > Link: > https://lore.kernel.org/linux-iommu/670baaf8-4ff8-4e84-4be3-030b95ab5...@huawei.com/ > Suggested-by: Lu Baolu >

Re: [PATCH] nfsd: remove unused function

2021-04-15 Thread Chuck Lever III
> On Apr 15, 2021, at 4:38 AM, Jiapeng Chong > wrote: > > Fix the following clang warning: > > fs/nfsd/nfs4state.c:6276:1: warning: unused function 'end_offset' > [-Wunused-function]. > > Reported-by: Abaci Robot > Signed-off-by: Jiapeng Chong Thanks for your patch. It's been added to

Re: [PATCH] PM / EM: Inefficient OPPs detection

2021-04-15 Thread Vincent Donnefort
On Thu, Apr 15, 2021 at 01:12:05PM +, Quentin Perret wrote: > Hi Vincent, > > On Thursday 08 Apr 2021 at 18:10:29 (+0100), Vincent Donnefort wrote: > > Some SoCs, such as the sd855 have OPPs within the same performance domain, > > whose cost is higher than others with a higher frequency. Even

Re: [PATCH] staging: media: atomisp: pci: Change line break to avoid an open parenthesis at the end of the line

2021-04-15 Thread Hans Verkuil
On 14/04/2021 22:56, Aline Santana Cordeiro wrote: > Change line break to avoid an open parenthesis at the end of the line. > It consequently removed spaces at the start of the subsequent line. > Both issues detected by checkpatch.pl. > > Signed-off-by: Aline Santana Cordeiro > --- >

Re: [PATCH v3 12/27] perf parse-events: Support no alias assigned event inside hybrid PMU

2021-04-15 Thread Jiri Olsa
On Thu, Apr 15, 2021 at 09:36:16PM +0800, Jin, Yao wrote: SNIP > > > + int n = 0; > > > + > > > + list_for_each(pos, list) > > > + n++; > > > + > > > + return n; > > > +} > > > + > > > +static int parse_events__with_hybrid_pmu(struct parse_events_state > > > *parse_state, > > > +

Re: [PATCH 09/11] mm/page_alloc: Avoid conflating IRQs disabled with zone->lock

2021-04-15 Thread Mel Gorman
On Thu, Apr 15, 2021 at 02:25:36PM +0200, Vlastimil Babka wrote: > > @@ -3294,6 +3295,7 @@ void free_unref_page_list(struct list_head *list) > > struct page *page, *next; > > unsigned long flags, pfn; > > int batch_count = 0; > > + int migratetype; > > > > /* Prepare pages for

UBSAN: array-index-out-of-bounds in ehci_hub_control

2021-04-15 Thread Dmitry Vyukov
Hi, I've got this report while booting v5.10.13 kernel, but upstream code seems to be the same. The access to port_status, the code is: struct ehci_regs { u32 port_status[0]; /* up to N_PORTS */ u32 reserved3[9];

Re: [PATCH v3] firmware_loader: fix use-after-free in firmware_fallback_sysfs

2021-04-15 Thread Shuah Khan
On 4/14/21 9:26 AM, Shuah Khan wrote: On 4/14/21 6:55 AM, Luis Chamberlain wrote: Shuah, a question for you toward the end here. On Wed, Apr 14, 2021 at 02:24:05PM +0530, Anirudh Rayabharam wrote: This use-after-free happens when a fw_priv object has been freed but hasn't been removed from

Re: [PATCH] dmaengine: idxd: Fix potential null dereference on pointer status

2021-04-15 Thread Dave Jiang
On 4/15/2021 4:06 AM, Colin King wrote: From: Colin Ian King There are calls to idxd_cmd_exec that pass a null status pointer however a recent commit has added an assignment to *status that can end up with a null pointer dereference. The function expects a null status pointer sometimes as

Re: [PATCH v4 2/2] kvm/arm64: Try stage2 block mapping for host device MMIO

2021-04-15 Thread Keqian Zhu
Hi Marc, On 2021/4/15 22:03, Keqian Zhu wrote: > The MMIO region of a device maybe huge (GB level), try to use > block mapping in stage2 to speedup both map and unmap. > > Compared to normal memory mapping, we should consider two more > points when try block mapping for MMIO region: > > 1. For

[PATCH RFC v3] media: em28xx: Fix race condition between open and init function

2021-04-15 Thread Igor Matheus Andrade Torrente
Fixes a race condition - for lack of a more precise term - between em28xx_v4l2_open and em28xx_v4l2_init, by detaching the v4l2_dev, media_pad and vdev structs from the em28xx_v4l2, and managing the lifetime of those objects more dynamicaly. The race happens when a thread[1] - containing the

[PATCH] arm: dts: aspeed: tiogapass: add hotplug controller

2021-04-15 Thread Paul Fertser
The ADM1278 IC is accessible on I2C bus and on both Wiwynn and Quanta Tioga Pass implementations a pair of parallel 0.5 mOhm resistors is used for current measurement. Signed-off-by: Paul Fertser --- arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dts | 5 + 1 file changed, 5 insertions(+)

Re: [PATCH] staging: media: tegra-video: Align line break to match with the open parenthesis in file vi.c

2021-04-15 Thread Hans Verkuil
On 14/04/2021 15:09, Aline Santana Cordeiro wrote: > Align line break to match with the open parenthesis. > Issue detected by checkpatch.pl. > > Signed-off-by: Aline Santana Cordeiro > --- > drivers/staging/media/tegra-video/vi.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > >

[PATCH v4 1/2] kvm/arm64: Remove the creation time's mapping of MMIO regions

2021-04-15 Thread Keqian Zhu
The MMIO regions may be unmapped for many reasons and can be remapped by stage2 fault path. Map MMIO regions at creation time becomes a minor optimization and makes these two mapping path hard to sync. Remove the mapping code while keep the useful sanity check. Signed-off-by: Keqian Zhu ---

[PATCH v4 2/2] kvm/arm64: Try stage2 block mapping for host device MMIO

2021-04-15 Thread Keqian Zhu
The MMIO region of a device maybe huge (GB level), try to use block mapping in stage2 to speedup both map and unmap. Compared to normal memory mapping, we should consider two more points when try block mapping for MMIO region: 1. For normal memory mapping, the PA(host physical address) and HVA

[PATCH v4 0/2] kvm/arm64: Try stage2 block mapping for host device MMIO

2021-04-15 Thread Keqian Zhu
Hi, We have two pathes to build stage2 mapping for MMIO regions. Create time's path and stage2 fault path. Patch#1 removes the creation time's mapping of MMIO regions Patch#2 tries stage2 block mapping for host device MMIO at fault path Changelog: v4: - use get_vma_page_shift() handle all

Re: [PATCH v3 1/2] binfmt_flat: allow not offsetting data start

2021-04-15 Thread Greg Ungerer
Hi Damien, On 15/4/21 4:15 pm, Damien Le Moal wrote: Commit 2217b9826246 ("binfmt_flat: revert "binfmt_flat: don't offset the data start"") restored offsetting the start of the data section by a number of words defined by MAX_SHARED_LIBS. As a result, since MAX_SHARED_LIBS is never 0, a gap

Re: [PATCH v2 4/5] staging: rtl8192e: rectified spelling mistake and replace memcmp with ether_oui_equal

2021-04-15 Thread Mitali Borkar
On Wed, Apr 14, 2021 at 10:55:25AM +0300, Dan Carpenter wrote: > On Wed, Apr 14, 2021 at 12:26:01PM +0530, Mitali Borkar wrote: > > Added a generic function of static inline bool in > > include/linux/etherdevice.h to replace memcmp with > > ether_oui_equal throughout the execution. > > Corrected

Re: [PATCH] dt-bindings: mailbox: ti,message-manager: Convert to yaml

2021-04-15 Thread Lokesh Vutla
[..snip..] > diff --git > a/Documentation/devicetree/bindings/mailbox/ti,message-manager.yaml > b/Documentation/devicetree/bindings/mailbox/ti,message-manager.yaml > new file mode 100644 > index ..4987e803ac37 > --- /dev/null > +++

Re: [PATCH v2 4/5] staging: rtl8192e: rectified spelling mistake and replace memcmp with ether_oui_equal

2021-04-15 Thread Greg KH
On Thu, Apr 15, 2021 at 07:12:47PM +0530, Mitali Borkar wrote: > On Wed, Apr 14, 2021 at 10:16:59AM +0200, Greg KH wrote: > > On Wed, Apr 14, 2021 at 12:26:01PM +0530, Mitali Borkar wrote: > > > Added a generic function of static inline bool in > > > include/linux/etherdevice.h to replace memcmp

Re: [PATCH] arm64: alternatives: Move length validation in alternative_{insn,endif}

2021-04-15 Thread Catalin Marinas
On Thu, Apr 15, 2021 at 06:25:57AM -0700, Nathan Chancellor wrote: > On Thu, Apr 15, 2021 at 10:17:43AM +0100, Catalin Marinas wrote: > > On Tue, Apr 13, 2021 at 05:08:04PM -0700, Nathan Chancellor wrote: > > > After commit 2decad92f473 ("arm64: mte: Ensure TIF_MTE_ASYNC_FAULT is > > > set

RE: linux-next: manual merge of the net-next tree with the net tree

2021-04-15 Thread Ong, Boon Leong
>Hi all, > >Today's linux-next merge of the net-next tree got a conflict in: > > drivers/net/ethernet/stmicro/stmmac/stmmac_main.c > >between commit: > > 00423969d806 ("Revert "net: stmmac: re-init rx buffers when mac resume >back"") > >from the net tree and commits: > > bba2556efad6 ("net:

[GIT PULL] gpio: fixes for v5.12-rc8

2021-04-15 Thread Bartosz Golaszewski
Linus, I waited until late with this non-urgent one hoping we'd get more fixes for this release cycle to go with it but nothing's coming up so please pull this single fix for an older problem with the sysfs interface. Bartosz The following changes since commit

[PATCH v1 1/1] ACPI: NFIT: Import GUID before use

2021-04-15 Thread Andy Shevchenko
Strictly speaking the comparison between guid_t and raw buffer is not correct. Import GUID to variable of guid_t type and then compare. Signed-off-by: Andy Shevchenko --- drivers/acpi/nfit/core.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/acpi/nfit/core.c

Re: backport patches to linux-5.4.y

2021-04-15 Thread Greg KH
On Tue, Apr 13, 2021 at 02:11:54PM +0200, Anders Roxell wrote: > Hi, > > Can these patches be backported to linux-5.4.y, I've tried to build > perf on arm and it failed without these patches. > fc8c0a992233 ("perf tools: Use %define api.pure full instead of %pure-parser") > 20befbb10803 ("perf

YES PLS

2021-04-15 Thread Nayef Abu Sakran
Did you received the mail i send to you?

Re: [PATCH] driver core: Fix locking bug in deferred_probe_timeout_work_func()

2021-04-15 Thread Greg Kroah-Hartman
On Mon, Apr 12, 2021 at 11:09:06AM -0700, Saravana Kannan wrote: > commit eed6e41813deb9ee622cd9242341f21430d7789f upstream. > > list_for_each_entry_safe() is only useful if we are deleting nodes in a > linked list within the loop. It doesn't protect against other threads > adding/deleting nodes

[GIT PULL] HID fixes

2021-04-15 Thread Jiri Kosina
Linus, please pull from git://git.kernel.org/pub/scm/linux/kernel/git/hid/hid.git for-linus to receive HID fixes. I wanted to send them earlier than for the last -rc, but then unfortunately many things interfered. The changes are all device/driver specific fixes. = - EV_KEY and EV_ABS

Re: [RFC PATCH 2/5] tracing/hwlat: Implement the mode config option

2021-04-15 Thread Steven Rostedt
On Thu, 15 Apr 2021 15:16:04 +0200 Daniel Bristot de Oliveira wrote: > That was my initial intention with the NONE mode, but I feared breaking > something by removing the "migrate_disable" logic. If you do not think it is > a problem, I will remove the migrate disable and just change the mode.

Re: [RFC PATCH 1/5] tracing/hwlat: Add a cpus file specific for hwlat_detector

2021-04-15 Thread Steven Rostedt
On Thu, 15 Apr 2021 15:09:50 +0200 Daniel Bristot de Oliveira wrote: > But for the osnoise tracer the cpus file is really useful. For instance, on a > system with the CPU 7 isolated: > > - %< - > # echo 7 > osnoise/cpus > # echo target_cpu == 7 > events/sched/sched_wakeup/filter >

Re: [PATCH V2 3/3] vDPA/ifcvf: get_config_size should return dev specific config size

2021-04-15 Thread Stefano Garzarella
On Thu, Apr 15, 2021 at 05:53:36PM +0800, Zhu Lingshan wrote: get_config_size() should return the size based on the decected device type. Signed-off-by: Zhu Lingshan --- drivers/vdpa/ifcvf/ifcvf_main.c | 18 +- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git

Re: [PATCH 1/2] iommu/mediatek-v1: Avoid build fail when build as module

2021-04-15 Thread Joerg Roedel
On Mon, Apr 12, 2021 at 02:48:42PM +0800, Yong Wu wrote: > When this driver build as module, It build fail like: > > ERROR: modpost: "of_phandle_iterator_args" > [drivers/iommu/mtk_iommu_v1.ko] undefined! > > This patch remove this interface to avoid this build fail. > > Reported-by: Valdis

<    5   6   7   8   9   10   11   12   13   14   >