Re: [PATCH v2 03/12] cxl/core: Refactor a cxl_lock_class() out of cxl_nested_lock()

2022-04-13 Thread Dan Williams
On Wed, Apr 13, 2022 at 2:40 AM Peter Zijlstra wrote: > > > *Completely* untested (I wouldn't know where to begin and probably odn't > have the hardware anyway), and known incomplete. > > What's wrong with something like this then? > I'll give it a shot, I think it solves all the cringeworthy asp

Re: [PATCH v2 02/12] device-core: Add dev->lock_class to enable device_lock() lockdep validation

2022-04-13 Thread Dan Williams
On Wed, Apr 13, 2022 at 1:43 AM Peter Zijlstra wrote: > > On Tue, Apr 12, 2022 at 11:01:38PM -0700, Dan Williams wrote: > > The device_lock() is hidden from lockdep by default because, for > > example, a device subsystem may do something like: > > > > --- > > device_add(dev1); > > ...in driver cor

Re: [PATCH v12 6/7] xfs: Implement ->notify_failure() for XFS

2022-04-13 Thread Christoph Hellwig
On Wed, Apr 13, 2022 at 10:09:40AM -0700, Dan Williams wrote: > Yes, sounds like we're on the same page. I had mistakenly interpreted > "Hence these notifications need to be delayed until after the > filesystem is mounted" as something the producer would need to handle, > but yes, consumer is free

Re: [PATCH v12 6/7] xfs: Implement ->notify_failure() for XFS

2022-04-13 Thread Dan Williams
On Tue, Apr 12, 2022 at 11:10 PM Dave Chinner wrote: > > On Tue, Apr 12, 2022 at 07:06:40PM -0700, Dan Williams wrote: > > On Tue, Apr 12, 2022 at 5:04 PM Dave Chinner wrote: > > > On Mon, Apr 11, 2022 at 12:09:03AM +0800, Shiyang Ruan wrote: > > > > Introduce xfs_notify_failure.c to handle failu

Re: [PATCH v2 00/12] device-core: Enable device_lock() lockdep validation

2022-04-13 Thread Waiman Long
On 4/13/22 02:01, Dan Williams wrote: Changes since v1 [1]: - Improve the clarity of the cover letter and changelogs of the major patches (Patch2 and Patch12) (Pierre, Kevin, and Dave) - Fix device_lock_interruptible() false negative deadlock detection (Kevin) - Fix off-by-one error in the

Re: [PATCH v2 03/12] cxl/core: Refactor a cxl_lock_class() out of cxl_nested_lock()

2022-04-13 Thread Peter Zijlstra
*Completely* untested (I wouldn't know where to begin and probably odn't have the hardware anyway), and known incomplete. What's wrong with something like this then? --- drivers/cxl/core/pmem.c | 8 + drivers/cxl/core/port.c | 58 +--- drivers/cxl/cxl.h

Re: [PATCH v2 02/12] device-core: Add dev->lock_class to enable device_lock() lockdep validation

2022-04-13 Thread Peter Zijlstra
On Tue, Apr 12, 2022 at 11:01:38PM -0700, Dan Williams wrote: > The device_lock() is hidden from lockdep by default because, for > example, a device subsystem may do something like: > > --- > device_add(dev1); > ...in driver core... > device_lock(dev1); > bus->probe(dev1); /* where bus->probe() ca