Re: [PATCH] mm: fix missing wake-up event for FSDAX pages

2022-07-21 Thread Dan Williams
Jason Gunthorpe wrote: > On Mon, Jul 11, 2022 at 07:39:17PM -0700, Dan Williams wrote: > > Muchun Song wrote: > > > On Mon, Jul 04, 2022 at 11:38:16AM +0100, Matthew Wilcox wrote: > > > > On Mon, Jul 04, 2022 at 03:40:54PM +0800, Muchun Song wrote: > > > > > FSDAX page refcounts are 1-based,

Re: [PATCH] fs: Call kmap_local_page() in copy_string_kernel()

2022-07-21 Thread Ira Weiny
On Sun, Jul 10, 2022 at 12:01:36PM +0200, Fabio M. De Francesco wrote: > The use of kmap_atomic() is being deprecated in favor of kmap_local_page(). > > With kmap_local_page(), the mappings are per thread, CPU local, not > globally visible and can take page faults. Furthermore, the mappings can

Re: [PATCH] mm: fix missing wake-up event for FSDAX pages

2022-07-21 Thread Jason Gunthorpe
On Mon, Jul 11, 2022 at 07:39:17PM -0700, Dan Williams wrote: > Muchun Song wrote: > > On Mon, Jul 04, 2022 at 11:38:16AM +0100, Matthew Wilcox wrote: > > > On Mon, Jul 04, 2022 at 03:40:54PM +0800, Muchun Song wrote: > > > > FSDAX page refcounts are 1-based, rather than 0-based: if refcount is >

Re: [PATCH] xfs: fail dax mount if reflink is enabled on a partition

2022-07-21 Thread Darrick J. Wong
On Thu, Jul 21, 2022 at 02:06:10PM +, ruansy.f...@fujitsu.com wrote: > 在 2022/7/1 8:31, Darrick J. Wong 写道: > > On Thu, Jun 09, 2022 at 10:34:35PM +0800, Shiyang Ruan wrote: > >> Failure notification is not supported on partitions. So, when we mount > >> a reflink enabled xfs on a partition

Re: [PATCH] xfs: fail dax mount if reflink is enabled on a partition

2022-07-21 Thread ruansy.f...@fujitsu.com
在 2022/7/1 8:31, Darrick J. Wong 写道: > On Thu, Jun 09, 2022 at 10:34:35PM +0800, Shiyang Ruan wrote: >> Failure notification is not supported on partitions. So, when we mount >> a reflink enabled xfs on a partition with dax option, let it fail with >> -EINVAL code. >> >> Signed-off-by: Shiyang

Re: [PATCH] xfs: fail dax mount if reflink is enabled on a partition

2022-07-21 Thread ruansy.f...@fujitsu.com
Hi Andrew, I am not sure if you had seen this. So make a ping. 在 2022/7/1 13:14, Shiyang Ruan 写道: > > > 在 2022/7/1 8:31, Darrick J. Wong 写道: >> On Thu, Jun 09, 2022 at 10:34:35PM +0800, Shiyang Ruan wrote: >>> Failure notification is not supported on partitions.  So, when we mount >>> a