Re: [PATCH v8 0/3] mm, pmem, xfs: Introduce MF_MEM_REMOVE for unbind

2022-09-14 Thread Shiyang Ruan
在 2022/9/15 2:15, Darrick J. Wong 写道: On Wed, Sep 14, 2022 at 11:09:23AM -0700, Darrick J. Wong wrote: On Wed, Sep 07, 2022 at 05:46:00PM +0800, Shiyang Ruan wrote: ping 在 2022/9/2 18:35, Shiyang Ruan 写道: Changes since v7: 1. Add P1 to fix calculation mistake 2. Add P2 to move

Re: [PATCH 3/3] mm, pmem, xfs: Introduce MF_MEM_REMOVE for unbind

2022-09-14 Thread Shiyang Ruan
在 2022/9/15 2:15, Darrick J. Wong 写道: On Fri, Sep 02, 2022 at 10:36:01AM +, Shiyang Ruan wrote: This patch is inspired by Dan's "mm, dax, pmem: Introduce dev_pagemap_failure()"[1]. With the help of dax_holder and ->notify_failure() mechanism, the pmem driver is able to ask filesystem

Re: [PATCH 2/3] fs: move drop_pagecache_sb() for others to use

2022-09-14 Thread Darrick J. Wong
On Fri, Sep 02, 2022 at 10:36:00AM +, Shiyang Ruan wrote: > xfs_notify_failure requires a method to invalidate all mappings. > drop_pagecache_sb() can do this but it is a static function and only > build with CONFIG_SYSCTL. Now, move it to super.c and make it available > for others. > >

Re: [PATCH v8 0/3] mm, pmem, xfs: Introduce MF_MEM_REMOVE for unbind

2022-09-14 Thread Darrick J. Wong
On Wed, Sep 14, 2022 at 11:09:23AM -0700, Darrick J. Wong wrote: > On Wed, Sep 07, 2022 at 05:46:00PM +0800, Shiyang Ruan wrote: > > ping > > > > 在 2022/9/2 18:35, Shiyang Ruan 写道: > > > Changes since v7: > > >1. Add P1 to fix calculation mistake > > >2. Add P2 to move drop_pagecache_sb()

Re: [PATCH 3/3] mm, pmem, xfs: Introduce MF_MEM_REMOVE for unbind

2022-09-14 Thread Darrick J. Wong
On Fri, Sep 02, 2022 at 10:36:01AM +, Shiyang Ruan wrote: > This patch is inspired by Dan's "mm, dax, pmem: Introduce > dev_pagemap_failure()"[1]. With the help of dax_holder and > ->notify_failure() mechanism, the pmem driver is able to ask filesystem > (or mapped device) on it to unmap all

Re: [PATCH 1/3] xfs: fix the calculation of length and end

2022-09-14 Thread Darrick J. Wong
On Fri, Sep 02, 2022 at 10:35:59AM +, Shiyang Ruan wrote: > The end should be start + length - 1. Also fix the calculation of the > length when seeking for intersection of notify range and device. > > Signed-off-by: Shiyang Ruan Looks correct to me, Reviewed-by: Darrick J. Wong --D >

Re: [PATCH v8 0/3] mm, pmem, xfs: Introduce MF_MEM_REMOVE for unbind

2022-09-14 Thread Darrick J. Wong
On Wed, Sep 07, 2022 at 05:46:00PM +0800, Shiyang Ruan wrote: > ping > > 在 2022/9/2 18:35, Shiyang Ruan 写道: > > Changes since v7: > >1. Add P1 to fix calculation mistake > >2. Add P2 to move drop_pagecache_sb() to super.c for xfs to use > >3. P3: Add invalidate all mappings after

Re: [PATCH] xfs: fail dax mount if reflink is enabled on a partition

2022-09-14 Thread Darrick J. Wong
On Wed, Sep 14, 2022 at 08:34:26AM -0400, Brian Foster wrote: > On Wed, Sep 14, 2022 at 05:38:02PM +0800, Yang, Xiao/杨 晓 wrote: > > On 2022/9/14 14:44, Yang, Xiao/杨 晓 wrote: > > > On 2022/9/9 21:01, Brian Foster wrote: > > > > Yes.. I don't recall all the internals of the tools and test, but IIRC

Re: [PATCH v2] libnvdimm/region: Allow setting align attribute on regions without mappings

2022-09-14 Thread Tyler Hicks
On 2022-08-30 00:45:05, Tyler Hicks wrote: > The alignment constraint for namespace creation in a region was > increased, from 2M to 16M, for non-PowerPC architectures in v5.7 with > commit 2522afb86a8c ("libnvdimm/region: Introduce an 'align' > attribute"). The thought behind the change was that

Re: [PATCH] xfs: fail dax mount if reflink is enabled on a partition

2022-09-14 Thread Brian Foster
On Wed, Sep 14, 2022 at 05:38:02PM +0800, Yang, Xiao/杨 晓 wrote: > On 2022/9/14 14:44, Yang, Xiao/杨 晓 wrote: > > On 2022/9/9 21:01, Brian Foster wrote: > > > Yes.. I don't recall all the internals of the tools and test, but IIRC > > > it relied on discard to perform zeroing between checkpoints or

Re: [PATCH] xfs: fail dax mount if reflink is enabled on a partition

2022-09-14 Thread Yang , Xiao/杨 晓
On 2022/9/14 14:44, Yang, Xiao/杨 晓 wrote: On 2022/9/9 21:01, Brian Foster wrote: Yes.. I don't recall all the internals of the tools and test, but IIRC it relied on discard to perform zeroing between checkpoints or some such and avoid spurious failures. The purpose of running on dm-thin was

Re: [PATCH] xfs: fail dax mount if reflink is enabled on a partition

2022-09-14 Thread Yang , Xiao/杨 晓
On 2022/9/9 21:01, Brian Foster wrote: Yes.. I don't recall all the internals of the tools and test, but IIRC it relied on discard to perform zeroing between checkpoints or some such and avoid spurious failures. The purpose of running on dm-thin was merely to provide reliable discard zeroing

[PATCH] nvdimm: make __nvdimm_security_overwrite_query static

2022-09-14 Thread Jiapeng Chong
This symbol is not used outside of security.c, so marks it static. drivers/nvdimm/security.c:411:6: warning: no previous prototype for function '__nvdimm_security_overwrite_query'. Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=2148 Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong