Re: [PATCH 0/2] fsdax,xfs: fix warning messages

2022-11-29 Thread Dan Williams
Darrick J. Wong wrote: > On Tue, Nov 29, 2022 at 07:59:14PM -0800, Dan Williams wrote: > > [ add Andrew ] > > > > Shiyang Ruan wrote: > > > Many testcases failed in dax+reflink mode with warning message in dmesg. > > > This also effects dax+noreflink mode if we run the test after a > > >

Re: [PATCH 0/2] fsdax,xfs: fix warning messages

2022-11-29 Thread Darrick J. Wong
On Tue, Nov 29, 2022 at 07:59:14PM -0800, Dan Williams wrote: > [ add Andrew ] > > Shiyang Ruan wrote: > > Many testcases failed in dax+reflink mode with warning message in dmesg. > > This also effects dax+noreflink mode if we run the test after a > > dax+reflink test. So, the most urgent thing

RE: [PATCH 1/2] fsdax,xfs: fix warning messages at dax_[dis]associate_entry()

2022-11-29 Thread Dan Williams
Shiyang Ruan wrote: > This patch fixes the warning message reported in dax_associate_entry() > and dax_disassociate_entry(). Can you include the xfstest test number and a snippet of the warning message. > 1. reset page->mapping and ->index when refcount counting down to 0. > 2. set

Re: [PATCH 1/2] fsdax,xfs: fix warning messages at dax_[dis]associate_entry()

2022-11-29 Thread Darrick J. Wong
On Thu, Nov 24, 2022 at 02:54:53PM +, Shiyang Ruan wrote: > This patch fixes the warning message reported in dax_associate_entry() > and dax_disassociate_entry(). Hmm, that's quite a bit to put in a single patch, but I'll try to get through this... > 1. reset page->mapping and ->index when

RE: [PATCH 0/2] fsdax,xfs: fix warning messages

2022-11-29 Thread Dan Williams
[ add Andrew ] Shiyang Ruan wrote: > Many testcases failed in dax+reflink mode with warning message in dmesg. > This also effects dax+noreflink mode if we run the test after a > dax+reflink test. So, the most urgent thing is solving the warning > messages. > > Patch 1 fixes some mistakes and

Re: [PATCH 2/2] fsdax,xfs: port unshare to fsdax

2022-11-29 Thread Darrick J. Wong
On Thu, Nov 24, 2022 at 02:54:54PM +, Shiyang Ruan wrote: > Implement unshare in fsdax mode: copy data from srcmap to iomap. > > Signed-off-by: Shiyang Ruan Heh, I had a version nearly like this in my tree. Makes reviewing easier: Reviewed-by: Darrick J. Wong --D > --- > fs/dax.c