Re: [PATCH v5 3/4] arm64: dts: qcom: Add SM7125 device tree

2023-10-20 Thread Rob Herring
On Thu, Aug 24, 2023 at 4:17 AM David Wronek wrote: > > The Snapdragon 720G (sm7125) is software-wise very similar to the > Snapdragon 7c with minor differences in clock speeds and as added here, > it uses the Kryo 465 instead of Kryo 468. > > Signed-off-by: David Wronek > Reviewed-by: Konrad

Re: [PATCH v2] bus: mhi: host: Add tracing support

2023-10-20 Thread Steven Rostedt
On Fri, 20 Oct 2023 09:03:59 -0600 Jeffrey Hugo wrote: > > diff --git a/drivers/bus/mhi/host/init.c b/drivers/bus/mhi/host/init.c > > index f78aefd2d7a3..3afa90a204fd 100644 > > --- a/drivers/bus/mhi/host/init.c > > +++ b/drivers/bus/mhi/host/init.c > > @@ -20,6 +20,9 @@ > > #include > >

Re: [PATCH v2] bus: mhi: host: Add tracing support

2023-10-20 Thread Jeffrey Hugo
On 10/13/2023 3:52 AM, Krishna chaitanya chundru wrote: This change adds ftrace support for following functions which helps in debugging the issues when there is Channel state & MHI state change and also when we receive data and control events: 1. mhi_intvec_threaded_handler 2.

Re: [PATCH v6 0/2] Return EADDRNOTAVAIL when func matches several symbols during kprobe creation

2023-10-20 Thread Francis Laniel
Hi! Le vendredi 20 octobre 2023, 15:12:39 EEST Masami Hiramatsu a écrit : > Hi, > > Thanks for update the series. The series looks good to me. > Let me pick those in probes/fixes. Thank you for picking it and all the good advices during the development process! > Thank you! Best regards. >

[PATCH] tracing: Fix a NULL vs IS_ERR() bug in event_subsystem_dir()

2023-10-20 Thread Dan Carpenter
The eventfs_create_dir() function returns error pointers, it never returns NULL. Update the check to reflect that. Fixes: 5790b1fb3d67 ("eventfs: Remove eventfs_file and just use eventfs_inode") Signed-off-by: Dan Carpenter --- kernel/trace/trace_events.c | 2 +- 1 file changed, 1

[bug report] eventfs: Remove eventfs_file and just use eventfs_inode

2023-10-20 Thread Dan Carpenter
Hello Steven Rostedt (Google), The patch 5790b1fb3d67: "eventfs: Remove eventfs_file and just use eventfs_inode" from Oct 4, 2023 (linux-next), leads to the following Smatch static checker warning: fs/tracefs/event_inode.c:782 eventfs_create_events_dir() error: potential null

Re: [PATCH v6 0/2] Return EADDRNOTAVAIL when func matches several symbols during kprobe creation

2023-10-20 Thread Google
Hi, Thanks for update the series. The series looks good to me. Let me pick those in probes/fixes. Thank you! On Fri, 20 Oct 2023 13:42:48 +0300 Francis Laniel wrote: > Hi. > > > In the kernel source code, it exists different functions which share the same > name but which have, of course,

Re: [PATCH 4/4] arm64: dts: qcom: qcm6490-fairphone-fp5: Add PM7325 thermals

2023-10-20 Thread Luca Weiss
On Wed Oct 18, 2023 at 10:28 PM CEST, Konrad Dybcio wrote: > > > On 10/14/23 19:52, Luca Weiss wrote: > > On Samstag, 14. Oktober 2023 01:13:29 CEST Konrad Dybcio wrote: > >> On 13.10.2023 10:09, Luca Weiss wrote: > >>> Configure the thermals for the QUIET_THERM, CAM_FLASH_THERM, MSM_THERM > >>>

[PATCH v6 1/2] tracing/kprobes: Return EADDRNOTAVAIL when func matches several symbols

2023-10-20 Thread Francis Laniel
When a kprobe is attached to a function that's name is not unique (is static and shares the name with other functions in the kernel), the kprobe is attached to the first function it finds. This is a bug as the function that it is attaching to is not necessarily the one that the user wants to

[PATCH v6 0/2] Return EADDRNOTAVAIL when func matches several symbols during kprobe creation

2023-10-20 Thread Francis Laniel
Hi. In the kernel source code, it exists different functions which share the same name but which have, of course, different addresses as they can be defined in different modules: # Kernel was compiled with CONFIG_NTFS_FS and CONFIG_NTFS3_FS as built-in. root@vm-amd64:~# grep ntfs_file_write_iter

Re: [PATCH v5 0/2] Return EADDRNOTAVAIL when func matches several symbols during kprobe creation

2023-10-20 Thread Francis Laniel
Hi! Le jeudi 19 octobre 2023, 18:07:08 EEST Masami Hiramatsu a écrit : > On Thu, 19 Oct 2023 09:51:04 -0400 > > Steven Rostedt wrote: > > On Thu, 19 Oct 2023 21:18:43 +0900 > > > > Masami Hiramatsu (Google) wrote: > > > > So why is this adding stable? (and as Greg's form letter states, > > >

Re: [PATCH v5 0/2] Return EADDRNOTAVAIL when func matches several symbols during kprobe creation

2023-10-20 Thread Francis Laniel
Hi! Le jeudi 19 octobre 2023, 16:51:04 EEST Steven Rostedt a écrit : > On Thu, 19 Oct 2023 21:18:43 +0900 > > Masami Hiramatsu (Google) wrote: > > > So why is this adding stable? (and as Greg's form letter states, that's > > > not > > > how you do that) > > > > > > I don't see this as a fix

[PATCH v2 2/2] usb: typec: add support for PTN36502 redriver

2023-10-20 Thread Luca Weiss
Add a driver for the NXP PTN36502 Type-C USB 3.1 Gen 1 and DisplayPort v1.2 combo redriver. Reviewed-by: Heikki Krogerus Signed-off-by: Luca Weiss --- drivers/usb/typec/mux/Kconfig| 10 + drivers/usb/typec/mux/Makefile | 1 + drivers/usb/typec/mux/ptn36502.c | 444

[PATCH v2 0/2] Add driver for NXP PTN36502 Type-C redriver

2023-10-20 Thread Luca Weiss
The NXP PTN36502 is used in the Fairphone 5 smartphone, add a driver for it so we can soon enable DisplayPort over USB-C on this phone. Signed-off-by: Luca Weiss --- Changes in v2: - Use FIELD_PREP+GENMASK for register values - Move FIELD_GET for chip revision from macro to code (to align with

[PATCH v2 1/2] dt-bindings: usb: add NXP PTN36502 Type-C redriver bindings

2023-10-20 Thread Luca Weiss
Document bindings for this Type-C USB 3.1 Gen 1 and DisplayPort v1.2 combo redriver. The PTN36502 can also run in GPIO mode where it is configured differently, without any I2C connection, but this is not supported yet. Reviewed-by: Krzysztof Kozlowski Signed-off-by: Luca Weiss ---

[PATCH v2 0/3] Handle reversed SBU orientation for FSA4480

2023-10-20 Thread Luca Weiss
Short reason: Without swapping the SBU lanes, on QCM6490 Fairphone 5 the DisplayPort-over-USB-C doesn't work. The Orient-Chip OCP96011 used in this phone is generally compatible with FSA4480 but has a difference how AUX+/- should be connected to SBU1/2. Long explanation, with my current

Re: [PATCH 2/2] usb: typec: add support for PTN36502 redriver

2023-10-20 Thread Luca Weiss
On Fri Oct 20, 2023 at 9:18 AM CEST, Neil Armstrong wrote: > On 20/10/2023 08:13, Luca Weiss wrote: > > On Tue Oct 17, 2023 at 10:34 AM CEST, Heikki Krogerus wrote: > >> Hi, > >> > >> On Fri, Oct 13, 2023 at 04:24:48PM +0200, Luca Weiss wrote: > >>> Add a driver for the NXP PTN36502 Type-C USB 3.1

[PATCH v2 2/3] usb: typec: fsa4480: Add support to swap SBU orientation

2023-10-20 Thread Luca Weiss
On some hardware designs the AUX+/- lanes are connected reversed to SBU1/2 compared to the expected design by FSA4480. Made more complicated, the otherwise compatible Orient-Chip OCP96011 expects the lanes to be connected reversed compared to FSA4480. * FSA4480 block diagram shows AUX+ connected

[PATCH v2 1/3] dt-bindings: usb: fsa4480: Add data-lanes property to endpoint

2023-10-20 Thread Luca Weiss
Allow specifying data-lanes to reverse the muxing orientation between AUX+/- and SBU1/2 where necessary by the hardware design. In the mux there's a switch that needs to be controlled from the OS, and it either connects AUX+ -> SBU1 and AUX- -> SBU2, or the reverse: AUX+ -> SBU2 and AUX- -> SBU1,

[PATCH v2 3/3] dt-bindings: usb: fsa4480: Add compatible for OCP96011

2023-10-20 Thread Luca Weiss
The Orient-Chip OCP96011 is generally compatible with the FSA4480, add a compatible for it with the fallback on fsa4480. However the AUX/SBU connections are expected to be swapped compared to FSA4480, so document this in the data-lanes description. Signed-off-by: Luca Weiss ---

[PATCH 1/2] tracing: mm: multigen-lru: fix mglru trace

2023-10-20 Thread Huan Yang
This patch add reclaim stat: nr_promote: nr_pages shrink before promote by folio_update_gen. And then, use correct nr_scanned which evict_folios passed into trace_mm_vmscan_lru_shrink_inactive. Mistake info like this: ``` kswapd0-89[000]64.887613: mm_vmscan_lru_shrink_inactive: nid=0

[PATCH 0/2] check MGLRU promoted without hold page lock

2023-10-20 Thread Huan Yang
This patchset add a new reclaim_stat named nr_promote to observe number folios which MGLRU promoted before shrink touch, and then show in mm_vmscan_lru_shrink_inactive. Also, fix nr_scanned in MGLRU trace into nr_taken. (patch1) Base this trace, here are many folio promoted before shrink touch,

[PATCH 2/2] mm: multi-gen LRU: move promoted folio out of lock

2023-10-20 Thread Huan Yang
With nr_prmote trace, show that here are many folio promoted before shrink check. I just test by below cmd, and grep nr_reclaimed=0: ``` trace-cmd record -e vmscan:mm_vmscan_lru_shrink_inactive\ stressapptest -M 8096 -s 120 -m 1 -W trace-cmd report | grep "nr_reclaim\=0" ``` Then find

[PATCH] module: main: Remove unnecessary ‘0’ values from err

2023-10-20 Thread ZhouJie
Remove redundant assignment .The variable 'err' was assigned a value before its usage, making the initial assignment unnecessary. This commit removes the redundant assignment, improving code clarity and efficiency. Signed-off-by: ZhouJie --- kernel/module/main.c | 2 +- 1 file changed, 1

Re: [PATCH v1] Ftrace: make sched_wakeup can focus on the target process

2023-10-20 Thread kernel test robot
mov%eax,%esi 12: a1 .byte 0xa1 13: e4 38 in $0x38,%al 15: 25 .byte 0x25 The kernel config and materials to reproduce are available at: https://download.01.org/0day-ci/archive/20231020/202310201530.46065346-oliver.s...@intel.c

Re: [PATCH 2/2] usb: typec: add support for PTN36502 redriver

2023-10-20 Thread Neil Armstrong
On 20/10/2023 08:13, Luca Weiss wrote: On Tue Oct 17, 2023 at 10:34 AM CEST, Heikki Krogerus wrote: Hi, On Fri, Oct 13, 2023 at 04:24:48PM +0200, Luca Weiss wrote: Add a driver for the NXP PTN36502 Type-C USB 3.1 Gen 1 and DisplayPort v1.2 combo redriver. Signed-off-by: Luca Weiss Looks

Re: [PATCH 2/2] usb: typec: add support for PTN36502 redriver

2023-10-20 Thread Luca Weiss
On Tue Oct 17, 2023 at 10:34 AM CEST, Heikki Krogerus wrote: > Hi, > > On Fri, Oct 13, 2023 at 04:24:48PM +0200, Luca Weiss wrote: > > Add a driver for the NXP PTN36502 Type-C USB 3.1 Gen 1 and DisplayPort > > v1.2 combo redriver. > > > > Signed-off-by: Luca Weiss > > Looks OK to me, but couple