Re: Re: Re: EEVDF/vhost regression (bisected to 86bfbb7ce4f6 sched/fair: Add lag based placement)

2023-11-28 Thread Tobias Huschle
On Tue, Nov 28, 2023 at 04:55:11PM +0800, Abel Wu wrote: > On 11/27/23 9:56 PM, Tobias Huschle Wrote: > > On Wed, Nov 22, 2023 at 11:00:16AM +0100, Peter Zijlstra wrote: > > > On Tue, Nov 21, 2023 at 02:17:21PM +0100, Tobias Huschle wrote: [...] > > - At depth 4, the cgroup shows the observed

[PATCH v4] libtracecmd: Use an rbtree for mapping of cache pages

2023-11-28 Thread Steven Rostedt
From: "Steven Rostedt (Google)" I was loading a very large trace.dat file into kernelshark when it just stopped near the end off the load and hung there for a very long time. I ran it under gdb and hit Ctrl^C when it hit the hang to see what it was doing and found that it was spinning in:

[PATCH AUTOSEL 6.6 35/40] eventfs: Do not allow NULL parent to eventfs_start_creating()

2023-11-28 Thread Sasha Levin
From: "Steven Rostedt (Google)" [ Upstream commit fc4561226feaad5fcdcb55646c348d77b8ee69c5 ] The eventfs directory is dynamically created via the meta data supplied by the existing trace events. All files and directories in eventfs has a parent. Do not allow NULL to be passed into

Re: [PATCH RFC v2 19/27] mm: mprotect: Introduce PAGE_FAULT_ON_ACCESS for mprotect(PROT_MTE)

2023-11-28 Thread David Hildenbrand
On 28.11.23 18:55, David Hildenbrand wrote: On 19.11.23 17:57, Alexandru Elisei wrote: To enable tagging on a memory range, userspace can use mprotect() with the PROT_MTE access flag. Pages already mapped in the VMA don't have the associated tag storage block reserved, so mark the PTEs as

Re: [PATCH RFC v2 19/27] mm: mprotect: Introduce PAGE_FAULT_ON_ACCESS for mprotect(PROT_MTE)

2023-11-28 Thread David Hildenbrand
On 19.11.23 17:57, Alexandru Elisei wrote: To enable tagging on a memory range, userspace can use mprotect() with the PROT_MTE access flag. Pages already mapped in the VMA don't have the associated tag storage block reserved, so mark the PTEs as PAGE_FAULT_ON_ACCESS to trigger a fault next time

Re: [PATCH RFC v2 04/27] mm: migrate/mempolicy: Add hook to modify migration target gfp

2023-11-28 Thread Alexandru Elisei
Hi, On Tue, Nov 28, 2023 at 08:49:57AM +0200, Mike Rapoport wrote: > On Mon, Nov 27, 2023 at 11:52:56AM +, Alexandru Elisei wrote: > > Hi Mike, > > > > I really appreciate you having a look! > > > > On Sat, Nov 25, 2023 at 12:03:22PM +0200, Mike Rapoport wrote: > > > On Sun, Nov 19, 2023 at

[PATCH] tracing: Allow creating instances with specified system events

2023-11-28 Thread Steven Rostedt
From: "Steven Rostedt (Google)" A trace instance may only need to enable specific events. As the eventfs directory of an instance currently creates all events which adds overhead, allow internal instances to be created with just the events in systems that they care about. This currently only

Re: [PATCH RFC v2 05/27] mm: page_alloc: Add an arch hook to allow prep_new_page() to fail

2023-11-28 Thread Alexandru Elisei
Hi, On Tue, Nov 28, 2023 at 05:57:31PM +0100, David Hildenbrand wrote: > On 27.11.23 13:09, Alexandru Elisei wrote: > > Hi, > > > > Thank you so much for your comments, there are genuinely useful. > > > > On Fri, Nov 24, 2023 at 08:35:47PM +0100, David Hildenbrand wrote: > > > On 19.11.23

Re: [PATCH RFC v2 18/27] arm64: mte: Reserve tag block for the zero page

2023-11-28 Thread David Hildenbrand
On 19.11.23 17:57, Alexandru Elisei wrote: On arm64, the zero page receives special treatment by having the tagged flag set on MTE initialization, not when the page is mapped in a process address space. Reserve the corresponding tag block when tag storage management is being activated. Out of

Re: [PATCH RFC v2 14/27] arm64: mte: Disable dynamic tag storage management if HW KASAN is enabled

2023-11-28 Thread David Hildenbrand
On 27.11.23 16:07, Alexandru Elisei wrote: Hi, On Fri, Nov 24, 2023 at 08:54:12PM +0100, David Hildenbrand wrote: On 19.11.23 17:57, Alexandru Elisei wrote: To be able to reserve the tag storage associated with a page requires that the tag storage page can be migrated. When HW KASAN is

Re: [PATCH RFC v2 12/27] arm64: mte: Add tag storage pages to the MIGRATE_CMA migratetype

2023-11-28 Thread David Hildenbrand
On 27.11.23 16:01, Alexandru Elisei wrote: Hi David, On Fri, Nov 24, 2023 at 08:40:55PM +0100, David Hildenbrand wrote: On 19.11.23 17:57, Alexandru Elisei wrote: Add the MTE tag storage pages to the MIGRATE_CMA migratetype, which allows the page allocator to manage them like regular pages.

Re: [RFC][PATCH] tracing: Allow creating instances with specified system events

2023-11-28 Thread Steven Rostedt
On Wed, 29 Nov 2023 00:17:38 +0900 Masami Hiramatsu (Google) wrote: > Hi Steve, > > On Mon, 27 Nov 2023 17:41:08 -0500 > Steven Rostedt wrote: > > > From: "Steven Rostedt (Google)" > > > > A trace instance may only need to enable specific events. As the eventfs > > directory of an instance

Re: [RFC][PATCH] tracing: Allow creating instances with specified system events

2023-11-28 Thread Google
Hi Steve, On Mon, 27 Nov 2023 17:41:08 -0500 Steven Rostedt wrote: > From: "Steven Rostedt (Google)" > > A trace instance may only need to enable specific events. As the eventfs > directory of an instance currently creates all events which adds overhead, > allow internal instances to be

Re: [PATCH 1/2] tracing: Simplify and fix "buffered event" synchronization

2023-11-28 Thread Petr Pavlu
On 11/27/23 18:41, Steven Rostedt wrote: > On Mon, 27 Nov 2023 16:12:47 +0100 > Petr Pavlu wrote: > >> The following warning appears when using buffered events: >> [ 203.556451] WARNING: CPU: 53 PID: 10220 at >> kernel/trace/ring_buffer.c:3912 ring_buffer_discard_commit+0x2eb/0x420 > > Hmm, I

Re: [RFC][PATCH] tracing: Allow creating instances with specified system events

2023-11-28 Thread Steven Rostedt
On Tue, 28 Nov 2023 09:20:29 -0500 Steven Rostedt wrote: > On Tue, 28 Nov 2023 14:14:29 +0100 > Dmytro Maluka wrote: > > > > This limitation will cause (unrelated) events created by modules that > > are insmoded after creating the instance to be also added to the > > instance. Why not filter

Re: [RFC][PATCH] tracing: Allow creating instances with specified system events

2023-11-28 Thread Steven Rostedt
On Tue, 28 Nov 2023 14:14:29 +0100 Dmytro Maluka wrote: > This limitation will cause (unrelated) events created by modules that > are insmoded after creating the instance to be also added to the > instance. Why not filter those as well? I did think of that. But that would be a separate patch.

Re: [RFC][PATCH] tracing: Allow creating instances with specified system events

2023-11-28 Thread Dmytro Maluka
On Mon, Nov 27, 2023 at 05:41:08PM -0500, Steven Rostedt wrote: > From: "Steven Rostedt (Google)" > > A trace instance may only need to enable specific events. As the eventfs > directory of an instance currently creates all events which adds overhead, > allow internal instances to be created

Re: [PATCH v3 28/33] fprobe: Rewrite fprobe on function-graph tracer

2023-11-28 Thread Google
On Tue, 28 Nov 2023 11:53:19 +0100 Jiri Olsa wrote: > On Mon, Nov 27, 2023 at 10:58:40PM +0900, Masami Hiramatsu (Google) wrote: > > From: Masami Hiramatsu (Google) > > > > Rewrite fprobe implementation on function-graph tracer. > > Major API changes are: > > - 'nr_maxactive' field is

Re: [PATCH] dt-bindings: correct white-spaces in examples

2023-11-28 Thread Ulf Hansson
On Fri, 24 Nov 2023 at 10:21, Krzysztof Kozlowski wrote: > > Use only one and exactly one space around '=' in DTS example. > > Signed-off-by: Krzysztof Kozlowski Acked-by: Ulf Hansson # For MMC Kind regards Uffe > > --- > > Merging idea: Rob's DT. > Should apply cleanly on Rob's for-next. >

Re: [PATCH v3 28/33] fprobe: Rewrite fprobe on function-graph tracer

2023-11-28 Thread Jiri Olsa
On Mon, Nov 27, 2023 at 10:58:40PM +0900, Masami Hiramatsu (Google) wrote: > From: Masami Hiramatsu (Google) > > Rewrite fprobe implementation on function-graph tracer. > Major API changes are: > - 'nr_maxactive' field is deprecated. > - This depends on CONFIG_DYNAMIC_FTRACE_WITH_ARGS or >

Re: Re: Re: EEVDF/vhost regression (bisected to 86bfbb7ce4f6 sched/fair: Add lag based placement)

2023-11-28 Thread Abel Wu
On 11/27/23 9:56 PM, Tobias Huschle Wrote: On Wed, Nov 22, 2023 at 11:00:16AM +0100, Peter Zijlstra wrote: On Tue, Nov 21, 2023 at 02:17:21PM +0100, Tobias Huschle wrote: The below should also work for internal entities, but last time I poked around with it I had some regressions elsewhere --

Re: [RFC][PATCH] tracing: Allow creating instances with specified system events

2023-11-28 Thread Daniel Wagner
On Mon, Nov 27, 2023 at 05:50:21PM -0500, Steven Rostedt wrote: > On Mon, 27 Nov 2023 17:41:08 -0500 > Steven Rostedt wrote: > > > From: "Steven Rostedt (Google)" > > > > A trace instance may only need to enable specific events. As the eventfs > > directory of an instance currently creates all

Re: [PATCH v2 0/5] MODVERSIONS + RUST Redux

2023-11-28 Thread Greg KH
On Tue, Nov 28, 2023 at 08:05:26AM +, Greg KH wrote: > On Mon, Nov 27, 2023 at 11:27:07AM -0800, Matthew Maurer wrote: > > > > > > > > > > > With regards to future directions that likely won't work for > > > > > > loosening it: > > > > > > Unfortunately, the .rmeta format itself is not

Re: [PATCH v2 0/5] MODVERSIONS + RUST Redux

2023-11-28 Thread Greg KH
On Mon, Nov 27, 2023 at 11:27:07AM -0800, Matthew Maurer wrote: > > > > > > > > > With regards to future directions that likely won't work for > > > > > loosening it: > > > > > Unfortunately, the .rmeta format itself is not stable, so I wouldn't > > > > > want to > > > > > teach genksyms to open